From 9283e9bd115cac8be3cf4241c8873fc10aeebb2d Mon Sep 17 00:00:00 2001 From: Pauli Date: Mon, 29 Jun 2020 08:29:10 +1000 Subject: [PATCH] cmp: remove NULL check. Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting. Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/12309) --- apps/cmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/cmp.c b/apps/cmp.c index 4a6074ba58..87daa37dfa 100644 --- a/apps/cmp.c +++ b/apps/cmp.c @@ -3186,8 +3186,7 @@ int cmp_main(int argc, char **argv) X509_STORE_free(OSSL_CMP_CTX_get_certConf_cb_arg(cmp_ctx)); OSSL_CMP_CTX_free(cmp_ctx); X509_VERIFY_PARAM_free(vpm); - if (engine != NULL) /* workaround for Coverity false positive */ - release_engine(engine); + release_engine(engine); NCONF_free(conf); /* must not do as long as opt_... variables are used */ OSSL_CMP_log_close(); -- 2.39.2