From fc270c357a3301fec8cc161199242bb934203cf6 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 28 Dec 2013 15:32:27 -0700 Subject: [PATCH] replace XCALLOC with XCNEWVEC or XCNEW This removes XCALLOC and replaces it either with XCNEWVEC, or, if the number of elements being requested was 1, with XCNEW. 2014-01-13 Tom Tromey * defs.h (XCALLOC): Remove. * bcache.c (bcache_xmalloc): Use XCNEW, not XCALLOC. (print_bcache_statistics): Use XCNEWVEC, not XCALLOC. * dwarf2loc.c (allocate_piece_closure): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_symfile_segments): Likewise. * gdbtypes.c (copy_type_recursive): Likewise. * i386-tdep.c (i386_gdbarch_init): Use XCNEW, not XCALLOC. * jit.c (jit_frame_sniffer): Use XCNEWVEC, not XCALLOC. * minsyms.c (prim_record_minimal_symbol_full): Use XCNEW, not XCALLOC. * mt-tdep.c (mt_gdbarch_init): Likewise. * opencl-lang.c (allocate_lval_closure): Use XCNEWVEC, not XCALLOC. * psymtab.c (psymbol_compare): Use XCNEW, not XCALLOC. * regcache.c (regcache_xmalloc_1): Use XCNEWVEC, not XCALLOC. * registry.c (registry_alloc_data): Likewise. * rs6000-tdep.c (rs6000_gdbarch_init): Use XCNEW, not XCALLOC. * s390-linux-tdep.c (s390_gdbarch_init): Likewise. * serial.c (serial_fdopen_ops): Likewise. * solib-aix.c (solib_aix_get_section_offsets): Use XCNEWVEC, not XCALLOC. * spu-tdep.c (spu_gdbarch_init): Use XCNEW, not XCALLOC. * symfile.c (default_symfile_segments): Use XCNEW and XCNEWVEC, not XCALLOC. --- gdb/ChangeLog | 28 ++++++++++++++++++++++++++++ gdb/bcache.c | 6 +++--- gdb/defs.h | 5 ----- gdb/dwarf2loc.c | 2 +- gdb/elfread.c | 6 +++--- gdb/gdbtypes.c | 2 +- gdb/i386-tdep.c | 2 +- gdb/jit.c | 4 ++-- gdb/minsyms.c | 2 +- gdb/mt-tdep.c | 2 +- gdb/opencl-lang.c | 2 +- gdb/psymtab.c | 2 +- gdb/regcache.c | 8 ++++---- gdb/registry.c | 2 +- gdb/rs6000-tdep.c | 2 +- gdb/s390-linux-tdep.c | 2 +- gdb/serial.c | 2 +- gdb/solib-aix.c | 2 +- gdb/spu-tdep.c | 2 +- gdb/symfile.c | 6 +++--- 20 files changed, 56 insertions(+), 33 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a55e19db2dd..2247c790c7d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,31 @@ +2014-01-13 Tom Tromey + + * defs.h (XCALLOC): Remove. + * bcache.c (bcache_xmalloc): Use XCNEW, not XCALLOC. + (print_bcache_statistics): Use XCNEWVEC, not XCALLOC. + * dwarf2loc.c (allocate_piece_closure): Likewise. + * elfread.c (elf_symfile_segments): Likewise. + (elf_symfile_segments): Likewise. + * gdbtypes.c (copy_type_recursive): Likewise. + * i386-tdep.c (i386_gdbarch_init): Use XCNEW, not XCALLOC. + * jit.c (jit_frame_sniffer): Use XCNEWVEC, not XCALLOC. + * minsyms.c (prim_record_minimal_symbol_full): Use XCNEW, not + XCALLOC. + * mt-tdep.c (mt_gdbarch_init): Likewise. + * opencl-lang.c (allocate_lval_closure): Use XCNEWVEC, not + XCALLOC. + * psymtab.c (psymbol_compare): Use XCNEW, not XCALLOC. + * regcache.c (regcache_xmalloc_1): Use XCNEWVEC, not XCALLOC. + * registry.c (registry_alloc_data): Likewise. + * rs6000-tdep.c (rs6000_gdbarch_init): Use XCNEW, not XCALLOC. + * s390-linux-tdep.c (s390_gdbarch_init): Likewise. + * serial.c (serial_fdopen_ops): Likewise. + * solib-aix.c (solib_aix_get_section_offsets): Use XCNEWVEC, not + XCALLOC. + * spu-tdep.c (spu_gdbarch_init): Use XCNEW, not XCALLOC. + * symfile.c (default_symfile_segments): Use XCNEW and XCNEWVEC, + not XCALLOC. + 2014-01-13 Tom Tromey * defs.h (XMALLOC): Remove. diff --git a/gdb/bcache.c b/gdb/bcache.c index 3d1280a61fa..99e9184ef6d 100644 --- a/gdb/bcache.c +++ b/gdb/bcache.c @@ -313,7 +313,7 @@ bcache_xmalloc (unsigned long (*hash_function)(const void *, int length), int length)) { /* Allocate the bcache pre-zeroed. */ - struct bcache *b = XCALLOC (1, struct bcache); + struct bcache *b = XCNEW (struct bcache); if (hash_function) b->hash_function = hash_function; @@ -372,8 +372,8 @@ print_bcache_statistics (struct bcache *c, char *type) lengths, and measure chain lengths. */ { unsigned int b; - int *chain_length = XCALLOC (c->num_buckets + 1, int); - int *entry_size = XCALLOC (c->unique_count + 1, int); + int *chain_length = XCNEWVEC (int, c->num_buckets + 1); + int *entry_size = XCNEWVEC (int, c->unique_count + 1); int stringi = 0; occupied_buckets = 0; diff --git a/gdb/defs.h b/gdb/defs.h index a4770efb9b2..a7ce88a7831 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -553,11 +553,6 @@ enum val_prettyformat extern int longest_to_int (LONGEST); -/* Utility macros to allocate typed memory. Avoids errors like: - struct foo *foo = xmalloc (sizeof struct bar); and memset (foo, - sizeof (struct foo), 0). */ -#define XCALLOC(NMEMB, TYPE) ((TYPE*) xcalloc ((NMEMB), sizeof (TYPE))) - #include "common-utils.h" /* List of known OS ABIs. If you change this, make sure to update the diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index 6185a6b4e25..99a18a95ed6 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -1421,7 +1421,7 @@ allocate_piece_closure (struct dwarf2_per_cu_data *per_cu, c->per_cu = per_cu; c->n_pieces = n_pieces; c->addr_size = addr_size; - c->pieces = XCALLOC (n_pieces, struct dwarf_expr_piece); + c->pieces = XCNEWVEC (struct dwarf_expr_piece, n_pieces); memcpy (c->pieces, pieces, n_pieces * sizeof (struct dwarf_expr_piece)); for (i = 0; i < n_pieces; ++i) diff --git a/gdb/elfread.c b/gdb/elfread.c index 4f27aff19e1..d43a1f74ffd 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -107,8 +107,8 @@ elf_symfile_segments (bfd *abfd) data = XCNEW (struct symfile_segment_data); data->num_segments = num_segments; - data->segment_bases = XCALLOC (num_segments, CORE_ADDR); - data->segment_sizes = XCALLOC (num_segments, CORE_ADDR); + data->segment_bases = XCNEWVEC (CORE_ADDR, num_segments); + data->segment_sizes = XCNEWVEC (CORE_ADDR, num_segments); for (i = 0; i < num_segments; i++) { @@ -117,7 +117,7 @@ elf_symfile_segments (bfd *abfd) } num_sections = bfd_count_sections (abfd); - data->segment_info = XCALLOC (num_sections, int); + data->segment_info = XCNEWVEC (int, num_sections); for (i = 0, sect = abfd->sections; sect != NULL; i++, sect = sect->next) { diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index e02b66c7aac..042c17d4c6b 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -3700,7 +3700,7 @@ copy_type_recursive (struct objfile *objfile, int i, nfields; nfields = TYPE_NFIELDS (type); - TYPE_FIELDS (new_type) = XCALLOC (nfields, struct field); + TYPE_FIELDS (new_type) = XCNEWVEC (struct field, nfields); for (i = 0; i < nfields; i++) { TYPE_FIELD_ARTIFICIAL (new_type, i) = diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 9d1d9e0ad56..4a5f652b168 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -7819,7 +7819,7 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) return arches->gdbarch; /* Allocate space for the new architecture. */ - tdep = XCALLOC (1, struct gdbarch_tdep); + tdep = XCNEW (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); /* General-purpose registers. */ diff --git a/gdb/jit.c b/gdb/jit.c index ebbee5418e0..546b3b62eaa 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -1184,8 +1184,8 @@ jit_frame_sniffer (const struct frame_unwind *self, *cache = XCNEW (struct jit_unwind_private); priv_data = *cache; priv_data->registers = - XCALLOC (gdbarch_num_regs (get_frame_arch (this_frame)), - struct gdb_reg_value *); + XCNEWVEC (struct gdb_reg_value *, + gdbarch_num_regs (get_frame_arch (this_frame))); priv_data->this_frame = this_frame; callbacks.priv_data = priv_data; diff --git a/gdb/minsyms.c b/gdb/minsyms.c index ee9575c8fa5..c7ae981605c 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -935,7 +935,7 @@ prim_record_minimal_symbol_full (const char *name, int name_len, int copy_name, if (msym_bunch_index == BUNCH_SIZE) { - new = XCALLOC (1, struct msym_bunch); + new = XCNEW (struct msym_bunch); msym_bunch_index = 0; new->next = msym_bunch; msym_bunch = new; diff --git a/gdb/mt-tdep.c b/gdb/mt-tdep.c index 2072528c899..e3786e815ea 100644 --- a/gdb/mt-tdep.c +++ b/gdb/mt-tdep.c @@ -1149,7 +1149,7 @@ mt_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* None found, create a new architecture from the information provided. */ - tdep = XCALLOC (1, struct gdbarch_tdep); + tdep = XCNEW (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); set_gdbarch_float_format (gdbarch, floatformats_ieee_single); diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c index 4bcaf7ecaec..2dd76fac36e 100644 --- a/gdb/opencl-lang.c +++ b/gdb/opencl-lang.c @@ -160,7 +160,7 @@ allocate_lval_closure (int *indices, int n, struct value *val) c->refc = 1; c->n = n; - c->indices = XCALLOC (n, int); + c->indices = XCNEWVEC (int, n); memcpy (c->indices, indices, n * sizeof (int)); value_incref (val); /* Increment the reference counter of the value. */ c->val = val; diff --git a/gdb/psymtab.c b/gdb/psymtab.c index 34e833c04c1..56fe409ae68 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1530,7 +1530,7 @@ psymbol_compare (const void *addr1, const void *addr2, int length) struct psymbol_bcache * psymbol_bcache_init (void) { - struct psymbol_bcache *bcache = XCALLOC (1, struct psymbol_bcache); + struct psymbol_bcache *bcache = XCNEW (struct psymbol_bcache); bcache->bcache = bcache_xmalloc (psymbol_hash, psymbol_compare); return bcache; } diff --git a/gdb/regcache.c b/gdb/regcache.c index 1ddf9b025ae..8b588c60050 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -223,16 +223,16 @@ regcache_xmalloc_1 (struct gdbarch *gdbarch, struct address_space *aspace, if (readonly_p) { regcache->registers - = XCALLOC (descr->sizeof_cooked_registers, gdb_byte); + = XCNEWVEC (gdb_byte, descr->sizeof_cooked_registers); regcache->register_status - = XCALLOC (descr->sizeof_cooked_register_status, signed char); + = XCNEWVEC (signed char, descr->sizeof_cooked_register_status); } else { regcache->registers - = XCALLOC (descr->sizeof_raw_registers, gdb_byte); + = XCNEWVEC (gdb_byte, descr->sizeof_raw_registers); regcache->register_status - = XCALLOC (descr->sizeof_raw_register_status, signed char); + = XCNEWVEC (signed char, descr->sizeof_raw_register_status); } regcache->aspace = aspace; regcache->ptid = minus_one_ptid; diff --git a/gdb/registry.c b/gdb/registry.c index ed614b9ba64..2fd60335e88 100644 --- a/gdb/registry.c +++ b/gdb/registry.c @@ -51,7 +51,7 @@ registry_alloc_data (struct registry_data_registry *registry, { gdb_assert (fields->data == NULL); fields->num_data = registry->num_registrations; - fields->data = XCALLOC (fields->num_data, void *); + fields->data = XCNEWVEC (void *, fields->num_data); } void diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 0008f843db8..d7416e5a2dc 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3954,7 +3954,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) - "set arch" trust blindly - GDB startup useless but harmless */ - tdep = XCALLOC (1, struct gdbarch_tdep); + tdep = XCNEW (struct gdbarch_tdep); tdep->wordsize = wordsize; tdep->soft_float = soft_float; tdep->vector_abi = vector_abi; diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c index 69befcfa4c5..b75c86a5789 100644 --- a/gdb/s390-linux-tdep.c +++ b/gdb/s390-linux-tdep.c @@ -3196,7 +3196,7 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) } /* Otherwise create a new gdbarch for the specified machine type. */ - tdep = XCALLOC (1, struct gdbarch_tdep); + tdep = XCNEW (struct gdbarch_tdep); tdep->abi = tdep_abi; gdbarch = gdbarch_alloc (&info, tdep); diff --git a/gdb/serial.c b/gdb/serial.c index c87875fc96b..2b1ecedae38 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -263,7 +263,7 @@ serial_fdopen_ops (const int fd, const struct serial_ops *ops) if (!ops) return NULL; - scb = XCALLOC (1, struct serial); + scb = XCNEW (struct serial); scb->ops = ops; diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c index 8f335f6a76c..78d2753d467 100644 --- a/gdb/solib-aix.c +++ b/gdb/solib-aix.c @@ -470,7 +470,7 @@ solib_aix_get_section_offsets (struct objfile *objfile, bfd *abfd = objfile->obfd; int i; - offsets = XCALLOC (objfile->num_sections, struct section_offsets); + offsets = XCNEWVEC (struct section_offsets, objfile->num_sections); /* .text */ diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index 4d745d9ad74..f096a2ebbc3 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -2658,7 +2658,7 @@ spu_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) } /* None found, so create a new architecture. */ - tdep = XCALLOC (1, struct gdbarch_tdep); + tdep = XCNEW (struct gdbarch_tdep); tdep->id = id; gdbarch = gdbarch_alloc (&info, tdep); diff --git a/gdb/symfile.c b/gdb/symfile.c index 02471a4f9b2..a8bc3d8a5d3 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -801,11 +801,11 @@ default_symfile_segments (bfd *abfd) data = XCNEW (struct symfile_segment_data); data->num_segments = 1; - data->segment_bases = XCALLOC (1, CORE_ADDR); - data->segment_sizes = XCALLOC (1, CORE_ADDR); + data->segment_bases = XCNEW (CORE_ADDR); + data->segment_sizes = XCNEW (CORE_ADDR); num_sections = bfd_count_sections (abfd); - data->segment_info = XCALLOC (num_sections, int); + data->segment_info = XCNEWVEC (int, num_sections); for (i = 0, sect = abfd->sections; sect != NULL; i++, sect = sect->next) { -- 2.39.2