From ca43e66033ca0d72bb93837c9b1ab482977e06e6 Mon Sep 17 00:00:00 2001 From: Tankut Baris Aktemur Date: Fri, 21 May 2021 17:20:53 +0200 Subject: [PATCH] testsuite/gdb.dwarf2: avoid dead code in dw2-inline-with-lexical-scope.c The test in gdb.dwarf2/dw2-inline-with-lexical-scope.c fails with icc. The reason is, icc did not emit code for a dead statement, which in turn caused some labels to be collapsed. Fix this by replacing the dead code with assignment to a global value. The statement itself does not change the test scenario. Also fix a whitespacing problem around an assignment operator. gdb/testsuite/ChangeLog: 2021-05-21 Tankut Baris Aktemur * gdb.dwarf2/dw2-inline-with-lexical-scope.c (func): Replace a dead code with an assignment to a global var. Fix a whitespacing problem around an assignment operator. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 705afbaf40d..4a3f53ba33a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2021-05-21 Tankut Baris Aktemur + + * gdb.dwarf2/dw2-inline-with-lexical-scope.c (func): Replace + a dead code with an assignment to a global var. Fix a + whitespacing problem around an assignment operator. + 2021-05-19 Will Schmidt * gdb.arch/powerpc64-prologue.c: New test to exercise prologues diff --git a/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c index ef9b71af4e0..c5f42806a22 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c +++ b/gdb/testsuite/gdb.dwarf2/dw2-inline-with-lexical-scope.c @@ -30,14 +30,14 @@ static void func () { /* func prologue */ global_num = 42; - int num= 42; + int num = 42; if (num > 2) { asm ("scope_label1: .globl scope_label1"); global_value = num; int value = num; asm ("breakpoint_label: .globl breakpoint_label"); - value += 10; + global_value += value; asm ("scope_label2: .globl scope_label2"); } } /* func end */ -- 2.39.2