From f8dcc90b6030b641fa7b0b33e4203498bbb0f0e0 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Tue, 4 Feb 2020 17:36:17 +0100 Subject: [PATCH] [gdb/testsuite] Add note to 'Race detection' entry in README Add note to 'Race detection' entry in README about the possibility that check-read1 makes failing tests pass. gdb/testsuite/ChangeLog: 2020-02-04 Tom de Vries * README (Race detection): Add note. Change-Id: I12ef2f0ec35abc5a0221585bf30e5f4f0616aa7c --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/README | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8fcf67b13e9..cd496e7837c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-02-04 Tom de Vries + + * README (Race detection): Add note. + 2020-02-04 Tom de Vries * lib/gdb.exp (inferior_exited_re): Use "\[^\n\r\]*" instead of ".*". diff --git a/gdb/testsuite/README b/gdb/testsuite/README index 4795df1f759..3e42526e623 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -352,6 +352,13 @@ Examples: make -j10 check-read1 TESTS="*/paginate-*.exp" make -j10 check READ1="1" +Note: While the intention is to detect races and make otherwise passing tests +fail, it can also have the effect of making otherwise failing tests pass. +This happens f.i. if the test is trying to match a gdb prompt using an end of +input marker "${gdb_prompt} $" and there is output after the gdb prompt. This +may either pass or fail in normal operation, but using check-read1 will ensure +that it passes. + Testsuite Configuration *********************** -- 2.39.2