From 000619344ddb01aa2e9aa746583f7c5a52ce56fe Mon Sep 17 00:00:00 2001 From: Enrico Scholz Date: Mon, 18 Mar 2024 12:14:21 +0100 Subject: [PATCH] lib/copydir:copy_entry(): use temporary stat buffer There are no guarantees that fstatat() does not clobber the stat buffer on errors. Use a temporary buffer so that the following code sees correct attributes of the source entry. Issue #973 Signed-off-by: Enrico Scholz --- lib/copydir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/copydir.c b/lib/copydir.c index 3a22738fc..926033afc 100644 --- a/lib/copydir.c +++ b/lib/copydir.c @@ -400,6 +400,7 @@ static int copy_entry (const struct path_info *src, const struct path_info *dst, { int err = 0; struct stat sb; + struct stat tmp_sb; struct link_name *lp; struct timespec mt[2]; @@ -423,7 +424,7 @@ static int copy_entry (const struct path_info *src, const struct path_info *dst, * If the destination already exists do nothing. * This is after the copy_dir above to still iterate into subdirectories. */ - if (fstatat(dst->dirfd, dst->name, &sb, AT_SYMLINK_NOFOLLOW) != -1) { + if (fstatat(dst->dirfd, dst->name, &tmp_sb, AT_SYMLINK_NOFOLLOW) != -1) { return err; } -- 2.47.3