From 00e77ef76c5cf0e400db38127b01d20a8ba759e4 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Mon, 12 Jul 2021 11:13:33 +0300 Subject: [PATCH] Remove dead assignment to local variable. This should have been removed in commit 7e30c186da, which split the loop into two. Only the first loop uses the 'from' variable; updating it in the second loop is bogus. It was never read after the first loop, so this was harmless and surely optimized away by the compiler, but let's be tidy. Backpatch to all supported versions. Author: Ranier Vilela Discussion: https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com --- src/backend/access/nbtree/nbtxlog.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c index c536e224321..fc277b1ee4f 100644 --- a/src/backend/access/nbtree/nbtxlog.c +++ b/src/backend/access/nbtree/nbtxlog.c @@ -67,7 +67,6 @@ _bt_restore_page(Page page, char *from, int len) if (PageAddItem(page, items[i], itemsizes[i], nitems - i, false, false) == InvalidOffsetNumber) elog(PANIC, "_bt_restore_page: cannot add item to page"); - from += itemsz; } } -- 2.39.5