From 044229c864a49b38c231608f86f1abfef1d1afc2 Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date: Sat, 28 Sep 2024 18:01:22 +0200 Subject: [PATCH] test(crdb): fix or skip tests that now run because libpq 17 is available --- tests/fix_crdb.py | 1 + tests/pq/test_async.py | 2 +- tests/pq/test_exec.py | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/fix_crdb.py b/tests/fix_crdb.py index 32ec457bd..42a6e4acc 100644 --- a/tests/fix_crdb.py +++ b/tests/fix_crdb.py @@ -95,6 +95,7 @@ _crdb_reasons = { "cancel": 41335, "cast adds tz": 51692, "cidr": 18846, + "close portal": None, "composite": 27792, "copy array": 82792, "copy canceled": 81559, diff --git a/tests/pq/test_async.py b/tests/pq/test_async.py index e529eb743..d2a46084b 100644 --- a/tests/pq/test_async.py +++ b/tests/pq/test_async.py @@ -232,8 +232,8 @@ def test_send_describe_portal(pgconn): pgconn.send_describe_portal(b"cur") -@pytest.mark.crdb_skip("server-side cursor") @pytest.mark.libpq(">= 17") +@pytest.mark.crdb_skip("close portal") def test_send_close_portal(pgconn): res = pgconn.exec_( b""" diff --git a/tests/pq/test_exec.py b/tests/pq/test_exec.py index 2ba18f3a8..3a7372875 100644 --- a/tests/pq/test_exec.py +++ b/tests/pq/test_exec.py @@ -145,7 +145,7 @@ def test_close_prepared_no_close(pgconn): pgconn.close_prepared(b"cur") -@pytest.mark.crdb_skip("server-side cursor") +@pytest.mark.crdb_skip("close portal") def test_describe_portal(pgconn): res = pgconn.exec_( b""" @@ -165,7 +165,7 @@ def test_describe_portal(pgconn): pgconn.describe_portal(b"cur") -@pytest.mark.crdb_skip("server-side cursor") +@pytest.mark.crdb_skip("close portal") @pytest.mark.libpq(">= 17") def test_close_portal(pgconn): res = pgconn.exec_( -- 2.47.3