From 06f9c307dd7387576fc79fedaedb557725c847ea Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Wed, 20 Jun 2012 18:45:19 +0200 Subject: [PATCH] snmp: remove extra '\n' at the end of SNMP log message Putting `\0` is useless. The code was done to remove an extra `\n`. --- src/agent.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/agent.c b/src/agent.c index c76af5a3..ed325f57 100644 --- a/src/agent.c +++ b/src/agent.c @@ -1673,7 +1673,8 @@ agent_log_callback(int major, int minor, struct snmp_log_message *slm = (struct snmp_log_message *)serverarg; char *msg = strdup(slm->msg); (void)major; (void)minor; (void)clientarg; - if (msg) msg[strlen(msg)-1] = '\0'; + + if (msg && msg[strlen(msg)-1] == '\n') msg[strlen(msg)-1] = '\0'; switch (slm->priority) { case LOG_EMERG: log_warnx("snmp[emerg]: %s", msg?msg:slm->msg); break; case LOG_ALERT: log_warnx("snmp[alert]: %s", msg?msg:slm->msg); break; -- 2.39.5