From 075641fd001bf2b59ac452fb645aecb4252bb860 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Sun, 28 Oct 2018 12:22:32 -0400 Subject: [PATCH] Fix perl searchpath for modern perl for MSVC tools Modern versions of perl no longer include the current directory in the perl searchpath, as it's insecure. Instead of adding the current directory, we get around the problem by adding the directory where the script lives. Problem noted by Victor Wagner. Solution adapted from buildfarm client code. Backpatch to all live versions. --- src/tools/msvc/install.pl | 4 ++++ src/tools/msvc/mkvcbuild.pl | 4 ++++ src/tools/msvc/vcregress.pl | 3 +++ 3 files changed, 11 insertions(+) diff --git a/src/tools/msvc/install.pl b/src/tools/msvc/install.pl index 63d39039907..9bda4bb3047 100755 --- a/src/tools/msvc/install.pl +++ b/src/tools/msvc/install.pl @@ -6,6 +6,10 @@ use strict; use warnings; +use File::Basename; +use File::Spec; +BEGIN { use lib File::Spec->rel2abs(dirname(__FILE__)); } + use Install qw(Install); # buildenv.pl is for specifying the build environment settings diff --git a/src/tools/msvc/mkvcbuild.pl b/src/tools/msvc/mkvcbuild.pl index 6f1c42e5044..748b0eb4156 100644 --- a/src/tools/msvc/mkvcbuild.pl +++ b/src/tools/msvc/mkvcbuild.pl @@ -7,6 +7,10 @@ use strict; use warnings; +use File::Basename; +use File::Spec; +BEGIN { use lib File::Spec->rel2abs(dirname(__FILE__)); } + use Mkvcbuild; chdir('..\..\..') if (-d '..\msvc' && -d '..\..\..\src'); diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl index 46da0bbd3e9..ed2ccdcff7d 100644 --- a/src/tools/msvc/vcregress.pl +++ b/src/tools/msvc/vcregress.pl @@ -7,7 +7,10 @@ use strict; our $config; use Cwd; +use File::Basename; use File::Copy; +use File::Spec; +BEGIN { use lib File::Spec->rel2abs(dirname(__FILE__)); } use Install qw(Install); -- 2.39.5