From 0769cf8b5803b4da0f512e9d203468afb49a24c3 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Sun, 11 Jul 2021 10:44:13 -0400 Subject: [PATCH] Fixes for 5.10 Signed-off-by: Sasha Levin --- ...nchronous-external-aborts-in-user-mo.patch | 160 +++++ queue-5.10/acpi-bgrt-fix-cfi-violation.patch | 125 ++++ ...-kobject_put-in-acpi_init-error-path.patch | 36 ++ ...make-more-asus-laptops-use-ecdt-_gpe.patch | 54 ++ ...trust-dsdt-gpe-for-certain-hp-laptop.patch | 84 +++ ...fan-device-ids-into-separate-header-.patch | 102 ++++ ...dle-fix-up-c-state-latency-if-not-or.patch | 113 ++++ ...ces-add-checks-for-acpi-irq-override.patch | 82 +++ ...-buffer-overrun-problem-with-descrip.patch | 73 +++ ...custom-dsdt-file-as-makefile-prerequ.patch | 43 ++ ...cpi-use-device_attr_-rw-ro-wo-macros.patch | 456 ++++++++++++++ ...ative-backlight-for-ga401-ga502-ga50.patch | 57 ++ ...y-leak-caused-by-_cid-repair-functio.patch | 55 ++ ...a-reference-to-ucounts-for-each-cred.patch | 341 +++++++++++ ...b-fix-amdtp_domain_start-when-no-amd.patch | 53 ++ ...m64-consistently-use-reserved_pg_dir.patch | 209 +++++++ ...l-armada-37xx-fix-reg-for-standard-v.patch | 41 ++ ...r0-values-stored-in-struct-thread_in.patch | 70 +++ ...-perf-convert-snprintf-to-sysfs_emit.patch | 37 ++ ...ix-usage-of-capture-and-playback-at-.patch | 100 +++ ...rect-definition-of-cs42l42_adc_pdn_m.patch | 37 ++ ...ix-error-handler-with-pm_runtime_ena.patch | 73 +++ ...ix-unexpected-interrupt-after-suspen.patch | 49 ++ ...ix-missing-clk_disable_unprepare-on-.patch | 64 ++ ...dw-add-quirk-support-for-brya-and-bt.patch | 56 ++ ...dw-add-sof_rt715_dai_id_fix-for-alde.patch | 37 ++ ...dw-use-mach-data-for-adl-rvp-dmic-co.patch | 40 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 106 ++++ ...k-btcvsd-fix-an-error-handling-path-.patch | 92 +++ ...missing-clk_disable_unprepare-on-err.patch | 80 +++ ...nd-tidyup-loop-on-rsnd_adg_clk_query.patch | 49 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 48 ++ .../asoc-rt5682-disable-irq-on-shutdown.patch | 45 ++ ...getting-the-wrong-device-id-when-the.patch | 70 +++ ...set-regcache_cache_only-false-before.patch | 54 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 48 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 48 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 48 ++ ...sdw-use-first_hw_init-flag-on-resume.patch | 48 ++ ...ng-error-return-code-in-ath10k_pci_p.patch | 64 ++ ...n-error-code-in-ath10k_add_interface.patch | 43 ++ ...h-err_unsupported-when-chip-id-is-no.patch | 37 ++ ...ror-handling-path-in-ath11k_core_fet.patch | 40 ++ ...on-template-after-vdev_start-restart.patch | 63 ++ ...a_bl-put-fwnode-in-error-case-during.patch | 43 ++ ...le-request-in-tags-rq-before-freeing.patch | 162 +++++ ...efcount-before-calling-fn-in-blk_mq_.patch | 180 ++++++ ...tx-dispatch_busy-in-case-of-real-sch.patch | 44 ++ ...e-a-new-disable-state-to-prevent-fal.patch | 66 ++ ...ke-sure-throttle-is-enabled-properly.patch | 45 ++ ...uble-io-accounting-for-flush-request.patch | 52 ++ .../block-fix-discard-request-merge.patch | 58 ++ ...etween-adding-removing-rq-qos-and-no.patch | 113 ++++ ...e-block_dump-feature-in-mark_inode_d.patch | 84 +++ ...ndling-of-hci_le_advertising_set_ter.patch | 56 ++ ...t-sending-set-extended-scan-response.patch | 60 ++ ...-fix-set-extended-scan-response-data.patch | 176 ++++++ ...ix-slab-out-of-bounds-in-tlv_data_is.patch | 65 ++ ...e-gso_size-during-bpf_skb_change_pro.patch | 145 +++++ ...elf-endian-handling-in-resolv_btfids.patch | 58 ++ ...-deref-with-mixed-tail-calls-and-sub.patch | 129 ++++ ...y-the-log-level-for-the-kmsg-message.patch | 45 ++ ...ly-report-average-rssi-in-station-in.patch | 87 +++ ...-double-free-in-brcmf_sdio_bus_reset.patch | 38 ++ ...tting-of-station-info-chains-bitmask.patch | 61 ++ ...1_if-fix-a-resource-leak-in-an-error.patch | 55 ++ ...saction-if-we-fail-to-update-the-del.patch | 43 ++ ...tree-recovering-status-if-starting-t.patch | 44 ++ ...ild-on-platforms-having-page-size-25.patch | 54 ++ ...r-page-extent-mapped-if-we-re-not-in.patch | 83 +++ ...handling-in-__btrfs_update_delayed_i.patch | 73 +++ ...lemap_range_has_page-call-in-btrfs_p.patch | 104 ++++ ...format-string-for-some-discard-stats.patch | 46 ++ ...sk_setsockopt-prevent-allocation-of-.patch | 42 ++ ...r-out-if-num_bytes_read-is-greater-t.patch | 41 ++ ...-spinlock-around-update-to-ses-statu.patch | 63 ++ .../cifs-improve-fallocate-emulation.patch | 191 ++++++ ...ahpprediv-h-ahb-clock-chain-on-owl-s.patch | 91 +++ ...bisp_factor_table-based-clocks-on-ow.patch | 143 +++++ ...sd-clocks-factor-table-on-owl-s500-s.patch | 49 ++ ...-uart-clock-dividers-on-owl-s500-soc.patch | 75 +++ ...mx8mq-remove-sys-pll-1-2-clock-gates.patch | 127 ++++ ...k-meson-g12a-fix-gp0-and-hifi-ranges.patch | 45 ++ ...ha-pll-fix-cal_l-write-in-alpha_pll_.patch | 37 ++ ...-divide-errors-due-to-bogus-register.patch | 70 +++ ...-for-input-clock-presence-and-pll-lo.patch | 82 +++ ...k-si5341-update-initialization-magic.patch | 48 ++ ...341-wait-for-device_ready-on-startup.patch | 86 +++ ...-300mhz-for-video-decoder-by-default.patch | 38 ++ ...output-disabling-when-enabling-a-fod.patch | 112 ++++ ...k-per-cpu-clock-synchronization-when.patch | 142 +++++ ...ers-timer-ti-dm-save-and-restore-tim.patch | 67 ++ ...y-clock-read-if-long-delays-detected.patch | 144 +++++ ...memleak-in-configfs_release_bin_file.patch | 47 ++ ...ore-fix-use-of-uninitialized-pointer.patch | 41 ++ ...freq_online-call-driver-offline-on-e.patch | 62 ++ ...-resource-leak-in-an-error-handling-.patch | 51 ++ ...-sec-fixup-3des-minimum-key-size-dec.patch | 39 ++ ...ixp4xx-dma_unmap-the-correct-address.patch | 38 ++ ...ypto-ixp4xx-update-iv-after-requests.patch | 84 +++ ...x-unchecked-variable-in-nitrox_regis.patch | 38 ++ ...o-nx-add-missing-module_device_table.patch | 36 ++ ...x-rcu-warning-in-nx842_of_upd_status.patch | 61 ++ ...-fix-pm-reference-leak-in-omap-sham-.patch | 48 ++ ...ck-return-code-of-qat_hal_rd_rel_reg.patch | 47 ++ ...qat-remove-unused-macro-in-fw-loader.patch | 42 ++ ...her-fix-incorrect-sg-count-for-dma-t.patch | 70 +++ ...-leaks-on-failure-paths-with-sa_dma_.patch | 99 +++ ...fix-pm_runtime-enable-in-sa_ul_probe.patch | 39 ++ ...id-comparing-pointers-to-exported-fu.patch | 88 +++ .../crypto-sm2-fix-a-memory-leak-in-sm2.patch | 87 +++ ...-remove-unnecessary-reset-operations.patch | 137 +++++ ...x-error-return-code-in-hash_hw_final.patch | 37 ++ ...25519-fix-cpu-feature-checking-logic.patch | 41 ++ ...y-fix-syscache.c-fallthrough-warning.patch | 49 ++ ...syscache-fixup-duplicate-cache-flush.patch | 54 ++ ...necessary-patches-that-fix-unreal-us.patch | 101 ++++ ...nomem-handling-in-grab_mapping_entry.patch | 63 ++ ...-missing-error-code-in-vmbus_connect.patch | 43 ++ ...-the-missed-ida_simple_remove-in-ddr.patch | 41 ++ ...-missing-check-bug-in-dm_dp_mst_dete.patch | 38 ++ ...x-missing-conversions-to-managed-api.patch | 49 ++ ...he-stop-condition-of-drm_bridge_chai.patch | 40 ++ ...dge-sii8620-fix-dependency-on-extcon.patch | 43 ++ ...x-error-return-code-in-dpu_mdss_init.patch | 70 +++ ...ix-error-return-code-in-msm_drm_init.patch | 39 ++ ...ly-fix-config_vexpress_config-depend.patch | 40 ++ ...111-depend-on-config_vexpress_config.patch | 39 ++ ...xl-ensure-surf.data-is-ininitialized.patch | 40 ++ ...-dp-core-add-missing-clk_disable_unp.patch | 38 ++ ...-dp-fix-sign-extension-on-an-int-mul.patch | 42 ++ ...-move-all-lane-config-except-lcdc-mu.patch | 120 ++++ ...chip-lvds-fix-an-error-handling-path.patch | 44 ++ ...-set-alpha_en-to-0-if-it-is-not-used.patch | 36 ++ ...vc4-hdmi-fix-error-path-of-hpd-gpios.patch | 52 ++ ...pu-updates-of-coherent-multisample-s.patch | 109 ++++ ...a-surface-gpu-dirty-after-the-svga3d.patch | 67 ++ queue-5.10/e1000e-check-the-pcim-state.patch | 64 ++ ...t-load-edac-driver-when-running-as-a.patch | 87 +++ ...c-ti-add-missing-module_device_table.patch | 39 ++ ...sx-put-fwnode-in-matching-case-durin.patch | 37 ++ ...sx-restore-printing-the-unsupported-.patch | 46 ++ ...rror-return-code-in-ehea_restart_qps.patch | 69 +++ ...-fix-writing-securityfs-evm-overflow.patch | 44 ++ ...ax8997-fix-irq-freeing-at-error-path.patch | 41 ++ ...-max8997-add-missing-modalias-string.patch | 33 + ...op-invalid-register-write-in-sm5502_.patch | 40 ++ ...10-svc-fix-a-resource-leak-in-an-err.patch | 73 +++ .../fs-dlm-cancel-work-sync-othercon.patch | 38 ++ .../fs-dlm-fix-memory-leak-when-fenced.patch | 85 +++ ...x-return-of-error-values-on-failures.patch | 50 ++ ...cept-response-from-un-initialized-oc.patch | 38 ++ ...n-up-correct-fifo-when-receiving-res.patch | 39 ++ .../fsi-sbefifo-fix-reset-timeout.patch | 60 ++ ...set-the-fsi2pib-engine-for-any-error.patch | 63 ++ ...wapped-vars-when-fetching-max-queues.patch | 35 ++ ...n-error-handling-path-in-hl_pci_prob.patch | 37 ++ ...own_interruptible-when-unbinding-dev.patch | 53 ++ ...t-base-usage-for-capacitive-expressk.patch | 35 ++ ...ref-count-racing-in-prep_compound_gi.patch | 212 +++++++ ...move-prep_compound_huge_page-cleanup.patch | 121 ++++ ...-fix-passing-zero-to-ptr_err-warning.patch | 43 ++ ...vert-hwmon-lm70-add-support-for-acpi.patch | 80 +++ ...hwmon-lm70-use-device_get_match_data.patch | 76 +++ ...-remove-non-standard-acpi-device-ids.patch | 58 ++ ...-fix-fan-speed-reporting-for-fan7.12.patch | 50 ++ ...-max31790-fix-pwmx_enable-attributes.patch | 140 +++++ ...eport-correct-current-pwm-duty-cycle.patch | 76 +++ ...os-fix-runtime-pm-imbalance-on-error.patch | 49 ++ ...neg-disabling-for-non-10gbaset-links.patch | 41 ++ ...-fix-error-handling-in-i40e_vsi_open.patch | 38 ++ ...-rtnl-locking-when-setting-up-pf-swi.patch | 90 +++ ...fix-incorrect-array-size-calculation.patch | 48 ++ ...free-tx_pool-if-tso_pool-alloc-fails.patch | 44 ++ ...c-set-ltb-buff-to-null-after-freeing.patch | 84 +++ ...-avoid-possible-crash-in-hwsim_del_e.patch | 41 ++ ...sim-fix-memory-leak-in-hwsim_add_one.patch | 60 ++ ...-fix-possible-memory-leak-in-hwsim_s.patch | 49 ++ ...-fix-buffer-alignment-in-iio_push_to.patch | 60 ++ ...-fix-buffer-alignment-in-iio_push_to.patch | 59 ++ ...x-buffer-alignment-in-iio_push_to_bu.patch | 68 +++ ...1013-fix-buffer-alignment-in-iio_pus.patch | 87 +++ ...5-fix-overread-of-data-and-alignment.patch | 63 ++ ...2-fix-buffer-alignment-in-iio_push_t.patch | 68 +++ ...50-fix-buffer-alignment-in-iio_push_.patch | 71 +++ ...a5d2-fix-buffer-alignment-in-iio_pus.patch | 45 ++ ...x-buffer-alignment-in-iio_push_to_bu.patch | 47 ++ ...c-fix-buffer-alignment-in-iio_push_t.patch | 47 ++ ...15-fix-buffer-alignment-in-iio_push_.patch | 63 ++ ...88-fix-alignment-of-buffer-in-iio_pu.patch | 43 ++ ...x-buffer-alignment-in-iio_push_to_bu.patch | 59 ++ ...0-do-not-return-ints-in-irq-handlers.patch | 42 ++ ...5-do-not-return-ints-in-irq-handlers.patch | 43 ++ ...r-do-not-return-ints-in-irq-handlers.patch | 42 ++ ...as-fix-buffer-alignment-in-iio_push_.patch | 47 ++ ...ors-fix-alignment-of-buffer-in-iio_p.patch | 46 ++ ...fix-buffer-alignment-in-iio_push_to_.patch | 61 ++ ...315-fix-buffer-alignment-in-iio_push.patch | 71 +++ ...25-fix-buffer-alignment-in-iio_push_.patch | 58 ++ ...4-fix-buffer-alignment-in-iio_push_t.patch | 58 ++ ...2-fix-buffer-alignment-in-iio_push_t.patch | 62 ++ ...00-fix-buffer-alignment-in-iio_push_.patch | 49 ++ ...35-fix-buffer-alignment-in-iio_push_.patch | 48 ++ ...fix-buffer-alignment-in-iio_push_to_.patch | 63 ++ ...-fix-buffer-alignment-in-iio_push_to.patch | 75 +++ ...fix-alignment-of-buffer-in-iio_push_.patch | 47 ++ ...-lmp91000-fix-alignment-of-buffer-in.patch | 45 ++ ...fix-buffer-alignment-in-iio_push_to_.patch | 58 ++ ...1-fix-buffer-alignment-in-iio_push_t.patch | 47 ++ ...light-fix-buffer-alignment-in-iio_pu.patch | 59 ++ ...ix-buffer-alignment-in-iio_push_to_b.patch | 62 ++ ...inux-huge_mm.h-remove-extern-keyword.patch | 166 +++++ ...tform-x86-touchscreen_dmi-move-upsid.patch | 192 ++++++ ...x-error-return-code-in-hil_dev_conne.patch | 37 ++ ...mu-amd-fix-extended-features-logging.patch | 63 ++ ...ommu-dma-fix-iova-reserve-dma-ranges.patch | 44 ++ .../ip6_tunnel-fix-gre6-segmentation.patch | 60 ++ ...-exthdrs-do-not-blindly-use-init_net.patch | 61 ++ ...out-of-bound-access-in-ip6_parse_tlv.patch | 89 +++ .../iwlwifi-increase-pnvm-load-timeout.patch | 48 ++ ...ol-dependency-for-object_files_non_s.patch | 61 ++ ...ix-return-value-when-kthread_mod_del.patch | 99 +++ ...zero-the-cycle-count-register-when-p.patch | 42 ++ ...lobber-nested-mmu-s-a-d-status-on-ep.patch | 70 +++ ...64-bit-shift-when-checking-vmfunc-bi.patch | 54 ++ ...l-pgds-on-nested-transition-with-sha.patch | 113 ++++ ...v-fix-tlb-management-on-smt8-power9-.patch | 142 +++++ ...m-s390-get-rid-of-register-asm-usage.patch | 78 +++ ...return-value-in-tdp_mmu_map_handle_t.patch | 45 ++ ...-error-return-code-in-as3645a_parse_.patch | 37 ++ ...notsupp-should-never-be-seen-by-user.patch | 39 ++ ...s-ktd2692-fix-an-error-handling-path.patch | 85 +++ .../leds-lm3532-select-regmap-i2c-api.patch | 37 ++ ...ut-fwnode-in-error-case-during-probe.patch | 43 ++ ...-put-fwnode-in-any-case-during-probe.patch | 52 ++ ...n-t-spam-logs-when-probe-is-deferred.patch | 44 ++ ...ut-fwnode-in-error-case-during-probe.patch | 47 ++ ...b-math-rational.c-fix-divide-by-zero.patch | 78 +++ ...-handling-of-number-field-widths-in-.patch | 233 +++++++ ...ockdep-fix-wait-type-for-empty-stack.patch | 37 ++ ...s-fix-selftests-vs-prove_raw_lock_ne.patch | 41 ++ ...-avoid-to-find-wrong-lock-dep-path-i.patch | 59 ++ ...fix-the-dep-path-printing-for-backwa.patch | 163 +++++ ...ckdep-reduce-lockdep-dependency-list.patch | 62 ++ ...tari_kbd_core-kconfig-unmet-dependen.patch | 64 ++ ...iwlwifi-specific-workaround-ndps-of-.patch | 41 ++ ...-platform_devid_auto-to-register-pla.patch | 48 ++ ...ile-fix-gdb-warning-with-config_relr.patch | 65 ++ queue-5.10/mark-pstore-blk-as-broken.patch | 41 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 69 +++ ...ia-au0828-fix-a-null-vs-is_err-check.patch | 40 ++ ...ot-schedule-tasklet-when-it-is-not-s.patch | 52 ++ ...x-a-missing-check-bug-in-bt878_probe.patch | 122 ++++ .../media-cedrus-fix-.buf_prepare.patch | 47 ++ ...lt-fix-race-condition-in-setting-hpd.patch | 70 +++ ...2-fix-memory-leak-in-cpia2_usb_probe.patch | 104 ++++ ..._net-avoid-speculation-from-net-slot.patch | 89 +++ ...b-memory-leak-in-cinergyt2_fe_attach.patch | 52 ++ ...-possible-memory-leak-of-em28xx-stru.patch | 58 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 46 ++ ...-fix-a-use-after-free-in-isp_video_r.patch | 57 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 225 +++++++ ...x-media-controller-api-config-checks.patch | 88 +++ ...860-fix-zero-length-control-requests.patch | 48 ++ .../media-hantro-do-a-pm-resume-earlier.patch | 99 +++ .../media-hantro-fix-.buf_prepare.patch | 48 ++ ...vc-fix-dependent-slice-segment-flags.patch | 88 +++ ...-rst-to-rset-to-fix-multiple-build-e.patch | 244 ++++++++ ...-use-clk_-prepare_enable-disable_unp.patch | 106 ++++ ...ip-first-few-frames-from-a-bt.656-so.patch | 63 ++ ...ipi_csis-fix-logging-of-only-error-e.patch | 48 ++ ...c-fix-some-issues-when-getting-pm_ru.patch | 60 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 50 ++ ...-mtk-vcodec-fix-pm-runtime-get-logic.patch | 86 +++ ...b2-fix-warning-in-pvr2_i2c_core_done.patch | 60 ++ .../media-rc-i2c-fix-an-error-message.patch | 40 ++ .../media-rkvdec-fix-.buf_prepare.patch | 54 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 50 ++ ...-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch | 40 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 49 ++ ...ec-decrement-usage-count-if-disabled.patch | 39 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 45 ++ ...siano-fix-device-register-error-path.patch | 39 ++ ...out-of-bounds-warnings-in-smscore_lo.patch | 167 +++++ ...-potential-null-pointer-dereferences.patch | 40 ++ ...-fix-pm_runtime_get_sync-usage-count.patch | 67 ++ .../media-sti-fix-obj-config-targets.patch | 58 ++ ...emove-vidioc_dqevent_time32-handling.patch | 72 +++ ...-fix-pm_runtime_get_sync-usage-count.patch | 39 ++ ...ix-error-return-code-in-tc358743_pro.patch | 38 ++ ...-clean-v4l2_async_notifier_add_fwnod.patch | 566 +++++++++++++++++ ...avoid-the-dangling-pointer-in-v4l2_f.patch | 39 ++ ...enus-rework-error-fail-recover-logic.patch | 156 +++++ ...ia-video-mux-skip-dangling-endpoints.patch | 54 ++ queue-5.10/memstick-rtsx_usb_ms-fix-uaf.patch | 89 +++ ...9-select-mfd_core-to-fix-build-error.patch | 36 ++ ...irq-trigger-by-changing-it-to-level-.patch | 38 ++ ...p-with-32-bit-mips-huge-page-support.patch | 38 ++ ...ble-basic-add-validation-for-dirtine.patch | 178 ++++++ ...ble-basic-iterate-over-entire-protec.patch | 174 ++++++ ...ble-ensure-thp-availability-via-has_.patch | 239 ++++++++ ...-add-missing-read-only-thp-checking-.patch | 229 +++++++ ...-don-t-discard-hugepage-if-other-pro.patch | 58 ++ ...-remove-dedicated-macro-hpage_cache_.patch | 73 +++ ...e-redundant-check-in-preparing-and-d.patch | 53 ++ ...elper-huge_page_order-and-pages_per_.patch | 50 ++ ...operly-set-up-gfp-flags-for-objcg-po.patch | 116 ++++ ..._alloc-fix-counting-of-managed_pages.patch | 56 ++ ...factor-setup_per_zone_lowmem_reserve.patch | 98 +++ ...serting-hugepage-pte-entry-with-fsda.patch | 101 ++++ ...m-fix-shmem_swapin-race-with-swapoff.patch | 99 +++ ...tential-memory-leak-in-z3fold_destro.patch | 40 ++ ...lease_z3fold_page_locked-to-release-.patch | 41 ++ ...mmc-sdhci-sprd-use-sdhci_sprd_writew.patch | 37 ++ ...ix-error-return-code-in-usdhi6_probe.patch | 37 ++ ...d-a-check-against-null-pointer-deref.patch | 140 +++++ ...-pr_debug-in-mptcp_token_new_connect.patch | 55 ++ ...subflow-hmac-after-mptcp_finish_join.patch | 49 ++ ...e-null-pointer-dereference-in-mt76_t.patch | 36 ++ ...null-pointer-dereference-in-tx_prepa.patch | 76 +++ ...edboot-seek-fis-index-block-in-the-r.patch | 51 ++ ...an-ensure-proper-configuration-for-t.patch | 160 +++++ ...ell-add-missing-clk_disable_unprepar.patch | 41 ++ ...wifiex-re-fix-for-unaligned-accesses.patch | 62 ++ ...t-atlantic-fix-the-macsec-key-length.patch | 52 ++ ...ix-attaching-to-pyh-failed-on-rpi-4b.patch | 47 ++ ...fix-null-pointer-dereference-in-sja1.patch | 55 ++ ...-aeroflex-fix-uaf-in-greth_of_remove.patch | 54 ++ ...t-ethernet-ezchip-fix-error-handling.patch | 44 ++ ...et-ezchip-fix-uaf-in-nps_enet_remove.patch | 39 ++ ...d-missing-error-return-code-in-ftgma.patch | 57 ++ ...ap-flow-ports-when-validating-source.patch | 39 ++ ...-handle-mtu-calculation-in-forwading.patch | 142 +++++ ...he-length-used-to-copy-the-key-for-o.patch | 65 ++ ...ut-fwnode-in-error-case-during-probe.patch | 40 ++ ...agate-error-from-devm_gpio_request_o.patch | 56 ++ .../net-phy-mscc-fix-macsec-key-length.patch | 56 ++ ...ix-error-return-code-in-qrtr_ns_init.patch | 41 ++ ...sched-act_vlan-fix-modify-to-allow-0.patch | 95 +++ ...rrier-to-ensure-correct-ordering-for.patch | 68 +++ ...arning-in-tcindex_alloc_perfect_hash.patch | 40 ++ ...-nuss-fix-crash-when-changing-number.patch | 93 +++ .../net-tipc-fix-fb_mtu-eat-two-pages.patch | 118 ++++ ...les_offload-check-flow_dissector_key.patch | 60 ++ ...thdr-check-for-ipv6-packet-before-fu.patch | 38 ++ ...f-check-for-tcp-packet-before-furthe.patch | 40 ++ ...roxy-restrict-support-to-tcp-and-udp.patch | 50 ++ ...emory-leak-in-netlbl_mgmt_add_common.patch | 114 ++++ ...fix-var.-type-for-increasing-cq_head.patch | 44 ++ ...r-storaged3enable-on-companion-acpi-.patch | 78 +++ ...check-for-invalid-target-port-in-nvm.patch | 55 ++ queue-5.10/ocfs2-fix-snprintf-checking.patch | 85 +++ ...n-of-memory-sizes-on-32-bit-platform.patch | 87 +++ ...tly-ignore-unknown-o-flags-in-openat.patch | 108 ++++ .../pata_ep93xx-fix-deferred-probing.patch | 39 ++ ...f-avoid-warn_on-in-ata_host_activate.patch | 45 ++ .../pata_rb532_cf-fix-deferred-probing.patch | 46 ++ ...-for-hyperv_initialized-in-init_hv_p.patch | 41 ++ ...-invalid-pointer-when-access-dtc-obj.patch | 41 ++ ...vm-return-enomem-when-asprintf-fails.patch | 57 ++ ...f-scripting-python-fix-tuple_set_u64.patch | 281 +++++++++ ...x-the-error-handling-path-in-dm816x_.patch | 62 ++ ...ier-pcie-fix-updating-phy-parameters.patch | 63 ++ ...r8a7796-add-missing-bias-for-preset-.patch | 49 ++ ...r8a77990-jtag-pins-do-not-have-pull-.patch | 47 ++ ..._qfq-fix-qfq_change_class-error-path.patch | 203 +++++++ ...s-nb-wmi-revert-add-support-for-asus.patch | 134 ++++ ...s-nb-wmi-revert-drop-duplicate-dmi-q.patch | 116 ++++ ...hiba_acpi-fix-missing-error-code-in-.patch | 42 ++ ...chscreen_dmi-add-an-extra-entry-for-.patch | 48 ++ ...chscreen_dmi-add-info-for-the-goodix.patch | 76 +++ ...issing-error-code-in-devfreq_add_dev.patch | 34 ++ ...copy-paste-data-exposure-into-newly-.patch | 108 ++++ ...powerpc-offline-cpu-in-stop_this_cpu.patch | 61 ++ ...-make-perf_stats-invisible-if-perf-s.patch | 144 +++++ ...m-properly-handle-uuid-types-and-api.patch | 82 +++ ...fix-machine-check-reporting-of-async.patch | 134 ++++ ...e-between-psi_trigger_create-destroy.patch | 112 ++++ ...licit-truncation-warning-in-prandom_.patch | 48 ++ ...pawn_core_kthreads-from-rcu_spawn_gp.patch | 57 ++ ...ncorrect-packet-lifetime-calculation.patch | 54 ++ .../rdma-cma-protect-rmw-with-qp_mutex.patch | 126 ++++ ...-core-always-release-restrack-object.patch | 61 ++ ...ze-wq-state-received-from-the-usersp.patch | 104 ++++ ...on-t-access-null-cleared-mpi-pointer.patch | 93 +++ ...-add-slave-port-to-unaffiliated-list.patch | 49 ++ ...eck-if-the-queue_depth-has-changed-d.patch | 78 +++ ...eck-state-of-the-rtrs_clt_sess-befor.patch | 59 ++ ...x-memory-leak-of-not-freed-sess-stat.patch | 64 ++ ...-reset-hb_missed_max-after-re-connec.patch | 43 ++ ...x-memory-leak-of-unfreed-rtrs_srv_st.patch | 69 +++ ...x-memory-leak-when-having-multiple-s.patch | 88 +++ ...t-minimal-max_send_wr-and-max_recv_w.patch | 107 ++++ ...a-rxe-fix-failure-during-driver-load.patch | 58 ++ ...qp-reference-counting-for-atomic-ops.patch | 60 ++ ...ix-a-recently-introduced-memory-leak.patch | 56 ++ ...-ensure-enough-delay-time-for-.set_v.patch | 39 ++ ...80-fix-vsel_mask-setting-for-fan5388.patch | 42 ++ ...-fix-pass-wrong-pointer-to-config.dr.patch | 80 +++ ...gulator-mt6358-fix-vdram2-.vsel_mask.patch | 36 ++ ...hier-add-missing-module_device_table.patch | 37 ++ ...sable-bh-with-spin_lock-in-be_proces.patch | 118 ++++ ...emove-duplicate-napi_schedule-call-i.patch | 46 ++ ...tw88-8822c-fix-lc-calibration-timing.patch | 82 +++ ...s390-appldata-depends-on-proc_sysctl.patch | 46 ++ .../s390-enable-have_ioremap_prot.patch | 79 +++ ...rq-select-have_irq_exit_on_irq_stack.patch | 34 ++ ...segmentation-fault-for-xdp_redirect-.patch | 46 ++ ...the-error-return-code-of-xdp_redirec.patch | 37 ++ .../sata_highbank-fix-deferred-probing.patch | 46 ++ ...alize-the-idle-task-with-preemption-.patch | 405 +++++++++++++ ...fair-fix-ascii-art-by-relpacing-tabs.patch | 65 ++ ...dline-utilization-tracking-during-po.patch | 53 ++ ...utilization-tracking-during-policy-c.patch | 70 +++ ...x-locking-around-cpu_util_update_eff.patch | 61 ++ .../sched-uclamp-fix-uclamp_tg_restrict.patch | 188 ++++++ ...-wrong-implementation-of-cpu.uclamp..patch | 116 ++++ ...csi-flashpoint-rename-si_flags-field.patch | 163 +++++ ...scsi-flush-block-work-before-unblock.patch | 43 ++ ...-error-return-value-in-_scsih_expand.patch | 43 ++ ...itelist-test_progs.h-from-.gitignore.patch | 45 ++ ...e-fix-event-no-pid-on-1-core-machine.patch | 58 ++ ...-adjust-for-handler-fallback-removal.patch | 188 ++++++ ...ys-fix-alloc_random_pkey-to-make-it-.patch | 102 ++++ ...ys-handle-negative-sys_pkey_alloc-re.patch | 57 ++ ...ys-refill-shadow-register-after-impl.patch | 75 +++ ..._omap-disable-rx-interrupt-after-dma.patch | 148 +++++ ..._omap-fix-possible-interrupt-storm-o.patch | 90 +++ ...ally-allow-upf_magic_multiplier-baud.patch | 84 +++ ...50_omap-fix-a-timeout-loop-condition.patch | 37 ++ ...t-don-t-modify-arbitrary-data-on-lpu.patch | 37 ++ ...t-remove-rtscts-handling-from-get_mc.patch | 50 ++ ...t-correctly-calculate-minimal-possib.patch | 66 ++ ...t-do-not-allow-changing-baudrate-whe.patch | 55 ++ queue-5.10/series | 482 +++++++++++++++ ...eam-fix-test-for-dp-prepare-complete.patch | 70 +++ ...e-all-native-css-in-use-along-with-g.patch | 53 ++ ...ned-behaviour-when-counting-unused-n.patch | 38 ++ ...ister_spi_device-also-set-the-fwnode.patch | 62 ++ ...fix-a-wrong-goto-jump-for-avoiding-m.patch | 50 ++ ...fix-memory-leak-in-meson_spicc_probe.patch | 37 ++ ...100k-fix-the-length-judgment-problem.patch | 36 ++ ...back-test-fix-tx_buf-might-be-rx_buf.patch | 35 ++ ...i-spi-sun6i-fix-chipselect-clock-bug.patch | 56 ++ ...-pch-fix-potential-double-free-in-pc.patch | 42 ++ ...ix-error-return-code-in-ssb_bus_scan.patch | 41 ++ ...n-t-spam-logs-when-probe-is-deferred.patch | 55 ++ .../staging-fbtft-rectify-gpio-handling.patch | 485 +++++++++++++++ ...check-for-buffer-overflow-in-gdm_lte.patch | 61 ++ ...check-for-overflow-in-gdm_lte_netif_.patch | 45 ++ ...vdec-fix-pm_runtime_get_sync-usage-c.patch | 40 ++ ...iq-fix-incorrect-static-vchiq_instan.patch | 46 ++ ...ts-fix-pci-address-for-pci-memory-ra.patch | 54 ++ ...fix-error-handling-in-r871xu_drv_ini.patch | 121 ++++ ...fix-memory-leak-in-rtl871x_load_fw_c.patch | 83 +++ ...p-fix-do_swap_page-race-with-swapoff.patch | 130 ++++ queue-5.10/tc-testing-fix-list-handling.patch | 35 ++ ...cooling-update-offline-cpus-per-cpu-.patch | 47 ++ ...-lanes-only-when-dual_link_port-null.patch | 53 ++ ...sized-sendfile-hangs-by-ignoring-msg.patch | 61 ++ ...ol-fix-error-return-code-in-do_batch.patch | 42 ++ ...pi-add-missing-spi-device-id-entries.patch | 59 ++ ...-resource-leak-in-an-error-handling-.patch | 39 ++ ...he-error-handling-path-of-nozomi_car.patch | 58 ++ ...eset-the-core-after-setting-turnarou.patch | 101 ++++ ...fix-setting-of-device-and-driver-dat.patch | 572 ++++++++++++++++++ ...fio-pci-handle-concurrent-vma-faults.patch | 124 ++++ ...deo-fbdev-imxfb-fix-an-error-message.patch | 41 ++ ...ror-return-code-in-visorchipset_init.patch | 58 ++ ...non-nd-strict-packets-with-a-source-.patch | 83 +++ ...issing-rcu_read_lock-in-neigh_reduce.patch | 84 +++ ..._buf-allocation-to-devm_kmalloc-in-p.patch | 92 +++ ...l9170-fix-leds-build-errors-warnings.patch | 66 ++ ...-increment-isw_nr_in_flight-before-g.patch | 68 +++ ...tain-a-reference-to-a-freeing-memcg-.patch | 61 ++ ...elf-use-_bitul-macro-in-uapi-headers.patch | 43 ++ ...e-irqs-are-disabled-while-ghcb-is-ac.patch | 170 ++++++ ...-runtime-vc-handler-for-correct-stat.patch | 322 ++++++++++ ...-fix-xfrm-offload-fallback-fail-case.patch | 46 ++ ...he-fragment-check-for-ipv6-beet-mode.patch | 55 ++ ...mtu-should-return-at-least-1280-for-.patch | 111 ++++ .../xsk-fix-broken-tx-ring-validation.patch | 65 ++ ...validation-for-skb-and-unaligned-mod.patch | 70 +++ 483 files changed, 36665 insertions(+) create mode 100644 queue-5.10/acpi-apei-fix-synchronous-external-aborts-in-user-mo.patch create mode 100644 queue-5.10/acpi-bgrt-fix-cfi-violation.patch create mode 100644 queue-5.10/acpi-bus-call-kobject_put-in-acpi_init-error-path.patch create mode 100644 queue-5.10/acpi-ec-make-more-asus-laptops-use-ecdt-_gpe.patch create mode 100644 queue-5.10/acpi-ec-trust-dsdt-gpe-for-certain-hp-laptop.patch create mode 100644 queue-5.10/acpi-pm-fan-put-fan-device-ids-into-separate-header-.patch create mode 100644 queue-5.10/acpi-processor-idle-fix-up-c-state-latency-if-not-or.patch create mode 100644 queue-5.10/acpi-resources-add-checks-for-acpi-irq-override.patch create mode 100644 queue-5.10/acpi-sysfs-fix-a-buffer-overrun-problem-with-descrip.patch create mode 100644 queue-5.10/acpi-tables-add-custom-dsdt-file-as-makefile-prerequ.patch create mode 100644 queue-5.10/acpi-use-device_attr_-rw-ro-wo-macros.patch create mode 100644 queue-5.10/acpi-video-use-native-backlight-for-ga401-ga502-ga50.patch create mode 100644 queue-5.10/acpica-fix-memory-leak-caused-by-_cid-repair-functio.patch create mode 100644 queue-5.10/add-a-reference-to-ucounts-for-each-cred.patch create mode 100644 queue-5.10/alsa-firewire-lib-fix-amdtp_domain_start-when-no-amd.patch create mode 100644 queue-5.10/arm64-consistently-use-reserved_pg_dir.patch create mode 100644 queue-5.10/arm64-dts-marvell-armada-37xx-fix-reg-for-standard-v.patch create mode 100644 queue-5.10/arm64-mm-fix-ttbr0-values-stored-in-struct-thread_in.patch create mode 100644 queue-5.10/arm64-perf-convert-snprintf-to-sysfs_emit.patch create mode 100644 queue-5.10/asoc-atmel-i2s-fix-usage-of-capture-and-playback-at-.patch create mode 100644 queue-5.10/asoc-cs42l42-correct-definition-of-cs42l42_adc_pdn_m.patch create mode 100644 queue-5.10/asoc-fsl_spdif-fix-error-handler-with-pm_runtime_ena.patch create mode 100644 queue-5.10/asoc-fsl_spdif-fix-unexpected-interrupt-after-suspen.patch create mode 100644 queue-5.10/asoc-hisilicon-fix-missing-clk_disable_unprepare-on-.patch create mode 100644 queue-5.10/asoc-intel-sof_sdw-add-quirk-support-for-brya-and-bt.patch create mode 100644 queue-5.10/asoc-intel-sof_sdw-add-sof_rt715_dai_id_fix-for-alde.patch create mode 100644 queue-5.10/asoc-intel-sof_sdw-use-mach-data-for-adl-rvp-dmic-co.patch create mode 100644 queue-5.10/asoc-max98373-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/asoc-mediatek-mtk-btcvsd-fix-an-error-handling-path-.patch create mode 100644 queue-5.10/asoc-rk3328-fix-missing-clk_disable_unprepare-on-err.patch create mode 100644 queue-5.10/asoc-rsnd-tidyup-loop-on-rsnd_adg_clk_query.patch create mode 100644 queue-5.10/asoc-rt1308-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/asoc-rt5682-disable-irq-on-shutdown.patch create mode 100644 queue-5.10/asoc-rt5682-fix-getting-the-wrong-device-id-when-the.patch create mode 100644 queue-5.10/asoc-rt5682-sdw-set-regcache_cache_only-false-before.patch create mode 100644 queue-5.10/asoc-rt5682-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/asoc-rt700-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/asoc-rt711-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/asoc-rt715-sdw-use-first_hw_init-flag-on-resume.patch create mode 100644 queue-5.10/ath10k-add-missing-error-return-code-in-ath10k_pci_p.patch create mode 100644 queue-5.10/ath10k-fix-an-error-code-in-ath10k_add_interface.patch create mode 100644 queue-5.10/ath10k-go-to-path-err_unsupported-when-chip-id-is-no.patch create mode 100644 queue-5.10/ath11k-fix-an-error-handling-path-in-ath11k_core_fet.patch create mode 100644 queue-5.10/ath11k-send-beacon-template-after-vdev_start-restart.patch create mode 100644 queue-5.10/backlight-lm3630a_bl-put-fwnode-in-error-case-during.patch create mode 100644 queue-5.10/blk-mq-clear-stale-request-in-tags-rq-before-freeing.patch create mode 100644 queue-5.10/blk-mq-grab-rq-refcount-before-calling-fn-in-blk_mq_.patch create mode 100644 queue-5.10/blk-mq-update-hctx-dispatch_busy-in-case-of-real-sch.patch create mode 100644 queue-5.10/blk-wbt-introduce-a-new-disable-state-to-prevent-fal.patch create mode 100644 queue-5.10/blk-wbt-make-sure-throttle-is-enabled-properly.patch create mode 100644 queue-5.10/block-avoid-double-io-accounting-for-flush-request.patch create mode 100644 queue-5.10/block-fix-discard-request-merge.patch create mode 100644 queue-5.10/block-fix-race-between-adding-removing-rq-qos-and-no.patch create mode 100644 queue-5.10/block_dump-remove-block_dump-feature-in-mark_inode_d.patch create mode 100644 queue-5.10/bluetooth-fix-handling-of-hci_le_advertising_set_ter.patch create mode 100644 queue-5.10/bluetooth-fix-not-sending-set-extended-scan-response.patch create mode 100644 queue-5.10/bluetooth-fix-set-extended-scan-response-data.patch create mode 100644 queue-5.10/bluetooth-mgmt-fix-slab-out-of-bounds-in-tlv_data_is.patch create mode 100644 queue-5.10/bpf-do-not-change-gso_size-during-bpf_skb_change_pro.patch create mode 100644 queue-5.10/bpf-fix-libelf-endian-handling-in-resolv_btfids.patch create mode 100644 queue-5.10/bpf-fix-null-ptr-deref-with-mixed-tail-calls-and-sub.patch create mode 100644 queue-5.10/bpfilter-specify-the-log-level-for-the-kmsg-message.patch create mode 100644 queue-5.10/brcmfmac-correctly-report-average-rssi-in-station-in.patch create mode 100644 queue-5.10/brcmfmac-fix-a-double-free-in-brcmf_sdio_bus_reset.patch create mode 100644 queue-5.10/brcmfmac-fix-setting-of-station-info-chains-bitmask.patch create mode 100644 queue-5.10/brcmsmac-mac80211_if-fix-a-resource-leak-in-an-error.patch create mode 100644 queue-5.10/btrfs-abort-transaction-if-we-fail-to-update-the-del.patch create mode 100644 queue-5.10/btrfs-clear-log-tree-recovering-status-if-starting-t.patch create mode 100644 queue-5.10/btrfs-disable-build-on-platforms-having-page-size-25.patch create mode 100644 queue-5.10/btrfs-don-t-clear-page-extent-mapped-if-we-re-not-in.patch create mode 100644 queue-5.10/btrfs-fix-error-handling-in-__btrfs_update_delayed_i.patch create mode 100644 queue-5.10/btrfs-fix-the-filemap_range_has_page-call-in-btrfs_p.patch create mode 100644 queue-5.10/btrfs-sysfs-fix-format-string-for-some-discard-stats.patch create mode 100644 queue-5.10/can-j1939-j1939_sk_setsockopt-prevent-allocation-of-.patch create mode 100644 queue-5.10/char-pcmcia-error-out-if-num_bytes_read-is-greater-t.patch create mode 100644 queue-5.10/cifs-fix-missing-spinlock-around-update-to-ses-statu.patch create mode 100644 queue-5.10/cifs-improve-fallocate-emulation.patch create mode 100644 queue-5.10/clk-actions-fix-ahpprediv-h-ahb-clock-chain-on-owl-s.patch create mode 100644 queue-5.10/clk-actions-fix-bisp_factor_table-based-clocks-on-ow.patch create mode 100644 queue-5.10/clk-actions-fix-sd-clocks-factor-table-on-owl-s500-s.patch create mode 100644 queue-5.10/clk-actions-fix-uart-clock-dividers-on-owl-s500-soc.patch create mode 100644 queue-5.10/clk-imx8mq-remove-sys-pll-1-2-clock-gates.patch create mode 100644 queue-5.10/clk-meson-g12a-fix-gp0-and-hifi-ranges.patch create mode 100644 queue-5.10/clk-qcom-clk-alpha-pll-fix-cal_l-write-in-alpha_pll_.patch create mode 100644 queue-5.10/clk-si5341-avoid-divide-errors-due-to-bogus-register.patch create mode 100644 queue-5.10/clk-si5341-check-for-input-clock-presence-and-pll-lo.patch create mode 100644 queue-5.10/clk-si5341-update-initialization-magic.patch create mode 100644 queue-5.10/clk-si5341-wait-for-device_ready-on-startup.patch create mode 100644 queue-5.10/clk-tegra30-use-300mhz-for-video-decoder-by-default.patch create mode 100644 queue-5.10/clk-vc5-fix-output-disabling-when-enabling-a-fod.patch create mode 100644 queue-5.10/clocksource-check-per-cpu-clock-synchronization-when.patch create mode 100644 queue-5.10/clocksource-drivers-timer-ti-dm-save-and-restore-tim.patch create mode 100644 queue-5.10/clocksource-retry-clock-read-if-long-delays-detected.patch create mode 100644 queue-5.10/configfs-fix-memleak-in-configfs_release_bin_file.patch create mode 100644 queue-5.10/coresight-core-fix-use-of-uninitialized-pointer.patch create mode 100644 queue-5.10/cpufreq-make-cpufreq_online-call-driver-offline-on-e.patch create mode 100644 queue-5.10/crypto-ccp-fix-a-resource-leak-in-an-error-handling-.patch create mode 100644 queue-5.10/crypto-hisilicon-sec-fixup-3des-minimum-key-size-dec.patch create mode 100644 queue-5.10/crypto-ixp4xx-dma_unmap-the-correct-address.patch create mode 100644 queue-5.10/crypto-ixp4xx-update-iv-after-requests.patch create mode 100644 queue-5.10/crypto-nitrox-fix-unchecked-variable-in-nitrox_regis.patch create mode 100644 queue-5.10/crypto-nx-add-missing-module_device_table.patch create mode 100644 queue-5.10/crypto-nx-fix-rcu-warning-in-nx842_of_upd_status.patch create mode 100644 queue-5.10/crypto-omap-sham-fix-pm-reference-leak-in-omap-sham-.patch create mode 100644 queue-5.10/crypto-qat-check-return-code-of-qat_hal_rd_rel_reg.patch create mode 100644 queue-5.10/crypto-qat-remove-unused-macro-in-fw-loader.patch create mode 100644 queue-5.10/crypto-qce-skcipher-fix-incorrect-sg-count-for-dma-t.patch create mode 100644 queue-5.10/crypto-sa2ul-fix-leaks-on-failure-paths-with-sa_dma_.patch create mode 100644 queue-5.10/crypto-sa2ul-fix-pm_runtime-enable-in-sa_ul_probe.patch create mode 100644 queue-5.10/crypto-shash-avoid-comparing-pointers-to-exported-fu.patch create mode 100644 queue-5.10/crypto-sm2-fix-a-memory-leak-in-sm2.patch create mode 100644 queue-5.10/crypto-sm2-remove-unnecessary-reset-operations.patch create mode 100644 queue-5.10/crypto-ux500-fix-error-return-code-in-hash_hw_final.patch create mode 100644 queue-5.10/crypto-x86-curve25519-fix-cpu-feature-checking-logic.patch create mode 100644 queue-5.10/csky-fix-syscache.c-fallthrough-warning.patch create mode 100644 queue-5.10/csky-syscache-fixup-duplicate-cache-flush.patch create mode 100644 queue-5.10/cw1200-revert-unnecessary-patches-that-fix-unreal-us.patch create mode 100644 queue-5.10/dax-fix-enomem-handling-in-grab_mapping_entry.patch create mode 100644 queue-5.10/drivers-hv-fix-missing-error-code-in-vmbus_connect.patch create mode 100644 queue-5.10/drivers-perf-fix-the-missed-ida_simple_remove-in-ddr.patch create mode 100644 queue-5.10/drm-amd-dc-fix-a-missing-check-bug-in-dm_dp_mst_dete.patch create mode 100644 queue-5.10/drm-ast-fix-missing-conversions-to-managed-api.patch create mode 100644 queue-5.10/drm-bridge-fix-the-stop-condition-of-drm_bridge_chai.patch create mode 100644 queue-5.10/drm-bridge-sii8620-fix-dependency-on-extcon.patch create mode 100644 queue-5.10/drm-msm-dpu-fix-error-return-code-in-dpu_mdss_init.patch create mode 100644 queue-5.10/drm-msm-fix-error-return-code-in-msm_drm_init.patch create mode 100644 queue-5.10/drm-pl111-actually-fix-config_vexpress_config-depend.patch create mode 100644 queue-5.10/drm-pl111-depend-on-config_vexpress_config.patch create mode 100644 queue-5.10/drm-qxl-ensure-surf.data-is-ininitialized.patch create mode 100644 queue-5.10/drm-rockchip-cdn-dp-core-add-missing-clk_disable_unp.patch create mode 100644 queue-5.10/drm-rockchip-cdn-dp-fix-sign-extension-on-an-int-mul.patch create mode 100644 queue-5.10/drm-rockchip-dsi-move-all-lane-config-except-lcdc-mu.patch create mode 100644 queue-5.10/drm-rockchip-lvds-fix-an-error-handling-path.patch create mode 100644 queue-5.10/drm-rockchip-set-alpha_en-to-0-if-it-is-not-used.patch create mode 100644 queue-5.10/drm-vc4-hdmi-fix-error-path-of-hpd-gpios.patch create mode 100644 queue-5.10/drm-vmwgfx-fix-cpu-updates-of-coherent-multisample-s.patch create mode 100644 queue-5.10/drm-vmwgfx-mark-a-surface-gpu-dirty-after-the-svga3d.patch create mode 100644 queue-5.10/e1000e-check-the-pcim-state.patch create mode 100644 queue-5.10/edac-intel-do-not-load-edac-driver-when-running-as-a.patch create mode 100644 queue-5.10/edac-ti-add-missing-module_device_table.patch create mode 100644 queue-5.10/eeprom-idt_89hpesx-put-fwnode-in-matching-case-durin.patch create mode 100644 queue-5.10/eeprom-idt_89hpesx-restore-printing-the-unsupported-.patch create mode 100644 queue-5.10/ehea-fix-error-return-code-in-ehea_restart_qps.patch create mode 100644 queue-5.10/evm-fix-writing-securityfs-evm-overflow.patch create mode 100644 queue-5.10/extcon-extcon-max8997-fix-irq-freeing-at-error-path.patch create mode 100644 queue-5.10/extcon-max8997-add-missing-modalias-string.patch create mode 100644 queue-5.10/extcon-sm5502-drop-invalid-register-write-in-sm5502_.patch create mode 100644 queue-5.10/firmware-stratix10-svc-fix-a-resource-leak-in-an-err.patch create mode 100644 queue-5.10/fs-dlm-cancel-work-sync-othercon.patch create mode 100644 queue-5.10/fs-dlm-fix-memory-leak-when-fenced.patch create mode 100644 queue-5.10/fsi-core-fix-return-of-error-values-on-failures.patch create mode 100644 queue-5.10/fsi-occ-don-t-accept-response-from-un-initialized-oc.patch create mode 100644 queue-5.10/fsi-sbefifo-clean-up-correct-fifo-when-receiving-res.patch create mode 100644 queue-5.10/fsi-sbefifo-fix-reset-timeout.patch create mode 100644 queue-5.10/fsi-scom-reset-the-fsi2pib-engine-for-any-error.patch create mode 100644 queue-5.10/gve-fix-swapped-vars-when-fetching-max-queues.patch create mode 100644 queue-5.10/habanalabs-fix-an-error-handling-path-in-hl_pci_prob.patch create mode 100644 queue-5.10/hid-do-not-use-down_interruptible-when-unbinding-dev.patch create mode 100644 queue-5.10/hid-wacom-correct-base-usage-for-capacitive-expressk.patch create mode 100644 queue-5.10/hugetlb-address-ref-count-racing-in-prep_compound_gi.patch create mode 100644 queue-5.10/hugetlb-remove-prep_compound_huge_page-cleanup.patch create mode 100644 queue-5.10/hv_utils-fix-passing-zero-to-ptr_err-warning.patch create mode 100644 queue-5.10/hwmon-lm70-revert-hwmon-lm70-add-support-for-acpi.patch create mode 100644 queue-5.10/hwmon-lm70-use-device_get_match_data.patch create mode 100644 queue-5.10/hwmon-max31722-remove-non-standard-acpi-device-ids.patch create mode 100644 queue-5.10/hwmon-max31790-fix-fan-speed-reporting-for-fan7.12.patch create mode 100644 queue-5.10/hwmon-max31790-fix-pwmx_enable-attributes.patch create mode 100644 queue-5.10/hwmon-max31790-report-correct-current-pwm-duty-cycle.patch create mode 100644 queue-5.10/hwrng-exynos-fix-runtime-pm-imbalance-on-error.patch create mode 100644 queue-5.10/i40e-fix-autoneg-disabling-for-non-10gbaset-links.patch create mode 100644 queue-5.10/i40e-fix-error-handling-in-i40e_vsi_open.patch create mode 100644 queue-5.10/i40e-fix-missing-rtnl-locking-when-setting-up-pf-swi.patch create mode 100644 queue-5.10/ia64-mca_drv-fix-incorrect-array-size-calculation.patch create mode 100644 queue-5.10/ibmvnic-free-tx_pool-if-tso_pool-alloc-fails.patch create mode 100644 queue-5.10/ibmvnic-set-ltb-buff-to-null-after-freeing.patch create mode 100644 queue-5.10/ieee802154-hwsim-avoid-possible-crash-in-hwsim_del_e.patch create mode 100644 queue-5.10/ieee802154-hwsim-fix-memory-leak-in-hwsim_add_one.patch create mode 100644 queue-5.10/ieee802154-hwsim-fix-possible-memory-leak-in-hwsim_s.patch create mode 100644 queue-5.10/iio-accel-bma180-fix-buffer-alignment-in-iio_push_to.patch create mode 100644 queue-5.10/iio-accel-bma220-fix-buffer-alignment-in-iio_push_to.patch create mode 100644 queue-5.10/iio-accel-hid-fix-buffer-alignment-in-iio_push_to_bu.patch create mode 100644 queue-5.10/iio-accel-kxcjk-1013-fix-buffer-alignment-in-iio_pus.patch create mode 100644 queue-5.10/iio-accel-mxc4005-fix-overread-of-data-and-alignment.patch create mode 100644 queue-5.10/iio-accel-stk8312-fix-buffer-alignment-in-iio_push_t.patch create mode 100644 queue-5.10/iio-accel-stk8ba50-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-adc-at91-sama5d2-fix-buffer-alignment-in-iio_pus.patch create mode 100644 queue-5.10/iio-adc-hx711-fix-buffer-alignment-in-iio_push_to_bu.patch create mode 100644 queue-5.10/iio-adc-mxs-lradc-fix-buffer-alignment-in-iio_push_t.patch create mode 100644 queue-5.10/iio-adc-ti-ads1015-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-adc-ti-ads8688-fix-alignment-of-buffer-in-iio_pu.patch create mode 100644 queue-5.10/iio-adc-vf610-fix-buffer-alignment-in-iio_push_to_bu.patch create mode 100644 queue-5.10/iio-adis16400-do-not-return-ints-in-irq-handlers.patch create mode 100644 queue-5.10/iio-adis16475-do-not-return-ints-in-irq-handlers.patch create mode 100644 queue-5.10/iio-adis_buffer-do-not-return-ints-in-irq-handlers.patch create mode 100644 queue-5.10/iio-chemical-atlas-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-cros_ec_sensors-fix-alignment-of-buffer-in-iio_p.patch create mode 100644 queue-5.10/iio-gyro-bmg160-fix-buffer-alignment-in-iio_push_to_.patch create mode 100644 queue-5.10/iio-humidity-am2315-fix-buffer-alignment-in-iio_push.patch create mode 100644 queue-5.10/iio-light-isl29125-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-light-tcs3414-fix-buffer-alignment-in-iio_push_t.patch create mode 100644 queue-5.10/iio-light-tcs3472-fix-buffer-alignment-in-iio_push_t.patch create mode 100644 queue-5.10/iio-light-vcnl4000-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-light-vcnl4035-fix-buffer-alignment-in-iio_push_.patch create mode 100644 queue-5.10/iio-magn-bmc150-fix-buffer-alignment-in-iio_push_to_.patch create mode 100644 queue-5.10/iio-magn-hmc5843-fix-buffer-alignment-in-iio_push_to.patch create mode 100644 queue-5.10/iio-magn-rm3100-fix-alignment-of-buffer-in-iio_push_.patch create mode 100644 queue-5.10/iio-potentiostat-lmp91000-fix-alignment-of-buffer-in.patch create mode 100644 queue-5.10/iio-prox-as3935-fix-buffer-alignment-in-iio_push_to_.patch create mode 100644 queue-5.10/iio-prox-isl29501-fix-buffer-alignment-in-iio_push_t.patch create mode 100644 queue-5.10/iio-prox-pulsed-light-fix-buffer-alignment-in-iio_pu.patch create mode 100644 queue-5.10/iio-prox-srf08-fix-buffer-alignment-in-iio_push_to_b.patch create mode 100644 queue-5.10/include-linux-huge_mm.h-remove-extern-keyword.patch create mode 100644 queue-5.10/input-goodix-platform-x86-touchscreen_dmi-move-upsid.patch create mode 100644 queue-5.10/input-hil_kbd-fix-error-return-code-in-hil_dev_conne.patch create mode 100644 queue-5.10/iommu-amd-fix-extended-features-logging.patch create mode 100644 queue-5.10/iommu-dma-fix-iova-reserve-dma-ranges.patch create mode 100644 queue-5.10/ip6_tunnel-fix-gre6-segmentation.patch create mode 100644 queue-5.10/ipv6-exthdrs-do-not-blindly-use-init_net.patch create mode 100644 queue-5.10/ipv6-fix-out-of-bound-access-in-ip6_parse_tlv.patch create mode 100644 queue-5.10/iwlwifi-increase-pnvm-load-timeout.patch create mode 100644 queue-5.10/kbuild-fix-objtool-dependency-for-object_files_non_s.patch create mode 100644 queue-5.10/kthread_worker-fix-return-value-when-kthread_mod_del.patch create mode 100644 queue-5.10/kvm-arm64-don-t-zero-the-cycle-count-register-when-p.patch create mode 100644 queue-5.10/kvm-nvmx-don-t-clobber-nested-mmu-s-a-d-status-on-ep.patch create mode 100644 queue-5.10/kvm-nvmx-ensure-64-bit-shift-when-checking-vmfunc-bi.patch create mode 100644 queue-5.10/kvm-nvmx-sync-all-pgds-on-nested-transition-with-sha.patch create mode 100644 queue-5.10/kvm-ppc-book3s-hv-fix-tlb-management-on-smt8-power9-.patch create mode 100644 queue-5.10/kvm-s390-get-rid-of-register-asm-usage.patch create mode 100644 queue-5.10/kvm-x86-mmu-fix-return-value-in-tdp_mmu_map_handle_t.patch create mode 100644 queue-5.10/leds-as3645a-fix-error-return-code-in-as3645a_parse_.patch create mode 100644 queue-5.10/leds-class-the-enotsupp-should-never-be-seen-by-user.patch create mode 100644 queue-5.10/leds-ktd2692-fix-an-error-handling-path.patch create mode 100644 queue-5.10/leds-lm3532-select-regmap-i2c-api.patch create mode 100644 queue-5.10/leds-lm36274-put-fwnode-in-error-case-during-probe.patch create mode 100644 queue-5.10/leds-lm3692x-put-fwnode-in-any-case-during-probe.patch create mode 100644 queue-5.10/leds-lm3697-don-t-spam-logs-when-probe-is-deferred.patch create mode 100644 queue-5.10/leds-lp50xx-put-fwnode-in-error-case-during-probe.patch create mode 100644 queue-5.10/lib-math-rational.c-fix-divide-by-zero.patch create mode 100644 queue-5.10/lib-vsprintf-fix-handling-of-number-field-widths-in-.patch create mode 100644 queue-5.10/lockdep-fix-wait-type-for-empty-stack.patch create mode 100644 queue-5.10/lockdep-selftests-fix-selftests-vs-prove_raw_lock_ne.patch create mode 100644 queue-5.10/lockding-lockdep-avoid-to-find-wrong-lock-dep-path-i.patch create mode 100644 queue-5.10/locking-lockdep-fix-the-dep-path-printing-for-backwa.patch create mode 100644 queue-5.10/locking-lockdep-reduce-lockdep-dependency-list.patch create mode 100644 queue-5.10/m68k-atari-fix-atari_kbd_core-kconfig-unmet-dependen.patch create mode 100644 queue-5.10/mac80211-remove-iwlwifi-specific-workaround-ndps-of-.patch create mode 100644 queue-5.10/mailbox-qcom-use-platform_devid_auto-to-register-pla.patch create mode 100644 queue-5.10/makefile-fix-gdb-warning-with-config_relr.patch create mode 100644 queue-5.10/mark-pstore-blk-as-broken.patch create mode 100644 queue-5.10/media-am437x-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-au0828-fix-a-null-vs-is_err-check.patch create mode 100644 queue-5.10/media-bt878-do-not-schedule-tasklet-when-it-is-not-s.patch create mode 100644 queue-5.10/media-bt8xx-fix-a-missing-check-bug-in-bt878_probe.patch create mode 100644 queue-5.10/media-cedrus-fix-.buf_prepare.patch create mode 100644 queue-5.10/media-cobalt-fix-race-condition-in-setting-hpd.patch create mode 100644 queue-5.10/media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch create mode 100644 queue-5.10/media-dvb_net-avoid-speculation-from-net-slot.patch create mode 100644 queue-5.10/media-dvd_usb-memory-leak-in-cinergyt2_fe_attach.patch create mode 100644 queue-5.10/media-em28xx-fix-possible-memory-leak-of-em28xx-stru.patch create mode 100644 queue-5.10/media-exynos-gsc-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-exynos4-is-fix-a-use-after-free-in-isp_video_r.patch create mode 100644 queue-5.10/media-exynos4-is-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-fix-media-controller-api-config-checks.patch create mode 100644 queue-5.10/media-gspca-gl860-fix-zero-length-control-requests.patch create mode 100644 queue-5.10/media-hantro-do-a-pm-resume-earlier.patch create mode 100644 queue-5.10/media-hantro-fix-.buf_prepare.patch create mode 100644 queue-5.10/media-hevc-fix-dependent-slice-segment-flags.patch create mode 100644 queue-5.10/media-i2c-change-rst-to-rset-to-fix-multiple-build-e.patch create mode 100644 queue-5.10/media-i2c-ov2659-use-clk_-prepare_enable-disable_unp.patch create mode 100644 queue-5.10/media-imx-csi-skip-first-few-frames-from-a-bt.656-so.patch create mode 100644 queue-5.10/media-imx-imx7_mipi_csis-fix-logging-of-only-error-e.patch create mode 100644 queue-5.10/media-marvel-ccic-fix-some-issues-when-getting-pm_ru.patch create mode 100644 queue-5.10/media-mdk-mdp-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-mtk-vcodec-fix-pm-runtime-get-logic.patch create mode 100644 queue-5.10/media-pvrusb2-fix-warning-in-pvr2_i2c_core_done.patch create mode 100644 queue-5.10/media-rc-i2c-fix-an-error-message.patch create mode 100644 queue-5.10/media-rkvdec-fix-.buf_prepare.patch create mode 100644 queue-5.10/media-s5p-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-s5p-g2d-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch create mode 100644 queue-5.10/media-s5p-jpeg-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-s5p_cec-decrement-usage-count-if-disabled.patch create mode 100644 queue-5.10/media-sh_vou-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-siano-fix-device-register-error-path.patch create mode 100644 queue-5.10/media-siano-fix-out-of-bounds-warnings-in-smscore_lo.patch create mode 100644 queue-5.10/media-st-hva-fix-potential-null-pointer-dereferences.patch create mode 100644 queue-5.10/media-sti-bdisp-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-sti-fix-obj-config-targets.patch create mode 100644 queue-5.10/media-subdev-remove-vidioc_dqevent_time32-handling.patch create mode 100644 queue-5.10/media-sunxi-fix-pm_runtime_get_sync-usage-count.patch create mode 100644 queue-5.10/media-tc358743-fix-error-return-code-in-tc358743_pro.patch create mode 100644 queue-5.10/media-v4l2-async-clean-v4l2_async_notifier_add_fwnod.patch create mode 100644 queue-5.10/media-v4l2-core-avoid-the-dangling-pointer-in-v4l2_f.patch create mode 100644 queue-5.10/media-venus-rework-error-fail-recover-logic.patch create mode 100644 queue-5.10/media-video-mux-skip-dangling-endpoints.patch create mode 100644 queue-5.10/memstick-rtsx_usb_ms-fix-uaf.patch create mode 100644 queue-5.10/mfd-mp2629-select-mfd_core-to-fix-build-error.patch create mode 100644 queue-5.10/mfd-rn5t618-fix-irq-trigger-by-changing-it-to-level-.patch create mode 100644 queue-5.10/mips-fix-pkmap-with-32-bit-mips-huge-page-support.patch create mode 100644 queue-5.10/mm-debug_vm_pgtable-basic-add-validation-for-dirtine.patch create mode 100644 queue-5.10/mm-debug_vm_pgtable-basic-iterate-over-entire-protec.patch create mode 100644 queue-5.10/mm-debug_vm_pgtable-ensure-thp-availability-via-has_.patch create mode 100644 queue-5.10/mm-huge_memory.c-add-missing-read-only-thp-checking-.patch create mode 100644 queue-5.10/mm-huge_memory.c-don-t-discard-hugepage-if-other-pro.patch create mode 100644 queue-5.10/mm-huge_memory.c-remove-dedicated-macro-hpage_cache_.patch create mode 100644 queue-5.10/mm-hugetlb-remove-redundant-check-in-preparing-and-d.patch create mode 100644 queue-5.10/mm-hugetlb-use-helper-huge_page_order-and-pages_per_.patch create mode 100644 queue-5.10/mm-memcg-slab-properly-set-up-gfp-flags-for-objcg-po.patch create mode 100644 queue-5.10/mm-page_alloc-fix-counting-of-managed_pages.patch create mode 100644 queue-5.10/mm-page_alloc-refactor-setup_per_zone_lowmem_reserve.patch create mode 100644 queue-5.10/mm-pmem-avoid-inserting-hugepage-pte-entry-with-fsda.patch create mode 100644 queue-5.10/mm-shmem-fix-shmem_swapin-race-with-swapoff.patch create mode 100644 queue-5.10/mm-z3fold-fix-potential-memory-leak-in-z3fold_destro.patch create mode 100644 queue-5.10/mm-z3fold-use-release_z3fold_page_locked-to-release-.patch create mode 100644 queue-5.10/mmc-sdhci-sprd-use-sdhci_sprd_writew.patch create mode 100644 queue-5.10/mmc-usdhi6rol0-fix-error-return-code-in-usdhi6_probe.patch create mode 100644 queue-5.10/mmc-via-sdmmc-add-a-check-against-null-pointer-deref.patch create mode 100644 queue-5.10/mptcp-fix-pr_debug-in-mptcp_token_new_connect.patch create mode 100644 queue-5.10/mptcp-generate-subflow-hmac-after-mptcp_finish_join.patch create mode 100644 queue-5.10/mt76-fix-possible-null-pointer-dereference-in-mt76_t.patch create mode 100644 queue-5.10/mt76-mt7615-fix-null-pointer-dereference-in-tx_prepa.patch create mode 100644 queue-5.10/mtd-partitions-redboot-seek-fis-index-block-in-the-r.patch create mode 100644 queue-5.10/mtd-rawnand-arasan-ensure-proper-configuration-for-t.patch create mode 100644 queue-5.10/mtd-rawnand-marvell-add-missing-clk_disable_unprepar.patch create mode 100644 queue-5.10/mwifiex-re-fix-for-unaligned-accesses.patch create mode 100644 queue-5.10/net-atlantic-fix-the-macsec-key-length.patch create mode 100644 queue-5.10/net-bcmgenet-fix-attaching-to-pyh-failed-on-rpi-4b.patch create mode 100644 queue-5.10/net-dsa-sja1105-fix-null-pointer-dereference-in-sja1.patch create mode 100644 queue-5.10/net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch create mode 100644 queue-5.10/net-ethernet-ezchip-fix-error-handling.patch create mode 100644 queue-5.10/net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch create mode 100644 queue-5.10/net-ftgmac100-add-missing-error-return-code-in-ftgma.patch create mode 100644 queue-5.10/net-ipv4-swap-flow-ports-when-validating-source.patch create mode 100644 queue-5.10/net-lwtunnel-handle-mtu-calculation-in-forwading.patch create mode 100644 queue-5.10/net-macsec-fix-the-length-used-to-copy-the-key-for-o.patch create mode 100644 queue-5.10/net-mvpp2-put-fwnode-in-error-case-during-probe.patch create mode 100644 queue-5.10/net-pch_gbe-propagate-error-from-devm_gpio_request_o.patch create mode 100644 queue-5.10/net-phy-mscc-fix-macsec-key-length.patch create mode 100644 queue-5.10/net-qrtr-ns-fix-error-return-code-in-qrtr_ns_init.patch create mode 100644 queue-5.10/net-sched-act_vlan-fix-modify-to-allow-0.patch create mode 100644 queue-5.10/net-sched-add-barrier-to-ensure-correct-ordering-for.patch create mode 100644 queue-5.10/net-sched-fix-warning-in-tcindex_alloc_perfect_hash.patch create mode 100644 queue-5.10/net-ti-am65-cpsw-nuss-fix-crash-when-changing-number.patch create mode 100644 queue-5.10/net-tipc-fix-fb_mtu-eat-two-pages.patch create mode 100644 queue-5.10/netfilter-nf_tables_offload-check-flow_dissector_key.patch create mode 100644 queue-5.10/netfilter-nft_exthdr-check-for-ipv6-packet-before-fu.patch create mode 100644 queue-5.10/netfilter-nft_osf-check-for-tcp-packet-before-furthe.patch create mode 100644 queue-5.10/netfilter-nft_tproxy-restrict-support-to-tcp-and-udp.patch create mode 100644 queue-5.10/netlabel-fix-memory-leak-in-netlbl_mgmt_add_common.patch create mode 100644 queue-5.10/nvme-pci-fix-var.-type-for-increasing-cq_head.patch create mode 100644 queue-5.10/nvme-pci-look-for-storaged3enable-on-companion-acpi-.patch create mode 100644 queue-5.10/nvmet-fc-do-not-check-for-invalid-target-port-in-nvm.patch create mode 100644 queue-5.10/ocfs2-fix-snprintf-checking.patch create mode 100644 queue-5.10/of-fix-truncation-of-memory-sizes-on-32-bit-platform.patch create mode 100644 queue-5.10/open-don-t-silently-ignore-unknown-o-flags-in-openat.patch create mode 100644 queue-5.10/pata_ep93xx-fix-deferred-probing.patch create mode 100644 queue-5.10/pata_octeon_cf-avoid-warn_on-in-ata_host_activate.patch create mode 100644 queue-5.10/pata_rb532_cf-fix-deferred-probing.patch create mode 100644 queue-5.10/pci-hv-add-check-for-hyperv_initialized-in-init_hv_p.patch create mode 100644 queue-5.10/perf-arm-cmn-fix-invalid-pointer-when-access-dtc-obj.patch create mode 100644 queue-5.10/perf-llvm-return-enomem-when-asprintf-fails.patch create mode 100644 queue-5.10/perf-scripting-python-fix-tuple_set_u64.patch create mode 100644 queue-5.10/phy-ti-dm816x-fix-the-error-handling-path-in-dm816x_.patch create mode 100644 queue-5.10/phy-uniphier-pcie-fix-updating-phy-parameters.patch create mode 100644 queue-5.10/pinctrl-renesas-r8a7796-add-missing-bias-for-preset-.patch create mode 100644 queue-5.10/pinctrl-renesas-r8a77990-jtag-pins-do-not-have-pull-.patch create mode 100644 queue-5.10/pkt_sched-sch_qfq-fix-qfq_change_class-error-path.patch create mode 100644 queue-5.10/platform-x86-asus-nb-wmi-revert-add-support-for-asus.patch create mode 100644 queue-5.10/platform-x86-asus-nb-wmi-revert-drop-duplicate-dmi-q.patch create mode 100644 queue-5.10/platform-x86-toshiba_acpi-fix-missing-error-code-in-.patch create mode 100644 queue-5.10/platform-x86-touchscreen_dmi-add-an-extra-entry-for-.patch create mode 100644 queue-5.10/platform-x86-touchscreen_dmi-add-info-for-the-goodix.patch create mode 100644 queue-5.10/pm-devfreq-add-missing-error-code-in-devfreq_add_dev.patch create mode 100644 queue-5.10/powerpc-64s-fix-copy-paste-data-exposure-into-newly-.patch create mode 100644 queue-5.10/powerpc-offline-cpu-in-stop_this_cpu.patch create mode 100644 queue-5.10/powerpc-papr_scm-make-perf_stats-invisible-if-perf-s.patch create mode 100644 queue-5.10/powerpc-papr_scm-properly-handle-uuid-types-and-api.patch create mode 100644 queue-5.10/powerpc-powernv-fix-machine-check-reporting-of-async.patch create mode 100644 queue-5.10/psi-fix-race-between-psi_trigger_create-destroy.patch create mode 100644 queue-5.10/random32-fix-implicit-truncation-warning-in-prandom_.patch create mode 100644 queue-5.10/rcu-invoke-rcu_spawn_core_kthreads-from-rcu_spawn_gp.patch create mode 100644 queue-5.10/rdma-cma-fix-incorrect-packet-lifetime-calculation.patch create mode 100644 queue-5.10/rdma-cma-protect-rmw-with-qp_mutex.patch create mode 100644 queue-5.10/rdma-core-always-release-restrack-object.patch create mode 100644 queue-5.10/rdma-core-sanitize-wq-state-received-from-the-usersp.patch create mode 100644 queue-5.10/rdma-mlx5-don-t-access-null-cleared-mpi-pointer.patch create mode 100644 queue-5.10/rdma-mlx5-don-t-add-slave-port-to-unaffiliated-list.patch create mode 100644 queue-5.10/rdma-rtrs-clt-check-if-the-queue_depth-has-changed-d.patch create mode 100644 queue-5.10/rdma-rtrs-clt-check-state-of-the-rtrs_clt_sess-befor.patch create mode 100644 queue-5.10/rdma-rtrs-clt-fix-memory-leak-of-not-freed-sess-stat.patch create mode 100644 queue-5.10/rdma-rtrs-do-not-reset-hb_missed_max-after-re-connec.patch create mode 100644 queue-5.10/rdma-rtrs-srv-fix-memory-leak-of-unfreed-rtrs_srv_st.patch create mode 100644 queue-5.10/rdma-rtrs-srv-fix-memory-leak-when-having-multiple-s.patch create mode 100644 queue-5.10/rdma-rtrs-srv-set-minimal-max_send_wr-and-max_recv_w.patch create mode 100644 queue-5.10/rdma-rxe-fix-failure-during-driver-load.patch create mode 100644 queue-5.10/rdma-rxe-fix-qp-reference-counting-for-atomic-ops.patch create mode 100644 queue-5.10/rdma-srp-fix-a-recently-introduced-memory-leak.patch create mode 100644 queue-5.10/regulator-da9052-ensure-enough-delay-time-for-.set_v.patch create mode 100644 queue-5.10/regulator-fan53880-fix-vsel_mask-setting-for-fan5388.patch create mode 100644 queue-5.10/regulator-hi655x-fix-pass-wrong-pointer-to-config.dr.patch create mode 100644 queue-5.10/regulator-mt6358-fix-vdram2-.vsel_mask.patch create mode 100644 queue-5.10/regulator-uniphier-add-missing-module_device_table.patch create mode 100644 queue-5.10/revert-be2net-disable-bh-with-spin_lock-in-be_proces.patch create mode 100644 queue-5.10/revert-ibmvnic-remove-duplicate-napi_schedule-call-i.patch create mode 100644 queue-5.10/rtw88-8822c-fix-lc-calibration-timing.patch create mode 100644 queue-5.10/s390-appldata-depends-on-proc_sysctl.patch create mode 100644 queue-5.10/s390-enable-have_ioremap_prot.patch create mode 100644 queue-5.10/s390-irq-select-have_irq_exit_on_irq_stack.patch create mode 100644 queue-5.10/samples-bpf-fix-segmentation-fault-for-xdp_redirect-.patch create mode 100644 queue-5.10/samples-bpf-fix-the-error-return-code-of-xdp_redirec.patch create mode 100644 queue-5.10/sata_highbank-fix-deferred-probing.patch create mode 100644 queue-5.10/sched-core-initialize-the-idle-task-with-preemption-.patch create mode 100644 queue-5.10/sched-fair-fix-ascii-art-by-relpacing-tabs.patch create mode 100644 queue-5.10/sched-rt-fix-deadline-utilization-tracking-during-po.patch create mode 100644 queue-5.10/sched-rt-fix-rt-utilization-tracking-during-policy-c.patch create mode 100644 queue-5.10/sched-uclamp-fix-locking-around-cpu_util_update_eff.patch create mode 100644 queue-5.10/sched-uclamp-fix-uclamp_tg_restrict.patch create mode 100644 queue-5.10/sched-uclamp-fix-wrong-implementation-of-cpu.uclamp..patch create mode 100644 queue-5.10/scsi-flashpoint-rename-si_flags-field.patch create mode 100644 queue-5.10/scsi-iscsi-flush-block-work-before-unblock.patch create mode 100644 queue-5.10/scsi-mpt3sas-fix-error-return-value-in-_scsih_expand.patch create mode 100644 queue-5.10/selftests-bpf-whitelist-test_progs.h-from-.gitignore.patch create mode 100644 queue-5.10/selftests-ftrace-fix-event-no-pid-on-1-core-machine.patch create mode 100644 queue-5.10/selftests-splice-adjust-for-handler-fallback-removal.patch create mode 100644 queue-5.10/selftests-vm-pkeys-fix-alloc_random_pkey-to-make-it-.patch create mode 100644 queue-5.10/selftests-vm-pkeys-handle-negative-sys_pkey_alloc-re.patch create mode 100644 queue-5.10/selftests-vm-pkeys-refill-shadow-register-after-impl.patch create mode 100644 queue-5.10/serial-8250-8250_omap-disable-rx-interrupt-after-dma.patch create mode 100644 queue-5.10/serial-8250-8250_omap-fix-possible-interrupt-storm-o.patch create mode 100644 queue-5.10/serial-8250-actually-allow-upf_magic_multiplier-baud.patch create mode 100644 queue-5.10/serial-8250_omap-fix-a-timeout-loop-condition.patch create mode 100644 queue-5.10/serial-fsl_lpuart-don-t-modify-arbitrary-data-on-lpu.patch create mode 100644 queue-5.10/serial-fsl_lpuart-remove-rtscts-handling-from-get_mc.patch create mode 100644 queue-5.10/serial-mvebu-uart-correctly-calculate-minimal-possib.patch create mode 100644 queue-5.10/serial-mvebu-uart-do-not-allow-changing-baudrate-whe.patch create mode 100644 queue-5.10/soundwire-stream-fix-test-for-dp-prepare-complete.patch create mode 100644 queue-5.10/spi-allow-to-have-all-native-css-in-use-along-with-g.patch create mode 100644 queue-5.10/spi-avoid-undefined-behaviour-when-counting-unused-n.patch create mode 100644 queue-5.10/spi-make-of_register_spi_device-also-set-the-fwnode.patch create mode 100644 queue-5.10/spi-meson-spicc-fix-a-wrong-goto-jump-for-avoiding-m.patch create mode 100644 queue-5.10/spi-meson-spicc-fix-memory-leak-in-meson_spicc_probe.patch create mode 100644 queue-5.10/spi-omap-100k-fix-the-length-judgment-problem.patch create mode 100644 queue-5.10/spi-spi-loopback-test-fix-tx_buf-might-be-rx_buf.patch create mode 100644 queue-5.10/spi-spi-sun6i-fix-chipselect-clock-bug.patch create mode 100644 queue-5.10/spi-spi-topcliff-pch-fix-potential-double-free-in-pc.patch create mode 100644 queue-5.10/ssb-fix-error-return-code-in-ssb_bus_scan.patch create mode 100644 queue-5.10/staging-fbtft-don-t-spam-logs-when-probe-is-deferred.patch create mode 100644 queue-5.10/staging-fbtft-rectify-gpio-handling.patch create mode 100644 queue-5.10/staging-gdm724x-check-for-buffer-overflow-in-gdm_lte.patch create mode 100644 queue-5.10/staging-gdm724x-check-for-overflow-in-gdm_lte_netif_.patch create mode 100644 queue-5.10/staging-media-rkvdec-fix-pm_runtime_get_sync-usage-c.patch create mode 100644 queue-5.10/staging-mmal-vchiq-fix-incorrect-static-vchiq_instan.patch create mode 100644 queue-5.10/staging-mt7621-dts-fix-pci-address-for-pci-memory-ra.patch create mode 100644 queue-5.10/staging-rtl8712-fix-error-handling-in-r871xu_drv_ini.patch create mode 100644 queue-5.10/staging-rtl8712-fix-memory-leak-in-rtl871x_load_fw_c.patch create mode 100644 queue-5.10/swap-fix-do_swap_page-race-with-swapoff.patch create mode 100644 queue-5.10/tc-testing-fix-list-handling.patch create mode 100644 queue-5.10/thermal-cpufreq_cooling-update-offline-cpus-per-cpu-.patch create mode 100644 queue-5.10/thunderbolt-bond-lanes-only-when-dual_link_port-null.patch create mode 100644 queue-5.10/tls-prevent-oversized-sendfile-hangs-by-ignoring-msg.patch create mode 100644 queue-5.10/tools-bpftool-fix-error-return-code-in-do_batch.patch create mode 100644 queue-5.10/tpm_tis_spi-add-missing-spi-device-id-entries.patch create mode 100644 queue-5.10/tty-nozomi-fix-a-resource-leak-in-an-error-handling-.patch create mode 100644 queue-5.10/tty-nozomi-fix-the-error-handling-path-of-nozomi_car.patch create mode 100644 queue-5.10/usb-dwc2-don-t-reset-the-core-after-setting-turnarou.patch create mode 100644 queue-5.10/usb-gadget-f_fs-fix-setting-of-device-and-driver-dat.patch create mode 100644 queue-5.10/vfio-pci-handle-concurrent-vma-faults.patch create mode 100644 queue-5.10/video-fbdev-imxfb-fix-an-error-message.patch create mode 100644 queue-5.10/visorbus-fix-error-return-code-in-visorchipset_init.patch create mode 100644 queue-5.10/vrf-do-not-push-non-nd-strict-packets-with-a-source-.patch create mode 100644 queue-5.10/vxlan-add-missing-rcu_read_lock-in-neigh_reduce.patch create mode 100644 queue-5.10/wcn36xx-move-hal_buf-allocation-to-devm_kmalloc-in-p.patch create mode 100644 queue-5.10/wireless-carl9170-fix-leds-build-errors-warnings.patch create mode 100644 queue-5.10/writeback-cgroup-increment-isw_nr_in_flight-before-g.patch create mode 100644 queue-5.10/writeback-fix-obtain-a-reference-to-a-freeing-memcg-.patch create mode 100644 queue-5.10/x86-elf-use-_bitul-macro-in-uapi-headers.patch create mode 100644 queue-5.10/x86-sev-make-sure-irqs-are-disabled-while-ghcb-is-ac.patch create mode 100644 queue-5.10/x86-sev-split-up-runtime-vc-handler-for-correct-stat.patch create mode 100644 queue-5.10/xfrm-fix-xfrm-offload-fallback-fail-case.patch create mode 100644 queue-5.10/xfrm-remove-the-fragment-check-for-ipv6-beet-mode.patch create mode 100644 queue-5.10/xfrm-xfrm_state_mtu-should-return-at-least-1280-for-.patch create mode 100644 queue-5.10/xsk-fix-broken-tx-ring-validation.patch create mode 100644 queue-5.10/xsk-fix-missing-validation-for-skb-and-unaligned-mod.patch diff --git a/queue-5.10/acpi-apei-fix-synchronous-external-aborts-in-user-mo.patch b/queue-5.10/acpi-apei-fix-synchronous-external-aborts-in-user-mo.patch new file mode 100644 index 00000000000..245364ccc65 --- /dev/null +++ b/queue-5.10/acpi-apei-fix-synchronous-external-aborts-in-user-mo.patch @@ -0,0 +1,160 @@ +From 4f73a1afbc22b47f1ad1fc1138af484b28a160e2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 20:37:07 +0800 +Subject: ACPI: APEI: fix synchronous external aborts in user-mode + +From: Xiaofei Tan + +[ Upstream commit ccb5ecdc2ddeaff744ee075b54cdff8a689e8fa7 ] + +Before commit 8fcc4ae6faf8 ("arm64: acpi: Make apei_claim_sea() +synchronise with APEI's irq work"), do_sea() would unconditionally +signal the affected task from the arch code. Since that change, +the GHES driver sends the signals. + +This exposes a problem as errors the GHES driver doesn't understand +or doesn't handle effectively are silently ignored. It will cause +the errors get taken again, and circulate endlessly. User-space task +get stuck in this loop. + +Existing firmware on Kunpeng9xx systems reports cache errors with the +'ARM Processor Error' CPER records. + +Do memory failure handling for ARM Processor Error Section just like +for Memory Error Section. + +Fixes: 8fcc4ae6faf8 ("arm64: acpi: Make apei_claim_sea() synchronise with APEI's irq work") +Signed-off-by: Xiaofei Tan +Reviewed-by: James Morse +[ rjw: Subject edit ] +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/apei/ghes.c | 81 +++++++++++++++++++++++++++++++--------- + 1 file changed, 64 insertions(+), 17 deletions(-) + +diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c +index fce7ade2aba9..0c8330ed1ffd 100644 +--- a/drivers/acpi/apei/ghes.c ++++ b/drivers/acpi/apei/ghes.c +@@ -441,28 +441,35 @@ static void ghes_kick_task_work(struct callback_head *head) + gen_pool_free(ghes_estatus_pool, (unsigned long)estatus_node, node_len); + } + +-static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, +- int sev) ++static bool ghes_do_memory_failure(u64 physical_addr, int flags) + { + unsigned long pfn; +- int flags = -1; +- int sec_sev = ghes_severity(gdata->error_severity); +- struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata); + + if (!IS_ENABLED(CONFIG_ACPI_APEI_MEMORY_FAILURE)) + return false; + +- if (!(mem_err->validation_bits & CPER_MEM_VALID_PA)) +- return false; +- +- pfn = mem_err->physical_addr >> PAGE_SHIFT; ++ pfn = PHYS_PFN(physical_addr); + if (!pfn_valid(pfn)) { + pr_warn_ratelimited(FW_WARN GHES_PFX + "Invalid address in generic error data: %#llx\n", +- mem_err->physical_addr); ++ physical_addr); + return false; + } + ++ memory_failure_queue(pfn, flags); ++ return true; ++} ++ ++static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, ++ int sev) ++{ ++ int flags = -1; ++ int sec_sev = ghes_severity(gdata->error_severity); ++ struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata); ++ ++ if (!(mem_err->validation_bits & CPER_MEM_VALID_PA)) ++ return false; ++ + /* iff following two events can be handled properly by now */ + if (sec_sev == GHES_SEV_CORRECTED && + (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) +@@ -470,14 +477,56 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, + if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) + flags = 0; + +- if (flags != -1) { +- memory_failure_queue(pfn, flags); +- return true; +- } ++ if (flags != -1) ++ return ghes_do_memory_failure(mem_err->physical_addr, flags); + + return false; + } + ++static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int sev) ++{ ++ struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); ++ bool queued = false; ++ int sec_sev, i; ++ char *p; ++ ++ log_arm_hw_error(err); ++ ++ sec_sev = ghes_severity(gdata->error_severity); ++ if (sev != GHES_SEV_RECOVERABLE || sec_sev != GHES_SEV_RECOVERABLE) ++ return false; ++ ++ p = (char *)(err + 1); ++ for (i = 0; i < err->err_info_num; i++) { ++ struct cper_arm_err_info *err_info = (struct cper_arm_err_info *)p; ++ bool is_cache = (err_info->type == CPER_ARM_CACHE_ERROR); ++ bool has_pa = (err_info->validation_bits & CPER_ARM_INFO_VALID_PHYSICAL_ADDR); ++ const char *error_type = "unknown error"; ++ ++ /* ++ * The field (err_info->error_info & BIT(26)) is fixed to set to ++ * 1 in some old firmware of HiSilicon Kunpeng920. We assume that ++ * firmware won't mix corrected errors in an uncorrected section, ++ * and don't filter out 'corrected' error here. ++ */ ++ if (is_cache && has_pa) { ++ queued = ghes_do_memory_failure(err_info->physical_fault_addr, 0); ++ p += err_info->length; ++ continue; ++ } ++ ++ if (err_info->type < ARRAY_SIZE(cper_proc_error_type_strs)) ++ error_type = cper_proc_error_type_strs[err_info->type]; ++ ++ pr_warn_ratelimited(FW_WARN GHES_PFX ++ "Unhandled processor error type: %s\n", ++ error_type); ++ p += err_info->length; ++ } ++ ++ return queued; ++} ++ + /* + * PCIe AER errors need to be sent to the AER driver for reporting and + * recovery. The GHES severities map to the following AER severities and +@@ -605,9 +654,7 @@ static bool ghes_do_proc(struct ghes *ghes, + ghes_handle_aer(gdata); + } + else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { +- struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); +- +- log_arm_hw_error(err); ++ queued = ghes_handle_arm_hw_error(gdata, sev); + } else { + void *err = acpi_hest_get_payload(gdata); + +-- +2.30.2 + diff --git a/queue-5.10/acpi-bgrt-fix-cfi-violation.patch b/queue-5.10/acpi-bgrt-fix-cfi-violation.patch new file mode 100644 index 00000000000..1322b6bfb81 --- /dev/null +++ b/queue-5.10/acpi-bgrt-fix-cfi-violation.patch @@ -0,0 +1,125 @@ +From 25c22becae31d5d385f7b8695b4fbc13bab0b856 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 18:38:01 -0700 +Subject: ACPI: bgrt: Fix CFI violation + +From: Nathan Chancellor + +[ Upstream commit f37ccf8fce155d08ae2a4fb3db677911ced0c21a ] + +clang's Control Flow Integrity requires that every indirect call has a +valid target, which is based on the type of the function pointer. The +*_show() functions in this file are written as if they will be called +from dev_attr_show(); however, they will be called from +sysfs_kf_seq_show() because the files were created by +sysfs_create_group() and the sysfs ops are based on kobj_sysfs_ops +because of kobject_add_and_create(). Because the *_show() functions do +not match the type of the show() member in struct kobj_attribute, there +is a CFI violation. + +$ cat /sys/firmware/acpi/bgrt/{status,type,version,{x,y}offset}} +1 +0 +1 +522 +307 + +$ dmesg | grep "CFI failure" +[ 267.761825] CFI failure (target: type_show.d5e1ad21498a5fd14edbc5c320906598.cfi_jt+0x0/0x8): +[ 267.762246] CFI failure (target: xoffset_show.d5e1ad21498a5fd14edbc5c320906598.cfi_jt+0x0/0x8): +[ 267.762584] CFI failure (target: status_show.d5e1ad21498a5fd14edbc5c320906598.cfi_jt+0x0/0x8): +[ 267.762973] CFI failure (target: yoffset_show.d5e1ad21498a5fd14edbc5c320906598.cfi_jt+0x0/0x8): +[ 267.763330] CFI failure (target: version_show.d5e1ad21498a5fd14edbc5c320906598.cfi_jt+0x0/0x8): + +Convert these functions to the type of the show() member in struct +kobj_attribute so that there is no more CFI violation. Because these +functions are all so similar, combine them into a macro. + +Fixes: d1ff4b1cdbab ("ACPI: Add support for exposing BGRT data") +Link: https://github.com/ClangBuiltLinux/linux/issues/1406 +Signed-off-by: Nathan Chancellor +Reviewed-by: Kees Cook +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/bgrt.c | 57 ++++++++++++++------------------------------- + 1 file changed, 18 insertions(+), 39 deletions(-) + +diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c +index 19bb7f870204..e0d14017706e 100644 +--- a/drivers/acpi/bgrt.c ++++ b/drivers/acpi/bgrt.c +@@ -15,40 +15,19 @@ + static void *bgrt_image; + static struct kobject *bgrt_kobj; + +-static ssize_t version_show(struct device *dev, +- struct device_attribute *attr, char *buf) +-{ +- return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.version); +-} +-static DEVICE_ATTR_RO(version); +- +-static ssize_t status_show(struct device *dev, +- struct device_attribute *attr, char *buf) +-{ +- return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.status); +-} +-static DEVICE_ATTR_RO(status); +- +-static ssize_t type_show(struct device *dev, +- struct device_attribute *attr, char *buf) +-{ +- return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_type); +-} +-static DEVICE_ATTR_RO(type); +- +-static ssize_t xoffset_show(struct device *dev, +- struct device_attribute *attr, char *buf) +-{ +- return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_offset_x); +-} +-static DEVICE_ATTR_RO(xoffset); +- +-static ssize_t yoffset_show(struct device *dev, +- struct device_attribute *attr, char *buf) +-{ +- return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_offset_y); +-} +-static DEVICE_ATTR_RO(yoffset); ++#define BGRT_SHOW(_name, _member) \ ++ static ssize_t _name##_show(struct kobject *kobj, \ ++ struct kobj_attribute *attr, char *buf) \ ++ { \ ++ return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab._member); \ ++ } \ ++ struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name) ++ ++BGRT_SHOW(version, version); ++BGRT_SHOW(status, status); ++BGRT_SHOW(type, image_type); ++BGRT_SHOW(xoffset, image_offset_x); ++BGRT_SHOW(yoffset, image_offset_y); + + static ssize_t image_read(struct file *file, struct kobject *kobj, + struct bin_attribute *attr, char *buf, loff_t off, size_t count) +@@ -60,11 +39,11 @@ static ssize_t image_read(struct file *file, struct kobject *kobj, + static BIN_ATTR_RO(image, 0); /* size gets filled in later */ + + static struct attribute *bgrt_attributes[] = { +- &dev_attr_version.attr, +- &dev_attr_status.attr, +- &dev_attr_type.attr, +- &dev_attr_xoffset.attr, +- &dev_attr_yoffset.attr, ++ &bgrt_attr_version.attr, ++ &bgrt_attr_status.attr, ++ &bgrt_attr_type.attr, ++ &bgrt_attr_xoffset.attr, ++ &bgrt_attr_yoffset.attr, + NULL, + }; + +-- +2.30.2 + diff --git a/queue-5.10/acpi-bus-call-kobject_put-in-acpi_init-error-path.patch b/queue-5.10/acpi-bus-call-kobject_put-in-acpi_init-error-path.patch new file mode 100644 index 00000000000..b0b9ab4cad7 --- /dev/null +++ b/queue-5.10/acpi-bus-call-kobject_put-in-acpi_init-error-path.patch @@ -0,0 +1,36 @@ +From a87e5f70414f2c78fe6d0a978d560e6a727c6ebc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 2 Jun 2021 17:36:50 +0800 +Subject: ACPI: bus: Call kobject_put() in acpi_init() error path + +From: Hanjun Guo + +[ Upstream commit 4ac7a817f1992103d4e68e9837304f860b5e7300 ] + +Although the system will not be in a good condition or it will not +boot if acpi_bus_init() fails, it is still necessary to put the +kobject in the error path before returning to avoid leaking memory. + +Signed-off-by: Hanjun Guo +[ rjw: Subject and changelog edits ] +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/bus.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c +index 1682f8b454a2..e317214aabec 100644 +--- a/drivers/acpi/bus.c ++++ b/drivers/acpi/bus.c +@@ -1245,6 +1245,7 @@ static int __init acpi_init(void) + + result = acpi_bus_init(); + if (result) { ++ kobject_put(acpi_kobj); + disable_acpi(); + return result; + } +-- +2.30.2 + diff --git a/queue-5.10/acpi-ec-make-more-asus-laptops-use-ecdt-_gpe.patch b/queue-5.10/acpi-ec-make-more-asus-laptops-use-ecdt-_gpe.patch new file mode 100644 index 00000000000..54e2c4b5e0b --- /dev/null +++ b/queue-5.10/acpi-ec-make-more-asus-laptops-use-ecdt-_gpe.patch @@ -0,0 +1,54 @@ +From e218267cc3b76dd7d7f8d15c562f6aadcc7e368e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 20 May 2021 11:09:50 +0800 +Subject: ACPI: EC: Make more Asus laptops use ECDT _GPE + +From: Chris Chiu + +[ Upstream commit 6306f0431914beaf220634ad36c08234006571d5 ] + +More ASUS laptops have the _GPE define in the DSDT table with a +different value than the _GPE number in the ECDT. + +This is causing media keys not working on ASUS X505BA/BP, X542BA/BP + +Add model info to the quirks list. + +Signed-off-by: Chris Chiu +Signed-off-by: Jian-Hong Pan +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/ec.c | 16 ++++++++++++++++ + 1 file changed, 16 insertions(+) + +diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c +index e0cb1bcfffb2..32f3b6d268f5 100644 +--- a/drivers/acpi/ec.c ++++ b/drivers/acpi/ec.c +@@ -1859,6 +1859,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL}, + { ++ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL}, ++ { ++ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL}, ++ { ++ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL}, ++ { ++ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL}, ++ { + ec_honor_ecdt_gpe, "ASUS X550VXK", { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL}, +-- +2.30.2 + diff --git a/queue-5.10/acpi-ec-trust-dsdt-gpe-for-certain-hp-laptop.patch b/queue-5.10/acpi-ec-trust-dsdt-gpe-for-certain-hp-laptop.patch new file mode 100644 index 00000000000..1f5dc2af0db --- /dev/null +++ b/queue-5.10/acpi-ec-trust-dsdt-gpe-for-certain-hp-laptop.patch @@ -0,0 +1,84 @@ +From 3af5c5e9e91e4c34547f228b1d6e2159576743ee Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 09:37:27 +0800 +Subject: ACPI: EC: trust DSDT GPE for certain HP laptop + +From: Zhang Rui + +[ Upstream commit 4370cbf350dbaca984dbda9f9ce3fac45d6949d5 ] + +On HP Pavilion Gaming Laptop 15-cx0xxx, the ECDT EC and DSDT EC share +the same port addresses but different GPEs. And the DSDT GPE is the +right one to use. + +The current code duplicates DSDT EC with ECDT EC if the port addresses +are the same, and uses ECDT GPE as a result, which breaks this machine. + +Introduce a new quirk for the HP laptop to trust the DSDT GPE, +and avoid duplicating even if the port addresses are the same. + +Link: https://bugzilla.kernel.org/show_bug.cgi?id=209989 +Reported-and-tested-by: Shao Fu, Chen +Signed-off-by: Zhang Rui +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/ec.c | 21 ++++++++++++++++++++- + 1 file changed, 20 insertions(+), 1 deletion(-) + +diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c +index 32f3b6d268f5..be3e0921a6c0 100644 +--- a/drivers/acpi/ec.c ++++ b/drivers/acpi/ec.c +@@ -183,6 +183,7 @@ static struct workqueue_struct *ec_query_wq; + + static int EC_FLAGS_CORRECT_ECDT; /* Needs ECDT port address correction */ + static int EC_FLAGS_IGNORE_DSDT_GPE; /* Needs ECDT GPE as correction setting */ ++static int EC_FLAGS_TRUST_DSDT_GPE; /* Needs DSDT GPE as correction setting */ + static int EC_FLAGS_CLEAR_ON_RESUME; /* Needs acpi_ec_clear() on boot/resume */ + + /* -------------------------------------------------------------------------- +@@ -1606,7 +1607,8 @@ static int acpi_ec_add(struct acpi_device *device) + } + + if (boot_ec && ec->command_addr == boot_ec->command_addr && +- ec->data_addr == boot_ec->data_addr) { ++ ec->data_addr == boot_ec->data_addr && ++ !EC_FLAGS_TRUST_DSDT_GPE) { + /* + * Trust PNP0C09 namespace location rather than + * ECDT ID. But trust ECDT GPE rather than _GPE +@@ -1829,6 +1831,18 @@ static int ec_correct_ecdt(const struct dmi_system_id *id) + return 0; + } + ++/* ++ * Some ECDTs contain wrong GPE setting, but they share the same port addresses ++ * with DSDT EC, don't duplicate the DSDT EC with ECDT EC in this case. ++ * https://bugzilla.kernel.org/show_bug.cgi?id=209989 ++ */ ++static int ec_honor_dsdt_gpe(const struct dmi_system_id *id) ++{ ++ pr_debug("Detected system needing DSDT GPE setting.\n"); ++ EC_FLAGS_TRUST_DSDT_GPE = 1; ++ return 0; ++} ++ + /* + * Some DSDTs contain wrong GPE setting. + * Asus FX502VD/VE, GL702VMK, X550VXK, X580VD +@@ -1883,6 +1897,11 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X580VD"),}, NULL}, + { ++ /* https://bugzilla.kernel.org/show_bug.cgi?id=209989 */ ++ ec_honor_dsdt_gpe, "HP Pavilion Gaming Laptop 15-cx0xxx", { ++ DMI_MATCH(DMI_SYS_VENDOR, "HP"), ++ DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Gaming Laptop 15-cx0xxx"),}, NULL}, ++ { + ec_clear_on_resume, "Samsung hardware", { + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD.")}, NULL}, + {}, +-- +2.30.2 + diff --git a/queue-5.10/acpi-pm-fan-put-fan-device-ids-into-separate-header-.patch b/queue-5.10/acpi-pm-fan-put-fan-device-ids-into-separate-header-.patch new file mode 100644 index 00000000000..e5de279b33a --- /dev/null +++ b/queue-5.10/acpi-pm-fan-put-fan-device-ids-into-separate-header-.patch @@ -0,0 +1,102 @@ +From d213534ee28a9699896fe9aabafe99c43f43ede0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 21:08:51 +0200 +Subject: ACPI: PM / fan: Put fan device IDs into separate header file + +From: Rafael J. Wysocki + +[ Upstream commit b9370dceabb7841c5e65ce4ee4405b9db5231fc4 ] + +The ACPI fan device IDs are shared between the fan driver and the +device power management code. The former is modular, so it needs +to include the table of device IDs for module autoloading and the +latter needs that list to avoid attaching the generic ACPI PM domain +to fan devices (which doesn't make sense) possibly before the fan +driver module is loaded. + +Unfortunately, that requires the list of fan device IDs to be +updated in two places which is prone to mistakes, so put it into +a symbol definition in a separate header file so there is only one +copy of it in case it needs to be updated again in the future. + +Fixes: b9ea0bae260f ("ACPI: PM: Avoid attaching ACPI PM domain to certain devices") +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/device_pm.c | 6 ++---- + drivers/acpi/fan.c | 7 +++---- + drivers/acpi/fan.h | 13 +++++++++++++ + 3 files changed, 18 insertions(+), 8 deletions(-) + create mode 100644 drivers/acpi/fan.h + +diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c +index 48ff6821a83d..ecd2ddc2215f 100644 +--- a/drivers/acpi/device_pm.c ++++ b/drivers/acpi/device_pm.c +@@ -18,6 +18,7 @@ + #include + #include + ++#include "fan.h" + #include "internal.h" + + #define _COMPONENT ACPI_POWER_COMPONENT +@@ -1298,10 +1299,7 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on) + * with the generic ACPI PM domain. + */ + static const struct acpi_device_id special_pm_ids[] = { +- {"PNP0C0B", }, /* Generic ACPI fan */ +- {"INT3404", }, /* Fan */ +- {"INTC1044", }, /* Fan for Tiger Lake generation */ +- {"INTC1048", }, /* Fan for Alder Lake generation */ ++ ACPI_FAN_DEVICE_IDS, + {} + }; + struct acpi_device *adev = ACPI_COMPANION(dev); +diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c +index 66c3983f0ccc..5cd0ceb50bc8 100644 +--- a/drivers/acpi/fan.c ++++ b/drivers/acpi/fan.c +@@ -16,6 +16,8 @@ + #include + #include + ++#include "fan.h" ++ + MODULE_AUTHOR("Paul Diefenbaugh"); + MODULE_DESCRIPTION("ACPI Fan Driver"); + MODULE_LICENSE("GPL"); +@@ -24,10 +26,7 @@ static int acpi_fan_probe(struct platform_device *pdev); + static int acpi_fan_remove(struct platform_device *pdev); + + static const struct acpi_device_id fan_device_ids[] = { +- {"PNP0C0B", 0}, +- {"INT3404", 0}, +- {"INTC1044", 0}, +- {"INTC1048", 0}, ++ ACPI_FAN_DEVICE_IDS, + {"", 0}, + }; + MODULE_DEVICE_TABLE(acpi, fan_device_ids); +diff --git a/drivers/acpi/fan.h b/drivers/acpi/fan.h +new file mode 100644 +index 000000000000..dc9a6efa514b +--- /dev/null ++++ b/drivers/acpi/fan.h +@@ -0,0 +1,13 @@ ++/* SPDX-License-Identifier: GPL-2.0-only */ ++ ++/* ++ * ACPI fan device IDs are shared between the fan driver and the device power ++ * management code. ++ * ++ * Add new device IDs before the generic ACPI fan one. ++ */ ++#define ACPI_FAN_DEVICE_IDS \ ++ {"INT3404", }, /* Fan */ \ ++ {"INTC1044", }, /* Fan for Tiger Lake generation */ \ ++ {"INTC1048", }, /* Fan for Alder Lake generation */ \ ++ {"PNP0C0B", } /* Generic ACPI fan */ +-- +2.30.2 + diff --git a/queue-5.10/acpi-processor-idle-fix-up-c-state-latency-if-not-or.patch b/queue-5.10/acpi-processor-idle-fix-up-c-state-latency-if-not-or.patch new file mode 100644 index 00000000000..e2507a24591 --- /dev/null +++ b/queue-5.10/acpi-processor-idle-fix-up-c-state-latency-if-not-or.patch @@ -0,0 +1,113 @@ +From ae5be72159a5ce260ec2694c2f2188ba8ac4002a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 17:15:14 -0500 +Subject: ACPI: processor idle: Fix up C-state latency if not ordered + +From: Mario Limonciello + +[ Upstream commit 65ea8f2c6e230bdf71fed0137cf9e9d1b307db32 ] + +Generally, the C-state latency is provided by the _CST method or +FADT, but some OEM platforms using AMD Picasso, Renoir, Van Gogh, +and Cezanne set the C2 latency greater than C3's which causes the +C2 state to be skipped. + +That will block the core entering PC6, which prevents S0ix working +properly on Linux systems. + +In other operating systems, the latency values are not validated and +this does not cause problems by skipping states. + +To avoid this issue on Linux, detect when latencies are not an +arithmetic progression and sort them. + +Link: https://gitlab.freedesktop.org/agd5f/linux/-/commit/026d186e4592c1ee9c1cb44295912d0294508725 +Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1230#note_712174 +Suggested-by: Prike Liang +Suggested-by: Alex Deucher +Signed-off-by: Mario Limonciello +[ rjw: Subject and changelog edits ] +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/processor_idle.c | 40 +++++++++++++++++++++++++++++++++++ + 1 file changed, 40 insertions(+) + +diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c +index fb161a21d0ae..8377c3ed10ff 100644 +--- a/drivers/acpi/processor_idle.c ++++ b/drivers/acpi/processor_idle.c +@@ -16,6 +16,7 @@ + #include + #include + #include /* need_resched() */ ++#include + #include + #include + #include +@@ -389,10 +390,37 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr, + return; + } + ++static int acpi_cst_latency_cmp(const void *a, const void *b) ++{ ++ const struct acpi_processor_cx *x = a, *y = b; ++ ++ if (!(x->valid && y->valid)) ++ return 0; ++ if (x->latency > y->latency) ++ return 1; ++ if (x->latency < y->latency) ++ return -1; ++ return 0; ++} ++static void acpi_cst_latency_swap(void *a, void *b, int n) ++{ ++ struct acpi_processor_cx *x = a, *y = b; ++ u32 tmp; ++ ++ if (!(x->valid && y->valid)) ++ return; ++ tmp = x->latency; ++ x->latency = y->latency; ++ y->latency = tmp; ++} ++ + static int acpi_processor_power_verify(struct acpi_processor *pr) + { + unsigned int i; + unsigned int working = 0; ++ unsigned int last_latency = 0; ++ unsigned int last_type = 0; ++ bool buggy_latency = false; + + pr->power.timer_broadcast_on_state = INT_MAX; + +@@ -416,12 +444,24 @@ static int acpi_processor_power_verify(struct acpi_processor *pr) + } + if (!cx->valid) + continue; ++ if (cx->type >= last_type && cx->latency < last_latency) ++ buggy_latency = true; ++ last_latency = cx->latency; ++ last_type = cx->type; + + lapic_timer_check_state(i, pr, cx); + tsc_check_state(cx->type); + working++; + } + ++ if (buggy_latency) { ++ pr_notice("FW issue: working around C-state latencies out of order\n"); ++ sort(&pr->power.states[1], max_cstate, ++ sizeof(struct acpi_processor_cx), ++ acpi_cst_latency_cmp, ++ acpi_cst_latency_swap); ++ } ++ + lapic_timer_propagate_broadcast(pr); + + return (working); +-- +2.30.2 + diff --git a/queue-5.10/acpi-resources-add-checks-for-acpi-irq-override.patch b/queue-5.10/acpi-resources-add-checks-for-acpi-irq-override.patch new file mode 100644 index 00000000000..654f66afa2e --- /dev/null +++ b/queue-5.10/acpi-resources-add-checks-for-acpi-irq-override.patch @@ -0,0 +1,82 @@ +From 2d150b48e8a47a4c5b831a9dc09cd48d1f342976 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 10:14:42 +0800 +Subject: ACPI: resources: Add checks for ACPI IRQ override + +From: Hui Wang + +[ Upstream commit 0ec4e55e9f571f08970ed115ec0addc691eda613 ] + +The laptop keyboard doesn't work on many MEDION notebooks, but the +keyboard works well under Windows and Unix. + +Through debugging, we found this log in the dmesg: + + ACPI: IRQ 1 override to edge, high + pnp 00:03: Plug and Play ACPI device, IDs PNP0303 (active) + + And we checked the IRQ definition in the DSDT, it is: + + IRQ (Level, ActiveLow, Exclusive, ) + {1} + +So the BIOS defines the keyboard IRQ to Level_Low, but the Linux +kernel override it to Edge_High. If the Linux kernel is modified +to skip the IRQ override, the keyboard will work normally. + +From the existing comment in acpi_dev_get_irqresource(), the override +function only needs to be called when IRQ() or IRQNoFlags() is used +to populate the resource descriptor, and according to Section 6.4.2.1 +of ACPI 6.4 [1], if IRQ() is empty or IRQNoFlags() is used, the IRQ +is High true, edge sensitive and non-shareable. ACPICA also assumes +that to be the case (see acpi_rs_set_irq[] in rsirq.c). + +In accordance with the above, check 3 additional conditions +(EdgeSensitive, ActiveHigh and Exclusive) when deciding whether or +not to treat an ACPI_RESOURCE_TYPE_IRQ resource as "legacy", in which +case the IRQ override is applicable to it. + +Link: https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration.html#irq-descriptor # [1] +BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213031 +BugLink: http://bugs.launchpad.net/bugs/1909814 +Suggested-by: Rafael J. Wysocki +Reported-by: Manuel Krause +Tested-by: Manuel Krause +Signed-off-by: Hui Wang +[ rjw: Subject rewrite, changelog edits ] +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/resource.c | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c +index f2f5f1dc7c61..9d82440a1d75 100644 +--- a/drivers/acpi/resource.c ++++ b/drivers/acpi/resource.c +@@ -430,6 +430,13 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi, + } + } + ++static bool irq_is_legacy(struct acpi_resource_irq *irq) ++{ ++ return irq->triggering == ACPI_EDGE_SENSITIVE && ++ irq->polarity == ACPI_ACTIVE_HIGH && ++ irq->shareable == ACPI_EXCLUSIVE; ++} ++ + /** + * acpi_dev_resource_interrupt - Extract ACPI interrupt resource information. + * @ares: Input ACPI resource object. +@@ -468,7 +475,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index, + } + acpi_dev_get_irqresource(res, irq->interrupts[index], + irq->triggering, irq->polarity, +- irq->shareable, true); ++ irq->shareable, irq_is_legacy(irq)); + break; + case ACPI_RESOURCE_TYPE_EXTENDED_IRQ: + ext_irq = &ares->data.extended_irq; +-- +2.30.2 + diff --git a/queue-5.10/acpi-sysfs-fix-a-buffer-overrun-problem-with-descrip.patch b/queue-5.10/acpi-sysfs-fix-a-buffer-overrun-problem-with-descrip.patch new file mode 100644 index 00000000000..e34b15e0f0e --- /dev/null +++ b/queue-5.10/acpi-sysfs-fix-a-buffer-overrun-problem-with-descrip.patch @@ -0,0 +1,73 @@ +From ffd5e204a17eabc00940534ecad88077d24ae6c0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 17:12:01 +0000 +Subject: ACPI: sysfs: Fix a buffer overrun problem with description_show() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Krzysztof Wilczyński + +[ Upstream commit 888be6067b97132c3992866bbcf647572253ab3f ] + +Currently, a device description can be obtained using ACPI, if the _STR +method exists for a particular device, and then exposed to the userspace +via a sysfs object as a string value. + +If the _STR method is available for a given device then the data +(usually a Unicode string) is read and stored in a buffer (of the +ACPI_TYPE_BUFFER type) with a pointer to said buffer cached in the +struct acpi_device_pnp for later access. + +The description_show() function is responsible for exposing the device +description to the userspace via a corresponding sysfs object and +internally calls the utf16s_to_utf8s() function with a pointer to the +buffer that contains the Unicode string so that it can be converted from +UTF16 encoding to UTF8 and thus allowing for the value to be safely +stored and later displayed. + +When invoking the utf16s_to_utf8s() function, the description_show() +function also sets a limit of the data that can be saved into a provided +buffer as a result of the character conversion to be a total of +PAGE_SIZE, and upon completion, the utf16s_to_utf8s() function returns +an integer value denoting the number of bytes that have been written +into the provided buffer. + +Following the execution of the utf16s_to_utf8s() a newline character +will be added at the end of the resulting buffer so that when the value +is read in the userspace through the sysfs object then it would include +newline making it more accessible when working with the sysfs file +system in the shell, etc. Normally, this wouldn't be a problem, but if +the function utf16s_to_utf8s() happens to return the number of bytes +written to be precisely PAGE_SIZE, then we would overrun the buffer and +write the newline character outside the allotted space which can have +undefined consequences or result in a failure. + +To fix this buffer overrun, ensure that there always is enough space +left for the newline character to be safely appended. + +Fixes: d1efe3c324ea ("ACPI: Add new sysfs interface to export device description") +Signed-off-by: Krzysztof Wilczyński +Reviewed-by: Bjorn Helgaas +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/device_sysfs.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c +index bfca116482b8..75e412b2b660 100644 +--- a/drivers/acpi/device_sysfs.c ++++ b/drivers/acpi/device_sysfs.c +@@ -446,7 +446,7 @@ static ssize_t description_show(struct device *dev, + (wchar_t *)acpi_dev->pnp.str_obj->buffer.pointer, + acpi_dev->pnp.str_obj->buffer.length, + UTF16_LITTLE_ENDIAN, buf, +- PAGE_SIZE); ++ PAGE_SIZE - 1); + + buf[result++] = '\n'; + +-- +2.30.2 + diff --git a/queue-5.10/acpi-tables-add-custom-dsdt-file-as-makefile-prerequ.patch b/queue-5.10/acpi-tables-add-custom-dsdt-file-as-makefile-prerequ.patch new file mode 100644 index 00000000000..1d5f315a167 --- /dev/null +++ b/queue-5.10/acpi-tables-add-custom-dsdt-file-as-makefile-prerequ.patch @@ -0,0 +1,43 @@ +From 0286e20c149937d35d36e2b8c657ae45809a5b62 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 16:24:33 +0100 +Subject: ACPI: tables: Add custom DSDT file as makefile prerequisite + +From: Richard Fitzgerald + +[ Upstream commit d1059c1b1146870c52f3dac12cb7b6cbf39ed27f ] + +A custom DSDT file is mostly used during development or debugging, +and in that case it is quite likely to want to rebuild the kernel +after changing ONLY the content of the DSDT. + +This patch adds the custom DSDT as a prerequisite to tables.o +to ensure a rebuild if the DSDT file is updated. Make will merge +the prerequisites from multiple rules for the same target. + +Signed-off-by: Richard Fitzgerald +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/Makefile | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile +index 44e412506317..4466156474ee 100644 +--- a/drivers/acpi/Makefile ++++ b/drivers/acpi/Makefile +@@ -8,6 +8,11 @@ ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT + # + # ACPI Boot-Time Table Parsing + # ++ifeq ($(CONFIG_ACPI_CUSTOM_DSDT),y) ++tables.o: $(src)/../../include/$(subst $\",,$(CONFIG_ACPI_CUSTOM_DSDT_FILE)) ; ++ ++endif ++ + obj-$(CONFIG_ACPI) += tables.o + obj-$(CONFIG_X86) += blacklist.o + +-- +2.30.2 + diff --git a/queue-5.10/acpi-use-device_attr_-rw-ro-wo-macros.patch b/queue-5.10/acpi-use-device_attr_-rw-ro-wo-macros.patch new file mode 100644 index 00000000000..b09089422de --- /dev/null +++ b/queue-5.10/acpi-use-device_attr_-rw-ro-wo-macros.patch @@ -0,0 +1,456 @@ +From 29b5f7255d7879de3e31c78db1b4ee656e401718 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Dec 2020 18:15:36 +0530 +Subject: ACPI: Use DEVICE_ATTR_ macros + +From: Dwaipayan Ray + +[ Upstream commit 0f39ee8324e75c9d370e84a61323ceb194641a18 ] + +Instead of open coding DEVICE_ATTR(), use the +DEVICE_ATTR_RW(), DEVICE_ATTR_RO() and DEVICE_ATTR_WO() +macros wherever possible. + +This required a few functions to be renamed but the +functionality itself is unchanged. + +Signed-off-by: Dwaipayan Ray +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/acpi_pad.c | 24 ++++++++------------ + drivers/acpi/acpi_tad.c | 14 ++++++------ + drivers/acpi/bgrt.c | 20 ++++++++--------- + drivers/acpi/device_sysfs.c | 44 ++++++++++++++++++------------------- + drivers/acpi/dock.c | 26 +++++++++++----------- + drivers/acpi/power.c | 9 ++++---- + 6 files changed, 66 insertions(+), 71 deletions(-) + +diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c +index b8745ce48a47..b84ab722feb4 100644 +--- a/drivers/acpi/acpi_pad.c ++++ b/drivers/acpi/acpi_pad.c +@@ -261,7 +261,7 @@ static uint32_t acpi_pad_idle_cpus_num(void) + return ps_tsk_num; + } + +-static ssize_t acpi_pad_rrtime_store(struct device *dev, ++static ssize_t rrtime_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) + { + unsigned long num; +@@ -275,16 +275,14 @@ static ssize_t acpi_pad_rrtime_store(struct device *dev, + return count; + } + +-static ssize_t acpi_pad_rrtime_show(struct device *dev, ++static ssize_t rrtime_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return scnprintf(buf, PAGE_SIZE, "%d\n", round_robin_time); + } +-static DEVICE_ATTR(rrtime, S_IRUGO|S_IWUSR, +- acpi_pad_rrtime_show, +- acpi_pad_rrtime_store); ++static DEVICE_ATTR_RW(rrtime); + +-static ssize_t acpi_pad_idlepct_store(struct device *dev, ++static ssize_t idlepct_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) + { + unsigned long num; +@@ -298,16 +296,14 @@ static ssize_t acpi_pad_idlepct_store(struct device *dev, + return count; + } + +-static ssize_t acpi_pad_idlepct_show(struct device *dev, ++static ssize_t idlepct_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return scnprintf(buf, PAGE_SIZE, "%d\n", idle_pct); + } +-static DEVICE_ATTR(idlepct, S_IRUGO|S_IWUSR, +- acpi_pad_idlepct_show, +- acpi_pad_idlepct_store); ++static DEVICE_ATTR_RW(idlepct); + +-static ssize_t acpi_pad_idlecpus_store(struct device *dev, ++static ssize_t idlecpus_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) + { + unsigned long num; +@@ -319,16 +315,14 @@ static ssize_t acpi_pad_idlecpus_store(struct device *dev, + return count; + } + +-static ssize_t acpi_pad_idlecpus_show(struct device *dev, ++static ssize_t idlecpus_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return cpumap_print_to_pagebuf(false, buf, + to_cpumask(pad_busy_cpus_bits)); + } + +-static DEVICE_ATTR(idlecpus, S_IRUGO|S_IWUSR, +- acpi_pad_idlecpus_show, +- acpi_pad_idlecpus_store); ++static DEVICE_ATTR_RW(idlecpus); + + static int acpi_pad_add_sysfs(struct acpi_device *device) + { +diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c +index 7d45cce0c3c1..e9b8e8305e23 100644 +--- a/drivers/acpi/acpi_tad.c ++++ b/drivers/acpi/acpi_tad.c +@@ -237,7 +237,7 @@ static ssize_t time_show(struct device *dev, struct device_attribute *attr, + rt.tz, rt.daylight); + } + +-static DEVICE_ATTR(time, S_IRUSR | S_IWUSR, time_show, time_store); ++static DEVICE_ATTR_RW(time); + + static struct attribute *acpi_tad_time_attrs[] = { + &dev_attr_time.attr, +@@ -446,7 +446,7 @@ static ssize_t ac_alarm_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_alarm_read(dev, buf, ACPI_TAD_AC_TIMER); + } + +-static DEVICE_ATTR(ac_alarm, S_IRUSR | S_IWUSR, ac_alarm_show, ac_alarm_store); ++static DEVICE_ATTR_RW(ac_alarm); + + static ssize_t ac_policy_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +@@ -462,7 +462,7 @@ static ssize_t ac_policy_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_policy_read(dev, buf, ACPI_TAD_AC_TIMER); + } + +-static DEVICE_ATTR(ac_policy, S_IRUSR | S_IWUSR, ac_policy_show, ac_policy_store); ++static DEVICE_ATTR_RW(ac_policy); + + static ssize_t ac_status_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +@@ -478,7 +478,7 @@ static ssize_t ac_status_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_status_read(dev, buf, ACPI_TAD_AC_TIMER); + } + +-static DEVICE_ATTR(ac_status, S_IRUSR | S_IWUSR, ac_status_show, ac_status_store); ++static DEVICE_ATTR_RW(ac_status); + + static struct attribute *acpi_tad_attrs[] = { + &dev_attr_caps.attr, +@@ -505,7 +505,7 @@ static ssize_t dc_alarm_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_alarm_read(dev, buf, ACPI_TAD_DC_TIMER); + } + +-static DEVICE_ATTR(dc_alarm, S_IRUSR | S_IWUSR, dc_alarm_show, dc_alarm_store); ++static DEVICE_ATTR_RW(dc_alarm); + + static ssize_t dc_policy_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +@@ -521,7 +521,7 @@ static ssize_t dc_policy_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_policy_read(dev, buf, ACPI_TAD_DC_TIMER); + } + +-static DEVICE_ATTR(dc_policy, S_IRUSR | S_IWUSR, dc_policy_show, dc_policy_store); ++static DEVICE_ATTR_RW(dc_policy); + + static ssize_t dc_status_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +@@ -537,7 +537,7 @@ static ssize_t dc_status_show(struct device *dev, struct device_attribute *attr, + return acpi_tad_status_read(dev, buf, ACPI_TAD_DC_TIMER); + } + +-static DEVICE_ATTR(dc_status, S_IRUSR | S_IWUSR, dc_status_show, dc_status_store); ++static DEVICE_ATTR_RW(dc_status); + + static struct attribute *acpi_tad_dc_attrs[] = { + &dev_attr_dc_alarm.attr, +diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c +index 251f961c28cc..19bb7f870204 100644 +--- a/drivers/acpi/bgrt.c ++++ b/drivers/acpi/bgrt.c +@@ -15,40 +15,40 @@ + static void *bgrt_image; + static struct kobject *bgrt_kobj; + +-static ssize_t show_version(struct device *dev, ++static ssize_t version_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.version); + } +-static DEVICE_ATTR(version, S_IRUGO, show_version, NULL); ++static DEVICE_ATTR_RO(version); + +-static ssize_t show_status(struct device *dev, ++static ssize_t status_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.status); + } +-static DEVICE_ATTR(status, S_IRUGO, show_status, NULL); ++static DEVICE_ATTR_RO(status); + +-static ssize_t show_type(struct device *dev, ++static ssize_t type_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_type); + } +-static DEVICE_ATTR(type, S_IRUGO, show_type, NULL); ++static DEVICE_ATTR_RO(type); + +-static ssize_t show_xoffset(struct device *dev, ++static ssize_t xoffset_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_offset_x); + } +-static DEVICE_ATTR(xoffset, S_IRUGO, show_xoffset, NULL); ++static DEVICE_ATTR_RO(xoffset); + +-static ssize_t show_yoffset(struct device *dev, ++static ssize_t yoffset_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + return snprintf(buf, PAGE_SIZE, "%d\n", bgrt_tab.image_offset_y); + } +-static DEVICE_ATTR(yoffset, S_IRUGO, show_yoffset, NULL); ++static DEVICE_ATTR_RO(yoffset); + + static ssize_t image_read(struct file *file, struct kobject *kobj, + struct bin_attribute *attr, char *buf, loff_t off, size_t count) +diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c +index 75e412b2b660..fe8c7e79f472 100644 +--- a/drivers/acpi/device_sysfs.c ++++ b/drivers/acpi/device_sysfs.c +@@ -325,11 +325,11 @@ int acpi_device_modalias(struct device *dev, char *buf, int size) + EXPORT_SYMBOL_GPL(acpi_device_modalias); + + static ssize_t +-acpi_device_modalias_show(struct device *dev, struct device_attribute *attr, char *buf) ++modalias_show(struct device *dev, struct device_attribute *attr, char *buf) + { + return __acpi_device_modalias(to_acpi_device(dev), buf, 1024); + } +-static DEVICE_ATTR(modalias, 0444, acpi_device_modalias_show, NULL); ++static DEVICE_ATTR_RO(modalias); + + static ssize_t real_power_state_show(struct device *dev, + struct device_attribute *attr, char *buf) +@@ -358,8 +358,8 @@ static ssize_t power_state_show(struct device *dev, + static DEVICE_ATTR_RO(power_state); + + static ssize_t +-acpi_eject_store(struct device *d, struct device_attribute *attr, +- const char *buf, size_t count) ++eject_store(struct device *d, struct device_attribute *attr, ++ const char *buf, size_t count) + { + struct acpi_device *acpi_device = to_acpi_device(d); + acpi_object_type not_used; +@@ -387,28 +387,28 @@ acpi_eject_store(struct device *d, struct device_attribute *attr, + return status == AE_NO_MEMORY ? -ENOMEM : -EAGAIN; + } + +-static DEVICE_ATTR(eject, 0200, NULL, acpi_eject_store); ++static DEVICE_ATTR_WO(eject); + + static ssize_t +-acpi_device_hid_show(struct device *dev, struct device_attribute *attr, char *buf) ++hid_show(struct device *dev, struct device_attribute *attr, char *buf) + { + struct acpi_device *acpi_dev = to_acpi_device(dev); + + return sprintf(buf, "%s\n", acpi_device_hid(acpi_dev)); + } +-static DEVICE_ATTR(hid, 0444, acpi_device_hid_show, NULL); ++static DEVICE_ATTR_RO(hid); + +-static ssize_t acpi_device_uid_show(struct device *dev, +- struct device_attribute *attr, char *buf) ++static ssize_t uid_show(struct device *dev, ++ struct device_attribute *attr, char *buf) + { + struct acpi_device *acpi_dev = to_acpi_device(dev); + + return sprintf(buf, "%s\n", acpi_dev->pnp.unique_id); + } +-static DEVICE_ATTR(uid, 0444, acpi_device_uid_show, NULL); ++static DEVICE_ATTR_RO(uid); + +-static ssize_t acpi_device_adr_show(struct device *dev, +- struct device_attribute *attr, char *buf) ++static ssize_t adr_show(struct device *dev, ++ struct device_attribute *attr, char *buf) + { + struct acpi_device *acpi_dev = to_acpi_device(dev); + +@@ -417,16 +417,16 @@ static ssize_t acpi_device_adr_show(struct device *dev, + else + return sprintf(buf, "0x%08llx\n", acpi_dev->pnp.bus_address); + } +-static DEVICE_ATTR(adr, 0444, acpi_device_adr_show, NULL); ++static DEVICE_ATTR_RO(adr); + +-static ssize_t acpi_device_path_show(struct device *dev, +- struct device_attribute *attr, char *buf) ++static ssize_t path_show(struct device *dev, ++ struct device_attribute *attr, char *buf) + { + struct acpi_device *acpi_dev = to_acpi_device(dev); + + return acpi_object_path(acpi_dev->handle, buf); + } +-static DEVICE_ATTR(path, 0444, acpi_device_path_show, NULL); ++static DEVICE_ATTR_RO(path); + + /* sysfs file that shows description text from the ACPI _STR method */ + static ssize_t description_show(struct device *dev, +@@ -455,8 +455,8 @@ static ssize_t description_show(struct device *dev, + static DEVICE_ATTR_RO(description); + + static ssize_t +-acpi_device_sun_show(struct device *dev, struct device_attribute *attr, +- char *buf) { ++sun_show(struct device *dev, struct device_attribute *attr, ++ char *buf) { + struct acpi_device *acpi_dev = to_acpi_device(dev); + acpi_status status; + unsigned long long sun; +@@ -467,11 +467,11 @@ acpi_device_sun_show(struct device *dev, struct device_attribute *attr, + + return sprintf(buf, "%llu\n", sun); + } +-static DEVICE_ATTR(sun, 0444, acpi_device_sun_show, NULL); ++static DEVICE_ATTR_RO(sun); + + static ssize_t +-acpi_device_hrv_show(struct device *dev, struct device_attribute *attr, +- char *buf) { ++hrv_show(struct device *dev, struct device_attribute *attr, ++ char *buf) { + struct acpi_device *acpi_dev = to_acpi_device(dev); + acpi_status status; + unsigned long long hrv; +@@ -482,7 +482,7 @@ acpi_device_hrv_show(struct device *dev, struct device_attribute *attr, + + return sprintf(buf, "%llu\n", hrv); + } +-static DEVICE_ATTR(hrv, 0444, acpi_device_hrv_show, NULL); ++static DEVICE_ATTR_RO(hrv); + + static ssize_t status_show(struct device *dev, struct device_attribute *attr, + char *buf) { +diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c +index 24e076f44d23..0937ceab052e 100644 +--- a/drivers/acpi/dock.c ++++ b/drivers/acpi/dock.c +@@ -484,7 +484,7 @@ int dock_notify(struct acpi_device *adev, u32 event) + /* + * show_docked - read method for "docked" file in sysfs + */ +-static ssize_t show_docked(struct device *dev, ++static ssize_t docked_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + struct dock_station *dock_station = dev->platform_data; +@@ -493,25 +493,25 @@ static ssize_t show_docked(struct device *dev, + acpi_bus_get_device(dock_station->handle, &adev); + return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev)); + } +-static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL); ++static DEVICE_ATTR_RO(docked); + + /* + * show_flags - read method for flags file in sysfs + */ +-static ssize_t show_flags(struct device *dev, ++static ssize_t flags_show(struct device *dev, + struct device_attribute *attr, char *buf) + { + struct dock_station *dock_station = dev->platform_data; + return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags); + + } +-static DEVICE_ATTR(flags, S_IRUGO, show_flags, NULL); ++static DEVICE_ATTR_RO(flags); + + /* + * write_undock - write method for "undock" file in sysfs + */ +-static ssize_t write_undock(struct device *dev, struct device_attribute *attr, +- const char *buf, size_t count) ++static ssize_t undock_store(struct device *dev, struct device_attribute *attr, ++ const char *buf, size_t count) + { + int ret; + struct dock_station *dock_station = dev->platform_data; +@@ -525,13 +525,13 @@ static ssize_t write_undock(struct device *dev, struct device_attribute *attr, + acpi_scan_lock_release(); + return ret ? ret: count; + } +-static DEVICE_ATTR(undock, S_IWUSR, NULL, write_undock); ++static DEVICE_ATTR_WO(undock); + + /* + * show_dock_uid - read method for "uid" file in sysfs + */ +-static ssize_t show_dock_uid(struct device *dev, +- struct device_attribute *attr, char *buf) ++static ssize_t uid_show(struct device *dev, ++ struct device_attribute *attr, char *buf) + { + unsigned long long lbuf; + struct dock_station *dock_station = dev->platform_data; +@@ -542,10 +542,10 @@ static ssize_t show_dock_uid(struct device *dev, + + return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf); + } +-static DEVICE_ATTR(uid, S_IRUGO, show_dock_uid, NULL); ++static DEVICE_ATTR_RO(uid); + +-static ssize_t show_dock_type(struct device *dev, +- struct device_attribute *attr, char *buf) ++static ssize_t type_show(struct device *dev, ++ struct device_attribute *attr, char *buf) + { + struct dock_station *dock_station = dev->platform_data; + char *type; +@@ -561,7 +561,7 @@ static ssize_t show_dock_type(struct device *dev, + + return snprintf(buf, PAGE_SIZE, "%s\n", type); + } +-static DEVICE_ATTR(type, S_IRUGO, show_dock_type, NULL); ++static DEVICE_ATTR_RO(type); + + static struct attribute *dock_attributes[] = { + &dev_attr_docked.attr, +diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c +index 8048da85b7e0..61115ed8b93f 100644 +--- a/drivers/acpi/power.c ++++ b/drivers/acpi/power.c +@@ -886,15 +886,16 @@ static void acpi_release_power_resource(struct device *dev) + kfree(resource); + } + +-static ssize_t acpi_power_in_use_show(struct device *dev, +- struct device_attribute *attr, +- char *buf) { ++static ssize_t resource_in_use_show(struct device *dev, ++ struct device_attribute *attr, ++ char *buf) ++{ + struct acpi_power_resource *resource; + + resource = to_power_resource(to_acpi_device(dev)); + return sprintf(buf, "%u\n", !!resource->ref_count); + } +-static DEVICE_ATTR(resource_in_use, 0444, acpi_power_in_use_show, NULL); ++static DEVICE_ATTR_RO(resource_in_use); + + static void acpi_power_sysfs_remove(struct acpi_device *device) + { +-- +2.30.2 + diff --git a/queue-5.10/acpi-video-use-native-backlight-for-ga401-ga502-ga50.patch b/queue-5.10/acpi-video-use-native-backlight-for-ga401-ga502-ga50.patch new file mode 100644 index 00000000000..6e4f1c3b36f --- /dev/null +++ b/queue-5.10/acpi-video-use-native-backlight-for-ga401-ga502-ga50.patch @@ -0,0 +1,57 @@ +From f80be5b5fc70fd84223a85d9fc104cb6261ad57d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 19 Apr 2021 19:39:17 +1200 +Subject: ACPI: video: use native backlight for GA401/GA502/GA503 + +From: Luke D Jones + +[ Upstream commit 2dfbacc65d1d2eae587ccb6b93f6280542641858 ] + +Force backlight control in these models to use the native interface +at /sys/class/backlight/amdgpu_bl0. + +Signed-off-by: Luke D. Jones +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/video_detect.c | 24 ++++++++++++++++++++++++ + 1 file changed, 24 insertions(+) + +diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c +index 83cd4c95faf0..33474fd96991 100644 +--- a/drivers/acpi/video_detect.c ++++ b/drivers/acpi/video_detect.c +@@ -385,6 +385,30 @@ static const struct dmi_system_id video_detect_dmi_table[] = { + DMI_MATCH(DMI_BOARD_NAME, "BA51_MV"), + }, + }, ++ { ++ .callback = video_detect_force_native, ++ .ident = "ASUSTeK COMPUTER INC. GA401", ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "GA401"), ++ }, ++ }, ++ { ++ .callback = video_detect_force_native, ++ .ident = "ASUSTeK COMPUTER INC. GA502", ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "GA502"), ++ }, ++ }, ++ { ++ .callback = video_detect_force_native, ++ .ident = "ASUSTeK COMPUTER INC. GA503", ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "GA503"), ++ }, ++ }, + + /* + * Desktops which falsely report a backlight and which our heuristics +-- +2.30.2 + diff --git a/queue-5.10/acpica-fix-memory-leak-caused-by-_cid-repair-functio.patch b/queue-5.10/acpica-fix-memory-leak-caused-by-_cid-repair-functio.patch new file mode 100644 index 00000000000..09c9a2d3982 --- /dev/null +++ b/queue-5.10/acpica-fix-memory-leak-caused-by-_cid-repair-functio.patch @@ -0,0 +1,55 @@ +From cf082a6d1cb99c1cbcace0f529acecbeac9504b2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 4 Jun 2021 14:25:57 -0700 +Subject: ACPICA: Fix memory leak caused by _CID repair function + +From: Erik Kaneda + +[ Upstream commit c27bac0314131b11bccd735f7e8415ac6444b667 ] + +ACPICA commit 180cb53963aa876c782a6f52cc155d951b26051a + +According to the ACPI spec, _CID returns a package containing +hardware ID's. Each element of an ASL package contains a reference +count from the parent package as well as the element itself. + +Name (TEST, Package() { + "String object" // this package element has a reference count of 2 +}) + +A memory leak was caused in the _CID repair function because it did +not decrement the reference count created by the package. Fix the +memory leak by calling acpi_ut_remove_reference on _CID package elements +that represent a hardware ID (_HID). + +Link: https://github.com/acpica/acpica/commit/180cb539 +Tested-by: Shawn Guo +Signed-off-by: Erik Kaneda +Signed-off-by: Bob Moore +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/acpica/nsrepair2.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c +index 125143c41bb8..8768594c79e5 100644 +--- a/drivers/acpi/acpica/nsrepair2.c ++++ b/drivers/acpi/acpica/nsrepair2.c +@@ -375,6 +375,13 @@ acpi_ns_repair_CID(struct acpi_evaluate_info *info, + + (*element_ptr)->common.reference_count = + original_ref_count; ++ ++ /* ++ * The original_element holds a reference from the package object ++ * that represents _HID. Since a new element was created by _HID, ++ * remove the reference from the _CID package. ++ */ ++ acpi_ut_remove_reference(original_element); + } + + element_ptr++; +-- +2.30.2 + diff --git a/queue-5.10/add-a-reference-to-ucounts-for-each-cred.patch b/queue-5.10/add-a-reference-to-ucounts-for-each-cred.patch new file mode 100644 index 00000000000..9894ef22df2 --- /dev/null +++ b/queue-5.10/add-a-reference-to-ucounts-for-each-cred.patch @@ -0,0 +1,341 @@ +From a9fee60b1d684cbf95b8ba56e8828d0d7bd12b8d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 22 Apr 2021 14:27:09 +0200 +Subject: Add a reference to ucounts for each cred + +From: Alexey Gladkov + +[ Upstream commit 905ae01c4ae2ae3df05bb141801b1db4b7d83c61 ] + +For RLIMIT_NPROC and some other rlimits the user_struct that holds the +global limit is kept alive for the lifetime of a process by keeping it +in struct cred. Adding a pointer to ucounts in the struct cred will +allow to track RLIMIT_NPROC not only for user in the system, but for +user in the user_namespace. + +Updating ucounts may require memory allocation which may fail. So, we +cannot change cred.ucounts in the commit_creds() because this function +cannot fail and it should always return 0. For this reason, we modify +cred.ucounts before calling the commit_creds(). + +Changelog + +v6: +* Fix null-ptr-deref in is_ucounts_overlimit() detected by trinity. This + error was caused by the fact that cred_alloc_blank() left the ucounts + pointer empty. + +Reported-by: kernel test robot +Signed-off-by: Alexey Gladkov +Link: https://lkml.kernel.org/r/b37aaef28d8b9b0d757e07ba6dd27281bbe39259.1619094428.git.legion@kernel.org +Signed-off-by: Eric W. Biederman +Signed-off-by: Sasha Levin +--- + fs/exec.c | 4 ++++ + include/linux/cred.h | 2 ++ + include/linux/user_namespace.h | 4 ++++ + kernel/cred.c | 40 ++++++++++++++++++++++++++++++++++ + kernel/fork.c | 6 +++++ + kernel/sys.c | 12 ++++++++++ + kernel/ucount.c | 40 +++++++++++++++++++++++++++++++--- + kernel/user_namespace.c | 3 +++ + 8 files changed, 108 insertions(+), 3 deletions(-) + +diff --git a/fs/exec.c b/fs/exec.c +index ca89e0e3ef10..c7a4ef8df305 100644 +--- a/fs/exec.c ++++ b/fs/exec.c +@@ -1347,6 +1347,10 @@ int begin_new_exec(struct linux_binprm * bprm) + WRITE_ONCE(me->self_exec_id, me->self_exec_id + 1); + flush_signal_handlers(me, 0); + ++ retval = set_cred_ucounts(bprm->cred); ++ if (retval < 0) ++ goto out_unlock; ++ + /* + * install the new credentials for this executable + */ +diff --git a/include/linux/cred.h b/include/linux/cred.h +index 18639c069263..ad160e5fe5c6 100644 +--- a/include/linux/cred.h ++++ b/include/linux/cred.h +@@ -144,6 +144,7 @@ struct cred { + #endif + struct user_struct *user; /* real user ID subscription */ + struct user_namespace *user_ns; /* user_ns the caps and keyrings are relative to. */ ++ struct ucounts *ucounts; + struct group_info *group_info; /* supplementary groups for euid/fsgid */ + /* RCU deletion */ + union { +@@ -170,6 +171,7 @@ extern int set_security_override_from_ctx(struct cred *, const char *); + extern int set_create_files_as(struct cred *, struct inode *); + extern int cred_fscmp(const struct cred *, const struct cred *); + extern void __init cred_init(void); ++extern int set_cred_ucounts(struct cred *); + + /* + * check for validity of credentials +diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h +index 7616c7bf4b24..e1bd560da1cd 100644 +--- a/include/linux/user_namespace.h ++++ b/include/linux/user_namespace.h +@@ -101,11 +101,15 @@ struct ucounts { + }; + + extern struct user_namespace init_user_ns; ++extern struct ucounts init_ucounts; + + bool setup_userns_sysctls(struct user_namespace *ns); + void retire_userns_sysctls(struct user_namespace *ns); + struct ucounts *inc_ucount(struct user_namespace *ns, kuid_t uid, enum ucount_type type); + void dec_ucount(struct ucounts *ucounts, enum ucount_type type); ++struct ucounts *alloc_ucounts(struct user_namespace *ns, kuid_t uid); ++struct ucounts *get_ucounts(struct ucounts *ucounts); ++void put_ucounts(struct ucounts *ucounts); + + #ifdef CONFIG_USER_NS + +diff --git a/kernel/cred.c b/kernel/cred.c +index 421b1149c651..58a8a9e24347 100644 +--- a/kernel/cred.c ++++ b/kernel/cred.c +@@ -60,6 +60,7 @@ struct cred init_cred = { + .user = INIT_USER, + .user_ns = &init_user_ns, + .group_info = &init_groups, ++ .ucounts = &init_ucounts, + }; + + static inline void set_cred_subscribers(struct cred *cred, int n) +@@ -119,6 +120,8 @@ static void put_cred_rcu(struct rcu_head *rcu) + if (cred->group_info) + put_group_info(cred->group_info); + free_uid(cred->user); ++ if (cred->ucounts) ++ put_ucounts(cred->ucounts); + put_user_ns(cred->user_ns); + kmem_cache_free(cred_jar, cred); + } +@@ -222,6 +225,7 @@ struct cred *cred_alloc_blank(void) + #ifdef CONFIG_DEBUG_CREDENTIALS + new->magic = CRED_MAGIC; + #endif ++ new->ucounts = get_ucounts(&init_ucounts); + + if (security_cred_alloc_blank(new, GFP_KERNEL_ACCOUNT) < 0) + goto error; +@@ -284,6 +288,11 @@ struct cred *prepare_creds(void) + + if (security_prepare_creds(new, old, GFP_KERNEL_ACCOUNT) < 0) + goto error; ++ ++ new->ucounts = get_ucounts(new->ucounts); ++ if (!new->ucounts) ++ goto error; ++ + validate_creds(new); + return new; + +@@ -363,6 +372,8 @@ int copy_creds(struct task_struct *p, unsigned long clone_flags) + ret = create_user_ns(new); + if (ret < 0) + goto error_put; ++ if (set_cred_ucounts(new) < 0) ++ goto error_put; + } + + #ifdef CONFIG_KEYS +@@ -653,6 +664,31 @@ int cred_fscmp(const struct cred *a, const struct cred *b) + } + EXPORT_SYMBOL(cred_fscmp); + ++int set_cred_ucounts(struct cred *new) ++{ ++ struct task_struct *task = current; ++ const struct cred *old = task->real_cred; ++ struct ucounts *old_ucounts = new->ucounts; ++ ++ if (new->user == old->user && new->user_ns == old->user_ns) ++ return 0; ++ ++ /* ++ * This optimization is needed because alloc_ucounts() uses locks ++ * for table lookups. ++ */ ++ if (old_ucounts && old_ucounts->ns == new->user_ns && uid_eq(old_ucounts->uid, new->euid)) ++ return 0; ++ ++ if (!(new->ucounts = alloc_ucounts(new->user_ns, new->euid))) ++ return -EAGAIN; ++ ++ if (old_ucounts) ++ put_ucounts(old_ucounts); ++ ++ return 0; ++} ++ + /* + * initialise the credentials stuff + */ +@@ -719,6 +755,10 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon) + if (security_prepare_creds(new, old, GFP_KERNEL_ACCOUNT) < 0) + goto error; + ++ new->ucounts = get_ucounts(new->ucounts); ++ if (!new->ucounts) ++ goto error; ++ + put_cred(old); + validate_creds(new); + return new; +diff --git a/kernel/fork.c b/kernel/fork.c +index 7c044d377926..281addb694df 100644 +--- a/kernel/fork.c ++++ b/kernel/fork.c +@@ -2960,6 +2960,12 @@ int ksys_unshare(unsigned long unshare_flags) + if (err) + goto bad_unshare_cleanup_cred; + ++ if (new_cred) { ++ err = set_cred_ucounts(new_cred); ++ if (err) ++ goto bad_unshare_cleanup_cred; ++ } ++ + if (new_fs || new_fd || do_sysvsem || new_cred || new_nsproxy) { + if (do_sysvsem) { + /* +diff --git a/kernel/sys.c b/kernel/sys.c +index a730c03ee607..0670e824e019 100644 +--- a/kernel/sys.c ++++ b/kernel/sys.c +@@ -552,6 +552,10 @@ long __sys_setreuid(uid_t ruid, uid_t euid) + if (retval < 0) + goto error; + ++ retval = set_cred_ucounts(new); ++ if (retval < 0) ++ goto error; ++ + return commit_creds(new); + + error: +@@ -610,6 +614,10 @@ long __sys_setuid(uid_t uid) + if (retval < 0) + goto error; + ++ retval = set_cred_ucounts(new); ++ if (retval < 0) ++ goto error; ++ + return commit_creds(new); + + error: +@@ -685,6 +693,10 @@ long __sys_setresuid(uid_t ruid, uid_t euid, uid_t suid) + if (retval < 0) + goto error; + ++ retval = set_cred_ucounts(new); ++ if (retval < 0) ++ goto error; ++ + return commit_creds(new); + + error: +diff --git a/kernel/ucount.c b/kernel/ucount.c +index 11b1596e2542..9894795043c4 100644 +--- a/kernel/ucount.c ++++ b/kernel/ucount.c +@@ -8,6 +8,12 @@ + #include + #include + ++struct ucounts init_ucounts = { ++ .ns = &init_user_ns, ++ .uid = GLOBAL_ROOT_UID, ++ .count = 1, ++}; ++ + #define UCOUNTS_HASHTABLE_BITS 10 + static struct hlist_head ucounts_hashtable[(1 << UCOUNTS_HASHTABLE_BITS)]; + static DEFINE_SPINLOCK(ucounts_lock); +@@ -125,7 +131,15 @@ static struct ucounts *find_ucounts(struct user_namespace *ns, kuid_t uid, struc + return NULL; + } + +-static struct ucounts *get_ucounts(struct user_namespace *ns, kuid_t uid) ++static void hlist_add_ucounts(struct ucounts *ucounts) ++{ ++ struct hlist_head *hashent = ucounts_hashentry(ucounts->ns, ucounts->uid); ++ spin_lock_irq(&ucounts_lock); ++ hlist_add_head(&ucounts->node, hashent); ++ spin_unlock_irq(&ucounts_lock); ++} ++ ++struct ucounts *alloc_ucounts(struct user_namespace *ns, kuid_t uid) + { + struct hlist_head *hashent = ucounts_hashentry(ns, uid); + struct ucounts *ucounts, *new; +@@ -160,7 +174,26 @@ static struct ucounts *get_ucounts(struct user_namespace *ns, kuid_t uid) + return ucounts; + } + +-static void put_ucounts(struct ucounts *ucounts) ++struct ucounts *get_ucounts(struct ucounts *ucounts) ++{ ++ unsigned long flags; ++ ++ if (!ucounts) ++ return NULL; ++ ++ spin_lock_irqsave(&ucounts_lock, flags); ++ if (ucounts->count == INT_MAX) { ++ WARN_ONCE(1, "ucounts: counter has reached its maximum value"); ++ ucounts = NULL; ++ } else { ++ ucounts->count += 1; ++ } ++ spin_unlock_irqrestore(&ucounts_lock, flags); ++ ++ return ucounts; ++} ++ ++void put_ucounts(struct ucounts *ucounts) + { + unsigned long flags; + +@@ -194,7 +227,7 @@ struct ucounts *inc_ucount(struct user_namespace *ns, kuid_t uid, + { + struct ucounts *ucounts, *iter, *bad; + struct user_namespace *tns; +- ucounts = get_ucounts(ns, uid); ++ ucounts = alloc_ucounts(ns, uid); + for (iter = ucounts; iter; iter = tns->ucounts) { + int max; + tns = iter->ns; +@@ -237,6 +270,7 @@ static __init int user_namespace_sysctl_init(void) + BUG_ON(!user_header); + BUG_ON(!setup_userns_sysctls(&init_user_ns)); + #endif ++ hlist_add_ucounts(&init_ucounts); + return 0; + } + subsys_initcall(user_namespace_sysctl_init); +diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c +index ce396ea4de60..8206a13c81eb 100644 +--- a/kernel/user_namespace.c ++++ b/kernel/user_namespace.c +@@ -1340,6 +1340,9 @@ static int userns_install(struct nsset *nsset, struct ns_common *ns) + put_user_ns(cred->user_ns); + set_cred_user_ns(cred, get_user_ns(user_ns)); + ++ if (set_cred_ucounts(cred) < 0) ++ return -EINVAL; ++ + return 0; + } + +-- +2.30.2 + diff --git a/queue-5.10/alsa-firewire-lib-fix-amdtp_domain_start-when-no-amd.patch b/queue-5.10/alsa-firewire-lib-fix-amdtp_domain_start-when-no-amd.patch new file mode 100644 index 00000000000..0df668ec7a9 --- /dev/null +++ b/queue-5.10/alsa-firewire-lib-fix-amdtp_domain_start-when-no-amd.patch @@ -0,0 +1,53 @@ +From 4f23aebe794661cf8e37beab6d9c210237ac800b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 20:49:36 +0200 +Subject: ALSA: firewire-lib: Fix 'amdtp_domain_start()' when no + AMDTP_OUT_STREAM stream is found + +From: Christophe JAILLET + +[ Upstream commit 0cbbeaf370221fc469c95945dd3c1198865c5fe4 ] + +The intent here is to return an error code if we don't find what we are +looking for in the 'list_for_each_entry()' loop. + +'s' is not NULL if the list is empty or if we scan the complete list. +Introduce a new 'found' variable to handle such cases. + +Fixes: 60dd49298ec5 ("ALSA: firewire-lib: handle several AMDTP streams in callback handler of IRQ target") +Signed-off-by: Christophe JAILLET +Acked-by: Takashi Sakamoto +Link: https://lore.kernel.org/r/9c9a53a4905984a570ba5672cbab84f2027dedc1.1624560484.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Takashi Iwai +Signed-off-by: Sasha Levin +--- + sound/firewire/amdtp-stream.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c +index 5805c5de39fb..7a282d8e7148 100644 +--- a/sound/firewire/amdtp-stream.c ++++ b/sound/firewire/amdtp-stream.c +@@ -1404,14 +1404,17 @@ int amdtp_domain_start(struct amdtp_domain *d, unsigned int ir_delay_cycle) + unsigned int queue_size; + struct amdtp_stream *s; + int cycle; ++ bool found = false; + int err; + + // Select an IT context as IRQ target. + list_for_each_entry(s, &d->streams, list) { +- if (s->direction == AMDTP_OUT_STREAM) ++ if (s->direction == AMDTP_OUT_STREAM) { ++ found = true; + break; ++ } + } +- if (!s) ++ if (!found) + return -ENXIO; + d->irq_target = s; + +-- +2.30.2 + diff --git a/queue-5.10/arm64-consistently-use-reserved_pg_dir.patch b/queue-5.10/arm64-consistently-use-reserved_pg_dir.patch new file mode 100644 index 00000000000..5d580c4cea5 --- /dev/null +++ b/queue-5.10/arm64-consistently-use-reserved_pg_dir.patch @@ -0,0 +1,209 @@ +From 68cfe48f688c85898112ed3875ec4d68260c661c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 10:22:29 +0000 +Subject: arm64: consistently use reserved_pg_dir + +From: Mark Rutland + +[ Upstream commit 833be850f1cabd0e3b5337c0fcab20a6e936dd48 ] + +Depending on configuration options and specific code paths, we either +use the empty_zero_page or the configuration-dependent reserved_ttbr0 +as a reserved value for TTBR{0,1}_EL1. + +To simplify this code, let's always allocate and use the same +reserved_pg_dir, replacing reserved_ttbr0. Note that this is allocated +(and hence pre-zeroed), and is also marked as read-only in the kernel +Image mapping. + +Keeping this separate from the empty_zero_page potentially helps with +robustness as the empty_zero_page is used in a number of cases where a +failure to map it read-only could allow it to become corrupted. + +The (presently unused) swapper_pg_end symbol is also removed, and +comments are added wherever we rely on the offsets between the +pre-allocated pg_dirs to keep these cases easily identifiable. + +Signed-off-by: Mark Rutland +Cc: Will Deacon +Link: https://lore.kernel.org/r/20201103102229.8542-1-mark.rutland@arm.com +Signed-off-by: Catalin Marinas +Signed-off-by: Sasha Levin +--- + arch/arm64/include/asm/asm-uaccess.h | 4 ++-- + arch/arm64/include/asm/kernel-pgtable.h | 6 ------ + arch/arm64/include/asm/mmu_context.h | 6 +++--- + arch/arm64/include/asm/pgtable.h | 1 + + arch/arm64/include/asm/uaccess.h | 4 ++-- + arch/arm64/kernel/entry.S | 6 ++++-- + arch/arm64/kernel/setup.c | 2 +- + arch/arm64/kernel/vmlinux.lds.S | 8 +++----- + arch/arm64/mm/proc.S | 2 +- + 9 files changed, 17 insertions(+), 22 deletions(-) + +diff --git a/arch/arm64/include/asm/asm-uaccess.h b/arch/arm64/include/asm/asm-uaccess.h +index f68a0e64482a..5ef624fef44a 100644 +--- a/arch/arm64/include/asm/asm-uaccess.h ++++ b/arch/arm64/include/asm/asm-uaccess.h +@@ -15,10 +15,10 @@ + .macro __uaccess_ttbr0_disable, tmp1 + mrs \tmp1, ttbr1_el1 // swapper_pg_dir + bic \tmp1, \tmp1, #TTBR_ASID_MASK +- sub \tmp1, \tmp1, #RESERVED_TTBR0_SIZE // reserved_ttbr0 just before swapper_pg_dir ++ sub \tmp1, \tmp1, #PAGE_SIZE // reserved_pg_dir just before swapper_pg_dir + msr ttbr0_el1, \tmp1 // set reserved TTBR0_EL1 + isb +- add \tmp1, \tmp1, #RESERVED_TTBR0_SIZE ++ add \tmp1, \tmp1, #PAGE_SIZE + msr ttbr1_el1, \tmp1 // set reserved ASID + isb + .endm +diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/asm/kernel-pgtable.h +index 19ca76ea60d9..587c504a4c8b 100644 +--- a/arch/arm64/include/asm/kernel-pgtable.h ++++ b/arch/arm64/include/asm/kernel-pgtable.h +@@ -89,12 +89,6 @@ + #define INIT_DIR_SIZE (PAGE_SIZE * EARLY_PAGES(KIMAGE_VADDR, _end)) + #define IDMAP_DIR_SIZE (IDMAP_PGTABLE_LEVELS * PAGE_SIZE) + +-#ifdef CONFIG_ARM64_SW_TTBR0_PAN +-#define RESERVED_TTBR0_SIZE (PAGE_SIZE) +-#else +-#define RESERVED_TTBR0_SIZE (0) +-#endif +- + /* Initial memory map size */ + #if ARM64_SWAPPER_USES_SECTION_MAPS + #define SWAPPER_BLOCK_SHIFT SECTION_SHIFT +diff --git a/arch/arm64/include/asm/mmu_context.h b/arch/arm64/include/asm/mmu_context.h +index 4e2ba9477845..68028de06d18 100644 +--- a/arch/arm64/include/asm/mmu_context.h ++++ b/arch/arm64/include/asm/mmu_context.h +@@ -36,11 +36,11 @@ static inline void contextidr_thread_switch(struct task_struct *next) + } + + /* +- * Set TTBR0 to empty_zero_page. No translations will be possible via TTBR0. ++ * Set TTBR0 to reserved_pg_dir. No translations will be possible via TTBR0. + */ + static inline void cpu_set_reserved_ttbr0(void) + { +- unsigned long ttbr = phys_to_ttbr(__pa_symbol(empty_zero_page)); ++ unsigned long ttbr = phys_to_ttbr(__pa_symbol(reserved_pg_dir)); + + write_sysreg(ttbr, ttbr0_el1); + isb(); +@@ -192,7 +192,7 @@ static inline void update_saved_ttbr0(struct task_struct *tsk, + return; + + if (mm == &init_mm) +- ttbr = __pa_symbol(empty_zero_page); ++ ttbr = __pa_symbol(reserved_pg_dir); + else + ttbr = virt_to_phys(mm->pgd) | ASID(mm) << 48; + +diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h +index 717f13d52ecc..10ffbc96ac31 100644 +--- a/arch/arm64/include/asm/pgtable.h ++++ b/arch/arm64/include/asm/pgtable.h +@@ -530,6 +530,7 @@ extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; + extern pgd_t idmap_pg_dir[PTRS_PER_PGD]; + extern pgd_t idmap_pg_end[]; + extern pgd_t tramp_pg_dir[PTRS_PER_PGD]; ++extern pgd_t reserved_pg_dir[PTRS_PER_PGD]; + + extern void set_swapper_pgd(pgd_t *pgdp, pgd_t pgd); + +diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h +index 991dd5f031e4..385a189f7d39 100644 +--- a/arch/arm64/include/asm/uaccess.h ++++ b/arch/arm64/include/asm/uaccess.h +@@ -113,8 +113,8 @@ static inline void __uaccess_ttbr0_disable(void) + local_irq_save(flags); + ttbr = read_sysreg(ttbr1_el1); + ttbr &= ~TTBR_ASID_MASK; +- /* reserved_ttbr0 placed before swapper_pg_dir */ +- write_sysreg(ttbr - RESERVED_TTBR0_SIZE, ttbr0_el1); ++ /* reserved_pg_dir placed before swapper_pg_dir */ ++ write_sysreg(ttbr - PAGE_SIZE, ttbr0_el1); + isb(); + /* Set reserved ASID */ + write_sysreg(ttbr, ttbr1_el1); +diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S +index 60d399123360..fe83d6d67ec3 100644 +--- a/arch/arm64/kernel/entry.S ++++ b/arch/arm64/kernel/entry.S +@@ -770,9 +770,10 @@ SYM_CODE_END(ret_to_user) + */ + .pushsection ".entry.tramp.text", "ax" + ++ // Move from tramp_pg_dir to swapper_pg_dir + .macro tramp_map_kernel, tmp + mrs \tmp, ttbr1_el1 +- add \tmp, \tmp, #(PAGE_SIZE + RESERVED_TTBR0_SIZE) ++ add \tmp, \tmp, #(2 * PAGE_SIZE) + bic \tmp, \tmp, #USER_ASID_FLAG + msr ttbr1_el1, \tmp + #ifdef CONFIG_QCOM_FALKOR_ERRATUM_1003 +@@ -789,9 +790,10 @@ alternative_else_nop_endif + #endif /* CONFIG_QCOM_FALKOR_ERRATUM_1003 */ + .endm + ++ // Move from swapper_pg_dir to tramp_pg_dir + .macro tramp_unmap_kernel, tmp + mrs \tmp, ttbr1_el1 +- sub \tmp, \tmp, #(PAGE_SIZE + RESERVED_TTBR0_SIZE) ++ sub \tmp, \tmp, #(2 * PAGE_SIZE) + orr \tmp, \tmp, #USER_ASID_FLAG + msr ttbr1_el1, \tmp + /* +diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c +index 133257ffd859..c28a9ec76b11 100644 +--- a/arch/arm64/kernel/setup.c ++++ b/arch/arm64/kernel/setup.c +@@ -366,7 +366,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) + * faults in case uaccess_enable() is inadvertently called by the init + * thread. + */ +- init_task.thread_info.ttbr0 = __pa_symbol(empty_zero_page); ++ init_task.thread_info.ttbr0 = __pa_symbol(reserved_pg_dir); + #endif + + if (boot_args[1] || boot_args[2] || boot_args[3]) { +diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S +index 1bda604f4c70..30c102978942 100644 +--- a/arch/arm64/kernel/vmlinux.lds.S ++++ b/arch/arm64/kernel/vmlinux.lds.S +@@ -164,13 +164,11 @@ SECTIONS + . += PAGE_SIZE; + #endif + +-#ifdef CONFIG_ARM64_SW_TTBR0_PAN +- reserved_ttbr0 = .; +- . += RESERVED_TTBR0_SIZE; +-#endif ++ reserved_pg_dir = .; ++ . += PAGE_SIZE; ++ + swapper_pg_dir = .; + . += PAGE_SIZE; +- swapper_pg_end = .; + + . = ALIGN(SEGMENT_ALIGN); + __init_begin = .; +diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S +index a14927360be2..aacc7eab9b2f 100644 +--- a/arch/arm64/mm/proc.S ++++ b/arch/arm64/mm/proc.S +@@ -168,7 +168,7 @@ SYM_FUNC_END(cpu_do_resume) + .pushsection ".idmap.text", "awx" + + .macro __idmap_cpu_set_reserved_ttbr1, tmp1, tmp2 +- adrp \tmp1, empty_zero_page ++ adrp \tmp1, reserved_pg_dir + phys_to_ttbr \tmp2, \tmp1 + offset_ttbr1 \tmp2, \tmp1 + msr ttbr1_el1, \tmp2 +-- +2.30.2 + diff --git a/queue-5.10/arm64-dts-marvell-armada-37xx-fix-reg-for-standard-v.patch b/queue-5.10/arm64-dts-marvell-armada-37xx-fix-reg-for-standard-v.patch new file mode 100644 index 00000000000..a0ab3896d2b --- /dev/null +++ b/queue-5.10/arm64-dts-marvell-armada-37xx-fix-reg-for-standard-v.patch @@ -0,0 +1,41 @@ +From 53ed87cc4556c2500b419bf22ccceef83e6b8e85 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 00:49:04 +0200 +Subject: arm64: dts: marvell: armada-37xx: Fix reg for standard variant of + UART +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit 2cbfdedef39fb5994b8f1e1df068eb8440165975 ] + +UART1 (standard variant with DT node name 'uart0') has register space +0x12000-0x12018 and not whole size 0x200. So fix also this in example. + +Signed-off-by: Pali Rohár +Fixes: c737abc193d1 ("arm64: dts: marvell: Fix A37xx UART0 register size") +Link: https://lore.kernel.org/r/20210624224909.6350-6-pali@kernel.org +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi +index a89e47d95eef..879115dfdf82 100644 +--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi ++++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi +@@ -134,7 +134,7 @@ + + uart0: serial@12000 { + compatible = "marvell,armada-3700-uart"; +- reg = <0x12000 0x200>; ++ reg = <0x12000 0x18>; + clocks = <&xtalclk>; + interrupts = + , +-- +2.30.2 + diff --git a/queue-5.10/arm64-mm-fix-ttbr0-values-stored-in-struct-thread_in.patch b/queue-5.10/arm64-mm-fix-ttbr0-values-stored-in-struct-thread_in.patch new file mode 100644 index 00000000000..24fabafbce5 --- /dev/null +++ b/queue-5.10/arm64-mm-fix-ttbr0-values-stored-in-struct-thread_in.patch @@ -0,0 +1,70 @@ +From 0486c235790b5eb91d186a1eb15c0cf8e942672a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Jun 2021 15:02:58 +0530 +Subject: arm64/mm: Fix ttbr0 values stored in struct thread_info for + software-pan + +From: Anshuman Khandual + +[ Upstream commit 9163f01130304fab1f74683d7d44632da7bda637 ] + +When using CONFIG_ARM64_SW_TTBR0_PAN, a task's thread_info::ttbr0 must be +the TTBR0_EL1 value used to run userspace. With 52-bit PAs, the PA must be +packed into the TTBR using phys_to_ttbr(), but we forget to do this in some +of the SW PAN code. Thus, if the value is installed into TTBR0_EL1 (as may +happen in the uaccess routines), this could result in UNPREDICTABLE +behaviour. + +Since hardware with 52-bit PA support almost certainly has HW PAN, which +will be used in preference, this shouldn't be a practical issue, but let's +fix this for consistency. + +Cc: Catalin Marinas +Cc: Will Deacon +Cc: Mark Rutland +Cc: James Morse +Cc: linux-arm-kernel@lists.infradead.org +Cc: linux-kernel@vger.kernel.org +Fixes: 529c4b05a3cb ("arm64: handle 52-bit addresses in TTBR") +Signed-off-by: Anshuman Khandual +Reviewed-by: Catalin Marinas +Link: https://lore.kernel.org/r/1623749578-11231-1-git-send-email-anshuman.khandual@arm.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + arch/arm64/include/asm/mmu_context.h | 4 ++-- + arch/arm64/kernel/setup.c | 2 +- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/arch/arm64/include/asm/mmu_context.h b/arch/arm64/include/asm/mmu_context.h +index 68028de06d18..5a54a5ab5f92 100644 +--- a/arch/arm64/include/asm/mmu_context.h ++++ b/arch/arm64/include/asm/mmu_context.h +@@ -192,9 +192,9 @@ static inline void update_saved_ttbr0(struct task_struct *tsk, + return; + + if (mm == &init_mm) +- ttbr = __pa_symbol(reserved_pg_dir); ++ ttbr = phys_to_ttbr(__pa_symbol(reserved_pg_dir)); + else +- ttbr = virt_to_phys(mm->pgd) | ASID(mm) << 48; ++ ttbr = phys_to_ttbr(virt_to_phys(mm->pgd)) | ASID(mm) << 48; + + WRITE_ONCE(task_thread_info(tsk)->ttbr0, ttbr); + } +diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c +index c28a9ec76b11..eb4b24652c10 100644 +--- a/arch/arm64/kernel/setup.c ++++ b/arch/arm64/kernel/setup.c +@@ -366,7 +366,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) + * faults in case uaccess_enable() is inadvertently called by the init + * thread. + */ +- init_task.thread_info.ttbr0 = __pa_symbol(reserved_pg_dir); ++ init_task.thread_info.ttbr0 = phys_to_ttbr(__pa_symbol(reserved_pg_dir)); + #endif + + if (boot_args[1] || boot_args[2] || boot_args[3]) { +-- +2.30.2 + diff --git a/queue-5.10/arm64-perf-convert-snprintf-to-sysfs_emit.patch b/queue-5.10/arm64-perf-convert-snprintf-to-sysfs_emit.patch new file mode 100644 index 00000000000..69e33ac3da5 --- /dev/null +++ b/queue-5.10/arm64-perf-convert-snprintf-to-sysfs_emit.patch @@ -0,0 +1,37 @@ +From 98f60b0a14dc84bc59d6f7fa5492107a13cfd93a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 20 May 2021 15:59:45 +0800 +Subject: arm64: perf: Convert snprintf to sysfs_emit + +From: Tian Tao + +[ Upstream commit a5740e955540181f4ab8f076cc9795c6bbe4d730 ] + +Use sysfs_emit instead of snprintf to avoid buf overrun,because in +sysfs_emit it strictly checks whether buf is null or buf whether +pagesize aligned, otherwise it returns an error. + +Signed-off-by: Tian Tao +Link: https://lore.kernel.org/r/1621497585-30887-1-git-send-email-tiantao6@hisilicon.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + arch/arm64/kernel/perf_event.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c +index 11852e05ee32..cdb3d4549b3a 100644 +--- a/arch/arm64/kernel/perf_event.c ++++ b/arch/arm64/kernel/perf_event.c +@@ -312,7 +312,7 @@ static ssize_t slots_show(struct device *dev, struct device_attribute *attr, + struct arm_pmu *cpu_pmu = container_of(pmu, struct arm_pmu, pmu); + u32 slots = cpu_pmu->reg_pmmir & ARMV8_PMU_SLOTS_MASK; + +- return snprintf(page, PAGE_SIZE, "0x%08x\n", slots); ++ return sysfs_emit(page, "0x%08x\n", slots); + } + + static DEVICE_ATTR_RO(slots); +-- +2.30.2 + diff --git a/queue-5.10/asoc-atmel-i2s-fix-usage-of-capture-and-playback-at-.patch b/queue-5.10/asoc-atmel-i2s-fix-usage-of-capture-and-playback-at-.patch new file mode 100644 index 00000000000..94f53203fb5 --- /dev/null +++ b/queue-5.10/asoc-atmel-i2s-fix-usage-of-capture-and-playback-at-.patch @@ -0,0 +1,100 @@ +From 0cea3133bf28b3f9ba79eea3d4ddc1cb225588fe Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 18:07:41 +0300 +Subject: ASoC: atmel-i2s: Fix usage of capture and playback at the same time + +From: Codrin Ciubotariu + +[ Upstream commit 3b7961a326f8a7e03f54a19f02fedae8d488b80f ] + +For both capture and playback streams to work at the same time, only the +needed values from a register need to be updated. Also, clocks should be +enabled only when the first stream is started and stopped when there is no +running stream. + +Fixes: b543e467d1a9 ("ASoC: atmel-i2s: add driver for the new Atmel I2S controller") +Signed-off-by: Codrin Ciubotariu +Link: https://lore.kernel.org/r/20210618150741.401739-2-codrin.ciubotariu@microchip.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/atmel/atmel-i2s.c | 34 ++++++++++++++++++++++++++-------- + 1 file changed, 26 insertions(+), 8 deletions(-) + +diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c +index bbe2b638abb5..d870f56c44cf 100644 +--- a/sound/soc/atmel/atmel-i2s.c ++++ b/sound/soc/atmel/atmel-i2s.c +@@ -200,6 +200,7 @@ struct atmel_i2s_dev { + unsigned int fmt; + const struct atmel_i2s_gck_param *gck_param; + const struct atmel_i2s_caps *caps; ++ int clk_use_no; + }; + + static irqreturn_t atmel_i2s_interrupt(int irq, void *dev_id) +@@ -321,9 +322,16 @@ static int atmel_i2s_hw_params(struct snd_pcm_substream *substream, + { + struct atmel_i2s_dev *dev = snd_soc_dai_get_drvdata(dai); + bool is_playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK); +- unsigned int mr = 0; ++ unsigned int mr = 0, mr_mask; + int ret; + ++ mr_mask = ATMEL_I2SC_MR_FORMAT_MASK | ATMEL_I2SC_MR_MODE_MASK | ++ ATMEL_I2SC_MR_DATALENGTH_MASK; ++ if (is_playback) ++ mr_mask |= ATMEL_I2SC_MR_TXMONO; ++ else ++ mr_mask |= ATMEL_I2SC_MR_RXMONO; ++ + switch (dev->fmt & SND_SOC_DAIFMT_FORMAT_MASK) { + case SND_SOC_DAIFMT_I2S: + mr |= ATMEL_I2SC_MR_FORMAT_I2S; +@@ -402,7 +410,7 @@ static int atmel_i2s_hw_params(struct snd_pcm_substream *substream, + return -EINVAL; + } + +- return regmap_write(dev->regmap, ATMEL_I2SC_MR, mr); ++ return regmap_update_bits(dev->regmap, ATMEL_I2SC_MR, mr_mask, mr); + } + + static int atmel_i2s_switch_mck_generator(struct atmel_i2s_dev *dev, +@@ -495,18 +503,28 @@ static int atmel_i2s_trigger(struct snd_pcm_substream *substream, int cmd, + is_master = (mr & ATMEL_I2SC_MR_MODE_MASK) == ATMEL_I2SC_MR_MODE_MASTER; + + /* If master starts, enable the audio clock. */ +- if (is_master && mck_enabled) +- err = atmel_i2s_switch_mck_generator(dev, true); +- if (err) +- return err; ++ if (is_master && mck_enabled) { ++ if (!dev->clk_use_no) { ++ err = atmel_i2s_switch_mck_generator(dev, true); ++ if (err) ++ return err; ++ } ++ dev->clk_use_no++; ++ } + + err = regmap_write(dev->regmap, ATMEL_I2SC_CR, cr); + if (err) + return err; + + /* If master stops, disable the audio clock. */ +- if (is_master && !mck_enabled) +- err = atmel_i2s_switch_mck_generator(dev, false); ++ if (is_master && !mck_enabled) { ++ if (dev->clk_use_no == 1) { ++ err = atmel_i2s_switch_mck_generator(dev, false); ++ if (err) ++ return err; ++ } ++ dev->clk_use_no--; ++ } + + return err; + } +-- +2.30.2 + diff --git a/queue-5.10/asoc-cs42l42-correct-definition-of-cs42l42_adc_pdn_m.patch b/queue-5.10/asoc-cs42l42-correct-definition-of-cs42l42_adc_pdn_m.patch new file mode 100644 index 00000000000..13e85a255d2 --- /dev/null +++ b/queue-5.10/asoc-cs42l42-correct-definition-of-cs42l42_adc_pdn_m.patch @@ -0,0 +1,37 @@ +From 2fd8b81673b46f6aec3e946d24b6ce8c1b5de05a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 14:56:04 +0100 +Subject: ASoC: cs42l42: Correct definition of CS42L42_ADC_PDN_MASK + +From: Richard Fitzgerald + +[ Upstream commit fac165f22ac947b55407cd3a60a2a9824f905235 ] + +The definition of CS42L42_ADC_PDN_MASK was incorrectly defined +as the HP_PDN bit. + +Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec") +Signed-off-by: Richard Fitzgerald +Link: https://lore.kernel.org/r/20210616135604.19363-1-rf@opensource.cirrus.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/cs42l42.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h +index 866d7c873e3c..ca2019732013 100644 +--- a/sound/soc/codecs/cs42l42.h ++++ b/sound/soc/codecs/cs42l42.h +@@ -77,7 +77,7 @@ + #define CS42L42_HP_PDN_SHIFT 3 + #define CS42L42_HP_PDN_MASK (1 << CS42L42_HP_PDN_SHIFT) + #define CS42L42_ADC_PDN_SHIFT 2 +-#define CS42L42_ADC_PDN_MASK (1 << CS42L42_HP_PDN_SHIFT) ++#define CS42L42_ADC_PDN_MASK (1 << CS42L42_ADC_PDN_SHIFT) + #define CS42L42_PDN_ALL_SHIFT 0 + #define CS42L42_PDN_ALL_MASK (1 << CS42L42_PDN_ALL_SHIFT) + +-- +2.30.2 + diff --git a/queue-5.10/asoc-fsl_spdif-fix-error-handler-with-pm_runtime_ena.patch b/queue-5.10/asoc-fsl_spdif-fix-error-handler-with-pm_runtime_ena.patch new file mode 100644 index 00000000000..5e1bcbc636e --- /dev/null +++ b/queue-5.10/asoc-fsl_spdif-fix-error-handler-with-pm_runtime_ena.patch @@ -0,0 +1,73 @@ +From e2f802bb5e703a75428184c7d25e9b2f35315bd0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 14:18:38 +0800 +Subject: ASoC: fsl_spdif: Fix error handler with pm_runtime_enable + +From: Shengjiu Wang + +[ Upstream commit 28108d71ee11a7232e1102effab3361049dcd3b8 ] + +There is error message when defer probe happens: + +fsl-spdif-dai 2dab0000.spdif: Unbalanced pm_runtime_enable! + +Fix the error handler with pm_runtime_enable and add +fsl_spdif_remove() for pm_runtime_disable. + +Fixes: 9cb2b3796e08 ("ASoC: fsl_spdif: Add pm runtime function") +Signed-off-by: Shengjiu Wang +Link: https://lore.kernel.org/r/1623392318-26304-1-git-send-email-shengjiu.wang@nxp.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/fsl/fsl_spdif.c | 20 +++++++++++++++++--- + 1 file changed, 17 insertions(+), 3 deletions(-) + +diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c +index b0f643fefe1e..1fbc6d780700 100644 +--- a/sound/soc/fsl/fsl_spdif.c ++++ b/sound/soc/fsl/fsl_spdif.c +@@ -1358,16 +1358,29 @@ static int fsl_spdif_probe(struct platform_device *pdev) + &spdif_priv->cpu_dai_drv, 1); + if (ret) { + dev_err(&pdev->dev, "failed to register DAI: %d\n", ret); +- return ret; ++ goto err_pm_disable; + } + + ret = imx_pcm_dma_init(pdev, IMX_SPDIF_DMABUF_SIZE); +- if (ret && ret != -EPROBE_DEFER) +- dev_err(&pdev->dev, "imx_pcm_dma_init failed: %d\n", ret); ++ if (ret) { ++ dev_err_probe(&pdev->dev, ret, "imx_pcm_dma_init failed\n"); ++ goto err_pm_disable; ++ } ++ ++ return ret; + ++err_pm_disable: ++ pm_runtime_disable(&pdev->dev); + return ret; + } + ++static int fsl_spdif_remove(struct platform_device *pdev) ++{ ++ pm_runtime_disable(&pdev->dev); ++ ++ return 0; ++} ++ + #ifdef CONFIG_PM + static int fsl_spdif_runtime_suspend(struct device *dev) + { +@@ -1469,6 +1482,7 @@ static struct platform_driver fsl_spdif_driver = { + .pm = &fsl_spdif_pm, + }, + .probe = fsl_spdif_probe, ++ .remove = fsl_spdif_remove, + }; + + module_platform_driver(fsl_spdif_driver); +-- +2.30.2 + diff --git a/queue-5.10/asoc-fsl_spdif-fix-unexpected-interrupt-after-suspen.patch b/queue-5.10/asoc-fsl_spdif-fix-unexpected-interrupt-after-suspen.patch new file mode 100644 index 00000000000..6d33c09f88a --- /dev/null +++ b/queue-5.10/asoc-fsl_spdif-fix-unexpected-interrupt-after-suspen.patch @@ -0,0 +1,49 @@ +From 075282e0471f167f546acfb46b0405c90807082f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 20:31:24 +0800 +Subject: ASoC: fsl_spdif: Fix unexpected interrupt after suspend + +From: Shengjiu Wang + +[ Upstream commit a7a0a2feb957e446b2bcf732f245ba04fc8b6314 ] + +When system enter suspend, the machine driver suspend callback +function will be called, then the cpu driver trigger callback +(SNDRV_PCM_TRIGGER_SUSPEND) be called, it would disable the +interrupt. + +But the machine driver suspend and cpu dai driver suspend order +maybe changed, the cpu dai driver's suspend callback is called before +machine driver's suppend callback, then the interrupt is not cleared +successfully in trigger callback. + +So need to clear interrupts in cpu dai driver's suspend callback +to avoid such issue. + +Fixes: 9cb2b3796e08 ("ASoC: fsl_spdif: Add pm runtime function") +Signed-off-by: Shengjiu Wang +Reviewed-by: Fabio Estevam +Link: https://lore.kernel.org/r/1624365084-7934-1-git-send-email-shengjiu.wang@nxp.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/fsl/fsl_spdif.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c +index 1fbc6d780700..15bcb0f38ec9 100644 +--- a/sound/soc/fsl/fsl_spdif.c ++++ b/sound/soc/fsl/fsl_spdif.c +@@ -1387,6 +1387,9 @@ static int fsl_spdif_runtime_suspend(struct device *dev) + struct fsl_spdif_priv *spdif_priv = dev_get_drvdata(dev); + int i; + ++ /* Disable all the interrupts */ ++ regmap_update_bits(spdif_priv->regmap, REG_SPDIF_SIE, 0xffffff, 0); ++ + regmap_read(spdif_priv->regmap, REG_SPDIF_SRPC, + &spdif_priv->regcache_srpc); + regcache_cache_only(spdif_priv->regmap, true); +-- +2.30.2 + diff --git a/queue-5.10/asoc-hisilicon-fix-missing-clk_disable_unprepare-on-.patch b/queue-5.10/asoc-hisilicon-fix-missing-clk_disable_unprepare-on-.patch new file mode 100644 index 00000000000..87990c90e9f --- /dev/null +++ b/queue-5.10/asoc-hisilicon-fix-missing-clk_disable_unprepare-on-.patch @@ -0,0 +1,64 @@ +From 7c067943b7b8a27f95d2b6bfd13791a46668f694 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 12:45:14 +0800 +Subject: ASoC: hisilicon: fix missing clk_disable_unprepare() on error in + hi6210_i2s_startup() + +From: Yang Yingliang + +[ Upstream commit 375904e3931955fcf0a847f029b2492a117efc43 ] + +After calling clk_prepare_enable(), clk_disable_unprepare() need +be called when calling clk_set_rate() failed. + +Fixes: 0bf750f4cbe1 ("ASoC: hisilicon: Add hi6210 i2s audio driver") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Link: https://lore.kernel.org/r/20210518044514.607010-1-yangyingliang@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/hisilicon/hi6210-i2s.c | 14 ++++++++------ + 1 file changed, 8 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/hisilicon/hi6210-i2s.c b/sound/soc/hisilicon/hi6210-i2s.c +index 907f5f1f7b44..ff05b9779e4b 100644 +--- a/sound/soc/hisilicon/hi6210-i2s.c ++++ b/sound/soc/hisilicon/hi6210-i2s.c +@@ -102,18 +102,15 @@ static int hi6210_i2s_startup(struct snd_pcm_substream *substream, + + for (n = 0; n < i2s->clocks; n++) { + ret = clk_prepare_enable(i2s->clk[n]); +- if (ret) { +- while (n--) +- clk_disable_unprepare(i2s->clk[n]); +- return ret; +- } ++ if (ret) ++ goto err_unprepare_clk; + } + + ret = clk_set_rate(i2s->clk[CLK_I2S_BASE], 49152000); + if (ret) { + dev_err(i2s->dev, "%s: setting 49.152MHz base rate failed %d\n", + __func__, ret); +- return ret; ++ goto err_unprepare_clk; + } + + /* enable clock before frequency division */ +@@ -165,6 +162,11 @@ static int hi6210_i2s_startup(struct snd_pcm_substream *substream, + hi6210_write_reg(i2s, HII2S_SW_RST_N, val); + + return 0; ++ ++err_unprepare_clk: ++ while (n--) ++ clk_disable_unprepare(i2s->clk[n]); ++ return ret; + } + + static void hi6210_i2s_shutdown(struct snd_pcm_substream *substream, +-- +2.30.2 + diff --git a/queue-5.10/asoc-intel-sof_sdw-add-quirk-support-for-brya-and-bt.patch b/queue-5.10/asoc-intel-sof_sdw-add-quirk-support-for-brya-and-bt.patch new file mode 100644 index 00000000000..df048bbbbe4 --- /dev/null +++ b/queue-5.10/asoc-intel-sof_sdw-add-quirk-support-for-brya-and-bt.patch @@ -0,0 +1,56 @@ +From 7ed74424ab4149a5ea69fdc57a797ee9df443149 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 18:56:32 +0300 +Subject: ASoC: Intel: sof_sdw: add quirk support for Brya and BT-offload + +From: Vamshi Krishna Gopal + +[ Upstream commit 03effde3a2ea1d82c4dd6b634fc6174545d2c34f ] + +Brya is another ADL-P product. + +AlderLake has support for Bluetooth audio offload capability. +Enable the BT-offload quirk for ADL-P Brya and the Intel RVP. + +Signed-off-by: Vamshi Krishna Gopal +Signed-off-by: Yong Zhi +Reviewed-by: Bard Liao +Reviewed-by: Ranjani Sridharan +Signed-off-by: Kai Vehmanen +Link: https://lore.kernel.org/r/20210521155632.3736393-2-kai.vehmanen@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/boards/sof_sdw.c | 16 +++++++++++++++- + 1 file changed, 15 insertions(+), 1 deletion(-) + +diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c +index 75a0bfedb449..f0a9aad4f385 100644 +--- a/sound/soc/intel/boards/sof_sdw.c ++++ b/sound/soc/intel/boards/sof_sdw.c +@@ -197,7 +197,21 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { + .driver_data = (void *)(SOF_RT711_JD_SRC_JD1 | + SOF_SDW_TGL_HDMI | + SOF_RT715_DAI_ID_FIX | +- SOF_SDW_PCH_DMIC), ++ SOF_SDW_PCH_DMIC | ++ SOF_BT_OFFLOAD_SSP(2) | ++ SOF_SSP_BT_OFFLOAD_PRESENT), ++ }, ++ { ++ .callback = sof_sdw_quirk_cb, ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "Google"), ++ DMI_MATCH(DMI_PRODUCT_NAME, "Brya"), ++ }, ++ .driver_data = (void *)(SOF_SDW_TGL_HDMI | ++ SOF_SDW_PCH_DMIC | ++ SOF_SDW_FOUR_SPK | ++ SOF_BT_OFFLOAD_SSP(2) | ++ SOF_SSP_BT_OFFLOAD_PRESENT), + }, + {} + }; +-- +2.30.2 + diff --git a/queue-5.10/asoc-intel-sof_sdw-add-sof_rt715_dai_id_fix-for-alde.patch b/queue-5.10/asoc-intel-sof_sdw-add-sof_rt715_dai_id_fix-for-alde.patch new file mode 100644 index 00000000000..e11728dd1e6 --- /dev/null +++ b/queue-5.10/asoc-intel-sof_sdw-add-sof_rt715_dai_id_fix-for-alde.patch @@ -0,0 +1,37 @@ +From ae921bc366954699b22b56f9a7e48515c6fd725b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 11:37:02 -0500 +Subject: ASoC: Intel: sof_sdw: add SOF_RT715_DAI_ID_FIX for AlderLake + +From: Libin Yang + +[ Upstream commit 81cd42e5174ba7918edd3d006406ce21ebaa8507 ] + +AlderLake needs the flag SOF_RT715_DAI_ID_FIX if it is using the +rt715 DMIC. + +Reviewed-by: Bard Liao +Signed-off-by: Libin Yang +Signed-off-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20210505163705.305616-11-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/boards/sof_sdw.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c +index 9dc982c2c776..75a0bfedb449 100644 +--- a/sound/soc/intel/boards/sof_sdw.c ++++ b/sound/soc/intel/boards/sof_sdw.c +@@ -196,6 +196,7 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { + }, + .driver_data = (void *)(SOF_RT711_JD_SRC_JD1 | + SOF_SDW_TGL_HDMI | ++ SOF_RT715_DAI_ID_FIX | + SOF_SDW_PCH_DMIC), + }, + {} +-- +2.30.2 + diff --git a/queue-5.10/asoc-intel-sof_sdw-use-mach-data-for-adl-rvp-dmic-co.patch b/queue-5.10/asoc-intel-sof_sdw-use-mach-data-for-adl-rvp-dmic-co.patch new file mode 100644 index 00000000000..1ef8c8a04f3 --- /dev/null +++ b/queue-5.10/asoc-intel-sof_sdw-use-mach-data-for-adl-rvp-dmic-co.patch @@ -0,0 +1,40 @@ +From 99c9d5a695ff84213937e137d5555abd01a0b63e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 14:40:48 -0500 +Subject: ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count + +From: Kai Vehmanen + +[ Upstream commit 505351329d26e684588a6919c0407b8a0f5c3813 ] + +On the reference boards, number of PCH dmics may vary and the number +should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC +quirk to make DMIC number configurable. + +Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp") + +BugLink: https://github.com/thesofproject/sof/issues/4185 +Signed-off-by: Kai Vehmanen +Signed-off-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20210621194057.21711-2-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/boards/sof_sdw.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c +index f0a9aad4f385..2a7b5de6da60 100644 +--- a/sound/soc/intel/boards/sof_sdw.c ++++ b/sound/soc/intel/boards/sof_sdw.c +@@ -197,7 +197,6 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { + .driver_data = (void *)(SOF_RT711_JD_SRC_JD1 | + SOF_SDW_TGL_HDMI | + SOF_RT715_DAI_ID_FIX | +- SOF_SDW_PCH_DMIC | + SOF_BT_OFFLOAD_SSP(2) | + SOF_SSP_BT_OFFLOAD_PRESENT), + }, +-- +2.30.2 + diff --git a/queue-5.10/asoc-max98373-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-max98373-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..1894c7f308b --- /dev/null +++ b/queue-5.10/asoc-max98373-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,106 @@ +From f3e1252049d7ea03dab0595bfde68d3db4daee5a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:26 -0500 +Subject: ASoC: max98373-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit bf881170311ea74ff30c3be0be8fb097132ce696 ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +This patch renames the status flag to 'first_hw_init' for consistency +with other drivers. + +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: 56a5b7910e96 ('ASoC: codecs: max98373: add SoundWire support') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-3-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/max98373-sdw.c | 12 ++++++------ + sound/soc/codecs/max98373.h | 2 +- + 2 files changed, 7 insertions(+), 7 deletions(-) + +diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c +index 14fd2f9a0bf3..39afa011f0e2 100644 +--- a/sound/soc/codecs/max98373-sdw.c ++++ b/sound/soc/codecs/max98373-sdw.c +@@ -258,7 +258,7 @@ static __maybe_unused int max98373_resume(struct device *dev) + struct max98373_priv *max98373 = dev_get_drvdata(dev); + unsigned long time; + +- if (!max98373->hw_init) ++ if (!max98373->first_hw_init) + return 0; + + if (!slave->unattach_request) +@@ -349,7 +349,7 @@ static int max98373_io_init(struct sdw_slave *slave) + struct device *dev = &slave->dev; + struct max98373_priv *max98373 = dev_get_drvdata(dev); + +- if (max98373->pm_init_once) { ++ if (max98373->first_hw_init) { + regcache_cache_only(max98373->regmap, false); + regcache_cache_bypass(max98373->regmap, true); + } +@@ -357,7 +357,7 @@ static int max98373_io_init(struct sdw_slave *slave) + /* + * PM runtime is only enabled when a Slave reports as Attached + */ +- if (!max98373->pm_init_once) { ++ if (!max98373->first_hw_init) { + /* set autosuspend parameters */ + pm_runtime_set_autosuspend_delay(dev, 3000); + pm_runtime_use_autosuspend(dev); +@@ -449,12 +449,12 @@ static int max98373_io_init(struct sdw_slave *slave) + regmap_write(max98373->regmap, MAX98373_R20B5_BDE_EN, 1); + regmap_write(max98373->regmap, MAX98373_R20E2_LIMITER_EN, 1); + +- if (max98373->pm_init_once) { ++ if (max98373->first_hw_init) { + regcache_cache_bypass(max98373->regmap, false); + regcache_mark_dirty(max98373->regmap); + } + +- max98373->pm_init_once = true; ++ max98373->first_hw_init = true; + max98373->hw_init = true; + + pm_runtime_mark_last_busy(dev); +@@ -773,7 +773,7 @@ static int max98373_init(struct sdw_slave *slave, struct regmap *regmap) + max98373_slot_config(dev, max98373); + + max98373->hw_init = false; +- max98373->pm_init_once = false; ++ max98373->first_hw_init = false; + + /* codec registration */ + ret = devm_snd_soc_register_component(dev, &soc_codec_dev_max98373_sdw, +diff --git a/sound/soc/codecs/max98373.h b/sound/soc/codecs/max98373.h +index 4ab29b9d51c7..010f6bb21e9a 100644 +--- a/sound/soc/codecs/max98373.h ++++ b/sound/soc/codecs/max98373.h +@@ -215,7 +215,7 @@ struct max98373_priv { + /* variables to support soundwire */ + struct sdw_slave *slave; + bool hw_init; +- bool pm_init_once; ++ bool first_hw_init; + int slot; + unsigned int rx_mask; + }; +-- +2.30.2 + diff --git a/queue-5.10/asoc-mediatek-mtk-btcvsd-fix-an-error-handling-path-.patch b/queue-5.10/asoc-mediatek-mtk-btcvsd-fix-an-error-handling-path-.patch new file mode 100644 index 00000000000..f9a6f00dc6b --- /dev/null +++ b/queue-5.10/asoc-mediatek-mtk-btcvsd-fix-an-error-handling-path-.patch @@ -0,0 +1,92 @@ +From a16f1d022114adfec996b5df11da07822deccbf0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 6 Jun 2021 16:31:09 +0200 +Subject: ASoC: mediatek: mtk-btcvsd: Fix an error handling path in + 'mtk_btcvsd_snd_probe()' + +From: Christophe JAILLET + +[ Upstream commit b6052c3c7a78f5e2b9756c92ef77c0b56435f107 ] + +If an error occurs after a successful 'of_iomap()' call, it must be undone +by a corresponding 'iounmap()' call, as already done in the remove +function. + +While at it, remove the useless initialization of 'ret' at the beginning of +the function. + +Fixes: 4bd8597dc36c ("ASoC: mediatek: add btcvsd driver") +Signed-off-by: Christophe JAILLET +Link: https://lore.kernel.org/r/0c2ba562c3364e61bfbd5b3013a99dfa0d9045d7.1622989685.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/mediatek/common/mtk-btcvsd.c | 24 ++++++++++++++++++------ + 1 file changed, 18 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/mediatek/common/mtk-btcvsd.c b/sound/soc/mediatek/common/mtk-btcvsd.c +index 668fef3e319a..86e982e3209e 100644 +--- a/sound/soc/mediatek/common/mtk-btcvsd.c ++++ b/sound/soc/mediatek/common/mtk-btcvsd.c +@@ -1281,7 +1281,7 @@ static const struct snd_soc_component_driver mtk_btcvsd_snd_platform = { + + static int mtk_btcvsd_snd_probe(struct platform_device *pdev) + { +- int ret = 0; ++ int ret; + int irq_id; + u32 offset[5] = {0, 0, 0, 0, 0}; + struct mtk_btcvsd_snd *btcvsd; +@@ -1337,7 +1337,8 @@ static int mtk_btcvsd_snd_probe(struct platform_device *pdev) + btcvsd->bt_sram_bank2_base = of_iomap(dev->of_node, 1); + if (!btcvsd->bt_sram_bank2_base) { + dev_err(dev, "iomap bt_sram_bank2_base fail\n"); +- return -EIO; ++ ret = -EIO; ++ goto unmap_pkv_err; + } + + btcvsd->infra = syscon_regmap_lookup_by_phandle(dev->of_node, +@@ -1345,7 +1346,8 @@ static int mtk_btcvsd_snd_probe(struct platform_device *pdev) + if (IS_ERR(btcvsd->infra)) { + dev_err(dev, "cannot find infra controller: %ld\n", + PTR_ERR(btcvsd->infra)); +- return PTR_ERR(btcvsd->infra); ++ ret = PTR_ERR(btcvsd->infra); ++ goto unmap_bank2_err; + } + + /* get offset */ +@@ -1354,7 +1356,7 @@ static int mtk_btcvsd_snd_probe(struct platform_device *pdev) + ARRAY_SIZE(offset)); + if (ret) { + dev_warn(dev, "%s(), get offset fail, ret %d\n", __func__, ret); +- return ret; ++ goto unmap_bank2_err; + } + btcvsd->infra_misc_offset = offset[0]; + btcvsd->conn_bt_cvsd_mask = offset[1]; +@@ -1373,8 +1375,18 @@ static int mtk_btcvsd_snd_probe(struct platform_device *pdev) + mtk_btcvsd_snd_set_state(btcvsd, btcvsd->tx, BT_SCO_STATE_IDLE); + mtk_btcvsd_snd_set_state(btcvsd, btcvsd->rx, BT_SCO_STATE_IDLE); + +- return devm_snd_soc_register_component(dev, &mtk_btcvsd_snd_platform, +- NULL, 0); ++ ret = devm_snd_soc_register_component(dev, &mtk_btcvsd_snd_platform, ++ NULL, 0); ++ if (ret) ++ goto unmap_bank2_err; ++ ++ return 0; ++ ++unmap_bank2_err: ++ iounmap(btcvsd->bt_sram_bank2_base); ++unmap_pkv_err: ++ iounmap(btcvsd->bt_pkv_base); ++ return ret; + } + + static int mtk_btcvsd_snd_remove(struct platform_device *pdev) +-- +2.30.2 + diff --git a/queue-5.10/asoc-rk3328-fix-missing-clk_disable_unprepare-on-err.patch b/queue-5.10/asoc-rk3328-fix-missing-clk_disable_unprepare-on-err.patch new file mode 100644 index 00000000000..5943b450829 --- /dev/null +++ b/queue-5.10/asoc-rk3328-fix-missing-clk_disable_unprepare-on-err.patch @@ -0,0 +1,80 @@ +From a32afbf903854ce2621578fe2fcc60f8d708e7a2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 15:58:47 +0800 +Subject: ASoC: rk3328: fix missing clk_disable_unprepare() on error in + rk3328_platform_probe() + +From: Yang Yingliang + +[ Upstream commit d14eece945a8068a017995f7512ea2beac21e34b ] + +Fix the missing clk_disable_unprepare() before return +from rk3328_platform_probe() in the error handling case. + +Fixes: c32759035ad2 ("ASoC: rockchip: support ACODEC for rk3328") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Link: https://lore.kernel.org/r/20210518075847.1116983-1-yangyingliang@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rk3328_codec.c | 28 ++++++++++++++++++++++------ + 1 file changed, 22 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/codecs/rk3328_codec.c b/sound/soc/codecs/rk3328_codec.c +index 940a2fa933ed..aed18cbb9f68 100644 +--- a/sound/soc/codecs/rk3328_codec.c ++++ b/sound/soc/codecs/rk3328_codec.c +@@ -474,7 +474,8 @@ static int rk3328_platform_probe(struct platform_device *pdev) + rk3328->pclk = devm_clk_get(&pdev->dev, "pclk"); + if (IS_ERR(rk3328->pclk)) { + dev_err(&pdev->dev, "can't get acodec pclk\n"); +- return PTR_ERR(rk3328->pclk); ++ ret = PTR_ERR(rk3328->pclk); ++ goto err_unprepare_mclk; + } + + ret = clk_prepare_enable(rk3328->pclk); +@@ -484,19 +485,34 @@ static int rk3328_platform_probe(struct platform_device *pdev) + } + + base = devm_platform_ioremap_resource(pdev, 0); +- if (IS_ERR(base)) +- return PTR_ERR(base); ++ if (IS_ERR(base)) { ++ ret = PTR_ERR(base); ++ goto err_unprepare_pclk; ++ } + + rk3328->regmap = devm_regmap_init_mmio(&pdev->dev, base, + &rk3328_codec_regmap_config); +- if (IS_ERR(rk3328->regmap)) +- return PTR_ERR(rk3328->regmap); ++ if (IS_ERR(rk3328->regmap)) { ++ ret = PTR_ERR(rk3328->regmap); ++ goto err_unprepare_pclk; ++ } + + platform_set_drvdata(pdev, rk3328); + +- return devm_snd_soc_register_component(&pdev->dev, &soc_codec_rk3328, ++ ret = devm_snd_soc_register_component(&pdev->dev, &soc_codec_rk3328, + rk3328_dai, + ARRAY_SIZE(rk3328_dai)); ++ if (ret) ++ goto err_unprepare_pclk; ++ ++ return 0; ++ ++err_unprepare_pclk: ++ clk_disable_unprepare(rk3328->pclk); ++ ++err_unprepare_mclk: ++ clk_disable_unprepare(rk3328->mclk); ++ return ret; + } + + static const struct of_device_id rk3328_codec_of_match[] = { +-- +2.30.2 + diff --git a/queue-5.10/asoc-rsnd-tidyup-loop-on-rsnd_adg_clk_query.patch b/queue-5.10/asoc-rsnd-tidyup-loop-on-rsnd_adg_clk_query.patch new file mode 100644 index 00000000000..b5c05ced7b6 --- /dev/null +++ b/queue-5.10/asoc-rsnd-tidyup-loop-on-rsnd_adg_clk_query.patch @@ -0,0 +1,49 @@ +From fa2d5dbc32e92bd7f2b1aa81e97932fe6d42f107 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 24 May 2021 15:12:09 +0900 +Subject: ASoC: rsnd: tidyup loop on rsnd_adg_clk_query() + +From: Kuninori Morimoto + +[ Upstream commit cf9d5c6619fadfc41cf8f5154cb990cc38e3da85 ] + +commit 06e8f5c842f2d ("ASoC: rsnd: don't call clk_get_rate() under +atomic context") used saved clk_rate, thus for_each_rsnd_clk() +is no longer needed. This patch fixes it. + +Fixes: 06e8f5c842f2d ("ASoC: rsnd: don't call clk_get_rate() under atomic context") +Signed-off-by: Kuninori Morimoto +Link: https://lore.kernel.org/r/87v978oe2u.wl-kuninori.morimoto.gx@renesas.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sh/rcar/adg.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c +index b9aacf3d3b29..7532ab27a48d 100644 +--- a/sound/soc/sh/rcar/adg.c ++++ b/sound/soc/sh/rcar/adg.c +@@ -289,7 +289,6 @@ static void rsnd_adg_set_ssi_clk(struct rsnd_mod *ssi_mod, u32 val) + int rsnd_adg_clk_query(struct rsnd_priv *priv, unsigned int rate) + { + struct rsnd_adg *adg = rsnd_priv_to_adg(priv); +- struct clk *clk; + int i; + int sel_table[] = { + [CLKA] = 0x1, +@@ -302,10 +301,9 @@ int rsnd_adg_clk_query(struct rsnd_priv *priv, unsigned int rate) + * find suitable clock from + * AUDIO_CLKA/AUDIO_CLKB/AUDIO_CLKC/AUDIO_CLKI. + */ +- for_each_rsnd_clk(clk, adg, i) { ++ for (i = 0; i < CLKMAX; i++) + if (rate == adg->clk_rate[i]) + return sel_table[i]; +- } + + /* + * find divided clock from BRGA/BRGB +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt1308-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-rt1308-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..d804edb93b2 --- /dev/null +++ b/queue-5.10/asoc-rt1308-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,48 @@ +From 85d100eb85ee65b3c954517cd546fd3350bd49f8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:27 -0500 +Subject: ASoC: rt1308-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit 30e102dab5fad1db71684f8ac5e1ac74e49da06d ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +BugLink: https://github.com/thesofproject/linux/issues/2908 +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: a87a6653a28c0 ('ASoC: rt1308-sdw: add rt1308 SdW amplifier driver') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-4-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt1308-sdw.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c +index c2621b0afe6c..31daa749c3db 100644 +--- a/sound/soc/codecs/rt1308-sdw.c ++++ b/sound/soc/codecs/rt1308-sdw.c +@@ -709,7 +709,7 @@ static int __maybe_unused rt1308_dev_resume(struct device *dev) + struct rt1308_sdw_priv *rt1308 = dev_get_drvdata(dev); + unsigned long time; + +- if (!rt1308->hw_init) ++ if (!rt1308->first_hw_init) + return 0; + + if (!slave->unattach_request) +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt5682-disable-irq-on-shutdown.patch b/queue-5.10/asoc-rt5682-disable-irq-on-shutdown.patch new file mode 100644 index 00000000000..f39b7f1663b --- /dev/null +++ b/queue-5.10/asoc-rt5682-disable-irq-on-shutdown.patch @@ -0,0 +1,45 @@ +From 28f1b4255121eca797b450fbe6e8e16b49ccc160 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 00:51:50 -0700 +Subject: ASoC: rt5682: Disable irq on shutdown + +From: Stephen Boyd + +[ Upstream commit 47bcb1c7108363418cd578283333d72e310dfeaa ] + +We cancel the work queues, and reset the device on shutdown, but the irq +isn't disabled so the work queues could be queued again. Let's disable +the irq during shutdown so that we don't have to worry about this device +trying to do anything anymore. This fixes a problem seen where the i2c +bus is shutdown at reboot but this device irq still comes in and tries +to make another i2c transaction when the bus doesn't work. + +Cc: Jairaj Arava +Cc: Sathyanarayana Nujella +Cc: Pierre-Louis Bossart +Cc: Shuming Fan +Cc: Ranjani Sridharan +Fixes: 45a2702ce109 ("ASoC: rt5682: Fix panic in rt5682_jack_detect_handler happening during system shutdown") +Signed-off-by: Stephen Boyd +Link: https://lore.kernel.org/r/20210508075151.1626903-1-swboyd@chromium.org +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt5682-i2c.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c +index 7e652843c57d..547445d1e3c6 100644 +--- a/sound/soc/codecs/rt5682-i2c.c ++++ b/sound/soc/codecs/rt5682-i2c.c +@@ -268,6 +268,7 @@ static void rt5682_i2c_shutdown(struct i2c_client *client) + { + struct rt5682_priv *rt5682 = i2c_get_clientdata(client); + ++ disable_irq(client->irq); + cancel_delayed_work_sync(&rt5682->jack_detect_work); + cancel_delayed_work_sync(&rt5682->jd_check_work); + +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt5682-fix-getting-the-wrong-device-id-when-the.patch b/queue-5.10/asoc-rt5682-fix-getting-the-wrong-device-id-when-the.patch new file mode 100644 index 00000000000..00cce469028 --- /dev/null +++ b/queue-5.10/asoc-rt5682-fix-getting-the-wrong-device-id-when-the.patch @@ -0,0 +1,70 @@ +From c609e88efb0aa91efda4f412722e93aa16cb62ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 11 Jan 2021 17:27:40 +0800 +Subject: ASoC: rt5682: fix getting the wrong device id when the + suspend_stress_test + +From: Shuming Fan + +[ Upstream commit 867f8d18df4f5ccd6c2daf4441a6adeca0b9725b ] + +This patch will be the workaround to fix getting the wrong device ID on the rare chance. +It seems like something unstable when the system resumes. e.g. the bus clock +This patch tries to read the device ID to check several times. +After the test, the driver will get the correct device ID the second time. + +Signed-off-by: Shuming Fan +Link: https://lore.kernel.org/r/20210111092740.9128-1-shumingf@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt5682-sdw.c | 21 ++++++++++++++------- + 1 file changed, 14 insertions(+), 7 deletions(-) + +diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c +index 848b79b5a130..5f8867e00923 100644 +--- a/sound/soc/codecs/rt5682-sdw.c ++++ b/sound/soc/codecs/rt5682-sdw.c +@@ -375,18 +375,12 @@ static int rt5682_sdw_init(struct device *dev, struct regmap *regmap, + static int rt5682_io_init(struct device *dev, struct sdw_slave *slave) + { + struct rt5682_priv *rt5682 = dev_get_drvdata(dev); +- int ret = 0; ++ int ret = 0, loop = 10; + unsigned int val; + + if (rt5682->hw_init) + return 0; + +- regmap_read(rt5682->regmap, RT5682_DEVICE_ID, &val); +- if (val != DEVICE_ID) { +- dev_err(dev, "Device with ID register %x is not rt5682\n", val); +- return -ENODEV; +- } +- + /* + * PM runtime is only enabled when a Slave reports as Attached + */ +@@ -406,6 +400,19 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave) + + pm_runtime_get_noresume(&slave->dev); + ++ while (loop > 0) { ++ regmap_read(rt5682->regmap, RT5682_DEVICE_ID, &val); ++ if (val == DEVICE_ID) ++ break; ++ dev_warn(dev, "Device with ID register %x is not rt5682\n", val); ++ usleep_range(30000, 30005); ++ loop--; ++ } ++ if (val != DEVICE_ID) { ++ dev_err(dev, "Device with ID register %x is not rt5682\n", val); ++ return -ENODEV; ++ } ++ + if (rt5682->first_hw_init) { + regcache_cache_only(rt5682->regmap, false); + regcache_cache_bypass(rt5682->regmap, true); +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt5682-sdw-set-regcache_cache_only-false-before.patch b/queue-5.10/asoc-rt5682-sdw-set-regcache_cache_only-false-before.patch new file mode 100644 index 00000000000..396d2fe1e38 --- /dev/null +++ b/queue-5.10/asoc-rt5682-sdw-set-regcache_cache_only-false-before.patch @@ -0,0 +1,54 @@ +From 8d7965e02b16e3a01807bd52405c48b19e39ed09 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:37 -0500 +Subject: ASoC: rt5682-sdw: set regcache_cache_only false before reading + RT5682_DEVICE_ID + +From: Bard Liao + +[ Upstream commit c0372bc873dd29f325ee908351e0bd5b08d4d608 ] + +RT5682_DEVICE_ID is a volatile register, we can not read it in cache +only mode. + +Fixes: 03f6fc6de919 ("ASoC: rt5682: Add the soundwire support") +Signed-off-by: Bard Liao +Signed-off-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20210607222239.582139-14-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt5682-sdw.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c +index 5f8867e00923..c9868dd096fc 100644 +--- a/sound/soc/codecs/rt5682-sdw.c ++++ b/sound/soc/codecs/rt5682-sdw.c +@@ -400,6 +400,11 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave) + + pm_runtime_get_noresume(&slave->dev); + ++ if (rt5682->first_hw_init) { ++ regcache_cache_only(rt5682->regmap, false); ++ regcache_cache_bypass(rt5682->regmap, true); ++ } ++ + while (loop > 0) { + regmap_read(rt5682->regmap, RT5682_DEVICE_ID, &val); + if (val == DEVICE_ID) +@@ -413,11 +418,6 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave) + return -ENODEV; + } + +- if (rt5682->first_hw_init) { +- regcache_cache_only(rt5682->regmap, false); +- regcache_cache_bypass(rt5682->regmap, true); +- } +- + rt5682_calibrate(rt5682); + + if (rt5682->first_hw_init) { +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt5682-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-rt5682-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..d47410497b9 --- /dev/null +++ b/queue-5.10/asoc-rt5682-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,48 @@ +From 56e0c26baf1c0075262e056c0a589277aae01a7b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:29 -0500 +Subject: ASoC: rt5682-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit 5361a42114689f875a9748299cadb4b1adbee6f4 ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +BugLink: https://github.com/thesofproject/linux/issues/2908 +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: 03f6fc6de9192 ('ASoC: rt5682: Add the soundwire support') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-6-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt5682-sdw.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c +index aa6c325faeab..848b79b5a130 100644 +--- a/sound/soc/codecs/rt5682-sdw.c ++++ b/sound/soc/codecs/rt5682-sdw.c +@@ -734,7 +734,7 @@ static int __maybe_unused rt5682_dev_resume(struct device *dev) + struct rt5682_priv *rt5682 = dev_get_drvdata(dev); + unsigned long time; + +- if (!rt5682->hw_init) ++ if (!rt5682->first_hw_init) + return 0; + + if (!slave->unattach_request) +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt700-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-rt700-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..7ec634191b5 --- /dev/null +++ b/queue-5.10/asoc-rt700-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,48 @@ +From fa0e01a6eac415f0148aa887bfc904b8879a1da9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:30 -0500 +Subject: ASoC: rt700-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit a9e54e5fbe396b546771cf77b43ce7c75e212278 ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +BugLink: https://github.com/thesofproject/linux/issues/2908 +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: 7d2a5f9ae41e3 ('ASoC: rt700: add rt700 codec driver') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-7-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt700-sdw.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt700-sdw.c b/sound/soc/codecs/rt700-sdw.c +index fb77e77a4ebd..3a1db79030d7 100644 +--- a/sound/soc/codecs/rt700-sdw.c ++++ b/sound/soc/codecs/rt700-sdw.c +@@ -498,7 +498,7 @@ static int __maybe_unused rt700_dev_resume(struct device *dev) + struct rt700_priv *rt700 = dev_get_drvdata(dev); + unsigned long time; + +- if (!rt700->hw_init) ++ if (!rt700->first_hw_init) + return 0; + + if (!slave->unattach_request) +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt711-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-rt711-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..d82f8e16097 --- /dev/null +++ b/queue-5.10/asoc-rt711-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,48 @@ +From 4b76e34c9506355c5f8106f2882c79fa9714d82c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:32 -0500 +Subject: ASoC: rt711-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit a0897ebca669f09a2e02206a9c48a738af655329 ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +BugLink: https://github.com/thesofproject/linux/issues/2908 +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: 320b8b0d13b81 ('ASoC: rt711: add rt711 codec driver') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-9-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt711-sdw.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c +index f0a0691bd31c..eb54e90c1c60 100644 +--- a/sound/soc/codecs/rt711-sdw.c ++++ b/sound/soc/codecs/rt711-sdw.c +@@ -500,7 +500,7 @@ static int __maybe_unused rt711_dev_resume(struct device *dev) + struct rt711_priv *rt711 = dev_get_drvdata(dev); + unsigned long time; + +- if (!rt711->hw_init) ++ if (!rt711->first_hw_init) + return 0; + + if (!slave->unattach_request) +-- +2.30.2 + diff --git a/queue-5.10/asoc-rt715-sdw-use-first_hw_init-flag-on-resume.patch b/queue-5.10/asoc-rt715-sdw-use-first_hw_init-flag-on-resume.patch new file mode 100644 index 00000000000..8da5c7c8f70 --- /dev/null +++ b/queue-5.10/asoc-rt715-sdw-use-first_hw_init-flag-on-resume.patch @@ -0,0 +1,48 @@ +From 921e12a177dd4075febf2fe8eb7aaea8dc18b47b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 17:22:34 -0500 +Subject: ASoC: rt715-sdw: use first_hw_init flag on resume + +From: Pierre-Louis Bossart + +[ Upstream commit dbc07517ab173688ef11234d1099bc1e24e4f14b ] + +The intent of the status check on resume was to verify if a SoundWire +peripheral reported ATTACHED before waiting for the initialization to +complete. This is required to avoid timeouts that will happen with +'ghost' devices that are exposed in the platform firmware but are not +populated in hardware. + +Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to +another error, the resume operation never timed out, but the volume +settings were not properly restored. + +BugLink: https://github.com/thesofproject/linux/issues/2908 +BugLink: https://github.com/thesofproject/linux/issues/2637 +Fixes: d1ede0641b05e ('ASoC: rt715: add RT715 codec driver') +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Guennadi Liakhovetski +Reviewed-by: Bard Liao +Link: https://lore.kernel.org/r/20210607222239.582139-11-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt715-sdw.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c +index 8f0aa1e8a273..361a90ae594c 100644 +--- a/sound/soc/codecs/rt715-sdw.c ++++ b/sound/soc/codecs/rt715-sdw.c +@@ -541,7 +541,7 @@ static int __maybe_unused rt715_dev_resume(struct device *dev) + struct rt715_priv *rt715 = dev_get_drvdata(dev); + unsigned long time; + +- if (!rt715->hw_init) ++ if (!rt715->first_hw_init) + return 0; + + if (!slave->unattach_request) +-- +2.30.2 + diff --git a/queue-5.10/ath10k-add-missing-error-return-code-in-ath10k_pci_p.patch b/queue-5.10/ath10k-add-missing-error-return-code-in-ath10k_pci_p.patch new file mode 100644 index 00000000000..dbe7df2f27b --- /dev/null +++ b/queue-5.10/ath10k-add-missing-error-return-code-in-ath10k_pci_p.patch @@ -0,0 +1,64 @@ +From 90d5e28c5cd8fb9b955e16008b1c98000430f00f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 17:41:28 +0300 +Subject: ath10k: add missing error return code in ath10k_pci_probe() + +From: Yang Yingliang + +[ Upstream commit e2783e2f39ba99178dedfc1646d5cc0979d1bab3 ] + +When chip_id is not supported, the resources will be freed +on path err_unsupported, these resources will also be freed +when calling ath10k_pci_remove(), it will cause double free, +so return -ENODEV when it doesn't support the device with wrong +chip_id. + +Fixes: c0c378f9907c ("ath10k: remove target soc ps code") +Fixes: 7505f7c3ec1d ("ath10k: create a chip revision whitelist") +Fixes: f8914a14623a ("ath10k: restore QCA9880-AR1A (v1) detection") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210522105822.1091848-3-yangyingliang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/pci.c | 12 +++++++++--- + 1 file changed, 9 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c +index 55f483d22b6d..86f52bcb3e4d 100644 +--- a/drivers/net/wireless/ath/ath10k/pci.c ++++ b/drivers/net/wireless/ath/ath10k/pci.c +@@ -3684,8 +3684,10 @@ static int ath10k_pci_probe(struct pci_dev *pdev, + ath10k_pci_soc_read32(ar, SOC_CHIP_ID_ADDRESS); + if (bus_params.chip_id != 0xffffffff) { + if (!ath10k_pci_chip_is_supported(pdev->device, +- bus_params.chip_id)) ++ bus_params.chip_id)) { ++ ret = -ENODEV; + goto err_unsupported; ++ } + } + } + +@@ -3696,11 +3698,15 @@ static int ath10k_pci_probe(struct pci_dev *pdev, + } + + bus_params.chip_id = ath10k_pci_soc_read32(ar, SOC_CHIP_ID_ADDRESS); +- if (bus_params.chip_id == 0xffffffff) ++ if (bus_params.chip_id == 0xffffffff) { ++ ret = -ENODEV; + goto err_unsupported; ++ } + +- if (!ath10k_pci_chip_is_supported(pdev->device, bus_params.chip_id)) ++ if (!ath10k_pci_chip_is_supported(pdev->device, bus_params.chip_id)) { ++ ret = -ENODEV; + goto err_unsupported; ++ } + + ret = ath10k_core_register(ar, &bus_params); + if (ret) { +-- +2.30.2 + diff --git a/queue-5.10/ath10k-fix-an-error-code-in-ath10k_add_interface.patch b/queue-5.10/ath10k-fix-an-error-code-in-ath10k_add_interface.patch new file mode 100644 index 00000000000..59c777fee87 --- /dev/null +++ b/queue-5.10/ath10k-fix-an-error-code-in-ath10k_add_interface.patch @@ -0,0 +1,43 @@ +From f392bb77b82cf0f3b7b1cbf34601a4c00768aac8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 18:46:17 +0800 +Subject: ath10k: Fix an error code in ath10k_add_interface() + +From: Yang Li + +[ Upstream commit e9ca70c735ce66fc6a0e02c8b6958434f74ef8de ] + +When the code execute this if statement, the value of ret is 0. +However, we can see from the ath10k_warn() log that the value of +ret should be -EINVAL. + +Clean up smatch warning: + +drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: +missing error code 'ret' + +Reported-by: Abaci Robot +Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine") +Signed-off-by: Yang Li +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/mac.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c +index f5c0f9bac840..36183fdfb7f0 100644 +--- a/drivers/net/wireless/ath/ath10k/mac.c ++++ b/drivers/net/wireless/ath/ath10k/mac.c +@@ -5482,6 +5482,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, + + if (arvif->nohwcrypt && + !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { ++ ret = -EINVAL; + ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); + goto err; + } +-- +2.30.2 + diff --git a/queue-5.10/ath10k-go-to-path-err_unsupported-when-chip-id-is-no.patch b/queue-5.10/ath10k-go-to-path-err_unsupported-when-chip-id-is-no.patch new file mode 100644 index 00000000000..8c4ceaa653f --- /dev/null +++ b/queue-5.10/ath10k-go-to-path-err_unsupported-when-chip-id-is-no.patch @@ -0,0 +1,37 @@ +From 45b65b51bf136b5597f398ed54eb98d00e3200bb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 17:41:28 +0300 +Subject: ath10k: go to path err_unsupported when chip id is not supported + +From: Yang Yingliang + +[ Upstream commit 9e88dd431d2345acdb7a549f3e88aaf4c2a307a1 ] + +When chip id is not supported, it go to path err_unsupported +to print the error message. + +Fixes: f8914a14623a ("ath10k: restore QCA9880-AR1A (v1) detection") +Signed-off-by: Yang Yingliang +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210522105822.1091848-2-yangyingliang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/pci.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c +index 36426efdb2ea..55f483d22b6d 100644 +--- a/drivers/net/wireless/ath/ath10k/pci.c ++++ b/drivers/net/wireless/ath/ath10k/pci.c +@@ -3700,7 +3700,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev, + goto err_unsupported; + + if (!ath10k_pci_chip_is_supported(pdev->device, bus_params.chip_id)) +- goto err_free_irq; ++ goto err_unsupported; + + ret = ath10k_core_register(ar, &bus_params); + if (ret) { +-- +2.30.2 + diff --git a/queue-5.10/ath11k-fix-an-error-handling-path-in-ath11k_core_fet.patch b/queue-5.10/ath11k-fix-an-error-handling-path-in-ath11k_core_fet.patch new file mode 100644 index 00000000000..727c3550b35 --- /dev/null +++ b/queue-5.10/ath11k-fix-an-error-handling-path-in-ath11k_core_fet.patch @@ -0,0 +1,40 @@ +From ed9efa8769a9efe90308cc1978e998d724865009 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 22 May 2021 11:50:54 +0200 +Subject: ath11k: Fix an error handling path in + ath11k_core_fetch_board_data_api_n() + +From: Christophe JAILLET + +[ Upstream commit 515bda1d1e51c64edf2a384a58801f85a80a3f2d ] + +All error paths but this one 'goto err' in order to release some +resources. +Fix this. + +Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") +Signed-off-by: Christophe JAILLET +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath11k/core.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c +index a68fe3a45a74..28de2c7ae899 100644 +--- a/drivers/net/wireless/ath/ath11k/core.c ++++ b/drivers/net/wireless/ath/ath11k/core.c +@@ -329,7 +329,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab, + if (len < ALIGN(ie_len, 4)) { + ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n", + ie_id, ie_len, len); +- return -EINVAL; ++ ret = -EINVAL; ++ goto err; + } + + switch (ie_id) { +-- +2.30.2 + diff --git a/queue-5.10/ath11k-send-beacon-template-after-vdev_start-restart.patch b/queue-5.10/ath11k-send-beacon-template-after-vdev_start-restart.patch new file mode 100644 index 00000000000..481e3685fc3 --- /dev/null +++ b/queue-5.10/ath11k-send-beacon-template-after-vdev_start-restart.patch @@ -0,0 +1,63 @@ +From af43b5ccb60bf7edde0d9f2a83506fdb8462fe57 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 15:30:28 +0200 +Subject: ath11k: send beacon template after vdev_start/restart during csa + +From: Seevalamuthu Mariappan + +[ Upstream commit 979ebc54cf13bd1e3eb6e21766d208d5de984fb8 ] + +Firmware has added assert if beacon template is received after +vdev_down. Firmware expects beacon template after vdev_start +and before vdev_up. This change is needed to support MBSSID EMA +cases in firmware. + +Hence, Change the sequence in ath11k as expected from firmware. +This new change is not causing any issues with older +firmware. + +Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1.r3-00011-QCAHKSWPL_SILICONZ-1 +Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1.r4-00008-QCAHKSWPL_SILICONZ-1 + +Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") +Signed-off-by: Seevalamuthu Mariappan +[sven@narfation.org: added tested-on/fixes information] +Signed-off-by: Sven Eckelmann +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210525133028.2805615-1-sven@narfation.org +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath11k/mac.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c +index 0738c784616f..cc0c30ceaa0d 100644 +--- a/drivers/net/wireless/ath/ath11k/mac.c ++++ b/drivers/net/wireless/ath/ath11k/mac.c +@@ -5123,11 +5123,6 @@ ath11k_mac_update_vif_chan(struct ath11k *ar, + if (WARN_ON(!arvif->is_up)) + continue; + +- ret = ath11k_mac_setup_bcn_tmpl(arvif); +- if (ret) +- ath11k_warn(ab, "failed to update bcn tmpl during csa: %d\n", +- ret); +- + ret = ath11k_mac_vdev_restart(arvif, &vifs[i].new_ctx->def); + if (ret) { + ath11k_warn(ab, "failed to restart vdev %d: %d\n", +@@ -5135,6 +5130,11 @@ ath11k_mac_update_vif_chan(struct ath11k *ar, + continue; + } + ++ ret = ath11k_mac_setup_bcn_tmpl(arvif); ++ if (ret) ++ ath11k_warn(ab, "failed to update bcn tmpl during csa: %d\n", ++ ret); ++ + ret = ath11k_wmi_vdev_up(arvif->ar, arvif->vdev_id, arvif->aid, + arvif->bssid); + if (ret) { +-- +2.30.2 + diff --git a/queue-5.10/backlight-lm3630a_bl-put-fwnode-in-error-case-during.patch b/queue-5.10/backlight-lm3630a_bl-put-fwnode-in-error-case-during.patch new file mode 100644 index 00000000000..b18109a53e7 --- /dev/null +++ b/queue-5.10/backlight-lm3630a_bl-put-fwnode-in-error-case-during.patch @@ -0,0 +1,43 @@ +From bd428148c72525c2038dd71df8f7f9e72c318414 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:57:16 +0300 +Subject: backlight: lm3630a_bl: Put fwnode in error case during ->probe() + +From: Andy Shevchenko + +[ Upstream commit 6d1c32dbedd7d7e7372aa38033ec8782c39f6379 ] + +device_for_each_child_node() bumps a reference counting of a returned variable. +We have to balance it whenever we return to the caller. + +Cc: Brian Masney +Cc: Dan Murphy +Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") +Signed-off-by: Andy Shevchenko +Reviewed-by: Brian Masney +Reviewed-by: Daniel Thompson +Signed-off-by: Lee Jones +Signed-off-by: Sasha Levin +--- + drivers/video/backlight/lm3630a_bl.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c +index e88a2b0e5904..662029d6a3dc 100644 +--- a/drivers/video/backlight/lm3630a_bl.c ++++ b/drivers/video/backlight/lm3630a_bl.c +@@ -482,8 +482,10 @@ static int lm3630a_parse_node(struct lm3630a_chip *pchip, + + device_for_each_child_node(pchip->dev, node) { + ret = lm3630a_parse_bank(pdata, node, &seen_led_sources); +- if (ret) ++ if (ret) { ++ fwnode_handle_put(node); + return ret; ++ } + } + + return ret; +-- +2.30.2 + diff --git a/queue-5.10/blk-mq-clear-stale-request-in-tags-rq-before-freeing.patch b/queue-5.10/blk-mq-clear-stale-request-in-tags-rq-before-freeing.patch new file mode 100644 index 00000000000..a8c9c17ef03 --- /dev/null +++ b/queue-5.10/blk-mq-clear-stale-request-in-tags-rq-before-freeing.patch @@ -0,0 +1,162 @@ +From f5df068417ff22948c1fe457a1cb008d21bffa94 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 11 May 2021 23:22:35 +0800 +Subject: blk-mq: clear stale request in tags->rq[] before freeing one request + pool + +From: Ming Lei + +[ Upstream commit bd63141d585bef14f4caf111f6d0e27fe2300ec6 ] + +refcount_inc_not_zero() in bt_tags_iter() still may read one freed +request. + +Fix the issue by the following approach: + +1) hold a per-tags spinlock when reading ->rqs[tag] and calling +refcount_inc_not_zero in bt_tags_iter() + +2) clearing stale request referred via ->rqs[tag] before freeing +request pool, the per-tags spinlock is held for clearing stale +->rq[tag] + +So after we cleared stale requests, bt_tags_iter() won't observe +freed request any more, also the clearing will wait for pending +request reference. + +The idea of clearing ->rqs[] is borrowed from John Garry's previous +patch and one recent David's patch. + +Tested-by: John Garry +Reviewed-by: David Jeffery +Reviewed-by: Bart Van Assche +Signed-off-by: Ming Lei +Link: https://lore.kernel.org/r/20210511152236.763464-4-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-mq-tag.c | 9 +++++++-- + block/blk-mq-tag.h | 6 ++++++ + block/blk-mq.c | 46 +++++++++++++++++++++++++++++++++++++++++----- + 3 files changed, 54 insertions(+), 7 deletions(-) + +diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c +index 6772c3728865..c4f2f6c123ae 100644 +--- a/block/blk-mq-tag.c ++++ b/block/blk-mq-tag.c +@@ -202,10 +202,14 @@ struct bt_iter_data { + static struct request *blk_mq_find_and_get_req(struct blk_mq_tags *tags, + unsigned int bitnr) + { +- struct request *rq = tags->rqs[bitnr]; ++ struct request *rq; ++ unsigned long flags; + ++ spin_lock_irqsave(&tags->lock, flags); ++ rq = tags->rqs[bitnr]; + if (!rq || !refcount_inc_not_zero(&rq->ref)) +- return NULL; ++ rq = NULL; ++ spin_unlock_irqrestore(&tags->lock, flags); + return rq; + } + +@@ -538,6 +542,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags, + + tags->nr_tags = total_tags; + tags->nr_reserved_tags = reserved_tags; ++ spin_lock_init(&tags->lock); + + if (flags & BLK_MQ_F_TAG_HCTX_SHARED) + return tags; +diff --git a/block/blk-mq-tag.h b/block/blk-mq-tag.h +index 7d3e6b333a4a..f887988e5ef6 100644 +--- a/block/blk-mq-tag.h ++++ b/block/blk-mq-tag.h +@@ -20,6 +20,12 @@ struct blk_mq_tags { + struct request **rqs; + struct request **static_rqs; + struct list_head page_list; ++ ++ /* ++ * used to clear request reference in rqs[] before freeing one ++ * request pool ++ */ ++ spinlock_t lock; + }; + + extern struct blk_mq_tags *blk_mq_init_tags(unsigned int nr_tags, +diff --git a/block/blk-mq.c b/block/blk-mq.c +index 50d3527a5d97..00d6ed2fe812 100644 +--- a/block/blk-mq.c ++++ b/block/blk-mq.c +@@ -2276,6 +2276,45 @@ queue_exit: + return BLK_QC_T_NONE; + } + ++static size_t order_to_size(unsigned int order) ++{ ++ return (size_t)PAGE_SIZE << order; ++} ++ ++/* called before freeing request pool in @tags */ ++static void blk_mq_clear_rq_mapping(struct blk_mq_tag_set *set, ++ struct blk_mq_tags *tags, unsigned int hctx_idx) ++{ ++ struct blk_mq_tags *drv_tags = set->tags[hctx_idx]; ++ struct page *page; ++ unsigned long flags; ++ ++ list_for_each_entry(page, &tags->page_list, lru) { ++ unsigned long start = (unsigned long)page_address(page); ++ unsigned long end = start + order_to_size(page->private); ++ int i; ++ ++ for (i = 0; i < set->queue_depth; i++) { ++ struct request *rq = drv_tags->rqs[i]; ++ unsigned long rq_addr = (unsigned long)rq; ++ ++ if (rq_addr >= start && rq_addr < end) { ++ WARN_ON_ONCE(refcount_read(&rq->ref) != 0); ++ cmpxchg(&drv_tags->rqs[i], rq, NULL); ++ } ++ } ++ } ++ ++ /* ++ * Wait until all pending iteration is done. ++ * ++ * Request reference is cleared and it is guaranteed to be observed ++ * after the ->lock is released. ++ */ ++ spin_lock_irqsave(&drv_tags->lock, flags); ++ spin_unlock_irqrestore(&drv_tags->lock, flags); ++} ++ + void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags, + unsigned int hctx_idx) + { +@@ -2294,6 +2333,8 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags, + } + } + ++ blk_mq_clear_rq_mapping(set, tags, hctx_idx); ++ + while (!list_empty(&tags->page_list)) { + page = list_first_entry(&tags->page_list, struct page, lru); + list_del_init(&page->lru); +@@ -2353,11 +2394,6 @@ struct blk_mq_tags *blk_mq_alloc_rq_map(struct blk_mq_tag_set *set, + return tags; + } + +-static size_t order_to_size(unsigned int order) +-{ +- return (size_t)PAGE_SIZE << order; +-} +- + static int blk_mq_init_request(struct blk_mq_tag_set *set, struct request *rq, + unsigned int hctx_idx, int node) + { +-- +2.30.2 + diff --git a/queue-5.10/blk-mq-grab-rq-refcount-before-calling-fn-in-blk_mq_.patch b/queue-5.10/blk-mq-grab-rq-refcount-before-calling-fn-in-blk_mq_.patch new file mode 100644 index 00000000000..db24fe962ef --- /dev/null +++ b/queue-5.10/blk-mq-grab-rq-refcount-before-calling-fn-in-blk_mq_.patch @@ -0,0 +1,180 @@ +From ca84f7e7dc9882a30e6817744379f371566ca694 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 11 May 2021 23:22:34 +0800 +Subject: blk-mq: grab rq->refcount before calling ->fn in + blk_mq_tagset_busy_iter + +From: Ming Lei + +[ Upstream commit 2e315dc07df009c3e29d6926871f62a30cfae394 ] + +Grab rq->refcount before calling ->fn in blk_mq_tagset_busy_iter(), and +this way will prevent the request from being re-used when ->fn is +running. The approach is same as what we do during handling timeout. + +Fix request use-after-free(UAF) related with completion race or queue +releasing: + +- If one rq is referred before rq->q is frozen, then queue won't be +frozen before the request is released during iteration. + +- If one rq is referred after rq->q is frozen, refcount_inc_not_zero() +will return false, and we won't iterate over this request. + +However, still one request UAF not covered: refcount_inc_not_zero() may +read one freed request, and it will be handled in next patch. + +Tested-by: John Garry +Reviewed-by: Christoph Hellwig +Reviewed-by: Bart Van Assche +Signed-off-by: Ming Lei +Link: https://lore.kernel.org/r/20210511152236.763464-3-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-mq-tag.c | 44 +++++++++++++++++++++++++++++++++----------- + block/blk-mq.c | 14 +++++++++----- + block/blk-mq.h | 1 + + 3 files changed, 43 insertions(+), 16 deletions(-) + +diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c +index 9c92053e704d..6772c3728865 100644 +--- a/block/blk-mq-tag.c ++++ b/block/blk-mq-tag.c +@@ -199,6 +199,16 @@ struct bt_iter_data { + bool reserved; + }; + ++static struct request *blk_mq_find_and_get_req(struct blk_mq_tags *tags, ++ unsigned int bitnr) ++{ ++ struct request *rq = tags->rqs[bitnr]; ++ ++ if (!rq || !refcount_inc_not_zero(&rq->ref)) ++ return NULL; ++ return rq; ++} ++ + static bool bt_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) + { + struct bt_iter_data *iter_data = data; +@@ -206,18 +216,22 @@ static bool bt_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) + struct blk_mq_tags *tags = hctx->tags; + bool reserved = iter_data->reserved; + struct request *rq; ++ bool ret = true; + + if (!reserved) + bitnr += tags->nr_reserved_tags; +- rq = tags->rqs[bitnr]; +- + /* + * We can hit rq == NULL here, because the tagging functions + * test and set the bit before assigning ->rqs[]. + */ +- if (rq && rq->q == hctx->queue && rq->mq_hctx == hctx) +- return iter_data->fn(hctx, rq, iter_data->data, reserved); +- return true; ++ rq = blk_mq_find_and_get_req(tags, bitnr); ++ if (!rq) ++ return true; ++ ++ if (rq->q == hctx->queue && rq->mq_hctx == hctx) ++ ret = iter_data->fn(hctx, rq, iter_data->data, reserved); ++ blk_mq_put_rq_ref(rq); ++ return ret; + } + + /** +@@ -264,6 +278,8 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) + struct blk_mq_tags *tags = iter_data->tags; + bool reserved = iter_data->flags & BT_TAG_ITER_RESERVED; + struct request *rq; ++ bool ret = true; ++ bool iter_static_rqs = !!(iter_data->flags & BT_TAG_ITER_STATIC_RQS); + + if (!reserved) + bitnr += tags->nr_reserved_tags; +@@ -272,16 +288,19 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) + * We can hit rq == NULL here, because the tagging functions + * test and set the bit before assigning ->rqs[]. + */ +- if (iter_data->flags & BT_TAG_ITER_STATIC_RQS) ++ if (iter_static_rqs) + rq = tags->static_rqs[bitnr]; + else +- rq = tags->rqs[bitnr]; ++ rq = blk_mq_find_and_get_req(tags, bitnr); + if (!rq) + return true; +- if ((iter_data->flags & BT_TAG_ITER_STARTED) && +- !blk_mq_request_started(rq)) +- return true; +- return iter_data->fn(rq, iter_data->data, reserved); ++ ++ if (!(iter_data->flags & BT_TAG_ITER_STARTED) || ++ blk_mq_request_started(rq)) ++ ret = iter_data->fn(rq, iter_data->data, reserved); ++ if (!iter_static_rqs) ++ blk_mq_put_rq_ref(rq); ++ return ret; + } + + /** +@@ -348,6 +367,9 @@ void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn, + * indicates whether or not @rq is a reserved request. Return + * true to continue iterating tags, false to stop. + * @priv: Will be passed as second argument to @fn. ++ * ++ * We grab one request reference before calling @fn and release it after ++ * @fn returns. + */ + void blk_mq_tagset_busy_iter(struct blk_mq_tag_set *tagset, + busy_tag_iter_fn *fn, void *priv) +diff --git a/block/blk-mq.c b/block/blk-mq.c +index 4bf9449b4586..50d3527a5d97 100644 +--- a/block/blk-mq.c ++++ b/block/blk-mq.c +@@ -927,6 +927,14 @@ static bool blk_mq_req_expired(struct request *rq, unsigned long *next) + return false; + } + ++void blk_mq_put_rq_ref(struct request *rq) ++{ ++ if (is_flush_rq(rq, rq->mq_hctx)) ++ rq->end_io(rq, 0); ++ else if (refcount_dec_and_test(&rq->ref)) ++ __blk_mq_free_request(rq); ++} ++ + static bool blk_mq_check_expired(struct blk_mq_hw_ctx *hctx, + struct request *rq, void *priv, bool reserved) + { +@@ -960,11 +968,7 @@ static bool blk_mq_check_expired(struct blk_mq_hw_ctx *hctx, + if (blk_mq_req_expired(rq, next)) + blk_mq_rq_timed_out(rq, reserved); + +- if (is_flush_rq(rq, hctx)) +- rq->end_io(rq, 0); +- else if (refcount_dec_and_test(&rq->ref)) +- __blk_mq_free_request(rq); +- ++ blk_mq_put_rq_ref(rq); + return true; + } + +diff --git a/block/blk-mq.h b/block/blk-mq.h +index d2359f7cfd5f..f792a0920ebb 100644 +--- a/block/blk-mq.h ++++ b/block/blk-mq.h +@@ -47,6 +47,7 @@ void blk_mq_add_to_requeue_list(struct request *rq, bool at_head, + void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list); + struct request *blk_mq_dequeue_from_ctx(struct blk_mq_hw_ctx *hctx, + struct blk_mq_ctx *start); ++void blk_mq_put_rq_ref(struct request *rq); + + /* + * Internal helpers for allocating/freeing the request map +-- +2.30.2 + diff --git a/queue-5.10/blk-mq-update-hctx-dispatch_busy-in-case-of-real-sch.patch b/queue-5.10/blk-mq-update-hctx-dispatch_busy-in-case-of-real-sch.patch new file mode 100644 index 00000000000..35d7c9a1532 --- /dev/null +++ b/queue-5.10/blk-mq-update-hctx-dispatch_busy-in-case-of-real-sch.patch @@ -0,0 +1,44 @@ +From 3a58ae0d787019727ab82e40034512c543d0bd07 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 10:02:48 +0800 +Subject: blk-mq: update hctx->dispatch_busy in case of real scheduler + +From: Ming Lei + +[ Upstream commit cb9516be7708a2a18ec0a19fe3a225b5b3bc92c7 ] + +Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") +starts to support io batching submission by using hctx->dispatch_busy. + +However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy +in that commit, so fix the issue by updating hctx->dispatch_busy in case +of real scheduler. + +Reported-by: Jan Kara +Reviewed-by: Jan Kara +Fixes: 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") +Signed-off-by: Ming Lei +Link: https://lore.kernel.org/r/20210625020248.1630497-1-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-mq.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/block/blk-mq.c b/block/blk-mq.c +index 00d6ed2fe812..a368eb6dc647 100644 +--- a/block/blk-mq.c ++++ b/block/blk-mq.c +@@ -1242,9 +1242,6 @@ static void blk_mq_update_dispatch_busy(struct blk_mq_hw_ctx *hctx, bool busy) + { + unsigned int ewma; + +- if (hctx->queue->elevator) +- return; +- + ewma = hctx->dispatch_busy; + + if (!ewma && !busy) +-- +2.30.2 + diff --git a/queue-5.10/blk-wbt-introduce-a-new-disable-state-to-prevent-fal.patch b/queue-5.10/blk-wbt-introduce-a-new-disable-state-to-prevent-fal.patch new file mode 100644 index 00000000000..c8f6692d584 --- /dev/null +++ b/queue-5.10/blk-wbt-introduce-a-new-disable-state-to-prevent-fal.patch @@ -0,0 +1,66 @@ +From 45e6dbffed077e03e925b1c60022d80eab3016cd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 19 Jun 2021 17:36:59 +0800 +Subject: blk-wbt: introduce a new disable state to prevent false positive by + rwb_enabled() + +From: Zhang Yi + +[ Upstream commit 1d0903d61e9645c6330b94247b96dd873dfc11c8 ] + +Now that we disable wbt by simply zero out rwb->wb_normal in +wbt_disable_default() when switch elevator to bfq, but it's not safe +because it will become false positive if we change queue depth. If it +become false positive between wbt_wait() and wbt_track() when submit +write request, it will lead to drop rqw->inflight to -1 in wbt_done(), +which will end up trigger IO hung. Fix this issue by introduce a new +state which mean the wbt was disabled. + +Fixes: a79050434b45 ("blk-rq-qos: refactor out common elements of blk-wbt") +Signed-off-by: Zhang Yi +Link: https://lore.kernel.org/r/20210619093700.920393-2-yi.zhang@huawei.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-wbt.c | 5 +++-- + block/blk-wbt.h | 1 + + 2 files changed, 4 insertions(+), 2 deletions(-) + +diff --git a/block/blk-wbt.c b/block/blk-wbt.c +index fd410086fe1d..d90082c6b41f 100644 +--- a/block/blk-wbt.c ++++ b/block/blk-wbt.c +@@ -77,7 +77,8 @@ enum { + + static inline bool rwb_enabled(struct rq_wb *rwb) + { +- return rwb && rwb->wb_normal != 0; ++ return rwb && rwb->enable_state != WBT_STATE_OFF_DEFAULT && ++ rwb->wb_normal != 0; + } + + static void wb_timestamp(struct rq_wb *rwb, unsigned long *var) +@@ -702,7 +703,7 @@ void wbt_disable_default(struct request_queue *q) + rwb = RQWB(rqos); + if (rwb->enable_state == WBT_STATE_ON_DEFAULT) { + blk_stat_deactivate(rwb->cb); +- rwb->wb_normal = 0; ++ rwb->enable_state = WBT_STATE_OFF_DEFAULT; + } + } + EXPORT_SYMBOL_GPL(wbt_disable_default); +diff --git a/block/blk-wbt.h b/block/blk-wbt.h +index 16bdc85b8df9..2eb01becde8c 100644 +--- a/block/blk-wbt.h ++++ b/block/blk-wbt.h +@@ -34,6 +34,7 @@ enum { + enum { + WBT_STATE_ON_DEFAULT = 1, + WBT_STATE_ON_MANUAL = 2, ++ WBT_STATE_OFF_DEFAULT + }; + + struct rq_wb { +-- +2.30.2 + diff --git a/queue-5.10/blk-wbt-make-sure-throttle-is-enabled-properly.patch b/queue-5.10/blk-wbt-make-sure-throttle-is-enabled-properly.patch new file mode 100644 index 00000000000..e171ce199c4 --- /dev/null +++ b/queue-5.10/blk-wbt-make-sure-throttle-is-enabled-properly.patch @@ -0,0 +1,45 @@ +From 9a894ea989fa7c49a7159a1e718f5237ef6d3cb4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 19 Jun 2021 17:37:00 +0800 +Subject: blk-wbt: make sure throttle is enabled properly + +From: Zhang Yi + +[ Upstream commit 76a8040817b4b9c69b53f9b326987fa891b4082a ] + +After commit a79050434b45 ("blk-rq-qos: refactor out common elements of +blk-wbt"), if throttle was disabled by wbt_disable_default(), we could +not enable again, fix this by set enable_state back to +WBT_STATE_ON_DEFAULT. + +Fixes: a79050434b45 ("blk-rq-qos: refactor out common elements of blk-wbt") +Signed-off-by: Zhang Yi +Link: https://lore.kernel.org/r/20210619093700.920393-3-yi.zhang@huawei.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-wbt.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/block/blk-wbt.c b/block/blk-wbt.c +index d90082c6b41f..35d81b5deae1 100644 +--- a/block/blk-wbt.c ++++ b/block/blk-wbt.c +@@ -637,9 +637,13 @@ void wbt_set_write_cache(struct request_queue *q, bool write_cache_on) + void wbt_enable_default(struct request_queue *q) + { + struct rq_qos *rqos = wbt_rq_qos(q); ++ + /* Throttling already enabled? */ +- if (rqos) ++ if (rqos) { ++ if (RQWB(rqos)->enable_state == WBT_STATE_OFF_DEFAULT) ++ RQWB(rqos)->enable_state = WBT_STATE_ON_DEFAULT; + return; ++ } + + /* Queue not registered? Maybe shutting down... */ + if (!blk_queue_registered(q)) +-- +2.30.2 + diff --git a/queue-5.10/block-avoid-double-io-accounting-for-flush-request.patch b/queue-5.10/block-avoid-double-io-accounting-for-flush-request.patch new file mode 100644 index 00000000000..c7e351dd808 --- /dev/null +++ b/queue-5.10/block-avoid-double-io-accounting-for-flush-request.patch @@ -0,0 +1,52 @@ +From 545739d147100e29c4c1b0cd2f9eab654a49196b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 11 May 2021 23:22:33 +0800 +Subject: block: avoid double io accounting for flush request + +From: Ming Lei + +[ Upstream commit 84da7acc3ba53af26f15c4b0ada446127b7a7836 ] + +For flush request, rq->end_io() may be called two times, one is from +timeout handling(blk_mq_check_expired()), another is from normal +completion(__blk_mq_end_request()). + +Move blk_account_io_flush() after flush_rq->ref drops to zero, so +io accounting can be done just once for flush request. + +Fixes: b68663186577 ("block: add iostat counters for flush requests") +Reviewed-by: Bart Van Assche +Reviewed-by: Christoph Hellwig +Tested-by: John Garry +Signed-off-by: Ming Lei +Link: https://lore.kernel.org/r/20210511152236.763464-2-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-flush.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/block/blk-flush.c b/block/blk-flush.c +index fd5cee9f1a3b..7ee7e5e8905d 100644 +--- a/block/blk-flush.c ++++ b/block/blk-flush.c +@@ -220,8 +220,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) + unsigned long flags = 0; + struct blk_flush_queue *fq = blk_get_flush_queue(q, flush_rq->mq_ctx); + +- blk_account_io_flush(flush_rq); +- + /* release the tag's ownership to the req cloned from */ + spin_lock_irqsave(&fq->mq_flush_lock, flags); + +@@ -231,6 +229,7 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) + return; + } + ++ blk_account_io_flush(flush_rq); + /* + * Flush request has to be marked as IDLE when it is really ended + * because its .end_io() is called from timeout code path too for +-- +2.30.2 + diff --git a/queue-5.10/block-fix-discard-request-merge.patch b/queue-5.10/block-fix-discard-request-merge.patch new file mode 100644 index 00000000000..38f6049bdb7 --- /dev/null +++ b/queue-5.10/block-fix-discard-request-merge.patch @@ -0,0 +1,58 @@ +From 12cd04412bc4ab5a52a612f6b6e67144ec7cd7ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 10:33:12 +0800 +Subject: block: fix discard request merge + +From: Ming Lei + +[ Upstream commit 2705dfb2094777e405e065105e307074af8965c1 ] + +ll_new_hw_segment() is reached only in case of single range discard +merge, and we don't have max discard segment size limit actually, so +it is wrong to run the following check: + +if (req->nr_phys_segments + nr_phys_segs > blk_rq_get_max_segments(req)) + +it may be always false since req->nr_phys_segments is initialized as +one, and bio's segment count is still 1, blk_rq_get_max_segments(reg) +is 1 too. + +Fix the issue by not doing the check and bypassing the calculation of +discard request's nr_phys_segments. + +Based on analysis from Wang Shanker. + +Cc: Christoph Hellwig +Reported-by: Wang Shanker +Signed-off-by: Ming Lei +Link: https://lore.kernel.org/r/20210628023312.1903255-1-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-merge.c | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +diff --git a/block/blk-merge.c b/block/blk-merge.c +index 7cdd56696647..349cd7d3af81 100644 +--- a/block/blk-merge.c ++++ b/block/blk-merge.c +@@ -552,10 +552,14 @@ static inline unsigned int blk_rq_get_max_segments(struct request *rq) + static inline int ll_new_hw_segment(struct request *req, struct bio *bio, + unsigned int nr_phys_segs) + { +- if (req->nr_phys_segments + nr_phys_segs > blk_rq_get_max_segments(req)) ++ if (blk_integrity_merge_bio(req->q, req, bio) == false) + goto no_merge; + +- if (blk_integrity_merge_bio(req->q, req, bio) == false) ++ /* discard request merge won't add new segment */ ++ if (req_op(req) == REQ_OP_DISCARD) ++ return 1; ++ ++ if (req->nr_phys_segments + nr_phys_segs > blk_rq_get_max_segments(req)) + goto no_merge; + + /* +-- +2.30.2 + diff --git a/queue-5.10/block-fix-race-between-adding-removing-rq-qos-and-no.patch b/queue-5.10/block-fix-race-between-adding-removing-rq-qos-and-no.patch new file mode 100644 index 00000000000..42ac1b2c750 --- /dev/null +++ b/queue-5.10/block-fix-race-between-adding-removing-rq-qos-and-no.patch @@ -0,0 +1,113 @@ +From 1e041b11cf37f661ff430d3fb4a3fc0bcaf44ce9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 09:58:21 +0800 +Subject: block: fix race between adding/removing rq qos and normal IO + +From: Ming Lei + +[ Upstream commit 2cafe29a8d03f02a3d16193bdaae2f3e82a423f9 ] + +Yi reported several kernel panics on: + +[16687.001777] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 +... +[16687.163549] pc : __rq_qos_track+0x38/0x60 + +or + +[ 997.690455] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020 +... +[ 997.850347] pc : __rq_qos_done+0x2c/0x50 + +Turns out it is caused by race between adding rq qos(wbt) and normal IO +because rq_qos_add can be run when IO is being submitted, fix this issue +by freezing queue before adding/deleting rq qos to queue. + +rq_qos_exit() needn't to freeze queue because it is called after queue +has been frozen. + +iolatency calls rq_qos_add() during allocating queue, so freezing won't +add delay because queue usage refcount works at atomic mode at that +time. + +iocost calls rq_qos_add() when writing cgroup attribute file, that is +fine to freeze queue at that time since we usually freeze queue when +storing to queue sysfs attribute, meantime iocost only exists on the +root cgroup. + +wbt_init calls it in blk_register_queue() and queue sysfs attribute +store(queue_wb_lat_store() when write it 1st time in case of !BLK_WBT_MQ), +the following patch will speedup the queue freezing in wbt_init. + +Reported-by: Yi Zhang +Cc: Bart Van Assche +Signed-off-by: Ming Lei +Reviewed-by: Bart Van Assche +Tested-by: Yi Zhang +Link: https://lore.kernel.org/r/20210609015822.103433-2-ming.lei@redhat.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-rq-qos.h | 24 ++++++++++++++++++++++++ + 1 file changed, 24 insertions(+) + +diff --git a/block/blk-rq-qos.h b/block/blk-rq-qos.h +index 2bc43e94f4c4..2bcb3495e376 100644 +--- a/block/blk-rq-qos.h ++++ b/block/blk-rq-qos.h +@@ -7,6 +7,7 @@ + #include + #include + #include ++#include + + #include "blk-mq-debugfs.h" + +@@ -99,8 +100,21 @@ static inline void rq_wait_init(struct rq_wait *rq_wait) + + static inline void rq_qos_add(struct request_queue *q, struct rq_qos *rqos) + { ++ /* ++ * No IO can be in-flight when adding rqos, so freeze queue, which ++ * is fine since we only support rq_qos for blk-mq queue. ++ * ++ * Reuse ->queue_lock for protecting against other concurrent ++ * rq_qos adding/deleting ++ */ ++ blk_mq_freeze_queue(q); ++ ++ spin_lock_irq(&q->queue_lock); + rqos->next = q->rq_qos; + q->rq_qos = rqos; ++ spin_unlock_irq(&q->queue_lock); ++ ++ blk_mq_unfreeze_queue(q); + + if (rqos->ops->debugfs_attrs) + blk_mq_debugfs_register_rqos(rqos); +@@ -110,12 +124,22 @@ static inline void rq_qos_del(struct request_queue *q, struct rq_qos *rqos) + { + struct rq_qos **cur; + ++ /* ++ * See comment in rq_qos_add() about freezing queue & using ++ * ->queue_lock. ++ */ ++ blk_mq_freeze_queue(q); ++ ++ spin_lock_irq(&q->queue_lock); + for (cur = &q->rq_qos; *cur; cur = &(*cur)->next) { + if (*cur == rqos) { + *cur = rqos->next; + break; + } + } ++ spin_unlock_irq(&q->queue_lock); ++ ++ blk_mq_unfreeze_queue(q); + + blk_mq_debugfs_unregister_rqos(rqos); + } +-- +2.30.2 + diff --git a/queue-5.10/block_dump-remove-block_dump-feature-in-mark_inode_d.patch b/queue-5.10/block_dump-remove-block_dump-feature-in-mark_inode_d.patch new file mode 100644 index 00000000000..251e22304c3 --- /dev/null +++ b/queue-5.10/block_dump-remove-block_dump-feature-in-mark_inode_d.patch @@ -0,0 +1,84 @@ +From 1e4e56e618c43c2bf188a9b4e2846f62cb246884 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 13 Mar 2021 11:01:44 +0800 +Subject: block_dump: remove block_dump feature in mark_inode_dirty() + +From: zhangyi (F) + +[ Upstream commit 12e0613715e1cf305fffafaf0e89d810d9a85cc0 ] + +block_dump is an old debugging interface, one of it's functions is used +to print the information about who write which file on disk. If we +enable block_dump through /proc/sys/vm/block_dump and turn on debug log +level, we can gather information about write process name, target file +name and disk from kernel message. This feature is realized in +block_dump___mark_inode_dirty(), it print above information into kernel +message directly when marking inode dirty, so it is noisy and can easily +trigger log storm. At the same time, get the dentry refcount is also not +safe, we found it will lead to deadlock on ext4 file system with +data=journal mode. + +After tracepoints has been introduced into the kernel, we got a +tracepoint in __mark_inode_dirty(), which is a better replacement of +block_dump___mark_inode_dirty(). The only downside is that it only trace +the inode number and not a file name, but it probably doesn't matter +because the original printed file name in block_dump is not accurate in +some cases, and we can still find it through the inode number and device +id. So this patch delete the dirting inode part of block_dump feature. + +Signed-off-by: zhangyi (F) +Reviewed-by: Jan Kara +Reviewed-by: Christoph Hellwig +Link: https://lore.kernel.org/r/20210313030146.2882027-2-yi.zhang@huawei.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + fs/fs-writeback.c | 25 ------------------------- + 1 file changed, 25 deletions(-) + +diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c +index 90dddb507e4a..0d0f014b09ec 100644 +--- a/fs/fs-writeback.c ++++ b/fs/fs-writeback.c +@@ -2196,28 +2196,6 @@ int dirtytime_interval_handler(struct ctl_table *table, int write, + return ret; + } + +-static noinline void block_dump___mark_inode_dirty(struct inode *inode) +-{ +- if (inode->i_ino || strcmp(inode->i_sb->s_id, "bdev")) { +- struct dentry *dentry; +- const char *name = "?"; +- +- dentry = d_find_alias(inode); +- if (dentry) { +- spin_lock(&dentry->d_lock); +- name = (const char *) dentry->d_name.name; +- } +- printk(KERN_DEBUG +- "%s(%d): dirtied inode %lu (%s) on %s\n", +- current->comm, task_pid_nr(current), inode->i_ino, +- name, inode->i_sb->s_id); +- if (dentry) { +- spin_unlock(&dentry->d_lock); +- dput(dentry); +- } +- } +-} +- + /** + * __mark_inode_dirty - internal function + * +@@ -2277,9 +2255,6 @@ void __mark_inode_dirty(struct inode *inode, int flags) + (dirtytime && (inode->i_state & I_DIRTY_INODE))) + return; + +- if (unlikely(block_dump)) +- block_dump___mark_inode_dirty(inode); +- + spin_lock(&inode->i_lock); + if (dirtytime && (inode->i_state & I_DIRTY_INODE)) + goto out_unlock_inode; +-- +2.30.2 + diff --git a/queue-5.10/bluetooth-fix-handling-of-hci_le_advertising_set_ter.patch b/queue-5.10/bluetooth-fix-handling-of-hci_le_advertising_set_ter.patch new file mode 100644 index 00000000000..9834c133ce2 --- /dev/null +++ b/queue-5.10/bluetooth-fix-handling-of-hci_le_advertising_set_ter.patch @@ -0,0 +1,56 @@ +From e91d451ad9fd4ca90574cdd4c1a9327aa1e0a42c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 20:59:02 -0700 +Subject: Bluetooth: Fix handling of HCI_LE_Advertising_Set_Terminated event + +From: Luiz Augusto von Dentz + +[ Upstream commit 23837a6d7a1a61818ed94a6b8af552d6cf7d32d5 ] + +Error status of this event means that it has ended due reasons other +than a connection: + + 'If advertising has terminated as a result of the advertising duration + elapsing, the Status parameter shall be set to the error code + Advertising Timeout (0x3C).' + + 'If advertising has terminated because the + Max_Extended_Advertising_Events was reached, the Status parameter + shall be set to the error code Limit Reached (0x43).' + +Fixes: acf0aeae431a0 ("Bluetooth: Handle ADv set terminated event") +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Marcel Holtmann +Signed-off-by: Sasha Levin +--- + net/bluetooth/hci_event.c | 13 ++++++++++++- + 1 file changed, 12 insertions(+), 1 deletion(-) + +diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c +index 20f17d312596..d62ac4b73709 100644 +--- a/net/bluetooth/hci_event.c ++++ b/net/bluetooth/hci_event.c +@@ -5256,8 +5256,19 @@ static void hci_le_ext_adv_term_evt(struct hci_dev *hdev, struct sk_buff *skb) + + BT_DBG("%s status 0x%2.2x", hdev->name, ev->status); + +- if (ev->status) ++ if (ev->status) { ++ struct adv_info *adv; ++ ++ adv = hci_find_adv_instance(hdev, ev->handle); ++ if (!adv) ++ return; ++ ++ /* Remove advertising as it has been terminated */ ++ hci_remove_adv_instance(hdev, ev->handle); ++ mgmt_advertising_removed(NULL, hdev, ev->handle); ++ + return; ++ } + + conn = hci_conn_hash_lookup_handle(hdev, __le16_to_cpu(ev->conn_handle)); + if (conn) { +-- +2.30.2 + diff --git a/queue-5.10/bluetooth-fix-not-sending-set-extended-scan-response.patch b/queue-5.10/bluetooth-fix-not-sending-set-extended-scan-response.patch new file mode 100644 index 00000000000..0b68dba5b66 --- /dev/null +++ b/queue-5.10/bluetooth-fix-not-sending-set-extended-scan-response.patch @@ -0,0 +1,60 @@ +From b302db36c3b08abc6257d6bb03e5289d4706cf38 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 13 Nov 2020 16:44:33 -0800 +Subject: Bluetooth: Fix not sending Set Extended Scan Response + +From: Luiz Augusto von Dentz + +[ Upstream commit a76a0d365077711594ce200a9553ed6d1ff40276 ] + +Current code is actually failing on the following tests of mgmt-tester +because get_adv_instance_scan_rsp_len did not account for flags that +cause scan response data to be included resulting in non-scannable +instance when in fact it should be scannable. + +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Marcel Holtmann +Signed-off-by: Johan Hedberg +Signed-off-by: Sasha Levin +--- + net/bluetooth/hci_request.c | 14 ++++++-------- + 1 file changed, 6 insertions(+), 8 deletions(-) + +diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c +index 161ea93a5382..33dc78c24b73 100644 +--- a/net/bluetooth/hci_request.c ++++ b/net/bluetooth/hci_request.c +@@ -1060,9 +1060,10 @@ static u8 get_adv_instance_scan_rsp_len(struct hci_dev *hdev, u8 instance) + if (!adv_instance) + return 0; + +- /* TODO: Take into account the "appearance" and "local-name" flags here. +- * These are currently being ignored as they are not supported. +- */ ++ if (adv_instance->flags & MGMT_ADV_FLAG_APPEARANCE || ++ adv_instance->flags & MGMT_ADV_FLAG_LOCAL_NAME) ++ return 1; ++ + return adv_instance->scan_rsp_len; + } + +@@ -1599,14 +1600,11 @@ void __hci_req_update_scan_rsp_data(struct hci_request *req, u8 instance) + + memset(&cp, 0, sizeof(cp)); + +- /* Extended scan response data doesn't allow a response to be +- * set if the instance isn't scannable. +- */ +- if (get_adv_instance_scan_rsp_len(hdev, instance)) ++ if (instance) + len = create_instance_scan_rsp_data(hdev, instance, + cp.data); + else +- len = 0; ++ len = create_default_scan_rsp_data(hdev, cp.data); + + if (hdev->scan_rsp_data_len == len && + !memcmp(cp.data, hdev->scan_rsp_data, len)) +-- +2.30.2 + diff --git a/queue-5.10/bluetooth-fix-set-extended-scan-response-data.patch b/queue-5.10/bluetooth-fix-set-extended-scan-response-data.patch new file mode 100644 index 00000000000..526751863ef --- /dev/null +++ b/queue-5.10/bluetooth-fix-set-extended-scan-response-data.patch @@ -0,0 +1,176 @@ +From 1f00c46d29486b1167e6dd095bfb4596b21d4714 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 11:09:27 -0700 +Subject: Bluetooth: Fix Set Extended (Scan Response) Data + +From: Luiz Augusto von Dentz + +[ Upstream commit c9ed0a7077306f9d41d74fb006ab5dbada8349c5 ] + +These command do have variable length and the length can go up to 251, +so this changes the struct to not use a fixed size and then when +creating the PDU only the actual length of the data send to the +controller. + +Fixes: a0fb3726ba551 ("Bluetooth: Use Set ext adv/scan rsp data if controller supports") +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Marcel Holtmann +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/hci.h | 6 ++-- + include/net/bluetooth/hci_core.h | 8 ++--- + net/bluetooth/hci_request.c | 51 ++++++++++++++++++-------------- + 3 files changed, 37 insertions(+), 28 deletions(-) + +diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h +index 6da4b3c5dd55..243de74e118e 100644 +--- a/include/net/bluetooth/hci.h ++++ b/include/net/bluetooth/hci.h +@@ -1773,13 +1773,15 @@ struct hci_cp_ext_adv_set { + __u8 max_events; + } __packed; + ++#define HCI_MAX_EXT_AD_LENGTH 251 ++ + #define HCI_OP_LE_SET_EXT_ADV_DATA 0x2037 + struct hci_cp_le_set_ext_adv_data { + __u8 handle; + __u8 operation; + __u8 frag_pref; + __u8 length; +- __u8 data[HCI_MAX_AD_LENGTH]; ++ __u8 data[]; + } __packed; + + #define HCI_OP_LE_SET_EXT_SCAN_RSP_DATA 0x2038 +@@ -1788,7 +1790,7 @@ struct hci_cp_le_set_ext_scan_rsp_data { + __u8 operation; + __u8 frag_pref; + __u8 length; +- __u8 data[HCI_MAX_AD_LENGTH]; ++ __u8 data[]; + } __packed; + + #define LE_SET_ADV_DATA_OP_COMPLETE 0x03 +diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h +index df611c8b6b59..e534dff2874e 100644 +--- a/include/net/bluetooth/hci_core.h ++++ b/include/net/bluetooth/hci_core.h +@@ -226,9 +226,9 @@ struct adv_info { + __u16 remaining_time; + __u16 duration; + __u16 adv_data_len; +- __u8 adv_data[HCI_MAX_AD_LENGTH]; ++ __u8 adv_data[HCI_MAX_EXT_AD_LENGTH]; + __u16 scan_rsp_len; +- __u8 scan_rsp_data[HCI_MAX_AD_LENGTH]; ++ __u8 scan_rsp_data[HCI_MAX_EXT_AD_LENGTH]; + __s8 tx_power; + bdaddr_t random_addr; + bool rpa_expired; +@@ -523,9 +523,9 @@ struct hci_dev { + DECLARE_BITMAP(dev_flags, __HCI_NUM_FLAGS); + + __s8 adv_tx_power; +- __u8 adv_data[HCI_MAX_AD_LENGTH]; ++ __u8 adv_data[HCI_MAX_EXT_AD_LENGTH]; + __u8 adv_data_len; +- __u8 scan_rsp_data[HCI_MAX_AD_LENGTH]; ++ __u8 scan_rsp_data[HCI_MAX_EXT_AD_LENGTH]; + __u8 scan_rsp_data_len; + + struct list_head adv_instances; +diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c +index 33dc78c24b73..1a94ed2f8a4f 100644 +--- a/net/bluetooth/hci_request.c ++++ b/net/bluetooth/hci_request.c +@@ -1596,30 +1596,33 @@ void __hci_req_update_scan_rsp_data(struct hci_request *req, u8 instance) + return; + + if (ext_adv_capable(hdev)) { +- struct hci_cp_le_set_ext_scan_rsp_data cp; ++ struct { ++ struct hci_cp_le_set_ext_scan_rsp_data cp; ++ u8 data[HCI_MAX_EXT_AD_LENGTH]; ++ } pdu; + +- memset(&cp, 0, sizeof(cp)); ++ memset(&pdu, 0, sizeof(pdu)); + + if (instance) + len = create_instance_scan_rsp_data(hdev, instance, +- cp.data); ++ pdu.data); + else +- len = create_default_scan_rsp_data(hdev, cp.data); ++ len = create_default_scan_rsp_data(hdev, pdu.data); + + if (hdev->scan_rsp_data_len == len && +- !memcmp(cp.data, hdev->scan_rsp_data, len)) ++ !memcmp(pdu.data, hdev->scan_rsp_data, len)) + return; + +- memcpy(hdev->scan_rsp_data, cp.data, sizeof(cp.data)); ++ memcpy(hdev->scan_rsp_data, pdu.data, len); + hdev->scan_rsp_data_len = len; + +- cp.handle = instance; +- cp.length = len; +- cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; +- cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; ++ pdu.cp.handle = instance; ++ pdu.cp.length = len; ++ pdu.cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; ++ pdu.cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; + +- hci_req_add(req, HCI_OP_LE_SET_EXT_SCAN_RSP_DATA, sizeof(cp), +- &cp); ++ hci_req_add(req, HCI_OP_LE_SET_EXT_SCAN_RSP_DATA, ++ sizeof(pdu.cp) + len, &pdu.cp); + } else { + struct hci_cp_le_set_scan_rsp_data cp; + +@@ -1742,26 +1745,30 @@ void __hci_req_update_adv_data(struct hci_request *req, u8 instance) + return; + + if (ext_adv_capable(hdev)) { +- struct hci_cp_le_set_ext_adv_data cp; ++ struct { ++ struct hci_cp_le_set_ext_adv_data cp; ++ u8 data[HCI_MAX_EXT_AD_LENGTH]; ++ } pdu; + +- memset(&cp, 0, sizeof(cp)); ++ memset(&pdu, 0, sizeof(pdu)); + +- len = create_instance_adv_data(hdev, instance, cp.data); ++ len = create_instance_adv_data(hdev, instance, pdu.data); + + /* There's nothing to do if the data hasn't changed */ + if (hdev->adv_data_len == len && +- memcmp(cp.data, hdev->adv_data, len) == 0) ++ memcmp(pdu.data, hdev->adv_data, len) == 0) + return; + +- memcpy(hdev->adv_data, cp.data, sizeof(cp.data)); ++ memcpy(hdev->adv_data, pdu.data, len); + hdev->adv_data_len = len; + +- cp.length = len; +- cp.handle = instance; +- cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; +- cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; ++ pdu.cp.length = len; ++ pdu.cp.handle = instance; ++ pdu.cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; ++ pdu.cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; + +- hci_req_add(req, HCI_OP_LE_SET_EXT_ADV_DATA, sizeof(cp), &cp); ++ hci_req_add(req, HCI_OP_LE_SET_EXT_ADV_DATA, ++ sizeof(pdu.cp) + len, &pdu.cp); + } else { + struct hci_cp_le_set_adv_data cp; + +-- +2.30.2 + diff --git a/queue-5.10/bluetooth-mgmt-fix-slab-out-of-bounds-in-tlv_data_is.patch b/queue-5.10/bluetooth-mgmt-fix-slab-out-of-bounds-in-tlv_data_is.patch new file mode 100644 index 00000000000..49ec4056daa --- /dev/null +++ b/queue-5.10/bluetooth-mgmt-fix-slab-out-of-bounds-in-tlv_data_is.patch @@ -0,0 +1,65 @@ +From 8bdbfeeb2ea322c38627d5c45a2d6234da219740 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 11:45:02 -0700 +Subject: Bluetooth: mgmt: Fix slab-out-of-bounds in tlv_data_is_valid + +From: Luiz Augusto von Dentz + +[ Upstream commit 799acb9347915bfe4eac0ff2345b468f0a1ca207 ] + +This fixes parsing of LTV entries when the length is 0. + +Found with: + +tools/mgmt-tester -s "Add Advertising - Success (ScRsp only)" + +Add Advertising - Success (ScRsp only) - run + Sending Add Advertising (0x003e) + Test condition added, total 1 +[ 11.004577] ================================================================== +[ 11.005292] BUG: KASAN: slab-out-of-bounds in tlv_data_is_valid+0x87/0xe0 +[ 11.005984] Read of size 1 at addr ffff888002c695b0 by task mgmt-tester/87 +[ 11.006711] +[ 11.007176] +[ 11.007429] Allocated by task 87: +[ 11.008151] +[ 11.008438] The buggy address belongs to the object at ffff888002c69580 +[ 11.008438] which belongs to the cache kmalloc-64 of size 64 +[ 11.010526] The buggy address is located 48 bytes inside of +[ 11.010526] 64-byte region [ffff888002c69580, ffff888002c695c0) +[ 11.012423] The buggy address belongs to the page: +[ 11.013291] +[ 11.013544] Memory state around the buggy address: +[ 11.014359] ffff888002c69480: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc +[ 11.015453] ffff888002c69500: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc +[ 11.016232] >ffff888002c69580: 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc +[ 11.017010] ^ +[ 11.017547] ffff888002c69600: 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc +[ 11.018296] ffff888002c69680: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc +[ 11.019116] ================================================================== + +Fixes: 2bb36870e8cb2 ("Bluetooth: Unify advertising instance flags check") +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Marcel Holtmann +Signed-off-by: Sasha Levin +--- + net/bluetooth/mgmt.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c +index 12d7b368b428..13520c7b4f2f 100644 +--- a/net/bluetooth/mgmt.c ++++ b/net/bluetooth/mgmt.c +@@ -7350,6 +7350,9 @@ static bool tlv_data_is_valid(struct hci_dev *hdev, u32 adv_flags, u8 *data, + for (i = 0, cur_len = 0; i < len; i += (cur_len + 1)) { + cur_len = data[i]; + ++ if (!cur_len) ++ continue; ++ + if (data[i + 1] == EIR_FLAGS && + (!is_adv_data || flags_managed(adv_flags))) + return false; +-- +2.30.2 + diff --git a/queue-5.10/bpf-do-not-change-gso_size-during-bpf_skb_change_pro.patch b/queue-5.10/bpf-do-not-change-gso_size-during-bpf_skb_change_pro.patch new file mode 100644 index 00000000000..016c1d12337 --- /dev/null +++ b/queue-5.10/bpf-do-not-change-gso_size-during-bpf_skb_change_pro.patch @@ -0,0 +1,145 @@ +From fca5e672d3deb79cab6a46cda19bde41eac65bf3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 17:09:51 -0700 +Subject: bpf: Do not change gso_size during bpf_skb_change_proto() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Maciej Å»enczykowski + +[ Upstream commit 364745fbe981a4370f50274475da4675661104df ] + +This is technically a backwards incompatible change in behaviour, but I'm +going to argue that it is very unlikely to break things, and likely to fix +*far* more then it breaks. + +In no particular order, various reasons follow: + +(a) I've long had a bug assigned to myself to debug a super rare kernel crash +on Android Pixel phones which can (per stacktrace) be traced back to BPF clat +IPv6 to IPv4 protocol conversion causing some sort of ugly failure much later +on during transmit deep in the GSO engine, AFAICT precisely because of this +change to gso_size, though I've never been able to manually reproduce it. I +believe it may be related to the particular network offload support of attached +USB ethernet dongle being used for tethering off of an IPv6-only cellular +connection. The reason might be we end up with more segments than max permitted, +or with a GSO packet with only one segment... (either way we break some +assumption and hit a BUG_ON) + +(b) There is no check that the gso_size is > 20 when reducing it by 20, so we +might end up with a negative (or underflowing) gso_size or a gso_size of 0. +This can't possibly be good. Indeed this is probably somehow exploitable (or +at least can result in a kernel crash) by delivering crafted packets and perhaps +triggering an infinite loop or a divide by zero... As a reminder: gso_size (MSS) +is related to MTU, but not directly derived from it: gso_size/MSS may be +significantly smaller then one would get by deriving from local MTU. And on +some NICs (which do loose MTU checking on receive, it may even potentially be +larger, for example my work pc with 1500 MTU can receive 1520 byte frames [and +sometimes does due to bugs in a vendor plat46 implementation]). Indeed even just +going from 21 to 1 is potentially problematic because it increases the number +of segments by a factor of 21 (think DoS, or some other crash due to too many +segments). + +(c) It's always safe to not increase the gso_size, because it doesn't result in +the max packet size increasing. So the skb_increase_gso_size() call was always +unnecessary for correctness (and outright undesirable, see later). As such the +only part which is potentially dangerous (ie. could cause backwards compatibility +issues) is the removal of the skb_decrease_gso_size() call. + +(d) If the packets are ultimately destined to the local device, then there is +absolutely no benefit to playing around with gso_size. It only matters if the +packets will egress the device. ie. we're either forwarding, or transmitting +from the device. + +(e) This logic only triggers for packets which are GSO. It does not trigger for +skbs which are not GSO. It will not convert a non-GSO MTU sized packet into a +GSO packet (and you don't even know what the MTU is, so you can't even fix it). +As such your transmit path must *already* be able to handle an MTU 20 bytes +larger then your receive path (for IPv4 to IPv6 translation) - and indeed 28 +bytes larger due to IPv4 fragments. Thus removing the skb_decrease_gso_size() +call doesn't actually increase the size of the packets your transmit side must +be able to handle. ie. to handle non-GSO max-MTU packets, the IPv4/IPv6 device/ +route MTUs must already be set correctly. Since for example with an IPv4 egress +MTU of 1500, IPv4 to IPv6 translation will already build 1520 byte IPv6 frames, +so you need a 1520 byte device MTU. This means if your IPv6 device's egress +MTU is 1280, your IPv4 route must be 1260 (and actually 1252, because of the +need to handle fragments). This is to handle normal non-GSO packets. Thus the +reduction is simply not needed for GSO packets, because when they're correctly +built, they will already be the right size. + +(f) TSO/GSO should be able to exactly undo GRO: the number of packets (TCP +segments) should not be modified, so that TCP's MSS counting works correctly +(this matters for congestion control). If protocol conversion changes the +gso_size, then the number of TCP segments may increase or decrease. Packet loss +after protocol conversion can result in partial loss of MSS segments that the +sender sent. How's the sending TCP stack going to react to receiving ACKs/SACKs +in the middle of the segments it sent? + +(g) skb_{decrease,increase}_gso_size() are already no-ops for GSO_BY_FRAGS +case (besides triggering WARN_ON_ONCE). This means you already cannot guarantee +that gso_size (and thus resulting packet MTU) is changed. ie. you must assume +it won't be changed. + +(h) changing gso_size is outright buggy for UDP GSO packets, where framing +matters (I believe that's also the case for SCTP, but it's already excluded +by [g]). So the only remaining case is TCP, which also doesn't want it +(see [f]). + +(i) see also the reasoning on the previous attempt at fixing this +(commit fa7b83bf3b156c767f3e4a25bbf3817b08f3ff8e) which shows that the current +behaviour causes TCP packet loss: + + In the forwarding path GRO -> BPF 6 to 4 -> GSO for TCP traffic, the + coalesced packet payload can be > MSS, but < MSS + 20. + + bpf_skb_proto_6_to_4() will upgrade the MSS and it can be > the payload + length. After then tcp_gso_segment checks for the payload length if it + is <= MSS. The condition is causing the packet to be dropped. + + tcp_gso_segment(): + [...] + mss = skb_shinfo(skb)->gso_size; + if (unlikely(skb->len <= mss)) goto out; + [...] + +Thus changing the gso_size is simply a very bad idea. Increasing is unnecessary +and buggy, and decreasing can go negative. + +Fixes: 6578171a7ff0 ("bpf: add bpf_skb_change_proto helper") +Signed-off-by: Maciej Å»enczykowski +Signed-off-by: Daniel Borkmann +Cc: Dongseok Yi +Cc: Willem de Bruijn +Link: https://lore.kernel.org/bpf/CANP3RGfjLikQ6dg=YpBU0OeHvyv7JOki7CyOUS9modaXAi-9vQ@mail.gmail.com +Link: https://lore.kernel.org/bpf/20210617000953.2787453-2-zenczykowski@gmail.com +Signed-off-by: Sasha Levin +--- + net/core/filter.c | 4 ---- + 1 file changed, 4 deletions(-) + +diff --git a/net/core/filter.c b/net/core/filter.c +index ef6bdbb63ecb..7ea752af7894 100644 +--- a/net/core/filter.c ++++ b/net/core/filter.c +@@ -3266,8 +3266,6 @@ static int bpf_skb_proto_4_to_6(struct sk_buff *skb) + shinfo->gso_type |= SKB_GSO_TCPV6; + } + +- /* Due to IPv6 header, MSS needs to be downgraded. */ +- skb_decrease_gso_size(shinfo, len_diff); + /* Header must be checked, and gso_segs recomputed. */ + shinfo->gso_type |= SKB_GSO_DODGY; + shinfo->gso_segs = 0; +@@ -3307,8 +3305,6 @@ static int bpf_skb_proto_6_to_4(struct sk_buff *skb) + shinfo->gso_type |= SKB_GSO_TCPV4; + } + +- /* Due to IPv4 header, MSS can be upgraded. */ +- skb_increase_gso_size(shinfo, len_diff); + /* Header must be checked, and gso_segs recomputed. */ + shinfo->gso_type |= SKB_GSO_DODGY; + shinfo->gso_segs = 0; +-- +2.30.2 + diff --git a/queue-5.10/bpf-fix-libelf-endian-handling-in-resolv_btfids.patch b/queue-5.10/bpf-fix-libelf-endian-handling-in-resolv_btfids.patch new file mode 100644 index 00000000000..e8534ea15b6 --- /dev/null +++ b/queue-5.10/bpf-fix-libelf-endian-handling-in-resolv_btfids.patch @@ -0,0 +1,58 @@ +From 20eeec43347ca38d5bcca3a3a56d15f4b76b0c6b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 23:14:04 -0700 +Subject: bpf: Fix libelf endian handling in resolv_btfids + +From: Tony Ambardar + +[ Upstream commit 61e8aeda9398925f8c6fc290585bdd9727d154c4 ] + +The vmlinux ".BTF_ids" ELF section is declared in btf_ids.h to hold a list +of zero-filled BTF IDs, which is then patched at link-time with correct +values by resolv_btfids. The section is flagged as "allocable" to preclude +compression, but notably the section contents (BTF IDs) are untyped. + +When patching the BTF IDs, resolve_btfids writes in host-native endianness +and relies on libelf for any required translation on reading and updating +vmlinux. However, since the type of the .BTF_ids section content defaults +to ELF_T_BYTE (i.e. unsigned char), no translation occurs. This results in +incorrect patched values when cross-compiling to non-native endianness, +and can manifest as kernel Oops and test failures which are difficult to +troubleshoot [1]. + +Explicitly set the type of patched data to ELF_T_WORD, the architecture- +neutral ELF type corresponding to the u32 BTF IDs. This enables libelf to +transparently perform any needed endian conversions. + +Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object") +Signed-off-by: Tony Ambardar +Signed-off-by: Daniel Borkmann +Acked-by: Jiri Olsa +Cc: Frank Eigler +Cc: Mark Wielaard +Cc: Jiri Olsa +Cc: Yonghong Song +Link: https://lore.kernel.org/bpf/CAPGftE_eY-Zdi3wBcgDfkz_iOr1KF10n=9mJHm1_a_PykcsoeA@mail.gmail.com [1] +Link: https://lore.kernel.org/bpf/20210618061404.818569-1-Tony.Ambardar@gmail.com +Signed-off-by: Sasha Levin +--- + tools/bpf/resolve_btfids/main.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c +index d636643ddd35..f32c059fbfb4 100644 +--- a/tools/bpf/resolve_btfids/main.c ++++ b/tools/bpf/resolve_btfids/main.c +@@ -649,6 +649,9 @@ static int symbols_patch(struct object *obj) + if (sets_patch(obj)) + return -1; + ++ /* Set type to ensure endian translation occurs. */ ++ obj->efile.idlist->d_type = ELF_T_WORD; ++ + elf_flagdata(obj->efile.idlist, ELF_C_SET, ELF_F_DIRTY); + + err = elf_update(obj->efile.elf, ELF_C_WRITE); +-- +2.30.2 + diff --git a/queue-5.10/bpf-fix-null-ptr-deref-with-mixed-tail-calls-and-sub.patch b/queue-5.10/bpf-fix-null-ptr-deref-with-mixed-tail-calls-and-sub.patch new file mode 100644 index 00000000000..7118654e4cf --- /dev/null +++ b/queue-5.10/bpf-fix-null-ptr-deref-with-mixed-tail-calls-and-sub.patch @@ -0,0 +1,129 @@ +From 21788c5725ee84efb31c294df3ad991d61f5c8d2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 15:55:00 -0700 +Subject: bpf: Fix null ptr deref with mixed tail calls and subprogs + +From: John Fastabend + +[ Upstream commit 7506d211b932870155bcb39e3dd9e39fab45a7c7 ] + +The sub-programs prog->aux->poke_tab[] is populated in jit_subprogs() and +then used when emitting 'BPF_JMP|BPF_TAIL_CALL' insn->code from the +individual JITs. The poke_tab[] to use is stored in the insn->imm by +the code adding it to that array slot. The JIT then uses imm to find the +right entry for an individual instruction. In the x86 bpf_jit_comp.c +this is done by calling emit_bpf_tail_call_direct with the poke_tab[] +of the imm value. + +However, we observed the below null-ptr-deref when mixing tail call +programs with subprog programs. For this to happen we just need to +mix bpf-2-bpf calls and tailcalls with some extra calls or instructions +that would be patched later by one of the fixup routines. So whats +happening? + +Before the fixup_call_args() -- where the jit op is done -- various +code patching is done by do_misc_fixups(). This may increase the +insn count, for example when we patch map_lookup_up using map_gen_lookup +hook. This does two things. First, it means the instruction index, +insn_idx field, of a tail call instruction will move by a 'delta'. + +In verifier code, + + struct bpf_jit_poke_descriptor desc = { + .reason = BPF_POKE_REASON_TAIL_CALL, + .tail_call.map = BPF_MAP_PTR(aux->map_ptr_state), + .tail_call.key = bpf_map_key_immediate(aux), + .insn_idx = i + delta, + }; + +Then subprog start values subprog_info[i].start will be updated +with the delta and any poke descriptor index will also be updated +with the delta in adjust_poke_desc(). If we look at the adjust +subprog starts though we see its only adjusted when the delta +occurs before the new instructions, + + /* NOTE: fake 'exit' subprog should be updated as well. */ + for (i = 0; i <= env->subprog_cnt; i++) { + if (env->subprog_info[i].start <= off) + continue; + +Earlier subprograms are not changed because their start values +are not moved. But, adjust_poke_desc() does the offset + delta +indiscriminately. The result is poke descriptors are potentially +corrupted. + +Then in jit_subprogs() we only populate the poke_tab[] +when the above insn_idx is less than the next subprogram start. From +above we corrupted our insn_idx so we might incorrectly assume a +poke descriptor is not used in a subprogram omitting it from the +subprogram. And finally when the jit runs it does the deref of poke_tab +when emitting the instruction and crashes with below. Because earlier +step omitted the poke descriptor. + +The fix is straight forward with above context. Simply move same logic +from adjust_subprog_starts() into adjust_poke_descs() and only adjust +insn_idx when needed. + +[ 82.396354] bpf_testmod: version magic '5.12.0-rc2alu+ SMP preempt mod_unload ' should be '5.12.0+ SMP preempt mod_unload ' +[ 82.623001] loop10: detected capacity change from 0 to 8 +[ 88.487424] ================================================================== +[ 88.487438] BUG: KASAN: null-ptr-deref in do_jit+0x184a/0x3290 +[ 88.487455] Write of size 8 at addr 0000000000000008 by task test_progs/5295 +[ 88.487471] CPU: 7 PID: 5295 Comm: test_progs Tainted: G I 5.12.0+ #386 +[ 88.487483] Hardware name: Dell Inc. Precision 5820 Tower/002KVM, BIOS 1.9.2 01/24/2019 +[ 88.487490] Call Trace: +[ 88.487498] dump_stack+0x93/0xc2 +[ 88.487515] kasan_report.cold+0x5f/0xd8 +[ 88.487530] ? do_jit+0x184a/0x3290 +[ 88.487542] do_jit+0x184a/0x3290 + ... +[ 88.487709] bpf_int_jit_compile+0x248/0x810 + ... +[ 88.487765] bpf_check+0x3718/0x5140 + ... +[ 88.487920] bpf_prog_load+0xa22/0xf10 + +Fixes: a748c6975dea3 ("bpf: propagate poke descriptors to subprograms") +Reported-by: Jussi Maki +Signed-off-by: John Fastabend +Signed-off-by: Alexei Starovoitov +Reviewed-by: Daniel Borkmann +Signed-off-by: Sasha Levin +--- + kernel/bpf/verifier.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c +index e97724e36dfb..bf6798fb2331 100644 +--- a/kernel/bpf/verifier.c ++++ b/kernel/bpf/verifier.c +@@ -10532,7 +10532,7 @@ static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len + } + } + +-static void adjust_poke_descs(struct bpf_prog *prog, u32 len) ++static void adjust_poke_descs(struct bpf_prog *prog, u32 off, u32 len) + { + struct bpf_jit_poke_descriptor *tab = prog->aux->poke_tab; + int i, sz = prog->aux->size_poke_tab; +@@ -10540,6 +10540,8 @@ static void adjust_poke_descs(struct bpf_prog *prog, u32 len) + + for (i = 0; i < sz; i++) { + desc = &tab[i]; ++ if (desc->insn_idx <= off) ++ continue; + desc->insn_idx += len - 1; + } + } +@@ -10560,7 +10562,7 @@ static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 of + if (adjust_insn_aux_data(env, new_prog, off, len)) + return NULL; + adjust_subprog_starts(env, off, len); +- adjust_poke_descs(new_prog, len); ++ adjust_poke_descs(new_prog, off, len); + return new_prog; + } + +-- +2.30.2 + diff --git a/queue-5.10/bpfilter-specify-the-log-level-for-the-kmsg-message.patch b/queue-5.10/bpfilter-specify-the-log-level-for-the-kmsg-message.patch new file mode 100644 index 00000000000..0f81486f27e --- /dev/null +++ b/queue-5.10/bpfilter-specify-the-log-level-for-the-kmsg-message.patch @@ -0,0 +1,45 @@ +From 7b0312888b7b94bf8b18ad4dcea98ee4c2015ea8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 12:09:18 +0800 +Subject: bpfilter: Specify the log level for the kmsg message + +From: Gary Lin + +[ Upstream commit a196fa78a26571359740f701cf30d774eb8a72cb ] + +Per the kmsg document [0], if we don't specify the log level with a +prefix "" in the message string, the default log level will be +applied to the message. Since the default level could be warning(4), +this would make the log utility such as journalctl treat the message, +"Started bpfilter", as a warning. To avoid confusion, this commit +adds the prefix "<5>" to make the message always a notice. + + [0] https://www.kernel.org/doc/Documentation/ABI/testing/dev-kmsg + +Fixes: 36c4357c63f3 ("net: bpfilter: print umh messages to /dev/kmsg") +Reported-by: Martin Loviska +Signed-off-by: Gary Lin +Signed-off-by: Daniel Borkmann +Acked-by: Dmitrii Banshchikov +Link: https://lore.kernel.org/bpf/20210623040918.8683-1-glin@suse.com +Signed-off-by: Sasha Levin +--- + net/bpfilter/main.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c +index 05e1cfc1e5cd..291a92546246 100644 +--- a/net/bpfilter/main.c ++++ b/net/bpfilter/main.c +@@ -57,7 +57,7 @@ int main(void) + { + debug_f = fopen("/dev/kmsg", "w"); + setvbuf(debug_f, 0, _IOLBF, 0); +- fprintf(debug_f, "Started bpfilter\n"); ++ fprintf(debug_f, "<5>Started bpfilter\n"); + loop(); + fclose(debug_f); + return 0; +-- +2.30.2 + diff --git a/queue-5.10/brcmfmac-correctly-report-average-rssi-in-station-in.patch b/queue-5.10/brcmfmac-correctly-report-average-rssi-in-station-in.patch new file mode 100644 index 00000000000..e3238893f85 --- /dev/null +++ b/queue-5.10/brcmfmac-correctly-report-average-rssi-in-station-in.patch @@ -0,0 +1,87 @@ +From 5304078e94dd01c7809677811d405450451bd4d5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 6 May 2021 13:20:12 +0000 +Subject: brcmfmac: correctly report average RSSI in station info +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Alvin Å ipraga + +[ Upstream commit 9a1590934d9a02e570636432b93052c0c035f31f ] + +The rx_lastpkt_rssi field provided by the firmware is suitable for +NL80211_STA_INFO_{SIGNAL,CHAIN_SIGNAL}, while the rssi field is an +average. Fix up the assignments and set the correct STA_INFO bits. This +lets userspace know that the average RSSI is part of the station info. + +Fixes: cae355dc90db ("brcmfmac: Add RSSI information to get_station.") +Signed-off-by: Alvin Å ipraga +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210506132010.3964484-2-alsi@bang-olufsen.dk +Signed-off-by: Sasha Levin +--- + .../broadcom/brcm80211/brcmfmac/cfg80211.c | 36 ++++++++++--------- + 1 file changed, 20 insertions(+), 16 deletions(-) + +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +index 8c3c7755e949..c2b6e5c966d0 100644 +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +@@ -2767,8 +2767,9 @@ brcmf_cfg80211_get_station(struct wiphy *wiphy, struct net_device *ndev, + struct brcmf_sta_info_le sta_info_le; + u32 sta_flags; + u32 is_tdls_peer; +- s32 total_rssi; +- s32 count_rssi; ++ s32 total_rssi_avg = 0; ++ s32 total_rssi = 0; ++ s32 count_rssi = 0; + int rssi; + u32 i; + +@@ -2834,24 +2835,27 @@ brcmf_cfg80211_get_station(struct wiphy *wiphy, struct net_device *ndev, + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_BYTES); + sinfo->rx_bytes = le64_to_cpu(sta_info_le.rx_tot_bytes); + } +- total_rssi = 0; +- count_rssi = 0; + for (i = 0; i < BRCMF_ANT_MAX; i++) { +- if (sta_info_le.rssi[i]) { +- sinfo->chains |= BIT(count_rssi); +- sinfo->chain_signal_avg[count_rssi] = +- sta_info_le.rssi[i]; +- sinfo->chain_signal[count_rssi] = +- sta_info_le.rssi[i]; +- total_rssi += sta_info_le.rssi[i]; +- count_rssi++; +- } ++ if (sta_info_le.rssi[i] == 0 || ++ sta_info_le.rx_lastpkt_rssi[i] == 0) ++ continue; ++ sinfo->chains |= BIT(count_rssi); ++ sinfo->chain_signal[count_rssi] = ++ sta_info_le.rx_lastpkt_rssi[i]; ++ sinfo->chain_signal_avg[count_rssi] = ++ sta_info_le.rssi[i]; ++ total_rssi += sta_info_le.rx_lastpkt_rssi[i]; ++ total_rssi_avg += sta_info_le.rssi[i]; ++ count_rssi++; + } + if (count_rssi) { +- sinfo->filled |= BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL); + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL); +- total_rssi /= count_rssi; +- sinfo->signal = total_rssi; ++ sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL_AVG); ++ sinfo->filled |= BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL); ++ sinfo->filled |= ++ BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL_AVG); ++ sinfo->signal = total_rssi / count_rssi; ++ sinfo->signal_avg = total_rssi_avg / count_rssi; + } else if (test_bit(BRCMF_VIF_STATUS_CONNECTED, + &ifp->vif->sme_state)) { + memset(&scb_val, 0, sizeof(scb_val)); +-- +2.30.2 + diff --git a/queue-5.10/brcmfmac-fix-a-double-free-in-brcmf_sdio_bus_reset.patch b/queue-5.10/brcmfmac-fix-a-double-free-in-brcmf_sdio_bus_reset.patch new file mode 100644 index 00000000000..15c4997c64e --- /dev/null +++ b/queue-5.10/brcmfmac-fix-a-double-free-in-brcmf_sdio_bus_reset.patch @@ -0,0 +1,38 @@ +From 95621ff6766a8aaa031871d0629b71f5a8c69a8b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 18:01:28 +0800 +Subject: brcmfmac: Fix a double-free in brcmf_sdio_bus_reset + +From: Tong Tiangen + +[ Upstream commit 7ea7a1e05c7ff5ffc9f9ec1f0849f6ceb7fcd57c ] + +brcmf_sdiod_remove has been called inside brcmf_sdiod_probe when fails, +so there's no need to call another one. Otherwise, sdiodev->freezer +would be double freed. + +Fixes: 7836102a750a ("brcmfmac: reset SDIO bus on a firmware crash") +Signed-off-by: Tong Tiangen +Reviewed-by: Arend van Spriel +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210601100128.69561-1-tongtiangen@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +index 59c2b2b6027d..6d5d5c39c635 100644 +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +@@ -4157,7 +4157,6 @@ static int brcmf_sdio_bus_reset(struct device *dev) + if (ret) { + brcmf_err("Failed to probe after sdio device reset: ret %d\n", + ret); +- brcmf_sdiod_remove(sdiodev); + } + + return ret; +-- +2.30.2 + diff --git a/queue-5.10/brcmfmac-fix-setting-of-station-info-chains-bitmask.patch b/queue-5.10/brcmfmac-fix-setting-of-station-info-chains-bitmask.patch new file mode 100644 index 00000000000..ce916515187 --- /dev/null +++ b/queue-5.10/brcmfmac-fix-setting-of-station-info-chains-bitmask.patch @@ -0,0 +1,61 @@ +From c5d00613a478a054816bf3c4b5e5d3f76d05885d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 6 May 2021 13:20:12 +0000 +Subject: brcmfmac: fix setting of station info chains bitmask +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Alvin Å ipraga + +[ Upstream commit feb45643762172110cb3a44f99dd54304f33b711 ] + +The sinfo->chains field is a bitmask for filled values in chain_signal +and chain_signal_avg, not a count. Treat it as such so that the driver +can properly report per-chain RSSI information. + +Before (MIMO mode): + + $ iw dev wlan0 station dump + ... + signal: -51 [-51] dBm + +After (MIMO mode): + + $ iw dev wlan0 station dump + ... + signal: -53 [-53, -54] dBm + +Fixes: cae355dc90db ("brcmfmac: Add RSSI information to get_station.") +Signed-off-by: Alvin Å ipraga +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210506132010.3964484-1-alsi@bang-olufsen.dk +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +index 23e6422c2251..8c3c7755e949 100644 +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +@@ -2838,6 +2838,7 @@ brcmf_cfg80211_get_station(struct wiphy *wiphy, struct net_device *ndev, + count_rssi = 0; + for (i = 0; i < BRCMF_ANT_MAX; i++) { + if (sta_info_le.rssi[i]) { ++ sinfo->chains |= BIT(count_rssi); + sinfo->chain_signal_avg[count_rssi] = + sta_info_le.rssi[i]; + sinfo->chain_signal[count_rssi] = +@@ -2848,8 +2849,6 @@ brcmf_cfg80211_get_station(struct wiphy *wiphy, struct net_device *ndev, + } + if (count_rssi) { + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_CHAIN_SIGNAL); +- sinfo->chains = count_rssi; +- + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL); + total_rssi /= count_rssi; + sinfo->signal = total_rssi; +-- +2.30.2 + diff --git a/queue-5.10/brcmsmac-mac80211_if-fix-a-resource-leak-in-an-error.patch b/queue-5.10/brcmsmac-mac80211_if-fix-a-resource-leak-in-an-error.patch new file mode 100644 index 00000000000..c7b160bb04f --- /dev/null +++ b/queue-5.10/brcmsmac-mac80211_if-fix-a-resource-leak-in-an-error.patch @@ -0,0 +1,55 @@ +From 6f6455a5a56dfb721f556368f6bd38c96393c60b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 22:58:30 +0200 +Subject: brcmsmac: mac80211_if: Fix a resource leak in an error handling path + +From: Christophe JAILLET + +[ Upstream commit 9a25344d5177c2b9285532236dc3d10a091f39a8 ] + +If 'brcms_attach()' fails, we must undo the previous 'ieee80211_alloc_hw()' +as already done in the remove function. + +Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers") +Signed-off-by: Christophe JAILLET +Acked-by: Arend van Spriel +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/8fbc171a1a493b38db5a6f0873c6021fca026a6c.1620852921.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Sasha Levin +--- + .../wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +index 818e523f6025..fb76b4a69a05 100644 +--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +@@ -1221,6 +1221,7 @@ static int brcms_bcma_probe(struct bcma_device *pdev) + { + struct brcms_info *wl; + struct ieee80211_hw *hw; ++ int ret; + + dev_info(&pdev->dev, "mfg %x core %x rev %d class %d irq %d\n", + pdev->id.manuf, pdev->id.id, pdev->id.rev, pdev->id.class, +@@ -1245,11 +1246,16 @@ static int brcms_bcma_probe(struct bcma_device *pdev) + wl = brcms_attach(pdev); + if (!wl) { + pr_err("%s: brcms_attach failed!\n", __func__); +- return -ENODEV; ++ ret = -ENODEV; ++ goto err_free_ieee80211; + } + brcms_led_register(wl); + + return 0; ++ ++err_free_ieee80211: ++ ieee80211_free_hw(hw); ++ return ret; + } + + static int brcms_suspend(struct bcma_device *pdev) +-- +2.30.2 + diff --git a/queue-5.10/btrfs-abort-transaction-if-we-fail-to-update-the-del.patch b/queue-5.10/btrfs-abort-transaction-if-we-fail-to-update-the-del.patch new file mode 100644 index 00000000000..ff574623f50 --- /dev/null +++ b/queue-5.10/btrfs-abort-transaction-if-we-fail-to-update-the-del.patch @@ -0,0 +1,43 @@ +From 5d383f5ff809b6a2f26712e96fda1308903b2290 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 16:44:09 -0400 +Subject: btrfs: abort transaction if we fail to update the delayed inode + +From: Josef Bacik + +[ Upstream commit 04587ad9bef6ce9d510325b4ba9852b6129eebdb ] + +If we fail to update the delayed inode we need to abort the transaction, +because we could leave an inode with the improper counts or some other +such corruption behind. + +Signed-off-by: Josef Bacik +Reviewed-by: David Sterba +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/delayed-inode.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c +index 3af06ef98b12..04422d929c23 100644 +--- a/fs/btrfs/delayed-inode.c ++++ b/fs/btrfs/delayed-inode.c +@@ -1073,6 +1073,14 @@ err_out: + btrfs_delayed_inode_release_metadata(fs_info, node, (ret < 0)); + btrfs_release_delayed_inode(node); + ++ /* ++ * If we fail to update the delayed inode we need to abort the ++ * transaction, because we could leave the inode with the improper ++ * counts behind. ++ */ ++ if (ret && ret != -ENOENT) ++ btrfs_abort_transaction(trans, ret); ++ + return ret; + + search: +-- +2.30.2 + diff --git a/queue-5.10/btrfs-clear-log-tree-recovering-status-if-starting-t.patch b/queue-5.10/btrfs-clear-log-tree-recovering-status-if-starting-t.patch new file mode 100644 index 00000000000..c595a3d7fd8 --- /dev/null +++ b/queue-5.10/btrfs-clear-log-tree-recovering-status-if-starting-t.patch @@ -0,0 +1,44 @@ +From 694de48876ca48a72e0edd33941c5f01f671ec31 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 Jul 2020 18:38:05 +0200 +Subject: btrfs: clear log tree recovering status if starting transaction fails + +From: David Sterba + +[ Upstream commit 1aeb6b563aea18cd55c73cf666d1d3245a00f08c ] + +When a log recovery is in progress, lots of operations have to take that +into account, so we keep this status per tree during the operation. Long +time ago error handling revamp patch 79787eaab461 ("btrfs: replace many +BUG_ONs with proper error handling") removed clearing of the status in +an error branch. Add it back as was intended in e02119d5a7b4 ("Btrfs: +Add a write ahead tree log to optimize synchronous operations"). + +There are probably no visible effects, log replay is done only during +mount and if it fails all structures are cleared so the stale status +won't be kept. + +Fixes: 79787eaab461 ("btrfs: replace many BUG_ONs with proper error handling") +Reviewed-by: Qu Wenruo +Reviewed-by: Anand Jain +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/tree-log.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c +index 300951088a11..4b913de2f24f 100644 +--- a/fs/btrfs/tree-log.c ++++ b/fs/btrfs/tree-log.c +@@ -6348,6 +6348,7 @@ next: + error: + if (wc.trans) + btrfs_end_transaction(wc.trans); ++ clear_bit(BTRFS_FS_LOG_RECOVERING, &fs_info->flags); + btrfs_free_path(path); + return ret; + } +-- +2.30.2 + diff --git a/queue-5.10/btrfs-disable-build-on-platforms-having-page-size-25.patch b/queue-5.10/btrfs-disable-build-on-platforms-having-page-size-25.patch new file mode 100644 index 00000000000..d6175422052 --- /dev/null +++ b/queue-5.10/btrfs-disable-build-on-platforms-having-page-size-25.patch @@ -0,0 +1,54 @@ +From 71de3f6cf91d90c1c127944097550731cddb1ace Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 05:23:02 +0000 +Subject: btrfs: disable build on platforms having page size 256K + +From: Christophe Leroy + +[ Upstream commit b05fbcc36be1f8597a1febef4892053a0b2f3f60 ] + +With a config having PAGE_SIZE set to 256K, BTRFS build fails +with the following message + + include/linux/compiler_types.h:326:38: error: call to + '__compiletime_assert_791' declared with attribute error: + BUILD_BUG_ON failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) != 0 + +BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms with +256K pages at the time being. + +There are two platforms that can select 256K pages: + - hexagon + - powerpc + +Disable BTRFS when 256K page size is selected. Supporting this would +require changes to the subpage mode that's currently being developed. +Given that 256K is many times larger than page sizes commonly used and +for what the algorithms and structures have been tuned, it's out of +scope and disabling build is a reasonable option. + +Reported-by: kernel test robot +Signed-off-by: Christophe Leroy +[ update changelog ] +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/Kconfig | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig +index 68b95ad82126..520a0f6a7d9e 100644 +--- a/fs/btrfs/Kconfig ++++ b/fs/btrfs/Kconfig +@@ -18,6 +18,8 @@ config BTRFS_FS + select RAID6_PQ + select XOR_BLOCKS + select SRCU ++ depends on !PPC_256K_PAGES # powerpc ++ depends on !PAGE_SIZE_256KB # hexagon + + help + Btrfs is a general purpose copy-on-write filesystem with extents, +-- +2.30.2 + diff --git a/queue-5.10/btrfs-don-t-clear-page-extent-mapped-if-we-re-not-in.patch b/queue-5.10/btrfs-don-t-clear-page-extent-mapped-if-we-re-not-in.patch new file mode 100644 index 00000000000..b16082b59ad --- /dev/null +++ b/queue-5.10/btrfs-don-t-clear-page-extent-mapped-if-we-re-not-in.patch @@ -0,0 +1,83 @@ +From e47da9553dd9b62b6785b33ce6c7566d547e4994 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 16:50:55 +0800 +Subject: btrfs: don't clear page extent mapped if we're not invalidating the + full page + +From: Qu Wenruo + +[ Upstream commit bcd77455d590eaa0422a5e84ae852007cfce574a ] + +[BUG] +With current btrfs subpage rw support, the following script can lead to +fs hang: + + $ mkfs.btrfs -f -s 4k $dev + $ mount $dev -o nospace_cache $mnt + $ fsstress -w -n 100 -p 1 -s 1608140256 -v -d $mnt + +The fs will hang at btrfs_start_ordered_extent(). + +[CAUSE] +In above test case, btrfs_invalidate() will be called with the following +parameters: + + offset = 0 length = 53248 page dirty = 1 subpage dirty bitmap = 0x2000 + +Since @offset is 0, btrfs_invalidate() will try to invalidate the full +page, and finally call clear_page_extent_mapped() which will detach +subpage structure from the page. + +And since the page no longer has subpage structure, the subpage dirty +bitmap will be cleared, preventing the dirty range from being written +back, thus no way to wake up the ordered extent. + +[FIX] +Just follow other filesystems, only to invalidate the page if the range +covers the full page. + +There are cases like truncate_setsize() which can call +btrfs_invalidatepage() with offset == 0 and length != 0 for the last +page of an inode. + +Although the old code will still try to invalidate the full page, we are +still safe to just wait for ordered extent to finish. +So it shouldn't cause extra problems. + +Tested-by: Ritesh Harjani # [ppc64] +Tested-by: Anand Jain # [aarch64] +Signed-off-by: Qu Wenruo +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/inode.c | 14 +++++++++++++- + 1 file changed, 13 insertions(+), 1 deletion(-) + +diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c +index a03d3bad2139..4f21b8fbfd4b 100644 +--- a/fs/btrfs/inode.c ++++ b/fs/btrfs/inode.c +@@ -8213,7 +8213,19 @@ static void btrfs_invalidatepage(struct page *page, unsigned int offset, + */ + wait_on_page_writeback(page); + +- if (offset) { ++ /* ++ * For subpage case, we have call sites like ++ * btrfs_punch_hole_lock_range() which passes range not aligned to ++ * sectorsize. ++ * If the range doesn't cover the full page, we don't need to and ++ * shouldn't clear page extent mapped, as page->private can still ++ * record subpage dirty bits for other part of the range. ++ * ++ * For cases that can invalidate the full even the range doesn't ++ * cover the full page, like invalidating the last page, we're ++ * still safe to wait for ordered extent to finish. ++ */ ++ if (!(offset == 0 && length == PAGE_SIZE)) { + btrfs_releasepage(page, GFP_NOFS); + return; + } +-- +2.30.2 + diff --git a/queue-5.10/btrfs-fix-error-handling-in-__btrfs_update_delayed_i.patch b/queue-5.10/btrfs-fix-error-handling-in-__btrfs_update_delayed_i.patch new file mode 100644 index 00000000000..aed1b64f353 --- /dev/null +++ b/queue-5.10/btrfs-fix-error-handling-in-__btrfs_update_delayed_i.patch @@ -0,0 +1,73 @@ +From 6cb559f8a9b5ff4c76062030b04a08d30297fbcc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 16:44:08 -0400 +Subject: btrfs: fix error handling in __btrfs_update_delayed_inode + +From: Josef Bacik + +[ Upstream commit bb385bedded3ccbd794559600de4a09448810f4a ] + +If we get an error while looking up the inode item we'll simply bail +without cleaning up the delayed node. This results in this style of +warning happening on commit: + + WARNING: CPU: 0 PID: 76403 at fs/btrfs/delayed-inode.c:1365 btrfs_assert_delayed_root_empty+0x5b/0x90 + CPU: 0 PID: 76403 Comm: fsstress Tainted: G W 5.13.0-rc1+ #373 + Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014 + RIP: 0010:btrfs_assert_delayed_root_empty+0x5b/0x90 + RSP: 0018:ffffb8bb815a7e50 EFLAGS: 00010286 + RAX: 0000000000000000 RBX: ffff95d6d07e1888 RCX: ffff95d6c0fa3000 + RDX: 0000000000000002 RSI: 000000000029e91c RDI: ffff95d6c0fc8060 + RBP: ffff95d6c0fc8060 R08: 00008d6d701a2c1d R09: 0000000000000000 + R10: ffff95d6d1760ea0 R11: 0000000000000001 R12: ffff95d6c15a4d00 + R13: ffff95d6c0fa3000 R14: 0000000000000000 R15: ffffb8bb815a7e90 + FS: 00007f490e8dbb80(0000) GS:ffff95d73bc00000(0000) knlGS:0000000000000000 + CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 + CR2: 00007f6e75555cb0 CR3: 00000001101ce001 CR4: 0000000000370ef0 + Call Trace: + btrfs_commit_transaction+0x43c/0xb00 + ? finish_wait+0x80/0x80 + ? vfs_fsync_range+0x90/0x90 + iterate_supers+0x8c/0x100 + ksys_sync+0x50/0x90 + __do_sys_sync+0xa/0x10 + do_syscall_64+0x3d/0x80 + entry_SYSCALL_64_after_hwframe+0x44/0xae + +Because the iref isn't dropped and this leaves an elevated node->count, +so any release just re-queues it onto the delayed inodes list. Fix this +by going to the out label to handle the proper cleanup of the delayed +node. + +Signed-off-by: Josef Bacik +Reviewed-by: David Sterba +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/delayed-inode.c | 10 ++++------ + 1 file changed, 4 insertions(+), 6 deletions(-) + +diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c +index 4e2cce5ca7f6..3af06ef98b12 100644 +--- a/fs/btrfs/delayed-inode.c ++++ b/fs/btrfs/delayed-inode.c +@@ -1032,12 +1032,10 @@ static int __btrfs_update_delayed_inode(struct btrfs_trans_handle *trans, + nofs_flag = memalloc_nofs_save(); + ret = btrfs_lookup_inode(trans, root, path, &key, mod); + memalloc_nofs_restore(nofs_flag); +- if (ret > 0) { +- btrfs_release_path(path); +- return -ENOENT; +- } else if (ret < 0) { +- return ret; +- } ++ if (ret > 0) ++ ret = -ENOENT; ++ if (ret < 0) ++ goto out; + + leaf = path->nodes[0]; + inode_item = btrfs_item_ptr(leaf, path->slots[0], +-- +2.30.2 + diff --git a/queue-5.10/btrfs-fix-the-filemap_range_has_page-call-in-btrfs_p.patch b/queue-5.10/btrfs-fix-the-filemap_range_has_page-call-in-btrfs_p.patch new file mode 100644 index 00000000000..67bfc84202d --- /dev/null +++ b/queue-5.10/btrfs-fix-the-filemap_range_has_page-call-in-btrfs_p.patch @@ -0,0 +1,104 @@ +From 1c44f53f6296370c39909233738392fdb0f69cbc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 16:50:54 +0800 +Subject: btrfs: fix the filemap_range_has_page() call in + btrfs_punch_hole_lock_range() + +From: Qu Wenruo + +[ Upstream commit 0528476b6ac7832f31e2ed740a57ae31316b124e ] + +[BUG] +With current subpage RW support, the following script can hang the fs +with 64K page size. + + # mkfs.btrfs -f -s 4k $dev + # mount $dev -o nospace_cache $mnt + # fsstress -w -n 50 -p 1 -s 1607749395 -d $mnt + +The kernel will do an infinite loop in btrfs_punch_hole_lock_range(). + +[CAUSE] +In btrfs_punch_hole_lock_range() we: + +- Truncate page cache range +- Lock extent io tree +- Wait any ordered extents in the range. + +We exit the loop until we meet all the following conditions: + +- No ordered extent in the lock range +- No page is in the lock range + +The latter condition has a pitfall, it only works for sector size == +PAGE_SIZE case. + +While can't handle the following subpage case: + + 0 32K 64K 96K 128K + | |///////||//////| || + +lockstart=32K +lockend=96K - 1 + +In this case, although the range crosses 2 pages, +truncate_pagecache_range() will invalidate no page at all, but only zero +the [32K, 96K) range of the two pages. + +Thus filemap_range_has_page(32K, 96K-1) will always return true, thus we +will never meet the loop exit condition. + +[FIX] +Fix the problem by doing page alignment for the lock range. + +Function filemap_range_has_page() has already handled lend < lstart +case, we only need to round up @lockstart, and round_down @lockend for +truncate_pagecache_range(). + +This modification should not change any thing for sector size == +PAGE_SIZE case, as in that case our range is already page aligned. + +Tested-by: Ritesh Harjani # [ppc64] +Tested-by: Anand Jain # [aarch64] +Signed-off-by: Qu Wenruo +Reviewed-by: David Sterba +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/file.c | 13 ++++++++++++- + 1 file changed, 12 insertions(+), 1 deletion(-) + +diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c +index ffa48ac98d1e..fdff99afb0be 100644 +--- a/fs/btrfs/file.c ++++ b/fs/btrfs/file.c +@@ -2485,6 +2485,17 @@ static int btrfs_punch_hole_lock_range(struct inode *inode, + const u64 lockend, + struct extent_state **cached_state) + { ++ /* ++ * For subpage case, if the range is not at page boundary, we could ++ * have pages at the leading/tailing part of the range. ++ * This could lead to dead loop since filemap_range_has_page() ++ * will always return true. ++ * So here we need to do extra page alignment for ++ * filemap_range_has_page(). ++ */ ++ const u64 page_lockstart = round_up(lockstart, PAGE_SIZE); ++ const u64 page_lockend = round_down(lockend + 1, PAGE_SIZE) - 1; ++ + while (1) { + struct btrfs_ordered_extent *ordered; + int ret; +@@ -2505,7 +2516,7 @@ static int btrfs_punch_hole_lock_range(struct inode *inode, + (ordered->file_offset + ordered->num_bytes <= lockstart || + ordered->file_offset > lockend)) && + !filemap_range_has_page(inode->i_mapping, +- lockstart, lockend)) { ++ page_lockstart, page_lockend)) { + if (ordered) + btrfs_put_ordered_extent(ordered); + break; +-- +2.30.2 + diff --git a/queue-5.10/btrfs-sysfs-fix-format-string-for-some-discard-stats.patch b/queue-5.10/btrfs-sysfs-fix-format-string-for-some-discard-stats.patch new file mode 100644 index 00000000000..9ea177487ab --- /dev/null +++ b/queue-5.10/btrfs-sysfs-fix-format-string-for-some-discard-stats.patch @@ -0,0 +1,46 @@ +From 0bdea8ae4d2fa9175a197512f2f47d3603b4f2ad Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 7 May 2021 20:00:14 +0200 +Subject: btrfs: sysfs: fix format string for some discard stats + +From: David Sterba + +[ Upstream commit 8c5ec995616f1202ab92e195fd75d6f60d86f85c ] + +The type of discard_bitmap_bytes and discard_extent_bytes is u64 so the +format should be %llu, though the actual values would hardly ever +overflow to negative values. + +Reviewed-by: Qu Wenruo +Reviewed-by: Anand Jain +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/sysfs.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c +index 279d9262b676..3bb6b688ece5 100644 +--- a/fs/btrfs/sysfs.c ++++ b/fs/btrfs/sysfs.c +@@ -382,7 +382,7 @@ static ssize_t btrfs_discard_bitmap_bytes_show(struct kobject *kobj, + { + struct btrfs_fs_info *fs_info = discard_to_fs_info(kobj); + +- return scnprintf(buf, PAGE_SIZE, "%lld\n", ++ return scnprintf(buf, PAGE_SIZE, "%llu\n", + fs_info->discard_ctl.discard_bitmap_bytes); + } + BTRFS_ATTR(discard, discard_bitmap_bytes, btrfs_discard_bitmap_bytes_show); +@@ -404,7 +404,7 @@ static ssize_t btrfs_discard_extent_bytes_show(struct kobject *kobj, + { + struct btrfs_fs_info *fs_info = discard_to_fs_info(kobj); + +- return scnprintf(buf, PAGE_SIZE, "%lld\n", ++ return scnprintf(buf, PAGE_SIZE, "%llu\n", + fs_info->discard_ctl.discard_extent_bytes); + } + BTRFS_ATTR(discard, discard_extent_bytes, btrfs_discard_extent_bytes_show); +-- +2.30.2 + diff --git a/queue-5.10/can-j1939-j1939_sk_setsockopt-prevent-allocation-of-.patch b/queue-5.10/can-j1939-j1939_sk_setsockopt-prevent-allocation-of-.patch new file mode 100644 index 00000000000..59f77c783af --- /dev/null +++ b/queue-5.10/can-j1939-j1939_sk_setsockopt-prevent-allocation-of-.patch @@ -0,0 +1,42 @@ +From 99871fef18073addaf56f522afb3d38810a351ee Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 20 Jun 2021 14:38:42 +0200 +Subject: can: j1939: j1939_sk_setsockopt(): prevent allocation of j1939 filter + for optlen == 0 + +From: Norbert Slusarek + +[ Upstream commit aaf473d0100f64abc88560e2bea905805bcf2a8e ] + +If optval != NULL and optlen == 0 are specified for SO_J1939_FILTER in +j1939_sk_setsockopt(), memdup_sockptr() will return ZERO_PTR for 0 +size allocation. The new filter will be mistakenly assigned ZERO_PTR. +This patch checks for optlen != 0 and filter will be assigned NULL in +case of optlen == 0. + +Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") +Link: https://lore.kernel.org/r/20210620123842.117975-1-nslusarek@gmx.net +Signed-off-by: Norbert Slusarek +Acked-by: Oleksij Rempel +Signed-off-by: Marc Kleine-Budde +Signed-off-by: Sasha Levin +--- + net/can/j1939/socket.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c +index fce8bc8afeb7..e1a399821238 100644 +--- a/net/can/j1939/socket.c ++++ b/net/can/j1939/socket.c +@@ -676,7 +676,7 @@ static int j1939_sk_setsockopt(struct socket *sock, int level, int optname, + + switch (optname) { + case SO_J1939_FILTER: +- if (!sockptr_is_null(optval)) { ++ if (!sockptr_is_null(optval) && optlen != 0) { + struct j1939_filter *f; + int c; + +-- +2.30.2 + diff --git a/queue-5.10/char-pcmcia-error-out-if-num_bytes_read-is-greater-t.patch b/queue-5.10/char-pcmcia-error-out-if-num_bytes_read-is-greater-t.patch new file mode 100644 index 00000000000..216d4a73877 --- /dev/null +++ b/queue-5.10/char-pcmcia-error-out-if-num_bytes_read-is-greater-t.patch @@ -0,0 +1,41 @@ +From 3f1f08fc52b7fa8a6f80bfd88a6d75de53d389d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 20:06:17 +0800 +Subject: char: pcmcia: error out if 'num_bytes_read' is greater than 4 in + set_protocol() + +From: Yu Kuai + +[ Upstream commit 37188559c610f1b7eec83c8e448936c361c578de ] + +Theoretically, it will cause index out of bounds error if +'num_bytes_read' is greater than 4. As we expect it(and was tested) +never to be greater than 4, error out if it happens. + +Fixes: c1986ee9bea3 ("[PATCH] New Omnikey Cardman 4000 driver") +Signed-off-by: Yu Kuai +Link: https://lore.kernel.org/r/20210521120617.138396-1-yukuai3@huawei.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/char/pcmcia/cm4000_cs.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c +index 89681f07bc78..9468e9520cee 100644 +--- a/drivers/char/pcmcia/cm4000_cs.c ++++ b/drivers/char/pcmcia/cm4000_cs.c +@@ -544,6 +544,10 @@ static int set_protocol(struct cm4000_dev *dev, struct ptsreq *ptsreq) + io_read_num_rec_bytes(iobase, &num_bytes_read); + if (num_bytes_read >= 4) { + DEBUGP(2, dev, "NumRecBytes = %i\n", num_bytes_read); ++ if (num_bytes_read > 4) { ++ rc = -EIO; ++ goto exit_setprotocol; ++ } + break; + } + usleep_range(10000, 11000); +-- +2.30.2 + diff --git a/queue-5.10/cifs-fix-missing-spinlock-around-update-to-ses-statu.patch b/queue-5.10/cifs-fix-missing-spinlock-around-update-to-ses-statu.patch new file mode 100644 index 00000000000..302c367940b --- /dev/null +++ b/queue-5.10/cifs-fix-missing-spinlock-around-update-to-ses-statu.patch @@ -0,0 +1,63 @@ +From b05e8b12d2c3f4bf1f3a8287b1ea4f3954b4a742 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 15:28:04 -0500 +Subject: cifs: fix missing spinlock around update to ses->status + +From: Steve French + +[ Upstream commit 0060a4f28a9ef45ae8163c0805e944a2b1546762 ] + +In the other places where we update ses->status we protect the +updates via GlobalMid_Lock. So to be consistent add the same +locking around it in cifs_put_smb_ses where it was missing. + +Addresses-Coverity: 1268904 ("Data race condition") +Signed-off-by: Steve French +Signed-off-by: Sasha Levin +--- + fs/cifs/cifsglob.h | 3 ++- + fs/cifs/connect.c | 5 ++++- + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h +index 248ee81e0151..6599069be690 100644 +--- a/fs/cifs/cifsglob.h ++++ b/fs/cifs/cifsglob.h +@@ -979,7 +979,7 @@ struct cifs_ses { + struct mutex session_mutex; + struct TCP_Server_Info *server; /* pointer to server info */ + int ses_count; /* reference counter */ +- enum statusEnum status; ++ enum statusEnum status; /* updates protected by GlobalMid_Lock */ + unsigned overrideSecFlg; /* if non-zero override global sec flags */ + char *serverOS; /* name of operating system underlying server */ + char *serverNOS; /* name of network operating system of server */ +@@ -1863,6 +1863,7 @@ require use of the stronger protocol */ + * list operations on pending_mid_q and oplockQ + * updates to XID counters, multiplex id and SMB sequence numbers + * list operations on global DnotifyReqList ++ * updates to ses->status + * tcp_ses_lock protects: + * list operations on tcp and SMB session lists + * tcon->open_file_lock protects the list of open files hanging off the tcon +diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c +index aabaebd1535f..fb7088d57e46 100644 +--- a/fs/cifs/connect.c ++++ b/fs/cifs/connect.c +@@ -2829,9 +2829,12 @@ void cifs_put_smb_ses(struct cifs_ses *ses) + spin_unlock(&cifs_tcp_ses_lock); + return; + } ++ spin_unlock(&cifs_tcp_ses_lock); ++ ++ spin_lock(&GlobalMid_Lock); + if (ses->status == CifsGood) + ses->status = CifsExiting; +- spin_unlock(&cifs_tcp_ses_lock); ++ spin_unlock(&GlobalMid_Lock); + + cifs_free_ipc(ses); + +-- +2.30.2 + diff --git a/queue-5.10/cifs-improve-fallocate-emulation.patch b/queue-5.10/cifs-improve-fallocate-emulation.patch new file mode 100644 index 00000000000..63a44951d39 --- /dev/null +++ b/queue-5.10/cifs-improve-fallocate-emulation.patch @@ -0,0 +1,191 @@ +From ea8b35f03c49f9b7c2a204b79928b4c7a9c16cb5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 15:31:01 +1000 +Subject: cifs: improve fallocate emulation + +From: Ronnie Sahlberg + +[ Upstream commit 966a3cb7c7db786452a87afdc3b48858fc4d4d6b ] + +RHBZ: 1866684 + +We don't have a real fallocate in the SMB2 protocol so we used to emulate fallocate +by simply switching the file to become non-sparse. But as that could potantially consume +a lot more data than we intended to fallocate (large sparse file and fallocating a thin +slice in the middle) we would only do this IFF the fallocate request was for virtually +the entire file. + +This patch improves this and starts allowing us to fallocate smaller chunks of a file by +overwriting the region with 0, for the parts that are unallocated. + +The method used is to first query the server for FSCTL_QUERY_ALLOCATED_RANGES to find what +is unallocated in the fallocate range and then to only overwrite-with-zero the unallocated +ranges to fill in the holes. + +As overwriting-with-zero is different from just allocating blocks, and potentially much +more expensive, we limit this to only allow fallocate ranges up to 1Mb in size. + +Reported-by: kernel test robot +Signed-off-by: Ronnie Sahlberg +Acked-by: Aurelien Aptel +Acked-by: Paulo Alcantara (SUSE) +Signed-off-by: Steve French +Signed-off-by: Sasha Levin +--- + fs/cifs/smb2ops.c | 133 ++++++++++++++++++++++++++++++++++++++++++++++ + 1 file changed, 133 insertions(+) + +diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c +index a9d155530144..f6ceb79a995d 100644 +--- a/fs/cifs/smb2ops.c ++++ b/fs/cifs/smb2ops.c +@@ -3459,6 +3459,119 @@ static long smb3_punch_hole(struct file *file, struct cifs_tcon *tcon, + return rc; + } + ++static int smb3_simple_fallocate_write_range(unsigned int xid, ++ struct cifs_tcon *tcon, ++ struct cifsFileInfo *cfile, ++ loff_t off, loff_t len, ++ char *buf) ++{ ++ struct cifs_io_parms io_parms = {0}; ++ int nbytes; ++ struct kvec iov[2]; ++ ++ io_parms.netfid = cfile->fid.netfid; ++ io_parms.pid = current->tgid; ++ io_parms.tcon = tcon; ++ io_parms.persistent_fid = cfile->fid.persistent_fid; ++ io_parms.volatile_fid = cfile->fid.volatile_fid; ++ io_parms.offset = off; ++ io_parms.length = len; ++ ++ /* iov[0] is reserved for smb header */ ++ iov[1].iov_base = buf; ++ iov[1].iov_len = io_parms.length; ++ return SMB2_write(xid, &io_parms, &nbytes, iov, 1); ++} ++ ++static int smb3_simple_fallocate_range(unsigned int xid, ++ struct cifs_tcon *tcon, ++ struct cifsFileInfo *cfile, ++ loff_t off, loff_t len) ++{ ++ struct file_allocated_range_buffer in_data, *out_data = NULL, *tmp_data; ++ u32 out_data_len; ++ char *buf = NULL; ++ loff_t l; ++ int rc; ++ ++ in_data.file_offset = cpu_to_le64(off); ++ in_data.length = cpu_to_le64(len); ++ rc = SMB2_ioctl(xid, tcon, cfile->fid.persistent_fid, ++ cfile->fid.volatile_fid, ++ FSCTL_QUERY_ALLOCATED_RANGES, true, ++ (char *)&in_data, sizeof(in_data), ++ 1024 * sizeof(struct file_allocated_range_buffer), ++ (char **)&out_data, &out_data_len); ++ if (rc) ++ goto out; ++ /* ++ * It is already all allocated ++ */ ++ if (out_data_len == 0) ++ goto out; ++ ++ buf = kzalloc(1024 * 1024, GFP_KERNEL); ++ if (buf == NULL) { ++ rc = -ENOMEM; ++ goto out; ++ } ++ ++ tmp_data = out_data; ++ while (len) { ++ /* ++ * The rest of the region is unmapped so write it all. ++ */ ++ if (out_data_len == 0) { ++ rc = smb3_simple_fallocate_write_range(xid, tcon, ++ cfile, off, len, buf); ++ goto out; ++ } ++ ++ if (out_data_len < sizeof(struct file_allocated_range_buffer)) { ++ rc = -EINVAL; ++ goto out; ++ } ++ ++ if (off < le64_to_cpu(tmp_data->file_offset)) { ++ /* ++ * We are at a hole. Write until the end of the region ++ * or until the next allocated data, ++ * whichever comes next. ++ */ ++ l = le64_to_cpu(tmp_data->file_offset) - off; ++ if (len < l) ++ l = len; ++ rc = smb3_simple_fallocate_write_range(xid, tcon, ++ cfile, off, l, buf); ++ if (rc) ++ goto out; ++ off = off + l; ++ len = len - l; ++ if (len == 0) ++ goto out; ++ } ++ /* ++ * We are at a section of allocated data, just skip forward ++ * until the end of the data or the end of the region ++ * we are supposed to fallocate, whichever comes first. ++ */ ++ l = le64_to_cpu(tmp_data->length); ++ if (len < l) ++ l = len; ++ off += l; ++ len -= l; ++ ++ tmp_data = &tmp_data[1]; ++ out_data_len -= sizeof(struct file_allocated_range_buffer); ++ } ++ ++ out: ++ kfree(out_data); ++ kfree(buf); ++ return rc; ++} ++ ++ + static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon, + loff_t off, loff_t len, bool keep_size) + { +@@ -3519,6 +3632,26 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon, + } + + if ((keep_size == true) || (i_size_read(inode) >= off + len)) { ++ /* ++ * At this point, we are trying to fallocate an internal ++ * regions of a sparse file. Since smb2 does not have a ++ * fallocate command we have two otions on how to emulate this. ++ * We can either turn the entire file to become non-sparse ++ * which we only do if the fallocate is for virtually ++ * the whole file, or we can overwrite the region with zeroes ++ * using SMB2_write, which could be prohibitevly expensive ++ * if len is large. ++ */ ++ /* ++ * We are only trying to fallocate a small region so ++ * just write it with zero. ++ */ ++ if (len <= 1024 * 1024) { ++ rc = smb3_simple_fallocate_range(xid, tcon, cfile, ++ off, len); ++ goto out; ++ } ++ + /* + * Check if falloc starts within first few pages of file + * and ends within a few pages of the end of file to +-- +2.30.2 + diff --git a/queue-5.10/clk-actions-fix-ahpprediv-h-ahb-clock-chain-on-owl-s.patch b/queue-5.10/clk-actions-fix-ahpprediv-h-ahb-clock-chain-on-owl-s.patch new file mode 100644 index 00000000000..f6b9ccc65bb --- /dev/null +++ b/queue-5.10/clk-actions-fix-ahpprediv-h-ahb-clock-chain-on-owl-s.patch @@ -0,0 +1,91 @@ +From 42db233cedd4ffd1271df1e0aaa60e7ed7d0e049 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 23:05:24 +0300 +Subject: clk: actions: Fix AHPPREDIV-H-AHB clock chain on Owl S500 SoC + +From: Cristian Ciocaltea + +[ Upstream commit fd90b5b9045274360b12cea0f2ce50f3bcfb25cc ] + +There are a few issues with the setup of the Actions Semi Owl S500 SoC's +clock chain involving AHPPREDIV, H and AHB clocks: + +* AHBPREDIV clock is defined as a muxer only, although it also acts as + a divider. +* H clock is using a wrong divider register offset +* AHB is defined as a multi-rate factor clock, but it is actually just + a fixed pass clock. + +Let's provide the following fixes: + +* Change AHBPREDIV clock to an ungated OWL_COMP_DIV definition. +* Use the correct register shift value in the OWL_DIVIDER definition + for H clock +* Drop the unneeded 'ahb_factor_table[]' and change AHB clock to an + ungated OWL_COMP_FIXED_FACTOR definition. + +Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") +Signed-off-by: Cristian Ciocaltea +Link: https://lore.kernel.org/r/21c1abd19a7089b65a34852ac6513961be88cbe1.1623354574.git.cristian.ciocaltea@gmail.com +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/actions/owl-s500.c | 19 +++++++++++-------- + 1 file changed, 11 insertions(+), 8 deletions(-) + +diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c +index 42d6899755e6..cbeb51c804eb 100644 +--- a/drivers/clk/actions/owl-s500.c ++++ b/drivers/clk/actions/owl-s500.c +@@ -153,11 +153,6 @@ static struct clk_factor_table hde_factor_table[] = { + { 0, 0, 0 }, + }; + +-static struct clk_factor_table ahb_factor_table[] = { +- { 1, 1, 2 }, { 2, 1, 3 }, +- { 0, 0, 0 }, +-}; +- + static struct clk_div_table rmii_ref_div_table[] = { + { 0, 4 }, { 1, 10 }, + { 0, 0 }, +@@ -186,7 +181,6 @@ static struct clk_div_table nand_div_table[] = { + + /* mux clock */ + static OWL_MUX(dev_clk, "dev_clk", dev_clk_mux_p, CMU_DEVPLL, 12, 1, CLK_SET_RATE_PARENT); +-static OWL_MUX(ahbprediv_clk, "ahbprediv_clk", ahbprediv_clk_mux_p, CMU_BUSCLK1, 8, 3, CLK_SET_RATE_PARENT); + + /* gate clocks */ + static OWL_GATE(gpio_clk, "gpio_clk", "apb_clk", CMU_DEVCLKEN0, 18, 0, 0); +@@ -199,16 +193,25 @@ static OWL_GATE(timer_clk, "timer_clk", "hosc", CMU_DEVCLKEN1, 27, 0, 0); + static OWL_GATE(hdmi_clk, "hdmi_clk", "hosc", CMU_DEVCLKEN1, 3, 0, 0); + + /* divider clocks */ +-static OWL_DIVIDER(h_clk, "h_clk", "ahbprediv_clk", CMU_BUSCLK1, 12, 2, NULL, 0, 0); ++static OWL_DIVIDER(h_clk, "h_clk", "ahbprediv_clk", CMU_BUSCLK1, 2, 2, NULL, 0, 0); + static OWL_DIVIDER(apb_clk, "apb_clk", "ahb_clk", CMU_BUSCLK1, 14, 2, NULL, 0, 0); + static OWL_DIVIDER(rmii_ref_clk, "rmii_ref_clk", "ethernet_pll_clk", CMU_ETHERNETPLL, 1, 1, rmii_ref_div_table, 0, 0); + + /* factor clocks */ +-static OWL_FACTOR(ahb_clk, "ahb_clk", "h_clk", CMU_BUSCLK1, 2, 2, ahb_factor_table, 0, 0); + static OWL_FACTOR(de1_clk, "de_clk1", "de_clk", CMU_DECLK, 0, 4, de_factor_table, 0, 0); + static OWL_FACTOR(de2_clk, "de_clk2", "de_clk", CMU_DECLK, 4, 4, de_factor_table, 0, 0); + + /* composite clocks */ ++static OWL_COMP_DIV(ahbprediv_clk, "ahbprediv_clk", ahbprediv_clk_mux_p, ++ OWL_MUX_HW(CMU_BUSCLK1, 8, 3), ++ { 0 }, ++ OWL_DIVIDER_HW(CMU_BUSCLK1, 12, 2, 0, NULL), ++ CLK_SET_RATE_PARENT); ++ ++static OWL_COMP_FIXED_FACTOR(ahb_clk, "ahb_clk", "h_clk", ++ { 0 }, ++ 1, 1, 0); ++ + static OWL_COMP_FACTOR(vce_clk, "vce_clk", hde_clk_mux_p, + OWL_MUX_HW(CMU_VCECLK, 4, 2), + OWL_GATE_HW(CMU_DEVCLKEN0, 26, 0), +-- +2.30.2 + diff --git a/queue-5.10/clk-actions-fix-bisp_factor_table-based-clocks-on-ow.patch b/queue-5.10/clk-actions-fix-bisp_factor_table-based-clocks-on-ow.patch new file mode 100644 index 00000000000..826073e64e5 --- /dev/null +++ b/queue-5.10/clk-actions-fix-bisp_factor_table-based-clocks-on-ow.patch @@ -0,0 +1,143 @@ +From 05661bbd67930f44b80c97a0d01a630da9dc200b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 23:05:23 +0300 +Subject: clk: actions: Fix bisp_factor_table based clocks on Owl S500 SoC + +From: Cristian Ciocaltea + +[ Upstream commit a8f1f03caa51aa7a69c671aa87c475034db7d368 ] + +The following clocks of the Actions Semi Owl S500 SoC have been defined +to use a shared clock factor table 'bisp_factor_table[]': DE[1-2], VCE, +VDE, BISP, SENSOR[0-1] + +There are several issues involved in this approach: + +* 'bisp_factor_table[]' describes the configuration of a regular 8-rates + divider, so its usage is redundant. Additionally, judging by the BISP + clock context, it is incomplete since it maps only 8 out of 12 + possible entries. + +* The clocks mentioned above are not identical in terms of the available + rates, therefore cannot rely on the same factor table. Specifically, + BISP and SENSOR* are standard 12-rate dividers so their configuration + should rely on a proper clock div table, while VCE and VDE require a + factor table that is a actually a subset of the one needed for DE[1-2] + clocks. + +Let's fix this by implementing the following: + +* Add new factor tables 'de_factor_table' and 'hde_factor_table' to + properly handle DE[1-2], VCE and VDE clocks. + +* Add a common div table 'std12rate_div_table' for BISP and SENSOR[0-1] + clocks converted to OWL_COMP_DIV. + +* Drop the now unused 'bisp_factor_table[]'. + +Additionally, drop the CLK_IGNORE_UNUSED flag for SENSOR[0-1] since +there is no reason to always keep ON those clocks. + +Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") +Signed-off-by: Cristian Ciocaltea +Reviewed-by: Manivannan Sadhasivam +Link: https://lore.kernel.org/r/e675820a46cd9930d8d576c6cae61d41c1a8416f.1623354574.git.cristian.ciocaltea@gmail.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/actions/owl-s500.c | 44 ++++++++++++++++++++++------------ + 1 file changed, 29 insertions(+), 15 deletions(-) + +diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c +index 42abdf964044..42d6899755e6 100644 +--- a/drivers/clk/actions/owl-s500.c ++++ b/drivers/clk/actions/owl-s500.c +@@ -140,9 +140,16 @@ static struct clk_factor_table sd_factor_table[] = { + { 0, 0, 0 }, + }; + +-static struct clk_factor_table bisp_factor_table[] = { +- { 0, 1, 1 }, { 1, 1, 2 }, { 2, 1, 3 }, { 3, 1, 4 }, +- { 4, 1, 5 }, { 5, 1, 6 }, { 6, 1, 7 }, { 7, 1, 8 }, ++static struct clk_factor_table de_factor_table[] = { ++ { 0, 1, 1 }, { 1, 2, 3 }, { 2, 1, 2 }, { 3, 2, 5 }, ++ { 4, 1, 3 }, { 5, 1, 4 }, { 6, 1, 6 }, { 7, 1, 8 }, ++ { 8, 1, 12 }, ++ { 0, 0, 0 }, ++}; ++ ++static struct clk_factor_table hde_factor_table[] = { ++ { 0, 1, 1 }, { 1, 2, 3 }, { 2, 1, 2 }, { 3, 2, 5 }, ++ { 4, 1, 3 }, { 5, 1, 4 }, { 6, 1, 6 }, { 7, 1, 8 }, + { 0, 0, 0 }, + }; + +@@ -156,6 +163,13 @@ static struct clk_div_table rmii_ref_div_table[] = { + { 0, 0 }, + }; + ++static struct clk_div_table std12rate_div_table[] = { ++ { 0, 1 }, { 1, 2 }, { 2, 3 }, { 3, 4 }, ++ { 4, 5 }, { 5, 6 }, { 6, 7 }, { 7, 8 }, ++ { 8, 9 }, { 9, 10 }, { 10, 11 }, { 11, 12 }, ++ { 0, 0 }, ++}; ++ + static struct clk_div_table i2s_div_table[] = { + { 0, 1 }, { 1, 2 }, { 2, 3 }, { 3, 4 }, + { 4, 6 }, { 5, 8 }, { 6, 12 }, { 7, 16 }, +@@ -191,39 +205,39 @@ static OWL_DIVIDER(rmii_ref_clk, "rmii_ref_clk", "ethernet_pll_clk", CMU_ETHERNE + + /* factor clocks */ + static OWL_FACTOR(ahb_clk, "ahb_clk", "h_clk", CMU_BUSCLK1, 2, 2, ahb_factor_table, 0, 0); +-static OWL_FACTOR(de1_clk, "de_clk1", "de_clk", CMU_DECLK, 0, 3, bisp_factor_table, 0, 0); +-static OWL_FACTOR(de2_clk, "de_clk2", "de_clk", CMU_DECLK, 4, 3, bisp_factor_table, 0, 0); ++static OWL_FACTOR(de1_clk, "de_clk1", "de_clk", CMU_DECLK, 0, 4, de_factor_table, 0, 0); ++static OWL_FACTOR(de2_clk, "de_clk2", "de_clk", CMU_DECLK, 4, 4, de_factor_table, 0, 0); + + /* composite clocks */ + static OWL_COMP_FACTOR(vce_clk, "vce_clk", hde_clk_mux_p, + OWL_MUX_HW(CMU_VCECLK, 4, 2), + OWL_GATE_HW(CMU_DEVCLKEN0, 26, 0), +- OWL_FACTOR_HW(CMU_VCECLK, 0, 3, 0, bisp_factor_table), ++ OWL_FACTOR_HW(CMU_VCECLK, 0, 3, 0, hde_factor_table), + 0); + + static OWL_COMP_FACTOR(vde_clk, "vde_clk", hde_clk_mux_p, + OWL_MUX_HW(CMU_VDECLK, 4, 2), + OWL_GATE_HW(CMU_DEVCLKEN0, 25, 0), +- OWL_FACTOR_HW(CMU_VDECLK, 0, 3, 0, bisp_factor_table), ++ OWL_FACTOR_HW(CMU_VDECLK, 0, 3, 0, hde_factor_table), + 0); + +-static OWL_COMP_FACTOR(bisp_clk, "bisp_clk", bisp_clk_mux_p, ++static OWL_COMP_DIV(bisp_clk, "bisp_clk", bisp_clk_mux_p, + OWL_MUX_HW(CMU_BISPCLK, 4, 1), + OWL_GATE_HW(CMU_DEVCLKEN0, 14, 0), +- OWL_FACTOR_HW(CMU_BISPCLK, 0, 3, 0, bisp_factor_table), ++ OWL_DIVIDER_HW(CMU_BISPCLK, 0, 4, 0, std12rate_div_table), + 0); + +-static OWL_COMP_FACTOR(sensor0_clk, "sensor0_clk", sensor_clk_mux_p, ++static OWL_COMP_DIV(sensor0_clk, "sensor0_clk", sensor_clk_mux_p, + OWL_MUX_HW(CMU_SENSORCLK, 4, 1), + OWL_GATE_HW(CMU_DEVCLKEN0, 14, 0), +- OWL_FACTOR_HW(CMU_SENSORCLK, 0, 3, 0, bisp_factor_table), +- CLK_IGNORE_UNUSED); ++ OWL_DIVIDER_HW(CMU_SENSORCLK, 0, 4, 0, std12rate_div_table), ++ 0); + +-static OWL_COMP_FACTOR(sensor1_clk, "sensor1_clk", sensor_clk_mux_p, ++static OWL_COMP_DIV(sensor1_clk, "sensor1_clk", sensor_clk_mux_p, + OWL_MUX_HW(CMU_SENSORCLK, 4, 1), + OWL_GATE_HW(CMU_DEVCLKEN0, 14, 0), +- OWL_FACTOR_HW(CMU_SENSORCLK, 8, 3, 0, bisp_factor_table), +- CLK_IGNORE_UNUSED); ++ OWL_DIVIDER_HW(CMU_SENSORCLK, 8, 4, 0, std12rate_div_table), ++ 0); + + static OWL_COMP_FACTOR(sd0_clk, "sd0_clk", sd_clk_mux_p, + OWL_MUX_HW(CMU_SD0CLK, 9, 1), +-- +2.30.2 + diff --git a/queue-5.10/clk-actions-fix-sd-clocks-factor-table-on-owl-s500-s.patch b/queue-5.10/clk-actions-fix-sd-clocks-factor-table-on-owl-s500-s.patch new file mode 100644 index 00000000000..2601e242853 --- /dev/null +++ b/queue-5.10/clk-actions-fix-sd-clocks-factor-table-on-owl-s500-s.patch @@ -0,0 +1,49 @@ +From 91baa55a3ab80b3ffca0fb6b18b62fba19802726 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 23:05:22 +0300 +Subject: clk: actions: Fix SD clocks factor table on Owl S500 SoC + +From: Cristian Ciocaltea + +[ Upstream commit fe1f71e338d77814da3ef44e9f64d32981a6ccdf ] + +Drop the unsupported entries in the factor table used for the SD[0-2] +clocks definitions on the Actions Semi Owl S500 SoC. + +Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") +Signed-off-by: Cristian Ciocaltea +Reviewed-by: Manivannan Sadhasivam +Link: https://lore.kernel.org/r/196c948d708a22b8198c95f064a0f6b6820f9980.1623354574.git.cristian.ciocaltea@gmail.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/actions/owl-s500.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c +index 75b7186185b0..42abdf964044 100644 +--- a/drivers/clk/actions/owl-s500.c ++++ b/drivers/clk/actions/owl-s500.c +@@ -127,8 +127,7 @@ static struct clk_factor_table sd_factor_table[] = { + { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, + { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, + { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, +- { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, +- { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, ++ { 24, 1, 25 }, + + /* bit8: /128 */ + { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, +@@ -137,8 +136,7 @@ static struct clk_factor_table sd_factor_table[] = { + { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, + { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, + { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, +- { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, +- { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, ++ { 280, 1, 25 * 128 }, + { 0, 0, 0 }, + }; + +-- +2.30.2 + diff --git a/queue-5.10/clk-actions-fix-uart-clock-dividers-on-owl-s500-soc.patch b/queue-5.10/clk-actions-fix-uart-clock-dividers-on-owl-s500-soc.patch new file mode 100644 index 00000000000..c47b5103f8d --- /dev/null +++ b/queue-5.10/clk-actions-fix-uart-clock-dividers-on-owl-s500-soc.patch @@ -0,0 +1,75 @@ +From 21ca5851613a78e5b629c88002b51f30912d9b31 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 23:05:21 +0300 +Subject: clk: actions: Fix UART clock dividers on Owl S500 SoC + +From: Cristian Ciocaltea + +[ Upstream commit 2dca2a619a907579e3e65e7c1789230c2b912e88 ] + +Use correct divider registers for the Actions Semi Owl S500 SoC's UART +clocks. + +Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") +Signed-off-by: Cristian Ciocaltea +Reviewed-by: Manivannan Sadhasivam +Link: https://lore.kernel.org/r/4714d05982b19ac5fec2ed74f54be42d8238e392.1623354574.git.cristian.ciocaltea@gmail.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/actions/owl-s500.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c +index 61bb224f6330..75b7186185b0 100644 +--- a/drivers/clk/actions/owl-s500.c ++++ b/drivers/clk/actions/owl-s500.c +@@ -305,7 +305,7 @@ static OWL_COMP_FIXED_FACTOR(i2c3_clk, "i2c3_clk", "ethernet_pll_clk", + static OWL_COMP_DIV(uart0_clk, "uart0_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART0CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 6, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART0CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(uart1_clk, "uart1_clk", uart_clk_mux_p, +@@ -317,31 +317,31 @@ static OWL_COMP_DIV(uart1_clk, "uart1_clk", uart_clk_mux_p, + static OWL_COMP_DIV(uart2_clk, "uart2_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART2CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 8, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART2CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(uart3_clk, "uart3_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART3CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 19, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART3CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(uart4_clk, "uart4_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART4CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 20, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART4CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(uart5_clk, "uart5_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART5CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 21, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART5CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(uart6_clk, "uart6_clk", uart_clk_mux_p, + OWL_MUX_HW(CMU_UART6CLK, 16, 1), + OWL_GATE_HW(CMU_DEVCLKEN1, 18, 0), +- OWL_DIVIDER_HW(CMU_UART1CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), ++ OWL_DIVIDER_HW(CMU_UART6CLK, 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL), + CLK_IGNORE_UNUSED); + + static OWL_COMP_DIV(i2srx_clk, "i2srx_clk", i2s_clk_mux_p, +-- +2.30.2 + diff --git a/queue-5.10/clk-imx8mq-remove-sys-pll-1-2-clock-gates.patch b/queue-5.10/clk-imx8mq-remove-sys-pll-1-2-clock-gates.patch new file mode 100644 index 00000000000..134f0e78e67 --- /dev/null +++ b/queue-5.10/clk-imx8mq-remove-sys-pll-1-2-clock-gates.patch @@ -0,0 +1,127 @@ +From e55d3fddf5e2bf4082da5b03e4ca861ddec9ae88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 20:01:35 +0200 +Subject: clk: imx8mq: remove SYS PLL 1/2 clock gates + +From: Lucas Stach + +[ Upstream commit c586f53ae159c6c1390f093a1ec94baef2df9f3a ] + +Remove the PLL clock gates as the allowing to gate the sys1_pll_266m breaks +the uSDHC module which is sporadically unable to enumerate devices after +this change. Also it makes AMP clock management harder with no obvious +benefit to Linux, so just revert the change. + +Link: https://lore.kernel.org/r/20210528180135.1640876-1-l.stach@pengutronix.de +Fixes: b04383b6a558 ("clk: imx8mq: Define gates for pll1/2 fixed dividers") +Signed-off-by: Lucas Stach +Reviewed-by: Abel Vesa +Signed-off-by: Abel Vesa +Signed-off-by: Sasha Levin +--- + drivers/clk/imx/clk-imx8mq.c | 56 ++++++++---------------- + include/dt-bindings/clock/imx8mq-clock.h | 19 -------- + 2 files changed, 18 insertions(+), 57 deletions(-) + +diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c +index 4e6c81a70221..aac6bcc65c20 100644 +--- a/drivers/clk/imx/clk-imx8mq.c ++++ b/drivers/clk/imx/clk-imx8mq.c +@@ -350,46 +350,26 @@ static int imx8mq_clocks_probe(struct platform_device *pdev) + hws[IMX8MQ_VIDEO2_PLL_OUT] = imx_clk_hw_sscg_pll("video2_pll_out", video2_pll_out_sels, ARRAY_SIZE(video2_pll_out_sels), 0, 0, 0, base + 0x54, 0); + + /* SYS PLL1 fixed output */ +- hws[IMX8MQ_SYS1_PLL_40M_CG] = imx_clk_hw_gate("sys1_pll_40m_cg", "sys1_pll_out", base + 0x30, 9); +- hws[IMX8MQ_SYS1_PLL_80M_CG] = imx_clk_hw_gate("sys1_pll_80m_cg", "sys1_pll_out", base + 0x30, 11); +- hws[IMX8MQ_SYS1_PLL_100M_CG] = imx_clk_hw_gate("sys1_pll_100m_cg", "sys1_pll_out", base + 0x30, 13); +- hws[IMX8MQ_SYS1_PLL_133M_CG] = imx_clk_hw_gate("sys1_pll_133m_cg", "sys1_pll_out", base + 0x30, 15); +- hws[IMX8MQ_SYS1_PLL_160M_CG] = imx_clk_hw_gate("sys1_pll_160m_cg", "sys1_pll_out", base + 0x30, 17); +- hws[IMX8MQ_SYS1_PLL_200M_CG] = imx_clk_hw_gate("sys1_pll_200m_cg", "sys1_pll_out", base + 0x30, 19); +- hws[IMX8MQ_SYS1_PLL_266M_CG] = imx_clk_hw_gate("sys1_pll_266m_cg", "sys1_pll_out", base + 0x30, 21); +- hws[IMX8MQ_SYS1_PLL_400M_CG] = imx_clk_hw_gate("sys1_pll_400m_cg", "sys1_pll_out", base + 0x30, 23); +- hws[IMX8MQ_SYS1_PLL_800M_CG] = imx_clk_hw_gate("sys1_pll_800m_cg", "sys1_pll_out", base + 0x30, 25); +- +- hws[IMX8MQ_SYS1_PLL_40M] = imx_clk_hw_fixed_factor("sys1_pll_40m", "sys1_pll_40m_cg", 1, 20); +- hws[IMX8MQ_SYS1_PLL_80M] = imx_clk_hw_fixed_factor("sys1_pll_80m", "sys1_pll_80m_cg", 1, 10); +- hws[IMX8MQ_SYS1_PLL_100M] = imx_clk_hw_fixed_factor("sys1_pll_100m", "sys1_pll_100m_cg", 1, 8); +- hws[IMX8MQ_SYS1_PLL_133M] = imx_clk_hw_fixed_factor("sys1_pll_133m", "sys1_pll_133m_cg", 1, 6); +- hws[IMX8MQ_SYS1_PLL_160M] = imx_clk_hw_fixed_factor("sys1_pll_160m", "sys1_pll_160m_cg", 1, 5); +- hws[IMX8MQ_SYS1_PLL_200M] = imx_clk_hw_fixed_factor("sys1_pll_200m", "sys1_pll_200m_cg", 1, 4); +- hws[IMX8MQ_SYS1_PLL_266M] = imx_clk_hw_fixed_factor("sys1_pll_266m", "sys1_pll_266m_cg", 1, 3); +- hws[IMX8MQ_SYS1_PLL_400M] = imx_clk_hw_fixed_factor("sys1_pll_400m", "sys1_pll_400m_cg", 1, 2); +- hws[IMX8MQ_SYS1_PLL_800M] = imx_clk_hw_fixed_factor("sys1_pll_800m", "sys1_pll_800m_cg", 1, 1); ++ hws[IMX8MQ_SYS1_PLL_40M] = imx_clk_hw_fixed_factor("sys1_pll_40m", "sys1_pll_out", 1, 20); ++ hws[IMX8MQ_SYS1_PLL_80M] = imx_clk_hw_fixed_factor("sys1_pll_80m", "sys1_pll_out", 1, 10); ++ hws[IMX8MQ_SYS1_PLL_100M] = imx_clk_hw_fixed_factor("sys1_pll_100m", "sys1_pll_out", 1, 8); ++ hws[IMX8MQ_SYS1_PLL_133M] = imx_clk_hw_fixed_factor("sys1_pll_133m", "sys1_pll_out", 1, 6); ++ hws[IMX8MQ_SYS1_PLL_160M] = imx_clk_hw_fixed_factor("sys1_pll_160m", "sys1_pll_out", 1, 5); ++ hws[IMX8MQ_SYS1_PLL_200M] = imx_clk_hw_fixed_factor("sys1_pll_200m", "sys1_pll_out", 1, 4); ++ hws[IMX8MQ_SYS1_PLL_266M] = imx_clk_hw_fixed_factor("sys1_pll_266m", "sys1_pll_out", 1, 3); ++ hws[IMX8MQ_SYS1_PLL_400M] = imx_clk_hw_fixed_factor("sys1_pll_400m", "sys1_pll_out", 1, 2); ++ hws[IMX8MQ_SYS1_PLL_800M] = imx_clk_hw_fixed_factor("sys1_pll_800m", "sys1_pll_out", 1, 1); + + /* SYS PLL2 fixed output */ +- hws[IMX8MQ_SYS2_PLL_50M_CG] = imx_clk_hw_gate("sys2_pll_50m_cg", "sys2_pll_out", base + 0x3c, 9); +- hws[IMX8MQ_SYS2_PLL_100M_CG] = imx_clk_hw_gate("sys2_pll_100m_cg", "sys2_pll_out", base + 0x3c, 11); +- hws[IMX8MQ_SYS2_PLL_125M_CG] = imx_clk_hw_gate("sys2_pll_125m_cg", "sys2_pll_out", base + 0x3c, 13); +- hws[IMX8MQ_SYS2_PLL_166M_CG] = imx_clk_hw_gate("sys2_pll_166m_cg", "sys2_pll_out", base + 0x3c, 15); +- hws[IMX8MQ_SYS2_PLL_200M_CG] = imx_clk_hw_gate("sys2_pll_200m_cg", "sys2_pll_out", base + 0x3c, 17); +- hws[IMX8MQ_SYS2_PLL_250M_CG] = imx_clk_hw_gate("sys2_pll_250m_cg", "sys2_pll_out", base + 0x3c, 19); +- hws[IMX8MQ_SYS2_PLL_333M_CG] = imx_clk_hw_gate("sys2_pll_333m_cg", "sys2_pll_out", base + 0x3c, 21); +- hws[IMX8MQ_SYS2_PLL_500M_CG] = imx_clk_hw_gate("sys2_pll_500m_cg", "sys2_pll_out", base + 0x3c, 23); +- hws[IMX8MQ_SYS2_PLL_1000M_CG] = imx_clk_hw_gate("sys2_pll_1000m_cg", "sys2_pll_out", base + 0x3c, 25); +- +- hws[IMX8MQ_SYS2_PLL_50M] = imx_clk_hw_fixed_factor("sys2_pll_50m", "sys2_pll_50m_cg", 1, 20); +- hws[IMX8MQ_SYS2_PLL_100M] = imx_clk_hw_fixed_factor("sys2_pll_100m", "sys2_pll_100m_cg", 1, 10); +- hws[IMX8MQ_SYS2_PLL_125M] = imx_clk_hw_fixed_factor("sys2_pll_125m", "sys2_pll_125m_cg", 1, 8); +- hws[IMX8MQ_SYS2_PLL_166M] = imx_clk_hw_fixed_factor("sys2_pll_166m", "sys2_pll_166m_cg", 1, 6); +- hws[IMX8MQ_SYS2_PLL_200M] = imx_clk_hw_fixed_factor("sys2_pll_200m", "sys2_pll_200m_cg", 1, 5); +- hws[IMX8MQ_SYS2_PLL_250M] = imx_clk_hw_fixed_factor("sys2_pll_250m", "sys2_pll_250m_cg", 1, 4); +- hws[IMX8MQ_SYS2_PLL_333M] = imx_clk_hw_fixed_factor("sys2_pll_333m", "sys2_pll_333m_cg", 1, 3); +- hws[IMX8MQ_SYS2_PLL_500M] = imx_clk_hw_fixed_factor("sys2_pll_500m", "sys2_pll_500m_cg", 1, 2); +- hws[IMX8MQ_SYS2_PLL_1000M] = imx_clk_hw_fixed_factor("sys2_pll_1000m", "sys2_pll_1000m_cg", 1, 1); ++ hws[IMX8MQ_SYS2_PLL_50M] = imx_clk_hw_fixed_factor("sys2_pll_50m", "sys2_pll_out", 1, 20); ++ hws[IMX8MQ_SYS2_PLL_100M] = imx_clk_hw_fixed_factor("sys2_pll_100m", "sys2_pll_out", 1, 10); ++ hws[IMX8MQ_SYS2_PLL_125M] = imx_clk_hw_fixed_factor("sys2_pll_125m", "sys2_pll_out", 1, 8); ++ hws[IMX8MQ_SYS2_PLL_166M] = imx_clk_hw_fixed_factor("sys2_pll_166m", "sys2_pll_out", 1, 6); ++ hws[IMX8MQ_SYS2_PLL_200M] = imx_clk_hw_fixed_factor("sys2_pll_200m", "sys2_pll_out", 1, 5); ++ hws[IMX8MQ_SYS2_PLL_250M] = imx_clk_hw_fixed_factor("sys2_pll_250m", "sys2_pll_out", 1, 4); ++ hws[IMX8MQ_SYS2_PLL_333M] = imx_clk_hw_fixed_factor("sys2_pll_333m", "sys2_pll_out", 1, 3); ++ hws[IMX8MQ_SYS2_PLL_500M] = imx_clk_hw_fixed_factor("sys2_pll_500m", "sys2_pll_out", 1, 2); ++ hws[IMX8MQ_SYS2_PLL_1000M] = imx_clk_hw_fixed_factor("sys2_pll_1000m", "sys2_pll_out", 1, 1); + + np = dev->of_node; + base = devm_platform_ioremap_resource(pdev, 0); +diff --git a/include/dt-bindings/clock/imx8mq-clock.h b/include/dt-bindings/clock/imx8mq-clock.h +index 9b8045d75b8b..da62c9f61371 100644 +--- a/include/dt-bindings/clock/imx8mq-clock.h ++++ b/include/dt-bindings/clock/imx8mq-clock.h +@@ -405,25 +405,6 @@ + + #define IMX8MQ_VIDEO2_PLL1_REF_SEL 266 + +-#define IMX8MQ_SYS1_PLL_40M_CG 267 +-#define IMX8MQ_SYS1_PLL_80M_CG 268 +-#define IMX8MQ_SYS1_PLL_100M_CG 269 +-#define IMX8MQ_SYS1_PLL_133M_CG 270 +-#define IMX8MQ_SYS1_PLL_160M_CG 271 +-#define IMX8MQ_SYS1_PLL_200M_CG 272 +-#define IMX8MQ_SYS1_PLL_266M_CG 273 +-#define IMX8MQ_SYS1_PLL_400M_CG 274 +-#define IMX8MQ_SYS1_PLL_800M_CG 275 +-#define IMX8MQ_SYS2_PLL_50M_CG 276 +-#define IMX8MQ_SYS2_PLL_100M_CG 277 +-#define IMX8MQ_SYS2_PLL_125M_CG 278 +-#define IMX8MQ_SYS2_PLL_166M_CG 279 +-#define IMX8MQ_SYS2_PLL_200M_CG 280 +-#define IMX8MQ_SYS2_PLL_250M_CG 281 +-#define IMX8MQ_SYS2_PLL_333M_CG 282 +-#define IMX8MQ_SYS2_PLL_500M_CG 283 +-#define IMX8MQ_SYS2_PLL_1000M_CG 284 +- + #define IMX8MQ_CLK_GPU_CORE 285 + #define IMX8MQ_CLK_GPU_SHADER 286 + #define IMX8MQ_CLK_M4_CORE 287 +-- +2.30.2 + diff --git a/queue-5.10/clk-meson-g12a-fix-gp0-and-hifi-ranges.patch b/queue-5.10/clk-meson-g12a-fix-gp0-and-hifi-ranges.patch new file mode 100644 index 00000000000..239475f242a --- /dev/null +++ b/queue-5.10/clk-meson-g12a-fix-gp0-and-hifi-ranges.patch @@ -0,0 +1,45 @@ +From 865ee7818ecd7bd26cec28fc948abbcf9c4235d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 29 Apr 2021 11:03:25 +0200 +Subject: clk: meson: g12a: fix gp0 and hifi ranges + +From: Jerome Brunet + +[ Upstream commit bc794f8c56abddf709f1f84fcb2a3c9e7d9cc9b4 ] + +While some SoC samples are able to lock with a PLL factor of 55, others +samples can't. ATM, a minimum of 60 appears to work on all the samples +I have tried. + +Even with 60, it sometimes takes a long time for the PLL to eventually +lock. The documentation says that the minimum rate of these PLLs DCO +should be 3GHz, a factor of 125. Let's use that to be on the safe side. + +With factor range changed, the PLL seems to lock quickly (enough) so far. +It is still unclear if the range was the only reason for the delay. + +Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") +Signed-off-by: Jerome Brunet +Acked-by: Neil Armstrong +Link: https://lore.kernel.org/r/20210429090325.60970-1-jbrunet@baylibre.com +Signed-off-by: Sasha Levin +--- + drivers/clk/meson/g12a.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c +index b814d44917a5..2876bb83d9d0 100644 +--- a/drivers/clk/meson/g12a.c ++++ b/drivers/clk/meson/g12a.c +@@ -1602,7 +1602,7 @@ static struct clk_regmap g12b_cpub_clk_trace = { + }; + + static const struct pll_mult_range g12a_gp0_pll_mult_range = { +- .min = 55, ++ .min = 125, + .max = 255, + }; + +-- +2.30.2 + diff --git a/queue-5.10/clk-qcom-clk-alpha-pll-fix-cal_l-write-in-alpha_pll_.patch b/queue-5.10/clk-qcom-clk-alpha-pll-fix-cal_l-write-in-alpha_pll_.patch new file mode 100644 index 00000000000..ca3e0297eaf --- /dev/null +++ b/queue-5.10/clk-qcom-clk-alpha-pll-fix-cal_l-write-in-alpha_pll_.patch @@ -0,0 +1,37 @@ +From 383fa5958da346c101caa2486860ffe281547db6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 22:28:52 -0400 +Subject: clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare + +From: Jonathan Marek + +[ Upstream commit 7f54bf2640e877c8a9b4cc7e2b29f82e3ca1a284 ] + +Caught this when looking at alpha-pll code. Untested but it is clear that +this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL. + +Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration") +Signed-off-by: Jonathan Marek +Link: https://lore.kernel.org/r/20210609022852.4151-1-jonathan@marek.ca +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/clk-alpha-pll.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c +index 564431130a76..1a571c04a76c 100644 +--- a/drivers/clk/qcom/clk-alpha-pll.c ++++ b/drivers/clk/qcom/clk-alpha-pll.c +@@ -1214,7 +1214,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw) + return -EINVAL; + + /* Setup PLL for calibration frequency */ +- regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l); ++ regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l); + + /* Bringup the PLL at calibration frequency */ + ret = clk_alpha_pll_enable(hw); +-- +2.30.2 + diff --git a/queue-5.10/clk-si5341-avoid-divide-errors-due-to-bogus-register.patch b/queue-5.10/clk-si5341-avoid-divide-errors-due-to-bogus-register.patch new file mode 100644 index 00000000000..0e8701375f8 --- /dev/null +++ b/queue-5.10/clk-si5341-avoid-divide-errors-due-to-bogus-register.patch @@ -0,0 +1,70 @@ +From 047a2507bf842b35c744f00f7831dd0a22038e8a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Mar 2021 13:26:37 -0600 +Subject: clk: si5341: Avoid divide errors due to bogus register contents + +From: Robert Hancock + +[ Upstream commit 78f6f406026d688868223d5dbeb197a4f7e9a9fd ] + +If the Si5341 is being initially programmed and has no stored NVM +configuration, some of the register contents may contain unexpected +values, such as zeros, which could cause divide by zero errors during +driver initialization. Trap errors caused by zero registers or zero clock +rates which could result in divide errors later in the code. + +Fixes: 3044a860fd ("clk: Add Si5341/Si5340 driver") +Signed-off-by: Robert Hancock +Link: https://lore.kernel.org/r/20210325192643.2190069-4-robert.hancock@calian.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-si5341.c | 15 +++++++++++++-- + 1 file changed, 13 insertions(+), 2 deletions(-) + +diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c +index b8a960e927bc..ac1ccec2b681 100644 +--- a/drivers/clk/clk-si5341.c ++++ b/drivers/clk/clk-si5341.c +@@ -624,6 +624,9 @@ static unsigned long si5341_synth_clk_recalc_rate(struct clk_hw *hw, + SI5341_SYNTH_N_NUM(synth->index), &n_num, &n_den); + if (err < 0) + return err; ++ /* Check for bogus/uninitialized settings */ ++ if (!n_num || !n_den) ++ return 0; + + /* + * n_num and n_den are shifted left as much as possible, so to prevent +@@ -807,6 +810,9 @@ static long si5341_output_clk_round_rate(struct clk_hw *hw, unsigned long rate, + { + unsigned long r; + ++ if (!rate) ++ return 0; ++ + r = *parent_rate >> 1; + + /* If rate is an even divisor, no changes to parent required */ +@@ -835,11 +841,16 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) + { + struct clk_si5341_output *output = to_clk_si5341_output(hw); +- /* Frequency divider is (r_div + 1) * 2 */ +- u32 r_div = (parent_rate / rate) >> 1; ++ u32 r_div; + int err; + u8 r[3]; + ++ if (!rate) ++ return -EINVAL; ++ ++ /* Frequency divider is (r_div + 1) * 2 */ ++ r_div = (parent_rate / rate) >> 1; ++ + if (r_div <= 1) + r_div = 0; + else if (r_div >= BIT(24)) +-- +2.30.2 + diff --git a/queue-5.10/clk-si5341-check-for-input-clock-presence-and-pll-lo.patch b/queue-5.10/clk-si5341-check-for-input-clock-presence-and-pll-lo.patch new file mode 100644 index 00000000000..e830ba06681 --- /dev/null +++ b/queue-5.10/clk-si5341-check-for-input-clock-presence-and-pll-lo.patch @@ -0,0 +1,82 @@ +From af9fac9c9a82bc908bec3faed8f6b88d713c8336 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Mar 2021 13:26:38 -0600 +Subject: clk: si5341: Check for input clock presence and PLL lock on startup + +From: Robert Hancock + +[ Upstream commit 71dcc4d1f7d2ad97ff7ab831281bc6893ff713a2 ] + +After initializing the device, wait for it to report that the input +clock is present and the PLL has locked before declaring success. + +Fixes: 3044a860fd ("clk: Add Si5341/Si5340 driver") +Signed-off-by: Robert Hancock +Link: https://lore.kernel.org/r/20210325192643.2190069-5-robert.hancock@calian.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-si5341.c | 26 ++++++++++++++++++++++++++ + 1 file changed, 26 insertions(+) + +diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c +index ac1ccec2b681..da40b90c2aa8 100644 +--- a/drivers/clk/clk-si5341.c ++++ b/drivers/clk/clk-si5341.c +@@ -92,6 +92,9 @@ struct clk_si5341_output_config { + #define SI5341_PN_BASE 0x0002 + #define SI5341_DEVICE_REV 0x0005 + #define SI5341_STATUS 0x000C ++#define SI5341_LOS 0x000D ++#define SI5341_STATUS_STICKY 0x0011 ++#define SI5341_LOS_STICKY 0x0012 + #define SI5341_SOFT_RST 0x001C + #define SI5341_IN_SEL 0x0021 + #define SI5341_DEVICE_READY 0x00FE +@@ -99,6 +102,12 @@ struct clk_si5341_output_config { + #define SI5341_IN_EN 0x0949 + #define SI5341_INX_TO_PFD_EN 0x094A + ++/* Status bits */ ++#define SI5341_STATUS_SYSINCAL BIT(0) ++#define SI5341_STATUS_LOSXAXB BIT(1) ++#define SI5341_STATUS_LOSREF BIT(2) ++#define SI5341_STATUS_LOL BIT(3) ++ + /* Input selection */ + #define SI5341_IN_SEL_MASK 0x06 + #define SI5341_IN_SEL_SHIFT 1 +@@ -1416,6 +1425,7 @@ static int si5341_probe(struct i2c_client *client, + unsigned int i; + struct clk_si5341_output_config config[SI5341_MAX_NUM_OUTPUTS]; + bool initialization_required; ++ u32 status; + + data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); + if (!data) +@@ -1583,6 +1593,22 @@ static int si5341_probe(struct i2c_client *client, + return err; + } + ++ /* wait for device to report input clock present and PLL lock */ ++ err = regmap_read_poll_timeout(data->regmap, SI5341_STATUS, status, ++ !(status & (SI5341_STATUS_LOSREF | SI5341_STATUS_LOL)), ++ 10000, 250000); ++ if (err) { ++ dev_err(&client->dev, "Error waiting for input clock or PLL lock\n"); ++ return err; ++ } ++ ++ /* clear sticky alarm bits from initialization */ ++ err = regmap_write(data->regmap, SI5341_STATUS_STICKY, 0); ++ if (err) { ++ dev_err(&client->dev, "unable to clear sticky status\n"); ++ return err; ++ } ++ + /* Free the names, clk framework makes copies */ + for (i = 0; i < data->num_synth; ++i) + devm_kfree(&client->dev, (void *)synth_clock_names[i]); +-- +2.30.2 + diff --git a/queue-5.10/clk-si5341-update-initialization-magic.patch b/queue-5.10/clk-si5341-update-initialization-magic.patch new file mode 100644 index 00000000000..162720f65cb --- /dev/null +++ b/queue-5.10/clk-si5341-update-initialization-magic.patch @@ -0,0 +1,48 @@ +From 3d7ef57594eafaacb5c30839c5b7600dcbb719ee Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Mar 2021 13:26:39 -0600 +Subject: clk: si5341: Update initialization magic + +From: Robert Hancock + +[ Upstream commit 3c9b49b0031aefb81adfdba5ab0ddf3ca3a2cdc9 ] + +Update the default register settings to include the VCO_RESET_CALCODE +settings (set by the SiLabs ClockBuilder software but not described in +the datasheet). Also update part of the initialization sequence to match +ClockBuilder and the datasheet. + +Fixes: 3044a860fd ("clk: Add Si5341/Si5340 driver") +Signed-off-by: Robert Hancock +Link: https://lore.kernel.org/r/20210325192643.2190069-6-robert.hancock@calian.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-si5341.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c +index da40b90c2aa8..eb22f4fdbc6b 100644 +--- a/drivers/clk/clk-si5341.c ++++ b/drivers/clk/clk-si5341.c +@@ -350,6 +350,8 @@ static const struct si5341_reg_default si5341_reg_defaults[] = { + { 0x094A, 0x00 }, /* INx_TO_PFD_EN (disabled) */ + { 0x0A02, 0x00 }, /* Not in datasheet */ + { 0x0B44, 0x0F }, /* PDIV_ENB (datasheet does not mention what it is) */ ++ { 0x0B57, 0x10 }, /* VCO_RESET_CALCODE (not described in datasheet) */ ++ { 0x0B58, 0x05 }, /* VCO_RESET_CALCODE (not described in datasheet) */ + }; + + /* Read and interpret a 44-bit followed by a 32-bit value in the regmap */ +@@ -1104,7 +1106,7 @@ static const struct si5341_reg_default si5341_preamble[] = { + { 0x0B25, 0x00 }, + { 0x0502, 0x01 }, + { 0x0505, 0x03 }, +- { 0x0957, 0x1F }, ++ { 0x0957, 0x17 }, + { 0x0B4E, 0x1A }, + }; + +-- +2.30.2 + diff --git a/queue-5.10/clk-si5341-wait-for-device_ready-on-startup.patch b/queue-5.10/clk-si5341-wait-for-device_ready-on-startup.patch new file mode 100644 index 00000000000..23af6efd1b6 --- /dev/null +++ b/queue-5.10/clk-si5341-wait-for-device_ready-on-startup.patch @@ -0,0 +1,86 @@ +From cc1f3e55164c107d51a6ef54d779b85f78ea693d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Mar 2021 13:26:36 -0600 +Subject: clk: si5341: Wait for DEVICE_READY on startup + +From: Robert Hancock + +[ Upstream commit 6e7d2de1e000d36990923ed80d2e78dfcb545cee ] + +The Si5341 datasheet warns that before accessing any other registers, +including the PAGE register, we need to wait for the DEVICE_READY register +to indicate the device is ready, or the process of the device loading its +state from NVM can be corrupted. Wait for DEVICE_READY on startup before +continuing initialization. This is done using a raw I2C register read +prior to setting up regmap to avoid any potential unwanted automatic PAGE +register accesses from regmap at this stage. + +Fixes: 3044a860fd ("clk: Add Si5341/Si5340 driver") +Signed-off-by: Robert Hancock +Link: https://lore.kernel.org/r/20210325192643.2190069-3-robert.hancock@calian.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-si5341.c | 32 ++++++++++++++++++++++++++++++++ + 1 file changed, 32 insertions(+) + +diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c +index e0446e66fa64..b8a960e927bc 100644 +--- a/drivers/clk/clk-si5341.c ++++ b/drivers/clk/clk-si5341.c +@@ -94,6 +94,7 @@ struct clk_si5341_output_config { + #define SI5341_STATUS 0x000C + #define SI5341_SOFT_RST 0x001C + #define SI5341_IN_SEL 0x0021 ++#define SI5341_DEVICE_READY 0x00FE + #define SI5341_XAXB_CFG 0x090E + #define SI5341_IN_EN 0x0949 + #define SI5341_INX_TO_PFD_EN 0x094A +@@ -1189,6 +1190,32 @@ static const struct regmap_range_cfg si5341_regmap_ranges[] = { + }, + }; + ++static int si5341_wait_device_ready(struct i2c_client *client) ++{ ++ int count; ++ ++ /* Datasheet warns: Any attempt to read or write any register other ++ * than DEVICE_READY before DEVICE_READY reads as 0x0F may corrupt the ++ * NVM programming and may corrupt the register contents, as they are ++ * read from NVM. Note that this includes accesses to the PAGE register. ++ * Also: DEVICE_READY is available on every register page, so no page ++ * change is needed to read it. ++ * Do this outside regmap to avoid automatic PAGE register access. ++ * May take up to 300ms to complete. ++ */ ++ for (count = 0; count < 15; ++count) { ++ s32 result = i2c_smbus_read_byte_data(client, ++ SI5341_DEVICE_READY); ++ if (result < 0) ++ return result; ++ if (result == 0x0F) ++ return 0; ++ msleep(20); ++ } ++ dev_err(&client->dev, "timeout waiting for DEVICE_READY\n"); ++ return -EIO; ++} ++ + static const struct regmap_config si5341_regmap_config = { + .reg_bits = 8, + .val_bits = 8, +@@ -1385,6 +1412,11 @@ static int si5341_probe(struct i2c_client *client, + + data->i2c_client = client; + ++ /* Must be done before otherwise touching hardware */ ++ err = si5341_wait_device_ready(client); ++ if (err) ++ return err; ++ + for (i = 0; i < SI5341_NUM_INPUTS; ++i) { + input = devm_clk_get(&client->dev, si5341_input_clock_names[i]); + if (IS_ERR(input)) { +-- +2.30.2 + diff --git a/queue-5.10/clk-tegra30-use-300mhz-for-video-decoder-by-default.patch b/queue-5.10/clk-tegra30-use-300mhz-for-video-decoder-by-default.patch new file mode 100644 index 00000000000..0861cb23afb --- /dev/null +++ b/queue-5.10/clk-tegra30-use-300mhz-for-video-decoder-by-default.patch @@ -0,0 +1,38 @@ +From e8fd57494584422477e2842da410bd4de7af3af7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 16 May 2021 19:30:33 +0300 +Subject: clk: tegra30: Use 300MHz for video decoder by default + +From: Dmitry Osipenko + +[ Upstream commit 56bb7c28ad00e7bcfc851c4e183c42d148d3ad4e ] + +The 600MHz is a too high clock rate for some SoC versions for the video +decoder hardware and this may cause stability issues. Use 300MHz for the +video decoder by default, which is supported by all hardware versions. + +Fixes: ed1a2459e20c ("clk: tegra: Add Tegra20/30 EMC clock implementation") +Acked-by: Thierry Reding +Signed-off-by: Dmitry Osipenko +Signed-off-by: Thierry Reding +Signed-off-by: Sasha Levin +--- + drivers/clk/tegra/clk-tegra30.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c +index 9cf249c344d9..31e752318a10 100644 +--- a/drivers/clk/tegra/clk-tegra30.c ++++ b/drivers/clk/tegra/clk-tegra30.c +@@ -1248,7 +1248,7 @@ static struct tegra_clk_init_table init_table[] __initdata = { + { TEGRA30_CLK_GR3D, TEGRA30_CLK_PLL_C, 300000000, 0 }, + { TEGRA30_CLK_GR3D2, TEGRA30_CLK_PLL_C, 300000000, 0 }, + { TEGRA30_CLK_PLL_U, TEGRA30_CLK_CLK_MAX, 480000000, 0 }, +- { TEGRA30_CLK_VDE, TEGRA30_CLK_PLL_C, 600000000, 0 }, ++ { TEGRA30_CLK_VDE, TEGRA30_CLK_PLL_C, 300000000, 0 }, + { TEGRA30_CLK_SPDIF_IN_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 }, + { TEGRA30_CLK_I2S0_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 }, + { TEGRA30_CLK_I2S1_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 }, +-- +2.30.2 + diff --git a/queue-5.10/clk-vc5-fix-output-disabling-when-enabling-a-fod.patch b/queue-5.10/clk-vc5-fix-output-disabling-when-enabling-a-fod.patch new file mode 100644 index 00000000000..10313cb1eee --- /dev/null +++ b/queue-5.10/clk-vc5-fix-output-disabling-when-enabling-a-fod.patch @@ -0,0 +1,112 @@ +From ded81da0f95d9aee41459f184938291d4c61fdfd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 23:16:47 +0200 +Subject: clk: vc5: fix output disabling when enabling a FOD +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Luca Ceresoli + +[ Upstream commit fc336ae622df0ec114dbe5551a4d2760c535ecd0 ] + +On 5P49V6965, when an output is enabled we enable the corresponding +FOD. When this happens for the first time, and specifically when writing +register VC5_OUT_DIV_CONTROL in vc5_clk_out_prepare(), all other outputs +are stopped for a short time and then restarted. + +According to Renesas support this is intended: "The reason for that is VC6E +has synced up all output function". + +This behaviour can be disabled at least on VersaClock 6E devices, of which +only the 5P49V6965 is currently implemented by this driver. This requires +writing bit 7 (bypass_sync{1..4}) in register 0x20..0x50. Those registers +are named "Unused Factory Reserved Register", and the bits are documented +as "Skip VDDO verification", which does not clearly explain the relation +to FOD sync. However according to Renesas support as well as my testing +setting this bit does prevent disabling of all clock outputs when enabling +a FOD. + +See "VersaClock ® 6E Family Register Descriptions and Programming Guide" +(August 30, 2018), Table 116 "Power Up VDD check", page 58: +https://www.renesas.com/us/en/document/mau/versaclock-6e-family-register-descriptions-and-programming-guide + +Signed-off-by: Luca Ceresoli +Reviewed-by: Adam Ford +Link: https://lore.kernel.org/r/20210527211647.1520720-1-luca@lucaceresoli.net +Fixes: 2bda748e6ad8 ("clk: vc5: Add support for IDT VersaClock 5P49V6965") +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-versaclock5.c | 27 ++++++++++++++++++++++++--- + 1 file changed, 24 insertions(+), 3 deletions(-) + +diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c +index 43db67337bc0..4e741f94baf0 100644 +--- a/drivers/clk/clk-versaclock5.c ++++ b/drivers/clk/clk-versaclock5.c +@@ -69,7 +69,10 @@ + #define VC5_FEEDBACK_FRAC_DIV(n) (0x19 + (n)) + #define VC5_RC_CONTROL0 0x1e + #define VC5_RC_CONTROL1 0x1f +-/* Register 0x20 is factory reserved */ ++ ++/* These registers are named "Unused Factory Reserved Registers" */ ++#define VC5_RESERVED_X0(idx) (0x20 + ((idx) * 0x10)) ++#define VC5_RESERVED_X0_BYPASS_SYNC BIT(7) /* bypass_sync bit */ + + /* Output divider control for divider 1,2,3,4 */ + #define VC5_OUT_DIV_CONTROL(idx) (0x21 + ((idx) * 0x10)) +@@ -87,7 +90,6 @@ + #define VC5_OUT_DIV_SKEW_INT(idx, n) (0x2b + ((idx) * 0x10) + (n)) + #define VC5_OUT_DIV_INT(idx, n) (0x2d + ((idx) * 0x10) + (n)) + #define VC5_OUT_DIV_SKEW_FRAC(idx) (0x2f + ((idx) * 0x10)) +-/* Registers 0x30, 0x40, 0x50 are factory reserved */ + + /* Clock control register for clock 1,2 */ + #define VC5_CLK_OUTPUT_CFG(idx, n) (0x60 + ((idx) * 0x2) + (n)) +@@ -140,6 +142,8 @@ + #define VC5_HAS_INTERNAL_XTAL BIT(0) + /* chip has PFD requency doubler */ + #define VC5_HAS_PFD_FREQ_DBL BIT(1) ++/* chip has bits to disable FOD sync */ ++#define VC5_HAS_BYPASS_SYNC_BIT BIT(2) + + /* Supported IDT VC5 models. */ + enum vc5_model { +@@ -581,6 +585,23 @@ static int vc5_clk_out_prepare(struct clk_hw *hw) + unsigned int src; + int ret; + ++ /* ++ * When enabling a FOD, all currently enabled FODs are briefly ++ * stopped in order to synchronize all of them. This causes a clock ++ * disruption to any unrelated chips that might be already using ++ * other clock outputs. Bypass the sync feature to avoid the issue, ++ * which is possible on the VersaClock 6E family via reserved ++ * registers. ++ */ ++ if (vc5->chip_info->flags & VC5_HAS_BYPASS_SYNC_BIT) { ++ ret = regmap_update_bits(vc5->regmap, ++ VC5_RESERVED_X0(hwdata->num), ++ VC5_RESERVED_X0_BYPASS_SYNC, ++ VC5_RESERVED_X0_BYPASS_SYNC); ++ if (ret) ++ return ret; ++ } ++ + /* + * If the input mux is disabled, enable it first and + * select source from matching FOD. +@@ -1102,7 +1123,7 @@ static const struct vc5_chip_info idt_5p49v6965_info = { + .model = IDT_VC6_5P49V6965, + .clk_fod_cnt = 4, + .clk_out_cnt = 5, +- .flags = 0, ++ .flags = VC5_HAS_BYPASS_SYNC_BIT, + }; + + static const struct i2c_device_id vc5_id[] = { +-- +2.30.2 + diff --git a/queue-5.10/clocksource-check-per-cpu-clock-synchronization-when.patch b/queue-5.10/clocksource-check-per-cpu-clock-synchronization-when.patch new file mode 100644 index 00000000000..e82d4e1ae26 --- /dev/null +++ b/queue-5.10/clocksource-check-per-cpu-clock-synchronization-when.patch @@ -0,0 +1,142 @@ +From 172094bf445b346b512ef2f11abdf8e085f035bf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 12:01:20 -0700 +Subject: clocksource: Check per-CPU clock synchronization when marked unstable + +From: Paul E. McKenney + +[ Upstream commit 7560c02bdffb7c52d1457fa551b9e745d4b9e754 ] + +Some sorts of per-CPU clock sources have a history of going out of +synchronization with each other. However, this problem has purportedy been +solved in the past ten years. Except that it is all too possible that the +problem has instead simply been made less likely, which might mean that +some of the occasional "Marking clocksource 'tsc' as unstable" messages +might be due to desynchronization. How would anyone know? + +Therefore apply CPU-to-CPU synchronization checking to newly unstable +clocksource that are marked with the new CLOCK_SOURCE_VERIFY_PERCPU flag. +Lists of desynchronized CPUs are printed, with the caveat that if it +is the reporting CPU that is itself desynchronized, it will appear that +all the other clocks are wrong. Just like in real life. + +Reported-by: Chris Mason +Signed-off-by: Paul E. McKenney +Signed-off-by: Thomas Gleixner +Acked-by: Feng Tang +Link: https://lore.kernel.org/r/20210527190124.440372-2-paulmck@kernel.org +Signed-off-by: Sasha Levin +--- + arch/x86/kernel/tsc.c | 3 +- + include/linux/clocksource.h | 2 +- + kernel/time/clocksource.c | 60 +++++++++++++++++++++++++++++++++++++ + 3 files changed, 63 insertions(+), 2 deletions(-) + +diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c +index f70dffc2771f..56289170753c 100644 +--- a/arch/x86/kernel/tsc.c ++++ b/arch/x86/kernel/tsc.c +@@ -1151,7 +1151,8 @@ static struct clocksource clocksource_tsc = { + .mask = CLOCKSOURCE_MASK(64), + .flags = CLOCK_SOURCE_IS_CONTINUOUS | + CLOCK_SOURCE_VALID_FOR_HRES | +- CLOCK_SOURCE_MUST_VERIFY, ++ CLOCK_SOURCE_MUST_VERIFY | ++ CLOCK_SOURCE_VERIFY_PERCPU, + .vdso_clock_mode = VDSO_CLOCKMODE_TSC, + .enable = tsc_cs_enable, + .resume = tsc_resume, +diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h +index 86d143db6523..83a3ebff7456 100644 +--- a/include/linux/clocksource.h ++++ b/include/linux/clocksource.h +@@ -131,7 +131,7 @@ struct clocksource { + #define CLOCK_SOURCE_UNSTABLE 0x40 + #define CLOCK_SOURCE_SUSPEND_NONSTOP 0x80 + #define CLOCK_SOURCE_RESELECT 0x100 +- ++#define CLOCK_SOURCE_VERIFY_PERCPU 0x200 + /* simplify initialization of mask field */ + #define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0) + +diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c +index a2059b78e34b..74492f08660c 100644 +--- a/kernel/time/clocksource.c ++++ b/kernel/time/clocksource.c +@@ -224,6 +224,60 @@ static bool cs_watchdog_read(struct clocksource *cs, u64 *csnow, u64 *wdnow) + return false; + } + ++static u64 csnow_mid; ++static cpumask_t cpus_ahead; ++static cpumask_t cpus_behind; ++ ++static void clocksource_verify_one_cpu(void *csin) ++{ ++ struct clocksource *cs = (struct clocksource *)csin; ++ ++ csnow_mid = cs->read(cs); ++} ++ ++static void clocksource_verify_percpu(struct clocksource *cs) ++{ ++ int64_t cs_nsec, cs_nsec_max = 0, cs_nsec_min = LLONG_MAX; ++ u64 csnow_begin, csnow_end; ++ int cpu, testcpu; ++ s64 delta; ++ ++ cpumask_clear(&cpus_ahead); ++ cpumask_clear(&cpus_behind); ++ preempt_disable(); ++ testcpu = smp_processor_id(); ++ pr_warn("Checking clocksource %s synchronization from CPU %d.\n", cs->name, testcpu); ++ for_each_online_cpu(cpu) { ++ if (cpu == testcpu) ++ continue; ++ csnow_begin = cs->read(cs); ++ smp_call_function_single(cpu, clocksource_verify_one_cpu, cs, 1); ++ csnow_end = cs->read(cs); ++ delta = (s64)((csnow_mid - csnow_begin) & cs->mask); ++ if (delta < 0) ++ cpumask_set_cpu(cpu, &cpus_behind); ++ delta = (csnow_end - csnow_mid) & cs->mask; ++ if (delta < 0) ++ cpumask_set_cpu(cpu, &cpus_ahead); ++ delta = clocksource_delta(csnow_end, csnow_begin, cs->mask); ++ cs_nsec = clocksource_cyc2ns(delta, cs->mult, cs->shift); ++ if (cs_nsec > cs_nsec_max) ++ cs_nsec_max = cs_nsec; ++ if (cs_nsec < cs_nsec_min) ++ cs_nsec_min = cs_nsec; ++ } ++ preempt_enable(); ++ if (!cpumask_empty(&cpus_ahead)) ++ pr_warn(" CPUs %*pbl ahead of CPU %d for clocksource %s.\n", ++ cpumask_pr_args(&cpus_ahead), testcpu, cs->name); ++ if (!cpumask_empty(&cpus_behind)) ++ pr_warn(" CPUs %*pbl behind CPU %d for clocksource %s.\n", ++ cpumask_pr_args(&cpus_behind), testcpu, cs->name); ++ if (!cpumask_empty(&cpus_ahead) || !cpumask_empty(&cpus_behind)) ++ pr_warn(" CPU %d check durations %lldns - %lldns for clocksource %s.\n", ++ testcpu, cs_nsec_min, cs_nsec_max, cs->name); ++} ++ + static void clocksource_watchdog(struct timer_list *unused) + { + u64 csnow, wdnow, cslast, wdlast, delta; +@@ -448,6 +502,12 @@ static int __clocksource_watchdog_kthread(void) + unsigned long flags; + int select = 0; + ++ /* Do any required per-CPU skew verification. */ ++ if (curr_clocksource && ++ curr_clocksource->flags & CLOCK_SOURCE_UNSTABLE && ++ curr_clocksource->flags & CLOCK_SOURCE_VERIFY_PERCPU) ++ clocksource_verify_percpu(curr_clocksource); ++ + spin_lock_irqsave(&watchdog_lock, flags); + list_for_each_entry_safe(cs, tmp, &watchdog_list, wd_list) { + if (cs->flags & CLOCK_SOURCE_UNSTABLE) { +-- +2.30.2 + diff --git a/queue-5.10/clocksource-drivers-timer-ti-dm-save-and-restore-tim.patch b/queue-5.10/clocksource-drivers-timer-ti-dm-save-and-restore-tim.patch new file mode 100644 index 00000000000..6fb4e3245e6 --- /dev/null +++ b/queue-5.10/clocksource-drivers-timer-ti-dm-save-and-restore-tim.patch @@ -0,0 +1,67 @@ +From e4566373f1768b80b538a519495539abd928cb4a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 15 Apr 2021 11:55:06 +0300 +Subject: clocksource/drivers/timer-ti-dm: Save and restore timer TIOCP_CFG + +From: Tony Lindgren + +[ Upstream commit 9517c577f9f722270584cfb1a7b4e1354e408658 ] + +As we are using cpu_pm to save and restore context, we must also save and +restore the timer sysconfig register TIOCP_CFG. This is needed because +we are not calling PM runtime functions at all with cpu_pm. + +Fixes: b34677b0999a ("clocksource/drivers/timer-ti-dm: Implement cpu_pm notifier for context save and restore") +Cc: Aaro Koskinen +Cc: Adam Ford +Cc: Andreas Kemnade +Cc: Lokesh Vutla +Cc: Peter Ujfalusi +Signed-off-by: Tony Lindgren +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/20210415085506.56828-1-tony@atomide.com +Signed-off-by: Sasha Levin +--- + drivers/clocksource/timer-ti-dm.c | 6 ++++++ + include/clocksource/timer-ti-dm.h | 1 + + 2 files changed, 7 insertions(+) + +diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c +index 33eeabf9c3d1..e5c631f1b5cb 100644 +--- a/drivers/clocksource/timer-ti-dm.c ++++ b/drivers/clocksource/timer-ti-dm.c +@@ -78,6 +78,9 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg, + + static void omap_timer_restore_context(struct omap_dm_timer *timer) + { ++ __omap_dm_timer_write(timer, OMAP_TIMER_OCP_CFG_OFFSET, ++ timer->context.ocp_cfg, 0); ++ + omap_dm_timer_write_reg(timer, OMAP_TIMER_WAKEUP_EN_REG, + timer->context.twer); + omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, +@@ -95,6 +98,9 @@ static void omap_timer_restore_context(struct omap_dm_timer *timer) + + static void omap_timer_save_context(struct omap_dm_timer *timer) + { ++ timer->context.ocp_cfg = ++ __omap_dm_timer_read(timer, OMAP_TIMER_OCP_CFG_OFFSET, 0); ++ + timer->context.tclr = + omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG); + timer->context.twer = +diff --git a/include/clocksource/timer-ti-dm.h b/include/clocksource/timer-ti-dm.h +index 4c61dade8835..f6da8a132639 100644 +--- a/include/clocksource/timer-ti-dm.h ++++ b/include/clocksource/timer-ti-dm.h +@@ -74,6 +74,7 @@ + #define OMAP_TIMER_ERRATA_I103_I767 0x80000000 + + struct timer_regs { ++ u32 ocp_cfg; + u32 tidr; + u32 tier; + u32 twer; +-- +2.30.2 + diff --git a/queue-5.10/clocksource-retry-clock-read-if-long-delays-detected.patch b/queue-5.10/clocksource-retry-clock-read-if-long-delays-detected.patch new file mode 100644 index 00000000000..daafbbf2a89 --- /dev/null +++ b/queue-5.10/clocksource-retry-clock-read-if-long-delays-detected.patch @@ -0,0 +1,144 @@ +From c336319a2d166de3eb6f705f4cffa30d18884b48 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 12:01:19 -0700 +Subject: clocksource: Retry clock read if long delays detected + +From: Paul E. McKenney + +[ Upstream commit db3a34e17433de2390eb80d436970edcebd0ca3e ] + +When the clocksource watchdog marks a clock as unstable, this might be due +to that clock being unstable or it might be due to delays that happen to +occur between the reads of the two clocks. Yes, interrupts are disabled +across those two reads, but there are no shortage of things that can delay +interrupts-disabled regions of code ranging from SMI handlers to vCPU +preemption. It would be good to have some indication as to why the clock +was marked unstable. + +Therefore, re-read the watchdog clock on either side of the read from the +clock under test. If the watchdog clock shows an excessive time delta +between its pair of reads, the reads are retried. + +The maximum number of retries is specified by a new kernel boot parameter +clocksource.max_cswd_read_retries, which defaults to three, that is, up to +four reads, one initial and up to three retries. If more than one retry +was required, a message is printed on the console (the occasional single +retry is expected behavior, especially in guest OSes). If the maximum +number of retries is exceeded, the clock under test will be marked +unstable. However, the probability of this happening due to various sorts +of delays is quite small. In addition, the reason (clock-read delays) for +the unstable marking will be apparent. + +Reported-by: Chris Mason +Signed-off-by: Paul E. McKenney +Signed-off-by: Thomas Gleixner +Acked-by: Feng Tang +Link: https://lore.kernel.org/r/20210527190124.440372-1-paulmck@kernel.org +Signed-off-by: Sasha Levin +--- + .../admin-guide/kernel-parameters.txt | 6 +++ + kernel/time/clocksource.c | 53 ++++++++++++++++--- + 2 files changed, 53 insertions(+), 6 deletions(-) + +diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt +index 26bfe7ae711b..f103667d3727 100644 +--- a/Documentation/admin-guide/kernel-parameters.txt ++++ b/Documentation/admin-guide/kernel-parameters.txt +@@ -577,6 +577,12 @@ + loops can be debugged more effectively on production + systems. + ++ clocksource.max_cswd_read_retries= [KNL] ++ Number of clocksource_watchdog() retries due to ++ external delays before the clock will be marked ++ unstable. Defaults to three retries, that is, ++ four attempts to read the clock under test. ++ + clearcpuid=BITNUM[,BITNUM...] [X86] + Disable CPUID feature X for the kernel. See + arch/x86/include/asm/cpufeatures.h for the valid bit +diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c +index 02441ead3c3b..a2059b78e34b 100644 +--- a/kernel/time/clocksource.c ++++ b/kernel/time/clocksource.c +@@ -124,6 +124,13 @@ static void __clocksource_change_rating(struct clocksource *cs, int rating); + #define WATCHDOG_INTERVAL (HZ >> 1) + #define WATCHDOG_THRESHOLD (NSEC_PER_SEC >> 4) + ++/* ++ * Maximum permissible delay between two readouts of the watchdog ++ * clocksource surrounding a read of the clocksource being validated. ++ * This delay could be due to SMIs, NMIs, or to VCPU preemptions. ++ */ ++#define WATCHDOG_MAX_SKEW (100 * NSEC_PER_USEC) ++ + static void clocksource_watchdog_work(struct work_struct *work) + { + /* +@@ -184,12 +191,45 @@ void clocksource_mark_unstable(struct clocksource *cs) + spin_unlock_irqrestore(&watchdog_lock, flags); + } + ++static ulong max_cswd_read_retries = 3; ++module_param(max_cswd_read_retries, ulong, 0644); ++ ++static bool cs_watchdog_read(struct clocksource *cs, u64 *csnow, u64 *wdnow) ++{ ++ unsigned int nretries; ++ u64 wd_end, wd_delta; ++ int64_t wd_delay; ++ ++ for (nretries = 0; nretries <= max_cswd_read_retries; nretries++) { ++ local_irq_disable(); ++ *wdnow = watchdog->read(watchdog); ++ *csnow = cs->read(cs); ++ wd_end = watchdog->read(watchdog); ++ local_irq_enable(); ++ ++ wd_delta = clocksource_delta(wd_end, *wdnow, watchdog->mask); ++ wd_delay = clocksource_cyc2ns(wd_delta, watchdog->mult, ++ watchdog->shift); ++ if (wd_delay <= WATCHDOG_MAX_SKEW) { ++ if (nretries > 1 || nretries >= max_cswd_read_retries) { ++ pr_warn("timekeeping watchdog on CPU%d: %s retried %d times before success\n", ++ smp_processor_id(), watchdog->name, nretries); ++ } ++ return true; ++ } ++ } ++ ++ pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n", ++ smp_processor_id(), watchdog->name, wd_delay, nretries); ++ return false; ++} ++ + static void clocksource_watchdog(struct timer_list *unused) + { +- struct clocksource *cs; + u64 csnow, wdnow, cslast, wdlast, delta; +- int64_t wd_nsec, cs_nsec; + int next_cpu, reset_pending; ++ int64_t wd_nsec, cs_nsec; ++ struct clocksource *cs; + + spin_lock(&watchdog_lock); + if (!watchdog_running) +@@ -206,10 +246,11 @@ static void clocksource_watchdog(struct timer_list *unused) + continue; + } + +- local_irq_disable(); +- csnow = cs->read(cs); +- wdnow = watchdog->read(watchdog); +- local_irq_enable(); ++ if (!cs_watchdog_read(cs, &csnow, &wdnow)) { ++ /* Clock readout unreliable, so give it up. */ ++ __clocksource_unstable(cs); ++ continue; ++ } + + /* Clocksource initialized ? */ + if (!(cs->flags & CLOCK_SOURCE_WATCHDOG) || +-- +2.30.2 + diff --git a/queue-5.10/configfs-fix-memleak-in-configfs_release_bin_file.patch b/queue-5.10/configfs-fix-memleak-in-configfs_release_bin_file.patch new file mode 100644 index 00000000000..a085f411a90 --- /dev/null +++ b/queue-5.10/configfs-fix-memleak-in-configfs_release_bin_file.patch @@ -0,0 +1,47 @@ +From 9517c01d5d88658032b8600b69e19b71043dcd5b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 15:59:25 +0800 +Subject: configfs: fix memleak in configfs_release_bin_file + +From: Chung-Chiang Cheng + +[ Upstream commit 3c252b087de08d3cb32468b54a158bd7ad0ae2f7 ] + +When reading binary attributes in progress, buffer->bin_buffer is setup in +configfs_read_bin_file() but never freed. + +Fixes: 03607ace807b4 ("configfs: implement binary attributes") +Signed-off-by: Chung-Chiang Cheng +[hch: move the vfree rather than duplicating it] +Signed-off-by: Christoph Hellwig +Signed-off-by: Sasha Levin +--- + fs/configfs/file.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/fs/configfs/file.c b/fs/configfs/file.c +index da8351d1e455..4d0825213116 100644 +--- a/fs/configfs/file.c ++++ b/fs/configfs/file.c +@@ -482,13 +482,13 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file) + buffer->bin_buffer_size); + } + up_read(&frag->frag_sem); +- /* vfree on NULL is safe */ +- vfree(buffer->bin_buffer); +- buffer->bin_buffer = NULL; +- buffer->bin_buffer_size = 0; +- buffer->needs_read_fill = 1; + } + ++ vfree(buffer->bin_buffer); ++ buffer->bin_buffer = NULL; ++ buffer->bin_buffer_size = 0; ++ buffer->needs_read_fill = 1; ++ + configfs_release(inode, file); + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/coresight-core-fix-use-of-uninitialized-pointer.patch b/queue-5.10/coresight-core-fix-use-of-uninitialized-pointer.patch new file mode 100644 index 00000000000..9d05b034fa8 --- /dev/null +++ b/queue-5.10/coresight-core-fix-use-of-uninitialized-pointer.patch @@ -0,0 +1,41 @@ +From 9f6fc34932f695b1eb13fede75f39811372949e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Jun 2021 11:58:57 -0600 +Subject: coresight: core: Fix use of uninitialized pointer + +From: Junhao He + +[ Upstream commit d777a8991847729ec4e2a13fcad58c2b00bb19dc ] + +Currently the pointer "sink" might be checked before initialized. Fix +this by initializing this pointer. + +Link: https://lore.kernel.org/r/1620912469-52222-2-git-send-email-liuqi115@huawei.com +Fixes: 6d578258b955 ("coresight: Make sysfs functional on topologies with per core sink") +Signed-off-by: Junhao He +Signed-off-by: Qi Liu +Signed-off-by: Suzuki K Poulose +Signed-off-by: Mathieu Poirier +Link: https://lore.kernel.org/r/20210614175901.532683-3-mathieu.poirier@linaro.org +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/hwtracing/coresight/coresight-core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c +index cc9e8025c533..b2088d2d386a 100644 +--- a/drivers/hwtracing/coresight/coresight-core.c ++++ b/drivers/hwtracing/coresight/coresight-core.c +@@ -581,7 +581,7 @@ static struct coresight_device * + coresight_find_enabled_sink(struct coresight_device *csdev) + { + int i; +- struct coresight_device *sink; ++ struct coresight_device *sink = NULL; + + if ((csdev->type == CORESIGHT_DEV_TYPE_SINK || + csdev->type == CORESIGHT_DEV_TYPE_LINKSINK) && +-- +2.30.2 + diff --git a/queue-5.10/cpufreq-make-cpufreq_online-call-driver-offline-on-e.patch b/queue-5.10/cpufreq-make-cpufreq_online-call-driver-offline-on-e.patch new file mode 100644 index 00000000000..356635ee59d --- /dev/null +++ b/queue-5.10/cpufreq-make-cpufreq_online-call-driver-offline-on-e.patch @@ -0,0 +1,62 @@ +From 96c150ab868a54ea2d20cc718f68de53dadfb3a8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 21:11:39 +0200 +Subject: cpufreq: Make cpufreq_online() call driver->offline() on errors + +From: Rafael J. Wysocki + +[ Upstream commit 3b7180573c250eb6e2a7eec54ae91f27472332ea ] + +In the CPU removal path the ->offline() callback provided by the +driver is always invoked before ->exit(), but in the cpufreq_online() +error path it is not, so ->exit() is expected to somehow know the +context in which it has been called and act accordingly. + +That is less than straightforward, so make cpufreq_online() invoke +the driver's ->offline() callback, if present, on errors before +->exit() too. + +This only potentially affects intel_pstate. + +Fixes: 91a12e91dc39 ("cpufreq: Allow light-weight tear down and bring up of CPUs") +Signed-off-by: Rafael J. Wysocki +Acked-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/cpufreq.c | 11 ++++++++++- + 1 file changed, 10 insertions(+), 1 deletion(-) + +diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c +index 1e7e3f2ff09f..ebee0ad559fa 100644 +--- a/drivers/cpufreq/cpufreq.c ++++ b/drivers/cpufreq/cpufreq.c +@@ -1368,9 +1368,14 @@ static int cpufreq_online(unsigned int cpu) + goto out_free_policy; + } + ++ /* ++ * The initialization has succeeded and the policy is online. ++ * If there is a problem with its frequency table, take it ++ * offline and drop it. ++ */ + ret = cpufreq_table_validate_and_sort(policy); + if (ret) +- goto out_exit_policy; ++ goto out_offline_policy; + + /* related_cpus should at least include policy->cpus. */ + cpumask_copy(policy->related_cpus, policy->cpus); +@@ -1513,6 +1518,10 @@ out_destroy_policy: + + up_write(&policy->rwsem); + ++out_offline_policy: ++ if (cpufreq_driver->offline) ++ cpufreq_driver->offline(policy); ++ + out_exit_policy: + if (cpufreq_driver->exit) + cpufreq_driver->exit(policy); +-- +2.30.2 + diff --git a/queue-5.10/crypto-ccp-fix-a-resource-leak-in-an-error-handling-.patch b/queue-5.10/crypto-ccp-fix-a-resource-leak-in-an-error-handling-.patch new file mode 100644 index 00000000000..37e97ef6886 --- /dev/null +++ b/queue-5.10/crypto-ccp-fix-a-resource-leak-in-an-error-handling-.patch @@ -0,0 +1,51 @@ +From a53a18b879150f65dce99a62c12ff0359d1e4611 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 16 May 2021 08:58:04 +0200 +Subject: crypto: ccp - Fix a resource leak in an error handling path + +From: Christophe JAILLET + +[ Upstream commit a6f8e68e238a15bb15f1726b35c695136c64eaba ] + +If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be +called as already done in the error handling path. + +Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration") +Signed-off-by: Christophe JAILLET +Acked-by: John Allen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/ccp/sp-pci.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c +index f471dbaef1fb..7d346d842a39 100644 +--- a/drivers/crypto/ccp/sp-pci.c ++++ b/drivers/crypto/ccp/sp-pci.c +@@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) + if (ret) { + dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", + ret); +- goto e_err; ++ goto free_irqs; + } + } + +@@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) + + ret = sp_init(sp); + if (ret) +- goto e_err; ++ goto free_irqs; + + return 0; + ++free_irqs: ++ sp_free_irqs(sp); + e_err: + dev_notice(dev, "initialization failed\n"); + return ret; +-- +2.30.2 + diff --git a/queue-5.10/crypto-hisilicon-sec-fixup-3des-minimum-key-size-dec.patch b/queue-5.10/crypto-hisilicon-sec-fixup-3des-minimum-key-size-dec.patch new file mode 100644 index 00000000000..25b8eea201f --- /dev/null +++ b/queue-5.10/crypto-hisilicon-sec-fixup-3des-minimum-key-size-dec.patch @@ -0,0 +1,39 @@ +From 18e3313a975a5752d4410878bce0bf48c8f28c54 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 19:42:06 +0800 +Subject: crypto: hisilicon/sec - fixup 3des minimum key size declaration + +From: Kai Ye + +[ Upstream commit 6161f40c630bd7ced5f236cd5fbabec06e47afae ] + +Fixup the 3des algorithm minimum key size declaration. + +Signed-off-by: Kai Ye +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/hisilicon/sec2/sec_crypto.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c +index 41f1fcacb280..630dcb59ad56 100644 +--- a/drivers/crypto/hisilicon/sec2/sec_crypto.c ++++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c +@@ -1515,11 +1515,11 @@ static struct skcipher_alg sec_skciphers[] = { + AES_BLOCK_SIZE, AES_BLOCK_SIZE) + + SEC_SKCIPHER_ALG("ecb(des3_ede)", sec_setkey_3des_ecb, +- SEC_DES3_2KEY_SIZE, SEC_DES3_3KEY_SIZE, ++ SEC_DES3_3KEY_SIZE, SEC_DES3_3KEY_SIZE, + DES3_EDE_BLOCK_SIZE, 0) + + SEC_SKCIPHER_ALG("cbc(des3_ede)", sec_setkey_3des_cbc, +- SEC_DES3_2KEY_SIZE, SEC_DES3_3KEY_SIZE, ++ SEC_DES3_3KEY_SIZE, SEC_DES3_3KEY_SIZE, + DES3_EDE_BLOCK_SIZE, DES3_EDE_BLOCK_SIZE) + + SEC_SKCIPHER_ALG("xts(sm4)", sec_setkey_sm4_xts, +-- +2.30.2 + diff --git a/queue-5.10/crypto-ixp4xx-dma_unmap-the-correct-address.patch b/queue-5.10/crypto-ixp4xx-dma_unmap-the-correct-address.patch new file mode 100644 index 00000000000..3f32619cf62 --- /dev/null +++ b/queue-5.10/crypto-ixp4xx-dma_unmap-the-correct-address.patch @@ -0,0 +1,38 @@ +From 1fe2db9d269f860b5fdcd728299d5c806fbdd063 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 20:26:08 +0000 +Subject: crypto: ixp4xx - dma_unmap the correct address + +From: Corentin Labbe + +[ Upstream commit 9395c58fdddd79cdd3882132cdd04e8ac7ad525f ] + +Testing ixp4xx_crypto with CONFIG_DMA_API_DEBUG lead to the following error: +DMA-API: platform ixp4xx_crypto.0: device driver tries to free DMA memory it has not allocated [device address=0x0000000000000000] [size=24 bytes] + +This is due to dma_unmap using the wrong address. + +Fixes: 0d44dc59b2b4 ("crypto: ixp4xx - Fix handling of chained sg buffers") +Signed-off-by: Corentin Labbe +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/ixp4xx_crypto.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c +index 276012e7c482..cbb1fda299a8 100644 +--- a/drivers/crypto/ixp4xx_crypto.c ++++ b/drivers/crypto/ixp4xx_crypto.c +@@ -330,7 +330,7 @@ static void free_buf_chain(struct device *dev, struct buffer_desc *buf, + + buf1 = buf->next; + phys1 = buf->phys_next; +- dma_unmap_single(dev, buf->phys_next, buf->buf_len, buf->dir); ++ dma_unmap_single(dev, buf->phys_addr, buf->buf_len, buf->dir); + dma_pool_free(buffer_pool, buf, phys); + buf = buf1; + phys = phys1; +-- +2.30.2 + diff --git a/queue-5.10/crypto-ixp4xx-update-iv-after-requests.patch b/queue-5.10/crypto-ixp4xx-update-iv-after-requests.patch new file mode 100644 index 00000000000..6b4977c4e44 --- /dev/null +++ b/queue-5.10/crypto-ixp4xx-update-iv-after-requests.patch @@ -0,0 +1,84 @@ +From a9bacfcf7f86f2c0adcd207f091564a911b50a7b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 20:26:09 +0000 +Subject: crypto: ixp4xx - update IV after requests + +From: Corentin Labbe + +[ Upstream commit e8acf011f2e7e21a7e2fae47cbaa06598e533d40 ] + +Crypto selftests fail on ixp4xx since it do not update IV after skcipher +requests. + +Fixes: 81bef0150074 ("crypto: ixp4xx - Hardware crypto support for IXP4xx CPUs") +Signed-off-by: Corentin Labbe +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/ixp4xx_crypto.c | 22 ++++++++++++++++++++++ + 1 file changed, 22 insertions(+) + +diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c +index cbb1fda299a8..5e474a7a1912 100644 +--- a/drivers/crypto/ixp4xx_crypto.c ++++ b/drivers/crypto/ixp4xx_crypto.c +@@ -149,6 +149,8 @@ struct crypt_ctl { + struct ablk_ctx { + struct buffer_desc *src; + struct buffer_desc *dst; ++ u8 iv[MAX_IVLEN]; ++ bool encrypt; + }; + + struct aead_ctx { +@@ -381,6 +383,20 @@ static void one_packet(dma_addr_t phys) + case CTL_FLAG_PERFORM_ABLK: { + struct skcipher_request *req = crypt->data.ablk_req; + struct ablk_ctx *req_ctx = skcipher_request_ctx(req); ++ struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(req); ++ unsigned int ivsize = crypto_skcipher_ivsize(tfm); ++ unsigned int offset; ++ ++ if (ivsize > 0) { ++ offset = req->cryptlen - ivsize; ++ if (req_ctx->encrypt) { ++ scatterwalk_map_and_copy(req->iv, req->dst, ++ offset, ivsize, 0); ++ } else { ++ memcpy(req->iv, req_ctx->iv, ivsize); ++ memzero_explicit(req_ctx->iv, ivsize); ++ } ++ } + + if (req_ctx->dst) { + free_buf_chain(dev, req_ctx->dst, crypt->dst_buf); +@@ -876,6 +892,7 @@ static int ablk_perform(struct skcipher_request *req, int encrypt) + struct ablk_ctx *req_ctx = skcipher_request_ctx(req); + struct buffer_desc src_hook; + struct device *dev = &pdev->dev; ++ unsigned int offset; + gfp_t flags = req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP ? + GFP_KERNEL : GFP_ATOMIC; + +@@ -885,6 +902,7 @@ static int ablk_perform(struct skcipher_request *req, int encrypt) + return -EAGAIN; + + dir = encrypt ? &ctx->encrypt : &ctx->decrypt; ++ req_ctx->encrypt = encrypt; + + crypt = get_crypt_desc(); + if (!crypt) +@@ -900,6 +918,10 @@ static int ablk_perform(struct skcipher_request *req, int encrypt) + + BUG_ON(ivsize && !req->iv); + memcpy(crypt->iv, req->iv, ivsize); ++ if (ivsize > 0 && !encrypt) { ++ offset = req->cryptlen - ivsize; ++ scatterwalk_map_and_copy(req_ctx->iv, req->src, offset, ivsize, 0); ++ } + if (req->src != req->dst) { + struct buffer_desc dst_hook; + crypt->mode |= NPE_OP_NOT_IN_PLACE; +-- +2.30.2 + diff --git a/queue-5.10/crypto-nitrox-fix-unchecked-variable-in-nitrox_regis.patch b/queue-5.10/crypto-nitrox-fix-unchecked-variable-in-nitrox_regis.patch new file mode 100644 index 00000000000..e953dfea53c --- /dev/null +++ b/queue-5.10/crypto-nitrox-fix-unchecked-variable-in-nitrox_regis.patch @@ -0,0 +1,38 @@ +From 08575947727d4916b997f47577ee3feffa23eeb9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 18:01:55 +0800 +Subject: crypto: nitrox - fix unchecked variable in nitrox_register_interrupts + +From: Tong Tiangen + +[ Upstream commit 57c126661f50b884d3812e7db6e00f2e778eccfb ] + +Function nitrox_register_interrupts leaves variable 'nr_vecs' unchecked, which +would be use as kcalloc parameter later. + +Fixes: 5155e118dda9 ("crypto: cavium/nitrox - use pci_alloc_irq_vectors() while enabling MSI-X.") +Signed-off-by: Tong Tiangen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/crypto/cavium/nitrox/nitrox_isr.c b/drivers/crypto/cavium/nitrox/nitrox_isr.c +index 3dec570a190a..10e3408bf704 100644 +--- a/drivers/crypto/cavium/nitrox/nitrox_isr.c ++++ b/drivers/crypto/cavium/nitrox/nitrox_isr.c +@@ -306,6 +306,10 @@ int nitrox_register_interrupts(struct nitrox_device *ndev) + * Entry 192: NPS_CORE_INT_ACTIVE + */ + nr_vecs = pci_msix_vec_count(pdev); ++ if (nr_vecs < 0) { ++ dev_err(DEV(ndev), "Error in getting vec count %d\n", nr_vecs); ++ return nr_vecs; ++ } + + /* Enable MSI-X */ + ret = pci_alloc_irq_vectors(pdev, nr_vecs, nr_vecs, PCI_IRQ_MSIX); +-- +2.30.2 + diff --git a/queue-5.10/crypto-nx-add-missing-module_device_table.patch b/queue-5.10/crypto-nx-add-missing-module_device_table.patch new file mode 100644 index 00000000000..d89176595dd --- /dev/null +++ b/queue-5.10/crypto-nx-add-missing-module_device_table.patch @@ -0,0 +1,36 @@ +From acb6208c11586ac62c8e0cc3399020e5698b3c46 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 11:14:55 +0800 +Subject: crypto: nx - add missing MODULE_DEVICE_TABLE + +From: Bixuan Cui + +[ Upstream commit 06676aa1f455c74e3ad1624cea3acb9ed2ef71ae ] + +This patch adds missing MODULE_DEVICE_TABLE definition which generates +correct modalias for automatic loading of this driver when it is built +as an external module. + +Reported-by: Hulk Robot +Signed-off-by: Bixuan Cui +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/nx/nx-842-pseries.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c +index 2de5e3672e42..258c5e38a551 100644 +--- a/drivers/crypto/nx/nx-842-pseries.c ++++ b/drivers/crypto/nx/nx-842-pseries.c +@@ -1071,6 +1071,7 @@ static const struct vio_device_id nx842_vio_driver_ids[] = { + {"ibm,compression-v1", "ibm,compression"}, + {"", ""}, + }; ++MODULE_DEVICE_TABLE(vio, nx842_vio_driver_ids); + + static struct vio_driver nx842_vio_driver = { + .name = KBUILD_MODNAME, +-- +2.30.2 + diff --git a/queue-5.10/crypto-nx-fix-rcu-warning-in-nx842_of_upd_status.patch b/queue-5.10/crypto-nx-fix-rcu-warning-in-nx842_of_upd_status.patch new file mode 100644 index 00000000000..682524552ec --- /dev/null +++ b/queue-5.10/crypto-nx-fix-rcu-warning-in-nx842_of_upd_status.patch @@ -0,0 +1,61 @@ +From be442399a8072a8e65efa84f4884b5a6d0ef5bb8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 15:57:12 +0800 +Subject: crypto: nx - Fix RCU warning in nx842_OF_upd_status + +From: Herbert Xu + +[ Upstream commit 2a96726bd0ccde4f12b9b9a9f61f7b1ac5af7e10 ] + +The function nx842_OF_upd_status triggers a sparse RCU warning when +it directly dereferences the RCU-protected devdata. This appears +to be an accident as there was another variable of the same name +that was passed in from the caller. + +After it was removed (because the main purpose of using it, to +update the status member was itself removed) the global variable +unintenionally stood in as its replacement. + +This patch restores the devdata parameter. + +Fixes: 90fd73f912f0 ("crypto: nx - remove pSeries NX 'status' field") +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/nx/nx-842-pseries.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c +index 258c5e38a551..c5ec50a28f30 100644 +--- a/drivers/crypto/nx/nx-842-pseries.c ++++ b/drivers/crypto/nx/nx-842-pseries.c +@@ -538,13 +538,15 @@ static int nx842_OF_set_defaults(struct nx842_devdata *devdata) + * The status field indicates if the device is enabled when the status + * is 'okay'. Otherwise the device driver will be disabled. + * +- * @prop - struct property point containing the maxsyncop for the update ++ * @devdata: struct nx842_devdata to use for dev_info ++ * @prop: struct property point containing the maxsyncop for the update + * + * Returns: + * 0 - Device is available + * -ENODEV - Device is not available + */ +-static int nx842_OF_upd_status(struct property *prop) ++static int nx842_OF_upd_status(struct nx842_devdata *devdata, ++ struct property *prop) + { + const char *status = (const char *)prop->value; + +@@ -758,7 +760,7 @@ static int nx842_OF_upd(struct property *new_prop) + goto out; + + /* Perform property updates */ +- ret = nx842_OF_upd_status(status); ++ ret = nx842_OF_upd_status(new_devdata, status); + if (ret) + goto error_out; + +-- +2.30.2 + diff --git a/queue-5.10/crypto-omap-sham-fix-pm-reference-leak-in-omap-sham-.patch b/queue-5.10/crypto-omap-sham-fix-pm-reference-leak-in-omap-sham-.patch new file mode 100644 index 00000000000..19da7be1bb1 --- /dev/null +++ b/queue-5.10/crypto-omap-sham-fix-pm-reference-leak-in-omap-sham-.patch @@ -0,0 +1,48 @@ +From a76c63b809c572751885be3f0f96a6f57aa9b918 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 22:51:18 +0800 +Subject: crypto: omap-sham - Fix PM reference leak in omap sham ops + +From: Zhang Qilong + +[ Upstream commit ca323b2c61ec321eb9f2179a405b9c34cdb4f553 ] + +pm_runtime_get_sync will increment pm usage counter +even it failed. Forgetting to putting operation will +result in reference leak here. We fix it by replacing +it with pm_runtime_resume_and_get to keep usage counter +balanced. + +Fixes: 604c31039dae4 ("crypto: omap-sham - Check for return value from pm_runtime_get_sync") +Signed-off-by: Zhang Qilong +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/omap-sham.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c +index a3b38d2c92e7..39d17ed1db2f 100644 +--- a/drivers/crypto/omap-sham.c ++++ b/drivers/crypto/omap-sham.c +@@ -371,7 +371,7 @@ static int omap_sham_hw_init(struct omap_sham_dev *dd) + { + int err; + +- err = pm_runtime_get_sync(dd->dev); ++ err = pm_runtime_resume_and_get(dd->dev); + if (err < 0) { + dev_err(dd->dev, "failed to get sync: %d\n", err); + return err; +@@ -2243,7 +2243,7 @@ static int omap_sham_suspend(struct device *dev) + + static int omap_sham_resume(struct device *dev) + { +- int err = pm_runtime_get_sync(dev); ++ int err = pm_runtime_resume_and_get(dev); + if (err < 0) { + dev_err(dev, "failed to get sync: %d\n", err); + return err; +-- +2.30.2 + diff --git a/queue-5.10/crypto-qat-check-return-code-of-qat_hal_rd_rel_reg.patch b/queue-5.10/crypto-qat-check-return-code-of-qat_hal_rd_rel_reg.patch new file mode 100644 index 00000000000..db09b28dde6 --- /dev/null +++ b/queue-5.10/crypto-qat-check-return-code-of-qat_hal_rd_rel_reg.patch @@ -0,0 +1,47 @@ +From f26507cc0198666071f2e3bbdd62f31125490900 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 17 May 2021 05:13:15 -0400 +Subject: crypto: qat - check return code of qat_hal_rd_rel_reg() + +From: Jack Xu + +[ Upstream commit 96b57229209490c8bca4335b01a426a96173dc56 ] + +Check the return code of the function qat_hal_rd_rel_reg() and return it +to the caller. + +This is to fix the following warning when compiling the driver with +clang scan-build: + + drivers/crypto/qat/qat_common/qat_hal.c:1436:2: warning: 6th function call argument is an uninitialized value + +Signed-off-by: Jack Xu +Co-developed-by: Zhehui Xiang +Signed-off-by: Zhehui Xiang +Reviewed-by: Giovanni Cabiddu +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/qat/qat_common/qat_hal.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c +index 52ef80efeddc..b40e81e0088f 100644 +--- a/drivers/crypto/qat/qat_common/qat_hal.c ++++ b/drivers/crypto/qat/qat_common/qat_hal.c +@@ -1213,7 +1213,11 @@ static int qat_hal_put_rel_wr_xfer(struct icp_qat_fw_loader_handle *handle, + pr_err("QAT: bad xfrAddr=0x%x\n", xfr_addr); + return -EINVAL; + } +- qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval); ++ status = qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval); ++ if (status) { ++ pr_err("QAT: failed to read register"); ++ return status; ++ } + gpr_addr = qat_hal_get_reg_addr(ICP_GPB_REL, gprnum); + data16low = 0xffff & data; + data16hi = 0xffff & (data >> 0x10); +-- +2.30.2 + diff --git a/queue-5.10/crypto-qat-remove-unused-macro-in-fw-loader.patch b/queue-5.10/crypto-qat-remove-unused-macro-in-fw-loader.patch new file mode 100644 index 00000000000..ad4b2ab2c33 --- /dev/null +++ b/queue-5.10/crypto-qat-remove-unused-macro-in-fw-loader.patch @@ -0,0 +1,42 @@ +From 7ed8eb5946547a27dcbea671c333495fa72fab81 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 17 May 2021 05:13:16 -0400 +Subject: crypto: qat - remove unused macro in FW loader + +From: Jack Xu + +[ Upstream commit 9afe77cf25d9670e61b489fd52cc6f75fd7f6803 ] + +Remove the unused macro ICP_DH895XCC_PESRAM_BAR_SIZE in the firmware +loader. + +This is to fix the following warning when compiling the driver using the +clang compiler with CC=clang W=2: + + drivers/crypto/qat/qat_common/qat_uclo.c:345:9: warning: macro is not used [-Wunused-macros] + +Signed-off-by: Jack Xu +Co-developed-by: Zhehui Xiang +Signed-off-by: Zhehui Xiang +Reviewed-by: Giovanni Cabiddu +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/qat/qat_common/qat_uclo.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/crypto/qat/qat_common/qat_uclo.c b/drivers/crypto/qat/qat_common/qat_uclo.c +index 5d1f28cd6680..6adc91fedb08 100644 +--- a/drivers/crypto/qat/qat_common/qat_uclo.c ++++ b/drivers/crypto/qat/qat_common/qat_uclo.c +@@ -342,7 +342,6 @@ static int qat_uclo_init_umem_seg(struct icp_qat_fw_loader_handle *handle, + return 0; + } + +-#define ICP_DH895XCC_PESRAM_BAR_SIZE 0x80000 + static int qat_uclo_init_ae_memory(struct icp_qat_fw_loader_handle *handle, + struct icp_qat_uof_initmem *init_mem) + { +-- +2.30.2 + diff --git a/queue-5.10/crypto-qce-skcipher-fix-incorrect-sg-count-for-dma-t.patch b/queue-5.10/crypto-qce-skcipher-fix-incorrect-sg-count-for-dma-t.patch new file mode 100644 index 00000000000..ef3551faa1b --- /dev/null +++ b/queue-5.10/crypto-qce-skcipher-fix-incorrect-sg-count-for-dma-t.patch @@ -0,0 +1,70 @@ +From e569b0c4e71535a6838047831f7b6a4f3ccc39e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 20 May 2021 22:20:23 -0400 +Subject: crypto: qce: skcipher: Fix incorrect sg count for dma transfers + +From: Thara Gopinath + +[ Upstream commit 1339a7c3ba05137a2d2fe75f602311bbfc6fab33 ] + +Use the sg count returned by dma_map_sg to call into +dmaengine_prep_slave_sg rather than using the original sg count. dma_map_sg +can merge consecutive sglist entries, thus making the original sg count +wrong. This is a fix for memory coruption issues observed while testing +encryption/decryption of large messages using libkcapi framework. + +Patch has been tested further by running full suite of tcrypt.ko tests +including fuzz tests. + +Signed-off-by: Thara Gopinath +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/qce/skcipher.c | 15 ++++++++------- + 1 file changed, 8 insertions(+), 7 deletions(-) + +diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c +index a2d3da0ad95f..5a6559131eac 100644 +--- a/drivers/crypto/qce/skcipher.c ++++ b/drivers/crypto/qce/skcipher.c +@@ -71,7 +71,7 @@ qce_skcipher_async_req_handle(struct crypto_async_request *async_req) + struct scatterlist *sg; + bool diff_dst; + gfp_t gfp; +- int ret; ++ int dst_nents, src_nents, ret; + + rctx->iv = req->iv; + rctx->ivsize = crypto_skcipher_ivsize(skcipher); +@@ -122,21 +122,22 @@ qce_skcipher_async_req_handle(struct crypto_async_request *async_req) + sg_mark_end(sg); + rctx->dst_sg = rctx->dst_tbl.sgl; + +- ret = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst); +- if (ret < 0) ++ dst_nents = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst); ++ if (dst_nents < 0) + goto error_free; + + if (diff_dst) { +- ret = dma_map_sg(qce->dev, req->src, rctx->src_nents, dir_src); +- if (ret < 0) ++ src_nents = dma_map_sg(qce->dev, req->src, rctx->src_nents, dir_src); ++ if (src_nents < 0) + goto error_unmap_dst; + rctx->src_sg = req->src; + } else { + rctx->src_sg = rctx->dst_sg; ++ src_nents = dst_nents - 1; + } + +- ret = qce_dma_prep_sgs(&qce->dma, rctx->src_sg, rctx->src_nents, +- rctx->dst_sg, rctx->dst_nents, ++ ret = qce_dma_prep_sgs(&qce->dma, rctx->src_sg, src_nents, ++ rctx->dst_sg, dst_nents, + qce_skcipher_done, async_req); + if (ret) + goto error_unmap_src; +-- +2.30.2 + diff --git a/queue-5.10/crypto-sa2ul-fix-leaks-on-failure-paths-with-sa_dma_.patch b/queue-5.10/crypto-sa2ul-fix-leaks-on-failure-paths-with-sa_dma_.patch new file mode 100644 index 00000000000..b1ae5e867b4 --- /dev/null +++ b/queue-5.10/crypto-sa2ul-fix-leaks-on-failure-paths-with-sa_dma_.patch @@ -0,0 +1,99 @@ +From ba92bdc260867b9609c1f9b80c1c134515db6239 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 11:12:42 -0500 +Subject: crypto: sa2ul - Fix leaks on failure paths with sa_dma_init() + +From: Suman Anna + +[ Upstream commit 4c0716ee1d973f6504d13f0e8d4d10350c85ad37 ] + +The sa_dma_init() function doesn't release the requested dma channels +on all failure paths. Any failure in this function also ends up +leaking the dma pool created in sa_init_mem() in the sa_ul_probe() +function. Fix all of these issues. + +Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") +Signed-off-by: Suman Anna +Reviewed-by: Tero Kristo +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/sa2ul.c | 21 ++++++++++++--------- + 1 file changed, 12 insertions(+), 9 deletions(-) + +diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c +index 4640fe0c1f22..fdc844363f02 100644 +--- a/drivers/crypto/sa2ul.c ++++ b/drivers/crypto/sa2ul.c +@@ -2270,9 +2270,9 @@ static int sa_dma_init(struct sa_crypto_data *dd) + + dd->dma_rx2 = dma_request_chan(dd->dev, "rx2"); + if (IS_ERR(dd->dma_rx2)) { +- dma_release_channel(dd->dma_rx1); +- return dev_err_probe(dd->dev, PTR_ERR(dd->dma_rx2), +- "Unable to request rx2 DMA channel\n"); ++ ret = dev_err_probe(dd->dev, PTR_ERR(dd->dma_rx2), ++ "Unable to request rx2 DMA channel\n"); ++ goto err_dma_rx2; + } + + dd->dma_tx = dma_request_chan(dd->dev, "tx"); +@@ -2293,28 +2293,31 @@ static int sa_dma_init(struct sa_crypto_data *dd) + if (ret) { + dev_err(dd->dev, "can't configure IN dmaengine slave: %d\n", + ret); +- return ret; ++ goto err_dma_config; + } + + ret = dmaengine_slave_config(dd->dma_rx2, &cfg); + if (ret) { + dev_err(dd->dev, "can't configure IN dmaengine slave: %d\n", + ret); +- return ret; ++ goto err_dma_config; + } + + ret = dmaengine_slave_config(dd->dma_tx, &cfg); + if (ret) { + dev_err(dd->dev, "can't configure OUT dmaengine slave: %d\n", + ret); +- return ret; ++ goto err_dma_config; + } + + return 0; + ++err_dma_config: ++ dma_release_channel(dd->dma_tx); + err_dma_tx: +- dma_release_channel(dd->dma_rx1); + dma_release_channel(dd->dma_rx2); ++err_dma_rx2: ++ dma_release_channel(dd->dma_rx1); + + return ret; + } +@@ -2359,7 +2362,7 @@ static int sa_ul_probe(struct platform_device *pdev) + sa_init_mem(dev_data); + ret = sa_dma_init(dev_data); + if (ret) +- goto disable_pm_runtime; ++ goto destroy_dma_pool; + + spin_lock_init(&dev_data->scid_lock); + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); +@@ -2389,9 +2392,9 @@ release_dma: + dma_release_channel(dev_data->dma_rx1); + dma_release_channel(dev_data->dma_tx); + ++destroy_dma_pool: + dma_pool_destroy(dev_data->sc_pool); + +-disable_pm_runtime: + pm_runtime_put_sync(&pdev->dev); + pm_runtime_disable(&pdev->dev); + +-- +2.30.2 + diff --git a/queue-5.10/crypto-sa2ul-fix-pm_runtime-enable-in-sa_ul_probe.patch b/queue-5.10/crypto-sa2ul-fix-pm_runtime-enable-in-sa_ul_probe.patch new file mode 100644 index 00000000000..1af24af9613 --- /dev/null +++ b/queue-5.10/crypto-sa2ul-fix-pm_runtime-enable-in-sa_ul_probe.patch @@ -0,0 +1,39 @@ +From 96a3d223bd9e1c4f9054da7c4031e6e068aa71c9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 11:12:43 -0500 +Subject: crypto: sa2ul - Fix pm_runtime enable in sa_ul_probe() + +From: Suman Anna + +[ Upstream commit 5c8552325e013cbdabc443cd1f1b4d03c4a2e64e ] + +The pm_runtime APIs added first in commit 7694b6ca649f ("crypto: sa2ul - +Add crypto driver") are not unwound properly and was fixed up partially +in commit 13343badae09 ("crypto: sa2ul - Fix PM reference leak in +sa_ul_probe()"). This fixed up the pm_runtime usage count but not the +state. Fix this properly. + +Fixes: 13343badae09 ("crypto: sa2ul - Fix PM reference leak in sa_ul_probe()") +Signed-off-by: Suman Anna +Reviewed-by: Tero Kristo +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/sa2ul.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c +index fdc844363f02..f15fc1fb3707 100644 +--- a/drivers/crypto/sa2ul.c ++++ b/drivers/crypto/sa2ul.c +@@ -2356,6 +2356,7 @@ static int sa_ul_probe(struct platform_device *pdev) + if (ret < 0) { + dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__, + ret); ++ pm_runtime_disable(dev); + return ret; + } + +-- +2.30.2 + diff --git a/queue-5.10/crypto-shash-avoid-comparing-pointers-to-exported-fu.patch b/queue-5.10/crypto-shash-avoid-comparing-pointers-to-exported-fu.patch new file mode 100644 index 00000000000..cb3f65defaf --- /dev/null +++ b/queue-5.10/crypto-shash-avoid-comparing-pointers-to-exported-fu.patch @@ -0,0 +1,88 @@ +From 09d05a45400cf89fa93369a5802cd7e06c8619e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 08:21:50 +0200 +Subject: crypto: shash - avoid comparing pointers to exported functions under + CFI + +From: Ard Biesheuvel + +[ Upstream commit 22ca9f4aaf431a9413dcc115dd590123307f274f ] + +crypto_shash_alg_has_setkey() is implemented by testing whether the +.setkey() member of a struct shash_alg points to the default version, +called shash_no_setkey(). As crypto_shash_alg_has_setkey() is a static +inline, this requires shash_no_setkey() to be exported to modules. + +Unfortunately, when building with CFI, function pointers are routed +via CFI stubs which are private to each module (or to the kernel proper) +and so this function pointer comparison may fail spuriously. + +Let's fix this by turning crypto_shash_alg_has_setkey() into an out of +line function. + +Cc: Sami Tolvanen +Cc: Eric Biggers +Signed-off-by: Ard Biesheuvel +Reviewed-by: Eric Biggers +Reviewed-by: Sami Tolvanen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + crypto/shash.c | 18 +++++++++++++++--- + include/crypto/internal/hash.h | 8 +------- + 2 files changed, 16 insertions(+), 10 deletions(-) + +diff --git a/crypto/shash.c b/crypto/shash.c +index 2e3433ad9762..0a0a50cb694f 100644 +--- a/crypto/shash.c ++++ b/crypto/shash.c +@@ -20,12 +20,24 @@ + + static const struct crypto_type crypto_shash_type; + +-int shash_no_setkey(struct crypto_shash *tfm, const u8 *key, +- unsigned int keylen) ++static int shash_no_setkey(struct crypto_shash *tfm, const u8 *key, ++ unsigned int keylen) + { + return -ENOSYS; + } +-EXPORT_SYMBOL_GPL(shash_no_setkey); ++ ++/* ++ * Check whether an shash algorithm has a setkey function. ++ * ++ * For CFI compatibility, this must not be an inline function. This is because ++ * when CFI is enabled, modules won't get the same address for shash_no_setkey ++ * (if it were exported, which inlining would require) as the core kernel will. ++ */ ++bool crypto_shash_alg_has_setkey(struct shash_alg *alg) ++{ ++ return alg->setkey != shash_no_setkey; ++} ++EXPORT_SYMBOL_GPL(crypto_shash_alg_has_setkey); + + static int shash_setkey_unaligned(struct crypto_shash *tfm, const u8 *key, + unsigned int keylen) +diff --git a/include/crypto/internal/hash.h b/include/crypto/internal/hash.h +index 0a288dddcf5b..25806141db59 100644 +--- a/include/crypto/internal/hash.h ++++ b/include/crypto/internal/hash.h +@@ -75,13 +75,7 @@ void crypto_unregister_ahashes(struct ahash_alg *algs, int count); + int ahash_register_instance(struct crypto_template *tmpl, + struct ahash_instance *inst); + +-int shash_no_setkey(struct crypto_shash *tfm, const u8 *key, +- unsigned int keylen); +- +-static inline bool crypto_shash_alg_has_setkey(struct shash_alg *alg) +-{ +- return alg->setkey != shash_no_setkey; +-} ++bool crypto_shash_alg_has_setkey(struct shash_alg *alg); + + static inline bool crypto_shash_alg_needs_key(struct shash_alg *alg) + { +-- +2.30.2 + diff --git a/queue-5.10/crypto-sm2-fix-a-memory-leak-in-sm2.patch b/queue-5.10/crypto-sm2-fix-a-memory-leak-in-sm2.patch new file mode 100644 index 00000000000..37ea129cef1 --- /dev/null +++ b/queue-5.10/crypto-sm2-fix-a-memory-leak-in-sm2.patch @@ -0,0 +1,87 @@ +From 268a3334e47b3894e7085cd0cf0c9f95b00261dd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 4 Jun 2021 14:30:35 +0800 +Subject: crypto: sm2 - fix a memory leak in sm2 + +From: Hongbo Li + +[ Upstream commit 5cd259ca5d466f65ffd21e2e2fa00fb648a8c555 ] + +SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in +test_akcipher_one(), it will set public key for every test vector, +and don't free ec->Q. This will cause a memory leak. + +This patch alloc ec->Q in sm2_ec_ctx_init(). + +Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm") +Signed-off-by: Hongbo Li +Reviewed-by: Tianjia Zhang +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + crypto/sm2.c | 24 ++++++++++-------------- + 1 file changed, 10 insertions(+), 14 deletions(-) + +diff --git a/crypto/sm2.c b/crypto/sm2.c +index b21addc3ac06..db8a4a265669 100644 +--- a/crypto/sm2.c ++++ b/crypto/sm2.c +@@ -79,10 +79,17 @@ static int sm2_ec_ctx_init(struct mpi_ec_ctx *ec) + goto free; + + rc = -ENOMEM; ++ ++ ec->Q = mpi_point_new(0); ++ if (!ec->Q) ++ goto free; ++ + /* mpi_ec_setup_elliptic_curve */ + ec->G = mpi_point_new(0); +- if (!ec->G) ++ if (!ec->G) { ++ mpi_point_release(ec->Q); + goto free; ++ } + + mpi_set(ec->G->x, x); + mpi_set(ec->G->y, y); +@@ -91,6 +98,7 @@ static int sm2_ec_ctx_init(struct mpi_ec_ctx *ec) + rc = -EINVAL; + ec->n = mpi_scanval(ecp->n); + if (!ec->n) { ++ mpi_point_release(ec->Q); + mpi_point_release(ec->G); + goto free; + } +@@ -386,27 +394,15 @@ static int sm2_set_pub_key(struct crypto_akcipher *tfm, + MPI a; + int rc; + +- ec->Q = mpi_point_new(0); +- if (!ec->Q) +- return -ENOMEM; +- + /* include the uncompressed flag '0x04' */ +- rc = -ENOMEM; + a = mpi_read_raw_data(key, keylen); + if (!a) +- goto error; ++ return -ENOMEM; + + mpi_normalize(a); + rc = sm2_ecc_os2ec(ec->Q, a); + mpi_free(a); +- if (rc) +- goto error; +- +- return 0; + +-error: +- mpi_point_release(ec->Q); +- ec->Q = NULL; + return rc; + } + +-- +2.30.2 + diff --git a/queue-5.10/crypto-sm2-remove-unnecessary-reset-operations.patch b/queue-5.10/crypto-sm2-remove-unnecessary-reset-operations.patch new file mode 100644 index 00000000000..426271b1666 --- /dev/null +++ b/queue-5.10/crypto-sm2-remove-unnecessary-reset-operations.patch @@ -0,0 +1,137 @@ +From 40a25efb7ad1a8b2677cfbcf9023079f0d29af4c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 15 Oct 2020 17:24:41 +0800 +Subject: crypto: sm2 - remove unnecessary reset operations + +From: Tianjia Zhang + +[ Upstream commit 1bc608b4655b8b1491fb100f4cf4f15ae64a8698 ] + +This is an algorithm optimization. The reset operation when +setting the public key is repeated and redundant, so remove it. +At the same time, `sm2_ecc_os2ec()` is optimized to make the +function more simpler and more in line with the Linux code style. + +Signed-off-by: Tianjia Zhang +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + crypto/sm2.c | 75 ++++++++++++++++++++-------------------------------- + 1 file changed, 29 insertions(+), 46 deletions(-) + +diff --git a/crypto/sm2.c b/crypto/sm2.c +index 767e160333f6..b21addc3ac06 100644 +--- a/crypto/sm2.c ++++ b/crypto/sm2.c +@@ -119,12 +119,6 @@ static void sm2_ec_ctx_deinit(struct mpi_ec_ctx *ec) + memset(ec, 0, sizeof(*ec)); + } + +-static int sm2_ec_ctx_reset(struct mpi_ec_ctx *ec) +-{ +- sm2_ec_ctx_deinit(ec); +- return sm2_ec_ctx_init(ec); +-} +- + /* RESULT must have been initialized and is set on success to the + * point given by VALUE. + */ +@@ -132,55 +126,48 @@ static int sm2_ecc_os2ec(MPI_POINT result, MPI value) + { + int rc; + size_t n; +- const unsigned char *buf; +- unsigned char *buf_memory; ++ unsigned char *buf; + MPI x, y; + +- n = (mpi_get_nbits(value)+7)/8; +- buf_memory = kmalloc(n, GFP_KERNEL); +- rc = mpi_print(GCRYMPI_FMT_USG, buf_memory, n, &n, value); +- if (rc) { +- kfree(buf_memory); +- return rc; +- } +- buf = buf_memory; ++ n = MPI_NBYTES(value); ++ buf = kmalloc(n, GFP_KERNEL); ++ if (!buf) ++ return -ENOMEM; + +- if (n < 1) { +- kfree(buf_memory); +- return -EINVAL; +- } +- if (*buf != 4) { +- kfree(buf_memory); +- return -EINVAL; /* No support for point compression. */ +- } +- if (((n-1)%2)) { +- kfree(buf_memory); +- return -EINVAL; +- } +- n = (n-1)/2; ++ rc = mpi_print(GCRYMPI_FMT_USG, buf, n, &n, value); ++ if (rc) ++ goto err_freebuf; ++ ++ rc = -EINVAL; ++ if (n < 1 || ((n - 1) % 2)) ++ goto err_freebuf; ++ /* No support for point compression */ ++ if (*buf != 0x4) ++ goto err_freebuf; ++ ++ rc = -ENOMEM; ++ n = (n - 1) / 2; + x = mpi_read_raw_data(buf + 1, n); +- if (!x) { +- kfree(buf_memory); +- return -ENOMEM; +- } ++ if (!x) ++ goto err_freebuf; + y = mpi_read_raw_data(buf + 1 + n, n); +- kfree(buf_memory); +- if (!y) { +- mpi_free(x); +- return -ENOMEM; +- } ++ if (!y) ++ goto err_freex; + + mpi_normalize(x); + mpi_normalize(y); +- + mpi_set(result->x, x); + mpi_set(result->y, y); + mpi_set_ui(result->z, 1); + +- mpi_free(x); +- mpi_free(y); ++ rc = 0; + +- return 0; ++ mpi_free(y); ++err_freex: ++ mpi_free(x); ++err_freebuf: ++ kfree(buf); ++ return rc; + } + + struct sm2_signature_ctx { +@@ -399,10 +386,6 @@ static int sm2_set_pub_key(struct crypto_akcipher *tfm, + MPI a; + int rc; + +- rc = sm2_ec_ctx_reset(ec); +- if (rc) +- return rc; +- + ec->Q = mpi_point_new(0); + if (!ec->Q) + return -ENOMEM; +-- +2.30.2 + diff --git a/queue-5.10/crypto-ux500-fix-error-return-code-in-hash_hw_final.patch b/queue-5.10/crypto-ux500-fix-error-return-code-in-hash_hw_final.patch new file mode 100644 index 00000000000..a3a0eb64376 --- /dev/null +++ b/queue-5.10/crypto-ux500-fix-error-return-code-in-hash_hw_final.patch @@ -0,0 +1,37 @@ +From 9ec271c7e5ff018c6777f2dda813755f9c57dfbb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 15:00:49 +0800 +Subject: crypto: ux500 - Fix error return code in hash_hw_final() + +From: Zhen Lei + +[ Upstream commit b01360384009ab066940b45f34880991ea7ccbfb ] + +Fix to return a negative error code from the error handling +case instead of 0, as done elsewhere in this function. + +Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Reviewed-by: Linus Walleij +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/ux500/hash/hash_core.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c +index 3d407eebb2ba..1e2daf403032 100644 +--- a/drivers/crypto/ux500/hash/hash_core.c ++++ b/drivers/crypto/ux500/hash/hash_core.c +@@ -1009,6 +1009,7 @@ static int hash_hw_final(struct ahash_request *req) + goto out; + } + } else if (req->nbytes == 0 && ctx->keylen > 0) { ++ ret = -EPERM; + dev_err(device_data->dev, "%s: Empty message with keylength > 0, NOT supported\n", + __func__); + goto out; +-- +2.30.2 + diff --git a/queue-5.10/crypto-x86-curve25519-fix-cpu-feature-checking-logic.patch b/queue-5.10/crypto-x86-curve25519-fix-cpu-feature-checking-logic.patch new file mode 100644 index 00000000000..5f86d5fed73 --- /dev/null +++ b/queue-5.10/crypto-x86-curve25519-fix-cpu-feature-checking-logic.patch @@ -0,0 +1,41 @@ +From f0bf5cf11f634e59a1f525afe06d302a9b034ba0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 01:53:40 -0400 +Subject: crypto: x86/curve25519 - fix cpu feature checking logic in mod_exit + +From: Hangbin Liu + +[ Upstream commit 1b82435d17774f3eaab35dce239d354548aa9da2 ] + +In curve25519_mod_init() the curve25519_alg will be registered only when +(X86_FEATURE_BMI2 && X86_FEATURE_ADX). But in curve25519_mod_exit() +it still checks (X86_FEATURE_BMI2 || X86_FEATURE_ADX) when do crypto +unregister. This will trigger a BUG_ON in crypto_unregister_alg() as +alg->cra_refcnt is 0 if the cpu only supports one of X86_FEATURE_BMI2 +and X86_FEATURE_ADX. + +Fixes: 07b586fe0662 ("crypto: x86/curve25519 - replace with formally verified implementation") +Signed-off-by: Hangbin Liu +Reviewed-by: Jason A. Donenfeld +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + arch/x86/crypto/curve25519-x86_64.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/x86/crypto/curve25519-x86_64.c b/arch/x86/crypto/curve25519-x86_64.c +index 5af8021b98ce..11b4c83c715e 100644 +--- a/arch/x86/crypto/curve25519-x86_64.c ++++ b/arch/x86/crypto/curve25519-x86_64.c +@@ -1500,7 +1500,7 @@ static int __init curve25519_mod_init(void) + static void __exit curve25519_mod_exit(void) + { + if (IS_REACHABLE(CONFIG_CRYPTO_KPP) && +- (boot_cpu_has(X86_FEATURE_BMI2) || boot_cpu_has(X86_FEATURE_ADX))) ++ static_branch_likely(&curve25519_use_bmi2_adx)) + crypto_unregister_kpp(&curve25519_alg); + } + +-- +2.30.2 + diff --git a/queue-5.10/csky-fix-syscache.c-fallthrough-warning.patch b/queue-5.10/csky-fix-syscache.c-fallthrough-warning.patch new file mode 100644 index 00000000000..451aa24884c --- /dev/null +++ b/queue-5.10/csky-fix-syscache.c-fallthrough-warning.patch @@ -0,0 +1,49 @@ +From ab87c42dd5e39bca5772b1a1bc964b414a7eed74 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 11 Apr 2021 09:41:04 -0700 +Subject: csky: fix syscache.c fallthrough warning + +From: Randy Dunlap + +[ Upstream commit 0679d29d3e2351a1c3049c26a63ce1959cad5447 ] + +This case of the switch statement falls through to the following case. +This appears to be on purpose, so declare it as OK. + +../arch/csky/mm/syscache.c: In function '__do_sys_cacheflush': +../arch/csky/mm/syscache.c:17:3: warning: this statement may fall through [-Wimplicit-fallthrough=] + 17 | flush_icache_mm_range(current->mm, + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + 18 | (unsigned long)addr, + | ~~~~~~~~~~~~~~~~~~~~ + 19 | (unsigned long)addr + bytes); + | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +../arch/csky/mm/syscache.c:20:2: note: here + 20 | case DCACHE: + | ^~~~ + +Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all") +Signed-off-by: Randy Dunlap +Signed-off-by: Guo Ren +Cc: linux-csky@vger.kernel.org +Cc: Arnd Bergmann +Signed-off-by: Sasha Levin +--- + arch/csky/mm/syscache.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c +index ffade2f9a4c8..4e51d63850c4 100644 +--- a/arch/csky/mm/syscache.c ++++ b/arch/csky/mm/syscache.c +@@ -17,6 +17,7 @@ SYSCALL_DEFINE3(cacheflush, + flush_icache_mm_range(current->mm, + (unsigned long)addr, + (unsigned long)addr + bytes); ++ fallthrough; + case DCACHE: + dcache_wb_range((unsigned long)addr, + (unsigned long)addr + bytes); +-- +2.30.2 + diff --git a/queue-5.10/csky-syscache-fixup-duplicate-cache-flush.patch b/queue-5.10/csky-syscache-fixup-duplicate-cache-flush.patch new file mode 100644 index 00000000000..e629e605da4 --- /dev/null +++ b/queue-5.10/csky-syscache-fixup-duplicate-cache-flush.patch @@ -0,0 +1,54 @@ +From 539994d82a72968ace4dc15d235a8dc901f3d239 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 14:08:44 +0800 +Subject: csky: syscache: Fixup duplicate cache flush + +From: Guo Ren + +[ Upstream commit 6ea42c84f33368eb3fe1ec1bff8d7cb1a5c7b07a ] + +The current csky logic of sys_cacheflush is wrong, it'll cause +icache flush call dcache flush again. Now fixup it with a +conditional "break & fallthrough". + +Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all") +Fixes: 0679d29d3e23 ("csky: fix syscache.c fallthrough warning") +Acked-by: Randy Dunlap +Co-Developed-by: Randy Dunlap +Signed-off-by: Guo Ren +Cc: Arnd Bergmann +Signed-off-by: Sasha Levin +--- + arch/csky/mm/syscache.c | 12 +++++++----- + 1 file changed, 7 insertions(+), 5 deletions(-) + +diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c +index 4e51d63850c4..cd847ad62c7e 100644 +--- a/arch/csky/mm/syscache.c ++++ b/arch/csky/mm/syscache.c +@@ -12,15 +12,17 @@ SYSCALL_DEFINE3(cacheflush, + int, cache) + { + switch (cache) { +- case ICACHE: + case BCACHE: +- flush_icache_mm_range(current->mm, +- (unsigned long)addr, +- (unsigned long)addr + bytes); +- fallthrough; + case DCACHE: + dcache_wb_range((unsigned long)addr, + (unsigned long)addr + bytes); ++ if (cache != BCACHE) ++ break; ++ fallthrough; ++ case ICACHE: ++ flush_icache_mm_range(current->mm, ++ (unsigned long)addr, ++ (unsigned long)addr + bytes); + break; + default: + return -EINVAL; +-- +2.30.2 + diff --git a/queue-5.10/cw1200-revert-unnecessary-patches-that-fix-unreal-us.patch b/queue-5.10/cw1200-revert-unnecessary-patches-that-fix-unreal-us.patch new file mode 100644 index 00000000000..f13f982a922 --- /dev/null +++ b/queue-5.10/cw1200-revert-unnecessary-patches-that-fix-unreal-us.patch @@ -0,0 +1,101 @@ +From 8fb8afcd3930e0f4c8e3df8d79eb2b9df7119c2e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 15:32:38 -0700 +Subject: cw1200: Revert unnecessary patches that fix unreal use-after-free + bugs + +From: Hang Zhang + +[ Upstream commit 3f60f4685699aa6006e58e424637e8e413e0a94d ] + +A previous commit 4f68ef64cd7f ("cw1200: Fix concurrency +use-after-free bugs in cw1200_hw_scan()") tried to fix a seemingly +use-after-free bug between cw1200_bss_info_changed() and +cw1200_hw_scan(), where the former frees a sk_buff pointed +to by frame.skb, and the latter accesses the sk_buff +pointed to by frame.skb. However, this issue should be a +false alarm because: + +(1) "frame.skb" is not a shared variable between the above +two functions, because "frame" is a local function variable, +each of the two functions has its own local "frame" - they +just happen to have the same variable name. + +(2) the sk_buff(s) pointed to by these two "frame.skb" are +also two different object instances, they are individually +allocated by different dev_alloc_skb() within the two above +functions. To free one object instance will not invalidate +the access of another different one. + +Based on these facts, the previous commit should be unnecessary. +Moreover, it also introduced a missing unlock which was +addressed in a subsequent commit 51c8d24101c7 ("cw1200: fix missing +unlock on error in cw1200_hw_scan()"). Now that the +original use-after-free is unreal, these two commits should +be reverted. This patch performs the reversion. + +Fixes: 4f68ef64cd7f ("cw1200: Fix concurrency use-after-free bugs in cw1200_hw_scan()") +Fixes: 51c8d24101c7 ("cw1200: fix missing unlock on error in cw1200_hw_scan()") +Signed-off-by: Hang Zhang +Acked-by: Jia-Ju Bai +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210521223238.25020-1-zh.nvgt@gmail.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/st/cw1200/scan.c | 17 +++++++---------- + 1 file changed, 7 insertions(+), 10 deletions(-) + +diff --git a/drivers/net/wireless/st/cw1200/scan.c b/drivers/net/wireless/st/cw1200/scan.c +index 988581cc134b..1f856fbbc0ea 100644 +--- a/drivers/net/wireless/st/cw1200/scan.c ++++ b/drivers/net/wireless/st/cw1200/scan.c +@@ -75,30 +75,27 @@ int cw1200_hw_scan(struct ieee80211_hw *hw, + if (req->n_ssids > WSM_SCAN_MAX_NUM_OF_SSIDS) + return -EINVAL; + +- /* will be unlocked in cw1200_scan_work() */ +- down(&priv->scan.lock); +- mutex_lock(&priv->conf_mutex); +- + frame.skb = ieee80211_probereq_get(hw, priv->vif->addr, NULL, 0, + req->ie_len); +- if (!frame.skb) { +- mutex_unlock(&priv->conf_mutex); +- up(&priv->scan.lock); ++ if (!frame.skb) + return -ENOMEM; +- } + + if (req->ie_len) + skb_put_data(frame.skb, req->ie, req->ie_len); + ++ /* will be unlocked in cw1200_scan_work() */ ++ down(&priv->scan.lock); ++ mutex_lock(&priv->conf_mutex); ++ + ret = wsm_set_template_frame(priv, &frame); + if (!ret) { + /* Host want to be the probe responder. */ + ret = wsm_set_probe_responder(priv, true); + } + if (ret) { +- dev_kfree_skb(frame.skb); + mutex_unlock(&priv->conf_mutex); + up(&priv->scan.lock); ++ dev_kfree_skb(frame.skb); + return ret; + } + +@@ -120,8 +117,8 @@ int cw1200_hw_scan(struct ieee80211_hw *hw, + ++priv->scan.n_ssids; + } + +- dev_kfree_skb(frame.skb); + mutex_unlock(&priv->conf_mutex); ++ dev_kfree_skb(frame.skb); + queue_work(priv->workqueue, &priv->scan.work); + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/dax-fix-enomem-handling-in-grab_mapping_entry.patch b/queue-5.10/dax-fix-enomem-handling-in-grab_mapping_entry.patch new file mode 100644 index 00000000000..333d3041857 --- /dev/null +++ b/queue-5.10/dax-fix-enomem-handling-in-grab_mapping_entry.patch @@ -0,0 +1,63 @@ +From 6850eb082b359e438bdf9e978a611e0f389dd540 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:35:04 -0700 +Subject: dax: fix ENOMEM handling in grab_mapping_entry() + +From: Jan Kara + +[ Upstream commit 1a14e3779dd58c16b30e56558146e5cc850ba8b0 ] + +grab_mapping_entry() has a bug in handling of ENOMEM condition. Suppose +we have a PMD entry at index i which we are downgrading to a PTE entry. +grab_mapping_entry() will set pmd_downgrade to true, lock the entry, clear +the entry in xarray, and decrement mapping->nrpages. The it will call: + + entry = dax_make_entry(pfn_to_pfn_t(0), flags); + dax_lock_entry(xas, entry); + +which inserts new PTE entry into xarray. However this may fail allocating +the new node. We handle this by: + + if (xas_nomem(xas, mapping_gfp_mask(mapping) & ~__GFP_HIGHMEM)) + goto retry; + +however pmd_downgrade stays set to true even though 'entry' returned from +get_unlocked_entry() will be NULL now. And we will go again through the +downgrade branch. This is mostly harmless except that mapping->nrpages is +decremented again and we temporarily have an invalid entry stored in +xarray. Fix the problem by setting pmd_downgrade to false each time we +lookup the entry we work with so that it matches the entry we found. + +Link: https://lkml.kernel.org/r/20210622160015.18004-1-jack@suse.cz +Fixes: b15cd800682f ("dax: Convert page fault handlers to XArray") +Signed-off-by: Jan Kara +Reviewed-by: Dan Williams +Cc: Matthew Wilcox +Cc: "Aneesh Kumar K.V" +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + fs/dax.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/fs/dax.c b/fs/dax.c +index df5485b4bddf..d5d7b9393bca 100644 +--- a/fs/dax.c ++++ b/fs/dax.c +@@ -488,10 +488,11 @@ static void *grab_mapping_entry(struct xa_state *xas, + struct address_space *mapping, unsigned int order) + { + unsigned long index = xas->xa_index; +- bool pmd_downgrade = false; /* splitting PMD entry into PTE entries? */ ++ bool pmd_downgrade; /* splitting PMD entry into PTE entries? */ + void *entry; + + retry: ++ pmd_downgrade = false; + xas_lock_irq(xas); + entry = get_unlocked_entry(xas, order); + +-- +2.30.2 + diff --git a/queue-5.10/drivers-hv-fix-missing-error-code-in-vmbus_connect.patch b/queue-5.10/drivers-hv-fix-missing-error-code-in-vmbus_connect.patch new file mode 100644 index 00000000000..73401dd69bd --- /dev/null +++ b/queue-5.10/drivers-hv-fix-missing-error-code-in-vmbus_connect.patch @@ -0,0 +1,43 @@ +From 10a02ce4fe4bf3ba5839df9c037dc7159b3fb848 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 18:58:41 +0800 +Subject: drivers: hv: Fix missing error code in vmbus_connect() + +From: Jiapeng Chong + +[ Upstream commit 9de6655cc5a6a1febc514465c87c24a0e96d8dba ] + +Eliminate the follow smatch warning: + +drivers/hv/connection.c:236 vmbus_connect() warn: missing error code +'ret'. + +Reported-by: Abaci Robot +Signed-off-by: Jiapeng Chong +Reviewed-by: Michael Kelley +Link: https://lore.kernel.org/r/1621940321-72353-1-git-send-email-jiapeng.chong@linux.alibaba.com +Signed-off-by: Wei Liu +Signed-off-by: Sasha Levin +--- + drivers/hv/connection.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c +index 11170d9a2e1a..bfd7f00a59ec 100644 +--- a/drivers/hv/connection.c ++++ b/drivers/hv/connection.c +@@ -229,8 +229,10 @@ int vmbus_connect(void) + */ + + for (i = 0; ; i++) { +- if (i == ARRAY_SIZE(vmbus_versions)) ++ if (i == ARRAY_SIZE(vmbus_versions)) { ++ ret = -EDOM; + goto cleanup; ++ } + + version = vmbus_versions[i]; + if (version > max_version) +-- +2.30.2 + diff --git a/queue-5.10/drivers-perf-fix-the-missed-ida_simple_remove-in-ddr.patch b/queue-5.10/drivers-perf-fix-the-missed-ida_simple_remove-in-ddr.patch new file mode 100644 index 00000000000..c65454ec7c7 --- /dev/null +++ b/queue-5.10/drivers-perf-fix-the-missed-ida_simple_remove-in-ddr.patch @@ -0,0 +1,41 @@ +From 6890fb4256e46be8176bc72ab4cdd50d741c12e4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 20:26:14 +0800 +Subject: drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() + +From: Jing Xiangfeng + +[ Upstream commit d96b1b8c9f79b6bb234a31c80972a6f422079376 ] + +ddr_perf_probe() misses to call ida_simple_remove() in an error path. +Jump to cpuhp_state_err to fix it. + +Signed-off-by: Jing Xiangfeng +Reviewed-by: Dong Aisheng +Link: https://lore.kernel.org/r/20210617122614.166823-1-jingxiangfeng@huawei.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c +index 397540a4b799..7f7bc0993670 100644 +--- a/drivers/perf/fsl_imx8_ddr_perf.c ++++ b/drivers/perf/fsl_imx8_ddr_perf.c +@@ -623,8 +623,10 @@ static int ddr_perf_probe(struct platform_device *pdev) + + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, DDR_PERF_DEV_NAME "%d", + num); +- if (!name) +- return -ENOMEM; ++ if (!name) { ++ ret = -ENOMEM; ++ goto cpuhp_state_err; ++ } + + pmu->devtype_data = of_device_get_match_data(&pdev->dev); + +-- +2.30.2 + diff --git a/queue-5.10/drm-amd-dc-fix-a-missing-check-bug-in-dm_dp_mst_dete.patch b/queue-5.10/drm-amd-dc-fix-a-missing-check-bug-in-dm_dp_mst_dete.patch new file mode 100644 index 00000000000..69db11650f3 --- /dev/null +++ b/queue-5.10/drm-amd-dc-fix-a-missing-check-bug-in-dm_dp_mst_dete.patch @@ -0,0 +1,38 @@ +From f45a89ffd599872617f080e0b5f7853310607912 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 8 Apr 2021 17:57:20 -0700 +Subject: drm/amd/dc: Fix a missing check bug in dm_dp_mst_detect() + +From: Yingjie Wang + +[ Upstream commit 655c0ed19772d92c9665ed08bdc5202acc096dda ] + +In dm_dp_mst_detect(), We should check whether or not @connector +has been unregistered from userspace. If the connector is unregistered, +we should return disconnected status. + +Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") +Signed-off-by: Yingjie Wang +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +index 1e448f1b39a1..955a055bd980 100644 +--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c ++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +@@ -268,6 +268,9 @@ dm_dp_mst_detect(struct drm_connector *connector, + struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector); + struct amdgpu_dm_connector *master = aconnector->mst_port; + ++ if (drm_connector_is_unregistered(connector)) ++ return connector_status_disconnected; ++ + return drm_dp_mst_detect_port(connector, ctx, &master->mst_mgr, + aconnector->port); + } +-- +2.30.2 + diff --git a/queue-5.10/drm-ast-fix-missing-conversions-to-managed-api.patch b/queue-5.10/drm-ast-fix-missing-conversions-to-managed-api.patch new file mode 100644 index 00000000000..e2e45564bef --- /dev/null +++ b/queue-5.10/drm-ast-fix-missing-conversions-to-managed-api.patch @@ -0,0 +1,49 @@ +From 90338be99a926cef260c88aab2a2bcfb3537dbdb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 21 Apr 2021 19:04:58 +0200 +Subject: drm/ast: Fix missing conversions to managed API + +From: Takashi Iwai + +[ Upstream commit 9ea172a9a3f4a7c5e876469509fc18ddefc7d49d ] + +The commit 7cbb93d89838 ("drm/ast: Use managed pci functions") +converted a few PCI accessors to the managed API and dropped the +manual pci_iounmap() calls, but it seems to have forgotten converting +pci_iomap() to the managed one. It resulted in the leftover resources +after the driver unbind. Let's fix them. + +Fixes: 7cbb93d89838 ("drm/ast: Use managed pci functions") +Signed-off-by: Takashi Iwai +Signed-off-by: Thomas Zimmermann +Link: https://patchwork.freedesktop.org/patch/msgid/20210421170458.21178-1-tiwai@suse.de +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/ast/ast_main.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c +index 77066bca8793..ee82b2ddf932 100644 +--- a/drivers/gpu/drm/ast/ast_main.c ++++ b/drivers/gpu/drm/ast/ast_main.c +@@ -409,7 +409,7 @@ struct ast_private *ast_device_create(struct drm_driver *drv, + dev->pdev = pdev; + pci_set_drvdata(pdev, dev); + +- ast->regs = pci_iomap(dev->pdev, 1, 0); ++ ast->regs = pcim_iomap(pdev, 1, 0); + if (!ast->regs) + return ERR_PTR(-EIO); + +@@ -425,7 +425,7 @@ struct ast_private *ast_device_create(struct drm_driver *drv, + + /* "map" IO regs if the above hasn't done so already */ + if (!ast->ioregs) { +- ast->ioregs = pci_iomap(dev->pdev, 2, 0); ++ ast->ioregs = pcim_iomap(pdev, 2, 0); + if (!ast->ioregs) + return ERR_PTR(-EIO); + } +-- +2.30.2 + diff --git a/queue-5.10/drm-bridge-fix-the-stop-condition-of-drm_bridge_chai.patch b/queue-5.10/drm-bridge-fix-the-stop-condition-of-drm_bridge_chai.patch new file mode 100644 index 00000000000..60292f56583 --- /dev/null +++ b/queue-5.10/drm-bridge-fix-the-stop-condition-of-drm_bridge_chai.patch @@ -0,0 +1,40 @@ +From 27e6c2ea013a41476a52e7450266cfd98458247c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 16 Apr 2021 15:39:24 -0700 +Subject: drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable() + +From: Douglas Anderson + +[ Upstream commit bab5cca7e609952b069a550e39fe4893149fb658 ] + +The drm_bridge_chain_pre_enable() is not the proper opposite of +drm_bridge_chain_post_disable(). It continues along the chain to +_before_ the starting bridge. Let's fix that. + +Fixes: 05193dc38197 ("drm/bridge: Make the bridge chain a double-linked list") +Signed-off-by: Douglas Anderson +Reviewed-by: Andrzej Hajda +Reviewed-by: Laurent Pinchart +Link: https://patchwork.freedesktop.org/patch/msgid/20210416153909.v4.1.If62a003f76a2bc4ccc6c53565becc05d2aad4430@changeid +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/drm_bridge.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c +index 64f0effb52ac..044acd07c153 100644 +--- a/drivers/gpu/drm/drm_bridge.c ++++ b/drivers/gpu/drm/drm_bridge.c +@@ -522,6 +522,9 @@ void drm_bridge_chain_pre_enable(struct drm_bridge *bridge) + list_for_each_entry_reverse(iter, &encoder->bridge_chain, chain_node) { + if (iter->funcs->pre_enable) + iter->funcs->pre_enable(iter); ++ ++ if (iter == bridge) ++ break; + } + } + EXPORT_SYMBOL(drm_bridge_chain_pre_enable); +-- +2.30.2 + diff --git a/queue-5.10/drm-bridge-sii8620-fix-dependency-on-extcon.patch b/queue-5.10/drm-bridge-sii8620-fix-dependency-on-extcon.patch new file mode 100644 index 00000000000..fabfdc2aa16 --- /dev/null +++ b/queue-5.10/drm-bridge-sii8620-fix-dependency-on-extcon.patch @@ -0,0 +1,43 @@ +From 7be7690ba8d5bf3dfbea98ba1c8dfc651e21f3d2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 19 Apr 2021 11:01:24 +0200 +Subject: drm/bridge/sii8620: fix dependency on extcon + +From: Robert Foss + +[ Upstream commit 08319adbdde15ef7cee1970336f63461254baa2a ] + +The DRM_SIL_SII8620 kconfig has a weak `imply` dependency +on EXTCON, which causes issues when sii8620 is built +as a builtin and EXTCON is built as a module. + +The symptoms are 'undefined reference' errors caused +by the symbols in EXTCON not being available +to the sii8620 driver. + +Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL") +Reported-by: kernel test robot +Signed-off-by: Robert Foss +Reviewed-by: Randy Dunlap +Link: https://patchwork.freedesktop.org/patch/msgid/20210419090124.153560-1-robert.foss@linaro.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/Kconfig | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig +index e145cbb35bac..4e82647a621e 100644 +--- a/drivers/gpu/drm/bridge/Kconfig ++++ b/drivers/gpu/drm/bridge/Kconfig +@@ -130,7 +130,7 @@ config DRM_SIL_SII8620 + tristate "Silicon Image SII8620 HDMI/MHL bridge" + depends on OF + select DRM_KMS_HELPER +- imply EXTCON ++ select EXTCON + depends on RC_CORE || !RC_CORE + help + Silicon Image SII8620 HDMI/MHL bridge chip driver. +-- +2.30.2 + diff --git a/queue-5.10/drm-msm-dpu-fix-error-return-code-in-dpu_mdss_init.patch b/queue-5.10/drm-msm-dpu-fix-error-return-code-in-dpu_mdss_init.patch new file mode 100644 index 00000000000..3ccdb5efc7a --- /dev/null +++ b/queue-5.10/drm-msm-dpu-fix-error-return-code-in-dpu_mdss_init.patch @@ -0,0 +1,70 @@ +From e28dc93102cedf85d4e9e480cb4377cd8063cd24 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 14:38:05 +0800 +Subject: drm/msm/dpu: Fix error return code in dpu_mdss_init() + +From: Zhen Lei + +[ Upstream commit e020ac961ce5d038de66dc7f6ffca98899e9a3f3 ] + +The error code returned by platform_get_irq() is stored in 'irq', it's +forgotten to be copied to 'ret' before being returned. As a result, the +value 0 of 'ret' is returned incorrectly. + +After the above fix is completed, initializing the local variable 'ret' +to 0 is no longer needed, remove it. + +In addition, when dpu_mdss_init() is successfully returned, the value of +'ret' is always 0. Therefore, replace "return ret" with "return 0" to make +the code clearer. + +Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Link: https://lore.kernel.org/r/20210510063805.3262-2-thunder.leizhen@huawei.com +Reviewed-by: Stephen Boyd +Reviewed-by: Dmitry Baryshkov +Signed-off-by: Dmitry Baryshkov +Signed-off-by: Rob Clark +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +index 3416e9617ee9..96f3908e4c5b 100644 +--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c ++++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +@@ -222,7 +222,7 @@ int dpu_mdss_init(struct drm_device *dev) + struct msm_drm_private *priv = dev->dev_private; + struct dpu_mdss *dpu_mdss; + struct dss_module_power *mp; +- int ret = 0; ++ int ret; + int irq; + + dpu_mdss = devm_kzalloc(dev->dev, sizeof(*dpu_mdss), GFP_KERNEL); +@@ -250,8 +250,10 @@ int dpu_mdss_init(struct drm_device *dev) + goto irq_domain_error; + + irq = platform_get_irq(pdev, 0); +- if (irq < 0) ++ if (irq < 0) { ++ ret = irq; + goto irq_error; ++ } + + irq_set_chained_handler_and_data(irq, dpu_mdss_irq, + dpu_mdss); +@@ -260,7 +262,7 @@ int dpu_mdss_init(struct drm_device *dev) + + pm_runtime_enable(dev->dev); + +- return ret; ++ return 0; + + irq_error: + _dpu_mdss_irq_domain_fini(dpu_mdss); +-- +2.30.2 + diff --git a/queue-5.10/drm-msm-fix-error-return-code-in-msm_drm_init.patch b/queue-5.10/drm-msm-fix-error-return-code-in-msm_drm_init.patch new file mode 100644 index 00000000000..3c07ed6e60d --- /dev/null +++ b/queue-5.10/drm-msm-fix-error-return-code-in-msm_drm_init.patch @@ -0,0 +1,39 @@ +From 3fc716d23cb29066d3a68b33edde6419ac829f72 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 10:28:36 +0800 +Subject: drm/msm: Fix error return code in msm_drm_init() + +From: Zhen Lei + +[ Upstream commit a1c9b1e3bdd6d8dc43c18699772fb6cf4497d45a ] + +Fix to return a negative error code from the error handling case instead +of 0, as done elsewhere in this function. + +Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Link: https://lore.kernel.org/r/20210508022836.1777-1-thunder.leizhen@huawei.com +Reviewed-by: Dmitry Baryshkov +Signed-off-by: Dmitry Baryshkov +Signed-off-by: Rob Clark +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/msm/msm_drv.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c +index 0aacc43faefa..edee4c2a76ce 100644 +--- a/drivers/gpu/drm/msm/msm_drv.c ++++ b/drivers/gpu/drm/msm/msm_drv.c +@@ -505,6 +505,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) + priv->event_thread[i].worker = kthread_create_worker(0, + "crtc_event:%d", priv->event_thread[i].crtc_id); + if (IS_ERR(priv->event_thread[i].worker)) { ++ ret = PTR_ERR(priv->event_thread[i].worker); + DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); + goto err_msm_uninit; + } +-- +2.30.2 + diff --git a/queue-5.10/drm-pl111-actually-fix-config_vexpress_config-depend.patch b/queue-5.10/drm-pl111-actually-fix-config_vexpress_config-depend.patch new file mode 100644 index 00000000000..01094c79063 --- /dev/null +++ b/queue-5.10/drm-pl111-actually-fix-config_vexpress_config-depend.patch @@ -0,0 +1,40 @@ +From 462492e9b32b05a071692ffbef568aac88b1b429 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 18:40:55 -0700 +Subject: drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends + +From: Kees Cook + +[ Upstream commit 4e566003571244f508408f59ce78f6ac2ccdba8e ] + +VEXPRESS_CONFIG needs to either be missing, built-in, or modular when +pl111 is modular. Update the Kconfig to reflect the need. + +Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG") +Signed-off-by: Kees Cook +Reviewed-by: Linus Walleij +Acked-by: Rob Herring +Signed-off-by: Linus Walleij +Link: https://patchwork.freedesktop.org/patch/msgid/20210604014055.4060521-1-keescook@chromium.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/pl111/Kconfig | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig +index c5210a5bef1b..3aae387a96af 100644 +--- a/drivers/gpu/drm/pl111/Kconfig ++++ b/drivers/gpu/drm/pl111/Kconfig +@@ -2,7 +2,8 @@ + config DRM_PL111 + tristate "DRM Support for PL111 CLCD Controller" + depends on DRM +- depends on VEXPRESS_CONFIG ++ depends on ARM || ARM64 || COMPILE_TEST ++ depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n + depends on COMMON_CLK + select DRM_KMS_HELPER + select DRM_KMS_CMA_HELPER +-- +2.30.2 + diff --git a/queue-5.10/drm-pl111-depend-on-config_vexpress_config.patch b/queue-5.10/drm-pl111-depend-on-config_vexpress_config.patch new file mode 100644 index 00000000000..049bf038efd --- /dev/null +++ b/queue-5.10/drm-pl111-depend-on-config_vexpress_config.patch @@ -0,0 +1,39 @@ +From dfebdff0da8a92cd0e7e7dff52887fbb0bc46540 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 2 Jun 2021 14:52:52 -0700 +Subject: drm/pl111: depend on CONFIG_VEXPRESS_CONFIG + +From: Kees Cook + +[ Upstream commit 4dc7c97d04dcaa9f19482f70dcfdbeb52cc7193f ] + +Avoid randconfig build failures by requiring VEXPRESS_CONFIG: + +aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_vexpress_clcd_init': +pl111_versatile.c:(.text+0x220): undefined reference to `devm_regmap_init_vexpress_config' + +Fixes: 826fc86b5903 ("drm: pl111: Move VExpress setup into versatile init") +Signed-off-by: Kees Cook +Signed-off-by: Daniel Vetter +Link: https://patchwork.freedesktop.org/patch/msgid/20210602215252.695994-4-keescook@chromium.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/pl111/Kconfig | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig +index 80f6748055e3..c5210a5bef1b 100644 +--- a/drivers/gpu/drm/pl111/Kconfig ++++ b/drivers/gpu/drm/pl111/Kconfig +@@ -2,7 +2,7 @@ + config DRM_PL111 + tristate "DRM Support for PL111 CLCD Controller" + depends on DRM +- depends on ARM || ARM64 || COMPILE_TEST ++ depends on VEXPRESS_CONFIG + depends on COMMON_CLK + select DRM_KMS_HELPER + select DRM_KMS_CMA_HELPER +-- +2.30.2 + diff --git a/queue-5.10/drm-qxl-ensure-surf.data-is-ininitialized.patch b/queue-5.10/drm-qxl-ensure-surf.data-is-ininitialized.patch new file mode 100644 index 00000000000..945a22ac5c5 --- /dev/null +++ b/queue-5.10/drm-qxl-ensure-surf.data-is-ininitialized.patch @@ -0,0 +1,40 @@ +From 6894a41b7add1cfa9a0bfb8ddab98cd8fd81f4f0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 17:13:13 +0100 +Subject: drm: qxl: ensure surf.data is ininitialized + +From: Colin Ian King + +[ Upstream commit fbbf23ddb2a1cc0c12c9f78237d1561c24006f50 ] + +The object surf is not fully initialized and the uninitialized +field surf.data is being copied by the call to qxl_bo_create +via the call to qxl_gem_object_create. Set surf.data to zero +to ensure garbage data from the stack is not being copied. + +Addresses-Coverity: ("Uninitialized scalar variable") +Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)") +Signed-off-by: Colin Ian King +Link: http://patchwork.freedesktop.org/patch/msgid/20210608161313.161922-1-colin.king@canonical.com +Signed-off-by: Gerd Hoffmann +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/qxl/qxl_dumb.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/gpu/drm/qxl/qxl_dumb.c b/drivers/gpu/drm/qxl/qxl_dumb.c +index c04cd5a2553c..e377bdbff90d 100644 +--- a/drivers/gpu/drm/qxl/qxl_dumb.c ++++ b/drivers/gpu/drm/qxl/qxl_dumb.c +@@ -58,6 +58,8 @@ int qxl_mode_dumb_create(struct drm_file *file_priv, + surf.height = args->height; + surf.stride = pitch; + surf.format = format; ++ surf.data = 0; ++ + r = qxl_gem_object_create_with_handle(qdev, file_priv, + QXL_GEM_DOMAIN_SURFACE, + args->size, &surf, &qobj, +-- +2.30.2 + diff --git a/queue-5.10/drm-rockchip-cdn-dp-core-add-missing-clk_disable_unp.patch b/queue-5.10/drm-rockchip-cdn-dp-core-add-missing-clk_disable_unp.patch new file mode 100644 index 00000000000..618cdbed434 --- /dev/null +++ b/queue-5.10/drm-rockchip-cdn-dp-core-add-missing-clk_disable_unp.patch @@ -0,0 +1,38 @@ +From 2a1489df4155295be8e3c81c951f8d15474dbd31 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 19 May 2021 21:49:28 +0800 +Subject: drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on + error in cdn_dp_grf_write() + +From: Yang Yingliang + +[ Upstream commit ae41d925c75b53798f289c69ee8d9f7d36432f6d ] + +After calling clk_prepare_enable(), clk_disable_unprepare() need +be called when calling regmap_write() failed. + +Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/20210519134928.2696617-1-yangyingliang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c +index a4a45daf93f2..6802d9b65f82 100644 +--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c ++++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c +@@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp, + ret = regmap_write(dp->grf, reg, val); + if (ret) { + DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret); ++ clk_disable_unprepare(dp->grf_clk); + return ret; + } + +-- +2.30.2 + diff --git a/queue-5.10/drm-rockchip-cdn-dp-fix-sign-extension-on-an-int-mul.patch b/queue-5.10/drm-rockchip-cdn-dp-fix-sign-extension-on-an-int-mul.patch new file mode 100644 index 00000000000..edebc6c61d6 --- /dev/null +++ b/queue-5.10/drm-rockchip-cdn-dp-fix-sign-extension-on-an-int-mul.patch @@ -0,0 +1,42 @@ +From ad289b649da0645bc2ee3340b33bae86b5fb87e6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Sep 2020 17:20:49 +0100 +Subject: drm/rockchip: cdn-dp: fix sign extension on an int multiply for a u64 + result + +From: Colin Ian King + +[ Upstream commit ce0cb93a5adb283f577cd4661f511047b5e39028 ] + +The variable bit_per_pix is a u8 and is promoted in the multiplication +to an int type and then sign extended to a u64. If the result of the +int multiplication is greater than 0x7fffffff then the upper 32 bits will +be set to 1 as a result of the sign extension. Avoid this by casting +tu_size_reg to u64 to avoid sign extension and also a potential overflow. + +Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") +Signed-off-by: Colin Ian King +Reviewed-by: Guenter Roeck +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/20200915162049.36434-1-colin.king@canonical.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c +index 9d2163ef4d6e..33fb4d05c506 100644 +--- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c ++++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c +@@ -658,7 +658,7 @@ int cdn_dp_config_video(struct cdn_dp_device *dp) + */ + do { + tu_size_reg += 2; +- symbol = tu_size_reg * mode->clock * bit_per_pix; ++ symbol = (u64)tu_size_reg * mode->clock * bit_per_pix; + do_div(symbol, dp->max_lanes * link_rate * 8); + rem = do_div(symbol, 1000); + if (tu_size_reg > 64) { +-- +2.30.2 + diff --git a/queue-5.10/drm-rockchip-dsi-move-all-lane-config-except-lcdc-mu.patch b/queue-5.10/drm-rockchip-dsi-move-all-lane-config-except-lcdc-mu.patch new file mode 100644 index 00000000000..e9bdf879484 --- /dev/null +++ b/queue-5.10/drm-rockchip-dsi-move-all-lane-config-except-lcdc-mu.patch @@ -0,0 +1,120 @@ +From ee2771bbb976a4d50b929dfe6cb26a835aed591b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 18 Apr 2021 19:04:10 -0700 +Subject: drm/rockchip: dsi: move all lane config except LCDC mux to bind() + +From: Thomas Hebb + +[ Upstream commit 43c2de1002d2b70fb5941fa14e97a34e3dc214d4 ] + +When we first enable the DSI encoder, we currently program some per-chip +configuration that we look up in rk3399_chip_data based on the device +tree compatible we match. This data configures various parameters of the +MIPI lanes, including on RK3399 whether DSI1 is slaved to DSI0 in a +dual-mode configuration. It also selects which LCDC (i.e. VOP) to scan +out from. + +This causes a problem in RK3399 dual-mode configurations, though: panel +prepare() callbacks run before the encoder gets enabled and expect to be +able to write commands to the DSI bus, but the bus isn't fully +functional until the lane and master/slave configuration have been +programmed. As a result, dual-mode panels (and possibly others too) fail +to turn on when the rockchipdrm driver is initially loaded. + +Because the LCDC mux is the only thing we don't know until enable time +(and is the only thing that can ever change), we can actually move most +of the initialization to bind() and get it out of the way early. That's +what this change does. (Rockchip's 4.4 BSP kernel does it in mode_set(), +which also avoids the issue, but bind() seems like the more correct +place to me.) + +Tested on a Google Scarlet board (Acer Chromebook Tab 10), which has a +Kingdisplay KD097D04 dual-mode panel. Prior to this change, the panel's +backlight would turn on but no image would appear when initially loading +rockchipdrm. If I kept rockchipdrm loaded and reloaded the panel driver, +it would come on. With this change, the panel successfully turns on +during initial rockchipdrm load as expected. + +Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver") +Signed-off-by: Thomas Hebb +Tested-by: Jonathan Liu +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/55fe7f3454d8c91dc3837ba5aa741d4a0e67378f.1618797813.git.tommyhebb@gmail.com +Signed-off-by: Sasha Levin +--- + .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 36 ++++++++++++++----- + 1 file changed, 28 insertions(+), 8 deletions(-) + +diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c +index 542dcf7eddd6..75a76408cb29 100644 +--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c ++++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c +@@ -692,13 +692,8 @@ static const struct dw_mipi_dsi_phy_ops dw_mipi_dsi_rockchip_phy_ops = { + .get_timing = dw_mipi_dsi_phy_get_timing, + }; + +-static void dw_mipi_dsi_rockchip_config(struct dw_mipi_dsi_rockchip *dsi, +- int mux) ++static void dw_mipi_dsi_rockchip_config(struct dw_mipi_dsi_rockchip *dsi) + { +- if (dsi->cdata->lcdsel_grf_reg) +- regmap_write(dsi->grf_regmap, dsi->cdata->lcdsel_grf_reg, +- mux ? dsi->cdata->lcdsel_lit : dsi->cdata->lcdsel_big); +- + if (dsi->cdata->lanecfg1_grf_reg) + regmap_write(dsi->grf_regmap, dsi->cdata->lanecfg1_grf_reg, + dsi->cdata->lanecfg1); +@@ -712,6 +707,13 @@ static void dw_mipi_dsi_rockchip_config(struct dw_mipi_dsi_rockchip *dsi, + dsi->cdata->enable); + } + ++static void dw_mipi_dsi_rockchip_set_lcdsel(struct dw_mipi_dsi_rockchip *dsi, ++ int mux) ++{ ++ regmap_write(dsi->grf_regmap, dsi->cdata->lcdsel_grf_reg, ++ mux ? dsi->cdata->lcdsel_lit : dsi->cdata->lcdsel_big); ++} ++ + static int + dw_mipi_dsi_encoder_atomic_check(struct drm_encoder *encoder, + struct drm_crtc_state *crtc_state, +@@ -767,9 +769,9 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) + return; + } + +- dw_mipi_dsi_rockchip_config(dsi, mux); ++ dw_mipi_dsi_rockchip_set_lcdsel(dsi, mux); + if (dsi->slave) +- dw_mipi_dsi_rockchip_config(dsi->slave, mux); ++ dw_mipi_dsi_rockchip_set_lcdsel(dsi->slave, mux); + + clk_disable_unprepare(dsi->grf_clk); + } +@@ -923,6 +925,24 @@ static int dw_mipi_dsi_rockchip_bind(struct device *dev, + return ret; + } + ++ /* ++ * With the GRF clock running, write lane and dual-mode configurations ++ * that won't change immediately. If we waited until enable() to do ++ * this, things like panel preparation would not be able to send ++ * commands over DSI. ++ */ ++ ret = clk_prepare_enable(dsi->grf_clk); ++ if (ret) { ++ DRM_DEV_ERROR(dsi->dev, "Failed to enable grf_clk: %d\n", ret); ++ return ret; ++ } ++ ++ dw_mipi_dsi_rockchip_config(dsi); ++ if (dsi->slave) ++ dw_mipi_dsi_rockchip_config(dsi->slave); ++ ++ clk_disable_unprepare(dsi->grf_clk); ++ + ret = rockchip_dsi_drm_create_encoder(dsi, drm_dev); + if (ret) { + DRM_DEV_ERROR(dev, "Failed to create drm encoder\n"); +-- +2.30.2 + diff --git a/queue-5.10/drm-rockchip-lvds-fix-an-error-handling-path.patch b/queue-5.10/drm-rockchip-lvds-fix-an-error-handling-path.patch new file mode 100644 index 00000000000..f21606091cf --- /dev/null +++ b/queue-5.10/drm-rockchip-lvds-fix-an-error-handling-path.patch @@ -0,0 +1,44 @@ +From 8e16b13a9a4247414122c0792205ac248d42f3b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 17:13:16 +0200 +Subject: drm/rockchip: lvds: Fix an error handling path + +From: Christophe JAILLET + +[ Upstream commit 3dfa159f6b0c054eb63673fbf643a5f2cc862e63 ] + +'ret' is know to be 0 a this point. Checking the return value of +'phy_init()' and 'phy_set_mode()' was intended instead. + +So add the missing assignments. + +Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support") +Signed-off-by: Christophe JAILLET +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/248220d4815dc8c8088cebfab7d6df5f70518438.1619881852.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c +index 41edd0a421b2..7c20b4a24a7e 100644 +--- a/drivers/gpu/drm/rockchip/rockchip_lvds.c ++++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c +@@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev, + if (IS_ERR(lvds->dphy)) + return PTR_ERR(lvds->dphy); + +- phy_init(lvds->dphy); ++ ret = phy_init(lvds->dphy); + if (ret) + return ret; + +- phy_set_mode(lvds->dphy, PHY_MODE_LVDS); ++ ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS); + if (ret) + return ret; + +-- +2.30.2 + diff --git a/queue-5.10/drm-rockchip-set-alpha_en-to-0-if-it-is-not-used.patch b/queue-5.10/drm-rockchip-set-alpha_en-to-0-if-it-is-not-used.patch new file mode 100644 index 00000000000..ce1bc6c770a --- /dev/null +++ b/queue-5.10/drm-rockchip-set-alpha_en-to-0-if-it-is-not-used.patch @@ -0,0 +1,36 @@ +From 78a32dbd14c6fdf828c62c66fd2c232dbbee9923 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 15:05:54 +0200 +Subject: drm: rockchip: set alpha_en to 0 if it is not used + +From: Alex Bee + +[ Upstream commit 046e0db975695540c9d9898cdbf0b60533d28afb ] + +alpha_en should be set to 0 if it is not used, i.e. to disable alpha +blending if it was enabled before and should be disabled now. + +Fixes: 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") +Signed-off-by: Alex Bee +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/20210528130554.72191-6-knaerzche@gmail.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +index c80f7d9fd13f..0f23144491e4 100644 +--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c ++++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +@@ -1013,6 +1013,7 @@ static void vop_plane_atomic_update(struct drm_plane *plane, + VOP_WIN_SET(vop, win, alpha_en, 1); + } else { + VOP_WIN_SET(vop, win, src_alpha_ctl, SRC_ALPHA_EN(0)); ++ VOP_WIN_SET(vop, win, alpha_en, 0); + } + + VOP_WIN_SET(vop, win, enable, 1); +-- +2.30.2 + diff --git a/queue-5.10/drm-vc4-hdmi-fix-error-path-of-hpd-gpios.patch b/queue-5.10/drm-vc4-hdmi-fix-error-path-of-hpd-gpios.patch new file mode 100644 index 00000000000..b26cc8472d1 --- /dev/null +++ b/queue-5.10/drm-vc4-hdmi-fix-error-path-of-hpd-gpios.patch @@ -0,0 +1,52 @@ +From 0a2a59e8f7bed2cc46241534034b10b8ba2adc1b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 24 May 2021 15:18:51 +0200 +Subject: drm/vc4: hdmi: Fix error path of hpd-gpios + +From: Maxime Ripard + +[ Upstream commit e075a7811977ff51c917a65ed1896e08231d2615 ] + +If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to +the err_unprepare_hsm label. That label will then call +pm_runtime_disable and put_device on the DDC device. + +We just retrieved the DDC device, so the latter is definitely justified. +However at that point we still haven't called pm_runtime_enable, so the +call to pm_runtime_disable is not supposed to be there. + +Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support") +Signed-off-by: Maxime Ripard +Reviewed-by: Linus Walleij +Link: https://patchwork.freedesktop.org/patch/msgid/20210524131852.263883-1-maxime@cerno.tech +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c +index 88a8cb840cd5..25a09aaf5883 100644 +--- a/drivers/gpu/drm/vc4/vc4_hdmi.c ++++ b/drivers/gpu/drm/vc4/vc4_hdmi.c +@@ -1795,7 +1795,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) + &hpd_gpio_flags); + if (vc4_hdmi->hpd_gpio < 0) { + ret = vc4_hdmi->hpd_gpio; +- goto err_unprepare_hsm; ++ goto err_put_ddc; + } + + vc4_hdmi->hpd_active_low = hpd_gpio_flags & OF_GPIO_ACTIVE_LOW; +@@ -1836,8 +1836,8 @@ err_destroy_conn: + vc4_hdmi_connector_destroy(&vc4_hdmi->connector); + err_destroy_encoder: + drm_encoder_cleanup(encoder); +-err_unprepare_hsm: + pm_runtime_disable(dev); ++err_put_ddc: + put_device(&vc4_hdmi->ddc->dev); + + return ret; +-- +2.30.2 + diff --git a/queue-5.10/drm-vmwgfx-fix-cpu-updates-of-coherent-multisample-s.patch b/queue-5.10/drm-vmwgfx-fix-cpu-updates-of-coherent-multisample-s.patch new file mode 100644 index 00000000000..c698d6214e9 --- /dev/null +++ b/queue-5.10/drm-vmwgfx-fix-cpu-updates-of-coherent-multisample-s.patch @@ -0,0 +1,109 @@ +From 6fdc61a8d45e519f59c2b5c552ecdde3161e1344 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 23:57:37 -0400 +Subject: drm/vmwgfx: Fix cpu updates of coherent multisample surfaces + +From: Thomas Hellstrom + +[ Upstream commit 88509f698c4e38e287e016e86a0445547824135c ] + +In cases where the dirty linear memory range spans multiple sample sheets +in a surface, the dirty surface region is incorrectly computed. +To do this correctly and in an optimized fashion we would have to compute +the dirty region of each sample sheet and compute the union of those +regions. + +But assuming that cpu writing to a multisample surface is rather a corner +case than a common case, just set the dirty region to the full surface. + +This fixes OpenGL piglit errors with SVGA_FORCE_COHERENT=1 +and the piglit test: + +fbo-depthstencil blit default_fb -samples=2 -auto + +Fixes: 9ca7d19ff8ba ("drm/vmwgfx: Add surface dirty-tracking callbacks") +Signed-off-by: Thomas Hellstrom +Reviewed-by: Charmaine Lee +Reviewed-by: Roland Scheidegger +Signed-off-by: Zack Rusin +Link: https://patchwork.freedesktop.org/patch/msgid/20210505035740.286923-4-zackr@vmware.com +Signed-off-by: Sasha Levin +--- + .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 8 ++++++-- + drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 13 +++++++++++++ + 2 files changed, 19 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h +index 4db25bd9fa22..127eaf0a0a58 100644 +--- a/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h ++++ b/drivers/gpu/drm/vmwgfx/device_include/svga3d_surfacedefs.h +@@ -1467,6 +1467,7 @@ struct svga3dsurface_cache { + + /** + * struct svga3dsurface_loc - Surface location ++ * @sheet: The multisample sheet. + * @sub_resource: Surface subresource. Defined as layer * num_mip_levels + + * mip_level. + * @x: X coordinate. +@@ -1474,6 +1475,7 @@ struct svga3dsurface_cache { + * @z: Z coordinate. + */ + struct svga3dsurface_loc { ++ u32 sheet; + u32 sub_resource; + u32 x, y, z; + }; +@@ -1566,8 +1568,8 @@ svga3dsurface_get_loc(const struct svga3dsurface_cache *cache, + u32 layer; + int i; + +- if (offset >= cache->sheet_bytes) +- offset %= cache->sheet_bytes; ++ loc->sheet = offset / cache->sheet_bytes; ++ offset -= loc->sheet * cache->sheet_bytes; + + layer = offset / cache->mip_chain_bytes; + offset -= layer * cache->mip_chain_bytes; +@@ -1631,6 +1633,7 @@ svga3dsurface_min_loc(const struct svga3dsurface_cache *cache, + u32 sub_resource, + struct svga3dsurface_loc *loc) + { ++ loc->sheet = 0; + loc->sub_resource = sub_resource; + loc->x = loc->y = loc->z = 0; + } +@@ -1652,6 +1655,7 @@ svga3dsurface_max_loc(const struct svga3dsurface_cache *cache, + const struct drm_vmw_size *size; + u32 mip; + ++ loc->sheet = 0; + loc->sub_resource = sub_resource + 1; + mip = sub_resource % cache->num_mip_levels; + size = &cache->mip[mip].size; +diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +index 3914bfee0533..f493b20c7a38 100644 +--- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c ++++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +@@ -1802,6 +1802,19 @@ static void vmw_surface_tex_dirty_range_add(struct vmw_resource *res, + svga3dsurface_get_loc(cache, &loc2, end - 1); + svga3dsurface_inc_loc(cache, &loc2); + ++ if (loc1.sheet != loc2.sheet) { ++ u32 sub_res; ++ ++ /* ++ * Multiple multisample sheets. To do this in an optimized ++ * fashion, compute the dirty region for each sheet and the ++ * resulting union. Since this is not a common case, just dirty ++ * the whole surface. ++ */ ++ for (sub_res = 0; sub_res < dirty->num_subres; ++sub_res) ++ vmw_subres_dirty_full(dirty, sub_res); ++ return; ++ } + if (loc1.sub_resource + 1 == loc2.sub_resource) { + /* Dirty range covers a single sub-resource */ + vmw_subres_dirty_add(dirty, &loc1, &loc2); +-- +2.30.2 + diff --git a/queue-5.10/drm-vmwgfx-mark-a-surface-gpu-dirty-after-the-svga3d.patch b/queue-5.10/drm-vmwgfx-mark-a-surface-gpu-dirty-after-the-svga3d.patch new file mode 100644 index 00000000000..1d1ec122af0 --- /dev/null +++ b/queue-5.10/drm-vmwgfx-mark-a-surface-gpu-dirty-after-the-svga3d.patch @@ -0,0 +1,67 @@ +From 9b3810406263eff42548e3c5aaac195ab332c7a5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 23:57:36 -0400 +Subject: drm/vmwgfx: Mark a surface gpu-dirty after the SVGA3dCmdDXGenMips + command + +From: Thomas Hellstrom + +[ Upstream commit 75156a887b6cea6e09d83ec19f4ebfd7c86265f0 ] + +The SVGA3dCmdDXGenMips command uses a shader-resource view to access +the underlying surface. Normally accesses using that view-type are not +dirtying the underlying surface, but that particular command is an +exception. +Mark the surface gpu-dirty after a SVGA3dCmdDXGenMips command has been +submitted. + +This fixes the piglit getteximage-formats test run with +SVGA_FORCE_COHERENT=1 + +Fixes: a9f58c456e9d ("drm/vmwgfx: Be more restrictive when dirtying resources") +Signed-off-by: Thomas Hellstrom +Reviewed-by: Charmaine Lee +Reviewed-by: Roland Scheidegger +Signed-off-by: Zack Rusin +Link: https://patchwork.freedesktop.org/patch/msgid/20210505035740.286923-3-zackr@vmware.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 20 ++++++++++++++++---- + 1 file changed, 16 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +index e67e2e8f6e6f..83e1b54eb864 100644 +--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c ++++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +@@ -2759,12 +2759,24 @@ static int vmw_cmd_dx_genmips(struct vmw_private *dev_priv, + { + VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdDXGenMips) = + container_of(header, typeof(*cmd), header); +- struct vmw_resource *ret; ++ struct vmw_resource *view; ++ struct vmw_res_cache_entry *rcache; + +- ret = vmw_view_id_val_add(sw_context, vmw_view_sr, +- cmd->body.shaderResourceViewId); ++ view = vmw_view_id_val_add(sw_context, vmw_view_sr, ++ cmd->body.shaderResourceViewId); ++ if (IS_ERR(view)) ++ return PTR_ERR(view); + +- return PTR_ERR_OR_ZERO(ret); ++ /* ++ * Normally the shader-resource view is not gpu-dirtying, but for ++ * this particular command it is... ++ * So mark the last looked-up surface, which is the surface ++ * the view points to, gpu-dirty. ++ */ ++ rcache = &sw_context->res_cache[vmw_res_surface]; ++ vmw_validation_res_set_dirty(sw_context->ctx, rcache->private, ++ VMW_RES_DIRTY_SET); ++ return 0; + } + + /** +-- +2.30.2 + diff --git a/queue-5.10/e1000e-check-the-pcim-state.patch b/queue-5.10/e1000e-check-the-pcim-state.patch new file mode 100644 index 00000000000..e12213a859c --- /dev/null +++ b/queue-5.10/e1000e-check-the-pcim-state.patch @@ -0,0 +1,64 @@ +From e33e36d0a1ef30afd24a47df84fe98658f780af5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 12:02:48 -0700 +Subject: e1000e: Check the PCIm state + +From: Sasha Neftin + +[ Upstream commit 2e7256f12cdb16eaa2515b6231d665044a07c51a ] + +Complete to commit def4ec6dce393e ("e1000e: PCIm function state support") +Check the PCIm state only on CSME systems. There is no point to do this +check on non CSME systems. +This patch fixes a generation a false-positive warning: +"Error in exiting dmoff" + +Fixes: def4ec6dce39 ("e1000e: PCIm function state support") +Signed-off-by: Sasha Neftin +Tested-by: Dvora Fuxbrumer +Signed-off-by: Tony Nguyen +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/e1000e/netdev.c | 24 ++++++++++++---------- + 1 file changed, 13 insertions(+), 11 deletions(-) + +diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c +index a0948002ddf8..b3ad95ac3d85 100644 +--- a/drivers/net/ethernet/intel/e1000e/netdev.c ++++ b/drivers/net/ethernet/intel/e1000e/netdev.c +@@ -5222,18 +5222,20 @@ static void e1000_watchdog_task(struct work_struct *work) + pm_runtime_resume(netdev->dev.parent); + + /* Checking if MAC is in DMoff state*/ +- pcim_state = er32(STATUS); +- while (pcim_state & E1000_STATUS_PCIM_STATE) { +- if (tries++ == dmoff_exit_timeout) { +- e_dbg("Error in exiting dmoff\n"); +- break; +- } +- usleep_range(10000, 20000); ++ if (er32(FWSM) & E1000_ICH_FWSM_FW_VALID) { + pcim_state = er32(STATUS); +- +- /* Checking if MAC exited DMoff state */ +- if (!(pcim_state & E1000_STATUS_PCIM_STATE)) +- e1000_phy_hw_reset(&adapter->hw); ++ while (pcim_state & E1000_STATUS_PCIM_STATE) { ++ if (tries++ == dmoff_exit_timeout) { ++ e_dbg("Error in exiting dmoff\n"); ++ break; ++ } ++ usleep_range(10000, 20000); ++ pcim_state = er32(STATUS); ++ ++ /* Checking if MAC exited DMoff state */ ++ if (!(pcim_state & E1000_STATUS_PCIM_STATE)) ++ e1000_phy_hw_reset(&adapter->hw); ++ } + } + + /* update snapshot of PHY registers on LSC */ +-- +2.30.2 + diff --git a/queue-5.10/edac-intel-do-not-load-edac-driver-when-running-as-a.patch b/queue-5.10/edac-intel-do-not-load-edac-driver-when-running-as-a.patch new file mode 100644 index 00000000000..ceab20b4077 --- /dev/null +++ b/queue-5.10/edac-intel-do-not-load-edac-driver-when-running-as-a.patch @@ -0,0 +1,87 @@ +From fc0604bad6111feee55f887b711e9076837d65d0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Jun 2021 10:44:19 -0700 +Subject: EDAC/Intel: Do not load EDAC driver when running as a guest + +From: Luck, Tony + +[ Upstream commit f0a029fff4a50eb01648810a77ba1873e829fdd4 ] + +There's little to no point in loading an EDAC driver running in a guest: +1) The CPU model reported by CPUID may not represent actual h/w +2) The hypervisor likely does not pass in access to memory controller devices +3) Hypervisors generally do not pass corrected error details to guests + +Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR +and simply return -ENODEV in the init routine. + +Acked-by: Borislav Petkov +Signed-off-by: Tony Luck +Link: https://lore.kernel.org/r/20210615174419.GA1087688@agluck-desk2.amr.corp.intel.com +Signed-off-by: Sasha Levin +--- + drivers/edac/i10nm_base.c | 3 +++ + drivers/edac/pnd2_edac.c | 3 +++ + drivers/edac/sb_edac.c | 3 +++ + drivers/edac/skx_base.c | 3 +++ + 4 files changed, 12 insertions(+) + +diff --git a/drivers/edac/i10nm_base.c b/drivers/edac/i10nm_base.c +index 7b52691c45d2..4912a7b88380 100644 +--- a/drivers/edac/i10nm_base.c ++++ b/drivers/edac/i10nm_base.c +@@ -263,6 +263,9 @@ static int __init i10nm_init(void) + if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) + return -EBUSY; + ++ if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) ++ return -ENODEV; ++ + id = x86_match_cpu(i10nm_cpuids); + if (!id) + return -ENODEV; +diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c +index 928f63a374c7..c94ca1f790c4 100644 +--- a/drivers/edac/pnd2_edac.c ++++ b/drivers/edac/pnd2_edac.c +@@ -1554,6 +1554,9 @@ static int __init pnd2_init(void) + if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) + return -EBUSY; + ++ if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) ++ return -ENODEV; ++ + id = x86_match_cpu(pnd2_cpuids); + if (!id) + return -ENODEV; +diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c +index 93daa4297f2e..4c626fcd4dcb 100644 +--- a/drivers/edac/sb_edac.c ++++ b/drivers/edac/sb_edac.c +@@ -3510,6 +3510,9 @@ static int __init sbridge_init(void) + if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) + return -EBUSY; + ++ if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) ++ return -ENODEV; ++ + id = x86_match_cpu(sbridge_cpuids); + if (!id) + return -ENODEV; +diff --git a/drivers/edac/skx_base.c b/drivers/edac/skx_base.c +index 2c7db95df326..f887e3166651 100644 +--- a/drivers/edac/skx_base.c ++++ b/drivers/edac/skx_base.c +@@ -656,6 +656,9 @@ static int __init skx_init(void) + if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) + return -EBUSY; + ++ if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) ++ return -ENODEV; ++ + id = x86_match_cpu(skx_cpuids); + if (!id) + return -ENODEV; +-- +2.30.2 + diff --git a/queue-5.10/edac-ti-add-missing-module_device_table.patch b/queue-5.10/edac-ti-add-missing-module_device_table.patch new file mode 100644 index 00000000000..40b039896b6 --- /dev/null +++ b/queue-5.10/edac-ti-add-missing-module_device_table.patch @@ -0,0 +1,39 @@ +From a19e5b3e0d585d34b79a87e109f4d5b5f5335809 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 11:37:27 +0800 +Subject: EDAC/ti: Add missing MODULE_DEVICE_TABLE + +From: Bixuan Cui + +[ Upstream commit 0a37f32ba5272b2d4ec8c8d0f6b212b81b578f7e ] + +The module misses MODULE_DEVICE_TABLE() for of_device_id tables and thus +never autoloads on ID matches. + +Add the missing declaration. + +Reported-by: Hulk Robot +Signed-off-by: Bixuan Cui +Signed-off-by: Borislav Petkov +Cc: Tero Kristo +Link: https://lkml.kernel.org/r/20210512033727.26701-1-cuibixuan@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/edac/ti_edac.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c +index e7eae20f83d1..169f96e51c29 100644 +--- a/drivers/edac/ti_edac.c ++++ b/drivers/edac/ti_edac.c +@@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = { + { .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 }, + {}, + }; ++MODULE_DEVICE_TABLE(of, ti_edac_of_match); + + static int _emif_get_id(struct device_node *node) + { +-- +2.30.2 + diff --git a/queue-5.10/eeprom-idt_89hpesx-put-fwnode-in-matching-case-durin.patch b/queue-5.10/eeprom-idt_89hpesx-put-fwnode-in-matching-case-durin.patch new file mode 100644 index 00000000000..0b4e75f3ea3 --- /dev/null +++ b/queue-5.10/eeprom-idt_89hpesx-put-fwnode-in-matching-case-durin.patch @@ -0,0 +1,37 @@ +From 13404247b6c5689c9b272c4fb7ee4a9105941eea Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 01:17:55 +0300 +Subject: eeprom: idt_89hpesx: Put fwnode in matching case during ->probe() + +From: Andy Shevchenko + +[ Upstream commit 3f6ee1c095156a74ab2df605af13020f1ce3e600 ] + +device_get_next_child_node() bumps a reference counting of a returned variable. +We have to balance it whenever we return to the caller. + +Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing") +Cc: Huy Duong +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210607221757.81465-1-andy.shevchenko@gmail.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/misc/eeprom/idt_89hpesx.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c +index 81c70e5bc168..45a61a1f9e98 100644 +--- a/drivers/misc/eeprom/idt_89hpesx.c ++++ b/drivers/misc/eeprom/idt_89hpesx.c +@@ -1161,6 +1161,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) + else /* if (!fwnode_property_read_bool(node, "read-only")) */ + pdev->eero = false; + ++ fwnode_handle_put(fwnode); + dev_info(dev, "EEPROM of %d bytes found by 0x%x", + pdev->eesize, pdev->eeaddr); + } +-- +2.30.2 + diff --git a/queue-5.10/eeprom-idt_89hpesx-restore-printing-the-unsupported-.patch b/queue-5.10/eeprom-idt_89hpesx-restore-printing-the-unsupported-.patch new file mode 100644 index 00000000000..72de1286a90 --- /dev/null +++ b/queue-5.10/eeprom-idt_89hpesx-restore-printing-the-unsupported-.patch @@ -0,0 +1,46 @@ +From 45027d8b11422edc81b5b4268cb738346f4686f0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 01:17:56 +0300 +Subject: eeprom: idt_89hpesx: Restore printing the unsupported fwnode name + +From: Andy Shevchenko + +[ Upstream commit e0db3deea73ba418bf5dc21f5a4e32ca87d16dde ] + +When iterating over child firmware nodes restore printing the name of ones +that are not supported. + +While at it, refactor loop body to clearly show that we stop at the first match. + +Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing") +Cc: Huy Duong +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210607221757.81465-2-andy.shevchenko@gmail.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/misc/eeprom/idt_89hpesx.c | 7 +++---- + 1 file changed, 3 insertions(+), 4 deletions(-) + +diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c +index 45a61a1f9e98..3e4a594c110b 100644 +--- a/drivers/misc/eeprom/idt_89hpesx.c ++++ b/drivers/misc/eeprom/idt_89hpesx.c +@@ -1126,11 +1126,10 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) + + device_for_each_child_node(dev, fwnode) { + ee_id = idt_ee_match_id(fwnode); +- if (!ee_id) { +- dev_warn(dev, "Skip unsupported EEPROM device"); +- continue; +- } else ++ if (ee_id) + break; ++ ++ dev_warn(dev, "Skip unsupported EEPROM device %pfw\n", fwnode); + } + + /* If there is no fwnode EEPROM device, then set zero size */ +-- +2.30.2 + diff --git a/queue-5.10/ehea-fix-error-return-code-in-ehea_restart_qps.patch b/queue-5.10/ehea-fix-error-return-code-in-ehea_restart_qps.patch new file mode 100644 index 00000000000..30d54342688 --- /dev/null +++ b/queue-5.10/ehea-fix-error-return-code-in-ehea_restart_qps.patch @@ -0,0 +1,69 @@ +From 287a5ffb949f32c4e0d279bc7a9a89392efba526 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 16:55:55 +0800 +Subject: ehea: fix error return code in ehea_restart_qps() + +From: Zhen Lei + +[ Upstream commit 015dbf5662fd689d581c0bc980711b073ca09a1a ] + +Fix to return -EFAULT from the error handling case instead of 0, as done +elsewhere in this function. + +By the way, when get_zeroed_page() fails, directly return -ENOMEM to +simplify code. + +Fixes: 2c69448bbced ("ehea: DLPAR memory add fix") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Link: https://lore.kernel.org/r/20210528085555.9390-1-thunder.leizhen@huawei.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ibm/ehea/ehea_main.c | 9 +++++---- + 1 file changed, 5 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c +index c2e740475786..f63066736425 100644 +--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c ++++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c +@@ -2617,10 +2617,8 @@ static int ehea_restart_qps(struct net_device *dev) + u16 dummy16 = 0; + + cb0 = (void *)get_zeroed_page(GFP_KERNEL); +- if (!cb0) { +- ret = -ENOMEM; +- goto out; +- } ++ if (!cb0) ++ return -ENOMEM; + + for (i = 0; i < (port->num_def_qps); i++) { + struct ehea_port_res *pr = &port->port_res[i]; +@@ -2640,6 +2638,7 @@ static int ehea_restart_qps(struct net_device *dev) + cb0); + if (hret != H_SUCCESS) { + netdev_err(dev, "query_ehea_qp failed (1)\n"); ++ ret = -EFAULT; + goto out; + } + +@@ -2652,6 +2651,7 @@ static int ehea_restart_qps(struct net_device *dev) + &dummy64, &dummy16, &dummy16); + if (hret != H_SUCCESS) { + netdev_err(dev, "modify_ehea_qp failed (1)\n"); ++ ret = -EFAULT; + goto out; + } + +@@ -2660,6 +2660,7 @@ static int ehea_restart_qps(struct net_device *dev) + cb0); + if (hret != H_SUCCESS) { + netdev_err(dev, "query_ehea_qp failed (2)\n"); ++ ret = -EFAULT; + goto out; + } + +-- +2.30.2 + diff --git a/queue-5.10/evm-fix-writing-securityfs-evm-overflow.patch b/queue-5.10/evm-fix-writing-securityfs-evm-overflow.patch new file mode 100644 index 00000000000..830fe26c36b --- /dev/null +++ b/queue-5.10/evm-fix-writing-securityfs-evm-overflow.patch @@ -0,0 +1,44 @@ +From a0d83bf2878645681ddc248017069d17f3ced0e9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Apr 2021 18:13:45 -0400 +Subject: evm: fix writing /evm overflow + +From: Mimi Zohar + +[ Upstream commit 49219d9b8785ba712575c40e48ce0f7461254626 ] + +EVM_SETUP_COMPLETE is defined as 0x80000000, which is larger than INT_MAX. +The "-fno-strict-overflow" compiler option properly prevents signaling +EVM that the EVM policy setup is complete. Define and read an unsigned +int. + +Fixes: f00d79750712 ("EVM: Allow userspace to signal an RSA key has been loaded") +Signed-off-by: Mimi Zohar +Signed-off-by: Sasha Levin +--- + security/integrity/evm/evm_secfs.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/security/integrity/evm/evm_secfs.c b/security/integrity/evm/evm_secfs.c +index a7042ae90b9e..bc10c945f3ed 100644 +--- a/security/integrity/evm/evm_secfs.c ++++ b/security/integrity/evm/evm_secfs.c +@@ -66,12 +66,13 @@ static ssize_t evm_read_key(struct file *filp, char __user *buf, + static ssize_t evm_write_key(struct file *file, const char __user *buf, + size_t count, loff_t *ppos) + { +- int i, ret; ++ unsigned int i; ++ int ret; + + if (!capable(CAP_SYS_ADMIN) || (evm_initialized & EVM_SETUP_COMPLETE)) + return -EPERM; + +- ret = kstrtoint_from_user(buf, count, 0, &i); ++ ret = kstrtouint_from_user(buf, count, 0, &i); + + if (ret) + return ret; +-- +2.30.2 + diff --git a/queue-5.10/extcon-extcon-max8997-fix-irq-freeing-at-error-path.patch b/queue-5.10/extcon-extcon-max8997-fix-irq-freeing-at-error-path.patch new file mode 100644 index 00000000000..944ad07354f --- /dev/null +++ b/queue-5.10/extcon-extcon-max8997-fix-irq-freeing-at-error-path.patch @@ -0,0 +1,41 @@ +From 52f227cdb8b9189393858dce44b566b4d4c74603 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 13:10:31 +0300 +Subject: extcon: extcon-max8997: Fix IRQ freeing at error path + +From: Matti Vaittinen + +[ Upstream commit 610bdc04830a864115e6928fc944f1171dfff6f3 ] + +If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits +without freeing the requested IRQs. + +Free the IRQs prior returning if reading the status fails. + +Fixes: 3e34c8198960 ("extcon: max8997: Avoid forcing UART path on drive probe") +Signed-off-by: Matti Vaittinen +Reviewed-by: Hans de Goede +Acked-by: Chanwoo Choi +Link: https://lore.kernel.org/r/27ee4a48ee775c3f8c9d90459c18b6f2b15edc76.1623146580.git.matti.vaittinen@fi.rohmeurope.com +Signed-off-by: Hans de Goede +Signed-off-by: Sasha Levin +--- + drivers/extcon/extcon-max8997.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c +index 337b0eea4e62..5c4f7746cbee 100644 +--- a/drivers/extcon/extcon-max8997.c ++++ b/drivers/extcon/extcon-max8997.c +@@ -729,7 +729,7 @@ static int max8997_muic_probe(struct platform_device *pdev) + 2, info->status); + if (ret) { + dev_err(info->dev, "failed to read MUIC register\n"); +- return ret; ++ goto err_irq; + } + cable_type = max8997_muic_get_cable_type(info, + MAX8997_CABLE_GROUP_ADC, &attached); +-- +2.30.2 + diff --git a/queue-5.10/extcon-max8997-add-missing-modalias-string.patch b/queue-5.10/extcon-max8997-add-missing-modalias-string.patch new file mode 100644 index 00000000000..2adf92bffa1 --- /dev/null +++ b/queue-5.10/extcon-max8997-add-missing-modalias-string.patch @@ -0,0 +1,33 @@ +From 40093a8d51d6c1bd69eb6074431a367d2fb1d8f0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 22:46:24 +0200 +Subject: extcon: max8997: Add missing modalias string + +From: Marek Szyprowski + +[ Upstream commit dc11fc2991e9efbceef93912b83e333d2835fb19 ] + +The platform device driver name is "max8997-muic", so advertise it +properly in the modalias string. This fixes automated module loading when +this driver is compiled as a module. + +Fixes: b76668ba8a77 ("Extcon: add MAX8997 extcon driver") +Signed-off-by: Marek Szyprowski +Signed-off-by: Chanwoo Choi +Signed-off-by: Sasha Levin +--- + drivers/extcon/extcon-max8997.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c +index 5c4f7746cbee..64008808675e 100644 +--- a/drivers/extcon/extcon-max8997.c ++++ b/drivers/extcon/extcon-max8997.c +@@ -784,3 +784,4 @@ module_platform_driver(max8997_muic_driver); + MODULE_DESCRIPTION("Maxim MAX8997 Extcon driver"); + MODULE_AUTHOR("Donggeun Kim "); + MODULE_LICENSE("GPL"); ++MODULE_ALIAS("platform:max8997-muic"); +-- +2.30.2 + diff --git a/queue-5.10/extcon-sm5502-drop-invalid-register-write-in-sm5502_.patch b/queue-5.10/extcon-sm5502-drop-invalid-register-write-in-sm5502_.patch new file mode 100644 index 00000000000..111f2073658 --- /dev/null +++ b/queue-5.10/extcon-sm5502-drop-invalid-register-write-in-sm5502_.patch @@ -0,0 +1,40 @@ +From d5a1c8d2dbee8cd90bd7bf1a828f7d864033ca75 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 15:34:35 +0200 +Subject: extcon: sm5502: Drop invalid register write in sm5502_reg_data + +From: Stephan Gerhold + +[ Upstream commit d25b224f8e5507879b36a769a6d1324cf163466c ] + +When sm5502_init_dev_type() iterates over sm5502_reg_data to +initialize the registers it is limited by ARRAY_SIZE(sm5502_reg_data). +There is no need to add another empty element to sm5502_reg_data. + +Having the additional empty element in sm5502_reg_data will just +result in writing 0xff to register 0x00, which does not really +make sense. + +Fixes: 914b881f9452 ("extcon: sm5502: Add support new SM5502 extcon device driver") +Signed-off-by: Stephan Gerhold +Signed-off-by: Chanwoo Choi +Signed-off-by: Sasha Levin +--- + drivers/extcon/extcon-sm5502.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c +index 106d4da647bd..5e0718dee03b 100644 +--- a/drivers/extcon/extcon-sm5502.c ++++ b/drivers/extcon/extcon-sm5502.c +@@ -88,7 +88,6 @@ static struct reg_data sm5502_reg_data[] = { + | SM5502_REG_INTM2_MHL_MASK, + .invert = true, + }, +- { } + }; + + /* List of detectable cables */ +-- +2.30.2 + diff --git a/queue-5.10/firmware-stratix10-svc-fix-a-resource-leak-in-an-err.patch b/queue-5.10/firmware-stratix10-svc-fix-a-resource-leak-in-an-err.patch new file mode 100644 index 00000000000..ab0c43a5440 --- /dev/null +++ b/queue-5.10/firmware-stratix10-svc-fix-a-resource-leak-in-an-err.patch @@ -0,0 +1,73 @@ +From 6c48995ec7ff6c2a4a98a9a8e0d7881f6ed6aa8a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 20:22:15 +0200 +Subject: firmware: stratix10-svc: Fix a resource leak in an error handling + path + +From: Christophe JAILLET + +[ Upstream commit d99247f9b542533ddbf87a3481a05473b8e48194 ] + +If an error occurs after a successful 'kfifo_alloc()' call, it must be +undone by a corresponding 'kfifo_free()' call, as already done in the +remove function. + +While at it, move the 'platform_device_put()' call to this new error +handling path and explicitly return 0 in the success path. + +Fixes: b5dc75c915cd ("firmware: stratix10-svc: extend svc to support new RSU features") +Signed-off-by: Christophe JAILLET +Link: https://lore.kernel.org/r/0ca3f3ab139c53e846804455a1e7599ee8ae896a.1621621271.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/firmware/stratix10-svc.c | 22 +++++++++++++++------- + 1 file changed, 15 insertions(+), 7 deletions(-) + +diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c +index 3aa489dba30a..2a7687911c09 100644 +--- a/drivers/firmware/stratix10-svc.c ++++ b/drivers/firmware/stratix10-svc.c +@@ -1034,24 +1034,32 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) + + /* add svc client device(s) */ + svc = devm_kzalloc(dev, sizeof(*svc), GFP_KERNEL); +- if (!svc) +- return -ENOMEM; ++ if (!svc) { ++ ret = -ENOMEM; ++ goto err_free_kfifo; ++ } + + svc->stratix10_svc_rsu = platform_device_alloc(STRATIX10_RSU, 0); + if (!svc->stratix10_svc_rsu) { + dev_err(dev, "failed to allocate %s device\n", STRATIX10_RSU); +- return -ENOMEM; ++ ret = -ENOMEM; ++ goto err_free_kfifo; + } + + ret = platform_device_add(svc->stratix10_svc_rsu); +- if (ret) { +- platform_device_put(svc->stratix10_svc_rsu); +- return ret; +- } ++ if (ret) ++ goto err_put_device; ++ + dev_set_drvdata(dev, svc); + + pr_info("Intel Service Layer Driver Initialized\n"); + ++ return 0; ++ ++err_put_device: ++ platform_device_put(svc->stratix10_svc_rsu); ++err_free_kfifo: ++ kfifo_free(&controller->svc_fifo); + return ret; + } + +-- +2.30.2 + diff --git a/queue-5.10/fs-dlm-cancel-work-sync-othercon.patch b/queue-5.10/fs-dlm-cancel-work-sync-othercon.patch new file mode 100644 index 00000000000..bb988cbaa32 --- /dev/null +++ b/queue-5.10/fs-dlm-cancel-work-sync-othercon.patch @@ -0,0 +1,38 @@ +From 4746597110ffbacaf0ecc0388fe2b73c68eb9cbc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 15:08:38 -0400 +Subject: fs: dlm: cancel work sync othercon + +From: Alexander Aring + +[ Upstream commit c6aa00e3d20c2767ba3f57b64eb862572b9744b3 ] + +These rx tx flags arguments are for signaling close_connection() from +which worker they are called. Obviously the receive worker cannot cancel +itself and vice versa for swork. For the othercon the receive worker +should only be used, however to avoid deadlocks we should pass the same +flags as the original close_connection() was called. + +Signed-off-by: Alexander Aring +Signed-off-by: David Teigland +Signed-off-by: Sasha Levin +--- + fs/dlm/lowcomms.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c +index 44e2716ac158..0c78fdfb1f6f 100644 +--- a/fs/dlm/lowcomms.c ++++ b/fs/dlm/lowcomms.c +@@ -599,7 +599,7 @@ static void close_connection(struct connection *con, bool and_other, + } + if (con->othercon && and_other) { + /* Will only re-enter once. */ +- close_connection(con->othercon, false, true, true); ++ close_connection(con->othercon, false, tx, rx); + } + + con->rx_leftover = 0; +-- +2.30.2 + diff --git a/queue-5.10/fs-dlm-fix-memory-leak-when-fenced.patch b/queue-5.10/fs-dlm-fix-memory-leak-when-fenced.patch new file mode 100644 index 00000000000..1927dbb90c9 --- /dev/null +++ b/queue-5.10/fs-dlm-fix-memory-leak-when-fenced.patch @@ -0,0 +1,85 @@ +From 8a861e30cc0cbde16b352e13337b2d81e19189db Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 2 Jun 2021 09:45:16 -0400 +Subject: fs: dlm: fix memory leak when fenced + +From: Alexander Aring + +[ Upstream commit 700ab1c363c7b54c9ea3222379b33fc00ab02f7b ] + +I got some kmemleak report when a node was fenced. The user space tool +dlm_controld will therefore run some rmdir() in dlm configfs which was +triggering some memleaks. This patch stores the sps and cms attributes +which stores some handling for subdirectories of the configfs cluster +entry and free them if they get released as the parent directory gets +freed. + +unreferenced object 0xffff88810d9e3e00 (size 192): + comm "dlm_controld", pid 342, jiffies 4294698126 (age 55438.801s) + hex dump (first 32 bytes): + 00 00 00 00 00 00 00 00 73 70 61 63 65 73 00 00 ........spaces.. + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + backtrace: + [<00000000db8b640b>] make_cluster+0x5d/0x360 + [<000000006a571db4>] configfs_mkdir+0x274/0x730 + [<00000000b094501c>] vfs_mkdir+0x27e/0x340 + [<0000000058b0adaf>] do_mkdirat+0xff/0x1b0 + [<00000000d1ffd156>] do_syscall_64+0x40/0x80 + [<00000000ab1408c8>] entry_SYSCALL_64_after_hwframe+0x44/0xae +unreferenced object 0xffff88810d9e3a00 (size 192): + comm "dlm_controld", pid 342, jiffies 4294698126 (age 55438.801s) + hex dump (first 32 bytes): + 00 00 00 00 00 00 00 00 63 6f 6d 6d 73 00 00 00 ........comms... + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + backtrace: + [<00000000a7ef6ad2>] make_cluster+0x82/0x360 + [<000000006a571db4>] configfs_mkdir+0x274/0x730 + [<00000000b094501c>] vfs_mkdir+0x27e/0x340 + [<0000000058b0adaf>] do_mkdirat+0xff/0x1b0 + [<00000000d1ffd156>] do_syscall_64+0x40/0x80 + [<00000000ab1408c8>] entry_SYSCALL_64_after_hwframe+0x44/0xae + +Signed-off-by: Alexander Aring +Signed-off-by: David Teigland +Signed-off-by: Sasha Levin +--- + fs/dlm/config.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/fs/dlm/config.c b/fs/dlm/config.c +index 73e6643903af..18a8ffcea0aa 100644 +--- a/fs/dlm/config.c ++++ b/fs/dlm/config.c +@@ -79,6 +79,9 @@ struct dlm_cluster { + unsigned int cl_new_rsb_count; + unsigned int cl_recover_callbacks; + char cl_cluster_name[DLM_LOCKSPACE_LEN]; ++ ++ struct dlm_spaces *sps; ++ struct dlm_comms *cms; + }; + + static struct dlm_cluster *config_item_to_cluster(struct config_item *i) +@@ -379,6 +382,9 @@ static struct config_group *make_cluster(struct config_group *g, + if (!cl || !sps || !cms) + goto fail; + ++ cl->sps = sps; ++ cl->cms = cms; ++ + config_group_init_type_name(&cl->group, name, &cluster_type); + config_group_init_type_name(&sps->ss_group, "spaces", &spaces_type); + config_group_init_type_name(&cms->cs_group, "comms", &comms_type); +@@ -428,6 +434,9 @@ static void drop_cluster(struct config_group *g, struct config_item *i) + static void release_cluster(struct config_item *i) + { + struct dlm_cluster *cl = config_item_to_cluster(i); ++ ++ kfree(cl->sps); ++ kfree(cl->cms); + kfree(cl); + } + +-- +2.30.2 + diff --git a/queue-5.10/fsi-core-fix-return-of-error-values-on-failures.patch b/queue-5.10/fsi-core-fix-return-of-error-values-on-failures.patch new file mode 100644 index 00000000000..dd79774c292 --- /dev/null +++ b/queue-5.10/fsi-core-fix-return-of-error-values-on-failures.patch @@ -0,0 +1,50 @@ +From a9298ee5d4e15530c679de8315bd39880b822afa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 13:28:12 +0100 +Subject: fsi: core: Fix return of error values on failures + +From: Colin Ian King + +[ Upstream commit 910810945707fe9877ca86a0dca4e585fd05e37b ] + +Currently the cfam_read and cfam_write functions return the provided +number of bytes given in the count parameter and not the error return +code in variable rc, hence all failures of read/writes are being +silently ignored. Fix this by returning the error code in rc. + +Addresses-Coverity: ("Unused value") +Fixes: d1dcd6782576 ("fsi: Add cfam char devices") +Signed-off-by: Colin Ian King +Reviewed-by: Jeremy Kerr +Link: https://lore.kernel.org/r/20210603122812.83587-1-colin.king@canonical.com +Signed-off-by: Joel Stanley +Signed-off-by: Sasha Levin +--- + drivers/fsi/fsi-core.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c +index 4e60e84cd17a..59ddc9fd5bca 100644 +--- a/drivers/fsi/fsi-core.c ++++ b/drivers/fsi/fsi-core.c +@@ -724,7 +724,7 @@ static ssize_t cfam_read(struct file *filep, char __user *buf, size_t count, + rc = count; + fail: + *offset = off; +- return count; ++ return rc; + } + + static ssize_t cfam_write(struct file *filep, const char __user *buf, +@@ -761,7 +761,7 @@ static ssize_t cfam_write(struct file *filep, const char __user *buf, + rc = count; + fail: + *offset = off; +- return count; ++ return rc; + } + + static loff_t cfam_llseek(struct file *file, loff_t offset, int whence) +-- +2.30.2 + diff --git a/queue-5.10/fsi-occ-don-t-accept-response-from-un-initialized-oc.patch b/queue-5.10/fsi-occ-don-t-accept-response-from-un-initialized-oc.patch new file mode 100644 index 00000000000..6a52196d58c --- /dev/null +++ b/queue-5.10/fsi-occ-don-t-accept-response-from-un-initialized-oc.patch @@ -0,0 +1,38 @@ +From 69389b1dadd3ede2d14ebbc7d8dc58263be56dbd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Feb 2021 11:12:32 -0600 +Subject: fsi: occ: Don't accept response from un-initialized OCC + +From: Eddie James + +[ Upstream commit 8a4659be08576141f47d47d94130eb148cb5f0df ] + +If the OCC is not initialized and responds as such, the driver +should continue waiting for a valid response until the timeout +expires. + +Signed-off-by: Eddie James +Reviewed-by: Joel Stanley +Fixes: 7ed98dddb764 ("fsi: Add On-Chip Controller (OCC) driver") +Link: https://lore.kernel.org/r/20210209171235.20624-2-eajames@linux.ibm.com +Signed-off-by: Joel Stanley +Signed-off-by: Sasha Levin +--- + drivers/fsi/fsi-occ.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c +index 9eeb856c8905..a691f9732a13 100644 +--- a/drivers/fsi/fsi-occ.c ++++ b/drivers/fsi/fsi-occ.c +@@ -445,6 +445,7 @@ int fsi_occ_submit(struct device *dev, const void *request, size_t req_len, + goto done; + + if (resp->return_status == OCC_RESP_CMD_IN_PRG || ++ resp->return_status == OCC_RESP_CRIT_INIT || + resp->seq_no != seq_no) { + rc = -ETIMEDOUT; + +-- +2.30.2 + diff --git a/queue-5.10/fsi-sbefifo-clean-up-correct-fifo-when-receiving-res.patch b/queue-5.10/fsi-sbefifo-clean-up-correct-fifo-when-receiving-res.patch new file mode 100644 index 00000000000..7dc02685915 --- /dev/null +++ b/queue-5.10/fsi-sbefifo-clean-up-correct-fifo-when-receiving-res.patch @@ -0,0 +1,39 @@ +From 992a93d1862acf13589394b12f3d53460761f215 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 24 Jul 2020 16:45:17 +0930 +Subject: fsi/sbefifo: Clean up correct FIFO when receiving reset request from + SBE + +From: Joachim Fenkes + +[ Upstream commit 95152433e46fdb36652ebdbea442356a16ae1fa6 ] + +When the SBE requests a reset via the down FIFO, that is also the +FIFO we should go and reset ;) + +Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO") +Signed-off-by: Joachim Fenkes +Signed-off-by: Joel Stanley +Link: https://lore.kernel.org/r/20200724071518.430515-2-joel@jms.id.au +Signed-off-by: Joel Stanley +Signed-off-by: Sasha Levin +--- + drivers/fsi/fsi-sbefifo.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c +index bfd5e5da8020..de27c435d706 100644 +--- a/drivers/fsi/fsi-sbefifo.c ++++ b/drivers/fsi/fsi-sbefifo.c +@@ -400,7 +400,7 @@ static int sbefifo_cleanup_hw(struct sbefifo *sbefifo) + /* The FIFO already contains a reset request from the SBE ? */ + if (down_status & SBEFIFO_STS_RESET_REQ) { + dev_info(dev, "Cleanup: FIFO reset request set, resetting\n"); +- rc = sbefifo_regw(sbefifo, SBEFIFO_UP, SBEFIFO_PERFORM_RESET); ++ rc = sbefifo_regw(sbefifo, SBEFIFO_DOWN, SBEFIFO_PERFORM_RESET); + if (rc) { + sbefifo->broken = true; + dev_err(dev, "Cleanup: Reset reg write failed, rc=%d\n", rc); +-- +2.30.2 + diff --git a/queue-5.10/fsi-sbefifo-fix-reset-timeout.patch b/queue-5.10/fsi-sbefifo-fix-reset-timeout.patch new file mode 100644 index 00000000000..66a099606af --- /dev/null +++ b/queue-5.10/fsi-sbefifo-fix-reset-timeout.patch @@ -0,0 +1,60 @@ +From 84a8496569f31c1c4b6037f6724c2c388d492688 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 24 Jul 2020 16:45:18 +0930 +Subject: fsi/sbefifo: Fix reset timeout + +From: Joachim Fenkes + +[ Upstream commit 9ab1428dfe2c66b51e0b41337cd0164da0ab6080 ] + +On BMCs with lower timer resolution than 1ms, msleep(1) will take +way longer than 1ms, so looping 10k times won't wait for 10s but +significantly longer. + +Fix this by using jiffies like the rest of the code. + +Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO") +Signed-off-by: Joachim Fenkes +Link: https://lore.kernel.org/r/20200724071518.430515-3-joel@jms.id.au +Signed-off-by: Joel Stanley +Signed-off-by: Sasha Levin +--- + drivers/fsi/fsi-sbefifo.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c +index de27c435d706..84cb965bfed5 100644 +--- a/drivers/fsi/fsi-sbefifo.c ++++ b/drivers/fsi/fsi-sbefifo.c +@@ -325,7 +325,8 @@ static int sbefifo_up_write(struct sbefifo *sbefifo, __be32 word) + static int sbefifo_request_reset(struct sbefifo *sbefifo) + { + struct device *dev = &sbefifo->fsi_dev->dev; +- u32 status, timeout; ++ unsigned long end_time; ++ u32 status; + int rc; + + dev_dbg(dev, "Requesting FIFO reset\n"); +@@ -341,7 +342,8 @@ static int sbefifo_request_reset(struct sbefifo *sbefifo) + } + + /* Wait for it to complete */ +- for (timeout = 0; timeout < SBEFIFO_RESET_TIMEOUT; timeout++) { ++ end_time = jiffies + msecs_to_jiffies(SBEFIFO_RESET_TIMEOUT); ++ while (!time_after(jiffies, end_time)) { + rc = sbefifo_regr(sbefifo, SBEFIFO_UP | SBEFIFO_STS, &status); + if (rc) { + dev_err(dev, "Failed to read UP fifo status during reset" +@@ -355,7 +357,7 @@ static int sbefifo_request_reset(struct sbefifo *sbefifo) + return 0; + } + +- msleep(1); ++ cond_resched(); + } + dev_err(dev, "FIFO reset timed out\n"); + +-- +2.30.2 + diff --git a/queue-5.10/fsi-scom-reset-the-fsi2pib-engine-for-any-error.patch b/queue-5.10/fsi-scom-reset-the-fsi2pib-engine-for-any-error.patch new file mode 100644 index 00000000000..235011cbd0b --- /dev/null +++ b/queue-5.10/fsi-scom-reset-the-fsi2pib-engine-for-any-error.patch @@ -0,0 +1,63 @@ +From fd10cc3464876f4b62a54be01aea3152a93aba4f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 29 Mar 2021 10:13:44 -0500 +Subject: fsi: scom: Reset the FSI2PIB engine for any error + +From: Eddie James + +[ Upstream commit a5c317dac5567206ca7b6bc9d008dd6890c8bced ] + +The error bits in the FSI2PIB status are only cleared by a reset. So +the driver needs to perform a reset after seeing any of the FSI2PIB +errors, otherwise subsequent operations will also look like failures. + +Fixes: 6b293258cded ("fsi: scom: Major overhaul") +Signed-off-by: Eddie James +Reviewed-by: Joel Stanley +Link: https://lore.kernel.org/r/20210329151344.14246-1-eajames@linux.ibm.com +Signed-off-by: Joel Stanley +Signed-off-by: Sasha Levin +--- + drivers/fsi/fsi-scom.c | 16 +++++++++------- + 1 file changed, 9 insertions(+), 7 deletions(-) + +diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c +index b45bfab7b7f5..75d1389e2626 100644 +--- a/drivers/fsi/fsi-scom.c ++++ b/drivers/fsi/fsi-scom.c +@@ -38,9 +38,10 @@ + #define SCOM_STATUS_PIB_RESP_MASK 0x00007000 + #define SCOM_STATUS_PIB_RESP_SHIFT 12 + +-#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_PROTECTION | \ +- SCOM_STATUS_PARITY | \ +- SCOM_STATUS_PIB_ABORT | \ ++#define SCOM_STATUS_FSI2PIB_ERROR (SCOM_STATUS_PROTECTION | \ ++ SCOM_STATUS_PARITY | \ ++ SCOM_STATUS_PIB_ABORT) ++#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_FSI2PIB_ERROR | \ + SCOM_STATUS_PIB_RESP_MASK) + /* SCOM address encodings */ + #define XSCOM_ADDR_IND_FLAG BIT_ULL(63) +@@ -240,13 +241,14 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status) + { + uint32_t dummy = -1; + +- if (status & SCOM_STATUS_PROTECTION) +- return -EPERM; +- if (status & SCOM_STATUS_PARITY) { ++ if (status & SCOM_STATUS_FSI2PIB_ERROR) + fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy, + sizeof(uint32_t)); ++ ++ if (status & SCOM_STATUS_PROTECTION) ++ return -EPERM; ++ if (status & SCOM_STATUS_PARITY) + return -EIO; +- } + /* Return -EBUSY on PIB abort to force a retry */ + if (status & SCOM_STATUS_PIB_ABORT) + return -EBUSY; +-- +2.30.2 + diff --git a/queue-5.10/gve-fix-swapped-vars-when-fetching-max-queues.patch b/queue-5.10/gve-fix-swapped-vars-when-fetching-max-queues.patch new file mode 100644 index 00000000000..54d6b88a064 --- /dev/null +++ b/queue-5.10/gve-fix-swapped-vars-when-fetching-max-queues.patch @@ -0,0 +1,35 @@ +From f0cce1e351f2e9240270cc1332644b12c5ecb1a8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 19:55:41 -0700 +Subject: gve: Fix swapped vars when fetching max queues + +From: Bailey Forrest + +[ Upstream commit 1db1a862a08f85edc36aad091236ac9b818e949e ] + +Fixes: 893ce44df565 ("gve: Add basic driver framework for Compute Engine Virtual NIC") +Signed-off-by: Bailey Forrest +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/google/gve/gve_main.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c +index d6e35421d8f7..3a74e4645ce6 100644 +--- a/drivers/net/ethernet/google/gve/gve_main.c ++++ b/drivers/net/ethernet/google/gve/gve_main.c +@@ -1286,8 +1286,8 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent) + + gve_write_version(®_bar->driver_version); + /* Get max queues to alloc etherdev */ +- max_rx_queues = ioread32be(®_bar->max_tx_queues); +- max_tx_queues = ioread32be(®_bar->max_rx_queues); ++ max_tx_queues = ioread32be(®_bar->max_tx_queues); ++ max_rx_queues = ioread32be(®_bar->max_rx_queues); + /* Alloc and setup the netdev and priv */ + dev = alloc_etherdev_mqs(sizeof(*priv), max_tx_queues, max_rx_queues); + if (!dev) { +-- +2.30.2 + diff --git a/queue-5.10/habanalabs-fix-an-error-handling-path-in-hl_pci_prob.patch b/queue-5.10/habanalabs-fix-an-error-handling-path-in-hl_pci_prob.patch new file mode 100644 index 00000000000..37de35ae674 --- /dev/null +++ b/queue-5.10/habanalabs-fix-an-error-handling-path-in-hl_pci_prob.patch @@ -0,0 +1,37 @@ +From 58efd2ff5b408eaa4bef94aaaa9bbeb0ec881c22 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 12 Jun 2021 07:39:51 +0200 +Subject: habanalabs: Fix an error handling path in 'hl_pci_probe()' + +From: Christophe JAILLET + +[ Upstream commit 3002f467a0b0a70aec01d9f446da4ac8c6fda10b ] + +If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it +must be undone by a corresponding 'pci_disable_pcie_error_reporting()' +call, as already done in the remove function. + +Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support") +Signed-off-by: Christophe JAILLET +Reviewed-by: Oded Gabbay +Signed-off-by: Oded Gabbay +Signed-off-by: Sasha Levin +--- + drivers/misc/habanalabs/common/habanalabs_drv.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c +index 3bcef64a677a..ded92b3cbdb2 100644 +--- a/drivers/misc/habanalabs/common/habanalabs_drv.c ++++ b/drivers/misc/habanalabs/common/habanalabs_drv.c +@@ -421,6 +421,7 @@ static int hl_pci_probe(struct pci_dev *pdev, + return 0; + + disable_device: ++ pci_disable_pcie_error_reporting(pdev); + pci_set_drvdata(pdev, NULL); + destroy_hdev(hdev); + +-- +2.30.2 + diff --git a/queue-5.10/hid-do-not-use-down_interruptible-when-unbinding-dev.patch b/queue-5.10/hid-do-not-use-down_interruptible-when-unbinding-dev.patch new file mode 100644 index 00000000000..6213f288de3 --- /dev/null +++ b/queue-5.10/hid-do-not-use-down_interruptible-when-unbinding-dev.patch @@ -0,0 +1,53 @@ +From a0e4d8c332af59c51ace7f23ef2ad90ebe9b19cf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Mar 2021 17:27:16 -0700 +Subject: HID: do not use down_interruptible() when unbinding devices + +From: Dmitry Torokhov + +[ Upstream commit f2145f8dc566c4f3b5a8deb58dcd12bed4e20194 ] + +Action of unbinding driver from a device is not cancellable and should not +fail, and driver core does not pay attention to the result of "remove" +method, therefore using down_interruptible() in hid_device_remove() does +not make sense. + +Signed-off-by: Dmitry Torokhov +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/hid-core.c | 10 +++------- + 1 file changed, 3 insertions(+), 7 deletions(-) + +diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c +index 0f69f35f2957..5550c943f985 100644 +--- a/drivers/hid/hid-core.c ++++ b/drivers/hid/hid-core.c +@@ -2306,12 +2306,8 @@ static int hid_device_remove(struct device *dev) + { + struct hid_device *hdev = to_hid_device(dev); + struct hid_driver *hdrv; +- int ret = 0; + +- if (down_interruptible(&hdev->driver_input_lock)) { +- ret = -EINTR; +- goto end; +- } ++ down(&hdev->driver_input_lock); + hdev->io_started = false; + + hdrv = hdev->driver; +@@ -2326,8 +2322,8 @@ static int hid_device_remove(struct device *dev) + + if (!hdev->io_started) + up(&hdev->driver_input_lock); +-end: +- return ret; ++ ++ return 0; + } + + static ssize_t modalias_show(struct device *dev, struct device_attribute *a, +-- +2.30.2 + diff --git a/queue-5.10/hid-wacom-correct-base-usage-for-capacitive-expressk.patch b/queue-5.10/hid-wacom-correct-base-usage-for-capacitive-expressk.patch new file mode 100644 index 00000000000..abb84a903db --- /dev/null +++ b/queue-5.10/hid-wacom-correct-base-usage-for-capacitive-expressk.patch @@ -0,0 +1,35 @@ +From b79dbd082c77844368db60bdc091bb5cfbddf8df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 09:58:09 -0700 +Subject: HID: wacom: Correct base usage for capacitive ExpressKey status bits + +From: Jason Gerecke + +[ Upstream commit 424d8237945c6c448c8b3f23885d464fb5685c97 ] + +The capacitive status of ExpressKeys is reported with usages beginning +at 0x940, not 0x950. Bring our driver into alignment with reality. + +Signed-off-by: Jason Gerecke +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/wacom_wac.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h +index 195910dd2154..e3835407e8d2 100644 +--- a/drivers/hid/wacom_wac.h ++++ b/drivers/hid/wacom_wac.h +@@ -122,7 +122,7 @@ + #define WACOM_HID_WD_TOUCHONOFF (WACOM_HID_UP_WACOMDIGITIZER | 0x0454) + #define WACOM_HID_WD_BATTERY_LEVEL (WACOM_HID_UP_WACOMDIGITIZER | 0x043b) + #define WACOM_HID_WD_EXPRESSKEY00 (WACOM_HID_UP_WACOMDIGITIZER | 0x0910) +-#define WACOM_HID_WD_EXPRESSKEYCAP00 (WACOM_HID_UP_WACOMDIGITIZER | 0x0950) ++#define WACOM_HID_WD_EXPRESSKEYCAP00 (WACOM_HID_UP_WACOMDIGITIZER | 0x0940) + #define WACOM_HID_WD_MODE_CHANGE (WACOM_HID_UP_WACOMDIGITIZER | 0x0980) + #define WACOM_HID_WD_MUTE_DEVICE (WACOM_HID_UP_WACOMDIGITIZER | 0x0981) + #define WACOM_HID_WD_CONTROLPANEL (WACOM_HID_UP_WACOMDIGITIZER | 0x0982) +-- +2.30.2 + diff --git a/queue-5.10/hugetlb-address-ref-count-racing-in-prep_compound_gi.patch b/queue-5.10/hugetlb-address-ref-count-racing-in-prep_compound_gi.patch new file mode 100644 index 00000000000..bb6489c84d7 --- /dev/null +++ b/queue-5.10/hugetlb-address-ref-count-racing-in-prep_compound_gi.patch @@ -0,0 +1,212 @@ +From 7a9780ce2a81d8ecb63d262dcc2cdd8d72ceeef4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:48:34 -0700 +Subject: hugetlb: address ref count racing in prep_compound_gigantic_page + +From: Mike Kravetz + +[ Upstream commit 7118fc2906e2925d7edb5ed9c8a57f2a5f23b849 ] + +In [1], Jann Horn points out a possible race between +prep_compound_gigantic_page and __page_cache_add_speculative. The root +cause of the possible race is prep_compound_gigantic_page uncondittionally +setting the ref count of pages to zero. It does this because +prep_compound_gigantic_page is handed a 'group' of pages from an allocator +and needs to convert that group of pages to a compound page. The ref +count of each page in this 'group' is one as set by the allocator. +However, the ref count of compound page tail pages must be zero. + +The potential race comes about when ref counted pages are returned from +the allocator. When this happens, other mm code could also take a +reference on the page. __page_cache_add_speculative is one such example. +Therefore, prep_compound_gigantic_page can not just set the ref count of +pages to zero as it does today. Doing so would lose the reference taken +by any other code. This would lead to BUGs in code checking ref counts +and could possibly even lead to memory corruption. + +There are two possible ways to address this issue. + +1) Make all allocators of gigantic groups of pages be able to return a + properly constructed compound page. + +2) Make prep_compound_gigantic_page be more careful when constructing a + compound page. + +This patch takes approach 2. + +In prep_compound_gigantic_page, use cmpxchg to only set ref count to zero +if it is one. If the cmpxchg fails, call synchronize_rcu() in the hope +that the extra ref count will be driopped during a rcu grace period. This +is not a performance critical code path and the wait should be +accceptable. If the ref count is still inflated after the grace period, +then undo any modifications made and return an error. + +Currently prep_compound_gigantic_page is type void and does not return +errors. Modify the two callers to check for and handle error returns. On +error, the caller must free the 'group' of pages as they can not be used +to form a gigantic page. After freeing pages, the runtime caller +(alloc_fresh_huge_page) will retry the allocation once. Boot time +allocations can not be retried. + +The routine prep_compound_page also unconditionally sets the ref count of +compound page tail pages to zero. However, in this case the buddy +allocator is constructing a compound page from freshly allocated pages. +The ref count on those freshly allocated pages is already zero, so the +set_page_count(p, 0) is unnecessary and could lead to confusion. Just +remove it. + +[1] https://lore.kernel.org/linux-mm/CAG48ez23q0Jy9cuVnwAe7t_fdhMk2S7N5Hdi-GLcCeq5bsfLxw@mail.gmail.com/ + +Link: https://lkml.kernel.org/r/20210622021423.154662-3-mike.kravetz@oracle.com +Fixes: 58a84aa92723 ("thp: set compound tail page _count to zero") +Signed-off-by: Mike Kravetz +Reported-by: Jann Horn +Cc: Youquan Song +Cc: Andrea Arcangeli +Cc: Jan Kara +Cc: John Hubbard +Cc: "Kirill A . Shutemov" +Cc: Matthew Wilcox +Cc: Michal Hocko +Cc: Muchun Song +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/hugetlb.c | 72 +++++++++++++++++++++++++++++++++++++++++++------ + mm/page_alloc.c | 1 - + 2 files changed, 64 insertions(+), 9 deletions(-) + +diff --git a/mm/hugetlb.c b/mm/hugetlb.c +index fa6b0ac6c280..2c29f9b426a5 100644 +--- a/mm/hugetlb.c ++++ b/mm/hugetlb.c +@@ -1552,9 +1552,9 @@ static void prep_new_huge_page(struct hstate *h, struct page *page, int nid) + spin_unlock(&hugetlb_lock); + } + +-static void prep_compound_gigantic_page(struct page *page, unsigned int order) ++static bool prep_compound_gigantic_page(struct page *page, unsigned int order) + { +- int i; ++ int i, j; + int nr_pages = 1 << order; + struct page *p = page + 1; + +@@ -1576,11 +1576,48 @@ static void prep_compound_gigantic_page(struct page *page, unsigned int order) + * after get_user_pages(). + */ + __ClearPageReserved(p); ++ /* ++ * Subtle and very unlikely ++ * ++ * Gigantic 'page allocators' such as memblock or cma will ++ * return a set of pages with each page ref counted. We need ++ * to turn this set of pages into a compound page with tail ++ * page ref counts set to zero. Code such as speculative page ++ * cache adding could take a ref on a 'to be' tail page. ++ * We need to respect any increased ref count, and only set ++ * the ref count to zero if count is currently 1. If count ++ * is not 1, we call synchronize_rcu in the hope that a rcu ++ * grace period will cause ref count to drop and then retry. ++ * If count is still inflated on retry we return an error and ++ * must discard the pages. ++ */ ++ if (!page_ref_freeze(p, 1)) { ++ pr_info("HugeTLB unexpected inflated ref count on freshly allocated page\n"); ++ synchronize_rcu(); ++ if (!page_ref_freeze(p, 1)) ++ goto out_error; ++ } + set_page_count(p, 0); + set_compound_head(p, page); + } + atomic_set(compound_mapcount_ptr(page), -1); + atomic_set(compound_pincount_ptr(page), 0); ++ return true; ++ ++out_error: ++ /* undo tail page modifications made above */ ++ p = page + 1; ++ for (j = 1; j < i; j++, p = mem_map_next(p, page, j)) { ++ clear_compound_head(p); ++ set_page_refcounted(p); ++ } ++ /* need to clear PG_reserved on remaining tail pages */ ++ for (; j < nr_pages; j++, p = mem_map_next(p, page, j)) ++ __ClearPageReserved(p); ++ set_compound_order(page, 0); ++ page[1].compound_nr = 0; ++ __ClearPageHead(page); ++ return false; + } + + /* +@@ -1700,7 +1737,9 @@ static struct page *alloc_fresh_huge_page(struct hstate *h, + nodemask_t *node_alloc_noretry) + { + struct page *page; ++ bool retry = false; + ++retry: + if (hstate_is_gigantic(h)) + page = alloc_gigantic_page(h, gfp_mask, nid, nmask); + else +@@ -1709,8 +1748,21 @@ static struct page *alloc_fresh_huge_page(struct hstate *h, + if (!page) + return NULL; + +- if (hstate_is_gigantic(h)) +- prep_compound_gigantic_page(page, huge_page_order(h)); ++ if (hstate_is_gigantic(h)) { ++ if (!prep_compound_gigantic_page(page, huge_page_order(h))) { ++ /* ++ * Rare failure to convert pages to compound page. ++ * Free pages and try again - ONCE! ++ */ ++ free_gigantic_page(page, huge_page_order(h)); ++ if (!retry) { ++ retry = true; ++ goto retry; ++ } ++ pr_warn("HugeTLB page can not be used due to unexpected inflated ref count\n"); ++ return NULL; ++ } ++ } + prep_new_huge_page(h, page, page_to_nid(page)); + + return page; +@@ -2490,10 +2542,14 @@ static void __init gather_bootmem_prealloc(void) + + VM_BUG_ON(!hstate_is_gigantic(h)); + WARN_ON(page_count(page) != 1); +- prep_compound_gigantic_page(page, huge_page_order(h)); +- WARN_ON(PageReserved(page)); +- prep_new_huge_page(h, page, page_to_nid(page)); +- put_page(page); /* free it into the hugepage allocator */ ++ if (prep_compound_gigantic_page(page, huge_page_order(h))) { ++ WARN_ON(PageReserved(page)); ++ prep_new_huge_page(h, page, page_to_nid(page)); ++ put_page(page); /* add to the hugepage allocator */ ++ } else { ++ free_gigantic_page(page, huge_page_order(h)); ++ pr_warn("HugeTLB page can not be used due to unexpected inflated ref count\n"); ++ } + + /* + * We need to restore the 'stolen' pages to totalram_pages +diff --git a/mm/page_alloc.c b/mm/page_alloc.c +index e30d88efd7fb..3fd7f82d6f7f 100644 +--- a/mm/page_alloc.c ++++ b/mm/page_alloc.c +@@ -701,7 +701,6 @@ void prep_compound_page(struct page *page, unsigned int order) + __SetPageHead(page); + for (i = 1; i < nr_pages; i++) { + struct page *p = page + i; +- set_page_count(p, 0); + p->mapping = TAIL_MAPPING; + set_compound_head(p, page); + } +-- +2.30.2 + diff --git a/queue-5.10/hugetlb-remove-prep_compound_huge_page-cleanup.patch b/queue-5.10/hugetlb-remove-prep_compound_huge_page-cleanup.patch new file mode 100644 index 00000000000..bab86d54b9b --- /dev/null +++ b/queue-5.10/hugetlb-remove-prep_compound_huge_page-cleanup.patch @@ -0,0 +1,121 @@ +From 57b19e14b0643e41f1551605b0eded0c1d26f67a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:48:31 -0700 +Subject: hugetlb: remove prep_compound_huge_page cleanup + +From: Mike Kravetz + +[ Upstream commit 48b8d744ea841b8adf8d07bfe7a2d55f22e4d179 ] + +Patch series "Fix prep_compound_gigantic_page ref count adjustment". + +These patches address the possible race between +prep_compound_gigantic_page and __page_cache_add_speculative as described +by Jann Horn in [1]. + +The first patch simply removes the unnecessary/obsolete helper routine +prep_compound_huge_page to make the actual fix a little simpler. + +The second patch is the actual fix and has a detailed explanation in the +commit message. + +This potential issue has existed for almost 10 years and I am unaware of +anyone actually hitting the race. I did not cc stable, but would be happy +to squash the patches and send to stable if anyone thinks that is a good +idea. + +[1] https://lore.kernel.org/linux-mm/CAG48ez23q0Jy9cuVnwAe7t_fdhMk2S7N5Hdi-GLcCeq5bsfLxw@mail.gmail.com/ + +This patch (of 2): + +I could not think of a reliable way to recreate the issue for testing. +Rather, I 'simulated errors' to exercise all the error paths. + +The routine prep_compound_huge_page is a simple wrapper to call either +prep_compound_gigantic_page or prep_compound_page. However, it is only +called from gather_bootmem_prealloc which only processes gigantic pages. +Eliminate the routine and call prep_compound_gigantic_page directly. + +Link: https://lkml.kernel.org/r/20210622021423.154662-1-mike.kravetz@oracle.com +Link: https://lkml.kernel.org/r/20210622021423.154662-2-mike.kravetz@oracle.com +Signed-off-by: Mike Kravetz +Cc: Andrea Arcangeli +Cc: Jan Kara +Cc: Jann Horn +Cc: John Hubbard +Cc: "Kirill A . Shutemov" +Cc: Matthew Wilcox +Cc: Michal Hocko +Cc: Youquan Song +Cc: Muchun Song +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/hugetlb.c | 29 ++++++++++------------------- + 1 file changed, 10 insertions(+), 19 deletions(-) + +diff --git a/mm/hugetlb.c b/mm/hugetlb.c +index f90dd909d017..fa6b0ac6c280 100644 +--- a/mm/hugetlb.c ++++ b/mm/hugetlb.c +@@ -1315,8 +1315,6 @@ static struct page *alloc_gigantic_page(struct hstate *h, gfp_t gfp_mask, + return alloc_contig_pages(nr_pages, gfp_mask, nid, nodemask); + } + +-static void prep_new_huge_page(struct hstate *h, struct page *page, int nid); +-static void prep_compound_gigantic_page(struct page *page, unsigned int order); + #else /* !CONFIG_CONTIG_ALLOC */ + static struct page *alloc_gigantic_page(struct hstate *h, gfp_t gfp_mask, + int nid, nodemask_t *nodemask) +@@ -2478,16 +2476,10 @@ found: + return 1; + } + +-static void __init prep_compound_huge_page(struct page *page, +- unsigned int order) +-{ +- if (unlikely(order > (MAX_ORDER - 1))) +- prep_compound_gigantic_page(page, order); +- else +- prep_compound_page(page, order); +-} +- +-/* Put bootmem huge pages into the standard lists after mem_map is up */ ++/* ++ * Put bootmem huge pages into the standard lists after mem_map is up. ++ * Note: This only applies to gigantic (order > MAX_ORDER) pages. ++ */ + static void __init gather_bootmem_prealloc(void) + { + struct huge_bootmem_page *m; +@@ -2496,20 +2488,19 @@ static void __init gather_bootmem_prealloc(void) + struct page *page = virt_to_page(m); + struct hstate *h = m->hstate; + ++ VM_BUG_ON(!hstate_is_gigantic(h)); + WARN_ON(page_count(page) != 1); +- prep_compound_huge_page(page, huge_page_order(h)); ++ prep_compound_gigantic_page(page, huge_page_order(h)); + WARN_ON(PageReserved(page)); + prep_new_huge_page(h, page, page_to_nid(page)); + put_page(page); /* free it into the hugepage allocator */ + + /* +- * If we had gigantic hugepages allocated at boot time, we need +- * to restore the 'stolen' pages to totalram_pages in order to +- * fix confusing memory reports from free(1) and another +- * side-effects, like CommitLimit going negative. ++ * We need to restore the 'stolen' pages to totalram_pages ++ * in order to fix confusing memory reports from free(1) and ++ * other side-effects, like CommitLimit going negative. + */ +- if (hstate_is_gigantic(h)) +- adjust_managed_page_count(page, pages_per_huge_page(h)); ++ adjust_managed_page_count(page, pages_per_huge_page(h)); + cond_resched(); + } + } +-- +2.30.2 + diff --git a/queue-5.10/hv_utils-fix-passing-zero-to-ptr_err-warning.patch b/queue-5.10/hv_utils-fix-passing-zero-to-ptr_err-warning.patch new file mode 100644 index 00000000000..771e895bac6 --- /dev/null +++ b/queue-5.10/hv_utils-fix-passing-zero-to-ptr_err-warning.patch @@ -0,0 +1,43 @@ +From 58bde291ea6f3df26da97509fe1238d9c69b8ca0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 15:01:16 +0800 +Subject: hv_utils: Fix passing zero to 'PTR_ERR' warning + +From: YueHaibing + +[ Upstream commit c6a8625fa4c6b0a97860d053271660ccedc3d1b3 ] + +Sparse warn this: + +drivers/hv/hv_util.c:753 hv_timesync_init() warn: + passing zero to 'PTR_ERR' + +Use PTR_ERR_OR_ZERO instead of PTR_ERR to fix this. + +Signed-off-by: YueHaibing +Link: https://lore.kernel.org/r/20210514070116.16800-1-yuehaibing@huawei.com +[ wei: change %ld to %d ] +Signed-off-by: Wei Liu +Signed-off-by: Sasha Levin +--- + drivers/hv/hv_util.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c +index 05566ecdbe4b..1b914e418e41 100644 +--- a/drivers/hv/hv_util.c ++++ b/drivers/hv/hv_util.c +@@ -696,8 +696,8 @@ static int hv_timesync_init(struct hv_util_service *srv) + */ + hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL); + if (IS_ERR_OR_NULL(hv_ptp_clock)) { +- pr_err("cannot register PTP clock: %ld\n", +- PTR_ERR(hv_ptp_clock)); ++ pr_err("cannot register PTP clock: %d\n", ++ PTR_ERR_OR_ZERO(hv_ptp_clock)); + hv_ptp_clock = NULL; + } + +-- +2.30.2 + diff --git a/queue-5.10/hwmon-lm70-revert-hwmon-lm70-add-support-for-acpi.patch b/queue-5.10/hwmon-lm70-revert-hwmon-lm70-add-support-for-acpi.patch new file mode 100644 index 00000000000..2e2e7d08f69 --- /dev/null +++ b/queue-5.10/hwmon-lm70-revert-hwmon-lm70-add-support-for-acpi.patch @@ -0,0 +1,80 @@ +From 37a691f2aa917c75bb7b4bc0403c794150e98fcd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 09:44:50 -0700 +Subject: hwmon: (lm70) Revert "hwmon: (lm70) Add support for ACPI" + +From: Guenter Roeck + +[ Upstream commit ac61c8aae446b9c0fe18981fe721d4a43e283ad6 ] + +This reverts commit b58bd4c6dfe709646ed9efcbba2a70643f9bc873. + +None of the ACPI IDs introduced with the reverted patch is a valid ACPI +device ID. Any ACPI users of this driver are advised to use PRP0001 and +a devicetree-compatible device identification. + +Fixes: b58bd4c6dfe7 ("hwmon: (lm70) Add support for ACPI") +Cc: Andrej Picej +Signed-off-by: Guenter Roeck +Signed-off-by: Sasha Levin +--- + drivers/hwmon/lm70.c | 26 +------------------------- + 1 file changed, 1 insertion(+), 25 deletions(-) + +diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c +index 40eab3349904..6b884ea00987 100644 +--- a/drivers/hwmon/lm70.c ++++ b/drivers/hwmon/lm70.c +@@ -22,10 +22,10 @@ + #include + #include + #include ++#include + #include + #include + #include +-#include + + #define DRVNAME "lm70" + +@@ -148,29 +148,6 @@ static const struct of_device_id lm70_of_ids[] = { + MODULE_DEVICE_TABLE(of, lm70_of_ids); + #endif + +-#ifdef CONFIG_ACPI +-static const struct acpi_device_id lm70_acpi_ids[] = { +- { +- .id = "LM000070", +- .driver_data = LM70_CHIP_LM70, +- }, +- { +- .id = "TMP00121", +- .driver_data = LM70_CHIP_TMP121, +- }, +- { +- .id = "LM000071", +- .driver_data = LM70_CHIP_LM71, +- }, +- { +- .id = "LM000074", +- .driver_data = LM70_CHIP_LM74, +- }, +- {}, +-}; +-MODULE_DEVICE_TABLE(acpi, lm70_acpi_ids); +-#endif +- + static int lm70_probe(struct spi_device *spi) + { + struct device *hwmon_dev; +@@ -217,7 +194,6 @@ static struct spi_driver lm70_driver = { + .driver = { + .name = "lm70", + .of_match_table = of_match_ptr(lm70_of_ids), +- .acpi_match_table = ACPI_PTR(lm70_acpi_ids), + }, + .id_table = lm70_ids, + .probe = lm70_probe, +-- +2.30.2 + diff --git a/queue-5.10/hwmon-lm70-use-device_get_match_data.patch b/queue-5.10/hwmon-lm70-use-device_get_match_data.patch new file mode 100644 index 00000000000..50588f2acec --- /dev/null +++ b/queue-5.10/hwmon-lm70-use-device_get_match_data.patch @@ -0,0 +1,76 @@ +From c23bce6552ee3eba5041affcab6bccf60c47ee20 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 22 Jan 2021 19:44:27 -0800 +Subject: hwmon: (lm70) Use device_get_match_data() + +From: Stephen Boyd + +[ Upstream commit 6e09d75513d2670b7ab91ab3584fc5bcf2675a75 ] + +Use the more modern API to get the match data out of the of match table. +This saves some code, lines, and nicely avoids referencing the match +table when it is undefined with configurations where CONFIG_OF=n. + +Signed-off-by: Stephen Boyd +Cc: Arnd Bergmann +Cc: Geert Uytterhoeven +Cc: Jean Delvare +Cc: Guenter Roeck +Cc: Rob Herring +Cc: Frank Rowand +Cc: +[robh: rework to use device_get_match_data()] +Signed-off-by: Rob Herring +Signed-off-by: Sasha Levin +--- + drivers/hwmon/lm70.c | 20 +++++--------------- + 1 file changed, 5 insertions(+), 15 deletions(-) + +diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c +index ae2b84263a44..40eab3349904 100644 +--- a/drivers/hwmon/lm70.c ++++ b/drivers/hwmon/lm70.c +@@ -22,9 +22,9 @@ + #include + #include + #include ++#include + #include + #include +-#include + #include + + #define DRVNAME "lm70" +@@ -173,25 +173,15 @@ MODULE_DEVICE_TABLE(acpi, lm70_acpi_ids); + + static int lm70_probe(struct spi_device *spi) + { +- const struct of_device_id *of_match; + struct device *hwmon_dev; + struct lm70 *p_lm70; + int chip; + +- of_match = of_match_device(lm70_of_ids, &spi->dev); +- if (of_match) +- chip = (int)(uintptr_t)of_match->data; +- else { +-#ifdef CONFIG_ACPI +- const struct acpi_device_id *acpi_match; ++ if (dev_fwnode(&spi->dev)) ++ chip = (int)(uintptr_t)device_get_match_data(&spi->dev); ++ else ++ chip = spi_get_device_id(spi)->driver_data; + +- acpi_match = acpi_match_device(lm70_acpi_ids, &spi->dev); +- if (acpi_match) +- chip = (int)(uintptr_t)acpi_match->driver_data; +- else +-#endif +- chip = spi_get_device_id(spi)->driver_data; +- } + + /* signaling is SPI_MODE_0 */ + if (spi->mode & (SPI_CPOL | SPI_CPHA)) +-- +2.30.2 + diff --git a/queue-5.10/hwmon-max31722-remove-non-standard-acpi-device-ids.patch b/queue-5.10/hwmon-max31722-remove-non-standard-acpi-device-ids.patch new file mode 100644 index 00000000000..f5331fd42a9 --- /dev/null +++ b/queue-5.10/hwmon-max31722-remove-non-standard-acpi-device-ids.patch @@ -0,0 +1,58 @@ +From 9ec09b743323b8552a305ebf0c97ec38b60a7a6e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 09:50:25 -0700 +Subject: hwmon: (max31722) Remove non-standard ACPI device IDs + +From: Guenter Roeck + +[ Upstream commit 97387c2f06bcfd79d04a848d35517b32ee6dca7c ] + +Valid Maxim Integrated ACPI device IDs would start with MXIM, +not with MAX1. On top of that, ACPI device IDs reflecting chip names +are almost always invalid. + +Remove the invalid ACPI IDs. + +Fixes: 04e1e70afec6 ("hwmon: (max31722) Add support for MAX31722/MAX31723 temperature sensors") +Signed-off-by: Guenter Roeck +Signed-off-by: Sasha Levin +--- + drivers/hwmon/max31722.c | 9 --------- + 1 file changed, 9 deletions(-) + +diff --git a/drivers/hwmon/max31722.c b/drivers/hwmon/max31722.c +index 062eceb7be0d..613338cbcb17 100644 +--- a/drivers/hwmon/max31722.c ++++ b/drivers/hwmon/max31722.c +@@ -6,7 +6,6 @@ + * Copyright (c) 2016, Intel Corporation. + */ + +-#include + #include + #include + #include +@@ -133,20 +132,12 @@ static const struct spi_device_id max31722_spi_id[] = { + {"max31723", 0}, + {} + }; +- +-static const struct acpi_device_id __maybe_unused max31722_acpi_id[] = { +- {"MAX31722", 0}, +- {"MAX31723", 0}, +- {} +-}; +- + MODULE_DEVICE_TABLE(spi, max31722_spi_id); + + static struct spi_driver max31722_driver = { + .driver = { + .name = "max31722", + .pm = &max31722_pm_ops, +- .acpi_match_table = ACPI_PTR(max31722_acpi_id), + }, + .probe = max31722_probe, + .remove = max31722_remove, +-- +2.30.2 + diff --git a/queue-5.10/hwmon-max31790-fix-fan-speed-reporting-for-fan7.12.patch b/queue-5.10/hwmon-max31790-fix-fan-speed-reporting-for-fan7.12.patch new file mode 100644 index 00000000000..9b4567cf64d --- /dev/null +++ b/queue-5.10/hwmon-max31790-fix-fan-speed-reporting-for-fan7.12.patch @@ -0,0 +1,50 @@ +From c02ea26f318e70e68201767c1720023b2c9a2cbb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 08:40:16 -0700 +Subject: hwmon: (max31790) Fix fan speed reporting for fan7..12 +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Guenter Roeck + +[ Upstream commit cbbf244f0515af3472084f22b6213121b4a63835 ] + +Fans 7..12 do not have their own set of configuration registers. +So far the code ignored that and read beyond the end of the configuration +register range to get the tachometer period. This resulted in more or less +random fan speed values for those fans. + +The datasheet is quite vague when it comes to defining the tachometer +period for fans 7..12. Experiments confirm that the period is the same +for both fans associated with a given set of configuration registers. + +Fixes: 54187ff9d766 ("hwmon: (max31790) Convert to use new hwmon registration API") +Fixes: 195a4b4298a7 ("hwmon: Driver for Maxim MAX31790") +Cc: Jan Kundrát +Reviewed-by: Jan Kundrát +Cc: Václav Kubernát +Reviewed-by: Jan Kundrát +Signed-off-by: Guenter Roeck +Link: https://lore.kernel.org/r/20210526154022.3223012-2-linux@roeck-us.net +Signed-off-by: Sasha Levin +--- + drivers/hwmon/max31790.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c +index 76aa96f5b984..67677c437768 100644 +--- a/drivers/hwmon/max31790.c ++++ b/drivers/hwmon/max31790.c +@@ -171,7 +171,7 @@ static int max31790_read_fan(struct device *dev, u32 attr, int channel, + + switch (attr) { + case hwmon_fan_input: +- sr = get_tach_period(data->fan_dynamics[channel]); ++ sr = get_tach_period(data->fan_dynamics[channel % NR_CHANNEL]); + rpm = RPM_FROM_REG(data->tach[channel], sr); + *val = rpm; + return 0; +-- +2.30.2 + diff --git a/queue-5.10/hwmon-max31790-fix-pwmx_enable-attributes.patch b/queue-5.10/hwmon-max31790-fix-pwmx_enable-attributes.patch new file mode 100644 index 00000000000..fcf7f96318f --- /dev/null +++ b/queue-5.10/hwmon-max31790-fix-pwmx_enable-attributes.patch @@ -0,0 +1,140 @@ +From d0b3e42c046b06f32d62965977f7e42b105a5a49 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 08:40:18 -0700 +Subject: hwmon: (max31790) Fix pwmX_enable attributes +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Guenter Roeck + +[ Upstream commit 148c847c9e5a54b99850617bf9c143af9a344f92 ] + +pwmX_enable supports three possible values: + +0: Fan control disabled. Duty cycle is fixed to 0% +1: Fan control enabled, pwm mode. Duty cycle is determined by + values written into Target Duty Cycle registers. +2: Fan control enabled, rpm mode + Duty cycle is adjusted such that fan speed matches + the values in Target Count registers + +The current code does not do this; instead, it mixes pwm control +configuration with fan speed monitoring configuration. Worse, it +reports that pwm control would be disabled (pwmX_enable==0) when +it is in fact enabled in pwm mode. Part of the problem may be that +the chip sets the "TACH input enable" bit on its own whenever the +mode bit is set to RPM mode, but that doesn't mean that "TACH input +enable" accurately reflects the pwm mode. + +Fix it up and only handle pwm control with the pwmX_enable attributes. +In the documentation, clarify that disabling pwm control (pwmX_enable=0) +sets the pwm duty cycle to 0%. In the code, explain why TACH_INPUT_EN +is set together with RPM_MODE. + +While at it, only update the configuration register if the configuration +has changed, and only update the cached configuration if updating the +chip configuration was successful. + +Cc: Jan Kundrát +Cc: Václav Kubernát +Signed-off-by: Guenter Roeck +Tested-by: Václav Kubernát +Reviewed-by: Jan Kundrát +Link: https://lore.kernel.org/r/20210526154022.3223012-4-linux@roeck-us.net +Signed-off-by: Sasha Levin +--- + Documentation/hwmon/max31790.rst | 2 +- + drivers/hwmon/max31790.c | 41 ++++++++++++++++++++------------ + 2 files changed, 27 insertions(+), 16 deletions(-) + +diff --git a/Documentation/hwmon/max31790.rst b/Documentation/hwmon/max31790.rst +index 54ff0f49e28f..7b097c3b9b90 100644 +--- a/Documentation/hwmon/max31790.rst ++++ b/Documentation/hwmon/max31790.rst +@@ -38,7 +38,7 @@ Sysfs entries + fan[1-12]_input RO fan tachometer speed in RPM + fan[1-12]_fault RO fan experienced fault + fan[1-6]_target RW desired fan speed in RPM +-pwm[1-6]_enable RW regulator mode, 0=disabled, 1=manual mode, 2=rpm mode ++pwm[1-6]_enable RW regulator mode, 0=disabled (duty cycle=0%), 1=manual mode, 2=rpm mode + pwm[1-6] RW read: current pwm duty cycle, + write: target pwm duty cycle (0-255) + ================== === ======================================================= +diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c +index 8ad7a45bfe68..76aa96f5b984 100644 +--- a/drivers/hwmon/max31790.c ++++ b/drivers/hwmon/max31790.c +@@ -27,6 +27,7 @@ + + /* Fan Config register bits */ + #define MAX31790_FAN_CFG_RPM_MODE 0x80 ++#define MAX31790_FAN_CFG_CTRL_MON 0x10 + #define MAX31790_FAN_CFG_TACH_INPUT_EN 0x08 + #define MAX31790_FAN_CFG_TACH_INPUT 0x01 + +@@ -271,12 +272,12 @@ static int max31790_read_pwm(struct device *dev, u32 attr, int channel, + *val = data->pwm[channel] >> 8; + return 0; + case hwmon_pwm_enable: +- if (fan_config & MAX31790_FAN_CFG_RPM_MODE) ++ if (fan_config & MAX31790_FAN_CFG_CTRL_MON) ++ *val = 0; ++ else if (fan_config & MAX31790_FAN_CFG_RPM_MODE) + *val = 2; +- else if (fan_config & MAX31790_FAN_CFG_TACH_INPUT_EN) +- *val = 1; + else +- *val = 0; ++ *val = 1; + return 0; + default: + return -EOPNOTSUPP; +@@ -307,23 +308,33 @@ static int max31790_write_pwm(struct device *dev, u32 attr, int channel, + case hwmon_pwm_enable: + fan_config = data->fan_config[channel]; + if (val == 0) { +- fan_config &= ~(MAX31790_FAN_CFG_TACH_INPUT_EN | +- MAX31790_FAN_CFG_RPM_MODE); ++ fan_config |= MAX31790_FAN_CFG_CTRL_MON; ++ /* ++ * Disable RPM mode; otherwise disabling fan speed ++ * monitoring is not possible. ++ */ ++ fan_config &= ~MAX31790_FAN_CFG_RPM_MODE; + } else if (val == 1) { +- fan_config = (fan_config | +- MAX31790_FAN_CFG_TACH_INPUT_EN) & +- ~MAX31790_FAN_CFG_RPM_MODE; ++ fan_config &= ~(MAX31790_FAN_CFG_CTRL_MON | MAX31790_FAN_CFG_RPM_MODE); + } else if (val == 2) { +- fan_config |= MAX31790_FAN_CFG_TACH_INPUT_EN | +- MAX31790_FAN_CFG_RPM_MODE; ++ fan_config &= ~MAX31790_FAN_CFG_CTRL_MON; ++ /* ++ * The chip sets MAX31790_FAN_CFG_TACH_INPUT_EN on its ++ * own if MAX31790_FAN_CFG_RPM_MODE is set. ++ * Do it here as well to reflect the actual register ++ * value in the cache. ++ */ ++ fan_config |= (MAX31790_FAN_CFG_RPM_MODE | MAX31790_FAN_CFG_TACH_INPUT_EN); + } else { + err = -EINVAL; + break; + } +- data->fan_config[channel] = fan_config; +- err = i2c_smbus_write_byte_data(client, +- MAX31790_REG_FAN_CONFIG(channel), +- fan_config); ++ if (fan_config != data->fan_config[channel]) { ++ err = i2c_smbus_write_byte_data(client, MAX31790_REG_FAN_CONFIG(channel), ++ fan_config); ++ if (!err) ++ data->fan_config[channel] = fan_config; ++ } + break; + default: + err = -EOPNOTSUPP; +-- +2.30.2 + diff --git a/queue-5.10/hwmon-max31790-report-correct-current-pwm-duty-cycle.patch b/queue-5.10/hwmon-max31790-report-correct-current-pwm-duty-cycle.patch new file mode 100644 index 00000000000..f5f2313e1dd --- /dev/null +++ b/queue-5.10/hwmon-max31790-report-correct-current-pwm-duty-cycle.patch @@ -0,0 +1,76 @@ +From 8d3be2538cda20113b4295df7ae6548bcc135cd6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 08:40:17 -0700 +Subject: hwmon: (max31790) Report correct current pwm duty cycles +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Guenter Roeck + +[ Upstream commit 897f6339893b741a5d68ae8e2475df65946041c2 ] + +The MAX31790 has two sets of registers for pwm duty cycles, one to request +a duty cycle and one to read the actual current duty cycle. Both do not +have to be the same. + +When reporting the pwm duty cycle to the user, the actual pwm duty cycle +from pwm duty cycle registers needs to be reported. When setting it, the +pwm target duty cycle needs to be written. Since we don't know the actual +pwm duty cycle after a target pwm duty cycle has been written, set the +valid flag to false to indicate that actual pwm duty cycle should be read +from the chip instead of using cached values. + +Cc: Jan Kundrát +Cc: Václav Kubernát +Signed-off-by: Guenter Roeck +Tested-by: Václav Kubernát +Reviewed-by: Jan Kundrát +Link: https://lore.kernel.org/r/20210526154022.3223012-3-linux@roeck-us.net +Signed-off-by: Sasha Levin +--- + Documentation/hwmon/max31790.rst | 3 ++- + drivers/hwmon/max31790.c | 6 +++--- + 2 files changed, 5 insertions(+), 4 deletions(-) + +diff --git a/Documentation/hwmon/max31790.rst b/Documentation/hwmon/max31790.rst +index f301385d8cef..54ff0f49e28f 100644 +--- a/Documentation/hwmon/max31790.rst ++++ b/Documentation/hwmon/max31790.rst +@@ -39,5 +39,6 @@ fan[1-12]_input RO fan tachometer speed in RPM + fan[1-12]_fault RO fan experienced fault + fan[1-6]_target RW desired fan speed in RPM + pwm[1-6]_enable RW regulator mode, 0=disabled, 1=manual mode, 2=rpm mode +-pwm[1-6] RW fan target duty cycle (0-255) ++pwm[1-6] RW read: current pwm duty cycle, ++ write: target pwm duty cycle (0-255) + ================== === ======================================================= +diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c +index 86e6c71db685..8ad7a45bfe68 100644 +--- a/drivers/hwmon/max31790.c ++++ b/drivers/hwmon/max31790.c +@@ -104,7 +104,7 @@ static struct max31790_data *max31790_update_device(struct device *dev) + data->tach[NR_CHANNEL + i] = rv; + } else { + rv = i2c_smbus_read_word_swapped(client, +- MAX31790_REG_PWMOUT(i)); ++ MAX31790_REG_PWM_DUTY_CYCLE(i)); + if (rv < 0) + goto abort; + data->pwm[i] = rv; +@@ -299,10 +299,10 @@ static int max31790_write_pwm(struct device *dev, u32 attr, int channel, + err = -EINVAL; + break; + } +- data->pwm[channel] = val << 8; ++ data->valid = false; + err = i2c_smbus_write_word_swapped(client, + MAX31790_REG_PWMOUT(channel), +- data->pwm[channel]); ++ val << 8); + break; + case hwmon_pwm_enable: + fan_config = data->fan_config[channel]; +-- +2.30.2 + diff --git a/queue-5.10/hwrng-exynos-fix-runtime-pm-imbalance-on-error.patch b/queue-5.10/hwrng-exynos-fix-runtime-pm-imbalance-on-error.patch new file mode 100644 index 00000000000..a161f82a8b7 --- /dev/null +++ b/queue-5.10/hwrng-exynos-fix-runtime-pm-imbalance-on-error.patch @@ -0,0 +1,49 @@ +From eb9ddd953758907807d8999715f281d33c819c41 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 20:29:14 +0200 +Subject: hwrng: exynos - Fix runtime PM imbalance on error +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Łukasz Stelmach + +[ Upstream commit 0cdbabf8bb7a6147f5adf37dbc251e92a1bbc2c7 ] + +pm_runtime_resume_and_get() wraps around pm_runtime_get_sync() and +decrements the runtime PM usage counter in case the latter function +fails and keeps the counter balanced. + +Signed-off-by: Łukasz Stelmach +Reviewed-by: Krzysztof Kozlowski +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/char/hw_random/exynos-trng.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c +index 8e1fe3f8dd2d..c8db62bc5ff7 100644 +--- a/drivers/char/hw_random/exynos-trng.c ++++ b/drivers/char/hw_random/exynos-trng.c +@@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev) + return PTR_ERR(trng->mem); + + pm_runtime_enable(&pdev->dev); +- ret = pm_runtime_get_sync(&pdev->dev); ++ ret = pm_runtime_resume_and_get(&pdev->dev); + if (ret < 0) { + dev_err(&pdev->dev, "Could not get runtime PM.\n"); + goto err_pm_get; +@@ -165,7 +165,7 @@ err_register: + clk_disable_unprepare(trng->clk); + + err_clock: +- pm_runtime_put_sync(&pdev->dev); ++ pm_runtime_put_noidle(&pdev->dev); + + err_pm_get: + pm_runtime_disable(&pdev->dev); +-- +2.30.2 + diff --git a/queue-5.10/i40e-fix-autoneg-disabling-for-non-10gbaset-links.patch b/queue-5.10/i40e-fix-autoneg-disabling-for-non-10gbaset-links.patch new file mode 100644 index 00000000000..c719b3c8a4c --- /dev/null +++ b/queue-5.10/i40e-fix-autoneg-disabling-for-non-10gbaset-links.patch @@ -0,0 +1,41 @@ +From 0f985b9a3ec6e6e350dbc911d425f1a1c12a3087 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Mar 2021 11:12:54 +0000 +Subject: i40e: Fix autoneg disabling for non-10GBaseT links + +From: Mateusz Palczewski + +[ Upstream commit 9262793e59f0423437166a879a73d056b1fe6f9a ] + +Disabling autonegotiation was allowed only for 10GBaseT PHY. +The condition was changed to check if link media type is BaseT. + +Fixes: 3ce12ee9d8f9 ("i40e: Fix order of checks when enabling/disabling autoneg in ethtool") +Reviewed-by: Aleksandr Loktionov +Reviewed-by: Karen Sornek +Signed-off-by: Dawid Lukwinski +Signed-off-by: Mateusz Palczewski +Tested-by: Tony Brelinski +Signed-off-by: Tony Nguyen +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +index 5d48bc0c3f6c..874073f7f024 100644 +--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c ++++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +@@ -1262,8 +1262,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev, + if (ethtool_link_ksettings_test_link_mode(&safe_ks, + supported, + Autoneg) && +- hw->phy.link_info.phy_type != +- I40E_PHY_TYPE_10GBASE_T) { ++ hw->phy.media_type != I40E_MEDIA_TYPE_BASET) { + netdev_info(netdev, "Autoneg cannot be disabled on this phy\n"); + err = -EINVAL; + goto done; +-- +2.30.2 + diff --git a/queue-5.10/i40e-fix-error-handling-in-i40e_vsi_open.patch b/queue-5.10/i40e-fix-error-handling-in-i40e_vsi_open.patch new file mode 100644 index 00000000000..6bf02349e6c --- /dev/null +++ b/queue-5.10/i40e-fix-error-handling-in-i40e_vsi_open.patch @@ -0,0 +1,38 @@ +From 15d0a1a01f790a727ed863ba61d36ffa1daf4ac2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 28 Feb 2021 19:50:58 +0800 +Subject: i40e: Fix error handling in i40e_vsi_open + +From: Dinghao Liu + +[ Upstream commit 9c04cfcd4aad232e36306cdc5c74cd9fc9148a7e ] + +When vsi->type == I40E_VSI_FDIR, we have caught the return value of +i40e_vsi_request_irq() but without further handling. Check and execute +memory clean on failure just like the other i40e_vsi_request_irq(). + +Fixes: 8a9eb7d3cbcab ("i40e: rework fdir setup and teardown") +Signed-off-by: Dinghao Liu +Tested-by: Tony Brelinski +Signed-off-by: Tony Nguyen +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c +index f0edea7cdbcc..f2ba8ad9b6aa 100644 +--- a/drivers/net/ethernet/intel/i40e/i40e_main.c ++++ b/drivers/net/ethernet/intel/i40e/i40e_main.c +@@ -8347,6 +8347,8 @@ int i40e_vsi_open(struct i40e_vsi *vsi) + dev_driver_string(&pf->pdev->dev), + dev_name(&pf->pdev->dev)); + err = i40e_vsi_request_irq(vsi, int_name); ++ if (err) ++ goto err_setup_rx; + + } else { + err = -EINVAL; +-- +2.30.2 + diff --git a/queue-5.10/i40e-fix-missing-rtnl-locking-when-setting-up-pf-swi.patch b/queue-5.10/i40e-fix-missing-rtnl-locking-when-setting-up-pf-swi.patch new file mode 100644 index 00000000000..c460eefdf45 --- /dev/null +++ b/queue-5.10/i40e-fix-missing-rtnl-locking-when-setting-up-pf-swi.patch @@ -0,0 +1,90 @@ +From 91691a9c36eb9eb2e57d76a04690d50aeb86a7c3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 12:01:41 +0200 +Subject: i40e: Fix missing rtnl locking when setting up pf switch + +From: Jan Sokolowski + +[ Upstream commit 956e759d5f8e0859e86b951a8779c60af633aafd ] + +A recent change that made i40e use new udp_tunnel infrastructure +uses a method that expects to be called under rtnl lock. + +However, not all codepaths do the lock prior to calling +i40e_setup_pf_switch. + +Fix that by adding additional rtnl locking and unlocking. + +Fixes: 40a98cb6f01f ("i40e: convert to new udp_tunnel infrastructure") +Signed-off-by: Jan Sokolowski +Signed-off-by: Mateusz Palczewski +Tested-by: Tony Brelinski +Signed-off-by: Tony Nguyen +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/i40e/i40e_main.c | 15 +++++++++++---- + 1 file changed, 11 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c +index f2ba8ad9b6aa..52e31f712a54 100644 +--- a/drivers/net/ethernet/intel/i40e/i40e_main.c ++++ b/drivers/net/ethernet/intel/i40e/i40e_main.c +@@ -31,7 +31,7 @@ static void i40e_vsi_reinit_locked(struct i40e_vsi *vsi); + static void i40e_handle_reset_warning(struct i40e_pf *pf, bool lock_acquired); + static int i40e_add_vsi(struct i40e_vsi *vsi); + static int i40e_add_veb(struct i40e_veb *veb, struct i40e_vsi *vsi); +-static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit); ++static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit, bool lock_acquired); + static int i40e_setup_misc_vector(struct i40e_pf *pf); + static void i40e_determine_queue_usage(struct i40e_pf *pf); + static int i40e_setup_pf_filter_control(struct i40e_pf *pf); +@@ -10114,7 +10114,7 @@ static void i40e_rebuild(struct i40e_pf *pf, bool reinit, bool lock_acquired) + /* do basic switch setup */ + if (!lock_acquired) + rtnl_lock(); +- ret = i40e_setup_pf_switch(pf, reinit); ++ ret = i40e_setup_pf_switch(pf, reinit, true); + if (ret) + goto end_unlock; + +@@ -14169,10 +14169,11 @@ int i40e_fetch_switch_configuration(struct i40e_pf *pf, bool printconfig) + * i40e_setup_pf_switch - Setup the HW switch on startup or after reset + * @pf: board private structure + * @reinit: if the Main VSI needs to re-initialized. ++ * @lock_acquired: indicates whether or not the lock has been acquired + * + * Returns 0 on success, negative value on failure + **/ +-static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit) ++static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit, bool lock_acquired) + { + u16 flags = 0; + int ret; +@@ -14274,9 +14275,15 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit) + + i40e_ptp_init(pf); + ++ if (!lock_acquired) ++ rtnl_lock(); ++ + /* repopulate tunnel port filters */ + udp_tunnel_nic_reset_ntf(pf->vsi[pf->lan_vsi]->netdev); + ++ if (!lock_acquired) ++ rtnl_unlock(); ++ + return ret; + } + +@@ -15048,7 +15055,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) + pf->flags |= I40E_FLAG_VEB_MODE_ENABLED; + } + #endif +- err = i40e_setup_pf_switch(pf, false); ++ err = i40e_setup_pf_switch(pf, false, false); + if (err) { + dev_info(&pdev->dev, "setup_pf_switch failed: %d\n", err); + goto err_vsis; +-- +2.30.2 + diff --git a/queue-5.10/ia64-mca_drv-fix-incorrect-array-size-calculation.patch b/queue-5.10/ia64-mca_drv-fix-incorrect-array-size-calculation.patch new file mode 100644 index 00000000000..f9ba9679223 --- /dev/null +++ b/queue-5.10/ia64-mca_drv-fix-incorrect-array-size-calculation.patch @@ -0,0 +1,48 @@ +From 7b611ad8f41306e8eca9ab094cb1d3b3fed55eaa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:33:41 -0700 +Subject: ia64: mca_drv: fix incorrect array size calculation + +From: Arnd Bergmann + +[ Upstream commit c5f320ff8a79501bb59338278336ec43acb9d7e2 ] + +gcc points out a mistake in the mca driver that goes back to before the +git history: + +arch/ia64/kernel/mca_drv.c: In function 'init_record_index_pools': +arch/ia64/kernel/mca_drv.c:346:54: error: expression does not compute the number of elements in this array; element typ +e is 'int', not 'size_t' {aka 'long unsigned int'} [-Werror=sizeof-array-div] + 346 | for (i = 1; i < sizeof sal_log_sect_min_sizes/sizeof(size_t); i++) + | ^ + +This is the same as sizeof(size_t), which is two shorter than the actual +array. Use the ARRAY_SIZE() macro to get the correct calculation instead. + +Link: https://lkml.kernel.org/r/20210514214123.875971-1-arnd@kernel.org +Signed-off-by: Arnd Bergmann +Cc: Masahiro Yamada +Cc: Randy Dunlap +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + arch/ia64/kernel/mca_drv.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/ia64/kernel/mca_drv.c b/arch/ia64/kernel/mca_drv.c +index 4d0ab323dee8..2a40268c3d49 100644 +--- a/arch/ia64/kernel/mca_drv.c ++++ b/arch/ia64/kernel/mca_drv.c +@@ -343,7 +343,7 @@ init_record_index_pools(void) + + /* - 2 - */ + sect_min_size = sal_log_sect_min_sizes[0]; +- for (i = 1; i < sizeof sal_log_sect_min_sizes/sizeof(size_t); i++) ++ for (i = 1; i < ARRAY_SIZE(sal_log_sect_min_sizes); i++) + if (sect_min_size > sal_log_sect_min_sizes[i]) + sect_min_size = sal_log_sect_min_sizes[i]; + +-- +2.30.2 + diff --git a/queue-5.10/ibmvnic-free-tx_pool-if-tso_pool-alloc-fails.patch b/queue-5.10/ibmvnic-free-tx_pool-if-tso_pool-alloc-fails.patch new file mode 100644 index 00000000000..3b8c57e2d2b --- /dev/null +++ b/queue-5.10/ibmvnic-free-tx_pool-if-tso_pool-alloc-fails.patch @@ -0,0 +1,44 @@ +From d26d1270a53b41bf665bd61d99c79de3820d6da7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 21:13:15 -0700 +Subject: ibmvnic: free tx_pool if tso_pool alloc fails + +From: Sukadev Bhattiprolu + +[ Upstream commit f6ebca8efa52e4ae770f0325d618e7bcf08ada0c ] + +Free tx_pool and clear it, if allocation of tso_pool fails. + +release_tx_pools() assumes we have both tx and tso_pools if ->tx_pool is +non-NULL. If allocation of tso_pool fails in init_tx_pools(), the assumption +will not be true and we would end up dereferencing ->tx_buff, ->free_map +fields from a NULL pointer. + +Fixes: 3205306c6b8d ("ibmvnic: Update TX pool initialization routine") +Signed-off-by: Sukadev Bhattiprolu +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ibm/ibmvnic.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c +index 458619aa84f4..3134c1988db3 100644 +--- a/drivers/net/ethernet/ibm/ibmvnic.c ++++ b/drivers/net/ethernet/ibm/ibmvnic.c +@@ -751,8 +751,11 @@ static int init_tx_pools(struct net_device *netdev) + + adapter->tso_pool = kcalloc(tx_subcrqs, + sizeof(struct ibmvnic_tx_pool), GFP_KERNEL); +- if (!adapter->tso_pool) ++ if (!adapter->tso_pool) { ++ kfree(adapter->tx_pool); ++ adapter->tx_pool = NULL; + return -1; ++ } + + adapter->num_active_tx_pools = tx_subcrqs; + +-- +2.30.2 + diff --git a/queue-5.10/ibmvnic-set-ltb-buff-to-null-after-freeing.patch b/queue-5.10/ibmvnic-set-ltb-buff-to-null-after-freeing.patch new file mode 100644 index 00000000000..5ae434bcd84 --- /dev/null +++ b/queue-5.10/ibmvnic-set-ltb-buff-to-null-after-freeing.patch @@ -0,0 +1,84 @@ +From 55ba54bfd1fcedd49938251b660d474d70cde18c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 21:13:14 -0700 +Subject: ibmvnic: set ltb->buff to NULL after freeing + +From: Sukadev Bhattiprolu + +[ Upstream commit 552a33729f1a7cc5115d0752064fe9abd6e3e336 ] + +free_long_term_buff() checks ltb->buff to decide whether we have a long +term buffer to free. So set ltb->buff to NULL afer freeing. While here, +also clear ->map_id, fix up some coding style and log an error. + +Fixes: 9c4eaabd1bb39 ("Check CRQ command return codes") +Signed-off-by: Sukadev Bhattiprolu +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ibm/ibmvnic.c | 26 +++++++++++++++----------- + 1 file changed, 15 insertions(+), 11 deletions(-) + +diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c +index 765b38c8b252..458619aa84f4 100644 +--- a/drivers/net/ethernet/ibm/ibmvnic.c ++++ b/drivers/net/ethernet/ibm/ibmvnic.c +@@ -212,12 +212,11 @@ static int alloc_long_term_buff(struct ibmvnic_adapter *adapter, + mutex_lock(&adapter->fw_lock); + adapter->fw_done_rc = 0; + reinit_completion(&adapter->fw_done); +- rc = send_request_map(adapter, ltb->addr, +- ltb->size, ltb->map_id); ++ ++ rc = send_request_map(adapter, ltb->addr, ltb->size, ltb->map_id); + if (rc) { +- dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr); +- mutex_unlock(&adapter->fw_lock); +- return rc; ++ dev_err(dev, "send_request_map failed, rc = %d\n", rc); ++ goto out; + } + + rc = ibmvnic_wait_for_completion(adapter, &adapter->fw_done, 10000); +@@ -225,20 +224,23 @@ static int alloc_long_term_buff(struct ibmvnic_adapter *adapter, + dev_err(dev, + "Long term map request aborted or timed out,rc = %d\n", + rc); +- dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr); +- mutex_unlock(&adapter->fw_lock); +- return rc; ++ goto out; + } + + if (adapter->fw_done_rc) { + dev_err(dev, "Couldn't map long term buffer,rc = %d\n", + adapter->fw_done_rc); ++ rc = -1; ++ goto out; ++ } ++ rc = 0; ++out: ++ if (rc) { + dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr); +- mutex_unlock(&adapter->fw_lock); +- return -1; ++ ltb->buff = NULL; + } + mutex_unlock(&adapter->fw_lock); +- return 0; ++ return rc; + } + + static void free_long_term_buff(struct ibmvnic_adapter *adapter, +@@ -258,6 +260,8 @@ static void free_long_term_buff(struct ibmvnic_adapter *adapter, + adapter->reset_reason != VNIC_RESET_TIMEOUT) + send_request_unmap(adapter, ltb->map_id); + dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr); ++ ltb->buff = NULL; ++ ltb->map_id = 0; + } + + static int reset_long_term_buff(struct ibmvnic_adapter *adapter, +-- +2.30.2 + diff --git a/queue-5.10/ieee802154-hwsim-avoid-possible-crash-in-hwsim_del_e.patch b/queue-5.10/ieee802154-hwsim-avoid-possible-crash-in-hwsim_del_e.patch new file mode 100644 index 00000000000..999d69b8b1f --- /dev/null +++ b/queue-5.10/ieee802154-hwsim-avoid-possible-crash-in-hwsim_del_e.patch @@ -0,0 +1,41 @@ +From 28b00b65d66394244df447115705562ba32f2030 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 11:02:44 -0700 +Subject: ieee802154: hwsim: avoid possible crash in hwsim_del_edge_nl() + +From: Eric Dumazet + +[ Upstream commit 0303b30375dff5351a79cc2c3c87dfa4fda29bed ] + +Both MAC802154_HWSIM_ATTR_RADIO_ID and MAC802154_HWSIM_ATTR_RADIO_EDGE +must be present to avoid a crash. + +Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") +Signed-off-by: Eric Dumazet +Cc: Alexander Aring +Cc: Stefan Schmidt +Reported-by: syzbot +Acked-by: Alexander Aring +Link: https://lore.kernel.org/r/20210621180244.882076-1-eric.dumazet@gmail.com +Signed-off-by: Stefan Schmidt +Signed-off-by: Sasha Levin +--- + drivers/net/ieee802154/mac802154_hwsim.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c +index 6d479df2d9e5..626e1ce817fc 100644 +--- a/drivers/net/ieee802154/mac802154_hwsim.c ++++ b/drivers/net/ieee802154/mac802154_hwsim.c +@@ -480,7 +480,7 @@ static int hwsim_del_edge_nl(struct sk_buff *msg, struct genl_info *info) + struct hwsim_edge *e; + u32 v0, v1; + +- if (!info->attrs[MAC802154_HWSIM_ATTR_RADIO_ID] && ++ if (!info->attrs[MAC802154_HWSIM_ATTR_RADIO_ID] || + !info->attrs[MAC802154_HWSIM_ATTR_RADIO_EDGE]) + return -EINVAL; + +-- +2.30.2 + diff --git a/queue-5.10/ieee802154-hwsim-fix-memory-leak-in-hwsim_add_one.patch b/queue-5.10/ieee802154-hwsim-fix-memory-leak-in-hwsim_add_one.patch new file mode 100644 index 00000000000..7dd07860b3c --- /dev/null +++ b/queue-5.10/ieee802154-hwsim-fix-memory-leak-in-hwsim_add_one.patch @@ -0,0 +1,60 @@ +From f3db6923dbec64a5caa13381b1b12553e5f68bd8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 10:09:01 +0800 +Subject: ieee802154: hwsim: Fix memory leak in hwsim_add_one + +From: Dongliang Mu + +[ Upstream commit 28a5501c3383f0e6643012c187b7c2027ef42aea ] + +No matter from hwsim_remove or hwsim_del_radio_nl, hwsim_del fails to +remove the entry in the edges list. Take the example below, phy0, phy1 +and e0 will be deleted, resulting in e1 not freed and accessed in the +future. + + hwsim_phys + | + ------------------------------ + | | +phy0 (edges) phy1 (edges) + ----> e1 (idx = 1) ----> e0 (idx = 0) + +Fix this by deleting and freeing all the entries in the edges list +between hwsim_edge_unsubscribe_me and list_del(&phy->list). + +Reported-by: syzbot+b80c9959009a9325cdff@syzkaller.appspotmail.com +Fixes: 1c9f4a3fce77 ("ieee802154: hwsim: fix rcu handling") +Signed-off-by: Dongliang Mu +Acked-by: Alexander Aring +Link: https://lore.kernel.org/r/20210616020901.2759466-1-mudongliangabcd@gmail.com +Signed-off-by: Stefan Schmidt +Signed-off-by: Sasha Levin +--- + drivers/net/ieee802154/mac802154_hwsim.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c +index 7a168170224a..6d479df2d9e5 100644 +--- a/drivers/net/ieee802154/mac802154_hwsim.c ++++ b/drivers/net/ieee802154/mac802154_hwsim.c +@@ -824,12 +824,17 @@ err_pib: + static void hwsim_del(struct hwsim_phy *phy) + { + struct hwsim_pib *pib; ++ struct hwsim_edge *e; + + hwsim_edge_unsubscribe_me(phy); + + list_del(&phy->list); + + rcu_read_lock(); ++ list_for_each_entry_rcu(e, &phy->edges, list) { ++ list_del_rcu(&e->list); ++ hwsim_free_edge(e); ++ } + pib = rcu_dereference(phy->pib); + rcu_read_unlock(); + +-- +2.30.2 + diff --git a/queue-5.10/ieee802154-hwsim-fix-possible-memory-leak-in-hwsim_s.patch b/queue-5.10/ieee802154-hwsim-fix-possible-memory-leak-in-hwsim_s.patch new file mode 100644 index 00000000000..7656cce9d42 --- /dev/null +++ b/queue-5.10/ieee802154-hwsim-fix-possible-memory-leak-in-hwsim_s.patch @@ -0,0 +1,49 @@ +From 0879e2b6de0b1cd0eff4a59fd62c267a25cb439c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 09:58:12 +0800 +Subject: ieee802154: hwsim: Fix possible memory leak in + hwsim_subscribe_all_others + +From: Dongliang Mu + +[ Upstream commit ab372c2293f5d0b279f31c8d768566ea37602dc9 ] + +In hwsim_subscribe_all_others, the error handling code performs +incorrectly if the second hwsim_alloc_edge fails. When this issue occurs, +it goes to sub_fail, without cleaning the edges allocated before. + +Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") +Signed-off-by: Dongliang Mu +Acked-by: Alexander Aring +Link: https://lore.kernel.org/r/20210611015812.1626999-1-mudongliangabcd@gmail.com +Signed-off-by: Stefan Schmidt +Signed-off-by: Sasha Levin +--- + drivers/net/ieee802154/mac802154_hwsim.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c +index c0bf7d78276e..7a168170224a 100644 +--- a/drivers/net/ieee802154/mac802154_hwsim.c ++++ b/drivers/net/ieee802154/mac802154_hwsim.c +@@ -715,6 +715,8 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy) + + return 0; + ++sub_fail: ++ hwsim_edge_unsubscribe_me(phy); + me_fail: + rcu_read_lock(); + list_for_each_entry_rcu(e, &phy->edges, list) { +@@ -722,8 +724,6 @@ me_fail: + hwsim_free_edge(e); + } + rcu_read_unlock(); +-sub_fail: +- hwsim_edge_unsubscribe_me(phy); + return -ENOMEM; + } + +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-bma180-fix-buffer-alignment-in-iio_push_to.patch b/queue-5.10/iio-accel-bma180-fix-buffer-alignment-in-iio_push_to.patch new file mode 100644 index 00000000000..48137bff71e --- /dev/null +++ b/queue-5.10/iio-accel-bma180-fix-buffer-alignment-in-iio_push_to.patch @@ -0,0 +1,60 @@ +From 764a089e59a9c0ca8b58dfa2788185b65e97afa7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:03 +0100 +Subject: iio: accel: bma180: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit fc36da3131a747a9367a05caf06de19be1bcc972 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: b9a6a237ffc9 ("iio:bma180: Drop _update_scan_mode()") +Signed-off-by: Jonathan Cameron +Cc: Peter Meerwald +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-2-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/bma180.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c +index 2309bdd00a31..da56488182d0 100644 +--- a/drivers/iio/accel/bma180.c ++++ b/drivers/iio/accel/bma180.c +@@ -164,7 +164,11 @@ struct bma180_data { + int scale; + int bw; + bool pmode; +- u8 buff[16]; /* 3x 16-bit + 8-bit + padding + timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s16 chan[4]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + enum bma180_chan { +@@ -943,12 +947,12 @@ static irqreturn_t bma180_trigger_handler(int irq, void *p) + mutex_unlock(&data->mutex); + goto err; + } +- ((s16 *)data->buff)[i++] = ret; ++ data->scan.chan[i++] = ret; + } + + mutex_unlock(&data->mutex); + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buff, time_ns); ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, time_ns); + err: + iio_trigger_notify_done(indio_dev->trig); + +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-bma220-fix-buffer-alignment-in-iio_push_to.patch b/queue-5.10/iio-accel-bma220-fix-buffer-alignment-in-iio_push_to.patch new file mode 100644 index 00000000000..32717f1ae3b --- /dev/null +++ b/queue-5.10/iio-accel-bma220-fix-buffer-alignment-in-iio_push_to.patch @@ -0,0 +1,59 @@ +From e2c0949755be99af539770782193cabadd98144f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:04 +0100 +Subject: iio: accel: bma220: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 151dbf0078da98206817ee0b87d499035479ef11 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: 194dc4c71413 ("iio: accel: Add triggered buffer support for BMA220") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-3-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/bma220_spi.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c +index 3c9b0c6954e6..e8a9db1a82ad 100644 +--- a/drivers/iio/accel/bma220_spi.c ++++ b/drivers/iio/accel/bma220_spi.c +@@ -63,7 +63,11 @@ static const int bma220_scale_table[][2] = { + struct bma220_data { + struct spi_device *spi_device; + struct mutex lock; +- s8 buffer[16]; /* 3x8-bit channels + 5x8 padding + 8x8 timestamp */ ++ struct { ++ s8 chans[3]; ++ /* Ensure timestamp is naturally aligned. */ ++ s64 timestamp __aligned(8); ++ } scan; + u8 tx_buf[2] ____cacheline_aligned; + }; + +@@ -94,12 +98,12 @@ static irqreturn_t bma220_trigger_handler(int irq, void *p) + + mutex_lock(&data->lock); + data->tx_buf[0] = BMA220_REG_ACCEL_X | BMA220_READ_MASK; +- ret = spi_write_then_read(spi, data->tx_buf, 1, data->buffer, ++ ret = spi_write_then_read(spi, data->tx_buf, 1, &data->scan.chans, + ARRAY_SIZE(bma220_channels) - 1); + if (ret < 0) + goto err; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + err: + mutex_unlock(&data->lock); +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-hid-fix-buffer-alignment-in-iio_push_to_bu.patch b/queue-5.10/iio-accel-hid-fix-buffer-alignment-in-iio_push_to_bu.patch new file mode 100644 index 00000000000..0ac3eede8b3 --- /dev/null +++ b/queue-5.10/iio-accel-hid-fix-buffer-alignment-in-iio_push_to_bu.patch @@ -0,0 +1,68 @@ +From 331eb64cc08887d4cad15967916fdf821b8cfe79 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:05 +0100 +Subject: iio: accel: hid: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit c6559bf796ccdb3a0c79db846af96c8f7046880b ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. +Note this matches what was done in all the other hid sensor drivers. +This one was missed previously due to an extra level of indirection. + +Found during an audit of all calls of this function. + +Fixes: a96cd0f901ee ("iio: accel: hid-sensor-accel-3d: Add timestamp") +Signed-off-by: Jonathan Cameron +Cc: Srinivas Pandruvada +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-4-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/hid-sensor-accel-3d.c | 13 ++++++++----- + 1 file changed, 8 insertions(+), 5 deletions(-) + +diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c +index 4c5e594024f8..f05840d17fb7 100644 +--- a/drivers/iio/accel/hid-sensor-accel-3d.c ++++ b/drivers/iio/accel/hid-sensor-accel-3d.c +@@ -27,8 +27,11 @@ struct accel_3d_state { + struct hid_sensor_hub_callbacks callbacks; + struct hid_sensor_common common_attributes; + struct hid_sensor_hub_attribute_info accel[ACCEL_3D_CHANNEL_MAX]; +- /* Reserve for 3 channels + padding + timestamp */ +- u32 accel_val[ACCEL_3D_CHANNEL_MAX + 3]; ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u32 accel_val[3]; ++ s64 timestamp __aligned(8); ++ } scan; + int scale_pre_decml; + int scale_post_decml; + int scale_precision; +@@ -239,8 +242,8 @@ static int accel_3d_proc_event(struct hid_sensor_hub_device *hsdev, + accel_state->timestamp = iio_get_time_ns(indio_dev); + + hid_sensor_push_data(indio_dev, +- accel_state->accel_val, +- sizeof(accel_state->accel_val), ++ &accel_state->scan, ++ sizeof(accel_state->scan), + accel_state->timestamp); + + accel_state->timestamp = 0; +@@ -265,7 +268,7 @@ static int accel_3d_capture_sample(struct hid_sensor_hub_device *hsdev, + case HID_USAGE_SENSOR_ACCEL_Y_AXIS: + case HID_USAGE_SENSOR_ACCEL_Z_AXIS: + offset = usage_id - HID_USAGE_SENSOR_ACCEL_X_AXIS; +- accel_state->accel_val[CHANNEL_SCAN_INDEX_X + offset] = ++ accel_state->scan.accel_val[CHANNEL_SCAN_INDEX_X + offset] = + *(u32 *)raw_data; + ret = 0; + break; +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-kxcjk-1013-fix-buffer-alignment-in-iio_pus.patch b/queue-5.10/iio-accel-kxcjk-1013-fix-buffer-alignment-in-iio_pus.patch new file mode 100644 index 00000000000..745d6500fd9 --- /dev/null +++ b/queue-5.10/iio-accel-kxcjk-1013-fix-buffer-alignment-in-iio_pus.patch @@ -0,0 +1,87 @@ +From 71d2e6bdab1f84ea2151f88d2f09e8827d21709c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:06 +0100 +Subject: iio: accel: kxcjk-1013: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 3ab3aa2e7bd57497f9a7c6275c00dce237d2c9ba ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: 1a4fbf6a9286 ("iio: accel: kxcjk1013 3-axis accelerometer driver") +Signed-off-by: Jonathan Cameron +Cc: Srinivas Pandruvada +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-5-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/kxcjk-1013.c | 24 ++++++++++++++---------- + 1 file changed, 14 insertions(+), 10 deletions(-) + +diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c +index 560a3373ff20..c99e90469a24 100644 +--- a/drivers/iio/accel/kxcjk-1013.c ++++ b/drivers/iio/accel/kxcjk-1013.c +@@ -132,13 +132,24 @@ enum kx_acpi_type { + ACPI_KIOX010A, + }; + ++enum kxcjk1013_axis { ++ AXIS_X, ++ AXIS_Y, ++ AXIS_Z, ++ AXIS_MAX ++}; ++ + struct kxcjk1013_data { + struct i2c_client *client; + struct iio_trigger *dready_trig; + struct iio_trigger *motion_trig; + struct iio_mount_matrix orientation; + struct mutex mutex; +- s16 buffer[8]; ++ /* Ensure timestamp naturally aligned */ ++ struct { ++ s16 chans[AXIS_MAX]; ++ s64 timestamp __aligned(8); ++ } scan; + u8 odr_bits; + u8 range; + int wake_thres; +@@ -152,13 +163,6 @@ struct kxcjk1013_data { + enum kx_acpi_type acpi_type; + }; + +-enum kxcjk1013_axis { +- AXIS_X, +- AXIS_Y, +- AXIS_Z, +- AXIS_MAX, +-}; +- + enum kxcjk1013_mode { + STANDBY, + OPERATION, +@@ -1092,12 +1096,12 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p) + ret = i2c_smbus_read_i2c_block_data_or_emulated(data->client, + KXCJK1013_REG_XOUT_L, + AXIS_MAX * 2, +- (u8 *)data->buffer); ++ (u8 *)data->scan.chans); + mutex_unlock(&data->mutex); + if (ret < 0) + goto err; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + data->timestamp); + err: + iio_trigger_notify_done(indio_dev->trig); +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-mxc4005-fix-overread-of-data-and-alignment.patch b/queue-5.10/iio-accel-mxc4005-fix-overread-of-data-and-alignment.patch new file mode 100644 index 00000000000..2d7b948521f --- /dev/null +++ b/queue-5.10/iio-accel-mxc4005-fix-overread-of-data-and-alignment.patch @@ -0,0 +1,63 @@ +From 07f51365b6862f0ef73f65a17dbd00327d66c0bc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:07 +0100 +Subject: iio: accel: mxc4005: Fix overread of data and alignment issue. + +From: Jonathan Cameron + +[ Upstream commit f65802284a3a337510d7f8f916c97d66c74f2e71 ] + +The bulk read size is based on the size of an array that also has +space for the timestamp alongside the channels. +Fix that and also fix alignment of the buffer passed +to iio_push_to_buffers_with_timestamp. + +Found during an audit of all calls to this function. + +Fixes: 1ce0eda0f757 ("iio: mxc4005: add triggered buffer mode for mxc4005") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-6-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/mxc4005.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c +index f877263dc6ef..5a2b0ffbb145 100644 +--- a/drivers/iio/accel/mxc4005.c ++++ b/drivers/iio/accel/mxc4005.c +@@ -56,7 +56,11 @@ struct mxc4005_data { + struct mutex mutex; + struct regmap *regmap; + struct iio_trigger *dready_trig; +- __be16 buffer[8]; ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ __be16 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + bool trigger_enabled; + }; + +@@ -135,7 +139,7 @@ static int mxc4005_read_xyz(struct mxc4005_data *data) + int ret; + + ret = regmap_bulk_read(data->regmap, MXC4005_REG_XOUT_UPPER, +- data->buffer, sizeof(data->buffer)); ++ data->scan.chans, sizeof(data->scan.chans)); + if (ret < 0) { + dev_err(data->dev, "failed to read axes\n"); + return ret; +@@ -301,7 +305,7 @@ static irqreturn_t mxc4005_trigger_handler(int irq, void *private) + if (ret < 0) + goto err; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + + err: +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-stk8312-fix-buffer-alignment-in-iio_push_t.patch b/queue-5.10/iio-accel-stk8312-fix-buffer-alignment-in-iio_push_t.patch new file mode 100644 index 00000000000..e3d878e4334 --- /dev/null +++ b/queue-5.10/iio-accel-stk8312-fix-buffer-alignment-in-iio_push_t.patch @@ -0,0 +1,68 @@ +From bf5595b3c273b1ccf26d6c228a9de51cd95ef0be Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:08 +0100 +Subject: iio: accel: stk8312: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit f40a71ffec808e7e51848f63f0c0d3c32d65081b ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: 95c12bba51c3 ("iio: accel: Add buffer mode for Sensortek STK8312") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-7-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/stk8312.c | 12 ++++++++---- + 1 file changed, 8 insertions(+), 4 deletions(-) + +diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c +index 3b59887a8581..7d24801e8aa7 100644 +--- a/drivers/iio/accel/stk8312.c ++++ b/drivers/iio/accel/stk8312.c +@@ -103,7 +103,11 @@ struct stk8312_data { + u8 mode; + struct iio_trigger *dready_trig; + bool dready_trigger_on; +- s8 buffer[16]; /* 3x8-bit channels + 5x8 padding + 64-bit timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s8 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + static IIO_CONST_ATTR(in_accel_scale_available, STK8312_SCALE_AVAIL); +@@ -438,7 +442,7 @@ static irqreturn_t stk8312_trigger_handler(int irq, void *p) + ret = i2c_smbus_read_i2c_block_data(data->client, + STK8312_REG_XOUT, + STK8312_ALL_CHANNEL_SIZE, +- data->buffer); ++ data->scan.chans); + if (ret < STK8312_ALL_CHANNEL_SIZE) { + dev_err(&data->client->dev, "register read failed\n"); + mutex_unlock(&data->lock); +@@ -452,12 +456,12 @@ static irqreturn_t stk8312_trigger_handler(int irq, void *p) + mutex_unlock(&data->lock); + goto err; + } +- data->buffer[i++] = ret; ++ data->scan.chans[i++] = ret; + } + } + mutex_unlock(&data->lock); + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + err: + iio_trigger_notify_done(indio_dev->trig); +-- +2.30.2 + diff --git a/queue-5.10/iio-accel-stk8ba50-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-accel-stk8ba50-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..3336d71736c --- /dev/null +++ b/queue-5.10/iio-accel-stk8ba50-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,71 @@ +From 453ee324eb4485117e192f65e62eafda4dcb57cf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:09 +0100 +Subject: iio: accel: stk8ba50: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 334883894bc1e145a1e0f5de1b0d1b6a1133f0e6 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: db6a19b8251f ("iio: accel: Add trigger support for STK8BA50") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-8-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/accel/stk8ba50.c | 17 ++++++++--------- + 1 file changed, 8 insertions(+), 9 deletions(-) + +diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c +index 3ead378b02c9..e8087d7ee49f 100644 +--- a/drivers/iio/accel/stk8ba50.c ++++ b/drivers/iio/accel/stk8ba50.c +@@ -91,12 +91,11 @@ struct stk8ba50_data { + u8 sample_rate_idx; + struct iio_trigger *dready_trig; + bool dready_trigger_on; +- /* +- * 3 x 16-bit channels (10-bit data, 6-bit padding) + +- * 1 x 16 padding + +- * 4 x 16 64-bit timestamp +- */ +- s16 buffer[8]; ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s16 chans[3]; ++ s64 timetamp __aligned(8); ++ } scan; + }; + + #define STK8BA50_ACCEL_CHANNEL(index, reg, axis) { \ +@@ -324,7 +323,7 @@ static irqreturn_t stk8ba50_trigger_handler(int irq, void *p) + ret = i2c_smbus_read_i2c_block_data(data->client, + STK8BA50_REG_XOUT, + STK8BA50_ALL_CHANNEL_SIZE, +- (u8 *)data->buffer); ++ (u8 *)data->scan.chans); + if (ret < STK8BA50_ALL_CHANNEL_SIZE) { + dev_err(&data->client->dev, "register read failed\n"); + goto err; +@@ -337,10 +336,10 @@ static irqreturn_t stk8ba50_trigger_handler(int irq, void *p) + if (ret < 0) + goto err; + +- data->buffer[i++] = ret; ++ data->scan.chans[i++] = ret; + } + } +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + err: + mutex_unlock(&data->lock); +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-at91-sama5d2-fix-buffer-alignment-in-iio_pus.patch b/queue-5.10/iio-adc-at91-sama5d2-fix-buffer-alignment-in-iio_pus.patch new file mode 100644 index 00000000000..9d9688960bc --- /dev/null +++ b/queue-5.10/iio-adc-at91-sama5d2-fix-buffer-alignment-in-iio_pus.patch @@ -0,0 +1,45 @@ +From 61901567862791597c76b14425e736d763d8a9dc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:54 +0100 +Subject: iio: adc: at91-sama5d2: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit 8f884758966259fa8c50c137ac6d4ce9bb7859db ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support") +Signed-off-by: Jonathan Cameron +Cc: Eugen Hristev +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-2-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/at91-sama5d2_adc.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c +index b917a4714a9c..b8139c435a4b 100644 +--- a/drivers/iio/adc/at91-sama5d2_adc.c ++++ b/drivers/iio/adc/at91-sama5d2_adc.c +@@ -403,7 +403,8 @@ struct at91_adc_state { + struct at91_adc_dma dma_st; + struct at91_adc_touch touch_st; + struct iio_dev *indio_dev; +- u16 buffer[AT91_BUFFER_MAX_HWORDS]; ++ /* Ensure naturally aligned timestamp */ ++ u16 buffer[AT91_BUFFER_MAX_HWORDS] __aligned(8); + /* + * lock to prevent concurrent 'single conversion' requests through + * sysfs. +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-hx711-fix-buffer-alignment-in-iio_push_to_bu.patch b/queue-5.10/iio-adc-hx711-fix-buffer-alignment-in-iio_push_to_bu.patch new file mode 100644 index 00000000000..e4b955e8fc9 --- /dev/null +++ b/queue-5.10/iio-adc-hx711-fix-buffer-alignment-in-iio_push_to_bu.patch @@ -0,0 +1,47 @@ +From 76552d634e95a870d0d1474d2df70b20535a5578 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:55 +0100 +Subject: iio: adc: hx711: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit afe2a789fbf7acd1a05407fc7839cc08d23825e3 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: d3bf60450d47 ("iio: hx711: add triggered buffer support") +Signed-off-by: Jonathan Cameron +Cc: Andreas Klinger +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-3-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/hx711.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c +index 6a173531d355..f7ee856a6b8b 100644 +--- a/drivers/iio/adc/hx711.c ++++ b/drivers/iio/adc/hx711.c +@@ -86,9 +86,9 @@ struct hx711_data { + struct mutex lock; + /* + * triggered buffer +- * 2x32-bit channel + 64-bit timestamp ++ * 2x32-bit channel + 64-bit naturally aligned timestamp + */ +- u32 buffer[4]; ++ u32 buffer[4] __aligned(8); + /* + * delay after a rising edge on SCK until the data is ready DOUT + * this is dependent on the hx711 where the datasheet tells a +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-mxs-lradc-fix-buffer-alignment-in-iio_push_t.patch b/queue-5.10/iio-adc-mxs-lradc-fix-buffer-alignment-in-iio_push_t.patch new file mode 100644 index 00000000000..f45b2309163 --- /dev/null +++ b/queue-5.10/iio-adc-mxs-lradc-fix-buffer-alignment-in-iio_push_t.patch @@ -0,0 +1,47 @@ +From bd694fdd290779dca231f40f7bb951aa9ccedc47 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:56 +0100 +Subject: iio: adc: mxs-lradc: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit 6a6be221b8bd561b053f0701ec752a5ed9007f69 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. +Add a comment on why the buffer is the size it is as not immediately +obvious. + +Found during an audit of all calls of this function. + +Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver") +Signed-off-by: Jonathan Cameron +Cc: Andreas Klinger +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-4-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/mxs-lradc-adc.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c +index 30e29f44ebd2..c480cb489c1a 100644 +--- a/drivers/iio/adc/mxs-lradc-adc.c ++++ b/drivers/iio/adc/mxs-lradc-adc.c +@@ -115,7 +115,8 @@ struct mxs_lradc_adc { + struct device *dev; + + void __iomem *base; +- u32 buffer[10]; ++ /* Maximum of 8 channels + 8 byte ts */ ++ u32 buffer[10] __aligned(8); + struct iio_trigger *trig; + struct completion completion; + spinlock_t lock; +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-ti-ads1015-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-adc-ti-ads1015-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..f2920c869a2 --- /dev/null +++ b/queue-5.10/iio-adc-ti-ads1015-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,63 @@ +From cf6c1735a063dcd6514010f88a3b29d40ab04b23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:10 +0100 +Subject: iio: adc: ti-ads1015: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit d85d71dd1ab67eaa7351f69fec512d8f09d164e1 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of this function. + +Fixes: ecc24e72f437 ("iio: adc: Add TI ADS1015 ADC driver support") +Signed-off-by: Jonathan Cameron +Cc: Daniel Baluta +Cc: Andy Shevchenko +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-9-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/ti-ads1015.c | 12 ++++++++---- + 1 file changed, 8 insertions(+), 4 deletions(-) + +diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c +index 9fef39bcf997..5b828428be77 100644 +--- a/drivers/iio/adc/ti-ads1015.c ++++ b/drivers/iio/adc/ti-ads1015.c +@@ -395,10 +395,14 @@ static irqreturn_t ads1015_trigger_handler(int irq, void *p) + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_dev; + struct ads1015_data *data = iio_priv(indio_dev); +- s16 buf[8]; /* 1x s16 ADC val + 3x s16 padding + 4x s16 timestamp */ ++ /* Ensure natural alignment of timestamp */ ++ struct { ++ s16 chan; ++ s64 timestamp __aligned(8); ++ } scan; + int chan, ret, res; + +- memset(buf, 0, sizeof(buf)); ++ memset(&scan, 0, sizeof(scan)); + + mutex_lock(&data->lock); + chan = find_first_bit(indio_dev->active_scan_mask, +@@ -409,10 +413,10 @@ static irqreturn_t ads1015_trigger_handler(int irq, void *p) + goto err; + } + +- buf[0] = res; ++ scan.chan = res; + mutex_unlock(&data->lock); + +- iio_push_to_buffers_with_timestamp(indio_dev, buf, ++ iio_push_to_buffers_with_timestamp(indio_dev, &scan, + iio_get_time_ns(indio_dev)); + + err: +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-ti-ads8688-fix-alignment-of-buffer-in-iio_pu.patch b/queue-5.10/iio-adc-ti-ads8688-fix-alignment-of-buffer-in-iio_pu.patch new file mode 100644 index 00000000000..ee3e15315e8 --- /dev/null +++ b/queue-5.10/iio-adc-ti-ads8688-fix-alignment-of-buffer-in-iio_pu.patch @@ -0,0 +1,43 @@ +From 4512fff58e9048cb542b607c683c8d5a0191662c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:57 +0100 +Subject: iio: adc: ti-ads8688: Fix alignment of buffer in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit 61fa5dfa5f52806f5ce37a0ba5712c271eb22f98 ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Fixes: f214ff521fb1 ("iio: ti-ads8688: Update buffer allocation for timestamps") +Signed-off-by: Jonathan Cameron +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-5-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/ti-ads8688.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c +index 16bcb37eebb7..79c803537dc4 100644 +--- a/drivers/iio/adc/ti-ads8688.c ++++ b/drivers/iio/adc/ti-ads8688.c +@@ -383,7 +383,8 @@ static irqreturn_t ads8688_trigger_handler(int irq, void *p) + { + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_dev; +- u16 buffer[ADS8688_MAX_CHANNELS + sizeof(s64)/sizeof(u16)]; ++ /* Ensure naturally aligned timestamp */ ++ u16 buffer[ADS8688_MAX_CHANNELS + sizeof(s64)/sizeof(u16)] __aligned(8); + int i, j = 0; + + for (i = 0; i < indio_dev->masklength; i++) { +-- +2.30.2 + diff --git a/queue-5.10/iio-adc-vf610-fix-buffer-alignment-in-iio_push_to_bu.patch b/queue-5.10/iio-adc-vf610-fix-buffer-alignment-in-iio_push_to_bu.patch new file mode 100644 index 00000000000..13acf9546d5 --- /dev/null +++ b/queue-5.10/iio-adc-vf610-fix-buffer-alignment-in-iio_push_to_bu.patch @@ -0,0 +1,59 @@ +From e9c99b5cb568745c73b63480fe85ff2c1883900e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:11 +0100 +Subject: iio: adc: vf610: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 7765dfaa22ea08abf0c175e7553826ba2a939632 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 0010d6b44406 ("iio: adc: vf610: Add IIO buffer support for Vybrid ADC") +Signed-off-by: Jonathan Cameron +Cc: Stefan-Gabriel Mirea +Cc: Sanchayan Maity +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-10-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/adc/vf610_adc.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c +index 1d794cf3e3f1..fd57fc43e8e5 100644 +--- a/drivers/iio/adc/vf610_adc.c ++++ b/drivers/iio/adc/vf610_adc.c +@@ -167,7 +167,11 @@ struct vf610_adc { + u32 sample_freq_avail[5]; + + struct completion completion; +- u16 buffer[8]; ++ /* Ensure the timestamp is naturally aligned */ ++ struct { ++ u16 chan; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + static const u32 vf610_hw_avgs[] = { 1, 4, 8, 16, 32 }; +@@ -579,9 +583,9 @@ static irqreturn_t vf610_adc_isr(int irq, void *dev_id) + if (coco & VF610_ADC_HS_COCO0) { + info->value = vf610_adc_read_data(info); + if (iio_buffer_enabled(indio_dev)) { +- info->buffer[0] = info->value; ++ info->scan.chan = info->value; + iio_push_to_buffers_with_timestamp(indio_dev, +- info->buffer, ++ &info->scan, + iio_get_time_ns(indio_dev)); + iio_trigger_notify_done(indio_dev->trig); + } else +-- +2.30.2 + diff --git a/queue-5.10/iio-adis16400-do-not-return-ints-in-irq-handlers.patch b/queue-5.10/iio-adis16400-do-not-return-ints-in-irq-handlers.patch new file mode 100644 index 00000000000..96242de8a08 --- /dev/null +++ b/queue-5.10/iio-adis16400-do-not-return-ints-in-irq-handlers.patch @@ -0,0 +1,42 @@ +From fba2c30b07b615ec7beda339ae4c0a35f4bff4d2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 22 Apr 2021 12:19:04 +0200 +Subject: iio: adis16400: do not return ints in irq handlers + +From: Nuno Sa + +[ Upstream commit ab3df79782e7d8a27a58576c9b4e8c6c4879ad79 ] + +On an IRQ handler we should not return normal error codes as 'irqreturn_t' +is expected. + +Not necessary to apply to stable as the original check cannot fail and +as such the bug cannot actually occur. + +Fixes: 5eda3550a3cc1 ("staging:iio:adis16400: Preallocate transfer message") +Reviewed-by: Alexandru Ardelean +Signed-off-by: Nuno Sa +Link: https://lore.kernel.org/r/20210422101911.135630-3-nuno.sa@analog.com +Signed-off-by: Jonathan Cameron +Signed-off-by: Sasha Levin +--- + drivers/iio/imu/adis16400.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c +index 785a4ce606d8..4aff16466da0 100644 +--- a/drivers/iio/imu/adis16400.c ++++ b/drivers/iio/imu/adis16400.c +@@ -647,9 +647,6 @@ static irqreturn_t adis16400_trigger_handler(int irq, void *p) + void *buffer; + int ret; + +- if (!adis->buffer) +- return -ENOMEM; +- + if (!(st->variant->flags & ADIS16400_NO_BURST) && + st->adis.spi->max_speed_hz > ADIS16400_SPI_BURST) { + st->adis.spi->max_speed_hz = ADIS16400_SPI_BURST; +-- +2.30.2 + diff --git a/queue-5.10/iio-adis16475-do-not-return-ints-in-irq-handlers.patch b/queue-5.10/iio-adis16475-do-not-return-ints-in-irq-handlers.patch new file mode 100644 index 00000000000..c45fc4d6f13 --- /dev/null +++ b/queue-5.10/iio-adis16475-do-not-return-ints-in-irq-handlers.patch @@ -0,0 +1,43 @@ +From abdf9cb110e39c1d27ff0775d481c01882c2ab6e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 27 Apr 2021 10:54:49 +0200 +Subject: iio: adis16475: do not return ints in irq handlers + +From: Nuno Sa + +[ Upstream commit 00a72db718fa198da3946286dcad222399ccd4fb ] + +On an IRQ handler we should not return normal error codes as 'irqreturn_t' +is expected. + +This is done by jumping to the 'check_burst32' label where we return +'IRQ_HANDLED'. Note that it is fine to do the burst32 check in this +error path. If we have proper settings to apply burst32, we might just +do the setup now so that the next sample already uses it. + +Fixes: fff7352bf7a3c ("iio: imu: Add support for adis16475") +Reviewed-by: Alexandru Ardelean +Signed-off-by: Nuno Sa +Link: https://lore.kernel.org/r/20210427085454.30616-2-nuno.sa@analog.com +Signed-off-by: Jonathan Cameron +Signed-off-by: Sasha Levin +--- + drivers/iio/imu/adis16475.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c +index 197d48240991..3c4e4deb8760 100644 +--- a/drivers/iio/imu/adis16475.c ++++ b/drivers/iio/imu/adis16475.c +@@ -990,7 +990,7 @@ static irqreturn_t adis16475_trigger_handler(int irq, void *p) + + ret = spi_sync(adis->spi, &adis->msg); + if (ret) +- return ret; ++ goto check_burst32; + + adis->spi->max_speed_hz = cached_spi_speed_hz; + buffer = adis->buffer; +-- +2.30.2 + diff --git a/queue-5.10/iio-adis_buffer-do-not-return-ints-in-irq-handlers.patch b/queue-5.10/iio-adis_buffer-do-not-return-ints-in-irq-handlers.patch new file mode 100644 index 00000000000..4b065e805cc --- /dev/null +++ b/queue-5.10/iio-adis_buffer-do-not-return-ints-in-irq-handlers.patch @@ -0,0 +1,42 @@ +From 6b27cc303b437e8090663010d840542a73dd844d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 22 Apr 2021 12:19:03 +0200 +Subject: iio: adis_buffer: do not return ints in irq handlers + +From: Nuno Sa + +[ Upstream commit d877539ad8e8fdde9af69887055fec6402be1a13 ] + +On an IRQ handler we should not return normal error codes as 'irqreturn_t' +is expected. + +Not necessarily stable material as the old check cannot fail, so it's a bug +we can not hit. + +Fixes: ccd2b52f4ac69 ("staging:iio: Add common ADIS library") +Reviewed-by: Alexandru Ardelean +Signed-off-by: Nuno Sa +Link: https://lore.kernel.org/r/20210422101911.135630-2-nuno.sa@analog.com +Signed-off-by: Jonathan Cameron +Signed-off-by: Sasha Levin +--- + drivers/iio/imu/adis_buffer.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c +index ac354321f63a..175af154e443 100644 +--- a/drivers/iio/imu/adis_buffer.c ++++ b/drivers/iio/imu/adis_buffer.c +@@ -129,9 +129,6 @@ static irqreturn_t adis_trigger_handler(int irq, void *p) + struct adis *adis = iio_device_get_drvdata(indio_dev); + int ret; + +- if (!adis->buffer) +- return -ENOMEM; +- + if (adis->data->has_paging) { + mutex_lock(&adis->state_lock); + if (adis->current_page != 0) { +-- +2.30.2 + diff --git a/queue-5.10/iio-chemical-atlas-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-chemical-atlas-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..7c017c0dddd --- /dev/null +++ b/queue-5.10/iio-chemical-atlas-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,47 @@ +From 38715f82aaab973170cf3b40f4dab7e83ebe9431 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:13:46 +0100 +Subject: iio: chemical: atlas: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit b0f5d8db7348a6ce5cdd79fba46ebc91eebc8fd9 ] + +Variable location for the timestamp, so just use __aligned(8) +to ensure it is always possible to naturally align it. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes tag is not accurate, but it will need manual backporting beyond +that point if anyone cares. + +Fixes: 0d15190f53b4 ("iio: chemical: atlas-ph-sensor: rename atlas-ph-sensor to atlas-sensor") +Signed-off-by: Jonathan Cameron +Cc: Matt Ranostay +Acked-by: Matt Ranostay +Link: https://lore.kernel.org/r/20210501171352.512953-6-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/chemical/atlas-sensor.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c +index cdab9d04dedd..0c8a50de8940 100644 +--- a/drivers/iio/chemical/atlas-sensor.c ++++ b/drivers/iio/chemical/atlas-sensor.c +@@ -91,8 +91,8 @@ struct atlas_data { + struct regmap *regmap; + struct irq_work work; + unsigned int interrupt_enabled; +- +- __be32 buffer[6]; /* 96-bit data + 32-bit pad + 64-bit timestamp */ ++ /* 96-bit data + 32-bit pad + 64-bit timestamp */ ++ __be32 buffer[6] __aligned(8); + }; + + static const struct regmap_config atlas_regmap_config = { +-- +2.30.2 + diff --git a/queue-5.10/iio-cros_ec_sensors-fix-alignment-of-buffer-in-iio_p.patch b/queue-5.10/iio-cros_ec_sensors-fix-alignment-of-buffer-in-iio_p.patch new file mode 100644 index 00000000000..8c9928b0ec0 --- /dev/null +++ b/queue-5.10/iio-cros_ec_sensors-fix-alignment-of-buffer-in-iio_p.patch @@ -0,0 +1,46 @@ +From 2b356ad2e5f635eb366ae2e52f878c79dbcfae91 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:13:47 +0100 +Subject: iio: cros_ec_sensors: Fix alignment of buffer in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 8dea228b174ac9637b567e5ef54f4c40db4b3c41 ] + +The samples buffer is passed to iio_push_to_buffers_with_timestamp() +which requires a buffer aligned to 8 bytes as it is assumed that +the timestamp will be naturally aligned if present. + +Fixes tag is inaccurate but prior to that likely manual backporting needed +(for anything before 4.18) Earlier than that the include file to fix is +drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h: +commit 974e6f02e27 ("iio: cros_ec_sensors_core: Add common functions +for the ChromeOS EC Sensor Hub.") present since kernel stable 4.10. +(Thanks to Gwendal for tracking this down) + +Fixes: 5a0b8cb46624c ("iio: cros_ec: Move cros_ec_sensors_core.h in /include") +Signed-off-by: Jonathan Cameron +Reviewed-by: Gwendal Grignou +--- + include/linux/iio/common/cros_ec_sensors_core.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/iio/common/cros_ec_sensors_core.h b/include/linux/iio/common/cros_ec_sensors_core.h +index c9b80be82440..f82857bd693f 100644 +--- a/include/linux/iio/common/cros_ec_sensors_core.h ++++ b/include/linux/iio/common/cros_ec_sensors_core.h +@@ -77,7 +77,7 @@ struct cros_ec_sensors_core_state { + u16 scale; + } calib[CROS_EC_SENSOR_MAX_AXIS]; + s8 sign[CROS_EC_SENSOR_MAX_AXIS]; +- u8 samples[CROS_EC_SAMPLE_SIZE]; ++ u8 samples[CROS_EC_SAMPLE_SIZE] __aligned(8); + + int (*read_ec_sensors_data)(struct iio_dev *indio_dev, + unsigned long scan_mask, s16 *data); +-- +2.30.2 + diff --git a/queue-5.10/iio-gyro-bmg160-fix-buffer-alignment-in-iio_push_to_.patch b/queue-5.10/iio-gyro-bmg160-fix-buffer-alignment-in-iio_push_to_.patch new file mode 100644 index 00000000000..414cd1bdc44 --- /dev/null +++ b/queue-5.10/iio-gyro-bmg160-fix-buffer-alignment-in-iio_push_to_.patch @@ -0,0 +1,61 @@ +From 5c29fdc54a9e5d1f2449d6aa3038f9ab885f7a98 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:12 +0100 +Subject: iio: gyro: bmg160: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 06778d881f3798ce93ffbbbf801234292250b598 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 13426454b649 ("iio: bmg160: Separate i2c and core driver") +Signed-off-by: Jonathan Cameron +Cc: Stephan Gerhold +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-11-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/gyro/bmg160_core.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c +index 8ddda96455fc..39fe0b178592 100644 +--- a/drivers/iio/gyro/bmg160_core.c ++++ b/drivers/iio/gyro/bmg160_core.c +@@ -96,7 +96,11 @@ struct bmg160_data { + struct iio_trigger *motion_trig; + struct iio_mount_matrix orientation; + struct mutex mutex; +- s16 buffer[8]; ++ /* Ensure naturally aligned timestamp */ ++ struct { ++ s16 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + u32 dps_range; + int ev_enable_state; + int slope_thres; +@@ -880,12 +884,12 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p) + + mutex_lock(&data->mutex); + ret = regmap_bulk_read(data->regmap, BMG160_REG_XOUT_L, +- data->buffer, AXIS_MAX * 2); ++ data->scan.chans, AXIS_MAX * 2); + mutex_unlock(&data->mutex); + if (ret < 0) + goto err; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + err: + iio_trigger_notify_done(indio_dev->trig); +-- +2.30.2 + diff --git a/queue-5.10/iio-humidity-am2315-fix-buffer-alignment-in-iio_push.patch b/queue-5.10/iio-humidity-am2315-fix-buffer-alignment-in-iio_push.patch new file mode 100644 index 00000000000..c9cbd338c86 --- /dev/null +++ b/queue-5.10/iio-humidity-am2315-fix-buffer-alignment-in-iio_push.patch @@ -0,0 +1,71 @@ +From d34584178ac36fe866414795a59079d274a499ec Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:13 +0100 +Subject: iio: humidity: am2315: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit f4ca2e2595d9fee65d5ce0d218b22ce00e5b2915 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 0d96d5ead3f7 ("iio: humidity: Add triggered buffer support for AM2315") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-12-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/humidity/am2315.c | 16 ++++++++++------ + 1 file changed, 10 insertions(+), 6 deletions(-) + +diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c +index 02ad1767c845..3398fa413ec5 100644 +--- a/drivers/iio/humidity/am2315.c ++++ b/drivers/iio/humidity/am2315.c +@@ -33,7 +33,11 @@ + struct am2315_data { + struct i2c_client *client; + struct mutex lock; +- s16 buffer[8]; /* 2x16-bit channels + 2x16 padding + 4x16 timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s16 chans[2]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + struct am2315_sensor_data { +@@ -167,20 +171,20 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p) + + mutex_lock(&data->lock); + if (*(indio_dev->active_scan_mask) == AM2315_ALL_CHANNEL_MASK) { +- data->buffer[0] = sensor_data.hum_data; +- data->buffer[1] = sensor_data.temp_data; ++ data->scan.chans[0] = sensor_data.hum_data; ++ data->scan.chans[1] = sensor_data.temp_data; + } else { + i = 0; + for_each_set_bit(bit, indio_dev->active_scan_mask, + indio_dev->masklength) { +- data->buffer[i] = (bit ? sensor_data.temp_data : +- sensor_data.hum_data); ++ data->scan.chans[i] = (bit ? sensor_data.temp_data : ++ sensor_data.hum_data); + i++; + } + } + mutex_unlock(&data->lock); + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + err: + iio_trigger_notify_done(indio_dev->trig); +-- +2.30.2 + diff --git a/queue-5.10/iio-light-isl29125-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-light-isl29125-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..a72325e8f04 --- /dev/null +++ b/queue-5.10/iio-light-isl29125-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,58 @@ +From 72cce0f8666dae7177cb251cd01e0b63bc16c5b7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:19 +0100 +Subject: iio: light: isl29125: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 3d4725194de6935dba2ad7c9cc075c885008f747 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 6c25539cbc46 ("iio: Add Intersil isl29125 digital color light sensor driver") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-18-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/light/isl29125.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/light/isl29125.c b/drivers/iio/light/isl29125.c +index b93b85dbc3a6..ba53b50d711a 100644 +--- a/drivers/iio/light/isl29125.c ++++ b/drivers/iio/light/isl29125.c +@@ -51,7 +51,11 @@ + struct isl29125_data { + struct i2c_client *client; + u8 conf1; +- u16 buffer[8]; /* 3x 16-bit, padding, 8 bytes timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u16 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + #define ISL29125_CHANNEL(_color, _si) { \ +@@ -184,10 +188,10 @@ static irqreturn_t isl29125_trigger_handler(int irq, void *p) + if (ret < 0) + goto done; + +- data->buffer[j++] = ret; ++ data->scan.chans[j++] = ret; + } + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + iio_get_time_ns(indio_dev)); + + done: +-- +2.30.2 + diff --git a/queue-5.10/iio-light-tcs3414-fix-buffer-alignment-in-iio_push_t.patch b/queue-5.10/iio-light-tcs3414-fix-buffer-alignment-in-iio_push_t.patch new file mode 100644 index 00000000000..5da41bb932d --- /dev/null +++ b/queue-5.10/iio-light-tcs3414-fix-buffer-alignment-in-iio_push_t.patch @@ -0,0 +1,58 @@ +From 39ecfee428dcfaecbafe1a171fcfee6b7be44e1d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:20 +0100 +Subject: iio: light: tcs3414: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit ff08fbc22ab32ccc6690c21b0e5e1d402dcc076f ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: a244e7b57f0f ("iio: Add driver for AMS/TAOS tcs3414 digital color sensor") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-19-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/light/tcs3414.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c +index 6fe5d46f80d4..0593abd600ec 100644 +--- a/drivers/iio/light/tcs3414.c ++++ b/drivers/iio/light/tcs3414.c +@@ -53,7 +53,11 @@ struct tcs3414_data { + u8 control; + u8 gain; + u8 timing; +- u16 buffer[8]; /* 4x 16-bit + 8 bytes timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u16 chans[4]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + #define TCS3414_CHANNEL(_color, _si, _addr) { \ +@@ -209,10 +213,10 @@ static irqreturn_t tcs3414_trigger_handler(int irq, void *p) + if (ret < 0) + goto done; + +- data->buffer[j++] = ret; ++ data->scan.chans[j++] = ret; + } + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + iio_get_time_ns(indio_dev)); + + done: +-- +2.30.2 + diff --git a/queue-5.10/iio-light-tcs3472-fix-buffer-alignment-in-iio_push_t.patch b/queue-5.10/iio-light-tcs3472-fix-buffer-alignment-in-iio_push_t.patch new file mode 100644 index 00000000000..db4b28b683f --- /dev/null +++ b/queue-5.10/iio-light-tcs3472-fix-buffer-alignment-in-iio_push_t.patch @@ -0,0 +1,62 @@ +From 1cdbccd7698156245f2344aa70b1983d826aceac Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:21 +0100 +Subject: iio: light: tcs3472: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit df2f37cffd6ed486d613e7ee22aadc8e49ae2dd3 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp(). + +Fixes tag is not strictly accurate as prior to that patch there was +potentially an unaligned write. However, any backport past there will +need to be done manually. + +Fixes: 0624bf847dd0 ("iio:tcs3472: Use iio_push_to_buffers_with_timestamp()") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-20-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/light/tcs3472.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/light/tcs3472.c b/drivers/iio/light/tcs3472.c +index b41068492338..371c6a39a165 100644 +--- a/drivers/iio/light/tcs3472.c ++++ b/drivers/iio/light/tcs3472.c +@@ -64,7 +64,11 @@ struct tcs3472_data { + u8 control; + u8 atime; + u8 apers; +- u16 buffer[8]; /* 4 16-bit channels + 64-bit timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u16 chans[4]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + static const struct iio_event_spec tcs3472_events[] = { +@@ -386,10 +390,10 @@ static irqreturn_t tcs3472_trigger_handler(int irq, void *p) + if (ret < 0) + goto done; + +- data->buffer[j++] = ret; ++ data->scan.chans[j++] = ret; + } + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + iio_get_time_ns(indio_dev)); + + done: +-- +2.30.2 + diff --git a/queue-5.10/iio-light-vcnl4000-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-light-vcnl4000-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..35a753e93af --- /dev/null +++ b/queue-5.10/iio-light-vcnl4000-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,49 @@ +From 85af94dadb91622589e95edfcacdf5a4bf848456 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:59 +0100 +Subject: iio: light: vcnl4000: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit dce793c0ab00c35039028fdcd5ce123805a01361 ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Here an explicit structure is not used, because the holes would +necessitate the addition of an explict memset(), to avoid a kernel +data leak, making for a less minimal fix. + +Found during an audit of all callers of iio_push_to_buffers_with_timestamp() + +Fixes: 8fe78d5261e7 ("iio: vcnl4000: Add buffer support for VCNL4010/20.") +Signed-off-by: Jonathan Cameron +Cc: Mathieu Othacehe +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-7-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/light/vcnl4000.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c +index fff4b36b8b58..f4feb44903b3 100644 +--- a/drivers/iio/light/vcnl4000.c ++++ b/drivers/iio/light/vcnl4000.c +@@ -910,7 +910,7 @@ static irqreturn_t vcnl4010_trigger_handler(int irq, void *p) + struct iio_dev *indio_dev = pf->indio_dev; + struct vcnl4000_data *data = iio_priv(indio_dev); + const unsigned long *active_scan_mask = indio_dev->active_scan_mask; +- u16 buffer[8] = {0}; /* 1x16-bit + ts */ ++ u16 buffer[8] __aligned(8) = {0}; /* 1x16-bit + naturally aligned ts */ + bool data_read = false; + unsigned long isr; + int val = 0; +-- +2.30.2 + diff --git a/queue-5.10/iio-light-vcnl4035-fix-buffer-alignment-in-iio_push_.patch b/queue-5.10/iio-light-vcnl4035-fix-buffer-alignment-in-iio_push_.patch new file mode 100644 index 00000000000..12c266e8b9c --- /dev/null +++ b/queue-5.10/iio-light-vcnl4035-fix-buffer-alignment-in-iio_push_.patch @@ -0,0 +1,48 @@ +From 07b62dfad93d7c6d4f63a2fd485779b32cd65254 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:23:00 +0100 +Subject: iio: light: vcnl4035: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit ec90b52c07c0403a6db60d752484ec08d605ead0 ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Here an explicit structure is not used, because the holes would +necessitate the addition of an explict memset(), to avoid a potential +kernel data leak, making for a less minimal fix. + +Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035") +Signed-off-by: Jonathan Cameron +Cc: Parthiban Nallathambi +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-8-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/light/vcnl4035.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c +index 765c44adac57..1bd85e21fd11 100644 +--- a/drivers/iio/light/vcnl4035.c ++++ b/drivers/iio/light/vcnl4035.c +@@ -102,7 +102,8 @@ static irqreturn_t vcnl4035_trigger_consumer_handler(int irq, void *p) + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_dev; + struct vcnl4035_data *data = iio_priv(indio_dev); +- u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)]; ++ /* Ensure naturally aligned timestamp */ ++ u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)] __aligned(8); + int ret; + + ret = regmap_read(data->regmap, VCNL4035_ALS_DATA, (int *)buffer); +-- +2.30.2 + diff --git a/queue-5.10/iio-magn-bmc150-fix-buffer-alignment-in-iio_push_to_.patch b/queue-5.10/iio-magn-bmc150-fix-buffer-alignment-in-iio_push_to_.patch new file mode 100644 index 00000000000..7796ac35e08 --- /dev/null +++ b/queue-5.10/iio-magn-bmc150-fix-buffer-alignment-in-iio_push_to_.patch @@ -0,0 +1,63 @@ +From d069c83c89a46885446873d71370295007817368 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:18 +0100 +Subject: iio: magn: bmc150: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 7692088f72865c41b6b531fd09486ee99a5da930 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: c91746a2361d ("iio: magn: Add support for BMC150 magnetometer") +Signed-off-by: Jonathan Cameron +Cc: Stephan Gerhold +Cc: Linus Walleij +Reviewed-by: Linus Walleij +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-17-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/magnetometer/bmc150_magn.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c +index fc6840f9c1fa..8042175275d0 100644 +--- a/drivers/iio/magnetometer/bmc150_magn.c ++++ b/drivers/iio/magnetometer/bmc150_magn.c +@@ -136,8 +136,11 @@ struct bmc150_magn_data { + struct mutex mutex; + struct regmap *regmap; + struct iio_mount_matrix orientation; +- /* 4 x 32 bits for x, y z, 4 bytes align, 64 bits timestamp */ +- s32 buffer[6]; ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s32 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + struct iio_trigger *dready_trig; + bool dready_trigger_on; + int max_odr; +@@ -673,11 +676,11 @@ static irqreturn_t bmc150_magn_trigger_handler(int irq, void *p) + int ret; + + mutex_lock(&data->mutex); +- ret = bmc150_magn_read_xyz(data, data->buffer); ++ ret = bmc150_magn_read_xyz(data, data->scan.chans); + if (ret < 0) + goto err; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); + + err: +-- +2.30.2 + diff --git a/queue-5.10/iio-magn-hmc5843-fix-buffer-alignment-in-iio_push_to.patch b/queue-5.10/iio-magn-hmc5843-fix-buffer-alignment-in-iio_push_to.patch new file mode 100644 index 00000000000..ca0400e3c54 --- /dev/null +++ b/queue-5.10/iio-magn-hmc5843-fix-buffer-alignment-in-iio_push_to.patch @@ -0,0 +1,75 @@ +From 643f9e96c00d4924554f23919290d35ea6d669c6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:17 +0100 +Subject: iio: magn: hmc5843: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 1ef2f51e9fe424ccecca5bb0373d71b900c2cd41 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging") +Signed-off-by: Jonathan Cameron +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-16-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/magnetometer/hmc5843.h | 8 ++++++-- + drivers/iio/magnetometer/hmc5843_core.c | 4 ++-- + 2 files changed, 8 insertions(+), 4 deletions(-) + +diff --git a/drivers/iio/magnetometer/hmc5843.h b/drivers/iio/magnetometer/hmc5843.h +index 3f6c0b662941..242f742f2643 100644 +--- a/drivers/iio/magnetometer/hmc5843.h ++++ b/drivers/iio/magnetometer/hmc5843.h +@@ -33,7 +33,8 @@ enum hmc5843_ids { + * @lock: update and read regmap data + * @regmap: hardware access register maps + * @variant: describe chip variants +- * @buffer: 3x 16-bit channels + padding + 64-bit timestamp ++ * @scan: buffer to pack data for passing to ++ * iio_push_to_buffers_with_timestamp() + */ + struct hmc5843_data { + struct device *dev; +@@ -41,7 +42,10 @@ struct hmc5843_data { + struct regmap *regmap; + const struct hmc5843_chip_info *variant; + struct iio_mount_matrix orientation; +- __be16 buffer[8]; ++ struct { ++ __be16 chans[3]; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + int hmc5843_common_probe(struct device *dev, struct regmap *regmap, +diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c +index 780faea61d82..221563e0c18f 100644 +--- a/drivers/iio/magnetometer/hmc5843_core.c ++++ b/drivers/iio/magnetometer/hmc5843_core.c +@@ -446,13 +446,13 @@ static irqreturn_t hmc5843_trigger_handler(int irq, void *p) + } + + ret = regmap_bulk_read(data->regmap, HMC5843_DATA_OUT_MSB_REGS, +- data->buffer, 3 * sizeof(__be16)); ++ data->scan.chans, sizeof(data->scan.chans)); + + mutex_unlock(&data->lock); + if (ret < 0) + goto done; + +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + iio_get_time_ns(indio_dev)); + + done: +-- +2.30.2 + diff --git a/queue-5.10/iio-magn-rm3100-fix-alignment-of-buffer-in-iio_push_.patch b/queue-5.10/iio-magn-rm3100-fix-alignment-of-buffer-in-iio_push_.patch new file mode 100644 index 00000000000..a4ff25bf04e --- /dev/null +++ b/queue-5.10/iio-magn-rm3100-fix-alignment-of-buffer-in-iio_push_.patch @@ -0,0 +1,47 @@ +From a4654c72b61940190a18ed659b62815c17679448 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:22:58 +0100 +Subject: iio: magn: rm3100: Fix alignment of buffer in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit b8f939fd20690623cb24845a563e7bc1e4a21482 ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Here an explicit structure is not used, because this buffer is used in +a non-trivial way for data repacking. + +Fixes: 121354b2eceb ("iio: magnetometer: Add driver support for PNI RM3100") +Signed-off-by: Jonathan Cameron +Cc: Song Qiang +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-6-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/magnetometer/rm3100-core.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/iio/magnetometer/rm3100-core.c b/drivers/iio/magnetometer/rm3100-core.c +index 7242897a05e9..720234a91db1 100644 +--- a/drivers/iio/magnetometer/rm3100-core.c ++++ b/drivers/iio/magnetometer/rm3100-core.c +@@ -78,7 +78,8 @@ struct rm3100_data { + bool use_interrupt; + int conversion_time; + int scale; +- u8 buffer[RM3100_SCAN_BYTES]; ++ /* Ensure naturally aligned timestamp */ ++ u8 buffer[RM3100_SCAN_BYTES] __aligned(8); + struct iio_trigger *drdy_trig; + + /* +-- +2.30.2 + diff --git a/queue-5.10/iio-potentiostat-lmp91000-fix-alignment-of-buffer-in.patch b/queue-5.10/iio-potentiostat-lmp91000-fix-alignment-of-buffer-in.patch new file mode 100644 index 00000000000..a0e50bd0bdb --- /dev/null +++ b/queue-5.10/iio-potentiostat-lmp91000-fix-alignment-of-buffer-in.patch @@ -0,0 +1,45 @@ +From 85907da8dbba8a01410618aff9a7f4de146c7c9c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:13:48 +0100 +Subject: iio: potentiostat: lmp91000: Fix alignment of buffer in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 8979b67ec61abc232636400ee8c758a16a73c95f ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Here structure is not used, because this buffer is also used +elsewhere in the driver. + +Fixes: 67e17300dc1d ("iio: potentiostat: add LMP91000 support") +Signed-off-by: Jonathan Cameron +Cc: Matt Ranostay +Acked-by: Matt Ranostay +Link: https://lore.kernel.org/r/20210501171352.512953-8-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/potentiostat/lmp91000.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c +index f34ca769dc20..d7ff74a798ba 100644 +--- a/drivers/iio/potentiostat/lmp91000.c ++++ b/drivers/iio/potentiostat/lmp91000.c +@@ -71,8 +71,8 @@ struct lmp91000_data { + + struct completion completion; + u8 chan_select; +- +- u32 buffer[4]; /* 64-bit data + 64-bit timestamp */ ++ /* 64-bit data + 64-bit naturally aligned timestamp */ ++ u32 buffer[4] __aligned(8); + }; + + static const struct iio_chan_spec lmp91000_channels[] = { +-- +2.30.2 + diff --git a/queue-5.10/iio-prox-as3935-fix-buffer-alignment-in-iio_push_to_.patch b/queue-5.10/iio-prox-as3935-fix-buffer-alignment-in-iio_push_to_.patch new file mode 100644 index 00000000000..f103fc3864a --- /dev/null +++ b/queue-5.10/iio-prox-as3935-fix-buffer-alignment-in-iio_push_to_.patch @@ -0,0 +1,58 @@ +From 9796e686b9fc69e0d087beaa08ad2f5dba24c5e1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:16 +0100 +Subject: iio: prox: as3935: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 37eb8d8c64f2ecb3a5521ba1cc1fad973adfae41 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 37b1ba2c68cf ("iio: proximity: as3935: fix buffer stack trashing") +Signed-off-by: Jonathan Cameron +Cc: Matt Ranostay +Acked-by: Matt Ranostay +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-15-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/proximity/as3935.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c +index b79ada839e01..98330e26ac3b 100644 +--- a/drivers/iio/proximity/as3935.c ++++ b/drivers/iio/proximity/as3935.c +@@ -59,7 +59,11 @@ struct as3935_state { + unsigned long noise_tripped; + u32 tune_cap; + u32 nflwdth_reg; +- u8 buffer[16]; /* 8-bit data + 56-bit padding + 64-bit timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u8 chan; ++ s64 timestamp __aligned(8); ++ } scan; + u8 buf[2] ____cacheline_aligned; + }; + +@@ -225,8 +229,8 @@ static irqreturn_t as3935_trigger_handler(int irq, void *private) + if (ret) + goto err_read; + +- st->buffer[0] = val & AS3935_DATA_MASK; +- iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer, ++ st->scan.chan = val & AS3935_DATA_MASK; ++ iio_push_to_buffers_with_timestamp(indio_dev, &st->scan, + iio_get_time_ns(indio_dev)); + err_read: + iio_trigger_notify_done(indio_dev->trig); +-- +2.30.2 + diff --git a/queue-5.10/iio-prox-isl29501-fix-buffer-alignment-in-iio_push_t.patch b/queue-5.10/iio-prox-isl29501-fix-buffer-alignment-in-iio_push_t.patch new file mode 100644 index 00000000000..66718aee9f7 --- /dev/null +++ b/queue-5.10/iio-prox-isl29501-fix-buffer-alignment-in-iio_push_t.patch @@ -0,0 +1,47 @@ +From 857fefbc4815cf822416e1e57730c35083ef25b6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 16:23:01 +0100 +Subject: iio: prox: isl29501: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jonathan Cameron + +[ Upstream commit 92babc9938ebbf4050f2fba774836f7edc16a570 ] + +Add __aligned(8) to ensure the buffer passed to +iio_push_to_buffers_with_timestamp() is suitable for the naturally +aligned timestamp that will be inserted. + +Here an explicit structure is not used, because the holes would +necessitate the addition of an explict memset(), to avoid a kernel +data leak, making for a less minimal fix. + +Fixes: 1c28799257bc ("iio: light: isl29501: Add support for the ISL29501 ToF sensor.") +Signed-off-by: Jonathan Cameron +Cc: Mathieu Othacehe +Reviewed-by: Nuno Sá +Link: https://lore.kernel.org/r/20210613152301.571002-9-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/proximity/isl29501.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl29501.c +index 90e76451c972..5b6ea783795d 100644 +--- a/drivers/iio/proximity/isl29501.c ++++ b/drivers/iio/proximity/isl29501.c +@@ -938,7 +938,7 @@ static irqreturn_t isl29501_trigger_handler(int irq, void *p) + struct iio_dev *indio_dev = pf->indio_dev; + struct isl29501_private *isl29501 = iio_priv(indio_dev); + const unsigned long *active_mask = indio_dev->active_scan_mask; +- u32 buffer[4] = {}; /* 1x16-bit + ts */ ++ u32 buffer[4] __aligned(8) = {}; /* 1x16-bit + naturally aligned ts */ + + if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) + isl29501_register_read(isl29501, REG_DISTANCE, buffer); +-- +2.30.2 + diff --git a/queue-5.10/iio-prox-pulsed-light-fix-buffer-alignment-in-iio_pu.patch b/queue-5.10/iio-prox-pulsed-light-fix-buffer-alignment-in-iio_pu.patch new file mode 100644 index 00000000000..cc1891d2be3 --- /dev/null +++ b/queue-5.10/iio-prox-pulsed-light-fix-buffer-alignment-in-iio_pu.patch @@ -0,0 +1,59 @@ +From b83f712cc813051b7c4e271ec58a23a7596fc1ec Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:15 +0100 +Subject: iio: prox: pulsed-light: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 679cc377a03ff1944491eafc7355c1eb1fad4109 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: cb119d535083 ("iio: proximity: add support for PulsedLight LIDAR") +Signed-off-by: Jonathan Cameron +Cc: Matt Ranostay +Acked-by: Matt Ranostay +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-14-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +index cc206bfa09c7..d854b8d5fbba 100644 +--- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c ++++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +@@ -44,7 +44,11 @@ struct lidar_data { + int (*xfer)(struct lidar_data *data, u8 reg, u8 *val, int len); + int i2c_enabled; + +- u16 buffer[8]; /* 2 byte distance + 8 byte timestamp */ ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ u16 chan; ++ s64 timestamp __aligned(8); ++ } scan; + }; + + static const struct iio_chan_spec lidar_channels[] = { +@@ -230,9 +234,9 @@ static irqreturn_t lidar_trigger_handler(int irq, void *private) + struct lidar_data *data = iio_priv(indio_dev); + int ret; + +- ret = lidar_get_measurement(data, data->buffer); ++ ret = lidar_get_measurement(data, &data->scan.chan); + if (!ret) { +- iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, ++ iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + iio_get_time_ns(indio_dev)); + } else if (ret != -EINVAL) { + dev_err(&data->client->dev, "cannot read LIDAR measurement"); +-- +2.30.2 + diff --git a/queue-5.10/iio-prox-srf08-fix-buffer-alignment-in-iio_push_to_b.patch b/queue-5.10/iio-prox-srf08-fix-buffer-alignment-in-iio_push_to_b.patch new file mode 100644 index 00000000000..e892ac00fb6 --- /dev/null +++ b/queue-5.10/iio-prox-srf08-fix-buffer-alignment-in-iio_push_to_b.patch @@ -0,0 +1,62 @@ +From 8e4d8791a3c4c2c56bb873b264725901a67b715f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 1 May 2021 18:01:14 +0100 +Subject: iio: prox: srf08: Fix buffer alignment in + iio_push_to_buffers_with_timestamp() + +From: Jonathan Cameron + +[ Upstream commit 19f1a254fe4949fff1e67db386409f48cf438bd7 ] + +To make code more readable, use a structure to express the channel +layout and ensure the timestamp is 8 byte aligned. + +Found during an audit of all calls of uses of +iio_push_to_buffers_with_timestamp() + +Fixes: 78f839029e1d ("iio: distance: srf08: add IIO driver for us ranger") +Signed-off-by: Jonathan Cameron +Cc: Andreas Klinger +Reviewed-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210501170121.512209-13-jic23@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/iio/proximity/srf08.c | 14 +++++++------- + 1 file changed, 7 insertions(+), 7 deletions(-) + +diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c +index 70beac5c9c1d..9b0886760f76 100644 +--- a/drivers/iio/proximity/srf08.c ++++ b/drivers/iio/proximity/srf08.c +@@ -63,11 +63,11 @@ struct srf08_data { + int range_mm; + struct mutex lock; + +- /* +- * triggered buffer +- * 1x16-bit channel + 3x16 padding + 4x16 timestamp +- */ +- s16 buffer[8]; ++ /* Ensure timestamp is naturally aligned */ ++ struct { ++ s16 chan; ++ s64 timestamp __aligned(8); ++ } scan; + + /* Sensor-Type */ + enum srf08_sensor_type sensor_type; +@@ -190,9 +190,9 @@ static irqreturn_t srf08_trigger_handler(int irq, void *p) + + mutex_lock(&data->lock); + +- data->buffer[0] = sensor_data; ++ data->scan.chan = sensor_data; + iio_push_to_buffers_with_timestamp(indio_dev, +- data->buffer, pf->timestamp); ++ &data->scan, pf->timestamp); + + mutex_unlock(&data->lock); + err: +-- +2.30.2 + diff --git a/queue-5.10/include-linux-huge_mm.h-remove-extern-keyword.patch b/queue-5.10/include-linux-huge_mm.h-remove-extern-keyword.patch new file mode 100644 index 00000000000..c5f574bacbb --- /dev/null +++ b/queue-5.10/include-linux-huge_mm.h-remove-extern-keyword.patch @@ -0,0 +1,166 @@ +From 4471783686d66cf688599759f81bc6dc76b154dc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Dec 2020 19:11:58 -0800 +Subject: include/linux/huge_mm.h: remove extern keyword + +From: Ralph Campbell + +[ Upstream commit ebfe1b8f6ea5d83d8c1aa18ddd8ede432a7414e7 ] + +The external function definitions don't need the "extern" keyword. Remove +them so future changes don't copy the function definition style. + +Link: https://lkml.kernel.org/r/20201106235135.32109-1-rcampbell@nvidia.com +Signed-off-by: Ralph Campbell +Reviewed-by: Christoph Hellwig +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + include/linux/huge_mm.h | 93 ++++++++++++++++++----------------------- + 1 file changed, 41 insertions(+), 52 deletions(-) + +diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h +index 42dc994c8897..e72787731a5b 100644 +--- a/include/linux/huge_mm.h ++++ b/include/linux/huge_mm.h +@@ -7,43 +7,37 @@ + + #include /* only for vma_is_dax() */ + +-extern vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf); +-extern int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, +- pmd_t *dst_pmd, pmd_t *src_pmd, unsigned long addr, +- struct vm_area_struct *vma); +-extern void huge_pmd_set_accessed(struct vm_fault *vmf, pmd_t orig_pmd); +-extern int copy_huge_pud(struct mm_struct *dst_mm, struct mm_struct *src_mm, +- pud_t *dst_pud, pud_t *src_pud, unsigned long addr, +- struct vm_area_struct *vma); ++vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf); ++int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, ++ pmd_t *dst_pmd, pmd_t *src_pmd, unsigned long addr, ++ struct vm_area_struct *vma); ++void huge_pmd_set_accessed(struct vm_fault *vmf, pmd_t orig_pmd); ++int copy_huge_pud(struct mm_struct *dst_mm, struct mm_struct *src_mm, ++ pud_t *dst_pud, pud_t *src_pud, unsigned long addr, ++ struct vm_area_struct *vma); + + #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD +-extern void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud); ++void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud); + #else + static inline void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud) + { + } + #endif + +-extern vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf, pmd_t orig_pmd); +-extern struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, +- unsigned long addr, +- pmd_t *pmd, +- unsigned int flags); +-extern bool madvise_free_huge_pmd(struct mmu_gather *tlb, +- struct vm_area_struct *vma, +- pmd_t *pmd, unsigned long addr, unsigned long next); +-extern int zap_huge_pmd(struct mmu_gather *tlb, +- struct vm_area_struct *vma, +- pmd_t *pmd, unsigned long addr); +-extern int zap_huge_pud(struct mmu_gather *tlb, +- struct vm_area_struct *vma, +- pud_t *pud, unsigned long addr); +-extern bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, +- unsigned long new_addr, +- pmd_t *old_pmd, pmd_t *new_pmd); +-extern int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, +- unsigned long addr, pgprot_t newprot, +- unsigned long cp_flags); ++vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf, pmd_t orig_pmd); ++struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, ++ unsigned long addr, pmd_t *pmd, ++ unsigned int flags); ++bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, ++ pmd_t *pmd, unsigned long addr, unsigned long next); ++int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t *pmd, ++ unsigned long addr); ++int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma, pud_t *pud, ++ unsigned long addr); ++bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr, ++ unsigned long new_addr, pmd_t *old_pmd, pmd_t *new_pmd); ++int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr, ++ pgprot_t newprot, unsigned long cp_flags); + vm_fault_t vmf_insert_pfn_pmd_prot(struct vm_fault *vmf, pfn_t pfn, + pgprot_t pgprot, bool write); + +@@ -101,13 +95,13 @@ enum transparent_hugepage_flag { + struct kobject; + struct kobj_attribute; + +-extern ssize_t single_hugepage_flag_store(struct kobject *kobj, +- struct kobj_attribute *attr, +- const char *buf, size_t count, +- enum transparent_hugepage_flag flag); +-extern ssize_t single_hugepage_flag_show(struct kobject *kobj, +- struct kobj_attribute *attr, char *buf, +- enum transparent_hugepage_flag flag); ++ssize_t single_hugepage_flag_store(struct kobject *kobj, ++ struct kobj_attribute *attr, ++ const char *buf, size_t count, ++ enum transparent_hugepage_flag flag); ++ssize_t single_hugepage_flag_show(struct kobject *kobj, ++ struct kobj_attribute *attr, char *buf, ++ enum transparent_hugepage_flag flag); + extern struct kobj_attribute shmem_enabled_attr; + + #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) +@@ -187,12 +181,11 @@ bool transparent_hugepage_active(struct vm_area_struct *vma); + (transparent_hugepage_flags & \ + (1< +Date: Tue, 4 May 2021 20:57:42 +0200 +Subject: Input: goodix - platform/x86: touchscreen_dmi - Move upside down + quirks to touchscreen_dmi.c + +From: Hans de Goede + +[ Upstream commit 5a6f0dbe621a5c20dc912ac474debf9f11129e03 ] + +Move the DMI quirks for upside-down mounted Goodix touchscreens from +drivers/input/touchscreen/goodix.c to +drivers/platform/x86/touchscreen_dmi.c, +where all the other x86 touchscreen quirks live. + +Note the touchscreen_dmi.c code attaches standard touchscreen +device-properties to an i2c-client device based on a combination of a +DMI match + a device-name match. I've verified that the: Teclast X98 Pro, +WinBook TW100 and WinBook TW700 uses an ACPI devicename of "GDIX1001:00" +based on acpidumps and/or dmesg output available on the web. + +This patch was tested on a Teclast X89 tablet. + +Signed-off-by: Hans de Goede +Link: https://lore.kernel.org/r/20210504185746.175461-2-hdegoede@redhat.com +Signed-off-by: Sasha Levin +--- + drivers/input/touchscreen/goodix.c | 52 ------------------------ + drivers/platform/x86/touchscreen_dmi.c | 56 ++++++++++++++++++++++++++ + 2 files changed, 56 insertions(+), 52 deletions(-) + +diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c +index 45113767db96..a06385c55af2 100644 +--- a/drivers/input/touchscreen/goodix.c ++++ b/drivers/input/touchscreen/goodix.c +@@ -178,51 +178,6 @@ static const unsigned long goodix_irq_flags[] = { + IRQ_TYPE_LEVEL_HIGH, + }; + +-/* +- * Those tablets have their coordinates origin at the bottom right +- * of the tablet, as if rotated 180 degrees +- */ +-static const struct dmi_system_id rotated_screen[] = { +-#if defined(CONFIG_DMI) && defined(CONFIG_X86) +- { +- .ident = "Teclast X89", +- .matches = { +- /* tPAD is too generic, also match on bios date */ +- DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), +- DMI_MATCH(DMI_BOARD_NAME, "tPAD"), +- DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"), +- }, +- }, +- { +- .ident = "Teclast X98 Pro", +- .matches = { +- /* +- * Only match BIOS date, because the manufacturers +- * BIOS does not report the board name at all +- * (sometimes)... +- */ +- DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), +- DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"), +- }, +- }, +- { +- .ident = "WinBook TW100", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), +- DMI_MATCH(DMI_PRODUCT_NAME, "TW100") +- } +- }, +- { +- .ident = "WinBook TW700", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), +- DMI_MATCH(DMI_PRODUCT_NAME, "TW700") +- }, +- }, +-#endif +- {} +-}; +- + static const struct dmi_system_id nine_bytes_report[] = { + #if defined(CONFIG_DMI) && defined(CONFIG_X86) + { +@@ -1121,13 +1076,6 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) + ABS_MT_POSITION_Y, ts->prop.max_y); + } + +- if (dmi_check_system(rotated_screen)) { +- ts->prop.invert_x = true; +- ts->prop.invert_y = true; +- dev_dbg(&ts->client->dev, +- "Applying '180 degrees rotated screen' quirk\n"); +- } +- + if (dmi_check_system(nine_bytes_report)) { + ts->contact_size = 9; + +diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c +index 3743d895399e..e52ff09b81de 100644 +--- a/drivers/platform/x86/touchscreen_dmi.c ++++ b/drivers/platform/x86/touchscreen_dmi.c +@@ -299,6 +299,23 @@ static const struct ts_dmi_data estar_beauty_hd_data = { + .properties = estar_beauty_hd_props, + }; + ++/* Generic props + data for upside-down mounted GDIX1001 touchscreens */ ++static const struct property_entry gdix1001_upside_down_props[] = { ++ PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), ++ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), ++ { } ++}; ++ ++static const struct ts_dmi_data gdix1001_00_upside_down_data = { ++ .acpi_name = "GDIX1001:00", ++ .properties = gdix1001_upside_down_props, ++}; ++ ++static const struct ts_dmi_data gdix1001_01_upside_down_data = { ++ .acpi_name = "GDIX1001:01", ++ .properties = gdix1001_upside_down_props, ++}; ++ + static const struct property_entry gp_electronic_t701_props[] = { + PROPERTY_ENTRY_U32("touchscreen-size-x", 960), + PROPERTY_ENTRY_U32("touchscreen-size-y", 640), +@@ -1268,6 +1285,16 @@ const struct dmi_system_id touchscreen_dmi_table[] = { + DMI_MATCH(DMI_BOARD_NAME, "X3 Plus"), + }, + }, ++ { ++ /* Teclast X89 (Windows version / BIOS) */ ++ .driver_data = (void *)&gdix1001_01_upside_down_data, ++ .matches = { ++ /* tPAD is too generic, also match on bios date */ ++ DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), ++ DMI_MATCH(DMI_BOARD_NAME, "tPAD"), ++ DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"), ++ }, ++ }, + { + /* Teclast X98 Plus II */ + .driver_data = (void *)&teclast_x98plus2_data, +@@ -1276,6 +1303,19 @@ const struct dmi_system_id touchscreen_dmi_table[] = { + DMI_MATCH(DMI_PRODUCT_NAME, "X98 Plus II"), + }, + }, ++ { ++ /* Teclast X98 Pro */ ++ .driver_data = (void *)&gdix1001_00_upside_down_data, ++ .matches = { ++ /* ++ * Only match BIOS date, because the manufacturers ++ * BIOS does not report the board name at all ++ * (sometimes)... ++ */ ++ DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), ++ DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"), ++ }, ++ }, + { + /* Trekstor Primebook C11 */ + .driver_data = (void *)&trekstor_primebook_c11_data, +@@ -1351,6 +1391,22 @@ const struct dmi_system_id touchscreen_dmi_table[] = { + DMI_MATCH(DMI_PRODUCT_NAME, "VINGA Twizzle J116"), + }, + }, ++ { ++ /* "WinBook TW100" */ ++ .driver_data = (void *)&gdix1001_00_upside_down_data, ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), ++ DMI_MATCH(DMI_PRODUCT_NAME, "TW100") ++ } ++ }, ++ { ++ /* WinBook TW700 */ ++ .driver_data = (void *)&gdix1001_00_upside_down_data, ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "WinBook"), ++ DMI_MATCH(DMI_PRODUCT_NAME, "TW700") ++ }, ++ }, + { + /* Yours Y8W81, same case and touchscreen as Chuwi Vi8 */ + .driver_data = (void *)&chuwi_vi8_data, +-- +2.30.2 + diff --git a/queue-5.10/input-hil_kbd-fix-error-return-code-in-hil_dev_conne.patch b/queue-5.10/input-hil_kbd-fix-error-return-code-in-hil_dev_conne.patch new file mode 100644 index 00000000000..da6281d66f6 --- /dev/null +++ b/queue-5.10/input-hil_kbd-fix-error-return-code-in-hil_dev_conne.patch @@ -0,0 +1,37 @@ +From fb6bc4680028740801fffdb8103d7d02f14530d4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 24 May 2021 11:52:42 -0700 +Subject: Input: hil_kbd - fix error return code in hil_dev_connect() + +From: Zhen Lei + +[ Upstream commit d9b576917a1d0efa293801a264150a1b37691617 ] + +Return error code -EINVAL rather than '0' when the combo devices are not +supported. + +Fixes: fa71c605c2bb ("Input: combine hil_kbd and hil_ptr drivers") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Link: https://lore.kernel.org/r/20210515030053.6824-1-thunder.leizhen@huawei.com +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/keyboard/hil_kbd.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c +index bb29a7c9a1c0..54afb38601b9 100644 +--- a/drivers/input/keyboard/hil_kbd.c ++++ b/drivers/input/keyboard/hil_kbd.c +@@ -512,6 +512,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv) + HIL_IDD_NUM_AXES_PER_SET(*idd)) { + printk(KERN_INFO PREFIX + "combo devices are not supported.\n"); ++ error = -EINVAL; + goto bail1; + } + +-- +2.30.2 + diff --git a/queue-5.10/iommu-amd-fix-extended-features-logging.patch b/queue-5.10/iommu-amd-fix-extended-features-logging.patch new file mode 100644 index 00000000000..22d79aac6ce --- /dev/null +++ b/queue-5.10/iommu-amd-fix-extended-features-logging.patch @@ -0,0 +1,63 @@ +From 4fbeb5096536677d0b484280bc7ca3d8e4aff23d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 13:22:20 +0300 +Subject: iommu/amd: Fix extended features logging + +From: Alexander Monakov + +[ Upstream commit 4b21a503adf597773e4b37db05db0e9b16a81d53 ] + +print_iommu_info prints the EFR register and then the decoded list of +features on a separate line: + +pci 0000:00:00.2: AMD-Vi: Extended features (0x206d73ef22254ade): + PPR X2APIC NX GT IA GA PC GA_vAPIC + +The second line is emitted via 'pr_cont', which causes it to have a +different ('warn') loglevel compared to the previous line ('info'). + +Commit 9a295ff0ffc9 attempted to rectify this by removing the newline +from the pci_info format string, but this doesn't work, as pci_info +calls implicitly append a newline anyway. + +Printing the decoded features on the same line would make it quite long. +Instead, change pci_info() to pr_info() to omit PCI bus location info, +which is also shown in the preceding message. This results in: + +pci 0000:00:00.2: AMD-Vi: Found IOMMU cap 0x40 +AMD-Vi: Extended features (0x206d73ef22254ade): PPR X2APIC NX GT IA GA PC GA_vAPIC +AMD-Vi: Interrupt remapping enabled + +Fixes: 9a295ff0ffc9 ("iommu/amd: Print extended features in one line to fix divergent log levels") +Link: https://lore.kernel.org/lkml/alpine.LNX.2.20.13.2104112326460.11104@monopod.intra.ispras.ru +Signed-off-by: Alexander Monakov +Cc: Paul Menzel +Cc: Joerg Roedel +Cc: Suravee Suthikulpanit +Cc: iommu@lists.linux-foundation.org +Reviewed-by: Paul Menzel +Link: https://lore.kernel.org/r/20210504102220.1793-1-amonakov@ispras.ru +Signed-off-by: Joerg Roedel +Signed-off-by: Sasha Levin +--- + drivers/iommu/amd/init.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c +index cc9869cc48e4..fa57986c2309 100644 +--- a/drivers/iommu/amd/init.c ++++ b/drivers/iommu/amd/init.c +@@ -1914,8 +1914,8 @@ static void print_iommu_info(void) + pci_info(pdev, "Found IOMMU cap 0x%hx\n", iommu->cap_ptr); + + if (iommu->cap & (1 << IOMMU_CAP_EFR)) { +- pci_info(pdev, "Extended features (%#llx):", +- iommu->features); ++ pr_info("Extended features (%#llx):", iommu->features); ++ + for (i = 0; i < ARRAY_SIZE(feat_str); ++i) { + if (iommu_feature(iommu, (1ULL << i))) + pr_cont(" %s", feat_str[i]); +-- +2.30.2 + diff --git a/queue-5.10/iommu-dma-fix-iova-reserve-dma-ranges.patch b/queue-5.10/iommu-dma-fix-iova-reserve-dma-ranges.patch new file mode 100644 index 00000000000..d373b57fec3 --- /dev/null +++ b/queue-5.10/iommu-dma-fix-iova-reserve-dma-ranges.patch @@ -0,0 +1,44 @@ +From 98642c85cfdce8950c7612639ebc8c6255045276 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Sep 2020 12:53:19 +0530 +Subject: iommu/dma: Fix IOVA reserve dma ranges + +From: Srinath Mannam + +[ Upstream commit 571f316074a203e979ea90211d9acf423dfe5f46 ] + +Fix IOVA reserve failure in the case when address of first memory region +listed in dma-ranges is equal to 0x0. + +Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address") +Signed-off-by: Srinath Mannam +Reviewed-by: Robin Murphy +Tested-by: Sven Peter +Link: https://lore.kernel.org/r/20200914072319.6091-1-srinath.mannam@broadcom.com +Signed-off-by: Joerg Roedel +Signed-off-by: Sasha Levin +--- + drivers/iommu/dma-iommu.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c +index 0cbcd3fc3e7e..840dd2b66ce7 100644 +--- a/drivers/iommu/dma-iommu.c ++++ b/drivers/iommu/dma-iommu.c +@@ -216,9 +216,11 @@ resv_iova: + lo = iova_pfn(iovad, start); + hi = iova_pfn(iovad, end); + reserve_iova(iovad, lo, hi); +- } else { ++ } else if (end < start) { + /* dma_ranges list should be sorted */ +- dev_err(&dev->dev, "Failed to reserve IOVA\n"); ++ dev_err(&dev->dev, ++ "Failed to reserve IOVA [%#010llx-%#010llx]\n", ++ start, end); + return -EINVAL; + } + +-- +2.30.2 + diff --git a/queue-5.10/ip6_tunnel-fix-gre6-segmentation.patch b/queue-5.10/ip6_tunnel-fix-gre6-segmentation.patch new file mode 100644 index 00000000000..57cb0c13c0d --- /dev/null +++ b/queue-5.10/ip6_tunnel-fix-gre6-segmentation.patch @@ -0,0 +1,60 @@ +From 3f82a30c00731f0f5e46312fd449d79a025c8bff Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 18:52:54 -0700 +Subject: ip6_tunnel: fix GRE6 segmentation + +From: Jakub Kicinski + +[ Upstream commit a6e3f2985a80ef6a45a17d2d9d9151f17ea3ce07 ] + +Commit 6c11fbf97e69 ("ip6_tunnel: add MPLS transmit support") +moved assiging inner_ipproto down from ipxip6_tnl_xmit() to +its callee ip6_tnl_xmit(). The latter is also used by GRE. + +Since commit 38720352412a ("gre: Use inner_proto to obtain inner +header protocol") GRE had been depending on skb->inner_protocol +during segmentation. It sets it in gre_build_header() and reads +it in gre_gso_segment(). Changes to ip6_tnl_xmit() overwrite +the protocol, resulting in GSO skbs getting dropped. + +Note that inner_protocol is a union with inner_ipproto, +GRE uses the former while the change switched it to the latter +(always setting it to just IPPROTO_GRE). + +Restore the original location of skb_set_inner_ipproto(), +it is unclear why it was moved in the first place. + +Fixes: 6c11fbf97e69 ("ip6_tunnel: add MPLS transmit support") +Signed-off-by: Jakub Kicinski +Tested-by: Vadim Fedorenko +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv6/ip6_tunnel.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c +index 42ca2d05c480..08441f06afd4 100644 +--- a/net/ipv6/ip6_tunnel.c ++++ b/net/ipv6/ip6_tunnel.c +@@ -1270,8 +1270,6 @@ route_lookup: + if (max_headroom > dev->needed_headroom) + dev->needed_headroom = max_headroom; + +- skb_set_inner_ipproto(skb, proto); +- + err = ip6_tnl_encap(skb, t, &proto, fl6); + if (err) + return err; +@@ -1408,6 +1406,8 @@ ipxip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev, + if (iptunnel_handle_offloads(skb, SKB_GSO_IPXIP6)) + return -1; + ++ skb_set_inner_ipproto(skb, protocol); ++ + err = ip6_tnl_xmit(skb, dev, dsfield, &fl6, encap_limit, &mtu, + protocol); + if (err != 0) { +-- +2.30.2 + diff --git a/queue-5.10/ipv6-exthdrs-do-not-blindly-use-init_net.patch b/queue-5.10/ipv6-exthdrs-do-not-blindly-use-init_net.patch new file mode 100644 index 00000000000..489a514afdc --- /dev/null +++ b/queue-5.10/ipv6-exthdrs-do-not-blindly-use-init_net.patch @@ -0,0 +1,61 @@ +From 66dc2b4aab68659bffb69cec55bb519ac25e0d3f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 08:27:00 -0700 +Subject: ipv6: exthdrs: do not blindly use init_net + +From: Eric Dumazet + +[ Upstream commit bcc3f2a829b9edbe3da5fb117ee5a63686d31834 ] + +I see no reason why max_dst_opts_cnt and max_hbh_opts_cnt +are fetched from the initial net namespace. + +The other sysctls (max_dst_opts_len & max_hbh_opts_len) +are in fact already using the current ns. + +Note: it is not clear why ipv6_destopt_rcv() use two ways to +get to the netns : + + 1) dev_net(dst->dev) + Originally used to increment IPSTATS_MIB_INHDRERRORS + + 2) dev_net(skb->dev) + Tom used this variant in his patch. + +Maybe this calls to use ipv6_skb_net() instead ? + +Fixes: 47d3d7ac656a ("ipv6: Implement limits on Hop-by-Hop and Destination options") +Signed-off-by: Eric Dumazet +Cc: Tom Herbert +Cc: Coco Li +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv6/exthdrs.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c +index 374105e4394f..15223451cd7f 100644 +--- a/net/ipv6/exthdrs.c ++++ b/net/ipv6/exthdrs.c +@@ -306,7 +306,7 @@ fail_and_free: + #endif + + if (ip6_parse_tlv(tlvprocdestopt_lst, skb, +- init_net.ipv6.sysctl.max_dst_opts_cnt)) { ++ net->ipv6.sysctl.max_dst_opts_cnt)) { + skb->transport_header += extlen; + opt = IP6CB(skb); + #if IS_ENABLED(CONFIG_IPV6_MIP6) +@@ -1041,7 +1041,7 @@ fail_and_free: + + opt->flags |= IP6SKB_HOPBYHOP; + if (ip6_parse_tlv(tlvprochopopt_lst, skb, +- init_net.ipv6.sysctl.max_hbh_opts_cnt)) { ++ net->ipv6.sysctl.max_hbh_opts_cnt)) { + skb->transport_header += extlen; + opt = IP6CB(skb); + opt->nhoff = sizeof(struct ipv6hdr); +-- +2.30.2 + diff --git a/queue-5.10/ipv6-fix-out-of-bound-access-in-ip6_parse_tlv.patch b/queue-5.10/ipv6-fix-out-of-bound-access-in-ip6_parse_tlv.patch new file mode 100644 index 00000000000..b458646a401 --- /dev/null +++ b/queue-5.10/ipv6-fix-out-of-bound-access-in-ip6_parse_tlv.patch @@ -0,0 +1,89 @@ +From 0d37fc5ca9cefe9d3e0db51c2733c6476a7996ec Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 03:07:20 -0700 +Subject: ipv6: fix out-of-bound access in ip6_parse_tlv() + +From: Eric Dumazet + +[ Upstream commit 624085a31c1ad6a80b1e53f686bf6ee92abbf6e8 ] + +First problem is that optlen is fetched without checking +there is more than one byte to parse. + +Fix this by taking care of IPV6_TLV_PAD1 before +fetching optlen (under appropriate sanity checks against len) + +Second problem is that IPV6_TLV_PADN checks of zero +padding are performed before the check of remaining length. + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Fixes: c1412fce7ecc ("net/ipv6/exthdrs.c: Strict PadN option checking") +Signed-off-by: Eric Dumazet +Cc: Paolo Abeni +Cc: Tom Herbert +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv6/exthdrs.c | 27 +++++++++++++-------------- + 1 file changed, 13 insertions(+), 14 deletions(-) + +diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c +index 15223451cd7f..4932dea9820b 100644 +--- a/net/ipv6/exthdrs.c ++++ b/net/ipv6/exthdrs.c +@@ -135,18 +135,23 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs, + len -= 2; + + while (len > 0) { +- int optlen = nh[off + 1] + 2; +- int i; ++ int optlen, i; + +- switch (nh[off]) { +- case IPV6_TLV_PAD1: +- optlen = 1; ++ if (nh[off] == IPV6_TLV_PAD1) { + padlen++; + if (padlen > 7) + goto bad; +- break; ++ off++; ++ len--; ++ continue; ++ } ++ if (len < 2) ++ goto bad; ++ optlen = nh[off + 1] + 2; ++ if (optlen > len) ++ goto bad; + +- case IPV6_TLV_PADN: ++ if (nh[off] == IPV6_TLV_PADN) { + /* RFC 2460 states that the purpose of PadN is + * to align the containing header to multiples + * of 8. 7 is therefore the highest valid value. +@@ -163,12 +168,7 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs, + if (nh[off + i] != 0) + goto bad; + } +- break; +- +- default: /* Other TLV code so scan list */ +- if (optlen > len) +- goto bad; +- ++ } else { + tlv_count++; + if (tlv_count > max_count) + goto bad; +@@ -188,7 +188,6 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs, + return false; + + padlen = 0; +- break; + } + off += optlen; + len -= optlen; +-- +2.30.2 + diff --git a/queue-5.10/iwlwifi-increase-pnvm-load-timeout.patch b/queue-5.10/iwlwifi-increase-pnvm-load-timeout.patch new file mode 100644 index 00000000000..e25aed7c44b --- /dev/null +++ b/queue-5.10/iwlwifi-increase-pnvm-load-timeout.patch @@ -0,0 +1,48 @@ +From 70d71c575e3b9adfb9d457cc31da29beea396a1c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 12 Jun 2021 14:32:40 +0300 +Subject: iwlwifi: increase PNVM load timeout + +From: Luca Coelho + +[ Upstream commit 5cc816ef9db1fe03f73e56e9d8f118add9c6efe4 ] + +The FW has a watchdog of 200ms in the PNVM load flow, so the driver +should have a slightly higher timeout. Change the timeout from 100ms +to 250ms. + +Signed-off-by: Luca Coelho +Fixes: 70d3ca86b025 ("iwlwifi: mvm: ring the doorbell and wait for PNVM load completion") +Signed-off-by: Luca Coelho +Link: https://lore.kernel.org/r/iwlwifi.20210612142637.ba22aec1e2be.I36bfadc28c480f4fc57266c075a79e8ea4a6934f@changeid +Signed-off-by: Luca Coelho +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/fw/pnvm.h | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h +index e4f91bce222d..61d3d4e0b7d9 100644 +--- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h ++++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h +@@ -1,7 +1,7 @@ + /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ + /****************************************************************************** + * +- * Copyright(c) 2020 Intel Corporation ++ * Copyright(c) 2020-2021 Intel Corporation + * + *****************************************************************************/ + +@@ -10,7 +10,7 @@ + + #include "fw/notif-wait.h" + +-#define MVM_UCODE_PNVM_TIMEOUT (HZ / 10) ++#define MVM_UCODE_PNVM_TIMEOUT (HZ / 4) + + int iwl_pnvm_load(struct iwl_trans *trans, + struct iwl_notif_wait_data *notif_wait); +-- +2.30.2 + diff --git a/queue-5.10/kbuild-fix-objtool-dependency-for-object_files_non_s.patch b/queue-5.10/kbuild-fix-objtool-dependency-for-object_files_non_s.patch new file mode 100644 index 00000000000..5518b1e0ca5 --- /dev/null +++ b/queue-5.10/kbuild-fix-objtool-dependency-for-object_files_non_s.patch @@ -0,0 +1,61 @@ +From 2d5462f93ca5c0357bf761aa11cf47c9b2c9062b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 18:59:15 -0500 +Subject: kbuild: Fix objtool dependency for 'OBJECT_FILES_NON_STANDARD_ + := n' + +From: Josh Poimboeuf + +[ Upstream commit 8852c552402979508fdc395ae07aa8761aa46045 ] + +"OBJECT_FILES_NON_STANDARD_vma.o := n" has a dependency bug. When +objtool source is updated, the affected object doesn't get re-analyzed +by objtool. + +Peter's new variable-sized jump label feature relies on objtool +rewriting the object file. Otherwise the system can fail to boot. That +effectively upgrades this minor dependency issue to a major bug. + +The problem is that variables in prerequisites are expanded early, +during the read-in phase. The '$(objtool_dep)' variable indirectly uses +'$@', which isn't yet available when the target prerequisites are +evaluated. + +Use '.SECONDEXPANSION:' which causes '$(objtool_dep)' to be expanded in +a later phase, after the target-specific '$@' variable has been defined. + +Fixes: b9ab5ebb14ec ("objtool: Add CONFIG_STACK_VALIDATION option") +Fixes: ab3257042c26 ("jump_label, x86: Allow short NOPs") +Reported-by: Matthew Wilcox +Signed-off-by: Josh Poimboeuf +Signed-off-by: Sasha Levin +--- + scripts/Makefile.build | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/scripts/Makefile.build b/scripts/Makefile.build +index 4c058f12dd73..8bd4e673383f 100644 +--- a/scripts/Makefile.build ++++ b/scripts/Makefile.build +@@ -275,7 +275,8 @@ define rule_as_o_S + endef + + # Built-in and composite module parts +-$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE ++.SECONDEXPANSION: ++$(obj)/%.o: $(src)/%.c $(recordmcount_source) $$(objtool_dep) FORCE + $(call if_changed_rule,cc_o_c) + $(call cmd,force_checksrc) + +@@ -356,7 +357,7 @@ cmd_modversions_S = \ + fi + endif + +-$(obj)/%.o: $(src)/%.S $(objtool_dep) FORCE ++$(obj)/%.o: $(src)/%.S $$(objtool_dep) FORCE + $(call if_changed_rule,as_o_S) + + targets += $(filter-out $(subdir-builtin), $(real-obj-y)) +-- +2.30.2 + diff --git a/queue-5.10/kthread_worker-fix-return-value-when-kthread_mod_del.patch b/queue-5.10/kthread_worker-fix-return-value-when-kthread_mod_del.patch new file mode 100644 index 00000000000..c4672a80e1f --- /dev/null +++ b/queue-5.10/kthread_worker-fix-return-value-when-kthread_mod_del.patch @@ -0,0 +1,99 @@ +From 05dd9aab09b2a0853b267bdaf4a16af626320c9c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:33:35 -0700 +Subject: kthread_worker: fix return value when kthread_mod_delayed_work() + races with kthread_cancel_delayed_work_sync() + +From: Petr Mladek + +[ Upstream commit d71ba1649fa3c464c51ec7163e4b817345bff2c7 ] + +kthread_mod_delayed_work() might race with +kthread_cancel_delayed_work_sync() or another kthread_mod_delayed_work() +call. The function lets the other operation win when it sees +work->canceling counter set. And it returns @false. + +But it should return @true as it is done by the related workqueue API, see +mod_delayed_work_on(). + +The reason is that the return value might be used for reference counting. +It has to distinguish the case when the number of queued works has changed +or stayed the same. + +The change is safe. kthread_mod_delayed_work() return value is not +checked anywhere at the moment. + +Link: https://lore.kernel.org/r/20210521163526.GA17916@redhat.com +Link: https://lkml.kernel.org/r/20210610133051.15337-4-pmladek@suse.com +Signed-off-by: Petr Mladek +Reported-by: Oleg Nesterov +Cc: Nathan Chancellor +Cc: Nick Desaulniers +Cc: Tejun Heo +Cc: Minchan Kim +Cc: +Cc: Martin Liu +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + kernel/kthread.c | 19 ++++++++++++------- + 1 file changed, 12 insertions(+), 7 deletions(-) + +diff --git a/kernel/kthread.c b/kernel/kthread.c +index 36be4364b313..9825cf89c614 100644 +--- a/kernel/kthread.c ++++ b/kernel/kthread.c +@@ -1107,14 +1107,14 @@ static bool __kthread_cancel_work(struct kthread_work *work) + * modify @dwork's timer so that it expires after @delay. If @delay is zero, + * @work is guaranteed to be queued immediately. + * +- * Return: %true if @dwork was pending and its timer was modified, +- * %false otherwise. ++ * Return: %false if @dwork was idle and queued, %true otherwise. + * + * A special case is when the work is being canceled in parallel. + * It might be caused either by the real kthread_cancel_delayed_work_sync() + * or yet another kthread_mod_delayed_work() call. We let the other command +- * win and return %false here. The caller is supposed to synchronize these +- * operations a reasonable way. ++ * win and return %true here. The return value can be used for reference ++ * counting and the number of queued works stays the same. Anyway, the caller ++ * is supposed to synchronize these operations a reasonable way. + * + * This function is safe to call from any context including IRQ handler. + * See __kthread_cancel_work() and kthread_delayed_work_timer_fn() +@@ -1126,13 +1126,15 @@ bool kthread_mod_delayed_work(struct kthread_worker *worker, + { + struct kthread_work *work = &dwork->work; + unsigned long flags; +- int ret = false; ++ int ret; + + raw_spin_lock_irqsave(&worker->lock, flags); + + /* Do not bother with canceling when never queued. */ +- if (!work->worker) ++ if (!work->worker) { ++ ret = false; + goto fast_queue; ++ } + + /* Work must not be used with >1 worker, see kthread_queue_work() */ + WARN_ON_ONCE(work->worker != worker); +@@ -1150,8 +1152,11 @@ bool kthread_mod_delayed_work(struct kthread_worker *worker, + * be used for reference counting. + */ + kthread_cancel_delayed_work_timer(work, &flags); +- if (work->canceling) ++ if (work->canceling) { ++ /* The number of works in the queue does not change. */ ++ ret = true; + goto out; ++ } + ret = __kthread_cancel_work(work); + + fast_queue: +-- +2.30.2 + diff --git a/queue-5.10/kvm-arm64-don-t-zero-the-cycle-count-register-when-p.patch b/queue-5.10/kvm-arm64-don-t-zero-the-cycle-count-register-when-p.patch new file mode 100644 index 00000000000..86c00739207 --- /dev/null +++ b/queue-5.10/kvm-arm64-don-t-zero-the-cycle-count-register-when-p.patch @@ -0,0 +1,42 @@ +From 3b4cba513f1a99bb0cd0192a4484c19fea074748 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 11:51:39 +0100 +Subject: KVM: arm64: Don't zero the cycle count register when PMCR_EL0.P is + set + +From: Alexandru Elisei + +[ Upstream commit 2a71fabf6a1bc9162a84e18d6ab991230ca4d588 ] + +According to ARM DDI 0487G.a, page D13-3895, setting the PMCR_EL0.P bit to +1 has the following effect: + +"Reset all event counters accessible in the current Exception level, not +including PMCCNTR_EL0, to zero." + +Similar behaviour is described for AArch32 on page G8-7022. Make it so. + +Fixes: c01d6a18023b ("KVM: arm64: pmu: Only handle supported event counters") +Signed-off-by: Alexandru Elisei +Signed-off-by: Marc Zyngier +Link: https://lore.kernel.org/r/20210618105139.83795-1-alexandru.elisei@arm.com +Signed-off-by: Sasha Levin +--- + arch/arm64/kvm/pmu-emul.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c +index 2dd164bb1c5a..4b30260e1abf 100644 +--- a/arch/arm64/kvm/pmu-emul.c ++++ b/arch/arm64/kvm/pmu-emul.c +@@ -578,6 +578,7 @@ void kvm_pmu_handle_pmcr(struct kvm_vcpu *vcpu, u64 val) + kvm_pmu_set_counter_value(vcpu, ARMV8_PMU_CYCLE_IDX, 0); + + if (val & ARMV8_PMU_PMCR_P) { ++ mask &= ~BIT(ARMV8_PMU_CYCLE_IDX); + for_each_set_bit(i, &mask, 32) + kvm_pmu_set_counter_value(vcpu, i, 0); + } +-- +2.30.2 + diff --git a/queue-5.10/kvm-nvmx-don-t-clobber-nested-mmu-s-a-d-status-on-ep.patch b/queue-5.10/kvm-nvmx-don-t-clobber-nested-mmu-s-a-d-status-on-ep.patch new file mode 100644 index 00000000000..f80488ab207 --- /dev/null +++ b/queue-5.10/kvm-nvmx-don-t-clobber-nested-mmu-s-a-d-status-on-ep.patch @@ -0,0 +1,70 @@ +From 8a3474a452415415873fa1a8fd7056289331d15b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 16:42:23 -0700 +Subject: KVM: nVMX: Don't clobber nested MMU's A/D status on EPTP switch + +From: Sean Christopherson + +[ Upstream commit 272b0a998d084e7667284bdd2d0c675c6a2d11de ] + +Drop bogus logic that incorrectly clobbers the accessed/dirty enabling +status of the nested MMU on an EPTP switch. When nested EPT is enabled, +walk_mmu points at L2's _legacy_ page tables, not L1's EPT for L2. + +This is likely a benign bug, as mmu->ept_ad is never consumed (since the +MMU is not a nested EPT MMU), and stuffing mmu_role.base.ad_disabled will +never propagate into future shadow pages since the nested MMU isn't used +to map anything, just to walk L2's page tables. + +Note, KVM also does a full MMU reload, i.e. the guest_mmu will be +recreated using the new EPTP, and thus any change in A/D enabling will be +properly recognized in the relevant MMU. + +Fixes: 41ab93727467 ("KVM: nVMX: Emulate EPTP switching for the L1 hypervisor") +Signed-off-by: Sean Christopherson +Message-Id: <20210609234235.1244004-4-seanjc@google.com> +Signed-off-by: Paolo Bonzini +Signed-off-by: Sasha Levin +--- + arch/x86/kvm/vmx/nested.c | 7 ------- + 1 file changed, 7 deletions(-) + +diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c +index 8f1319b7d3bd..67554bc7adb2 100644 +--- a/arch/x86/kvm/vmx/nested.c ++++ b/arch/x86/kvm/vmx/nested.c +@@ -5484,8 +5484,6 @@ static int nested_vmx_eptp_switching(struct kvm_vcpu *vcpu, + { + u32 index = kvm_rcx_read(vcpu); + u64 new_eptp; +- bool accessed_dirty; +- struct kvm_mmu *mmu = vcpu->arch.walk_mmu; + + if (!nested_cpu_has_eptp_switching(vmcs12) || + !nested_cpu_has_ept(vmcs12)) +@@ -5494,13 +5492,10 @@ static int nested_vmx_eptp_switching(struct kvm_vcpu *vcpu, + if (index >= VMFUNC_EPTP_ENTRIES) + return 1; + +- + if (kvm_vcpu_read_guest_page(vcpu, vmcs12->eptp_list_address >> PAGE_SHIFT, + &new_eptp, index * 8, 8)) + return 1; + +- accessed_dirty = !!(new_eptp & VMX_EPTP_AD_ENABLE_BIT); +- + /* + * If the (L2) guest does a vmfunc to the currently + * active ept pointer, we don't have to do anything else +@@ -5509,8 +5504,6 @@ static int nested_vmx_eptp_switching(struct kvm_vcpu *vcpu, + if (!nested_vmx_check_eptp(vcpu, new_eptp)) + return 1; + +- mmu->ept_ad = accessed_dirty; +- mmu->mmu_role.base.ad_disabled = !accessed_dirty; + vmcs12->ept_pointer = new_eptp; + + kvm_make_request(KVM_REQ_MMU_RELOAD, vcpu); +-- +2.30.2 + diff --git a/queue-5.10/kvm-nvmx-ensure-64-bit-shift-when-checking-vmfunc-bi.patch b/queue-5.10/kvm-nvmx-ensure-64-bit-shift-when-checking-vmfunc-bi.patch new file mode 100644 index 00000000000..6c01e4d6b41 --- /dev/null +++ b/queue-5.10/kvm-nvmx-ensure-64-bit-shift-when-checking-vmfunc-bi.patch @@ -0,0 +1,54 @@ +From 44486ee666011f231fd660aee04c1054ab3f71dc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 16:42:22 -0700 +Subject: KVM: nVMX: Ensure 64-bit shift when checking VMFUNC bitmap + +From: Sean Christopherson + +[ Upstream commit 0e75225dfa4c5d5d51291f54a3d2d5895bad38da ] + +Use BIT_ULL() instead of an open-coded shift to check whether or not a +function is enabled in L1's VMFUNC bitmap. This is a benign bug as KVM +supports only bit 0, and will fail VM-Enter if any other bits are set, +i.e. bits 63:32 are guaranteed to be zero. + +Note, "function" is bounded by hardware as VMFUNC will #UD before taking +a VM-Exit if the function is greater than 63. + +Before: + if ((vmcs12->vm_function_control & (1 << function)) == 0) + 0x000000000001a916 <+118>: mov $0x1,%eax + 0x000000000001a91b <+123>: shl %cl,%eax + 0x000000000001a91d <+125>: cltq + 0x000000000001a91f <+127>: and 0x128(%rbx),%rax + +After: + if (!(vmcs12->vm_function_control & BIT_ULL(function & 63))) + 0x000000000001a955 <+117>: mov 0x128(%rbx),%rdx + 0x000000000001a95c <+124>: bt %rax,%rdx + +Fixes: 27c42a1bb867 ("KVM: nVMX: Enable VMFUNC for the L1 hypervisor") +Signed-off-by: Sean Christopherson +Message-Id: <20210609234235.1244004-3-seanjc@google.com> +Signed-off-by: Paolo Bonzini +Signed-off-by: Sasha Levin +--- + arch/x86/kvm/vmx/nested.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c +index 4cd998bb1f0a..8f1319b7d3bd 100644 +--- a/arch/x86/kvm/vmx/nested.c ++++ b/arch/x86/kvm/vmx/nested.c +@@ -5536,7 +5536,7 @@ static int handle_vmfunc(struct kvm_vcpu *vcpu) + } + + vmcs12 = get_vmcs12(vcpu); +- if ((vmcs12->vm_function_control & (1 << function)) == 0) ++ if (!(vmcs12->vm_function_control & BIT_ULL(function))) + goto fail; + + switch (function) { +-- +2.30.2 + diff --git a/queue-5.10/kvm-nvmx-sync-all-pgds-on-nested-transition-with-sha.patch b/queue-5.10/kvm-nvmx-sync-all-pgds-on-nested-transition-with-sha.patch new file mode 100644 index 00000000000..e2f7bbd3a8d --- /dev/null +++ b/queue-5.10/kvm-nvmx-sync-all-pgds-on-nested-transition-with-sha.patch @@ -0,0 +1,113 @@ +From 0f7c4343da2a571821874771579dca61f92c6ec0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Jun 2021 16:42:21 -0700 +Subject: KVM: nVMX: Sync all PGDs on nested transition with shadow paging + +From: Sean Christopherson + +[ Upstream commit 07ffaf343e34b555c9e7ea39a9c81c439a706f13 ] + +Trigger a full TLB flush on behalf of the guest on nested VM-Enter and +VM-Exit when VPID is disabled for L2. kvm_mmu_new_pgd() syncs only the +current PGD, which can theoretically leave stale, unsync'd entries in a +previous guest PGD, which could be consumed if L2 is allowed to load CR3 +with PCID_NOFLUSH=1. + +Rename KVM_REQ_HV_TLB_FLUSH to KVM_REQ_TLB_FLUSH_GUEST so that it can +be utilized for its obvious purpose of emulating a guest TLB flush. + +Note, there is no change the actual TLB flush executed by KVM, even +though the fast PGD switch uses KVM_REQ_TLB_FLUSH_CURRENT. When VPID is +disabled for L2, vpid02 is guaranteed to be '0', and thus +nested_get_vpid02() will return the VPID that is shared by L1 and L2. + +Generate the request outside of kvm_mmu_new_pgd(), as getting the common +helper to correctly identify which requested is needed is quite painful. +E.g. using KVM_REQ_TLB_FLUSH_GUEST when nested EPT is in play is wrong as +a TLB flush from the L1 kernel's perspective does not invalidate EPT +mappings. And, by using KVM_REQ_TLB_FLUSH_GUEST, nVMX can do future +simplification by moving the logic into nested_vmx_transition_tlb_flush(). + +Fixes: 41fab65e7c44 ("KVM: nVMX: Skip MMU sync on nested VMX transition when possible") +Signed-off-by: Sean Christopherson +Message-Id: <20210609234235.1244004-2-seanjc@google.com> +Signed-off-by: Paolo Bonzini +Signed-off-by: Sasha Levin +--- + arch/x86/include/asm/kvm_host.h | 2 +- + arch/x86/kvm/hyperv.c | 2 +- + arch/x86/kvm/vmx/nested.c | 17 ++++++++++++----- + arch/x86/kvm/x86.c | 2 +- + 4 files changed, 15 insertions(+), 8 deletions(-) + +diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h +index d1ac2de41ea8..b1cd8334db11 100644 +--- a/arch/x86/include/asm/kvm_host.h ++++ b/arch/x86/include/asm/kvm_host.h +@@ -84,7 +84,7 @@ + #define KVM_REQ_APICV_UPDATE \ + KVM_ARCH_REQ_FLAGS(25, KVM_REQUEST_WAIT | KVM_REQUEST_NO_WAKEUP) + #define KVM_REQ_TLB_FLUSH_CURRENT KVM_ARCH_REQ(26) +-#define KVM_REQ_HV_TLB_FLUSH \ ++#define KVM_REQ_TLB_FLUSH_GUEST \ + KVM_ARCH_REQ_FLAGS(27, KVM_REQUEST_NO_WAKEUP) + #define KVM_REQ_APF_READY KVM_ARCH_REQ(28) + #define KVM_REQ_MSR_FILTER_CHANGED KVM_ARCH_REQ(29) +diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c +index 5c7c4060b45c..bb39f493447c 100644 +--- a/arch/x86/kvm/hyperv.c ++++ b/arch/x86/kvm/hyperv.c +@@ -1564,7 +1564,7 @@ static u64 kvm_hv_flush_tlb(struct kvm_vcpu *current_vcpu, u64 ingpa, + * vcpu->arch.cr3 may not be up-to-date for running vCPUs so we can't + * analyze it here, flush TLB regardless of the specified address space. + */ +- kvm_make_vcpus_request_mask(kvm, KVM_REQ_HV_TLB_FLUSH, ++ kvm_make_vcpus_request_mask(kvm, KVM_REQ_TLB_FLUSH_GUEST, + NULL, vcpu_mask, &hv_vcpu->tlb_flush); + + ret_success: +diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c +index ec8803bdc575..4cd998bb1f0a 100644 +--- a/arch/x86/kvm/vmx/nested.c ++++ b/arch/x86/kvm/vmx/nested.c +@@ -1142,12 +1142,19 @@ static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool ne + + /* + * Unconditionally skip the TLB flush on fast CR3 switch, all TLB +- * flushes are handled by nested_vmx_transition_tlb_flush(). See +- * nested_vmx_transition_mmu_sync for details on skipping the MMU sync. ++ * flushes are handled by nested_vmx_transition_tlb_flush(). + */ +- if (!nested_ept) +- kvm_mmu_new_pgd(vcpu, cr3, true, +- !nested_vmx_transition_mmu_sync(vcpu)); ++ if (!nested_ept) { ++ kvm_mmu_new_pgd(vcpu, cr3, true, true); ++ ++ /* ++ * A TLB flush on VM-Enter/VM-Exit flushes all linear mappings ++ * across all PCIDs, i.e. all PGDs need to be synchronized. ++ * See nested_vmx_transition_mmu_sync() for more details. ++ */ ++ if (nested_vmx_transition_mmu_sync(vcpu)) ++ kvm_make_request(KVM_REQ_TLB_FLUSH_GUEST, vcpu); ++ } + + vcpu->arch.cr3 = cr3; + kvm_register_mark_available(vcpu, VCPU_EXREG_CR3); +diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c +index d3372cb97307..7bf88e6cbd0e 100644 +--- a/arch/x86/kvm/x86.c ++++ b/arch/x86/kvm/x86.c +@@ -8852,7 +8852,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) + } + if (kvm_check_request(KVM_REQ_TLB_FLUSH_CURRENT, vcpu)) + kvm_vcpu_flush_tlb_current(vcpu); +- if (kvm_check_request(KVM_REQ_HV_TLB_FLUSH, vcpu)) ++ if (kvm_check_request(KVM_REQ_TLB_FLUSH_GUEST, vcpu)) + kvm_vcpu_flush_tlb_guest(vcpu); + + if (kvm_check_request(KVM_REQ_REPORT_TPR_ACCESS, vcpu)) { +-- +2.30.2 + diff --git a/queue-5.10/kvm-ppc-book3s-hv-fix-tlb-management-on-smt8-power9-.patch b/queue-5.10/kvm-ppc-book3s-hv-fix-tlb-management-on-smt8-power9-.patch new file mode 100644 index 00000000000..deb0e89478f --- /dev/null +++ b/queue-5.10/kvm-ppc-book3s-hv-fix-tlb-management-on-smt8-power9-.patch @@ -0,0 +1,142 @@ +From 4508698d83c140c8b3aaf52cbe4af9c92258e677 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 2 Jun 2021 14:04:41 +1000 +Subject: KVM: PPC: Book3S HV: Fix TLB management on SMT8 POWER9 and POWER10 + processors + +From: Suraj Jitindar Singh + +[ Upstream commit 77bbbc0cf84834ed130838f7ac1988567f4d0288 ] + +The POWER9 vCPU TLB management code assumes all threads in a core share +a TLB, and that TLBIEL execued by one thread will invalidate TLBs for +all threads. This is not the case for SMT8 capable POWER9 and POWER10 +(big core) processors, where the TLB is split between groups of threads. +This results in TLB multi-hits, random data corruption, etc. + +Fix this by introducing cpu_first_tlb_thread_sibling etc., to determine +which siblings share TLBs, and use that in the guest TLB flushing code. + +[npiggin@gmail.com: add changelog and comment] + +Signed-off-by: Paul Mackerras +Signed-off-by: Nicholas Piggin +Reviewed-by: Fabiano Rosas +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210602040441.3984352-1-npiggin@gmail.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/include/asm/cputhreads.h | 30 +++++++++++++++++++++++++++ + arch/powerpc/kvm/book3s_hv.c | 13 ++++++------ + arch/powerpc/kvm/book3s_hv_builtin.c | 2 +- + arch/powerpc/kvm/book3s_hv_rm_mmu.c | 2 +- + 4 files changed, 39 insertions(+), 8 deletions(-) + +diff --git a/arch/powerpc/include/asm/cputhreads.h b/arch/powerpc/include/asm/cputhreads.h +index 98c8bd155bf9..b167186aaee4 100644 +--- a/arch/powerpc/include/asm/cputhreads.h ++++ b/arch/powerpc/include/asm/cputhreads.h +@@ -98,6 +98,36 @@ static inline int cpu_last_thread_sibling(int cpu) + return cpu | (threads_per_core - 1); + } + ++/* ++ * tlb_thread_siblings are siblings which share a TLB. This is not ++ * architected, is not something a hypervisor could emulate and a future ++ * CPU may change behaviour even in compat mode, so this should only be ++ * used on PowerNV, and only with care. ++ */ ++static inline int cpu_first_tlb_thread_sibling(int cpu) ++{ ++ if (cpu_has_feature(CPU_FTR_ARCH_300) && (threads_per_core == 8)) ++ return cpu & ~0x6; /* Big Core */ ++ else ++ return cpu_first_thread_sibling(cpu); ++} ++ ++static inline int cpu_last_tlb_thread_sibling(int cpu) ++{ ++ if (cpu_has_feature(CPU_FTR_ARCH_300) && (threads_per_core == 8)) ++ return cpu | 0x6; /* Big Core */ ++ else ++ return cpu_last_thread_sibling(cpu); ++} ++ ++static inline int cpu_tlb_thread_sibling_step(void) ++{ ++ if (cpu_has_feature(CPU_FTR_ARCH_300) && (threads_per_core == 8)) ++ return 2; /* Big Core */ ++ else ++ return 1; ++} ++ + static inline u32 get_tensr(void) + { + #ifdef CONFIG_BOOKE +diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c +index 965b702208d8..2325b7a6e95f 100644 +--- a/arch/powerpc/kvm/book3s_hv.c ++++ b/arch/powerpc/kvm/book3s_hv.c +@@ -2578,7 +2578,7 @@ static void radix_flush_cpu(struct kvm *kvm, int cpu, struct kvm_vcpu *vcpu) + cpumask_t *cpu_in_guest; + int i; + +- cpu = cpu_first_thread_sibling(cpu); ++ cpu = cpu_first_tlb_thread_sibling(cpu); + if (nested) { + cpumask_set_cpu(cpu, &nested->need_tlb_flush); + cpu_in_guest = &nested->cpu_in_guest; +@@ -2592,9 +2592,10 @@ static void radix_flush_cpu(struct kvm *kvm, int cpu, struct kvm_vcpu *vcpu) + * the other side is the first smp_mb() in kvmppc_run_core(). + */ + smp_mb(); +- for (i = 0; i < threads_per_core; ++i) +- if (cpumask_test_cpu(cpu + i, cpu_in_guest)) +- smp_call_function_single(cpu + i, do_nothing, NULL, 1); ++ for (i = cpu; i <= cpu_last_tlb_thread_sibling(cpu); ++ i += cpu_tlb_thread_sibling_step()) ++ if (cpumask_test_cpu(i, cpu_in_guest)) ++ smp_call_function_single(i, do_nothing, NULL, 1); + } + + static void kvmppc_prepare_radix_vcpu(struct kvm_vcpu *vcpu, int pcpu) +@@ -2625,8 +2626,8 @@ static void kvmppc_prepare_radix_vcpu(struct kvm_vcpu *vcpu, int pcpu) + */ + if (prev_cpu != pcpu) { + if (prev_cpu >= 0 && +- cpu_first_thread_sibling(prev_cpu) != +- cpu_first_thread_sibling(pcpu)) ++ cpu_first_tlb_thread_sibling(prev_cpu) != ++ cpu_first_tlb_thread_sibling(pcpu)) + radix_flush_cpu(kvm, prev_cpu, vcpu); + if (nested) + nested->prev_cpu[vcpu->arch.nested_vcpu_id] = pcpu; +diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c b/arch/powerpc/kvm/book3s_hv_builtin.c +index 8f58dd20b362..4621905bdd9e 100644 +--- a/arch/powerpc/kvm/book3s_hv_builtin.c ++++ b/arch/powerpc/kvm/book3s_hv_builtin.c +@@ -893,7 +893,7 @@ void kvmppc_check_need_tlb_flush(struct kvm *kvm, int pcpu, + * Thus we make all 4 threads use the same bit. + */ + if (cpu_has_feature(CPU_FTR_ARCH_300)) +- pcpu = cpu_first_thread_sibling(pcpu); ++ pcpu = cpu_first_tlb_thread_sibling(pcpu); + + if (nested) + need_tlb_flush = &nested->need_tlb_flush; +diff --git a/arch/powerpc/kvm/book3s_hv_rm_mmu.c b/arch/powerpc/kvm/book3s_hv_rm_mmu.c +index 88da2764c1bb..3ddc83d2e849 100644 +--- a/arch/powerpc/kvm/book3s_hv_rm_mmu.c ++++ b/arch/powerpc/kvm/book3s_hv_rm_mmu.c +@@ -67,7 +67,7 @@ static int global_invalidates(struct kvm *kvm) + * so use the bit for the first thread to represent the core. + */ + if (cpu_has_feature(CPU_FTR_ARCH_300)) +- cpu = cpu_first_thread_sibling(cpu); ++ cpu = cpu_first_tlb_thread_sibling(cpu); + cpumask_clear_cpu(cpu, &kvm->arch.need_tlb_flush); + } + +-- +2.30.2 + diff --git a/queue-5.10/kvm-s390-get-rid-of-register-asm-usage.patch b/queue-5.10/kvm-s390-get-rid-of-register-asm-usage.patch new file mode 100644 index 00000000000..1ad54207917 --- /dev/null +++ b/queue-5.10/kvm-s390-get-rid-of-register-asm-usage.patch @@ -0,0 +1,78 @@ +From 255dc5e7dd1a7b6a303b7fe1b8c936bdac8f92d1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 16:03:56 +0200 +Subject: KVM: s390: get rid of register asm usage + +From: Heiko Carstens + +[ Upstream commit 4fa3b91bdee1b08348c82660668ca0ca34e271ad ] + +Using register asm statements has been proven to be very error prone, +especially when using code instrumentation where gcc may add function +calls, which clobbers register contents in an unexpected way. + +Therefore get rid of register asm statements in kvm code, even though +there is currently nothing wrong with them. This way we know for sure +that this bug class won't be introduced here. + +Signed-off-by: Heiko Carstens +Reviewed-by: Christian Borntraeger +Reviewed-by: Thomas Huth +Reviewed-by: Cornelia Huck +Reviewed-by: Claudio Imbrenda +Link: https://lore.kernel.org/r/20210621140356.1210771-1-hca@linux.ibm.com +[borntraeger@de.ibm.com: checkpatch strict fix] +Signed-off-by: Christian Borntraeger +Signed-off-by: Sasha Levin +--- + arch/s390/kvm/kvm-s390.c | 18 +++++++++--------- + 1 file changed, 9 insertions(+), 9 deletions(-) + +diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c +index 20afffd6b982..f94b4f78d4da 100644 +--- a/arch/s390/kvm/kvm-s390.c ++++ b/arch/s390/kvm/kvm-s390.c +@@ -327,31 +327,31 @@ static void allow_cpu_feat(unsigned long nr) + + static inline int plo_test_bit(unsigned char nr) + { +- register unsigned long r0 asm("0") = (unsigned long) nr | 0x100; ++ unsigned long function = (unsigned long)nr | 0x100; + int cc; + + asm volatile( ++ " lgr 0,%[function]\n" + /* Parameter registers are ignored for "test bit" */ + " plo 0,0,0,0(0)\n" + " ipm %0\n" + " srl %0,28\n" + : "=d" (cc) +- : "d" (r0) +- : "cc"); ++ : [function] "d" (function) ++ : "cc", "0"); + return cc == 0; + } + + static __always_inline void __insn32_query(unsigned int opcode, u8 *query) + { +- register unsigned long r0 asm("0") = 0; /* query function */ +- register unsigned long r1 asm("1") = (unsigned long) query; +- + asm volatile( +- /* Parameter regs are ignored */ ++ " lghi 0,0\n" ++ " lgr 1,%[query]\n" ++ /* Parameter registers are ignored */ + " .insn rrf,%[opc] << 16,2,4,6,0\n" + : +- : "d" (r0), "a" (r1), [opc] "i" (opcode) +- : "cc", "memory"); ++ : [query] "d" ((unsigned long)query), [opc] "i" (opcode) ++ : "cc", "memory", "0", "1"); + } + + #define INSN_SORTL 0xb938 +-- +2.30.2 + diff --git a/queue-5.10/kvm-x86-mmu-fix-return-value-in-tdp_mmu_map_handle_t.patch b/queue-5.10/kvm-x86-mmu-fix-return-value-in-tdp_mmu_map_handle_t.patch new file mode 100644 index 00000000000..660c75d9c56 --- /dev/null +++ b/queue-5.10/kvm-x86-mmu-fix-return-value-in-tdp_mmu_map_handle_t.patch @@ -0,0 +1,45 @@ +From ebb630bbfe07a54f4e50c7de8b00ba6a45033df0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Jun 2021 12:57:09 +1200 +Subject: KVM: x86/mmu: Fix return value in tdp_mmu_map_handle_target_level() + +From: Kai Huang + +[ Upstream commit 57a3e96d6d17ae5ac9861ef34af024a627f1c3bb ] + +Currently tdp_mmu_map_handle_target_level() returns 0, which is +RET_PF_RETRY, when page fault is actually fixed. This makes +kvm_tdp_mmu_map() also return RET_PF_RETRY in this case, instead of +RET_PF_FIXED. Fix by initializing ret to RET_PF_FIXED. + +Note that kvm_mmu_page_fault() resumes guest on both RET_PF_RETRY and +RET_PF_FIXED, which means in practice returning the two won't make +difference, so this fix alone won't be necessary for stable tree. + +Fixes: bb18842e2111 ("kvm: x86/mmu: Add TDP MMU PF handler") +Reviewed-by: Sean Christopherson +Reviewed-by: Ben Gardon +Signed-off-by: Kai Huang +Message-Id: +Signed-off-by: Paolo Bonzini +Signed-off-by: Sasha Levin +--- + arch/x86/kvm/mmu/tdp_mmu.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c +index 61c00f8631f1..f2ddf663e72e 100644 +--- a/arch/x86/kvm/mmu/tdp_mmu.c ++++ b/arch/x86/kvm/mmu/tdp_mmu.c +@@ -527,7 +527,7 @@ static int tdp_mmu_map_handle_target_level(struct kvm_vcpu *vcpu, int write, + kvm_pfn_t pfn, bool prefault) + { + u64 new_spte; +- int ret = 0; ++ int ret = RET_PF_FIXED; + int make_spte_ret = 0; + + if (unlikely(is_noslot_pfn(pfn))) { +-- +2.30.2 + diff --git a/queue-5.10/leds-as3645a-fix-error-return-code-in-as3645a_parse_.patch b/queue-5.10/leds-as3645a-fix-error-return-code-in-as3645a_parse_.patch new file mode 100644 index 00000000000..0676528f7e2 --- /dev/null +++ b/queue-5.10/leds-as3645a-fix-error-return-code-in-as3645a_parse_.patch @@ -0,0 +1,37 @@ +From 2ab44c409b22a8a6a3882406a4df642a3bd8e542 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 15 May 2021 11:06:46 +0800 +Subject: leds: as3645a: Fix error return code in as3645a_parse_node() + +From: Zhen Lei + +[ Upstream commit 96a30960a2c5246c8ffebe8a3c9031f9df094d97 ] + +Return error code -ENODEV rather than '0' when the indicator node can not +be found. + +Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver") +Reported-by: Hulk Robot +Acked-by: Sakari Ailus +Signed-off-by: Zhen Lei +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-as3645a.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c +index e8922fa03379..80411d41e802 100644 +--- a/drivers/leds/leds-as3645a.c ++++ b/drivers/leds/leds-as3645a.c +@@ -545,6 +545,7 @@ static int as3645a_parse_node(struct as3645a *flash, + if (!flash->indicator_node) { + dev_warn(&flash->client->dev, + "can't find indicator node\n"); ++ rval = -ENODEV; + goto out_err; + } + +-- +2.30.2 + diff --git a/queue-5.10/leds-class-the-enotsupp-should-never-be-seen-by-user.patch b/queue-5.10/leds-class-the-enotsupp-should-never-be-seen-by-user.patch new file mode 100644 index 00000000000..472ef8f8c4a --- /dev/null +++ b/queue-5.10/leds-class-the-enotsupp-should-never-be-seen-by-user.patch @@ -0,0 +1,39 @@ +From 78e50724639e7012f3c9be992dafd84761ddc3d4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:18 +0300 +Subject: leds: class: The -ENOTSUPP should never be seen by user space + +From: Andy Shevchenko + +[ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ] + +Drop the bogus error code and let of_led_get() to take care about absent +of_node. + +Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver") +Cc: Jean-Jacques Hiblot +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/led-class.c | 4 ---- + 1 file changed, 4 deletions(-) + +diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c +index 131ca83f5fb3..4365c1cc4505 100644 +--- a/drivers/leds/led-class.c ++++ b/drivers/leds/led-class.c +@@ -286,10 +286,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev, + if (!dev) + return ERR_PTR(-EINVAL); + +- /* Not using device tree? */ +- if (!IS_ENABLED(CONFIG_OF) || !dev->of_node) +- return ERR_PTR(-ENOTSUPP); +- + led = of_led_get(dev->of_node, index); + if (IS_ERR(led)) + return led; +-- +2.30.2 + diff --git a/queue-5.10/leds-ktd2692-fix-an-error-handling-path.patch b/queue-5.10/leds-ktd2692-fix-an-error-handling-path.patch new file mode 100644 index 00000000000..27b8a122dd6 --- /dev/null +++ b/queue-5.10/leds-ktd2692-fix-an-error-handling-path.patch @@ -0,0 +1,85 @@ +From 5f05e996d70edb7fdc8510680d7f287c44654511 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 13:21:01 +0200 +Subject: leds: ktd2692: Fix an error handling path + +From: Christophe JAILLET + +[ Upstream commit ee78b9360e14c276f5ceaa4a0d06f790f04ccdad ] + +In 'ktd2692_parse_dt()', if an error occurs after a successful +'regulator_enable()' call, we should call 'regulator_enable()'. + +This is the same in 'ktd2692_probe()', if an error occurs after a +successful 'ktd2692_parse_dt()' call. + +Instead of adding 'regulator_enable()' in several places, implement a +resource managed solution and simplify the remove function accordingly. + +Fixes: b7da8c5c725c ("leds: Add ktd2692 flash LED driver") +Signed-off-by: Christophe JAILLET +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-ktd2692.c | 27 ++++++++++++++++++--------- + 1 file changed, 18 insertions(+), 9 deletions(-) + +diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c +index 632f10db4b3f..f341da1503a4 100644 +--- a/drivers/leds/leds-ktd2692.c ++++ b/drivers/leds/leds-ktd2692.c +@@ -256,6 +256,17 @@ static void ktd2692_setup(struct ktd2692_context *led) + | KTD2692_REG_FLASH_CURRENT_BASE); + } + ++static void regulator_disable_action(void *_data) ++{ ++ struct device *dev = _data; ++ struct ktd2692_context *led = dev_get_drvdata(dev); ++ int ret; ++ ++ ret = regulator_disable(led->regulator); ++ if (ret) ++ dev_err(dev, "Failed to disable supply: %d\n", ret); ++} ++ + static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, + struct ktd2692_led_config_data *cfg) + { +@@ -286,8 +297,14 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, + + if (led->regulator) { + ret = regulator_enable(led->regulator); +- if (ret) ++ if (ret) { + dev_err(dev, "Failed to enable supply: %d\n", ret); ++ } else { ++ ret = devm_add_action_or_reset(dev, ++ regulator_disable_action, dev); ++ if (ret) ++ return ret; ++ } + } + + child_node = of_get_next_available_child(np, NULL); +@@ -377,17 +394,9 @@ static int ktd2692_probe(struct platform_device *pdev) + static int ktd2692_remove(struct platform_device *pdev) + { + struct ktd2692_context *led = platform_get_drvdata(pdev); +- int ret; + + led_classdev_flash_unregister(&led->fled_cdev); + +- if (led->regulator) { +- ret = regulator_disable(led->regulator); +- if (ret) +- dev_err(&pdev->dev, +- "Failed to disable supply: %d\n", ret); +- } +- + mutex_destroy(&led->lock); + + return 0; +-- +2.30.2 + diff --git a/queue-5.10/leds-lm3532-select-regmap-i2c-api.patch b/queue-5.10/leds-lm3532-select-regmap-i2c-api.patch new file mode 100644 index 00000000000..076e98fe9e4 --- /dev/null +++ b/queue-5.10/leds-lm3532-select-regmap-i2c-api.patch @@ -0,0 +1,37 @@ +From 3a6443cbc25473c22c2922db20f0dd5166617665 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:31 +0300 +Subject: leds: lm3532: select regmap I2C API + +From: Andy Shevchenko + +[ Upstream commit 99be74f61cb0292b518f5e6d7e5c6611555c2ec7 ] + +Regmap APIs should be selected, otherwise link can fail + +ERROR: modpost: "__devm_regmap_init_i2c" [drivers/leds/leds-lm3532.ko] undefined! + +Fixes: bc1b8492c764 ("leds: lm3532: Introduce the lm3532 LED driver") +Cc: Dan Murphy +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig +index 849d3c5f908e..56e8198e13d1 100644 +--- a/drivers/leds/Kconfig ++++ b/drivers/leds/Kconfig +@@ -199,6 +199,7 @@ config LEDS_LM3530 + + config LEDS_LM3532 + tristate "LCD Backlight driver for LM3532" ++ select REGMAP_I2C + depends on LEDS_CLASS + depends on I2C + help +-- +2.30.2 + diff --git a/queue-5.10/leds-lm36274-put-fwnode-in-error-case-during-probe.patch b/queue-5.10/leds-lm36274-put-fwnode-in-error-case-during-probe.patch new file mode 100644 index 00000000000..cf8cc0860c0 --- /dev/null +++ b/queue-5.10/leds-lm36274-put-fwnode-in-error-case-during-probe.patch @@ -0,0 +1,43 @@ +From 2cdd59a6de188b4254c6767fd9267a585bc596c9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:33 +0300 +Subject: leds: lm36274: Put fwnode in error case during ->probe() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Andy Shevchenko + +[ Upstream commit 3c5f655c44bb65cb7e3c219d08c130ce5fa45d7f ] + +device_get_next_child_node() bumps a reference counting of a returned variable. +We have to balance it whenever we return to the caller. + +In the older code the same is implied with device_for_each_child_node(). + +Fixes: 11e1bbc116a7 ("leds: lm36274: Introduce the TI LM36274 LED driver") +Fixes: a448fcf19c9c ("leds: lm36274: don't iterate through children since there is only one") +Cc: Dan Murphy +Cc: Marek Behún +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-lm36274.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c +index aadb03468a40..a23a9424c2f3 100644 +--- a/drivers/leds/leds-lm36274.c ++++ b/drivers/leds/leds-lm36274.c +@@ -127,6 +127,7 @@ static int lm36274_probe(struct platform_device *pdev) + + ret = lm36274_init(chip); + if (ret) { ++ fwnode_handle_put(init_data.fwnode); + dev_err(chip->dev, "Failed to init the device\n"); + return ret; + } +-- +2.30.2 + diff --git a/queue-5.10/leds-lm3692x-put-fwnode-in-any-case-during-probe.patch b/queue-5.10/leds-lm3692x-put-fwnode-in-any-case-during-probe.patch new file mode 100644 index 00000000000..faa1a4a0302 --- /dev/null +++ b/queue-5.10/leds-lm3692x-put-fwnode-in-any-case-during-probe.patch @@ -0,0 +1,52 @@ +From 637b2cee76160a48f67fbfb1ca93d1112f6b23e7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:35 +0300 +Subject: leds: lm3692x: Put fwnode in any case during ->probe() + +From: Andy Shevchenko + +[ Upstream commit f55db1c7fadc2a29c9fa4ff3aec98dbb111f2206 ] + +device_get_next_child_node() bumps a reference counting of a returned variable. +We have to balance it whenever we return to the caller. + +Fixes: 9a5c1c64ac0a ("leds: lm3692x: Change DT calls to fwnode calls") +Cc: Dan Murphy +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-lm3692x.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c +index e945de45388c..55e6443997ec 100644 +--- a/drivers/leds/leds-lm3692x.c ++++ b/drivers/leds/leds-lm3692x.c +@@ -435,6 +435,7 @@ static int lm3692x_probe_dt(struct lm3692x_led *led) + + ret = fwnode_property_read_u32(child, "reg", &led->led_enable); + if (ret) { ++ fwnode_handle_put(child); + dev_err(&led->client->dev, "reg DT property missing\n"); + return ret; + } +@@ -449,12 +450,11 @@ static int lm3692x_probe_dt(struct lm3692x_led *led) + + ret = devm_led_classdev_register_ext(&led->client->dev, &led->led_dev, + &init_data); +- if (ret) { ++ if (ret) + dev_err(&led->client->dev, "led register err: %d\n", ret); +- return ret; +- } + +- return 0; ++ fwnode_handle_put(init_data.fwnode); ++ return ret; + } + + static int lm3692x_probe(struct i2c_client *client, +-- +2.30.2 + diff --git a/queue-5.10/leds-lm3697-don-t-spam-logs-when-probe-is-deferred.patch b/queue-5.10/leds-lm3697-don-t-spam-logs-when-probe-is-deferred.patch new file mode 100644 index 00000000000..ab6d2a41608 --- /dev/null +++ b/queue-5.10/leds-lm3697-don-t-spam-logs-when-probe-is-deferred.patch @@ -0,0 +1,44 @@ +From fe1a0d2e443be22348ca530ad84b9b7bc6f2c84c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:39 +0300 +Subject: leds: lm3697: Don't spam logs when probe is deferred + +From: Andy Shevchenko + +[ Upstream commit 807553f8bf4afa673750e52905e0f9488179112f ] + +When requesting GPIO line the probe can be deferred. +In such case don't spam logs with an error message. +This can be achieved by switching to dev_err_probe(). + +Fixes: 5c1d824cda9f ("leds: lm3697: Introduce the lm3697 driver") +Cc: Dan Murphy +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-lm3697.c | 8 +++----- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c +index 7d216cdb91a8..912e8bb22a99 100644 +--- a/drivers/leds/leds-lm3697.c ++++ b/drivers/leds/leds-lm3697.c +@@ -203,11 +203,9 @@ static int lm3697_probe_dt(struct lm3697 *priv) + + priv->enable_gpio = devm_gpiod_get_optional(dev, "enable", + GPIOD_OUT_LOW); +- if (IS_ERR(priv->enable_gpio)) { +- ret = PTR_ERR(priv->enable_gpio); +- dev_err(dev, "Failed to get enable gpio: %d\n", ret); +- return ret; +- } ++ if (IS_ERR(priv->enable_gpio)) ++ return dev_err_probe(dev, PTR_ERR(priv->enable_gpio), ++ "Failed to get enable GPIO\n"); + + priv->regulator = devm_regulator_get(dev, "vled"); + if (IS_ERR(priv->regulator)) +-- +2.30.2 + diff --git a/queue-5.10/leds-lp50xx-put-fwnode-in-error-case-during-probe.patch b/queue-5.10/leds-lp50xx-put-fwnode-in-error-case-during-probe.patch new file mode 100644 index 00000000000..25b14a918f2 --- /dev/null +++ b/queue-5.10/leds-lp50xx-put-fwnode-in-error-case-during-probe.patch @@ -0,0 +1,47 @@ +From 137c4f8a110a131aa486bd604d3eb009e0a474d5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:50:40 +0300 +Subject: leds: lp50xx: Put fwnode in error case during ->probe() + +From: Andy Shevchenko + +[ Upstream commit f1e1d532da7e6ef355528a22fb97d9a8fbf76c4e ] + +fwnode_for_each_child_node() bumps a reference counting of a returned variable. +We have to balance it whenever we return to the caller. + +OTOH, the successful iteration will drop reference count under the hood, no need +to do it twice. + +Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver") +Cc: Dan Murphy +Signed-off-by: Andy Shevchenko +Signed-off-by: Pavel Machek +Signed-off-by: Sasha Levin +--- + drivers/leds/leds-lp50xx.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c +index f13117eed976..d4529082935b 100644 +--- a/drivers/leds/leds-lp50xx.c ++++ b/drivers/leds/leds-lp50xx.c +@@ -496,6 +496,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) + ret = fwnode_property_read_u32(led_node, "color", + &color_id); + if (ret) { ++ fwnode_handle_put(led_node); + dev_err(priv->dev, "Cannot read color\n"); + goto child_out; + } +@@ -519,7 +520,6 @@ static int lp50xx_probe_dt(struct lp50xx *priv) + goto child_out; + } + i++; +- fwnode_handle_put(child); + } + + return 0; +-- +2.30.2 + diff --git a/queue-5.10/lib-math-rational.c-fix-divide-by-zero.patch b/queue-5.10/lib-math-rational.c-fix-divide-by-zero.patch new file mode 100644 index 00000000000..c8db076f8d0 --- /dev/null +++ b/queue-5.10/lib-math-rational.c-fix-divide-by-zero.patch @@ -0,0 +1,78 @@ +From 2549373d2e884f463410754196104b7c398e2b18 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:55:49 -0700 +Subject: lib/math/rational.c: fix divide by zero + +From: Trent Piepho + +[ Upstream commit 65a0d3c14685663ba111038a35db70f559e39336 ] + +If the input is out of the range of the allowed values, either larger than +the largest value or closer to zero than the smallest non-zero allowed +value, then a division by zero would occur. + +In the case of input too large, the division by zero will occur on the +first iteration. The best result (largest allowed value) will be found by +always choosing the semi-convergent and excluding the denominator based +limit when finding it. + +In the case of the input too small, the division by zero will occur on the +second iteration. The numerator based semi-convergent should not be +calculated to avoid the division by zero. But the semi-convergent vs +previous convergent test is still needed, which effectively chooses +between 0 (the previous convergent) vs the smallest allowed fraction (best +semi-convergent) as the result. + +Link: https://lkml.kernel.org/r/20210525144250.214670-1-tpiepho@gmail.com +Fixes: 323dd2c3ed0 ("lib/math/rational.c: fix possible incorrect result from rational fractions helper") +Signed-off-by: Trent Piepho +Reported-by: Yiyuan Guo +Reviewed-by: Andy Shevchenko +Cc: Oskar Schirmer +Cc: Daniel Latypov +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + lib/math/rational.c | 16 +++++++++++----- + 1 file changed, 11 insertions(+), 5 deletions(-) + +diff --git a/lib/math/rational.c b/lib/math/rational.c +index 9781d521963d..c0ab51d8fbb9 100644 +--- a/lib/math/rational.c ++++ b/lib/math/rational.c +@@ -12,6 +12,7 @@ + #include + #include + #include ++#include + + /* + * calculate best rational approximation for a given fraction +@@ -78,13 +79,18 @@ void rational_best_approximation( + * found below as 't'. + */ + if ((n2 > max_numerator) || (d2 > max_denominator)) { +- unsigned long t = min((max_numerator - n0) / n1, +- (max_denominator - d0) / d1); ++ unsigned long t = ULONG_MAX; + +- /* This tests if the semi-convergent is closer +- * than the previous convergent. ++ if (d1) ++ t = (max_denominator - d0) / d1; ++ if (n1) ++ t = min(t, (max_numerator - n0) / n1); ++ ++ /* This tests if the semi-convergent is closer than the previous ++ * convergent. If d1 is zero there is no previous convergent as this ++ * is the 1st iteration, so always choose the semi-convergent. + */ +- if (2u * t > a || (2u * t == a && d0 * dp > d1 * d)) { ++ if (!d1 || 2u * t > a || (2u * t == a && d0 * dp > d1 * d)) { + n1 = n0 + t * n1; + d1 = d0 + t * d1; + } +-- +2.30.2 + diff --git a/queue-5.10/lib-vsprintf-fix-handling-of-number-field-widths-in-.patch b/queue-5.10/lib-vsprintf-fix-handling-of-number-field-widths-in-.patch new file mode 100644 index 00000000000..53546b61215 --- /dev/null +++ b/queue-5.10/lib-vsprintf-fix-handling-of-number-field-widths-in-.patch @@ -0,0 +1,233 @@ +From 54d9928a44801c64a3f4114ac7f6f69be721ae9b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 17:12:04 +0100 +Subject: lib: vsprintf: Fix handling of number field widths in vsscanf + +From: Richard Fitzgerald + +[ Upstream commit 900fdc4573766dd43b847b4f54bd4a1ee2bc7360 ] + +The existing code attempted to handle numbers by doing a strto[u]l(), +ignoring the field width, and then repeatedly dividing to extract the +field out of the full converted value. If the string contains a run of +valid digits longer than will fit in a long or long long, this would +overflow and no amount of dividing can recover the correct value. + +This patch fixes vsscanf() to obey number field widths when parsing +the number. + +A new _parse_integer_limit() is added that takes a limit for the number +of characters to parse. The number field conversion in vsscanf is changed +to use this new function. + +If a number starts with a radix prefix, the field width must be long +enough for at last one digit after the prefix. If not, it will be handled +like this: + + sscanf("0x4", "%1i", &i): i=0, scanning continues with the 'x' + sscanf("0x4", "%2i", &i): i=0, scanning continues with the '4' + +This is consistent with the observed behaviour of userland sscanf. + +Note that this patch does NOT fix the problem of a single field value +overflowing the target type. So for example: + + sscanf("123456789abcdef", "%x", &i); + +Will not produce the correct result because the value obviously overflows +INT_MAX. But sscanf will report a successful conversion. + +Note that where a very large number is used to mean "unlimited", the value +INT_MAX is used for consistency with the behaviour of vsnprintf(). + +Signed-off-by: Richard Fitzgerald +Reviewed-by: Petr Mladek +Signed-off-by: Petr Mladek +Link: https://lore.kernel.org/r/20210514161206.30821-2-rf@opensource.cirrus.com +Signed-off-by: Sasha Levin +--- + lib/kstrtox.c | 13 ++++++-- + lib/kstrtox.h | 2 ++ + lib/vsprintf.c | 82 +++++++++++++++++++++++++++++--------------------- + 3 files changed, 60 insertions(+), 37 deletions(-) + +diff --git a/lib/kstrtox.c b/lib/kstrtox.c +index a14ccf905055..8504526541c1 100644 +--- a/lib/kstrtox.c ++++ b/lib/kstrtox.c +@@ -39,20 +39,22 @@ const char *_parse_integer_fixup_radix(const char *s, unsigned int *base) + + /* + * Convert non-negative integer string representation in explicitly given radix +- * to an integer. ++ * to an integer. A maximum of max_chars characters will be converted. ++ * + * Return number of characters consumed maybe or-ed with overflow bit. + * If overflow occurs, result integer (incorrect) is still returned. + * + * Don't you dare use this function. + */ +-unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *p) ++unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned long long *p, ++ size_t max_chars) + { + unsigned long long res; + unsigned int rv; + + res = 0; + rv = 0; +- while (1) { ++ while (max_chars--) { + unsigned int c = *s; + unsigned int lc = c | 0x20; /* don't tolower() this line */ + unsigned int val; +@@ -82,6 +84,11 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long + return rv; + } + ++unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *p) ++{ ++ return _parse_integer_limit(s, base, p, INT_MAX); ++} ++ + static int _kstrtoull(const char *s, unsigned int base, unsigned long long *res) + { + unsigned long long _res; +diff --git a/lib/kstrtox.h b/lib/kstrtox.h +index 3b4637bcd254..158c400ca865 100644 +--- a/lib/kstrtox.h ++++ b/lib/kstrtox.h +@@ -4,6 +4,8 @@ + + #define KSTRTOX_OVERFLOW (1U << 31) + const char *_parse_integer_fixup_radix(const char *s, unsigned int *base); ++unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned long long *res, ++ size_t max_chars); + unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *res); + + #endif +diff --git a/lib/vsprintf.c b/lib/vsprintf.c +index fd0fde639ec9..8ade1a86d818 100644 +--- a/lib/vsprintf.c ++++ b/lib/vsprintf.c +@@ -53,6 +53,31 @@ + #include + #include "kstrtox.h" + ++static unsigned long long simple_strntoull(const char *startp, size_t max_chars, ++ char **endp, unsigned int base) ++{ ++ const char *cp; ++ unsigned long long result = 0ULL; ++ size_t prefix_chars; ++ unsigned int rv; ++ ++ cp = _parse_integer_fixup_radix(startp, &base); ++ prefix_chars = cp - startp; ++ if (prefix_chars < max_chars) { ++ rv = _parse_integer_limit(cp, base, &result, max_chars - prefix_chars); ++ /* FIXME */ ++ cp += (rv & ~KSTRTOX_OVERFLOW); ++ } else { ++ /* Field too short for prefix + digit, skip over without converting */ ++ cp = startp + max_chars; ++ } ++ ++ if (endp) ++ *endp = (char *)cp; ++ ++ return result; ++} ++ + /** + * simple_strtoull - convert a string to an unsigned long long + * @cp: The start of the string +@@ -63,18 +88,7 @@ + */ + unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base) + { +- unsigned long long result; +- unsigned int rv; +- +- cp = _parse_integer_fixup_radix(cp, &base); +- rv = _parse_integer(cp, base, &result); +- /* FIXME */ +- cp += (rv & ~KSTRTOX_OVERFLOW); +- +- if (endp) +- *endp = (char *)cp; +- +- return result; ++ return simple_strntoull(cp, INT_MAX, endp, base); + } + EXPORT_SYMBOL(simple_strtoull); + +@@ -109,6 +123,21 @@ long simple_strtol(const char *cp, char **endp, unsigned int base) + } + EXPORT_SYMBOL(simple_strtol); + ++static long long simple_strntoll(const char *cp, size_t max_chars, char **endp, ++ unsigned int base) ++{ ++ /* ++ * simple_strntoull() safely handles receiving max_chars==0 in the ++ * case cp[0] == '-' && max_chars == 1. ++ * If max_chars == 0 we can drop through and pass it to simple_strntoull() ++ * and the content of *cp is irrelevant. ++ */ ++ if (*cp == '-' && max_chars > 0) ++ return -simple_strntoull(cp + 1, max_chars - 1, endp, base); ++ ++ return simple_strntoull(cp, max_chars, endp, base); ++} ++ + /** + * simple_strtoll - convert a string to a signed long long + * @cp: The start of the string +@@ -119,10 +148,7 @@ EXPORT_SYMBOL(simple_strtol); + */ + long long simple_strtoll(const char *cp, char **endp, unsigned int base) + { +- if (*cp == '-') +- return -simple_strtoull(cp + 1, endp, base); +- +- return simple_strtoull(cp, endp, base); ++ return simple_strntoll(cp, INT_MAX, endp, base); + } + EXPORT_SYMBOL(simple_strtoll); + +@@ -3442,25 +3468,13 @@ int vsscanf(const char *buf, const char *fmt, va_list args) + break; + + if (is_sign) +- val.s = qualifier != 'L' ? +- simple_strtol(str, &next, base) : +- simple_strtoll(str, &next, base); ++ val.s = simple_strntoll(str, ++ field_width >= 0 ? field_width : INT_MAX, ++ &next, base); + else +- val.u = qualifier != 'L' ? +- simple_strtoul(str, &next, base) : +- simple_strtoull(str, &next, base); +- +- if (field_width > 0 && next - str > field_width) { +- if (base == 0) +- _parse_integer_fixup_radix(str, &base); +- while (next - str > field_width) { +- if (is_sign) +- val.s = div_s64(val.s, base); +- else +- val.u = div_u64(val.u, base); +- --next; +- } +- } ++ val.u = simple_strntoull(str, ++ field_width >= 0 ? field_width : INT_MAX, ++ &next, base); + + switch (qualifier) { + case 'H': /* that's 'hh' in format */ +-- +2.30.2 + diff --git a/queue-5.10/lockdep-fix-wait-type-for-empty-stack.patch b/queue-5.10/lockdep-fix-wait-type-for-empty-stack.patch new file mode 100644 index 00000000000..084ab842918 --- /dev/null +++ b/queue-5.10/lockdep-fix-wait-type-for-empty-stack.patch @@ -0,0 +1,37 @@ +From 7b33b969508bc37cfc11c85f9d3b05a1b8ee828f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 20:57:18 +0200 +Subject: lockdep: Fix wait-type for empty stack + +From: Peter Zijlstra + +[ Upstream commit f8b298cc39f0619544c607eaef09fd0b2afd10f3 ] + +Even the very first lock can violate the wait-context check, consider +the various IRQ contexts. + +Fixes: de8f5e4f2dc1 ("lockdep: Introduce wait-type checks") +Signed-off-by: Peter Zijlstra (Intel) +Tested-by: Joerg Roedel +Link: https://lore.kernel.org/r/20210617190313.256987481@infradead.org +Signed-off-by: Sasha Levin +--- + kernel/locking/lockdep.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c +index 788629c06ce9..8ae9d7abebc0 100644 +--- a/kernel/locking/lockdep.c ++++ b/kernel/locking/lockdep.c +@@ -4626,7 +4626,7 @@ static int check_wait_context(struct task_struct *curr, struct held_lock *next) + short curr_inner; + int depth; + +- if (!curr->lockdep_depth || !next_inner || next->trylock) ++ if (!next_inner || next->trylock) + return 0; + + if (!next_outer) +-- +2.30.2 + diff --git a/queue-5.10/lockdep-selftests-fix-selftests-vs-prove_raw_lock_ne.patch b/queue-5.10/lockdep-selftests-fix-selftests-vs-prove_raw_lock_ne.patch new file mode 100644 index 00000000000..1b145d1a4d9 --- /dev/null +++ b/queue-5.10/lockdep-selftests-fix-selftests-vs-prove_raw_lock_ne.patch @@ -0,0 +1,41 @@ +From 6ca5b33a4e41470da700502e45062db47e655f8d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 20:57:19 +0200 +Subject: lockdep/selftests: Fix selftests vs PROVE_RAW_LOCK_NESTING + +From: Peter Zijlstra + +[ Upstream commit c0c2c0dad6a06e0c05e9a52d65f932bd54364c97 ] + +When PROVE_RAW_LOCK_NESTING=y many of the selftests FAILED because +HARDIRQ context is out-of-bounds for spinlocks. Instead make the +default hardware context the threaded hardirq context, which preserves +the old locking rules. + +The wait-type specific locking selftests will have a non-threaded +HARDIRQ variant. + +Fixes: de8f5e4f2dc1 ("lockdep: Introduce wait-type checks") +Signed-off-by: Peter Zijlstra (Intel) +Tested-by: Joerg Roedel +Link: https://lore.kernel.org/r/20210617190313.322096283@infradead.org +Signed-off-by: Sasha Levin +--- + lib/locking-selftest.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c +index a899b3f0e2e5..76c52b0b76d3 100644 +--- a/lib/locking-selftest.c ++++ b/lib/locking-selftest.c +@@ -186,6 +186,7 @@ static void init_shared_classes(void) + #define HARDIRQ_ENTER() \ + local_irq_disable(); \ + __irq_enter(); \ ++ lockdep_hardirq_threaded(); \ + WARN_ON(!in_irq()); + + #define HARDIRQ_EXIT() \ +-- +2.30.2 + diff --git a/queue-5.10/lockding-lockdep-avoid-to-find-wrong-lock-dep-path-i.patch b/queue-5.10/lockding-lockdep-avoid-to-find-wrong-lock-dep-path-i.patch new file mode 100644 index 00000000000..0ce47a0de27 --- /dev/null +++ b/queue-5.10/lockding-lockdep-avoid-to-find-wrong-lock-dep-path-i.patch @@ -0,0 +1,59 @@ +From 52edbddd9da591ac5a92809145551c21fc08ee20 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 19 Jun 2021 01:01:09 +0800 +Subject: lockding/lockdep: Avoid to find wrong lock dep path in + check_irq_usage() + +From: Boqun Feng + +[ Upstream commit 7b1f8c6179769af6ffa055e1169610b51d71edd5 ] + +In the step #3 of check_irq_usage(), we seach backwards to find a lock +whose usage conflicts the usage of @target_entry1 on safe/unsafe. +However, we should only keep the irq-unsafe usage of @target_entry1 into +consideration, because it could be a case where a lock is hardirq-unsafe +but soft-safe, and in check_irq_usage() we find it because its +hardirq-unsafe could result into a hardirq-safe-unsafe deadlock, but +currently since we don't filter out the other usage bits, so we may find +a lock dependency path softirq-unsafe -> softirq-safe, which in fact +doesn't cause a deadlock. And this may cause misleading lockdep splats. + +Fix this by only keeping LOCKF_ENABLED_IRQ_ALL bits when we try the +backwards search. + +Reported-by: Johannes Berg +Signed-off-by: Boqun Feng +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lore.kernel.org/r/20210618170110.3699115-4-boqun.feng@gmail.com +Signed-off-by: Sasha Levin +--- + kernel/locking/lockdep.c | 12 +++++++++++- + 1 file changed, 11 insertions(+), 1 deletion(-) + +diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c +index 78b51b8ad4f6..788629c06ce9 100644 +--- a/kernel/locking/lockdep.c ++++ b/kernel/locking/lockdep.c +@@ -2764,8 +2764,18 @@ static int check_irq_usage(struct task_struct *curr, struct held_lock *prev, + * Step 3: we found a bad match! Now retrieve a lock from the backward + * list whose usage mask matches the exclusive usage mask from the + * lock found on the forward list. ++ * ++ * Note, we should only keep the LOCKF_ENABLED_IRQ_ALL bits, considering ++ * the follow case: ++ * ++ * When trying to add A -> B to the graph, we find that there is a ++ * hardirq-safe L, that L -> ... -> A, and another hardirq-unsafe M, ++ * that B -> ... -> M. However M is **softirq-safe**, if we use exact ++ * invert bits of M's usage_mask, we will find another lock N that is ++ * **softirq-unsafe** and N -> ... -> A, however N -> .. -> M will not ++ * cause a inversion deadlock. + */ +- backward_mask = original_mask(target_entry1->class->usage_mask); ++ backward_mask = original_mask(target_entry1->class->usage_mask & LOCKF_ENABLED_IRQ_ALL); + + ret = find_usage_backwards(&this, backward_mask, &target_entry); + if (bfs_error(ret)) { +-- +2.30.2 + diff --git a/queue-5.10/locking-lockdep-fix-the-dep-path-printing-for-backwa.patch b/queue-5.10/locking-lockdep-fix-the-dep-path-printing-for-backwa.patch new file mode 100644 index 00000000000..e9baf9aa023 --- /dev/null +++ b/queue-5.10/locking-lockdep-fix-the-dep-path-printing-for-backwa.patch @@ -0,0 +1,163 @@ +From ec1379c0528fd5b65e1cb6a15f7b6ccab75a1043 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 19 Jun 2021 01:01:07 +0800 +Subject: locking/lockdep: Fix the dep path printing for backwards BFS + +From: Boqun Feng + +[ Upstream commit 69c7a5fb2482636f525f016c8333fdb9111ecb9d ] + +We use the same code to print backwards lock dependency path as the +forwards lock dependency path, and this could result into incorrect +printing because for a backwards lock_list ->trace is not the call trace +where the lock of ->class is acquired. + +Fix this by introducing a separate function on printing the backwards +dependency path. Also add a few comments about the printing while we are +at it. + +Reported-by: Johannes Berg +Signed-off-by: Boqun Feng +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lore.kernel.org/r/20210618170110.3699115-2-boqun.feng@gmail.com +Signed-off-by: Sasha Levin +--- + kernel/locking/lockdep.c | 108 ++++++++++++++++++++++++++++++++++++++- + 1 file changed, 106 insertions(+), 2 deletions(-) + +diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c +index cdca007551e7..78b51b8ad4f6 100644 +--- a/kernel/locking/lockdep.c ++++ b/kernel/locking/lockdep.c +@@ -2297,7 +2297,56 @@ static void print_lock_class_header(struct lock_class *class, int depth) + } + + /* +- * printk the shortest lock dependencies from @start to @end in reverse order: ++ * Dependency path printing: ++ * ++ * After BFS we get a lock dependency path (linked via ->parent of lock_list), ++ * printing out each lock in the dependency path will help on understanding how ++ * the deadlock could happen. Here are some details about dependency path ++ * printing: ++ * ++ * 1) A lock_list can be either forwards or backwards for a lock dependency, ++ * for a lock dependency A -> B, there are two lock_lists: ++ * ++ * a) lock_list in the ->locks_after list of A, whose ->class is B and ++ * ->links_to is A. In this case, we can say the lock_list is ++ * "A -> B" (forwards case). ++ * ++ * b) lock_list in the ->locks_before list of B, whose ->class is A ++ * and ->links_to is B. In this case, we can say the lock_list is ++ * "B <- A" (bacwards case). ++ * ++ * The ->trace of both a) and b) point to the call trace where B was ++ * acquired with A held. ++ * ++ * 2) A "helper" lock_list is introduced during BFS, this lock_list doesn't ++ * represent a certain lock dependency, it only provides an initial entry ++ * for BFS. For example, BFS may introduce a "helper" lock_list whose ++ * ->class is A, as a result BFS will search all dependencies starting with ++ * A, e.g. A -> B or A -> C. ++ * ++ * The notation of a forwards helper lock_list is like "-> A", which means ++ * we should search the forwards dependencies starting with "A", e.g A -> B ++ * or A -> C. ++ * ++ * The notation of a bacwards helper lock_list is like "<- B", which means ++ * we should search the backwards dependencies ending with "B", e.g. ++ * B <- A or B <- C. ++ */ ++ ++/* ++ * printk the shortest lock dependencies from @root to @leaf in reverse order. ++ * ++ * We have a lock dependency path as follow: ++ * ++ * @root @leaf ++ * | | ++ * V V ++ * ->parent ->parent ++ * | lock_list | <--------- | lock_list | ... | lock_list | <--------- | lock_list | ++ * | -> L1 | | L1 -> L2 | ... |Ln-2 -> Ln-1| | Ln-1 -> Ln| ++ * ++ * , so it's natural that we start from @leaf and print every ->class and ++ * ->trace until we reach the @root. + */ + static void __used + print_shortest_lock_dependencies(struct lock_list *leaf, +@@ -2325,6 +2374,61 @@ print_shortest_lock_dependencies(struct lock_list *leaf, + } while (entry && (depth >= 0)); + } + ++/* ++ * printk the shortest lock dependencies from @leaf to @root. ++ * ++ * We have a lock dependency path (from a backwards search) as follow: ++ * ++ * @leaf @root ++ * | | ++ * V V ++ * ->parent ->parent ++ * | lock_list | ---------> | lock_list | ... | lock_list | ---------> | lock_list | ++ * | L2 <- L1 | | L3 <- L2 | ... | Ln <- Ln-1 | | <- Ln | ++ * ++ * , so when we iterate from @leaf to @root, we actually print the lock ++ * dependency path L1 -> L2 -> .. -> Ln in the non-reverse order. ++ * ++ * Another thing to notice here is that ->class of L2 <- L1 is L1, while the ++ * ->trace of L2 <- L1 is the call trace of L2, in fact we don't have the call ++ * trace of L1 in the dependency path, which is alright, because most of the ++ * time we can figure out where L1 is held from the call trace of L2. ++ */ ++static void __used ++print_shortest_lock_dependencies_backwards(struct lock_list *leaf, ++ struct lock_list *root) ++{ ++ struct lock_list *entry = leaf; ++ const struct lock_trace *trace = NULL; ++ int depth; ++ ++ /*compute depth from generated tree by BFS*/ ++ depth = get_lock_depth(leaf); ++ ++ do { ++ print_lock_class_header(entry->class, depth); ++ if (trace) { ++ printk("%*s ... acquired at:\n", depth, ""); ++ print_lock_trace(trace, 2); ++ printk("\n"); ++ } ++ ++ /* ++ * Record the pointer to the trace for the next lock_list ++ * entry, see the comments for the function. ++ */ ++ trace = entry->trace; ++ ++ if (depth == 0 && (entry != root)) { ++ printk("lockdep:%s bad path found in chain graph\n", __func__); ++ break; ++ } ++ ++ entry = get_lock_parent(entry); ++ depth--; ++ } while (entry && (depth >= 0)); ++} ++ + static void + print_irq_lock_scenario(struct lock_list *safe_entry, + struct lock_list *unsafe_entry, +@@ -2442,7 +2546,7 @@ print_bad_irq_dependency(struct task_struct *curr, + prev_root->trace = save_trace(); + if (!prev_root->trace) + return; +- print_shortest_lock_dependencies(backwards_entry, prev_root); ++ print_shortest_lock_dependencies_backwards(backwards_entry, prev_root); + + pr_warn("\nthe dependencies between the lock to be acquired"); + pr_warn(" and %s-irq-unsafe lock:\n", irqclass); +-- +2.30.2 + diff --git a/queue-5.10/locking-lockdep-reduce-lockdep-dependency-list.patch b/queue-5.10/locking-lockdep-reduce-lockdep-dependency-list.patch new file mode 100644 index 00000000000..85023f1b148 --- /dev/null +++ b/queue-5.10/locking-lockdep-reduce-lockdep-dependency-list.patch @@ -0,0 +1,62 @@ +From 32a720611b7d8a677a6cd755c530cd90fb191b4d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 24 May 2021 15:41:50 -0700 +Subject: locking/lockdep: Reduce LOCKDEP dependency list + +From: Randy Dunlap + +[ Upstream commit b8e00abe7d9fe21dd13609e2e3a707e38902b105 ] + +Some arches (um, sparc64, riscv, xtensa) cause a Kconfig warning for +LOCKDEP. +These arch-es select LOCKDEP_SUPPORT but they are not listed as one +of the arch-es that LOCKDEP depends on. + +Since (16) arch-es define the Kconfig symbol LOCKDEP_SUPPORT if they +intend to have LOCKDEP support, replace the awkward list of +arch-es that LOCKDEP depends on with the LOCKDEP_SUPPORT symbol. + +But wait. LOCKDEP_SUPPORT is included in LOCK_DEBUGGING_SUPPORT, +which is already a dependency here, so LOCKDEP_SUPPORT is redundant +and not needed. +That leaves the FRAME_POINTER dependency, but it is part of an +expression like this: + depends on (A && B) && (FRAME_POINTER || B') +where B' is a dependency of B so if B is true then B' is true +and the value of FRAME_POINTER does not matter. +Thus we can also delete the FRAME_POINTER dependency. + +Fixes this kconfig warning: (for um, sparc64, riscv, xtensa) + +WARNING: unmet direct dependencies detected for LOCKDEP + Depends on [n]: DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] && (FRAME_POINTER [=n] || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86) + Selected by [y]: + - PROVE_LOCKING [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] + - LOCK_STAT [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] + - DEBUG_LOCK_ALLOC [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] + +Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS") +Signed-off-by: Randy Dunlap +Signed-off-by: Peter Zijlstra (Intel) +Acked-by: Waiman Long +Link: https://lkml.kernel.org/r/20210524224150.8009-1-rdunlap@infradead.org +Signed-off-by: Sasha Levin +--- + lib/Kconfig.debug | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug +index dcf4a9028e16..5b7f88a2876d 100644 +--- a/lib/Kconfig.debug ++++ b/lib/Kconfig.debug +@@ -1302,7 +1302,6 @@ config LOCKDEP + bool + depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT + select STACKTRACE +- depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86 + select KALLSYMS + select KALLSYMS_ALL + +-- +2.30.2 + diff --git a/queue-5.10/m68k-atari-fix-atari_kbd_core-kconfig-unmet-dependen.patch b/queue-5.10/m68k-atari-fix-atari_kbd_core-kconfig-unmet-dependen.patch new file mode 100644 index 00000000000..032af957da6 --- /dev/null +++ b/queue-5.10/m68k-atari-fix-atari_kbd_core-kconfig-unmet-dependen.patch @@ -0,0 +1,64 @@ +From d3c62ef67ce08ff609c7033cc6f7ea06a5ed2b9a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 17:12:51 -0700 +Subject: m68k: atari: Fix ATARI_KBD_CORE kconfig unmet dependency warning + +From: Randy Dunlap + +[ Upstream commit c1367ee016e3550745315fb9a2dd1e4ce02cdcf6 ] + +Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/ +code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove +the dependency on INPUT_KEYBOARD. + +Removes this kconfig warning: + + WARNING: unmet direct dependencies detected for ATARI_KBD_CORE + Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] + Selected by [y]: + - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y] + +Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.") +Signed-off-by: Randy Dunlap +Suggested-by: Geert Uytterhoeven +Suggested-by: Michael Schmitz +Acked-by: Dmitry Torokhov +Link: https://lore.kernel.org/r/20210527001251.8529-1-rdunlap@infradead.org +Signed-off-by: Geert Uytterhoeven +Signed-off-by: Sasha Levin +--- + arch/m68k/Kconfig.machine | 3 +++ + drivers/input/keyboard/Kconfig | 3 --- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine +index 17e8c3a292d7..e161a4e1493b 100644 +--- a/arch/m68k/Kconfig.machine ++++ b/arch/m68k/Kconfig.machine +@@ -23,6 +23,9 @@ config ATARI + this kernel on an Atari, say Y here and browse the material + available in ; otherwise say N. + ++config ATARI_KBD_CORE ++ bool ++ + config MAC + bool "Macintosh support" + depends on MMU +diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig +index 793ecbbda32c..9f60f1559e49 100644 +--- a/drivers/input/keyboard/Kconfig ++++ b/drivers/input/keyboard/Kconfig +@@ -67,9 +67,6 @@ config KEYBOARD_AMIGA + To compile this driver as a module, choose M here: the + module will be called amikbd. + +-config ATARI_KBD_CORE +- bool +- + config KEYBOARD_APPLESPI + tristate "Apple SPI keyboard and trackpad" + depends on ACPI && EFI +-- +2.30.2 + diff --git a/queue-5.10/mac80211-remove-iwlwifi-specific-workaround-ndps-of-.patch b/queue-5.10/mac80211-remove-iwlwifi-specific-workaround-ndps-of-.patch new file mode 100644 index 00000000000..4fd190054f6 --- /dev/null +++ b/queue-5.10/mac80211-remove-iwlwifi-specific-workaround-ndps-of-.patch @@ -0,0 +1,41 @@ +From d5afbd4bb62390d52f7f78517e21be76a8658d7b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 21:48:25 +0800 +Subject: mac80211: remove iwlwifi specific workaround NDPs of null_response + +From: Ping-Ke Shih + +[ Upstream commit 744757e46bf13ec3a7b3507d17ab3faab9516d43 ] + +Remove the remaining workaround that is not removed by the +commit e41eb3e408de ("mac80211: remove iwlwifi specific workaround +that broke sta NDP tx") + +Fixes: 41cbb0f5a295 ("mac80211: add support for HE") +Signed-off-by: Ping-Ke Shih +Link: https://lore.kernel.org/r/20210623134826.10318-1-pkshih@realtek.com +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/mac80211/sta_info.c | 5 ----- + 1 file changed, 5 deletions(-) + +diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c +index f2fb69da9b6e..13250cadb420 100644 +--- a/net/mac80211/sta_info.c ++++ b/net/mac80211/sta_info.c +@@ -1398,11 +1398,6 @@ static void ieee80211_send_null_response(struct sta_info *sta, int tid, + struct ieee80211_tx_info *info; + struct ieee80211_chanctx_conf *chanctx_conf; + +- /* Don't send NDPs when STA is connected HE */ +- if (sdata->vif.type == NL80211_IFTYPE_STATION && +- !(sdata->u.mgd.flags & IEEE80211_STA_DISABLE_HE)) +- return; +- + if (qos) { + fc = cpu_to_le16(IEEE80211_FTYPE_DATA | + IEEE80211_STYPE_QOS_NULLFUNC | +-- +2.30.2 + diff --git a/queue-5.10/mailbox-qcom-use-platform_devid_auto-to-register-pla.patch b/queue-5.10/mailbox-qcom-use-platform_devid_auto-to-register-pla.patch new file mode 100644 index 00000000000..bebefef09dd --- /dev/null +++ b/queue-5.10/mailbox-qcom-use-platform_devid_auto-to-register-pla.patch @@ -0,0 +1,48 @@ +From 85c395481162a95aaaf22634decae73f286be1cc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 08:39:18 +0800 +Subject: mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device + +From: Shawn Guo + +[ Upstream commit 96e39e95c01283ff5695dafe659df88ada802159 ] + +In adding APCS clock support for MSM8939, the second clock registration +fails due to duplicate device name like below. + +[ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' +... +[ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk + +This is because MSM8939 has 3 APCS instances for Cluster0 (little cores), +Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although +only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has +A53PLL clock control bits. That said, 3 'qcom-apcs-msm8916-clk' devices +need to be registered to instantiate all 3 clocks. Use PLATFORM_DEVID_AUTO +rather than PLATFORM_DEVID_NONE for platform_device_register_data() call +to fix the issue above. + +Signed-off-by: Shawn Guo +Reviewed-by: Bjorn Andersson +Signed-off-by: Jassi Brar +Signed-off-by: Sasha Levin +--- + drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c +index 077e5c6a9ef7..3d100a004760 100644 +--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c ++++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c +@@ -128,7 +128,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) + if (apcs_data->clk_name) { + apcs->clk = platform_device_register_data(&pdev->dev, + apcs_data->clk_name, +- PLATFORM_DEVID_NONE, ++ PLATFORM_DEVID_AUTO, + NULL, 0); + if (IS_ERR(apcs->clk)) + dev_err(&pdev->dev, "failed to register APCS clk\n"); +-- +2.30.2 + diff --git a/queue-5.10/makefile-fix-gdb-warning-with-config_relr.patch b/queue-5.10/makefile-fix-gdb-warning-with-config_relr.patch new file mode 100644 index 00000000000..877bdcdbce3 --- /dev/null +++ b/queue-5.10/makefile-fix-gdb-warning-with-config_relr.patch @@ -0,0 +1,65 @@ +From d7597b8311d9a16be3b10333316959e5d4f4a2f0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 21 May 2021 18:26:24 -0700 +Subject: Makefile: fix GDB warning with CONFIG_RELR + +From: Nick Desaulniers + +[ Upstream commit 27f2a4db76e8d8a8b601fc1c6a7a17f88bd907ab ] + +GDB produces the following warning when debugging kernels built with +CONFIG_RELR: + +BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn' + +when loading a kernel built with CONFIG_RELR into GDB. It can also +prevent debugging symbols using such relocations. + +Peter sugguests: + [That flag] means that lld will use dynamic tags and section type + numbers in the OS-specific range rather than the generic range. The + kernel itself doesn't care about these numbers; it determines the + location of the RELR section using symbols defined by a linker script. + +Link: https://github.com/ClangBuiltLinux/linux/issues/1057 +Suggested-by: Peter Collingbourne +Reviewed-by: Nathan Chancellor +Signed-off-by: Nick Desaulniers +Link: https://lore.kernel.org/r/20210522012626.2811297-1-ndesaulniers@google.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + Makefile | 2 +- + scripts/tools-support-relr.sh | 3 ++- + 2 files changed, 3 insertions(+), 2 deletions(-) + +diff --git a/Makefile b/Makefile +index c51b73455ea3..ddd30b068be7 100644 +--- a/Makefile ++++ b/Makefile +@@ -978,7 +978,7 @@ LDFLAGS_vmlinux += $(call ld-option, -X,) + endif + + ifeq ($(CONFIG_RELR),y) +-LDFLAGS_vmlinux += --pack-dyn-relocs=relr ++LDFLAGS_vmlinux += --pack-dyn-relocs=relr --use-android-relr-tags + endif + + # We never want expected sections to be placed heuristically by the +diff --git a/scripts/tools-support-relr.sh b/scripts/tools-support-relr.sh +index 45e8aa360b45..cb55878bd5b8 100755 +--- a/scripts/tools-support-relr.sh ++++ b/scripts/tools-support-relr.sh +@@ -7,7 +7,8 @@ trap "rm -f $tmp_file.o $tmp_file $tmp_file.bin" EXIT + cat << "END" | $CC -c -x c - -o $tmp_file.o >/dev/null 2>&1 + void *p = &p; + END +-$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr -o $tmp_file ++$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr \ ++ --use-android-relr-tags -o $tmp_file + + # Despite printing an error message, GNU nm still exits with exit code 0 if it + # sees a relr section. So we need to check that nothing is printed to stderr. +-- +2.30.2 + diff --git a/queue-5.10/mark-pstore-blk-as-broken.patch b/queue-5.10/mark-pstore-blk-as-broken.patch new file mode 100644 index 00000000000..929c1ceaa68 --- /dev/null +++ b/queue-5.10/mark-pstore-blk-as-broken.patch @@ -0,0 +1,41 @@ +From f584a3960294cdc52cc6fc1755b9327e5ea406c4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Jun 2021 18:13:27 +0200 +Subject: mark pstore-blk as broken + +From: Christoph Hellwig + +[ Upstream commit d07f3b081ee632268786601f55e1334d1f68b997 ] + +pstore-blk just pokes directly into the pagecache for the block +device without going through the file operations for that by faking +up it's own file operations that do not match the block device ones. + +As this breaks the control of the block layer of it's page cache, +and even now just works by accident only the best thing is to just +disable this driver. + +Fixes: 17639f67c1d6 ("pstore/blk: Introduce backend for block devices") +Signed-off-by: Christoph Hellwig +Link: https://lore.kernel.org/r/20210608161327.1537919-1-hch@lst.de +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + fs/pstore/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig +index e16a49ebfe54..8efe60487b48 100644 +--- a/fs/pstore/Kconfig ++++ b/fs/pstore/Kconfig +@@ -165,6 +165,7 @@ config PSTORE_BLK + tristate "Log panic/oops to a block device" + depends on PSTORE + depends on BLOCK ++ depends on BROKEN + select PSTORE_ZONE + default n + help +-- +2.30.2 + diff --git a/queue-5.10/media-am437x-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-am437x-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..1f1b43a2581 --- /dev/null +++ b/queue-5.10/media-am437x-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,69 @@ +From d08357cc0f190f229ec2836c54452814de83e824 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:05:27 +0200 +Subject: media: am437x: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit c41e02493334985cca1a22efd5ca962ce3abb061 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +While here, ensure that the driver will check if PM runtime +resumed at vpfe_initialize_device(). + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/am437x/am437x-vpfe.c | 15 +++++++++++++-- + 1 file changed, 13 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c +index 0fb9f9ba1219..31cee69adbe1 100644 +--- a/drivers/media/platform/am437x/am437x-vpfe.c ++++ b/drivers/media/platform/am437x/am437x-vpfe.c +@@ -1021,7 +1021,9 @@ static int vpfe_initialize_device(struct vpfe_device *vpfe) + if (ret) + return ret; + +- pm_runtime_get_sync(vpfe->pdev); ++ ret = pm_runtime_resume_and_get(vpfe->pdev); ++ if (ret < 0) ++ return ret; + + vpfe_config_enable(&vpfe->ccdc, 1); + +@@ -2443,7 +2445,11 @@ static int vpfe_probe(struct platform_device *pdev) + pm_runtime_enable(&pdev->dev); + + /* for now just enable it here instead of waiting for the open */ +- pm_runtime_get_sync(&pdev->dev); ++ ret = pm_runtime_resume_and_get(&pdev->dev); ++ if (ret < 0) { ++ vpfe_err(vpfe, "Unable to resume device.\n"); ++ goto probe_out_v4l2_unregister; ++ } + + vpfe_ccdc_config_defaults(ccdc); + +@@ -2530,6 +2536,11 @@ static int vpfe_suspend(struct device *dev) + + /* only do full suspend if streaming has started */ + if (vb2_start_streaming_called(&vpfe->buffer_queue)) { ++ /* ++ * ignore RPM resume errors here, as it is already too late. ++ * A check like that should happen earlier, either at ++ * open() or just before start streaming. ++ */ + pm_runtime_get_sync(dev); + vpfe_config_enable(ccdc, 1); + +-- +2.30.2 + diff --git a/queue-5.10/media-au0828-fix-a-null-vs-is_err-check.patch b/queue-5.10/media-au0828-fix-a-null-vs-is_err-check.patch new file mode 100644 index 00000000000..c35a261470e --- /dev/null +++ b/queue-5.10/media-au0828-fix-a-null-vs-is_err-check.patch @@ -0,0 +1,40 @@ +From 03a4031daa512db71f1ba86efce462b4573c01aa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 16:20:38 +0200 +Subject: media: au0828: fix a NULL vs IS_ERR() check + +From: Dan Carpenter + +[ Upstream commit 8f2e452730d2bcd59fe05246f0e19a4c52e0012d ] + +The media_device_usb_allocate() function returns error pointers when +it's enabled and something goes wrong. It can return NULL as well, but +only if CONFIG_MEDIA_CONTROLLER is disabled so that doesn't apply here. + +Fixes: 812658d88d26 ("media: change au0828 to use Media Device Allocator API") +Signed-off-by: Dan Carpenter +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/au0828/au0828-core.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c +index a8a72d5fbd12..caefac07af92 100644 +--- a/drivers/media/usb/au0828/au0828-core.c ++++ b/drivers/media/usb/au0828/au0828-core.c +@@ -199,8 +199,8 @@ static int au0828_media_device_init(struct au0828_dev *dev, + struct media_device *mdev; + + mdev = media_device_usb_allocate(udev, KBUILD_MODNAME, THIS_MODULE); +- if (!mdev) +- return -ENOMEM; ++ if (IS_ERR(mdev)) ++ return PTR_ERR(mdev); + + dev->media_dev = mdev; + #endif +-- +2.30.2 + diff --git a/queue-5.10/media-bt878-do-not-schedule-tasklet-when-it-is-not-s.patch b/queue-5.10/media-bt878-do-not-schedule-tasklet-when-it-is-not-s.patch new file mode 100644 index 00000000000..71cd58f4c31 --- /dev/null +++ b/queue-5.10/media-bt878-do-not-schedule-tasklet-when-it-is-not-s.patch @@ -0,0 +1,52 @@ +From 8180a675e39d5544b9ed9e404bde7bf215194c75 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 29 Apr 2021 00:12:26 +0200 +Subject: media: bt878: do not schedule tasklet when it is not setup + +From: Tong Zhang + +[ Upstream commit a3a54bf4bddaecda8b5767209cfc703f0be2841d ] + +There is a problem with the tasklet in bt878. bt->tasklet is set by +dvb-bt8xx.ko, and bt878.ko can be loaded independently. +In this case if interrupt comes it may cause null-ptr-dereference. +To solve this issue, we check if the tasklet is actually set before +calling tasklet_schedule. + +[ 1.750438] bt878(0): irq FDSR FBUS risc_pc= +[ 1.750728] BUG: kernel NULL pointer dereference, address: 0000000000000000 +[ 1.752969] RIP: 0010:0x0 +[ 1.757526] Call Trace: +[ 1.757659] +[ 1.757770] tasklet_action_common.isra.0+0x107/0x110 +[ 1.758041] tasklet_action+0x22/0x30 +[ 1.758237] __do_softirq+0xe0/0x29b +[ 1.758430] irq_exit_rcu+0xa4/0xb0 +[ 1.758618] common_interrupt+0x8d/0xa0 +[ 1.758824] + +Signed-off-by: Tong Zhang +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/bt8xx/bt878.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/pci/bt8xx/bt878.c b/drivers/media/pci/bt8xx/bt878.c +index 79ba15a9385a..69a304e0db11 100644 +--- a/drivers/media/pci/bt8xx/bt878.c ++++ b/drivers/media/pci/bt8xx/bt878.c +@@ -300,7 +300,8 @@ static irqreturn_t bt878_irq(int irq, void *dev_id) + } + if (astat & BT878_ARISCI) { + bt->finished_block = (stat & BT878_ARISCS) >> 28; +- tasklet_schedule(&bt->tasklet); ++ if (bt->tasklet.callback) ++ tasklet_schedule(&bt->tasklet); + break; + } + count++; +-- +2.30.2 + diff --git a/queue-5.10/media-bt8xx-fix-a-missing-check-bug-in-bt878_probe.patch b/queue-5.10/media-bt8xx-fix-a-missing-check-bug-in-bt878_probe.patch new file mode 100644 index 00000000000..934aebfb8e5 --- /dev/null +++ b/queue-5.10/media-bt8xx-fix-a-missing-check-bug-in-bt878_probe.patch @@ -0,0 +1,122 @@ +From 076736fd2e74b00a9f072c5cff04186b4735c151 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 17:18:36 +0200 +Subject: media: bt8xx: Fix a missing check bug in bt878_probe + +From: Zheyu Ma + +[ Upstream commit 1a4520090681853e6b850cbe54b27247a013e0e5 ] + +In 'bt878_irq', the driver calls 'tasklet_schedule', but this tasklet is +set in 'dvb_bt8xx_load_card' of another driver 'dvb-bt8xx'. +However, this two drivers are separate. The user may not load the +'dvb-bt8xx' driver when loading the 'bt8xx' driver, that is, the tasklet +has not been initialized when 'tasklet_schedule' is called, so it is +necessary to check whether the tasklet is initialized in 'bt878_probe'. + +Fix this by adding a check at the end of bt878_probe. + +The KASAN's report reveals it: + +BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 +PGD 800000006aab2067 P4D 800000006aab2067 PUD 6b2ea067 PMD 0 +Oops: 0010 [#1] PREEMPT SMP KASAN PTI +CPU: 2 PID: 8724 Comm: syz-executor.0 Not tainted 4.19.177- +gdba4159c14ef-dirty #40 +Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59- +gc9ba5276e321-prebuilt.qemu.org 04/01/2014 +RIP: 0010: (null) +Code: Bad RIP value. +RSP: 0018:ffff88806c287ea0 EFLAGS: 00010246 +RAX: fffffbfff1b01774 RBX: dffffc0000000000 RCX: 0000000000000000 +RDX: 0000000000000000 RSI: 1ffffffff1b01775 RDI: 0000000000000000 +RBP: ffff88806c287f00 R08: fffffbfff1b01774 R09: fffffbfff1b01774 +R10: 0000000000000001 R11: fffffbfff1b01773 R12: 0000000000000000 +R13: ffff88806c29f530 R14: ffffffff8d80bb88 R15: ffffffff8d80bb90 +FS: 00007f6b550e6700(0000) GS:ffff88806c280000(0000) knlGS: +0000000000000000 +CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 +CR2: ffffffffffffffd6 CR3: 000000005ec98000 CR4: 00000000000006e0 +DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 +DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 +Call Trace: + + tasklet_action_common.isra.17+0x141/0x420 kernel/softirq.c:522 + tasklet_action+0x50/0x70 kernel/softirq.c:540 + __do_softirq+0x224/0x92c kernel/softirq.c:292 + invoke_softirq kernel/softirq.c:372 [inline] + irq_exit+0x15a/0x180 kernel/softirq.c:412 + exiting_irq arch/x86/include/asm/apic.h:535 [inline] + do_IRQ+0x123/0x1e0 arch/x86/kernel/irq.c:260 + common_interrupt+0xf/0xf arch/x86/entry/entry_64.S:670 + +RIP: 0010:__do_sys_interrupt kernel/sys.c:2593 [inline] +RIP: 0010:__se_sys_interrupt kernel/sys.c:2584 [inline] +RIP: 0010:__x64_sys_interrupt+0x5b/0x80 kernel/sys.c:2584 +Code: ba 00 04 00 00 48 c7 c7 c0 99 31 8c e8 ae 76 5e 01 48 85 c0 75 21 e8 +14 ae 24 00 48 c7 c3 c0 99 31 8c b8 0c 00 00 00 0f 01 c1 <31> db e8 fe ad +24 00 48 89 d8 5b 5d c3 48 c7 c3 ea ff ff ff eb ec +RSP: 0018:ffff888054167f10 EFLAGS: 00000212 ORIG_RAX: ffffffffffffffde +RAX: 000000000000000c RBX: ffffffff8c3199c0 RCX: ffffc90001ca6000 +RDX: 000000000000001a RSI: ffffffff813478fc RDI: ffffffff8c319dc0 +RBP: ffff888054167f18 R08: 0000000000000000 R09: 0000000000000000 +R10: 0000000000000080 R11: fffffbfff18633b7 R12: ffff888054167f58 +R13: ffff88805f638000 R14: 0000000000000000 R15: 0000000000000000 + do_syscall_64+0xb0/0x4e0 arch/x86/entry/common.c:293 + entry_SYSCALL_64_after_hwframe+0x49/0xbe +RIP: 0033:0x4692a9 +Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 +48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff +ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 +RSP: 002b:00007f6b550e5c48 EFLAGS: 00000246 ORIG_RAX: 000000000000014f +RAX: ffffffffffffffda RBX: 000000000077bf60 RCX: 00000000004692a9 +RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000140 +RBP: 00000000004cf7eb R08: 0000000000000000 R09: 0000000000000000 +R10: 0000000000000000 R11: 0000000000000246 R12: 000000000077bf60 +R13: 0000000000000000 R14: 000000000077bf60 R15: 00007fff55a1dca0 +Modules linked in: +Dumping ftrace buffer: + (ftrace buffer empty) +CR2: 0000000000000000 +---[ end trace 68e5849c3f77cbb6 ]--- +RIP: 0010: (null) +Code: Bad RIP value. +RSP: 0018:ffff88806c287ea0 EFLAGS: 00010246 +RAX: fffffbfff1b01774 RBX: dffffc0000000000 RCX: 0000000000000000 +RDX: 0000000000000000 RSI: 1ffffffff1b01775 RDI: 0000000000000000 +RBP: ffff88806c287f00 R08: fffffbfff1b01774 R09: fffffbfff1b01774 +R10: 0000000000000001 R11: fffffbfff1b01773 R12: 0000000000000000 +R13: ffff88806c29f530 R14: ffffffff8d80bb88 R15: ffffffff8d80bb90 +FS: 00007f6b550e6700(0000) GS:ffff88806c280000(0000) knlGS: +0000000000000000 +CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 +CR2: ffffffffffffffd6 CR3: 000000005ec98000 CR4: 00000000000006e0 +DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 +DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 + +Reported-by: Zheyu Ma +Signed-off-by: Zheyu Ma +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/bt8xx/bt878.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/media/pci/bt8xx/bt878.c b/drivers/media/pci/bt8xx/bt878.c +index 69a304e0db11..0705913972c6 100644 +--- a/drivers/media/pci/bt8xx/bt878.c ++++ b/drivers/media/pci/bt8xx/bt878.c +@@ -478,6 +478,9 @@ static int bt878_probe(struct pci_dev *dev, const struct pci_device_id *pci_id) + btwrite(0, BT878_AINT_MASK); + bt878_num++; + ++ if (!bt->tasklet.func) ++ tasklet_disable(&bt->tasklet); ++ + return 0; + + fail2: +-- +2.30.2 + diff --git a/queue-5.10/media-cedrus-fix-.buf_prepare.patch b/queue-5.10/media-cedrus-fix-.buf_prepare.patch new file mode 100644 index 00000000000..ca8ea0c6ae4 --- /dev/null +++ b/queue-5.10/media-cedrus-fix-.buf_prepare.patch @@ -0,0 +1,47 @@ +From b7e16a02245a27d603bc5980330a14592aafca58 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 14:23:47 +0200 +Subject: media: cedrus: Fix .buf_prepare + +From: Andrzej Pietrasiewicz + +[ Upstream commit d84b9202d712309840f8b5abee0ed272506563bd ] + +The driver should only set the payload on .buf_prepare if the +buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused +set by userspace then v4l2-core will set it to buffer length. + +If we overwrite bytesused for OUTPUT buffers, too, then +vb2_get_plane_payload() will return incorrect value which might be then +written to hw registers by the driver in cedrus_h264.c or cedrus_vp8.c. + +Signed-off-by: Andrzej Pietrasiewicz +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/sunxi/cedrus/cedrus_video.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c +index 911f607d9b09..16327be904d1 100644 +--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c ++++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c +@@ -449,7 +449,13 @@ static int cedrus_buf_prepare(struct vb2_buffer *vb) + if (vb2_plane_size(vb, 0) < pix_fmt->sizeimage) + return -EINVAL; + +- vb2_set_plane_payload(vb, 0, pix_fmt->sizeimage); ++ /* ++ * Buffer's bytesused must be written by driver for CAPTURE buffers. ++ * (for OUTPUT buffers, if userspace passes 0 bytesused, v4l2-core sets ++ * it to buffer length). ++ */ ++ if (V4L2_TYPE_IS_CAPTURE(vq->type)) ++ vb2_set_plane_payload(vb, 0, pix_fmt->sizeimage); + + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/media-cobalt-fix-race-condition-in-setting-hpd.patch b/queue-5.10/media-cobalt-fix-race-condition-in-setting-hpd.patch new file mode 100644 index 00000000000..cc2654e4d79 --- /dev/null +++ b/queue-5.10/media-cobalt-fix-race-condition-in-setting-hpd.patch @@ -0,0 +1,70 @@ +From f634230a3ff6389d0f5ceeec83dfefdd1eb62afa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 10:00:49 +0200 +Subject: media: cobalt: fix race condition in setting HPD + +From: Hans Verkuil + +[ Upstream commit 3d37ef41bed0854805ab9af22c422267510e1344 ] + +The cobalt_s_bit_sysctrl reads the old register value over PCI, +then changes a bit and sets writes the new value to the register. + +This is used among other things for setting the HPD output pin. + +But if the HPD is changed for multiple inputs at the same time, +then this causes a race condition where a stale value is read. + +Serialize this function with a mutex. + +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/cobalt/cobalt-driver.c | 1 + + drivers/media/pci/cobalt/cobalt-driver.h | 7 ++++++- + 2 files changed, 7 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c +index 0695078ef812..1bd8bbe57a30 100644 +--- a/drivers/media/pci/cobalt/cobalt-driver.c ++++ b/drivers/media/pci/cobalt/cobalt-driver.c +@@ -667,6 +667,7 @@ static int cobalt_probe(struct pci_dev *pci_dev, + return -ENOMEM; + cobalt->pci_dev = pci_dev; + cobalt->instance = i; ++ mutex_init(&cobalt->pci_lock); + + retval = v4l2_device_register(&pci_dev->dev, &cobalt->v4l2_dev); + if (retval) { +diff --git a/drivers/media/pci/cobalt/cobalt-driver.h b/drivers/media/pci/cobalt/cobalt-driver.h +index bca68572b324..12c33e035904 100644 +--- a/drivers/media/pci/cobalt/cobalt-driver.h ++++ b/drivers/media/pci/cobalt/cobalt-driver.h +@@ -251,6 +251,8 @@ struct cobalt { + int instance; + struct pci_dev *pci_dev; + struct v4l2_device v4l2_dev; ++ /* serialize PCI access in cobalt_s_bit_sysctrl() */ ++ struct mutex pci_lock; + + void __iomem *bar0, *bar1; + +@@ -320,10 +322,13 @@ static inline u32 cobalt_g_sysctrl(struct cobalt *cobalt) + static inline void cobalt_s_bit_sysctrl(struct cobalt *cobalt, + int bit, int val) + { +- u32 ctrl = cobalt_read_bar1(cobalt, COBALT_SYS_CTRL_BASE); ++ u32 ctrl; + ++ mutex_lock(&cobalt->pci_lock); ++ ctrl = cobalt_read_bar1(cobalt, COBALT_SYS_CTRL_BASE); + cobalt_write_bar1(cobalt, COBALT_SYS_CTRL_BASE, + (ctrl & ~(1UL << bit)) | (val << bit)); ++ mutex_unlock(&cobalt->pci_lock); + } + + static inline u32 cobalt_g_sysstat(struct cobalt *cobalt) +-- +2.30.2 + diff --git a/queue-5.10/media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch b/queue-5.10/media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch new file mode 100644 index 00000000000..059d2fc49a6 --- /dev/null +++ b/queue-5.10/media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch @@ -0,0 +1,104 @@ +From 477c22d349ef57f88ee44d9bedb1dc1cec489ac4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 21 Apr 2021 21:43:45 +0200 +Subject: media: cpia2: fix memory leak in cpia2_usb_probe + +From: Pavel Skripkin + +[ Upstream commit be8656e62e9e791837b606a027802b504a945c97 ] + +syzbot reported leak in cpia2 usb driver. The problem was +in invalid error handling. + +v4l2_device_register() is called in cpia2_init_camera_struct(), but +all error cases after cpia2_init_camera_struct() did not call the +v4l2_device_unregister() + +Reported-by: syzbot+d1e69c888f0d3866ead4@syzkaller.appspotmail.com +Signed-off-by: Pavel Skripkin +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/cpia2/cpia2.h | 1 + + drivers/media/usb/cpia2/cpia2_core.c | 12 ++++++++++++ + drivers/media/usb/cpia2/cpia2_usb.c | 13 +++++++------ + 3 files changed, 20 insertions(+), 6 deletions(-) + +diff --git a/drivers/media/usb/cpia2/cpia2.h b/drivers/media/usb/cpia2/cpia2.h +index 50835f5f7512..57b7f1ea68da 100644 +--- a/drivers/media/usb/cpia2/cpia2.h ++++ b/drivers/media/usb/cpia2/cpia2.h +@@ -429,6 +429,7 @@ int cpia2_send_command(struct camera_data *cam, struct cpia2_command *cmd); + int cpia2_do_command(struct camera_data *cam, + unsigned int command, + unsigned char direction, unsigned char param); ++void cpia2_deinit_camera_struct(struct camera_data *cam, struct usb_interface *intf); + struct camera_data *cpia2_init_camera_struct(struct usb_interface *intf); + int cpia2_init_camera(struct camera_data *cam); + int cpia2_allocate_buffers(struct camera_data *cam); +diff --git a/drivers/media/usb/cpia2/cpia2_core.c b/drivers/media/usb/cpia2/cpia2_core.c +index e747548ab286..b5a2d06fb356 100644 +--- a/drivers/media/usb/cpia2/cpia2_core.c ++++ b/drivers/media/usb/cpia2/cpia2_core.c +@@ -2163,6 +2163,18 @@ static void reset_camera_struct(struct camera_data *cam) + cam->height = cam->params.roi.height; + } + ++/****************************************************************************** ++ * ++ * cpia2_init_camera_struct ++ * ++ * Deinitialize camera struct ++ *****************************************************************************/ ++void cpia2_deinit_camera_struct(struct camera_data *cam, struct usb_interface *intf) ++{ ++ v4l2_device_unregister(&cam->v4l2_dev); ++ kfree(cam); ++} ++ + /****************************************************************************** + * + * cpia2_init_camera_struct +diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c +index 3ab80a7b4498..76aac06f9fb8 100644 +--- a/drivers/media/usb/cpia2/cpia2_usb.c ++++ b/drivers/media/usb/cpia2/cpia2_usb.c +@@ -844,15 +844,13 @@ static int cpia2_usb_probe(struct usb_interface *intf, + ret = set_alternate(cam, USBIF_CMDONLY); + if (ret < 0) { + ERR("%s: usb_set_interface error (ret = %d)\n", __func__, ret); +- kfree(cam); +- return ret; ++ goto alt_err; + } + + + if((ret = cpia2_init_camera(cam)) < 0) { + ERR("%s: failed to initialize cpia2 camera (ret = %d)\n", __func__, ret); +- kfree(cam); +- return ret; ++ goto alt_err; + } + LOG(" CPiA Version: %d.%02d (%d.%d)\n", + cam->params.version.firmware_revision_hi, +@@ -872,11 +870,14 @@ static int cpia2_usb_probe(struct usb_interface *intf, + ret = cpia2_register_camera(cam); + if (ret < 0) { + ERR("%s: Failed to register cpia2 camera (ret = %d)\n", __func__, ret); +- kfree(cam); +- return ret; ++ goto alt_err; + } + + return 0; ++ ++alt_err: ++ cpia2_deinit_camera_struct(cam, intf); ++ return ret; + } + + /****************************************************************************** +-- +2.30.2 + diff --git a/queue-5.10/media-dvb_net-avoid-speculation-from-net-slot.patch b/queue-5.10/media-dvb_net-avoid-speculation-from-net-slot.patch new file mode 100644 index 00000000000..275fea47966 --- /dev/null +++ b/queue-5.10/media-dvb_net-avoid-speculation-from-net-slot.patch @@ -0,0 +1,89 @@ +From 21730c84088d5d26991658e6eccc87350129ed50 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 13:13:54 +0200 +Subject: media: dvb_net: avoid speculation from net slot + +From: Mauro Carvalho Chehab + +[ Upstream commit abc0226df64dc137b48b911c1fe4319aec5891bb ] + +The risk of especulation is actually almost-non-existing here, +as there are very few users of TCP/IP using the DVB stack, +as, this is mainly used with DVB-S/S2 cards, and only by people +that receives TCP/IP from satellite connections, which limits +a lot the number of users of such feature(*). + +(*) In thesis, DVB-C cards could also benefit from it, but I'm +yet to see a hardware that supports it. + +Yet, fixing it is trivial. + +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/dvb-core/dvb_net.c | 25 +++++++++++++++++++------ + 1 file changed, 19 insertions(+), 6 deletions(-) + +diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c +index 89620da983ba..dddebea644bb 100644 +--- a/drivers/media/dvb-core/dvb_net.c ++++ b/drivers/media/dvb-core/dvb_net.c +@@ -45,6 +45,7 @@ + #include + #include + #include ++#include + #include + #include + #include +@@ -1462,14 +1463,20 @@ static int dvb_net_do_ioctl(struct file *file, + struct net_device *netdev; + struct dvb_net_priv *priv_data; + struct dvb_net_if *dvbnetif = parg; ++ int if_num = dvbnetif->if_num; + +- if (dvbnetif->if_num >= DVB_NET_DEVICES_MAX || +- !dvbnet->state[dvbnetif->if_num]) { ++ if (if_num >= DVB_NET_DEVICES_MAX) { + ret = -EINVAL; + goto ioctl_error; + } ++ if_num = array_index_nospec(if_num, DVB_NET_DEVICES_MAX); + +- netdev = dvbnet->device[dvbnetif->if_num]; ++ if (!dvbnet->state[if_num]) { ++ ret = -EINVAL; ++ goto ioctl_error; ++ } ++ ++ netdev = dvbnet->device[if_num]; + + priv_data = netdev_priv(netdev); + dvbnetif->pid=priv_data->pid; +@@ -1522,14 +1529,20 @@ static int dvb_net_do_ioctl(struct file *file, + struct net_device *netdev; + struct dvb_net_priv *priv_data; + struct __dvb_net_if_old *dvbnetif = parg; ++ int if_num = dvbnetif->if_num; ++ ++ if (if_num >= DVB_NET_DEVICES_MAX) { ++ ret = -EINVAL; ++ goto ioctl_error; ++ } ++ if_num = array_index_nospec(if_num, DVB_NET_DEVICES_MAX); + +- if (dvbnetif->if_num >= DVB_NET_DEVICES_MAX || +- !dvbnet->state[dvbnetif->if_num]) { ++ if (!dvbnet->state[if_num]) { + ret = -EINVAL; + goto ioctl_error; + } + +- netdev = dvbnet->device[dvbnetif->if_num]; ++ netdev = dvbnet->device[if_num]; + + priv_data = netdev_priv(netdev); + dvbnetif->pid=priv_data->pid; +-- +2.30.2 + diff --git a/queue-5.10/media-dvd_usb-memory-leak-in-cinergyt2_fe_attach.patch b/queue-5.10/media-dvd_usb-memory-leak-in-cinergyt2_fe_attach.patch new file mode 100644 index 00000000000..2e3343f9c71 --- /dev/null +++ b/queue-5.10/media-dvd_usb-memory-leak-in-cinergyt2_fe_attach.patch @@ -0,0 +1,52 @@ +From dc517e014733fc5994189b3ea10e7a26fa64c652 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 15:06:52 +0200 +Subject: media: dvd_usb: memory leak in cinergyt2_fe_attach + +From: Dongliang Mu + +[ Upstream commit 9ad1efee086e0e913914fa2b2173efb830bad68c ] + +When the driver fails to talk with the hardware with dvb_usb_generic_rw, +it will return an error to dvb_usb_adapter_frontend_init. However, the +driver forgets to free the resource (e.g., struct cinergyt2_fe_state), +which leads to a memory leak. + +Fix this by freeing struct cinergyt2_fe_state when dvb_usb_generic_rw +fails in cinergyt2_frontend_attach. + +backtrace: + [<0000000056e17b1a>] kmalloc include/linux/slab.h:552 [inline] + [<0000000056e17b1a>] kzalloc include/linux/slab.h:682 [inline] + [<0000000056e17b1a>] cinergyt2_fe_attach+0x21/0x80 drivers/media/usb/dvb-usb/cinergyT2-fe.c:271 + [<00000000ae0b1711>] cinergyt2_frontend_attach+0x21/0x70 drivers/media/usb/dvb-usb/cinergyT2-core.c:74 + [<00000000d0254861>] dvb_usb_adapter_frontend_init+0x11b/0x1b0 drivers/media/usb/dvb-usb/dvb-usb-dvb.c:290 + [<0000000002e08ac6>] dvb_usb_adapter_init drivers/media/usb/dvb-usb/dvb-usb-init.c:84 [inline] + [<0000000002e08ac6>] dvb_usb_init drivers/media/usb/dvb-usb/dvb-usb-init.c:173 [inline] + [<0000000002e08ac6>] dvb_usb_device_init.cold+0x4d0/0x6ae drivers/media/usb/dvb-usb/dvb-usb-init.c:287 + +Reported-by: syzbot+e1de8986786b3722050e@syzkaller.appspotmail.com +Signed-off-by: Dongliang Mu +Signed-off-by: Sean Young +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/dvb-usb/cinergyT2-core.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/media/usb/dvb-usb/cinergyT2-core.c b/drivers/media/usb/dvb-usb/cinergyT2-core.c +index 969a7ec71dff..4116ba5c45fc 100644 +--- a/drivers/media/usb/dvb-usb/cinergyT2-core.c ++++ b/drivers/media/usb/dvb-usb/cinergyT2-core.c +@@ -78,6 +78,8 @@ static int cinergyt2_frontend_attach(struct dvb_usb_adapter *adap) + + ret = dvb_usb_generic_rw(d, st->data, 1, st->data, 3, 0); + if (ret < 0) { ++ if (adap->fe_adap[0].fe) ++ adap->fe_adap[0].fe->ops.release(adap->fe_adap[0].fe); + deb_rc("cinergyt2_power_ctrl() Failed to retrieve sleep state info\n"); + } + mutex_unlock(&d->data_mutex); +-- +2.30.2 + diff --git a/queue-5.10/media-em28xx-fix-possible-memory-leak-of-em28xx-stru.patch b/queue-5.10/media-em28xx-fix-possible-memory-leak-of-em28xx-stru.patch new file mode 100644 index 00000000000..6f789fbc54e --- /dev/null +++ b/queue-5.10/media-em28xx-fix-possible-memory-leak-of-em28xx-stru.patch @@ -0,0 +1,58 @@ +From 4d492e90de4a6a48061eae332fe10ff307df4fbe Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 20:32:49 +0200 +Subject: media: em28xx: Fix possible memory leak of em28xx struct + +From: Igor Matheus Andrade Torrente + +[ Upstream commit ac5688637144644f06ed1f3c6d4dd8bb7db96020 ] + +The em28xx struct kref isn't being decreased after an error in the +em28xx_ir_init, leading to a possible memory leak. + +A kref_put and em28xx_shutdown_buttons is added to the error handler code. + +Signed-off-by: Igor Matheus Andrade Torrente +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/em28xx/em28xx-input.c | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c +index 5aa15a7a49de..59529cbf9cd0 100644 +--- a/drivers/media/usb/em28xx/em28xx-input.c ++++ b/drivers/media/usb/em28xx/em28xx-input.c +@@ -720,7 +720,8 @@ static int em28xx_ir_init(struct em28xx *dev) + dev->board.has_ir_i2c = 0; + dev_warn(&dev->intf->dev, + "No i2c IR remote control device found.\n"); +- return -ENODEV; ++ err = -ENODEV; ++ goto ref_put; + } + } + +@@ -735,7 +736,7 @@ static int em28xx_ir_init(struct em28xx *dev) + + ir = kzalloc(sizeof(*ir), GFP_KERNEL); + if (!ir) +- return -ENOMEM; ++ goto ref_put; + rc = rc_allocate_device(RC_DRIVER_SCANCODE); + if (!rc) + goto error; +@@ -839,6 +840,9 @@ error: + dev->ir = NULL; + rc_free_device(rc); + kfree(ir); ++ref_put: ++ em28xx_shutdown_buttons(dev); ++ kref_put(&dev->ref, em28xx_free_device); + return err; + } + +-- +2.30.2 + diff --git a/queue-5.10/media-exynos-gsc-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-exynos-gsc-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..b62281e3a84 --- /dev/null +++ b/queue-5.10/media-exynos-gsc-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,46 @@ +From f9a734c58732d70797e93546b20f813c0941b7c1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:18 +0200 +Subject: media: exynos-gsc: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit 59087b66ea6730c130c57d23bd9fd139b78c1ba5 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +As a bonus, as pm_runtime_get_sync() always return 0 on +success, the logic can be simplified. + +Reviewed-by: Jonathan Cameron +Reviewed-by: Sylwester Nawrocki +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c +index 27a3c92c73bc..f1cf847d1cc2 100644 +--- a/drivers/media/platform/exynos-gsc/gsc-m2m.c ++++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c +@@ -56,10 +56,8 @@ static void __gsc_m2m_job_abort(struct gsc_ctx *ctx) + static int gsc_m2m_start_streaming(struct vb2_queue *q, unsigned int count) + { + struct gsc_ctx *ctx = q->drv_priv; +- int ret; + +- ret = pm_runtime_get_sync(&ctx->gsc_dev->pdev->dev); +- return ret > 0 ? 0 : ret; ++ return pm_runtime_resume_and_get(&ctx->gsc_dev->pdev->dev); + } + + static void __gsc_m2m_cleanup_queue(struct gsc_ctx *ctx) +-- +2.30.2 + diff --git a/queue-5.10/media-exynos4-is-fix-a-use-after-free-in-isp_video_r.patch b/queue-5.10/media-exynos4-is-fix-a-use-after-free-in-isp_video_r.patch new file mode 100644 index 00000000000..568d2d8bc85 --- /dev/null +++ b/queue-5.10/media-exynos4-is-fix-a-use-after-free-in-isp_video_r.patch @@ -0,0 +1,57 @@ +From 9011f68b14a117a5e28e5f9ea5db32fd6c6cfb23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 9 May 2021 10:12:31 +0200 +Subject: media: exynos4-is: Fix a use after free in isp_video_release + +From: Lv Yunlong + +[ Upstream commit 01fe904c9afd26e79c1f73aa0ca2e3d785e5e319 ] + +In isp_video_release, file->private_data is freed via +_vb2_fop_release()->v4l2_fh_release(). But the freed +file->private_data is still used in v4l2_fh_is_singular_file() +->v4l2_fh_is_singular(file->private_data), which is a use +after free bug. + +My patch uses a variable 'is_singular_file' to avoid the uaf. +v3: https://lore.kernel.org/patchwork/patch/1419058/ + +Fixes: 34947b8aebe3f ("[media] exynos4-is: Add the FIMC-IS ISP capture DMA driver") +Signed-off-by: Lv Yunlong +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/exynos4-is/fimc-isp-video.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c +index 8d9dc597deaa..83688a7982f7 100644 +--- a/drivers/media/platform/exynos4-is/fimc-isp-video.c ++++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c +@@ -305,17 +305,20 @@ static int isp_video_release(struct file *file) + struct fimc_is_video *ivc = &isp->video_capture; + struct media_entity *entity = &ivc->ve.vdev.entity; + struct media_device *mdev = entity->graph_obj.mdev; ++ bool is_singular_file; + + mutex_lock(&isp->video_lock); + +- if (v4l2_fh_is_singular_file(file) && ivc->streaming) { ++ is_singular_file = v4l2_fh_is_singular_file(file); ++ ++ if (is_singular_file && ivc->streaming) { + media_pipeline_stop(entity); + ivc->streaming = 0; + } + + _vb2_fop_release(file, NULL); + +- if (v4l2_fh_is_singular_file(file)) { ++ if (is_singular_file) { + fimc_pipeline_call(&ivc->ve, close); + + mutex_lock(&mdev->graph_mutex); +-- +2.30.2 + diff --git a/queue-5.10/media-exynos4-is-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-exynos4-is-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..4a32f52c491 --- /dev/null +++ b/queue-5.10/media-exynos4-is-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,225 @@ +From dcdcbc90dda0d4e367ac581c411356b1af50ff83 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:17 +0200 +Subject: media: exynos4-is: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit 59f96244af9403ddf4810ec5c0fbe8920857634e ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. + +On some places, this is ok, but on others the usage count +ended being unbalanced on failures. + +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +As a bonus, such function always return zero on success. So, +some code can be simplified. + +Reviewed-by: Sylwester Nawrocki +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/exynos4-is/fimc-capture.c | 6 ++---- + drivers/media/platform/exynos4-is/fimc-is.c | 4 ++-- + drivers/media/platform/exynos4-is/fimc-isp-video.c | 3 +-- + drivers/media/platform/exynos4-is/fimc-isp.c | 7 +++---- + drivers/media/platform/exynos4-is/fimc-lite.c | 5 +++-- + drivers/media/platform/exynos4-is/fimc-m2m.c | 5 +---- + drivers/media/platform/exynos4-is/media-dev.c | 9 +++------ + drivers/media/platform/exynos4-is/mipi-csis.c | 10 ++++------ + 8 files changed, 19 insertions(+), 30 deletions(-) + +diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c +index 6000a4e789ad..808b490c1910 100644 +--- a/drivers/media/platform/exynos4-is/fimc-capture.c ++++ b/drivers/media/platform/exynos4-is/fimc-capture.c +@@ -478,11 +478,9 @@ static int fimc_capture_open(struct file *file) + goto unlock; + + set_bit(ST_CAPT_BUSY, &fimc->state); +- ret = pm_runtime_get_sync(&fimc->pdev->dev); +- if (ret < 0) { +- pm_runtime_put_sync(&fimc->pdev->dev); ++ ret = pm_runtime_resume_and_get(&fimc->pdev->dev); ++ if (ret < 0) + goto unlock; +- } + + ret = v4l2_fh_open(file); + if (ret) { +diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c +index 32ab01e89196..d26fa5967d82 100644 +--- a/drivers/media/platform/exynos4-is/fimc-is.c ++++ b/drivers/media/platform/exynos4-is/fimc-is.c +@@ -828,9 +828,9 @@ static int fimc_is_probe(struct platform_device *pdev) + goto err_irq; + } + +- ret = pm_runtime_get_sync(dev); ++ ret = pm_runtime_resume_and_get(dev); + if (ret < 0) +- goto err_pm; ++ goto err_irq; + + vb2_dma_contig_set_max_seg_size(dev, DMA_BIT_MASK(32)); + +diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c +index 612b9872afc8..8d9dc597deaa 100644 +--- a/drivers/media/platform/exynos4-is/fimc-isp-video.c ++++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c +@@ -275,7 +275,7 @@ static int isp_video_open(struct file *file) + if (ret < 0) + goto unlock; + +- ret = pm_runtime_get_sync(&isp->pdev->dev); ++ ret = pm_runtime_resume_and_get(&isp->pdev->dev); + if (ret < 0) + goto rel_fh; + +@@ -293,7 +293,6 @@ static int isp_video_open(struct file *file) + if (!ret) + goto unlock; + rel_fh: +- pm_runtime_put_noidle(&isp->pdev->dev); + v4l2_fh_release(file); + unlock: + mutex_unlock(&isp->video_lock); +diff --git a/drivers/media/platform/exynos4-is/fimc-isp.c b/drivers/media/platform/exynos4-is/fimc-isp.c +index a77c49b18511..74b49d30901e 100644 +--- a/drivers/media/platform/exynos4-is/fimc-isp.c ++++ b/drivers/media/platform/exynos4-is/fimc-isp.c +@@ -304,11 +304,10 @@ static int fimc_isp_subdev_s_power(struct v4l2_subdev *sd, int on) + pr_debug("on: %d\n", on); + + if (on) { +- ret = pm_runtime_get_sync(&is->pdev->dev); +- if (ret < 0) { +- pm_runtime_put(&is->pdev->dev); ++ ret = pm_runtime_resume_and_get(&is->pdev->dev); ++ if (ret < 0) + return ret; +- } ++ + set_bit(IS_ST_PWR_ON, &is->state); + + ret = fimc_is_start_firmware(is); +diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c +index fdd0d369b192..d279f282d592 100644 +--- a/drivers/media/platform/exynos4-is/fimc-lite.c ++++ b/drivers/media/platform/exynos4-is/fimc-lite.c +@@ -469,9 +469,9 @@ static int fimc_lite_open(struct file *file) + } + + set_bit(ST_FLITE_IN_USE, &fimc->state); +- ret = pm_runtime_get_sync(&fimc->pdev->dev); ++ ret = pm_runtime_resume_and_get(&fimc->pdev->dev); + if (ret < 0) +- goto err_pm; ++ goto err_in_use; + + ret = v4l2_fh_open(file); + if (ret < 0) +@@ -499,6 +499,7 @@ static int fimc_lite_open(struct file *file) + v4l2_fh_release(file); + err_pm: + pm_runtime_put_sync(&fimc->pdev->dev); ++err_in_use: + clear_bit(ST_FLITE_IN_USE, &fimc->state); + unlock: + mutex_unlock(&fimc->lock); +diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c b/drivers/media/platform/exynos4-is/fimc-m2m.c +index 4acb179556c4..24b1badd2080 100644 +--- a/drivers/media/platform/exynos4-is/fimc-m2m.c ++++ b/drivers/media/platform/exynos4-is/fimc-m2m.c +@@ -73,17 +73,14 @@ static void fimc_m2m_shutdown(struct fimc_ctx *ctx) + static int start_streaming(struct vb2_queue *q, unsigned int count) + { + struct fimc_ctx *ctx = q->drv_priv; +- int ret; + +- ret = pm_runtime_get_sync(&ctx->fimc_dev->pdev->dev); +- return ret > 0 ? 0 : ret; ++ return pm_runtime_resume_and_get(&ctx->fimc_dev->pdev->dev); + } + + static void stop_streaming(struct vb2_queue *q) + { + struct fimc_ctx *ctx = q->drv_priv; + +- + fimc_m2m_shutdown(ctx); + fimc_m2m_job_finish(ctx, VB2_BUF_STATE_ERROR); + pm_runtime_put(&ctx->fimc_dev->pdev->dev); +diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c +index e636c33e847b..1272f4703b81 100644 +--- a/drivers/media/platform/exynos4-is/media-dev.c ++++ b/drivers/media/platform/exynos4-is/media-dev.c +@@ -508,11 +508,9 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd) + if (!fmd->pmf) + return -ENXIO; + +- ret = pm_runtime_get_sync(fmd->pmf); +- if (ret < 0) { +- pm_runtime_put(fmd->pmf); ++ ret = pm_runtime_resume_and_get(fmd->pmf); ++ if (ret < 0) + return ret; +- } + + fmd->num_sensors = 0; + +@@ -1287,8 +1285,7 @@ static int cam_clk_prepare(struct clk_hw *hw) + if (camclk->fmd->pmf == NULL) + return -ENODEV; + +- ret = pm_runtime_get_sync(camclk->fmd->pmf); +- return ret < 0 ? ret : 0; ++ return pm_runtime_resume_and_get(camclk->fmd->pmf); + } + + static void cam_clk_unprepare(struct clk_hw *hw) +diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c +index 1aac167abb17..ebf39c856894 100644 +--- a/drivers/media/platform/exynos4-is/mipi-csis.c ++++ b/drivers/media/platform/exynos4-is/mipi-csis.c +@@ -494,7 +494,7 @@ static int s5pcsis_s_power(struct v4l2_subdev *sd, int on) + struct device *dev = &state->pdev->dev; + + if (on) +- return pm_runtime_get_sync(dev); ++ return pm_runtime_resume_and_get(dev); + + return pm_runtime_put_sync(dev); + } +@@ -509,11 +509,9 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable) + + if (enable) { + s5pcsis_clear_counters(state); +- ret = pm_runtime_get_sync(&state->pdev->dev); +- if (ret && ret != 1) { +- pm_runtime_put_noidle(&state->pdev->dev); ++ ret = pm_runtime_resume_and_get(&state->pdev->dev); ++ if (ret < 0) + return ret; +- } + } + + mutex_lock(&state->lock); +@@ -535,7 +533,7 @@ unlock: + if (!enable) + pm_runtime_put(&state->pdev->dev); + +- return ret == 1 ? 0 : ret; ++ return ret; + } + + static int s5pcsis_enum_mbus_code(struct v4l2_subdev *sd, +-- +2.30.2 + diff --git a/queue-5.10/media-fix-media-controller-api-config-checks.patch b/queue-5.10/media-fix-media-controller-api-config-checks.patch new file mode 100644 index 00000000000..c2a163f0f21 --- /dev/null +++ b/queue-5.10/media-fix-media-controller-api-config-checks.patch @@ -0,0 +1,88 @@ +From 6e10454f61f41cb5d751c0875ccf0245c02dd8e9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 17:19:06 +0200 +Subject: media: Fix Media Controller API config checks + +From: Shuah Khan + +[ Upstream commit 50e7a31d30e8221632675abed3be306382324ca2 ] + +Smatch static checker warns that "mdev" can be null: + +sound/usb/media.c:287 snd_media_device_create() + warn: 'mdev' can also be NULL + +If CONFIG_MEDIA_CONTROLLER is disabled, this file should not be included +in the build. + +The below conditions in the sound/usb/Makefile are in place to ensure that +media.c isn't included in the build. + +sound/usb/Makefile: +snd-usb-audio-$(CONFIG_SND_USB_AUDIO_USE_MEDIA_CONTROLLER) += media.o + +select SND_USB_AUDIO_USE_MEDIA_CONTROLLER if MEDIA_CONTROLLER && + (MEDIA_SUPPORT=y || MEDIA_SUPPORT=SND_USB_AUDIO) + +The following config check in include/media/media-dev-allocator.h is +in place to enable the API only when CONFIG_MEDIA_CONTROLLER and +CONFIG_USB are enabled. + + #if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) + +This check doesn't work as intended when CONFIG_USB=m. When CONFIG_USB=m, +CONFIG_USB_MODULE is defined and CONFIG_USB is not. The above config check +doesn't catch that CONFIG_USB is defined as a module and disables the API. +This results in sound/usb enabling Media Controller specific ALSA driver +code, while Media disables the Media Controller API. + +Fix the problem requires two changes: + +1. Change the check to use IS_ENABLED to detect when CONFIG_USB is enabled + as a module or static. Since CONFIG_MEDIA_CONTROLLER is a bool, leave + the check unchanged to be consistent with drivers/media/Makefile. + +2. Change the drivers/media/mc/Makefile to include mc-dev-allocator.o + in mc-objs when CONFIG_USB is enabled. + +Link: https://lore.kernel.org/alsa-devel/YLeAvT+R22FQ%2FEyw@mwanda/ + +Reported-by: Dan Carpenter +Signed-off-by: Shuah Khan +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/mc/Makefile | 2 +- + include/media/media-dev-allocator.h | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/mc/Makefile b/drivers/media/mc/Makefile +index 119037f0e686..2b7af42ba59c 100644 +--- a/drivers/media/mc/Makefile ++++ b/drivers/media/mc/Makefile +@@ -3,7 +3,7 @@ + mc-objs := mc-device.o mc-devnode.o mc-entity.o \ + mc-request.o + +-ifeq ($(CONFIG_USB),y) ++ifneq ($(CONFIG_USB),) + mc-objs += mc-dev-allocator.o + endif + +diff --git a/include/media/media-dev-allocator.h b/include/media/media-dev-allocator.h +index b35ea6062596..2ab54d426c64 100644 +--- a/include/media/media-dev-allocator.h ++++ b/include/media/media-dev-allocator.h +@@ -19,7 +19,7 @@ + + struct usb_device; + +-#if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) ++#if defined(CONFIG_MEDIA_CONTROLLER) && IS_ENABLED(CONFIG_USB) + /** + * media_device_usb_allocate() - Allocate and return struct &media device + * +-- +2.30.2 + diff --git a/queue-5.10/media-gspca-gl860-fix-zero-length-control-requests.patch b/queue-5.10/media-gspca-gl860-fix-zero-length-control-requests.patch new file mode 100644 index 00000000000..16f45839efb --- /dev/null +++ b/queue-5.10/media-gspca-gl860-fix-zero-length-control-requests.patch @@ -0,0 +1,48 @@ +From 2d84dbbc9b7b0ae905299c19cd197f4a07058dda Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 24 May 2021 13:09:18 +0200 +Subject: media: gspca/gl860: fix zero-length control requests + +From: Johan Hovold + +[ Upstream commit 8ed339f23d41e21660a389adf2e7b2966d457ff6 ] + +The direction of the pipe argument must match the request-type direction +bit or control requests may fail depending on the host-controller-driver +implementation. + +Control transfers without a data stage are treated as OUT requests by +the USB stack and should be using usb_sndctrlpipe(). Failing to do so +will now trigger a warning. + +Fix the gl860_RTx() helper so that zero-length control reads fail with +an error message instead. Note that there are no current callers that +would trigger this. + +Fixes: 4f7cb8837cec ("V4L/DVB (12954): gspca - gl860: Addition of GL860 based webcams") +Signed-off-by: Johan Hovold +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/gspca/gl860/gl860.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/usb/gspca/gl860/gl860.c b/drivers/media/usb/gspca/gl860/gl860.c +index 2c05ea2598e7..ce4ee8bc75c8 100644 +--- a/drivers/media/usb/gspca/gl860/gl860.c ++++ b/drivers/media/usb/gspca/gl860/gl860.c +@@ -561,8 +561,8 @@ int gl860_RTx(struct gspca_dev *gspca_dev, + len, 400 + 200 * (len > 1)); + memcpy(pdata, gspca_dev->usb_buf, len); + } else { +- r = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), +- req, pref, val, index, NULL, len, 400); ++ gspca_err(gspca_dev, "zero-length read request\n"); ++ r = -EINVAL; + } + } + +-- +2.30.2 + diff --git a/queue-5.10/media-hantro-do-a-pm-resume-earlier.patch b/queue-5.10/media-hantro-do-a-pm-resume-earlier.patch new file mode 100644 index 00000000000..f3b3d0e07e4 --- /dev/null +++ b/queue-5.10/media-hantro-do-a-pm-resume-earlier.patch @@ -0,0 +1,99 @@ +From 53dfb24990b1388209ecc7e00b8e72e118ce197b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Apr 2021 08:27:55 +0200 +Subject: media: hantro: do a PM resume earlier + +From: Mauro Carvalho Chehab + +[ Upstream commit 892bb6ecead9b834ba7ad1d07513e9eba1baa3a4 ] + +The device_run() first enables the clock and then +tries to resume PM runtime, checking for errors. + +Well, if for some reason the pm_runtime can not resume, +it would be better to detect it beforehand. + +So, change the order inside device_run(). + +Reviewed-by: Ezequiel Garcia +Fixes: 775fec69008d ("media: add Rockchip VPU JPEG encoder driver") +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/hantro/hantro_drv.c | 33 +++++++++++++++-------- + 1 file changed, 22 insertions(+), 11 deletions(-) + +diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c +index 3cd00cc0a364..7749ca9a8ebb 100644 +--- a/drivers/staging/media/hantro/hantro_drv.c ++++ b/drivers/staging/media/hantro/hantro_drv.c +@@ -56,16 +56,12 @@ dma_addr_t hantro_get_ref(struct hantro_ctx *ctx, u64 ts) + return hantro_get_dec_buf_addr(ctx, buf); + } + +-static void hantro_job_finish(struct hantro_dev *vpu, +- struct hantro_ctx *ctx, +- enum vb2_buffer_state result) ++static void hantro_job_finish_no_pm(struct hantro_dev *vpu, ++ struct hantro_ctx *ctx, ++ enum vb2_buffer_state result) + { + struct vb2_v4l2_buffer *src, *dst; + +- pm_runtime_mark_last_busy(vpu->dev); +- pm_runtime_put_autosuspend(vpu->dev); +- clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks); +- + src = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); + dst = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); + +@@ -81,6 +77,18 @@ static void hantro_job_finish(struct hantro_dev *vpu, + result); + } + ++static void hantro_job_finish(struct hantro_dev *vpu, ++ struct hantro_ctx *ctx, ++ enum vb2_buffer_state result) ++{ ++ pm_runtime_mark_last_busy(vpu->dev); ++ pm_runtime_put_autosuspend(vpu->dev); ++ ++ clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks); ++ ++ hantro_job_finish_no_pm(vpu, ctx, result); ++} ++ + void hantro_irq_done(struct hantro_dev *vpu, + enum vb2_buffer_state result) + { +@@ -152,12 +160,15 @@ static void device_run(void *priv) + src = hantro_get_src_buf(ctx); + dst = hantro_get_dst_buf(ctx); + ++ ret = pm_runtime_get_sync(ctx->dev->dev); ++ if (ret < 0) { ++ pm_runtime_put_noidle(ctx->dev->dev); ++ goto err_cancel_job; ++ } ++ + ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks); + if (ret) + goto err_cancel_job; +- ret = pm_runtime_get_sync(ctx->dev->dev); +- if (ret < 0) +- goto err_cancel_job; + + v4l2_m2m_buf_copy_metadata(src, dst, true); + +@@ -165,7 +176,7 @@ static void device_run(void *priv) + return; + + err_cancel_job: +- hantro_job_finish(ctx->dev, ctx, VB2_BUF_STATE_ERROR); ++ hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR); + } + + static struct v4l2_m2m_ops vpu_m2m_ops = { +-- +2.30.2 + diff --git a/queue-5.10/media-hantro-fix-.buf_prepare.patch b/queue-5.10/media-hantro-fix-.buf_prepare.patch new file mode 100644 index 00000000000..3b730da3756 --- /dev/null +++ b/queue-5.10/media-hantro-fix-.buf_prepare.patch @@ -0,0 +1,48 @@ +From 75892552daace9422caacea6325a073c2318450d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 14:23:46 +0200 +Subject: media: hantro: Fix .buf_prepare + +From: Andrzej Pietrasiewicz + +[ Upstream commit 082aaecff35fbe1937531057911b1dd1fc6b496e ] + +The driver should only set the payload on .buf_prepare if the +buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused +set by userspace then v4l2-core will set it to buffer length. + +If we overwrite bytesused for OUTPUT buffers, too, then +vb2_get_plane_payload() will return incorrect value which might be then +written to hw registers by the driver in hantro_g1_h264_dec.c. + +Signed-off-by: Andrzej Pietrasiewicz +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/hantro/hantro_v4l2.c | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers/staging/media/hantro/hantro_v4l2.c +index f5fbdbc4ffdb..5c2ca61add8e 100644 +--- a/drivers/staging/media/hantro/hantro_v4l2.c ++++ b/drivers/staging/media/hantro/hantro_v4l2.c +@@ -639,7 +639,14 @@ static int hantro_buf_prepare(struct vb2_buffer *vb) + ret = hantro_buf_plane_check(vb, pix_fmt); + if (ret) + return ret; +- vb2_set_plane_payload(vb, 0, pix_fmt->plane_fmt[0].sizeimage); ++ /* ++ * Buffer's bytesused must be written by driver for CAPTURE buffers. ++ * (for OUTPUT buffers, if userspace passes 0 bytesused, v4l2-core sets ++ * it to buffer length). ++ */ ++ if (V4L2_TYPE_IS_CAPTURE(vq->type)) ++ vb2_set_plane_payload(vb, 0, pix_fmt->plane_fmt[0].sizeimage); ++ + return 0; + } + +-- +2.30.2 + diff --git a/queue-5.10/media-hevc-fix-dependent-slice-segment-flags.patch b/queue-5.10/media-hevc-fix-dependent-slice-segment-flags.patch new file mode 100644 index 00000000000..be85bfa5b2e --- /dev/null +++ b/queue-5.10/media-hevc-fix-dependent-slice-segment-flags.patch @@ -0,0 +1,88 @@ +From 70ac05b60952642175ee6e9330a4920e26041a32 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 27 Apr 2021 09:15:54 +0200 +Subject: media: hevc: Fix dependent slice segment flags + +From: Jernej Skrabec + +[ Upstream commit 67a7e53d5b21f3a84efc03a4e62db7caf97841ef ] + +Dependent slice segment flag for PPS control is misnamed. It should have +"enabled" at the end. It only tells if this flag is present in slice +header or not and not the actual value. + +Fix this by renaming the PPS flag and introduce another flag for slice +control which tells actual value. + +Signed-off-by: Jernej Skrabec +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 ++++- + drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 4 ++-- + include/media/hevc-ctrls.h | 3 ++- + 3 files changed, 8 insertions(+), 4 deletions(-) + +diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst +index ce728c757eaf..b864869b42bc 100644 +--- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst ++++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst +@@ -4030,7 +4030,7 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - + :stub-columns: 0 + :widths: 1 1 2 + +- * - ``V4L2_HEVC_PPS_FLAG_DEPENDENT_SLICE_SEGMENT`` ++ * - ``V4L2_HEVC_PPS_FLAG_DEPENDENT_SLICE_SEGMENT_ENABLED`` + - 0x00000001 + - + * - ``V4L2_HEVC_PPS_FLAG_OUTPUT_FLAG_PRESENT`` +@@ -4238,6 +4238,9 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - + * - ``V4L2_HEVC_SLICE_PARAMS_FLAG_SLICE_LOOP_FILTER_ACROSS_SLICES_ENABLED`` + - 0x00000100 + - ++ * - ``V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT`` ++ - 0x00000200 ++ - + + .. c:type:: v4l2_hevc_dpb_entry + +diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c +index ce497d0197df..10744fab7cea 100644 +--- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c ++++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c +@@ -477,8 +477,8 @@ static void cedrus_h265_setup(struct cedrus_ctx *ctx, + slice_params->flags); + + reg |= VE_DEC_H265_FLAG(VE_DEC_H265_DEC_SLICE_HDR_INFO0_FLAG_DEPENDENT_SLICE_SEGMENT, +- V4L2_HEVC_PPS_FLAG_DEPENDENT_SLICE_SEGMENT, +- pps->flags); ++ V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT, ++ slice_params->flags); + + /* FIXME: For multi-slice support. */ + reg |= VE_DEC_H265_DEC_SLICE_HDR_INFO0_FLAG_FIRST_SLICE_SEGMENT_IN_PIC; +diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h +index 1009cf0891cc..a3b650ab00f6 100644 +--- a/include/media/hevc-ctrls.h ++++ b/include/media/hevc-ctrls.h +@@ -81,7 +81,7 @@ struct v4l2_ctrl_hevc_sps { + __u64 flags; + }; + +-#define V4L2_HEVC_PPS_FLAG_DEPENDENT_SLICE_SEGMENT (1ULL << 0) ++#define V4L2_HEVC_PPS_FLAG_DEPENDENT_SLICE_SEGMENT_ENABLED (1ULL << 0) + #define V4L2_HEVC_PPS_FLAG_OUTPUT_FLAG_PRESENT (1ULL << 1) + #define V4L2_HEVC_PPS_FLAG_SIGN_DATA_HIDING_ENABLED (1ULL << 2) + #define V4L2_HEVC_PPS_FLAG_CABAC_INIT_PRESENT (1ULL << 3) +@@ -160,6 +160,7 @@ struct v4l2_hevc_pred_weight_table { + #define V4L2_HEVC_SLICE_PARAMS_FLAG_USE_INTEGER_MV (1ULL << 6) + #define V4L2_HEVC_SLICE_PARAMS_FLAG_SLICE_DEBLOCKING_FILTER_DISABLED (1ULL << 7) + #define V4L2_HEVC_SLICE_PARAMS_FLAG_SLICE_LOOP_FILTER_ACROSS_SLICES_ENABLED (1ULL << 8) ++#define V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT (1ULL << 9) + + struct v4l2_ctrl_hevc_slice_params { + __u32 bit_size; +-- +2.30.2 + diff --git a/queue-5.10/media-i2c-change-rst-to-rset-to-fix-multiple-build-e.patch b/queue-5.10/media-i2c-change-rst-to-rset-to-fix-multiple-build-e.patch new file mode 100644 index 00000000000..441e115ee2e --- /dev/null +++ b/queue-5.10/media-i2c-change-rst-to-rset-to-fix-multiple-build-e.patch @@ -0,0 +1,244 @@ +From ab68b85d00172c3f2a4ed779b757e935a1f115f3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 30 Apr 2021 22:19:55 +0200 +Subject: media: I2C: change 'RST' to "RSET" to fix multiple build errors + +From: Randy Dunlap + +[ Upstream commit 8edcb5049ac29aa3c8acc5ef15dd4036543d747e ] + +The use of an enum named 'RST' conflicts with a #define macro +named 'RST' in arch/mips/include/asm/mach-rc32434/rb.h. + +The MIPS use of RST was there first (AFAICT), so change the +media/i2c/ uses of RST to be named 'RSET'. +'git grep -w RSET' does not report any naming conflicts with the +new name. + +This fixes multiple build errors: + +arch/mips/include/asm/mach-rc32434/rb.h:15:14: error: expected identifier before '(' token + 15 | #define RST (1 << 15) + | ^ +drivers/media/i2c/s5c73m3/s5c73m3.h:356:2: note: in expansion of macro 'RST' + 356 | RST, + | ^~~ + +../arch/mips/include/asm/mach-rc32434/rb.h:15:14: error: expected identifier before '(' token + 15 | #define RST (1 << 15) + | ^ +../drivers/media/i2c/s5k6aa.c:180:2: note: in expansion of macro 'RST' + 180 | RST, + | ^~~ + +../arch/mips/include/asm/mach-rc32434/rb.h:15:14: error: expected identifier before '(' token + 15 | #define RST (1 << 15) + | ^ +../drivers/media/i2c/s5k5baf.c:238:2: note: in expansion of macro 'RST' + 238 | RST, + | ^~~ + +and some others that I have trimmed. + +Fixes: cac47f1822fc ("[media] V4L: Add S5C73M3 camera driver") +Fixes: 8b99312b7214 ("[media] Add v4l2 subdev driver for S5K4ECGX sensor") +Fixes: 7d459937dc09 ("[media] Add driver for Samsung S5K5BAF camera sensor") +Fixes: bfa8dd3a0524 ("[media] v4l: Add v4l2 subdev driver for S5K6AAFX sensor") +Signed-off-by: Randy Dunlap +Reported-by: kernel test robot +Cc: Shawn Guo +Cc: Sascha Hauer +Cc: Pengutronix Kernel Team +Cc: Fabio Estevam +Cc: NXP Linux Team +Cc: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +Cc: Andrzej Hajda +Cc: Sylwester Nawrocki +Cc: Sangwook Lee +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/i2c/s5c73m3/s5c73m3-core.c | 6 +++--- + drivers/media/i2c/s5c73m3/s5c73m3.h | 2 +- + drivers/media/i2c/s5k4ecgx.c | 10 +++++----- + drivers/media/i2c/s5k5baf.c | 6 +++--- + drivers/media/i2c/s5k6aa.c | 10 +++++----- + 5 files changed, 17 insertions(+), 17 deletions(-) + +diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c +index 5b4c4a3547c9..71804a70bc6d 100644 +--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c ++++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c +@@ -1386,7 +1386,7 @@ static int __s5c73m3_power_on(struct s5c73m3 *state) + s5c73m3_gpio_deassert(state, STBY); + usleep_range(100, 200); + +- s5c73m3_gpio_deassert(state, RST); ++ s5c73m3_gpio_deassert(state, RSET); + usleep_range(50, 100); + + return 0; +@@ -1401,7 +1401,7 @@ static int __s5c73m3_power_off(struct s5c73m3 *state) + { + int i, ret; + +- if (s5c73m3_gpio_assert(state, RST)) ++ if (s5c73m3_gpio_assert(state, RSET)) + usleep_range(10, 50); + + if (s5c73m3_gpio_assert(state, STBY)) +@@ -1606,7 +1606,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state) + + state->mclk_frequency = pdata->mclk_frequency; + state->gpio[STBY] = pdata->gpio_stby; +- state->gpio[RST] = pdata->gpio_reset; ++ state->gpio[RSET] = pdata->gpio_reset; + return 0; + } + +diff --git a/drivers/media/i2c/s5c73m3/s5c73m3.h b/drivers/media/i2c/s5c73m3/s5c73m3.h +index ef7e85b34263..c3fcfdd3ea66 100644 +--- a/drivers/media/i2c/s5c73m3/s5c73m3.h ++++ b/drivers/media/i2c/s5c73m3/s5c73m3.h +@@ -353,7 +353,7 @@ struct s5c73m3_ctrls { + + enum s5c73m3_gpio_id { + STBY, +- RST, ++ RSET, + GPIO_NUM, + }; + +diff --git a/drivers/media/i2c/s5k4ecgx.c b/drivers/media/i2c/s5k4ecgx.c +index b2d53417badf..4e97309a67f4 100644 +--- a/drivers/media/i2c/s5k4ecgx.c ++++ b/drivers/media/i2c/s5k4ecgx.c +@@ -173,7 +173,7 @@ static const char * const s5k4ecgx_supply_names[] = { + + enum s5k4ecgx_gpio_id { + STBY, +- RST, ++ RSET, + GPIO_NUM, + }; + +@@ -476,7 +476,7 @@ static int __s5k4ecgx_power_on(struct s5k4ecgx *priv) + if (s5k4ecgx_gpio_set_value(priv, STBY, priv->gpio[STBY].level)) + usleep_range(30, 50); + +- if (s5k4ecgx_gpio_set_value(priv, RST, priv->gpio[RST].level)) ++ if (s5k4ecgx_gpio_set_value(priv, RSET, priv->gpio[RSET].level)) + usleep_range(30, 50); + + return 0; +@@ -484,7 +484,7 @@ static int __s5k4ecgx_power_on(struct s5k4ecgx *priv) + + static int __s5k4ecgx_power_off(struct s5k4ecgx *priv) + { +- if (s5k4ecgx_gpio_set_value(priv, RST, !priv->gpio[RST].level)) ++ if (s5k4ecgx_gpio_set_value(priv, RSET, !priv->gpio[RSET].level)) + usleep_range(30, 50); + + if (s5k4ecgx_gpio_set_value(priv, STBY, !priv->gpio[STBY].level)) +@@ -872,7 +872,7 @@ static int s5k4ecgx_config_gpios(struct s5k4ecgx *priv, + int ret; + + priv->gpio[STBY].gpio = -EINVAL; +- priv->gpio[RST].gpio = -EINVAL; ++ priv->gpio[RSET].gpio = -EINVAL; + + ret = s5k4ecgx_config_gpio(gpio->gpio, gpio->level, "S5K4ECGX_STBY"); + +@@ -891,7 +891,7 @@ static int s5k4ecgx_config_gpios(struct s5k4ecgx *priv, + s5k4ecgx_free_gpios(priv); + return ret; + } +- priv->gpio[RST] = *gpio; ++ priv->gpio[RSET] = *gpio; + if (gpio_is_valid(gpio->gpio)) + gpio_set_value(gpio->gpio, 0); + +diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c +index ec6f22efe19a..ec65a8e084c6 100644 +--- a/drivers/media/i2c/s5k5baf.c ++++ b/drivers/media/i2c/s5k5baf.c +@@ -235,7 +235,7 @@ struct s5k5baf_gpio { + + enum s5k5baf_gpio_id { + STBY, +- RST, ++ RSET, + NUM_GPIOS, + }; + +@@ -969,7 +969,7 @@ static int s5k5baf_power_on(struct s5k5baf *state) + + s5k5baf_gpio_deassert(state, STBY); + usleep_range(50, 100); +- s5k5baf_gpio_deassert(state, RST); ++ s5k5baf_gpio_deassert(state, RSET); + return 0; + + err_reg_dis: +@@ -987,7 +987,7 @@ static int s5k5baf_power_off(struct s5k5baf *state) + state->apply_cfg = 0; + state->apply_crop = 0; + +- s5k5baf_gpio_assert(state, RST); ++ s5k5baf_gpio_assert(state, RSET); + s5k5baf_gpio_assert(state, STBY); + + if (!IS_ERR(state->clock)) +diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c +index 72439fae7968..6516e205e9a3 100644 +--- a/drivers/media/i2c/s5k6aa.c ++++ b/drivers/media/i2c/s5k6aa.c +@@ -177,7 +177,7 @@ static const char * const s5k6aa_supply_names[] = { + + enum s5k6aa_gpio_id { + STBY, +- RST, ++ RSET, + GPIO_NUM, + }; + +@@ -841,7 +841,7 @@ static int __s5k6aa_power_on(struct s5k6aa *s5k6aa) + ret = s5k6aa->s_power(1); + usleep_range(4000, 5000); + +- if (s5k6aa_gpio_deassert(s5k6aa, RST)) ++ if (s5k6aa_gpio_deassert(s5k6aa, RSET)) + msleep(20); + + return ret; +@@ -851,7 +851,7 @@ static int __s5k6aa_power_off(struct s5k6aa *s5k6aa) + { + int ret; + +- if (s5k6aa_gpio_assert(s5k6aa, RST)) ++ if (s5k6aa_gpio_assert(s5k6aa, RSET)) + usleep_range(100, 150); + + if (s5k6aa->s_power) { +@@ -1510,7 +1510,7 @@ static int s5k6aa_configure_gpios(struct s5k6aa *s5k6aa, + int ret; + + s5k6aa->gpio[STBY].gpio = -EINVAL; +- s5k6aa->gpio[RST].gpio = -EINVAL; ++ s5k6aa->gpio[RSET].gpio = -EINVAL; + + gpio = &pdata->gpio_stby; + if (gpio_is_valid(gpio->gpio)) { +@@ -1533,7 +1533,7 @@ static int s5k6aa_configure_gpios(struct s5k6aa *s5k6aa, + if (ret < 0) + return ret; + +- s5k6aa->gpio[RST] = *gpio; ++ s5k6aa->gpio[RSET] = *gpio; + } + + return 0; +-- +2.30.2 + diff --git a/queue-5.10/media-i2c-ov2659-use-clk_-prepare_enable-disable_unp.patch b/queue-5.10/media-i2c-ov2659-use-clk_-prepare_enable-disable_unp.patch new file mode 100644 index 00000000000..8a30b8687ac --- /dev/null +++ b/queue-5.10/media-i2c-ov2659-use-clk_-prepare_enable-disable_unp.patch @@ -0,0 +1,106 @@ +From d81d55872132535744ffa791979f46ad82f722ce Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 07:09:53 +0200 +Subject: media: i2c: ov2659: Use clk_{prepare_enable,disable_unprepare}() to + set xvclk on/off + +From: Dillon Min + +[ Upstream commit 24786ccd9c80fdb05494aa4d90fcb8f34295c193 ] + +On some platform(imx6q), xvclk might not switch on in advance, +also for power save purpose, xvclk should not be always on. +so, add clk_prepare_enable(), clk_disable_unprepare() in driver +side to set xvclk on/off at proper stage. + +Add following changes: +- add 'struct clk *clk;' in 'struct ov2659 {}' +- enable xvclk in ov2659_power_on() +- disable xvclk in ov2659_power_off() + +Signed-off-by: Dillon Min +Acked-by: Lad Prabhakar +Signed-off-by: Sakari Ailus +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/i2c/ov2659.c | 24 ++++++++++++++++++------ + 1 file changed, 18 insertions(+), 6 deletions(-) + +diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c +index 42f64175a6df..fb78a1cedc03 100644 +--- a/drivers/media/i2c/ov2659.c ++++ b/drivers/media/i2c/ov2659.c +@@ -204,6 +204,7 @@ struct ov2659 { + struct i2c_client *client; + struct v4l2_ctrl_handler ctrls; + struct v4l2_ctrl *link_frequency; ++ struct clk *clk; + const struct ov2659_framesize *frame_size; + struct sensor_register *format_ctrl_regs; + struct ov2659_pll_ctrl pll; +@@ -1270,6 +1271,8 @@ static int ov2659_power_off(struct device *dev) + + gpiod_set_value(ov2659->pwdn_gpio, 1); + ++ clk_disable_unprepare(ov2659->clk); ++ + return 0; + } + +@@ -1278,9 +1281,17 @@ static int ov2659_power_on(struct device *dev) + struct i2c_client *client = to_i2c_client(dev); + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct ov2659 *ov2659 = to_ov2659(sd); ++ int ret; + + dev_dbg(&client->dev, "%s:\n", __func__); + ++ ret = clk_prepare_enable(ov2659->clk); ++ if (ret) { ++ dev_err(&client->dev, "%s: failed to enable clock\n", ++ __func__); ++ return ret; ++ } ++ + gpiod_set_value(ov2659->pwdn_gpio, 0); + + if (ov2659->resetb_gpio) { +@@ -1425,7 +1436,6 @@ static int ov2659_probe(struct i2c_client *client) + const struct ov2659_platform_data *pdata = ov2659_get_pdata(client); + struct v4l2_subdev *sd; + struct ov2659 *ov2659; +- struct clk *clk; + int ret; + + if (!pdata) { +@@ -1440,11 +1450,11 @@ static int ov2659_probe(struct i2c_client *client) + ov2659->pdata = pdata; + ov2659->client = client; + +- clk = devm_clk_get(&client->dev, "xvclk"); +- if (IS_ERR(clk)) +- return PTR_ERR(clk); ++ ov2659->clk = devm_clk_get(&client->dev, "xvclk"); ++ if (IS_ERR(ov2659->clk)) ++ return PTR_ERR(ov2659->clk); + +- ov2659->xvclk_frequency = clk_get_rate(clk); ++ ov2659->xvclk_frequency = clk_get_rate(ov2659->clk); + if (ov2659->xvclk_frequency < 6000000 || + ov2659->xvclk_frequency > 27000000) + return -EINVAL; +@@ -1506,7 +1516,9 @@ static int ov2659_probe(struct i2c_client *client) + ov2659->frame_size = &ov2659_framesizes[2]; + ov2659->format_ctrl_regs = ov2659_formats[0].format_ctrl_regs; + +- ov2659_power_on(&client->dev); ++ ret = ov2659_power_on(&client->dev); ++ if (ret < 0) ++ goto error; + + ret = ov2659_detect(sd); + if (ret < 0) +-- +2.30.2 + diff --git a/queue-5.10/media-imx-csi-skip-first-few-frames-from-a-bt.656-so.patch b/queue-5.10/media-imx-csi-skip-first-few-frames-from-a-bt.656-so.patch new file mode 100644 index 00000000000..9d7db1aa32f --- /dev/null +++ b/queue-5.10/media-imx-csi-skip-first-few-frames-from-a-bt.656-so.patch @@ -0,0 +1,63 @@ +From 9097c73c41e543e2b5459fedd6a6fc0412b5de4c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 17 May 2021 16:29:23 +0200 +Subject: media: imx-csi: Skip first few frames from a BT.656 source + +From: Steve Longerbeam + +[ Upstream commit e198be37e52551bb863d07d2edc535d0932a3c4f ] + +Some BT.656 sensors (e.g. ADV718x) transmit frames with unstable BT.656 +sync codes after initial power on. This confuses the imx CSI,resulting +in vertical and/or horizontal sync issues. Skip the first 20 frames +to avoid the unstable sync codes. + +[fabio: fixed checkpatch warning and increased the frame skipping to 20] + +Signed-off-by: Steve Longerbeam +Signed-off-by: Fabio Estevam +Reviewed-by: Tim Harvey +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/imx/imx-media-csi.c | 14 +++++++++++++- + 1 file changed, 13 insertions(+), 1 deletion(-) + +diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c +index 21ebf7769696..899d29f4c91a 100644 +--- a/drivers/staging/media/imx/imx-media-csi.c ++++ b/drivers/staging/media/imx/imx-media-csi.c +@@ -753,9 +753,10 @@ static int csi_setup(struct csi_priv *priv) + + static int csi_start(struct csi_priv *priv) + { +- struct v4l2_fract *output_fi; ++ struct v4l2_fract *input_fi, *output_fi; + int ret; + ++ input_fi = &priv->frame_interval[CSI_SINK_PAD]; + output_fi = &priv->frame_interval[priv->active_output_pad]; + + /* start upstream */ +@@ -764,6 +765,17 @@ static int csi_start(struct csi_priv *priv) + if (ret) + return ret; + ++ /* Skip first few frames from a BT.656 source */ ++ if (priv->upstream_ep.bus_type == V4L2_MBUS_BT656) { ++ u32 delay_usec, bad_frames = 20; ++ ++ delay_usec = DIV_ROUND_UP_ULL((u64)USEC_PER_SEC * ++ input_fi->numerator * bad_frames, ++ input_fi->denominator); ++ ++ usleep_range(delay_usec, delay_usec + 1000); ++ } ++ + if (priv->dest == IPU_CSI_DEST_IDMAC) { + ret = csi_idmac_start(priv); + if (ret) +-- +2.30.2 + diff --git a/queue-5.10/media-imx-imx7_mipi_csis-fix-logging-of-only-error-e.patch b/queue-5.10/media-imx-imx7_mipi_csis-fix-logging-of-only-error-e.patch new file mode 100644 index 00000000000..508fc8ae1f6 --- /dev/null +++ b/queue-5.10/media-imx-imx7_mipi_csis-fix-logging-of-only-error-e.patch @@ -0,0 +1,48 @@ +From 44f4317feb4f0a7b5d0961a83facd35616ec554f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 13 Apr 2021 04:29:52 +0200 +Subject: media: imx: imx7_mipi_csis: Fix logging of only error event counters + +From: Laurent Pinchart + +[ Upstream commit d2fcc9c2de1191ea80366e3658711753738dd10a ] + +The mipi_csis_events array ends with 6 non-error events, not 4. Update +mipi_csis_log_counters() accordingly. While at it, log event counters in +forward order, as there's no reason to log them backward. + +Signed-off-by: Laurent Pinchart +Acked-by: Rui Miguel Silva +Reviewed-by: Frieder Schrempf +Tested-by: Frieder Schrempf +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c +index 7612993cc1d6..c5a548976f1d 100644 +--- a/drivers/staging/media/imx/imx7-mipi-csis.c ++++ b/drivers/staging/media/imx/imx7-mipi-csis.c +@@ -597,13 +597,15 @@ static void mipi_csis_clear_counters(struct csi_state *state) + + static void mipi_csis_log_counters(struct csi_state *state, bool non_errors) + { +- int i = non_errors ? MIPI_CSIS_NUM_EVENTS : MIPI_CSIS_NUM_EVENTS - 4; ++ unsigned int num_events = non_errors ? MIPI_CSIS_NUM_EVENTS ++ : MIPI_CSIS_NUM_EVENTS - 6; + struct device *dev = &state->pdev->dev; + unsigned long flags; ++ unsigned int i; + + spin_lock_irqsave(&state->slock, flags); + +- for (i--; i >= 0; i--) { ++ for (i = 0; i < num_events; ++i) { + if (state->events[i].counter > 0 || state->debug) + dev_info(dev, "%s events: %d\n", state->events[i].name, + state->events[i].counter); +-- +2.30.2 + diff --git a/queue-5.10/media-marvel-ccic-fix-some-issues-when-getting-pm_ru.patch b/queue-5.10/media-marvel-ccic-fix-some-issues-when-getting-pm_ru.patch new file mode 100644 index 00000000000..3186a5f7615 --- /dev/null +++ b/queue-5.10/media-marvel-ccic-fix-some-issues-when-getting-pm_ru.patch @@ -0,0 +1,60 @@ +From 0459025ba84e06d5484c2a63afd7e3bf424f1994 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 16:54:25 +0200 +Subject: media: marvel-ccic: fix some issues when getting pm_runtime + +From: Mauro Carvalho Chehab + +[ Upstream commit e7c617cab7a522fba5b20f9033ee98565b6f3546 ] + +Calling pm_runtime_get_sync() is bad, since even when it +returns an error, pm_runtime_put*() should be called. +So, use instead pm_runtime_resume_and_get(). + +While here, ensure that the error condition will be checked +during clock enable an media open() calls. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/marvell-ccic/mcam-core.c | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c +index 34266fba824f..e56c5e56e824 100644 +--- a/drivers/media/platform/marvell-ccic/mcam-core.c ++++ b/drivers/media/platform/marvell-ccic/mcam-core.c +@@ -918,6 +918,7 @@ static int mclk_enable(struct clk_hw *hw) + struct mcam_camera *cam = container_of(hw, struct mcam_camera, mclk_hw); + int mclk_src; + int mclk_div; ++ int ret; + + /* + * Clock the sensor appropriately. Controller clock should +@@ -931,7 +932,9 @@ static int mclk_enable(struct clk_hw *hw) + mclk_div = 2; + } + +- pm_runtime_get_sync(cam->dev); ++ ret = pm_runtime_resume_and_get(cam->dev); ++ if (ret < 0) ++ return ret; + clk_enable(cam->clk[0]); + mcam_reg_write(cam, REG_CLKCTRL, (mclk_src << 29) | mclk_div); + mcam_ctlr_power_up(cam); +@@ -1611,7 +1614,9 @@ static int mcam_v4l_open(struct file *filp) + ret = sensor_call(cam, core, s_power, 1); + if (ret) + goto out; +- pm_runtime_get_sync(cam->dev); ++ ret = pm_runtime_resume_and_get(cam->dev); ++ if (ret < 0) ++ goto out; + __mcam_cam_reset(cam); + mcam_set_config_needed(cam, 1); + } +-- +2.30.2 + diff --git a/queue-5.10/media-mdk-mdp-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-mdk-mdp-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..c1366814274 --- /dev/null +++ b/queue-5.10/media-mdk-mdp-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,50 @@ +From 449f2b4f79f49b701bcde8a3312038d6ec7512e9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 16:57:16 +0200 +Subject: media: mdk-mdp: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit d07bb9702cf5f5ccf3fb661e6cab54bbc33cd23f ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +While here, fix the return contition of mtk_mdp_m2m_start_streaming(), +as it doesn't make any sense to return 0 if the PM runtime failed +to resume. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c +index 724c7333b6e5..45fc741c5541 100644 +--- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c ++++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c +@@ -394,12 +394,12 @@ static int mtk_mdp_m2m_start_streaming(struct vb2_queue *q, unsigned int count) + struct mtk_mdp_ctx *ctx = q->drv_priv; + int ret; + +- ret = pm_runtime_get_sync(&ctx->mdp_dev->pdev->dev); ++ ret = pm_runtime_resume_and_get(&ctx->mdp_dev->pdev->dev); + if (ret < 0) +- mtk_mdp_dbg(1, "[%d] pm_runtime_get_sync failed:%d", ++ mtk_mdp_dbg(1, "[%d] pm_runtime_resume_and_get failed:%d", + ctx->id, ret); + +- return 0; ++ return ret; + } + + static void *mtk_mdp_m2m_buf_remove(struct mtk_mdp_ctx *ctx, +-- +2.30.2 + diff --git a/queue-5.10/media-mtk-vcodec-fix-pm-runtime-get-logic.patch b/queue-5.10/media-mtk-vcodec-fix-pm-runtime-get-logic.patch new file mode 100644 index 00000000000..7047e2e360f --- /dev/null +++ b/queue-5.10/media-mtk-vcodec-fix-pm-runtime-get-logic.patch @@ -0,0 +1,86 @@ +From 30e4936cb61da16981b41316370672f1984befcc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:09 +0200 +Subject: media: mtk-vcodec: fix PM runtime get logic + +From: Mauro Carvalho Chehab + +[ Upstream commit 908711f542c17fe61e5d653da1beb8e5ab5c7b50 ] + +Currently, the driver just assumes that PM runtime logic +succeded resuming the device. + +That may not be the case, as pm_runtime_get_sync() +can fail (but keeping the usage count incremented). + +Replace the code to use pm_runtime_resume_and_get(), +and letting it return the error code. + +This way, if mtk_vcodec_dec_pw_on() fails, the logic +under fops_vcodec_open() will do the right thing and +return an error, instead of just assuming that the +device is ready to be used. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +++- + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 8 +++++--- + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 2 +- + 3 files changed, 9 insertions(+), 5 deletions(-) + +diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c +index 145686d2c219..f59ef8c8c9db 100644 +--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c ++++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c +@@ -126,7 +126,9 @@ static int fops_vcodec_open(struct file *file) + mtk_vcodec_dec_set_default_params(ctx); + + if (v4l2_fh_is_singular(&ctx->fh)) { +- mtk_vcodec_dec_pw_on(&dev->pm); ++ ret = mtk_vcodec_dec_pw_on(&dev->pm); ++ if (ret < 0) ++ goto err_load_fw; + /* + * Does nothing if firmware was already loaded. + */ +diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c +index ddee7046ce42..6038db96f71c 100644 +--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c ++++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c +@@ -88,13 +88,15 @@ void mtk_vcodec_release_dec_pm(struct mtk_vcodec_dev *dev) + put_device(dev->pm.larbvdec); + } + +-void mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) ++int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) + { + int ret; + +- ret = pm_runtime_get_sync(pm->dev); ++ ret = pm_runtime_resume_and_get(pm->dev); + if (ret) +- mtk_v4l2_err("pm_runtime_get_sync fail %d", ret); ++ mtk_v4l2_err("pm_runtime_resume_and_get fail %d", ret); ++ ++ return ret; + } + + void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm) +diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h +index 872d8bf8cfaf..280aeaefdb65 100644 +--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h ++++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h +@@ -12,7 +12,7 @@ + int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *dev); + void mtk_vcodec_release_dec_pm(struct mtk_vcodec_dev *dev); + +-void mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm); ++int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm); + void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm); + void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm); + void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm); +-- +2.30.2 + diff --git a/queue-5.10/media-pvrusb2-fix-warning-in-pvr2_i2c_core_done.patch b/queue-5.10/media-pvrusb2-fix-warning-in-pvr2_i2c_core_done.patch new file mode 100644 index 00000000000..680c2f2f2ba --- /dev/null +++ b/queue-5.10/media-pvrusb2-fix-warning-in-pvr2_i2c_core_done.patch @@ -0,0 +1,60 @@ +From d0d18380d34b30837ca0ea0af903ad19632ae9cb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 19:08:58 +0200 +Subject: media: pvrusb2: fix warning in pvr2_i2c_core_done + +From: Anirudh Rayabharam + +[ Upstream commit f8194e5e63fdcb349e8da9eef9e574d5b1d687cb ] + +syzbot has reported the following warning in pvr2_i2c_done: + + sysfs group 'power' not found for kobject '1-0043' + +When the device is disconnected (pvr_hdw_disconnect), the i2c adapter is +not unregistered along with the USB and v4l2 teardown. As part of the USB +device disconnect, the sysfs files of the subdevices are also deleted. +So, by the time pvr_i2c_core_done is called by pvr_context_destroy, the +sysfs files have been deleted. + +To fix this, unregister the i2c adapter too in pvr_hdw_disconnect. Make +the device deregistration code shared by calling pvr_hdw_disconnect from +pvr2_hdw_destroy. + +Reported-by: syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com +Tested-by: syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com +Reviewed-by: Greg Kroah-Hartman +Signed-off-by: Anirudh Rayabharam +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +index f4a727918e35..d38dee1792e4 100644 +--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c ++++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +@@ -2676,9 +2676,8 @@ void pvr2_hdw_destroy(struct pvr2_hdw *hdw) + pvr2_stream_destroy(hdw->vid_stream); + hdw->vid_stream = NULL; + } +- pvr2_i2c_core_done(hdw); + v4l2_device_unregister(&hdw->v4l2_dev); +- pvr2_hdw_remove_usb_stuff(hdw); ++ pvr2_hdw_disconnect(hdw); + mutex_lock(&pvr2_unit_mtx); + do { + if ((hdw->unit_number >= 0) && +@@ -2705,6 +2704,7 @@ void pvr2_hdw_disconnect(struct pvr2_hdw *hdw) + { + pvr2_trace(PVR2_TRACE_INIT,"pvr2_hdw_disconnect(hdw=%p)",hdw); + LOCK_TAKE(hdw->big_lock); ++ pvr2_i2c_core_done(hdw); + LOCK_TAKE(hdw->ctl_lock); + pvr2_hdw_remove_usb_stuff(hdw); + LOCK_GIVE(hdw->ctl_lock); +-- +2.30.2 + diff --git a/queue-5.10/media-rc-i2c-fix-an-error-message.patch b/queue-5.10/media-rc-i2c-fix-an-error-message.patch new file mode 100644 index 00000000000..9a5acf9d862 --- /dev/null +++ b/queue-5.10/media-rc-i2c-fix-an-error-message.patch @@ -0,0 +1,40 @@ +From fb1abce1e47692c426fbbea05e06eb2fa3cd66eb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 6 May 2021 07:38:56 +0200 +Subject: media: rc: i2c: Fix an error message + +From: Christophe JAILLET + +[ Upstream commit 9c87ae1a0dbeb5794957421157fd266d38a869b4 ] + +'ret' is known to be 1 here. In fact 'i' is expected instead. +Store the return value of 'i2c_master_recv()' in 'ret' so that the error +message print the correct error code. + +Fixes: acaa34bf06e9 ("media: rc: implement zilog transmitter") +Signed-off-by: Christophe JAILLET +Signed-off-by: Sean Young +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/i2c/ir-kbd-i2c.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c +index e8119ad0bc71..92376592455e 100644 +--- a/drivers/media/i2c/ir-kbd-i2c.c ++++ b/drivers/media/i2c/ir-kbd-i2c.c +@@ -678,8 +678,8 @@ static int zilog_tx(struct rc_dev *rcdev, unsigned int *txbuf, + goto out_unlock; + } + +- i = i2c_master_recv(ir->tx_c, buf, 1); +- if (i != 1) { ++ ret = i2c_master_recv(ir->tx_c, buf, 1); ++ if (ret != 1) { + dev_err(&ir->rc->dev, "i2c_master_recv failed with %d\n", ret); + ret = -EIO; + goto out_unlock; +-- +2.30.2 + diff --git a/queue-5.10/media-rkvdec-fix-.buf_prepare.patch b/queue-5.10/media-rkvdec-fix-.buf_prepare.patch new file mode 100644 index 00000000000..a5919a236eb --- /dev/null +++ b/queue-5.10/media-rkvdec-fix-.buf_prepare.patch @@ -0,0 +1,54 @@ +From dc545ae123d0369690794e2a137b4c086aac8167 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 5 May 2021 14:23:45 +0200 +Subject: media: rkvdec: Fix .buf_prepare + +From: Ezequiel Garcia + +[ Upstream commit ba1ed4ae760a81caf39f54232e089d95157a0dba ] + +The driver should only set the payload on .buf_prepare if the +buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused +set by userspace then v4l2-core will set it to buffer length. + +If we overwrite bytesused for OUTPUT buffers, too, then +vb2_get_plane_payload() will return incorrect value which might be then +written to hw registers by the driver in rkvdec-h264.c. + +[Changed the comment and used V4L2_TYPE_IS_CAPTURE macro] + +Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver") +Signed-off-by: Ezequiel Garcia +Signed-off-by: Adrian Ratiu +Signed-off-by: Andrzej Pietrasiewicz +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/rkvdec/rkvdec.c | 10 +++++++++- + 1 file changed, 9 insertions(+), 1 deletion(-) + +diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c +index b630e161d4ce..e68303e2b390 100644 +--- a/drivers/staging/media/rkvdec/rkvdec.c ++++ b/drivers/staging/media/rkvdec/rkvdec.c +@@ -471,7 +471,15 @@ static int rkvdec_buf_prepare(struct vb2_buffer *vb) + if (vb2_plane_size(vb, i) < sizeimage) + return -EINVAL; + } +- vb2_set_plane_payload(vb, 0, f->fmt.pix_mp.plane_fmt[0].sizeimage); ++ ++ /* ++ * Buffer's bytesused must be written by driver for CAPTURE buffers. ++ * (for OUTPUT buffers, if userspace passes 0 bytesused, v4l2-core sets ++ * it to buffer length). ++ */ ++ if (V4L2_TYPE_IS_CAPTURE(vq->type)) ++ vb2_set_plane_payload(vb, 0, f->fmt.pix_mp.plane_fmt[0].sizeimage); ++ + return 0; + } + +-- +2.30.2 + diff --git a/queue-5.10/media-s5p-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-s5p-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..2e295383a4d --- /dev/null +++ b/queue-5.10/media-s5p-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,50 @@ +From d37f9572fe820f1390655fe65f6e71ee30d7fb20 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:04:23 +0200 +Subject: media: s5p: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit fdc34e82c0f968ac4c157bd3d8c299ebc24c9c63 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +While here, check if the PM runtime error was caught at +s5p_cec_adap_enable(). + +Reviewed-by: Jonathan Cameron +Reviewed-by: Sylwester Nawrocki +Acked-by: Marek Szyprowski +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/cec/platform/s5p/s5p_cec.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c +index 2a3e7ffefe0a..2250c1cbc64e 100644 +--- a/drivers/media/cec/platform/s5p/s5p_cec.c ++++ b/drivers/media/cec/platform/s5p/s5p_cec.c +@@ -35,10 +35,13 @@ MODULE_PARM_DESC(debug, "debug level (0-2)"); + + static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) + { ++ int ret; + struct s5p_cec_dev *cec = cec_get_drvdata(adap); + + if (enable) { +- pm_runtime_get_sync(cec->dev); ++ ret = pm_runtime_resume_and_get(cec->dev); ++ if (ret < 0) ++ return ret; + + s5p_cec_reset(cec); + +-- +2.30.2 + diff --git a/queue-5.10/media-s5p-g2d-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch b/queue-5.10/media-s5p-g2d-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch new file mode 100644 index 00000000000..fbbd81a79e5 --- /dev/null +++ b/queue-5.10/media-s5p-g2d-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch @@ -0,0 +1,40 @@ +From f7049d42ab25243c5361252194ae1cb6ed1308a6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 17:18:32 +0200 +Subject: media: s5p-g2d: Fix a memory leak on ctx->fh.m2m_ctx + +From: Dillon Min + +[ Upstream commit 5d11e6aad1811ea293ee2996cec9124f7fccb661 ] + +The m2m_ctx resources was allocated by v4l2_m2m_ctx_init() in g2d_open() +should be freed from g2d_release() when it's not used. + +Fix it + +Fixes: 918847341af0 ("[media] v4l: add G2D driver for s5p device family") +Signed-off-by: Dillon Min +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/s5p-g2d/g2d.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c +index 15bcb7f6e113..1cb5eaabf340 100644 +--- a/drivers/media/platform/s5p-g2d/g2d.c ++++ b/drivers/media/platform/s5p-g2d/g2d.c +@@ -276,6 +276,9 @@ static int g2d_release(struct file *file) + struct g2d_dev *dev = video_drvdata(file); + struct g2d_ctx *ctx = fh2ctx(file->private_data); + ++ mutex_lock(&dev->mutex); ++ v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); ++ mutex_unlock(&dev->mutex); + v4l2_ctrl_handler_free(&ctx->ctrl_handler); + v4l2_fh_del(&ctx->fh); + v4l2_fh_exit(&ctx->fh); +-- +2.30.2 + diff --git a/queue-5.10/media-s5p-jpeg-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-s5p-jpeg-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..be3c4aacb83 --- /dev/null +++ b/queue-5.10/media-s5p-jpeg-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,49 @@ +From 9c7a6e57556ae446fc085f5fed3f71ad0f1ab0c0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:10 +0200 +Subject: media: s5p-jpeg: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit 10343de268d10cf07b092b8b525e12ad558ead77 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +As a plus, pm_runtime_resume_and_get() doesn't return +positive numbers, so the return code validation can +be removed. + +Reviewed-by: Jonathan Cameron +Reviewed-by: Sylwester Nawrocki +Acked-by: Andrzej Pietrasiewicz +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +---- + 1 file changed, 1 insertion(+), 4 deletions(-) + +diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c +index 9b22dd8e34f4..d515eb08c3ee 100644 +--- a/drivers/media/platform/s5p-jpeg/jpeg-core.c ++++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c +@@ -2566,11 +2566,8 @@ static void s5p_jpeg_buf_queue(struct vb2_buffer *vb) + static int s5p_jpeg_start_streaming(struct vb2_queue *q, unsigned int count) + { + struct s5p_jpeg_ctx *ctx = vb2_get_drv_priv(q); +- int ret; +- +- ret = pm_runtime_get_sync(ctx->jpeg->dev); + +- return ret > 0 ? 0 : ret; ++ return pm_runtime_resume_and_get(ctx->jpeg->dev); + } + + static void s5p_jpeg_stop_streaming(struct vb2_queue *q) +-- +2.30.2 + diff --git a/queue-5.10/media-s5p_cec-decrement-usage-count-if-disabled.patch b/queue-5.10/media-s5p_cec-decrement-usage-count-if-disabled.patch new file mode 100644 index 00000000000..850cf9b7e17 --- /dev/null +++ b/queue-5.10/media-s5p_cec-decrement-usage-count-if-disabled.patch @@ -0,0 +1,39 @@ +From cbddff79a1179a405d6a5fbc677983de0829eae6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Apr 2021 09:38:56 +0200 +Subject: media: s5p_cec: decrement usage count if disabled + +From: Mauro Carvalho Chehab + +[ Upstream commit 747bad54a677d8633ec14b39dfbeb859c821d7f2 ] + +There's a bug at s5p_cec_adap_enable(): if called to +disable the device, it should call pm_runtime_put() +instead of pm_runtime_disable(), as the goal here is to +decrement the usage_count and not to disable PM runtime. + +Reported-by: Sylwester Nawrocki +Reviewed-by: Jonathan Cameron +Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver") +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/cec/platform/s5p/s5p_cec.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c +index 2250c1cbc64e..028a09a7531e 100644 +--- a/drivers/media/cec/platform/s5p/s5p_cec.c ++++ b/drivers/media/cec/platform/s5p/s5p_cec.c +@@ -54,7 +54,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) + } else { + s5p_cec_mask_tx_interrupts(cec); + s5p_cec_mask_rx_interrupts(cec); +- pm_runtime_disable(cec->dev); ++ pm_runtime_put(cec->dev); + } + + return 0; +-- +2.30.2 + diff --git a/queue-5.10/media-sh_vou-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-sh_vou-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..71f814e87a9 --- /dev/null +++ b/queue-5.10/media-sh_vou-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,45 @@ +From 72832302cf8f7fb8faf9b3ae86a056e72adc01df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:07:41 +0200 +Subject: media: sh_vou: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit 6e8b1526db164c9d4b9dacfb9bc48e365d7c4860 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +While here, check if the PM runtime error was caught at open time. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/sh_vou.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c +index b22dc1d72527..7d30e0c9447e 100644 +--- a/drivers/media/platform/sh_vou.c ++++ b/drivers/media/platform/sh_vou.c +@@ -1133,7 +1133,11 @@ static int sh_vou_open(struct file *file) + if (v4l2_fh_is_singular_file(file) && + vou_dev->status == SH_VOU_INITIALISING) { + /* First open */ +- pm_runtime_get_sync(vou_dev->v4l2_dev.dev); ++ err = pm_runtime_resume_and_get(vou_dev->v4l2_dev.dev); ++ if (err < 0) { ++ v4l2_fh_release(file); ++ goto done_open; ++ } + err = sh_vou_hw_init(vou_dev); + if (err < 0) { + pm_runtime_put(vou_dev->v4l2_dev.dev); +-- +2.30.2 + diff --git a/queue-5.10/media-siano-fix-device-register-error-path.patch b/queue-5.10/media-siano-fix-device-register-error-path.patch new file mode 100644 index 00000000000..2bf5ed08152 --- /dev/null +++ b/queue-5.10/media-siano-fix-device-register-error-path.patch @@ -0,0 +1,39 @@ +From 06d19e05c56542f8a653873a3aca1966a5b15278 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 08:57:02 +0200 +Subject: media: siano: fix device register error path + +From: Mauro Carvalho Chehab + +[ Upstream commit 5368b1ee2939961a16e74972b69088433fc52195 ] + +As reported by smatch: + drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: '&client->entry' not removed from list + +If an error occur at the end of the registration logic, it won't +drop the device from the list. + +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/common/siano/smsdvb-main.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c +index ae17407e477a..7cc654bc52d3 100644 +--- a/drivers/media/common/siano/smsdvb-main.c ++++ b/drivers/media/common/siano/smsdvb-main.c +@@ -1176,6 +1176,10 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev, + return 0; + + media_graph_error: ++ mutex_lock(&g_smsdvb_clientslock); ++ list_del(&client->entry); ++ mutex_unlock(&g_smsdvb_clientslock); ++ + smsdvb_debugfs_release(client); + + client_error: +-- +2.30.2 + diff --git a/queue-5.10/media-siano-fix-out-of-bounds-warnings-in-smscore_lo.patch b/queue-5.10/media-siano-fix-out-of-bounds-warnings-in-smscore_lo.patch new file mode 100644 index 00000000000..5f60ccfc6a1 --- /dev/null +++ b/queue-5.10/media-siano-fix-out-of-bounds-warnings-in-smscore_lo.patch @@ -0,0 +1,167 @@ +From 1c81c69b140718a0eba9f6dda5bbe0412052afcd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Mar 2021 19:40:43 -0600 +Subject: media: siano: Fix out-of-bounds warnings in + smscore_load_firmware_family2() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Gustavo A. R. Silva + +[ Upstream commit 13dfead49db07225335d4f587a560a2210391a1a ] + +Rename struct sms_msg_data4 to sms_msg_data5 and increase the size of +its msg_data array from 4 to 5 elements. Notice that at some point +the 5th element of msg_data is being accessed in function +smscore_load_firmware_family2(): + +1006 trigger_msg->msg_data[4] = 4; /* Task ID */ + +Also, there is no need for the object _trigger_msg_ of type struct +sms_msg_data *, when _msg_ can be used, directly. Notice that msg_data +in struct sms_msg_data is a one-element array, which causes multiple +out-of-bounds warnings when accessing beyond its first element +in function smscore_load_firmware_family2(): + + 992 struct sms_msg_data *trigger_msg = + 993 (struct sms_msg_data *) msg; + 994 + 995 pr_debug("sending MSG_SMS_SWDOWNLOAD_TRIGGER_REQ\n"); + 996 SMS_INIT_MSG(&msg->x_msg_header, + 997 MSG_SMS_SWDOWNLOAD_TRIGGER_REQ, + 998 sizeof(struct sms_msg_hdr) + + 999 sizeof(u32) * 5); +1000 +1001 trigger_msg->msg_data[0] = firmware->start_address; +1002 /* Entry point */ +1003 trigger_msg->msg_data[1] = 6; /* Priority */ +1004 trigger_msg->msg_data[2] = 0x200; /* Stack size */ +1005 trigger_msg->msg_data[3] = 0; /* Parameter */ +1006 trigger_msg->msg_data[4] = 4; /* Task ID */ + +even when enough dynamic memory is allocated for _msg_: + + 929 /* PAGE_SIZE buffer shall be enough and dma aligned */ + 930 msg = kmalloc(PAGE_SIZE, GFP_KERNEL | coredev->gfp_buf_flags); + +but as _msg_ is casted to (struct sms_msg_data *): + + 992 struct sms_msg_data *trigger_msg = + 993 (struct sms_msg_data *) msg; + +the out-of-bounds warnings are actually valid and should be addressed. + +Fix this by declaring object _msg_ of type struct sms_msg_data5 *, +which contains a 5-elements array, instead of just 4. And use +_msg_ directly, instead of creating object trigger_msg. + +This helps with the ongoing efforts to enable -Warray-bounds by fixing +the following warnings: + + CC [M] drivers/media/common/siano/smscoreapi.o +drivers/media/common/siano/smscoreapi.c: In function ‘smscore_load_firmware_family2’: +drivers/media/common/siano/smscoreapi.c:1003:24: warning: array subscript 1 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] + 1003 | trigger_msg->msg_data[1] = 6; /* Priority */ + | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from drivers/media/common/siano/smscoreapi.c:12: +drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ + 619 | u32 msg_data[1]; + | ^~~~~~~~ +drivers/media/common/siano/smscoreapi.c:1004:24: warning: array subscript 2 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] + 1004 | trigger_msg->msg_data[2] = 0x200; /* Stack size */ + | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from drivers/media/common/siano/smscoreapi.c:12: +drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ + 619 | u32 msg_data[1]; + | ^~~~~~~~ +drivers/media/common/siano/smscoreapi.c:1005:24: warning: array subscript 3 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] + 1005 | trigger_msg->msg_data[3] = 0; /* Parameter */ + | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from drivers/media/common/siano/smscoreapi.c:12: +drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ + 619 | u32 msg_data[1]; + | ^~~~~~~~ +drivers/media/common/siano/smscoreapi.c:1006:24: warning: array subscript 4 is above array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Warray-bounds] + 1006 | trigger_msg->msg_data[4] = 4; /* Task ID */ + | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from drivers/media/common/siano/smscoreapi.c:12: +drivers/media/common/siano/smscoreapi.h:619:6: note: while referencing ‘msg_data’ + 619 | u32 msg_data[1]; + | ^~~~~~~~ + +Fixes: 018b0c6f8acb ("[media] siano: make load firmware logic to work with newer firmwares") +Co-developed-by: Kees Cook +Signed-off-by: Kees Cook +Signed-off-by: Gustavo A. R. Silva +Signed-off-by: Sasha Levin +--- + drivers/media/common/siano/smscoreapi.c | 22 +++++++++------------- + drivers/media/common/siano/smscoreapi.h | 4 ++-- + 2 files changed, 11 insertions(+), 15 deletions(-) + +diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c +index c1511094fdc7..b735e2370137 100644 +--- a/drivers/media/common/siano/smscoreapi.c ++++ b/drivers/media/common/siano/smscoreapi.c +@@ -908,7 +908,7 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev, + void *buffer, size_t size) + { + struct sms_firmware *firmware = (struct sms_firmware *) buffer; +- struct sms_msg_data4 *msg; ++ struct sms_msg_data5 *msg; + u32 mem_address, calc_checksum = 0; + u32 i, *ptr; + u8 *payload = firmware->payload; +@@ -989,24 +989,20 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev, + goto exit_fw_download; + + if (coredev->mode == DEVICE_MODE_NONE) { +- struct sms_msg_data *trigger_msg = +- (struct sms_msg_data *) msg; +- + pr_debug("sending MSG_SMS_SWDOWNLOAD_TRIGGER_REQ\n"); + SMS_INIT_MSG(&msg->x_msg_header, + MSG_SMS_SWDOWNLOAD_TRIGGER_REQ, +- sizeof(struct sms_msg_hdr) + +- sizeof(u32) * 5); ++ sizeof(*msg)); + +- trigger_msg->msg_data[0] = firmware->start_address; ++ msg->msg_data[0] = firmware->start_address; + /* Entry point */ +- trigger_msg->msg_data[1] = 6; /* Priority */ +- trigger_msg->msg_data[2] = 0x200; /* Stack size */ +- trigger_msg->msg_data[3] = 0; /* Parameter */ +- trigger_msg->msg_data[4] = 4; /* Task ID */ ++ msg->msg_data[1] = 6; /* Priority */ ++ msg->msg_data[2] = 0x200; /* Stack size */ ++ msg->msg_data[3] = 0; /* Parameter */ ++ msg->msg_data[4] = 4; /* Task ID */ + +- rc = smscore_sendrequest_and_wait(coredev, trigger_msg, +- trigger_msg->x_msg_header.msg_length, ++ rc = smscore_sendrequest_and_wait(coredev, msg, ++ msg->x_msg_header.msg_length, + &coredev->trigger_done); + } else { + SMS_INIT_MSG(&msg->x_msg_header, MSG_SW_RELOAD_EXEC_REQ, +diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h +index b3b793b5caf3..16c45afabc53 100644 +--- a/drivers/media/common/siano/smscoreapi.h ++++ b/drivers/media/common/siano/smscoreapi.h +@@ -629,9 +629,9 @@ struct sms_msg_data2 { + u32 msg_data[2]; + }; + +-struct sms_msg_data4 { ++struct sms_msg_data5 { + struct sms_msg_hdr x_msg_header; +- u32 msg_data[4]; ++ u32 msg_data[5]; + }; + + struct sms_data_download { +-- +2.30.2 + diff --git a/queue-5.10/media-st-hva-fix-potential-null-pointer-dereferences.patch b/queue-5.10/media-st-hva-fix-potential-null-pointer-dereferences.patch new file mode 100644 index 00000000000..af45836dbfb --- /dev/null +++ b/queue-5.10/media-st-hva-fix-potential-null-pointer-dereferences.patch @@ -0,0 +1,40 @@ +From 18dbe01419f80301875ee337b2540eb7cdd5ccaf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 19 May 2021 14:04:49 +0200 +Subject: media: st-hva: Fix potential NULL pointer dereferences + +From: Evgeny Novikov + +[ Upstream commit b7fdd208687ba59ebfb09b2199596471c63b69e3 ] + +When ctx_id >= HVA_MAX_INSTANCES in hva_hw_its_irq_thread() it tries to +access fields of ctx that is NULL at that point. The patch gets rid of +these accesses. + +Found by Linux Driver Verification project (linuxtesting.org). + +Signed-off-by: Evgeny Novikov +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/sti/hva/hva-hw.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c +index 43f279e2a6a3..cf4c891bf619 100644 +--- a/drivers/media/platform/sti/hva/hva-hw.c ++++ b/drivers/media/platform/sti/hva/hva-hw.c +@@ -130,8 +130,7 @@ static irqreturn_t hva_hw_its_irq_thread(int irq, void *arg) + ctx_id = (hva->sts_reg & 0xFF00) >> 8; + if (ctx_id >= HVA_MAX_INSTANCES) { + dev_err(dev, "%s %s: bad context identifier: %d\n", +- ctx->name, __func__, ctx_id); +- ctx->hw_err = true; ++ HVA_PREFIX, __func__, ctx_id); + goto out; + } + +-- +2.30.2 + diff --git a/queue-5.10/media-sti-bdisp-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-sti-bdisp-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..4eb83491e27 --- /dev/null +++ b/queue-5.10/media-sti-bdisp-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,67 @@ +From d3c1b65dac79881332f281907e8ddfc41da7ec39 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:21 +0200 +Subject: media: sti/bdisp: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit c44eac5b72e23c31eefc0e10a71d9650036b8341 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. + +The bdisp_start_streaming() doesn't take it into account, which +would unbalance PM usage counter at bdisp_stop_streaming(). + +The logic at bdisp_probe() is correct, but the best is to use +the same call along the driver. + +So, replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 7 ++++--- + 1 file changed, 4 insertions(+), 3 deletions(-) + +diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +index 060ca85f64d5..85288da9d2ae 100644 +--- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c ++++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +@@ -499,7 +499,7 @@ static int bdisp_start_streaming(struct vb2_queue *q, unsigned int count) + { + struct bdisp_ctx *ctx = q->drv_priv; + struct vb2_v4l2_buffer *buf; +- int ret = pm_runtime_get_sync(ctx->bdisp_dev->dev); ++ int ret = pm_runtime_resume_and_get(ctx->bdisp_dev->dev); + + if (ret < 0) { + dev_err(ctx->bdisp_dev->dev, "failed to set runtime PM\n"); +@@ -1364,10 +1364,10 @@ static int bdisp_probe(struct platform_device *pdev) + + /* Power management */ + pm_runtime_enable(dev); +- ret = pm_runtime_get_sync(dev); ++ ret = pm_runtime_resume_and_get(dev); + if (ret < 0) { + dev_err(dev, "failed to set PM\n"); +- goto err_pm; ++ goto err_remove; + } + + /* Filters */ +@@ -1395,6 +1395,7 @@ err_filter: + bdisp_hw_free_filters(bdisp->dev); + err_pm: + pm_runtime_put(dev); ++err_remove: + bdisp_debugfs_remove(bdisp); + v4l2_device_unregister(&bdisp->v4l2_dev); + err_clk: +-- +2.30.2 + diff --git a/queue-5.10/media-sti-fix-obj-config-targets.patch b/queue-5.10/media-sti-fix-obj-config-targets.patch new file mode 100644 index 00000000000..2c10c9e5dd7 --- /dev/null +++ b/queue-5.10/media-sti-fix-obj-config-targets.patch @@ -0,0 +1,58 @@ +From b0ce28207503778dd24627c21ead1335eb17b3a1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 11:26:31 +0200 +Subject: media: sti: fix obj-$(config) targets + +From: Mauro Carvalho Chehab + +[ Upstream commit 56c1f0876293888f686e31278d183d4af2cac3c3 ] + +The right thing to do is to add a new object to the building +system when a certain config option is selected, and *not* +override them. + +So, fix obj-$(config) logic at sti makefiles, using "+=", +instead of ":=". + +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/sti/bdisp/Makefile | 2 +- + drivers/media/platform/sti/delta/Makefile | 2 +- + drivers/media/platform/sti/hva/Makefile | 2 +- + 3 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/media/platform/sti/bdisp/Makefile b/drivers/media/platform/sti/bdisp/Makefile +index caf7ccd193ea..39ade0a34723 100644 +--- a/drivers/media/platform/sti/bdisp/Makefile ++++ b/drivers/media/platform/sti/bdisp/Makefile +@@ -1,4 +1,4 @@ + # SPDX-License-Identifier: GPL-2.0-only +-obj-$(CONFIG_VIDEO_STI_BDISP) := bdisp.o ++obj-$(CONFIG_VIDEO_STI_BDISP) += bdisp.o + + bdisp-objs := bdisp-v4l2.o bdisp-hw.o bdisp-debug.o +diff --git a/drivers/media/platform/sti/delta/Makefile b/drivers/media/platform/sti/delta/Makefile +index 92b37e216f00..32412fa4c632 100644 +--- a/drivers/media/platform/sti/delta/Makefile ++++ b/drivers/media/platform/sti/delta/Makefile +@@ -1,5 +1,5 @@ + # SPDX-License-Identifier: GPL-2.0-only +-obj-$(CONFIG_VIDEO_STI_DELTA_DRIVER) := st-delta.o ++obj-$(CONFIG_VIDEO_STI_DELTA_DRIVER) += st-delta.o + st-delta-y := delta-v4l2.o delta-mem.o delta-ipc.o delta-debug.o + + # MJPEG support +diff --git a/drivers/media/platform/sti/hva/Makefile b/drivers/media/platform/sti/hva/Makefile +index 74b41ec52f97..b5a5478bdd01 100644 +--- a/drivers/media/platform/sti/hva/Makefile ++++ b/drivers/media/platform/sti/hva/Makefile +@@ -1,4 +1,4 @@ + # SPDX-License-Identifier: GPL-2.0-only +-obj-$(CONFIG_VIDEO_STI_HVA) := st-hva.o ++obj-$(CONFIG_VIDEO_STI_HVA) += st-hva.o + st-hva-y := hva-v4l2.o hva-hw.o hva-mem.o hva-h264.o + st-hva-$(CONFIG_VIDEO_STI_HVA_DEBUGFS) += hva-debugfs.o +-- +2.30.2 + diff --git a/queue-5.10/media-subdev-remove-vidioc_dqevent_time32-handling.patch b/queue-5.10/media-subdev-remove-vidioc_dqevent_time32-handling.patch new file mode 100644 index 00000000000..c7e7498929e --- /dev/null +++ b/queue-5.10/media-subdev-remove-vidioc_dqevent_time32-handling.patch @@ -0,0 +1,72 @@ +From fe72e300105f589304872d8bf005c8a66deb7f88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Jun 2021 12:34:05 +0200 +Subject: media: subdev: remove VIDIOC_DQEVENT_TIME32 handling + +From: Arnd Bergmann + +[ Upstream commit 765ba251d2522e2a0daa2f0793fd0f0ce34816ec ] + +Converting the VIDIOC_DQEVENT_TIME32/VIDIOC_DQEVENT32/ +VIDIOC_DQEVENT32_TIME32 arguments to the canonical form is done in common +code, but for some reason I ended up adding another conversion helper to +subdev_do_ioctl() as well. I must have concluded that this does not go +through the common conversion, but it has done that since the ioctl +handler was first added. + +I assume this one is harmless as there should be no way to arrive here +from user space if CONFIG_COMPAT_32BIT_TIME is set, but since it is dead +code, it should just get removed. + +On a 64-bit architecture, as well as a 32-bit architecture without +CONFIG_COMPAT_32BIT_TIME, handling this command is a mistake, +and the kernel should return an error. + +Fixes: 1a6c0b36dd19 ("media: v4l2-core: fix VIDIOC_DQEVENT for time64 ABI") +Signed-off-by: Arnd Bergmann +Reviewed-by: Laurent Pinchart +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/v4l2-core/v4l2-subdev.c | 24 ------------------------ + 1 file changed, 24 deletions(-) + +diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c +index a7d508e74d6b..fbf0dcb313c8 100644 +--- a/drivers/media/v4l2-core/v4l2-subdev.c ++++ b/drivers/media/v4l2-core/v4l2-subdev.c +@@ -428,30 +428,6 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) + + return v4l2_event_dequeue(vfh, arg, file->f_flags & O_NONBLOCK); + +- case VIDIOC_DQEVENT_TIME32: { +- struct v4l2_event_time32 *ev32 = arg; +- struct v4l2_event ev = { }; +- +- if (!(sd->flags & V4L2_SUBDEV_FL_HAS_EVENTS)) +- return -ENOIOCTLCMD; +- +- rval = v4l2_event_dequeue(vfh, &ev, file->f_flags & O_NONBLOCK); +- +- *ev32 = (struct v4l2_event_time32) { +- .type = ev.type, +- .pending = ev.pending, +- .sequence = ev.sequence, +- .timestamp.tv_sec = ev.timestamp.tv_sec, +- .timestamp.tv_nsec = ev.timestamp.tv_nsec, +- .id = ev.id, +- }; +- +- memcpy(&ev32->u, &ev.u, sizeof(ev.u)); +- memcpy(&ev32->reserved, &ev.reserved, sizeof(ev.reserved)); +- +- return rval; +- } +- + case VIDIOC_SUBSCRIBE_EVENT: + return v4l2_subdev_call(sd, core, subscribe_event, vfh, arg); + +-- +2.30.2 + diff --git a/queue-5.10/media-sunxi-fix-pm_runtime_get_sync-usage-count.patch b/queue-5.10/media-sunxi-fix-pm_runtime_get_sync-usage-count.patch new file mode 100644 index 00000000000..53af5b8827c --- /dev/null +++ b/queue-5.10/media-sunxi-fix-pm_runtime_get_sync-usage-count.patch @@ -0,0 +1,39 @@ +From 5314f70f5c28a5edeef0744b4e35ac593044346c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Apr 2021 17:19:10 +0200 +Subject: media: sunxi: fix pm_runtime_get_sync() usage count + +From: Mauro Carvalho Chehab + +[ Upstream commit 9c298f82d8392f799a0595f50076afa1d91e9092 ] + +The pm_runtime_get_sync() internally increments the +dev->power.usage_count without decrementing it, even on errors. +Replace it by the new pm_runtime_resume_and_get(), introduced by: +commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") +in order to properly decrement the usage counter, avoiding +a potential PM usage counter leak. + +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c +index 3f81dd17755c..fbcca59a0517 100644 +--- a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c ++++ b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c +@@ -494,7 +494,7 @@ static int rotate_start_streaming(struct vb2_queue *vq, unsigned int count) + struct device *dev = ctx->dev->dev; + int ret; + +- ret = pm_runtime_get_sync(dev); ++ ret = pm_runtime_resume_and_get(dev); + if (ret < 0) { + dev_err(dev, "Failed to enable module\n"); + +-- +2.30.2 + diff --git a/queue-5.10/media-tc358743-fix-error-return-code-in-tc358743_pro.patch b/queue-5.10/media-tc358743-fix-error-return-code-in-tc358743_pro.patch new file mode 100644 index 00000000000..5151031f467 --- /dev/null +++ b/queue-5.10/media-tc358743-fix-error-return-code-in-tc358743_pro.patch @@ -0,0 +1,38 @@ +From e9fe9a4fb1e2edaa8ff8ac0a0949ef80028d9f9b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 15 May 2021 08:58:30 +0200 +Subject: media: tc358743: Fix error return code in tc358743_probe_of() + +From: Zhen Lei + +[ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] + +When the CSI bps per lane is not in the valid range, an appropriate error +code -EINVAL should be returned. However, we currently do not explicitly +assign this error code to 'ret'. As a result, 0 was incorrectly returned. + +Fixes: 256148246852 ("[media] tc358743: support probe from device tree") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/i2c/tc358743.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c +index 1b309bb743c7..f21da11caf22 100644 +--- a/drivers/media/i2c/tc358743.c ++++ b/drivers/media/i2c/tc358743.c +@@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) + bps_pr_lane = 2 * endpoint.link_frequencies[0]; + if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { + dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); ++ ret = -EINVAL; + goto disable_clk; + } + +-- +2.30.2 + diff --git a/queue-5.10/media-v4l2-async-clean-v4l2_async_notifier_add_fwnod.patch b/queue-5.10/media-v4l2-async-clean-v4l2_async_notifier_add_fwnod.patch new file mode 100644 index 00000000000..1a3828a5ac2 --- /dev/null +++ b/queue-5.10/media-v4l2-async-clean-v4l2_async_notifier_add_fwnod.patch @@ -0,0 +1,566 @@ +From 36c800cd591134c5157ccb52d4c83a09aeb4a08a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 18 Jan 2021 02:52:45 +0100 +Subject: media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev + +From: Ezequiel Garcia + +[ Upstream commit c1cf3d896d124e3e00794f9bfbde49f0fc279e3f ] + +Change v4l2_async_notifier_add_fwnode_remote_subdev semantics +so it allocates the struct v4l2_async_subdev pointer. + +This makes the API consistent: the v4l2-async subdevice addition +functions have now a unified usage model. This model is simpler, +as it makes v4l2-async responsible for the allocation and release +of the subdevice descriptor, and no longer something the driver +has to worry about. + +On the user side, the change makes the API simpler for the drivers +to use and less error-prone. + +Signed-off-by: Ezequiel Garcia +Reviewed-by: Laurent Pinchart +Signed-off-by: Sakari Ailus +Reviewed-by: Helen Koike +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/intel/ipu3/ipu3-cio2.c | 17 ++-- + drivers/media/platform/omap3isp/isp.c | 79 ++++++++----------- + .../platform/sunxi/sun4i-csi/sun4i_csi.c | 9 ++- + .../platform/sunxi/sun4i-csi/sun4i_csi.h | 1 - + drivers/media/platform/video-mux.c | 14 +--- + drivers/media/v4l2-core/v4l2-async.c | 24 +++--- + drivers/staging/media/imx/imx-media-csi.c | 14 +--- + drivers/staging/media/imx/imx6-mipi-csi2.c | 19 ++--- + drivers/staging/media/imx/imx7-media-csi.c | 16 ++-- + drivers/staging/media/imx/imx7-mipi-csis.c | 15 ++-- + drivers/staging/media/rkisp1/rkisp1-dev.c | 15 ++-- + include/media/v4l2-async.h | 15 ++-- + 12 files changed, 96 insertions(+), 142 deletions(-) + +diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c +index dcbfe8c9abc7..2fe4a0bd0284 100644 +--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c ++++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c +@@ -1476,7 +1476,8 @@ static int cio2_parse_firmware(struct cio2_device *cio2) + struct v4l2_fwnode_endpoint vep = { + .bus_type = V4L2_MBUS_CSI2_DPHY + }; +- struct sensor_async_subdev *s_asd = NULL; ++ struct sensor_async_subdev *s_asd; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + + ep = fwnode_graph_get_endpoint_by_id( +@@ -1490,27 +1491,23 @@ static int cio2_parse_firmware(struct cio2_device *cio2) + if (ret) + goto err_parse; + +- s_asd = kzalloc(sizeof(*s_asd), GFP_KERNEL); +- if (!s_asd) { +- ret = -ENOMEM; ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &cio2->notifier, ep, sizeof(*s_asd)); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + goto err_parse; + } + ++ s_asd = container_of(asd, struct sensor_async_subdev, asd); + s_asd->csi2.port = vep.base.port; + s_asd->csi2.lanes = vep.bus.mipi_csi2.num_data_lanes; + +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &cio2->notifier, ep, &s_asd->asd); +- if (ret) +- goto err_parse; +- + fwnode_handle_put(ep); + + continue; + + err_parse: + fwnode_handle_put(ep); +- kfree(s_asd); + return ret; + } + +diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c +index b1fc4518e275..1311b4996ece 100644 +--- a/drivers/media/platform/omap3isp/isp.c ++++ b/drivers/media/platform/omap3isp/isp.c +@@ -2126,21 +2126,6 @@ static void isp_parse_of_csi1_endpoint(struct device *dev, + buscfg->bus.ccp2.crc = 1; + } + +-static int isp_alloc_isd(struct isp_async_subdev **isd, +- struct isp_bus_cfg **buscfg) +-{ +- struct isp_async_subdev *__isd; +- +- __isd = kzalloc(sizeof(*__isd), GFP_KERNEL); +- if (!__isd) +- return -ENOMEM; +- +- *isd = __isd; +- *buscfg = &__isd->bus; +- +- return 0; +-} +- + static struct { + u32 phy; + u32 csi2_if; +@@ -2156,7 +2141,7 @@ static int isp_parse_of_endpoints(struct isp_device *isp) + { + struct fwnode_handle *ep; + struct isp_async_subdev *isd = NULL; +- struct isp_bus_cfg *buscfg; ++ struct v4l2_async_subdev *asd; + unsigned int i; + + ep = fwnode_graph_get_endpoint_by_id( +@@ -2174,20 +2159,15 @@ static int isp_parse_of_endpoints(struct isp_device *isp) + ret = v4l2_fwnode_endpoint_parse(ep, &vep); + + if (!ret) { +- ret = isp_alloc_isd(&isd, &buscfg); +- if (ret) +- return ret; +- } +- +- if (!ret) { +- isp_parse_of_parallel_endpoint(isp->dev, &vep, buscfg); +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &isp->notifier, ep, &isd->asd); ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &isp->notifier, ep, sizeof(*isd)); ++ if (!IS_ERR(asd)) { ++ isd = container_of(asd, struct isp_async_subdev, asd); ++ isp_parse_of_parallel_endpoint(isp->dev, &vep, &isd->bus); ++ } + } + + fwnode_handle_put(ep); +- if (ret) +- kfree(isd); + } + + for (i = 0; i < ARRAY_SIZE(isp_bus_interfaces); i++) { +@@ -2206,15 +2186,8 @@ static int isp_parse_of_endpoints(struct isp_device *isp) + dev_dbg(isp->dev, "parsing serial interface %u, node %pOF\n", i, + to_of_node(ep)); + +- ret = isp_alloc_isd(&isd, &buscfg); +- if (ret) +- return ret; +- + ret = v4l2_fwnode_endpoint_parse(ep, &vep); +- if (!ret) { +- buscfg->interface = isp_bus_interfaces[i].csi2_if; +- isp_parse_of_csi2_endpoint(isp->dev, &vep, buscfg); +- } else if (ret == -ENXIO) { ++ if (ret == -ENXIO) { + vep = (struct v4l2_fwnode_endpoint) + { .bus_type = V4L2_MBUS_CSI1 }; + ret = v4l2_fwnode_endpoint_parse(ep, &vep); +@@ -2224,21 +2197,35 @@ static int isp_parse_of_endpoints(struct isp_device *isp) + { .bus_type = V4L2_MBUS_CCP2 }; + ret = v4l2_fwnode_endpoint_parse(ep, &vep); + } +- if (!ret) { +- buscfg->interface = +- isp_bus_interfaces[i].csi1_if; +- isp_parse_of_csi1_endpoint(isp->dev, &vep, +- buscfg); +- } + } + +- if (!ret) +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &isp->notifier, ep, &isd->asd); ++ if (!ret) { ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &isp->notifier, ep, sizeof(*isd)); ++ ++ if (!IS_ERR(asd)) { ++ isd = container_of(asd, struct isp_async_subdev, asd); ++ ++ switch (vep.bus_type) { ++ case V4L2_MBUS_CSI2_DPHY: ++ isd->bus.interface = ++ isp_bus_interfaces[i].csi2_if; ++ isp_parse_of_csi2_endpoint(isp->dev, &vep, &isd->bus); ++ break; ++ case V4L2_MBUS_CSI1: ++ case V4L2_MBUS_CCP2: ++ isd->bus.interface = ++ isp_bus_interfaces[i].csi1_if; ++ isp_parse_of_csi1_endpoint(isp->dev, &vep, ++ &isd->bus); ++ break; ++ default: ++ break; ++ } ++ } ++ } + + fwnode_handle_put(ep); +- if (ret) +- kfree(isd); + } + + return 0; +diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +index eb15c8c725ca..64f25921463e 100644 +--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c ++++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +@@ -118,6 +118,7 @@ static int sun4i_csi_notifier_init(struct sun4i_csi *csi) + struct v4l2_fwnode_endpoint vep = { + .bus_type = V4L2_MBUS_PARALLEL, + }; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + int ret; + +@@ -134,10 +135,12 @@ static int sun4i_csi_notifier_init(struct sun4i_csi *csi) + + csi->bus = vep.bus.parallel; + +- ret = v4l2_async_notifier_add_fwnode_remote_subdev(&csi->notifier, +- ep, &csi->asd); +- if (ret) ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev(&csi->notifier, ++ ep, sizeof(*asd)); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + goto out; ++ } + + csi->notifier.ops = &sun4i_csi_notify_ops; + +diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h +index 0f67ff652c2e..a5f61ee0ec4d 100644 +--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h ++++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h +@@ -139,7 +139,6 @@ struct sun4i_csi { + struct v4l2_mbus_framefmt subdev_fmt; + + /* V4L2 Async variables */ +- struct v4l2_async_subdev asd; + struct v4l2_async_notifier notifier; + struct v4l2_subdev *src_subdev; + int src_pad; +diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c +index 53570250a25d..7b280dfca727 100644 +--- a/drivers/media/platform/video-mux.c ++++ b/drivers/media/platform/video-mux.c +@@ -370,19 +370,13 @@ static int video_mux_async_register(struct video_mux *vmux, + if (!ep) + continue; + +- asd = kzalloc(sizeof(*asd), GFP_KERNEL); +- if (!asd) { +- fwnode_handle_put(ep); +- return -ENOMEM; +- } +- +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &vmux->notifier, ep, asd); ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &vmux->notifier, ep, sizeof(*asd)); + + fwnode_handle_put(ep); + +- if (ret) { +- kfree(asd); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + /* OK if asd already exists */ + if (ret != -EEXIST) + return ret; +diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c +index e3ab003a6c85..33babe6e8b3a 100644 +--- a/drivers/media/v4l2-core/v4l2-async.c ++++ b/drivers/media/v4l2-core/v4l2-async.c +@@ -673,26 +673,26 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier, + } + EXPORT_SYMBOL_GPL(v4l2_async_notifier_add_fwnode_subdev); + +-int ++struct v4l2_async_subdev * + v4l2_async_notifier_add_fwnode_remote_subdev(struct v4l2_async_notifier *notif, + struct fwnode_handle *endpoint, +- struct v4l2_async_subdev *asd) ++ unsigned int asd_struct_size) + { ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *remote; +- int ret; + + remote = fwnode_graph_get_remote_port_parent(endpoint); + if (!remote) +- return -ENOTCONN; ++ return ERR_PTR(-ENOTCONN); + +- asd->match_type = V4L2_ASYNC_MATCH_FWNODE; +- asd->match.fwnode = remote; +- +- ret = v4l2_async_notifier_add_subdev(notif, asd); +- if (ret) +- fwnode_handle_put(remote); +- +- return ret; ++ asd = v4l2_async_notifier_add_fwnode_subdev(notif, remote, ++ asd_struct_size); ++ /* ++ * Calling v4l2_async_notifier_add_fwnode_subdev grabs a refcount, ++ * so drop the one we got in fwnode_graph_get_remote_port_parent. ++ */ ++ fwnode_handle_put(remote); ++ return asd; + } + EXPORT_SYMBOL_GPL(v4l2_async_notifier_add_fwnode_remote_subdev); + +diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c +index 899d29f4c91a..d9a8667b4bed 100644 +--- a/drivers/staging/media/imx/imx-media-csi.c ++++ b/drivers/staging/media/imx/imx-media-csi.c +@@ -1942,19 +1942,13 @@ static int imx_csi_async_register(struct csi_priv *priv) + port, 0, + FWNODE_GRAPH_ENDPOINT_NEXT); + if (ep) { +- asd = kzalloc(sizeof(*asd), GFP_KERNEL); +- if (!asd) { +- fwnode_handle_put(ep); +- return -ENOMEM; +- } +- +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &priv->notifier, ep, asd); ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &priv->notifier, ep, sizeof(*asd)); + + fwnode_handle_put(ep); + +- if (ret) { +- kfree(asd); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + /* OK if asd already exists */ + if (ret != -EEXIST) + return ret; +diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c +index 94d87d27d389..9457761b7c8b 100644 +--- a/drivers/staging/media/imx/imx6-mipi-csi2.c ++++ b/drivers/staging/media/imx/imx6-mipi-csi2.c +@@ -557,7 +557,7 @@ static int csi2_async_register(struct csi2_dev *csi2) + struct v4l2_fwnode_endpoint vep = { + .bus_type = V4L2_MBUS_CSI2_DPHY, + }; +- struct v4l2_async_subdev *asd = NULL; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + int ret; + +@@ -577,19 +577,13 @@ static int csi2_async_register(struct csi2_dev *csi2) + dev_dbg(csi2->dev, "data lanes: %d\n", csi2->bus.num_data_lanes); + dev_dbg(csi2->dev, "flags: 0x%08x\n", csi2->bus.flags); + +- asd = kzalloc(sizeof(*asd), GFP_KERNEL); +- if (!asd) { +- ret = -ENOMEM; +- goto err_parse; +- } +- +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &csi2->notifier, ep, asd); +- if (ret) +- goto err_parse; +- ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &csi2->notifier, ep, sizeof(*asd)); + fwnode_handle_put(ep); + ++ if (IS_ERR(asd)) ++ return PTR_ERR(asd); ++ + csi2->notifier.ops = &csi2_notify_ops; + + ret = v4l2_async_subdev_notifier_register(&csi2->sd, +@@ -601,7 +595,6 @@ static int csi2_async_register(struct csi2_dev *csi2) + + err_parse: + fwnode_handle_put(ep); +- kfree(asd); + return ret; + } + +diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c +index ac52b1daf991..6c59485291ca 100644 +--- a/drivers/staging/media/imx/imx7-media-csi.c ++++ b/drivers/staging/media/imx/imx7-media-csi.c +@@ -1191,7 +1191,7 @@ static const struct v4l2_async_notifier_operations imx7_csi_notify_ops = { + + static int imx7_csi_async_register(struct imx7_csi *csi) + { +- struct v4l2_async_subdev *asd = NULL; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + int ret; + +@@ -1200,19 +1200,13 @@ static int imx7_csi_async_register(struct imx7_csi *csi) + ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(csi->dev), 0, 0, + FWNODE_GRAPH_ENDPOINT_NEXT); + if (ep) { +- asd = kzalloc(sizeof(*asd), GFP_KERNEL); +- if (!asd) { +- fwnode_handle_put(ep); +- return -ENOMEM; +- } +- +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &csi->notifier, ep, asd); ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &csi->notifier, ep, sizeof(*asd)); + + fwnode_handle_put(ep); + +- if (ret) { +- kfree(asd); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + /* OK if asd already exists */ + if (ret != -EEXIST) + return ret; +diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c +index c5a548976f1d..a392f9012626 100644 +--- a/drivers/staging/media/imx/imx7-mipi-csis.c ++++ b/drivers/staging/media/imx/imx7-mipi-csis.c +@@ -1006,7 +1006,7 @@ static int mipi_csis_async_register(struct csi_state *state) + struct v4l2_fwnode_endpoint vep = { + .bus_type = V4L2_MBUS_CSI2_DPHY, + }; +- struct v4l2_async_subdev *asd = NULL; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + int ret; + +@@ -1026,17 +1026,13 @@ static int mipi_csis_async_register(struct csi_state *state) + dev_dbg(state->dev, "data lanes: %d\n", state->bus.num_data_lanes); + dev_dbg(state->dev, "flags: 0x%08x\n", state->bus.flags); + +- asd = kzalloc(sizeof(*asd), GFP_KERNEL); +- if (!asd) { +- ret = -ENOMEM; ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev( ++ &state->notifier, ep, sizeof(*asd)); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + goto err_parse; + } + +- ret = v4l2_async_notifier_add_fwnode_remote_subdev( +- &state->notifier, ep, asd); +- if (ret) +- goto err_parse; +- + fwnode_handle_put(ep); + + state->notifier.ops = &mipi_csis_notify_ops; +@@ -1050,7 +1046,6 @@ static int mipi_csis_async_register(struct csi_state *state) + + err_parse: + fwnode_handle_put(ep); +- kfree(asd); + + return ret; + } +diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c +index 91584695804b..06de5540c8af 100644 +--- a/drivers/staging/media/rkisp1/rkisp1-dev.c ++++ b/drivers/staging/media/rkisp1/rkisp1-dev.c +@@ -252,6 +252,7 @@ static int rkisp1_subdev_notifier(struct rkisp1_device *rkisp1) + .bus_type = V4L2_MBUS_CSI2_DPHY + }; + struct rkisp1_sensor_async *rk_asd = NULL; ++ struct v4l2_async_subdev *asd; + struct fwnode_handle *ep; + + ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(rkisp1->dev), +@@ -263,21 +264,18 @@ static int rkisp1_subdev_notifier(struct rkisp1_device *rkisp1) + if (ret) + goto err_parse; + +- rk_asd = kzalloc(sizeof(*rk_asd), GFP_KERNEL); +- if (!rk_asd) { +- ret = -ENOMEM; ++ asd = v4l2_async_notifier_add_fwnode_remote_subdev(ntf, ep, ++ sizeof(*rk_asd)); ++ if (IS_ERR(asd)) { ++ ret = PTR_ERR(asd); + goto err_parse; + } + ++ rk_asd = container_of(asd, struct rkisp1_sensor_async, asd); + rk_asd->mbus_type = vep.bus_type; + rk_asd->mbus_flags = vep.bus.mipi_csi2.flags; + rk_asd->lanes = vep.bus.mipi_csi2.num_data_lanes; + +- ret = v4l2_async_notifier_add_fwnode_remote_subdev(ntf, ep, +- &rk_asd->asd); +- if (ret) +- goto err_parse; +- + dev_dbg(rkisp1->dev, "registered ep id %d with %d lanes\n", + vep.base.id, rk_asd->lanes); + +@@ -288,7 +286,6 @@ static int rkisp1_subdev_notifier(struct rkisp1_device *rkisp1) + continue; + err_parse: + fwnode_handle_put(ep); +- kfree(rk_asd); + v4l2_async_notifier_cleanup(ntf); + return ret; + } +diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h +index d6e31234826f..92cd9f038fed 100644 +--- a/include/media/v4l2-async.h ++++ b/include/media/v4l2-async.h +@@ -189,9 +189,11 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier, + * + * @notif: pointer to &struct v4l2_async_notifier + * @endpoint: local endpoint pointing to the remote sub-device to be matched +- * @asd: Async sub-device struct allocated by the caller. The &struct +- * v4l2_async_subdev shall be the first member of the driver's async +- * sub-device struct, i.e. both begin at the same memory address. ++ * @asd_struct_size: size of the driver's async sub-device struct, including ++ * sizeof(struct v4l2_async_subdev). The &struct ++ * v4l2_async_subdev shall be the first member of ++ * the driver's async sub-device struct, i.e. both ++ * begin at the same memory address. + * + * Gets the remote endpoint of a given local endpoint, set it up for fwnode + * matching and adds the async sub-device to the notifier's @asd_list. The +@@ -199,13 +201,12 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier, + * notifier cleanup time. + * + * This is just like @v4l2_async_notifier_add_fwnode_subdev, but with the +- * exception that the fwnode refers to a local endpoint, not the remote one, and +- * the function relies on the caller to allocate the async sub-device struct. ++ * exception that the fwnode refers to a local endpoint, not the remote one. + */ +-int ++struct v4l2_async_subdev * + v4l2_async_notifier_add_fwnode_remote_subdev(struct v4l2_async_notifier *notif, + struct fwnode_handle *endpoint, +- struct v4l2_async_subdev *asd); ++ unsigned int asd_struct_size); + + /** + * v4l2_async_notifier_add_i2c_subdev - Allocate and add an i2c async +-- +2.30.2 + diff --git a/queue-5.10/media-v4l2-core-avoid-the-dangling-pointer-in-v4l2_f.patch b/queue-5.10/media-v4l2-core-avoid-the-dangling-pointer-in-v4l2_f.patch new file mode 100644 index 00000000000..680042c1a33 --- /dev/null +++ b/queue-5.10/media-v4l2-core-avoid-the-dangling-pointer-in-v4l2_f.patch @@ -0,0 +1,39 @@ +From 3d7073ff8902f8dd69826668f63d3191eaa41766 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 9 May 2021 10:24:02 +0200 +Subject: media: v4l2-core: Avoid the dangling pointer in v4l2_fh_release + +From: Lv Yunlong + +[ Upstream commit 7dd0c9e547b6924e18712b6b51aa3cba1896ee2c ] + +A use after free bug caused by the dangling pointer +filp->privitate_data in v4l2_fh_release. +See https://lore.kernel.org/patchwork/patch/1419058/. + +My patch sets the dangling pointer to NULL to provide +robust. + +Signed-off-by: Lv Yunlong +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/v4l2-core/v4l2-fh.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/media/v4l2-core/v4l2-fh.c b/drivers/media/v4l2-core/v4l2-fh.c +index 684574f58e82..90eec79ee995 100644 +--- a/drivers/media/v4l2-core/v4l2-fh.c ++++ b/drivers/media/v4l2-core/v4l2-fh.c +@@ -96,6 +96,7 @@ int v4l2_fh_release(struct file *filp) + v4l2_fh_del(fh); + v4l2_fh_exit(fh); + kfree(fh); ++ filp->private_data = NULL; + } + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/media-venus-rework-error-fail-recover-logic.patch b/queue-5.10/media-venus-rework-error-fail-recover-logic.patch new file mode 100644 index 00000000000..122e94c412a --- /dev/null +++ b/queue-5.10/media-venus-rework-error-fail-recover-logic.patch @@ -0,0 +1,156 @@ +From 3ccacdeea196ec045c32e083a2bf0b0109820851 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 27 Apr 2021 10:39:47 +0200 +Subject: media: venus: Rework error fail recover logic + +From: Mauro Carvalho Chehab + +[ Upstream commit 4cba5473c5ce0f1389d316c5dc6f83a0259df5eb ] + +The Venus code has a sort of watchdog that attempts to recover +from IP errors, implemented as a delayed work job, which +calls venus_sys_error_handler(). + +Right now, it has several issues: + +1. It assumes that PM runtime resume never fails + +2. It internally runs two while() loops that also assume that + PM runtime will never fail to go idle: + + while (pm_runtime_active(core->dev_dec) || pm_runtime_active(core->dev_enc)) + msleep(10); + +... + + while (core->pmdomains[0] && pm_runtime_active(core->pmdomains[0])) + usleep_range(1000, 1500); + +3. It uses an OR to merge all return codes and then report to the user + +4. If the hardware never recovers, it keeps running on every 10ms, + flooding the syslog with 2 messages (so, up to 200 messages + per second). + +Rework the code, in order to prevent that, by: + +1. check the return code from PM runtime resume; +2. don't let the while() loops run forever; +3. store the failed event; +4. use warn ratelimited when it fails to recover. + +Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") +Reviewed-by: Jonathan Cameron +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/qcom/venus/core.c | 60 +++++++++++++++++++----- + 1 file changed, 47 insertions(+), 13 deletions(-) + +diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c +index fd5993b3e674..58ddebbb8446 100644 +--- a/drivers/media/platform/qcom/venus/core.c ++++ b/drivers/media/platform/qcom/venus/core.c +@@ -48,52 +48,86 @@ static const struct hfi_core_ops venus_core_ops = { + .event_notify = venus_event_notify, + }; + ++#define RPM_WAIT_FOR_IDLE_MAX_ATTEMPTS 10 ++ + static void venus_sys_error_handler(struct work_struct *work) + { + struct venus_core *core = + container_of(work, struct venus_core, work.work); +- int ret = 0; +- +- pm_runtime_get_sync(core->dev); ++ int ret, i, max_attempts = RPM_WAIT_FOR_IDLE_MAX_ATTEMPTS; ++ const char *err_msg = ""; ++ bool failed = false; ++ ++ ret = pm_runtime_get_sync(core->dev); ++ if (ret < 0) { ++ err_msg = "resume runtime PM"; ++ max_attempts = 0; ++ failed = true; ++ } + + hfi_core_deinit(core, true); + +- dev_warn(core->dev, "system error has occurred, starting recovery!\n"); +- + mutex_lock(&core->lock); + +- while (pm_runtime_active(core->dev_dec) || pm_runtime_active(core->dev_enc)) ++ for (i = 0; i < max_attempts; i++) { ++ if (!pm_runtime_active(core->dev_dec) && !pm_runtime_active(core->dev_enc)) ++ break; + msleep(10); ++ } + + venus_shutdown(core); + + pm_runtime_put_sync(core->dev); + +- while (core->pmdomains[0] && pm_runtime_active(core->pmdomains[0])) ++ for (i = 0; i < max_attempts; i++) { ++ if (!core->pmdomains[0] || !pm_runtime_active(core->pmdomains[0])) ++ break; + usleep_range(1000, 1500); ++ } + + hfi_reinit(core); + +- pm_runtime_get_sync(core->dev); ++ ret = pm_runtime_get_sync(core->dev); ++ if (ret < 0) { ++ err_msg = "resume runtime PM"; ++ failed = true; ++ } ++ ++ ret = venus_boot(core); ++ if (ret && !failed) { ++ err_msg = "boot Venus"; ++ failed = true; ++ } + +- ret |= venus_boot(core); +- ret |= hfi_core_resume(core, true); ++ ret = hfi_core_resume(core, true); ++ if (ret && !failed) { ++ err_msg = "resume HFI"; ++ failed = true; ++ } + + enable_irq(core->irq); + + mutex_unlock(&core->lock); + +- ret |= hfi_core_init(core); ++ ret = hfi_core_init(core); ++ if (ret && !failed) { ++ err_msg = "init HFI"; ++ failed = true; ++ } + + pm_runtime_put_sync(core->dev); + +- if (ret) { ++ if (failed) { + disable_irq_nosync(core->irq); +- dev_warn(core->dev, "recovery failed (%d)\n", ret); ++ dev_warn_ratelimited(core->dev, ++ "System error has occurred, recovery failed to %s\n", ++ err_msg); + schedule_delayed_work(&core->work, msecs_to_jiffies(10)); + return; + } + ++ dev_warn(core->dev, "system error has occurred (recovered)\n"); ++ + mutex_lock(&core->lock); + core->sys_error = false; + mutex_unlock(&core->lock); +-- +2.30.2 + diff --git a/queue-5.10/media-video-mux-skip-dangling-endpoints.patch b/queue-5.10/media-video-mux-skip-dangling-endpoints.patch new file mode 100644 index 00000000000..5b57426a9fd --- /dev/null +++ b/queue-5.10/media-video-mux-skip-dangling-endpoints.patch @@ -0,0 +1,54 @@ +From 7789d6138711f94af461d1096d64492e333009ed Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Mar 2021 15:44:08 +0100 +Subject: media: video-mux: Skip dangling endpoints + +From: Philipp Zabel + +[ Upstream commit 95778c2d0979618e3349b1d2324ec282a5a6adbf ] + +i.MX6 device tree include files contain dangling endpoints for the +board device tree writers' convenience. These are still included in +many existing device trees. +Treat dangling endpoints as non-existent to support them. + +Signed-off-by: Philipp Zabel +Signed-off-by: Hans Verkuil +Fixes: 612b385efb1e ("media: video-mux: Create media links in bound notifier") +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/platform/video-mux.c | 10 +++++++++- + 1 file changed, 9 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c +index 7b280dfca727..640ce76fe0d9 100644 +--- a/drivers/media/platform/video-mux.c ++++ b/drivers/media/platform/video-mux.c +@@ -362,7 +362,7 @@ static int video_mux_async_register(struct video_mux *vmux, + + for (i = 0; i < num_input_pads; i++) { + struct v4l2_async_subdev *asd; +- struct fwnode_handle *ep; ++ struct fwnode_handle *ep, *remote_ep; + + ep = fwnode_graph_get_endpoint_by_id( + dev_fwnode(vmux->subdev.dev), i, 0, +@@ -370,6 +370,14 @@ static int video_mux_async_register(struct video_mux *vmux, + if (!ep) + continue; + ++ /* Skip dangling endpoints for backwards compatibility */ ++ remote_ep = fwnode_graph_get_remote_endpoint(ep); ++ if (!remote_ep) { ++ fwnode_handle_put(ep); ++ continue; ++ } ++ fwnode_handle_put(remote_ep); ++ + asd = v4l2_async_notifier_add_fwnode_remote_subdev( + &vmux->notifier, ep, sizeof(*asd)); + +-- +2.30.2 + diff --git a/queue-5.10/memstick-rtsx_usb_ms-fix-uaf.patch b/queue-5.10/memstick-rtsx_usb_ms-fix-uaf.patch new file mode 100644 index 00000000000..8c86a425599 --- /dev/null +++ b/queue-5.10/memstick-rtsx_usb_ms-fix-uaf.patch @@ -0,0 +1,89 @@ +From 708f194fe19ae907452d940281ca3032232712fa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 11 May 2021 12:39:45 -0400 +Subject: memstick: rtsx_usb_ms: fix UAF + +From: Tong Zhang + +[ Upstream commit 42933c8aa14be1caa9eda41f65cde8a3a95d3e39 ] + +This patch fixes the following issues: +1. memstick_free_host() will free the host, so the use of ms_dev(host) after +it will be a problem. To fix this, move memstick_free_host() after when we +are done with ms_dev(host). +2. In rtsx_usb_ms_drv_remove(), pm need to be disabled before we remove +and free host otherwise memstick_check will be called and UAF will +happen. + +[ 11.351173] BUG: KASAN: use-after-free in rtsx_usb_ms_drv_remove+0x94/0x140 [rtsx_usb_ms] +[ 11.357077] rtsx_usb_ms_drv_remove+0x94/0x140 [rtsx_usb_ms] +[ 11.357376] platform_remove+0x2a/0x50 +[ 11.367531] Freed by task 298: +[ 11.368537] kfree+0xa4/0x2a0 +[ 11.368711] device_release+0x51/0xe0 +[ 11.368905] kobject_put+0xa2/0x120 +[ 11.369090] rtsx_usb_ms_drv_remove+0x8c/0x140 [rtsx_usb_ms] +[ 11.369386] platform_remove+0x2a/0x50 + +[ 12.038408] BUG: KASAN: use-after-free in __mutex_lock.isra.0+0x3ec/0x7c0 +[ 12.045432] mutex_lock+0xc9/0xd0 +[ 12.046080] memstick_check+0x6a/0x578 [memstick] +[ 12.046509] process_one_work+0x46d/0x750 +[ 12.052107] Freed by task 297: +[ 12.053115] kfree+0xa4/0x2a0 +[ 12.053272] device_release+0x51/0xe0 +[ 12.053463] kobject_put+0xa2/0x120 +[ 12.053647] rtsx_usb_ms_drv_remove+0xc4/0x140 [rtsx_usb_ms] +[ 12.053939] platform_remove+0x2a/0x50 + +Signed-off-by: Tong Zhang +Co-developed-by: Ulf Hansson +Link: https://lore.kernel.org/r/20210511163944.1233295-1-ztong0001@gmail.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/memstick/host/rtsx_usb_ms.c | 10 ++++------ + 1 file changed, 4 insertions(+), 6 deletions(-) + +diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c +index 102dbb8080da..29271ad4728a 100644 +--- a/drivers/memstick/host/rtsx_usb_ms.c ++++ b/drivers/memstick/host/rtsx_usb_ms.c +@@ -799,9 +799,9 @@ static int rtsx_usb_ms_drv_probe(struct platform_device *pdev) + + return 0; + err_out: +- memstick_free_host(msh); + pm_runtime_disable(ms_dev(host)); + pm_runtime_put_noidle(ms_dev(host)); ++ memstick_free_host(msh); + return err; + } + +@@ -828,9 +828,6 @@ static int rtsx_usb_ms_drv_remove(struct platform_device *pdev) + } + mutex_unlock(&host->host_mutex); + +- memstick_remove_host(msh); +- memstick_free_host(msh); +- + /* Balance possible unbalanced usage count + * e.g. unconditional module removal + */ +@@ -838,10 +835,11 @@ static int rtsx_usb_ms_drv_remove(struct platform_device *pdev) + pm_runtime_put(ms_dev(host)); + + pm_runtime_disable(ms_dev(host)); +- platform_set_drvdata(pdev, NULL); +- ++ memstick_remove_host(msh); + dev_dbg(ms_dev(host), + ": Realtek USB Memstick controller has been removed\n"); ++ memstick_free_host(msh); ++ platform_set_drvdata(pdev, NULL); + + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/mfd-mp2629-select-mfd_core-to-fix-build-error.patch b/queue-5.10/mfd-mp2629-select-mfd_core-to-fix-build-error.patch new file mode 100644 index 00000000000..0f38223ea86 --- /dev/null +++ b/queue-5.10/mfd-mp2629-select-mfd_core-to-fix-build-error.patch @@ -0,0 +1,36 @@ +From ff739e117fb58a16a5fe4d1c5f16830000d5f139 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 3 May 2021 19:32:18 -0700 +Subject: mfd: mp2629: Select MFD_CORE to fix build error + +From: Randy Dunlap + +[ Upstream commit a933272041d852a1ef1c85f0c18b93e9999a41fa ] + +MFD_MP2629 should select MFD_CORE to a prevent build error: + +ERROR: modpost: "devm_mfd_add_devices" [drivers/mfd/mp2629.ko] undefined! + +Fixes: 06081646450e ("mfd: mp2629: Add support for mps battery charger") +Signed-off-by: Randy Dunlap +Signed-off-by: Lee Jones +Signed-off-by: Sasha Levin +--- + drivers/mfd/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig +index 4789507f325b..b8847ae04d93 100644 +--- a/drivers/mfd/Kconfig ++++ b/drivers/mfd/Kconfig +@@ -465,6 +465,7 @@ config MFD_MP2629 + tristate "Monolithic Power Systems MP2629 ADC and Battery charger" + depends on I2C + select REGMAP_I2C ++ select MFD_CORE + help + Select this option to enable support for Monolithic Power Systems + battery charger. This provides ADC, thermal and battery charger power +-- +2.30.2 + diff --git a/queue-5.10/mfd-rn5t618-fix-irq-trigger-by-changing-it-to-level-.patch b/queue-5.10/mfd-rn5t618-fix-irq-trigger-by-changing-it-to-level-.patch new file mode 100644 index 00000000000..2dfddd51a06 --- /dev/null +++ b/queue-5.10/mfd-rn5t618-fix-irq-trigger-by-changing-it-to-level-.patch @@ -0,0 +1,38 @@ +From 91e056a1955e522c4efc6ef10c9e658104c8803c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 15 May 2021 22:55:18 +0200 +Subject: mfd: rn5t618: Fix IRQ trigger by changing it to level mode + +From: Andreas Kemnade + +[ Upstream commit a1649a5260631979c68e5b2012f60f90300e646f ] + +During more massive generation of interrupts, the IRQ got stuck, +and the subdevices did not see any new interrupts. That happens +especially at wonky USB supply in combination with ADC reads. +To fix that trigger the IRQ at level low instead of falling edge. + +Fixes: 0c81604516af ("mfd: rn5t618: Add IRQ support") +Signed-off-by: Andreas Kemnade +Signed-off-by: Lee Jones +Signed-off-by: Sasha Levin +--- + drivers/mfd/rn5t618.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c +index dc452df1f1bf..652a5e60067f 100644 +--- a/drivers/mfd/rn5t618.c ++++ b/drivers/mfd/rn5t618.c +@@ -104,7 +104,7 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618) + + ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap, + rn5t618->irq, +- IRQF_TRIGGER_FALLING | IRQF_ONESHOT, ++ IRQF_TRIGGER_LOW | IRQF_ONESHOT, + 0, irq_chip, &rn5t618->irq_data); + if (ret) + dev_err(rn5t618->dev, "Failed to register IRQ chip\n"); +-- +2.30.2 + diff --git a/queue-5.10/mips-fix-pkmap-with-32-bit-mips-huge-page-support.patch b/queue-5.10/mips-fix-pkmap-with-32-bit-mips-huge-page-support.patch new file mode 100644 index 00000000000..36aae24a08d --- /dev/null +++ b/queue-5.10/mips-fix-pkmap-with-32-bit-mips-huge-page-support.patch @@ -0,0 +1,38 @@ +From e25a338a75251a6856f48ad5809c5870c05c4b1e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 29 Jun 2021 22:14:20 +0800 +Subject: MIPS: Fix PKMAP with 32-bit MIPS huge page support + +From: Wei Li + +[ Upstream commit cf02ce742f09188272bcc8b0e62d789eb671fc4c ] + +When 32-bit MIPS huge page support is enabled, we halve the number of +pointers a PTE page holds, making its last half go to waste. +Correspondingly, we should halve the number of kmap entries, as we just +initialized only a single pte table for that in pagetable_init(). + +Fixes: 35476311e529 ("MIPS: Add partial 32-bit huge page support") +Signed-off-by: Wei Li +Signed-off-by: Thomas Bogendoerfer +Signed-off-by: Sasha Levin +--- + arch/mips/include/asm/highmem.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/mips/include/asm/highmem.h b/arch/mips/include/asm/highmem.h +index f1f788b57166..9f021cf51aa7 100644 +--- a/arch/mips/include/asm/highmem.h ++++ b/arch/mips/include/asm/highmem.h +@@ -36,7 +36,7 @@ extern pte_t *pkmap_page_table; + * easily, subsequent pte tables have to be allocated in one physical + * chunk of RAM. + */ +-#ifdef CONFIG_PHYS_ADDR_T_64BIT ++#if defined(CONFIG_PHYS_ADDR_T_64BIT) || defined(CONFIG_MIPS_HUGE_TLB_SUPPORT) + #define LAST_PKMAP 512 + #else + #define LAST_PKMAP 1024 +-- +2.30.2 + diff --git a/queue-5.10/mm-debug_vm_pgtable-basic-add-validation-for-dirtine.patch b/queue-5.10/mm-debug_vm_pgtable-basic-add-validation-for-dirtine.patch new file mode 100644 index 00000000000..231f888a7ed --- /dev/null +++ b/queue-5.10/mm-debug_vm_pgtable-basic-add-validation-for-dirtine.patch @@ -0,0 +1,178 @@ +From fc7092ad0e486be40ac838e74708ea542aada9ce Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Feb 2021 12:01:32 -0800 +Subject: mm/debug_vm_pgtable/basic: add validation for dirtiness after write + protect + +From: Anshuman Khandual + +[ Upstream commit bb5c47ced46797409f4791d0380db3116d93134c ] + +Patch series "mm/debug_vm_pgtable: Some minor updates", v3. + +This series contains some cleanups and new test suggestions from Catalin +from an earlier discussion. + +https://lore.kernel.org/linux-mm/20201123142237.GF17833@gaia/ + +This patch (of 2): + +This adds validation tests for dirtiness after write protect conversion +for each page table level. There are two new separate test types involved +here. + +The first test ensures that a given page table entry does not become dirty +after pxx_wrprotect(). This is important for platforms like arm64 which +transfers and drops the hardware dirty bit (!PTE_RDONLY) to the software +dirty bit while making it an write protected one. This test ensures that +no fresh page table entry could be created with hardware dirty bit set. +The second test ensures that a given page table entry always preserve the +dirty information across pxx_wrprotect(). + +This adds two previously missing PUD level basic tests and while here +fixes pxx_wrprotect() related typos in the documentation file. + +Link: https://lkml.kernel.org/r/1611137241-26220-1-git-send-email-anshuman.khandual@arm.com +Link: https://lkml.kernel.org/r/1611137241-26220-2-git-send-email-anshuman.khandual@arm.com +Signed-off-by: Anshuman Khandual +Suggested-by: Catalin Marinas +Tested-by: Gerald Schaefer [s390] +Cc: Christophe Leroy +Cc: Gerald Schaefer +Cc: Vineet Gupta +Cc: Paul Walmsley +Cc: Steven Price +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + Documentation/vm/arch_pgtable_helpers.rst | 8 ++--- + mm/debug_vm_pgtable.c | 39 +++++++++++++++++++++++ + 2 files changed, 43 insertions(+), 4 deletions(-) + +diff --git a/Documentation/vm/arch_pgtable_helpers.rst b/Documentation/vm/arch_pgtable_helpers.rst +index f3591ee3aaa8..552567d863b8 100644 +--- a/Documentation/vm/arch_pgtable_helpers.rst ++++ b/Documentation/vm/arch_pgtable_helpers.rst +@@ -50,7 +50,7 @@ PTE Page Table Helpers + +---------------------------+--------------------------------------------------+ + | pte_mkwrite | Creates a writable PTE | + +---------------------------+--------------------------------------------------+ +-| pte_mkwrprotect | Creates a write protected PTE | ++| pte_wrprotect | Creates a write protected PTE | + +---------------------------+--------------------------------------------------+ + | pte_mkspecial | Creates a special PTE | + +---------------------------+--------------------------------------------------+ +@@ -120,7 +120,7 @@ PMD Page Table Helpers + +---------------------------+--------------------------------------------------+ + | pmd_mkwrite | Creates a writable PMD | + +---------------------------+--------------------------------------------------+ +-| pmd_mkwrprotect | Creates a write protected PMD | ++| pmd_wrprotect | Creates a write protected PMD | + +---------------------------+--------------------------------------------------+ + | pmd_mkspecial | Creates a special PMD | + +---------------------------+--------------------------------------------------+ +@@ -186,7 +186,7 @@ PUD Page Table Helpers + +---------------------------+--------------------------------------------------+ + | pud_mkwrite | Creates a writable PUD | + +---------------------------+--------------------------------------------------+ +-| pud_mkwrprotect | Creates a write protected PUD | ++| pud_wrprotect | Creates a write protected PUD | + +---------------------------+--------------------------------------------------+ + | pud_mkdevmap | Creates a ZONE_DEVICE mapped PUD | + +---------------------------+--------------------------------------------------+ +@@ -224,7 +224,7 @@ HugeTLB Page Table Helpers + +---------------------------+--------------------------------------------------+ + | huge_pte_mkwrite | Creates a writable HugeTLB | + +---------------------------+--------------------------------------------------+ +-| huge_pte_mkwrprotect | Creates a write protected HugeTLB | ++| huge_pte_wrprotect | Creates a write protected HugeTLB | + +---------------------------+--------------------------------------------------+ + | huge_ptep_get_and_clear | Clears a HugeTLB | + +---------------------------+--------------------------------------------------+ +diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c +index 750bfef26be3..79480fd18443 100644 +--- a/mm/debug_vm_pgtable.c ++++ b/mm/debug_vm_pgtable.c +@@ -63,6 +63,16 @@ static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot) + pte_t pte = pfn_pte(pfn, prot); + + pr_debug("Validating PTE basic\n"); ++ ++ /* ++ * This test needs to be executed after the given page table entry ++ * is created with pfn_pte() to make sure that protection_map[idx] ++ * does not have the dirty bit enabled from the beginning. This is ++ * important for platforms like arm64 where (!PTE_RDONLY) indicate ++ * dirty bit being set. ++ */ ++ WARN_ON(pte_dirty(pte_wrprotect(pte))); ++ + WARN_ON(!pte_same(pte, pte)); + WARN_ON(!pte_young(pte_mkyoung(pte_mkold(pte)))); + WARN_ON(!pte_dirty(pte_mkdirty(pte_mkclean(pte)))); +@@ -70,6 +80,8 @@ static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot) + WARN_ON(pte_young(pte_mkold(pte_mkyoung(pte)))); + WARN_ON(pte_dirty(pte_mkclean(pte_mkdirty(pte)))); + WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte)))); ++ WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte)))); ++ WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte)))); + } + + static void __init pte_advanced_tests(struct mm_struct *mm, +@@ -137,6 +149,17 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) + return; + + pr_debug("Validating PMD basic\n"); ++ ++ /* ++ * This test needs to be executed after the given page table entry ++ * is created with pfn_pmd() to make sure that protection_map[idx] ++ * does not have the dirty bit enabled from the beginning. This is ++ * important for platforms like arm64 where (!PTE_RDONLY) indicate ++ * dirty bit being set. ++ */ ++ WARN_ON(pmd_dirty(pmd_wrprotect(pmd))); ++ ++ + WARN_ON(!pmd_same(pmd, pmd)); + WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd)))); + WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd)))); +@@ -144,6 +167,8 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) + WARN_ON(pmd_young(pmd_mkold(pmd_mkyoung(pmd)))); + WARN_ON(pmd_dirty(pmd_mkclean(pmd_mkdirty(pmd)))); + WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd)))); ++ WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd)))); ++ WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd)))); + /* + * A huge page does not point to next level page table + * entry. Hence this must qualify as pmd_bad(). +@@ -257,11 +282,25 @@ static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) + return; + + pr_debug("Validating PUD basic\n"); ++ ++ /* ++ * This test needs to be executed after the given page table entry ++ * is created with pfn_pud() to make sure that protection_map[idx] ++ * does not have the dirty bit enabled from the beginning. This is ++ * important for platforms like arm64 where (!PTE_RDONLY) indicate ++ * dirty bit being set. ++ */ ++ WARN_ON(pud_dirty(pud_wrprotect(pud))); ++ + WARN_ON(!pud_same(pud, pud)); + WARN_ON(!pud_young(pud_mkyoung(pud_mkold(pud)))); ++ WARN_ON(!pud_dirty(pud_mkdirty(pud_mkclean(pud)))); ++ WARN_ON(pud_dirty(pud_mkclean(pud_mkdirty(pud)))); + WARN_ON(!pud_write(pud_mkwrite(pud_wrprotect(pud)))); + WARN_ON(pud_write(pud_wrprotect(pud_mkwrite(pud)))); + WARN_ON(pud_young(pud_mkold(pud_mkyoung(pud)))); ++ WARN_ON(pud_dirty(pud_wrprotect(pud_mkclean(pud)))); ++ WARN_ON(!pud_dirty(pud_wrprotect(pud_mkdirty(pud)))); + + if (mm_pmd_folded(mm)) + return; +-- +2.30.2 + diff --git a/queue-5.10/mm-debug_vm_pgtable-basic-iterate-over-entire-protec.patch b/queue-5.10/mm-debug_vm_pgtable-basic-iterate-over-entire-protec.patch new file mode 100644 index 00000000000..9ef5ae01469 --- /dev/null +++ b/queue-5.10/mm-debug_vm_pgtable-basic-iterate-over-entire-protec.patch @@ -0,0 +1,174 @@ +From ffcd5061d5ad8d04ae2c0efdc96527b55f37a407 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Feb 2021 12:01:36 -0800 +Subject: mm/debug_vm_pgtable/basic: iterate over entire protection_map[] + +From: Anshuman Khandual + +[ Upstream commit 2e326c07bbe1eabeece4047ab5972ef34b15679b ] + +Currently the basic tests just validate various page table transformations +after starting with vm_get_page_prot(VM_READ|VM_WRITE|VM_EXEC) protection. +Instead scan over the entire protection_map[] for better coverage. It +also makes sure that all these basic page table tranformations checks hold +true irrespective of the starting protection value for the page table +entry. There is also a slight change in the debug print format for basic +tests to capture the protection value it is being tested with. The +modified output looks something like + +[pte_basic_tests ]: Validating PTE basic () +[pte_basic_tests ]: Validating PTE basic (read) +[pte_basic_tests ]: Validating PTE basic (write) +[pte_basic_tests ]: Validating PTE basic (read|write) +[pte_basic_tests ]: Validating PTE basic (exec) +[pte_basic_tests ]: Validating PTE basic (read|exec) +[pte_basic_tests ]: Validating PTE basic (write|exec) +[pte_basic_tests ]: Validating PTE basic (read|write|exec) +[pte_basic_tests ]: Validating PTE basic (shared) +[pte_basic_tests ]: Validating PTE basic (read|shared) +[pte_basic_tests ]: Validating PTE basic (write|shared) +[pte_basic_tests ]: Validating PTE basic (read|write|shared) +[pte_basic_tests ]: Validating PTE basic (exec|shared) +[pte_basic_tests ]: Validating PTE basic (read|exec|shared) +[pte_basic_tests ]: Validating PTE basic (write|exec|shared) +[pte_basic_tests ]: Validating PTE basic (read|write|exec|shared) + +This adds a missing argument 'struct mm_struct *' in pud_basic_tests() +test . This never got exposed before as PUD based THP is available only +on X86 platform where mm_pmd_folded(mm) call gets macro replaced without +requiring the mm_struct i.e __is_defined(__PAGETABLE_PMD_FOLDED). + +Link: https://lkml.kernel.org/r/1611137241-26220-3-git-send-email-anshuman.khandual@arm.com +Signed-off-by: Anshuman Khandual +Tested-by: Gerald Schaefer [s390] +Reviewed-by: Steven Price +Suggested-by: Catalin Marinas +Cc: Christophe Leroy +Cc: Gerald Schaefer +Cc: Paul Walmsley +Cc: Vineet Gupta +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/debug_vm_pgtable.c | 47 ++++++++++++++++++++++++++++++++----------- + 1 file changed, 35 insertions(+), 12 deletions(-) + +diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c +index 79480fd18443..726fd2030f64 100644 +--- a/mm/debug_vm_pgtable.c ++++ b/mm/debug_vm_pgtable.c +@@ -58,11 +58,13 @@ + #define RANDOM_ORVALUE (GENMASK(BITS_PER_LONG - 1, 0) & ~ARCH_SKIP_MASK) + #define RANDOM_NZVALUE GENMASK(7, 0) + +-static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot) ++static void __init pte_basic_tests(unsigned long pfn, int idx) + { ++ pgprot_t prot = protection_map[idx]; + pte_t pte = pfn_pte(pfn, prot); ++ unsigned long val = idx, *ptr = &val; + +- pr_debug("Validating PTE basic\n"); ++ pr_debug("Validating PTE basic (%pGv)\n", ptr); + + /* + * This test needs to be executed after the given page table entry +@@ -141,14 +143,16 @@ static void __init pte_savedwrite_tests(unsigned long pfn, pgprot_t prot) + } + + #ifdef CONFIG_TRANSPARENT_HUGEPAGE +-static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) ++static void __init pmd_basic_tests(unsigned long pfn, int idx) + { ++ pgprot_t prot = protection_map[idx]; + pmd_t pmd = pfn_pmd(pfn, prot); ++ unsigned long val = idx, *ptr = &val; + + if (!has_transparent_hugepage()) + return; + +- pr_debug("Validating PMD basic\n"); ++ pr_debug("Validating PMD basic (%pGv)\n", ptr); + + /* + * This test needs to be executed after the given page table entry +@@ -274,14 +278,16 @@ static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) + } + + #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD +-static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) ++static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx) + { ++ pgprot_t prot = protection_map[idx]; + pud_t pud = pfn_pud(pfn, prot); ++ unsigned long val = idx, *ptr = &val; + + if (!has_transparent_hugepage()) + return; + +- pr_debug("Validating PUD basic\n"); ++ pr_debug("Validating PUD basic (%pGv)\n", ptr); + + /* + * This test needs to be executed after the given page table entry +@@ -398,7 +404,7 @@ static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) + #endif /* !CONFIG_HAVE_ARCH_HUGE_VMAP */ + + #else /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ +-static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) { } ++static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx) { } + static void __init pud_advanced_tests(struct mm_struct *mm, + struct vm_area_struct *vma, pud_t *pudp, + unsigned long pfn, unsigned long vaddr, +@@ -411,8 +417,8 @@ static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) + } + #endif /* CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ + #else /* !CONFIG_TRANSPARENT_HUGEPAGE */ +-static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) { } +-static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) { } ++static void __init pmd_basic_tests(unsigned long pfn, int idx) { } ++static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx) { } + static void __init pmd_advanced_tests(struct mm_struct *mm, + struct vm_area_struct *vma, pmd_t *pmdp, + unsigned long pfn, unsigned long vaddr, +@@ -938,6 +944,7 @@ static int __init debug_vm_pgtable(void) + unsigned long vaddr, pte_aligned, pmd_aligned; + unsigned long pud_aligned, p4d_aligned, pgd_aligned; + spinlock_t *ptl = NULL; ++ int idx; + + pr_info("Validating architecture page table helpers\n"); + prot = vm_get_page_prot(VMFLAGS); +@@ -1002,9 +1009,25 @@ static int __init debug_vm_pgtable(void) + saved_pmdp = pmd_offset(pudp, 0UL); + saved_ptep = pmd_pgtable(pmd); + +- pte_basic_tests(pte_aligned, prot); +- pmd_basic_tests(pmd_aligned, prot); +- pud_basic_tests(pud_aligned, prot); ++ /* ++ * Iterate over the protection_map[] to make sure that all ++ * the basic page table transformation validations just hold ++ * true irrespective of the starting protection value for a ++ * given page table entry. ++ */ ++ for (idx = 0; idx < ARRAY_SIZE(protection_map); idx++) { ++ pte_basic_tests(pte_aligned, idx); ++ pmd_basic_tests(pmd_aligned, idx); ++ pud_basic_tests(mm, pud_aligned, idx); ++ } ++ ++ /* ++ * Both P4D and PGD level tests are very basic which do not ++ * involve creating page table entries from the protection ++ * value and the given pfn. Hence just keep them out from ++ * the above iteration for now to save some test execution ++ * time. ++ */ + p4d_basic_tests(p4d_aligned, prot); + pgd_basic_tests(pgd_aligned, prot); + +-- +2.30.2 + diff --git a/queue-5.10/mm-debug_vm_pgtable-ensure-thp-availability-via-has_.patch b/queue-5.10/mm-debug_vm_pgtable-ensure-thp-availability-via-has_.patch new file mode 100644 index 00000000000..42d70fc5044 --- /dev/null +++ b/queue-5.10/mm-debug_vm_pgtable-ensure-thp-availability-via-has_.patch @@ -0,0 +1,239 @@ +From 7262fe1d52e70ac76496befa5c3be57f79426b53 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:35:10 -0700 +Subject: mm/debug_vm_pgtable: ensure THP availability via + has_transparent_hugepage() + +From: Anshuman Khandual + +[ Upstream commit 65ac1a60a57e2c55f2ac37f27095f6b012295e81 ] + +On certain platforms, THP support could not just be validated via the +build option CONFIG_TRANSPARENT_HUGEPAGE. Instead +has_transparent_hugepage() also needs to be called upon to verify THP +runtime support. Otherwise the debug test will just run into unusable THP +helpers like in the case of a 4K hash config on powerpc platform [1]. +This just moves all pfn_pmd() and pfn_pud() after THP runtime validation +with has_transparent_hugepage() which prevents the mentioned problem. + +[1] https://bugzilla.kernel.org/show_bug.cgi?id=213069 + +Link: https://lkml.kernel.org/r/1621397588-19211-1-git-send-email-anshuman.khandual@arm.com +Fixes: 787d563b8642 ("mm/debug_vm_pgtable: fix kernel crash by checking for THP support") +Signed-off-by: Anshuman Khandual +Cc: Aneesh Kumar K.V +Cc: Christophe Leroy +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/debug_vm_pgtable.c | 63 ++++++++++++++++++++++++++++++++++--------- + 1 file changed, 51 insertions(+), 12 deletions(-) + +diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c +index 726fd2030f64..12ebc97e8b43 100644 +--- a/mm/debug_vm_pgtable.c ++++ b/mm/debug_vm_pgtable.c +@@ -146,13 +146,14 @@ static void __init pte_savedwrite_tests(unsigned long pfn, pgprot_t prot) + static void __init pmd_basic_tests(unsigned long pfn, int idx) + { + pgprot_t prot = protection_map[idx]; +- pmd_t pmd = pfn_pmd(pfn, prot); + unsigned long val = idx, *ptr = &val; ++ pmd_t pmd; + + if (!has_transparent_hugepage()) + return; + + pr_debug("Validating PMD basic (%pGv)\n", ptr); ++ pmd = pfn_pmd(pfn, prot); + + /* + * This test needs to be executed after the given page table entry +@@ -185,7 +186,7 @@ static void __init pmd_advanced_tests(struct mm_struct *mm, + unsigned long pfn, unsigned long vaddr, + pgprot_t prot, pgtable_t pgtable) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; + + if (!has_transparent_hugepage()) + return; +@@ -232,9 +233,14 @@ static void __init pmd_advanced_tests(struct mm_struct *mm, + + static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; ++ ++ if (!has_transparent_hugepage()) ++ return; + + pr_debug("Validating PMD leaf\n"); ++ pmd = pfn_pmd(pfn, prot); ++ + /* + * PMD based THP is a leaf entry. + */ +@@ -267,12 +273,16 @@ static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot) + + static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; + + if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) + return; + ++ if (!has_transparent_hugepage()) ++ return; ++ + pr_debug("Validating PMD saved write\n"); ++ pmd = pfn_pmd(pfn, prot); + WARN_ON(!pmd_savedwrite(pmd_mk_savedwrite(pmd_clear_savedwrite(pmd)))); + WARN_ON(pmd_savedwrite(pmd_clear_savedwrite(pmd_mk_savedwrite(pmd)))); + } +@@ -281,13 +291,14 @@ static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) + static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx) + { + pgprot_t prot = protection_map[idx]; +- pud_t pud = pfn_pud(pfn, prot); + unsigned long val = idx, *ptr = &val; ++ pud_t pud; + + if (!has_transparent_hugepage()) + return; + + pr_debug("Validating PUD basic (%pGv)\n", ptr); ++ pud = pfn_pud(pfn, prot); + + /* + * This test needs to be executed after the given page table entry +@@ -323,7 +334,7 @@ static void __init pud_advanced_tests(struct mm_struct *mm, + unsigned long pfn, unsigned long vaddr, + pgprot_t prot) + { +- pud_t pud = pfn_pud(pfn, prot); ++ pud_t pud; + + if (!has_transparent_hugepage()) + return; +@@ -332,6 +343,7 @@ static void __init pud_advanced_tests(struct mm_struct *mm, + /* Align the address wrt HPAGE_PUD_SIZE */ + vaddr &= HPAGE_PUD_MASK; + ++ pud = pfn_pud(pfn, prot); + set_pud_at(mm, vaddr, pudp, pud); + pudp_set_wrprotect(mm, vaddr, pudp); + pud = READ_ONCE(*pudp); +@@ -370,9 +382,13 @@ static void __init pud_advanced_tests(struct mm_struct *mm, + + static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot) + { +- pud_t pud = pfn_pud(pfn, prot); ++ pud_t pud; ++ ++ if (!has_transparent_hugepage()) ++ return; + + pr_debug("Validating PUD leaf\n"); ++ pud = pfn_pud(pfn, prot); + /* + * PUD based THP is a leaf entry. + */ +@@ -654,12 +670,16 @@ static void __init pte_protnone_tests(unsigned long pfn, pgprot_t prot) + #ifdef CONFIG_TRANSPARENT_HUGEPAGE + static void __init pmd_protnone_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); ++ pmd_t pmd; + + if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) + return; + ++ if (!has_transparent_hugepage()) ++ return; ++ + pr_debug("Validating PMD protnone\n"); ++ pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); + WARN_ON(!pmd_protnone(pmd)); + WARN_ON(!pmd_present(pmd)); + } +@@ -679,18 +699,26 @@ static void __init pte_devmap_tests(unsigned long pfn, pgprot_t prot) + #ifdef CONFIG_TRANSPARENT_HUGEPAGE + static void __init pmd_devmap_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; ++ ++ if (!has_transparent_hugepage()) ++ return; + + pr_debug("Validating PMD devmap\n"); ++ pmd = pfn_pmd(pfn, prot); + WARN_ON(!pmd_devmap(pmd_mkdevmap(pmd))); + } + + #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD + static void __init pud_devmap_tests(unsigned long pfn, pgprot_t prot) + { +- pud_t pud = pfn_pud(pfn, prot); ++ pud_t pud; ++ ++ if (!has_transparent_hugepage()) ++ return; + + pr_debug("Validating PUD devmap\n"); ++ pud = pfn_pud(pfn, prot); + WARN_ON(!pud_devmap(pud_mkdevmap(pud))); + } + #else /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ +@@ -733,25 +761,33 @@ static void __init pte_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot) + #ifdef CONFIG_TRANSPARENT_HUGEPAGE + static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; + + if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY)) + return; + ++ if (!has_transparent_hugepage()) ++ return; ++ + pr_debug("Validating PMD soft dirty\n"); ++ pmd = pfn_pmd(pfn, prot); + WARN_ON(!pmd_soft_dirty(pmd_mksoft_dirty(pmd))); + WARN_ON(pmd_soft_dirty(pmd_clear_soft_dirty(pmd))); + } + + static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot) + { +- pmd_t pmd = pfn_pmd(pfn, prot); ++ pmd_t pmd; + + if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY) || + !IS_ENABLED(CONFIG_ARCH_ENABLE_THP_MIGRATION)) + return; + ++ if (!has_transparent_hugepage()) ++ return; ++ + pr_debug("Validating PMD swap soft dirty\n"); ++ pmd = pfn_pmd(pfn, prot); + WARN_ON(!pmd_swp_soft_dirty(pmd_swp_mksoft_dirty(pmd))); + WARN_ON(pmd_swp_soft_dirty(pmd_swp_clear_soft_dirty(pmd))); + } +@@ -780,6 +816,9 @@ static void __init pmd_swap_tests(unsigned long pfn, pgprot_t prot) + swp_entry_t swp; + pmd_t pmd; + ++ if (!has_transparent_hugepage()) ++ return; ++ + pr_debug("Validating PMD swap\n"); + pmd = pfn_pmd(pfn, prot); + swp = __pmd_to_swp_entry(pmd); +-- +2.30.2 + diff --git a/queue-5.10/mm-huge_memory.c-add-missing-read-only-thp-checking-.patch b/queue-5.10/mm-huge_memory.c-add-missing-read-only-thp-checking-.patch new file mode 100644 index 00000000000..aeea05ac736 --- /dev/null +++ b/queue-5.10/mm-huge_memory.c-add-missing-read-only-thp-checking-.patch @@ -0,0 +1,229 @@ +From d84246f0852e6fe1e88c826bf58ac51df613b539 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:47:50 -0700 +Subject: mm/huge_memory.c: add missing read-only THP checking in + transparent_hugepage_enabled() + +From: Miaohe Lin + +[ Upstream commit e6be37b2e7bddfe0c76585ee7c7eee5acc8efeab ] + +Since commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for +(non-shmem) FS"), read-only THP file mapping is supported. But it forgot +to add checking for it in transparent_hugepage_enabled(). To fix it, we +add checking for read-only THP file mapping and also introduce helper +transhuge_vma_enabled() to check whether thp is enabled for specified vma +to reduce duplicated code. We rename transparent_hugepage_enabled to +transparent_hugepage_active to make the code easier to follow as suggested +by David Hildenbrand. + +[linmiaohe@huawei.com: define transhuge_vma_enabled next to transhuge_vma_suitable] + Link: https://lkml.kernel.org/r/20210514093007.4117906-1-linmiaohe@huawei.com + +Link: https://lkml.kernel.org/r/20210511134857.1581273-4-linmiaohe@huawei.com +Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") +Signed-off-by: Miaohe Lin +Reviewed-by: Yang Shi +Cc: Alexey Dobriyan +Cc: "Aneesh Kumar K . V" +Cc: Anshuman Khandual +Cc: David Hildenbrand +Cc: Hugh Dickins +Cc: Johannes Weiner +Cc: Kirill A. Shutemov +Cc: Matthew Wilcox +Cc: Minchan Kim +Cc: Ralph Campbell +Cc: Rik van Riel +Cc: Song Liu +Cc: William Kucharski +Cc: Zi Yan +Cc: Mike Kravetz +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + fs/proc/task_mmu.c | 2 +- + include/linux/huge_mm.h | 57 +++++++++++++++++++++++++---------------- + mm/huge_memory.c | 11 +++++++- + mm/khugepaged.c | 4 +-- + mm/shmem.c | 3 +-- + 5 files changed, 48 insertions(+), 29 deletions(-) + +diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c +index 3cec6fbef725..3931f60e421f 100644 +--- a/fs/proc/task_mmu.c ++++ b/fs/proc/task_mmu.c +@@ -829,7 +829,7 @@ static int show_smap(struct seq_file *m, void *v) + __show_smap(m, &mss, false); + + seq_printf(m, "THPeligible: %d\n", +- transparent_hugepage_enabled(vma)); ++ transparent_hugepage_active(vma)); + + if (arch_pkeys_enabled()) + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); +diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h +index bf37fbdaa59d..42dc994c8897 100644 +--- a/include/linux/huge_mm.h ++++ b/include/linux/huge_mm.h +@@ -124,9 +124,34 @@ extern struct kobj_attribute shmem_enabled_attr; + + extern unsigned long transparent_hugepage_flags; + ++static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, ++ unsigned long haddr) ++{ ++ /* Don't have to check pgoff for anonymous vma */ ++ if (!vma_is_anonymous(vma)) { ++ if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, ++ HPAGE_PMD_NR)) ++ return false; ++ } ++ ++ if (haddr < vma->vm_start || haddr + HPAGE_PMD_SIZE > vma->vm_end) ++ return false; ++ return true; ++} ++ ++static inline bool transhuge_vma_enabled(struct vm_area_struct *vma, ++ unsigned long vm_flags) ++{ ++ /* Explicitly disabled through madvise. */ ++ if ((vm_flags & VM_NOHUGEPAGE) || ++ test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) ++ return false; ++ return true; ++} ++ + /* + * to be used on vmas which are known to support THP. +- * Use transparent_hugepage_enabled otherwise ++ * Use transparent_hugepage_active otherwise + */ + static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + { +@@ -137,15 +162,12 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER_DAX)) + return false; + +- if (vma->vm_flags & VM_NOHUGEPAGE) ++ if (!transhuge_vma_enabled(vma, vma->vm_flags)) + return false; + + if (vma_is_temporary_stack(vma)) + return false; + +- if (test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) +- return false; +- + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_FLAG)) + return true; + +@@ -159,22 +181,7 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + return false; + } + +-bool transparent_hugepage_enabled(struct vm_area_struct *vma); +- +-static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, +- unsigned long haddr) +-{ +- /* Don't have to check pgoff for anonymous vma */ +- if (!vma_is_anonymous(vma)) { +- if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, +- HPAGE_PMD_NR)) +- return false; +- } +- +- if (haddr < vma->vm_start || haddr + HPAGE_PMD_SIZE > vma->vm_end) +- return false; +- return true; +-} ++bool transparent_hugepage_active(struct vm_area_struct *vma); + + #define transparent_hugepage_use_zero_page() \ + (transparent_hugepage_flags & \ +@@ -366,7 +373,7 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + return false; + } + +-static inline bool transparent_hugepage_enabled(struct vm_area_struct *vma) ++static inline bool transparent_hugepage_active(struct vm_area_struct *vma) + { + return false; + } +@@ -377,6 +384,12 @@ static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, + return false; + } + ++static inline bool transhuge_vma_enabled(struct vm_area_struct *vma, ++ unsigned long vm_flags) ++{ ++ return false; ++} ++ + static inline void prep_transhuge_page(struct page *page) {} + + static inline bool is_transparent_hugepage(struct page *page) +diff --git a/mm/huge_memory.c b/mm/huge_memory.c +index f1432d4d81c7..07c664c47a4f 100644 +--- a/mm/huge_memory.c ++++ b/mm/huge_memory.c +@@ -63,7 +63,14 @@ static atomic_t huge_zero_refcount; + struct page *huge_zero_page __read_mostly; + unsigned long huge_zero_pfn __read_mostly = ~0UL; + +-bool transparent_hugepage_enabled(struct vm_area_struct *vma) ++static inline bool file_thp_enabled(struct vm_area_struct *vma) ++{ ++ return transhuge_vma_enabled(vma, vma->vm_flags) && vma->vm_file && ++ !inode_is_open_for_write(vma->vm_file->f_inode) && ++ (vma->vm_flags & VM_EXEC); ++} ++ ++bool transparent_hugepage_active(struct vm_area_struct *vma) + { + /* The addr is used to check if the vma size fits */ + unsigned long addr = (vma->vm_end & HPAGE_PMD_MASK) - HPAGE_PMD_SIZE; +@@ -74,6 +81,8 @@ bool transparent_hugepage_enabled(struct vm_area_struct *vma) + return __transparent_hugepage_enabled(vma); + if (vma_is_shmem(vma)) + return shmem_huge_enabled(vma); ++ if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) ++ return file_thp_enabled(vma); + + return false; + } +diff --git a/mm/khugepaged.c b/mm/khugepaged.c +index a6238118ac4c..ee8812578563 100644 +--- a/mm/khugepaged.c ++++ b/mm/khugepaged.c +@@ -440,9 +440,7 @@ static inline int khugepaged_test_exit(struct mm_struct *mm) + static bool hugepage_vma_check(struct vm_area_struct *vma, + unsigned long vm_flags) + { +- /* Explicitly disabled through madvise. */ +- if ((vm_flags & VM_NOHUGEPAGE) || +- test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) ++ if (!transhuge_vma_enabled(vma, vm_flags)) + return false; + + /* Enabled via shmem mount options or sysfs settings. */ +diff --git a/mm/shmem.c b/mm/shmem.c +index a847cba3c226..96df61c8af65 100644 +--- a/mm/shmem.c ++++ b/mm/shmem.c +@@ -4092,8 +4092,7 @@ bool shmem_huge_enabled(struct vm_area_struct *vma) + loff_t i_size; + pgoff_t off; + +- if ((vma->vm_flags & VM_NOHUGEPAGE) || +- test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) ++ if (!transhuge_vma_enabled(vma, vma->vm_flags)) + return false; + if (shmem_huge == SHMEM_HUGE_FORCE) + return true; +-- +2.30.2 + diff --git a/queue-5.10/mm-huge_memory.c-don-t-discard-hugepage-if-other-pro.patch b/queue-5.10/mm-huge_memory.c-don-t-discard-hugepage-if-other-pro.patch new file mode 100644 index 00000000000..d7a0354186a --- /dev/null +++ b/queue-5.10/mm-huge_memory.c-don-t-discard-hugepage-if-other-pro.patch @@ -0,0 +1,58 @@ +From 4420a4b2add0cadcc6e485eef4ea0dd55e0622cc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:47:57 -0700 +Subject: mm/huge_memory.c: don't discard hugepage if other processes are + mapping it + +From: Miaohe Lin + +[ Upstream commit babbbdd08af98a59089334eb3effbed5a7a0cf7f ] + +If other processes are mapping any other subpages of the hugepage, i.e. +in pte-mapped thp case, page_mapcount() will return 1 incorrectly. Then +we would discard the page while other processes are still mapping it. Fix +it by using total_mapcount() which can tell whether other processes are +still mapping it. + +Link: https://lkml.kernel.org/r/20210511134857.1581273-6-linmiaohe@huawei.com +Fixes: b8d3c4c3009d ("mm/huge_memory.c: don't split THP page when MADV_FREE syscall is called") +Reviewed-by: Yang Shi +Signed-off-by: Miaohe Lin +Cc: Alexey Dobriyan +Cc: "Aneesh Kumar K . V" +Cc: Anshuman Khandual +Cc: David Hildenbrand +Cc: Hugh Dickins +Cc: Johannes Weiner +Cc: Kirill A. Shutemov +Cc: Matthew Wilcox +Cc: Minchan Kim +Cc: Ralph Campbell +Cc: Rik van Riel +Cc: Song Liu +Cc: William Kucharski +Cc: Zi Yan +Cc: Mike Kravetz +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/huge_memory.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mm/huge_memory.c b/mm/huge_memory.c +index 07c664c47a4f..9fe622ff2fc4 100644 +--- a/mm/huge_memory.c ++++ b/mm/huge_memory.c +@@ -1604,7 +1604,7 @@ bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, + * If other processes are mapping this page, we couldn't discard + * the page unless they all do MADV_FREE so let's skip the page. + */ +- if (page_mapcount(page) != 1) ++ if (total_mapcount(page) != 1) + goto out; + + if (!trylock_page(page)) +-- +2.30.2 + diff --git a/queue-5.10/mm-huge_memory.c-remove-dedicated-macro-hpage_cache_.patch b/queue-5.10/mm-huge_memory.c-remove-dedicated-macro-hpage_cache_.patch new file mode 100644 index 00000000000..f1c174fb0ee --- /dev/null +++ b/queue-5.10/mm-huge_memory.c-remove-dedicated-macro-hpage_cache_.patch @@ -0,0 +1,73 @@ +From 737fb40fc822b7a1fced218e6c23306494e533ce Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:47:43 -0700 +Subject: mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK + +From: Miaohe Lin + +[ Upstream commit b2bd53f18bb7f7cfc91b3bb527d7809376700a8e ] + +Patch series "Cleanup and fixup for huge_memory:, v3. + +This series contains cleanups to remove dedicated macro and remove +unnecessary tlb_remove_page_size() for huge zero pmd. Also this adds +missing read-only THP checking for transparent_hugepage_enabled() and +avoids discarding hugepage if other processes are mapping it. More +details can be found in the respective changelogs. + +Thi patch (of 5): + +Rewrite the pgoff checking logic to remove macro HPAGE_CACHE_INDEX_MASK +which is only used here to simplify the code. + +Link: https://lkml.kernel.org/r/20210511134857.1581273-1-linmiaohe@huawei.com +Link: https://lkml.kernel.org/r/20210511134857.1581273-2-linmiaohe@huawei.com +Signed-off-by: Miaohe Lin +Reviewed-by: Yang Shi +Reviewed-by: Anshuman Khandual +Reviewed-by: David Hildenbrand +Cc: Zi Yan +Cc: William Kucharski +Cc: Matthew Wilcox +Cc: "Aneesh Kumar K . V" +Cc: Ralph Campbell +Cc: Song Liu +Cc: Kirill A. Shutemov +Cc: Rik van Riel +Cc: Johannes Weiner +Cc: Minchan Kim +Cc: Hugh Dickins +Cc: Alexey Dobriyan +Cc: Mike Kravetz +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + include/linux/huge_mm.h | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h +index 10c7a80a0394..bf37fbdaa59d 100644 +--- a/include/linux/huge_mm.h ++++ b/include/linux/huge_mm.h +@@ -161,15 +161,13 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + + bool transparent_hugepage_enabled(struct vm_area_struct *vma); + +-#define HPAGE_CACHE_INDEX_MASK (HPAGE_PMD_NR - 1) +- + static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, + unsigned long haddr) + { + /* Don't have to check pgoff for anonymous vma */ + if (!vma_is_anonymous(vma)) { +- if (((vma->vm_start >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) != +- (vma->vm_pgoff & HPAGE_CACHE_INDEX_MASK)) ++ if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, ++ HPAGE_PMD_NR)) + return false; + } + +-- +2.30.2 + diff --git a/queue-5.10/mm-hugetlb-remove-redundant-check-in-preparing-and-d.patch b/queue-5.10/mm-hugetlb-remove-redundant-check-in-preparing-and-d.patch new file mode 100644 index 00000000000..f006a280d8b --- /dev/null +++ b/queue-5.10/mm-hugetlb-remove-redundant-check-in-preparing-and-d.patch @@ -0,0 +1,53 @@ +From f14859f2b6957326d7d44a9a7730c9bed49f5279 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Feb 2021 12:07:22 -0800 +Subject: mm/hugetlb: remove redundant check in preparing and destroying + gigantic page + +From: Yanfei Xu + +[ Upstream commit 5291c09b3edb657f23c1939750c702ba2d74932f ] + +Gigantic page is a compound page and its order is more than 1. Thus it +must be available for hpage_pincount. Let's remove the redundant check +for gigantic page. + +Link: https://lkml.kernel.org/r/20210202112002.73170-1-yanfei.xu@windriver.com +Signed-off-by: Yanfei Xu +Reviewed-by: Mike Kravetz +Reviewed-by: David Hildenbrand +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/hugetlb.c | 7 ++----- + 1 file changed, 2 insertions(+), 5 deletions(-) + +diff --git a/mm/hugetlb.c b/mm/hugetlb.c +index 991b5cd40267..f90dd909d017 100644 +--- a/mm/hugetlb.c ++++ b/mm/hugetlb.c +@@ -1252,8 +1252,7 @@ static void destroy_compound_gigantic_page(struct page *page, + struct page *p = page + 1; + + atomic_set(compound_mapcount_ptr(page), 0); +- if (hpage_pincount_available(page)) +- atomic_set(compound_pincount_ptr(page), 0); ++ atomic_set(compound_pincount_ptr(page), 0); + + for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) { + clear_compound_head(p); +@@ -1583,9 +1582,7 @@ static void prep_compound_gigantic_page(struct page *page, unsigned int order) + set_compound_head(p, page); + } + atomic_set(compound_mapcount_ptr(page), -1); +- +- if (hpage_pincount_available(page)) +- atomic_set(compound_pincount_ptr(page), 0); ++ atomic_set(compound_pincount_ptr(page), 0); + } + + /* +-- +2.30.2 + diff --git a/queue-5.10/mm-hugetlb-use-helper-huge_page_order-and-pages_per_.patch b/queue-5.10/mm-hugetlb-use-helper-huge_page_order-and-pages_per_.patch new file mode 100644 index 00000000000..26073aa4caa --- /dev/null +++ b/queue-5.10/mm-hugetlb-use-helper-huge_page_order-and-pages_per_.patch @@ -0,0 +1,50 @@ +From 98bab86b73d8536522b0ee181e6a916f973c7096 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Feb 2021 12:07:01 -0800 +Subject: mm/hugetlb: use helper huge_page_order and pages_per_huge_page + +From: Miaohe Lin + +[ Upstream commit c78a7f3639932c48b4e1d329fc80fd26aa1a2fa3 ] + +Since commit a5516438959d ("hugetlb: modular state for hugetlb page +size"), we can use huge_page_order to access hstate->order and +pages_per_huge_page to fetch the pages per huge page. But +gather_bootmem_prealloc() forgot to use it. + +Link: https://lkml.kernel.org/r/20210114114435.40075-1-linmiaohe@huawei.com +Signed-off-by: Miaohe Lin +Reviewed-by: David Hildenbrand +Reviewed-by: Mike Kravetz +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/hugetlb.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/mm/hugetlb.c b/mm/hugetlb.c +index d4f89c2f9544..991b5cd40267 100644 +--- a/mm/hugetlb.c ++++ b/mm/hugetlb.c +@@ -2500,7 +2500,7 @@ static void __init gather_bootmem_prealloc(void) + struct hstate *h = m->hstate; + + WARN_ON(page_count(page) != 1); +- prep_compound_huge_page(page, h->order); ++ prep_compound_huge_page(page, huge_page_order(h)); + WARN_ON(PageReserved(page)); + prep_new_huge_page(h, page, page_to_nid(page)); + put_page(page); /* free it into the hugepage allocator */ +@@ -2512,7 +2512,7 @@ static void __init gather_bootmem_prealloc(void) + * side-effects, like CommitLimit going negative. + */ + if (hstate_is_gigantic(h)) +- adjust_managed_page_count(page, 1 << h->order); ++ adjust_managed_page_count(page, pages_per_huge_page(h)); + cond_resched(); + } + } +-- +2.30.2 + diff --git a/queue-5.10/mm-memcg-slab-properly-set-up-gfp-flags-for-objcg-po.patch b/queue-5.10/mm-memcg-slab-properly-set-up-gfp-flags-for-objcg-po.patch new file mode 100644 index 00000000000..71ba5885db2 --- /dev/null +++ b/queue-5.10/mm-memcg-slab-properly-set-up-gfp-flags-for-objcg-po.patch @@ -0,0 +1,116 @@ +From f539baa0e667db9ccea81b5bc877314918ae8b46 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:37:34 -0700 +Subject: mm: memcg/slab: properly set up gfp flags for objcg pointer array + +From: Waiman Long + +[ Upstream commit 41eb5df1cbc9b302fc263ad7c9f38cfc38b4df61 ] + +Patch series "mm: memcg/slab: Fix objcg pointer array handling problem", v4. + +Since the merging of the new slab memory controller in v5.9, the page +structure stores a pointer to objcg pointer array for slab pages. When +the slab has no used objects, it can be freed in free_slab() which will +call kfree() to free the objcg pointer array in +memcg_alloc_page_obj_cgroups(). If it happens that the objcg pointer +array is the last used object in its slab, that slab may then be freed +which may caused kfree() to be called again. + +With the right workload, the slab cache may be set up in a way that allows +the recursive kfree() calling loop to nest deep enough to cause a kernel +stack overflow and panic the system. In fact, we have a reproducer that +can cause kernel stack overflow on a s390 system involving kmalloc-rcl-256 +and kmalloc-rcl-128 slabs with the following kfree() loop recursively +called 74 times: + + [ 285.520739] [<000000000ec432fc>] kfree+0x4bc/0x560 [ 285.520740] +[<000000000ec43466>] __free_slab+0xc6/0x228 [ 285.520741] +[<000000000ec41fc2>] __slab_free+0x3c2/0x3e0 [ 285.520742] +[<000000000ec432fc>] kfree+0x4bc/0x560 : While investigating this issue, I +also found an issue on the allocation side. If the objcg pointer array +happen to come from the same slab or a circular dependency linkage is +formed with multiple slabs, those affected slabs can never be freed again. + +This patch series addresses these two issues by introducing a new set of +kmalloc-cg- caches split from kmalloc- caches. The new set will +only contain non-reclaimable and non-dma objects that are accounted in +memory cgroups whereas the old set are now for unaccounted objects only. +By making this split, all the objcg pointer arrays will come from the +kmalloc- caches, but those caches will never hold any objcg pointer +array. As a result, deeply nested kfree() call and the unfreeable slab +problems are now gone. + +This patch (of 4): + +Since the merging of the new slab memory controller in v5.9, the page +structure may store a pointer to obj_cgroup pointer array for slab pages. +Currently, only the __GFP_ACCOUNT bit is masked off. However, the array +is not readily reclaimable and doesn't need to come from the DMA buffer. +So those GFP bits should be masked off as well. + +Do the flag bit clearing at memcg_alloc_page_obj_cgroups() to make sure +that it is consistently applied no matter where it is called. + +Link: https://lkml.kernel.org/r/20210505200610.13943-1-longman@redhat.com +Link: https://lkml.kernel.org/r/20210505200610.13943-2-longman@redhat.com +Fixes: 286e04b8ed7a ("mm: memcg/slab: allocate obj_cgroups for non-root slab pages") +Signed-off-by: Waiman Long +Reviewed-by: Shakeel Butt +Acked-by: Roman Gushchin +Reviewed-by: Vlastimil Babka +Cc: Johannes Weiner +Cc: Michal Hocko +Cc: Vladimir Davydov +Cc: Christoph Lameter +Cc: Pekka Enberg +Cc: David Rientjes +Cc: Joonsoo Kim +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/memcontrol.c | 8 ++++++++ + mm/slab.h | 1 - + 2 files changed, 8 insertions(+), 1 deletion(-) + +diff --git a/mm/memcontrol.c b/mm/memcontrol.c +index 8d9f5fa4c6d3..92bf987d0a41 100644 +--- a/mm/memcontrol.c ++++ b/mm/memcontrol.c +@@ -2898,12 +2898,20 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg) + } + + #ifdef CONFIG_MEMCG_KMEM ++/* ++ * The allocated objcg pointers array is not accounted directly. ++ * Moreover, it should not come from DMA buffer and is not readily ++ * reclaimable. So those GFP bits should be masked off. ++ */ ++#define OBJCGS_CLEAR_MASK (__GFP_DMA | __GFP_RECLAIMABLE | __GFP_ACCOUNT) ++ + int memcg_alloc_page_obj_cgroups(struct page *page, struct kmem_cache *s, + gfp_t gfp) + { + unsigned int objects = objs_per_slab_page(s, page); + void *vec; + ++ gfp &= ~OBJCGS_CLEAR_MASK; + vec = kcalloc_node(objects, sizeof(struct obj_cgroup *), gfp, + page_to_nid(page)); + if (!vec) +diff --git a/mm/slab.h b/mm/slab.h +index e258ffcfb0ef..944e8b2040ae 100644 +--- a/mm/slab.h ++++ b/mm/slab.h +@@ -326,7 +326,6 @@ static inline void memcg_slab_post_alloc_hook(struct kmem_cache *s, + if (!memcg_kmem_enabled() || !objcg) + return; + +- flags &= ~__GFP_ACCOUNT; + for (i = 0; i < size; i++) { + if (likely(p[i])) { + page = virt_to_head_page(p[i]); +-- +2.30.2 + diff --git a/queue-5.10/mm-page_alloc-fix-counting-of-managed_pages.patch b/queue-5.10/mm-page_alloc-fix-counting-of-managed_pages.patch new file mode 100644 index 00000000000..77e45083b30 --- /dev/null +++ b/queue-5.10/mm-page_alloc-fix-counting-of-managed_pages.patch @@ -0,0 +1,56 @@ +From b8fef203560c9d010799ff6499d09e9fdff7a203 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:42:33 -0700 +Subject: mm/page_alloc: fix counting of managed_pages + +From: Liu Shixin + +[ Upstream commit f7ec104458e00d27a190348ac3a513f3df3699a4 ] + +commit f63661566fad ("mm/page_alloc.c: clear out zone->lowmem_reserve[] if +the zone is empty") clears out zone->lowmem_reserve[] if zone is empty. +But when zone is not empty and sysctl_lowmem_reserve_ratio[i] is set to +zero, zone_managed_pages(zone) is not counted in the managed_pages either. +This is inconsistent with the description of lowmem_reserve, so fix it. + +Link: https://lkml.kernel.org/r/20210527125707.3760259-1-liushixin2@huawei.com +Fixes: f63661566fad ("mm/page_alloc.c: clear out zone->lowmem_reserve[] if the zone is empty") +Signed-off-by: Liu Shixin +Reported-by: yangerkun +Reviewed-by: Baoquan He +Acked-by: David Hildenbrand +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/page_alloc.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/mm/page_alloc.c b/mm/page_alloc.c +index f955610fb552..e30d88efd7fb 100644 +--- a/mm/page_alloc.c ++++ b/mm/page_alloc.c +@@ -7798,14 +7798,14 @@ static void setup_per_zone_lowmem_reserve(void) + unsigned long managed_pages = 0; + + for (j = i + 1; j < MAX_NR_ZONES; j++) { +- if (clear) { +- zone->lowmem_reserve[j] = 0; +- } else { +- struct zone *upper_zone = &pgdat->node_zones[j]; ++ struct zone *upper_zone = &pgdat->node_zones[j]; ++ ++ managed_pages += zone_managed_pages(upper_zone); + +- managed_pages += zone_managed_pages(upper_zone); ++ if (clear) ++ zone->lowmem_reserve[j] = 0; ++ else + zone->lowmem_reserve[j] = managed_pages / ratio; +- } + } + } + } +-- +2.30.2 + diff --git a/queue-5.10/mm-page_alloc-refactor-setup_per_zone_lowmem_reserve.patch b/queue-5.10/mm-page_alloc-refactor-setup_per_zone_lowmem_reserve.patch new file mode 100644 index 00000000000..4a7f792cb38 --- /dev/null +++ b/queue-5.10/mm-page_alloc-refactor-setup_per_zone_lowmem_reserve.patch @@ -0,0 +1,98 @@ +From 8626b4fe9311381a70c2e9ad4716b81ed4711b0e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Dec 2020 19:11:22 -0800 +Subject: mm: page_alloc: refactor setup_per_zone_lowmem_reserve() + +From: Lorenzo Stoakes + +[ Upstream commit 470c61d70299b1826f56ff5fede10786798e3c14 ] + +setup_per_zone_lowmem_reserve() iterates through each zone setting +zone->lowmem_reserve[j] = 0 (where j is the zone's index) then iterates +backwards through all preceding zones, setting +lower_zone->lowmem_reserve[j] = sum(managed pages of higher zones) / +lowmem_reserve_ratio[idx] for each (where idx is the lower zone's index). + +If the lower zone has no managed pages or its ratio is 0 then all of its +lowmem_reserve[] entries are effectively zeroed. + +As these arrays are only assigned here and all lowmem_reserve[] entries +for index < this zone's index are implicitly assumed to be 0 (as these are +specifically output in show_free_areas() and zoneinfo_show_print() for +example) there is no need to additionally zero index == this zone's index +too. This patch avoids zeroing unnecessarily. + +Rather than iterating through zones and setting lowmem_reserve[j] for each +lower zone this patch reverse the process and populates each zone's +lowmem_reserve[] values in ascending order. + +This clarifies what is going on especially in the case of zero managed +pages or ratio which is now explicitly shown to clear these values. + +Link: https://lkml.kernel.org/r/20201129162758.115907-1-lstoakes@gmail.com +Signed-off-by: Lorenzo Stoakes +Cc: Baoquan He +Cc: Michal Hocko +Cc: Nicholas Piggin +Cc: Vlastimil Babka +Cc: Roman Gushchin +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/page_alloc.c | 35 ++++++++++++++--------------------- + 1 file changed, 14 insertions(+), 21 deletions(-) + +diff --git a/mm/page_alloc.c b/mm/page_alloc.c +index 81cc7fdc9c8f..f955610fb552 100644 +--- a/mm/page_alloc.c ++++ b/mm/page_alloc.c +@@ -7788,31 +7788,24 @@ static void calculate_totalreserve_pages(void) + static void setup_per_zone_lowmem_reserve(void) + { + struct pglist_data *pgdat; +- enum zone_type j, idx; ++ enum zone_type i, j; + + for_each_online_pgdat(pgdat) { +- for (j = 0; j < MAX_NR_ZONES; j++) { +- struct zone *zone = pgdat->node_zones + j; +- unsigned long managed_pages = zone_managed_pages(zone); +- +- zone->lowmem_reserve[j] = 0; +- +- idx = j; +- while (idx) { +- struct zone *lower_zone; +- +- idx--; +- lower_zone = pgdat->node_zones + idx; +- +- if (!sysctl_lowmem_reserve_ratio[idx] || +- !zone_managed_pages(lower_zone)) { +- lower_zone->lowmem_reserve[j] = 0; +- continue; ++ for (i = 0; i < MAX_NR_ZONES - 1; i++) { ++ struct zone *zone = &pgdat->node_zones[i]; ++ int ratio = sysctl_lowmem_reserve_ratio[i]; ++ bool clear = !ratio || !zone_managed_pages(zone); ++ unsigned long managed_pages = 0; ++ ++ for (j = i + 1; j < MAX_NR_ZONES; j++) { ++ if (clear) { ++ zone->lowmem_reserve[j] = 0; + } else { +- lower_zone->lowmem_reserve[j] = +- managed_pages / sysctl_lowmem_reserve_ratio[idx]; ++ struct zone *upper_zone = &pgdat->node_zones[j]; ++ ++ managed_pages += zone_managed_pages(upper_zone); ++ zone->lowmem_reserve[j] = managed_pages / ratio; + } +- managed_pages += zone_managed_pages(lower_zone); + } + } + } +-- +2.30.2 + diff --git a/queue-5.10/mm-pmem-avoid-inserting-hugepage-pte-entry-with-fsda.patch b/queue-5.10/mm-pmem-avoid-inserting-hugepage-pte-entry-with-fsda.patch new file mode 100644 index 00000000000..baf0200507c --- /dev/null +++ b/queue-5.10/mm-pmem-avoid-inserting-hugepage-pte-entry-with-fsda.patch @@ -0,0 +1,101 @@ +From 38b040db2052c5a188e06eb91cd75891ba501eeb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Feb 2021 12:07:32 -0800 +Subject: mm/pmem: avoid inserting hugepage PTE entry with fsdax if hugepage + support is disabled + +From: Aneesh Kumar K.V + +[ Upstream commit bae84953815793f68ddd8edeadd3f4e32676a2c8 ] + +Differentiate between hardware not supporting hugepages and user disabling +THP via 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' + +For the devdax namespace, the kernel handles the above via the +supported_alignment attribute and failing to initialize the namespace if +the namespace align value is not supported on the platform. + +For the fsdax namespace, the kernel will continue to initialize the +namespace. This can result in the kernel creating a huge pte entry even +though the hardware don't support the same. + +We do want hugepage support with pmem even if the end-user disabled THP +via sysfs file (/sys/kernel/mm/transparent_hugepage/enabled). Hence +differentiate between hardware/firmware lacking support vs user-controlled +disable of THP and prevent a huge fault if the hardware lacks hugepage +support. + +Link: https://lkml.kernel.org/r/20210205023956.417587-1-aneesh.kumar@linux.ibm.com +Signed-off-by: Aneesh Kumar K.V +Reviewed-by: Dan Williams +Cc: "Kirill A . Shutemov" +Cc: Jan Kara +Cc: David Hildenbrand +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + include/linux/huge_mm.h | 15 +++++++++------ + mm/huge_memory.c | 6 +++++- + 2 files changed, 14 insertions(+), 7 deletions(-) + +diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h +index ff55be011739..10c7a80a0394 100644 +--- a/include/linux/huge_mm.h ++++ b/include/linux/huge_mm.h +@@ -84,6 +84,7 @@ static inline vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, + } + + enum transparent_hugepage_flag { ++ TRANSPARENT_HUGEPAGE_NEVER_DAX, + TRANSPARENT_HUGEPAGE_FLAG, + TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, +@@ -129,6 +130,13 @@ extern unsigned long transparent_hugepage_flags; + */ + static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + { ++ ++ /* ++ * If the hardware/firmware marked hugepage support disabled. ++ */ ++ if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER_DAX)) ++ return false; ++ + if (vma->vm_flags & VM_NOHUGEPAGE) + return false; + +@@ -140,12 +148,7 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) + + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_FLAG)) + return true; +- /* +- * For dax vmas, try to always use hugepage mappings. If the kernel does +- * not support hugepages, fsdax mappings will fallback to PAGE_SIZE +- * mappings, and device-dax namespaces, that try to guarantee a given +- * mapping size, will fail to enable +- */ ++ + if (vma_is_dax(vma)) + return true; + +diff --git a/mm/huge_memory.c b/mm/huge_memory.c +index 6301ecc1f679..f1432d4d81c7 100644 +--- a/mm/huge_memory.c ++++ b/mm/huge_memory.c +@@ -375,7 +375,11 @@ static int __init hugepage_init(void) + struct kobject *hugepage_kobj; + + if (!has_transparent_hugepage()) { +- transparent_hugepage_flags = 0; ++ /* ++ * Hardware doesn't support hugepages, hence disable ++ * DAX PMD support. ++ */ ++ transparent_hugepage_flags = 1 << TRANSPARENT_HUGEPAGE_NEVER_DAX; + return -EINVAL; + } + +-- +2.30.2 + diff --git a/queue-5.10/mm-shmem-fix-shmem_swapin-race-with-swapoff.patch b/queue-5.10/mm-shmem-fix-shmem_swapin-race-with-swapoff.patch new file mode 100644 index 00000000000..7cfc2c0bc01 --- /dev/null +++ b/queue-5.10/mm-shmem-fix-shmem_swapin-race-with-swapoff.patch @@ -0,0 +1,99 @@ +From 8360fcebe295a8db4f644cda5bbc4eb4c67b2ae4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:36:57 -0700 +Subject: mm/shmem: fix shmem_swapin() race with swapoff + +From: Miaohe Lin + +[ Upstream commit 2efa33fc7f6ec94a3a538c1a264273c889be2b36 ] + +When I was investigating the swap code, I found the below possible race +window: + +CPU 1 CPU 2 +----- ----- +shmem_swapin + swap_cluster_readahead + if (likely(si->flags & (SWP_BLKDEV | SWP_FS_OPS))) { + swapoff + .. + si->swap_file = NULL; + .. + struct inode *inode = si->swap_file->f_mapping->host;[oops!] + +Close this race window by using get/put_swap_device() to guard against +concurrent swapoff. + +Link: https://lkml.kernel.org/r/20210426123316.806267-5-linmiaohe@huawei.com +Fixes: 8fd2e0b505d1 ("mm: swap: check if swap backing device is congested or not") +Signed-off-by: Miaohe Lin +Reviewed-by: "Huang, Ying" +Cc: Dennis Zhou +Cc: Tim Chen +Cc: Hugh Dickins +Cc: Johannes Weiner +Cc: Michal Hocko +Cc: Joonsoo Kim +Cc: Alex Shi +Cc: Matthew Wilcox +Cc: Minchan Kim +Cc: Wei Yang +Cc: Yang Shi +Cc: David Hildenbrand +Cc: Yu Zhao +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/shmem.c | 14 +++++++++++++- + 1 file changed, 13 insertions(+), 1 deletion(-) + +diff --git a/mm/shmem.c b/mm/shmem.c +index 6e487bf555f9..a847cba3c226 100644 +--- a/mm/shmem.c ++++ b/mm/shmem.c +@@ -1698,7 +1698,8 @@ static int shmem_swapin_page(struct inode *inode, pgoff_t index, + struct address_space *mapping = inode->i_mapping; + struct shmem_inode_info *info = SHMEM_I(inode); + struct mm_struct *charge_mm = vma ? vma->vm_mm : current->mm; +- struct page *page; ++ struct swap_info_struct *si; ++ struct page *page = NULL; + swp_entry_t swap; + int error; + +@@ -1706,6 +1707,12 @@ static int shmem_swapin_page(struct inode *inode, pgoff_t index, + swap = radix_to_swp_entry(*pagep); + *pagep = NULL; + ++ /* Prevent swapoff from happening to us. */ ++ si = get_swap_device(swap); ++ if (!si) { ++ error = EINVAL; ++ goto failed; ++ } + /* Look it up and read it in.. */ + page = lookup_swap_cache(swap, NULL, 0); + if (!page) { +@@ -1767,6 +1774,8 @@ static int shmem_swapin_page(struct inode *inode, pgoff_t index, + swap_free(swap); + + *pagep = page; ++ if (si) ++ put_swap_device(si); + return 0; + failed: + if (!shmem_confirm_swap(mapping, index, swap)) +@@ -1777,6 +1786,9 @@ unlock: + put_page(page); + } + ++ if (si) ++ put_swap_device(si); ++ + return error; + } + +-- +2.30.2 + diff --git a/queue-5.10/mm-z3fold-fix-potential-memory-leak-in-z3fold_destro.patch b/queue-5.10/mm-z3fold-fix-potential-memory-leak-in-z3fold_destro.patch new file mode 100644 index 00000000000..283533fa5c2 --- /dev/null +++ b/queue-5.10/mm-z3fold-fix-potential-memory-leak-in-z3fold_destro.patch @@ -0,0 +1,40 @@ +From 713125adb851ceaeb70c2c83d6b5022e0c8dc4af Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:50:36 -0700 +Subject: mm/z3fold: fix potential memory leak in z3fold_destroy_pool() + +From: Miaohe Lin + +[ Upstream commit dac0d1cfda56472378d330b1b76b9973557a7b1d ] + +There is a memory leak in z3fold_destroy_pool() as it forgets to +free_percpu pool->unbuddied. Call free_percpu for pool->unbuddied to fix +this issue. + +Link: https://lkml.kernel.org/r/20210619093151.1492174-6-linmiaohe@huawei.com +Fixes: d30561c56f41 ("z3fold: use per-cpu unbuddied lists") +Signed-off-by: Miaohe Lin +Reviewed-by: Vitaly Wool +Cc: Hillf Danton +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/z3fold.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/mm/z3fold.c b/mm/z3fold.c +index 8ae944eeb8e2..636a71c291bf 100644 +--- a/mm/z3fold.c ++++ b/mm/z3fold.c +@@ -1063,6 +1063,7 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool) + destroy_workqueue(pool->compact_wq); + destroy_workqueue(pool->release_wq); + z3fold_unregister_migration(pool); ++ free_percpu(pool->unbuddied); + kfree(pool); + } + +-- +2.30.2 + diff --git a/queue-5.10/mm-z3fold-use-release_z3fold_page_locked-to-release-.patch b/queue-5.10/mm-z3fold-use-release_z3fold_page_locked-to-release-.patch new file mode 100644 index 00000000000..91a0ba02ee9 --- /dev/null +++ b/queue-5.10/mm-z3fold-use-release_z3fold_page_locked-to-release-.patch @@ -0,0 +1,41 @@ +From a5116d048366d321844069564b85a11c1f4f3d19 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:50:39 -0700 +Subject: mm/z3fold: use release_z3fold_page_locked() to release locked z3fold + page + +From: Miaohe Lin + +[ Upstream commit 28473d91ff7f686d58047ff55f2fa98ab59114a4 ] + +We should use release_z3fold_page_locked() to release z3fold page when +it's locked, although it looks harmless to use release_z3fold_page() now. + +Link: https://lkml.kernel.org/r/20210619093151.1492174-7-linmiaohe@huawei.com +Fixes: dcf5aedb24f8 ("z3fold: stricter locking and more careful reclaim") +Signed-off-by: Miaohe Lin +Reviewed-by: Vitaly Wool +Cc: Hillf Danton +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + mm/z3fold.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mm/z3fold.c b/mm/z3fold.c +index 636a71c291bf..912ac9a64a15 100644 +--- a/mm/z3fold.c ++++ b/mm/z3fold.c +@@ -1387,7 +1387,7 @@ static int z3fold_reclaim_page(struct z3fold_pool *pool, unsigned int retries) + if (zhdr->foreign_handles || + test_and_set_bit(PAGE_CLAIMED, &page->private)) { + if (kref_put(&zhdr->refcount, +- release_z3fold_page)) ++ release_z3fold_page_locked)) + atomic64_dec(&pool->pages_nr); + else + z3fold_page_unlock(zhdr); +-- +2.30.2 + diff --git a/queue-5.10/mmc-sdhci-sprd-use-sdhci_sprd_writew.patch b/queue-5.10/mmc-sdhci-sprd-use-sdhci_sprd_writew.patch new file mode 100644 index 00000000000..d29f6a73cb8 --- /dev/null +++ b/queue-5.10/mmc-sdhci-sprd-use-sdhci_sprd_writew.patch @@ -0,0 +1,37 @@ +From cf93d71a3c7642c77716f790257c486e99d6ac11 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 11:54:03 +0200 +Subject: mmc: sdhci-sprd: use sdhci_sprd_writew + +From: Krzysztof Kozlowski + +[ Upstream commit 961470820021e6f9d74db4837bd6831a1a30341b ] + +The sdhci_sprd_writew() was defined by never used in sdhci_ops: + + drivers/mmc/host/sdhci-sprd.c:134:20: warning: unused function 'sdhci_sprd_writew' + +Reported-by: kernel test robot +Signed-off-by: Krzysztof Kozlowski +Link: https://lore.kernel.org/r/20210601095403.236007-2-krzysztof.kozlowski@canonical.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/mmc/host/sdhci-sprd.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c +index 19cbb6171b35..9cd8862e6cbd 100644 +--- a/drivers/mmc/host/sdhci-sprd.c ++++ b/drivers/mmc/host/sdhci-sprd.c +@@ -393,6 +393,7 @@ static void sdhci_sprd_request_done(struct sdhci_host *host, + static struct sdhci_ops sdhci_sprd_ops = { + .read_l = sdhci_sprd_readl, + .write_l = sdhci_sprd_writel, ++ .write_w = sdhci_sprd_writew, + .write_b = sdhci_sprd_writeb, + .set_clock = sdhci_sprd_set_clock, + .get_max_clock = sdhci_sprd_get_max_clock, +-- +2.30.2 + diff --git a/queue-5.10/mmc-usdhi6rol0-fix-error-return-code-in-usdhi6_probe.patch b/queue-5.10/mmc-usdhi6rol0-fix-error-return-code-in-usdhi6_probe.patch new file mode 100644 index 00000000000..8f91c546762 --- /dev/null +++ b/queue-5.10/mmc-usdhi6rol0-fix-error-return-code-in-usdhi6_probe.patch @@ -0,0 +1,37 @@ +From a30d1e047f1cafaeb4d3a40b4f270fc931c9dde5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 10:03:21 +0800 +Subject: mmc: usdhi6rol0: fix error return code in usdhi6_probe() + +From: Zhen Lei + +[ Upstream commit 2f9ae69e5267f53e89e296fccee291975a85f0eb ] + +Fix to return a negative error code from the error handling case instead +of 0, as done elsewhere in this function. + +Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Link: https://lore.kernel.org/r/20210508020321.1677-1-thunder.leizhen@huawei.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/mmc/host/usdhi6rol0.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c +index 615f3d008af1..b9b79b1089a0 100644 +--- a/drivers/mmc/host/usdhi6rol0.c ++++ b/drivers/mmc/host/usdhi6rol0.c +@@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev) + + version = usdhi6_read(host, USDHI6_VERSION); + if ((version & 0xfff) != 0xa0d) { ++ ret = -EPERM; + dev_err(dev, "Version not recognized %x\n", version); + goto e_clk_off; + } +-- +2.30.2 + diff --git a/queue-5.10/mmc-via-sdmmc-add-a-check-against-null-pointer-deref.patch b/queue-5.10/mmc-via-sdmmc-add-a-check-against-null-pointer-deref.patch new file mode 100644 index 00000000000..fa424db3406 --- /dev/null +++ b/queue-5.10/mmc-via-sdmmc-add-a-check-against-null-pointer-deref.patch @@ -0,0 +1,140 @@ +From 5ed310a1aae3e3f5420980f04c4a6cc81f23a84b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 13:33:20 +0000 +Subject: mmc: via-sdmmc: add a check against NULL pointer dereference + +From: Zheyu Ma + +[ Upstream commit 45c8ddd06c4b729c56a6083ab311bfbd9643f4a6 ] + +Before referencing 'host->data', the driver needs to check whether it is +null pointer, otherwise it will cause a null pointer reference. + +This log reveals it: + +[ 29.355199] BUG: kernel NULL pointer dereference, address: +0000000000000014 +[ 29.357323] #PF: supervisor write access in kernel mode +[ 29.357706] #PF: error_code(0x0002) - not-present page +[ 29.358088] PGD 0 P4D 0 +[ 29.358280] Oops: 0002 [#1] PREEMPT SMP PTI +[ 29.358595] CPU: 2 PID: 0 Comm: swapper/2 Not tainted 5.12.4- +g70e7f0549188-dirty #102 +[ 29.359164] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), +BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014 +[ 29.359978] RIP: 0010:via_sdc_isr+0x21f/0x410 +[ 29.360314] Code: ff ff e8 84 aa d0 fd 66 45 89 7e 28 66 41 f7 c4 00 +10 75 56 e8 72 aa d0 fd 66 41 f7 c4 00 c0 74 10 e8 65 aa d0 fd 48 8b 43 +18 40 14 ac ff ff ff e8 55 aa d0 fd 48 89 df e8 ad fb ff ff e9 77 +[ 29.361661] RSP: 0018:ffffc90000118e98 EFLAGS: 00010046 +[ 29.362042] RAX: 0000000000000000 RBX: ffff888107d77880 +RCX: 0000000000000000 +[ 29.362564] RDX: 0000000000000000 RSI: ffffffff835d20bb +RDI: 00000000ffffffff +[ 29.363085] RBP: ffffc90000118ed8 R08: 0000000000000001 +R09: 0000000000000001 +[ 29.363604] R10: 0000000000000000 R11: 0000000000000001 +R12: 0000000000008600 +[ 29.364128] R13: ffff888107d779c8 R14: ffffc90009c00200 +R15: 0000000000008000 +[ 29.364651] FS: 0000000000000000(0000) GS:ffff88817bc80000(0000) +knlGS:0000000000000000 +[ 29.365235] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 +[ 29.365655] CR2: 0000000000000014 CR3: 0000000005a2e000 +CR4: 00000000000006e0 +[ 29.366170] DR0: 0000000000000000 DR1: 0000000000000000 +DR2: 0000000000000000 +[ 29.366683] DR3: 0000000000000000 DR6: 00000000fffe0ff0 +DR7: 0000000000000400 +[ 29.367197] Call Trace: +[ 29.367381] +[ 29.367537] __handle_irq_event_percpu+0x53/0x3e0 +[ 29.367916] handle_irq_event_percpu+0x35/0x90 +[ 29.368247] handle_irq_event+0x39/0x60 +[ 29.368632] handle_fasteoi_irq+0xc2/0x1d0 +[ 29.368950] __common_interrupt+0x7f/0x150 +[ 29.369254] common_interrupt+0xb4/0xd0 +[ 29.369547] +[ 29.369708] asm_common_interrupt+0x1e/0x40 +[ 29.370016] RIP: 0010:native_safe_halt+0x17/0x20 +[ 29.370360] Code: 07 0f 00 2d db 80 43 00 f4 5d c3 0f 1f 84 00 00 00 +00 00 8b 05 c2 37 e5 01 55 48 89 e5 85 c0 7e 07 0f 00 2d bb 80 43 00 fb +f4 <5d> c3 cc cc cc cc cc cc cc 55 48 89 e5 e8 67 53 ff ff 8b 0d f9 91 +[ 29.371696] RSP: 0018:ffffc9000008fe90 EFLAGS: 00000246 +[ 29.372079] RAX: 0000000000000000 RBX: 0000000000000002 +RCX: 0000000000000000 +[ 29.372595] RDX: 0000000000000000 RSI: ffffffff854f67a4 +RDI: ffffffff85403406 +[ 29.373122] RBP: ffffc9000008fe90 R08: 0000000000000001 +R09: 0000000000000001 +[ 29.373646] R10: 0000000000000000 R11: 0000000000000001 +R12: ffffffff86009188 +[ 29.374160] R13: 0000000000000000 R14: 0000000000000000 +R15: ffff888100258000 +[ 29.374690] default_idle+0x9/0x10 +[ 29.374944] arch_cpu_idle+0xa/0x10 +[ 29.375198] default_idle_call+0x6e/0x250 +[ 29.375491] do_idle+0x1f0/0x2d0 +[ 29.375740] cpu_startup_entry+0x18/0x20 +[ 29.376034] start_secondary+0x11f/0x160 +[ 29.376328] secondary_startup_64_no_verify+0xb0/0xbb +[ 29.376705] Modules linked in: +[ 29.376939] Dumping ftrace buffer: +[ 29.377187] (ftrace buffer empty) +[ 29.377460] CR2: 0000000000000014 +[ 29.377712] ---[ end trace 51a473dffb618c47 ]--- +[ 29.378056] RIP: 0010:via_sdc_isr+0x21f/0x410 +[ 29.378380] Code: ff ff e8 84 aa d0 fd 66 45 89 7e 28 66 41 f7 c4 00 +10 75 56 e8 72 aa d0 fd 66 41 f7 c4 00 c0 74 10 e8 65 aa d0 fd 48 8b 43 +18 40 14 ac ff ff ff e8 55 aa d0 fd 48 89 df e8 ad fb ff ff e9 77 +[ 29.379714] RSP: 0018:ffffc90000118e98 EFLAGS: 00010046 +[ 29.380098] RAX: 0000000000000000 RBX: ffff888107d77880 +RCX: 0000000000000000 +[ 29.380614] RDX: 0000000000000000 RSI: ffffffff835d20bb +RDI: 00000000ffffffff +[ 29.381134] RBP: ffffc90000118ed8 R08: 0000000000000001 +R09: 0000000000000001 +[ 29.381653] R10: 0000000000000000 R11: 0000000000000001 +R12: 0000000000008600 +[ 29.382176] R13: ffff888107d779c8 R14: ffffc90009c00200 +R15: 0000000000008000 +[ 29.382697] FS: 0000000000000000(0000) GS:ffff88817bc80000(0000) +knlGS:0000000000000000 +[ 29.383277] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 +[ 29.383697] CR2: 0000000000000014 CR3: 0000000005a2e000 +CR4: 00000000000006e0 +[ 29.384223] DR0: 0000000000000000 DR1: 0000000000000000 +DR2: 0000000000000000 +[ 29.384736] DR3: 0000000000000000 DR6: 00000000fffe0ff0 +DR7: 0000000000000400 +[ 29.385260] Kernel panic - not syncing: Fatal exception in interrupt +[ 29.385882] Dumping ftrace buffer: +[ 29.386135] (ftrace buffer empty) +[ 29.386401] Kernel Offset: disabled +[ 29.386656] Rebooting in 1 seconds.. + +Signed-off-by: Zheyu Ma +Link: https://lore.kernel.org/r/1622727200-15808-1-git-send-email-zheyuma97@gmail.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/mmc/host/via-sdmmc.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c +index 9b755ea0fa03..f07c71db3caf 100644 +--- a/drivers/mmc/host/via-sdmmc.c ++++ b/drivers/mmc/host/via-sdmmc.c +@@ -857,6 +857,9 @@ static void via_sdc_data_isr(struct via_crdr_mmc_host *host, u16 intmask) + { + BUG_ON(intmask == 0); + ++ if (!host->data) ++ return; ++ + if (intmask & VIA_CRDR_SDSTS_DT) + host->data->error = -ETIMEDOUT; + else if (intmask & (VIA_CRDR_SDSTS_RC | VIA_CRDR_SDSTS_WC)) +-- +2.30.2 + diff --git a/queue-5.10/mptcp-fix-pr_debug-in-mptcp_token_new_connect.patch b/queue-5.10/mptcp-fix-pr_debug-in-mptcp_token_new_connect.patch new file mode 100644 index 00000000000..28aef15cf48 --- /dev/null +++ b/queue-5.10/mptcp-fix-pr_debug-in-mptcp_token_new_connect.patch @@ -0,0 +1,55 @@ +From bd6a97d3e79732a5c1ea64dd590c85f2cfec0e64 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 16:54:24 -0700 +Subject: mptcp: fix pr_debug in mptcp_token_new_connect + +From: Jianguo Wu + +[ Upstream commit 2f1af441fd5dd5caf0807bb19ce9bbf9325ce534 ] + +After commit 2c5ebd001d4f ("mptcp: refactor token container"), +pr_debug() is called before mptcp_crypto_key_gen_sha() in +mptcp_token_new_connect(), so the output local_key, token and +idsn are 0, like: + + MPTCP: ssk=00000000f6b3c4a2, local_key=0, token=0, idsn=0 + +Move pr_debug() after mptcp_crypto_key_gen_sha(). + +Fixes: 2c5ebd001d4f ("mptcp: refactor token container") +Acked-by: Paolo Abeni +Signed-off-by: Jianguo Wu +Signed-off-by: Mat Martineau +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/mptcp/token.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/net/mptcp/token.c b/net/mptcp/token.c +index feb4b9ffd462..0691a4883f3a 100644 +--- a/net/mptcp/token.c ++++ b/net/mptcp/token.c +@@ -156,9 +156,6 @@ int mptcp_token_new_connect(struct sock *sk) + int retries = TOKEN_MAX_RETRIES; + struct token_bucket *bucket; + +- pr_debug("ssk=%p, local_key=%llu, token=%u, idsn=%llu\n", +- sk, subflow->local_key, subflow->token, subflow->idsn); +- + again: + mptcp_crypto_key_gen_sha(&subflow->local_key, &subflow->token, + &subflow->idsn); +@@ -172,6 +169,9 @@ again: + goto again; + } + ++ pr_debug("ssk=%p, local_key=%llu, token=%u, idsn=%llu\n", ++ sk, subflow->local_key, subflow->token, subflow->idsn); ++ + WRITE_ONCE(msk->token, subflow->token); + __sk_nulls_add_node_rcu((struct sock *)msk, &bucket->msk_chain); + bucket->chain_len++; +-- +2.30.2 + diff --git a/queue-5.10/mptcp-generate-subflow-hmac-after-mptcp_finish_join.patch b/queue-5.10/mptcp-generate-subflow-hmac-after-mptcp_finish_join.patch new file mode 100644 index 00000000000..ca045ce59bb --- /dev/null +++ b/queue-5.10/mptcp-generate-subflow-hmac-after-mptcp_finish_join.patch @@ -0,0 +1,49 @@ +From c6e275b433f88cc6c29d82137bfb537fbd0174a0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 16:54:26 -0700 +Subject: mptcp: generate subflow hmac after mptcp_finish_join() + +From: Jianguo Wu + +[ Upstream commit 0a4d8e96e4fd687af92b961d5cdcea0fdbde05fe ] + +For outgoing subflow join, when recv SYNACK, in subflow_finish_connect(), +the mptcp_finish_join() may return false in some cases, and send a RESET +to remote, and no local hmac is required. +So generate subflow hmac after mptcp_finish_join(). + +Fixes: ec3edaa7ca6c ("mptcp: Add handling of outgoing MP_JOIN requests") +Signed-off-by: Jianguo Wu +Signed-off-by: Mat Martineau +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/mptcp/subflow.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c +index 851fb3d8c791..bba5696fee36 100644 +--- a/net/mptcp/subflow.c ++++ b/net/mptcp/subflow.c +@@ -338,15 +338,15 @@ static void subflow_finish_connect(struct sock *sk, const struct sk_buff *skb) + goto do_reset; + } + ++ if (!mptcp_finish_join(sk)) ++ goto do_reset; ++ + subflow_generate_hmac(subflow->local_key, subflow->remote_key, + subflow->local_nonce, + subflow->remote_nonce, + hmac); + memcpy(subflow->hmac, hmac, MPTCPOPT_HMAC_LEN); + +- if (!mptcp_finish_join(sk)) +- goto do_reset; +- + subflow->mp_join = 1; + MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINSYNACKRX); + } else if (mptcp_check_fallback(sk)) { +-- +2.30.2 + diff --git a/queue-5.10/mt76-fix-possible-null-pointer-dereference-in-mt76_t.patch b/queue-5.10/mt76-fix-possible-null-pointer-dereference-in-mt76_t.patch new file mode 100644 index 00000000000..7cae60e6d9e --- /dev/null +++ b/queue-5.10/mt76-fix-possible-null-pointer-dereference-in-mt76_t.patch @@ -0,0 +1,36 @@ +From f5ae9388d3c76640043c4dd4a64ebc9c8eed96e5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 27 Apr 2021 12:05:00 +0200 +Subject: mt76: fix possible NULL pointer dereference in mt76_tx + +From: Lorenzo Bianconi + +[ Upstream commit d7400a2f3e295b8cee692c7a66e10f60015a3c37 ] + +Even if this is not a real issue since mt76_tx is never run with wcid set +to NULL, fix a theoretical NULL pointer dereference in mt76_tx routine + +Fixes: db9f11d3433f7 ("mt76: store wcid tx rate info in one u32 reduce locking") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/tx.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c +index 44ef4bc7a46e..073c29eb2ed8 100644 +--- a/drivers/net/wireless/mediatek/mt76/tx.c ++++ b/drivers/net/wireless/mediatek/mt76/tx.c +@@ -278,7 +278,7 @@ mt76_tx(struct mt76_phy *phy, struct ieee80211_sta *sta, + skb_set_queue_mapping(skb, qid); + } + +- if (!(wcid->tx_info & MT_WCID_TX_INFO_SET)) ++ if (wcid && !(wcid->tx_info & MT_WCID_TX_INFO_SET)) + ieee80211_get_tx_rates(info->control.vif, sta, skb, + info->control.rates, 1); + +-- +2.30.2 + diff --git a/queue-5.10/mt76-mt7615-fix-null-pointer-dereference-in-tx_prepa.patch b/queue-5.10/mt76-mt7615-fix-null-pointer-dereference-in-tx_prepa.patch new file mode 100644 index 00000000000..a7183dcbbf1 --- /dev/null +++ b/queue-5.10/mt76-mt7615-fix-null-pointer-dereference-in-tx_prepa.patch @@ -0,0 +1,76 @@ +From 49cba71cf6a56336fa4fa8a8b5876569a50a8cb2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 27 Apr 2021 12:07:14 +0200 +Subject: mt76: mt7615: fix NULL pointer dereference in tx_prepare_skb() + +From: Lorenzo Bianconi + +[ Upstream commit 8d3cdc1bbb1d355f0ebef973175ae5fd74286feb ] + +Fix theoretical NULL pointer dereference in mt7615_tx_prepare_skb and +mt7663_usb_sdio_tx_prepare_skb routines. This issue has been identified +by code analysis. + +Fixes: 6aa4ed7927f11 ("mt76: mt7615: implement DMA support for MT7622") +Fixes: 4bb586bc33b98 ("mt76: mt7663u: sync probe sampling with rate configuration") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7615/pci_mac.c | 5 +++-- + drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c | 5 +++-- + 2 files changed, 6 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/pci_mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/pci_mac.c +index 4cf7c5d34325..490d55651de3 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7615/pci_mac.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7615/pci_mac.c +@@ -133,20 +133,21 @@ int mt7615_tx_prepare_skb(struct mt76_dev *mdev, void *txwi_ptr, + struct mt76_tx_info *tx_info) + { + struct mt7615_dev *dev = container_of(mdev, struct mt7615_dev, mt76); +- struct mt7615_sta *msta = container_of(wcid, struct mt7615_sta, wcid); + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(tx_info->skb); + struct ieee80211_key_conf *key = info->control.hw_key; + int pid, id; + u8 *txwi = (u8 *)txwi_ptr; + struct mt76_txwi_cache *t; ++ struct mt7615_sta *msta; + void *txp; + ++ msta = wcid ? container_of(wcid, struct mt7615_sta, wcid) : NULL; + if (!wcid) + wcid = &dev->mt76.global_wcid; + + pid = mt76_tx_status_skb_add(mdev, wcid, tx_info->skb); + +- if (info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE) { ++ if ((info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE) && msta) { + struct mt7615_phy *phy = &dev->phy; + + if ((info->hw_queue & MT_TX_HW_QUEUE_EXT_PHY) && mdev->phy2) +diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c b/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c +index 3b29a6d3dc64..18082b4ce7d3 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c +@@ -243,14 +243,15 @@ int mt7663_usb_sdio_tx_prepare_skb(struct mt76_dev *mdev, void *txwi_ptr, + struct ieee80211_sta *sta, + struct mt76_tx_info *tx_info) + { +- struct mt7615_sta *msta = container_of(wcid, struct mt7615_sta, wcid); + struct mt7615_dev *dev = container_of(mdev, struct mt7615_dev, mt76); + struct sk_buff *skb = tx_info->skb; + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); ++ struct mt7615_sta *msta; + int pad; + ++ msta = wcid ? container_of(wcid, struct mt7615_sta, wcid) : NULL; + if ((info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE) && +- !msta->rate_probe) { ++ msta && !msta->rate_probe) { + /* request to configure sampling rate */ + spin_lock_bh(&dev->mt76.lock); + mt7615_mac_set_rates(&dev->phy, msta, &info->control.rates[0], +-- +2.30.2 + diff --git a/queue-5.10/mtd-partitions-redboot-seek-fis-index-block-in-the-r.patch b/queue-5.10/mtd-partitions-redboot-seek-fis-index-block-in-the-r.patch new file mode 100644 index 00000000000..6efb5a3edff --- /dev/null +++ b/queue-5.10/mtd-partitions-redboot-seek-fis-index-block-in-the-r.patch @@ -0,0 +1,51 @@ +From 9a2596a3f1638e9fb87b39d493c9abc0705bca8d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 20 May 2021 11:48:50 +0000 +Subject: mtd: partitions: redboot: seek fis-index-block in the right node + +From: Corentin Labbe + +[ Upstream commit 237960880960863fb41888763d635b384cffb104 ] + +fis-index-block is seeked in the master node and not in the partitions node. +For following binding and current usage, the driver need to check the +partitions subnode. + +Fixes: c0e118c8a1a3 ("mtd: partitions: Add OF support to RedBoot partitions") +Signed-off-by: Corentin Labbe +Reviewed-by: Linus Walleij +Signed-off-by: Miquel Raynal +Link: https://lore.kernel.org/linux-mtd/20210520114851.1274609-1-clabbe@baylibre.com +Signed-off-by: Sasha Levin +--- + drivers/mtd/parsers/redboot.c | 7 ++++++- + 1 file changed, 6 insertions(+), 1 deletion(-) + +diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c +index 91146bdc4713..3ccd6363ee8c 100644 +--- a/drivers/mtd/parsers/redboot.c ++++ b/drivers/mtd/parsers/redboot.c +@@ -45,6 +45,7 @@ static inline int redboot_checksum(struct fis_image_desc *img) + static void parse_redboot_of(struct mtd_info *master) + { + struct device_node *np; ++ struct device_node *npart; + u32 dirblock; + int ret; + +@@ -52,7 +53,11 @@ static void parse_redboot_of(struct mtd_info *master) + if (!np) + return; + +- ret = of_property_read_u32(np, "fis-index-block", &dirblock); ++ npart = of_get_child_by_name(np, "partitions"); ++ if (!npart) ++ return; ++ ++ ret = of_property_read_u32(npart, "fis-index-block", &dirblock); + if (ret) + return; + +-- +2.30.2 + diff --git a/queue-5.10/mtd-rawnand-arasan-ensure-proper-configuration-for-t.patch b/queue-5.10/mtd-rawnand-arasan-ensure-proper-configuration-for-t.patch new file mode 100644 index 00000000000..8a47204cfd4 --- /dev/null +++ b/queue-5.10/mtd-rawnand-arasan-ensure-proper-configuration-for-t.patch @@ -0,0 +1,160 @@ +From f881f12b457c1e4ed960a6b0ac7298bf9dfa39f2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 11:32:41 +0200 +Subject: mtd: rawnand: arasan: Ensure proper configuration for the asserted + target + +From: Miquel Raynal + +[ Upstream commit b5437c7b682c9a505065b4ab4716cdc951dc3c7c ] + +The controller being always asserting one CS or the other, there is no +need to actually select the right target before doing a page read/write. +However, the anfc_select_target() helper actually also changes the +timing configuration and clock in the case were two different NAND chips +with different timing requirements would be used. In this situation, we +must ensure proper configuration of the controller by calling it. + +As a consequence of this change, the anfc_select_target() helper is +being moved earlier in the driver. + +Fixes: 88ffef1b65cf ("mtd: rawnand: arasan: Support the hardware BCH ECC engine") +Signed-off-by: Miquel Raynal +Link: https://lore.kernel.org/linux-mtd/20210526093242.183847-4-miquel.raynal@bootlin.com +Signed-off-by: Sasha Levin +--- + drivers/mtd/nand/raw/arasan-nand-controller.c | 90 ++++++++++++------- + 1 file changed, 57 insertions(+), 33 deletions(-) + +diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c +index fbb4ea751be8..0ee3192916d9 100644 +--- a/drivers/mtd/nand/raw/arasan-nand-controller.c ++++ b/drivers/mtd/nand/raw/arasan-nand-controller.c +@@ -272,6 +272,37 @@ static int anfc_pkt_len_config(unsigned int len, unsigned int *steps, + return 0; + } + ++static int anfc_select_target(struct nand_chip *chip, int target) ++{ ++ struct anand *anand = to_anand(chip); ++ struct arasan_nfc *nfc = to_anfc(chip->controller); ++ int ret; ++ ++ /* Update the controller timings and the potential ECC configuration */ ++ writel_relaxed(anand->timings, nfc->base + DATA_INTERFACE_REG); ++ ++ /* Update clock frequency */ ++ if (nfc->cur_clk != anand->clk) { ++ clk_disable_unprepare(nfc->controller_clk); ++ ret = clk_set_rate(nfc->controller_clk, anand->clk); ++ if (ret) { ++ dev_err(nfc->dev, "Failed to change clock rate\n"); ++ return ret; ++ } ++ ++ ret = clk_prepare_enable(nfc->controller_clk); ++ if (ret) { ++ dev_err(nfc->dev, ++ "Failed to re-enable the controller clock\n"); ++ return ret; ++ } ++ ++ nfc->cur_clk = anand->clk; ++ } ++ ++ return 0; ++} ++ + /* + * When using the embedded hardware ECC engine, the controller is in charge of + * feeding the engine with, first, the ECC residue present in the data array. +@@ -400,6 +431,18 @@ static int anfc_read_page_hw_ecc(struct nand_chip *chip, u8 *buf, + return 0; + } + ++static int anfc_sel_read_page_hw_ecc(struct nand_chip *chip, u8 *buf, ++ int oob_required, int page) ++{ ++ int ret; ++ ++ ret = anfc_select_target(chip, chip->cur_cs); ++ if (ret) ++ return ret; ++ ++ return anfc_read_page_hw_ecc(chip, buf, oob_required, page); ++}; ++ + static int anfc_write_page_hw_ecc(struct nand_chip *chip, const u8 *buf, + int oob_required, int page) + { +@@ -460,6 +503,18 @@ static int anfc_write_page_hw_ecc(struct nand_chip *chip, const u8 *buf, + return ret; + } + ++static int anfc_sel_write_page_hw_ecc(struct nand_chip *chip, const u8 *buf, ++ int oob_required, int page) ++{ ++ int ret; ++ ++ ret = anfc_select_target(chip, chip->cur_cs); ++ if (ret) ++ return ret; ++ ++ return anfc_write_page_hw_ecc(chip, buf, oob_required, page); ++}; ++ + /* NAND framework ->exec_op() hooks and related helpers */ + static int anfc_parse_instructions(struct nand_chip *chip, + const struct nand_subop *subop, +@@ -752,37 +807,6 @@ static const struct nand_op_parser anfc_op_parser = NAND_OP_PARSER( + NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)), + ); + +-static int anfc_select_target(struct nand_chip *chip, int target) +-{ +- struct anand *anand = to_anand(chip); +- struct arasan_nfc *nfc = to_anfc(chip->controller); +- int ret; +- +- /* Update the controller timings and the potential ECC configuration */ +- writel_relaxed(anand->timings, nfc->base + DATA_INTERFACE_REG); +- +- /* Update clock frequency */ +- if (nfc->cur_clk != anand->clk) { +- clk_disable_unprepare(nfc->controller_clk); +- ret = clk_set_rate(nfc->controller_clk, anand->clk); +- if (ret) { +- dev_err(nfc->dev, "Failed to change clock rate\n"); +- return ret; +- } +- +- ret = clk_prepare_enable(nfc->controller_clk); +- if (ret) { +- dev_err(nfc->dev, +- "Failed to re-enable the controller clock\n"); +- return ret; +- } +- +- nfc->cur_clk = anand->clk; +- } +- +- return 0; +-} +- + static int anfc_check_op(struct nand_chip *chip, + const struct nand_operation *op) + { +@@ -1006,8 +1030,8 @@ static int anfc_init_hw_ecc_controller(struct arasan_nfc *nfc, + if (!anand->bch) + return -EINVAL; + +- ecc->read_page = anfc_read_page_hw_ecc; +- ecc->write_page = anfc_write_page_hw_ecc; ++ ecc->read_page = anfc_sel_read_page_hw_ecc; ++ ecc->write_page = anfc_sel_write_page_hw_ecc; + + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/mtd-rawnand-marvell-add-missing-clk_disable_unprepar.patch b/queue-5.10/mtd-rawnand-marvell-add-missing-clk_disable_unprepar.patch new file mode 100644 index 00000000000..1ba4a304dc5 --- /dev/null +++ b/queue-5.10/mtd-rawnand-marvell-add-missing-clk_disable_unprepar.patch @@ -0,0 +1,41 @@ +From 42e7316357bb0ffe92de9e1fc188c20220bda23c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 20:58:14 +0800 +Subject: mtd: rawnand: marvell: add missing clk_disable_unprepare() on error + in marvell_nfc_resume() + +From: Yang Yingliang + +[ Upstream commit ae94c49527aa9bd3b563349adc4b5617747ca6bd ] + +Add clk_disable_unprepare() on error path in marvell_nfc_resume(). + +Fixes: bd9c3f9b3c00 ("mtd: rawnand: marvell: add suspend and resume hooks") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Signed-off-by: Miquel Raynal +Link: https://lore.kernel.org/linux-mtd/20210601125814.3260364-1-yangyingliang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/mtd/nand/raw/marvell_nand.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c +index f5ca2002d08e..d00c916f133b 100644 +--- a/drivers/mtd/nand/raw/marvell_nand.c ++++ b/drivers/mtd/nand/raw/marvell_nand.c +@@ -3036,8 +3036,10 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev) + return ret; + + ret = clk_prepare_enable(nfc->reg_clk); +- if (ret < 0) ++ if (ret < 0) { ++ clk_disable_unprepare(nfc->core_clk); + return ret; ++ } + + /* + * Reset nfc->selected_chip so the next command will cause the timing +-- +2.30.2 + diff --git a/queue-5.10/mwifiex-re-fix-for-unaligned-accesses.patch b/queue-5.10/mwifiex-re-fix-for-unaligned-accesses.patch new file mode 100644 index 00000000000..f8592939668 --- /dev/null +++ b/queue-5.10/mwifiex-re-fix-for-unaligned-accesses.patch @@ -0,0 +1,62 @@ +From 97ccfafbffd65fde2b2119ed95b9296ddae6f69f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 8 May 2021 00:07:55 +0200 +Subject: mwifiex: re-fix for unaligned accesses + +From: Arnd Bergmann + +[ Upstream commit 8f4e3d48bb50765ab27ae5bebed2595b20de80a1 ] + +A patch from 2017 changed some accesses to DMA memory to use +get_unaligned_le32() and similar interfaces, to avoid problems +with doing unaligned accesson uncached memory. + +However, the change in the mwifiex_pcie_alloc_sleep_cookie_buf() +function ended up changing the size of the access instead, +as it operates on a pointer to u8. + +Change this function back to actually access the entire 32 bits. +Note that the pointer is aligned by definition because it came +from dma_alloc_coherent(). + +Fixes: 92c70a958b0b ("mwifiex: fix for unaligned reads") +Acked-by: Kalle Valo +Signed-off-by: Arnd Bergmann +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/marvell/mwifiex/pcie.c | 10 ++++------ + 1 file changed, 4 insertions(+), 6 deletions(-) + +diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c +index 33cf952cc01d..b2de8d03c5fa 100644 +--- a/drivers/net/wireless/marvell/mwifiex/pcie.c ++++ b/drivers/net/wireless/marvell/mwifiex/pcie.c +@@ -1232,7 +1232,7 @@ static int mwifiex_pcie_delete_cmdrsp_buf(struct mwifiex_adapter *adapter) + static int mwifiex_pcie_alloc_sleep_cookie_buf(struct mwifiex_adapter *adapter) + { + struct pcie_service_card *card = adapter->card; +- u32 tmp; ++ u32 *cookie; + + card->sleep_cookie_vbase = dma_alloc_coherent(&card->dev->dev, + sizeof(u32), +@@ -1243,13 +1243,11 @@ static int mwifiex_pcie_alloc_sleep_cookie_buf(struct mwifiex_adapter *adapter) + "dma_alloc_coherent failed!\n"); + return -ENOMEM; + } ++ cookie = (u32 *)card->sleep_cookie_vbase; + /* Init val of Sleep Cookie */ +- tmp = FW_AWAKE_COOKIE; +- put_unaligned(tmp, card->sleep_cookie_vbase); ++ *cookie = FW_AWAKE_COOKIE; + +- mwifiex_dbg(adapter, INFO, +- "alloc_scook: sleep cookie=0x%x\n", +- get_unaligned(card->sleep_cookie_vbase)); ++ mwifiex_dbg(adapter, INFO, "alloc_scook: sleep cookie=0x%x\n", *cookie); + + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/net-atlantic-fix-the-macsec-key-length.patch b/queue-5.10/net-atlantic-fix-the-macsec-key-length.patch new file mode 100644 index 00000000000..9a6516f59e3 --- /dev/null +++ b/queue-5.10/net-atlantic-fix-the-macsec-key-length.patch @@ -0,0 +1,52 @@ +From 838ae7f96c139435a4c760d92906128b74502e9c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 11:38:30 +0200 +Subject: net: atlantic: fix the macsec key length + +From: Antoine Tenart + +[ Upstream commit d67fb4772d9a6cfd10f1109f0e7b1e6eb58c8e16 ] + +The key length used to store the macsec key was set to MACSEC_KEYID_LEN +(16), which is an issue as: +- This was never meant to be the key length. +- The key length can be > 16. + +Fix this by using MACSEC_MAX_KEY_LEN instead (the max length accepted in +uAPI). + +Fixes: 27736563ce32 ("net: atlantic: MACSec egress offload implementation") +Fixes: 9ff40a751a6f ("net: atlantic: MACSec ingress offload implementation") +Reported-by: Lior Nahmanson +Signed-off-by: Antoine Tenart +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/aquantia/atlantic/aq_macsec.h | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.h b/drivers/net/ethernet/aquantia/atlantic/aq_macsec.h +index f5fba8b8cdea..a47e2710487e 100644 +--- a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.h ++++ b/drivers/net/ethernet/aquantia/atlantic/aq_macsec.h +@@ -91,7 +91,7 @@ struct aq_macsec_txsc { + u32 hw_sc_idx; + unsigned long tx_sa_idx_busy; + const struct macsec_secy *sw_secy; +- u8 tx_sa_key[MACSEC_NUM_AN][MACSEC_KEYID_LEN]; ++ u8 tx_sa_key[MACSEC_NUM_AN][MACSEC_MAX_KEY_LEN]; + struct aq_macsec_tx_sc_stats stats; + struct aq_macsec_tx_sa_stats tx_sa_stats[MACSEC_NUM_AN]; + }; +@@ -101,7 +101,7 @@ struct aq_macsec_rxsc { + unsigned long rx_sa_idx_busy; + const struct macsec_secy *sw_secy; + const struct macsec_rx_sc *sw_rxsc; +- u8 rx_sa_key[MACSEC_NUM_AN][MACSEC_KEYID_LEN]; ++ u8 rx_sa_key[MACSEC_NUM_AN][MACSEC_MAX_KEY_LEN]; + struct aq_macsec_rx_sa_stats rx_sa_stats[MACSEC_NUM_AN]; + }; + +-- +2.30.2 + diff --git a/queue-5.10/net-bcmgenet-fix-attaching-to-pyh-failed-on-rpi-4b.patch b/queue-5.10/net-bcmgenet-fix-attaching-to-pyh-failed-on-rpi-4b.patch new file mode 100644 index 00000000000..fac555a0ab1 --- /dev/null +++ b/queue-5.10/net-bcmgenet-fix-attaching-to-pyh-failed-on-rpi-4b.patch @@ -0,0 +1,47 @@ +From 3eef5888c21f9fabda4112f3918e9a9224e5cf7c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 11:28:03 +0800 +Subject: net: bcmgenet: Fix attaching to PYH failed on RPi 4B + +From: Jian-Hong Pan + +[ Upstream commit b2ac9800cfe0f8da16abc4e74e003440361c112e ] + +The Broadcom UniMAC MDIO bus from mdio-bcm-unimac module comes too late. +So, GENET cannot find the ethernet PHY on UniMAC MDIO bus. This leads +GENET fail to attach the PHY as following log: + +bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000 +... +could not attach to PHY +bcmgenet fd580000.ethernet eth0: failed to connect to PHY +uart-pl011 fe201000.serial: no DMA platform data +libphy: bcmgenet MII bus: probed +... +unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus + +This patch adds the soft dependency to load mdio-bcm-unimac module +before genet module to avoid the issue. + +Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver") +Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=213485 +Signed-off-by: Jian-Hong Pan +Signed-off-by: Florian Fainelli +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/broadcom/genet/bcmgenet.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c +index fcca023f22e5..41f7f078cd27 100644 +--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c ++++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c +@@ -4296,3 +4296,4 @@ MODULE_AUTHOR("Broadcom Corporation"); + MODULE_DESCRIPTION("Broadcom GENET Ethernet controller driver"); + MODULE_ALIAS("platform:bcmgenet"); + MODULE_LICENSE("GPL"); ++MODULE_SOFTDEP("pre: mdio-bcm-unimac"); +-- +2.30.2 + diff --git a/queue-5.10/net-dsa-sja1105-fix-null-pointer-dereference-in-sja1.patch b/queue-5.10/net-dsa-sja1105-fix-null-pointer-dereference-in-sja1.patch new file mode 100644 index 00000000000..fd1ef8860c9 --- /dev/null +++ b/queue-5.10/net-dsa-sja1105-fix-null-pointer-dereference-in-sja1.patch @@ -0,0 +1,55 @@ +From ab81907d252633d08b2dbfe04780545adae348f7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 18:52:07 +0300 +Subject: net: dsa: sja1105: fix NULL pointer dereference in + sja1105_reload_cbs() + +From: Vladimir Oltean + +[ Upstream commit be7f62eebaff2f86c1467a2d33930a0a7a87675b ] + +priv->cbs is an array of priv->info->num_cbs_shapers elements of type +struct sja1105_cbs_entry which only get allocated if CONFIG_NET_SCH_CBS +is enabled. + +However, sja1105_reload_cbs() is called from sja1105_static_config_reload() +which in turn is called for any of the items in sja1105_reset_reasons, +therefore during the normal runtime of the driver and not just from a +code path which can be triggered by the tc-cbs offload. + +The sja1105_reload_cbs() function does not contain a check whether the +priv->cbs array is NULL or not, it just assumes it isn't and proceeds to +iterate through the credit-based shaper elements. This leads to a NULL +pointer dereference. + +The solution is to return success if the priv->cbs array has not been +allocated, since sja1105_reload_cbs() has nothing to do. + +Fixes: 4d7525085a9b ("net: dsa: sja1105: offload the Credit-Based Shaper qdisc") +Signed-off-by: Vladimir Oltean +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/dsa/sja1105/sja1105_main.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c +index e273b2bd82ba..82852c57cc0e 100644 +--- a/drivers/net/dsa/sja1105/sja1105_main.c ++++ b/drivers/net/dsa/sja1105/sja1105_main.c +@@ -1711,6 +1711,12 @@ static int sja1105_reload_cbs(struct sja1105_private *priv) + { + int rc = 0, i; + ++ /* The credit based shapers are only allocated if ++ * CONFIG_NET_SCH_CBS is enabled. ++ */ ++ if (!priv->cbs) ++ return 0; ++ + for (i = 0; i < priv->info->num_cbs_shapers; i++) { + struct sja1105_cbs_entry *cbs = &priv->cbs[i]; + +-- +2.30.2 + diff --git a/queue-5.10/net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch b/queue-5.10/net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch new file mode 100644 index 00000000000..c8e5729d08b --- /dev/null +++ b/queue-5.10/net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch @@ -0,0 +1,54 @@ +From 722f2b17b251a6b26f6f04054e858144f47c0a49 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 17:57:31 +0300 +Subject: net: ethernet: aeroflex: fix UAF in greth_of_remove + +From: Pavel Skripkin + +[ Upstream commit e3a5de6d81d8b2199935c7eb3f7d17a50a7075b7 ] + +static int greth_of_remove(struct platform_device *of_dev) +{ +... + struct greth_private *greth = netdev_priv(ndev); +... + unregister_netdev(ndev); + free_netdev(ndev); + + of_iounmap(&of_dev->resource[0], greth->regs, resource_size(&of_dev->resource[0])); +... +} + +greth is netdev private data, but it is used +after free_netdev(). It can cause use-after-free when accessing greth +pointer. So, fix it by moving free_netdev() after of_iounmap() +call. + +Fixes: d4c41139df6e ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver") +Signed-off-by: Pavel Skripkin +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/aeroflex/greth.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c +index 9c5891bbfe61..f4f50b3a472e 100644 +--- a/drivers/net/ethernet/aeroflex/greth.c ++++ b/drivers/net/ethernet/aeroflex/greth.c +@@ -1539,10 +1539,11 @@ static int greth_of_remove(struct platform_device *of_dev) + mdiobus_unregister(greth->mdio); + + unregister_netdev(ndev); +- free_netdev(ndev); + + of_iounmap(&of_dev->resource[0], greth->regs, resource_size(&of_dev->resource[0])); + ++ free_netdev(ndev); ++ + return 0; + } + +-- +2.30.2 + diff --git a/queue-5.10/net-ethernet-ezchip-fix-error-handling.patch b/queue-5.10/net-ethernet-ezchip-fix-error-handling.patch new file mode 100644 index 00000000000..ca981916ca2 --- /dev/null +++ b/queue-5.10/net-ethernet-ezchip-fix-error-handling.patch @@ -0,0 +1,44 @@ +From 207a58a12517fef31a09cf0785b760e666b39b05 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 19:14:47 +0300 +Subject: net: ethernet: ezchip: fix error handling + +From: Pavel Skripkin + +[ Upstream commit 0de449d599594f5472e00267d651615c7f2c6c1d ] + +As documented at drivers/base/platform.c for platform_get_irq: + + * Gets an IRQ for a platform device and prints an error message if finding the + * IRQ fails. Device drivers should check the return value for errors so as to + * not pass a negative integer value to the request_irq() APIs. + +So, the driver should check that platform_get_irq() return value +is _negative_, not that it's equal to zero, because -ENXIO (return +value from request_irq() if irq was not found) will +pass this check and it leads to passing negative irq to request_irq() + +Fixes: 0dd077093636 ("NET: Add ezchip ethernet driver") +Signed-off-by: Pavel Skripkin +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ezchip/nps_enet.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c +index 026a3ec19b6e..3d74401b4f10 100644 +--- a/drivers/net/ethernet/ezchip/nps_enet.c ++++ b/drivers/net/ethernet/ezchip/nps_enet.c +@@ -610,7 +610,7 @@ static s32 nps_enet_probe(struct platform_device *pdev) + + /* Get IRQ number */ + priv->irq = platform_get_irq(pdev, 0); +- if (!priv->irq) { ++ if (priv->irq < 0) { + dev_err(dev, "failed to retrieve value from device tree\n"); + err = -ENODEV; + goto out_netdev; +-- +2.30.2 + diff --git a/queue-5.10/net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch b/queue-5.10/net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch new file mode 100644 index 00000000000..fafb05af45b --- /dev/null +++ b/queue-5.10/net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch @@ -0,0 +1,39 @@ +From 2692246f443013745aeca2b4efaf76d1e3fefd98 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 19:14:31 +0300 +Subject: net: ethernet: ezchip: fix UAF in nps_enet_remove + +From: Pavel Skripkin + +[ Upstream commit e4b8700e07a86e8eab6916aa5c5ba99042c34089 ] + +priv is netdev private data, but it is used +after free_netdev(). It can cause use-after-free when accessing priv +pointer. So, fix it by moving free_netdev() after netif_napi_del() +call. + +Fixes: 0dd077093636 ("NET: Add ezchip ethernet driver") +Signed-off-by: Pavel Skripkin +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ezchip/nps_enet.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c +index 815fb62c4b02..026a3ec19b6e 100644 +--- a/drivers/net/ethernet/ezchip/nps_enet.c ++++ b/drivers/net/ethernet/ezchip/nps_enet.c +@@ -645,8 +645,8 @@ static s32 nps_enet_remove(struct platform_device *pdev) + struct nps_enet_priv *priv = netdev_priv(ndev); + + unregister_netdev(ndev); +- free_netdev(ndev); + netif_napi_del(&priv->napi); ++ free_netdev(ndev); + + return 0; + } +-- +2.30.2 + diff --git a/queue-5.10/net-ftgmac100-add-missing-error-return-code-in-ftgma.patch b/queue-5.10/net-ftgmac100-add-missing-error-return-code-in-ftgma.patch new file mode 100644 index 00000000000..638ab07a1ee --- /dev/null +++ b/queue-5.10/net-ftgmac100-add-missing-error-return-code-in-ftgma.patch @@ -0,0 +1,57 @@ +From c63b5000bd82b04bb0e29512a6c2d926a7ae7cdd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 22 May 2021 20:02:46 +0800 +Subject: net: ftgmac100: add missing error return code in ftgmac100_probe() + +From: Yang Yingliang + +[ Upstream commit 52af13a41489d7bbc1932d17583eff6e5fffc820 ] + +The variables will be free on path err_phy_connect, it should +return error code, or it will cause double free when calling +ftgmac100_remove(). + +Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode") +Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/faraday/ftgmac100.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c +index c9c380c50879..5bc11d1bb9df 100644 +--- a/drivers/net/ethernet/faraday/ftgmac100.c ++++ b/drivers/net/ethernet/faraday/ftgmac100.c +@@ -1831,14 +1831,17 @@ static int ftgmac100_probe(struct platform_device *pdev) + if (np && of_get_property(np, "use-ncsi", NULL)) { + if (!IS_ENABLED(CONFIG_NET_NCSI)) { + dev_err(&pdev->dev, "NCSI stack not enabled\n"); ++ err = -EINVAL; + goto err_ncsi_dev; + } + + dev_info(&pdev->dev, "Using NCSI interface\n"); + priv->use_ncsi = true; + priv->ndev = ncsi_register_dev(netdev, ftgmac100_ncsi_handler); +- if (!priv->ndev) ++ if (!priv->ndev) { ++ err = -EINVAL; + goto err_ncsi_dev; ++ } + } else if (np && of_get_property(np, "phy-handle", NULL)) { + struct phy_device *phy; + +@@ -1846,6 +1849,7 @@ static int ftgmac100_probe(struct platform_device *pdev) + &ftgmac100_adjust_link); + if (!phy) { + dev_err(&pdev->dev, "Failed to connect to phy\n"); ++ err = -EINVAL; + goto err_setup_mdio; + } + +-- +2.30.2 + diff --git a/queue-5.10/net-ipv4-swap-flow-ports-when-validating-source.patch b/queue-5.10/net-ipv4-swap-flow-ports-when-validating-source.patch new file mode 100644 index 00000000000..502efe4368f --- /dev/null +++ b/queue-5.10/net-ipv4-swap-flow-ports-when-validating-source.patch @@ -0,0 +1,39 @@ +From ea9b61cc020359b7b81d80504f3d6959090cb3d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 12:24:50 +0800 +Subject: net/ipv4: swap flow ports when validating source + +From: Miao Wang + +[ Upstream commit c69f114d09891adfa3e301a35d9e872b8b7b5a50 ] + +When doing source address validation, the flowi4 struct used for +fib_lookup should be in the reverse direction to the given skb. +fl4_dport and fl4_sport returned by fib4_rules_early_flow_dissect +should thus be swapped. + +Fixes: 5a847a6e1477 ("net/ipv4: Initialize proto and ports in flow struct") +Signed-off-by: Miao Wang +Reviewed-by: David Ahern +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv4/fib_frontend.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c +index 84bb707bd88d..647bceab56c2 100644 +--- a/net/ipv4/fib_frontend.c ++++ b/net/ipv4/fib_frontend.c +@@ -371,6 +371,8 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst, + fl4.flowi4_proto = 0; + fl4.fl4_sport = 0; + fl4.fl4_dport = 0; ++ } else { ++ swap(fl4.fl4_sport, fl4.fl4_dport); + } + + if (fib_lookup(net, &fl4, &res, 0)) +-- +2.30.2 + diff --git a/queue-5.10/net-lwtunnel-handle-mtu-calculation-in-forwading.patch b/queue-5.10/net-lwtunnel-handle-mtu-calculation-in-forwading.patch new file mode 100644 index 00000000000..e855aa63427 --- /dev/null +++ b/queue-5.10/net-lwtunnel-handle-mtu-calculation-in-forwading.patch @@ -0,0 +1,142 @@ +From ebf5c89b567f46df87dd665aa829e49345702e9b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 19:21:39 +0300 +Subject: net: lwtunnel: handle MTU calculation in forwading + +From: Vadim Fedorenko + +[ Upstream commit fade56410c22cacafb1be9f911a0afd3701d8366 ] + +Commit 14972cbd34ff ("net: lwtunnel: Handle fragmentation") moved +fragmentation logic away from lwtunnel by carry encap headroom and +use it in output MTU calculation. But the forwarding part was not +covered and created difference in MTU for output and forwarding and +further to silent drops on ipv4 forwarding path. Fix it by taking +into account lwtunnel encap headroom. + +The same commit also introduced difference in how to treat RTAX_MTU +in IPv4 and IPv6 where latter explicitly removes lwtunnel encap +headroom from route MTU. Make IPv4 version do the same. + +Fixes: 14972cbd34ff ("net: lwtunnel: Handle fragmentation") +Suggested-by: David Ahern +Signed-off-by: Vadim Fedorenko +Reviewed-by: David Ahern +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/net/ip.h | 12 ++++++++---- + include/net/ip6_route.h | 16 ++++++++++++---- + net/ipv4/route.c | 3 ++- + 3 files changed, 22 insertions(+), 9 deletions(-) + +diff --git a/include/net/ip.h b/include/net/ip.h +index 2d6b985d11cc..5538e54d4620 100644 +--- a/include/net/ip.h ++++ b/include/net/ip.h +@@ -31,6 +31,7 @@ + #include + #include + #include ++#include + + #define IPV4_MAX_PMTU 65535U /* RFC 2675, Section 5.1 */ + #define IPV4_MIN_MTU 68 /* RFC 791 */ +@@ -445,22 +446,25 @@ static inline unsigned int ip_dst_mtu_maybe_forward(const struct dst_entry *dst, + + /* 'forwarding = true' case should always honour route mtu */ + mtu = dst_metric_raw(dst, RTAX_MTU); +- if (mtu) +- return mtu; ++ if (!mtu) ++ mtu = min(READ_ONCE(dst->dev->mtu), IP_MAX_MTU); + +- return min(READ_ONCE(dst->dev->mtu), IP_MAX_MTU); ++ return mtu - lwtunnel_headroom(dst->lwtstate, mtu); + } + + static inline unsigned int ip_skb_dst_mtu(struct sock *sk, + const struct sk_buff *skb) + { ++ unsigned int mtu; ++ + if (!sk || !sk_fullsock(sk) || ip_sk_use_pmtu(sk)) { + bool forwarding = IPCB(skb)->flags & IPSKB_FORWARDED; + + return ip_dst_mtu_maybe_forward(skb_dst(skb), forwarding); + } + +- return min(READ_ONCE(skb_dst(skb)->dev->mtu), IP_MAX_MTU); ++ mtu = min(READ_ONCE(skb_dst(skb)->dev->mtu), IP_MAX_MTU); ++ return mtu - lwtunnel_headroom(skb_dst(skb)->lwtstate, mtu); + } + + struct dst_metrics *ip_fib_metrics_init(struct net *net, struct nlattr *fc_mx, +diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h +index 2a5277758379..37a7fb1969d6 100644 +--- a/include/net/ip6_route.h ++++ b/include/net/ip6_route.h +@@ -264,11 +264,18 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb, + + static inline int ip6_skb_dst_mtu(struct sk_buff *skb) + { ++ int mtu; ++ + struct ipv6_pinfo *np = skb->sk && !dev_recursion_level() ? + inet6_sk(skb->sk) : NULL; + +- return (np && np->pmtudisc >= IPV6_PMTUDISC_PROBE) ? +- skb_dst(skb)->dev->mtu : dst_mtu(skb_dst(skb)); ++ if (np && np->pmtudisc >= IPV6_PMTUDISC_PROBE) { ++ mtu = READ_ONCE(skb_dst(skb)->dev->mtu); ++ mtu -= lwtunnel_headroom(skb_dst(skb)->lwtstate, mtu); ++ } else ++ mtu = dst_mtu(skb_dst(skb)); ++ ++ return mtu; + } + + static inline bool ip6_sk_accept_pmtu(const struct sock *sk) +@@ -316,7 +323,7 @@ static inline unsigned int ip6_dst_mtu_forward(const struct dst_entry *dst) + if (dst_metric_locked(dst, RTAX_MTU)) { + mtu = dst_metric_raw(dst, RTAX_MTU); + if (mtu) +- return mtu; ++ goto out; + } + + mtu = IPV6_MIN_MTU; +@@ -326,7 +333,8 @@ static inline unsigned int ip6_dst_mtu_forward(const struct dst_entry *dst) + mtu = idev->cnf.mtu6; + rcu_read_unlock(); + +- return mtu; ++out: ++ return mtu - lwtunnel_headroom(dst->lwtstate, mtu); + } + + u32 ip6_mtu_from_fib6(const struct fib6_result *res, +diff --git a/net/ipv4/route.c b/net/ipv4/route.c +index e968bb47d5bd..e15c1d8b7c8d 100644 +--- a/net/ipv4/route.c ++++ b/net/ipv4/route.c +@@ -1327,7 +1327,7 @@ static unsigned int ipv4_mtu(const struct dst_entry *dst) + mtu = dst_metric_raw(dst, RTAX_MTU); + + if (mtu) +- return mtu; ++ goto out; + + mtu = READ_ONCE(dst->dev->mtu); + +@@ -1336,6 +1336,7 @@ static unsigned int ipv4_mtu(const struct dst_entry *dst) + mtu = 576; + } + ++out: + mtu = min_t(unsigned int, mtu, IP_MAX_MTU); + + return mtu - lwtunnel_headroom(dst->lwtstate, mtu); +-- +2.30.2 + diff --git a/queue-5.10/net-macsec-fix-the-length-used-to-copy-the-key-for-o.patch b/queue-5.10/net-macsec-fix-the-length-used-to-copy-the-key-for-o.patch new file mode 100644 index 00000000000..5a2ba292365 --- /dev/null +++ b/queue-5.10/net-macsec-fix-the-length-used-to-copy-the-key-for-o.patch @@ -0,0 +1,65 @@ +From 5209346b7f95159d3f08ff748166bc7cd8d6b4b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 11:38:28 +0200 +Subject: net: macsec: fix the length used to copy the key for offloading + +From: Antoine Tenart + +[ Upstream commit 1f7fe5121127e037b86592ba42ce36515ea0e3f7 ] + +The key length used when offloading macsec to Ethernet or PHY drivers +was set to MACSEC_KEYID_LEN (16), which is an issue as: +- This was never meant to be the key length. +- The key length can be > 16. + +Fix this by using MACSEC_MAX_KEY_LEN to store the key (the max length +accepted in uAPI) and secy->key_len to copy it. + +Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure") +Reported-by: Lior Nahmanson +Signed-off-by: Antoine Tenart +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/macsec.c | 4 ++-- + include/net/macsec.h | 2 +- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c +index 11ca5fa902a1..c601d3df2722 100644 +--- a/drivers/net/macsec.c ++++ b/drivers/net/macsec.c +@@ -1818,7 +1818,7 @@ static int macsec_add_rxsa(struct sk_buff *skb, struct genl_info *info) + ctx.sa.rx_sa = rx_sa; + ctx.secy = secy; + memcpy(ctx.sa.key, nla_data(tb_sa[MACSEC_SA_ATTR_KEY]), +- MACSEC_KEYID_LEN); ++ secy->key_len); + + err = macsec_offload(ops->mdo_add_rxsa, &ctx); + if (err) +@@ -2060,7 +2060,7 @@ static int macsec_add_txsa(struct sk_buff *skb, struct genl_info *info) + ctx.sa.tx_sa = tx_sa; + ctx.secy = secy; + memcpy(ctx.sa.key, nla_data(tb_sa[MACSEC_SA_ATTR_KEY]), +- MACSEC_KEYID_LEN); ++ secy->key_len); + + err = macsec_offload(ops->mdo_add_txsa, &ctx); + if (err) +diff --git a/include/net/macsec.h b/include/net/macsec.h +index 52874cdfe226..d6fa6b97f6ef 100644 +--- a/include/net/macsec.h ++++ b/include/net/macsec.h +@@ -241,7 +241,7 @@ struct macsec_context { + struct macsec_rx_sc *rx_sc; + struct { + unsigned char assoc_num; +- u8 key[MACSEC_KEYID_LEN]; ++ u8 key[MACSEC_MAX_KEY_LEN]; + union { + struct macsec_rx_sa *rx_sa; + struct macsec_tx_sa *tx_sa; +-- +2.30.2 + diff --git a/queue-5.10/net-mvpp2-put-fwnode-in-error-case-during-probe.patch b/queue-5.10/net-mvpp2-put-fwnode-in-error-case-during-probe.patch new file mode 100644 index 00000000000..1cfbb58acf0 --- /dev/null +++ b/queue-5.10/net-mvpp2-put-fwnode-in-error-case-during-probe.patch @@ -0,0 +1,40 @@ +From f911713bb86d9a098bef6f3bb43e6e9803990957 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 12:58:05 +0300 +Subject: net: mvpp2: Put fwnode in error case during ->probe() + +From: Andy Shevchenko + +[ Upstream commit 71f0891c84dfdc448736082ab0a00acd29853896 ] + +In each iteration fwnode_for_each_available_child_node() bumps a reference +counting of a loop variable followed by dropping in on a next iteration, + +Since in error case the loop is broken, we have to drop a reference count +by ourselves. Do it for port_fwnode in error case during ->probe(). + +Fixes: 248122212f68 ("net: mvpp2: use device_*/fwnode_* APIs instead of of_*") +Cc: Marcin Wojtas +Signed-off-by: Andy Shevchenko +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +index 6aa13c9f9fc9..a9f65d667761 100644 +--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c ++++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +@@ -7045,6 +7045,8 @@ static int mvpp2_probe(struct platform_device *pdev) + return 0; + + err_port_probe: ++ fwnode_handle_put(port_fwnode); ++ + i = 0; + fwnode_for_each_available_child_node(fwnode, port_fwnode) { + if (priv->port_list[i]) +-- +2.30.2 + diff --git a/queue-5.10/net-pch_gbe-propagate-error-from-devm_gpio_request_o.patch b/queue-5.10/net-pch_gbe-propagate-error-from-devm_gpio_request_o.patch new file mode 100644 index 00000000000..a2df59e4efc --- /dev/null +++ b/queue-5.10/net-pch_gbe-propagate-error-from-devm_gpio_request_o.patch @@ -0,0 +1,56 @@ +From 17f9f52449b5f35c64ad8c4b2fd9d1822ee13dfa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 19:39:27 +0300 +Subject: net: pch_gbe: Propagate error from devm_gpio_request_one() + +From: Andy Shevchenko + +[ Upstream commit 9e3617a7b84512bf96c04f9cf82d1a7257d33794 ] + +If GPIO controller is not available yet we need to defer +the probe of GBE until provider will become available. + +While here, drop GPIOF_EXPORT because it's deprecated and +may not be available. + +Fixes: f1a26fdf5944 ("pch_gbe: Add MinnowBoard support") +Signed-off-by: Andy Shevchenko +Tested-by: Flavio Suligoi +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +index ade8c44c01cd..9a0870dc2f03 100644 +--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c ++++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +@@ -2536,9 +2536,13 @@ static int pch_gbe_probe(struct pci_dev *pdev, + adapter->pdev = pdev; + adapter->hw.back = adapter; + adapter->hw.reg = pcim_iomap_table(pdev)[PCH_GBE_PCI_BAR]; ++ + adapter->pdata = (struct pch_gbe_privdata *)pci_id->driver_data; +- if (adapter->pdata && adapter->pdata->platform_init) +- adapter->pdata->platform_init(pdev); ++ if (adapter->pdata && adapter->pdata->platform_init) { ++ ret = adapter->pdata->platform_init(pdev); ++ if (ret) ++ goto err_free_netdev; ++ } + + adapter->ptp_pdev = + pci_get_domain_bus_and_slot(pci_domain_nr(adapter->pdev->bus), +@@ -2633,7 +2637,7 @@ err_free_netdev: + */ + static int pch_gbe_minnow_platform_init(struct pci_dev *pdev) + { +- unsigned long flags = GPIOF_DIR_OUT | GPIOF_INIT_HIGH | GPIOF_EXPORT; ++ unsigned long flags = GPIOF_OUT_INIT_HIGH; + unsigned gpio = MINNOW_PHY_RESET_GPIO; + int ret; + +-- +2.30.2 + diff --git a/queue-5.10/net-phy-mscc-fix-macsec-key-length.patch b/queue-5.10/net-phy-mscc-fix-macsec-key-length.patch new file mode 100644 index 00000000000..30b0a76f351 --- /dev/null +++ b/queue-5.10/net-phy-mscc-fix-macsec-key-length.patch @@ -0,0 +1,56 @@ +From c8d484d150e6e1dfead592f8a682ff0e6d462fdf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 24 Jun 2021 11:38:29 +0200 +Subject: net: phy: mscc: fix macsec key length + +From: Antoine Tenart + +[ Upstream commit c309217f91f2d2097c2a0a832d9bff50b88c81dc ] + +The key length used to store the macsec key was set to MACSEC_KEYID_LEN +(16), which is an issue as: +- This was never meant to be the key length. +- The key length can be > 16. + +Fix this by using MACSEC_MAX_KEY_LEN instead (the max length accepted in +uAPI). + +Fixes: 28c5107aa904 ("net: phy: mscc: macsec support") +Reported-by: Lior Nahmanson +Signed-off-by: Antoine Tenart +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/phy/mscc/mscc_macsec.c | 2 +- + drivers/net/phy/mscc/mscc_macsec.h | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c +index 10be266e48e8..b7b2521c73fb 100644 +--- a/drivers/net/phy/mscc/mscc_macsec.c ++++ b/drivers/net/phy/mscc/mscc_macsec.c +@@ -501,7 +501,7 @@ static u32 vsc8584_macsec_flow_context_id(struct macsec_flow *flow) + } + + /* Derive the AES key to get a key for the hash autentication */ +-static int vsc8584_macsec_derive_key(const u8 key[MACSEC_KEYID_LEN], ++static int vsc8584_macsec_derive_key(const u8 key[MACSEC_MAX_KEY_LEN], + u16 key_len, u8 hkey[16]) + { + const u8 input[AES_BLOCK_SIZE] = {0}; +diff --git a/drivers/net/phy/mscc/mscc_macsec.h b/drivers/net/phy/mscc/mscc_macsec.h +index 9c6d25e36de2..453304bae778 100644 +--- a/drivers/net/phy/mscc/mscc_macsec.h ++++ b/drivers/net/phy/mscc/mscc_macsec.h +@@ -81,7 +81,7 @@ struct macsec_flow { + /* Highest takes precedence [0..15] */ + u8 priority; + +- u8 key[MACSEC_KEYID_LEN]; ++ u8 key[MACSEC_MAX_KEY_LEN]; + + union { + struct macsec_rx_sa *rx_sa; +-- +2.30.2 + diff --git a/queue-5.10/net-qrtr-ns-fix-error-return-code-in-qrtr_ns_init.patch b/queue-5.10/net-qrtr-ns-fix-error-return-code-in-qrtr_ns_init.patch new file mode 100644 index 00000000000..3bca8163b2a --- /dev/null +++ b/queue-5.10/net-qrtr-ns-fix-error-return-code-in-qrtr_ns_init.patch @@ -0,0 +1,41 @@ +From 1764aee61323649b39037f0e0132cf44df64a03f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 19 May 2021 15:58:52 +0000 +Subject: net: qrtr: ns: Fix error return code in qrtr_ns_init() + +From: Wei Yongjun + +[ Upstream commit a49e72b3bda73d36664a084e47da9727a31b8095 ] + +Fix to return a negative error code -ENOMEM from the error handling +case instead of 0, as done elsewhere in this function. + +Fixes: c6e08d6251f3 ("net: qrtr: Allocate workqueue before kernel_bind") +Reported-by: Hulk Robot +Signed-off-by: Wei Yongjun +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/qrtr/ns.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c +index b8559c882431..e760d4a38faf 100644 +--- a/net/qrtr/ns.c ++++ b/net/qrtr/ns.c +@@ -783,8 +783,10 @@ void qrtr_ns_init(void) + } + + qrtr_ns.workqueue = alloc_workqueue("qrtr_ns_handler", WQ_UNBOUND, 1); +- if (!qrtr_ns.workqueue) ++ if (!qrtr_ns.workqueue) { ++ ret = -ENOMEM; + goto err_sock; ++ } + + qrtr_ns.sock->sk->sk_data_ready = qrtr_ns_data_ready; + +-- +2.30.2 + diff --git a/queue-5.10/net-sched-act_vlan-fix-modify-to-allow-0.patch b/queue-5.10/net-sched-act_vlan-fix-modify-to-allow-0.patch new file mode 100644 index 00000000000..26cd54e0b44 --- /dev/null +++ b/queue-5.10/net-sched-act_vlan-fix-modify-to-allow-0.patch @@ -0,0 +1,95 @@ +From 96eb2dd53cccb2f2eb6bc468e457e2894799a523 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Jun 2021 15:30:50 +0300 +Subject: net/sched: act_vlan: Fix modify to allow 0 + +From: Boris Sukholitko + +[ Upstream commit 9c5eee0afca09cbde6bd00f77876754aaa552970 ] + +Currently vlan modification action checks existence of vlan priority by +comparing it to 0. Therefore it is impossible to modify existing vlan +tag to have priority 0. + +For example, the following tc command will change the vlan id but will +not affect vlan priority: + +tc filter add dev eth1 ingress matchall action vlan modify id 300 \ + priority 0 pipe mirred egress redirect dev eth2 + +The incoming packet on eth1: + +ethertype 802.1Q (0x8100), vlan 200, p 4, ethertype IPv4 + +will be changed to: + +ethertype 802.1Q (0x8100), vlan 300, p 4, ethertype IPv4 + +although the user has intended to have p == 0. + +The fix is to add tcfv_push_prio_exists flag to struct tcf_vlan_params +and rely on it when deciding to set the priority. + +Fixes: 45a497f2d149a4a8061c (net/sched: act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action) +Signed-off-by: Boris Sukholitko +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/net/tc_act/tc_vlan.h | 1 + + net/sched/act_vlan.c | 7 +++++-- + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h +index f051046ba034..f94b8bc26f9e 100644 +--- a/include/net/tc_act/tc_vlan.h ++++ b/include/net/tc_act/tc_vlan.h +@@ -16,6 +16,7 @@ struct tcf_vlan_params { + u16 tcfv_push_vid; + __be16 tcfv_push_proto; + u8 tcfv_push_prio; ++ bool tcfv_push_prio_exists; + struct rcu_head rcu; + }; + +diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c +index 1cac3c6fbb49..a108469c664f 100644 +--- a/net/sched/act_vlan.c ++++ b/net/sched/act_vlan.c +@@ -70,7 +70,7 @@ static int tcf_vlan_act(struct sk_buff *skb, const struct tc_action *a, + /* replace the vid */ + tci = (tci & ~VLAN_VID_MASK) | p->tcfv_push_vid; + /* replace prio bits, if tcfv_push_prio specified */ +- if (p->tcfv_push_prio) { ++ if (p->tcfv_push_prio_exists) { + tci &= ~VLAN_PRIO_MASK; + tci |= p->tcfv_push_prio << VLAN_PRIO_SHIFT; + } +@@ -121,6 +121,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla, + struct tc_action_net *tn = net_generic(net, vlan_net_id); + struct nlattr *tb[TCA_VLAN_MAX + 1]; + struct tcf_chain *goto_ch = NULL; ++ bool push_prio_exists = false; + struct tcf_vlan_params *p; + struct tc_vlan *parm; + struct tcf_vlan *v; +@@ -189,7 +190,8 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla, + push_proto = htons(ETH_P_8021Q); + } + +- if (tb[TCA_VLAN_PUSH_VLAN_PRIORITY]) ++ push_prio_exists = !!tb[TCA_VLAN_PUSH_VLAN_PRIORITY]; ++ if (push_prio_exists) + push_prio = nla_get_u8(tb[TCA_VLAN_PUSH_VLAN_PRIORITY]); + break; + case TCA_VLAN_ACT_POP_ETH: +@@ -241,6 +243,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla, + p->tcfv_action = action; + p->tcfv_push_vid = push_vid; + p->tcfv_push_prio = push_prio; ++ p->tcfv_push_prio_exists = push_prio_exists || action == TCA_VLAN_ACT_PUSH; + p->tcfv_push_proto = push_proto; + + if (action == TCA_VLAN_ACT_PUSH_ETH) { +-- +2.30.2 + diff --git a/queue-5.10/net-sched-add-barrier-to-ensure-correct-ordering-for.patch b/queue-5.10/net-sched-add-barrier-to-ensure-correct-ordering-for.patch new file mode 100644 index 00000000000..00592f614c8 --- /dev/null +++ b/queue-5.10/net-sched-add-barrier-to-ensure-correct-ordering-for.patch @@ -0,0 +1,68 @@ +From 5b3ff78f323f81225bf78ef27f805222ac5f0b40 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 09:04:14 +0800 +Subject: net: sched: add barrier to ensure correct ordering for lockless qdisc + +From: Yunsheng Lin + +[ Upstream commit 89837eb4b2463c556a123437f242d6c2bc62ce81 ] + +The spin_trylock() was assumed to contain the implicit +barrier needed to ensure the correct ordering between +STATE_MISSED setting/clearing and STATE_MISSED checking +in commit a90c57f2cedd ("net: sched: fix packet stuck +problem for lockless qdisc"). + +But it turns out that spin_trylock() only has load-acquire +semantic, for strongly-ordered system(like x86), the compiler +barrier implicitly contained in spin_trylock() seems enough +to ensure the correct ordering. But for weakly-orderly system +(like arm64), the store-release semantic is needed to ensure +the correct ordering as clear_bit() and test_bit() is store +operation, see queued_spin_lock(). + +So add the explicit barrier to ensure the correct ordering +for the above case. + +Fixes: a90c57f2cedd ("net: sched: fix packet stuck problem for lockless qdisc") +Signed-off-by: Yunsheng Lin +Acked-by: Jakub Kicinski +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/net/sch_generic.h | 12 ++++++++++++ + 1 file changed, 12 insertions(+) + +diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h +index 4dd2c9e34976..f8631ad3c868 100644 +--- a/include/net/sch_generic.h ++++ b/include/net/sch_generic.h +@@ -163,6 +163,12 @@ static inline bool qdisc_run_begin(struct Qdisc *qdisc) + if (spin_trylock(&qdisc->seqlock)) + goto nolock_empty; + ++ /* Paired with smp_mb__after_atomic() to make sure ++ * STATE_MISSED checking is synchronized with clearing ++ * in pfifo_fast_dequeue(). ++ */ ++ smp_mb__before_atomic(); ++ + /* If the MISSED flag is set, it means other thread has + * set the MISSED flag before second spin_trylock(), so + * we can return false here to avoid multi cpus doing +@@ -180,6 +186,12 @@ static inline bool qdisc_run_begin(struct Qdisc *qdisc) + */ + set_bit(__QDISC_STATE_MISSED, &qdisc->state); + ++ /* spin_trylock() only has load-acquire semantic, so use ++ * smp_mb__after_atomic() to ensure STATE_MISSED is set ++ * before doing the second spin_trylock(). ++ */ ++ smp_mb__after_atomic(); ++ + /* Retry again in case other CPU may not see the new flag + * after it releases the lock at the end of qdisc_run_end(). + */ +-- +2.30.2 + diff --git a/queue-5.10/net-sched-fix-warning-in-tcindex_alloc_perfect_hash.patch b/queue-5.10/net-sched-fix-warning-in-tcindex_alloc_perfect_hash.patch new file mode 100644 index 00000000000..95a193a8b81 --- /dev/null +++ b/queue-5.10/net-sched-fix-warning-in-tcindex_alloc_perfect_hash.patch @@ -0,0 +1,40 @@ +From ae0c0f48f0d638e1af40f9cfc8360f1d8f8e5683 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 23:23:48 +0300 +Subject: net: sched: fix warning in tcindex_alloc_perfect_hash + +From: Pavel Skripkin + +[ Upstream commit 3f2db250099f46988088800052cdf2332c7aba61 ] + +Syzbot reported warning in tcindex_alloc_perfect_hash. The problem +was in too big cp->hash, which triggers warning in kmalloc. Since +cp->hash comes from userspace, there is no need to warn if value +is not correct + +Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()") +Reported-and-tested-by: syzbot+1071ad60cd7df39fdadb@syzkaller.appspotmail.com +Signed-off-by: Pavel Skripkin +Acked-by: Cong Wang +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/sched/cls_tcindex.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c +index c4007b9cd16d..5b274534264c 100644 +--- a/net/sched/cls_tcindex.c ++++ b/net/sched/cls_tcindex.c +@@ -304,7 +304,7 @@ static int tcindex_alloc_perfect_hash(struct net *net, struct tcindex_data *cp) + int i, err = 0; + + cp->perfect = kcalloc(cp->hash, sizeof(struct tcindex_filter_result), +- GFP_KERNEL); ++ GFP_KERNEL | __GFP_NOWARN); + if (!cp->perfect) + return -ENOMEM; + +-- +2.30.2 + diff --git a/queue-5.10/net-ti-am65-cpsw-nuss-fix-crash-when-changing-number.patch b/queue-5.10/net-ti-am65-cpsw-nuss-fix-crash-when-changing-number.patch new file mode 100644 index 00000000000..45ec16d7fa5 --- /dev/null +++ b/queue-5.10/net-ti-am65-cpsw-nuss-fix-crash-when-changing-number.patch @@ -0,0 +1,93 @@ +From cd2c54ae0227ab3e07a09d1e2d46448eeba8aeb2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 20:08:57 +0530 +Subject: net: ti: am65-cpsw-nuss: Fix crash when changing number of TX queues + +From: Vignesh Raghavendra + +[ Upstream commit ce8eb4c728ef40b554b4f3d8963f11ed44502e00 ] + +When changing number of TX queues using ethtool: + + # ethtool -L eth0 tx 1 + [ 135.301047] Unable to handle kernel paging request at virtual address 00000000af5d0000 + [...] + [ 135.525128] Call trace: + [ 135.525142] dma_release_from_dev_coherent+0x2c/0xb0 + [ 135.525148] dma_free_attrs+0x54/0xe0 + [ 135.525156] k3_cppi_desc_pool_destroy+0x50/0xa0 + [ 135.525164] am65_cpsw_nuss_remove_tx_chns+0x88/0xdc + [ 135.525171] am65_cpsw_set_channels+0x3c/0x70 + [...] + +This is because k3_cppi_desc_pool_destroy() which is called after +k3_udma_glue_release_tx_chn() in am65_cpsw_nuss_remove_tx_chns() +references struct device that is unregistered at the end of +k3_udma_glue_release_tx_chn() + +Therefore the right order is to call k3_cppi_desc_pool_destroy() and +destroy desc pool before calling k3_udma_glue_release_tx_chn(). +Fix this throughout the driver. + +Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") +Signed-off-by: Vignesh Raghavendra +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ti/am65-cpsw-nuss.c | 18 +++++++++--------- + 1 file changed, 9 insertions(+), 9 deletions(-) + +diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c +index 501d676fd88b..0805edef5625 100644 +--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c ++++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c +@@ -1433,12 +1433,12 @@ static void am65_cpsw_nuss_free_tx_chns(void *data) + for (i = 0; i < common->tx_ch_num; i++) { + struct am65_cpsw_tx_chn *tx_chn = &common->tx_chns[i]; + +- if (!IS_ERR_OR_NULL(tx_chn->tx_chn)) +- k3_udma_glue_release_tx_chn(tx_chn->tx_chn); +- + if (!IS_ERR_OR_NULL(tx_chn->desc_pool)) + k3_cppi_desc_pool_destroy(tx_chn->desc_pool); + ++ if (!IS_ERR_OR_NULL(tx_chn->tx_chn)) ++ k3_udma_glue_release_tx_chn(tx_chn->tx_chn); ++ + memset(tx_chn, 0, sizeof(*tx_chn)); + } + } +@@ -1458,12 +1458,12 @@ void am65_cpsw_nuss_remove_tx_chns(struct am65_cpsw_common *common) + + netif_napi_del(&tx_chn->napi_tx); + +- if (!IS_ERR_OR_NULL(tx_chn->tx_chn)) +- k3_udma_glue_release_tx_chn(tx_chn->tx_chn); +- + if (!IS_ERR_OR_NULL(tx_chn->desc_pool)) + k3_cppi_desc_pool_destroy(tx_chn->desc_pool); + ++ if (!IS_ERR_OR_NULL(tx_chn->tx_chn)) ++ k3_udma_glue_release_tx_chn(tx_chn->tx_chn); ++ + memset(tx_chn, 0, sizeof(*tx_chn)); + } + } +@@ -1550,11 +1550,11 @@ static void am65_cpsw_nuss_free_rx_chns(void *data) + + rx_chn = &common->rx_chns; + +- if (!IS_ERR_OR_NULL(rx_chn->rx_chn)) +- k3_udma_glue_release_rx_chn(rx_chn->rx_chn); +- + if (!IS_ERR_OR_NULL(rx_chn->desc_pool)) + k3_cppi_desc_pool_destroy(rx_chn->desc_pool); ++ ++ if (!IS_ERR_OR_NULL(rx_chn->rx_chn)) ++ k3_udma_glue_release_rx_chn(rx_chn->rx_chn); + } + + static int am65_cpsw_nuss_init_rx_chns(struct am65_cpsw_common *common) +-- +2.30.2 + diff --git a/queue-5.10/net-tipc-fix-fb_mtu-eat-two-pages.patch b/queue-5.10/net-tipc-fix-fb_mtu-eat-two-pages.patch new file mode 100644 index 00000000000..915627f2193 --- /dev/null +++ b/queue-5.10/net-tipc-fix-fb_mtu-eat-two-pages.patch @@ -0,0 +1,118 @@ +From f466eb46a029021e2a49c9b5dc6d2e1666e46098 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 27 Jun 2021 23:37:44 -0700 +Subject: net: tipc: fix FB_MTU eat two pages + +From: Menglong Dong + +[ Upstream commit 0c6de0c943dbb42831bf7502eb5c007f71e752d2 ] + +FB_MTU is used in 'tipc_msg_build()' to alloc smaller skb when memory +allocation fails, which can avoid unnecessary sending failures. + +The value of FB_MTU now is 3744, and the data size will be: + + (3744 + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \ + SKB_DATA_ALIGN(BUF_HEADROOM + BUF_TAILROOM + 3)) + +which is larger than one page(4096), and two pages will be allocated. + +To avoid it, replace '3744' with a calculation: + + (PAGE_SIZE - SKB_DATA_ALIGN(BUF_OVERHEAD) - \ + SKB_DATA_ALIGN(sizeof(struct skb_shared_info))) + +What's more, alloc_skb_fclone() will call SKB_DATA_ALIGN for data size, +and it's not necessary to make alignment for buf_size in +tipc_buf_acquire(). So, just remove it. + +Fixes: 4c94cc2d3d57 ("tipc: fall back to smaller MTU if allocation of local send skb fails") +Signed-off-by: Menglong Dong +Acked-by: Jon Maloy +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/tipc/bcast.c | 2 +- + net/tipc/msg.c | 17 ++++++++--------- + net/tipc/msg.h | 3 ++- + 3 files changed, 11 insertions(+), 11 deletions(-) + +diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c +index d4beca895992..593846d25214 100644 +--- a/net/tipc/bcast.c ++++ b/net/tipc/bcast.c +@@ -699,7 +699,7 @@ int tipc_bcast_init(struct net *net) + spin_lock_init(&tipc_net(net)->bclock); + + if (!tipc_link_bc_create(net, 0, 0, NULL, +- FB_MTU, ++ one_page_mtu, + BCLINK_WIN_DEFAULT, + BCLINK_WIN_DEFAULT, + 0, +diff --git a/net/tipc/msg.c b/net/tipc/msg.c +index 88a3ed80094c..91dcf648d32b 100644 +--- a/net/tipc/msg.c ++++ b/net/tipc/msg.c +@@ -44,12 +44,15 @@ + #define MAX_FORWARD_SIZE 1024 + #ifdef CONFIG_TIPC_CRYPTO + #define BUF_HEADROOM ALIGN(((LL_MAX_HEADER + 48) + EHDR_MAX_SIZE), 16) +-#define BUF_TAILROOM (TIPC_AES_GCM_TAG_SIZE) ++#define BUF_OVERHEAD (BUF_HEADROOM + TIPC_AES_GCM_TAG_SIZE) + #else + #define BUF_HEADROOM (LL_MAX_HEADER + 48) +-#define BUF_TAILROOM 16 ++#define BUF_OVERHEAD BUF_HEADROOM + #endif + ++const int one_page_mtu = PAGE_SIZE - SKB_DATA_ALIGN(BUF_OVERHEAD) - ++ SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); ++ + static unsigned int align(unsigned int i) + { + return (i + 3) & ~3u; +@@ -67,13 +70,8 @@ static unsigned int align(unsigned int i) + struct sk_buff *tipc_buf_acquire(u32 size, gfp_t gfp) + { + struct sk_buff *skb; +-#ifdef CONFIG_TIPC_CRYPTO +- unsigned int buf_size = (BUF_HEADROOM + size + BUF_TAILROOM + 3) & ~3u; +-#else +- unsigned int buf_size = (BUF_HEADROOM + size + 3) & ~3u; +-#endif + +- skb = alloc_skb_fclone(buf_size, gfp); ++ skb = alloc_skb_fclone(BUF_OVERHEAD + size, gfp); + if (skb) { + skb_reserve(skb, BUF_HEADROOM); + skb_put(skb, size); +@@ -395,7 +393,8 @@ int tipc_msg_build(struct tipc_msg *mhdr, struct msghdr *m, int offset, + if (unlikely(!skb)) { + if (pktmax != MAX_MSG_SIZE) + return -ENOMEM; +- rc = tipc_msg_build(mhdr, m, offset, dsz, FB_MTU, list); ++ rc = tipc_msg_build(mhdr, m, offset, dsz, ++ one_page_mtu, list); + if (rc != dsz) + return rc; + if (tipc_msg_assemble(list)) +diff --git a/net/tipc/msg.h b/net/tipc/msg.h +index 5d64596ba987..64ae4c4c44f8 100644 +--- a/net/tipc/msg.h ++++ b/net/tipc/msg.h +@@ -99,9 +99,10 @@ struct plist; + #define MAX_H_SIZE 60 /* Largest possible TIPC header size */ + + #define MAX_MSG_SIZE (MAX_H_SIZE + TIPC_MAX_USER_MSG_SIZE) +-#define FB_MTU 3744 + #define TIPC_MEDIA_INFO_OFFSET 5 + ++extern const int one_page_mtu; ++ + struct tipc_skb_cb { + union { + struct { +-- +2.30.2 + diff --git a/queue-5.10/netfilter-nf_tables_offload-check-flow_dissector_key.patch b/queue-5.10/netfilter-nf_tables_offload-check-flow_dissector_key.patch new file mode 100644 index 00000000000..18070ae30b0 --- /dev/null +++ b/queue-5.10/netfilter-nf_tables_offload-check-flow_dissector_key.patch @@ -0,0 +1,60 @@ +From 39512e3a378a5ce7d076e566076226076267e69b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 19 Jun 2021 01:25:14 +0200 +Subject: netfilter: nf_tables_offload: check FLOW_DISSECTOR_KEY_BASIC in VLAN + transfer logic + +From: Pablo Neira Ayuso + +[ Upstream commit ea45fdf82cc90430bb7c280e5e53821e833782c5 ] + +The VLAN transfer logic should actually check for +FLOW_DISSECTOR_KEY_BASIC, not FLOW_DISSECTOR_KEY_CONTROL. Moreover, do +not fallback to case 2) .n_proto is set to 802.1q or 802.1ad, if +FLOW_DISSECTOR_KEY_BASIC is unset. + +Fixes: 783003f3bb8a ("netfilter: nftables_offload: special ethertype handling for VLAN") +Signed-off-by: Pablo Neira Ayuso +Signed-off-by: Sasha Levin +--- + net/netfilter/nf_tables_offload.c | 17 +++++++---------- + 1 file changed, 7 insertions(+), 10 deletions(-) + +diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c +index 2b00f7f47693..9ce776175214 100644 +--- a/net/netfilter/nf_tables_offload.c ++++ b/net/netfilter/nf_tables_offload.c +@@ -54,15 +54,10 @@ static void nft_flow_rule_transfer_vlan(struct nft_offload_ctx *ctx, + struct nft_flow_rule *flow) + { + struct nft_flow_match *match = &flow->match; +- struct nft_offload_ethertype ethertype; +- +- if (match->dissector.used_keys & BIT(FLOW_DISSECTOR_KEY_CONTROL) && +- match->key.basic.n_proto != htons(ETH_P_8021Q) && +- match->key.basic.n_proto != htons(ETH_P_8021AD)) +- return; +- +- ethertype.value = match->key.basic.n_proto; +- ethertype.mask = match->mask.basic.n_proto; ++ struct nft_offload_ethertype ethertype = { ++ .value = match->key.basic.n_proto, ++ .mask = match->mask.basic.n_proto, ++ }; + + if (match->dissector.used_keys & BIT(FLOW_DISSECTOR_KEY_VLAN) && + (match->key.vlan.vlan_tpid == htons(ETH_P_8021Q) || +@@ -76,7 +71,9 @@ static void nft_flow_rule_transfer_vlan(struct nft_offload_ctx *ctx, + match->dissector.offset[FLOW_DISSECTOR_KEY_CVLAN] = + offsetof(struct nft_flow_key, cvlan); + match->dissector.used_keys |= BIT(FLOW_DISSECTOR_KEY_CVLAN); +- } else { ++ } else if (match->dissector.used_keys & BIT(FLOW_DISSECTOR_KEY_BASIC) && ++ (match->key.basic.n_proto == htons(ETH_P_8021Q) || ++ match->key.basic.n_proto == htons(ETH_P_8021AD))) { + match->key.basic.n_proto = match->key.vlan.vlan_tpid; + match->mask.basic.n_proto = match->mask.vlan.vlan_tpid; + match->key.vlan.vlan_tpid = ethertype.value; +-- +2.30.2 + diff --git a/queue-5.10/netfilter-nft_exthdr-check-for-ipv6-packet-before-fu.patch b/queue-5.10/netfilter-nft_exthdr-check-for-ipv6-packet-before-fu.patch new file mode 100644 index 00000000000..63a32862716 --- /dev/null +++ b/queue-5.10/netfilter-nft_exthdr-check-for-ipv6-packet-before-fu.patch @@ -0,0 +1,38 @@ +From 5a646d4dbfeed10d6e5881dfdd2142dfeec88216 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 20:20:30 +0200 +Subject: netfilter: nft_exthdr: check for IPv6 packet before further + processing + +From: Pablo Neira Ayuso + +[ Upstream commit cdd73cc545c0fb9b1a1f7b209f4f536e7990cff4 ] + +ipv6_find_hdr() does not validate that this is an IPv6 packet. Add a +sanity check for calling ipv6_find_hdr() to make sure an IPv6 packet +is passed for parsing. + +Fixes: 96518518cc41 ("netfilter: add nftables") +Signed-off-by: Pablo Neira Ayuso +Signed-off-by: Sasha Levin +--- + net/netfilter/nft_exthdr.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/net/netfilter/nft_exthdr.c b/net/netfilter/nft_exthdr.c +index 3c48cdc8935d..faa0844c01fb 100644 +--- a/net/netfilter/nft_exthdr.c ++++ b/net/netfilter/nft_exthdr.c +@@ -42,6 +42,9 @@ static void nft_exthdr_ipv6_eval(const struct nft_expr *expr, + unsigned int offset = 0; + int err; + ++ if (pkt->skb->protocol != htons(ETH_P_IPV6)) ++ goto err; ++ + err = ipv6_find_hdr(pkt->skb, &offset, priv->type, NULL, NULL); + if (priv->flags & NFT_EXTHDR_F_PRESENT) { + nft_reg_store8(dest, err >= 0); +-- +2.30.2 + diff --git a/queue-5.10/netfilter-nft_osf-check-for-tcp-packet-before-furthe.patch b/queue-5.10/netfilter-nft_osf-check-for-tcp-packet-before-furthe.patch new file mode 100644 index 00000000000..1b80cda5648 --- /dev/null +++ b/queue-5.10/netfilter-nft_osf-check-for-tcp-packet-before-furthe.patch @@ -0,0 +1,40 @@ +From 0b517fe5d631f28f26f1e86d22adf213689f04ac Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 20:20:31 +0200 +Subject: netfilter: nft_osf: check for TCP packet before further processing + +From: Pablo Neira Ayuso + +[ Upstream commit 8f518d43f89ae00b9cf5460e10b91694944ca1a8 ] + +The osf expression only supports for TCP packets, add a upfront sanity +check to skip packet parsing if this is not a TCP packet. + +Fixes: b96af92d6eaf ("netfilter: nf_tables: implement Passive OS fingerprint module in nft_osf") +Signed-off-by: Pablo Neira Ayuso +Reported-by: kernel test robot +Signed-off-by: Pablo Neira Ayuso +Signed-off-by: Sasha Levin +--- + net/netfilter/nft_osf.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c +index c261d57a666a..2c957629ea66 100644 +--- a/net/netfilter/nft_osf.c ++++ b/net/netfilter/nft_osf.c +@@ -28,6 +28,11 @@ static void nft_osf_eval(const struct nft_expr *expr, struct nft_regs *regs, + struct nf_osf_data data; + struct tcphdr _tcph; + ++ if (pkt->tprot != IPPROTO_TCP) { ++ regs->verdict.code = NFT_BREAK; ++ return; ++ } ++ + tcp = skb_header_pointer(skb, ip_hdrlen(skb), + sizeof(struct tcphdr), &_tcph); + if (!tcp) { +-- +2.30.2 + diff --git a/queue-5.10/netfilter-nft_tproxy-restrict-support-to-tcp-and-udp.patch b/queue-5.10/netfilter-nft_tproxy-restrict-support-to-tcp-and-udp.patch new file mode 100644 index 00000000000..d84354a9656 --- /dev/null +++ b/queue-5.10/netfilter-nft_tproxy-restrict-support-to-tcp-and-udp.patch @@ -0,0 +1,50 @@ +From a9420b71d63bd4af750d6a102f52c29c9d6a79f8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 19:26:56 +0200 +Subject: netfilter: nft_tproxy: restrict support to TCP and UDP transport + protocols + +From: Pablo Neira Ayuso + +[ Upstream commit 52f0f4e178c757b3d356087376aad8bd77271828 ] + +Add unfront check for TCP and UDP packets before performing further +processing. + +Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support") +Signed-off-by: Pablo Neira Ayuso +Signed-off-by: Sasha Levin +--- + net/netfilter/nft_tproxy.c | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/net/netfilter/nft_tproxy.c b/net/netfilter/nft_tproxy.c +index d67f83a0958d..242222dc52c3 100644 +--- a/net/netfilter/nft_tproxy.c ++++ b/net/netfilter/nft_tproxy.c +@@ -30,6 +30,12 @@ static void nft_tproxy_eval_v4(const struct nft_expr *expr, + __be16 tport = 0; + struct sock *sk; + ++ if (pkt->tprot != IPPROTO_TCP && ++ pkt->tprot != IPPROTO_UDP) { ++ regs->verdict.code = NFT_BREAK; ++ return; ++ } ++ + hp = skb_header_pointer(skb, ip_hdrlen(skb), sizeof(_hdr), &_hdr); + if (!hp) { + regs->verdict.code = NFT_BREAK; +@@ -91,7 +97,8 @@ static void nft_tproxy_eval_v6(const struct nft_expr *expr, + + memset(&taddr, 0, sizeof(taddr)); + +- if (!pkt->tprot_set) { ++ if (pkt->tprot != IPPROTO_TCP && ++ pkt->tprot != IPPROTO_UDP) { + regs->verdict.code = NFT_BREAK; + return; + } +-- +2.30.2 + diff --git a/queue-5.10/netlabel-fix-memory-leak-in-netlbl_mgmt_add_common.patch b/queue-5.10/netlabel-fix-memory-leak-in-netlbl_mgmt_add_common.patch new file mode 100644 index 00000000000..d81ed39cc4c --- /dev/null +++ b/queue-5.10/netlabel-fix-memory-leak-in-netlbl_mgmt_add_common.patch @@ -0,0 +1,114 @@ +From cb18ace1b2174a7501c3bb7d397bba4ee358851b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Jun 2021 10:14:44 +0800 +Subject: netlabel: Fix memory leak in netlbl_mgmt_add_common + +From: Liu Shixin + +[ Upstream commit b8f6b0522c298ae9267bd6584e19b942a0636910 ] + +Hulk Robot reported memory leak in netlbl_mgmt_add_common. +The problem is non-freed map in case of netlbl_domhsh_add() failed. + +BUG: memory leak +unreferenced object 0xffff888100ab7080 (size 96): + comm "syz-executor537", pid 360, jiffies 4294862456 (age 22.678s) + hex dump (first 32 bytes): + 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + fe 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 ................ + backtrace: + [<0000000008b40026>] netlbl_mgmt_add_common.isra.0+0xb2a/0x1b40 + [<000000003be10950>] netlbl_mgmt_add+0x271/0x3c0 + [<00000000c70487ed>] genl_family_rcv_msg_doit.isra.0+0x20e/0x320 + [<000000001f2ff614>] genl_rcv_msg+0x2bf/0x4f0 + [<0000000089045792>] netlink_rcv_skb+0x134/0x3d0 + [<0000000020e96fdd>] genl_rcv+0x24/0x40 + [<0000000042810c66>] netlink_unicast+0x4a0/0x6a0 + [<000000002e1659f0>] netlink_sendmsg+0x789/0xc70 + [<000000006e43415f>] sock_sendmsg+0x139/0x170 + [<00000000680a73d7>] ____sys_sendmsg+0x658/0x7d0 + [<0000000065cbb8af>] ___sys_sendmsg+0xf8/0x170 + [<0000000019932b6c>] __sys_sendmsg+0xd3/0x190 + [<00000000643ac172>] do_syscall_64+0x37/0x90 + [<000000009b79d6dc>] entry_SYSCALL_64_after_hwframe+0x44/0xae + +Fixes: 63c416887437 ("netlabel: Add network address selectors to the NetLabel/LSM domain mapping") +Reported-by: Hulk Robot +Signed-off-by: Liu Shixin +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/netlabel/netlabel_mgmt.c | 19 ++++++++++--------- + 1 file changed, 10 insertions(+), 9 deletions(-) + +diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c +index eb1d66d20afb..02a97bca1a1a 100644 +--- a/net/netlabel/netlabel_mgmt.c ++++ b/net/netlabel/netlabel_mgmt.c +@@ -76,6 +76,7 @@ static const struct nla_policy netlbl_mgmt_genl_policy[NLBL_MGMT_A_MAX + 1] = { + static int netlbl_mgmt_add_common(struct genl_info *info, + struct netlbl_audit *audit_info) + { ++ void *pmap = NULL; + int ret_val = -EINVAL; + struct netlbl_domaddr_map *addrmap = NULL; + struct cipso_v4_doi *cipsov4 = NULL; +@@ -175,6 +176,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info, + ret_val = -ENOMEM; + goto add_free_addrmap; + } ++ pmap = map; + map->list.addr = addr->s_addr & mask->s_addr; + map->list.mask = mask->s_addr; + map->list.valid = 1; +@@ -183,10 +185,8 @@ static int netlbl_mgmt_add_common(struct genl_info *info, + map->def.cipso = cipsov4; + + ret_val = netlbl_af4list_add(&map->list, &addrmap->list4); +- if (ret_val != 0) { +- kfree(map); +- goto add_free_addrmap; +- } ++ if (ret_val != 0) ++ goto add_free_map; + + entry->family = AF_INET; + entry->def.type = NETLBL_NLTYPE_ADDRSELECT; +@@ -223,6 +223,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info, + ret_val = -ENOMEM; + goto add_free_addrmap; + } ++ pmap = map; + map->list.addr = *addr; + map->list.addr.s6_addr32[0] &= mask->s6_addr32[0]; + map->list.addr.s6_addr32[1] &= mask->s6_addr32[1]; +@@ -235,10 +236,8 @@ static int netlbl_mgmt_add_common(struct genl_info *info, + map->def.calipso = calipso; + + ret_val = netlbl_af6list_add(&map->list, &addrmap->list6); +- if (ret_val != 0) { +- kfree(map); +- goto add_free_addrmap; +- } ++ if (ret_val != 0) ++ goto add_free_map; + + entry->family = AF_INET6; + entry->def.type = NETLBL_NLTYPE_ADDRSELECT; +@@ -248,10 +247,12 @@ static int netlbl_mgmt_add_common(struct genl_info *info, + + ret_val = netlbl_domhsh_add(entry, audit_info); + if (ret_val != 0) +- goto add_free_addrmap; ++ goto add_free_map; + + return 0; + ++add_free_map: ++ kfree(pmap); + add_free_addrmap: + kfree(addrmap); + add_doi_put_def: +-- +2.30.2 + diff --git a/queue-5.10/nvme-pci-fix-var.-type-for-increasing-cq_head.patch b/queue-5.10/nvme-pci-fix-var.-type-for-increasing-cq_head.patch new file mode 100644 index 00000000000..28f1561a0f6 --- /dev/null +++ b/queue-5.10/nvme-pci-fix-var.-type-for-increasing-cq_head.patch @@ -0,0 +1,44 @@ +From 3391a42b073bdaa42ce5c244ce67867952d346a0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 15:02:17 +0900 +Subject: nvme-pci: fix var. type for increasing cq_head + +From: JK Kim + +[ Upstream commit a0aac973a26d1ac814b9e131e209eb39472a67ce ] + +nvmeq->cq_head is compared with nvmeq->q_depth and changed the value +and cq_phase for handling the next cq db. + +but, nvmeq->q_depth's type is u32 and max. value is 0x10000 when +CQP.MSQE is 0xffff and io_queue_depth is 0x10000. + +current temp. variable for comparing with nvmeq->q_depth is overflowed +when previous nvmeq->cq_head is 0xffff. + +in this case, nvmeq->cq_phase is not updated. +so, fix data type for temp. variable to u32. + +Signed-off-by: JK Kim +Signed-off-by: Christoph Hellwig +Signed-off-by: Sasha Levin +--- + drivers/nvme/host/pci.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c +index c1f3446216c5..56263214ea06 100644 +--- a/drivers/nvme/host/pci.c ++++ b/drivers/nvme/host/pci.c +@@ -1027,7 +1027,7 @@ static inline void nvme_handle_cqe(struct nvme_queue *nvmeq, u16 idx) + + static inline void nvme_update_cq_head(struct nvme_queue *nvmeq) + { +- u16 tmp = nvmeq->cq_head + 1; ++ u32 tmp = nvmeq->cq_head + 1; + + if (tmp == nvmeq->q_depth) { + nvmeq->cq_head = 0; +-- +2.30.2 + diff --git a/queue-5.10/nvme-pci-look-for-storaged3enable-on-companion-acpi-.patch b/queue-5.10/nvme-pci-look-for-storaged3enable-on-companion-acpi-.patch new file mode 100644 index 00000000000..79f500e6315 --- /dev/null +++ b/queue-5.10/nvme-pci-look-for-storaged3enable-on-companion-acpi-.patch @@ -0,0 +1,78 @@ +From f7f45fddd4314e20f74d17505c4dbf7e228f1f71 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 11:02:34 -0500 +Subject: nvme-pci: look for StorageD3Enable on companion ACPI device instead + +From: Mario Limonciello + +[ Upstream commit e21e0243e7b0f1c2a21d21f4d115f7b37175772a ] + +The documentation around the StorageD3Enable property hints that it +should be made on the PCI device. This is where newer AMD systems set +the property and it's required for S0i3 support. + +So rather than look for nodes of the root port only present on Intel +systems, switch to the companion ACPI device for all systems. +David Box from Intel indicated this should work on Intel as well. + +Link: https://lore.kernel.org/linux-nvme/YK6gmAWqaRmvpJXb@google.com/T/#m900552229fa455867ee29c33b854845fce80ba70 +Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro +Fixes: df4f9bc4fb9c ("nvme-pci: add support for ACPI StorageD3Enable property") +Suggested-by: Liang Prike +Acked-by: Raul E Rangel +Signed-off-by: Mario Limonciello +Reviewed-by: David E. Box +Signed-off-by: Christoph Hellwig +Signed-off-by: Sasha Levin +--- + drivers/nvme/host/pci.c | 24 +----------------------- + 1 file changed, 1 insertion(+), 23 deletions(-) + +diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c +index 56263214ea06..3f05df98697d 100644 +--- a/drivers/nvme/host/pci.c ++++ b/drivers/nvme/host/pci.c +@@ -2836,10 +2836,7 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) + #ifdef CONFIG_ACPI + static bool nvme_acpi_storage_d3(struct pci_dev *dev) + { +- struct acpi_device *adev; +- struct pci_dev *root; +- acpi_handle handle; +- acpi_status status; ++ struct acpi_device *adev = ACPI_COMPANION(&dev->dev); + u8 val; + + /* +@@ -2847,28 +2844,9 @@ static bool nvme_acpi_storage_d3(struct pci_dev *dev) + * must use D3 to support deep platform power savings during + * suspend-to-idle. + */ +- root = pcie_find_root_port(dev); +- if (!root) +- return false; + +- adev = ACPI_COMPANION(&root->dev); + if (!adev) + return false; +- +- /* +- * The property is defined in the PXSX device for South complex ports +- * and in the PEGP device for North complex ports. +- */ +- status = acpi_get_handle(adev->handle, "PXSX", &handle); +- if (ACPI_FAILURE(status)) { +- status = acpi_get_handle(adev->handle, "PEGP", &handle); +- if (ACPI_FAILURE(status)) +- return false; +- } +- +- if (acpi_bus_get_device(handle, &adev)) +- return false; +- + if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", + &val)) + return false; +-- +2.30.2 + diff --git a/queue-5.10/nvmet-fc-do-not-check-for-invalid-target-port-in-nvm.patch b/queue-5.10/nvmet-fc-do-not-check-for-invalid-target-port-in-nvm.patch new file mode 100644 index 00000000000..d039dd4c67f --- /dev/null +++ b/queue-5.10/nvmet-fc-do-not-check-for-invalid-target-port-in-nvm.patch @@ -0,0 +1,55 @@ +From a94a8d5db3d25f738cb31c86c1bc17ae88b30cc5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 14:54:14 +0200 +Subject: nvmet-fc: do not check for invalid target port in + nvmet_fc_handle_fcp_rqst() + +From: Hannes Reinecke + +[ Upstream commit 2a4a910aa4f0acc428dc8d10227c42e14ed21d10 ] + +When parsing a request in nvmet_fc_handle_fcp_rqst() we should not +check for invalid target ports; if we do the command is aborted +from the fcp layer, causing the host to assume a transport error. +Rather we should still forward this request to the nvmet layer, which +will then correctly fail the command with an appropriate error status. + +Signed-off-by: Hannes Reinecke +Reviewed-by: James Smart +Signed-off-by: Christoph Hellwig +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/fc.c | 10 ++-------- + 1 file changed, 2 insertions(+), 8 deletions(-) + +diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c +index cd4e73aa9807..640031cbda7c 100644 +--- a/drivers/nvme/target/fc.c ++++ b/drivers/nvme/target/fc.c +@@ -2499,13 +2499,6 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport, + u32 xfrlen = be32_to_cpu(cmdiu->data_len); + int ret; + +- /* +- * if there is no nvmet mapping to the targetport there +- * shouldn't be requests. just terminate them. +- */ +- if (!tgtport->pe) +- goto transport_error; +- + /* + * Fused commands are currently not supported in the linux + * implementation. +@@ -2533,7 +2526,8 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport, + + fod->req.cmd = &fod->cmdiubuf.sqe; + fod->req.cqe = &fod->rspiubuf.cqe; +- fod->req.port = tgtport->pe->port; ++ if (tgtport->pe) ++ fod->req.port = tgtport->pe->port; + + /* clear any response payload */ + memset(&fod->rspiubuf, 0, sizeof(fod->rspiubuf)); +-- +2.30.2 + diff --git a/queue-5.10/ocfs2-fix-snprintf-checking.patch b/queue-5.10/ocfs2-fix-snprintf-checking.patch new file mode 100644 index 00000000000..dd45cbf6fc7 --- /dev/null +++ b/queue-5.10/ocfs2-fix-snprintf-checking.patch @@ -0,0 +1,85 @@ +From f4ae1be32c6c579d60e54cfa89fc7f16848a1b57 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 28 Jun 2021 19:34:01 -0700 +Subject: ocfs2: fix snprintf() checking + +From: Dan Carpenter + +[ Upstream commit 54e948c60cc843b6e84dc44496edc91f51d2a28e ] + +The snprintf() function returns the number of bytes which would have been +printed if the buffer was large enough. In other words it can return ">= +remain" but this code assumes it returns "== remain". + +The run time impact of this bug is not very severe. The next iteration +through the loop would trigger a WARN() when we pass a negative limit to +snprintf(). We would then return success instead of -E2BIG. + +The kernel implementation of snprintf() will never return negatives so +there is no need to check and I have deleted that dead code. + +Link: https://lkml.kernel.org/r/20210511135350.GV1955@kadam +Fixes: a860f6eb4c6a ("ocfs2: sysfile interfaces for online file check") +Fixes: 74ae4e104dfc ("ocfs2: Create stack glue sysfs files.") +Signed-off-by: Dan Carpenter +Reviewed-by: Joseph Qi +Cc: Mark Fasheh +Cc: Joel Becker +Cc: Junxiao Bi +Cc: Changwei Ge +Cc: Gang He +Cc: Jun Piao +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + fs/ocfs2/filecheck.c | 6 +----- + fs/ocfs2/stackglue.c | 8 ++------ + 2 files changed, 3 insertions(+), 11 deletions(-) + +diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2/filecheck.c +index 50f11bfdc8c2..82a3edc4aea4 100644 +--- a/fs/ocfs2/filecheck.c ++++ b/fs/ocfs2/filecheck.c +@@ -328,11 +328,7 @@ static ssize_t ocfs2_filecheck_attr_show(struct kobject *kobj, + ret = snprintf(buf + total, remain, "%lu\t\t%u\t%s\n", + p->fe_ino, p->fe_done, + ocfs2_filecheck_error(p->fe_status)); +- if (ret < 0) { +- total = ret; +- break; +- } +- if (ret == remain) { ++ if (ret >= remain) { + /* snprintf() didn't fit */ + total = -E2BIG; + break; +diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c +index a191094694c6..03eacb249f37 100644 +--- a/fs/ocfs2/stackglue.c ++++ b/fs/ocfs2/stackglue.c +@@ -502,11 +502,7 @@ static ssize_t ocfs2_loaded_cluster_plugins_show(struct kobject *kobj, + list_for_each_entry(p, &ocfs2_stack_list, sp_list) { + ret = snprintf(buf, remain, "%s\n", + p->sp_name); +- if (ret < 0) { +- total = ret; +- break; +- } +- if (ret == remain) { ++ if (ret >= remain) { + /* snprintf() didn't fit */ + total = -E2BIG; + break; +@@ -533,7 +529,7 @@ static ssize_t ocfs2_active_cluster_plugin_show(struct kobject *kobj, + if (active_stack) { + ret = snprintf(buf, PAGE_SIZE, "%s\n", + active_stack->sp_name); +- if (ret == PAGE_SIZE) ++ if (ret >= PAGE_SIZE) + ret = -E2BIG; + } + spin_unlock(&ocfs2_stack_lock); +-- +2.30.2 + diff --git a/queue-5.10/of-fix-truncation-of-memory-sizes-on-32-bit-platform.patch b/queue-5.10/of-fix-truncation-of-memory-sizes-on-32-bit-platform.patch new file mode 100644 index 00000000000..d51c087d279 --- /dev/null +++ b/queue-5.10/of-fix-truncation-of-memory-sizes-on-32-bit-platform.patch @@ -0,0 +1,87 @@ +From 33740a789686bf8971cd4f47a3398b1ce3f6ab37 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 11:27:44 +0200 +Subject: of: Fix truncation of memory sizes on 32-bit platforms + +From: Geert Uytterhoeven + +[ Upstream commit 2892d8a00d23d511a0591ac4b2ff3f050ae1f004 ] + +Variable "size" has type "phys_addr_t", which can be either 32-bit or +64-bit on 32-bit systems, while "unsigned long" is always 32-bit on +32-bit systems. Hence the cast in + + (unsigned long)size / SZ_1M + +may truncate a 64-bit size to 32-bit, as casts have a higher operator +precedence than divisions. + +Fix this by inverting the order of the cast and division, which should +be safe for memory blocks smaller than 4 PiB. Note that the division is +actually a shift, as SZ_1M is a power-of-two constant, hence there is no +need to use div_u64(). + +While at it, use "%lu" to format "unsigned long". + +Fixes: e8d9d1f5485b52ec ("drivers: of: add initialization code for static reserved memory") +Fixes: 3f0c8206644836e4 ("drivers: of: add initialization code for dynamic reserved memory") +Signed-off-by: Geert Uytterhoeven +Acked-by: Marek Szyprowski +Link: https://lore.kernel.org/r/4a1117e72d13d26126f57be034c20dac02f1e915.1623835273.git.geert+renesas@glider.be +Signed-off-by: Rob Herring +Signed-off-by: Sasha Levin +--- + drivers/of/fdt.c | 8 ++++---- + drivers/of/of_reserved_mem.c | 8 ++++---- + 2 files changed, 8 insertions(+), 8 deletions(-) + +diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c +index f2e697000b96..57ff31b6b1e4 100644 +--- a/drivers/of/fdt.c ++++ b/drivers/of/fdt.c +@@ -501,11 +501,11 @@ static int __init __reserved_mem_reserve_reg(unsigned long node, + + if (size && + early_init_dt_reserve_memory_arch(base, size, nomap) == 0) +- pr_debug("Reserved memory: reserved region for node '%s': base %pa, size %ld MiB\n", +- uname, &base, (unsigned long)size / SZ_1M); ++ pr_debug("Reserved memory: reserved region for node '%s': base %pa, size %lu MiB\n", ++ uname, &base, (unsigned long)(size / SZ_1M)); + else +- pr_info("Reserved memory: failed to reserve memory for node '%s': base %pa, size %ld MiB\n", +- uname, &base, (unsigned long)size / SZ_1M); ++ pr_info("Reserved memory: failed to reserve memory for node '%s': base %pa, size %lu MiB\n", ++ uname, &base, (unsigned long)(size / SZ_1M)); + + len -= t_len; + if (first) { +diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c +index a7fbc5e37e19..6c95bbdf9265 100644 +--- a/drivers/of/of_reserved_mem.c ++++ b/drivers/of/of_reserved_mem.c +@@ -134,9 +134,9 @@ static int __init __reserved_mem_alloc_size(unsigned long node, + ret = early_init_dt_alloc_reserved_memory_arch(size, + align, start, end, nomap, &base); + if (ret == 0) { +- pr_debug("allocated memory for '%s' node: base %pa, size %ld MiB\n", ++ pr_debug("allocated memory for '%s' node: base %pa, size %lu MiB\n", + uname, &base, +- (unsigned long)size / SZ_1M); ++ (unsigned long)(size / SZ_1M)); + break; + } + len -= t_len; +@@ -146,8 +146,8 @@ static int __init __reserved_mem_alloc_size(unsigned long node, + ret = early_init_dt_alloc_reserved_memory_arch(size, align, + 0, 0, nomap, &base); + if (ret == 0) +- pr_debug("allocated memory for '%s' node: base %pa, size %ld MiB\n", +- uname, &base, (unsigned long)size / SZ_1M); ++ pr_debug("allocated memory for '%s' node: base %pa, size %lu MiB\n", ++ uname, &base, (unsigned long)(size / SZ_1M)); + } + + if (base == 0) { +-- +2.30.2 + diff --git a/queue-5.10/open-don-t-silently-ignore-unknown-o-flags-in-openat.patch b/queue-5.10/open-don-t-silently-ignore-unknown-o-flags-in-openat.patch new file mode 100644 index 00000000000..43b9f69acaa --- /dev/null +++ b/queue-5.10/open-don-t-silently-ignore-unknown-o-flags-in-openat.patch @@ -0,0 +1,108 @@ +From 4dc57d26cb547243c8a569faba53428d17b090c4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 11:24:16 +0200 +Subject: open: don't silently ignore unknown O-flags in openat2() + +From: Christian Brauner + +[ Upstream commit cfe80306a0dd6d363934913e47c3f30d71b721e5 ] + +The new openat2() syscall verifies that no unknown O-flag values are +set and returns an error to userspace if they are while the older open +syscalls like open() and openat() simply ignore unknown flag values: + + #define O_FLAG_CURRENTLY_INVALID (1 << 31) + struct open_how how = { + .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID, + .resolve = 0, + }; + + /* fails */ + fd = openat2(-EBADF, "/dev/null", &how, sizeof(how)); + + /* succeeds */ + fd = openat(-EBADF, "/dev/null", O_RDONLY | O_FLAG_CURRENTLY_INVALID); + +However, openat2() silently truncates the upper 32 bits meaning: + + #define O_FLAG_CURRENTLY_INVALID_LOWER32 (1 << 31) + #define O_FLAG_CURRENTLY_INVALID_UPPER32 (1 << 40) + + struct open_how how_lowe32 = { + .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_LOWER32, + }; + + struct open_how how_upper32 = { + .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_UPPER32, + }; + + /* fails */ + fd = openat2(-EBADF, "/dev/null", &how_lower32, sizeof(how_lower32)); + + /* succeeds */ + fd = openat2(-EBADF, "/dev/null", &how_upper32, sizeof(how_upper32)); + +Fix this by preventing the immediate truncation in build_open_flags(). + +There's a snafu here though stripping FMODE_* directly from flags would +cause the upper 32 bits to be truncated as well due to integer promotion +rules since FMODE_* is unsigned int, O_* are signed ints (yuck). + +In addition, struct open_flags currently defines flags to be 32 bit +which is reasonable. If we simply were to bump it to 64 bit we would +need to change a lot of code preemptively which doesn't seem worth it. +So simply add a compile-time check verifying that all currently known +O_* flags are within the 32 bit range and fail to build if they aren't +anymore. + +This change shouldn't regress old open syscalls since they silently +truncate any unknown values anyway. It is a tiny semantic change for +openat2() but it is very unlikely people pass ing > 32 bit unknown flags +and the syscall is relatively new too. + +Link: https://lore.kernel.org/r/20210528092417.3942079-3-brauner@kernel.org +Cc: Christoph Hellwig +Cc: Aleksa Sarai +Cc: Al Viro +Cc: linux-fsdevel@vger.kernel.org +Reported-by: Richard Guy Briggs +Reviewed-by: Christoph Hellwig +Reviewed-by: Aleksa Sarai +Reviewed-by: Richard Guy Briggs +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/open.c | 14 +++++++++++--- + 1 file changed, 11 insertions(+), 3 deletions(-) + +diff --git a/fs/open.c b/fs/open.c +index 4d7537ae59df..3aaaad47d9ca 100644 +--- a/fs/open.c ++++ b/fs/open.c +@@ -993,12 +993,20 @@ inline struct open_how build_open_how(int flags, umode_t mode) + + inline int build_open_flags(const struct open_how *how, struct open_flags *op) + { +- int flags = how->flags; ++ u64 flags = how->flags; ++ u64 strip = FMODE_NONOTIFY | O_CLOEXEC; + int lookup_flags = 0; + int acc_mode = ACC_MODE(flags); + +- /* Must never be set by userspace */ +- flags &= ~(FMODE_NONOTIFY | O_CLOEXEC); ++ BUILD_BUG_ON_MSG(upper_32_bits(VALID_OPEN_FLAGS), ++ "struct open_flags doesn't yet handle flags > 32 bits"); ++ ++ /* ++ * Strip flags that either shouldn't be set by userspace like ++ * FMODE_NONOTIFY or that aren't relevant in determining struct ++ * open_flags like O_CLOEXEC. ++ */ ++ flags &= ~strip; + + /* + * Older syscalls implicitly clear all of the invalid flags or argument +-- +2.30.2 + diff --git a/queue-5.10/pata_ep93xx-fix-deferred-probing.patch b/queue-5.10/pata_ep93xx-fix-deferred-probing.patch new file mode 100644 index 00000000000..ab13e57ba02 --- /dev/null +++ b/queue-5.10/pata_ep93xx-fix-deferred-probing.patch @@ -0,0 +1,39 @@ +From a4a4ab7d9bf7d5dd61c5cd06abf922d45e1cb8de Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 20 Mar 2021 23:32:38 +0300 +Subject: pata_ep93xx: fix deferred probing + +From: Sergey Shtylyov + +[ Upstream commit 5c8121262484d99bffb598f39a0df445cecd8efb ] + +The driver overrides the error codes returned by platform_get_irq() to +-ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe +permanently instead of the deferred probing. Propagate the error code +upstream, as it should have been done from the start... + +Fixes: 2fff27512600 ("PATA host controller driver for ep93xx") +Signed-off-by: Sergey Shtylyov +Link: https://lore.kernel.org/r/509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + drivers/ata/pata_ep93xx.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c +index badab6708893..46208ececbb6 100644 +--- a/drivers/ata/pata_ep93xx.c ++++ b/drivers/ata/pata_ep93xx.c +@@ -928,7 +928,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev) + /* INT[3] (IRQ_EP93XX_EXT3) line connected as pull down */ + irq = platform_get_irq(pdev, 0); + if (irq < 0) { +- err = -ENXIO; ++ err = irq; + goto err_rel_gpio; + } + +-- +2.30.2 + diff --git a/queue-5.10/pata_octeon_cf-avoid-warn_on-in-ata_host_activate.patch b/queue-5.10/pata_octeon_cf-avoid-warn_on-in-ata_host_activate.patch new file mode 100644 index 00000000000..554678a3044 --- /dev/null +++ b/queue-5.10/pata_octeon_cf-avoid-warn_on-in-ata_host_activate.patch @@ -0,0 +1,45 @@ +From 25a969a1aa06e87492820436eaa0145cc2252df9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 23:38:54 +0300 +Subject: pata_octeon_cf: avoid WARN_ON() in ata_host_activate() + +From: Sergey Shtylyov + +[ Upstream commit bfc1f378c8953e68ccdbfe0a8c20748427488b80 ] + +Iff platform_get_irq() fails (or returns IRQ0) and thus the polling mode +has to be used, ata_host_activate() hits the WARN_ON() due to 'irq_handler' +parameter being non-NULL if the polling mode is selected. Let's only set +the pointer to the driver's IRQ handler if platform_get_irq() returns a +valid IRQ # -- this should avoid the unnecessary WARN_ON()... + +Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.") +Signed-off-by: Sergey Shtylyov +Link: https://lore.kernel.org/r/3a241167-f84d-1d25-5b9b-be910afbe666@omp.ru +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + drivers/ata/pata_octeon_cf.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c +index bd87476ab481..b5a3f710d76d 100644 +--- a/drivers/ata/pata_octeon_cf.c ++++ b/drivers/ata/pata_octeon_cf.c +@@ -898,10 +898,11 @@ static int octeon_cf_probe(struct platform_device *pdev) + return -EINVAL; + } + +- irq_handler = octeon_cf_interrupt; + i = platform_get_irq(dma_dev, 0); +- if (i > 0) ++ if (i > 0) { + irq = i; ++ irq_handler = octeon_cf_interrupt; ++ } + } + of_node_put(dma_node); + } +-- +2.30.2 + diff --git a/queue-5.10/pata_rb532_cf-fix-deferred-probing.patch b/queue-5.10/pata_rb532_cf-fix-deferred-probing.patch new file mode 100644 index 00000000000..83df89236a9 --- /dev/null +++ b/queue-5.10/pata_rb532_cf-fix-deferred-probing.patch @@ -0,0 +1,46 @@ +From 7d29af7550adf6e72088ef78c0d2d93c62323b37 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Mar 2021 14:46:53 +0300 +Subject: pata_rb532_cf: fix deferred probing + +From: Sergey Shtylyov + +[ Upstream commit 2d3a62fbae8e5badc2342388f65ab2191c209cc0 ] + +The driver overrides the error codes returned by platform_get_irq() to +-ENOENT, so if it returns -EPROBE_DEFER, the driver would fail the probe +permanently instead of the deferred probing. Switch to propagating the +error code upstream, still checking/overriding IRQ0 as libata regards it +as "no IRQ" (thus polling) anyway... + +Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") +Signed-off-by: Sergey Shtylyov +Link: https://lore.kernel.org/r/771ced55-3efb-21f5-f21c-b99920aae611@omprussia.ru +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + drivers/ata/pata_rb532_cf.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c +index 479c4b29b856..303f8c375b3a 100644 +--- a/drivers/ata/pata_rb532_cf.c ++++ b/drivers/ata/pata_rb532_cf.c +@@ -115,10 +115,12 @@ static int rb532_pata_driver_probe(struct platform_device *pdev) + } + + irq = platform_get_irq(pdev, 0); +- if (irq <= 0) { ++ if (irq < 0) { + dev_err(&pdev->dev, "no IRQ resource found\n"); +- return -ENOENT; ++ return irq; + } ++ if (!irq) ++ return -EINVAL; + + gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_IN); + if (IS_ERR(gpiod)) { +-- +2.30.2 + diff --git a/queue-5.10/pci-hv-add-check-for-hyperv_initialized-in-init_hv_p.patch b/queue-5.10/pci-hv-add-check-for-hyperv_initialized-in-init_hv_p.patch new file mode 100644 index 00000000000..ba38c92dc4c --- /dev/null +++ b/queue-5.10/pci-hv-add-check-for-hyperv_initialized-in-init_hv_p.patch @@ -0,0 +1,41 @@ +From e47fa0313d83becb0883f07c7c120fa93719ba95 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 16:17:33 -0700 +Subject: PCI: hv: Add check for hyperv_initialized in init_hv_pci_drv() + +From: Haiyang Zhang + +[ Upstream commit 7d815f4afa87f2032b650ae1bba7534b550a6b8b ] + +Add check for hv_is_hyperv_initialized() at the top of +init_hv_pci_drv(), so if the pci-hyperv driver is force-loaded on non +Hyper-V platforms, the init_hv_pci_drv() will exit immediately, without +any side effects, like assignments to hvpci_block_ops, etc. + +Signed-off-by: Haiyang Zhang +Reported-and-tested-by: Mohammad Alqayeem +Reviewed-by: Wei Liu +Link: https://lore.kernel.org/r/1621984653-1210-1-git-send-email-haiyangz@microsoft.com +Signed-off-by: Wei Liu +Signed-off-by: Sasha Levin +--- + drivers/pci/controller/pci-hyperv.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c +index 03ed5cb1c4b2..d57c538bbb2d 100644 +--- a/drivers/pci/controller/pci-hyperv.c ++++ b/drivers/pci/controller/pci-hyperv.c +@@ -3480,6 +3480,9 @@ static void __exit exit_hv_pci_drv(void) + + static int __init init_hv_pci_drv(void) + { ++ if (!hv_is_hyperv_initialized()) ++ return -ENODEV; ++ + /* Set the invalid domain number's bit, so it will not be used */ + set_bit(HVPCI_DOM_INVALID, hvpci_dom_map); + +-- +2.30.2 + diff --git a/queue-5.10/perf-arm-cmn-fix-invalid-pointer-when-access-dtc-obj.patch b/queue-5.10/perf-arm-cmn-fix-invalid-pointer-when-access-dtc-obj.patch new file mode 100644 index 00000000000..1b69897d45a --- /dev/null +++ b/queue-5.10/perf-arm-cmn-fix-invalid-pointer-when-access-dtc-obj.patch @@ -0,0 +1,41 @@ +From c22c87c90469bedb4b8e8d36089eadf583e825d6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 09:08:49 -0700 +Subject: perf/arm-cmn: Fix invalid pointer when access dtc object sharing the + same IRQ number + +From: Tuan Phan + +[ Upstream commit 4e16f283edc289820e9b2d6f617ed8e514ee8396 ] + +When multiple dtcs share the same IRQ number, the irq_friend which +used to refer to dtc object gets calculated incorrect which leads +to invalid pointer. + +Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") + +Signed-off-by: Tuan Phan +Reviewed-by: Robin Murphy +Link: https://lore.kernel.org/r/1623946129-3290-1-git-send-email-tuanphan@os.amperecomputing.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + drivers/perf/arm-cmn.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c +index 46defb1dcf86..bb019e383988 100644 +--- a/drivers/perf/arm-cmn.c ++++ b/drivers/perf/arm-cmn.c +@@ -1212,7 +1212,7 @@ static int arm_cmn_init_irqs(struct arm_cmn *cmn) + irq = cmn->dtc[i].irq; + for (j = i; j--; ) { + if (cmn->dtc[j].irq == irq) { +- cmn->dtc[j].irq_friend = j - i; ++ cmn->dtc[j].irq_friend = i - j; + goto next; + } + } +-- +2.30.2 + diff --git a/queue-5.10/perf-llvm-return-enomem-when-asprintf-fails.patch b/queue-5.10/perf-llvm-return-enomem-when-asprintf-fails.patch new file mode 100644 index 00000000000..7fb258bc769 --- /dev/null +++ b/queue-5.10/perf-llvm-return-enomem-when-asprintf-fails.patch @@ -0,0 +1,57 @@ +From 9ab4d9a214cabc1e4cc452cc0f620dafb1b5fca0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 1 Jul 2021 14:20:58 -0300 +Subject: perf llvm: Return -ENOMEM when asprintf() fails + +From: Arnaldo Carvalho de Melo + +[ Upstream commit c435c166dcf526ac827bc964d82cc0d5e7a1fd0b ] + +Zhihao sent a patch but it made llvm__compile_bpf() return what +asprintf() returns on error, which is just -1, but since this function +returns -errno, fix it by returning -ENOMEM for this case instead. + +Fixes: cb76371441d098 ("perf llvm: Allow passing options to llc ...") +Fixes: 5eab5a7ee032ac ("perf llvm: Display eBPF compiling command ...") +Reported-by: Hulk Robot +Reported-by: Zhihao Cheng +Cc: Alexei Starovoitov +Cc: Andrii Nakryiko +Cc: Daniel Borkmann +Cc: Ingo Molnar +Cc: Jiri Olsa +Cc: Nathan Chancellor +Cc: Nick Desaulniers +Cc: Peter Zijlstra +Cc: Yu Kuai +Cc: clang-built-linux@googlegroups.com +Link: http://lore.kernel.org/lkml/20210609115945.2193194-1-chengzhihao1@huawei.com +Signed-off-by: Arnaldo Carvalho de Melo +Signed-off-by: Sasha Levin +--- + tools/perf/util/llvm-utils.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c +index dbdffb6673fe..0bf6b4d4c90a 100644 +--- a/tools/perf/util/llvm-utils.c ++++ b/tools/perf/util/llvm-utils.c +@@ -504,6 +504,7 @@ int llvm__compile_bpf(const char *path, void **p_obj_buf, + goto errout; + } + ++ err = -ENOMEM; + if (asprintf(&pipe_template, "%s -emit-llvm | %s -march=bpf %s -filetype=obj -o -", + template, llc_path, opts) < 0) { + pr_err("ERROR:\tnot enough memory to setup command line\n"); +@@ -524,6 +525,7 @@ int llvm__compile_bpf(const char *path, void **p_obj_buf, + + pr_debug("llvm compiling command template: %s\n", template); + ++ err = -ENOMEM; + if (asprintf(&command_echo, "echo -n \"%s\"", template) < 0) + goto errout; + +-- +2.30.2 + diff --git a/queue-5.10/perf-scripting-python-fix-tuple_set_u64.patch b/queue-5.10/perf-scripting-python-fix-tuple_set_u64.patch new file mode 100644 index 00000000000..2ec0bc560e7 --- /dev/null +++ b/queue-5.10/perf-scripting-python-fix-tuple_set_u64.patch @@ -0,0 +1,281 @@ +From 94174addaf07e284196cb62d559cad753e127687 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 12:51:03 +0300 +Subject: perf scripting python: Fix tuple_set_u64() + +From: Adrian Hunter + +[ Upstream commit d04c1ff0b3ddd5c0fbbe640996c8eaad279ed1c5 ] + +tuple_set_u64() produces a signed value instead of an unsigned value. +That works for database export but not other cases. Rename to +tuple_set_d64() for database export and fix tuple_set_u64(). + +Fixes: df919b400ad3f ("perf scripting python: Extend interface to export data in a database-friendly way") +Signed-off-by: Adrian Hunter +Cc: Andi Kleen +Cc: Jiri Olsa +Signed-off-by: Arnaldo Carvalho de Melo +Link: https://lore.kernel.org/r/20210525095112.1399-2-adrian.hunter@intel.com +Signed-off-by: Sasha Levin +--- + .../scripting-engines/trace-event-python.c | 146 ++++++++++-------- + 1 file changed, 81 insertions(+), 65 deletions(-) + +diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c +index c83c2c6564e0..23dc5014e711 100644 +--- a/tools/perf/util/scripting-engines/trace-event-python.c ++++ b/tools/perf/util/scripting-engines/trace-event-python.c +@@ -934,7 +934,7 @@ static PyObject *tuple_new(unsigned int sz) + return t; + } + +-static int tuple_set_u64(PyObject *t, unsigned int pos, u64 val) ++static int tuple_set_s64(PyObject *t, unsigned int pos, s64 val) + { + #if BITS_PER_LONG == 64 + return PyTuple_SetItem(t, pos, _PyLong_FromLong(val)); +@@ -944,6 +944,22 @@ static int tuple_set_u64(PyObject *t, unsigned int pos, u64 val) + #endif + } + ++/* ++ * Databases support only signed 64-bit numbers, so even though we are ++ * exporting a u64, it must be as s64. ++ */ ++#define tuple_set_d64 tuple_set_s64 ++ ++static int tuple_set_u64(PyObject *t, unsigned int pos, u64 val) ++{ ++#if BITS_PER_LONG == 64 ++ return PyTuple_SetItem(t, pos, PyLong_FromUnsignedLong(val)); ++#endif ++#if BITS_PER_LONG == 32 ++ return PyTuple_SetItem(t, pos, PyLong_FromUnsignedLongLong(val)); ++#endif ++} ++ + static int tuple_set_s32(PyObject *t, unsigned int pos, s32 val) + { + return PyTuple_SetItem(t, pos, _PyLong_FromLong(val)); +@@ -967,7 +983,7 @@ static int python_export_evsel(struct db_export *dbe, struct evsel *evsel) + + t = tuple_new(2); + +- tuple_set_u64(t, 0, evsel->db_id); ++ tuple_set_d64(t, 0, evsel->db_id); + tuple_set_string(t, 1, evsel__name(evsel)); + + call_object(tables->evsel_handler, t, "evsel_table"); +@@ -985,7 +1001,7 @@ static int python_export_machine(struct db_export *dbe, + + t = tuple_new(3); + +- tuple_set_u64(t, 0, machine->db_id); ++ tuple_set_d64(t, 0, machine->db_id); + tuple_set_s32(t, 1, machine->pid); + tuple_set_string(t, 2, machine->root_dir ? machine->root_dir : ""); + +@@ -1004,9 +1020,9 @@ static int python_export_thread(struct db_export *dbe, struct thread *thread, + + t = tuple_new(5); + +- tuple_set_u64(t, 0, thread->db_id); +- tuple_set_u64(t, 1, machine->db_id); +- tuple_set_u64(t, 2, main_thread_db_id); ++ tuple_set_d64(t, 0, thread->db_id); ++ tuple_set_d64(t, 1, machine->db_id); ++ tuple_set_d64(t, 2, main_thread_db_id); + tuple_set_s32(t, 3, thread->pid_); + tuple_set_s32(t, 4, thread->tid); + +@@ -1025,10 +1041,10 @@ static int python_export_comm(struct db_export *dbe, struct comm *comm, + + t = tuple_new(5); + +- tuple_set_u64(t, 0, comm->db_id); ++ tuple_set_d64(t, 0, comm->db_id); + tuple_set_string(t, 1, comm__str(comm)); +- tuple_set_u64(t, 2, thread->db_id); +- tuple_set_u64(t, 3, comm->start); ++ tuple_set_d64(t, 2, thread->db_id); ++ tuple_set_d64(t, 3, comm->start); + tuple_set_s32(t, 4, comm->exec); + + call_object(tables->comm_handler, t, "comm_table"); +@@ -1046,9 +1062,9 @@ static int python_export_comm_thread(struct db_export *dbe, u64 db_id, + + t = tuple_new(3); + +- tuple_set_u64(t, 0, db_id); +- tuple_set_u64(t, 1, comm->db_id); +- tuple_set_u64(t, 2, thread->db_id); ++ tuple_set_d64(t, 0, db_id); ++ tuple_set_d64(t, 1, comm->db_id); ++ tuple_set_d64(t, 2, thread->db_id); + + call_object(tables->comm_thread_handler, t, "comm_thread_table"); + +@@ -1068,8 +1084,8 @@ static int python_export_dso(struct db_export *dbe, struct dso *dso, + + t = tuple_new(5); + +- tuple_set_u64(t, 0, dso->db_id); +- tuple_set_u64(t, 1, machine->db_id); ++ tuple_set_d64(t, 0, dso->db_id); ++ tuple_set_d64(t, 1, machine->db_id); + tuple_set_string(t, 2, dso->short_name); + tuple_set_string(t, 3, dso->long_name); + tuple_set_string(t, 4, sbuild_id); +@@ -1090,10 +1106,10 @@ static int python_export_symbol(struct db_export *dbe, struct symbol *sym, + + t = tuple_new(6); + +- tuple_set_u64(t, 0, *sym_db_id); +- tuple_set_u64(t, 1, dso->db_id); +- tuple_set_u64(t, 2, sym->start); +- tuple_set_u64(t, 3, sym->end); ++ tuple_set_d64(t, 0, *sym_db_id); ++ tuple_set_d64(t, 1, dso->db_id); ++ tuple_set_d64(t, 2, sym->start); ++ tuple_set_d64(t, 3, sym->end); + tuple_set_s32(t, 4, sym->binding); + tuple_set_string(t, 5, sym->name); + +@@ -1130,30 +1146,30 @@ static void python_export_sample_table(struct db_export *dbe, + + t = tuple_new(24); + +- tuple_set_u64(t, 0, es->db_id); +- tuple_set_u64(t, 1, es->evsel->db_id); +- tuple_set_u64(t, 2, es->al->maps->machine->db_id); +- tuple_set_u64(t, 3, es->al->thread->db_id); +- tuple_set_u64(t, 4, es->comm_db_id); +- tuple_set_u64(t, 5, es->dso_db_id); +- tuple_set_u64(t, 6, es->sym_db_id); +- tuple_set_u64(t, 7, es->offset); +- tuple_set_u64(t, 8, es->sample->ip); +- tuple_set_u64(t, 9, es->sample->time); ++ tuple_set_d64(t, 0, es->db_id); ++ tuple_set_d64(t, 1, es->evsel->db_id); ++ tuple_set_d64(t, 2, es->al->maps->machine->db_id); ++ tuple_set_d64(t, 3, es->al->thread->db_id); ++ tuple_set_d64(t, 4, es->comm_db_id); ++ tuple_set_d64(t, 5, es->dso_db_id); ++ tuple_set_d64(t, 6, es->sym_db_id); ++ tuple_set_d64(t, 7, es->offset); ++ tuple_set_d64(t, 8, es->sample->ip); ++ tuple_set_d64(t, 9, es->sample->time); + tuple_set_s32(t, 10, es->sample->cpu); +- tuple_set_u64(t, 11, es->addr_dso_db_id); +- tuple_set_u64(t, 12, es->addr_sym_db_id); +- tuple_set_u64(t, 13, es->addr_offset); +- tuple_set_u64(t, 14, es->sample->addr); +- tuple_set_u64(t, 15, es->sample->period); +- tuple_set_u64(t, 16, es->sample->weight); +- tuple_set_u64(t, 17, es->sample->transaction); +- tuple_set_u64(t, 18, es->sample->data_src); ++ tuple_set_d64(t, 11, es->addr_dso_db_id); ++ tuple_set_d64(t, 12, es->addr_sym_db_id); ++ tuple_set_d64(t, 13, es->addr_offset); ++ tuple_set_d64(t, 14, es->sample->addr); ++ tuple_set_d64(t, 15, es->sample->period); ++ tuple_set_d64(t, 16, es->sample->weight); ++ tuple_set_d64(t, 17, es->sample->transaction); ++ tuple_set_d64(t, 18, es->sample->data_src); + tuple_set_s32(t, 19, es->sample->flags & PERF_BRANCH_MASK); + tuple_set_s32(t, 20, !!(es->sample->flags & PERF_IP_FLAG_IN_TX)); +- tuple_set_u64(t, 21, es->call_path_id); +- tuple_set_u64(t, 22, es->sample->insn_cnt); +- tuple_set_u64(t, 23, es->sample->cyc_cnt); ++ tuple_set_d64(t, 21, es->call_path_id); ++ tuple_set_d64(t, 22, es->sample->insn_cnt); ++ tuple_set_d64(t, 23, es->sample->cyc_cnt); + + call_object(tables->sample_handler, t, "sample_table"); + +@@ -1167,8 +1183,8 @@ static void python_export_synth(struct db_export *dbe, struct export_sample *es) + + t = tuple_new(3); + +- tuple_set_u64(t, 0, es->db_id); +- tuple_set_u64(t, 1, es->evsel->core.attr.config); ++ tuple_set_d64(t, 0, es->db_id); ++ tuple_set_d64(t, 1, es->evsel->core.attr.config); + tuple_set_bytes(t, 2, es->sample->raw_data, es->sample->raw_size); + + call_object(tables->synth_handler, t, "synth_data"); +@@ -1200,10 +1216,10 @@ static int python_export_call_path(struct db_export *dbe, struct call_path *cp) + + t = tuple_new(4); + +- tuple_set_u64(t, 0, cp->db_id); +- tuple_set_u64(t, 1, parent_db_id); +- tuple_set_u64(t, 2, sym_db_id); +- tuple_set_u64(t, 3, cp->ip); ++ tuple_set_d64(t, 0, cp->db_id); ++ tuple_set_d64(t, 1, parent_db_id); ++ tuple_set_d64(t, 2, sym_db_id); ++ tuple_set_d64(t, 3, cp->ip); + + call_object(tables->call_path_handler, t, "call_path_table"); + +@@ -1221,20 +1237,20 @@ static int python_export_call_return(struct db_export *dbe, + + t = tuple_new(14); + +- tuple_set_u64(t, 0, cr->db_id); +- tuple_set_u64(t, 1, cr->thread->db_id); +- tuple_set_u64(t, 2, comm_db_id); +- tuple_set_u64(t, 3, cr->cp->db_id); +- tuple_set_u64(t, 4, cr->call_time); +- tuple_set_u64(t, 5, cr->return_time); +- tuple_set_u64(t, 6, cr->branch_count); +- tuple_set_u64(t, 7, cr->call_ref); +- tuple_set_u64(t, 8, cr->return_ref); +- tuple_set_u64(t, 9, cr->cp->parent->db_id); ++ tuple_set_d64(t, 0, cr->db_id); ++ tuple_set_d64(t, 1, cr->thread->db_id); ++ tuple_set_d64(t, 2, comm_db_id); ++ tuple_set_d64(t, 3, cr->cp->db_id); ++ tuple_set_d64(t, 4, cr->call_time); ++ tuple_set_d64(t, 5, cr->return_time); ++ tuple_set_d64(t, 6, cr->branch_count); ++ tuple_set_d64(t, 7, cr->call_ref); ++ tuple_set_d64(t, 8, cr->return_ref); ++ tuple_set_d64(t, 9, cr->cp->parent->db_id); + tuple_set_s32(t, 10, cr->flags); +- tuple_set_u64(t, 11, cr->parent_db_id); +- tuple_set_u64(t, 12, cr->insn_count); +- tuple_set_u64(t, 13, cr->cyc_count); ++ tuple_set_d64(t, 11, cr->parent_db_id); ++ tuple_set_d64(t, 12, cr->insn_count); ++ tuple_set_d64(t, 13, cr->cyc_count); + + call_object(tables->call_return_handler, t, "call_return_table"); + +@@ -1254,14 +1270,14 @@ static int python_export_context_switch(struct db_export *dbe, u64 db_id, + + t = tuple_new(9); + +- tuple_set_u64(t, 0, db_id); +- tuple_set_u64(t, 1, machine->db_id); +- tuple_set_u64(t, 2, sample->time); ++ tuple_set_d64(t, 0, db_id); ++ tuple_set_d64(t, 1, machine->db_id); ++ tuple_set_d64(t, 2, sample->time); + tuple_set_s32(t, 3, sample->cpu); +- tuple_set_u64(t, 4, th_out_id); +- tuple_set_u64(t, 5, comm_out_id); +- tuple_set_u64(t, 6, th_in_id); +- tuple_set_u64(t, 7, comm_in_id); ++ tuple_set_d64(t, 4, th_out_id); ++ tuple_set_d64(t, 5, comm_out_id); ++ tuple_set_d64(t, 6, th_in_id); ++ tuple_set_d64(t, 7, comm_in_id); + tuple_set_s32(t, 8, flags); + + call_object(tables->context_switch_handler, t, "context_switch"); +-- +2.30.2 + diff --git a/queue-5.10/phy-ti-dm816x-fix-the-error-handling-path-in-dm816x_.patch b/queue-5.10/phy-ti-dm816x-fix-the-error-handling-path-in-dm816x_.patch new file mode 100644 index 00000000000..0828aa8a495 --- /dev/null +++ b/queue-5.10/phy-ti-dm816x-fix-the-error-handling-path-in-dm816x_.patch @@ -0,0 +1,62 @@ +From 517fefb3d46c65786b3a48052ab0ec7c0f84b47d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 5 Jun 2021 15:17:43 +0200 +Subject: phy: ti: dm816x: Fix the error handling path in + 'dm816x_usb_phy_probe() + +From: Christophe JAILLET + +[ Upstream commit f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f ] + +Add an error handling path in the probe to release some resources, as +already done in the remove function. + +Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY") +Signed-off-by: Christophe JAILLET +Link: https://lore.kernel.org/r/ac5136881f6bdec50be19b3bf73b3bc1b15ef1f1.1622898974.git.christophe.jaillet@wanadoo.fr +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/phy/ti/phy-dm816x-usb.c | 17 +++++++++++++---- + 1 file changed, 13 insertions(+), 4 deletions(-) + +diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x-usb.c +index 57adc08a89b2..9fe6ea6fdae5 100644 +--- a/drivers/phy/ti/phy-dm816x-usb.c ++++ b/drivers/phy/ti/phy-dm816x-usb.c +@@ -242,19 +242,28 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev) + + pm_runtime_enable(phy->dev); + generic_phy = devm_phy_create(phy->dev, NULL, &ops); +- if (IS_ERR(generic_phy)) +- return PTR_ERR(generic_phy); ++ if (IS_ERR(generic_phy)) { ++ error = PTR_ERR(generic_phy); ++ goto clk_unprepare; ++ } + + phy_set_drvdata(generic_phy, phy); + + phy_provider = devm_of_phy_provider_register(phy->dev, + of_phy_simple_xlate); +- if (IS_ERR(phy_provider)) +- return PTR_ERR(phy_provider); ++ if (IS_ERR(phy_provider)) { ++ error = PTR_ERR(phy_provider); ++ goto clk_unprepare; ++ } + + usb_add_phy_dev(&phy->phy); + + return 0; ++ ++clk_unprepare: ++ pm_runtime_disable(phy->dev); ++ clk_unprepare(phy->refclk); ++ return error; + } + + static int dm816x_usb_phy_remove(struct platform_device *pdev) +-- +2.30.2 + diff --git a/queue-5.10/phy-uniphier-pcie-fix-updating-phy-parameters.patch b/queue-5.10/phy-uniphier-pcie-fix-updating-phy-parameters.patch new file mode 100644 index 00000000000..b1e915b7f55 --- /dev/null +++ b/queue-5.10/phy-uniphier-pcie-fix-updating-phy-parameters.patch @@ -0,0 +1,63 @@ +From c89e59b5fada1e4649f3dc0ad87363ec895610a9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 12:50:42 +0900 +Subject: phy: uniphier-pcie: Fix updating phy parameters + +From: Kunihiko Hayashi + +[ Upstream commit 4a90bbb478dbf18ecdec9dcf8eb708e319d24264 ] + +The current driver uses a value from register TEST_O as the original +value for register TEST_I, though, the value is overwritten by "param", +so there is a bug that the original value isn't no longer used. + +The value of TEST_O[7:0] should be masked with "mask", replaced with +"param", and placed in the bitfield TESTI_DAT_MASK as new TEST_I value. + +Fixes: c6d9b1324159 ("phy: socionext: add PCIe PHY driver support") +Signed-off-by: Kunihiko Hayashi +Link: https://lore.kernel.org/r/1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/phy/socionext/phy-uniphier-pcie.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/drivers/phy/socionext/phy-uniphier-pcie.c b/drivers/phy/socionext/phy-uniphier-pcie.c +index e4adab375c73..6bdbd1f214dd 100644 +--- a/drivers/phy/socionext/phy-uniphier-pcie.c ++++ b/drivers/phy/socionext/phy-uniphier-pcie.c +@@ -24,11 +24,13 @@ + #define PORT_SEL_1 FIELD_PREP(PORT_SEL_MASK, 1) + + #define PCL_PHY_TEST_I 0x2000 +-#define PCL_PHY_TEST_O 0x2004 + #define TESTI_DAT_MASK GENMASK(13, 6) + #define TESTI_ADR_MASK GENMASK(5, 1) + #define TESTI_WR_EN BIT(0) + ++#define PCL_PHY_TEST_O 0x2004 ++#define TESTO_DAT_MASK GENMASK(7, 0) ++ + #define PCL_PHY_RESET 0x200c + #define PCL_PHY_RESET_N_MNMODE BIT(8) /* =1:manual */ + #define PCL_PHY_RESET_N BIT(0) /* =1:deasssert */ +@@ -77,11 +79,12 @@ static void uniphier_pciephy_set_param(struct uniphier_pciephy_priv *priv, + val = FIELD_PREP(TESTI_DAT_MASK, 1); + val |= FIELD_PREP(TESTI_ADR_MASK, reg); + uniphier_pciephy_testio_write(priv, val); +- val = readl(priv->base + PCL_PHY_TEST_O); ++ val = readl(priv->base + PCL_PHY_TEST_O) & TESTO_DAT_MASK; + + /* update value */ +- val &= ~FIELD_PREP(TESTI_DAT_MASK, mask); +- val = FIELD_PREP(TESTI_DAT_MASK, mask & param); ++ val &= ~mask; ++ val |= mask & param; ++ val = FIELD_PREP(TESTI_DAT_MASK, val); + val |= FIELD_PREP(TESTI_ADR_MASK, reg); + uniphier_pciephy_testio_write(priv, val); + uniphier_pciephy_testio_write(priv, val | TESTI_WR_EN); +-- +2.30.2 + diff --git a/queue-5.10/pinctrl-renesas-r8a7796-add-missing-bias-for-preset-.patch b/queue-5.10/pinctrl-renesas-r8a7796-add-missing-bias-for-preset-.patch new file mode 100644 index 00000000000..b0107060d9c --- /dev/null +++ b/queue-5.10/pinctrl-renesas-r8a7796-add-missing-bias-for-preset-.patch @@ -0,0 +1,49 @@ +From b010d4f7b043ec9fd27b49f9dbbd2ba764e6f50d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 30 Apr 2021 14:31:00 +0200 +Subject: pinctrl: renesas: r8a7796: Add missing bias for PRESET# pin +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Geert Uytterhoeven + +[ Upstream commit 2cee31cd49733e89dfedf4f68a56839fc2e42040 ] + +R-Car Gen3 Hardware Manual Errata for Rev. 0.52 of Nov 30, 2016, added +the configuration bit for bias pull-down control for the PRESET# pin on +R-Car M3-W. Add driver support for controlling pull-down on this pin. + +Fixes: 2d40bd24274d2577 ("pinctrl: sh-pfc: r8a7796: Add bias pinconf support") +Signed-off-by: Geert Uytterhoeven +Reviewed-by: Niklas Söderlund +Link: https://lore.kernel.org/r/c479de5b3f235c2f7d5faea9e7e08e6fccb135df.1619785375.git.geert+renesas@glider.be +Signed-off-by: Sasha Levin +--- + drivers/pinctrl/renesas/pfc-r8a7796.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/pinctrl/renesas/pfc-r8a7796.c b/drivers/pinctrl/renesas/pfc-r8a7796.c +index 55f0344a3d3e..3878d6b0db14 100644 +--- a/drivers/pinctrl/renesas/pfc-r8a7796.c ++++ b/drivers/pinctrl/renesas/pfc-r8a7796.c +@@ -68,6 +68,7 @@ + PIN_NOGP_CFG(QSPI1_MOSI_IO0, "QSPI1_MOSI_IO0", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(QSPI1_SPCLK, "QSPI1_SPCLK", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(QSPI1_SSL, "QSPI1_SSL", fn, CFG_FLAGS), \ ++ PIN_NOGP_CFG(PRESET_N, "PRESET#", fn, SH_PFC_PIN_CFG_PULL_DOWN),\ + PIN_NOGP_CFG(RPC_INT_N, "RPC_INT#", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(RPC_RESET_N, "RPC_RESET#", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(RPC_WP_N, "RPC_WP#", fn, CFG_FLAGS), \ +@@ -6109,7 +6110,7 @@ static const struct pinmux_bias_reg pinmux_bias_regs[] = { + [ 4] = RCAR_GP_PIN(6, 29), /* USB30_OVC */ + [ 5] = RCAR_GP_PIN(6, 30), /* GP6_30 */ + [ 6] = RCAR_GP_PIN(6, 31), /* GP6_31 */ +- [ 7] = SH_PFC_PIN_NONE, ++ [ 7] = PIN_PRESET_N, /* PRESET# */ + [ 8] = SH_PFC_PIN_NONE, + [ 9] = SH_PFC_PIN_NONE, + [10] = SH_PFC_PIN_NONE, +-- +2.30.2 + diff --git a/queue-5.10/pinctrl-renesas-r8a77990-jtag-pins-do-not-have-pull-.patch b/queue-5.10/pinctrl-renesas-r8a77990-jtag-pins-do-not-have-pull-.patch new file mode 100644 index 00000000000..91049927842 --- /dev/null +++ b/queue-5.10/pinctrl-renesas-r8a77990-jtag-pins-do-not-have-pull-.patch @@ -0,0 +1,47 @@ +From 04cec677058a3d94a18515fa3a0793129a891c34 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 30 Apr 2021 14:31:01 +0200 +Subject: pinctrl: renesas: r8a77990: JTAG pins do not have pull-down + capabilities +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Geert Uytterhoeven + +[ Upstream commit 702a5fa2fe4d7e7f28fed92a170b540acfff9d34 ] + +Hence remove the SH_PFC_PIN_CFG_PULL_DOWN flags from their pin +descriptions. + +Fixes: 83f6941a42a5e773 ("pinctrl: sh-pfc: r8a77990: Add bias pinconf support") +Signed-off-by: Geert Uytterhoeven +Reviewed-by: Niklas Söderlund +Link: https://lore.kernel.org/r/da4b2d69955840a506412f1e8099607a0da97ecc.1619785375.git.geert+renesas@glider.be +Signed-off-by: Sasha Levin +--- + drivers/pinctrl/renesas/pfc-r8a77990.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl/renesas/pfc-r8a77990.c +index aed04a4c6116..240aadc4611f 100644 +--- a/drivers/pinctrl/renesas/pfc-r8a77990.c ++++ b/drivers/pinctrl/renesas/pfc-r8a77990.c +@@ -54,10 +54,10 @@ + PIN_NOGP_CFG(FSCLKST_N, "FSCLKST_N", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(MLB_REF, "MLB_REF", fn, CFG_FLAGS), \ + PIN_NOGP_CFG(PRESETOUT_N, "PRESETOUT_N", fn, CFG_FLAGS), \ +- PIN_NOGP_CFG(TCK, "TCK", fn, CFG_FLAGS), \ +- PIN_NOGP_CFG(TDI, "TDI", fn, CFG_FLAGS), \ +- PIN_NOGP_CFG(TMS, "TMS", fn, CFG_FLAGS), \ +- PIN_NOGP_CFG(TRST_N, "TRST_N", fn, CFG_FLAGS) ++ PIN_NOGP_CFG(TCK, "TCK", fn, SH_PFC_PIN_CFG_PULL_UP), \ ++ PIN_NOGP_CFG(TDI, "TDI", fn, SH_PFC_PIN_CFG_PULL_UP), \ ++ PIN_NOGP_CFG(TMS, "TMS", fn, SH_PFC_PIN_CFG_PULL_UP), \ ++ PIN_NOGP_CFG(TRST_N, "TRST_N", fn, SH_PFC_PIN_CFG_PULL_UP) + + /* + * F_() : just information +-- +2.30.2 + diff --git a/queue-5.10/pkt_sched-sch_qfq-fix-qfq_change_class-error-path.patch b/queue-5.10/pkt_sched-sch_qfq-fix-qfq_change_class-error-path.patch new file mode 100644 index 00000000000..96c994cfb95 --- /dev/null +++ b/queue-5.10/pkt_sched-sch_qfq-fix-qfq_change_class-error-path.patch @@ -0,0 +1,203 @@ +From ff5742e7d3345627021e46afcfc7e9f45dacc31f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 10:54:49 -0700 +Subject: pkt_sched: sch_qfq: fix qfq_change_class() error path + +From: Eric Dumazet + +[ Upstream commit 0cd58e5c53babb9237b741dbef711f0a9eb6d3fd ] + +If qfq_change_class() is unable to allocate memory for qfq_aggregate, +it frees the class that has been inserted in the class hash table, +but does not unhash it. + +Defer the insertion after the problematic allocation. + +BUG: KASAN: use-after-free in hlist_add_head include/linux/list.h:884 [inline] +BUG: KASAN: use-after-free in qdisc_class_hash_insert+0x200/0x210 net/sched/sch_api.c:731 +Write of size 8 at addr ffff88814a534f10 by task syz-executor.4/31478 + +CPU: 0 PID: 31478 Comm: syz-executor.4 Not tainted 5.13.0-rc6-syzkaller #0 +Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 +Call Trace: + __dump_stack lib/dump_stack.c:79 [inline] + dump_stack+0x141/0x1d7 lib/dump_stack.c:120 + print_address_description.constprop.0.cold+0x5b/0x2f8 mm/kasan/report.c:233 + __kasan_report mm/kasan/report.c:419 [inline] + kasan_report.cold+0x7c/0xd8 mm/kasan/report.c:436 + hlist_add_head include/linux/list.h:884 [inline] + qdisc_class_hash_insert+0x200/0x210 net/sched/sch_api.c:731 + qfq_change_class+0x96c/0x1990 net/sched/sch_qfq.c:489 + tc_ctl_tclass+0x514/0xe50 net/sched/sch_api.c:2113 + rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5564 + netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504 + netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] + netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340 + netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1929 + sock_sendmsg_nosec net/socket.c:654 [inline] + sock_sendmsg+0xcf/0x120 net/socket.c:674 + ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350 + ___sys_sendmsg+0xf3/0x170 net/socket.c:2404 + __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433 + do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47 + entry_SYSCALL_64_after_hwframe+0x44/0xae +RIP: 0033:0x4665d9 +Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 +RSP: 002b:00007fdc7b5f0188 EFLAGS: 00000246 ORIG_RAX: 000000000000002e +RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665d9 +RDX: 0000000000000000 RSI: 00000000200001c0 RDI: 0000000000000003 +RBP: 00007fdc7b5f01d0 R08: 0000000000000000 R09: 0000000000000000 +R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002 +R13: 00007ffcf7310b3f R14: 00007fdc7b5f0300 R15: 0000000000022000 + +Allocated by task 31445: + kasan_save_stack+0x1b/0x40 mm/kasan/common.c:38 + kasan_set_track mm/kasan/common.c:46 [inline] + set_alloc_info mm/kasan/common.c:428 [inline] + ____kasan_kmalloc mm/kasan/common.c:507 [inline] + ____kasan_kmalloc mm/kasan/common.c:466 [inline] + __kasan_kmalloc+0x9b/0xd0 mm/kasan/common.c:516 + kmalloc include/linux/slab.h:556 [inline] + kzalloc include/linux/slab.h:686 [inline] + qfq_change_class+0x705/0x1990 net/sched/sch_qfq.c:464 + tc_ctl_tclass+0x514/0xe50 net/sched/sch_api.c:2113 + rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5564 + netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504 + netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] + netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340 + netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1929 + sock_sendmsg_nosec net/socket.c:654 [inline] + sock_sendmsg+0xcf/0x120 net/socket.c:674 + ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350 + ___sys_sendmsg+0xf3/0x170 net/socket.c:2404 + __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433 + do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47 + entry_SYSCALL_64_after_hwframe+0x44/0xae + +Freed by task 31445: + kasan_save_stack+0x1b/0x40 mm/kasan/common.c:38 + kasan_set_track+0x1c/0x30 mm/kasan/common.c:46 + kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:357 + ____kasan_slab_free mm/kasan/common.c:360 [inline] + ____kasan_slab_free mm/kasan/common.c:325 [inline] + __kasan_slab_free+0xfb/0x130 mm/kasan/common.c:368 + kasan_slab_free include/linux/kasan.h:212 [inline] + slab_free_hook mm/slub.c:1583 [inline] + slab_free_freelist_hook+0xdf/0x240 mm/slub.c:1608 + slab_free mm/slub.c:3168 [inline] + kfree+0xe5/0x7f0 mm/slub.c:4212 + qfq_change_class+0x10fb/0x1990 net/sched/sch_qfq.c:518 + tc_ctl_tclass+0x514/0xe50 net/sched/sch_api.c:2113 + rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5564 + netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504 + netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] + netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340 + netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1929 + sock_sendmsg_nosec net/socket.c:654 [inline] + sock_sendmsg+0xcf/0x120 net/socket.c:674 + ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350 + ___sys_sendmsg+0xf3/0x170 net/socket.c:2404 + __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433 + do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47 + entry_SYSCALL_64_after_hwframe+0x44/0xae + +The buggy address belongs to the object at ffff88814a534f00 + which belongs to the cache kmalloc-128 of size 128 +The buggy address is located 16 bytes inside of + 128-byte region [ffff88814a534f00, ffff88814a534f80) +The buggy address belongs to the page: +page:ffffea0005294d00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x14a534 +flags: 0x57ff00000000200(slab|node=1|zone=2|lastcpupid=0x7ff) +raw: 057ff00000000200 ffffea00004fee00 0000000600000006 ffff8880110418c0 +raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 +page dumped because: kasan: bad access detected +page_owner tracks the page as allocated +page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY), pid 29797, ts 604817765317, free_ts 604810151744 + prep_new_page mm/page_alloc.c:2358 [inline] + get_page_from_freelist+0x1033/0x2b60 mm/page_alloc.c:3994 + __alloc_pages+0x1b2/0x500 mm/page_alloc.c:5200 + alloc_pages+0x18c/0x2a0 mm/mempolicy.c:2272 + alloc_slab_page mm/slub.c:1646 [inline] + allocate_slab+0x2c5/0x4c0 mm/slub.c:1786 + new_slab mm/slub.c:1849 [inline] + new_slab_objects mm/slub.c:2595 [inline] + ___slab_alloc+0x4a1/0x810 mm/slub.c:2758 + __slab_alloc.constprop.0+0xa7/0xf0 mm/slub.c:2798 + slab_alloc_node mm/slub.c:2880 [inline] + slab_alloc mm/slub.c:2922 [inline] + __kmalloc+0x315/0x330 mm/slub.c:4050 + kmalloc include/linux/slab.h:561 [inline] + kzalloc include/linux/slab.h:686 [inline] + __register_sysctl_table+0x112/0x1090 fs/proc/proc_sysctl.c:1318 + mpls_dev_sysctl_register+0x1b7/0x2d0 net/mpls/af_mpls.c:1421 + mpls_add_dev net/mpls/af_mpls.c:1472 [inline] + mpls_dev_notify+0x214/0x8b0 net/mpls/af_mpls.c:1588 + notifier_call_chain+0xb5/0x200 kernel/notifier.c:83 + call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:2121 + call_netdevice_notifiers_extack net/core/dev.c:2133 [inline] + call_netdevice_notifiers net/core/dev.c:2147 [inline] + register_netdevice+0x106b/0x1500 net/core/dev.c:10312 + veth_newlink+0x585/0xac0 drivers/net/veth.c:1547 + __rtnl_newlink+0x1062/0x1710 net/core/rtnetlink.c:3452 + rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3500 +page last free stack trace: + reset_page_owner include/linux/page_owner.h:24 [inline] + free_pages_prepare mm/page_alloc.c:1298 [inline] + free_pcp_prepare+0x223/0x300 mm/page_alloc.c:1342 + free_unref_page_prepare mm/page_alloc.c:3250 [inline] + free_unref_page+0x12/0x1d0 mm/page_alloc.c:3298 + __vunmap+0x783/0xb60 mm/vmalloc.c:2566 + free_work+0x58/0x70 mm/vmalloc.c:80 + process_one_work+0x98d/0x1600 kernel/workqueue.c:2276 + worker_thread+0x64c/0x1120 kernel/workqueue.c:2422 + kthread+0x3b1/0x4a0 kernel/kthread.c:313 + ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 + +Memory state around the buggy address: + ffff88814a534e00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb + ffff88814a534e80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc +>ffff88814a534f00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb + ^ + ffff88814a534f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc + ffff88814a535000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 + +Fixes: 462dbc9101acd ("pkt_sched: QFQ Plus: fair-queueing service at DRR cost") +Signed-off-by: Eric Dumazet +Reported-by: syzbot +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/sched/sch_qfq.c | 8 +++----- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c +index 6335230a971e..ade2d6ddc914 100644 +--- a/net/sched/sch_qfq.c ++++ b/net/sched/sch_qfq.c +@@ -485,11 +485,6 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid, + + if (cl->qdisc != &noop_qdisc) + qdisc_hash_add(cl->qdisc, true); +- sch_tree_lock(sch); +- qdisc_class_hash_insert(&q->clhash, &cl->common); +- sch_tree_unlock(sch); +- +- qdisc_class_hash_grow(sch, &q->clhash); + + set_change_agg: + sch_tree_lock(sch); +@@ -507,8 +502,11 @@ set_change_agg: + } + if (existing) + qfq_deact_rm_from_agg(q, cl); ++ else ++ qdisc_class_hash_insert(&q->clhash, &cl->common); + qfq_add_to_agg(q, new_agg, cl); + sch_tree_unlock(sch); ++ qdisc_class_hash_grow(sch, &q->clhash); + + *arg = (unsigned long)cl; + return 0; +-- +2.30.2 + diff --git a/queue-5.10/platform-x86-asus-nb-wmi-revert-add-support-for-asus.patch b/queue-5.10/platform-x86-asus-nb-wmi-revert-add-support-for-asus.patch new file mode 100644 index 00000000000..6ca191072de --- /dev/null +++ b/queue-5.10/platform-x86-asus-nb-wmi-revert-add-support-for-asus.patch @@ -0,0 +1,134 @@ +From 3d226e4281036b675fb07a79b1ca635fb975f323 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 19 Apr 2021 19:49:15 +1200 +Subject: platform/x86: asus-nb-wmi: Revert "add support for ASUS ROG Zephyrus + G14 and G15" + +From: Luke D. Jones + +[ Upstream commit 28117f3a5c3c8375a3304af76357d5bf9cf30f0b ] + +The quirks added to asus-nb-wmi for the ASUS ROG Zephyrus G14 and G15 are +wrong, they tell the asus-wmi code to use the vendor specific WMI backlight +interface. But there is no such interface on these laptops. + +As a side effect, these quirks stop the acpi_video driver to register since +they make acpi_video_get_backlight_type() return acpi_backlight_vendor, +leaving only the native AMD backlight driver in place, which is the one we +want. This happy coincidence is being replaced with a new quirk in +drivers/acpi/video_detect.c which actually sets the backlight_type to +acpi_backlight_native fixinf this properly. This reverts +commit 13bceda68fb9 ("platform/x86: asus-nb-wmi: add support for ASUS ROG +Zephyrus G14 and G15"). + +Signed-off-by: Luke D. Jones +Link: https://lore.kernel.org/r/20210419074915.393433-3-luke@ljones.dev +Signed-off-by: Hans de Goede +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/asus-nb-wmi.c | 82 ------------------------------ + 1 file changed, 82 deletions(-) + +diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c +index ff39079e2d75..949ddeb673bc 100644 +--- a/drivers/platform/x86/asus-nb-wmi.c ++++ b/drivers/platform/x86/asus-nb-wmi.c +@@ -110,16 +110,6 @@ static struct quirk_entry quirk_asus_forceals = { + .wmi_force_als_set = true, + }; + +-static struct quirk_entry quirk_asus_ga401i = { +- .wmi_backlight_power = true, +- .wmi_backlight_set_devstate = true, +-}; +- +-static struct quirk_entry quirk_asus_ga502i = { +- .wmi_backlight_power = true, +- .wmi_backlight_set_devstate = true, +-}; +- + static struct quirk_entry quirk_asus_use_kbd_dock_devid = { + .use_kbd_dock_devid = true, + }; +@@ -425,78 +415,6 @@ static const struct dmi_system_id asus_quirks[] = { + }, + .driver_data = &quirk_asus_forceals, + }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA401IH", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA401IH"), +- }, +- .driver_data = &quirk_asus_ga401i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA401II", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA401II"), +- }, +- .driver_data = &quirk_asus_ga401i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA401IU", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA401IU"), +- }, +- .driver_data = &quirk_asus_ga401i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA401IV", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA401IV"), +- }, +- .driver_data = &quirk_asus_ga401i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA401IVC", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA401IVC"), +- }, +- .driver_data = &quirk_asus_ga401i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA502II", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA502II"), +- }, +- .driver_data = &quirk_asus_ga502i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA502IU", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA502IU"), +- }, +- .driver_data = &quirk_asus_ga502i, +- }, +- { +- .callback = dmi_matched, +- .ident = "ASUSTeK COMPUTER INC. GA502IV", +- .matches = { +- DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_MATCH(DMI_PRODUCT_NAME, "GA502IV"), +- }, +- .driver_data = &quirk_asus_ga502i, +- }, + { + .callback = dmi_matched, + .ident = "Asus Transformer T100TA / T100HA / T100CHI", +-- +2.30.2 + diff --git a/queue-5.10/platform-x86-asus-nb-wmi-revert-drop-duplicate-dmi-q.patch b/queue-5.10/platform-x86-asus-nb-wmi-revert-drop-duplicate-dmi-q.patch new file mode 100644 index 00000000000..526d5e7979b --- /dev/null +++ b/queue-5.10/platform-x86-asus-nb-wmi-revert-drop-duplicate-dmi-q.patch @@ -0,0 +1,116 @@ +From 93bcb3cbe0be64bd6fb1f90bbfca5d83b4d9a1b1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 19 Apr 2021 19:49:14 +1200 +Subject: platform/x86: asus-nb-wmi: Revert "Drop duplicate DMI quirk + structures" + +From: Luke D. Jones + +[ Upstream commit 98c0c85b1040db24f0d04d3e1d315c6c7b05cc07 ] + +This is a preparation revert for reverting the "add support for ASUS ROG +Zephyrus G14 and G15" change. This reverts +commit 67186653c903 ("platform/x86: asus-nb-wmi: Drop duplicate DMI quirk +structures") + +Signed-off-by: Luke D. Jones +Link: https://lore.kernel.org/r/20210419074915.393433-2-luke@ljones.dev +Signed-off-by: Hans de Goede +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/asus-nb-wmi.c | 23 ++++++++++++++--------- + 1 file changed, 14 insertions(+), 9 deletions(-) + +diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c +index 1d9fbabd02fb..ff39079e2d75 100644 +--- a/drivers/platform/x86/asus-nb-wmi.c ++++ b/drivers/platform/x86/asus-nb-wmi.c +@@ -110,7 +110,12 @@ static struct quirk_entry quirk_asus_forceals = { + .wmi_force_als_set = true, + }; + +-static struct quirk_entry quirk_asus_vendor_backlight = { ++static struct quirk_entry quirk_asus_ga401i = { ++ .wmi_backlight_power = true, ++ .wmi_backlight_set_devstate = true, ++}; ++ ++static struct quirk_entry quirk_asus_ga502i = { + .wmi_backlight_power = true, + .wmi_backlight_set_devstate = true, + }; +@@ -427,7 +432,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IH"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga401i, + }, + { + .callback = dmi_matched, +@@ -436,7 +441,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401II"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga401i, + }, + { + .callback = dmi_matched, +@@ -445,7 +450,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IU"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga401i, + }, + { + .callback = dmi_matched, +@@ -454,7 +459,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IV"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga401i, + }, + { + .callback = dmi_matched, +@@ -463,7 +468,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IVC"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga401i, + }, + { + .callback = dmi_matched, +@@ -472,7 +477,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502II"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga502i, + }, + { + .callback = dmi_matched, +@@ -481,7 +486,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IU"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga502i, + }, + { + .callback = dmi_matched, +@@ -490,7 +495,7 @@ static const struct dmi_system_id asus_quirks[] = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IV"), + }, +- .driver_data = &quirk_asus_vendor_backlight, ++ .driver_data = &quirk_asus_ga502i, + }, + { + .callback = dmi_matched, +-- +2.30.2 + diff --git a/queue-5.10/platform-x86-toshiba_acpi-fix-missing-error-code-in-.patch b/queue-5.10/platform-x86-toshiba_acpi-fix-missing-error-code-in-.patch new file mode 100644 index 00000000000..82cbeb85ade --- /dev/null +++ b/queue-5.10/platform-x86-toshiba_acpi-fix-missing-error-code-in-.patch @@ -0,0 +1,42 @@ +From e6e2b4409144416ebe91a3d3d53cf322ac091e13 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 2 Jun 2021 18:05:48 +0800 +Subject: platform/x86: toshiba_acpi: Fix missing error code in + toshiba_acpi_setup_keyboard() + +From: Jiapeng Chong + +[ Upstream commit 28e367127718a9cb85d615a71e152f7acee41bfc ] + +The error code is missing in this code scenario, add the error code +'-EINVAL' to the return value 'error'. + +Eliminate the follow smatch warning: + +drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard() +warn: missing error code 'error'. + +Reported-by: Abaci Robot +Signed-off-by: Jiapeng Chong +Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com +Signed-off-by: Hans de Goede +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/toshiba_acpi.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c +index fa7232ad8c39..352508d30467 100644 +--- a/drivers/platform/x86/toshiba_acpi.c ++++ b/drivers/platform/x86/toshiba_acpi.c +@@ -2831,6 +2831,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev) + + if (!dev->info_supported && !dev->system_event_supported) { + pr_warn("No hotkey query interface found\n"); ++ error = -EINVAL; + goto err_remove_filter; + } + +-- +2.30.2 + diff --git a/queue-5.10/platform-x86-touchscreen_dmi-add-an-extra-entry-for-.patch b/queue-5.10/platform-x86-touchscreen_dmi-add-an-extra-entry-for-.patch new file mode 100644 index 00000000000..156f2e3c914 --- /dev/null +++ b/queue-5.10/platform-x86-touchscreen_dmi-add-an-extra-entry-for-.patch @@ -0,0 +1,48 @@ +From 93175c4599f4751d7c58b6b8d8c1a7ac42b1c341 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 20:57:44 +0200 +Subject: platform/x86: touchscreen_dmi: Add an extra entry for the upside down + Goodix touchscreen on Teclast X89 tablets + +From: Hans de Goede + +[ Upstream commit a22e3803f2a4d947ff0083a9448a169269ea0f62 ] + +Teclast X89 tablets come in 2 versions, with Windows pre-installed and with +Android pre-installed. These 2 versions have different DMI strings. + +Add a match for the DMI strings used by the Android version BIOS. + +Note the Android version BIOS has a bug in the DSDT where no IRQ is +provided, so for the touchscreen to work a DSDT override fixing this +is necessary as well. + +Signed-off-by: Hans de Goede +Link: https://lore.kernel.org/r/20210504185746.175461-4-hdegoede@redhat.com +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/touchscreen_dmi.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c +index e52ff09b81de..ebae21b78327 100644 +--- a/drivers/platform/x86/touchscreen_dmi.c ++++ b/drivers/platform/x86/touchscreen_dmi.c +@@ -1285,6 +1285,14 @@ const struct dmi_system_id touchscreen_dmi_table[] = { + DMI_MATCH(DMI_BOARD_NAME, "X3 Plus"), + }, + }, ++ { ++ /* Teclast X89 (Android version / BIOS) */ ++ .driver_data = (void *)&gdix1001_00_upside_down_data, ++ .matches = { ++ DMI_MATCH(DMI_BOARD_VENDOR, "WISKY"), ++ DMI_MATCH(DMI_BOARD_NAME, "3G062i"), ++ }, ++ }, + { + /* Teclast X89 (Windows version / BIOS) */ + .driver_data = (void *)&gdix1001_01_upside_down_data, +-- +2.30.2 + diff --git a/queue-5.10/platform-x86-touchscreen_dmi-add-info-for-the-goodix.patch b/queue-5.10/platform-x86-touchscreen_dmi-add-info-for-the-goodix.patch new file mode 100644 index 00000000000..ac1bbc7e905 --- /dev/null +++ b/queue-5.10/platform-x86-touchscreen_dmi-add-info-for-the-goodix.patch @@ -0,0 +1,76 @@ +From 9b7a5d87df46c8180b3bbf9ffd0983a8ffa7a284 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 4 May 2021 20:57:45 +0200 +Subject: platform/x86: touchscreen_dmi: Add info for the Goodix GT912 panel of + TM800A550L tablets + +From: Hans de Goede + +[ Upstream commit fcd8cf0e3e48f4c66af82c8e799c37cb0cccffe0 ] + +The Bay Trail Glavey TM800A550L tablet, which ships with Android installed +from the factory, uses a GT912 touchscreen controller which needs to have +its firmware uploaded by the OS to work (this is a first for a x86 based +device with a Goodix touchscreen controller). + +Add a touchscreen_dmi entry for this which specifies the filenames +to use for the firmware and config files needed for this. + +Note this matches on a GDIX1001 ACPI HID, while the original DSDT uses +a HID of GODX0911. For the touchscreen to work on these devices a DSDT +override is necessary to fix a missing IRQ and broken GPIO settings in +the ACPI-resources for the touchscreen. This override also changes the +HID to the standard GDIX1001 id typically used for Goodix touchscreens. +The DSDT override is available here: +https://fedorapeople.org/~jwrdegoede/glavey-tm800a550l-dsdt-override/ + +Reviewed-by: Bastien Nocera +Signed-off-by: Hans de Goede +Link: https://lore.kernel.org/r/20210504185746.175461-5-hdegoede@redhat.com +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/touchscreen_dmi.c | 21 +++++++++++++++++++++ + 1 file changed, 21 insertions(+) + +diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c +index ebae21b78327..99260915122c 100644 +--- a/drivers/platform/x86/touchscreen_dmi.c ++++ b/drivers/platform/x86/touchscreen_dmi.c +@@ -316,6 +316,18 @@ static const struct ts_dmi_data gdix1001_01_upside_down_data = { + .properties = gdix1001_upside_down_props, + }; + ++static const struct property_entry glavey_tm800a550l_props[] = { ++ PROPERTY_ENTRY_STRING("firmware-name", "gt912-glavey-tm800a550l.fw"), ++ PROPERTY_ENTRY_STRING("goodix,config-name", "gt912-glavey-tm800a550l.cfg"), ++ PROPERTY_ENTRY_U32("goodix,main-clk", 54), ++ { } ++}; ++ ++static const struct ts_dmi_data glavey_tm800a550l_data = { ++ .acpi_name = "GDIX1001:00", ++ .properties = glavey_tm800a550l_props, ++}; ++ + static const struct property_entry gp_electronic_t701_props[] = { + PROPERTY_ENTRY_U32("touchscreen-size-x", 960), + PROPERTY_ENTRY_U32("touchscreen-size-y", 640), +@@ -1012,6 +1024,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = { + DMI_MATCH(DMI_PRODUCT_NAME, "eSTAR BEAUTY HD Intel Quad core"), + }, + }, ++ { /* Glavey TM800A550L */ ++ .driver_data = (void *)&glavey_tm800a550l_data, ++ .matches = { ++ DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), ++ DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"), ++ /* Above strings are too generic, also match on BIOS version */ ++ DMI_MATCH(DMI_BIOS_VERSION, "ZY-8-BI-PX4S70VTR400-X423B-005-D"), ++ }, ++ }, + { + /* GP-electronic T701 */ + .driver_data = (void *)&gp_electronic_t701_data, +-- +2.30.2 + diff --git a/queue-5.10/pm-devfreq-add-missing-error-code-in-devfreq_add_dev.patch b/queue-5.10/pm-devfreq-add-missing-error-code-in-devfreq_add_dev.patch new file mode 100644 index 00000000000..210ff7ffb67 --- /dev/null +++ b/queue-5.10/pm-devfreq-add-missing-error-code-in-devfreq_add_dev.patch @@ -0,0 +1,34 @@ +From e94efad42a9824f20bc39fbc32b324692f74bd5d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 14:48:43 +0800 +Subject: PM / devfreq: Add missing error code in devfreq_add_device() + +From: YueHaibing + +[ Upstream commit 18b380ed61f892ed06838d1f1a5124d966292ed3 ] + +Set err code in the error path before jumping to the end of the function. + +Fixes: 4dc3bab8687f ("PM / devfreq: Add support delayed timer for polling mode") +Signed-off-by: YueHaibing +Signed-off-by: Chanwoo Choi +Signed-off-by: Sasha Levin +--- + drivers/devfreq/devfreq.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c +index 98f03a02d112..829128c0cc68 100644 +--- a/drivers/devfreq/devfreq.c ++++ b/drivers/devfreq/devfreq.c +@@ -789,6 +789,7 @@ struct devfreq *devfreq_add_device(struct device *dev, + if (devfreq->profile->timer < 0 + || devfreq->profile->timer >= DEVFREQ_TIMER_NUM) { + mutex_unlock(&devfreq->lock); ++ err = -EINVAL; + goto err_dev; + } + +-- +2.30.2 + diff --git a/queue-5.10/powerpc-64s-fix-copy-paste-data-exposure-into-newly-.patch b/queue-5.10/powerpc-64s-fix-copy-paste-data-exposure-into-newly-.patch new file mode 100644 index 00000000000..7c35e853fca --- /dev/null +++ b/queue-5.10/powerpc-64s-fix-copy-paste-data-exposure-into-newly-.patch @@ -0,0 +1,108 @@ +From 2427eb2cf6448dc6d42e20c427b88a7c774a4e23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 15:30:36 +1000 +Subject: powerpc/64s: Fix copy-paste data exposure into newly created tasks + +From: Nicholas Piggin + +[ Upstream commit f35d2f249ef05b9671e7898f09ad89aa78f99122 ] + +copy-paste contains implicit "copy buffer" state that can contain +arbitrary user data (if the user process executes a copy instruction). +This could be snooped by another process if a context switch hits while +the state is live. So cp_abort is executed on context switch to clear +out possible sensitive data and prevent the leak. + +cp_abort is done after the low level _switch(), which means it is never +reached by newly created tasks, so they could snoop on this buffer +between their first and second context switch. + +Fix this by doing the cp_abort before calling _switch. Add some +comments which should make the issue harder to miss. + +Fixes: 07d2a628bc000 ("powerpc/64s: Avoid cpabort in context switch when possible") +Signed-off-by: Nicholas Piggin +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210622053036.474678-1-npiggin@gmail.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/kernel/process.c | 48 +++++++++++++++++++++++------------ + 1 file changed, 32 insertions(+), 16 deletions(-) + +diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c +index 1a1d2657fe8d..3064694afea1 100644 +--- a/arch/powerpc/kernel/process.c ++++ b/arch/powerpc/kernel/process.c +@@ -1227,6 +1227,19 @@ struct task_struct *__switch_to(struct task_struct *prev, + __flush_tlb_pending(batch); + batch->active = 0; + } ++ ++ /* ++ * On POWER9 the copy-paste buffer can only paste into ++ * foreign real addresses, so unprivileged processes can not ++ * see the data or use it in any way unless they have ++ * foreign real mappings. If the new process has the foreign ++ * real address mappings, we must issue a cp_abort to clear ++ * any state and prevent snooping, corruption or a covert ++ * channel. ISA v3.1 supports paste into local memory. ++ */ ++ if (new->mm && (cpu_has_feature(CPU_FTR_ARCH_31) || ++ atomic_read(&new->mm->context.vas_windows))) ++ asm volatile(PPC_CP_ABORT); + #endif /* CONFIG_PPC_BOOK3S_64 */ + + #ifdef CONFIG_PPC_ADV_DEBUG_REGS +@@ -1272,30 +1285,33 @@ struct task_struct *__switch_to(struct task_struct *prev, + + last = _switch(old_thread, new_thread); + ++ /* ++ * Nothing after _switch will be run for newly created tasks, ++ * because they switch directly to ret_from_fork/ret_from_kernel_thread ++ * etc. Code added here should have a comment explaining why that is ++ * okay. ++ */ ++ + #ifdef CONFIG_PPC_BOOK3S_64 ++ /* ++ * This applies to a process that was context switched while inside ++ * arch_enter_lazy_mmu_mode(), to re-activate the batch that was ++ * deactivated above, before _switch(). This will never be the case ++ * for new tasks. ++ */ + if (current_thread_info()->local_flags & _TLF_LAZY_MMU) { + current_thread_info()->local_flags &= ~_TLF_LAZY_MMU; + batch = this_cpu_ptr(&ppc64_tlb_batch); + batch->active = 1; + } + +- if (current->thread.regs) { ++ /* ++ * Math facilities are masked out of the child MSR in copy_thread. ++ * A new task does not need to restore_math because it will ++ * demand fault them. ++ */ ++ if (current->thread.regs) + restore_math(current->thread.regs); +- +- /* +- * On POWER9 the copy-paste buffer can only paste into +- * foreign real addresses, so unprivileged processes can not +- * see the data or use it in any way unless they have +- * foreign real mappings. If the new process has the foreign +- * real address mappings, we must issue a cp_abort to clear +- * any state and prevent snooping, corruption or a covert +- * channel. ISA v3.1 supports paste into local memory. +- */ +- if (current->mm && +- (cpu_has_feature(CPU_FTR_ARCH_31) || +- atomic_read(¤t->mm->context.vas_windows))) +- asm volatile(PPC_CP_ABORT); +- } + #endif /* CONFIG_PPC_BOOK3S_64 */ + + return last; +-- +2.30.2 + diff --git a/queue-5.10/powerpc-offline-cpu-in-stop_this_cpu.patch b/queue-5.10/powerpc-offline-cpu-in-stop_this_cpu.patch new file mode 100644 index 00000000000..fc0b43c37da --- /dev/null +++ b/queue-5.10/powerpc-offline-cpu-in-stop_this_cpu.patch @@ -0,0 +1,61 @@ +From b42c30b432d7c51975755e2746212ef728aabb3c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 14:12:45 +1000 +Subject: powerpc: Offline CPU in stop_this_cpu() + +From: Nicholas Piggin + +[ Upstream commit bab26238bbd44d5a4687c0a64fd2c7f2755ea937 ] + +printk_safe_flush_on_panic() has special lock breaking code for the case +where we panic()ed with the console lock held. It relies on panic IPI +causing other CPUs to mark themselves offline. + +Do as most other architectures do. + +This effectively reverts commit de6e5d38417e ("powerpc: smp_send_stop do +not offline stopped CPUs"), unfortunately it may result in some false +positive warnings, but the alternative is more situations where we can +crash without getting messages out. + +Fixes: de6e5d38417e ("powerpc: smp_send_stop do not offline stopped CPUs") +Signed-off-by: Nicholas Piggin +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210623041245.865134-1-npiggin@gmail.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/kernel/smp.c | 11 +++++++++++ + 1 file changed, 11 insertions(+) + +diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c +index 0760230be56f..26a028a9233a 100644 +--- a/arch/powerpc/kernel/smp.c ++++ b/arch/powerpc/kernel/smp.c +@@ -600,6 +600,8 @@ static void nmi_stop_this_cpu(struct pt_regs *regs) + /* + * IRQs are already hard disabled by the smp_handle_nmi_ipi. + */ ++ set_cpu_online(smp_processor_id(), false); ++ + spin_begin(); + while (1) + spin_cpu_relax(); +@@ -615,6 +617,15 @@ void smp_send_stop(void) + static void stop_this_cpu(void *dummy) + { + hard_irq_disable(); ++ ++ /* ++ * Offlining CPUs in stop_this_cpu can result in scheduler warnings, ++ * (see commit de6e5d38417e), but printk_safe_flush_on_panic() wants ++ * to know other CPUs are offline before it breaks locks to flush ++ * printk buffers, in case we panic()ed while holding the lock. ++ */ ++ set_cpu_online(smp_processor_id(), false); ++ + spin_begin(); + while (1) + spin_cpu_relax(); +-- +2.30.2 + diff --git a/queue-5.10/powerpc-papr_scm-make-perf_stats-invisible-if-perf-s.patch b/queue-5.10/powerpc-papr_scm-make-perf_stats-invisible-if-perf-s.patch new file mode 100644 index 00000000000..69809684640 --- /dev/null +++ b/queue-5.10/powerpc-papr_scm-make-perf_stats-invisible-if-perf-s.patch @@ -0,0 +1,144 @@ +From 3bb7d412217de79f0c46b87437eff797e846e5cd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 13 May 2021 14:53:49 +0530 +Subject: powerpc/papr_scm: Make 'perf_stats' invisible if perf-stats + unavailable + +From: Vaibhav Jain + +[ Upstream commit ed78f56e1271f108e8af61baeba383dcd77adbec ] + +In case performance stats for an nvdimm are not available, reading the +'perf_stats' sysfs file returns an -ENOENT error. A better approach is +to make the 'perf_stats' file entirely invisible to indicate that +performance stats for an nvdimm are unavailable. + +So this patch updates 'papr_nd_attribute_group' to add a 'is_visible' +callback implemented as newly introduced 'papr_nd_attribute_visible()' +that returns an appropriate mode in case performance stats aren't +supported in a given nvdimm. + +Also the initialization of 'papr_scm_priv.stat_buffer_len' is moved +from papr_scm_nvdimm_init() to papr_scm_probe() so that it value is +available when 'papr_nd_attribute_visible()' is called during nvdimm +initialization. + +Even though 'perf_stats' attribute is available since v5.9, there are +no known user-space tools/scripts that are dependent on presence of its +sysfs file. Hence I dont expect any user-space breakage with this +patch. + +Fixes: 2d02bf835e57 ("powerpc/papr_scm: Fetch nvdimm performance stats from PHYP") +Signed-off-by: Vaibhav Jain +Reviewed-by: Dan Williams +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210513092349.285021-1-vaibhav@linux.ibm.com +Signed-off-by: Sasha Levin +--- + Documentation/ABI/testing/sysfs-bus-papr-pmem | 8 +++-- + arch/powerpc/platforms/pseries/papr_scm.c | 35 +++++++++++++------ + 2 files changed, 29 insertions(+), 14 deletions(-) + +diff --git a/Documentation/ABI/testing/sysfs-bus-papr-pmem b/Documentation/ABI/testing/sysfs-bus-papr-pmem +index 8316c33862a0..0aa02bf2bde5 100644 +--- a/Documentation/ABI/testing/sysfs-bus-papr-pmem ++++ b/Documentation/ABI/testing/sysfs-bus-papr-pmem +@@ -39,9 +39,11 @@ KernelVersion: v5.9 + Contact: linuxppc-dev , linux-nvdimm@lists.01.org, + Description: + (RO) Report various performance stats related to papr-scm NVDIMM +- device. Each stat is reported on a new line with each line +- composed of a stat-identifier followed by it value. Below are +- currently known dimm performance stats which are reported: ++ device. This attribute is only available for NVDIMM devices ++ that support reporting NVDIMM performance stats. Each stat is ++ reported on a new line with each line composed of a ++ stat-identifier followed by it value. Below are currently known ++ dimm performance stats which are reported: + + * "CtlResCt" : Controller Reset Count + * "CtlResTm" : Controller Reset Elapsed Time +diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c +index 0693bc8d70ac..057acbb9116d 100644 +--- a/arch/powerpc/platforms/pseries/papr_scm.c ++++ b/arch/powerpc/platforms/pseries/papr_scm.c +@@ -868,6 +868,20 @@ static ssize_t flags_show(struct device *dev, + } + DEVICE_ATTR_RO(flags); + ++static umode_t papr_nd_attribute_visible(struct kobject *kobj, ++ struct attribute *attr, int n) ++{ ++ struct device *dev = kobj_to_dev(kobj); ++ struct nvdimm *nvdimm = to_nvdimm(dev); ++ struct papr_scm_priv *p = nvdimm_provider_data(nvdimm); ++ ++ /* For if perf-stats not available remove perf_stats sysfs */ ++ if (attr == &dev_attr_perf_stats.attr && p->stat_buffer_len == 0) ++ return 0; ++ ++ return attr->mode; ++} ++ + /* papr_scm specific dimm attributes */ + static struct attribute *papr_nd_attributes[] = { + &dev_attr_flags.attr, +@@ -877,6 +891,7 @@ static struct attribute *papr_nd_attributes[] = { + + static struct attribute_group papr_nd_attribute_group = { + .name = "papr", ++ .is_visible = papr_nd_attribute_visible, + .attrs = papr_nd_attributes, + }; + +@@ -892,7 +907,6 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) + struct nd_region_desc ndr_desc; + unsigned long dimm_flags; + int target_nid, online_nid; +- ssize_t stat_size; + + p->bus_desc.ndctl = papr_scm_ndctl; + p->bus_desc.module = THIS_MODULE; +@@ -963,16 +977,6 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) + list_add_tail(&p->region_list, &papr_nd_regions); + mutex_unlock(&papr_ndr_lock); + +- /* Try retriving the stat buffer and see if its supported */ +- stat_size = drc_pmem_query_stats(p, NULL, 0); +- if (stat_size > 0) { +- p->stat_buffer_len = stat_size; +- dev_dbg(&p->pdev->dev, "Max perf-stat size %lu-bytes\n", +- p->stat_buffer_len); +- } else { +- dev_info(&p->pdev->dev, "Dimm performance stats unavailable\n"); +- } +- + return 0; + + err: nvdimm_bus_unregister(p->bus); +@@ -1050,6 +1054,7 @@ static int papr_scm_probe(struct platform_device *pdev) + struct papr_scm_priv *p; + u8 uuid_raw[UUID_SIZE]; + const char *uuid_str; ++ ssize_t stat_size; + uuid_t uuid; + int rc; + +@@ -1133,6 +1138,14 @@ static int papr_scm_probe(struct platform_device *pdev) + p->res.name = pdev->name; + p->res.flags = IORESOURCE_MEM; + ++ /* Try retrieving the stat buffer and see if its supported */ ++ stat_size = drc_pmem_query_stats(p, NULL, 0); ++ if (stat_size > 0) { ++ p->stat_buffer_len = stat_size; ++ dev_dbg(&p->pdev->dev, "Max perf-stat size %lu-bytes\n", ++ p->stat_buffer_len); ++ } ++ + rc = papr_scm_nvdimm_init(p); + if (rc) + goto err2; +-- +2.30.2 + diff --git a/queue-5.10/powerpc-papr_scm-properly-handle-uuid-types-and-api.patch b/queue-5.10/powerpc-papr_scm-properly-handle-uuid-types-and-api.patch new file mode 100644 index 00000000000..ef8a03582d5 --- /dev/null +++ b/queue-5.10/powerpc-papr_scm-properly-handle-uuid-types-and-api.patch @@ -0,0 +1,82 @@ +From c9c55d632e38ddf79ceef492b67f267d56d27cbd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 16:43:03 +0300 +Subject: powerpc/papr_scm: Properly handle UUID types and API + +From: Andy Shevchenko + +[ Upstream commit 0e8554b5d7801b0aebc6c348a0a9f7706aa17b3b ] + +Parse to and export from UUID own type, before dereferencing. +This also fixes wrong comment (Little Endian UUID is something else) +and should eliminate the direct strict types assignments. + +Fixes: 43001c52b603 ("powerpc/papr_scm: Use ibm,unit-guid as the iset cookie") +Fixes: 259a948c4ba1 ("powerpc/pseries/scm: Use a specific endian format for storing uuid from the device tree") +Signed-off-by: Andy Shevchenko +Reviewed-by: Aneesh Kumar K.V +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210616134303.58185-1-andriy.shevchenko@linux.intel.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/platforms/pseries/papr_scm.c | 27 +++++++++++++++-------- + 1 file changed, 18 insertions(+), 9 deletions(-) + +diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c +index 835163f54244..0693bc8d70ac 100644 +--- a/arch/powerpc/platforms/pseries/papr_scm.c ++++ b/arch/powerpc/platforms/pseries/papr_scm.c +@@ -18,6 +18,7 @@ + #include + #include + #include ++#include + + #define BIND_ANY_ADDR (~0ul) + +@@ -1047,8 +1048,9 @@ static int papr_scm_probe(struct platform_device *pdev) + u32 drc_index, metadata_size; + u64 blocks, block_size; + struct papr_scm_priv *p; ++ u8 uuid_raw[UUID_SIZE]; + const char *uuid_str; +- u64 uuid[2]; ++ uuid_t uuid; + int rc; + + /* check we have all the required DT properties */ +@@ -1090,16 +1092,23 @@ static int papr_scm_probe(struct platform_device *pdev) + p->is_volatile = !of_property_read_bool(dn, "ibm,cache-flush-required"); + + /* We just need to ensure that set cookies are unique across */ +- uuid_parse(uuid_str, (uuid_t *) uuid); ++ uuid_parse(uuid_str, &uuid); ++ + /* +- * cookie1 and cookie2 are not really little endian +- * we store a little endian representation of the +- * uuid str so that we can compare this with the label +- * area cookie irrespective of the endian config with which +- * the kernel is built. ++ * The cookie1 and cookie2 are not really little endian. ++ * We store a raw buffer representation of the ++ * uuid string so that we can compare this with the label ++ * area cookie irrespective of the endian configuration ++ * with which the kernel is built. ++ * ++ * Historically we stored the cookie in the below format. ++ * for a uuid string 72511b67-0b3b-42fd-8d1d-5be3cae8bcaa ++ * cookie1 was 0xfd423b0b671b5172 ++ * cookie2 was 0xaabce8cae35b1d8d + */ +- p->nd_set.cookie1 = cpu_to_le64(uuid[0]); +- p->nd_set.cookie2 = cpu_to_le64(uuid[1]); ++ export_uuid(uuid_raw, &uuid); ++ p->nd_set.cookie1 = get_unaligned_le64(&uuid_raw[0]); ++ p->nd_set.cookie2 = get_unaligned_le64(&uuid_raw[8]); + + /* might be zero */ + p->metadata_size = metadata_size; +-- +2.30.2 + diff --git a/queue-5.10/powerpc-powernv-fix-machine-check-reporting-of-async.patch b/queue-5.10/powerpc-powernv-fix-machine-check-reporting-of-async.patch new file mode 100644 index 00000000000..613e946cd71 --- /dev/null +++ b/queue-5.10/powerpc-powernv-fix-machine-check-reporting-of-async.patch @@ -0,0 +1,134 @@ +From 063a82aac36d6a8c721c1f1c0d345efae7928841 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 00:03:55 +1000 +Subject: powerpc/powernv: Fix machine check reporting of async store errors + +From: Nicholas Piggin + +[ Upstream commit 3729e0ec59a20825bd4c8c70996b2df63915e1dd ] + +POWER9 and POWER10 asynchronous machine checks due to stores have their +cause reported in SRR1 but SRR1[42] is set, which in other cases +indicates DSISR cause. + +Check for these cases and clear SRR1[42], so the cause matching uses +the i-side (SRR1) table. + +Fixes: 7b9f71f974a1 ("powerpc/64s: POWER9 machine check handler") +Fixes: 201220bb0e8c ("powerpc/powernv: Machine check handler for POWER10") +Signed-off-by: Nicholas Piggin +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20210517140355.2325406-1-npiggin@gmail.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/kernel/mce_power.c | 48 +++++++++++++++++++++++++++------ + 1 file changed, 40 insertions(+), 8 deletions(-) + +diff --git a/arch/powerpc/kernel/mce_power.c b/arch/powerpc/kernel/mce_power.c +index b7e173754a2e..ea8b002820ce 100644 +--- a/arch/powerpc/kernel/mce_power.c ++++ b/arch/powerpc/kernel/mce_power.c +@@ -475,12 +475,11 @@ static int mce_find_instr_ea_and_phys(struct pt_regs *regs, uint64_t *addr, + return -1; + } + +-static int mce_handle_ierror(struct pt_regs *regs, ++static int mce_handle_ierror(struct pt_regs *regs, unsigned long srr1, + const struct mce_ierror_table table[], + struct mce_error_info *mce_err, uint64_t *addr, + uint64_t *phys_addr) + { +- uint64_t srr1 = regs->msr; + int handled = 0; + int i; + +@@ -683,19 +682,19 @@ static long mce_handle_ue_error(struct pt_regs *regs, + } + + static long mce_handle_error(struct pt_regs *regs, ++ unsigned long srr1, + const struct mce_derror_table dtable[], + const struct mce_ierror_table itable[]) + { + struct mce_error_info mce_err = { 0 }; + uint64_t addr, phys_addr = ULONG_MAX; +- uint64_t srr1 = regs->msr; + long handled; + + if (SRR1_MC_LOADSTORE(srr1)) + handled = mce_handle_derror(regs, dtable, &mce_err, &addr, + &phys_addr); + else +- handled = mce_handle_ierror(regs, itable, &mce_err, &addr, ++ handled = mce_handle_ierror(regs, srr1, itable, &mce_err, &addr, + &phys_addr); + + if (!handled && mce_err.error_type == MCE_ERROR_TYPE_UE) +@@ -711,16 +710,20 @@ long __machine_check_early_realmode_p7(struct pt_regs *regs) + /* P7 DD1 leaves top bits of DSISR undefined */ + regs->dsisr &= 0x0000ffff; + +- return mce_handle_error(regs, mce_p7_derror_table, mce_p7_ierror_table); ++ return mce_handle_error(regs, regs->msr, ++ mce_p7_derror_table, mce_p7_ierror_table); + } + + long __machine_check_early_realmode_p8(struct pt_regs *regs) + { +- return mce_handle_error(regs, mce_p8_derror_table, mce_p8_ierror_table); ++ return mce_handle_error(regs, regs->msr, ++ mce_p8_derror_table, mce_p8_ierror_table); + } + + long __machine_check_early_realmode_p9(struct pt_regs *regs) + { ++ unsigned long srr1 = regs->msr; ++ + /* + * On POWER9 DD2.1 and below, it's possible to get a machine check + * caused by a paste instruction where only DSISR bit 25 is set. This +@@ -734,10 +737,39 @@ long __machine_check_early_realmode_p9(struct pt_regs *regs) + if (SRR1_MC_LOADSTORE(regs->msr) && regs->dsisr == 0x02000000) + return 1; + +- return mce_handle_error(regs, mce_p9_derror_table, mce_p9_ierror_table); ++ /* ++ * Async machine check due to bad real address from store or foreign ++ * link time out comes with the load/store bit (PPC bit 42) set in ++ * SRR1, but the cause comes in SRR1 not DSISR. Clear bit 42 so we're ++ * directed to the ierror table so it will find the cause (which ++ * describes it correctly as a store error). ++ */ ++ if (SRR1_MC_LOADSTORE(srr1) && ++ ((srr1 & 0x081c0000) == 0x08140000 || ++ (srr1 & 0x081c0000) == 0x08180000)) { ++ srr1 &= ~PPC_BIT(42); ++ } ++ ++ return mce_handle_error(regs, srr1, ++ mce_p9_derror_table, mce_p9_ierror_table); + } + + long __machine_check_early_realmode_p10(struct pt_regs *regs) + { +- return mce_handle_error(regs, mce_p10_derror_table, mce_p10_ierror_table); ++ unsigned long srr1 = regs->msr; ++ ++ /* ++ * Async machine check due to bad real address from store comes with ++ * the load/store bit (PPC bit 42) set in SRR1, but the cause comes in ++ * SRR1 not DSISR. Clear bit 42 so we're directed to the ierror table ++ * so it will find the cause (which describes it correctly as a store ++ * error). ++ */ ++ if (SRR1_MC_LOADSTORE(srr1) && ++ (srr1 & 0x081c0000) == 0x08140000) { ++ srr1 &= ~PPC_BIT(42); ++ } ++ ++ return mce_handle_error(regs, srr1, ++ mce_p10_derror_table, mce_p10_ierror_table); + } +-- +2.30.2 + diff --git a/queue-5.10/psi-fix-race-between-psi_trigger_create-destroy.patch b/queue-5.10/psi-fix-race-between-psi_trigger_create-destroy.patch new file mode 100644 index 00000000000..e859d13ec6b --- /dev/null +++ b/queue-5.10/psi-fix-race-between-psi_trigger_create-destroy.patch @@ -0,0 +1,112 @@ +From 4ebd8c3935737437a67fa364c1b7790057fba24f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Jun 2021 08:29:34 +0800 +Subject: psi: Fix race between psi_trigger_create/destroy + +From: Zhaoyang Huang + +[ Upstream commit 8f91efd870ea5d8bc10b0fcc9740db51cd4c0c83 ] + +Race detected between psi_trigger_destroy/create as shown below, which +cause panic by accessing invalid psi_system->poll_wait->wait_queue_entry +and psi_system->poll_timer->entry->next. Under this modification, the +race window is removed by initialising poll_wait and poll_timer in +group_init which are executed only once at beginning. + + psi_trigger_destroy() psi_trigger_create() + + mutex_lock(trigger_lock); + rcu_assign_pointer(poll_task, NULL); + mutex_unlock(trigger_lock); + mutex_lock(trigger_lock); + if (!rcu_access_pointer(group->poll_task)) { + timer_setup(poll_timer, poll_timer_fn, 0); + rcu_assign_pointer(poll_task, task); + } + mutex_unlock(trigger_lock); + + synchronize_rcu(); + del_timer_sync(poll_timer); <-- poll_timer has been reinitialized by + psi_trigger_create() + +So, trigger_lock/RCU correctly protects destruction of +group->poll_task but misses this race affecting poll_timer and +poll_wait. + +Fixes: 461daba06bdc ("psi: eliminate kthread_worker from psi trigger scheduling mechanism") +Co-developed-by: ziwei.dai +Signed-off-by: ziwei.dai +Co-developed-by: ke.wang +Signed-off-by: ke.wang +Signed-off-by: Zhaoyang Huang +Signed-off-by: Peter Zijlstra (Intel) +Reviewed-by: Suren Baghdasaryan +Acked-by: Johannes Weiner +Link: https://lkml.kernel.org/r/1623371374-15664-1-git-send-email-huangzhaoyang@gmail.com +Signed-off-by: Sasha Levin +--- + kernel/sched/psi.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c +index 651218ded981..d50a31ecedee 100644 +--- a/kernel/sched/psi.c ++++ b/kernel/sched/psi.c +@@ -179,6 +179,8 @@ struct psi_group psi_system = { + + static void psi_avgs_work(struct work_struct *work); + ++static void poll_timer_fn(struct timer_list *t); ++ + static void group_init(struct psi_group *group) + { + int cpu; +@@ -198,6 +200,8 @@ static void group_init(struct psi_group *group) + memset(group->polling_total, 0, sizeof(group->polling_total)); + group->polling_next_update = ULLONG_MAX; + group->polling_until = 0; ++ init_waitqueue_head(&group->poll_wait); ++ timer_setup(&group->poll_timer, poll_timer_fn, 0); + rcu_assign_pointer(group->poll_task, NULL); + } + +@@ -1126,9 +1130,7 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group, + return ERR_CAST(task); + } + atomic_set(&group->poll_wakeup, 0); +- init_waitqueue_head(&group->poll_wait); + wake_up_process(task); +- timer_setup(&group->poll_timer, poll_timer_fn, 0); + rcu_assign_pointer(group->poll_task, task); + } + +@@ -1180,6 +1182,7 @@ static void psi_trigger_destroy(struct kref *ref) + group->poll_task, + lockdep_is_held(&group->trigger_lock)); + rcu_assign_pointer(group->poll_task, NULL); ++ del_timer(&group->poll_timer); + } + } + +@@ -1192,17 +1195,14 @@ static void psi_trigger_destroy(struct kref *ref) + */ + synchronize_rcu(); + /* +- * Destroy the kworker after releasing trigger_lock to prevent a ++ * Stop kthread 'psimon' after releasing trigger_lock to prevent a + * deadlock while waiting for psi_poll_work to acquire trigger_lock + */ + if (task_to_destroy) { + /* + * After the RCU grace period has expired, the worker + * can no longer be found through group->poll_task. +- * But it might have been already scheduled before +- * that - deschedule it cleanly before destroying it. + */ +- del_timer_sync(&group->poll_timer); + kthread_stop(task_to_destroy); + } + kfree(t); +-- +2.30.2 + diff --git a/queue-5.10/random32-fix-implicit-truncation-warning-in-prandom_.patch b/queue-5.10/random32-fix-implicit-truncation-warning-in-prandom_.patch new file mode 100644 index 00000000000..c88a2bf5aec --- /dev/null +++ b/queue-5.10/random32-fix-implicit-truncation-warning-in-prandom_.patch @@ -0,0 +1,48 @@ +From 3528a4a708f0be7be10eb4172202a3362f617527 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 13:20:12 +0100 +Subject: random32: Fix implicit truncation warning in prandom_seed_state() + +From: Richard Fitzgerald + +[ Upstream commit d327ea15a305024ef0085252fa3657bbb1ce25f5 ] + +sparse generates the following warning: + + include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits from + constant value + +This is because the 64-bit seed value is manipulated and then placed in a +u32, causing an implicit cast and truncation. A forced cast to u32 doesn't +prevent this warning, which is reasonable because a typecast doesn't prove +that truncation was expected. + +Logical-AND the value with 0xffffffff to make explicit that truncation to +32-bit is intended. + +Reported-by: kernel test robot +Signed-off-by: Richard Fitzgerald +Reviewed-by: Petr Mladek +Signed-off-by: Petr Mladek +Link: https://lore.kernel.org/r/20210525122012.6336-3-rf@opensource.cirrus.com +Signed-off-by: Sasha Levin +--- + include/linux/prandom.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/prandom.h b/include/linux/prandom.h +index bbf4b4ad61df..056d31317e49 100644 +--- a/include/linux/prandom.h ++++ b/include/linux/prandom.h +@@ -111,7 +111,7 @@ static inline u32 __seed(u32 x, u32 m) + */ + static inline void prandom_seed_state(struct rnd_state *state, u64 seed) + { +- u32 i = (seed >> 32) ^ (seed << 10) ^ seed; ++ u32 i = ((seed >> 32) ^ (seed << 10) ^ seed) & 0xffffffffUL; + + state->s1 = __seed(i, 2U); + state->s2 = __seed(i, 8U); +-- +2.30.2 + diff --git a/queue-5.10/rcu-invoke-rcu_spawn_core_kthreads-from-rcu_spawn_gp.patch b/queue-5.10/rcu-invoke-rcu_spawn_core_kthreads-from-rcu_spawn_gp.patch new file mode 100644 index 00000000000..dd7836ff829 --- /dev/null +++ b/queue-5.10/rcu-invoke-rcu_spawn_core_kthreads-from-rcu_spawn_gp.patch @@ -0,0 +1,57 @@ +From 88f31cd38603f267facce8b2fa5535751b5f36d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 31 Mar 2021 10:59:05 -0700 +Subject: rcu: Invoke rcu_spawn_core_kthreads() from rcu_spawn_gp_kthread() + +From: Paul E. McKenney + +[ Upstream commit 8e4b1d2bc198e34b48fc7cc3a3c5a2fcb269e271 ] + +Currently, rcu_spawn_core_kthreads() is invoked via an early_initcall(), +which works, except that rcu_spawn_gp_kthread() is also invoked via an +early_initcall() and rcu_spawn_core_kthreads() relies on adjustments to +kthread_prio that are carried out by rcu_spawn_gp_kthread(). There is +no guaranttee of ordering among early_initcall() handlers, and thus no +guarantee that kthread_prio will be properly checked and range-limited +at the time that rcu_spawn_core_kthreads() needs it. + +In most cases, this bug is harmless. After all, the only reason that +rcu_spawn_gp_kthread() adjusts the value of kthread_prio is if the user +specified a nonsensical value for this boot parameter, which experience +indicates is rare. + +Nevertheless, a bug is a bug. This commit therefore causes the +rcu_spawn_core_kthreads() function to be invoked directly from +rcu_spawn_gp_kthread() after any needed adjustments to kthread_prio have +been carried out. + +Fixes: 48d07c04b4cc ("rcu: Enable elimination of Tree-RCU softirq processing") +Signed-off-by: Paul E. McKenney +Signed-off-by: Sasha Levin +--- + kernel/rcu/tree.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c +index 61e250cdd7c9..45b60e997461 100644 +--- a/kernel/rcu/tree.c ++++ b/kernel/rcu/tree.c +@@ -2837,7 +2837,6 @@ static int __init rcu_spawn_core_kthreads(void) + "%s: Could not start rcuc kthread, OOM is now expected behavior\n", __func__); + return 0; + } +-early_initcall(rcu_spawn_core_kthreads); + + /* + * Handle any core-RCU processing required by a call_rcu() invocation. +@@ -4273,6 +4272,7 @@ static int __init rcu_spawn_gp_kthread(void) + wake_up_process(t); + rcu_spawn_nocb_kthreads(); + rcu_spawn_boost_kthreads(); ++ rcu_spawn_core_kthreads(); + return 0; + } + early_initcall(rcu_spawn_gp_kthread); +-- +2.30.2 + diff --git a/queue-5.10/rdma-cma-fix-incorrect-packet-lifetime-calculation.patch b/queue-5.10/rdma-cma-fix-incorrect-packet-lifetime-calculation.patch new file mode 100644 index 00000000000..616bdd240e3 --- /dev/null +++ b/queue-5.10/rdma-cma-fix-incorrect-packet-lifetime-calculation.patch @@ -0,0 +1,54 @@ +From dfc2c790e4d5e5738063df921d7cbb8508537ea1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 16:13:27 +0200 +Subject: RDMA/cma: Fix incorrect Packet Lifetime calculation +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: HÃ¥kon Bugge + +[ Upstream commit e84045eab69c625bc0b0bf24d8e05bc65da1eed1 ] + +An approximation for the PacketLifeTime is half the local ACK timeout. +The encoding for both timers are logarithmic. + +If the local ACK timeout is set, but zero, it means the timer is +disabled. In this case, we choose the CMA_IBOE_PACKET_LIFETIME value, +since 50% of infinite makes no sense. + +Before this commit, the PacketLifeTime became 255 if local ACK +timeout was zero (not running). + +Fixed by explicitly testing for timeout being zero. + +Fixes: e1ee1e62bec4 ("RDMA/cma: Use ACK timeout for RoCE packetLifeTime") +Link: https://lore.kernel.org/r/1624371207-26710-1-git-send-email-haakon.bugge@oracle.com +Signed-off-by: HÃ¥kon Bugge +Reviewed-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/core/cma.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c +index f2fd4bc2fbec..be4e447134b3 100644 +--- a/drivers/infiniband/core/cma.c ++++ b/drivers/infiniband/core/cma.c +@@ -3060,8 +3060,10 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) + * as a reasonable approximation for RoCE networks. + */ + mutex_lock(&id_priv->qp_mutex); +- route->path_rec->packet_life_time = id_priv->timeout_set ? +- id_priv->timeout - 1 : CMA_IBOE_PACKET_LIFETIME; ++ if (id_priv->timeout_set && id_priv->timeout) ++ route->path_rec->packet_life_time = id_priv->timeout - 1; ++ else ++ route->path_rec->packet_life_time = CMA_IBOE_PACKET_LIFETIME; + mutex_unlock(&id_priv->qp_mutex); + + if (!route->path_rec->mtu) { +-- +2.30.2 + diff --git a/queue-5.10/rdma-cma-protect-rmw-with-qp_mutex.patch b/queue-5.10/rdma-cma-protect-rmw-with-qp_mutex.patch new file mode 100644 index 00000000000..3ad312366fb --- /dev/null +++ b/queue-5.10/rdma-cma-protect-rmw-with-qp_mutex.patch @@ -0,0 +1,126 @@ +From 372e1332a77bfea251f3363c0be25cf99d1a508c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 15:39:57 +0200 +Subject: RDMA/cma: Protect RMW with qp_mutex +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: HÃ¥kon Bugge + +[ Upstream commit ca0c448d2b9f43e3175835d536853854ef544e22 ] + +The struct rdma_id_private contains three bit-fields, tos_set, +timeout_set, and min_rnr_timer_set. These are set by accessor functions +without any synchronization. If two or all accessor functions are invoked +in close proximity in time, there will be Read-Modify-Write from several +contexts to the same variable, and the result will be intermittent. + +Fixed by protecting the bit-fields by the qp_mutex in the accessor +functions. + +The consumer of timeout_set and min_rnr_timer_set is in +rdma_init_qp_attr(), which is called with qp_mutex held for connected +QPs. Explicit locking is added for the consumers of tos and tos_set. + +This commit depends on ("RDMA/cma: Remove unnecessary INIT->INIT +transition"), since the call to rdma_init_qp_attr() from +cma_init_conn_qp() does not hold the qp_mutex. + +Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") +Fixes: 3aeffc46afde ("IB/cma: Introduce rdma_set_min_rnr_timer()") +Link: https://lore.kernel.org/r/1624369197-24578-3-git-send-email-haakon.bugge@oracle.com +Signed-off-by: HÃ¥kon Bugge +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/core/cma.c | 18 +++++++++++++++++- + 1 file changed, 17 insertions(+), 1 deletion(-) + +diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c +index d1e94147fb16..f2fd4bc2fbec 100644 +--- a/drivers/infiniband/core/cma.c ++++ b/drivers/infiniband/core/cma.c +@@ -2476,8 +2476,10 @@ static int cma_iw_listen(struct rdma_id_private *id_priv, int backlog) + if (IS_ERR(id)) + return PTR_ERR(id); + ++ mutex_lock(&id_priv->qp_mutex); + id->tos = id_priv->tos; + id->tos_set = id_priv->tos_set; ++ mutex_unlock(&id_priv->qp_mutex); + id_priv->cm_id.iw = id; + + memcpy(&id_priv->cm_id.iw->local_addr, cma_src_addr(id_priv), +@@ -2537,8 +2539,10 @@ static int cma_listen_on_dev(struct rdma_id_private *id_priv, + cma_id_get(id_priv); + dev_id_priv->internal_id = 1; + dev_id_priv->afonly = id_priv->afonly; ++ mutex_lock(&id_priv->qp_mutex); + dev_id_priv->tos_set = id_priv->tos_set; + dev_id_priv->tos = id_priv->tos; ++ mutex_unlock(&id_priv->qp_mutex); + + ret = rdma_listen(&dev_id_priv->id, id_priv->backlog); + if (ret) +@@ -2585,8 +2589,10 @@ void rdma_set_service_type(struct rdma_cm_id *id, int tos) + struct rdma_id_private *id_priv; + + id_priv = container_of(id, struct rdma_id_private, id); ++ mutex_lock(&id_priv->qp_mutex); + id_priv->tos = (u8) tos; + id_priv->tos_set = true; ++ mutex_unlock(&id_priv->qp_mutex); + } + EXPORT_SYMBOL(rdma_set_service_type); + +@@ -2613,8 +2619,10 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout) + return -EINVAL; + + id_priv = container_of(id, struct rdma_id_private, id); ++ mutex_lock(&id_priv->qp_mutex); + id_priv->timeout = timeout; + id_priv->timeout_set = true; ++ mutex_unlock(&id_priv->qp_mutex); + + return 0; + } +@@ -3000,8 +3008,11 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) + + u8 default_roce_tos = id_priv->cma_dev->default_roce_tos[id_priv->id.port_num - + rdma_start_port(id_priv->cma_dev->device)]; +- u8 tos = id_priv->tos_set ? id_priv->tos : default_roce_tos; ++ u8 tos; + ++ mutex_lock(&id_priv->qp_mutex); ++ tos = id_priv->tos_set ? id_priv->tos : default_roce_tos; ++ mutex_unlock(&id_priv->qp_mutex); + + work = kzalloc(sizeof *work, GFP_KERNEL); + if (!work) +@@ -3048,8 +3059,10 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv) + * PacketLifeTime = local ACK timeout/2 + * as a reasonable approximation for RoCE networks. + */ ++ mutex_lock(&id_priv->qp_mutex); + route->path_rec->packet_life_time = id_priv->timeout_set ? + id_priv->timeout - 1 : CMA_IBOE_PACKET_LIFETIME; ++ mutex_unlock(&id_priv->qp_mutex); + + if (!route->path_rec->mtu) { + ret = -EINVAL; +@@ -4073,8 +4086,11 @@ static int cma_connect_iw(struct rdma_id_private *id_priv, + if (IS_ERR(cm_id)) + return PTR_ERR(cm_id); + ++ mutex_lock(&id_priv->qp_mutex); + cm_id->tos = id_priv->tos; + cm_id->tos_set = id_priv->tos_set; ++ mutex_unlock(&id_priv->qp_mutex); ++ + id_priv->cm_id.iw = cm_id; + + memcpy(&cm_id->local_addr, cma_src_addr(id_priv), +-- +2.30.2 + diff --git a/queue-5.10/rdma-core-always-release-restrack-object.patch b/queue-5.10/rdma-core-always-release-restrack-object.patch new file mode 100644 index 00000000000..d144e7276f2 --- /dev/null +++ b/queue-5.10/rdma-core-always-release-restrack-object.patch @@ -0,0 +1,61 @@ +From df1fe003fe922e8d719ad363e55357792ad28004 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 29 Jun 2021 09:49:33 +0300 +Subject: RDMA/core: Always release restrack object + +From: Leon Romanovsky + +[ Upstream commit 3d8287544223a3d2f37981c1f9ffd94d0b5e9ffc ] + +Change location of rdma_restrack_del() to fix the bug where +task_struct was acquired but not released, causing to resource leak. + + ucma_create_id() { + ucma_alloc_ctx(); + rdma_create_user_id() { + rdma_restrack_new(); + rdma_restrack_set_name() { + rdma_restrack_attach_task.part.0(); <--- task_struct was gotten + } + } + ucma_destroy_private_ctx() { + ucma_put_ctx(); + rdma_destroy_id() { + _destroy_id() <--- id_priv was freed + } + } + } + +Fixes: 889d916b6f8a ("RDMA/core: Don't access cm_id after its destruction") +Link: https://lore.kernel.org/r/073ec27acb943ca8b6961663c47c5abe78a5c8cc.1624948948.git.leonro@nvidia.com +Reported-by: Pavel Skripkin +Signed-off-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/core/cma.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c +index be4e447134b3..0c879e40bd18 100644 +--- a/drivers/infiniband/core/cma.c ++++ b/drivers/infiniband/core/cma.c +@@ -1856,6 +1856,7 @@ static void _destroy_id(struct rdma_id_private *id_priv, + { + cma_cancel_operation(id_priv, state); + ++ rdma_restrack_del(&id_priv->res); + if (id_priv->cma_dev) { + if (rdma_cap_ib_cm(id_priv->id.device, 1)) { + if (id_priv->cm_id.ib) +@@ -1865,7 +1866,6 @@ static void _destroy_id(struct rdma_id_private *id_priv, + iw_destroy_cm_id(id_priv->cm_id.iw); + } + cma_leave_mc_groups(id_priv); +- rdma_restrack_del(&id_priv->res); + cma_release_dev(id_priv); + } + +-- +2.30.2 + diff --git a/queue-5.10/rdma-core-sanitize-wq-state-received-from-the-usersp.patch b/queue-5.10/rdma-core-sanitize-wq-state-received-from-the-usersp.patch new file mode 100644 index 00000000000..2cea3971233 --- /dev/null +++ b/queue-5.10/rdma-core-sanitize-wq-state-received-from-the-usersp.patch @@ -0,0 +1,104 @@ +From 8421de1b9dac29fe1d458b639a082ddde453e46e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 19 May 2021 11:37:31 +0300 +Subject: RDMA/core: Sanitize WQ state received from the userspace + +From: Leon Romanovsky + +[ Upstream commit f97442887275d11c88c2899e720fe945c1f61488 ] + +The mlx4 and mlx5 implemented differently the WQ input checks. Instead of +duplicating mlx4 logic in the mlx5, let's prepare the input in the central +place. + +The mlx5 implementation didn't check for validity of state input. It is +not real bug because our FW checked that, but still worth to fix. + +Fixes: f213c0527210 ("IB/uverbs: Add WQ support") +Link: https://lore.kernel.org/r/ac41ad6a81b095b1a8ad453dcf62cf8d3c5da779.1621413310.git.leonro@nvidia.com +Reported-by: Jiapeng Chong +Signed-off-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/core/uverbs_cmd.c | 21 +++++++++++++++++++-- + drivers/infiniband/hw/mlx4/qp.c | 9 ++------- + drivers/infiniband/hw/mlx5/qp.c | 6 ++---- + 3 files changed, 23 insertions(+), 13 deletions(-) + +diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c +index 418d133a8fb0..466026825dd7 100644 +--- a/drivers/infiniband/core/uverbs_cmd.c ++++ b/drivers/infiniband/core/uverbs_cmd.c +@@ -3000,12 +3000,29 @@ static int ib_uverbs_ex_modify_wq(struct uverbs_attr_bundle *attrs) + if (!wq) + return -EINVAL; + +- wq_attr.curr_wq_state = cmd.curr_wq_state; +- wq_attr.wq_state = cmd.wq_state; + if (cmd.attr_mask & IB_WQ_FLAGS) { + wq_attr.flags = cmd.flags; + wq_attr.flags_mask = cmd.flags_mask; + } ++ ++ if (cmd.attr_mask & IB_WQ_CUR_STATE) { ++ if (cmd.curr_wq_state > IB_WQS_ERR) ++ return -EINVAL; ++ ++ wq_attr.curr_wq_state = cmd.curr_wq_state; ++ } else { ++ wq_attr.curr_wq_state = wq->state; ++ } ++ ++ if (cmd.attr_mask & IB_WQ_STATE) { ++ if (cmd.wq_state > IB_WQS_ERR) ++ return -EINVAL; ++ ++ wq_attr.wq_state = cmd.wq_state; ++ } else { ++ wq_attr.wq_state = wq_attr.curr_wq_state; ++ } ++ + ret = wq->device->ops.modify_wq(wq, &wq_attr, cmd.attr_mask, + &attrs->driver_udata); + rdma_lookup_put_uobject(&wq->uobject->uevent.uobject, +diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c +index 5cb8e602294c..6bc0818f4b2c 100644 +--- a/drivers/infiniband/hw/mlx4/qp.c ++++ b/drivers/infiniband/hw/mlx4/qp.c +@@ -4244,13 +4244,8 @@ int mlx4_ib_modify_wq(struct ib_wq *ibwq, struct ib_wq_attr *wq_attr, + if (wq_attr_mask & IB_WQ_FLAGS) + return -EOPNOTSUPP; + +- cur_state = wq_attr_mask & IB_WQ_CUR_STATE ? wq_attr->curr_wq_state : +- ibwq->state; +- new_state = wq_attr_mask & IB_WQ_STATE ? wq_attr->wq_state : cur_state; +- +- if (cur_state < IB_WQS_RESET || cur_state > IB_WQS_ERR || +- new_state < IB_WQS_RESET || new_state > IB_WQS_ERR) +- return -EINVAL; ++ cur_state = wq_attr->curr_wq_state; ++ new_state = wq_attr->wq_state; + + if ((new_state == IB_WQS_RDY) && (cur_state == IB_WQS_ERR)) + return -EINVAL; +diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c +index 6d2715f65d78..8beba002e5dd 100644 +--- a/drivers/infiniband/hw/mlx5/qp.c ++++ b/drivers/infiniband/hw/mlx5/qp.c +@@ -5236,10 +5236,8 @@ int mlx5_ib_modify_wq(struct ib_wq *wq, struct ib_wq_attr *wq_attr, + + rqc = MLX5_ADDR_OF(modify_rq_in, in, ctx); + +- curr_wq_state = (wq_attr_mask & IB_WQ_CUR_STATE) ? +- wq_attr->curr_wq_state : wq->state; +- wq_state = (wq_attr_mask & IB_WQ_STATE) ? +- wq_attr->wq_state : curr_wq_state; ++ curr_wq_state = wq_attr->curr_wq_state; ++ wq_state = wq_attr->wq_state; + if (curr_wq_state == IB_WQS_ERR) + curr_wq_state = MLX5_RQC_STATE_ERR; + if (wq_state == IB_WQS_ERR) +-- +2.30.2 + diff --git a/queue-5.10/rdma-mlx5-don-t-access-null-cleared-mpi-pointer.patch b/queue-5.10/rdma-mlx5-don-t-access-null-cleared-mpi-pointer.patch new file mode 100644 index 00000000000..1b8e4c8664f --- /dev/null +++ b/queue-5.10/rdma-mlx5-don-t-access-null-cleared-mpi-pointer.patch @@ -0,0 +1,93 @@ +From 19e5eb7c691e7d8478acd93cf7b6e2f63adf93fe Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 29 Jun 2021 11:51:38 +0300 +Subject: RDMA/mlx5: Don't access NULL-cleared mpi pointer + +From: Leon Romanovsky + +[ Upstream commit 4a754d7637026b42b0c9ba5787ad5ee3bc2ff77f ] + +The "dev->port[i].mp.mpi" is set to NULL during mlx5_ib_unbind_slave_port() +execution, however that field is needed to add device to unaffiliated list. + +Such flow causes to the following kernel panic while unloading mlx5_ib +module in multi-port mode, hence the device should be added to the list +prior to unbind call. + + RPC: Unregistered rdma transport module. + RPC: Unregistered rdma backchannel transport module. + BUG: kernel NULL pointer dereference, address: 0000000000000000 + #PF: supervisor write access in kernel mode + #PF: error_code(0x0002) - not-present page + PGD 0 P4D 0 + Oops: 0002 [#1] SMP NOPTI + CPU: 4 PID: 1904 Comm: modprobe Not tainted 5.13.0-rc7_for_upstream_min_debug_2021_06_24_12_08 #1 + Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 + RIP: 0010:mlx5_ib_cleanup_multiport_master+0x18b/0x2d0 [mlx5_ib] + Code: 00 04 0f 85 c4 00 00 00 48 89 df e8 ef fa ff ff 48 8b 83 40 0d 00 00 48 8b 15 b9 e8 05 00 4a 8b 44 28 20 48 89 05 ad e8 05 00 <48> c7 00 d0 57 c5 a0 48 89 50 08 48 89 02 39 ab 88 0a 00 00 0f 86 + RSP: 0018:ffff888116ee3df8 EFLAGS: 00010296 + RAX: 0000000000000000 RBX: ffff8881154f6000 RCX: 0000000000000080 + RDX: ffffffffa0c557d0 RSI: ffff88810b69d200 RDI: 000000000002d8a0 + RBP: 0000000000000002 R08: ffff888110780408 R09: 0000000000000000 + R10: ffff88812452e1c0 R11: fffffffffff7e028 R12: 0000000000000000 + R13: 0000000000000080 R14: ffff888102c58000 R15: 0000000000000000 + FS: 00007f884393a740(0000) GS:ffff8882f5a00000(0000) knlGS:0000000000000000 + CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 + CR2: 0000000000000000 CR3: 00000001249f6004 CR4: 0000000000370ea0 + DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 + DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 + Call Trace: + mlx5_ib_stage_init_cleanup+0x16/0xd0 [mlx5_ib] + __mlx5_ib_remove+0x33/0x90 [mlx5_ib] + mlx5r_remove+0x22/0x30 [mlx5_ib] + auxiliary_bus_remove+0x18/0x30 + __device_release_driver+0x177/0x220 + driver_detach+0xc4/0x100 + bus_remove_driver+0x58/0xd0 + auxiliary_driver_unregister+0x12/0x20 + mlx5_ib_cleanup+0x13/0x897 [mlx5_ib] + __x64_sys_delete_module+0x154/0x230 + ? exit_to_user_mode_prepare+0x104/0x140 + do_syscall_64+0x3f/0x80 + entry_SYSCALL_64_after_hwframe+0x44/0xae + RIP: 0033:0x7f8842e095c7 + Code: 73 01 c3 48 8b 0d d9 48 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 48 2c 00 f7 d8 64 89 01 48 + RSP: 002b:00007ffc68f6e758 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0 + RAX: ffffffffffffffda RBX: 00005638207929c0 RCX: 00007f8842e095c7 + RDX: 0000000000000000 RSI: 0000000000000800 RDI: 0000563820792a28 + RBP: 00005638207929c0 R08: 00007ffc68f6d701 R09: 0000000000000000 + R10: 00007f8842e82880 R11: 0000000000000206 R12: 0000563820792a28 + R13: 0000000000000001 R14: 0000563820792a28 R15: 00007ffc68f6fb40 + Modules linked in: xt_MASQUERADE nf_conntrack_netlink nfnetlink iptable_nat xt_addrtype xt_conntrack nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 br_netfilter overlay rdma_ucm ib_iser libiscsi scsi_transport_iscsi rdma_cm iw_cm ib_ipoib ib_cm ib_umad mlx5_ib(-) mlx4_ib ib_uverbs ib_core mlx4_en mlx4_core mlx5_core ptp pps_core [last unloaded: rpcrdma] + CR2: 0000000000000000 + ---[ end trace a0bb7e20804e9e9b ]--- + +Fixes: 7ce6095e3bff ("RDMA/mlx5: Don't add slave port to unaffiliated list") +Link: https://lore.kernel.org/r/899ac1b33a995be5ec0e16a4765c4e43c2b1ba5b.1624956444.git.leonro@nvidia.com +Reviewed-by: Itay Aveksis +Reviewed-by: Maor Gottlieb +Signed-off-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/main.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c +index 60aceb3b47a5..eb69bec77e5d 100644 +--- a/drivers/infiniband/hw/mlx5/main.c ++++ b/drivers/infiniband/hw/mlx5/main.c +@@ -3592,9 +3592,9 @@ static void mlx5_ib_cleanup_multiport_master(struct mlx5_ib_dev *dev) + dev->port[i].mp.mpi = NULL; + } else { + mlx5_ib_dbg(dev, "unbinding port_num: %d\n", i + 1); +- mlx5_ib_unbind_slave_port(dev, dev->port[i].mp.mpi); + list_add_tail(&dev->port[i].mp.mpi->list, + &mlx5_ib_unaffiliated_port_list); ++ mlx5_ib_unbind_slave_port(dev, dev->port[i].mp.mpi); + } + } + } +-- +2.30.2 + diff --git a/queue-5.10/rdma-mlx5-don-t-add-slave-port-to-unaffiliated-list.patch b/queue-5.10/rdma-mlx5-don-t-add-slave-port-to-unaffiliated-list.patch new file mode 100644 index 00000000000..22488ae6789 --- /dev/null +++ b/queue-5.10/rdma-mlx5-don-t-add-slave-port-to-unaffiliated-list.patch @@ -0,0 +1,49 @@ +From c95a800bc417abe5a0473bb26dab93e0806db5fb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 31 May 2021 19:04:44 +0300 +Subject: RDMA/mlx5: Don't add slave port to unaffiliated list + +From: Leon Romanovsky + +[ Upstream commit 7ce6095e3bff8e20ce018b050960b527e298f7df ] + +The mlx5_ib_bind_slave_port() doesn't remove multiport device from the +unaffiliated list, but mlx5_ib_unbind_slave_port() did it. This unbalanced +flow caused to the situation where mlx5_ib_unaffiliated_port_list was +changed during iteration. + +Fixes: 32f69e4be269 ("{net, IB}/mlx5: Manage port association for multiport RoCE") +Link: https://lore.kernel.org/r/2726e6603b1e6ecfe76aa5a12a063af72173bcf7.1622477058.git.leonro@nvidia.com +Reported-by: Dan Carpenter +Signed-off-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/main.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c +index b19506707e45..60aceb3b47a5 100644 +--- a/drivers/infiniband/hw/mlx5/main.c ++++ b/drivers/infiniband/hw/mlx5/main.c +@@ -3440,8 +3440,6 @@ static void mlx5_ib_unbind_slave_port(struct mlx5_ib_dev *ibdev, + + port->mp.mpi = NULL; + +- list_add_tail(&mpi->list, &mlx5_ib_unaffiliated_port_list); +- + spin_unlock(&port->mp.mpi_lock); + + err = mlx5_nic_vport_unaffiliate_multiport(mpi->mdev); +@@ -3595,6 +3593,8 @@ static void mlx5_ib_cleanup_multiport_master(struct mlx5_ib_dev *dev) + } else { + mlx5_ib_dbg(dev, "unbinding port_num: %d\n", i + 1); + mlx5_ib_unbind_slave_port(dev, dev->port[i].mp.mpi); ++ list_add_tail(&dev->port[i].mp.mpi->list, ++ &mlx5_ib_unaffiliated_port_list); + } + } + } +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-clt-check-if-the-queue_depth-has-changed-d.patch b/queue-5.10/rdma-rtrs-clt-check-if-the-queue_depth-has-changed-d.patch new file mode 100644 index 00000000000..b4f4ad8d074 --- /dev/null +++ b/queue-5.10/rdma-rtrs-clt-check-if-the-queue_depth-has-changed-d.patch @@ -0,0 +1,78 @@ +From aa5eb6e71084c0cb4e64c2cc8efc78ddff09a54c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:17 +0200 +Subject: RDMA/rtrs-clt: Check if the queue_depth has changed during a + reconnection + +From: Md Haris Iqbal + +[ Upstream commit 5b73b799c25c68a4703cd6c5ac4518006d9865b8 ] + +The queue_depth is a module parameter for rtrs_server. It is used on the +client side to determing the queue_depth of the request queue for the RNBD +virtual block device. + +During a reconnection event for an already mapped device, in case the +rtrs_server module queue_depth has changed, fail the reconnect attempt. + +Also stop further auto reconnection attempts. A manual reconnect via +sysfs has to be triggerred. + +Fixes: 6a98d71daea18 ("RDMA/rtrs: client: main functionality") +Link: https://lore.kernel.org/r/20210528113018.52290-20-jinpu.wang@ionos.com +Signed-off-by: Md Haris Iqbal +Signed-off-by: Gioh Kim +Signed-off-by: Jack Wang +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-clt.c | 19 +++++++++++++++---- + 1 file changed, 15 insertions(+), 4 deletions(-) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +index 7d7dcc0a0458..dc44a9bfcdaa 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +@@ -1727,7 +1727,19 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, + queue_depth); + return -ECONNRESET; + } +- if (!sess->rbufs || sess->queue_depth < queue_depth) { ++ if (sess->queue_depth > 0 && queue_depth != sess->queue_depth) { ++ rtrs_err(clt, "Error: queue depth changed\n"); ++ ++ /* ++ * Stop any more reconnection attempts ++ */ ++ sess->reconnect_attempts = -1; ++ rtrs_err(clt, ++ "Disabling auto-reconnect. Trigger a manual reconnect after issue is resolved\n"); ++ return -ECONNRESET; ++ } ++ ++ if (!sess->rbufs) { + kfree(sess->rbufs); + sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs), + GFP_KERNEL); +@@ -1741,7 +1753,7 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, + sess->chunk_size = sess->max_io_size + sess->max_hdr_size; + + /* +- * Global queue depth and IO size is always a minimum. ++ * Global IO size is always a minimum. + * If while a reconnection server sends us a value a bit + * higher - client does not care and uses cached minimum. + * +@@ -1749,8 +1761,7 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, + * connections in parallel, use lock. + */ + mutex_lock(&clt->paths_mutex); +- clt->queue_depth = min_not_zero(sess->queue_depth, +- clt->queue_depth); ++ clt->queue_depth = sess->queue_depth; + clt->max_io_size = min_not_zero(sess->max_io_size, + clt->max_io_size); + mutex_unlock(&clt->paths_mutex); +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-clt-check-state-of-the-rtrs_clt_sess-befor.patch b/queue-5.10/rdma-rtrs-clt-check-state-of-the-rtrs_clt_sess-befor.patch new file mode 100644 index 00000000000..a9a0572773b --- /dev/null +++ b/queue-5.10/rdma-rtrs-clt-check-state-of-the-rtrs_clt_sess-befor.patch @@ -0,0 +1,59 @@ +From 11002c7012ed32cefe0edcbda3fc6bd77b04d218 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:10 +0200 +Subject: RDMA/rtrs-clt: Check state of the rtrs_clt_sess before reading its + stats + +From: Md Haris Iqbal + +[ Upstream commit 41db63a7efe1c8c2dd282c1849a6ebfbbedbaf67 ] + +When get_next_path_min_inflight is called to select the next path, it +iterates over the list of available rtrs_clt_sess (paths). It then reads +the number of inflight IOs for that path to select one which has the least +inflight IO. + +But it may so happen that rtrs_clt_sess (path) is no longer in the +connected state because closing or error recovery paths can change the status +of the rtrs_clt_Sess. + +For example, the client sent the heart-beat and did not get the +response, it would change the session status and stop IO processing. +The added checking of this patch can prevent accessing the broken path +and generating duplicated error messages. + +It is ok if the status is changed after checking the status because +the error recovery path does not free memory and only tries to +reconnection. And also it is ok if the session is closed after checking +the status because closing the session changes the session status and +flush all IO beforing free memory. If the session is being accessed for +IO processing, the closing session will wait. + +Fixes: 6a98d71daea18 ("RDMA/rtrs: client: main functionality") +Link: https://lore.kernel.org/r/20210528113018.52290-13-jinpu.wang@ionos.com +Signed-off-by: Md Haris Iqbal +Reviewed-by: Gioh Kim +Signed-off-by: Gioh Kim +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-clt.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +index 7db550ba25d7..7d7dcc0a0458 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +@@ -811,6 +811,9 @@ static struct rtrs_clt_sess *get_next_path_min_inflight(struct path_it *it) + int inflight; + + list_for_each_entry_rcu(sess, &clt->paths_list, s.entry) { ++ if (unlikely(READ_ONCE(sess->state) != RTRS_CLT_CONNECTED)) ++ continue; ++ + if (unlikely(!list_empty(raw_cpu_ptr(sess->mp_skip_entry)))) + continue; + +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-clt-fix-memory-leak-of-not-freed-sess-stat.patch b/queue-5.10/rdma-rtrs-clt-fix-memory-leak-of-not-freed-sess-stat.patch new file mode 100644 index 00000000000..d424981f68f --- /dev/null +++ b/queue-5.10/rdma-rtrs-clt-fix-memory-leak-of-not-freed-sess-stat.patch @@ -0,0 +1,64 @@ +From b412d7482e123ee467c8c36ede557db8b132199d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:18 +0200 +Subject: RDMA/rtrs-clt: Fix memory leak of not-freed sess->stats and + stats->pcpu_stats + +From: Gioh Kim + +[ Upstream commit 7ecd7e290bee0ab9cf75b79a367a4cc113cf8292 ] + +sess->stats and sess->stats->pcpu_stats objects are freed +when sysfs entry is removed. If something wrong happens and +session is closed before sysfs entry is created, +sess->stats and sess->stats->pcpu_stats objects are not freed. + +This patch adds freeing of them at three places: +1. When client uses wrong address and session creation fails. +2. When client fails to create a sysfs entry. +3. When client adds wrong address via sysfs add_path. + +Fixes: 215378b838df0 ("RDMA/rtrs: client: sysfs interface functions") +Link: https://lore.kernel.org/r/20210528113018.52290-21-jinpu.wang@ionos.com +Signed-off-by: Gioh Kim +Signed-off-by: Jack Wang +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-clt.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +index dc44a9bfcdaa..46fad202a380 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c +@@ -2706,6 +2706,8 @@ struct rtrs_clt *rtrs_clt_open(struct rtrs_clt_ops *ops, + if (err) { + list_del_rcu(&sess->s.entry); + rtrs_clt_close_conns(sess, true); ++ free_percpu(sess->stats->pcpu_stats); ++ kfree(sess->stats); + free_sess(sess); + goto close_all_sess; + } +@@ -2714,6 +2716,8 @@ struct rtrs_clt *rtrs_clt_open(struct rtrs_clt_ops *ops, + if (err) { + list_del_rcu(&sess->s.entry); + rtrs_clt_close_conns(sess, true); ++ free_percpu(sess->stats->pcpu_stats); ++ kfree(sess->stats); + free_sess(sess); + goto close_all_sess; + } +@@ -2973,6 +2977,8 @@ int rtrs_clt_create_path_from_sysfs(struct rtrs_clt *clt, + close_sess: + rtrs_clt_remove_path_from_arr(sess); + rtrs_clt_close_conns(sess, true); ++ free_percpu(sess->stats->pcpu_stats); ++ kfree(sess->stats); + free_sess(sess); + + return err; +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-do-not-reset-hb_missed_max-after-re-connec.patch b/queue-5.10/rdma-rtrs-do-not-reset-hb_missed_max-after-re-connec.patch new file mode 100644 index 00000000000..ed601878367 --- /dev/null +++ b/queue-5.10/rdma-rtrs-do-not-reset-hb_missed_max-after-re-connec.patch @@ -0,0 +1,43 @@ +From dcdfaca3b4d56a1e758d86cc9676965acc3e7411 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:13 +0200 +Subject: RDMA/rtrs: Do not reset hb_missed_max after re-connection + +From: Gioh Kim + +[ Upstream commit 64bce1ee978491a779eb31098b21c57d4e431d6a ] + +When re-connecting, it resets hb_missed_max to 0. +Before the first re-connecting, client will trigger re-connection +when it gets hb-ack more than 5 times. But after the first +re-connecting, clients will do re-connection whenever it does +not get hb-ack because hb_missed_max is 0. + +There is no need to reset hb_missed_max when re-connecting. +hb_missed_max should be kept until closing the session. + +Fixes: c0894b3ea69d3 ("RDMA/rtrs: core: lib functions shared between client and server modules") +Link: https://lore.kernel.org/r/20210528113018.52290-16-jinpu.wang@ionos.com +Signed-off-by: Gioh Kim +Signed-off-by: Jack Wang +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c +index d13aff0aa816..4629bb758126 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs.c +@@ -373,7 +373,6 @@ void rtrs_stop_hb(struct rtrs_sess *sess) + { + cancel_delayed_work_sync(&sess->hb_dwork); + sess->hb_missed_cnt = 0; +- sess->hb_missed_max = 0; + } + EXPORT_SYMBOL_GPL(rtrs_stop_hb); + +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-srv-fix-memory-leak-of-unfreed-rtrs_srv_st.patch b/queue-5.10/rdma-rtrs-srv-fix-memory-leak-of-unfreed-rtrs_srv_st.patch new file mode 100644 index 00000000000..01bca4d035b --- /dev/null +++ b/queue-5.10/rdma-rtrs-srv-fix-memory-leak-of-unfreed-rtrs_srv_st.patch @@ -0,0 +1,69 @@ +From 320656da6630477d1033263b57c81351dbd29ea8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:15 +0200 +Subject: RDMA/rtrs-srv: Fix memory leak of unfreed rtrs_srv_stats object + +From: Gioh Kim + +[ Upstream commit 2371c40354509746e4a4dad09a752e027a30f148 ] + +When closing a session, currently the rtrs_srv_stats object in the +closing session is freed by kobject release. But if it failed +to create a session by various reasons, it must free the rtrs_srv_stats +object directly because kobject is not created yet. + +This problem is found by kmemleak as below: + +1. One client machine maps /dev/nullb0 with session name 'bla': +root@test1:~# echo "sessname=bla path=ip:192.168.122.190 \ +device_path=/dev/nullb0" > /sys/devices/virtual/rnbd-client/ctl/map_device + +2. Another machine failed to create a session with the same name 'bla': +root@test2:~# echo "sessname=bla path=ip:192.168.122.190 \ +device_path=/dev/nullb1" > /sys/devices/virtual/rnbd-client/ctl/map_device +-bash: echo: write error: Connection reset by peer + +3. The kmemleak on server machine reported an error: +unreferenced object 0xffff888033cdc800 (size 128): + comm "kworker/2:1", pid 83, jiffies 4295086585 (age 2508.680s) + hex dump (first 32 bytes): + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + backtrace: + [<00000000a72903b2>] __alloc_sess+0x1d4/0x1250 [rtrs_server] + [<00000000d1e5321e>] rtrs_srv_rdma_cm_handler+0xc31/0xde0 [rtrs_server] + [<00000000bb2f6e7e>] cma_ib_req_handler+0xdc5/0x2b50 [rdma_cm] + [<00000000e896235d>] cm_process_work+0x2d/0x100 [ib_cm] + [<00000000b6866c5f>] cm_req_handler+0x11bc/0x1c40 [ib_cm] + [<000000005f5dd9aa>] cm_work_handler+0xe65/0x3cf2 [ib_cm] + [<00000000610151e7>] process_one_work+0x4bc/0x980 + [<00000000541e0f77>] worker_thread+0x78/0x5c0 + [<00000000423898ca>] kthread+0x191/0x1e0 + [<000000005a24b239>] ret_from_fork+0x3a/0x50 + +Fixes: 39c2d639ca183 ("RDMA/rtrs-srv: Set .release function for rtrs srv device during device init") +Link: https://lore.kernel.org/r/20210528113018.52290-18-jinpu.wang@ionos.com +Signed-off-by: Gioh Kim +Signed-off-by: Md Haris Iqbal +Signed-off-by: Jack Wang +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-srv.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c +index 43806180f85e..e1041023d143 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c +@@ -1490,6 +1490,7 @@ static void free_sess(struct rtrs_srv_sess *sess) + kobject_del(&sess->kobj); + kobject_put(&sess->kobj); + } else { ++ kfree(sess->stats); + kfree(sess); + } + } +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-srv-fix-memory-leak-when-having-multiple-s.patch b/queue-5.10/rdma-rtrs-srv-fix-memory-leak-when-having-multiple-s.patch new file mode 100644 index 00000000000..f3b5d5f0463 --- /dev/null +++ b/queue-5.10/rdma-rtrs-srv-fix-memory-leak-when-having-multiple-s.patch @@ -0,0 +1,88 @@ +From 049b352f7b5fc8623860d89d10aff217346345ef Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 28 May 2021 13:30:16 +0200 +Subject: RDMA/rtrs-srv: Fix memory leak when having multiple sessions + +From: Jack Wang + +[ Upstream commit 6bb97a2c1aa5278a30d49abb6186d50c34c207e2 ] + +Gioh notice memory leak below +unreferenced object 0xffff8880acda2000 (size 2048): + comm "kworker/4:1", pid 77, jiffies 4295062871 (age 1270.730s) + hex dump (first 32 bytes): + 00 20 da ac 80 88 ff ff 00 20 da ac 80 88 ff ff . ....... ...... + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + backtrace: + [<00000000e85d85b5>] rtrs_srv_rdma_cm_handler+0x8e5/0xa90 [rtrs_server] + [<00000000e31a988a>] cma_ib_req_handler+0xdc5/0x2b50 [rdma_cm] + [<000000000eb02c5b>] cm_process_work+0x2d/0x100 [ib_cm] + [<00000000e1650ca9>] cm_req_handler+0x11bc/0x1c40 [ib_cm] + [<000000009c28818b>] cm_work_handler+0xe65/0x3cf2 [ib_cm] + [<000000002b53eaa1>] process_one_work+0x4bc/0x980 + [<00000000da3499fb>] worker_thread+0x78/0x5c0 + [<00000000167127a4>] kthread+0x191/0x1e0 + [<0000000060802104>] ret_from_fork+0x3a/0x50 +unreferenced object 0xffff88806d595d90 (size 8): + comm "kworker/4:1H", pid 131, jiffies 4295062972 (age 1269.720s) + hex dump (first 8 bytes): + 62 6c 61 00 6b 6b 6b a5 bla.kkk. + backtrace: + [<000000004447d253>] kstrdup+0x2e/0x60 + [<0000000047259793>] kobject_set_name_vargs+0x2f/0xb0 + [<00000000c2ee3bc8>] dev_set_name+0xab/0xe0 + [<000000002b6bdfb1>] rtrs_srv_create_sess_files+0x260/0x290 [rtrs_server] + [<0000000075d87bd7>] rtrs_srv_info_req_done+0x71b/0x960 [rtrs_server] + [<00000000ccdf1bb5>] __ib_process_cq+0x94/0x100 [ib_core] + [<00000000cbcb60cb>] ib_cq_poll_work+0x32/0xc0 [ib_core] + [<000000002b53eaa1>] process_one_work+0x4bc/0x980 + [<00000000da3499fb>] worker_thread+0x78/0x5c0 + [<00000000167127a4>] kthread+0x191/0x1e0 + [<0000000060802104>] ret_from_fork+0x3a/0x50 +unreferenced object 0xffff88806d6bb100 (size 256): + comm "kworker/4:1H", pid 131, jiffies 4295062972 (age 1269.720s) + hex dump (first 32 bytes): + 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... + ff ff ff ff ff ff ff ff 00 59 4d 86 ff ff ff ff .........YM..... + backtrace: + [<00000000a18a11e4>] device_add+0x74d/0xa00 + [<00000000a915b95f>] rtrs_srv_create_sess_files.cold+0x49/0x1fe [rtrs_server] + [<0000000075d87bd7>] rtrs_srv_info_req_done+0x71b/0x960 [rtrs_server] + [<00000000ccdf1bb5>] __ib_process_cq+0x94/0x100 [ib_core] + [<00000000cbcb60cb>] ib_cq_poll_work+0x32/0xc0 [ib_core] + [<000000002b53eaa1>] process_one_work+0x4bc/0x980 + [<00000000da3499fb>] worker_thread+0x78/0x5c0 + [<00000000167127a4>] kthread+0x191/0x1e0 + [<0000000060802104>] ret_from_fork+0x3a/0x50 + +The problem is we increase device refcount by get_device in process_info_req +for each path, but only does put_deice for last path, which lead to +memory leak. + +To fix it, it also calls put_device when dev_ref is not 0. + +Fixes: e2853c49477d1 ("RDMA/rtrs-srv-sysfs: fix missing put_device") +Link: https://lore.kernel.org/r/20210528113018.52290-19-jinpu.wang@ionos.com +Signed-off-by: Gioh Kim +Signed-off-by: Jack Wang +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c +index 39708ab4f26e..7c75e1459017 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c +@@ -214,6 +214,7 @@ rtrs_srv_destroy_once_sysfs_root_folders(struct rtrs_srv_sess *sess) + device_del(&srv->dev); + put_device(&srv->dev); + } else { ++ put_device(&srv->dev); + mutex_unlock(&srv->paths_mutex); + } + } +-- +2.30.2 + diff --git a/queue-5.10/rdma-rtrs-srv-set-minimal-max_send_wr-and-max_recv_w.patch b/queue-5.10/rdma-rtrs-srv-set-minimal-max_send_wr-and-max_recv_w.patch new file mode 100644 index 00000000000..c65ecebd349 --- /dev/null +++ b/queue-5.10/rdma-rtrs-srv-set-minimal-max_send_wr-and-max_recv_w.patch @@ -0,0 +1,107 @@ +From 0781237690a294684985aed3bdb4eecdab527829 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Jun 2021 11:03:33 +0200 +Subject: RDMA/rtrs-srv: Set minimal max_send_wr and max_recv_wr + +From: Jack Wang + +[ Upstream commit 5e91eabf66c854f16ca2e954e5c68939bc81601e ] + +Currently rtrs when create_qp use a coarse numbers (bigger in general), +which leads to hardware create more resources which only waste memory with +no benefits. + +For max_send_wr, we don't really need alway max_qp_wr size when creating +qp, reduce it to cq_size. + +For max_recv_wr, cq_size is enough. + +With the patch when sess_queue_depth=128, per session (2 paths) memory +consumption reduced from 188 MB to 65MB + +When always_invalidate is enabled, we need send more wr, so treat it +special. + +Fixes: 9cb837480424e ("RDMA/rtrs: server: main functionality") +Link: https://lore.kernel.org/r/20210614090337.29557-2-jinpu.wang@ionos.com +Signed-off-by: Jack Wang +Reviewed-by: Md Haris Iqbal +Signed-off-by: Gioh Kim +Reviewed-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/rtrs/rtrs-srv.c | 38 +++++++++++++++++--------- + 1 file changed, 25 insertions(+), 13 deletions(-) + +diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c +index e1041023d143..b033bfa9f383 100644 +--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c ++++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c +@@ -1614,7 +1614,7 @@ static int create_con(struct rtrs_srv_sess *sess, + struct rtrs_sess *s = &sess->s; + struct rtrs_srv_con *con; + +- u32 cq_size, wr_queue_size; ++ u32 cq_size, max_send_wr, max_recv_wr, wr_limit; + int err, cq_vector; + + con = kzalloc(sizeof(*con), GFP_KERNEL); +@@ -1635,30 +1635,42 @@ static int create_con(struct rtrs_srv_sess *sess, + * All receive and all send (each requiring invalidate) + * + 2 for drain and heartbeat + */ +- wr_queue_size = SERVICE_CON_QUEUE_DEPTH * 3 + 2; +- cq_size = wr_queue_size; ++ max_send_wr = SERVICE_CON_QUEUE_DEPTH * 2 + 2; ++ max_recv_wr = SERVICE_CON_QUEUE_DEPTH + 2; ++ cq_size = max_send_wr + max_recv_wr; + } else { +- /* +- * If we have all receive requests posted and +- * all write requests posted and each read request +- * requires an invalidate request + drain +- * and qp gets into error state. +- */ +- cq_size = srv->queue_depth * 3 + 1; + /* + * In theory we might have queue_depth * 32 + * outstanding requests if an unsafe global key is used + * and we have queue_depth read requests each consisting + * of 32 different addresses. div 3 for mlx5. + */ +- wr_queue_size = sess->s.dev->ib_dev->attrs.max_qp_wr / 3; ++ wr_limit = sess->s.dev->ib_dev->attrs.max_qp_wr / 3; ++ /* when always_invlaidate enalbed, we need linv+rinv+mr+imm */ ++ if (always_invalidate) ++ max_send_wr = ++ min_t(int, wr_limit, ++ srv->queue_depth * (1 + 4) + 1); ++ else ++ max_send_wr = ++ min_t(int, wr_limit, ++ srv->queue_depth * (1 + 2) + 1); ++ ++ max_recv_wr = srv->queue_depth + 1; ++ /* ++ * If we have all receive requests posted and ++ * all write requests posted and each read request ++ * requires an invalidate request + drain ++ * and qp gets into error state. ++ */ ++ cq_size = max_send_wr + max_recv_wr; + } +- atomic_set(&con->sq_wr_avail, wr_queue_size); ++ atomic_set(&con->sq_wr_avail, max_send_wr); + cq_vector = rtrs_srv_get_next_cq_vector(sess); + + /* TODO: SOFTIRQ can be faster, but be careful with softirq context */ + err = rtrs_cq_qp_create(&sess->s, &con->c, 1, cq_vector, cq_size, +- wr_queue_size, wr_queue_size, ++ max_send_wr, max_recv_wr, + IB_POLL_WORKQUEUE); + if (err) { + rtrs_err(s, "rtrs_cq_qp_create(), err: %d\n", err); +-- +2.30.2 + diff --git a/queue-5.10/rdma-rxe-fix-failure-during-driver-load.patch b/queue-5.10/rdma-rxe-fix-failure-during-driver-load.patch new file mode 100644 index 00000000000..26c575ddf72 --- /dev/null +++ b/queue-5.10/rdma-rxe-fix-failure-during-driver-load.patch @@ -0,0 +1,58 @@ +From 31312db8d9fa233f096fa78eda7920d24835d4e7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Jun 2021 12:01:12 +0300 +Subject: RDMA/rxe: Fix failure during driver load + +From: Kamal Heib + +[ Upstream commit 32a25f2ea690dfaace19f7a3a916f5d7e1ddafe8 ] + +To avoid the following failure when trying to load the rdma_rxe module +while IPv6 is disabled, add a check for EAFNOSUPPORT and ignore the +failure, also delete the needless debug print from rxe_setup_udp_tunnel(). + +$ modprobe rdma_rxe +modprobe: ERROR: could not insert 'rdma_rxe': Operation not permitted + +Fixes: dfdd6158ca2c ("IB/rxe: Fix kernel panic in udp_setup_tunnel") +Link: https://lore.kernel.org/r/20210603090112.36341-1-kamalheib1@gmail.com +Reported-by: Yi Zhang +Signed-off-by: Kamal Heib +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/sw/rxe/rxe_net.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c +index bce44502ab0e..c071d5b1b85a 100644 +--- a/drivers/infiniband/sw/rxe/rxe_net.c ++++ b/drivers/infiniband/sw/rxe/rxe_net.c +@@ -212,10 +212,8 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, + + /* Create UDP socket */ + err = udp_sock_create(net, &udp_cfg, &sock); +- if (err < 0) { +- pr_err("failed to create udp socket. err = %d\n", err); ++ if (err < 0) + return ERR_PTR(err); +- } + + tnl_cfg.encap_type = 1; + tnl_cfg.encap_rcv = rxe_udp_encap_recv; +@@ -616,6 +614,12 @@ static int rxe_net_ipv6_init(void) + + recv_sockets.sk6 = rxe_setup_udp_tunnel(&init_net, + htons(ROCE_V2_UDP_DPORT), true); ++ if (PTR_ERR(recv_sockets.sk6) == -EAFNOSUPPORT) { ++ recv_sockets.sk6 = NULL; ++ pr_warn("IPv6 is not supported, can not create a UDPv6 socket\n"); ++ return 0; ++ } ++ + if (IS_ERR(recv_sockets.sk6)) { + recv_sockets.sk6 = NULL; + pr_err("Failed to create IPv6 UDP tunnel\n"); +-- +2.30.2 + diff --git a/queue-5.10/rdma-rxe-fix-qp-reference-counting-for-atomic-ops.patch b/queue-5.10/rdma-rxe-fix-qp-reference-counting-for-atomic-ops.patch new file mode 100644 index 00000000000..fb2e8e24888 --- /dev/null +++ b/queue-5.10/rdma-rxe-fix-qp-reference-counting-for-atomic-ops.patch @@ -0,0 +1,60 @@ +From a261c9da32c51e2d21ce8ea110e36eb3e7e7cce1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 4 Jun 2021 18:05:59 -0500 +Subject: RDMA/rxe: Fix qp reference counting for atomic ops + +From: Bob Pearson + +[ Upstream commit 15ae1375ea91ae2dee6f12d71a79d8c0a10a30bf ] + +Currently the rdma_rxe driver attempts to protect atomic responder +resources by taking a reference to the qp which is only freed when the +resource is recycled for a new read or atomic operation. This means that +in normal circumstances there is almost always an extra qp reference once +an atomic operation has been executed which prevents cleaning up the qp +and associated pd and cqs when the qp is destroyed. + +This patch removes the call to rxe_add_ref() in send_atomic_ack() and the +call to rxe_drop_ref() in free_rd_atomic_resource(). If the qp is +destroyed while a peer is retrying an atomic op it will cause the +operation to fail which is acceptable. + +Link: https://lore.kernel.org/r/20210604230558.4812-1-rpearsonhpe@gmail.com +Reported-by: Zhu Yanjun +Fixes: 86af61764151 ("IB/rxe: remove unnecessary skb_clone") +Signed-off-by: Bob Pearson +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/sw/rxe/rxe_qp.c | 1 - + drivers/infiniband/sw/rxe/rxe_resp.c | 2 -- + 2 files changed, 3 deletions(-) + +diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c +index 1e716fe7014c..a1b79015e6f2 100644 +--- a/drivers/infiniband/sw/rxe/rxe_qp.c ++++ b/drivers/infiniband/sw/rxe/rxe_qp.c +@@ -125,7 +125,6 @@ static void free_rd_atomic_resources(struct rxe_qp *qp) + void free_rd_atomic_resource(struct rxe_qp *qp, struct resp_res *res) + { + if (res->type == RXE_ATOMIC_MASK) { +- rxe_drop_ref(qp); + kfree_skb(res->atomic.skb); + } else if (res->type == RXE_READ_MASK) { + if (res->read.mr) +diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c +index c7e3b6a4af38..83c03212099a 100644 +--- a/drivers/infiniband/sw/rxe/rxe_resp.c ++++ b/drivers/infiniband/sw/rxe/rxe_resp.c +@@ -966,8 +966,6 @@ static int send_atomic_ack(struct rxe_qp *qp, struct rxe_pkt_info *pkt, + goto out; + } + +- rxe_add_ref(qp); +- + res = &qp->resp.resources[qp->resp.res_head]; + free_rd_atomic_resource(qp, res); + rxe_advance_resp_resource(qp); +-- +2.30.2 + diff --git a/queue-5.10/rdma-srp-fix-a-recently-introduced-memory-leak.patch b/queue-5.10/rdma-srp-fix-a-recently-introduced-memory-leak.patch new file mode 100644 index 00000000000..2d8d1146281 --- /dev/null +++ b/queue-5.10/rdma-srp-fix-a-recently-introduced-memory-leak.patch @@ -0,0 +1,56 @@ +From 2ff6f8e03c910f3d630cddc15602b4204c4dd6fc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 23 May 2021 21:12:10 -0700 +Subject: RDMA/srp: Fix a recently introduced memory leak + +From: Bart Van Assche + +[ Upstream commit 7ec2e27a3afff64c96bfe7a77685c33619db84be ] + +Only allocate a memory registration list if it will be used and if it will +be freed. + +Link: https://lore.kernel.org/r/20210524041211.9480-5-bvanassche@acm.org +Reviewed-by: Max Gurtovoy +Fixes: f273ad4f8d90 ("RDMA/srp: Remove support for FMR memory registration") +Signed-off-by: Bart Van Assche +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/srp/ib_srp.c | 13 ++++++------- + 1 file changed, 6 insertions(+), 7 deletions(-) + +diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c +index a8f85993dab3..86d5c4c92b36 100644 +--- a/drivers/infiniband/ulp/srp/ib_srp.c ++++ b/drivers/infiniband/ulp/srp/ib_srp.c +@@ -998,7 +998,6 @@ static int srp_alloc_req_data(struct srp_rdma_ch *ch) + struct srp_device *srp_dev = target->srp_host->srp_dev; + struct ib_device *ibdev = srp_dev->dev; + struct srp_request *req; +- void *mr_list; + dma_addr_t dma_addr; + int i, ret = -ENOMEM; + +@@ -1009,12 +1008,12 @@ static int srp_alloc_req_data(struct srp_rdma_ch *ch) + + for (i = 0; i < target->req_ring_size; ++i) { + req = &ch->req_ring[i]; +- mr_list = kmalloc_array(target->mr_per_cmd, sizeof(void *), +- GFP_KERNEL); +- if (!mr_list) +- goto out; +- if (srp_dev->use_fast_reg) +- req->fr_list = mr_list; ++ if (srp_dev->use_fast_reg) { ++ req->fr_list = kmalloc_array(target->mr_per_cmd, ++ sizeof(void *), GFP_KERNEL); ++ if (!req->fr_list) ++ goto out; ++ } + req->indirect_desc = kmalloc(target->indirect_size, GFP_KERNEL); + if (!req->indirect_desc) + goto out; +-- +2.30.2 + diff --git a/queue-5.10/regulator-da9052-ensure-enough-delay-time-for-.set_v.patch b/queue-5.10/regulator-da9052-ensure-enough-delay-time-for-.set_v.patch new file mode 100644 index 00000000000..db8f108eaa4 --- /dev/null +++ b/queue-5.10/regulator-da9052-ensure-enough-delay-time-for-.set_v.patch @@ -0,0 +1,39 @@ +From 72b761d709533b4f682182b6f3c2301741cbf3ea Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 22:14:11 +0800 +Subject: regulator: da9052: Ensure enough delay time for .set_voltage_time_sel + +From: Axel Lin + +[ Upstream commit a336dc8f683e5be794186b5643cd34cb28dd2c53 ] + +Use DIV_ROUND_UP to prevent truncation by integer division issue. +This ensures we return enough delay time. + +Also fix returning negative value when new_sel < old_sel. + +Signed-off-by: Axel Lin +Link: https://lore.kernel.org/r/20210618141412.4014912-1-axel.lin@ingics.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/da9052-regulator.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c +index e18d291c7f21..23fa429ebe76 100644 +--- a/drivers/regulator/da9052-regulator.c ++++ b/drivers/regulator/da9052-regulator.c +@@ -250,7 +250,8 @@ static int da9052_regulator_set_voltage_time_sel(struct regulator_dev *rdev, + case DA9052_ID_BUCK3: + case DA9052_ID_LDO2: + case DA9052_ID_LDO3: +- ret = (new_sel - old_sel) * info->step_uV / 6250; ++ ret = DIV_ROUND_UP(abs(new_sel - old_sel) * info->step_uV, ++ 6250); + break; + } + +-- +2.30.2 + diff --git a/queue-5.10/regulator-fan53880-fix-vsel_mask-setting-for-fan5388.patch b/queue-5.10/regulator-fan53880-fix-vsel_mask-setting-for-fan5388.patch new file mode 100644 index 00000000000..7ca019f6708 --- /dev/null +++ b/queue-5.10/regulator-fan53880-fix-vsel_mask-setting-for-fan5388.patch @@ -0,0 +1,42 @@ +From 8c7c20e7b64d3a9784ac7d05c8c010ea4fa82426 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Jun 2021 22:29:07 +0800 +Subject: regulator: fan53880: Fix vsel_mask setting for FAN53880_BUCK +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Axel Lin + +[ Upstream commit 2e11737a772b95c6587df73f216eec1762431432 ] + +According to the datasheet: +REGISTER DETAILS − 0x02 BUCK, BUCK_OUT is BIT0 ~ BIT7. + +So vsel_mask for FAN53880_BUCK should be 0xFF. + +Fixes: e6dea51e2d41 ("regulator: fan53880: Add initial support") +Signed-off-by: Axel Lin +Link: https://lore.kernel.org/r/20210607142907.1599905-1-axel.lin@ingics.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/fan53880.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c +index 1684faf82ed2..94f02f3099dd 100644 +--- a/drivers/regulator/fan53880.c ++++ b/drivers/regulator/fan53880.c +@@ -79,7 +79,7 @@ static const struct regulator_desc fan53880_regulators[] = { + .n_linear_ranges = 2, + .n_voltages = 0xf8, + .vsel_reg = FAN53880_BUCKVOUT, +- .vsel_mask = 0x7f, ++ .vsel_mask = 0xff, + .enable_reg = FAN53880_ENABLE, + .enable_mask = 0x10, + .enable_time = 480, +-- +2.30.2 + diff --git a/queue-5.10/regulator-hi655x-fix-pass-wrong-pointer-to-config.dr.patch b/queue-5.10/regulator-hi655x-fix-pass-wrong-pointer-to-config.dr.patch new file mode 100644 index 00000000000..a3e3042312a --- /dev/null +++ b/queue-5.10/regulator-hi655x-fix-pass-wrong-pointer-to-config.dr.patch @@ -0,0 +1,80 @@ +From bbcf109983fdbb64839e8c9dcd77e65a52fca70c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 20 Jun 2021 21:27:15 +0800 +Subject: regulator: hi655x: Fix pass wrong pointer to config.driver_data + +From: Axel Lin + +[ Upstream commit 61eb1b24f9e4f4e0725aa5f8164a932c933f3339 ] + +Current code sets config.driver_data to a zero initialized regulator +which is obviously wrong. Fix it. + +Fixes: 4618119b9be5 ("regulator: hi655x: enable regulator for hi655x PMIC") +Signed-off-by: Axel Lin +Link: https://lore.kernel.org/r/20210620132715.60215-1-axel.lin@ingics.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/hi655x-regulator.c | 16 +++++----------- + 1 file changed, 5 insertions(+), 11 deletions(-) + +diff --git a/drivers/regulator/hi655x-regulator.c b/drivers/regulator/hi655x-regulator.c +index ac2ee2030211..b44f492a2b83 100644 +--- a/drivers/regulator/hi655x-regulator.c ++++ b/drivers/regulator/hi655x-regulator.c +@@ -72,7 +72,7 @@ enum hi655x_regulator_id { + static int hi655x_is_enabled(struct regulator_dev *rdev) + { + unsigned int value = 0; +- struct hi655x_regulator *regulator = rdev_get_drvdata(rdev); ++ const struct hi655x_regulator *regulator = rdev_get_drvdata(rdev); + + regmap_read(rdev->regmap, regulator->status_reg, &value); + return (value & rdev->desc->enable_mask); +@@ -80,7 +80,7 @@ static int hi655x_is_enabled(struct regulator_dev *rdev) + + static int hi655x_disable(struct regulator_dev *rdev) + { +- struct hi655x_regulator *regulator = rdev_get_drvdata(rdev); ++ const struct hi655x_regulator *regulator = rdev_get_drvdata(rdev); + + return regmap_write(rdev->regmap, regulator->disable_reg, + rdev->desc->enable_mask); +@@ -169,7 +169,6 @@ static const struct hi655x_regulator regulators[] = { + static int hi655x_regulator_probe(struct platform_device *pdev) + { + unsigned int i; +- struct hi655x_regulator *regulator; + struct hi655x_pmic *pmic; + struct regulator_config config = { }; + struct regulator_dev *rdev; +@@ -180,22 +179,17 @@ static int hi655x_regulator_probe(struct platform_device *pdev) + return -ENODEV; + } + +- regulator = devm_kzalloc(&pdev->dev, sizeof(*regulator), GFP_KERNEL); +- if (!regulator) +- return -ENOMEM; +- +- platform_set_drvdata(pdev, regulator); +- + config.dev = pdev->dev.parent; + config.regmap = pmic->regmap; +- config.driver_data = regulator; + for (i = 0; i < ARRAY_SIZE(regulators); i++) { ++ config.driver_data = (void *) ®ulators[i]; ++ + rdev = devm_regulator_register(&pdev->dev, + ®ulators[i].rdesc, + &config); + if (IS_ERR(rdev)) { + dev_err(&pdev->dev, "failed to register regulator %s\n", +- regulator->rdesc.name); ++ regulators[i].rdesc.name); + return PTR_ERR(rdev); + } + } +-- +2.30.2 + diff --git a/queue-5.10/regulator-mt6358-fix-vdram2-.vsel_mask.patch b/queue-5.10/regulator-mt6358-fix-vdram2-.vsel_mask.patch new file mode 100644 index 00000000000..a4652930fab --- /dev/null +++ b/queue-5.10/regulator-mt6358-fix-vdram2-.vsel_mask.patch @@ -0,0 +1,36 @@ +From 5f842860e275d33273f03ede375902848914338e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 12:56:09 +0800 +Subject: regulator: mt6358: Fix vdram2 .vsel_mask + +From: Hsin-Hsiung Wang + +[ Upstream commit 50c9462edcbf900f3d5097ca3ad60171346124de ] + +The valid vsel value are 0 and 12, so the .vsel_mask should be 0xf. + +Signed-off-by: Hsin-Hsiung Wang +Reviewed-by: Axel Lin +Link: https://lore.kernel.org/r/1624424169-510-1-git-send-email-hsin-hsiung.wang@mediatek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/mt6358-regulator.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c +index 13cb6ac9a892..1d4eb5dc4fac 100644 +--- a/drivers/regulator/mt6358-regulator.c ++++ b/drivers/regulator/mt6358-regulator.c +@@ -457,7 +457,7 @@ static struct mt6358_regulator_info mt6358_regulators[] = { + MT6358_REG_FIXED("ldo_vaud28", VAUD28, + MT6358_LDO_VAUD28_CON0, 0, 2800000), + MT6358_LDO("ldo_vdram2", VDRAM2, vdram2_voltages, vdram2_idx, +- MT6358_LDO_VDRAM2_CON0, 0, MT6358_LDO_VDRAM2_ELR0, 0x10, 0), ++ MT6358_LDO_VDRAM2_CON0, 0, MT6358_LDO_VDRAM2_ELR0, 0xf, 0), + MT6358_LDO("ldo_vsim1", VSIM1, vsim_voltages, vsim_idx, + MT6358_LDO_VSIM1_CON0, 0, MT6358_VSIM1_ANA_CON0, 0xf00, 8), + MT6358_LDO("ldo_vibr", VIBR, vibr_voltages, vibr_idx, +-- +2.30.2 + diff --git a/queue-5.10/regulator-uniphier-add-missing-module_device_table.patch b/queue-5.10/regulator-uniphier-add-missing-module_device_table.patch new file mode 100644 index 00000000000..7296beea713 --- /dev/null +++ b/queue-5.10/regulator-uniphier-add-missing-module_device_table.patch @@ -0,0 +1,37 @@ +From 5150ab45095b674f64a392fa492e13050b415007 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 11 May 2021 11:53:18 +0800 +Subject: regulator: uniphier: Add missing MODULE_DEVICE_TABLE + +From: Zou Wei + +[ Upstream commit d019f38a1af3c6015cde6a47951a3ec43beeed80 ] + +This patch adds missing MODULE_DEVICE_TABLE definition which generates +correct modalias for automatic loading of this driver when it is built +as an external module. + +Reported-by: Hulk Robot +Signed-off-by: Zou Wei +Link: https://lore.kernel.org/r/1620705198-104566-1-git-send-email-zou_wei@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/uniphier-regulator.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c +index 2e02e26b516c..e75b0973e325 100644 +--- a/drivers/regulator/uniphier-regulator.c ++++ b/drivers/regulator/uniphier-regulator.c +@@ -201,6 +201,7 @@ static const struct of_device_id uniphier_regulator_match[] = { + }, + { /* Sentinel */ }, + }; ++MODULE_DEVICE_TABLE(of, uniphier_regulator_match); + + static struct platform_driver uniphier_regulator_driver = { + .probe = uniphier_regulator_probe, +-- +2.30.2 + diff --git a/queue-5.10/revert-be2net-disable-bh-with-spin_lock-in-be_proces.patch b/queue-5.10/revert-be2net-disable-bh-with-spin_lock-in-be_proces.patch new file mode 100644 index 00000000000..6debf77bb95 --- /dev/null +++ b/queue-5.10/revert-be2net-disable-bh-with-spin_lock-in-be_proces.patch @@ -0,0 +1,118 @@ +From 17da20d61e756d57529cd51d6f93b25a39a61449 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 10:27:45 +0200 +Subject: Revert "be2net: disable bh with spin_lock in be_process_mcc" + +From: Petr Oros + +[ Upstream commit d6765985a42a660f078896d5c5b27f97c580a490 ] + +Patch was based on wrong presumption that be_poll can be called only +from bh context. It reintroducing old regression (also reverted) and +causing deadlock when we use netconsole with benet in bonding. + +Old revert: commit 072a9c486004 ("netpoll: revert 6bdb7fe3104 and fix +be_poll() instead") + +[ 331.269715] bond0: (slave enp0s7f0): Releasing backup interface +[ 331.270121] CPU: 4 PID: 1479 Comm: ifenslave Not tainted 5.13.0-rc7+ #2 +[ 331.270122] Call Trace: +[ 331.270122] [c00000001789f200] [c0000000008c505c] dump_stack+0x100/0x174 (unreliable) +[ 331.270124] [c00000001789f240] [c008000001238b9c] be_poll+0x64/0xe90 [be2net] +[ 331.270125] [c00000001789f330] [c000000000d1e6e4] netpoll_poll_dev+0x174/0x3d0 +[ 331.270127] [c00000001789f400] [c008000001bc167c] bond_poll_controller+0xb4/0x130 [bonding] +[ 331.270128] [c00000001789f450] [c000000000d1e624] netpoll_poll_dev+0xb4/0x3d0 +[ 331.270129] [c00000001789f520] [c000000000d1ed88] netpoll_send_skb+0x448/0x470 +[ 331.270130] [c00000001789f5d0] [c0080000011f14f8] write_msg+0x180/0x1b0 [netconsole] +[ 331.270131] [c00000001789f640] [c000000000230c0c] console_unlock+0x54c/0x790 +[ 331.270132] [c00000001789f7b0] [c000000000233098] vprintk_emit+0x2d8/0x450 +[ 331.270133] [c00000001789f810] [c000000000234758] vprintk+0xc8/0x270 +[ 331.270134] [c00000001789f850] [c000000000233c28] printk+0x40/0x54 +[ 331.270135] [c00000001789f870] [c000000000ccf908] __netdev_printk+0x150/0x198 +[ 331.270136] [c00000001789f910] [c000000000ccfdb4] netdev_info+0x68/0x94 +[ 331.270137] [c00000001789f950] [c008000001bcbd70] __bond_release_one+0x188/0x6b0 [bonding] +[ 331.270138] [c00000001789faa0] [c008000001bcc6f4] bond_do_ioctl+0x42c/0x490 [bonding] +[ 331.270139] [c00000001789fb60] [c000000000d0d17c] dev_ifsioc+0x17c/0x400 +[ 331.270140] [c00000001789fbc0] [c000000000d0db70] dev_ioctl+0x390/0x890 +[ 331.270141] [c00000001789fc10] [c000000000c7c76c] sock_do_ioctl+0xac/0x1b0 +[ 331.270142] [c00000001789fc90] [c000000000c7ffac] sock_ioctl+0x31c/0x6e0 +[ 331.270143] [c00000001789fd60] [c0000000005b9728] sys_ioctl+0xf8/0x150 +[ 331.270145] [c00000001789fdb0] [c0000000000336c0] system_call_exception+0x160/0x2f0 +[ 331.270146] [c00000001789fe10] [c00000000000d35c] system_call_common+0xec/0x278 +[ 331.270147] --- interrupt: c00 at 0x7fffa6c6ec00 +[ 331.270147] NIP: 00007fffa6c6ec00 LR: 0000000105c4185c CTR: 0000000000000000 +[ 331.270148] REGS: c00000001789fe80 TRAP: 0c00 Not tainted (5.13.0-rc7+) +[ 331.270148] MSR: 800000000280f033 CR: 28000428 XER: 00000000 +[ 331.270155] IRQMASK: 0 +[ 331.270156] GPR00: 0000000000000036 00007fffd494d5b0 00007fffa6d57100 0000000000000003 +[ 331.270158] GPR04: 0000000000008991 00007fffd494d6d0 0000000000000008 00007fffd494f28c +[ 331.270161] GPR08: 0000000000000003 0000000000000000 0000000000000000 0000000000000000 +[ 331.270164] GPR12: 0000000000000000 00007fffa6dfa220 0000000000000000 0000000000000000 +[ 331.270167] GPR16: 0000000105c44880 0000000000000000 0000000105c60088 0000000105c60318 +[ 331.270170] GPR20: 0000000105c602c0 0000000105c44560 0000000000000000 0000000000000000 +[ 331.270172] GPR24: 00007fffd494dc50 00007fffd494d6a8 0000000105c60008 00007fffd494d6d0 +[ 331.270175] GPR28: 00007fffd494f27e 0000000105c6026c 00007fffd494f284 0000000000000000 +[ 331.270178] NIP [00007fffa6c6ec00] 0x7fffa6c6ec00 +[ 331.270178] LR [0000000105c4185c] 0x105c4185c +[ 331.270179] --- interrupt: c00 + +This reverts commit d0d006a43e9a7a796f6f178839c92fcc222c564d. + +Fixes: d0d006a43e9a7a ("be2net: disable bh with spin_lock in be_process_mcc") +Signed-off-by: Petr Oros +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/emulex/benet/be_cmds.c | 6 ++++-- + drivers/net/ethernet/emulex/benet/be_main.c | 2 ++ + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c +index 701c12c9e033..649c5c429bd7 100644 +--- a/drivers/net/ethernet/emulex/benet/be_cmds.c ++++ b/drivers/net/ethernet/emulex/benet/be_cmds.c +@@ -550,7 +550,7 @@ int be_process_mcc(struct be_adapter *adapter) + int num = 0, status = 0; + struct be_mcc_obj *mcc_obj = &adapter->mcc_obj; + +- spin_lock_bh(&adapter->mcc_cq_lock); ++ spin_lock(&adapter->mcc_cq_lock); + + while ((compl = be_mcc_compl_get(adapter))) { + if (compl->flags & CQE_FLAGS_ASYNC_MASK) { +@@ -566,7 +566,7 @@ int be_process_mcc(struct be_adapter *adapter) + if (num) + be_cq_notify(adapter, mcc_obj->cq.id, mcc_obj->rearm_cq, num); + +- spin_unlock_bh(&adapter->mcc_cq_lock); ++ spin_unlock(&adapter->mcc_cq_lock); + return status; + } + +@@ -581,7 +581,9 @@ static int be_mcc_wait_compl(struct be_adapter *adapter) + if (be_check_error(adapter, BE_ERROR_ANY)) + return -EIO; + ++ local_bh_disable(); + status = be_process_mcc(adapter); ++ local_bh_enable(); + + if (atomic_read(&mcc_obj->q.used) == 0) + break; +diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c +index cb1e1ad652d0..89697cb09d1c 100644 +--- a/drivers/net/ethernet/emulex/benet/be_main.c ++++ b/drivers/net/ethernet/emulex/benet/be_main.c +@@ -5509,7 +5509,9 @@ static void be_worker(struct work_struct *work) + * mcc completions + */ + if (!netif_running(adapter->netdev)) { ++ local_bh_disable(); + be_process_mcc(adapter); ++ local_bh_enable(); + goto reschedule; + } + +-- +2.30.2 + diff --git a/queue-5.10/revert-ibmvnic-remove-duplicate-napi_schedule-call-i.patch b/queue-5.10/revert-ibmvnic-remove-duplicate-napi_schedule-call-i.patch new file mode 100644 index 00000000000..6acd4322c12 --- /dev/null +++ b/queue-5.10/revert-ibmvnic-remove-duplicate-napi_schedule-call-i.patch @@ -0,0 +1,46 @@ +From a795f695bbc648e27d56f99c38fc1afbe832b088 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 21:13:11 -0700 +Subject: Revert "ibmvnic: remove duplicate napi_schedule call in open + function" + +From: Dany Madden + +[ Upstream commit 2ca220f92878470c6ba03f9946e412323093cc94 ] + +This reverts commit 7c451f3ef676c805a4b77a743a01a5c21a250a73. + +When a vnic interface is taken down and then up, connectivity is not +restored. We bisected it to this commit. Reverting this commit until +we can fully investigate the issue/benefit of the change. + +Fixes: 7c451f3ef676 ("ibmvnic: remove duplicate napi_schedule call in open function") +Reported-by: Cristobal Forno +Reported-by: Abdul Haleem +Signed-off-by: Dany Madden +Signed-off-by: Sukadev Bhattiprolu +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/ibm/ibmvnic.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c +index 8cc444684491..765b38c8b252 100644 +--- a/drivers/net/ethernet/ibm/ibmvnic.c ++++ b/drivers/net/ethernet/ibm/ibmvnic.c +@@ -1166,6 +1166,11 @@ static int __ibmvnic_open(struct net_device *netdev) + + netif_tx_start_all_queues(netdev); + ++ if (prev_state == VNIC_CLOSED) { ++ for (i = 0; i < adapter->req_rx_queues; i++) ++ napi_schedule(&adapter->napi[i]); ++ } ++ + adapter->state = VNIC_OPEN; + return rc; + } +-- +2.30.2 + diff --git a/queue-5.10/rtw88-8822c-fix-lc-calibration-timing.patch b/queue-5.10/rtw88-8822c-fix-lc-calibration-timing.patch new file mode 100644 index 00000000000..441c59b266c --- /dev/null +++ b/queue-5.10/rtw88-8822c-fix-lc-calibration-timing.patch @@ -0,0 +1,82 @@ +From db8f61d31362a4d83fc2b12a617a7e47e3d4b3a6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Apr 2021 09:32:52 +0800 +Subject: rtw88: 8822c: fix lc calibration timing + +From: Po-Hao Huang + +[ Upstream commit 05684fd583e1acc34dddea283838fbfbed4904a0 ] + +Before this patch, we use value from 2 seconds ago to decide +whether we should do lc calibration. +Although this don't happen frequently, fix flow to the way it should be. + +Fixes: 7ae7784ec2a8 ("rtw88: 8822c: add LC calibration for RTL8822C") +Signed-off-by: Po-Hao Huang +Signed-off-by: Ping-Ke Shih +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210426013252.5665-3-pkshih@realtek.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/realtek/rtw88/rtw8822c.c | 22 ++++++++++--------- + 1 file changed, 12 insertions(+), 10 deletions(-) + +diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c +index b718f5d810be..79ad6232dce8 100644 +--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c ++++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c +@@ -3510,26 +3510,28 @@ static void rtw8822c_pwrtrack_set(struct rtw_dev *rtwdev, u8 rf_path) + } + } + +-static void rtw8822c_pwr_track_path(struct rtw_dev *rtwdev, +- struct rtw_swing_table *swing_table, +- u8 path) ++static void rtw8822c_pwr_track_stats(struct rtw_dev *rtwdev, u8 path) + { +- struct rtw_dm_info *dm_info = &rtwdev->dm_info; +- u8 thermal_value, delta; ++ u8 thermal_value; + + if (rtwdev->efuse.thermal_meter[path] == 0xff) + return; + + thermal_value = rtw_read_rf(rtwdev, path, RF_T_METER, 0x7e); +- + rtw_phy_pwrtrack_avg(rtwdev, thermal_value, path); ++} + +- delta = rtw_phy_pwrtrack_get_delta(rtwdev, path); ++static void rtw8822c_pwr_track_path(struct rtw_dev *rtwdev, ++ struct rtw_swing_table *swing_table, ++ u8 path) ++{ ++ struct rtw_dm_info *dm_info = &rtwdev->dm_info; ++ u8 delta; + ++ delta = rtw_phy_pwrtrack_get_delta(rtwdev, path); + dm_info->delta_power_index[path] = + rtw_phy_pwrtrack_get_pwridx(rtwdev, swing_table, path, path, + delta); +- + rtw8822c_pwrtrack_set(rtwdev, path); + } + +@@ -3540,12 +3542,12 @@ static void __rtw8822c_pwr_track(struct rtw_dev *rtwdev) + + rtw_phy_config_swing_table(rtwdev, &swing_table); + ++ for (i = 0; i < rtwdev->hal.rf_path_num; i++) ++ rtw8822c_pwr_track_stats(rtwdev, i); + if (rtw_phy_pwrtrack_need_lck(rtwdev)) + rtw8822c_do_lck(rtwdev); +- + for (i = 0; i < rtwdev->hal.rf_path_num; i++) + rtw8822c_pwr_track_path(rtwdev, &swing_table, i); +- + } + + static void rtw8822c_pwr_track(struct rtw_dev *rtwdev) +-- +2.30.2 + diff --git a/queue-5.10/s390-appldata-depends-on-proc_sysctl.patch b/queue-5.10/s390-appldata-depends-on-proc_sysctl.patch new file mode 100644 index 00000000000..df842cd3198 --- /dev/null +++ b/queue-5.10/s390-appldata-depends-on-proc_sysctl.patch @@ -0,0 +1,46 @@ +From ad0dec1da93f755ea4f22a54d74208822480ae70 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 27 May 2021 17:24:20 -0700 +Subject: s390: appldata depends on PROC_SYSCTL + +From: Randy Dunlap + +[ Upstream commit 5d3516b3647621d5a1180672ea9e0817fb718ada ] + +APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS. +Building with PROC_FS but not PROC_SYSCTL causes a build error, +since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c. + +arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler': +appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals' + +Fixes: c185b783b099 ("[S390] Remove config options.") +Signed-off-by: Randy Dunlap +Cc: Heiko Carstens +Cc: Vasily Gorbik +Cc: Christian Borntraeger +Cc: linux-s390@vger.kernel.org +Signed-off-by: Vasily Gorbik +Link: https://lore.kernel.org/r/20210528002420.17634-1-rdunlap@infradead.org +Signed-off-by: Vasily Gorbik +Signed-off-by: Sasha Levin +--- + arch/s390/Kconfig | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig +index 7105d44a335b..896b68e541b2 100644 +--- a/arch/s390/Kconfig ++++ b/arch/s390/Kconfig +@@ -858,7 +858,7 @@ config CMM_IUCV + config APPLDATA_BASE + def_bool n + prompt "Linux - VM Monitor Stream, base infrastructure" +- depends on PROC_FS ++ depends on PROC_SYSCTL + help + This provides a kernel interface for creating and updating z/VM APPLDATA + monitor records. The monitor records are updated at certain time +-- +2.30.2 + diff --git a/queue-5.10/s390-enable-have_ioremap_prot.patch b/queue-5.10/s390-enable-have_ioremap_prot.patch new file mode 100644 index 00000000000..cdbdaedaaa2 --- /dev/null +++ b/queue-5.10/s390-enable-have_ioremap_prot.patch @@ -0,0 +1,79 @@ +From ed7cd17fc559d4572a2b6cb7235d63b7a4a7f347 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Feb 2021 12:00:52 +0100 +Subject: s390: enable HAVE_IOREMAP_PROT + +From: Niklas Schnelle + +[ Upstream commit d460bb6c6417588dd8b0907d34f69b237918812a ] + +In commit b02002cc4c0f ("s390/pci: Implement ioremap_wc/prot() with +MIO") we implemented both ioremap_wc() and ioremap_prot() however until +now we had not set HAVE_IOREMAP_PROT in Kconfig, do so now. + +This also requires implementing pte_pgprot() as this is used in the +generic_access_phys() code enabled by CONFIG_HAVE_IOREMAP_PROT. As with +ioremap_wc() we need to take the MMIO Write Back bit index into account. + +Moreover since the pgprot value returned from pte_pgprot() is to be used +for mappings into kernel address space we must make sure that it uses +appropriate kernel page table protection bits. In particular a pgprot +value originally coming from userspace could have the _PAGE_PROTECT +bit set to enable fault based dirty bit accounting which would then make +the mapping inaccessible when used in kernel address space. + +Fixes: b02002cc4c0f ("s390/pci: Implement ioremap_wc/prot() with MIO") +Reviewed-by: Gerald Schaefer +Signed-off-by: Niklas Schnelle +Signed-off-by: Vasily Gorbik +Signed-off-by: Sasha Levin +--- + arch/s390/Kconfig | 1 + + arch/s390/include/asm/pgtable.h | 19 +++++++++++++++++++ + 2 files changed, 20 insertions(+) + +diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig +index dc5c3e6fd200..7105d44a335b 100644 +--- a/arch/s390/Kconfig ++++ b/arch/s390/Kconfig +@@ -154,6 +154,7 @@ config S390 + select HAVE_FUTEX_CMPXCHG if FUTEX + select HAVE_GCC_PLUGINS + select HAVE_GENERIC_VDSO ++ select HAVE_IOREMAP_PROT if PCI + select HAVE_IRQ_EXIT_ON_IRQ_STACK + select HAVE_KERNEL_BZIP2 + select HAVE_KERNEL_GZIP +diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h +index b5dbae78969b..2338345912a3 100644 +--- a/arch/s390/include/asm/pgtable.h ++++ b/arch/s390/include/asm/pgtable.h +@@ -864,6 +864,25 @@ static inline int pte_unused(pte_t pte) + return pte_val(pte) & _PAGE_UNUSED; + } + ++/* ++ * Extract the pgprot value from the given pte while at the same time making it ++ * usable for kernel address space mappings where fault driven dirty and ++ * young/old accounting is not supported, i.e _PAGE_PROTECT and _PAGE_INVALID ++ * must not be set. ++ */ ++static inline pgprot_t pte_pgprot(pte_t pte) ++{ ++ unsigned long pte_flags = pte_val(pte) & _PAGE_CHG_MASK; ++ ++ if (pte_write(pte)) ++ pte_flags |= pgprot_val(PAGE_KERNEL); ++ else ++ pte_flags |= pgprot_val(PAGE_KERNEL_RO); ++ pte_flags |= pte_val(pte) & mio_wb_bit_mask; ++ ++ return __pgprot(pte_flags); ++} ++ + /* + * pgd/pmd/pte modification functions + */ +-- +2.30.2 + diff --git a/queue-5.10/s390-irq-select-have_irq_exit_on_irq_stack.patch b/queue-5.10/s390-irq-select-have_irq_exit_on_irq_stack.patch new file mode 100644 index 00000000000..fdfee13fd62 --- /dev/null +++ b/queue-5.10/s390-irq-select-have_irq_exit_on_irq_stack.patch @@ -0,0 +1,34 @@ +From 750cf7f4bbe5c4faa48a0bde42e0cc9b901e3dcf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Dec 2020 22:30:09 +0100 +Subject: s390/irq: select HAVE_IRQ_EXIT_ON_IRQ_STACK + +From: Heiko Carstens + +[ Upstream commit 9ceed9988a8e6a1656ed2bdaa30501cf0f3dd925 ] + +irq_exit() is always called on async stack. Therefore select +HAVE_IRQ_EXIT_ON_IRQ_STACK and get a tiny optimization in +invoke_softirq(). + +Signed-off-by: Heiko Carstens +Signed-off-by: Sasha Levin +--- + arch/s390/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig +index 4a2a12be04c9..dc5c3e6fd200 100644 +--- a/arch/s390/Kconfig ++++ b/arch/s390/Kconfig +@@ -154,6 +154,7 @@ config S390 + select HAVE_FUTEX_CMPXCHG if FUTEX + select HAVE_GCC_PLUGINS + select HAVE_GENERIC_VDSO ++ select HAVE_IRQ_EXIT_ON_IRQ_STACK + select HAVE_KERNEL_BZIP2 + select HAVE_KERNEL_GZIP + select HAVE_KERNEL_LZ4 +-- +2.30.2 + diff --git a/queue-5.10/samples-bpf-fix-segmentation-fault-for-xdp_redirect-.patch b/queue-5.10/samples-bpf-fix-segmentation-fault-for-xdp_redirect-.patch new file mode 100644 index 00000000000..3c57f6484b4 --- /dev/null +++ b/queue-5.10/samples-bpf-fix-segmentation-fault-for-xdp_redirect-.patch @@ -0,0 +1,46 @@ +From 2af37a9258ab6da528a4d4e5c6403b0bf8bc9cda Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 12:23:24 +0800 +Subject: samples/bpf: Fix Segmentation fault for xdp_redirect command + +From: Wang Hai + +[ Upstream commit 85102ba58b4125ebad941d7555c3c248b23efd16 ] + +A Segmentation fault error is caused when the following command +is executed. + +$ sudo ./samples/bpf/xdp_redirect lo +Segmentation fault + +This command is missing a device as an argument, resulting +in out-of-bounds access from argv. + +If the number of devices for the xdp_redirect parameter is not 2, +we should report an error and exit. + +Fixes: 24251c264798 ("samples/bpf: add option for native and skb mode for redirect apps") +Signed-off-by: Wang Hai +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/20210616042324.314832-1-wanghai38@huawei.com +Signed-off-by: Sasha Levin +--- + samples/bpf/xdp_redirect_user.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c +index 9ca2bf457cda..1ddac4bcf447 100644 +--- a/samples/bpf/xdp_redirect_user.c ++++ b/samples/bpf/xdp_redirect_user.c +@@ -131,7 +131,7 @@ int main(int argc, char **argv) + if (!(xdp_flags & XDP_FLAGS_SKB_MODE)) + xdp_flags |= XDP_FLAGS_DRV_MODE; + +- if (optind == argc) { ++ if (optind + 2 != argc) { + printf("usage: %s _IN _OUT\n", argv[0]); + return 1; + } +-- +2.30.2 + diff --git a/queue-5.10/samples-bpf-fix-the-error-return-code-of-xdp_redirec.patch b/queue-5.10/samples-bpf-fix-the-error-return-code-of-xdp_redirec.patch new file mode 100644 index 00000000000..ab57ba63c9d --- /dev/null +++ b/queue-5.10/samples-bpf-fix-the-error-return-code-of-xdp_redirec.patch @@ -0,0 +1,37 @@ +From d74f9747b3aa817479d9408efecdcba1ad5eb7c9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 12:25:34 +0800 +Subject: samples/bpf: Fix the error return code of xdp_redirect's main() + +From: Wang Hai + +[ Upstream commit 7c6090ee2a7b3315410cfc83a94c3eb057407b25 ] + +Fix to return a negative error code from the error handling +case instead of 0, as done elsewhere in this function. + +If bpf_map_update_elem() failed, main() should return a negative error. + +Fixes: 832622e6bd18 ("xdp: sample program for new bpf_redirect helper") +Signed-off-by: Wang Hai +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/20210616042534.315097-1-wanghai38@huawei.com +Signed-off-by: Sasha Levin +--- + samples/bpf/xdp_redirect_user.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c +index 1ddac4bcf447..3c92adc2a7bd 100644 +--- a/samples/bpf/xdp_redirect_user.c ++++ b/samples/bpf/xdp_redirect_user.c +@@ -219,5 +219,5 @@ int main(int argc, char **argv) + poll_stats(2, ifindex_out); + + out: +- return 0; ++ return ret; + } +-- +2.30.2 + diff --git a/queue-5.10/sata_highbank-fix-deferred-probing.patch b/queue-5.10/sata_highbank-fix-deferred-probing.patch new file mode 100644 index 00000000000..9be5acc551c --- /dev/null +++ b/queue-5.10/sata_highbank-fix-deferred-probing.patch @@ -0,0 +1,46 @@ +From a6fe5cfd4e8d7bdb2a03cc328b9d1b4b5e04d910 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 14 Mar 2021 23:34:27 +0300 +Subject: sata_highbank: fix deferred probing + +From: Sergey Shtylyov + +[ Upstream commit 4a24efa16e7db02306fb5db84518bb0a7ada5a46 ] + +The driver overrides the error codes returned by platform_get_irq() to +-EINVAL, so if it returns -EPROBE_DEFER, the driver would fail the probe +permanently instead of the deferred probing. Switch to propagating the +error code upstream, still checking/overriding IRQ0 as libata regards it +as "no IRQ" (thus polling) anyway... + +Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") +Signed-off-by: Sergey Shtylyov +Link: https://lore.kernel.org/r/105b456d-1199-f6e9-ceb7-ffc5ba551d1a@omprussia.ru +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + drivers/ata/sata_highbank.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c +index 64b2ef15ec19..8440203e835e 100644 +--- a/drivers/ata/sata_highbank.c ++++ b/drivers/ata/sata_highbank.c +@@ -469,10 +469,12 @@ static int ahci_highbank_probe(struct platform_device *pdev) + } + + irq = platform_get_irq(pdev, 0); +- if (irq <= 0) { ++ if (irq < 0) { + dev_err(dev, "no irq\n"); +- return -EINVAL; ++ return irq; + } ++ if (!irq) ++ return -EINVAL; + + hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); + if (!hpriv) { +-- +2.30.2 + diff --git a/queue-5.10/sched-core-initialize-the-idle-task-with-preemption-.patch b/queue-5.10/sched-core-initialize-the-idle-task-with-preemption-.patch new file mode 100644 index 00000000000..87b24b9e867 --- /dev/null +++ b/queue-5.10/sched-core-initialize-the-idle-task-with-preemption-.patch @@ -0,0 +1,405 @@ +From 7d88c73ab95935af243c7bf32e47a36f07f7be3b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 10:46:36 +0100 +Subject: sched/core: Initialize the idle task with preemption disabled + +From: Valentin Schneider + +[ Upstream commit f1a0a376ca0c4ef1fc3d24e3e502acbb5b795674 ] + +As pointed out by commit + + de9b8f5dcbd9 ("sched: Fix crash trying to dequeue/enqueue the idle thread") + +init_idle() can and will be invoked more than once on the same idle +task. At boot time, it is invoked for the boot CPU thread by +sched_init(). Then smp_init() creates the threads for all the secondary +CPUs and invokes init_idle() on them. + +As the hotplug machinery brings the secondaries to life, it will issue +calls to idle_thread_get(), which itself invokes init_idle() yet again. +In this case it's invoked twice more per secondary: at _cpu_up(), and at +bringup_cpu(). + +Given smp_init() already initializes the idle tasks for all *possible* +CPUs, no further initialization should be required. Now, removing +init_idle() from idle_thread_get() exposes some interesting expectations +with regards to the idle task's preempt_count: the secondary startup always +issues a preempt_disable(), requiring some reset of the preempt count to 0 +between hot-unplug and hotplug, which is currently served by +idle_thread_get() -> idle_init(). + +Given the idle task is supposed to have preemption disabled once and never +see it re-enabled, it seems that what we actually want is to initialize its +preempt_count to PREEMPT_DISABLED and leave it there. Do that, and remove +init_idle() from idle_thread_get(). + +Secondary startups were patched via coccinelle: + + @begone@ + @@ + + -preempt_disable(); + ... + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); + +Signed-off-by: Valentin Schneider +Signed-off-by: Ingo Molnar +Acked-by: Peter Zijlstra +Link: https://lore.kernel.org/r/20210512094636.2958515-1-valentin.schneider@arm.com +Signed-off-by: Sasha Levin +--- + arch/alpha/kernel/smp.c | 1 - + arch/arc/kernel/smp.c | 1 - + arch/arm/kernel/smp.c | 1 - + arch/arm64/include/asm/preempt.h | 2 +- + arch/arm64/kernel/smp.c | 1 - + arch/csky/kernel/smp.c | 1 - + arch/ia64/kernel/smpboot.c | 1 - + arch/mips/kernel/smp.c | 1 - + arch/openrisc/kernel/smp.c | 2 -- + arch/parisc/kernel/smp.c | 1 - + arch/powerpc/kernel/smp.c | 1 - + arch/riscv/kernel/smpboot.c | 1 - + arch/s390/include/asm/preempt.h | 4 ++-- + arch/s390/kernel/smp.c | 1 - + arch/sh/kernel/smp.c | 2 -- + arch/sparc/kernel/smp_32.c | 1 - + arch/sparc/kernel/smp_64.c | 3 --- + arch/x86/include/asm/preempt.h | 2 +- + arch/x86/kernel/smpboot.c | 1 - + arch/xtensa/kernel/smp.c | 1 - + include/asm-generic/preempt.h | 2 +- + init/main.c | 6 +----- + kernel/fork.c | 2 +- + kernel/sched/core.c | 2 +- + kernel/smpboot.c | 1 - + 25 files changed, 8 insertions(+), 34 deletions(-) + +diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c +index f4dd9f3f3001..4b2575f936d4 100644 +--- a/arch/alpha/kernel/smp.c ++++ b/arch/alpha/kernel/smp.c +@@ -166,7 +166,6 @@ smp_callin(void) + DBGS(("smp_callin: commencing CPU %d current %p active_mm %p\n", + cpuid, current, current->active_mm)); + +- preempt_disable(); + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); + } + +diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c +index 52906d314537..db0e104d6835 100644 +--- a/arch/arc/kernel/smp.c ++++ b/arch/arc/kernel/smp.c +@@ -189,7 +189,6 @@ void start_kernel_secondary(void) + pr_info("## CPU%u LIVE ##: Executing Code...\n", cpu); + + local_irq_enable(); +- preempt_disable(); + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); + } + +diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c +index 48099c6e1e4a..8aa7fa949c23 100644 +--- a/arch/arm/kernel/smp.c ++++ b/arch/arm/kernel/smp.c +@@ -432,7 +432,6 @@ asmlinkage void secondary_start_kernel(void) + #endif + pr_debug("CPU%u: Booted secondary processor\n", cpu); + +- preempt_disable(); + trace_hardirqs_off(); + + /* +diff --git a/arch/arm64/include/asm/preempt.h b/arch/arm64/include/asm/preempt.h +index 80e946b2abee..e83f0982b99c 100644 +--- a/arch/arm64/include/asm/preempt.h ++++ b/arch/arm64/include/asm/preempt.h +@@ -23,7 +23,7 @@ static inline void preempt_count_set(u64 pc) + } while (0) + + #define init_idle_preempt_count(p, cpu) do { \ +- task_thread_info(p)->preempt_count = PREEMPT_ENABLED; \ ++ task_thread_info(p)->preempt_count = PREEMPT_DISABLED; \ + } while (0) + + static inline void set_preempt_need_resched(void) +diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c +index 18e9727d3f64..feee5a3cd128 100644 +--- a/arch/arm64/kernel/smp.c ++++ b/arch/arm64/kernel/smp.c +@@ -223,7 +223,6 @@ asmlinkage notrace void secondary_start_kernel(void) + init_gic_priority_masking(); + + rcu_cpu_starting(cpu); +- preempt_disable(); + trace_hardirqs_off(); + + /* +diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c +index 041d0de6a1b6..1a8d7eaf1ff7 100644 +--- a/arch/csky/kernel/smp.c ++++ b/arch/csky/kernel/smp.c +@@ -282,7 +282,6 @@ void csky_start_secondary(void) + pr_info("CPU%u Online: %s...\n", cpu, __func__); + + local_irq_enable(); +- preempt_disable(); + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); + } + +diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c +index 093040f7e626..0cad990385c0 100644 +--- a/arch/ia64/kernel/smpboot.c ++++ b/arch/ia64/kernel/smpboot.c +@@ -440,7 +440,6 @@ start_secondary (void *unused) + #endif + efi_map_pal_code(); + cpu_init(); +- preempt_disable(); + smp_callin(); + + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); +diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c +index 48d84d5fcc36..ff25926c5458 100644 +--- a/arch/mips/kernel/smp.c ++++ b/arch/mips/kernel/smp.c +@@ -348,7 +348,6 @@ asmlinkage void start_secondary(void) + */ + + calibrate_delay(); +- preempt_disable(); + cpu = smp_processor_id(); + cpu_data[cpu].udelay_val = loops_per_jiffy; + +diff --git a/arch/openrisc/kernel/smp.c b/arch/openrisc/kernel/smp.c +index 29c82ef2e207..e4dad76066ae 100644 +--- a/arch/openrisc/kernel/smp.c ++++ b/arch/openrisc/kernel/smp.c +@@ -134,8 +134,6 @@ asmlinkage __init void secondary_start_kernel(void) + set_cpu_online(cpu, true); + + local_irq_enable(); +- +- preempt_disable(); + /* + * OK, it's off to the idle thread for us + */ +diff --git a/arch/parisc/kernel/smp.c b/arch/parisc/kernel/smp.c +index 10227f667c8a..1405b603b91b 100644 +--- a/arch/parisc/kernel/smp.c ++++ b/arch/parisc/kernel/smp.c +@@ -302,7 +302,6 @@ void __init smp_callin(unsigned long pdce_proc) + #endif + + smp_cpu_init(slave_id); +- preempt_disable(); + + flush_cache_all_local(); /* start with known state */ + flush_tlb_all_local(NULL); +diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c +index db7ac77bea3a..0760230be56f 100644 +--- a/arch/powerpc/kernel/smp.c ++++ b/arch/powerpc/kernel/smp.c +@@ -1426,7 +1426,6 @@ void start_secondary(void *unused) + smp_store_cpu_info(cpu); + set_dec(tb_ticks_per_jiffy); + rcu_cpu_starting(cpu); +- preempt_disable(); + cpu_callin_map[cpu] = 1; + + if (smp_ops->setup_cpu) +diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c +index 96167d55ed98..0b04e0eae3ab 100644 +--- a/arch/riscv/kernel/smpboot.c ++++ b/arch/riscv/kernel/smpboot.c +@@ -166,7 +166,6 @@ asmlinkage __visible void smp_callin(void) + * Disable preemption before enabling interrupts, so we don't try to + * schedule a CPU that hasn't actually started yet. + */ +- preempt_disable(); + local_irq_enable(); + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); + } +diff --git a/arch/s390/include/asm/preempt.h b/arch/s390/include/asm/preempt.h +index 6ede29907fbf..e38480eb58fa 100644 +--- a/arch/s390/include/asm/preempt.h ++++ b/arch/s390/include/asm/preempt.h +@@ -32,7 +32,7 @@ static inline void preempt_count_set(int pc) + #define init_task_preempt_count(p) do { } while (0) + + #define init_idle_preempt_count(p, cpu) do { \ +- S390_lowcore.preempt_count = PREEMPT_ENABLED; \ ++ S390_lowcore.preempt_count = PREEMPT_DISABLED; \ + } while (0) + + static inline void set_preempt_need_resched(void) +@@ -91,7 +91,7 @@ static inline void preempt_count_set(int pc) + #define init_task_preempt_count(p) do { } while (0) + + #define init_idle_preempt_count(p, cpu) do { \ +- S390_lowcore.preempt_count = PREEMPT_ENABLED; \ ++ S390_lowcore.preempt_count = PREEMPT_DISABLED; \ + } while (0) + + static inline void set_preempt_need_resched(void) +diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c +index 791bc373418b..7db5460553b7 100644 +--- a/arch/s390/kernel/smp.c ++++ b/arch/s390/kernel/smp.c +@@ -863,7 +863,6 @@ static void smp_init_secondary(void) + set_cpu_flag(CIF_ASCE_SECONDARY); + cpu_init(); + rcu_cpu_starting(cpu); +- preempt_disable(); + init_cpu_timer(); + vtime_init(); + pfault_init(); +diff --git a/arch/sh/kernel/smp.c b/arch/sh/kernel/smp.c +index 372acdc9033e..65924d9ec245 100644 +--- a/arch/sh/kernel/smp.c ++++ b/arch/sh/kernel/smp.c +@@ -186,8 +186,6 @@ asmlinkage void start_secondary(void) + + per_cpu_trap_init(); + +- preempt_disable(); +- + notify_cpu_starting(cpu); + + local_irq_enable(); +diff --git a/arch/sparc/kernel/smp_32.c b/arch/sparc/kernel/smp_32.c +index 50c127ab46d5..22b148e5a5f8 100644 +--- a/arch/sparc/kernel/smp_32.c ++++ b/arch/sparc/kernel/smp_32.c +@@ -348,7 +348,6 @@ static void sparc_start_secondary(void *arg) + */ + arch_cpu_pre_starting(arg); + +- preempt_disable(); + cpu = smp_processor_id(); + + notify_cpu_starting(cpu); +diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c +index e38d8bf454e8..ae5faa1d989d 100644 +--- a/arch/sparc/kernel/smp_64.c ++++ b/arch/sparc/kernel/smp_64.c +@@ -138,9 +138,6 @@ void smp_callin(void) + + set_cpu_online(cpuid, true); + +- /* idle thread is expected to have preempt disabled */ +- preempt_disable(); +- + local_irq_enable(); + + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); +diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h +index 69485ca13665..a334dd0d7c42 100644 +--- a/arch/x86/include/asm/preempt.h ++++ b/arch/x86/include/asm/preempt.h +@@ -43,7 +43,7 @@ static __always_inline void preempt_count_set(int pc) + #define init_task_preempt_count(p) do { } while (0) + + #define init_idle_preempt_count(p, cpu) do { \ +- per_cpu(__preempt_count, (cpu)) = PREEMPT_ENABLED; \ ++ per_cpu(__preempt_count, (cpu)) = PREEMPT_DISABLED; \ + } while (0) + + /* +diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c +index 582387fc939f..8baff500914e 100644 +--- a/arch/x86/kernel/smpboot.c ++++ b/arch/x86/kernel/smpboot.c +@@ -230,7 +230,6 @@ static void notrace start_secondary(void *unused) + cpu_init_exception_handling(); + cpu_init(); + x86_cpuinit.early_percpu_clock_init(); +- preempt_disable(); + smp_callin(); + + enable_start_cpu0 = 0; +diff --git a/arch/xtensa/kernel/smp.c b/arch/xtensa/kernel/smp.c +index cd85a7a2722b..1254da07ead1 100644 +--- a/arch/xtensa/kernel/smp.c ++++ b/arch/xtensa/kernel/smp.c +@@ -145,7 +145,6 @@ void secondary_start_kernel(void) + cpumask_set_cpu(cpu, mm_cpumask(mm)); + enter_lazy_tlb(mm, current); + +- preempt_disable(); + trace_hardirqs_off(); + + calibrate_delay(); +diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h +index d683f5e6d791..b4d43a4af5f7 100644 +--- a/include/asm-generic/preempt.h ++++ b/include/asm-generic/preempt.h +@@ -29,7 +29,7 @@ static __always_inline void preempt_count_set(int pc) + } while (0) + + #define init_idle_preempt_count(p, cpu) do { \ +- task_thread_info(p)->preempt_count = PREEMPT_ENABLED; \ ++ task_thread_info(p)->preempt_count = PREEMPT_DISABLED; \ + } while (0) + + static __always_inline void set_preempt_need_resched(void) +diff --git a/init/main.c b/init/main.c +index b4449544390c..dd26a42e80a8 100644 +--- a/init/main.c ++++ b/init/main.c +@@ -914,11 +914,7 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) + * time - but meanwhile we still have a functioning scheduler. + */ + sched_init(); +- /* +- * Disable preemption - early bootup scheduling is extremely +- * fragile until we cpu_idle() for the first time. +- */ +- preempt_disable(); ++ + if (WARN(!irqs_disabled(), + "Interrupts were enabled *very* early, fixing it\n")) + local_irq_disable(); +diff --git a/kernel/fork.c b/kernel/fork.c +index 281addb694df..096945ef49ad 100644 +--- a/kernel/fork.c ++++ b/kernel/fork.c +@@ -2392,7 +2392,7 @@ static inline void init_idle_pids(struct task_struct *idle) + } + } + +-struct task_struct *fork_idle(int cpu) ++struct task_struct * __init fork_idle(int cpu) + { + struct task_struct *task; + struct kernel_clone_args args = { +diff --git a/kernel/sched/core.c b/kernel/sched/core.c +index 57b236251884..bd3fa14fda1f 100644 +--- a/kernel/sched/core.c ++++ b/kernel/sched/core.c +@@ -6512,7 +6512,7 @@ void show_state_filter(unsigned long state_filter) + * NOTE: this function does not set the idle thread's NEED_RESCHED + * flag, to make booting more robust. + */ +-void init_idle(struct task_struct *idle, int cpu) ++void __init init_idle(struct task_struct *idle, int cpu) + { + struct rq *rq = cpu_rq(cpu); + unsigned long flags; +diff --git a/kernel/smpboot.c b/kernel/smpboot.c +index f25208e8df83..e4163042c4d6 100644 +--- a/kernel/smpboot.c ++++ b/kernel/smpboot.c +@@ -33,7 +33,6 @@ struct task_struct *idle_thread_get(unsigned int cpu) + + if (!tsk) + return ERR_PTR(-ENOMEM); +- init_idle(tsk, cpu); + return tsk; + } + +-- +2.30.2 + diff --git a/queue-5.10/sched-fair-fix-ascii-art-by-relpacing-tabs.patch b/queue-5.10/sched-fair-fix-ascii-art-by-relpacing-tabs.patch new file mode 100644 index 00000000000..ce8e6b510f2 --- /dev/null +++ b/queue-5.10/sched-fair-fix-ascii-art-by-relpacing-tabs.patch @@ -0,0 +1,65 @@ +From 18a3f90587a83be57bcc43ff58f3bd3b9d174ae1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 18 May 2021 14:52:02 +0200 +Subject: sched/fair: Fix ascii art by relpacing tabs + +From: Odin Ugedal + +[ Upstream commit 08f7c2f4d0e9f4283f5796b8168044c034a1bfcb ] + +When using something other than 8 spaces per tab, this ascii art +makes not sense, and the reader might end up wondering what this +advanced equation "is". + +Signed-off-by: Odin Ugedal +Signed-off-by: Peter Zijlstra (Intel) +Acked-by: Vincent Guittot +Link: https://lkml.kernel.org/r/20210518125202.78658-4-odin@uged.al +Signed-off-by: Sasha Levin +--- + kernel/sched/fair.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c +index d6e1c90de570..3d92de7909bf 100644 +--- a/kernel/sched/fair.c ++++ b/kernel/sched/fair.c +@@ -3141,7 +3141,7 @@ void reweight_task(struct task_struct *p, int prio) + * + * tg->weight * grq->load.weight + * ge->load.weight = ----------------------------- (1) +- * \Sum grq->load.weight ++ * \Sum grq->load.weight + * + * Now, because computing that sum is prohibitively expensive to compute (been + * there, done that) we approximate it with this average stuff. The average +@@ -3155,7 +3155,7 @@ void reweight_task(struct task_struct *p, int prio) + * + * tg->weight * grq->avg.load_avg + * ge->load.weight = ------------------------------ (3) +- * tg->load_avg ++ * tg->load_avg + * + * Where: tg->load_avg ~= \Sum grq->avg.load_avg + * +@@ -3171,7 +3171,7 @@ void reweight_task(struct task_struct *p, int prio) + * + * tg->weight * grq->load.weight + * ge->load.weight = ----------------------------- = tg->weight (4) +- * grp->load.weight ++ * grp->load.weight + * + * That is, the sum collapses because all other CPUs are idle; the UP scenario. + * +@@ -3190,7 +3190,7 @@ void reweight_task(struct task_struct *p, int prio) + * + * tg->weight * grq->load.weight + * ge->load.weight = ----------------------------- (6) +- * tg_load_avg' ++ * tg_load_avg' + * + * Where: + * +-- +2.30.2 + diff --git a/queue-5.10/sched-rt-fix-deadline-utilization-tracking-during-po.patch b/queue-5.10/sched-rt-fix-deadline-utilization-tracking-during-po.patch new file mode 100644 index 00000000000..f13e006ca9d --- /dev/null +++ b/queue-5.10/sched-rt-fix-deadline-utilization-tracking-during-po.patch @@ -0,0 +1,53 @@ +From 10d626cd70e9e51b7fd154d73fb9cf8633455f23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 11:37:52 +0100 +Subject: sched/rt: Fix Deadline utilization tracking during policy change + +From: Vincent Donnefort + +[ Upstream commit d7d607096ae6d378b4e92d49946d22739c047d4c ] + +DL keeps track of the utilization on a per-rq basis with the structure +avg_dl. This utilization is updated during task_tick_dl(), +put_prev_task_dl() and set_next_task_dl(). However, when the current +running task changes its policy, set_next_task_dl() which would usually +take care of updating the utilization when the rq starts running DL +tasks, will not see a such change, leaving the avg_dl structure outdated. +When that very same task will be dequeued later, put_prev_task_dl() will +then update the utilization, based on a wrong last_update_time, leading to +a huge spike in the DL utilization signal. + +The signal would eventually recover from this issue after few ms. Even +if no DL tasks are run, avg_dl is also updated in +__update_blocked_others(). But as the CPU capacity depends partly on the +avg_dl, this issue has nonetheless a significant impact on the scheduler. + +Fix this issue by ensuring a load update when a running task changes +its policy to DL. + +Fixes: 3727e0e ("sched/dl: Add dl_rq utilization tracking") +Signed-off-by: Vincent Donnefort +Signed-off-by: Peter Zijlstra (Intel) +Reviewed-by: Vincent Guittot +Link: https://lore.kernel.org/r/1624271872-211872-3-git-send-email-vincent.donnefort@arm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/deadline.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c +index 8d06d1f4e2f7..6b98c1fe6e7f 100644 +--- a/kernel/sched/deadline.c ++++ b/kernel/sched/deadline.c +@@ -2470,6 +2470,8 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) + check_preempt_curr_dl(rq, p, 0); + else + resched_curr(rq); ++ } else { ++ update_dl_rq_load_avg(rq_clock_pelt(rq), rq, 0); + } + } + +-- +2.30.2 + diff --git a/queue-5.10/sched-rt-fix-rt-utilization-tracking-during-policy-c.patch b/queue-5.10/sched-rt-fix-rt-utilization-tracking-during-policy-c.patch new file mode 100644 index 00000000000..4251348676a --- /dev/null +++ b/queue-5.10/sched-rt-fix-rt-utilization-tracking-during-policy-c.patch @@ -0,0 +1,70 @@ +From f405c3ed226ee72b59b58b7285472fc17d83ecaf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Jun 2021 11:37:51 +0100 +Subject: sched/rt: Fix RT utilization tracking during policy change + +From: Vincent Donnefort + +[ Upstream commit fecfcbc288e9f4923f40fd23ca78a6acdc7fdf6c ] + +RT keeps track of the utilization on a per-rq basis with the structure +avg_rt. This utilization is updated during task_tick_rt(), +put_prev_task_rt() and set_next_task_rt(). However, when the current +running task changes its policy, set_next_task_rt() which would usually +take care of updating the utilization when the rq starts running RT tasks, +will not see a such change, leaving the avg_rt structure outdated. When +that very same task will be dequeued later, put_prev_task_rt() will then +update the utilization, based on a wrong last_update_time, leading to a +huge spike in the RT utilization signal. + +The signal would eventually recover from this issue after few ms. Even if +no RT tasks are run, avg_rt is also updated in __update_blocked_others(). +But as the CPU capacity depends partly on the avg_rt, this issue has +nonetheless a significant impact on the scheduler. + +Fix this issue by ensuring a load update when a running task changes +its policy to RT. + +Fixes: 371bf427 ("sched/rt: Add rt_rq utilization tracking") +Signed-off-by: Vincent Donnefort +Signed-off-by: Peter Zijlstra (Intel) +Reviewed-by: Vincent Guittot +Link: https://lore.kernel.org/r/1624271872-211872-2-git-send-email-vincent.donnefort@arm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/rt.c | 17 ++++++++++++----- + 1 file changed, 12 insertions(+), 5 deletions(-) + +diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c +index 49ec096a8aa1..b5cf418e2e3f 100644 +--- a/kernel/sched/rt.c ++++ b/kernel/sched/rt.c +@@ -2291,13 +2291,20 @@ void __init init_sched_rt_class(void) + static void switched_to_rt(struct rq *rq, struct task_struct *p) + { + /* +- * If we are already running, then there's nothing +- * that needs to be done. But if we are not running +- * we may need to preempt the current running task. +- * If that current running task is also an RT task ++ * If we are running, update the avg_rt tracking, as the running time ++ * will now on be accounted into the latter. ++ */ ++ if (task_current(rq, p)) { ++ update_rt_rq_load_avg(rq_clock_pelt(rq), rq, 0); ++ return; ++ } ++ ++ /* ++ * If we are not running we may need to preempt the current ++ * running task. If that current running task is also an RT task + * then see if we can move to another run queue. + */ +- if (task_on_rq_queued(p) && rq->curr != p) { ++ if (task_on_rq_queued(p)) { + #ifdef CONFIG_SMP + if (p->nr_cpus_allowed > 1 && rq->rt.overloaded) + rt_queue_push_tasks(rq); +-- +2.30.2 + diff --git a/queue-5.10/sched-uclamp-fix-locking-around-cpu_util_update_eff.patch b/queue-5.10/sched-uclamp-fix-locking-around-cpu_util_update_eff.patch new file mode 100644 index 00000000000..c1ee74932f7 --- /dev/null +++ b/queue-5.10/sched-uclamp-fix-locking-around-cpu_util_update_eff.patch @@ -0,0 +1,61 @@ +From 781f1a70c27d436fcc93857ee3b8d5de8a761f5a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 15:50:32 +0100 +Subject: sched/uclamp: Fix locking around cpu_util_update_eff() + +From: Qais Yousef + +[ Upstream commit 93b73858701fd01de26a4a874eb95f9b7156fd4b ] + +cpu_cgroup_css_online() calls cpu_util_update_eff() without holding the +uclamp_mutex or rcu_read_lock() like other call sites, which is +a mistake. + +The uclamp_mutex is required to protect against concurrent reads and +writes that could update the cgroup hierarchy. + +The rcu_read_lock() is required to traverse the cgroup data structures +in cpu_util_update_eff(). + +Surround the caller with the required locks and add some asserts to +better document the dependency in cpu_util_update_eff(). + +Fixes: 7226017ad37a ("sched/uclamp: Fix a bug in propagating uclamp value in new cgroups") +Reported-by: Quentin Perret +Signed-off-by: Qais Yousef +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lkml.kernel.org/r/20210510145032.1934078-3-qais.yousef@arm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/core.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/kernel/sched/core.c b/kernel/sched/core.c +index c561c3b993b5..d4bbead59ad2 100644 +--- a/kernel/sched/core.c ++++ b/kernel/sched/core.c +@@ -7620,7 +7620,11 @@ static int cpu_cgroup_css_online(struct cgroup_subsys_state *css) + + #ifdef CONFIG_UCLAMP_TASK_GROUP + /* Propagate the effective uclamp value for the new group */ ++ mutex_lock(&uclamp_mutex); ++ rcu_read_lock(); + cpu_util_update_eff(css); ++ rcu_read_unlock(); ++ mutex_unlock(&uclamp_mutex); + #endif + + return 0; +@@ -7710,6 +7714,9 @@ static void cpu_util_update_eff(struct cgroup_subsys_state *css) + enum uclamp_id clamp_id; + unsigned int clamps; + ++ lockdep_assert_held(&uclamp_mutex); ++ SCHED_WARN_ON(!rcu_read_lock_held()); ++ + css_for_each_descendant_pre(css, top_css) { + uc_parent = css_tg(css)->parent + ? css_tg(css)->parent->uclamp : NULL; +-- +2.30.2 + diff --git a/queue-5.10/sched-uclamp-fix-uclamp_tg_restrict.patch b/queue-5.10/sched-uclamp-fix-uclamp_tg_restrict.patch new file mode 100644 index 00000000000..84338283953 --- /dev/null +++ b/queue-5.10/sched-uclamp-fix-uclamp_tg_restrict.patch @@ -0,0 +1,188 @@ +From 34f26c348eac0dbe720407e37a331c6af542c1ef Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 17 Jun 2021 17:51:55 +0100 +Subject: sched/uclamp: Fix uclamp_tg_restrict() + +From: Qais Yousef + +[ Upstream commit 0213b7083e81f4acd69db32cb72eb4e5f220329a ] + +Now cpu.uclamp.min acts as a protection, we need to make sure that the +uclamp request of the task is within the allowed range of the cgroup, +that is it is clamp()'ed correctly by tg->uclamp[UCLAMP_MIN] and +tg->uclamp[UCLAMP_MAX]. + +As reported by Xuewen [1] we can have some corner cases where there's +inversion between uclamp requested by task (p) and the uclamp values of +the taskgroup it's attached to (tg). Following table demonstrates +2 corner cases: + + | p | tg | effective + -----------+-----+------+----------- + CASE 1 + -----------+-----+------+----------- + uclamp_min | 60% | 0% | 60% + -----------+-----+------+----------- + uclamp_max | 80% | 50% | 50% + -----------+-----+------+----------- + CASE 2 + -----------+-----+------+----------- + uclamp_min | 0% | 30% | 30% + -----------+-----+------+----------- + uclamp_max | 20% | 50% | 20% + -----------+-----+------+----------- + +With this fix we get: + + | p | tg | effective + -----------+-----+------+----------- + CASE 1 + -----------+-----+------+----------- + uclamp_min | 60% | 0% | 50% + -----------+-----+------+----------- + uclamp_max | 80% | 50% | 50% + -----------+-----+------+----------- + CASE 2 + -----------+-----+------+----------- + uclamp_min | 0% | 30% | 30% + -----------+-----+------+----------- + uclamp_max | 20% | 50% | 30% + -----------+-----+------+----------- + +Additionally uclamp_update_active_tasks() must now unconditionally +update both UCLAMP_MIN/MAX because changing the tg's UCLAMP_MAX for +instance could have an impact on the effective UCLAMP_MIN of the tasks. + + | p | tg | effective + -----------+-----+------+----------- + old + -----------+-----+------+----------- + uclamp_min | 60% | 0% | 50% + -----------+-----+------+----------- + uclamp_max | 80% | 50% | 50% + -----------+-----+------+----------- + *new* + -----------+-----+------+----------- + uclamp_min | 60% | 0% | *60%* + -----------+-----+------+----------- + uclamp_max | 80% |*70%* | *70%* + -----------+-----+------+----------- + +[1] https://lore.kernel.org/lkml/CAB8ipk_a6VFNjiEnHRHkUMBKbA+qzPQvhtNjJ_YNzQhqV_o8Zw@mail.gmail.com/ + +Fixes: 0c18f2ecfcc2 ("sched/uclamp: Fix wrong implementation of cpu.uclamp.min") +Reported-by: Xuewen Yan +Signed-off-by: Qais Yousef +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lkml.kernel.org/r/20210617165155.3774110-1-qais.yousef@arm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/core.c | 49 +++++++++++++++++---------------------------- + 1 file changed, 18 insertions(+), 31 deletions(-) + +diff --git a/kernel/sched/core.c b/kernel/sched/core.c +index d4bbead59ad2..679562d2f55d 100644 +--- a/kernel/sched/core.c ++++ b/kernel/sched/core.c +@@ -1063,8 +1063,10 @@ static void uclamp_sync_util_min_rt_default(void) + static inline struct uclamp_se + uclamp_tg_restrict(struct task_struct *p, enum uclamp_id clamp_id) + { ++ /* Copy by value as we could modify it */ + struct uclamp_se uc_req = p->uclamp_req[clamp_id]; + #ifdef CONFIG_UCLAMP_TASK_GROUP ++ unsigned int tg_min, tg_max, value; + + /* + * Tasks in autogroups or root task group will be +@@ -1075,23 +1077,11 @@ uclamp_tg_restrict(struct task_struct *p, enum uclamp_id clamp_id) + if (task_group(p) == &root_task_group) + return uc_req; + +- switch (clamp_id) { +- case UCLAMP_MIN: { +- struct uclamp_se uc_min = task_group(p)->uclamp[clamp_id]; +- if (uc_req.value < uc_min.value) +- return uc_min; +- break; +- } +- case UCLAMP_MAX: { +- struct uclamp_se uc_max = task_group(p)->uclamp[clamp_id]; +- if (uc_req.value > uc_max.value) +- return uc_max; +- break; +- } +- default: +- WARN_ON_ONCE(1); +- break; +- } ++ tg_min = task_group(p)->uclamp[UCLAMP_MIN].value; ++ tg_max = task_group(p)->uclamp[UCLAMP_MAX].value; ++ value = uc_req.value; ++ value = clamp(value, tg_min, tg_max); ++ uclamp_se_set(&uc_req, value, false); + #endif + + return uc_req; +@@ -1290,8 +1280,9 @@ static inline void uclamp_rq_dec(struct rq *rq, struct task_struct *p) + } + + static inline void +-uclamp_update_active(struct task_struct *p, enum uclamp_id clamp_id) ++uclamp_update_active(struct task_struct *p) + { ++ enum uclamp_id clamp_id; + struct rq_flags rf; + struct rq *rq; + +@@ -1311,9 +1302,11 @@ uclamp_update_active(struct task_struct *p, enum uclamp_id clamp_id) + * affecting a valid clamp bucket, the next time it's enqueued, + * it will already see the updated clamp bucket value. + */ +- if (p->uclamp[clamp_id].active) { +- uclamp_rq_dec_id(rq, p, clamp_id); +- uclamp_rq_inc_id(rq, p, clamp_id); ++ for_each_clamp_id(clamp_id) { ++ if (p->uclamp[clamp_id].active) { ++ uclamp_rq_dec_id(rq, p, clamp_id); ++ uclamp_rq_inc_id(rq, p, clamp_id); ++ } + } + + task_rq_unlock(rq, p, &rf); +@@ -1321,20 +1314,14 @@ uclamp_update_active(struct task_struct *p, enum uclamp_id clamp_id) + + #ifdef CONFIG_UCLAMP_TASK_GROUP + static inline void +-uclamp_update_active_tasks(struct cgroup_subsys_state *css, +- unsigned int clamps) ++uclamp_update_active_tasks(struct cgroup_subsys_state *css) + { +- enum uclamp_id clamp_id; + struct css_task_iter it; + struct task_struct *p; + + css_task_iter_start(css, 0, &it); +- while ((p = css_task_iter_next(&it))) { +- for_each_clamp_id(clamp_id) { +- if ((0x1 << clamp_id) & clamps) +- uclamp_update_active(p, clamp_id); +- } +- } ++ while ((p = css_task_iter_next(&it))) ++ uclamp_update_active(p); + css_task_iter_end(&it); + } + +@@ -7749,7 +7736,7 @@ static void cpu_util_update_eff(struct cgroup_subsys_state *css) + } + + /* Immediately update descendants RUNNABLE tasks */ +- uclamp_update_active_tasks(css, clamps); ++ uclamp_update_active_tasks(css); + } + } + +-- +2.30.2 + diff --git a/queue-5.10/sched-uclamp-fix-wrong-implementation-of-cpu.uclamp..patch b/queue-5.10/sched-uclamp-fix-wrong-implementation-of-cpu.uclamp..patch new file mode 100644 index 00000000000..2264f86d1e1 --- /dev/null +++ b/queue-5.10/sched-uclamp-fix-wrong-implementation-of-cpu.uclamp..patch @@ -0,0 +1,116 @@ +From 45a4df3e11f6091c34c14926d2280bedda4cd714 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 15:50:31 +0100 +Subject: sched/uclamp: Fix wrong implementation of cpu.uclamp.min + +From: Qais Yousef + +[ Upstream commit 0c18f2ecfcc274a4bcc1d122f79ebd4001c3b445 ] + +cpu.uclamp.min is a protection as described in cgroup-v2 Resource +Distribution Model + + Documentation/admin-guide/cgroup-v2.rst + +which means we try our best to preserve the minimum performance point of +tasks in this group. See full description of cpu.uclamp.min in the +cgroup-v2.rst. + +But the current implementation makes it a limit, which is not what was +intended. + +For example: + + tg->cpu.uclamp.min = 20% + + p0->uclamp[UCLAMP_MIN] = 0 + p1->uclamp[UCLAMP_MIN] = 50% + + Previous Behavior (limit): + + p0->effective_uclamp = 0 + p1->effective_uclamp = 20% + + New Behavior (Protection): + + p0->effective_uclamp = 20% + p1->effective_uclamp = 50% + +Which is inline with how protections should work. + +With this change the cgroup and per-task behaviors are the same, as +expected. + +Additionally, we remove the confusing relationship between cgroup and +!user_defined flag. + +We don't want for example RT tasks that are boosted by default to max to +change their boost value when they attach to a cgroup. If a cgroup wants +to limit the max performance point of tasks attached to it, then +cpu.uclamp.max must be set accordingly. + +Or if they want to set different boost value based on cgroup, then +sysctl_sched_util_clamp_min_rt_default must be used to NOT boost to max +and set the right cpu.uclamp.min for each group to let the RT tasks +obtain the desired boost value when attached to that group. + +As it stands the dependency on !user_defined flag adds an extra layer of +complexity that is not required now cpu.uclamp.min behaves properly as +a protection. + +The propagation model of effective cpu.uclamp.min in child cgroups as +implemented by cpu_util_update_eff() is still correct. The parent +protection sets an upper limit of what the child cgroups will +effectively get. + +Fixes: 3eac870a3247 (sched/uclamp: Use TG's clamps to restrict TASK's clamps) +Signed-off-by: Qais Yousef +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lkml.kernel.org/r/20210510145032.1934078-2-qais.yousef@arm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/core.c | 21 +++++++++++++++++---- + 1 file changed, 17 insertions(+), 4 deletions(-) + +diff --git a/kernel/sched/core.c b/kernel/sched/core.c +index bd3fa14fda1f..c561c3b993b5 100644 +--- a/kernel/sched/core.c ++++ b/kernel/sched/core.c +@@ -1065,7 +1065,6 @@ uclamp_tg_restrict(struct task_struct *p, enum uclamp_id clamp_id) + { + struct uclamp_se uc_req = p->uclamp_req[clamp_id]; + #ifdef CONFIG_UCLAMP_TASK_GROUP +- struct uclamp_se uc_max; + + /* + * Tasks in autogroups or root task group will be +@@ -1076,9 +1075,23 @@ uclamp_tg_restrict(struct task_struct *p, enum uclamp_id clamp_id) + if (task_group(p) == &root_task_group) + return uc_req; + +- uc_max = task_group(p)->uclamp[clamp_id]; +- if (uc_req.value > uc_max.value || !uc_req.user_defined) +- return uc_max; ++ switch (clamp_id) { ++ case UCLAMP_MIN: { ++ struct uclamp_se uc_min = task_group(p)->uclamp[clamp_id]; ++ if (uc_req.value < uc_min.value) ++ return uc_min; ++ break; ++ } ++ case UCLAMP_MAX: { ++ struct uclamp_se uc_max = task_group(p)->uclamp[clamp_id]; ++ if (uc_req.value > uc_max.value) ++ return uc_max; ++ break; ++ } ++ default: ++ WARN_ON_ONCE(1); ++ break; ++ } + #endif + + return uc_req; +-- +2.30.2 + diff --git a/queue-5.10/scsi-flashpoint-rename-si_flags-field.patch b/queue-5.10/scsi-flashpoint-rename-si_flags-field.patch new file mode 100644 index 00000000000..9fba2efe3f8 --- /dev/null +++ b/queue-5.10/scsi-flashpoint-rename-si_flags-field.patch @@ -0,0 +1,163 @@ +From 729d609c21f4be450c4ceb6363f7d39d2d67410a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 29 May 2021 16:48:57 -0700 +Subject: scsi: FlashPoint: Rename si_flags field + +From: Randy Dunlap + +[ Upstream commit 4d431153e751caa93f3b7e6f6313446974e92253 ] + +The BusLogic driver has build errors on ia64 due to a name collision (in +the #included FlashPoint.c file). Rename the struct field in struct +sccb_mgr_info from si_flags to si_mflags (manager flags) to mend the build. + +This is the first problem. There are 50+ others after this one: + +In file included from ../include/uapi/linux/signal.h:6, + from ../include/linux/signal_types.h:10, + from ../include/linux/sched.h:29, + from ../include/linux/hardirq.h:9, + from ../include/linux/interrupt.h:11, + from ../drivers/scsi/BusLogic.c:27: +../arch/ia64/include/uapi/asm/siginfo.h:15:27: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token + 15 | #define si_flags _sifields._sigfault._flags + | ^ +../drivers/scsi/FlashPoint.c:43:6: note: in expansion of macro 'si_flags' + 43 | u16 si_flags; + | ^~~~~~~~ +In file included from ../drivers/scsi/BusLogic.c:51: +../drivers/scsi/FlashPoint.c: In function 'FlashPoint_ProbeHostAdapter': +../drivers/scsi/FlashPoint.c:1076:11: error: 'struct sccb_mgr_info' has no member named '_sifields' + 1076 | pCardInfo->si_flags = 0x0000; + | ^~ +../drivers/scsi/FlashPoint.c:1079:12: error: 'struct sccb_mgr_info' has no member named '_sifields' + +Link: https://lore.kernel.org/r/20210529234857.6870-1-rdunlap@infradead.org +Fixes: 391e2f25601e ("[SCSI] BusLogic: Port driver to 64-bit.") +Cc: "James E.J. Bottomley" +Cc: "Martin K. Petersen" +Cc: Christoph Hellwig +Cc: Jens Axboe +Cc: Hannes Reinecke +Cc: Khalid Aziz +Cc: Khalid Aziz +Reported-by: kernel test robot +Reviewed-by: Hannes Reinecke +Signed-off-by: Randy Dunlap +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/FlashPoint.c | 32 ++++++++++++++++---------------- + 1 file changed, 16 insertions(+), 16 deletions(-) + +diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c +index 24ace1824048..ec8a621d232d 100644 +--- a/drivers/scsi/FlashPoint.c ++++ b/drivers/scsi/FlashPoint.c +@@ -40,7 +40,7 @@ struct sccb_mgr_info { + u16 si_per_targ_ultra_nego; + u16 si_per_targ_no_disc; + u16 si_per_targ_wide_nego; +- u16 si_flags; ++ u16 si_mflags; + unsigned char si_card_family; + unsigned char si_bustype; + unsigned char si_card_model[3]; +@@ -1073,22 +1073,22 @@ static int FlashPoint_ProbeHostAdapter(struct sccb_mgr_info *pCardInfo) + ScamFlg = + (unsigned char)FPT_utilEERead(ioport, SCAM_CONFIG / 2); + +- pCardInfo->si_flags = 0x0000; ++ pCardInfo->si_mflags = 0x0000; + + if (i & 0x01) +- pCardInfo->si_flags |= SCSI_PARITY_ENA; ++ pCardInfo->si_mflags |= SCSI_PARITY_ENA; + + if (!(i & 0x02)) +- pCardInfo->si_flags |= SOFT_RESET; ++ pCardInfo->si_mflags |= SOFT_RESET; + + if (i & 0x10) +- pCardInfo->si_flags |= EXTENDED_TRANSLATION; ++ pCardInfo->si_mflags |= EXTENDED_TRANSLATION; + + if (ScamFlg & SCAM_ENABLED) +- pCardInfo->si_flags |= FLAG_SCAM_ENABLED; ++ pCardInfo->si_mflags |= FLAG_SCAM_ENABLED; + + if (ScamFlg & SCAM_LEVEL2) +- pCardInfo->si_flags |= FLAG_SCAM_LEVEL2; ++ pCardInfo->si_mflags |= FLAG_SCAM_LEVEL2; + + j = (RD_HARPOON(ioport + hp_bm_ctrl) & ~SCSI_TERM_ENA_L); + if (i & 0x04) { +@@ -1104,7 +1104,7 @@ static int FlashPoint_ProbeHostAdapter(struct sccb_mgr_info *pCardInfo) + + if (!(RD_HARPOON(ioport + hp_page_ctrl) & NARROW_SCSI_CARD)) + +- pCardInfo->si_flags |= SUPPORT_16TAR_32LUN; ++ pCardInfo->si_mflags |= SUPPORT_16TAR_32LUN; + + pCardInfo->si_card_family = HARPOON_FAMILY; + pCardInfo->si_bustype = BUSTYPE_PCI; +@@ -1140,15 +1140,15 @@ static int FlashPoint_ProbeHostAdapter(struct sccb_mgr_info *pCardInfo) + + if (pCardInfo->si_card_model[1] == '3') { + if (RD_HARPOON(ioport + hp_ee_ctrl) & BIT(7)) +- pCardInfo->si_flags |= LOW_BYTE_TERM; ++ pCardInfo->si_mflags |= LOW_BYTE_TERM; + } else if (pCardInfo->si_card_model[2] == '0') { + temp = RD_HARPOON(ioport + hp_xfer_pad); + WR_HARPOON(ioport + hp_xfer_pad, (temp & ~BIT(4))); + if (RD_HARPOON(ioport + hp_ee_ctrl) & BIT(7)) +- pCardInfo->si_flags |= LOW_BYTE_TERM; ++ pCardInfo->si_mflags |= LOW_BYTE_TERM; + WR_HARPOON(ioport + hp_xfer_pad, (temp | BIT(4))); + if (RD_HARPOON(ioport + hp_ee_ctrl) & BIT(7)) +- pCardInfo->si_flags |= HIGH_BYTE_TERM; ++ pCardInfo->si_mflags |= HIGH_BYTE_TERM; + WR_HARPOON(ioport + hp_xfer_pad, temp); + } else { + temp = RD_HARPOON(ioport + hp_ee_ctrl); +@@ -1166,9 +1166,9 @@ static int FlashPoint_ProbeHostAdapter(struct sccb_mgr_info *pCardInfo) + WR_HARPOON(ioport + hp_ee_ctrl, temp); + WR_HARPOON(ioport + hp_xfer_pad, temp2); + if (!(temp3 & BIT(7))) +- pCardInfo->si_flags |= LOW_BYTE_TERM; ++ pCardInfo->si_mflags |= LOW_BYTE_TERM; + if (!(temp3 & BIT(6))) +- pCardInfo->si_flags |= HIGH_BYTE_TERM; ++ pCardInfo->si_mflags |= HIGH_BYTE_TERM; + } + + ARAM_ACCESS(ioport); +@@ -1275,7 +1275,7 @@ static void *FlashPoint_HardwareResetHostAdapter(struct sccb_mgr_info + WR_HARPOON(ioport + hp_arb_id, pCardInfo->si_id); + CurrCard->ourId = pCardInfo->si_id; + +- i = (unsigned char)pCardInfo->si_flags; ++ i = (unsigned char)pCardInfo->si_mflags; + if (i & SCSI_PARITY_ENA) + WR_HARPOON(ioport + hp_portctrl_1, (HOST_MODE8 | CHK_SCSI_P)); + +@@ -1289,14 +1289,14 @@ static void *FlashPoint_HardwareResetHostAdapter(struct sccb_mgr_info + j |= SCSI_TERM_ENA_H; + WR_HARPOON(ioport + hp_ee_ctrl, j); + +- if (!(pCardInfo->si_flags & SOFT_RESET)) { ++ if (!(pCardInfo->si_mflags & SOFT_RESET)) { + + FPT_sresb(ioport, thisCard); + + FPT_scini(thisCard, pCardInfo->si_id, 0); + } + +- if (pCardInfo->si_flags & POST_ALL_UNDERRRUNS) ++ if (pCardInfo->si_mflags & POST_ALL_UNDERRRUNS) + CurrCard->globalFlags |= F_NO_FILTER; + + if (pCurrNvRam) { +-- +2.30.2 + diff --git a/queue-5.10/scsi-iscsi-flush-block-work-before-unblock.patch b/queue-5.10/scsi-iscsi-flush-block-work-before-unblock.patch new file mode 100644 index 00000000000..c64b542313b --- /dev/null +++ b/queue-5.10/scsi-iscsi-flush-block-work-before-unblock.patch @@ -0,0 +1,43 @@ +From aa779a037dcf3edd6c41de0304239193009100e3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 25 May 2021 13:18:09 -0500 +Subject: scsi: iscsi: Flush block work before unblock + +From: Mike Christie + +[ Upstream commit 7ce9fc5ecde0d8bd64c29baee6c5e3ce7074ec9a ] + +We set the max_active iSCSI EH works to 1, so all work is going to execute +in order by default. However, userspace can now override this in sysfs. If +max_active > 1, we can end up with the block_work on CPU1 and +iscsi_unblock_session running the unblock_work on CPU2 and the session and +target/device state will end up out of sync with each other. + +This adds a flush of the block_work in iscsi_unblock_session. + +Link: https://lore.kernel.org/r/20210525181821.7617-17-michael.christie@oracle.com +Fixes: 1d726aa6ef57 ("scsi: iscsi: Optimize work queue flush use") +Reviewed-by: Lee Duncan +Signed-off-by: Mike Christie +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/scsi_transport_iscsi.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c +index c53c3f9fa526..c520239082fc 100644 +--- a/drivers/scsi/scsi_transport_iscsi.c ++++ b/drivers/scsi/scsi_transport_iscsi.c +@@ -1979,6 +1979,8 @@ static void __iscsi_unblock_session(struct work_struct *work) + */ + void iscsi_unblock_session(struct iscsi_cls_session *session) + { ++ flush_work(&session->block_work); ++ + queue_work(iscsi_eh_timer_workq, &session->unblock_work); + /* + * Blocking the session can be done from any context so we only +-- +2.30.2 + diff --git a/queue-5.10/scsi-mpt3sas-fix-error-return-value-in-_scsih_expand.patch b/queue-5.10/scsi-mpt3sas-fix-error-return-value-in-_scsih_expand.patch new file mode 100644 index 00000000000..ed1789a947a --- /dev/null +++ b/queue-5.10/scsi-mpt3sas-fix-error-return-value-in-_scsih_expand.patch @@ -0,0 +1,43 @@ +From bc87d8e78d0ada5efb8f97b6557eb2dee33e8031 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 14 May 2021 16:13:00 +0800 +Subject: scsi: mpt3sas: Fix error return value in _scsih_expander_add() + +From: Zhen Lei + +[ Upstream commit d6c2ce435ffe23ef7f395ae76ec747414589db46 ] + +When an expander does not contain any 'phys', an appropriate error code -1 +should be returned, as done elsewhere in this function. However, we +currently do not explicitly assign this error code to 'rc'. As a result, 0 +was incorrectly returned. + +Link: https://lore.kernel.org/r/20210514081300.6650-1-thunder.leizhen@huawei.com +Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c +index 5f845d7094fc..008f734698f7 100644 +--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c ++++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c +@@ -6007,8 +6007,10 @@ _scsih_expander_add(struct MPT3SAS_ADAPTER *ioc, u16 handle) + handle, parent_handle, + (u64)sas_expander->sas_address, sas_expander->num_phys); + +- if (!sas_expander->num_phys) ++ if (!sas_expander->num_phys) { ++ rc = -1; + goto out_fail; ++ } + sas_expander->phy = kcalloc(sas_expander->num_phys, + sizeof(struct _sas_phy), GFP_KERNEL); + if (!sas_expander->phy) { +-- +2.30.2 + diff --git a/queue-5.10/selftests-bpf-whitelist-test_progs.h-from-.gitignore.patch b/queue-5.10/selftests-bpf-whitelist-test_progs.h-from-.gitignore.patch new file mode 100644 index 00000000000..3816d514288 --- /dev/null +++ b/queue-5.10/selftests-bpf-whitelist-test_progs.h-from-.gitignore.patch @@ -0,0 +1,45 @@ +From 0a947a0c68366ae1f3bea499e5dc57b289418b3f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Jun 2021 14:52:11 -0700 +Subject: selftests/bpf: Whitelist test_progs.h from .gitignore + +From: Daniel Xu + +[ Upstream commit 809ed84de8b3f2fd7b1d06efb94bf98fd318a7d7 ] + +Somehow test_progs.h was being included by the existing rule: + + /test_progs* + +This is bad because: + + 1) test_progs.h is a checked in file + 2) grep-like tools like ripgrep[0] respect gitignore and + test_progs.h was being hidden from searches + +[0]: https://github.com/BurntSushi/ripgrep + +Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule") +Signed-off-by: Daniel Xu +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/a46f64944bf678bc652410ca6028d3450f4f7f4b.1623880296.git.dxu@dxuuu.xyz +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/bpf/.gitignore | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore +index 3ab1200e172f..b1b37dcade9f 100644 +--- a/tools/testing/selftests/bpf/.gitignore ++++ b/tools/testing/selftests/bpf/.gitignore +@@ -9,6 +9,7 @@ fixdep + test_dev_cgroup + /test_progs* + test_tcpbpf_user ++!test_progs.h + test_verifier_log + feature + test_sock +-- +2.30.2 + diff --git a/queue-5.10/selftests-ftrace-fix-event-no-pid-on-1-core-machine.patch b/queue-5.10/selftests-ftrace-fix-event-no-pid-on-1-core-machine.patch new file mode 100644 index 00000000000..3b2d1c3b3d3 --- /dev/null +++ b/queue-5.10/selftests-ftrace-fix-event-no-pid-on-1-core-machine.patch @@ -0,0 +1,58 @@ +From ecd45afecaf2ee3d5b234854f337284af79dfda4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 23 Jun 2021 15:43:15 +0200 +Subject: selftests/ftrace: fix event-no-pid on 1-core machine + +From: Krzysztof Kozlowski + +[ Upstream commit 07b60713b57a8f952d029a2b6849d003d9c16108 ] + +When running event-no-pid test on small machines (e.g. cloud 1-core +instance), other events might not happen: + + + cat trace + + cnt=0 + + [ 0 -eq 0 ] + + fail No other events were recorded + [15] event tracing - restricts events based on pid notrace filtering [FAIL] + +Schedule a simple sleep task to be sure that some other process events +get recorded. + +Fixes: ebed9628f5c2 ("selftests/ftrace: Add test to test new set_event_notrace_pid file") +Signed-off-by: Krzysztof Kozlowski +Acked-by: Steven Rostedt (VMware) +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + .../testing/selftests/ftrace/test.d/event/event-no-pid.tc | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc +index e6eb78f0b954..9933ed24f901 100644 +--- a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc ++++ b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc +@@ -57,6 +57,10 @@ enable_events() { + echo 1 > tracing_on + } + ++other_task() { ++ sleep .001 || usleep 1 || sleep 1 ++} ++ + echo 0 > options/event-fork + + do_reset +@@ -94,6 +98,9 @@ child=$! + echo "child = $child" + wait $child + ++# Be sure some other events will happen for small systems (e.g. 1 core) ++other_task ++ + echo 0 > tracing_on + + cnt=`count_pid $mypid` +-- +2.30.2 + diff --git a/queue-5.10/selftests-splice-adjust-for-handler-fallback-removal.patch b/queue-5.10/selftests-splice-adjust-for-handler-fallback-removal.patch new file mode 100644 index 00000000000..c8b0f407992 --- /dev/null +++ b/queue-5.10/selftests-splice-adjust-for-handler-fallback-removal.patch @@ -0,0 +1,188 @@ +From d3ece0d7a5d23769deef7bdead68cec3afca15e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 26 May 2021 20:25:37 -0700 +Subject: selftests: splice: Adjust for handler fallback removal + +From: Kees Cook + +[ Upstream commit 6daf076b717d189f4d02a303d45edd5732341ec1 ] + +Some pseudo-filesystems do not have an explicit splice fops since adding +commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops"), +and now will reject attempts to use splice() in those filesystem paths. + +Reported-by: kernel test robot +Link: https://lore.kernel.org/lkml/202009181443.C2179FB@keescook/ +Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") +Cc: Christoph Hellwig +Cc: Shuah Khan +Cc: linux-kselftest@vger.kernel.org +Signed-off-by: Kees Cook +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + .../selftests/splice/short_splice_read.sh | 119 ++++++++++++++---- + 1 file changed, 98 insertions(+), 21 deletions(-) + +diff --git a/tools/testing/selftests/splice/short_splice_read.sh b/tools/testing/selftests/splice/short_splice_read.sh +index 7810d3589d9a..22b6c8910b18 100755 +--- a/tools/testing/selftests/splice/short_splice_read.sh ++++ b/tools/testing/selftests/splice/short_splice_read.sh +@@ -1,21 +1,87 @@ + #!/bin/sh + # SPDX-License-Identifier: GPL-2.0 ++# ++# Test for mishandling of splice() on pseudofilesystems, which should catch ++# bugs like 11990a5bd7e5 ("module: Correctly truncate sysfs sections output") ++# ++# Since splice fallback was removed as part of the set_fs() rework, many of these ++# tests expect to fail now. See https://lore.kernel.org/lkml/202009181443.C2179FB@keescook/ + set -e + ++DIR=$(dirname "$0") ++ + ret=0 + ++expect_success() ++{ ++ title="$1" ++ shift ++ ++ echo "" >&2 ++ echo "$title ..." >&2 ++ ++ set +e ++ "$@" ++ rc=$? ++ set -e ++ ++ case "$rc" in ++ 0) ++ echo "ok: $title succeeded" >&2 ++ ;; ++ 1) ++ echo "FAIL: $title should work" >&2 ++ ret=$(( ret + 1 )) ++ ;; ++ *) ++ echo "FAIL: something else went wrong" >&2 ++ ret=$(( ret + 1 )) ++ ;; ++ esac ++} ++ ++expect_failure() ++{ ++ title="$1" ++ shift ++ ++ echo "" >&2 ++ echo "$title ..." >&2 ++ ++ set +e ++ "$@" ++ rc=$? ++ set -e ++ ++ case "$rc" in ++ 0) ++ echo "FAIL: $title unexpectedly worked" >&2 ++ ret=$(( ret + 1 )) ++ ;; ++ 1) ++ echo "ok: $title correctly failed" >&2 ++ ;; ++ *) ++ echo "FAIL: something else went wrong" >&2 ++ ret=$(( ret + 1 )) ++ ;; ++ esac ++} ++ + do_splice() + { + filename="$1" + bytes="$2" + expected="$3" ++ report="$4" + +- out=$(./splice_read "$filename" "$bytes" | cat) ++ out=$("$DIR"/splice_read "$filename" "$bytes" | cat) + if [ "$out" = "$expected" ] ; then +- echo "ok: $filename $bytes" ++ echo " matched $report" >&2 ++ return 0 + else +- echo "FAIL: $filename $bytes" +- ret=1 ++ echo " no match: '$out' vs $report" >&2 ++ return 1 + fi + } + +@@ -23,34 +89,45 @@ test_splice() + { + filename="$1" + ++ echo " checking $filename ..." >&2 ++ + full=$(cat "$filename") ++ rc=$? ++ if [ $rc -ne 0 ] ; then ++ return 2 ++ fi ++ + two=$(echo "$full" | grep -m1 . | cut -c-2) + + # Make sure full splice has the same contents as a standard read. +- do_splice "$filename" 4096 "$full" ++ echo " splicing 4096 bytes ..." >&2 ++ if ! do_splice "$filename" 4096 "$full" "full read" ; then ++ return 1 ++ fi + + # Make sure a partial splice see the first two characters. +- do_splice "$filename" 2 "$two" ++ echo " splicing 2 bytes ..." >&2 ++ if ! do_splice "$filename" 2 "$two" "'$two'" ; then ++ return 1 ++ fi ++ ++ return 0 + } + +-# proc_single_open(), seq_read() +-test_splice /proc/$$/limits +-# special open, seq_read() +-test_splice /proc/$$/comm ++### /proc/$pid/ has no splice interface; these should all fail. ++expect_failure "proc_single_open(), seq_read() splice" test_splice /proc/$$/limits ++expect_failure "special open(), seq_read() splice" test_splice /proc/$$/comm + +-# proc_handler, proc_dointvec_minmax +-test_splice /proc/sys/fs/nr_open +-# proc_handler, proc_dostring +-test_splice /proc/sys/kernel/modprobe +-# proc_handler, special read +-test_splice /proc/sys/kernel/version ++### /proc/sys/ has a splice interface; these should all succeed. ++expect_success "proc_handler: proc_dointvec_minmax() splice" test_splice /proc/sys/fs/nr_open ++expect_success "proc_handler: proc_dostring() splice" test_splice /proc/sys/kernel/modprobe ++expect_success "proc_handler: special read splice" test_splice /proc/sys/kernel/version + ++### /sys/ has no splice interface; these should all fail. + if ! [ -d /sys/module/test_module/sections ] ; then +- modprobe test_module ++ expect_success "test_module kernel module load" modprobe test_module + fi +-# kernfs, attr +-test_splice /sys/module/test_module/coresize +-# kernfs, binattr +-test_splice /sys/module/test_module/sections/.init.text ++expect_failure "kernfs attr splice" test_splice /sys/module/test_module/coresize ++expect_failure "kernfs binattr splice" test_splice /sys/module/test_module/sections/.init.text + + exit $ret +-- +2.30.2 + diff --git a/queue-5.10/selftests-vm-pkeys-fix-alloc_random_pkey-to-make-it-.patch b/queue-5.10/selftests-vm-pkeys-fix-alloc_random_pkey-to-make-it-.patch new file mode 100644 index 00000000000..bed633f388a --- /dev/null +++ b/queue-5.10/selftests-vm-pkeys-fix-alloc_random_pkey-to-make-it-.patch @@ -0,0 +1,102 @@ +From ef8cf705dee24428aa1aed7f4cf9a5ba28dfb277 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:56:53 -0700 +Subject: selftests/vm/pkeys: fix alloc_random_pkey() to make it really, really + random + +From: Dave Hansen + +[ Upstream commit f36ef407628835a7d7fb3d235b1f1aac7022d9a3 ] + +Patch series "selftests/vm/pkeys: Bug fixes and a new test". + +There has been a lot of activity on the x86 front around the XSAVE +architecture which is used to context-switch processor state (among other +things). In addition, AMD has recently joined the protection keys club by +adding processor support for PKU. + +The AMD implementation helped uncover a kernel bug around the PKRU "init +state", which actually applied to Intel's implementation but was just +harder to hit. This series adds a test which is expected to help find +this class of bug both on AMD and Intel. All the work around pkeys on x86 +also uncovered a few bugs in the selftest. + +This patch (of 4): + +The "random" pkey allocation code currently does the good old: + + srand((unsigned int)time(NULL)); + +*But*, it unfortunately does this on every random pkey allocation. + +There may be thousands of these a second. time() has a one second +resolution. So, each time alloc_random_pkey() is called, the PRNG is +*RESET* to time(). This is nasty. Normally, if you do: + + srand(); + foo = rand(); + bar = rand(); + +You'll be quite guaranteed that 'foo' and 'bar' are different. But, if +you do: + + srand(1); + foo = rand(); + srand(1); + bar = rand(); + +You are quite guaranteed that 'foo' and 'bar' are the *SAME*. The recent +"fix" effectively forced the test case to use the same "random" pkey for +the whole test, unless the test run crossed a second boundary. + +Only run srand() once at program startup. + +This explains some very odd and persistent test failures I've been seeing. + +Link: https://lkml.kernel.org/r/20210611164153.91B76FB8@viggo.jf.intel.com +Link: https://lkml.kernel.org/r/20210611164155.192D00FF@viggo.jf.intel.com +Fixes: 6e373263ce07 ("selftests/vm/pkeys: fix alloc_random_pkey() to make it really random") +Signed-off-by: Dave Hansen +Signed-off-by: Thomas Gleixner +Tested-by: Aneesh Kumar K.V +Cc: Ram Pai +Cc: Sandipan Das +Cc: Florian Weimer +Cc: "Desnes A. Nunes do Rosario" +Cc: Ingo Molnar +Cc: Thiago Jung Bauermann +Cc: Michael Ellerman +Cc: Michal Hocko +Cc: Michal Suchanek +Cc: Shuah Khan +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/vm/protection_keys.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c +index fdbb602ecf32..9ee0ae5d3e06 100644 +--- a/tools/testing/selftests/vm/protection_keys.c ++++ b/tools/testing/selftests/vm/protection_keys.c +@@ -561,7 +561,6 @@ int alloc_random_pkey(void) + int nr_alloced = 0; + int random_index; + memset(alloced_pkeys, 0, sizeof(alloced_pkeys)); +- srand((unsigned int)time(NULL)); + + /* allocate every possible key and make a note of which ones we got */ + max_nr_pkey_allocs = NR_PKEYS; +@@ -1552,6 +1551,8 @@ int main(void) + int nr_iterations = 22; + int pkeys_supported = is_pkeys_supported(); + ++ srand((unsigned int)time(NULL)); ++ + setup_handlers(); + + printf("has pkeys: %d\n", pkeys_supported); +-- +2.30.2 + diff --git a/queue-5.10/selftests-vm-pkeys-handle-negative-sys_pkey_alloc-re.patch b/queue-5.10/selftests-vm-pkeys-handle-negative-sys_pkey_alloc-re.patch new file mode 100644 index 00000000000..4c801d0bad1 --- /dev/null +++ b/queue-5.10/selftests-vm-pkeys-handle-negative-sys_pkey_alloc-re.patch @@ -0,0 +1,57 @@ +From 8779cd572ba22eef9c765280d94c417cf5f7a329 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:56:56 -0700 +Subject: selftests/vm/pkeys: handle negative sys_pkey_alloc() return code + +From: Dave Hansen + +[ Upstream commit bf68294a2ec39ed7fec6a5b45d52034e6983157a ] + +The alloc_pkey() sefltest function wraps the sys_pkey_alloc() system call. +On success, it updates its "shadow" register value because +sys_pkey_alloc() updates the real register. + +But, the success check is wrong. pkey_alloc() considers any non-zero +return code to indicate success where the pkey register will be modified. +This fails to take negative return codes into account. + +Consider only a positive return value as a successful call. + +Link: https://lkml.kernel.org/r/20210611164157.87AB4246@viggo.jf.intel.com +Fixes: 5f23f6d082a9 ("x86/pkeys: Add self-tests") +Reported-by: Thomas Gleixner +Signed-off-by: Dave Hansen +Tested-by: Aneesh Kumar K.V +Cc: Ram Pai +Cc: Sandipan Das +Cc: Florian Weimer +Cc: "Desnes A. Nunes do Rosario" +Cc: Ingo Molnar +Cc: Thiago Jung Bauermann +Cc: Michael Ellerman +Cc: Michal Hocko +Cc: Michal Suchanek +Cc: Shuah Khan +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/vm/protection_keys.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c +index 9ee0ae5d3e06..356d62fca27f 100644 +--- a/tools/testing/selftests/vm/protection_keys.c ++++ b/tools/testing/selftests/vm/protection_keys.c +@@ -510,7 +510,7 @@ int alloc_pkey(void) + " shadow: 0x%016llx\n", + __func__, __LINE__, ret, __read_pkey_reg(), + shadow_pkey_reg); +- if (ret) { ++ if (ret > 0) { + /* clear both the bits: */ + shadow_pkey_reg = set_pkey_bits(shadow_pkey_reg, ret, + ~PKEY_MASK); +-- +2.30.2 + diff --git a/queue-5.10/selftests-vm-pkeys-refill-shadow-register-after-impl.patch b/queue-5.10/selftests-vm-pkeys-refill-shadow-register-after-impl.patch new file mode 100644 index 00000000000..68d1239aa37 --- /dev/null +++ b/queue-5.10/selftests-vm-pkeys-refill-shadow-register-after-impl.patch @@ -0,0 +1,75 @@ +From e265bbe87708508fccab82e82d2b6dffddd34021 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Jun 2021 18:56:59 -0700 +Subject: selftests/vm/pkeys: refill shadow register after implicit kernel + write + +From: Dave Hansen + +[ Upstream commit 6039ca254979694c5362dfebadd105e286c397bb ] + +The pkey test code keeps a "shadow" of the pkey register around. This +ensures that any bugs which might write to the register can be caught more +quickly. + +Generally, userspace has a good idea when the kernel is going to write to +the register. For instance, alloc_pkey() is passed a permission mask. +The caller of alloc_pkey() can update the shadow based on the return value +and the mask. + +But, the kernel can also modify the pkey register in a more sneaky way. +For mprotect(PROT_EXEC) mappings, the kernel will allocate a pkey and +write the pkey register to create an execute-only mapping. The kernel +never tells userspace what key it uses for this. + +This can cause the test to fail with messages like: + + protection_keys_64.2: pkey-helpers.h:132: _read_pkey_reg: Assertion `pkey_reg == shadow_pkey_reg' failed. + +because the shadow was not updated with the new kernel-set value. + +Forcibly update the shadow value immediately after an mprotect(). + +Link: https://lkml.kernel.org/r/20210611164200.EF76AB73@viggo.jf.intel.com +Fixes: 6af17cf89e99 ("x86/pkeys/selftests: Add PROT_EXEC test") +Signed-off-by: Dave Hansen +Signed-off-by: Thomas Gleixner +Tested-by: Aneesh Kumar K.V +Cc: Ram Pai +Cc: Sandipan Das +Cc: Florian Weimer +Cc: "Desnes A. Nunes do Rosario" +Cc: Ingo Molnar +Cc: Thiago Jung Bauermann +Cc: Michael Ellerman +Cc: Michal Hocko +Cc: Michal Suchanek +Cc: Shuah Khan +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/vm/protection_keys.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c +index 356d62fca27f..87eecd5ba577 100644 +--- a/tools/testing/selftests/vm/protection_keys.c ++++ b/tools/testing/selftests/vm/protection_keys.c +@@ -1448,6 +1448,13 @@ void test_implicit_mprotect_exec_only_memory(int *ptr, u16 pkey) + ret = mprotect(p1, PAGE_SIZE, PROT_EXEC); + pkey_assert(!ret); + ++ /* ++ * Reset the shadow, assuming that the above mprotect() ++ * correctly changed PKRU, but to an unknown value since ++ * the actual alllocated pkey is unknown. ++ */ ++ shadow_pkey_reg = __read_pkey_reg(); ++ + dprintf2("pkey_reg: %016llx\n", read_pkey_reg()); + + /* Make sure this is an *instruction* fault */ +-- +2.30.2 + diff --git a/queue-5.10/serial-8250-8250_omap-disable-rx-interrupt-after-dma.patch b/queue-5.10/serial-8250-8250_omap-disable-rx-interrupt-after-dma.patch new file mode 100644 index 00000000000..7c97408fbff --- /dev/null +++ b/queue-5.10/serial-8250-8250_omap-disable-rx-interrupt-after-dma.patch @@ -0,0 +1,148 @@ +From 1018410d812c7d061d46e761b334796060190605 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 29 Oct 2020 10:49:30 +0530 +Subject: serial: 8250: 8250_omap: Disable RX interrupt after DMA enable + +From: Vignesh Raghavendra + +[ Upstream commit 439c7183e5b97952bba1747f5ffc4dea45a6a18b ] + +UARTs on TI SoCs prior to J7200 don't provide independent control over +RX FIFO not empty interrupt (RHR_IT) and RX timeout interrupt. +Starting with J7200 SoC, its possible to disable RHR_IT independent of +RX timeout interrupt using bit 2 of IER2 register. So disable RHR_IT +once RX DMA is started so as to avoid spurious interrupt being raised +when data is in the RX FIFO but is yet to be drained by DMA (a known +errata in older SoCs). + +Signed-off-by: Vignesh Raghavendra +Link: https://lore.kernel.org/r/20201029051930.7097-1-vigneshr@ti.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/8250/8250_omap.c | 42 ++++++++++++++++++++++++++++- + 1 file changed, 41 insertions(+), 1 deletion(-) + +diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c +index f284c6f77a6c..a9cfe1c57642 100644 +--- a/drivers/tty/serial/8250/8250_omap.c ++++ b/drivers/tty/serial/8250/8250_omap.c +@@ -27,6 +27,7 @@ + #include + #include + #include ++#include + + #include "8250.h" + +@@ -41,6 +42,7 @@ + */ + #define UART_ERRATA_CLOCK_DISABLE (1 << 3) + #define UART_HAS_EFR2 BIT(4) ++#define UART_HAS_RHR_IT_DIS BIT(5) + + #define OMAP_UART_FCR_RX_TRIG 6 + #define OMAP_UART_FCR_TX_TRIG 4 +@@ -94,6 +96,10 @@ + #define OMAP_UART_REV_52 0x0502 + #define OMAP_UART_REV_63 0x0603 + ++/* Interrupt Enable Register 2 */ ++#define UART_OMAP_IER2 0x1B ++#define UART_OMAP_IER2_RHR_IT_DIS BIT(2) ++ + /* Enhanced features register 2 */ + #define UART_OMAP_EFR2 0x23 + #define UART_OMAP_EFR2_TIMEOUT_BEHAVE BIT(6) +@@ -756,17 +762,27 @@ static void __dma_rx_do_complete(struct uart_8250_port *p) + { + struct uart_8250_dma *dma = p->dma; + struct tty_port *tty_port = &p->port.state->port; ++ struct omap8250_priv *priv = p->port.private_data; + struct dma_chan *rxchan = dma->rxchan; + dma_cookie_t cookie; + struct dma_tx_state state; + int count; + int ret; ++ u32 reg; + + if (!dma->rx_running) + goto out; + + cookie = dma->rx_cookie; + dma->rx_running = 0; ++ ++ /* Re-enable RX FIFO interrupt now that transfer is complete */ ++ if (priv->habit & UART_HAS_RHR_IT_DIS) { ++ reg = serial_in(p, UART_OMAP_IER2); ++ reg &= ~UART_OMAP_IER2_RHR_IT_DIS; ++ serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS); ++ } ++ + dmaengine_tx_status(rxchan, cookie, &state); + + count = dma->rx_size - state.residue + state.in_flight_bytes; +@@ -862,6 +878,7 @@ static int omap_8250_rx_dma(struct uart_8250_port *p) + int err = 0; + struct dma_async_tx_descriptor *desc; + unsigned long flags; ++ u32 reg; + + if (priv->rx_dma_broken) + return -EINVAL; +@@ -897,6 +914,17 @@ static int omap_8250_rx_dma(struct uart_8250_port *p) + + dma->rx_cookie = dmaengine_submit(desc); + ++ /* ++ * Disable RX FIFO interrupt while RX DMA is enabled, else ++ * spurious interrupt may be raised when data is in the RX FIFO ++ * but is yet to be drained by DMA. ++ */ ++ if (priv->habit & UART_HAS_RHR_IT_DIS) { ++ reg = serial_in(p, UART_OMAP_IER2); ++ reg |= UART_OMAP_IER2_RHR_IT_DIS; ++ serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS); ++ } ++ + dma_async_issue_pending(dma->rxchan); + out: + spin_unlock_irqrestore(&priv->rx_dma_lock, flags); +@@ -1163,6 +1191,11 @@ static int omap8250_no_handle_irq(struct uart_port *port) + return 0; + } + ++static const struct soc_device_attribute k3_soc_devices[] = { ++ { .family = "AM65X", }, ++ { .family = "J721E", .revision = "SR1.0" }, ++}; ++ + static struct omap8250_dma_params am654_dma = { + .rx_size = SZ_2K, + .rx_trigger = 1, +@@ -1177,7 +1210,7 @@ static struct omap8250_dma_params am33xx_dma = { + + static struct omap8250_platdata am654_platdata = { + .dma_params = &am654_dma, +- .habit = UART_HAS_EFR2, ++ .habit = UART_HAS_EFR2 | UART_HAS_RHR_IT_DIS, + }; + + static struct omap8250_platdata am33xx_platdata = { +@@ -1367,6 +1400,13 @@ static int omap8250_probe(struct platform_device *pdev) + up.dma->rxconf.src_maxburst = RX_TRIGGER; + up.dma->txconf.dst_maxburst = TX_TRIGGER; + } ++ ++ /* ++ * AM65x SR1.0, AM65x SR2.0 and J721e SR1.0 don't ++ * don't have RHR_IT_DIS bit in IER2 register ++ */ ++ if (soc_device_match(k3_soc_devices)) ++ priv->habit &= ~UART_HAS_RHR_IT_DIS; + } + #endif + ret = serial8250_register_8250_port(&up); +-- +2.30.2 + diff --git a/queue-5.10/serial-8250-8250_omap-fix-possible-interrupt-storm-o.patch b/queue-5.10/serial-8250-8250_omap-fix-possible-interrupt-storm-o.patch new file mode 100644 index 00000000000..9dc525fa80c --- /dev/null +++ b/queue-5.10/serial-8250-8250_omap-fix-possible-interrupt-storm-o.patch @@ -0,0 +1,90 @@ +From 26cf89bf2f4c5d85f881476b55233c56c7d64300 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 20:27:04 +0530 +Subject: serial: 8250: 8250_omap: Fix possible interrupt storm on K3 SoCs + +From: Vignesh Raghavendra + +[ Upstream commit b67e830d38fa9335d927fe67e812e3ed81b4689c ] + +On K3 family of SoCs (which includes AM654 SoC), it is observed that RX +TIMEOUT is signalled after RX FIFO has been drained, in which case a +dummy read of RX FIFO is required to clear RX TIMEOUT condition. +Otherwise, this would lead to an interrupt storm. + +Fix this by introducing UART_RX_TIMEOUT_QUIRK flag and doing a dummy +read in IRQ handler when RX TIMEOUT is reported with no data in RX FIFO. + +Fixes: be70874498f3 ("serial: 8250_omap: Add support for AM654 UART controller") +Reported-by: Jan Kiszka +Tested-by: Jan Kiszka +Signed-off-by: Vignesh Raghavendra +Link: https://lore.kernel.org/r/20210622145704.11168-1-vigneshr@ti.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/8250/8250_omap.c | 20 +++++++++++++++++++- + 1 file changed, 19 insertions(+), 1 deletion(-) + +diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c +index a9cfe1c57642..95e2d6de4f21 100644 +--- a/drivers/tty/serial/8250/8250_omap.c ++++ b/drivers/tty/serial/8250/8250_omap.c +@@ -43,6 +43,7 @@ + #define UART_ERRATA_CLOCK_DISABLE (1 << 3) + #define UART_HAS_EFR2 BIT(4) + #define UART_HAS_RHR_IT_DIS BIT(5) ++#define UART_RX_TIMEOUT_QUIRK BIT(6) + + #define OMAP_UART_FCR_RX_TRIG 6 + #define OMAP_UART_FCR_TX_TRIG 4 +@@ -104,6 +105,9 @@ + #define UART_OMAP_EFR2 0x23 + #define UART_OMAP_EFR2_TIMEOUT_BEHAVE BIT(6) + ++/* RX FIFO occupancy indicator */ ++#define UART_OMAP_RX_LVL 0x64 ++ + struct omap8250_priv { + int line; + u8 habit; +@@ -598,6 +602,7 @@ static int omap_8250_dma_handle_irq(struct uart_port *port); + static irqreturn_t omap8250_irq(int irq, void *dev_id) + { + struct uart_port *port = dev_id; ++ struct omap8250_priv *priv = port->private_data; + struct uart_8250_port *up = up_to_u8250p(port); + unsigned int iir; + int ret; +@@ -612,6 +617,18 @@ static irqreturn_t omap8250_irq(int irq, void *dev_id) + serial8250_rpm_get(up); + iir = serial_port_in(port, UART_IIR); + ret = serial8250_handle_irq(port, iir); ++ ++ /* ++ * On K3 SoCs, it is observed that RX TIMEOUT is signalled after ++ * FIFO has been drained, in which case a dummy read of RX FIFO ++ * is required to clear RX TIMEOUT condition. ++ */ ++ if (priv->habit & UART_RX_TIMEOUT_QUIRK && ++ (iir & UART_IIR_RX_TIMEOUT) == UART_IIR_RX_TIMEOUT && ++ serial_port_in(port, UART_OMAP_RX_LVL) == 0) { ++ serial_port_in(port, UART_RX); ++ } ++ + serial8250_rpm_put(up); + + return IRQ_RETVAL(ret); +@@ -1210,7 +1227,8 @@ static struct omap8250_dma_params am33xx_dma = { + + static struct omap8250_platdata am654_platdata = { + .dma_params = &am654_dma, +- .habit = UART_HAS_EFR2 | UART_HAS_RHR_IT_DIS, ++ .habit = UART_HAS_EFR2 | UART_HAS_RHR_IT_DIS | ++ UART_RX_TIMEOUT_QUIRK, + }; + + static struct omap8250_platdata am33xx_platdata = { +-- +2.30.2 + diff --git a/queue-5.10/serial-8250-actually-allow-upf_magic_multiplier-baud.patch b/queue-5.10/serial-8250-actually-allow-upf_magic_multiplier-baud.patch new file mode 100644 index 00000000000..56e8f5ea6dc --- /dev/null +++ b/queue-5.10/serial-8250-actually-allow-upf_magic_multiplier-baud.patch @@ -0,0 +1,84 @@ +From b0b63278fa59d3e7b3b1e2518f959198619a2539 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 20:38:34 +0200 +Subject: serial: 8250: Actually allow UPF_MAGIC_MULTIPLIER baud rates + +From: Maciej W. Rozycki + +[ Upstream commit 78bcae8616ac277d6cb7f38e211493948ed73e30 ] + +Support for magic baud rate divisors of 32770 and 32769 used with SMSC +Super I/O chips for extra baud rates of 230400 and 460800 respectively +where base rate is 115200[1] has been added around Linux 2.5.64, which +predates our repo history, but the origin could be identified as commit +2a717aad772f ("Merge with Linux 2.5.64.") with the old MIPS/Linux repo +also at: . + +Code that is now in `serial8250_do_get_divisor' was added back then to +`serial8250_get_divisor', but that code would only ever trigger if one +of the higher baud rates was actually requested, and that cannot ever +happen, because the earlier call to `serial8250_get_baud_rate' never +returns them. This is because it calls `uart_get_baud_rate' with the +maximum requested being the base rate, that is clk/16 or 115200 for SMSC +chips at their nominal clock rate. + +Fix it then and allow UPF_MAGIC_MULTIPLIER baud rates to be selected, by +requesting the maximum baud rate of clk/4 rather than clk/16 if the flag +has been set. Also correct the minimum baud rate, observing that these +ports only support actual (non-magic) divisors of up to 32767 only. + +References: + +[1] "FDC37M81x, PC98/99 Compliant Enhanced Super I/O Controller with + Keyboard/Mouse Wake-Up", Standard Microsystems Corporation, Rev. + 03/27/2000, Table 31 - "Baud Rates", p. 77 + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Signed-off-by: Maciej W. Rozycki +Link: https://lore.kernel.org/r/alpine.DEB.2.21.2105190412280.29169@angie.orcam.me.uk +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/8250/8250_port.c | 19 ++++++++++++++++--- + 1 file changed, 16 insertions(+), 3 deletions(-) + +diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c +index 6e141429c980..6d9c494bed7d 100644 +--- a/drivers/tty/serial/8250/8250_port.c ++++ b/drivers/tty/serial/8250/8250_port.c +@@ -2635,6 +2635,21 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port, + struct ktermios *old) + { + unsigned int tolerance = port->uartclk / 100; ++ unsigned int min; ++ unsigned int max; ++ ++ /* ++ * Handle magic divisors for baud rates above baud_base on SMSC ++ * Super I/O chips. Enable custom rates of clk/4 and clk/8, but ++ * disable divisor values beyond 32767, which are unavailable. ++ */ ++ if (port->flags & UPF_MAGIC_MULTIPLIER) { ++ min = port->uartclk / 16 / UART_DIV_MAX >> 1; ++ max = (port->uartclk + tolerance) / 4; ++ } else { ++ min = port->uartclk / 16 / UART_DIV_MAX; ++ max = (port->uartclk + tolerance) / 16; ++ } + + /* + * Ask the core to calculate the divisor for us. +@@ -2642,9 +2657,7 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port, + * slower than nominal still match standard baud rates without + * causing transmission errors. + */ +- return uart_get_baud_rate(port, termios, old, +- port->uartclk / 16 / UART_DIV_MAX, +- (port->uartclk + tolerance) / 16); ++ return uart_get_baud_rate(port, termios, old, min, max); + } + + /* +-- +2.30.2 + diff --git a/queue-5.10/serial-8250_omap-fix-a-timeout-loop-condition.patch b/queue-5.10/serial-8250_omap-fix-a-timeout-loop-condition.patch new file mode 100644 index 00000000000..9bfc39baa37 --- /dev/null +++ b/queue-5.10/serial-8250_omap-fix-a-timeout-loop-condition.patch @@ -0,0 +1,37 @@ +From 0fe108c03fa52348a5bb7efc846775c9264644f5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 29 Apr 2021 10:19:22 +0300 +Subject: serial: 8250_omap: fix a timeout loop condition + +From: Dan Carpenter + +[ Upstream commit d7e325aaa8c3593b5a572b583ecad79e95f32e7f ] + +This loop ends on -1 so the error message will never be printed. + +Fixes: 4bcf59a5dea0 ("serial: 8250: 8250_omap: Account for data in flight during DMA teardown") +Reviewed-by: Alexander Sverdlin +Signed-off-by: Dan Carpenter +Link: https://lore.kernel.org/r/YIpd+kOpXKMpEXPf@mwanda +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/8250/8250_omap.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c +index 0cc6d35a0815..f284c6f77a6c 100644 +--- a/drivers/tty/serial/8250/8250_omap.c ++++ b/drivers/tty/serial/8250/8250_omap.c +@@ -784,7 +784,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p) + poll_count--) + cpu_relax(); + +- if (!poll_count) ++ if (poll_count == -1) + dev_err(p->port.dev, "teardown incomplete\n"); + } + } +-- +2.30.2 + diff --git a/queue-5.10/serial-fsl_lpuart-don-t-modify-arbitrary-data-on-lpu.patch b/queue-5.10/serial-fsl_lpuart-don-t-modify-arbitrary-data-on-lpu.patch new file mode 100644 index 00000000000..5cb600655f8 --- /dev/null +++ b/queue-5.10/serial-fsl_lpuart-don-t-modify-arbitrary-data-on-lpu.patch @@ -0,0 +1,37 @@ +From 1d61766e12007e4b2515dc12de6eae4e3a982808 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 16:12:47 +0200 +Subject: serial: fsl_lpuart: don't modify arbitrary data on lpuart32 + +From: Michael Walle + +[ Upstream commit ccf08fd1204bcb5311cc10aea037c71c6e74720a ] + +lpuart_rx_dma_startup() is used for both the 8 bit and the 32 bit +version of the LPUART. Modify the UARTCR only for the 8 bit version. + +Fixes: f4eef224a09f ("serial: fsl_lpuart: add sysrq support when using dma") +Signed-off-by: Michael Walle +Link: https://lore.kernel.org/r/20210512141255.18277-2-michael@walle.cc +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/fsl_lpuart.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c +index bd047e1f9bea..6b8e638c2389 100644 +--- a/drivers/tty/serial/fsl_lpuart.c ++++ b/drivers/tty/serial/fsl_lpuart.c +@@ -1625,7 +1625,7 @@ static void lpuart_rx_dma_startup(struct lpuart_port *sport) + sport->lpuart_dma_rx_use = true; + rx_dma_timer_init(sport); + +- if (sport->port.has_sysrq) { ++ if (sport->port.has_sysrq && !lpuart_is_32(sport)) { + cr3 = readb(sport->port.membase + UARTCR3); + cr3 |= UARTCR3_FEIE; + writeb(cr3, sport->port.membase + UARTCR3); +-- +2.30.2 + diff --git a/queue-5.10/serial-fsl_lpuart-remove-rtscts-handling-from-get_mc.patch b/queue-5.10/serial-fsl_lpuart-remove-rtscts-handling-from-get_mc.patch new file mode 100644 index 00000000000..128fc0028f8 --- /dev/null +++ b/queue-5.10/serial-fsl_lpuart-remove-rtscts-handling-from-get_mc.patch @@ -0,0 +1,50 @@ +From a3a0c254f3c9dd783561c6299917fc5dcbcb18e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 12 May 2021 16:12:52 +0200 +Subject: serial: fsl_lpuart: remove RTSCTS handling from get_mctrl() + +From: Michael Walle + +[ Upstream commit e60c2991f18bf221fa9908ff10cb24eaedaa9bae ] + +The wrong code in set_mctrl() was already removed in commit 2b30efe2e88a +("tty: serial: lpuart: Remove unnecessary code from set_mctrl"), but the +code in get_mctrl() wasn't removed. It will not return the state of the +RTS or CTS line but whether automatic flow control is enabled, which is +wrong for the get_mctrl(). Thus remove it. + +Fixes: 2b30efe2e88a ("tty: serial: lpuart: Remove unnecessary code from set_mctrl") +Signed-off-by: Michael Walle +Link: https://lore.kernel.org/r/20210512141255.18277-7-michael@walle.cc +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/fsl_lpuart.c | 12 +----------- + 1 file changed, 1 insertion(+), 11 deletions(-) + +diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c +index 6b8e638c2389..de5ee4aad9f3 100644 +--- a/drivers/tty/serial/fsl_lpuart.c ++++ b/drivers/tty/serial/fsl_lpuart.c +@@ -1408,17 +1408,7 @@ static unsigned int lpuart_get_mctrl(struct uart_port *port) + + static unsigned int lpuart32_get_mctrl(struct uart_port *port) + { +- unsigned int temp = 0; +- unsigned long reg; +- +- reg = lpuart32_read(port, UARTMODIR); +- if (reg & UARTMODIR_TXCTSE) +- temp |= TIOCM_CTS; +- +- if (reg & UARTMODIR_RXRTSE) +- temp |= TIOCM_RTS; +- +- return temp; ++ return 0; + } + + static void lpuart_set_mctrl(struct uart_port *port, unsigned int mctrl) +-- +2.30.2 + diff --git a/queue-5.10/serial-mvebu-uart-correctly-calculate-minimal-possib.patch b/queue-5.10/serial-mvebu-uart-correctly-calculate-minimal-possib.patch new file mode 100644 index 00000000000..d2b06101f20 --- /dev/null +++ b/queue-5.10/serial-mvebu-uart-correctly-calculate-minimal-possib.patch @@ -0,0 +1,66 @@ +From 503ecaae6755bbb4a5ea1ff00e15ccb8e5e8cd30 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 00:49:02 +0200 +Subject: serial: mvebu-uart: correctly calculate minimal possible baudrate +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit deeaf963569a0d9d1b08babb771f61bb501a5704 ] + +For default (x16) scheme which is currently used by mvebu-uart.c driver, +maximal divisor of UART base clock is 1023*16. Therefore there is limit for +minimal supported baudrate. This change calculate it correctly and prevents +setting invalid divisor 0 into hardware registers. + +Signed-off-by: Pali Rohár +Fixes: 68a0db1d7da2 ("serial: mvebu-uart: add function to change baudrate") +Link: https://lore.kernel.org/r/20210624224909.6350-4-pali@kernel.org +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/mvebu-uart.c | 11 ++++++++--- + 1 file changed, 8 insertions(+), 3 deletions(-) + +diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c +index 9638ae6aae79..1e26220c7852 100644 +--- a/drivers/tty/serial/mvebu-uart.c ++++ b/drivers/tty/serial/mvebu-uart.c +@@ -481,7 +481,7 @@ static void mvebu_uart_set_termios(struct uart_port *port, + struct ktermios *old) + { + unsigned long flags; +- unsigned int baud; ++ unsigned int baud, min_baud, max_baud; + + spin_lock_irqsave(&port->lock, flags); + +@@ -500,16 +500,21 @@ static void mvebu_uart_set_termios(struct uart_port *port, + port->ignore_status_mask |= STAT_RX_RDY(port) | STAT_BRK_ERR; + + /* ++ * Maximal divisor is 1023 * 16 when using default (x16) scheme. + * Maximum achievable frequency with simple baudrate divisor is 230400. + * Since the error per bit frame would be of more than 15%, achieving + * higher frequencies would require to implement the fractional divisor + * feature. + */ +- baud = uart_get_baud_rate(port, termios, old, 0, 230400); ++ min_baud = DIV_ROUND_UP(port->uartclk, 1023 * 16); ++ max_baud = 230400; ++ ++ baud = uart_get_baud_rate(port, termios, old, min_baud, max_baud); + if (mvebu_uart_baud_rate_set(port, baud)) { + /* No clock available, baudrate cannot be changed */ + if (old) +- baud = uart_get_baud_rate(port, old, NULL, 0, 230400); ++ baud = uart_get_baud_rate(port, old, NULL, ++ min_baud, max_baud); + } else { + tty_termios_encode_baud_rate(termios, baud, baud); + uart_update_timeout(port, termios->c_cflag, baud); +-- +2.30.2 + diff --git a/queue-5.10/serial-mvebu-uart-do-not-allow-changing-baudrate-whe.patch b/queue-5.10/serial-mvebu-uart-do-not-allow-changing-baudrate-whe.patch new file mode 100644 index 00000000000..dfb8d8d1df9 --- /dev/null +++ b/queue-5.10/serial-mvebu-uart-do-not-allow-changing-baudrate-whe.patch @@ -0,0 +1,55 @@ +From 0024e9d897c93838a7e5433a3b51610f58c41432 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 25 Jun 2021 00:49:01 +0200 +Subject: serial: mvebu-uart: do not allow changing baudrate when uartclk is + not available +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit ecd6b010d81f97b06b2f64d2d4f50ebf5acddaa9 ] + +Testing mvuart->clk for non-error is not enough as mvuart->clk may contain +valid clk pointer but when clk_prepare_enable(mvuart->clk) failed then +port->uartclk is zero. + +When mvuart->clk is not available then port->uartclk is zero too. + +Parent clock rate port->uartclk is needed to calculate UART clock divisor +and without it is not possible to change baudrate. + +So fix test condition when it is possible to change baudrate. + +Signed-off-by: Pali Rohár +Fixes: 68a0db1d7da2 ("serial: mvebu-uart: add function to change baudrate") +Link: https://lore.kernel.org/r/20210624224909.6350-3-pali@kernel.org +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/tty/serial/mvebu-uart.c | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c +index 908a4ac6b5a7..9638ae6aae79 100644 +--- a/drivers/tty/serial/mvebu-uart.c ++++ b/drivers/tty/serial/mvebu-uart.c +@@ -445,12 +445,11 @@ static void mvebu_uart_shutdown(struct uart_port *port) + + static int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud) + { +- struct mvebu_uart *mvuart = to_mvuart(port); + unsigned int d_divisor, m_divisor; + u32 brdv, osamp; + +- if (IS_ERR(mvuart->clk)) +- return -PTR_ERR(mvuart->clk); ++ if (!port->uartclk) ++ return -EOPNOTSUPP; + + /* + * The baudrate is derived from the UART clock thanks to two divisors: +-- +2.30.2 + diff --git a/queue-5.10/series b/queue-5.10/series index 366b1fe7f63..c530ccb4c8c 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -96,3 +96,485 @@ fuse-fix-infinite-loop-in-sget_fc.patch fuse-ignore-pg_workingset-after-stealing.patch fuse-check-connected-before-queueing-on-fpq-io.patch fuse-reject-internal-errno.patch +thermal-cpufreq_cooling-update-offline-cpus-per-cpu-.patch +spi-make-of_register_spi_device-also-set-the-fwnode.patch +add-a-reference-to-ucounts-for-each-cred.patch +staging-media-rkvdec-fix-pm_runtime_get_sync-usage-c.patch +media-marvel-ccic-fix-some-issues-when-getting-pm_ru.patch +media-mdk-mdp-fix-pm_runtime_get_sync-usage-count.patch +media-s5p-fix-pm_runtime_get_sync-usage-count.patch +media-am437x-fix-pm_runtime_get_sync-usage-count.patch +media-sh_vou-fix-pm_runtime_get_sync-usage-count.patch +media-mtk-vcodec-fix-pm-runtime-get-logic.patch +media-s5p-jpeg-fix-pm_runtime_get_sync-usage-count.patch +media-sunxi-fix-pm_runtime_get_sync-usage-count.patch +media-sti-bdisp-fix-pm_runtime_get_sync-usage-count.patch +media-exynos4-is-fix-pm_runtime_get_sync-usage-count.patch +media-exynos-gsc-fix-pm_runtime_get_sync-usage-count.patch +spi-spi-loopback-test-fix-tx_buf-might-be-rx_buf.patch +spi-spi-topcliff-pch-fix-potential-double-free-in-pc.patch +spi-omap-100k-fix-the-length-judgment-problem.patch +regulator-uniphier-add-missing-module_device_table.patch +sched-core-initialize-the-idle-task-with-preemption-.patch +hwrng-exynos-fix-runtime-pm-imbalance-on-error.patch +crypto-nx-add-missing-module_device_table.patch +media-sti-fix-obj-config-targets.patch +media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch +media-cobalt-fix-race-condition-in-setting-hpd.patch +media-hevc-fix-dependent-slice-segment-flags.patch +media-pvrusb2-fix-warning-in-pvr2_i2c_core_done.patch +media-imx-imx7_mipi_csis-fix-logging-of-only-error-e.patch +crypto-qat-check-return-code-of-qat_hal_rd_rel_reg.patch +crypto-qat-remove-unused-macro-in-fw-loader.patch +crypto-qce-skcipher-fix-incorrect-sg-count-for-dma-t.patch +arm64-perf-convert-snprintf-to-sysfs_emit.patch +sched-fair-fix-ascii-art-by-relpacing-tabs.patch +media-i2c-ov2659-use-clk_-prepare_enable-disable_unp.patch +media-bt878-do-not-schedule-tasklet-when-it-is-not-s.patch +media-em28xx-fix-possible-memory-leak-of-em28xx-stru.patch +media-hantro-fix-.buf_prepare.patch +media-cedrus-fix-.buf_prepare.patch +media-v4l2-core-avoid-the-dangling-pointer-in-v4l2_f.patch +media-bt8xx-fix-a-missing-check-bug-in-bt878_probe.patch +media-st-hva-fix-potential-null-pointer-dereferences.patch +crypto-hisilicon-sec-fixup-3des-minimum-key-size-dec.patch +makefile-fix-gdb-warning-with-config_relr.patch +media-dvd_usb-memory-leak-in-cinergyt2_fe_attach.patch +memstick-rtsx_usb_ms-fix-uaf.patch +mmc-sdhci-sprd-use-sdhci_sprd_writew.patch +mmc-via-sdmmc-add-a-check-against-null-pointer-deref.patch +spi-meson-spicc-fix-a-wrong-goto-jump-for-avoiding-m.patch +spi-meson-spicc-fix-memory-leak-in-meson_spicc_probe.patch +crypto-shash-avoid-comparing-pointers-to-exported-fu.patch +media-dvb_net-avoid-speculation-from-net-slot.patch +media-siano-fix-device-register-error-path.patch +media-imx-csi-skip-first-few-frames-from-a-bt.656-so.patch +hwmon-max31790-report-correct-current-pwm-duty-cycle.patch +hwmon-max31790-fix-pwmx_enable-attributes.patch +drivers-perf-fix-the-missed-ida_simple_remove-in-ddr.patch +kvm-ppc-book3s-hv-fix-tlb-management-on-smt8-power9-.patch +btrfs-fix-error-handling-in-__btrfs_update_delayed_i.patch +btrfs-abort-transaction-if-we-fail-to-update-the-del.patch +btrfs-sysfs-fix-format-string-for-some-discard-stats.patch +btrfs-fix-the-filemap_range_has_page-call-in-btrfs_p.patch +btrfs-don-t-clear-page-extent-mapped-if-we-re-not-in.patch +btrfs-disable-build-on-platforms-having-page-size-25.patch +locking-lockdep-fix-the-dep-path-printing-for-backwa.patch +lockding-lockdep-avoid-to-find-wrong-lock-dep-path-i.patch +kvm-s390-get-rid-of-register-asm-usage.patch +regulator-mt6358-fix-vdram2-.vsel_mask.patch +regulator-da9052-ensure-enough-delay-time-for-.set_v.patch +media-fix-media-controller-api-config-checks.patch +acpi-video-use-native-backlight-for-ga401-ga502-ga50.patch +hid-do-not-use-down_interruptible-when-unbinding-dev.patch +edac-ti-add-missing-module_device_table.patch +acpi-processor-idle-fix-up-c-state-latency-if-not-or.patch +hv_utils-fix-passing-zero-to-ptr_err-warning.patch +lib-vsprintf-fix-handling-of-number-field-widths-in-.patch +input-goodix-platform-x86-touchscreen_dmi-move-upsid.patch +platform-x86-touchscreen_dmi-add-an-extra-entry-for-.patch +platform-x86-touchscreen_dmi-add-info-for-the-goodix.patch +acpi-ec-make-more-asus-laptops-use-ecdt-_gpe.patch +block_dump-remove-block_dump-feature-in-mark_inode_d.patch +blk-mq-grab-rq-refcount-before-calling-fn-in-blk_mq_.patch +blk-mq-clear-stale-request-in-tags-rq-before-freeing.patch +fs-dlm-cancel-work-sync-othercon.patch +random32-fix-implicit-truncation-warning-in-prandom_.patch +open-don-t-silently-ignore-unknown-o-flags-in-openat.patch +drivers-hv-fix-missing-error-code-in-vmbus_connect.patch +fs-dlm-fix-memory-leak-when-fenced.patch +acpica-fix-memory-leak-caused-by-_cid-repair-functio.patch +acpi-bus-call-kobject_put-in-acpi_init-error-path.patch +acpi-resources-add-checks-for-acpi-irq-override.patch +block-fix-race-between-adding-removing-rq-qos-and-no.patch +platform-x86-asus-nb-wmi-revert-drop-duplicate-dmi-q.patch +platform-x86-asus-nb-wmi-revert-add-support-for-asus.patch +platform-x86-toshiba_acpi-fix-missing-error-code-in-.patch +nvme-pci-fix-var.-type-for-increasing-cq_head.patch +nvmet-fc-do-not-check-for-invalid-target-port-in-nvm.patch +edac-intel-do-not-load-edac-driver-when-running-as-a.patch +pci-hv-add-check-for-hyperv_initialized-in-init_hv_p.patch +cifs-improve-fallocate-emulation.patch +acpi-ec-trust-dsdt-gpe-for-certain-hp-laptop.patch +clocksource-retry-clock-read-if-long-delays-detected.patch +clocksource-check-per-cpu-clock-synchronization-when.patch +tpm_tis_spi-add-missing-spi-device-id-entries.patch +acpi-tables-add-custom-dsdt-file-as-makefile-prerequ.patch +hid-wacom-correct-base-usage-for-capacitive-expressk.patch +cifs-fix-missing-spinlock-around-update-to-ses-statu.patch +mailbox-qcom-use-platform_devid_auto-to-register-pla.patch +block-fix-discard-request-merge.patch +kthread_worker-fix-return-value-when-kthread_mod_del.patch +ia64-mca_drv-fix-incorrect-array-size-calculation.patch +writeback-cgroup-increment-isw_nr_in_flight-before-g.patch +spi-allow-to-have-all-native-css-in-use-along-with-g.patch +spi-avoid-undefined-behaviour-when-counting-unused-n.patch +media-venus-rework-error-fail-recover-logic.patch +media-s5p_cec-decrement-usage-count-if-disabled.patch +media-hantro-do-a-pm-resume-earlier.patch +crypto-ixp4xx-dma_unmap-the-correct-address.patch +crypto-ixp4xx-update-iv-after-requests.patch +crypto-ux500-fix-error-return-code-in-hash_hw_final.patch +sata_highbank-fix-deferred-probing.patch +pata_rb532_cf-fix-deferred-probing.patch +media-i2c-change-rst-to-rset-to-fix-multiple-build-e.patch +sched-uclamp-fix-wrong-implementation-of-cpu.uclamp..patch +sched-uclamp-fix-locking-around-cpu_util_update_eff.patch +kbuild-fix-objtool-dependency-for-object_files_non_s.patch +pata_octeon_cf-avoid-warn_on-in-ata_host_activate.patch +evm-fix-writing-securityfs-evm-overflow.patch +x86-elf-use-_bitul-macro-in-uapi-headers.patch +crypto-sa2ul-fix-leaks-on-failure-paths-with-sa_dma_.patch +crypto-sa2ul-fix-pm_runtime-enable-in-sa_ul_probe.patch +crypto-ccp-fix-a-resource-leak-in-an-error-handling-.patch +media-rc-i2c-fix-an-error-message.patch +pata_ep93xx-fix-deferred-probing.patch +locking-lockdep-reduce-lockdep-dependency-list.patch +media-rkvdec-fix-.buf_prepare.patch +media-exynos4-is-fix-a-use-after-free-in-isp_video_r.patch +media-au0828-fix-a-null-vs-is_err-check.patch +media-tc358743-fix-error-return-code-in-tc358743_pro.patch +media-gspca-gl860-fix-zero-length-control-requests.patch +m68k-atari-fix-atari_kbd_core-kconfig-unmet-dependen.patch +media-siano-fix-out-of-bounds-warnings-in-smscore_lo.patch +regulator-fan53880-fix-vsel_mask-setting-for-fan5388.patch +crypto-nitrox-fix-unchecked-variable-in-nitrox_regis.patch +crypto-omap-sham-fix-pm-reference-leak-in-omap-sham-.patch +crypto-x86-curve25519-fix-cpu-feature-checking-logic.patch +crypto-sm2-remove-unnecessary-reset-operations.patch +crypto-sm2-fix-a-memory-leak-in-sm2.patch +mmc-usdhi6rol0-fix-error-return-code-in-usdhi6_probe.patch +arm64-consistently-use-reserved_pg_dir.patch +arm64-mm-fix-ttbr0-values-stored-in-struct-thread_in.patch +media-subdev-remove-vidioc_dqevent_time32-handling.patch +media-s5p-g2d-fix-a-memory-leak-on-ctx-fh.m2m_ctx.patch +hwmon-lm70-use-device_get_match_data.patch +hwmon-lm70-revert-hwmon-lm70-add-support-for-acpi.patch +hwmon-max31722-remove-non-standard-acpi-device-ids.patch +hwmon-max31790-fix-fan-speed-reporting-for-fan7.12.patch +kvm-nvmx-sync-all-pgds-on-nested-transition-with-sha.patch +kvm-nvmx-ensure-64-bit-shift-when-checking-vmfunc-bi.patch +kvm-nvmx-don-t-clobber-nested-mmu-s-a-d-status-on-ep.patch +kvm-x86-mmu-fix-return-value-in-tdp_mmu_map_handle_t.patch +perf-arm-cmn-fix-invalid-pointer-when-access-dtc-obj.patch +kvm-arm64-don-t-zero-the-cycle-count-register-when-p.patch +regulator-hi655x-fix-pass-wrong-pointer-to-config.dr.patch +btrfs-clear-log-tree-recovering-status-if-starting-t.patch +x86-sev-make-sure-irqs-are-disabled-while-ghcb-is-ac.patch +x86-sev-split-up-runtime-vc-handler-for-correct-stat.patch +sched-rt-fix-rt-utilization-tracking-during-policy-c.patch +sched-rt-fix-deadline-utilization-tracking-during-po.patch +sched-uclamp-fix-uclamp_tg_restrict.patch +lockdep-fix-wait-type-for-empty-stack.patch +lockdep-selftests-fix-selftests-vs-prove_raw_lock_ne.patch +spi-spi-sun6i-fix-chipselect-clock-bug.patch +crypto-nx-fix-rcu-warning-in-nx842_of_upd_status.patch +psi-fix-race-between-psi_trigger_create-destroy.patch +media-v4l2-async-clean-v4l2_async_notifier_add_fwnod.patch +media-video-mux-skip-dangling-endpoints.patch +pm-devfreq-add-missing-error-code-in-devfreq_add_dev.patch +acpi-pm-fan-put-fan-device-ids-into-separate-header-.patch +block-avoid-double-io-accounting-for-flush-request.patch +nvme-pci-look-for-storaged3enable-on-companion-acpi-.patch +acpi-sysfs-fix-a-buffer-overrun-problem-with-descrip.patch +mark-pstore-blk-as-broken.patch +clocksource-drivers-timer-ti-dm-save-and-restore-tim.patch +extcon-extcon-max8997-fix-irq-freeing-at-error-path.patch +acpi-apei-fix-synchronous-external-aborts-in-user-mo.patch +blk-wbt-introduce-a-new-disable-state-to-prevent-fal.patch +blk-wbt-make-sure-throttle-is-enabled-properly.patch +acpi-use-device_attr_-rw-ro-wo-macros.patch +acpi-bgrt-fix-cfi-violation.patch +cpufreq-make-cpufreq_online-call-driver-offline-on-e.patch +blk-mq-update-hctx-dispatch_busy-in-case-of-real-sch.patch +ocfs2-fix-snprintf-checking.patch +dax-fix-enomem-handling-in-grab_mapping_entry.patch +mm-debug_vm_pgtable-basic-add-validation-for-dirtine.patch +mm-debug_vm_pgtable-basic-iterate-over-entire-protec.patch +mm-debug_vm_pgtable-ensure-thp-availability-via-has_.patch +swap-fix-do_swap_page-race-with-swapoff.patch +mm-shmem-fix-shmem_swapin-race-with-swapoff.patch +mm-memcg-slab-properly-set-up-gfp-flags-for-objcg-po.patch +mm-page_alloc-refactor-setup_per_zone_lowmem_reserve.patch +mm-page_alloc-fix-counting-of-managed_pages.patch +xfrm-xfrm_state_mtu-should-return-at-least-1280-for-.patch +drm-bridge-sii8620-fix-dependency-on-extcon.patch +drm-bridge-fix-the-stop-condition-of-drm_bridge_chai.patch +drm-amd-dc-fix-a-missing-check-bug-in-dm_dp_mst_dete.patch +drm-ast-fix-missing-conversions-to-managed-api.patch +video-fbdev-imxfb-fix-an-error-message.patch +net-mvpp2-put-fwnode-in-error-case-during-probe.patch +net-pch_gbe-propagate-error-from-devm_gpio_request_o.patch +pinctrl-renesas-r8a7796-add-missing-bias-for-preset-.patch +pinctrl-renesas-r8a77990-jtag-pins-do-not-have-pull-.patch +drm-vmwgfx-mark-a-surface-gpu-dirty-after-the-svga3d.patch +drm-vmwgfx-fix-cpu-updates-of-coherent-multisample-s.patch +net-qrtr-ns-fix-error-return-code-in-qrtr_ns_init.patch +clk-meson-g12a-fix-gp0-and-hifi-ranges.patch +net-ftgmac100-add-missing-error-return-code-in-ftgma.patch +drm-rockchip-set-alpha_en-to-0-if-it-is-not-used.patch +drm-rockchip-cdn-dp-core-add-missing-clk_disable_unp.patch +drm-rockchip-dsi-move-all-lane-config-except-lcdc-mu.patch +drm-rockchip-lvds-fix-an-error-handling-path.patch +drm-rockchip-cdn-dp-fix-sign-extension-on-an-int-mul.patch +mptcp-fix-pr_debug-in-mptcp_token_new_connect.patch +mptcp-generate-subflow-hmac-after-mptcp_finish_join.patch +rdma-srp-fix-a-recently-introduced-memory-leak.patch +rdma-rtrs-clt-check-state-of-the-rtrs_clt_sess-befor.patch +rdma-rtrs-do-not-reset-hb_missed_max-after-re-connec.patch +rdma-rtrs-srv-fix-memory-leak-of-unfreed-rtrs_srv_st.patch +rdma-rtrs-srv-fix-memory-leak-when-having-multiple-s.patch +rdma-rtrs-clt-check-if-the-queue_depth-has-changed-d.patch +rdma-rtrs-clt-fix-memory-leak-of-not-freed-sess-stat.patch +ehea-fix-error-return-code-in-ehea_restart_qps.patch +clk-tegra30-use-300mhz-for-video-decoder-by-default.patch +xfrm-remove-the-fragment-check-for-ipv6-beet-mode.patch +net-sched-act_vlan-fix-modify-to-allow-0.patch +rdma-core-sanitize-wq-state-received-from-the-usersp.patch +drm-pl111-depend-on-config_vexpress_config.patch +rdma-rxe-fix-failure-during-driver-load.patch +drm-pl111-actually-fix-config_vexpress_config-depend.patch +drm-vc4-hdmi-fix-error-path-of-hpd-gpios.patch +clk-vc5-fix-output-disabling-when-enabling-a-fod.patch +drm-qxl-ensure-surf.data-is-ininitialized.patch +tools-bpftool-fix-error-return-code-in-do_batch.patch +ath10k-go-to-path-err_unsupported-when-chip-id-is-no.patch +ath10k-add-missing-error-return-code-in-ath10k_pci_p.patch +wireless-carl9170-fix-leds-build-errors-warnings.patch +ieee802154-hwsim-fix-possible-memory-leak-in-hwsim_s.patch +clk-imx8mq-remove-sys-pll-1-2-clock-gates.patch +wcn36xx-move-hal_buf-allocation-to-devm_kmalloc-in-p.patch +ssb-fix-error-return-code-in-ssb_bus_scan.patch +brcmfmac-fix-setting-of-station-info-chains-bitmask.patch +brcmfmac-correctly-report-average-rssi-in-station-in.patch +brcmfmac-fix-a-double-free-in-brcmf_sdio_bus_reset.patch +brcmsmac-mac80211_if-fix-a-resource-leak-in-an-error.patch +cw1200-revert-unnecessary-patches-that-fix-unreal-us.patch +ath11k-fix-an-error-handling-path-in-ath11k_core_fet.patch +ath10k-fix-an-error-code-in-ath10k_add_interface.patch +ath11k-send-beacon-template-after-vdev_start-restart.patch +netlabel-fix-memory-leak-in-netlbl_mgmt_add_common.patch +rdma-mlx5-don-t-add-slave-port-to-unaffiliated-list.patch +netfilter-nft_exthdr-check-for-ipv6-packet-before-fu.patch +netfilter-nft_osf-check-for-tcp-packet-before-furthe.patch +netfilter-nft_tproxy-restrict-support-to-tcp-and-udp.patch +rdma-rxe-fix-qp-reference-counting-for-atomic-ops.patch +selftests-bpf-whitelist-test_progs.h-from-.gitignore.patch +xsk-fix-missing-validation-for-skb-and-unaligned-mod.patch +xsk-fix-broken-tx-ring-validation.patch +bpf-fix-libelf-endian-handling-in-resolv_btfids.patch +rdma-rtrs-srv-set-minimal-max_send_wr-and-max_recv_w.patch +samples-bpf-fix-segmentation-fault-for-xdp_redirect-.patch +samples-bpf-fix-the-error-return-code-of-xdp_redirec.patch +mt76-fix-possible-null-pointer-dereference-in-mt76_t.patch +mt76-mt7615-fix-null-pointer-dereference-in-tx_prepa.patch +net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch +net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch +net-ethernet-ezchip-fix-error-handling.patch +vrf-do-not-push-non-nd-strict-packets-with-a-source-.patch +net-sched-add-barrier-to-ensure-correct-ordering-for.patch +tls-prevent-oversized-sendfile-hangs-by-ignoring-msg.patch +netfilter-nf_tables_offload-check-flow_dissector_key.patch +pkt_sched-sch_qfq-fix-qfq_change_class-error-path.patch +xfrm-fix-xfrm-offload-fallback-fail-case.patch +iwlwifi-increase-pnvm-load-timeout.patch +rtw88-8822c-fix-lc-calibration-timing.patch +vxlan-add-missing-rcu_read_lock-in-neigh_reduce.patch +ip6_tunnel-fix-gre6-segmentation.patch +net-ipv4-swap-flow-ports-when-validating-source.patch +net-ti-am65-cpsw-nuss-fix-crash-when-changing-number.patch +tc-testing-fix-list-handling.patch +ieee802154-hwsim-fix-memory-leak-in-hwsim_add_one.patch +ieee802154-hwsim-avoid-possible-crash-in-hwsim_del_e.patch +bpf-fix-null-ptr-deref-with-mixed-tail-calls-and-sub.patch +drm-msm-fix-error-return-code-in-msm_drm_init.patch +drm-msm-dpu-fix-error-return-code-in-dpu_mdss_init.patch +mac80211-remove-iwlwifi-specific-workaround-ndps-of-.patch +net-bcmgenet-fix-attaching-to-pyh-failed-on-rpi-4b.patch +ipv6-exthdrs-do-not-blindly-use-init_net.patch +can-j1939-j1939_sk_setsockopt-prevent-allocation-of-.patch +bpf-do-not-change-gso_size-during-bpf_skb_change_pro.patch +i40e-fix-error-handling-in-i40e_vsi_open.patch +i40e-fix-autoneg-disabling-for-non-10gbaset-links.patch +i40e-fix-missing-rtnl-locking-when-setting-up-pf-swi.patch +revert-ibmvnic-remove-duplicate-napi_schedule-call-i.patch +ibmvnic-set-ltb-buff-to-null-after-freeing.patch +ibmvnic-free-tx_pool-if-tso_pool-alloc-fails.patch +rdma-cma-protect-rmw-with-qp_mutex.patch +net-macsec-fix-the-length-used-to-copy-the-key-for-o.patch +net-phy-mscc-fix-macsec-key-length.patch +net-atlantic-fix-the-macsec-key-length.patch +ipv6-fix-out-of-bound-access-in-ip6_parse_tlv.patch +e1000e-check-the-pcim-state.patch +net-dsa-sja1105-fix-null-pointer-dereference-in-sja1.patch +bpfilter-specify-the-log-level-for-the-kmsg-message.patch +rdma-cma-fix-incorrect-packet-lifetime-calculation.patch +gve-fix-swapped-vars-when-fetching-max-queues.patch +revert-be2net-disable-bh-with-spin_lock-in-be_proces.patch +bluetooth-mgmt-fix-slab-out-of-bounds-in-tlv_data_is.patch +bluetooth-fix-not-sending-set-extended-scan-response.patch +bluetooth-fix-set-extended-scan-response-data.patch +bluetooth-fix-handling-of-hci_le_advertising_set_ter.patch +clk-actions-fix-uart-clock-dividers-on-owl-s500-soc.patch +clk-actions-fix-sd-clocks-factor-table-on-owl-s500-s.patch +clk-actions-fix-bisp_factor_table-based-clocks-on-ow.patch +clk-actions-fix-ahpprediv-h-ahb-clock-chain-on-owl-s.patch +clk-qcom-clk-alpha-pll-fix-cal_l-write-in-alpha_pll_.patch +clk-si5341-wait-for-device_ready-on-startup.patch +clk-si5341-avoid-divide-errors-due-to-bogus-register.patch +clk-si5341-check-for-input-clock-presence-and-pll-lo.patch +clk-si5341-update-initialization-magic.patch +writeback-fix-obtain-a-reference-to-a-freeing-memcg-.patch +net-lwtunnel-handle-mtu-calculation-in-forwading.patch +net-sched-fix-warning-in-tcindex_alloc_perfect_hash.patch +net-tipc-fix-fb_mtu-eat-two-pages.patch +rdma-mlx5-don-t-access-null-cleared-mpi-pointer.patch +rdma-core-always-release-restrack-object.patch +mips-fix-pkmap-with-32-bit-mips-huge-page-support.patch +staging-fbtft-rectify-gpio-handling.patch +staging-fbtft-don-t-spam-logs-when-probe-is-deferred.patch +asoc-rt5682-disable-irq-on-shutdown.patch +rcu-invoke-rcu_spawn_core_kthreads-from-rcu_spawn_gp.patch +serial-fsl_lpuart-don-t-modify-arbitrary-data-on-lpu.patch +serial-fsl_lpuart-remove-rtscts-handling-from-get_mc.patch +serial-8250_omap-fix-a-timeout-loop-condition.patch +tty-nozomi-fix-a-resource-leak-in-an-error-handling-.patch +mwifiex-re-fix-for-unaligned-accesses.patch +iio-adis_buffer-do-not-return-ints-in-irq-handlers.patch +iio-adis16400-do-not-return-ints-in-irq-handlers.patch +iio-adis16475-do-not-return-ints-in-irq-handlers.patch +iio-accel-bma180-fix-buffer-alignment-in-iio_push_to.patch +iio-accel-bma220-fix-buffer-alignment-in-iio_push_to.patch +iio-accel-hid-fix-buffer-alignment-in-iio_push_to_bu.patch +iio-accel-kxcjk-1013-fix-buffer-alignment-in-iio_pus.patch +iio-accel-mxc4005-fix-overread-of-data-and-alignment.patch +iio-accel-stk8312-fix-buffer-alignment-in-iio_push_t.patch +iio-accel-stk8ba50-fix-buffer-alignment-in-iio_push_.patch +iio-adc-ti-ads1015-fix-buffer-alignment-in-iio_push_.patch +iio-adc-vf610-fix-buffer-alignment-in-iio_push_to_bu.patch +iio-gyro-bmg160-fix-buffer-alignment-in-iio_push_to_.patch +iio-humidity-am2315-fix-buffer-alignment-in-iio_push.patch +iio-prox-srf08-fix-buffer-alignment-in-iio_push_to_b.patch +iio-prox-pulsed-light-fix-buffer-alignment-in-iio_pu.patch +iio-prox-as3935-fix-buffer-alignment-in-iio_push_to_.patch +iio-magn-hmc5843-fix-buffer-alignment-in-iio_push_to.patch +iio-magn-bmc150-fix-buffer-alignment-in-iio_push_to_.patch +iio-light-isl29125-fix-buffer-alignment-in-iio_push_.patch +iio-light-tcs3414-fix-buffer-alignment-in-iio_push_t.patch +iio-light-tcs3472-fix-buffer-alignment-in-iio_push_t.patch +iio-chemical-atlas-fix-buffer-alignment-in-iio_push_.patch +iio-cros_ec_sensors-fix-alignment-of-buffer-in-iio_p.patch +iio-potentiostat-lmp91000-fix-alignment-of-buffer-in.patch +asoc-rk3328-fix-missing-clk_disable_unprepare-on-err.patch +asoc-hisilicon-fix-missing-clk_disable_unprepare-on-.patch +backlight-lm3630a_bl-put-fwnode-in-error-case-during.patch +asoc-rsnd-tidyup-loop-on-rsnd_adg_clk_query.patch +input-hil_kbd-fix-error-return-code-in-hil_dev_conne.patch +perf-scripting-python-fix-tuple_set_u64.patch +mtd-partitions-redboot-seek-fis-index-block-in-the-r.patch +mtd-rawnand-arasan-ensure-proper-configuration-for-t.patch +staging-mmal-vchiq-fix-incorrect-static-vchiq_instan.patch +char-pcmcia-error-out-if-num_bytes_read-is-greater-t.patch +firmware-stratix10-svc-fix-a-resource-leak-in-an-err.patch +tty-nozomi-fix-the-error-handling-path-of-nozomi_car.patch +leds-class-the-enotsupp-should-never-be-seen-by-user.patch +leds-lm3532-select-regmap-i2c-api.patch +leds-lm36274-put-fwnode-in-error-case-during-probe.patch +leds-lm3692x-put-fwnode-in-any-case-during-probe.patch +leds-lm3697-don-t-spam-logs-when-probe-is-deferred.patch +leds-lp50xx-put-fwnode-in-error-case-during-probe.patch +scsi-flashpoint-rename-si_flags-field.patch +scsi-iscsi-flush-block-work-before-unblock.patch +mfd-mp2629-select-mfd_core-to-fix-build-error.patch +mfd-rn5t618-fix-irq-trigger-by-changing-it-to-level-.patch +fsi-core-fix-return-of-error-values-on-failures.patch +fsi-scom-reset-the-fsi2pib-engine-for-any-error.patch +fsi-occ-don-t-accept-response-from-un-initialized-oc.patch +fsi-sbefifo-clean-up-correct-fifo-when-receiving-res.patch +fsi-sbefifo-fix-reset-timeout.patch +visorbus-fix-error-return-code-in-visorchipset_init.patch +iommu-amd-fix-extended-features-logging.patch +s390-irq-select-have_irq_exit_on_irq_stack.patch +s390-enable-have_ioremap_prot.patch +s390-appldata-depends-on-proc_sysctl.patch +selftests-splice-adjust-for-handler-fallback-removal.patch +iommu-dma-fix-iova-reserve-dma-ranges.patch +asoc-max98373-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt1308-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt5682-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt700-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt711-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt715-sdw-use-first_hw_init-flag-on-resume.patch +asoc-rt5682-fix-getting-the-wrong-device-id-when-the.patch +asoc-rt5682-sdw-set-regcache_cache_only-false-before.patch +asoc-mediatek-mtk-btcvsd-fix-an-error-handling-path-.patch +usb-gadget-f_fs-fix-setting-of-device-and-driver-dat.patch +usb-dwc2-don-t-reset-the-core-after-setting-turnarou.patch +eeprom-idt_89hpesx-put-fwnode-in-matching-case-durin.patch +eeprom-idt_89hpesx-restore-printing-the-unsupported-.patch +thunderbolt-bond-lanes-only-when-dual_link_port-null.patch +iio-adc-at91-sama5d2-fix-buffer-alignment-in-iio_pus.patch +iio-adc-hx711-fix-buffer-alignment-in-iio_push_to_bu.patch +iio-adc-mxs-lradc-fix-buffer-alignment-in-iio_push_t.patch +iio-adc-ti-ads8688-fix-alignment-of-buffer-in-iio_pu.patch +iio-magn-rm3100-fix-alignment-of-buffer-in-iio_push_.patch +iio-light-vcnl4000-fix-buffer-alignment-in-iio_push_.patch +asoc-fsl_spdif-fix-error-handler-with-pm_runtime_ena.patch +staging-gdm724x-check-for-buffer-overflow-in-gdm_lte.patch +staging-gdm724x-check-for-overflow-in-gdm_lte_netif_.patch +staging-rtl8712-fix-error-handling-in-r871xu_drv_ini.patch +staging-rtl8712-fix-memory-leak-in-rtl871x_load_fw_c.patch +coresight-core-fix-use-of-uninitialized-pointer.patch +staging-mt7621-dts-fix-pci-address-for-pci-memory-ra.patch +serial-8250-actually-allow-upf_magic_multiplier-baud.patch +iio-light-vcnl4035-fix-buffer-alignment-in-iio_push_.patch +iio-prox-isl29501-fix-buffer-alignment-in-iio_push_t.patch +asoc-cs42l42-correct-definition-of-cs42l42_adc_pdn_m.patch +of-fix-truncation-of-memory-sizes-on-32-bit-platform.patch +mtd-rawnand-marvell-add-missing-clk_disable_unprepar.patch +habanalabs-fix-an-error-handling-path-in-hl_pci_prob.patch +scsi-mpt3sas-fix-error-return-value-in-_scsih_expand.patch +soundwire-stream-fix-test-for-dp-prepare-complete.patch +phy-uniphier-pcie-fix-updating-phy-parameters.patch +phy-ti-dm816x-fix-the-error-handling-path-in-dm816x_.patch +extcon-sm5502-drop-invalid-register-write-in-sm5502_.patch +extcon-max8997-add-missing-modalias-string.patch +powerpc-powernv-fix-machine-check-reporting-of-async.patch +asoc-atmel-i2s-fix-usage-of-capture-and-playback-at-.patch +configfs-fix-memleak-in-configfs_release_bin_file.patch +asoc-intel-sof_sdw-add-sof_rt715_dai_id_fix-for-alde.patch +asoc-intel-sof_sdw-add-quirk-support-for-brya-and-bt.patch +asoc-intel-sof_sdw-use-mach-data-for-adl-rvp-dmic-co.patch +asoc-fsl_spdif-fix-unexpected-interrupt-after-suspen.patch +leds-as3645a-fix-error-return-code-in-as3645a_parse_.patch +leds-ktd2692-fix-an-error-handling-path.patch +selftests-ftrace-fix-event-no-pid-on-1-core-machine.patch +serial-8250-8250_omap-disable-rx-interrupt-after-dma.patch +serial-8250-8250_omap-fix-possible-interrupt-storm-o.patch +powerpc-offline-cpu-in-stop_this_cpu.patch +powerpc-papr_scm-properly-handle-uuid-types-and-api.patch +powerpc-64s-fix-copy-paste-data-exposure-into-newly-.patch +powerpc-papr_scm-make-perf_stats-invisible-if-perf-s.patch +alsa-firewire-lib-fix-amdtp_domain_start-when-no-amd.patch +serial-mvebu-uart-do-not-allow-changing-baudrate-whe.patch +serial-mvebu-uart-correctly-calculate-minimal-possib.patch +arm64-dts-marvell-armada-37xx-fix-reg-for-standard-v.patch +vfio-pci-handle-concurrent-vma-faults.patch +mm-pmem-avoid-inserting-hugepage-pte-entry-with-fsda.patch +mm-huge_memory.c-remove-dedicated-macro-hpage_cache_.patch +mm-huge_memory.c-add-missing-read-only-thp-checking-.patch +mm-huge_memory.c-don-t-discard-hugepage-if-other-pro.patch +mm-hugetlb-use-helper-huge_page_order-and-pages_per_.patch +mm-hugetlb-remove-redundant-check-in-preparing-and-d.patch +hugetlb-remove-prep_compound_huge_page-cleanup.patch +hugetlb-address-ref-count-racing-in-prep_compound_gi.patch +include-linux-huge_mm.h-remove-extern-keyword.patch +mm-z3fold-fix-potential-memory-leak-in-z3fold_destro.patch +mm-z3fold-use-release_z3fold_page_locked-to-release-.patch +lib-math-rational.c-fix-divide-by-zero.patch +selftests-vm-pkeys-fix-alloc_random_pkey-to-make-it-.patch +selftests-vm-pkeys-handle-negative-sys_pkey_alloc-re.patch +selftests-vm-pkeys-refill-shadow-register-after-impl.patch +perf-llvm-return-enomem-when-asprintf-fails.patch +csky-fix-syscache.c-fallthrough-warning.patch +csky-syscache-fixup-duplicate-cache-flush.patch diff --git a/queue-5.10/soundwire-stream-fix-test-for-dp-prepare-complete.patch b/queue-5.10/soundwire-stream-fix-test-for-dp-prepare-complete.patch new file mode 100644 index 00000000000..8fca09aa3b6 --- /dev/null +++ b/queue-5.10/soundwire-stream-fix-test-for-dp-prepare-complete.patch @@ -0,0 +1,70 @@ +From ef8caea50b470ae7052bdacbc6265e75ebdace88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 18 Jun 2021 15:47:45 +0100 +Subject: soundwire: stream: Fix test for DP prepare complete + +From: Richard Fitzgerald + +[ Upstream commit 3d3e88e336338834086278236d42039f3cde50e1 ] + +In sdw_prep_deprep_slave_ports(), after the wait_for_completion() +the DP prepare status register is read. If this indicates that the +port is now prepared, the code should continue with the port setup. +It is irrelevant whether the wait_for_completion() timed out if the +port is now ready. + +The previous implementation would always fail if the +wait_for_completion() timed out, even if the port was reporting +successful prepare. + +This patch also fixes a minor bug where the return from sdw_read() +was not checked for error - any error code with LSBits clear could +be misinterpreted as a successful port prepare. + +Fixes: 79df15b7d37c ("soundwire: Add helpers for ports operations") +Signed-off-by: Richard Fitzgerald +Reviewed-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20210618144745.30629-1-rf@opensource.cirrus.com +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/soundwire/stream.c | 13 ++++++------- + 1 file changed, 6 insertions(+), 7 deletions(-) + +diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c +index a418c3c7001c..304ff2ee7d75 100644 +--- a/drivers/soundwire/stream.c ++++ b/drivers/soundwire/stream.c +@@ -422,7 +422,6 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus, + struct completion *port_ready; + struct sdw_dpn_prop *dpn_prop; + struct sdw_prepare_ch prep_ch; +- unsigned int time_left; + bool intr = false; + int ret = 0, val; + u32 addr; +@@ -479,15 +478,15 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus, + + /* Wait for completion on port ready */ + port_ready = &s_rt->slave->port_ready[prep_ch.num]; +- time_left = wait_for_completion_timeout(port_ready, +- msecs_to_jiffies(dpn_prop->ch_prep_timeout)); ++ wait_for_completion_timeout(port_ready, ++ msecs_to_jiffies(dpn_prop->ch_prep_timeout)); + + val = sdw_read(s_rt->slave, SDW_DPN_PREPARESTATUS(p_rt->num)); +- val &= p_rt->ch_mask; +- if (!time_left || val) { ++ if ((val < 0) || (val & p_rt->ch_mask)) { ++ ret = (val < 0) ? val : -ETIMEDOUT; + dev_err(&s_rt->slave->dev, +- "Chn prep failed for port:%d\n", prep_ch.num); +- return -ETIMEDOUT; ++ "Chn prep failed for port %d: %d\n", prep_ch.num, ret); ++ return ret; + } + } + +-- +2.30.2 + diff --git a/queue-5.10/spi-allow-to-have-all-native-css-in-use-along-with-g.patch b/queue-5.10/spi-allow-to-have-all-native-css-in-use-along-with-g.patch new file mode 100644 index 00000000000..b2e9baa1d84 --- /dev/null +++ b/queue-5.10/spi-allow-to-have-all-native-css-in-use-along-with-g.patch @@ -0,0 +1,53 @@ +From 26f02d1df85087af80830720cbc5792e009c76ee Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 20 Apr 2021 19:44:24 +0300 +Subject: spi: Allow to have all native CSs in use along with GPIOs + +From: Andy Shevchenko + +[ Upstream commit dbaca8e56ea3f23fa215f48c2d46dd03ede06e02 ] + +The commit 7d93aecdb58d ("spi: Add generic support for unused native cs +with cs-gpios") excludes the valid case for the controllers that doesn't +need to switch native CS in order to perform the transfer, i.e. when + + 0 native + ... ... + - 1 native + GPIO + + 1 GPIO + ... ... + +where defines maximum of native CSs supported by the controller. + +To allow this, bail out from spi_get_gpio_descs() conditionally for +the controllers which explicitly marked with SPI_MASTER_GPIO_SS. + +Fixes: 7d93aecdb58d ("spi: Add generic support for unused native cs with cs-gpios") +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210420164425.40287-1-andriy.shevchenko@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c +index bd8b1f79dce2..a1a85f0baf7c 100644 +--- a/drivers/spi/spi.c ++++ b/drivers/spi/spi.c +@@ -2615,8 +2615,9 @@ static int spi_get_gpio_descs(struct spi_controller *ctlr) + } + + ctlr->unused_native_cs = ffz(native_cs_mask); +- if (num_cs_gpios && ctlr->max_native_cs && +- ctlr->unused_native_cs >= ctlr->max_native_cs) { ++ ++ if ((ctlr->flags & SPI_MASTER_GPIO_SS) && num_cs_gpios && ++ ctlr->max_native_cs && ctlr->unused_native_cs >= ctlr->max_native_cs) { + dev_err(dev, "No unused native chip select available\n"); + return -EINVAL; + } +-- +2.30.2 + diff --git a/queue-5.10/spi-avoid-undefined-behaviour-when-counting-unused-n.patch b/queue-5.10/spi-avoid-undefined-behaviour-when-counting-unused-n.patch new file mode 100644 index 00000000000..e0a704394a7 --- /dev/null +++ b/queue-5.10/spi-avoid-undefined-behaviour-when-counting-unused-n.patch @@ -0,0 +1,38 @@ +From a97c2a412056b9110611a9dac1f1af1472212488 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 20 Apr 2021 19:44:25 +0300 +Subject: spi: Avoid undefined behaviour when counting unused native CSs + +From: Andy Shevchenko + +[ Upstream commit f60d7270c8a3d2beb1c23ae0da42497afa3584c2 ] + +ffz(), that has been used to count unused native CSs, +might cause undefined behaviour when called against ~0U. +To fix that, open code it with ffs(~value) - 1. + +Fixes: 7d93aecdb58d ("spi: Add generic support for unused native cs with cs-gpios") +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210420164425.40287-2-andriy.shevchenko@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c +index a1a85f0baf7c..8c261eac2cee 100644 +--- a/drivers/spi/spi.c ++++ b/drivers/spi/spi.c +@@ -2614,7 +2614,7 @@ static int spi_get_gpio_descs(struct spi_controller *ctlr) + native_cs_mask |= BIT(i); + } + +- ctlr->unused_native_cs = ffz(native_cs_mask); ++ ctlr->unused_native_cs = ffs(~native_cs_mask) - 1; + + if ((ctlr->flags & SPI_MASTER_GPIO_SS) && num_cs_gpios && + ctlr->max_native_cs && ctlr->unused_native_cs >= ctlr->max_native_cs) { +-- +2.30.2 + diff --git a/queue-5.10/spi-make-of_register_spi_device-also-set-the-fwnode.patch b/queue-5.10/spi-make-of_register_spi_device-also-set-the-fwnode.patch new file mode 100644 index 00000000000..f1158320a4f --- /dev/null +++ b/queue-5.10/spi-make-of_register_spi_device-also-set-the-fwnode.patch @@ -0,0 +1,62 @@ +From 09838f0b01f5bccd4f33dbc4db6bc35e65eef592 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 21 Apr 2021 11:14:02 +0100 +Subject: spi: Make of_register_spi_device also set the fwnode + +From: Charles Keepax + +[ Upstream commit 0e793ba77c18382f08e440260fe72bc6fce2a3cb ] + +Currently, the SPI core doesn't set the struct device fwnode pointer +when it creates a new SPI device. This means when the device is +registered the fwnode is NULL and the check in device_add which sets +the fwnode->dev pointer is skipped. This wasn't previously an issue, +however these two patches: + +commit 4731210c09f5 ("gpiolib: Bind gpio_device to a driver to enable +fw_devlink=on by default") +commit ced2af419528 ("gpiolib: Don't probe gpio_device if it's not the +primary device") + +Added some code to the GPIO core which relies on using that +fwnode->dev pointer to determine if a driver is bound to the fwnode +and if not bind a stub GPIO driver. This means the GPIO providers +behind SPI will get both the expected driver and this stub driver +causing the stub driver to fail if it attempts to request any pin +configuration. For example on my system: + +madera-pinctrl madera-pinctrl: pin gpio5 already requested by madera-pinctrl; cannot claim for gpiochip3 +madera-pinctrl madera-pinctrl: pin-4 (gpiochip3) status -22 +madera-pinctrl madera-pinctrl: could not request pin 4 (gpio5) from group aif1 on device madera-pinctrl +gpio_stub_drv gpiochip3: Error applying setting, reverse things back +gpio_stub_drv: probe of gpiochip3 failed with error -22 + +The firmware node on the device created by the GPIO framework is set +through the of_node pointer hence things generally actually work, +however that fwnode->dev is never set, as the check was skipped at +device_add time. This fix appears to match how the I2C subsystem +handles the same situation. + +Signed-off-by: Charles Keepax +Link: https://lore.kernel.org/r/20210421101402.8468-1-ckeepax@opensource.cirrus.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c +index 0cf67de741e7..bd8b1f79dce2 100644 +--- a/drivers/spi/spi.c ++++ b/drivers/spi/spi.c +@@ -2050,6 +2050,7 @@ of_register_spi_device(struct spi_controller *ctlr, struct device_node *nc) + /* Store a pointer to the node in the device structure */ + of_node_get(nc); + spi->dev.of_node = nc; ++ spi->dev.fwnode = of_fwnode_handle(nc); + + /* Register the new device */ + rc = spi_add_device(spi); +-- +2.30.2 + diff --git a/queue-5.10/spi-meson-spicc-fix-a-wrong-goto-jump-for-avoiding-m.patch b/queue-5.10/spi-meson-spicc-fix-a-wrong-goto-jump-for-avoiding-m.patch new file mode 100644 index 00000000000..48efdbd3438 --- /dev/null +++ b/queue-5.10/spi-meson-spicc-fix-a-wrong-goto-jump-for-avoiding-m.patch @@ -0,0 +1,50 @@ +From 3ef8e98d77e4fe6875695f880d76a486a4a7d915 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 13:29:32 +0800 +Subject: spi: meson-spicc: fix a wrong goto jump for avoiding memory leak. + +From: zpershuai + +[ Upstream commit 95730d5eb73170a6d225a9998c478be273598634 ] + +In meson_spifc_probe function, when enable the device pclk clock is +error, it should use clk_disable_unprepare to release the core clock. + +Signed-off-by: zpershuai +Reviewed-by: Neil Armstrong +Link: https://lore.kernel.org/r/1623562172-22056-1-git-send-email-zpershuai@gmail.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-meson-spicc.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c +index ecba6b4a5d85..51aef2c6e966 100644 +--- a/drivers/spi/spi-meson-spicc.c ++++ b/drivers/spi/spi-meson-spicc.c +@@ -725,7 +725,7 @@ static int meson_spicc_probe(struct platform_device *pdev) + ret = clk_prepare_enable(spicc->pclk); + if (ret) { + dev_err(&pdev->dev, "pclk clock enable failed\n"); +- goto out_master; ++ goto out_core_clk; + } + + device_reset_optional(&pdev->dev); +@@ -764,9 +764,11 @@ static int meson_spicc_probe(struct platform_device *pdev) + return 0; + + out_clk: +- clk_disable_unprepare(spicc->core); + clk_disable_unprepare(spicc->pclk); + ++out_core_clk: ++ clk_disable_unprepare(spicc->core); ++ + out_master: + spi_master_put(master); + +-- +2.30.2 + diff --git a/queue-5.10/spi-meson-spicc-fix-memory-leak-in-meson_spicc_probe.patch b/queue-5.10/spi-meson-spicc-fix-memory-leak-in-meson_spicc_probe.patch new file mode 100644 index 00000000000..ac81c06d8b3 --- /dev/null +++ b/queue-5.10/spi-meson-spicc-fix-memory-leak-in-meson_spicc_probe.patch @@ -0,0 +1,37 @@ +From 41dd73ffae5d7c0809e5b6f1719a9bc4e7a7d55b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Jun 2021 13:29:16 +0800 +Subject: spi: meson-spicc: fix memory leak in meson_spicc_probe + +From: zpershuai + +[ Upstream commit b2d501c13470409ee7613855b17e5e5ec4111e1c ] + +when meson_spicc_clk_init returns failed, it should goto the +out_clk label. + +Signed-off-by: zpershuai +Reviewed-by: Neil Armstrong +Link: https://lore.kernel.org/r/1623562156-21995-1-git-send-email-zpershuai@gmail.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-meson-spicc.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c +index 51aef2c6e966..b2c4621db34d 100644 +--- a/drivers/spi/spi-meson-spicc.c ++++ b/drivers/spi/spi-meson-spicc.c +@@ -752,7 +752,7 @@ static int meson_spicc_probe(struct platform_device *pdev) + ret = meson_spicc_clk_init(spicc); + if (ret) { + dev_err(&pdev->dev, "clock registration failed\n"); +- goto out_master; ++ goto out_clk; + } + + ret = devm_spi_register_master(&pdev->dev, master); +-- +2.30.2 + diff --git a/queue-5.10/spi-omap-100k-fix-the-length-judgment-problem.patch b/queue-5.10/spi-omap-100k-fix-the-length-judgment-problem.patch new file mode 100644 index 00000000000..ae06ce9144c --- /dev/null +++ b/queue-5.10/spi-omap-100k-fix-the-length-judgment-problem.patch @@ -0,0 +1,36 @@ +From 7c6bdf2f183807dd06169f190c6e84b1b073b463 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 29 Apr 2021 19:20:48 +0800 +Subject: spi: omap-100k: Fix the length judgment problem + +From: Tian Tao + +[ Upstream commit e7a1a3abea373e41ba7dfe0fbc93cb79b6a3a529 ] + +word_len should be checked in the omap1_spi100k_setup_transfer +function to see if it exceeds 32. + +Signed-off-by: Tian Tao +Link: https://lore.kernel.org/r/1619695248-39045-1-git-send-email-tiantao6@hisilicon.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-omap-100k.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c +index ccd817ee4917..0d0cd061d356 100644 +--- a/drivers/spi/spi-omap-100k.c ++++ b/drivers/spi/spi-omap-100k.c +@@ -241,7 +241,7 @@ static int omap1_spi100k_setup_transfer(struct spi_device *spi, + else + word_len = spi->bits_per_word; + +- if (spi->bits_per_word > 32) ++ if (word_len > 32) + return -EINVAL; + cs->word_len = word_len; + +-- +2.30.2 + diff --git a/queue-5.10/spi-spi-loopback-test-fix-tx_buf-might-be-rx_buf.patch b/queue-5.10/spi-spi-loopback-test-fix-tx_buf-might-be-rx_buf.patch new file mode 100644 index 00000000000..26e8ea5f11d --- /dev/null +++ b/queue-5.10/spi-spi-loopback-test-fix-tx_buf-might-be-rx_buf.patch @@ -0,0 +1,35 @@ +From 5fb3227efbdf1c05ae00f62e326404cc51f39a77 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 10 May 2021 14:58:23 +0800 +Subject: spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf' + +From: Jay Fang + +[ Upstream commit 9e37a3ab0627011fb63875e9a93094b6fc8ddf48 ] + +In function 'spi_test_run_iter': Value 'tx_buf' might be 'rx_buf'. + +Signed-off-by: Jay Fang +Link: https://lore.kernel.org/r/1620629903-15493-5-git-send-email-f.fangjian@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-loopback-test.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c +index df981e55c24c..89b91cdfb2a5 100644 +--- a/drivers/spi/spi-loopback-test.c ++++ b/drivers/spi/spi-loopback-test.c +@@ -874,7 +874,7 @@ static int spi_test_run_iter(struct spi_device *spi, + test.transfers[i].len = len; + if (test.transfers[i].tx_buf) + test.transfers[i].tx_buf += tx_off; +- if (test.transfers[i].tx_buf) ++ if (test.transfers[i].rx_buf) + test.transfers[i].rx_buf += rx_off; + } + +-- +2.30.2 + diff --git a/queue-5.10/spi-spi-sun6i-fix-chipselect-clock-bug.patch b/queue-5.10/spi-spi-sun6i-fix-chipselect-clock-bug.patch new file mode 100644 index 00000000000..f4ed8d9a238 --- /dev/null +++ b/queue-5.10/spi-spi-sun6i-fix-chipselect-clock-bug.patch @@ -0,0 +1,56 @@ +From 59528088dd0cf69a8829add78b723f59d988703a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Jun 2021 16:45:07 +0200 +Subject: spi: spi-sun6i: Fix chipselect/clock bug + +From: Mirko Vogt + +[ Upstream commit 0d7993b234c9fad8cb6bec6adfaa74694ba85ecb ] + +The current sun6i SPI implementation initializes the transfer too early, +resulting in SCK going high before the transfer. When using an additional +(gpio) chipselect with sun6i, the chipselect is asserted at a time when +clock is high, making the SPI transfer fail. + +This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into +SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer +function, hence, right before the transfer starts, mitigates that +problem. + +Fixes: 3558fe900e8af (spi: sunxi: Add Allwinner A31 SPI controller driver) +Signed-off-by: Mirko Vogt +Signed-off-by: Ralf Schlatterbeck +Link: https://lore.kernel.org/r/20210614144507.y3udezjfbko7eavv@runtux.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-sun6i.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c +index 19238e1b76b4..803d92f8d031 100644 +--- a/drivers/spi/spi-sun6i.c ++++ b/drivers/spi/spi-sun6i.c +@@ -290,6 +290,10 @@ static int sun6i_spi_transfer_one(struct spi_master *master, + } + + sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg); ++ /* Finally enable the bus - doing so before might raise SCK to HIGH */ ++ reg = sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG); ++ reg |= SUN6I_GBL_CTL_BUS_ENABLE; ++ sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, reg); + + /* Setup the transfer now... */ + if (sspi->tx_buf) +@@ -398,7 +402,7 @@ static int sun6i_spi_runtime_resume(struct device *dev) + } + + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, +- SUN6I_GBL_CTL_BUS_ENABLE | SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); ++ SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); + + return 0; + +-- +2.30.2 + diff --git a/queue-5.10/spi-spi-topcliff-pch-fix-potential-double-free-in-pc.patch b/queue-5.10/spi-spi-topcliff-pch-fix-potential-double-free-in-pc.patch new file mode 100644 index 00000000000..2f0d9fa28e1 --- /dev/null +++ b/queue-5.10/spi-spi-topcliff-pch-fix-potential-double-free-in-pc.patch @@ -0,0 +1,42 @@ +From 92351003818c67d313b2fa8ebe9dcbdb8c77100f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 6 May 2021 15:08:08 +0800 +Subject: spi: spi-topcliff-pch: Fix potential double free in + pch_spi_process_messages() + +From: Jay Fang + +[ Upstream commit 026a1dc1af52742c5897e64a3431445371a71871 ] + +pch_spi_set_tx() frees data->pkt_tx_buff on failure of kzalloc() for +data->pkt_rx_buff, but its caller, pch_spi_process_messages(), will +free data->pkt_tx_buff again. Set data->pkt_tx_buff to NULL after +kfree() to avoid double free. + +Signed-off-by: Jay Fang +Link: https://lore.kernel.org/r/1620284888-65215-1-git-send-email-f.fangjian@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-topcliff-pch.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c +index b459e369079f..7fb020a1d66a 100644 +--- a/drivers/spi/spi-topcliff-pch.c ++++ b/drivers/spi/spi-topcliff-pch.c +@@ -580,8 +580,10 @@ static void pch_spi_set_tx(struct pch_spi_data *data, int *bpw) + data->pkt_tx_buff = kzalloc(size, GFP_KERNEL); + if (data->pkt_tx_buff != NULL) { + data->pkt_rx_buff = kzalloc(size, GFP_KERNEL); +- if (!data->pkt_rx_buff) ++ if (!data->pkt_rx_buff) { + kfree(data->pkt_tx_buff); ++ data->pkt_tx_buff = NULL; ++ } + } + + if (!data->pkt_rx_buff) { +-- +2.30.2 + diff --git a/queue-5.10/ssb-fix-error-return-code-in-ssb_bus_scan.patch b/queue-5.10/ssb-fix-error-return-code-in-ssb_bus_scan.patch new file mode 100644 index 00000000000..9286ef4abdd --- /dev/null +++ b/queue-5.10/ssb-fix-error-return-code-in-ssb_bus_scan.patch @@ -0,0 +1,41 @@ +From d515dbf1a44d7e9c053ace3db1ac92e8d04e12d5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 15 May 2021 15:29:49 +0800 +Subject: ssb: Fix error return code in ssb_bus_scan() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Zhen Lei + +[ Upstream commit 77a0989baa427dbd242c5784d05a53ca3d197d43 ] + +Fix to return -EINVAL from the error handling case instead of 0, as done +elsewhere in this function. + +Fixes: 61e115a56d1a ("[SSB]: add Sonics Silicon Backplane bus support") +Reported-by: Hulk Robot +Signed-off-by: Zhen Lei +Acked-by: Michael Büsch +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20210515072949.7151-1-thunder.leizhen@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/ssb/scan.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/ssb/scan.c b/drivers/ssb/scan.c +index f49ab1aa2149..4161e5d1f276 100644 +--- a/drivers/ssb/scan.c ++++ b/drivers/ssb/scan.c +@@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus, + if (bus->nr_devices > ARRAY_SIZE(bus->devices)) { + pr_err("More than %d ssb cores found (%d)\n", + SSB_MAX_NR_CORES, bus->nr_devices); ++ err = -EINVAL; + goto err_unmap; + } + if (bus->bustype == SSB_BUSTYPE_SSB) { +-- +2.30.2 + diff --git a/queue-5.10/staging-fbtft-don-t-spam-logs-when-probe-is-deferred.patch b/queue-5.10/staging-fbtft-don-t-spam-logs-when-probe-is-deferred.patch new file mode 100644 index 00000000000..96973c51545 --- /dev/null +++ b/queue-5.10/staging-fbtft-don-t-spam-logs-when-probe-is-deferred.patch @@ -0,0 +1,55 @@ +From 1f245bbfc98c53d719825d43e93bf995c76876ff Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 3 May 2021 20:21:11 +0300 +Subject: staging: fbtft: Don't spam logs when probe is deferred + +From: Andy Shevchenko + +[ Upstream commit 37667f6e57712cef5652fa67f1cbd1299e204d94 ] + +When requesting GPIO line the probe can be deferred. +In such case don't spam logs with an error message. +This can be achieved by switching to dev_err_probe(). + +Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") +Cc: Nishad Kamdar +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210503172114.27891-3-andriy.shevchenko@linux.intel.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/staging/fbtft/fbtft-core.c | 12 ++++-------- + 1 file changed, 4 insertions(+), 8 deletions(-) + +diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c +index 67c3b1975a4d..3723269890d5 100644 +--- a/drivers/staging/fbtft/fbtft-core.c ++++ b/drivers/staging/fbtft/fbtft-core.c +@@ -75,20 +75,16 @@ static int fbtft_request_one_gpio(struct fbtft_par *par, + struct gpio_desc **gpiop) + { + struct device *dev = par->info->device; +- int ret = 0; + + *gpiop = devm_gpiod_get_index_optional(dev, name, index, + GPIOD_OUT_LOW); +- if (IS_ERR(*gpiop)) { +- ret = PTR_ERR(*gpiop); +- dev_err(dev, +- "Failed to request %s GPIO: %d\n", name, ret); +- return ret; +- } ++ if (IS_ERR(*gpiop)) ++ return dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name); ++ + fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, "%s: '%s' GPIO\n", + __func__, name); + +- return ret; ++ return 0; + } + + static int fbtft_request_gpios(struct fbtft_par *par) +-- +2.30.2 + diff --git a/queue-5.10/staging-fbtft-rectify-gpio-handling.patch b/queue-5.10/staging-fbtft-rectify-gpio-handling.patch new file mode 100644 index 00000000000..33dd836dc92 --- /dev/null +++ b/queue-5.10/staging-fbtft-rectify-gpio-handling.patch @@ -0,0 +1,485 @@ +From d6df1f94bde17e816756511fbd59c55ba1cfca45 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 3 May 2021 20:21:10 +0300 +Subject: staging: fbtft: Rectify GPIO handling +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Andy Shevchenko + +[ Upstream commit ec03c2104365ead0a33627c05e685093eed3eaef ] + +The infamous commit c440eee1a7a1 ("Staging: staging: fbtft: Switch to +the GPIO descriptor interface") broke GPIO handling completely. +It has already four commits to rectify and it seems not enough. +In order to fix the mess here we: + + 1) Set default to "inactive" for all requested pins + + 2) Fix CS#, RD#, and WR# pins polarity since it's active low + and GPIO descriptor interface takes it into consideration + from the Device Tree or ACPI + + 3) Consolidate chip activation (CS# assertion) under default + ->reset() callback + +To summarize the expectations about polarity for GPIOs: + + RD# Low + WR# Low + CS# Low + RESET# Low + DC or RS High + RW High + Data 0 .. 15 High + +See also Adafruit learning course [1] for the example of the schematics. + +While at it, drop unneeded NULL checks, since GPIO API is tolerant to that. + +[1]: https://learn.adafruit.com/adafruit-2-8-and-3-2-color-tft-touchscreen-breakout-v2/downloads + +Fixes: 92e3e884887c ("Staging: fbtft: Fix GPIO handling") +Fixes: b918d1c27066 ("Staging: fbtft: Fix reset assertion when using gpio descriptor") +Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor") +Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") +Cc: Jan Sebastian Götte +Cc: Nishad Kamdar +Reviewed-by: Phil Reid +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20210503172114.27891-2-andriy.shevchenko@linux.intel.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/staging/fbtft/fb_agm1264k-fl.c | 20 ++++++++++---------- + drivers/staging/fbtft/fb_bd663474.c | 4 ---- + drivers/staging/fbtft/fb_ili9163.c | 4 ---- + drivers/staging/fbtft/fb_ili9320.c | 1 - + drivers/staging/fbtft/fb_ili9325.c | 4 ---- + drivers/staging/fbtft/fb_ili9340.c | 1 - + drivers/staging/fbtft/fb_s6d1121.c | 4 ---- + drivers/staging/fbtft/fb_sh1106.c | 1 - + drivers/staging/fbtft/fb_ssd1289.c | 4 ---- + drivers/staging/fbtft/fb_ssd1325.c | 2 -- + drivers/staging/fbtft/fb_ssd1331.c | 6 ++---- + drivers/staging/fbtft/fb_ssd1351.c | 1 - + drivers/staging/fbtft/fb_upd161704.c | 4 ---- + drivers/staging/fbtft/fb_watterott.c | 1 - + drivers/staging/fbtft/fbtft-bus.c | 3 +-- + drivers/staging/fbtft/fbtft-core.c | 13 ++++++------- + drivers/staging/fbtft/fbtft-io.c | 12 ++++++------ + 17 files changed, 25 insertions(+), 60 deletions(-) + +diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c +index eeeeec97ad27..b545c2ca80a4 100644 +--- a/drivers/staging/fbtft/fb_agm1264k-fl.c ++++ b/drivers/staging/fbtft/fb_agm1264k-fl.c +@@ -84,9 +84,9 @@ static void reset(struct fbtft_par *par) + + dev_dbg(par->info->device, "%s()\n", __func__); + +- gpiod_set_value(par->gpio.reset, 0); +- udelay(20); + gpiod_set_value(par->gpio.reset, 1); ++ udelay(20); ++ gpiod_set_value(par->gpio.reset, 0); + mdelay(120); + } + +@@ -194,12 +194,12 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...) + /* select chip */ + if (*buf) { + /* cs1 */ +- gpiod_set_value(par->CS0, 1); +- gpiod_set_value(par->CS1, 0); +- } else { +- /* cs0 */ + gpiod_set_value(par->CS0, 0); + gpiod_set_value(par->CS1, 1); ++ } else { ++ /* cs0 */ ++ gpiod_set_value(par->CS0, 1); ++ gpiod_set_value(par->CS1, 0); + } + + gpiod_set_value(par->RS, 0); /* RS->0 (command mode) */ +@@ -397,8 +397,8 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) + } + kfree(convert_buf); + +- gpiod_set_value(par->CS0, 1); +- gpiod_set_value(par->CS1, 1); ++ gpiod_set_value(par->CS0, 0); ++ gpiod_set_value(par->CS1, 0); + + return ret; + } +@@ -419,10 +419,10 @@ static int write(struct fbtft_par *par, void *buf, size_t len) + for (i = 0; i < 8; ++i) + gpiod_set_value(par->gpio.db[i], data & (1 << i)); + /* set E */ +- gpiod_set_value(par->EPIN, 1); ++ gpiod_set_value(par->EPIN, 0); + udelay(5); + /* unset E - write */ +- gpiod_set_value(par->EPIN, 0); ++ gpiod_set_value(par->EPIN, 1); + udelay(1); + } + +diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c +index e2c7646588f8..1629c2c440a9 100644 +--- a/drivers/staging/fbtft/fb_bd663474.c ++++ b/drivers/staging/fbtft/fb_bd663474.c +@@ -12,7 +12,6 @@ + #include + #include + #include +-#include + #include + + #include "fbtft.h" +@@ -24,9 +23,6 @@ + + static int init_display(struct fbtft_par *par) + { +- if (par->gpio.cs) +- gpiod_set_value(par->gpio.cs, 0); /* Activate chip */ +- + par->fbtftops.reset(par); + + /* Initialization sequence from Lib_UTFT */ +diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c +index 05648c3ffe47..6582a2c90aaf 100644 +--- a/drivers/staging/fbtft/fb_ili9163.c ++++ b/drivers/staging/fbtft/fb_ili9163.c +@@ -11,7 +11,6 @@ + #include + #include + #include +-#include + #include + #include