From 0afd9a9acab584e770ffcd6a0e1e02e2d18d360a Mon Sep 17 00:00:00 2001
From: Josef 'Jeff' Sipek <jeff.sipek@dovecot.fi>
Date: Tue, 12 Dec 2017 11:26:21 -0500
Subject: [PATCH] submission-login: remove unnecessary casts

Casting from a void * to any pointer type is automatic and doesn't
require an explicit cast.
---
 src/submission-login/client-authenticate.c |  9 +++------
 src/submission-login/client.c              | 15 +++++----------
 src/submission-login/submission-proxy.c    |  3 +--
 3 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/src/submission-login/client-authenticate.c b/src/submission-login/client-authenticate.c
index 67e879afe4..27ddf00742 100644
--- a/src/submission-login/client-authenticate.c
+++ b/src/submission-login/client-authenticate.c
@@ -71,8 +71,7 @@ static void cmd_helo_reply(struct submission_client *subm_client,
 int cmd_helo(void *conn_ctx, struct smtp_server_cmd_ctx *cmd,
 	     struct smtp_server_cmd_helo *data)
 {
-	struct submission_client *subm_client =
-		(struct submission_client *)conn_ctx;
+	struct submission_client *subm_client = conn_ctx;
 
 	T_BEGIN {
 		cmd_helo_reply(subm_client, cmd, data);
@@ -214,8 +213,7 @@ int cmd_auth_continue(void *conn_ctx,
 		      struct smtp_server_cmd_ctx *cmd ATTR_UNUSED,
 		      const char *response)
 {
-	struct submission_client *subm_client =
-		(struct submission_client *)conn_ctx;
+	struct submission_client *subm_client = conn_ctx;
 	struct client *client = &subm_client->common;
 
 	if (strcmp(response, "*") == 0) {
@@ -242,8 +240,7 @@ void submission_client_auth_send_challenge(struct client *client,
 int cmd_auth(void *conn_ctx, struct smtp_server_cmd_ctx *cmd,
 	     struct smtp_server_cmd_auth *data)
 {
-	struct submission_client *subm_client =
-		(struct submission_client *)conn_ctx;
+	struct submission_client *subm_client = conn_ctx;
 	struct client *client = &subm_client->common;
 	struct smtp_server_helo_data *helo;
 	char *prefix;
diff --git a/src/submission-login/client.c b/src/submission-login/client.c
index 5e942ab809..60d329dd1c 100644
--- a/src/submission-login/client.c
+++ b/src/submission-login/client.c
@@ -29,8 +29,7 @@ static struct smtp_server *smtp_server = NULL;
 static void submission_login_start_tls(void *conn_ctx,
 	struct istream **input, struct ostream **output)
 {
-	struct submission_client *subm_client =
-		(struct submission_client *)conn_ctx;
+	struct submission_client *subm_client = conn_ctx;
 	struct client *client = &subm_client->common;
 
 	client->starttls = TRUE;
@@ -135,8 +134,7 @@ client_connection_cmd_xclient(void *context,
 {
 	unsigned int i;
 
-	struct submission_client *client =
-		(struct submission_client *)context;
+	struct submission_client *client = context;
 
 	client->common.ip = data->source_ip;
 	client->common.remote_port = data->source_port;
@@ -172,16 +170,14 @@ client_connection_cmd_xclient(void *context,
 
 static void client_connection_disconnect(void *context, const char *reason)
 {
-	struct submission_client *client =
-		(struct submission_client *)context;
+	struct submission_client *client = context;
 
 	client_disconnect(&client->common, reason);
 }
 
 static void client_connection_destroy(void *context)
 {
-	struct submission_client *client =
-		(struct submission_client *)context;
+	struct submission_client *client = context;
 
 	if (client->conn == NULL)
 		return;
@@ -191,8 +187,7 @@ static void client_connection_destroy(void *context)
 
 static bool client_connection_is_trusted(void *context)
 {
-	struct submission_client *client =
-		(struct submission_client *)context;
+	struct submission_client *client = context;
 
 	return client->common.trusted;
 }
diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c
index 95774ff8e1..4ded03b742 100644
--- a/src/submission-login/submission-proxy.c
+++ b/src/submission-login/submission-proxy.c
@@ -208,8 +208,7 @@ strip_enhanced_code(const char *text, const char **enh_code_r)
 static void
 submission_proxy_success_reply_sent(struct smtp_server_cmd_ctx *cmd)
 {
-	struct submission_client *subm_client =
-		(struct submission_client *)cmd->context;
+	struct submission_client *subm_client = cmd->context;
 
 	client_proxy_finish_destroy_client(&subm_client->common);
 }
-- 
2.47.3