From 0c856224d202a7ad7ece25c77038ac3cafb7d56c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Carlo=20Marcelo=20Arenas=20Bel=C3=B3n?= Date: Thu, 26 Jun 2025 02:51:39 -0700 Subject: [PATCH] daemon: remove unnecesary restriction for listener fd MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available., 2005-07-23), any file descriptor assigned to a listening socket was validated to be within the range to be used in an FDSET later. 6573faff34 (NO_IPV6 support for git daemon, 2005-09-28), moves to use poll() instead of select(), that doesn't have that restriction, so remove the original check. Signed-off-by: Carlo Marcelo Arenas Belón Acked-by: Phillip Wood Signed-off-by: Junio C Hamano --- daemon.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/daemon.c b/daemon.c index d1be61fd57..99741f0b45 100644 --- a/daemon.c +++ b/daemon.c @@ -990,11 +990,6 @@ static int setup_named_sock(char *listen_addr, int listen_port, struct socketlis sockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol); if (sockfd < 0) continue; - if (sockfd >= FD_SETSIZE) { - logerror("Socket descriptor too large"); - close(sockfd); - continue; - } #ifdef IPV6_V6ONLY if (ai->ai_family == AF_INET6) { -- 2.47.2