From 0e393a31226205dd348b1fb1d80b1fb42513bbcf Mon Sep 17 00:00:00 2001 From: Evert Timberg Date: Sat, 9 Jan 2016 09:50:56 -0500 Subject: [PATCH] Update controllers --- src/controllers/controller.bar.js | 15 ++++----------- src/controllers/controller.line.js | 2 +- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/controllers/controller.bar.js b/src/controllers/controller.bar.js index 696b67ad8..1aca0df2e 100644 --- a/src/controllers/controller.bar.js +++ b/src/controllers/controller.bar.js @@ -139,14 +139,14 @@ if (value < 0) { for (var i = 0; i < datasetIndex; i++) { var negDS = this.chart.data.datasets[i]; - if (helpers.isDatasetVisible(negDS) && negDS.yAxisID === yScale.id) { + if (helpers.isDatasetVisible(negDS) && negDS.yAxisID === yScale.id && negDS.bar) { base += negDS.data[index] < 0 ? negDS.data[index] : 0; } } } else { for (var j = 0; j < datasetIndex; j++) { var posDS = this.chart.data.datasets[j]; - if (helpers.isDatasetVisible(posDS) && posDS.yAxisID === yScale.id) { + if (helpers.isDatasetVisible(posDS) && posDS.yAxisID === yScale.id && posDS.bar) { base += posDS.data[index] > 0 ? posDS.data[index] : 0; } } @@ -200,16 +200,9 @@ }, calculateBarWidth: function() { - var xScale = this.getScaleForId(this.getDataset().xAxisID); var ruler = this.getRuler(); - - if (xScale.options.stacked) { - return ruler.categoryWidth; - } - - return ruler.barWidth; - + return xScale.options.stacked ? ruler.categoryWidth : ruler.barWidth; }, // Get bar index from the given dataset index accounting for the fact that not all bars are visible @@ -261,7 +254,7 @@ for (var i = 0; i < datasetIndex; i++) { var ds = this.chart.data.datasets[i]; - if (helpers.isDatasetVisible(ds)) { + if (helpers.isDatasetVisible(ds) && ds.bar && ds.yAxisID === yScale.id) { if (ds.data[index] < 0) { sumNeg += ds.data[index] || 0; } else { diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js index 4776f7f73..3e87c9532 100644 --- a/src/controllers/controller.line.js +++ b/src/controllers/controller.line.js @@ -206,7 +206,7 @@ for (var i = this.chart.data.datasets.length - 1; i > datasetIndex; i--) { var ds = this.chart.data.datasets[i]; - if (helpers.isDatasetVisible(ds)) { + if (ds.type === 'line' && helpers.isDatasetVisible(ds)) { if (ds.data[index] < 0) { sumNeg += ds.data[index] || 0; } else { -- 2.47.3