From 1067afb690dd5bc804408e2aec6be7a6e03cd037 Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 29 Jul 2025 12:41:21 +0200
Subject: [PATCH] virDomainVcpuDefPostParse: Remove impossible check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Many callers of 'virDomainDefGetVcpu' don't validate return value when
iterating CPUs up to def->maxvcpus/virDomainDefGetVcpusMax. Remove this
one.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/conf/domain_postparse.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c
index a07ec8d94e..38e731348d 100644
--- a/src/conf/domain_postparse.c
+++ b/src/conf/domain_postparse.c
@@ -1013,10 +1013,6 @@ virDomainVcpuDefPostParse(virDomainDef *def)
     for (i = 0; i < maxvcpus; i++) {
         vcpu = virDomainDefGetVcpu(def, i);
 
-        /* impossible but some compilers don't like it */
-        if (!vcpu)
-            continue;
-
         switch (vcpu->hotpluggable) {
         case VIR_TRISTATE_BOOL_ABSENT:
             if (vcpu->online)
-- 
2.47.3