From 1071c3040c9adde19ea587265198921c69694925 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Thu, 4 Jan 2018 10:40:36 -0500 Subject: [PATCH] Remove cx_oracle test rule from requirements Removed an oracle-specific requirements rule from the public test suite that was interfering with third party dialect suites. Change-Id: Iebae510edcb8ef908dcd9be9222888e12caed97d --- .../changelog/unreleased_12/fix_oracle_test_rule.rst | 6 ++++++ lib/sqlalchemy/testing/suite/test_types.py | 1 - test/requirements.py | 9 --------- 3 files changed, 6 insertions(+), 10 deletions(-) create mode 100644 doc/build/changelog/unreleased_12/fix_oracle_test_rule.rst diff --git a/doc/build/changelog/unreleased_12/fix_oracle_test_rule.rst b/doc/build/changelog/unreleased_12/fix_oracle_test_rule.rst new file mode 100644 index 0000000000..073414abef --- /dev/null +++ b/doc/build/changelog/unreleased_12/fix_oracle_test_rule.rst @@ -0,0 +1,6 @@ +.. change:: + :tags: bug, tests + + Removed an oracle-specific requirements rule from the public + test suite that was interfering with third party dialect + suites. diff --git a/lib/sqlalchemy/testing/suite/test_types.py b/lib/sqlalchemy/testing/suite/test_types.py index e419fb450b..83aac28505 100644 --- a/lib/sqlalchemy/testing/suite/test_types.py +++ b/lib/sqlalchemy/testing/suite/test_types.py @@ -495,7 +495,6 @@ class NumericTest(_LiteralRoundTripFixture, fixtures.TestBase): numbers ) - @testing.fails_if(testing.requires.broken_cx_oracle6_numerics) @testing.requires.precision_numerics_enotation_large def test_enotation_decimal_large(self): """test exceedingly large decimals. diff --git a/test/requirements.py b/test/requirements.py index be85c1c0dc..3cbc5aaada 100644 --- a/test/requirements.py +++ b/test/requirements.py @@ -1027,15 +1027,6 @@ class DefaultRequirements(SuiteRequirements): config.db.scalar("show server_encoding").lower() == "utf8" ) - @property - def broken_cx_oracle6_numerics(config): - return exclusions.LambdaPredicate( - lambda config: against(config, 'oracle+cx_oracle') and - config.db.dialect.cx_oracle_ver <= (6, 0, 2) and - config.db.dialect.cx_oracle_ver > (6, ), - "cx_Oracle github issue #77" - ) - @property def oracle5x(self): return only_if( -- 2.47.3