From 12ad8f46f5e626626459a0bcdc6a6fbc77ccaccc Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Mon, 7 Jul 2025 12:01:24 -0400 Subject: [PATCH] better debug output and clarifications --- src/lib/server/tmpl_eval.c | 5 ++++- src/lib/unlang/xlat_eval.c | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/lib/server/tmpl_eval.c b/src/lib/server/tmpl_eval.c index d19ff0f96b..79d4e5c5f3 100644 --- a/src/lib/server/tmpl_eval.c +++ b/src/lib/server/tmpl_eval.c @@ -511,7 +511,10 @@ ssize_t _tmpl_to_atype(TALLOC_CTX *ctx, void *out, * permitted. */ slen = xlat_aeval_compiled(tmp_ctx, &str, request, tmpl_xlat(vpt), escape, escape_ctx); - if (slen < 0) goto error; + if (slen < 0) { + RPEDEBUG("Failed expanding %s", vpt->name); + goto error; + } /* * The output is a string which might get cast to something later. diff --git a/src/lib/unlang/xlat_eval.c b/src/lib/unlang/xlat_eval.c index ad38f2ebfb..126900c325 100644 --- a/src/lib/unlang/xlat_eval.c +++ b/src/lib/unlang/xlat_eval.c @@ -1662,8 +1662,10 @@ static ssize_t xlat_eval_sync(TALLOC_CTX *ctx, char **out, request_t *request, x switch (rcode) { default: - if (!XLAT_RESULT_SUCCESS(&unlang_result)) goto fail; - break; + if (XLAT_RESULT_SUCCESS(&unlang_result)) { + break; + } + FALL_THROUGH; case RLM_MODULE_REJECT: case RLM_MODULE_FAIL: -- 2.47.3