From 169c852a740dd902f902188b08dd158cb1a08e46 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Fri, 29 Mar 2019 07:08:16 +0100 Subject: [PATCH] 4.14-stable patches added patches: tun-add-a-missing-rcu_read_unlock-in-error-path.patch --- queue-4.14/series | 1 + ...issing-rcu_read_unlock-in-error-path.patch | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 queue-4.14/tun-add-a-missing-rcu_read_unlock-in-error-path.patch diff --git a/queue-4.14/series b/queue-4.14/series index 9a998c2677d..5374814feb5 100644 --- a/queue-4.14/series +++ b/queue-4.14/series @@ -21,3 +21,4 @@ sctp-get-sctphdr-by-offset-in-sctp_compute_cksum.patch net-aquantia-fix-rx-checksum-offload-for-udp-tcp-over-ipv6.patch mac8390-fix-mmio-access-size-probe.patch tun-properly-test-for-iff_up.patch +tun-add-a-missing-rcu_read_unlock-in-error-path.patch diff --git a/queue-4.14/tun-add-a-missing-rcu_read_unlock-in-error-path.patch b/queue-4.14/tun-add-a-missing-rcu_read_unlock-in-error-path.patch new file mode 100644 index 00000000000..f96e1ba928d --- /dev/null +++ b/queue-4.14/tun-add-a-missing-rcu_read_unlock-in-error-path.patch @@ -0,0 +1,32 @@ +From 9180bb4f046064dfa4541488102703b402bb04e1 Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Sat, 16 Mar 2019 13:09:53 -0700 +Subject: tun: add a missing rcu_read_unlock() in error path + +From: Eric Dumazet + +commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream. + +In my latest patch I missed one rcu_read_unlock(), in case +device is down. + +Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") +Signed-off-by: Eric Dumazet +Reported-by: syzbot +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/net/tun.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/drivers/net/tun.c ++++ b/drivers/net/tun.c +@@ -1569,6 +1569,7 @@ drop: + rcu_read_lock(); + if (unlikely(!(tun->dev->flags & IFF_UP))) { + err = -EIO; ++ rcu_read_unlock(); + goto drop; + } + -- 2.47.2