From 16c6cac2463d57d3dc15057937fd7aedacff656e Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 14 Mar 2025 13:10:15 +0300 Subject: [PATCH] spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write() The "ret" variable needs to be signed for the error handling to work. It should be type int, since it only holds zero and negative error codes. Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver") Signed-off-by: Dan Carpenter Reviewed-by: Tudor Ambarus Link: https://patch.msgid.link/4e16e1bf-e5fb-4771-bc92-c5cba9aac473@stanley.mountain Signed-off-by: Mark Brown --- drivers/spi/spi-sg2044-nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sg2044-nor.c b/drivers/spi/spi-sg2044-nor.c index 454153a63b42e..baa4cf6776631 100644 --- a/drivers/spi/spi-sg2044-nor.c +++ b/drivers/spi/spi-sg2044-nor.c @@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc, size_t xfer_size; const u8 *dout = op->data.buf.out; int i, offset; - size_t ret; + int ret; u32 reg; reg = sg2044_spifmc_init_reg(spifmc); -- 2.39.5