From 182228e76f886cacd10ddd1d9da54149fe1ab969 Mon Sep 17 00:00:00 2001 From: Joel Rosdahl Date: Tue, 5 Apr 2022 20:14:03 +0200 Subject: [PATCH] style: Enable some clang-tidy readability checks for unit tests --- unittest/.clang-tidy | 9 ++++++++- unittest/test_util_Tokenizer.cpp | 7 ++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/unittest/.clang-tidy b/unittest/.clang-tidy index 06d78c329..978237e36 100644 --- a/unittest/.clang-tidy +++ b/unittest/.clang-tidy @@ -1,5 +1,12 @@ --- -Checks: '-*,readability-function-size' +Checks: '-*, + readability-*, + -readability-implicit-bool-conversion, + -readability-magic-numbers, + -readability-else-after-return, + -readability-named-parameter, + -readability-qualified-auto, + -readability-redundant-declaration' WarningsAsErrors: '*' # Only include headers directly in unittest. HeaderFilterRegex: 'unittest/[^/]*$' diff --git a/unittest/test_util_Tokenizer.cpp b/unittest/test_util_Tokenizer.cpp index c5efea34c..ce3a55313 100644 --- a/unittest/test_util_Tokenizer.cpp +++ b/unittest/test_util_Tokenizer.cpp @@ -1,4 +1,4 @@ -// Copyright (C) 2021 Joel Rosdahl and other contributors +// Copyright (C) 2021-2022 Joel Rosdahl and other contributors // // See doc/AUTHORS.adoc for a complete list of contributors. // @@ -36,13 +36,14 @@ TEST_CASE("util::Tokenizer") void operator()(const char* input, const char* separators, - const std::vector& expected) + const std::vector& expected) const { const auto res = Util::split_into_views(input, separators, m_mode, m_includeDelimiter); REQUIRE(res.size() == expected.size()); - for (int i = 0, total = expected.size(); i < total; ++i) + for (int i = 0, total = expected.size(); i < total; ++i) { CHECK(res[i] == expected[i]); + } } Mode m_mode; -- 2.47.2