From 188e53673901eb72d12bfdd933eba91c9cfd4e3c Mon Sep 17 00:00:00 2001 From: Michael Chapman Date: Mon, 30 Mar 2015 13:40:59 +1100 Subject: [PATCH] qemu: fix error propagation in qemuMigrationBegin If virCloseCallbacksSet fails, qemuMigrationBegin must return NULL to indicate an error occurred. Signed-off-by: Michael Chapman (cherry picked from commit 77ddd0bba2379b4ba33980d8f3976f9344451cca) --- src/qemu/qemu_migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 9458606827..21432c0b98 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2745,8 +2745,10 @@ qemuMigrationBegin(virConnectPtr conn, * place. */ if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn, - qemuMigrationCleanup) < 0) + qemuMigrationCleanup) < 0) { + VIR_FREE(xml); goto endjob; + } qemuMigrationJobContinue(vm); } else { goto endjob; -- 2.47.3