From 1ac9b7548b5a5f62cbb05dfa85cdda16677986d3 Mon Sep 17 00:00:00 2001 From: Philip Homburg Date: Thu, 23 Mar 2023 15:15:54 +0100 Subject: [PATCH] Small fixes from Wouter's review --- services/cache/dns.c | 2 +- testdata/serve_expired_0ttl_nodata.rpl | 2 +- testdata/serve_expired_0ttl_nxdomain.rpl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/services/cache/dns.c b/services/cache/dns.c index 1a4fbdd2f..9fbcb5f0f 100644 --- a/services/cache/dns.c +++ b/services/cache/dns.c @@ -178,7 +178,7 @@ dns_cache_store_msg(struct module_env* env, struct query_info* qinfo, * which could be useful for delegation information */ verbose(VERB_ALGO, "TTL 0: dropped msg from cache"); free(rep); - /* if the message is in then cache, remove that msg, + /* if the message is in the cache, remove that msg, * so that the TTL 0 response can be returned for future * responses (i.e. don't get answered from * cache, but instead go to recursion to get this TTL0 diff --git a/testdata/serve_expired_0ttl_nodata.rpl b/testdata/serve_expired_0ttl_nodata.rpl index e28e35255..45b51444b 100644 --- a/testdata/serve_expired_0ttl_nodata.rpl +++ b/testdata/serve_expired_0ttl_nodata.rpl @@ -17,7 +17,7 @@ CONFIG_END SCENARIO_BEGIN Test serve-expired with NXDOMAIN followed by 0 TTL ; Scenario overview: ; - query for 0ttl.example.com. IN A -; - answer from upstream is NODATA; will be cached for NORR_TTL(5) +; - answer from upstream is NODATA; will be cached for the SOA negative TTL. ; - check that the client gets the NODATA; also cached ; - query again right after the TTL expired ; - this time the server answers with a 0 TTL RRset diff --git a/testdata/serve_expired_0ttl_nxdomain.rpl b/testdata/serve_expired_0ttl_nxdomain.rpl index 55b7605ad..0fcde9f2d 100644 --- a/testdata/serve_expired_0ttl_nxdomain.rpl +++ b/testdata/serve_expired_0ttl_nxdomain.rpl @@ -17,7 +17,7 @@ CONFIG_END SCENARIO_BEGIN Test serve-expired with NXDOMAIN followed by 0 TTL ; Scenario overview: ; - query for 0ttl.example.com. IN A -; - answer from upstream is NXDOMAIN; will be cached for NORR_TTL(5) +; - answer from upstream is NXDOMAIN; will be cached for the SOA negative TTL. ; - check that the client gets the NXDOMAIN; also cached ; - query again right after the TTL expired ; - this time the server answers with a 0 TTL RRset -- 2.47.3