From 1b316dc60c7593747bbc4c684825076a759d2086 Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Tue, 3 Apr 2012 19:20:33 +0200 Subject: [PATCH] Don't dump transaction if it is empty. --- python/pakfire/transaction.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/python/pakfire/transaction.py b/python/pakfire/transaction.py index 98b3cd468..7da927f8f 100644 --- a/python/pakfire/transaction.py +++ b/python/pakfire/transaction.py @@ -350,6 +350,9 @@ class Transaction(object): if logger is None: logger = logging.getLogger("pakfire") + if not self.actions: + logger.info(_("Nothing to do")) + width = 80 line = "=" * width @@ -397,6 +400,10 @@ class Transaction(object): logger.info(line) def cli_yesno(self): + # Empty transactions are always denied. + if not self.actions: + return False + return util.ask_user(_("Is this okay?")) def check(self, logger=None): @@ -490,6 +497,7 @@ class Transaction(object): logger.warning("") def run(self, logger=None, signatures_mode=None): + assert self.actions, "Cannot run an empty transaction." assert not self.__need_sort, "Did you forget to sort the transaction?" if logger is None: -- 2.39.5