From 1ca8bbfb1ca81a3ed4a13a2b608437e0768aaec5 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Fri, 19 Aug 2016 18:55:38 +1200 Subject: [PATCH] Cleanup: remove needless LockingPointer::resetWithoutLocking(nullptr) --- src/comm.cc | 2 +- src/fde.h | 2 +- src/security/cert_generators/file/security_file_certgen.cc | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/comm.cc b/src/comm.cc index e606224740..0edaea2ff1 100644 --- a/src/comm.cc +++ b/src/comm.cc @@ -838,7 +838,7 @@ void comm_close_complete(const FdeCbParams ¶ms) { fde *F = &fd_table[params.fd]; - F->ssl.resetWithoutLocking(nullptr); + F->ssl.reset(); #if USE_OPENSSL if (F->dynamicSslContext) { diff --git a/src/fde.h b/src/fde.h index 4978b5e377..938e3b79b9 100644 --- a/src/fde.h +++ b/src/fde.h @@ -167,7 +167,7 @@ public: halfClosedReader = NULL; read_method = NULL; write_method = NULL; - ssl.resetWithoutLocking(nullptr); + ssl.reset(); dynamicSslContext = NULL; #if _SQUID_WINDOWS_ win32.handle = (long)NULL; diff --git a/src/security/cert_generators/file/security_file_certgen.cc b/src/security/cert_generators/file/security_file_certgen.cc index 63e96c889d..2b4bbd6452 100644 --- a/src/security/cert_generators/file/security_file_certgen.cc +++ b/src/security/cert_generators/file/security_file_certgen.cc @@ -204,8 +204,8 @@ static bool processNewRequest(Ssl::CrtdMessage & request_message, std::string co if (!Ssl::certificateMatchesProperties(cert.get(), certProperties)) { // The certificate changed (renewed or other reason). // Generete a new one with the updated fields. - cert.resetWithoutLocking(nullptr); - pkey.resetWithoutLocking(nullptr); + cert.reset(); + pkey.reset(); db.purgeCert(cert_subject); } } -- 2.47.2