From 1fc7e5ba6097302dc91ba22821d420899177b700 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 5 Mar 2015 11:46:39 +1300 Subject: [PATCH] KCC: highlight our deviation from the spec in color_vertices The documentation didn't make much sense. Worked out by Garming. Signed-off-by: Douglas Bagnall Reviewed-by: Garming Sam Reviewed-by: Andrew Bartlett --- source4/scripting/bin/samba_kcc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/source4/scripting/bin/samba_kcc b/source4/scripting/bin/samba_kcc index ab1cafea208..0e0275676b2 100755 --- a/source4/scripting/bin/samba_kcc +++ b/source4/scripting/bin/samba_kcc @@ -1435,6 +1435,16 @@ class KCC(object): self.keep_connection_list.append(cn) def add_transports(self, vertex, local_vertex, graph, detect_failed): + + # The docs ([MS-ADTS] 6.2.2.3.4.3) say to use local_vertex + # here and in the, but using vertex seems to make more + # sense. That is, it wants this: + # + #bh = self.get_bridgehead(vertex.site, vertex.part, transport, + # local_vertex.is_black(), detect_failed) + # + # TODO WHY????? + vertex.accept_red_red = [] vertex.accept_black = [] found_failed = False @@ -1451,9 +1461,6 @@ class KCC(object): continue partial_replica_okay = vertex.is_black() - - # TODO WHY????? - # bh = self.get_bridgehead(local_vertex.site, vertex.part, transport, bh = self.get_bridgehead(vertex.site, vertex.part, transport, partial_replica_okay, detect_failed) if bh is None: -- 2.47.3