From 20634e5c15655ce398cf85f689e796fad73099fe Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Mon, 4 Jan 2016 21:20:29 +0000
Subject: [PATCH] repobrowse: tree: handle lack of trailing newline

This fixes a bug where the trailing newline was not shown
correctly and tells the reader the file is missing a trailing
newline.
---
 lib/PublicInbox/RepoBrowseGitTree.pm | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/RepoBrowseGitTree.pm b/lib/PublicInbox/RepoBrowseGitTree.pm
index d5c74e7e6..6d5d4b8c9 100644
--- a/lib/PublicInbox/RepoBrowseGitTree.pm
+++ b/lib/PublicInbox/RepoBrowseGitTree.pm
@@ -88,6 +88,7 @@ sub git_blob_show {
 	$plain = PublicInbox::Hval->utf8($plain)->as_path . $q->qs;
 	my $t = cur_path($req, $q);
 	my $h = qq{<pre>path: $t\n\nblob: $hex (<a\nhref="$plain">plain</a>)};
+	my $end = '';
 
 	$git->cat_file($hex, sub {
 		my ($cat, $left) = @_; # $$left == $size
@@ -111,7 +112,16 @@ sub git_blob_show {
 				$fh->write("<a\nid=n$n>". utf8_html($l).
 						"</a>\n");
 			}
-			last if ($$left == 0 || !defined $buf);
+			# no trailing newline:
+			if ($$left == 0 && $buf ne '') {
+				++$n;
+				$buf = utf8_html($buf);
+				$fh->write("<a\nid=n$n>". $buf ."</a>");
+				$end = '<pre>\ No newline at end of file</pre>';
+				last;
+			}
+
+			last unless defined($buf);
 
 			$to_read = $$left if $to_read > $$left;
 			my $off = length $buf; # last line from previous read
@@ -125,7 +135,7 @@ sub git_blob_show {
 	# line numbers go in a second column:
 	$fh->write('</pre></td><td><pre>');
 	$fh->write(qq(<a\nhref="#n$_">$_</a>\n)) foreach (1..$n);
-	$fh->write('</pre></td></tr></table>');
+	$fh->write("</pre></td></tr></table><hr />$end");
 }
 
 sub git_tree_show {
-- 
2.47.3