From 20e0bc3fbd8ce4398f76a3c3dae7df2f02e5943a Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 26 Feb 2025 16:55:54 +0100 Subject: [PATCH] qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on (impossible) error If 'vm->def->sec->sectype' would be invalid; which is currently not possible; we'd not unlock the domain object. Fix the logic even when the bug currently can't happen. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6290e5bb8d..51ccd6b822 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19152,7 +19152,7 @@ qemuDomainGetLaunchSecurityInfo(virDomainPtr domain, case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: virReportEnumRangeError(virDomainLaunchSecurity, vm->def->sec->sectype); - return -1; + goto cleanup; } ret = 0; -- 2.47.3