From 2676267afd72e77ddf10bb64a6dcf208295ab933 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 10 Sep 2024 08:50:16 +0200 Subject: [PATCH] libsmb: Use nybble_to_hex_upper() in smbc_urlencode() Signed-off-by: Volker Lendecke Reviewed-by: Noel Power --- source3/libsmb/libsmb_path.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/source3/libsmb/libsmb_path.c b/source3/libsmb/libsmb_path.c index 615de1c398b..12bfd21065c 100644 --- a/source3/libsmb/libsmb_path.c +++ b/source3/libsmb/libsmb_path.c @@ -131,8 +131,6 @@ smbc_urlencode(char *dest, char *src, int max_dest_len) { - char hex[] = "0123456789ABCDEF"; - for (; *src != '\0' && max_dest_len >= 3; src++) { if ((*src < '0' && @@ -145,8 +143,8 @@ smbc_urlencode(char *dest, *src != '_') || (*src > 'z')) { *dest++ = '%'; - *dest++ = hex[(*src >> 4) & 0x0f]; - *dest++ = hex[*src & 0x0f]; + *dest++ = nybble_to_hex_upper(*src >> 4); + *dest++ = nybble_to_hex_upper(*src); max_dest_len -= 3; } else { *dest++ = *src; -- 2.47.3