From 270d572504cba639659037d20e720fffa64f0f0f Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Fri, 4 Mar 2022 10:18:25 +0000 Subject: [PATCH] backup: Abort when the backup could not be extracted Signed-off-by: Michael Tremer --- config/backup/backup.pl | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/config/backup/backup.pl b/config/backup/backup.pl index 63004491c9..768b355088 100644 --- a/config/backup/backup.pl +++ b/config/backup/backup.pl @@ -71,7 +71,11 @@ make_backup() { restore_backup() { local filename="${1}" - tar xvzpf "${filename}" -C / + # Extract backup + if ! tar xvzpf "${filename}" -C /; then + echo "Could not extract backup" >&2 + return 1 + fi # Restart syslogd, httpd and suricata in case we've just loaded old logs apachectl -k graceful @@ -202,7 +206,11 @@ restore_addon_backup() { mv "/tmp/${name}.ipf" "/var/ipfire/backup/addons/backup/${name}.ipf" fi - tar xvzpf "/var/ipfire/backup/addons/backup/${name}.ipf" -C / + # Extract backup + if ! tar xvzpf "/var/ipfire/backup/addons/backup/${name}.ipf" -C /; then + echo "Could not extract backup" >&2 + return 1 + fi } main() { -- 2.39.5