From 271a24e7bf5f9e98b8d6180ed9462719c0e755f9 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Tue, 17 Aug 2010 18:58:55 +0200 Subject: [PATCH] qemu-img rebase: Open new backing file read-only We never write to a backing file, so opening rw is useless. It just means that you can't rebase on top of a file for which you don't have write permissions. Signed-off-by: Kevin Wolf (cherry picked from commit cdbae85169c384d1641aa1ae86cdeefe16285745) --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index e300f911cb5..d2a978b9126 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1286,7 +1286,7 @@ static int img_rebase(int argc, char **argv) } bs_new_backing = bdrv_new("new_backing"); - ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS | BDRV_O_RDWR, + ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS, new_backing_drv); if (ret) { error("Could not open new backing file '%s'", out_baseimg); -- 2.39.5