From 27bd6b5bd69f52a3be6f9f2abeccccbfe58568a6 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Sun, 26 May 2024 13:03:59 -0400 Subject: [PATCH] Fixes for 6.8 Signed-off-by: Sasha Levin --- ...-indicate-support-for-_tfp-thru-_osc.patch | 52 + ...e-support-for-irq-resourcesource-thr.patch | 51 + ...e-support-for-more-than-16-p-states-.patch | 51 + ...e-support-for-the-generic-event-devi.patch | 52 + .../acpi-disable-wstringop-truncation.patch | 48 + ...-generic-initiator-affinity-_osc-bit.patch | 40 + ...ise-number-of-chip-selects-via-prope.patch | 35 + ...-call-packet_read_pending-from-tpack.patch | 49 + ...-races-in-unix_release_sock-unix_str.patch | 76 + ...e-e-mu-fpga-writes-potentially-more-.patch | 40 + ...-remove-speaker-id-for-lenovo-legion.patch | 44 + ...-exit-cache-only-after-cs35l56_wait_.patch | 51 + ...sp-config-harden-i2c-i2s-codec-detec.patch | 84 + ...arm-configs-sunxi-enable-drm_dw_hdmi.patch | 41 + ...ecessary-irqflags-alternative.h-incl.patch | 37 + ...-microphone-from-device-acer-315-24p.patch | 40 + ...ate-dsp1rx5-6-sources-for-dsp-config.patch | 77 + ...-usages-of-device_get_named_child_no.patch | 91 ++ ...fix-usage-of-device_get_named_child_.patch | 55 + ...-rt5645-add-cbj-sleeve-gpio-property.patch | 48 + ...l-avs-fix-asrc-module-initialization.patch | 36 + ...l-avs-fix-potential-integer-overflow.patch | 41 + ...restore-stream-decoupling-on-prepare.patch | 57 + ...s-ssm4567-do-not-ignore-route-checks.patch | 36 + ...-test-result-of-avs_get_module_entry.patch | 59 + ..._rt5640-apply-asus-t100ta-quirk-to-a.patch | 71 + ...able-route-checks-for-skylake-boards.patch | 209 +++ ...kwood-fix-potential-null-dereference.patch | 41 + ...sign-dummy-when-codec-not-specified-.patch | 45 + ...the-electric-noise-due-to-the-cbj-co.patch | 105 ++ ...15-add-vendor-clear-control-register.patch | 38 + ...-rt715-sdca-volume-step-modification.patch | 61 + ...add-headset-microphone-vrefo-setting.patch | 96 ++ ...modify-channel-number-to-support-4-c.patch | 36 + ...da-dai-fix-channel-map-configuration.patch | 92 ++ ...sof-intel-lnl-correct-rom_status_reg.patch | 79 + ...sof-intel-mtl-correct-rom_status_reg.patch | 71 + ...tl-disable-interrupts-when-firmware-.patch | 40 + ...tl-implement-firmware-boot-state-che.patch | 88 ++ ...m-introduce-generic-sof_ipc4_pcm_str.patch | 156 ++ ...m-use-consistent-name-for-snd_sof_pc.patch | 117 ++ ...m-use-consistent-name-for-sof_ipc4_t.patch | 127 ++ ...estrict-dsp-d0i3-during-s0ix-to-ipc3.patch | 84 + ...ort-snd_soc_dapm_dir_out-to-its-valu.patch | 48 + ...rence-count-leak-issue-of-net_device.patch | 53 + ...erence-count-leak-issues-of-ax25_dev.patch | 74 + ...universal-linked-list-to-implement-a.patch | 163 ++ .../bitops-add-missing-prototype-check.patch | 40 + ...simplify-blkdevparts-cmdline-parsing.patch | 208 +++ ...-the-eof-check-in-blkdev_iomap_begin.patch | 43 + ...upport-to-account-io_ticks-precisely.patch | 152 ++ ...e-le-flow-credits-based-on-recvbuf-s.patch | 388 +++++ ...bluetooth-hci-remove-hci_amp-support.patch | 1398 +++++++++++++++++ ...nn-hci_sync-use-__counted_by-to-avoi.patch | 335 ++++ ...re-fix-not-handling-hdev-le_num_of_a.patch | 134 ++ ...ent-remove-code-to-removed-config_bt.patch | 206 +++ ...th-iso-add-hcon-for-listening-bis-sk.patch | 195 +++ ...ean-up-returns-values-in-iso_connect.patch | 64 + ...iso-make-iso_get_sock_listen-generic.patch | 198 +++ ...x-error-code-in-qca_read_fw_build_in.patch | 39 + ...-usage-of-the-deprecated-ida_simple_.patch | 85 + ...ift-undefined-behavior-in-bnxt_qplib.patch | 122 ++ ..._type_cgroup_skb-attach-type-enforce.patch | 50 + ...verifier-assumptions-about-socket-sk.patch | 220 +++ .../bpf-pack-struct-bpf_fib_lookup.patch | 74 + ...register-from-being-marked-as-precis.patch | 58 + ...x86-fix-probe_mem-runtime-load-check.patch | 166 ++ ...ol-fix-missing-pids-during-link-show.patch | 89 ++ ...ffs-on-provided-dir-instead-of-paren.patch | 264 ++++ ...leaner_mutex-earlier-in-qgroup-disab.patch | 263 ++++ ...k-mediatek-mt8365-mm-fix-dpi0-parent.patch | 52 + ...fh-don-t-log-error-for-missing-fhctl.patch | 52 + ...pss-ipq-pll-fix-pll-rate-for-ipq5018.patch | 48 + ...ha-pll-remove-invalid-stromer-regist.patch | 51 + ...dispcc-sm6350-fix-displayport-clocks.patch | 65 + ...dispcc-sm8450-fix-displayport-clocks.patch | 109 ++ ...dispcc-sm8550-fix-displayport-clocks.patch | 110 ++ ...dispcc-sm8650-fix-displayport-clocks.patch | 110 ++ ...com-fix-sc_camcc_8280xp-dependencies.patch | 46 + ...-qcom-fix-sm_gpucc_8650-dependencies.patch | 46 + ...m-mmcc-msm8998-fix-venus-clock-issue.patch | 114 ++ ...esas-r8a779a0-fix-canfd-parent-clock.patch | 40 + ...7g043-add-clock-and-reset-entry-for-.patch | 59 + ...ng-default-value-for-clock-amplitude.patch | 72 + ...osautov9-fix-wrong-pll-clock-id-valu.patch | 47 + ...ix-possible-null-pointer-dereference.patch | 65 + ...ations-kernel-parameter-if-cpu_mitig.patch | 136 ++ ...avs-cpufreq-iso-c90-forbids-mixed-de.patch | 44 + .../cpufreq-exit-callback-is-optional.patch | 58 + .../crypto-bcm-fix-pointer-arithmetic.patch | 40 + ...rypto-ccp-drop-platform-ifdef-checks.patch | 94 ++ ...-add-missing-check-for-dma_map_singl.patch | 39 + ...ve-error-logging-to-be-consistent-ac.patch | 37 + ...ve-error-message-in-adf_get_arbiter_.patch | 50 + ...qat-specify-firmware-files-for-402xx.patch | 43 + ...validate-slices-count-returned-by-fw.patch | 101 ++ ...o-x86-nh-avx2-add-missing-vzeroupper.patch | 36 + ...6-sha256-avx2-add-missing-vzeroupper.patch | 37 + ...6-sha512-avx2-add-missing-vzeroupper.patch | 37 + ...dev_printk-add-and-use-dev_no_printk.patch | 98 ++ ...user-space-lock-decision-to-copy-lvb.patch | 143 ++ ...hung-task-introduced-by-kthread-mode.patch | 43 + .../dm-delay-fix-max_delay-calculations.patch | 51 + ...delay-fix-workqueue-delay_timer-race.patch | 55 + ...inx-xdma-clarify-kdoc-in-xdma-driver.patch | 50 + ...l-fix-return-value-check-for-kmemdup.patch | 40 + ...i-hns3-actually-use-devm_add_action_.patch | 43 + ...i-hns3-fix-out-of-bound-access-when-.patch | 70 + ...i_pcie-fix-out-of-bound-access-when-.patch | 69 + ...n-fix-pfnmap-pte-checks-in-acrn_vm_r.patch | 195 +++ ...-display-add-dtbclk-access-to-dcn315.patch | 55 + ...add-vco-speed-parameter-for-dcn31-fp.patch | 43 + ...allocate-zero-bw-after-bw-alloc-enab.patch | 62 + ...disable-seamless-boot-on-128b-132b-e.patch | 43 + ...ensure-that-dmcub-support-flag-is-se.patch | 36 + ...fix-dc-mode-screen-flickering-on-dcn.patch | 61 + ...fix-potential-index-out-of-bounds-in.patch | 58 + ...remove-redundant-condition-in-dcn35_.patch | 51 + ...set-color_mgmt_changed-to-true-on-un.patch | 37 + ...-pm-restore-config-space-after-reset.patch | 73 + ...he-ring-buffer-size-for-queue-vm-flu.patch | 94 ++ ...rm-amdgpu-fix-vram-memory-accounting.patch | 37 + ...-amdgpu-mes-fix-use-after-free-issue.patch | 41 + ...amdgpu-update-bo-eviction-priorities.patch | 44 + ...dd-vram-accounting-for-svm-migration.patch | 76 + ...-the-process-wq-before-creating-a-kf.patch | 61 + ...ix-a-possible-null-pointer-dereferen.patch | 42 + ...25-don-t-log-an-error-when-dsi-host-.patch | 49 + ...25-update-audio-status-while-detecti.patch | 54 + ...mhdp8546-fix-possible-null-pointer-d.patch | 43 + ...33-don-t-log-an-error-when-dsi-host-.patch | 80 + ...mproper-bridge-init-order-with-pre_e.patch | 154 ++ ...11-don-t-log-an-error-when-dsi-host-.patch | 49 + ...2b-don-t-log-an-error-when-dsi-host-.patch | 49 + ...1-don-t-log-an-error-when-dsi-host-c.patch | 50 + ...1uxc-don-t-log-an-error-when-dsi-hos.patch | 51 + ...775-don-t-log-an-error-when-dsi-host.patch | 49 + ...date-device-type-for-volteer-devices.patch | 52 + ...empt-aux-transfers-when-edp-panels-a.patch | 180 +++ ...opology-block-for-all-dispid-structu.patch | 83 + ...tx-clock-gating-on-some-gc7000-varia.patch | 43 + ...-imagination-avoid-woverflow-warning.patch | 64 + ...-disable-clocks-on-already-suspended.patch | 61 + ...-add-0-size-check-to-mtk_drm_gem_obj.patch | 44 + ...atek-init-ddp_comp-with-devm_kcalloc.patch | 60 + ...ix-calculation-of-59.94-fractional-r.patch | 65 + ...-correct-return-type-for-the-dsc-fun.patch | 69 + ...llow-voltage-swing-pre-emphasis-of-3.patch | 138 ++ ...-a-long-timeout-for-aux-transfer-if-.patch | 133 ++ ...ix-incorrect-return-code-in-r535_dp_.patch | 48 + ...fix-console-by-implementing-fb_dirty.patch | 54 + ...mapdrm-fix-console-with-deferred-ops.patch | 156 ++ ...xc20-fix-unbalanced-regulator-in-the.patch | 74 + ...h3146w-add-mipi_dsi_mode_video-to-lt.patch | 44 + ...h3146w-drop-duplicate-commands-from-.patch | 41 + ...k-nt35950-don-t-log-an-error-when-ds.patch | 49 + ...-add-missing-innolux-g121x1-l03-form.patch | 50 + ...2-do-not-divide-height-twice-for-yuv.patch | 83 + ...ix-possible-null-pointer-dereference.patch | 39 + ...chip-grf-add-missing-type-to-pcie-ph.patch | 37 + ...mal-loongson-ls2k-thermal-add-loongs.patch | 40 + ...mal-loongson-ls2k-thermal-fix-incorr.patch | 83 + ...fs-fix-buffer-size-for-tag-66-packet.patch | 116 ++ ...mmon-allow-decoding-of-sgx-addresses.patch | 43 + ...ersal-do-not-register-for-noc-errors.patch | 46 + ...enetc-avoid-truncating-error-message.patch | 41 + ...epoll-be-better-about-file-lifetimes.patch | 94 ++ ...e-.ndo_poll_controller-to-avoid-dead.patch | 67 + ...sive-credit-estimate-in-ext4_tmpfile.patch | 52 + ...-fix-potential-unnitialized-variable.patch | 40 + ...move-the-redundant-folio_wait_stable.patch | 42 + .../fbdev-sh7760fb-allow-modular-build.patch | 50 + ...dev-shmobile-fix-snprintf-truncation.patch | 40 + .../fbdev-sisfb-hide-unused-variables.patch | 68 + ...m-fix-unused-qcom_scm_qseecom_allowl.patch | 44 + ...m-fix-__scm-and-waitq-completion-var.patch | 70 + ...rypi-use-correct-device-for-dma-mapp.patch | 65 + ...-pci-subdevice-id-for-intel-d5005-ca.patch | 51 + queue-6.8/gfs2-do_xmote-fixes.patch | 128 ++ ...-forget-to-complete-delayed-withdraw.patch | 39 + queue-6.8/gfs2-finish_xmote-cleanup.patch | 108 ++ ...gnore-unlock-failures-after-withdraw.patch | 63 + ...tial-glock-use-after-free-on-unmount.patch | 227 +++ ...-remove-ill-placed-consistency-check.patch | 37 + ...o-nuvoton-fix-sgpio-irq-handle-error.patch | 55 + ...h-handle-no-sensors-in-pm-operations.patch | 52 + ...d-ipc-add-check-for-pci_alloc_irq_ve.patch | 41 + ...cel-delayed_work-only-when-config_ii.patch | 40 + ...-n64-controller-being-identified-as-.patch | 51 + ...2-put-ip-into-rpm-suspend-on-failure.patch | 56 + .../hwrng-stm32-repair-clock-handling.patch | 79 + ...-stm32-use-logical-or-in-conditional.patch | 37 + ...write64_copy-for-write-combining-sto.patch | 83 + .../ice-fix-package-download-algorithm.patch | 56 + .../ice-make-ice_vsi_cfg_rxq-static.patch | 236 +++ .../ice-make-ice_vsi_cfg_txq-static.patch | 310 ++++ ...-over-ethtool-tcp-data-split-setting.patch | 53 + ...ark-driver-struct-with-__refdata-to-.patch | 51 + ...pad-add-support-for-asus-rog-raikiri.patch | 42 + ...-next_work-before-dropping-acct_lock.patch | 76 + ...ure-async-prep-handlers-always-initi.patch | 64 + ...ing-net-fix-sendzc-lazy-wake-polling.patch | 37 + ...ove-dependency-on-req_f_partial_io-f.patch | 92 ++ ...-right-type-for-work_llist-empty-che.patch | 37 + ...-attachment-only-for-the-devices-tha.patch | 86 + .../ipv6-sr-add-missing-seg6_local_exit.patch | 38 + ...v6-sr-fix-incorrect-unregister-order.patch | 39 + ...sr-fix-invalid-unregister-error-path.patch | 46 + ...si-fix-off-by-one-in-allocation-erro.patch | 40 + ...-pch-msi-fix-off-by-one-on-allocatio.patch | 41 + ...ttr-node-from-overflowing-the-eraseb.patch | 81 + ...arly-in-__kunit_test_suites_init-if-.patch | 47 + queue-6.8/kunit-fix-kthread-reference.patch | 70 + ...y-fix-mismatched-kvalloc-vfree-usage.patch | 64 + ...kunit-unregister-the-device-on-error.patch | 39 + ...d-test-for-uaccesses-to-non-existent.patch | 102 ++ ...error-handling-for-udp-encap-sockets.patch | 133 ++ ...andle-src_pfns-and-dst_pfns-allocati.patch | 62 + ...error-message-in-attach_kprobe_multi.patch | 37 + ...ull-pointer-dereference-when-prog-to.patch | 57 + queue-6.8/libfs-add-simple_offset_empty.patch | 111 ++ .../libfs-add-simple_offset_rename-api.patch | 85 + ...mple-directory-offsets-to-use-a-mapl.patch | 220 +++ ...fs-define-a-minimum-directory-offset.patch | 70 + ...fs-fix-simple_offset_rename_exchange.patch | 85 + ...rrange-locking-in-offset_iterate_dir.patch | 87 + ...ble-cfi-checking-for-perms-functions.patch | 59 + ...86-correct-the-definition-of-__arch_.patch | 40 + ...-lately-init-pmu-after-smp-is-online.patch | 40 + ...nlock-race-in-kernel-thread-creation.patch | 77 + ...m68k-mac-fix-reboot-hang-on-mac-iici.patch | 99 ++ ...cii-fix-bug-sleeping-function-called.patch | 59 + .../maple_tree-add-mtree_alloc_cyclic.patch | 168 ++ ...ftlockup-when-bitmap-size-is-less-th.patch | 93 ++ ...h_css-fix-a-null-pointer-dereference.patch | 52 + ...i2rx-configure-dphy-before-starting-.patch | 91 ++ ...s-ovti-ov2680-fix-the-power-supply-n.patch | 77 + ...-don-t-strip-remove-function-when-dr.patch | 57 + .../media-ipu3-cio2-request-irq-earlier.patch | 52 + ...dvb_ca_en50221_init-return-value-che.patch | 40 + ...o-shark2-avoid-led_names-truncations.patch | 40 + ...ork-around-wenum-compare-conditional.patch | 47 + ...deo-add-quirk-for-logitech-rally-bar.patch | 106 ++ ...dev-fix-stream-handling-for-crop-api.patch | 47 + .../mlx5-avoid-truncating-error-message.patch | 41 + .../mlx5-stop-warning-for-64kb-pages.patch | 57 + ...m-ksm-fix-ksm-exec-support-for-prctl.patch | 116 ++ ...e-inverted-data-to-corrupt-kmem-cach.patch | 69 + ...o-not-place-zeropages-when-zeropages.patch | 95 ++ ...-.export_symbol-section-from-the-fin.patch | 35 + ...-duplicate-code-in-socket-option-han.patch | 66 + .../mptcp-cleanup-sol_tcp-handling.patch | 157 ++ queue-6.8/mptcp-cleanup-writer-wake-up.patch | 104 ++ ...ptcp-fix-full-tcp-keep-alive-support.patch | 157 ++ ...-implement-tcp_notsent_lowat-support.patch | 202 +++ ...-so_keepalive-fix-getsockopt-support.patch | 53 + ...error-if-first-mtd_otp_size-call-fai.patch | 44 + queue-6.8/mtd-rawnand-hynix-fixed-typo.patch | 43 + ...t-bridge-mst-fix-vlan-use-after-free.patch | 123 ++ ...make-sure-we-have-at-least-eth-heade.patch | 90 ++ ...x-add-support-for-model-specific-pre.patch | 234 +++ ...x-avoid-eeprom-timeout-without-eepro.patch | 173 ++ .../net-ethernet-cortina-locking-fixes.patch | 86 + ...iatek-split-tx-and-rx-fields-in-mtk_.patch | 618 ++++++++ ...iatek-use-admav1-instead-of-admav2.0.patch | 138 ++ ...ndo_poll_controller-to-avoid-deadloc.patch | 75 + ...ances-to-rcu-in-netdev_wait_allrefs_.patch | 54 + ...ng-start-position-when-receive-hop-b.patch | 41 + ...eceiving-the-timestamp-in-the-frame-.patch | 44 + ...imeout-to-acquire-the-command-queue-.patch | 156 ++ ...-command-completions-in-internal-err.patch | 75 + ...r-devlink-set-for-sf-representor-dev.patch | 166 ++ ...only-ib-representors-upon-lag-disabl.patch | 222 +++ ...fix-overwriting-ct-original-tuple-fo.patch | 86 + queue-6.8/net-qrtr-ns-fix-module-refcnt.patch | 83 + ...st-per-tx-queue-error-count-for-hlbf.patch | 65 + ...e-the-est-lock-to-struct-stmmac_priv.patch | 192 +++ ...c-offload-queuemaxsdu-from-tc-taprio.patch | 158 ++ ...-stmmac-report-taprio-offload-status.patch | 123 ++ ...et-txgbe-fix-gpio-interrupt-blocking.patch | 91 ++ ...-clear-interrupt-status-after-handli.patch | 41 + .../net-txgbe-fix-to-control-vlan-strip.patch | 278 ++++ ...e-interrupt-codes-to-a-separate-file.patch | 339 ++++ ...-irq_domain-for-interrupt-controller.patch | 500 ++++++ ...wwan-add-telit-fn920c04-compositions.patch | 108 ++ ...sc95xx-stop-lying-about-skb-truesize.patch | 87 + ...sr9700-stop-lying-about-skb-truesize.patch | 59 + ...et-wangxun-fix-to-change-rx-features.patch | 47 + ...un-match-vlan-ctag-and-stag-features.patch | 123 ++ ...ix-possible-dead-lock-in-nr_rt_ioctl.patch | 192 +++ ...e-nfsv4recoverydir-in-nfsdfs-when-no.patch | 68 + .../nilfs2-fix-out-of-range-warning.patch | 45 + ...rblock-data-array-index-computation-.patch | 73 + ...sing-mutex_destroy-at-module-removal.patch | 37 + ...ing-i-o-if-nvme-controller-is-in-ter.patch | 126 ++ ...istance-only-if-controller-has-valid.patch | 47 + ...pdu-pacing-to-avoid-send-stalls-on-t.patch | 62 + ...ce-pr_debug-with-pr_err-to-report-an.patch | 41 + ...n-the-error-code-to-the-nvmet_auth_h.patch | 38 + ...tatus-code-when-namespace-is-disable.patch | 94 ++ ...rintf-overflow-in-nvmet_subsys_nsid_.patch | 49 + ...ssible-memory-leak-when-tearing-down.patch | 65 + ...buffer-overflow-check-in-of_modalias.patch | 50 + ...nish-conversion-to-the-new-mount-api.patch | 58 + ...on-t-send-signals-to-kernel-mode-thr.patch | 91 ++ ...define_flex-to-take-__counted_by-mem.patch | 293 ++++ ...c-add-missing-export-of-__cmpxchg_u8.patch | 36 + ...isst-add-grand-ridge-to-hpm-cpu-list.patch | 39 + ...omi-wmi-fix-race-condition-when-repo.patch | 95 ++ ...c-fsl-soc-hide-unused-const-variable.patch | 48 + .../printk-let-no_printk-use-_printk.patch | 55 + queue-6.8/ptp-ocp-fix-dpll-functions.patch | 55 + ...te-check-against-chip-npwm-in-of_pwm.patch | 42 + ...-member-.of_pwm_n_cells-of-struct-pw.patch | 161 ++ ...period-with-pwm-cells-1-and-of_pwm_s.patch | 44 + ...late-callbacks-accept-references-wit.patch | 79 + ...-check-for-error-from-clk_round_rate.patch | 62 + ...-prototype-of-a-few-helpers-to-prepa.patch | 162 ++ ...-make-use-of-pwmchip_parent-accessor.patch | 91 ++ ...l_u64_u64_div_u64-for-frequency-calc.patch | 51 + ...nline-function-to-get-the-parent-dev.patch | 227 +++ queue-6.8/pwm-reorder-symbols-in-core.c.patch | 1023 ++++++++++++ ...e-removing-pwm_chip-from-driver-data.patch | 90 ++ ...-probe-function-using-devm-functions.patch | 115 ++ ...d-avoid-truncating-work-queue-length.patch | 58 + ...fer-overflow-in-print_cpu_stall_info.patch | 51 + ...ow_rcu_tasks_trace_gp_kthread-buffer.patch | 45 + ...mleak-in-rdma_core-observed-during-b.patch | 77 + ...hns-fix-deadlock-on-srq-async-events.patch | 69 + .../rdma-hns-fix-gmv-table-pagesize.patch | 39 + ...x-return-value-in-hns_roce_map_mr_sg.patch | 75 + .../rdma-hns-fix-uaf-for-cq-async-event.patch | 91 ++ ...-modify-the-print-level-of-cqe-error.patch | 42 + ...s-use-complete-parentheses-in-macros.patch | 52 + ...format-truncation-compilation-errors.patch | 66 + ...ndary-check-before-installing-cq-cal.patch | 37 + ...roduce-helpers-to-create-and-destroy.patch | 109 ++ ..._ib-use-struct-mana_ib_queue-for-cqs.patch | 231 +++ ...-remote-atomic-access-flag-to-updata.patch | 39 + ...lx5-change-check-for-cacheable-mkeys.patch | 103 ++ ...eable-mkey-has-neither-rb_key-or-cac.patch | 38 + ...ow-good-work-requests-to-be-executed.patch | 58 + ...-fix-incorrect-rxe_put-in-error-path.patch | 55 + ...-fix-seg-fault-in-rxe_comp_queue_pkt.patch | 52 + ...lator-irq_helpers-duplicate-irq-name.patch | 43 + ...r-qcom-refgen-fix-module-autoloading.patch | 36 + ...vqmmc-ipq4019-fix-module-autoloading.patch | 36 + ...-fix-clk_name-exceed-max_dev_id-limi.patch | 39 + ...-fix-i2c-dev-name-cannot-match-clkde.patch | 58 + ...-calling-csum_partial-with-misaligne.patch | 187 +++ ...some-atomic-operations-fully-ordered.patch | 97 ++ ...t-availability-bit-before-enabling-m.patch | 73 + ...iscv-thead-rename-t-head-pbmt-to-mae.patch | 138 ++ ...a-barrier-for-bpf_fetch-instructions.patch | 62 + ...fix-tracepoint-subchannel-type-field.patch | 38 + ...e-the-shared-zeropage-for-pv-and-ske.patch | 369 +++++ ...-fix-incorrect-free-in-populate_rule.patch | 51 + ...ncorrect-initialization-of-the-burst.patch | 71 + ...as-checks-before-updating-root_domai.patch | 148 ++ ...-disabling-sched_balance_newidle-wit.patch | 64 + ...fix-boot-crash-when-maxcpus-first-ho.patch | 78 + ...ure-the-copied-buf-is-nul-terminated.patch | 49 + ...location-size-for-scsi_host-private-.patch | 41 + ...the-failure-of-adding-phy-with-zero-.patch | 55 + ...ure-the-copied-buf-is-nul-terminated.patch | 40 + ...-debugfs-output-for-fw_resource_coun.patch | 43 + ...tfrm-perform-read-back-after-writing.patch | 50 + ...s-core-mcq-fix-ufshcd_mcq_sqe_search.patch | 50 + ...rform-read-back-after-disabling-inte.patch | 53 + ...rform-read-back-after-disabling-uic_.patch | 52 + ...rform-read-back-after-writing-utp_ta.patch | 53 + ...rform-read-back-after-writing-cgc-en.patch | 51 + ...rform-read-back-after-writing-reg_uf.patch | 51 + ...rform-read-back-after-writing-reset-.patch | 71 + ...rform-read-back-after-writing-unipro.patch | 52 + ...fs-use-the-makefile-s-rules-not-make.patch | 71 + ...x-a-fd-leak-in-error-paths-in-open_n.patch | 40 + ...x-pointer-arithmetic-in-test_xdp_do_.patch | 62 + ...x-umount-cgroup2-error-in-test_sockm.patch | 43 + ...n-cgroup1_hierarchy-test-in-own-moun.patch | 92 ++ ...-skip-test_cgcore_lesser_ns_open-whe.patch | 221 +++ ..._damon_sysfs-check-errors-from-nr_sc.patch | 39 + ...default-to-host-arch-for-llvm-builds.patch | 85 + ...lftests-kcmp-remove-unused-open-mode.patch | 42 + ...ts-net-add-missing-config-for-amt.sh.patch | 35 + ...idge-increase-igmp-mld-exclude-timeo.patch | 82 + ...b-no-need-to-record-ns-name-if-it-al.patch | 56 + ...ve-amt-to-socat-for-better-compatibi.patch | 77 + ...l-fix-clang-build-failure-use-local_.patch | 60 + ...st-return-correct-emulated-syscall-v.patch | 56 + queue-6.8/series | 456 ++++++ ...-arch_copy_kprobe-into-arch_prepare_.patch | 53 + queue-6.8/shmem-fix-shmem_rename2.patch | 55 + ...-cmdq-fix-typo-of-cmdq_jump_relative.patch | 49 + ...ink-don-t-traverse-clients-list-with.patch | 56 + ..._glink-make-client-lock-non-sleeping.patch | 142 ++ ...ink-notify-clients-about-the-current.patch | 48 + ...suspicious-rcu-usage-in-__do_softirq.patch | 102 ++ ...arfive-remove-links-when-unregisteri.patch | 40 + .../sunrpc-fix-gss_free_in_token_pages.patch | 78 + ...sunrpc-removed-redundant-procp-check.patch | 39 + ...d-premature-drops-in-tcp_add_backlog.patch | 87 + ...crease-the-default-tcp-scaling-ratio.patch | 71 + ...avoid-excessive-updates-of-trip-poin.patch | 86 + ...create-records-for-cdev-states-as-th.patch | 50 + ...pass-cooling-device-state-to-thermal.patch | 131 ++ ...mediatek-lvts_thermal-add-coeff-for-.patch | 45 + ...s-tsens-fix-null-pointer-dereference.patch | 42 + ...events-fix-non-spaced-field-matching.patch | 139 ++ ...nts-prepare-find-delete-for-same-nam.patch | 234 +++ ...l-to-compute_score-on-multiple-sites.patch | 164 ++ ...aqc111-stop-lying-about-skb-truesize.patch | 55 + .../virt-acrn-stop-using-follow_pfn.patch | 71 + ...-enable-proper-endpoint-verification.patch | 99 ++ ...an-error-code-problem-in-ath10k_dbg_.patch | 43 + ...-service-ready-message-before-failin.patch | 81 + ...h10k-populate-board-data-for-wcn3990.patch | 65 + ...t-force-enable-power-save-on-non-run.patch | 94 ++ ...out-of-bound-access-of-qmi_invoke_ha.patch | 72 + ...correct-flag-field-for-320-mhz-chann.patch | 44 + ...ie-handle-randbuf-allocation-failure.patch | 71 + ...d-a-proper-sanity-check-for-endpoint.patch | 97 ++ ...9170-re-fix-fortified-memset-warning.patch | 60 + ...x-the-order-of-arguments-for-trace-e.patch | 50 + ...ix-ieee80211_mle_basic_sta_prof_size.patch | 45 + ...mplement-can_activate_links-callback.patch | 80 + ...-allocate-sta-links-only-for-active-.patch | 50 + ...-do-not-warn-on-invalid-link-on-scan.patch | 44 + ...-fix-active-link-counting-during-rec.patch | 87 + ...-fix-check-in-iwl_mvm_sta_fw_id_mask.patch | 41 + ...iwlwifi-mvm-init-vif-works-only-once.patch | 116 ++ ...-select-sta-mask-only-for-active-lin.patch | 72 + ...fi-reconfigure-tlc-during-hw-restart.patch | 45 + ...n-t-select-link-id-if-not-provided-i.patch | 56 + ...211-don-t-use-rate-mask-for-scanning.patch | 119 ++ ...sure-beacon-is-non-s1g-prior-to-extr.patch | 42 + ...-add-wpdma-tx-eof-flag-for-pse-clien.patch | 33 + ...603-fix-tx-queue-of-loopback-packets.patch | 109 ++ ...-workaround-too-long-expansion-spars.patch | 62 + ...-ensure-4-byte-alignment-for-suspend.patch | 49 + ...-fix-potential-memory-leakage-when-r.patch | 49 + ...7996-fix-size-of-txpower-mcu-command.patch | 68 + ...-fix-uninitialized-variable-in-mt799.patch | 37 + ...i-mwl8k-initialize-cmd-addr-properly.patch | 38 + ...id-address-calculations-via-out-of-b.patch | 70 + ...efine-wowlan-flows-of-hci-interrupts.patch | 108 ++ ...r-most-of-cr4-in-startup_64-except-p.patch | 74 + ...relocations-in-.notes-sections-in-wa.patch | 54 + ...-versions-of-vpdpbusd-vpdpbusds-vpdp.patch | 75 + ...h-instruction-in-x86-instruction-dec.patch | 98 ++ ...d-avoid-wformat-warning-with-clang-1.patch | 49 + ...oken-vsyscall-emulation-code-from-th.patch | 232 +++ ...t-lookup-of-cfmws-ranges-with-numa_f.patch | 118 ++ ...violation-false-positives-when-runni.patch | 144 ++ ...introduce-lookup_address_in_pgd_attr.patch | 127 ++ ...-pat-restructure-_lookup_address_cpa.patch | 51 + ...itch-to-the-position-independent-sma.patch | 81 + 457 files changed, 40123 insertions(+) create mode 100644 queue-6.8/acpi-bus-indicate-support-for-_tfp-thru-_osc.patch create mode 100644 queue-6.8/acpi-bus-indicate-support-for-irq-resourcesource-thr.patch create mode 100644 queue-6.8/acpi-bus-indicate-support-for-more-than-16-p-states-.patch create mode 100644 queue-6.8/acpi-bus-indicate-support-for-the-generic-event-devi.patch create mode 100644 queue-6.8/acpi-disable-wstringop-truncation.patch create mode 100644 queue-6.8/acpi-fix-generic-initiator-affinity-_osc-bit.patch create mode 100644 queue-6.8/acpi-lpss-advertise-number-of-chip-selects-via-prope.patch create mode 100644 queue-6.8/af_packet-do-not-call-packet_read_pending-from-tpack.patch create mode 100644 queue-6.8/af_unix-fix-data-races-in-unix_release_sock-unix_str.patch create mode 100644 queue-6.8/alsa-emu10k1-make-e-mu-fpga-writes-potentially-more-.patch create mode 100644 queue-6.8/alsa-hda-cs35l41-remove-speaker-id-for-lenovo-legion.patch create mode 100644 queue-6.8/alsa-hda-cs35l56-exit-cache-only-after-cs35l56_wait_.patch create mode 100644 queue-6.8/alsa-hda-intel-dsp-config-harden-i2c-i2s-codec-detec.patch create mode 100644 queue-6.8/arm-configs-sunxi-enable-drm_dw_hdmi.patch create mode 100644 queue-6.8/arm64-remove-unnecessary-irqflags-alternative.h-incl.patch create mode 100644 queue-6.8/asoc-acp-support-microphone-from-device-acer-315-24p.patch create mode 100644 queue-6.8/asoc-cs35l41-update-dsp1rx5-6-sources-for-dsp-config.patch create mode 100644 queue-6.8/asoc-cs35l56-fix-usages-of-device_get_named_child_no.patch create mode 100644 queue-6.8/asoc-da7219-aad-fix-usage-of-device_get_named_child_.patch create mode 100644 queue-6.8/asoc-dt-bindings-rt5645-add-cbj-sleeve-gpio-property.patch create mode 100644 queue-6.8/asoc-intel-avs-fix-asrc-module-initialization.patch create mode 100644 queue-6.8/asoc-intel-avs-fix-potential-integer-overflow.patch create mode 100644 queue-6.8/asoc-intel-avs-restore-stream-decoupling-on-prepare.patch create mode 100644 queue-6.8/asoc-intel-avs-ssm4567-do-not-ignore-route-checks.patch create mode 100644 queue-6.8/asoc-intel-avs-test-result-of-avs_get_module_entry.patch create mode 100644 queue-6.8/asoc-intel-bytcr_rt5640-apply-asus-t100ta-quirk-to-a.patch create mode 100644 queue-6.8/asoc-intel-disable-route-checks-for-skylake-boards.patch create mode 100644 queue-6.8/asoc-kirkwood-fix-potential-null-dereference.patch create mode 100644 queue-6.8/asoc-mediatek-assign-dummy-when-codec-not-specified-.patch create mode 100644 queue-6.8/asoc-rt5645-fix-the-electric-noise-due-to-the-cbj-co.patch create mode 100644 queue-6.8/asoc-rt715-add-vendor-clear-control-register.patch create mode 100644 queue-6.8/asoc-rt715-sdca-volume-step-modification.patch create mode 100644 queue-6.8/asoc-rt722-sdca-add-headset-microphone-vrefo-setting.patch create mode 100644 queue-6.8/asoc-rt722-sdca-modify-channel-number-to-support-4-c.patch create mode 100644 queue-6.8/asoc-sof-intel-hda-dai-fix-channel-map-configuration.patch create mode 100644 queue-6.8/asoc-sof-intel-lnl-correct-rom_status_reg.patch create mode 100644 queue-6.8/asoc-sof-intel-mtl-correct-rom_status_reg.patch create mode 100644 queue-6.8/asoc-sof-intel-mtl-disable-interrupts-when-firmware-.patch create mode 100644 queue-6.8/asoc-sof-intel-mtl-implement-firmware-boot-state-che.patch create mode 100644 queue-6.8/asoc-sof-ipc4-pcm-introduce-generic-sof_ipc4_pcm_str.patch create mode 100644 queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-snd_sof_pc.patch create mode 100644 queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-sof_ipc4_t.patch create mode 100644 queue-6.8/asoc-sof-pcm-restrict-dsp-d0i3-during-s0ix-to-ipc3.patch create mode 100644 queue-6.8/asoc-tracing-export-snd_soc_dapm_dir_out-to-its-valu.patch create mode 100644 queue-6.8/ax25-fix-reference-count-leak-issue-of-net_device.patch create mode 100644 queue-6.8/ax25-fix-reference-count-leak-issues-of-ax25_dev.patch create mode 100644 queue-6.8/ax25-use-kernel-universal-linked-list-to-implement-a.patch create mode 100644 queue-6.8/bitops-add-missing-prototype-check.patch create mode 100644 queue-6.8/block-fix-and-simplify-blkdevparts-cmdline-parsing.patch create mode 100644 queue-6.8/block-refine-the-eof-check-in-blkdev_iomap_begin.patch create mode 100644 queue-6.8/block-support-to-account-io_ticks-precisely.patch create mode 100644 queue-6.8/bluetooth-compute-le-flow-credits-based-on-recvbuf-s.patch create mode 100644 queue-6.8/bluetooth-hci-remove-hci_amp-support.patch create mode 100644 queue-6.8/bluetooth-hci_conn-hci_sync-use-__counted_by-to-avoi.patch create mode 100644 queue-6.8/bluetooth-hci_core-fix-not-handling-hdev-le_num_of_a.patch create mode 100644 queue-6.8/bluetooth-hci_event-remove-code-to-removed-config_bt.patch create mode 100644 queue-6.8/bluetooth-iso-add-hcon-for-listening-bis-sk.patch create mode 100644 queue-6.8/bluetooth-iso-clean-up-returns-values-in-iso_connect.patch create mode 100644 queue-6.8/bluetooth-iso-make-iso_get_sock_listen-generic.patch create mode 100644 queue-6.8/bluetooth-qca-fix-error-code-in-qca_read_fw_build_in.patch create mode 100644 queue-6.8/bluetooth-remove-usage-of-the-deprecated-ida_simple_.patch create mode 100644 queue-6.8/bnxt_re-avoid-shift-undefined-behavior-in-bnxt_qplib.patch create mode 100644 queue-6.8/bpf-add-bpf_prog_type_cgroup_skb-attach-type-enforce.patch create mode 100644 queue-6.8/bpf-fix-verifier-assumptions-about-socket-sk.patch create mode 100644 queue-6.8/bpf-pack-struct-bpf_fib_lookup.patch create mode 100644 queue-6.8/bpf-prevent-r10-register-from-being-marked-as-precis.patch create mode 100644 queue-6.8/bpf-x86-fix-probe_mem-runtime-load-check.patch create mode 100644 queue-6.8/bpftool-fix-missing-pids-during-link-show.patch create mode 100644 queue-6.8/bpftool-mount-bpffs-on-provided-dir-instead-of-paren.patch create mode 100644 queue-6.8/btrfs-take-the-cleaner_mutex-earlier-in-qgroup-disab.patch create mode 100644 queue-6.8/clk-mediatek-mt8365-mm-fix-dpi0-parent.patch create mode 100644 queue-6.8/clk-mediatek-pllfh-don-t-log-error-for-missing-fhctl.patch create mode 100644 queue-6.8/clk-qcom-apss-ipq-pll-fix-pll-rate-for-ipq5018.patch create mode 100644 queue-6.8/clk-qcom-clk-alpha-pll-remove-invalid-stromer-regist.patch create mode 100644 queue-6.8/clk-qcom-dispcc-sm6350-fix-displayport-clocks.patch create mode 100644 queue-6.8/clk-qcom-dispcc-sm8450-fix-displayport-clocks.patch create mode 100644 queue-6.8/clk-qcom-dispcc-sm8550-fix-displayport-clocks.patch create mode 100644 queue-6.8/clk-qcom-dispcc-sm8650-fix-displayport-clocks.patch create mode 100644 queue-6.8/clk-qcom-fix-sc_camcc_8280xp-dependencies.patch create mode 100644 queue-6.8/clk-qcom-fix-sm_gpucc_8650-dependencies.patch create mode 100644 queue-6.8/clk-qcom-mmcc-msm8998-fix-venus-clock-issue.patch create mode 100644 queue-6.8/clk-renesas-r8a779a0-fix-canfd-parent-clock.patch create mode 100644 queue-6.8/clk-renesas-r9a07g043-add-clock-and-reset-entry-for-.patch create mode 100644 queue-6.8/clk-rs9-fix-wrong-default-value-for-clock-amplitude.patch create mode 100644 queue-6.8/clk-samsung-exynosautov9-fix-wrong-pll-clock-id-valu.patch create mode 100644 queue-6.8/cppc_cpufreq-fix-possible-null-pointer-dereference.patch create mode 100644 queue-6.8/cpu-ignore-mitigations-kernel-parameter-if-cpu_mitig.patch create mode 100644 queue-6.8/cpufreq-brcmstb-avs-cpufreq-iso-c90-forbids-mixed-de.patch create mode 100644 queue-6.8/cpufreq-exit-callback-is-optional.patch create mode 100644 queue-6.8/crypto-bcm-fix-pointer-arithmetic.patch create mode 100644 queue-6.8/crypto-ccp-drop-platform-ifdef-checks.patch create mode 100644 queue-6.8/crypto-octeontx2-add-missing-check-for-dma_map_singl.patch create mode 100644 queue-6.8/crypto-qat-improve-error-logging-to-be-consistent-ac.patch create mode 100644 queue-6.8/crypto-qat-improve-error-message-in-adf_get_arbiter_.patch create mode 100644 queue-6.8/crypto-qat-specify-firmware-files-for-402xx.patch create mode 100644 queue-6.8/crypto-qat-validate-slices-count-returned-by-fw.patch create mode 100644 queue-6.8/crypto-x86-nh-avx2-add-missing-vzeroupper.patch create mode 100644 queue-6.8/crypto-x86-sha256-avx2-add-missing-vzeroupper.patch create mode 100644 queue-6.8/crypto-x86-sha512-avx2-add-missing-vzeroupper.patch create mode 100644 queue-6.8/dev_printk-add-and-use-dev_no_printk.patch create mode 100644 queue-6.8/dlm-fix-user-space-lock-decision-to-copy-lvb.patch create mode 100644 queue-6.8/dm-delay-fix-hung-task-introduced-by-kthread-mode.patch create mode 100644 queue-6.8/dm-delay-fix-max_delay-calculations.patch create mode 100644 queue-6.8/dm-delay-fix-workqueue-delay_timer-race.patch create mode 100644 queue-6.8/dmaengine-xilinx-xdma-clarify-kdoc-in-xdma-driver.patch create mode 100644 queue-6.8/dpll-fix-return-value-check-for-kmemdup.patch create mode 100644 queue-6.8/drivers-perf-hisi-hns3-actually-use-devm_add_action_.patch create mode 100644 queue-6.8/drivers-perf-hisi-hns3-fix-out-of-bound-access-when-.patch create mode 100644 queue-6.8/drivers-perf-hisi_pcie-fix-out-of-bound-access-when-.patch create mode 100644 queue-6.8/drivers-virt-acrn-fix-pfnmap-pte-checks-in-acrn_vm_r.patch create mode 100644 queue-6.8/drm-amd-display-add-dtbclk-access-to-dcn315.patch create mode 100644 queue-6.8/drm-amd-display-add-vco-speed-parameter-for-dcn31-fp.patch create mode 100644 queue-6.8/drm-amd-display-allocate-zero-bw-after-bw-alloc-enab.patch create mode 100644 queue-6.8/drm-amd-display-disable-seamless-boot-on-128b-132b-e.patch create mode 100644 queue-6.8/drm-amd-display-ensure-that-dmcub-support-flag-is-se.patch create mode 100644 queue-6.8/drm-amd-display-fix-dc-mode-screen-flickering-on-dcn.patch create mode 100644 queue-6.8/drm-amd-display-fix-potential-index-out-of-bounds-in.patch create mode 100644 queue-6.8/drm-amd-display-remove-redundant-condition-in-dcn35_.patch create mode 100644 queue-6.8/drm-amd-display-set-color_mgmt_changed-to-true-on-un.patch create mode 100644 queue-6.8/drm-amd-pm-restore-config-space-after-reset.patch create mode 100644 queue-6.8/drm-amdgpu-fix-the-ring-buffer-size-for-queue-vm-flu.patch create mode 100644 queue-6.8/drm-amdgpu-fix-vram-memory-accounting.patch create mode 100644 queue-6.8/drm-amdgpu-mes-fix-use-after-free-issue.patch create mode 100644 queue-6.8/drm-amdgpu-update-bo-eviction-priorities.patch create mode 100644 queue-6.8/drm-amdkfd-add-vram-accounting-for-svm-migration.patch create mode 100644 queue-6.8/drm-amdkfd-flush-the-process-wq-before-creating-a-kf.patch create mode 100644 queue-6.8/drm-arm-malidp-fix-a-possible-null-pointer-dereferen.patch create mode 100644 queue-6.8/drm-bridge-anx7625-don-t-log-an-error-when-dsi-host-.patch create mode 100644 queue-6.8/drm-bridge-anx7625-update-audio-status-while-detecti.patch create mode 100644 queue-6.8/drm-bridge-cdns-mhdp8546-fix-possible-null-pointer-d.patch create mode 100644 queue-6.8/drm-bridge-dpc3433-don-t-log-an-error-when-dsi-host-.patch create mode 100644 queue-6.8/drm-bridge-fix-improper-bridge-init-order-with-pre_e.patch create mode 100644 queue-6.8/drm-bridge-icn6211-don-t-log-an-error-when-dsi-host-.patch create mode 100644 queue-6.8/drm-bridge-lt8912b-don-t-log-an-error-when-dsi-host-.patch create mode 100644 queue-6.8/drm-bridge-lt9611-don-t-log-an-error-when-dsi-host-c.patch create mode 100644 queue-6.8/drm-bridge-lt9611uxc-don-t-log-an-error-when-dsi-hos.patch create mode 100644 queue-6.8/drm-bridge-tc358775-don-t-log-an-error-when-dsi-host.patch create mode 100644 queue-6.8/drm-ci-update-device-type-for-volteer-devices.patch create mode 100644 queue-6.8/drm-dp-don-t-attempt-aux-transfers-when-edp-panels-a.patch create mode 100644 queue-6.8/drm-edid-parse-topology-block-for-all-dispid-structu.patch create mode 100644 queue-6.8/drm-etnaviv-fix-tx-clock-gating-on-some-gc7000-varia.patch create mode 100644 queue-6.8/drm-imagination-avoid-woverflow-warning.patch create mode 100644 queue-6.8/drm-lcdif-do-not-disable-clocks-on-already-suspended.patch create mode 100644 queue-6.8/drm-mediatek-add-0-size-check-to-mtk_drm_gem_obj.patch create mode 100644 queue-6.8/drm-mediatek-init-ddp_comp-with-devm_kcalloc.patch create mode 100644 queue-6.8/drm-meson-vclk-fix-calculation-of-59.94-fractional-r.patch create mode 100644 queue-6.8/drm-mipi-dsi-use-correct-return-type-for-the-dsc-fun.patch create mode 100644 queue-6.8/drm-msm-dp-allow-voltage-swing-pre-emphasis-of-3.patch create mode 100644 queue-6.8/drm-msm-dp-avoid-a-long-timeout-for-aux-transfer-if-.patch create mode 100644 queue-6.8/drm-nouveau-dp-fix-incorrect-return-code-in-r535_dp_.patch create mode 100644 queue-6.8/drm-omapdrm-fix-console-by-implementing-fb_dirty.patch create mode 100644 queue-6.8/drm-omapdrm-fix-console-with-deferred-ops.patch create mode 100644 queue-6.8/drm-panel-atna33xc20-fix-unbalanced-regulator-in-the.patch create mode 100644 queue-6.8/drm-panel-ltk050h3146w-add-mipi_dsi_mode_video-to-lt.patch create mode 100644 queue-6.8/drm-panel-ltk050h3146w-drop-duplicate-commands-from-.patch create mode 100644 queue-6.8/drm-panel-novatek-nt35950-don-t-log-an-error-when-ds.patch create mode 100644 queue-6.8/drm-panel-simple-add-missing-innolux-g121x1-l03-form.patch create mode 100644 queue-6.8/drm-rockchip-vop2-do-not-divide-height-twice-for-yuv.patch create mode 100644 queue-6.8/drm-vc4-fix-possible-null-pointer-dereference.patch create mode 100644 queue-6.8/dt-bindings-rockchip-grf-add-missing-type-to-pcie-ph.patch create mode 100644 queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-add-loongs.patch create mode 100644 queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-fix-incorr.patch create mode 100644 queue-6.8/ecryptfs-fix-buffer-size-for-tag-66-packet.patch create mode 100644 queue-6.8/edac-skx_common-allow-decoding-of-sgx-addresses.patch create mode 100644 queue-6.8/edac-versal-do-not-register-for-noc-errors.patch create mode 100644 queue-6.8/enetc-avoid-truncating-error-message.patch create mode 100644 queue-6.8/epoll-be-better-about-file-lifetimes.patch create mode 100644 queue-6.8/eth-sungem-remove-.ndo_poll_controller-to-avoid-dead.patch create mode 100644 queue-6.8/ext4-avoid-excessive-credit-estimate-in-ext4_tmpfile.patch create mode 100644 queue-6.8/ext4-fix-potential-unnitialized-variable.patch create mode 100644 queue-6.8/ext4-remove-the-redundant-folio_wait_stable.patch create mode 100644 queue-6.8/fbdev-sh7760fb-allow-modular-build.patch create mode 100644 queue-6.8/fbdev-shmobile-fix-snprintf-truncation.patch create mode 100644 queue-6.8/fbdev-sisfb-hide-unused-variables.patch create mode 100644 queue-6.8/firmware-qcom-qcm-fix-unused-qcom_scm_qseecom_allowl.patch create mode 100644 queue-6.8/firmware-qcom-scm-fix-__scm-and-waitq-completion-var.patch create mode 100644 queue-6.8/firmware-raspberrypi-use-correct-device-for-dma-mapp.patch create mode 100644 queue-6.8/fpga-dfl-pci-add-pci-subdevice-id-for-intel-d5005-ca.patch create mode 100644 queue-6.8/gfs2-do_xmote-fixes.patch create mode 100644 queue-6.8/gfs2-don-t-forget-to-complete-delayed-withdraw.patch create mode 100644 queue-6.8/gfs2-finish_xmote-cleanup.patch create mode 100644 queue-6.8/gfs2-fix-ignore-unlock-failures-after-withdraw.patch create mode 100644 queue-6.8/gfs2-fix-potential-glock-use-after-free-on-unmount.patch create mode 100644 queue-6.8/gfs2-remove-ill-placed-consistency-check.patch create mode 100644 queue-6.8/gpio-nuvoton-fix-sgpio-irq-handle-error.patch create mode 100644 queue-6.8/hid-amd_sfh-handle-no-sensors-in-pm-operations.patch create mode 100644 queue-6.8/hid-intel-ish-hid-ipc-add-check-for-pci_alloc_irq_ve.patch create mode 100644 queue-6.8/hid-mcp-2221-cancel-delayed_work-only-when-config_ii.patch create mode 100644 queue-6.8/hid-nintendo-fix-n64-controller-being-identified-as-.patch create mode 100644 queue-6.8/hwrng-stm32-put-ip-into-rpm-suspend-on-failure.patch create mode 100644 queue-6.8/hwrng-stm32-repair-clock-handling.patch create mode 100644 queue-6.8/hwrng-stm32-use-logical-or-in-conditional.patch create mode 100644 queue-6.8/ib-mlx5-use-__iowrite64_copy-for-write-combining-sto.patch create mode 100644 queue-6.8/ice-fix-package-download-algorithm.patch create mode 100644 queue-6.8/ice-make-ice_vsi_cfg_rxq-static.patch create mode 100644 queue-6.8/ice-make-ice_vsi_cfg_txq-static.patch create mode 100644 queue-6.8/idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch create mode 100644 queue-6.8/input-amimouse-mark-driver-struct-with-__refdata-to-.patch create mode 100644 queue-6.8/input-xpad-add-support-for-asus-rog-raikiri.patch create mode 100644 queue-6.8/io-wq-write-next_work-before-dropping-acct_lock.patch create mode 100644 queue-6.8/io_uring-net-ensure-async-prep-handlers-always-initi.patch create mode 100644 queue-6.8/io_uring-net-fix-sendzc-lazy-wake-polling.patch create mode 100644 queue-6.8/io_uring-net-remove-dependency-on-req_f_partial_io-f.patch create mode 100644 queue-6.8/io_uring-use-the-right-type-for-work_llist-empty-che.patch create mode 100644 queue-6.8/iommu-undo-pasid-attachment-only-for-the-devices-tha.patch create mode 100644 queue-6.8/ipv6-sr-add-missing-seg6_local_exit.patch create mode 100644 queue-6.8/ipv6-sr-fix-incorrect-unregister-order.patch create mode 100644 queue-6.8/ipv6-sr-fix-invalid-unregister-error-path.patch create mode 100644 queue-6.8/irqchip-alpine-msi-fix-off-by-one-in-allocation-erro.patch create mode 100644 queue-6.8/irqchip-loongson-pch-msi-fix-off-by-one-on-allocatio.patch create mode 100644 queue-6.8/jffs2-prevent-xattr-node-from-overflowing-the-eraseb.patch create mode 100644 queue-6.8/kunit-bail-out-early-in-__kunit_test_suites_init-if-.patch create mode 100644 queue-6.8/kunit-fix-kthread-reference.patch create mode 100644 queue-6.8/kunit-fortify-fix-mismatched-kvalloc-vfree-usage.patch create mode 100644 queue-6.8/kunit-unregister-the-device-on-error.patch create mode 100644 queue-6.8/kvm-selftests-add-test-for-uaccesses-to-non-existent.patch create mode 100644 queue-6.8/l2tp-fix-icmp-error-handling-for-udp-encap-sockets.patch create mode 100644 queue-6.8/lib-test_hmm.c-handle-src_pfns-and-dst_pfns-allocati.patch create mode 100644 queue-6.8/libbpf-fix-error-message-in-attach_kprobe_multi.patch create mode 100644 queue-6.8/libbpf-prevent-null-pointer-dereference-when-prog-to.patch create mode 100644 queue-6.8/libfs-add-simple_offset_empty.patch create mode 100644 queue-6.8/libfs-add-simple_offset_rename-api.patch create mode 100644 queue-6.8/libfs-convert-simple-directory-offsets-to-use-a-mapl.patch create mode 100644 queue-6.8/libfs-define-a-minimum-directory-offset.patch create mode 100644 queue-6.8/libfs-fix-simple_offset_rename_exchange.patch create mode 100644 queue-6.8/libfs-re-arrange-locking-in-offset_iterate_dir.patch create mode 100644 queue-6.8/lkdtm-disable-cfi-checking-for-perms-functions.patch create mode 100644 queue-6.8/locking-atomic-x86-correct-the-definition-of-__arch_.patch create mode 100644 queue-6.8/loongarch-lately-init-pmu-after-smp-is-online.patch create mode 100644 queue-6.8/m68k-fix-spinlock-race-in-kernel-thread-creation.patch create mode 100644 queue-6.8/m68k-mac-fix-reboot-hang-on-mac-iici.patch create mode 100644 queue-6.8/macintosh-via-macii-fix-bug-sleeping-function-called.patch create mode 100644 queue-6.8/maple_tree-add-mtree_alloc_cyclic.patch create mode 100644 queue-6.8/md-fix-resync-softlockup-when-bitmap-size-is-less-th.patch create mode 100644 queue-6.8/media-atomisp-ssh_css-fix-a-null-pointer-dereference.patch create mode 100644 queue-6.8/media-cadence-csi2rx-configure-dphy-before-starting-.patch create mode 100644 queue-6.8/media-dt-bindings-ovti-ov2680-fix-the-power-supply-n.patch create mode 100644 queue-6.8/media-i2c-et8ek8-don-t-strip-remove-function-when-dr.patch create mode 100644 queue-6.8/media-ipu3-cio2-request-irq-earlier.patch create mode 100644 queue-6.8/media-ngene-add-dvb_ca_en50221_init-return-value-che.patch create mode 100644 queue-6.8/media-radio-shark2-avoid-led_names-truncations.patch create mode 100644 queue-6.8/media-rcar-vin-work-around-wenum-compare-conditional.patch create mode 100644 queue-6.8/media-uvcvideo-add-quirk-for-logitech-rally-bar.patch create mode 100644 queue-6.8/media-v4l2-subdev-fix-stream-handling-for-crop-api.patch create mode 100644 queue-6.8/mlx5-avoid-truncating-error-message.patch create mode 100644 queue-6.8/mlx5-stop-warning-for-64kb-pages.patch create mode 100644 queue-6.8/mm-ksm-fix-ksm-exec-support-for-prctl.patch create mode 100644 queue-6.8/mm-slub-kunit-use-inverted-data-to-corrupt-kmem-cach.patch create mode 100644 queue-6.8/mm-userfaultfd-do-not-place-zeropages-when-zeropages.patch create mode 100644 queue-6.8/modules-drop-the-.export_symbol-section-from-the-fin.patch create mode 100644 queue-6.8/mptcp-avoid-some-duplicate-code-in-socket-option-han.patch create mode 100644 queue-6.8/mptcp-cleanup-sol_tcp-handling.patch create mode 100644 queue-6.8/mptcp-cleanup-writer-wake-up.patch create mode 100644 queue-6.8/mptcp-fix-full-tcp-keep-alive-support.patch create mode 100644 queue-6.8/mptcp-implement-tcp_notsent_lowat-support.patch create mode 100644 queue-6.8/mptcp-so_keepalive-fix-getsockopt-support.patch create mode 100644 queue-6.8/mtd-core-report-error-if-first-mtd_otp_size-call-fai.patch create mode 100644 queue-6.8/mtd-rawnand-hynix-fixed-typo.patch create mode 100644 queue-6.8/net-bridge-mst-fix-vlan-use-after-free.patch create mode 100644 queue-6.8/net-bridge-xmit-make-sure-we-have-at-least-eth-heade.patch create mode 100644 queue-6.8/net-dsa-mv88e6xxx-add-support-for-model-specific-pre.patch create mode 100644 queue-6.8/net-dsa-mv88e6xxx-avoid-eeprom-timeout-without-eepro.patch create mode 100644 queue-6.8/net-ethernet-cortina-locking-fixes.patch create mode 100644 queue-6.8/net-ethernet-mediatek-split-tx-and-rx-fields-in-mtk_.patch create mode 100644 queue-6.8/net-ethernet-mediatek-use-admav1-instead-of-admav2.0.patch create mode 100644 queue-6.8/net-fec-remove-.ndo_poll_controller-to-avoid-deadloc.patch create mode 100644 queue-6.8/net-give-more-chances-to-rcu-in-netdev_wait_allrefs_.patch create mode 100644 queue-6.8/net-ipv6-fix-wrong-start-position-when-receive-hop-b.patch create mode 100644 queue-6.8/net-micrel-fix-receiving-the-timestamp-in-the-frame-.patch create mode 100644 queue-6.8/net-mlx5-add-a-timeout-to-acquire-the-command-queue-.patch create mode 100644 queue-6.8/net-mlx5-discard-command-completions-in-internal-err.patch create mode 100644 queue-6.8/net-mlx5-fix-peer-devlink-set-for-sf-representor-dev.patch create mode 100644 queue-6.8/net-mlx5-reload-only-ib-representors-upon-lag-disabl.patch create mode 100644 queue-6.8/net-openvswitch-fix-overwriting-ct-original-tuple-fo.patch create mode 100644 queue-6.8/net-qrtr-ns-fix-module-refcnt.patch create mode 100644 queue-6.8/net-stmmac-est-per-tx-queue-error-count-for-hlbf.patch create mode 100644 queue-6.8/net-stmmac-move-the-est-lock-to-struct-stmmac_priv.patch create mode 100644 queue-6.8/net-stmmac-offload-queuemaxsdu-from-tc-taprio.patch create mode 100644 queue-6.8/net-stmmac-report-taprio-offload-status.patch create mode 100644 queue-6.8/net-txgbe-fix-gpio-interrupt-blocking.patch create mode 100644 queue-6.8/net-txgbe-fix-to-clear-interrupt-status-after-handli.patch create mode 100644 queue-6.8/net-txgbe-fix-to-control-vlan-strip.patch create mode 100644 queue-6.8/net-txgbe-move-interrupt-codes-to-a-separate-file.patch create mode 100644 queue-6.8/net-txgbe-use-irq_domain-for-interrupt-controller.patch create mode 100644 queue-6.8/net-usb-qmi_wwan-add-telit-fn920c04-compositions.patch create mode 100644 queue-6.8/net-usb-smsc95xx-stop-lying-about-skb-truesize.patch create mode 100644 queue-6.8/net-usb-sr9700-stop-lying-about-skb-truesize.patch create mode 100644 queue-6.8/net-wangxun-fix-to-change-rx-features.patch create mode 100644 queue-6.8/net-wangxun-match-vlan-ctag-and-stag-features.patch create mode 100644 queue-6.8/netrom-fix-possible-dead-lock-in-nr_rt_ioctl.patch create mode 100644 queue-6.8/nfsd-don-t-create-nfsv4recoverydir-in-nfsdfs-when-no.patch create mode 100644 queue-6.8/nilfs2-fix-out-of-range-warning.patch create mode 100644 queue-6.8/nilfs2-make-superblock-data-array-index-computation-.patch create mode 100644 queue-6.8/null_blk-fix-missing-mutex_destroy-at-module-removal.patch create mode 100644 queue-6.8/nvme-cancel-pending-i-o-if-nvme-controller-is-in-ter.patch create mode 100644 queue-6.8/nvme-find-numa-distance-only-if-controller-has-valid.patch create mode 100644 queue-6.8/nvme-tcp-strict-pdu-pacing-to-avoid-send-stalls-on-t.patch create mode 100644 queue-6.8/nvmet-auth-replace-pr_debug-with-pr_err-to-report-an.patch create mode 100644 queue-6.8/nvmet-auth-return-the-error-code-to-the-nvmet_auth_h.patch create mode 100644 queue-6.8/nvmet-fix-nvme-status-code-when-namespace-is-disable.patch create mode 100644 queue-6.8/nvmet-prevent-sprintf-overflow-in-nvmet_subsys_nsid_.patch create mode 100644 queue-6.8/nvmet-tcp-fix-possible-memory-leak-when-tearing-down.patch create mode 100644 queue-6.8/of-module-add-buffer-overflow-check-in-of_modalias.patch create mode 100644 queue-6.8/openpromfs-finish-conversion-to-the-new-mount-api.patch create mode 100644 queue-6.8/openrisc-traps-don-t-send-signals-to-kernel-mode-thr.patch create mode 100644 queue-6.8/overflow-change-define_flex-to-take-__counted_by-mem.patch create mode 100644 queue-6.8/parisc-add-missing-export-of-__cmpxchg_u8.patch create mode 100644 queue-6.8/platform-x86-isst-add-grand-ridge-to-hpm-cpu-list.patch create mode 100644 queue-6.8/platform-x86-xiaomi-wmi-fix-race-condition-when-repo.patch create mode 100644 queue-6.8/powerpc-fsl-soc-hide-unused-const-variable.patch create mode 100644 queue-6.8/printk-let-no_printk-use-_printk.patch create mode 100644 queue-6.8/ptp-ocp-fix-dpll-functions.patch create mode 100644 queue-6.8/pwm-drop-duplicate-check-against-chip-npwm-in-of_pwm.patch create mode 100644 queue-6.8/pwm-drop-useless-member-.of_pwm_n_cells-of-struct-pw.patch create mode 100644 queue-6.8/pwm-fix-setting-period-with-pwm-cells-1-and-of_pwm_s.patch create mode 100644 queue-6.8/pwm-let-the-of_xlate-callbacks-accept-references-wit.patch create mode 100644 queue-6.8/pwm-meson-add-check-for-error-from-clk_round_rate.patch create mode 100644 queue-6.8/pwm-meson-change-prototype-of-a-few-helpers-to-prepa.patch create mode 100644 queue-6.8/pwm-meson-make-use-of-pwmchip_parent-accessor.patch create mode 100644 queue-6.8/pwm-meson-use-mul_u64_u64_div_u64-for-frequency-calc.patch create mode 100644 queue-6.8/pwm-provide-an-inline-function-to-get-the-parent-dev.patch create mode 100644 queue-6.8/pwm-reorder-symbols-in-core.c.patch create mode 100644 queue-6.8/pwm-sti-prepare-removing-pwm_chip-from-driver-data.patch create mode 100644 queue-6.8/pwm-sti-simplify-probe-function-using-devm-functions.patch create mode 100644 queue-6.8/qed-avoid-truncating-work-queue-length.patch create mode 100644 queue-6.8/rcu-fix-buffer-overflow-in-print_cpu_stall_info.patch create mode 100644 queue-6.8/rcu-tasks-fix-show_rcu_tasks_trace_gp_kthread-buffer.patch create mode 100644 queue-6.8/rdma-cma-fix-kmemleak-in-rdma_core-observed-during-b.patch create mode 100644 queue-6.8/rdma-hns-fix-deadlock-on-srq-async-events.patch create mode 100644 queue-6.8/rdma-hns-fix-gmv-table-pagesize.patch create mode 100644 queue-6.8/rdma-hns-fix-return-value-in-hns_roce_map_mr_sg.patch create mode 100644 queue-6.8/rdma-hns-fix-uaf-for-cq-async-event.patch create mode 100644 queue-6.8/rdma-hns-modify-the-print-level-of-cqe-error.patch create mode 100644 queue-6.8/rdma-hns-use-complete-parentheses-in-macros.patch create mode 100644 queue-6.8/rdma-ipoib-fix-format-truncation-compilation-errors.patch create mode 100644 queue-6.8/rdma-mana_ib-boundary-check-before-installing-cq-cal.patch create mode 100644 queue-6.8/rdma-mana_ib-introduce-helpers-to-create-and-destroy.patch create mode 100644 queue-6.8/rdma-mana_ib-use-struct-mana_ib_queue-for-cqs.patch create mode 100644 queue-6.8/rdma-mlx5-adding-remote-atomic-access-flag-to-updata.patch create mode 100644 queue-6.8/rdma-mlx5-change-check-for-cacheable-mkeys.patch create mode 100644 queue-6.8/rdma-mlx5-uncacheable-mkey-has-neither-rb_key-or-cac.patch create mode 100644 queue-6.8/rdma-rxe-allow-good-work-requests-to-be-executed.patch create mode 100644 queue-6.8/rdma-rxe-fix-incorrect-rxe_put-in-error-path.patch create mode 100644 queue-6.8/rdma-rxe-fix-seg-fault-in-rxe_comp_queue_pkt.patch create mode 100644 queue-6.8/regulator-irq_helpers-duplicate-irq-name.patch create mode 100644 queue-6.8/regulator-qcom-refgen-fix-module-autoloading.patch create mode 100644 queue-6.8/regulator-vqmmc-ipq4019-fix-module-autoloading.patch create mode 100644 queue-6.8/revert-net-txgbe-fix-clk_name-exceed-max_dev_id-limi.patch create mode 100644 queue-6.8/revert-net-txgbe-fix-i2c-dev-name-cannot-match-clkde.patch create mode 100644 queue-6.8/revert-sh-handle-calling-csum_partial-with-misaligne.patch create mode 100644 queue-6.8/riscv-bpf-make-some-atomic-operations-fully-ordered.patch create mode 100644 queue-6.8/riscv-t-head-test-availability-bit-before-enabling-m.patch create mode 100644 queue-6.8/riscv-thead-rename-t-head-pbmt-to-mae.patch create mode 100644 queue-6.8/s390-bpf-emit-a-barrier-for-bpf_fetch-instructions.patch create mode 100644 queue-6.8/s390-cio-fix-tracepoint-subchannel-type-field.patch create mode 100644 queue-6.8/s390-mm-re-enable-the-shared-zeropage-for-pv-and-ske.patch create mode 100644 queue-6.8/samples-landlock-fix-incorrect-free-in-populate_rule.patch create mode 100644 queue-6.8/sched-core-fix-incorrect-initialization-of-the-burst.patch create mode 100644 queue-6.8/sched-fair-add-eas-checks-before-updating-root_domai.patch create mode 100644 queue-6.8/sched-fair-allow-disabling-sched_balance_newidle-wit.patch create mode 100644 queue-6.8/sched-isolation-fix-boot-crash-when-maxcpus-first-ho.patch create mode 100644 queue-6.8/scsi-bfa-ensure-the-copied-buf-is-nul-terminated.patch create mode 100644 queue-6.8/scsi-hpsa-fix-allocation-size-for-scsi_host-private-.patch create mode 100644 queue-6.8/scsi-libsas-fix-the-failure-of-adding-phy-with-zero-.patch create mode 100644 queue-6.8/scsi-qedf-ensure-the-copied-buf-is-nul-terminated.patch create mode 100644 queue-6.8/scsi-qla2xxx-fix-debugfs-output-for-fw_resource_coun.patch create mode 100644 queue-6.8/scsi-ufs-cdns-pltfrm-perform-read-back-after-writing.patch create mode 100644 queue-6.8/scsi-ufs-core-mcq-fix-ufshcd_mcq_sqe_search.patch create mode 100644 queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-inte.patch create mode 100644 queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-uic_.patch create mode 100644 queue-6.8/scsi-ufs-core-perform-read-back-after-writing-utp_ta.patch create mode 100644 queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-cgc-en.patch create mode 100644 queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reg_uf.patch create mode 100644 queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reset-.patch create mode 100644 queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-unipro.patch create mode 100644 queue-6.8/selftests-binderfs-use-the-makefile-s-rules-not-make.patch create mode 100644 queue-6.8/selftests-bpf-fix-a-fd-leak-in-error-paths-in-open_n.patch create mode 100644 queue-6.8/selftests-bpf-fix-pointer-arithmetic-in-test_xdp_do_.patch create mode 100644 queue-6.8/selftests-bpf-fix-umount-cgroup2-error-in-test_sockm.patch create mode 100644 queue-6.8/selftests-bpf-run-cgroup1_hierarchy-test-in-own-moun.patch create mode 100644 queue-6.8/selftests-cgroup-skip-test_cgcore_lesser_ns_open-whe.patch create mode 100644 queue-6.8/selftests-damon-_damon_sysfs-check-errors-from-nr_sc.patch create mode 100644 queue-6.8/selftests-default-to-host-arch-for-llvm-builds.patch create mode 100644 queue-6.8/selftests-kcmp-remove-unused-open-mode.patch create mode 100644 queue-6.8/selftests-net-add-missing-config-for-amt.sh.patch create mode 100644 queue-6.8/selftests-net-bridge-increase-igmp-mld-exclude-timeo.patch create mode 100644 queue-6.8/selftests-net-lib-no-need-to-record-ns-name-if-it-al.patch create mode 100644 queue-6.8/selftests-net-move-amt-to-socat-for-better-compatibi.patch create mode 100644 queue-6.8/selftests-resctrl-fix-clang-build-failure-use-local_.patch create mode 100644 queue-6.8/selftests-sud_test-return-correct-emulated-syscall-v.patch create mode 100644 queue-6.8/sh-kprobes-merge-arch_copy_kprobe-into-arch_prepare_.patch create mode 100644 queue-6.8/shmem-fix-shmem_rename2.patch create mode 100644 queue-6.8/soc-mediatek-cmdq-fix-typo-of-cmdq_jump_relative.patch create mode 100644 queue-6.8/soc-qcom-pmic_glink-don-t-traverse-clients-list-with.patch create mode 100644 queue-6.8/soc-qcom-pmic_glink-make-client-lock-non-sleeping.patch create mode 100644 queue-6.8/soc-qcom-pmic_glink-notify-clients-about-the-current.patch create mode 100644 queue-6.8/softirq-fix-suspicious-rcu-usage-in-__do_softirq.patch create mode 100644 queue-6.8/staging-media-starfive-remove-links-when-unregisteri.patch create mode 100644 queue-6.8/sunrpc-fix-gss_free_in_token_pages.patch create mode 100644 queue-6.8/sunrpc-removed-redundant-procp-check.patch create mode 100644 queue-6.8/tcp-avoid-premature-drops-in-tcp_add_backlog.patch create mode 100644 queue-6.8/tcp-increase-the-default-tcp-scaling-ratio.patch create mode 100644 queue-6.8/thermal-debugfs-avoid-excessive-updates-of-trip-poin.patch create mode 100644 queue-6.8/thermal-debugfs-create-records-for-cdev-states-as-th.patch create mode 100644 queue-6.8/thermal-debugfs-pass-cooling-device-state-to-thermal.patch create mode 100644 queue-6.8/thermal-drivers-mediatek-lvts_thermal-add-coeff-for-.patch create mode 100644 queue-6.8/thermal-drivers-tsens-fix-null-pointer-dereference.patch create mode 100644 queue-6.8/tracing-user_events-fix-non-spaced-field-matching.patch create mode 100644 queue-6.8/tracing-user_events-prepare-find-delete-for-same-nam.patch create mode 100644 queue-6.8/udp-avoid-call-to-compute_score-on-multiple-sites.patch create mode 100644 queue-6.8/usb-aqc111-stop-lying-about-skb-truesize.patch create mode 100644 queue-6.8/virt-acrn-stop-using-follow_pfn.patch create mode 100644 queue-6.8/wifi-ar5523-enable-proper-endpoint-verification.patch create mode 100644 queue-6.8/wifi-ath10k-fix-an-error-code-problem-in-ath10k_dbg_.patch create mode 100644 queue-6.8/wifi-ath10k-poll-service-ready-message-before-failin.patch create mode 100644 queue-6.8/wifi-ath10k-populate-board-data-for-wcn3990.patch create mode 100644 queue-6.8/wifi-ath11k-don-t-force-enable-power-save-on-non-run.patch create mode 100644 queue-6.8/wifi-ath12k-fix-out-of-bound-access-of-qmi_invoke_ha.patch create mode 100644 queue-6.8/wifi-ath12k-use-correct-flag-field-for-320-mhz-chann.patch create mode 100644 queue-6.8/wifi-brcmfmac-pcie-handle-randbuf-allocation-failure.patch create mode 100644 queue-6.8/wifi-carl9170-add-a-proper-sanity-check-for-endpoint.patch create mode 100644 queue-6.8/wifi-carl9170-re-fix-fortified-memset-warning.patch create mode 100644 queue-6.8/wifi-cfg80211-fix-the-order-of-arguments-for-trace-e.patch create mode 100644 queue-6.8/wifi-ieee80211-fix-ieee80211_mle_basic_sta_prof_size.patch create mode 100644 queue-6.8/wifi-iwlwifi-implement-can_activate_links-callback.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-allocate-sta-links-only-for-active-.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-do-not-warn-on-invalid-link-on-scan.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-fix-active-link-counting-during-rec.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-fix-check-in-iwl_mvm_sta_fw_id_mask.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-init-vif-works-only-once.patch create mode 100644 queue-6.8/wifi-iwlwifi-mvm-select-sta-mask-only-for-active-lin.patch create mode 100644 queue-6.8/wifi-iwlwifi-reconfigure-tlc-during-hw-restart.patch create mode 100644 queue-6.8/wifi-mac80211-don-t-select-link-id-if-not-provided-i.patch create mode 100644 queue-6.8/wifi-mac80211-don-t-use-rate-mask-for-scanning.patch create mode 100644 queue-6.8/wifi-mac80211-ensure-beacon-is-non-s1g-prior-to-extr.patch create mode 100644 queue-6.8/wifi-mt76-mt7603-add-wpdma-tx-eof-flag-for-pse-clien.patch create mode 100644 queue-6.8/wifi-mt76-mt7603-fix-tx-queue-of-loopback-packets.patch create mode 100644 queue-6.8/wifi-mt76-mt7915-workaround-too-long-expansion-spars.patch create mode 100644 queue-6.8/wifi-mt76-mt7925-ensure-4-byte-alignment-for-suspend.patch create mode 100644 queue-6.8/wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch create mode 100644 queue-6.8/wifi-mt76-mt7996-fix-size-of-txpower-mcu-command.patch create mode 100644 queue-6.8/wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch create mode 100644 queue-6.8/wifi-mwl8k-initialize-cmd-addr-properly.patch create mode 100644 queue-6.8/wifi-nl80211-avoid-address-calculations-via-out-of-b.patch create mode 100644 queue-6.8/wifi-rtw89-wow-refine-wowlan-flows-of-hci-interrupts.patch create mode 100644 queue-6.8/x86-boot-64-clear-most-of-cr4-in-startup_64-except-p.patch create mode 100644 queue-6.8/x86-boot-ignore-relocations-in-.notes-sections-in-wa.patch create mode 100644 queue-6.8/x86-insn-add-vex-versions-of-vpdpbusd-vpdpbusds-vpdp.patch create mode 100644 queue-6.8/x86-insn-fix-push-instruction-in-x86-instruction-dec.patch create mode 100644 queue-6.8/x86-microcode-amd-avoid-wformat-warning-with-clang-1.patch create mode 100644 queue-6.8/x86-mm-remove-broken-vsyscall-emulation-code-from-th.patch create mode 100644 queue-6.8/x86-numa-fix-srat-lookup-of-cfmws-ranges-with-numa_f.patch create mode 100644 queue-6.8/x86-pat-fix-w-x-violation-false-positives-when-runni.patch create mode 100644 queue-6.8/x86-pat-introduce-lookup_address_in_pgd_attr.patch create mode 100644 queue-6.8/x86-pat-restructure-_lookup_address_cpa.patch create mode 100644 queue-6.8/x86-purgatory-switch-to-the-position-independent-sma.patch diff --git a/queue-6.8/acpi-bus-indicate-support-for-_tfp-thru-_osc.patch b/queue-6.8/acpi-bus-indicate-support-for-_tfp-thru-_osc.patch new file mode 100644 index 00000000000..e764213ee28 --- /dev/null +++ b/queue-6.8/acpi-bus-indicate-support-for-_tfp-thru-_osc.patch @@ -0,0 +1,52 @@ +From 27e388f47f8a444f6e86c2df3582fec219cfaa32 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 21:13:06 +0100 +Subject: ACPI: bus: Indicate support for _TFP thru _OSC + +From: Armin Wolf + +[ Upstream commit 95d43290f1e476b3be782dd17642e452d0436266 ] + +The ACPI thermal driver already uses the _TPF ACPI method to retrieve +precise sampling time values, but this is not reported thru _OSC. + +Fix this by setting bit 9 ("Fast Thermal Sampling support") when +evaluating _OSC. + +Fixes: a2ee7581afd5 ("ACPI: thermal: Add Thermal fast Sampling Period (_TFP) support") +Signed-off-by: Armin Wolf +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/bus.c | 2 ++ + include/linux/acpi.h | 1 + + 2 files changed, 3 insertions(+) + +diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c +index 569bd15f211be..9c5fc12fc13cb 100644 +--- a/drivers/acpi/bus.c ++++ b/drivers/acpi/bus.c +@@ -316,6 +316,8 @@ static void acpi_bus_osc_negotiate_platform_control(void) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PAD_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_PROCESSOR)) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PPC_OST_SUPPORT; ++ if (IS_ENABLED(CONFIG_ACPI_THERMAL)) ++ capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_FAST_THERMAL_SAMPLING_SUPPORT; + + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT; +diff --git a/include/linux/acpi.h b/include/linux/acpi.h +index b7165e52b3c68..e4f4fb67ab55a 100644 +--- a/include/linux/acpi.h ++++ b/include/linux/acpi.h +@@ -573,6 +573,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context); + #define OSC_SB_CPCV2_SUPPORT 0x00000040 + #define OSC_SB_PCLPI_SUPPORT 0x00000080 + #define OSC_SB_OSLPI_SUPPORT 0x00000100 ++#define OSC_SB_FAST_THERMAL_SAMPLING_SUPPORT 0x00000200 + #define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT 0x00001000 + #define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00002000 + #define OSC_SB_CPC_FLEXIBLE_ADR_SPACE 0x00004000 +-- +2.43.0 + diff --git a/queue-6.8/acpi-bus-indicate-support-for-irq-resourcesource-thr.patch b/queue-6.8/acpi-bus-indicate-support-for-irq-resourcesource-thr.patch new file mode 100644 index 00000000000..255fbf442d0 --- /dev/null +++ b/queue-6.8/acpi-bus-indicate-support-for-irq-resourcesource-thr.patch @@ -0,0 +1,51 @@ +From 2d578f620a8d82378ec6344fc49ad1bf573020ae Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 21:13:10 +0100 +Subject: ACPI: bus: Indicate support for IRQ ResourceSource thru _OSC + +From: Armin Wolf + +[ Upstream commit 403ad17c06509794fdf6e4d4b3070bd5b56e2a8e ] + +The ACPI IRQ mapping code supports parsing of ResourceSource, +but this is not reported thru _OSC. + +Fix this by setting bit 13 ("Interrupt ResourceSource support") +when evaluating _OSC. + +Fixes: d44fa3d46079 ("ACPI: Add support for ResourceSource/IRQ domain mapping") +Signed-off-by: Armin Wolf +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/bus.c | 1 + + include/linux/acpi.h | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c +index 9486c1be7258e..3f84d8ed9d299 100644 +--- a/drivers/acpi/bus.c ++++ b/drivers/acpi/bus.c +@@ -323,6 +323,7 @@ static void acpi_bus_osc_negotiate_platform_control(void) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_OVER_16_PSTATES_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_GED_SUPPORT; ++ capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_IRQ_RESOURCE_SOURCE_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_PRMT)) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PRM_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_FFH)) +diff --git a/include/linux/acpi.h b/include/linux/acpi.h +index 01ff2dd313680..de1263b1da3bc 100644 +--- a/include/linux/acpi.h ++++ b/include/linux/acpi.h +@@ -577,6 +577,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context); + #define OSC_SB_OVER_16_PSTATES_SUPPORT 0x00000400 + #define OSC_SB_GED_SUPPORT 0x00000800 + #define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT 0x00001000 ++#define OSC_SB_IRQ_RESOURCE_SOURCE_SUPPORT 0x00002000 + #define OSC_SB_CPC_FLEXIBLE_ADR_SPACE 0x00004000 + #define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00020000 + #define OSC_SB_NATIVE_USB4_SUPPORT 0x00040000 +-- +2.43.0 + diff --git a/queue-6.8/acpi-bus-indicate-support-for-more-than-16-p-states-.patch b/queue-6.8/acpi-bus-indicate-support-for-more-than-16-p-states-.patch new file mode 100644 index 00000000000..e31a1afcbf8 --- /dev/null +++ b/queue-6.8/acpi-bus-indicate-support-for-more-than-16-p-states-.patch @@ -0,0 +1,51 @@ +From 2d05f7e9f8f34c609ed3928fe739b37962bb53a5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 21:13:07 +0100 +Subject: ACPI: bus: Indicate support for more than 16 p-states thru _OSC + +From: Armin Wolf + +[ Upstream commit 6e8345f23ca37d6d41bb76be5d6a705ddf542817 ] + +The code responsible for parsing the available p-states should +have no problems handling more than 16 p-states. + +Indicate this by setting bit 10 ("Greater Than 16 p-state support") +when evaluating _OSC. + +Signed-off-by: Armin Wolf +Signed-off-by: Rafael J. Wysocki +Stable-dep-of: a8a967a243d7 ("ACPI: bus: Indicate support for the Generic Event Device thru _OSC") +Signed-off-by: Sasha Levin +--- + drivers/acpi/bus.c | 1 + + include/linux/acpi.h | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c +index 9c5fc12fc13cb..aee91fa2a4596 100644 +--- a/drivers/acpi/bus.c ++++ b/drivers/acpi/bus.c +@@ -321,6 +321,7 @@ static void acpi_bus_osc_negotiate_platform_control(void) + + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT; ++ capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_OVER_16_PSTATES_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_PRMT)) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PRM_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_FFH)) +diff --git a/include/linux/acpi.h b/include/linux/acpi.h +index e4f4fb67ab55a..7658d06b5bccf 100644 +--- a/include/linux/acpi.h ++++ b/include/linux/acpi.h +@@ -574,6 +574,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context); + #define OSC_SB_PCLPI_SUPPORT 0x00000080 + #define OSC_SB_OSLPI_SUPPORT 0x00000100 + #define OSC_SB_FAST_THERMAL_SAMPLING_SUPPORT 0x00000200 ++#define OSC_SB_OVER_16_PSTATES_SUPPORT 0x00000400 + #define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT 0x00001000 + #define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00002000 + #define OSC_SB_CPC_FLEXIBLE_ADR_SPACE 0x00004000 +-- +2.43.0 + diff --git a/queue-6.8/acpi-bus-indicate-support-for-the-generic-event-devi.patch b/queue-6.8/acpi-bus-indicate-support-for-the-generic-event-devi.patch new file mode 100644 index 00000000000..317d547376f --- /dev/null +++ b/queue-6.8/acpi-bus-indicate-support-for-the-generic-event-devi.patch @@ -0,0 +1,52 @@ +From d33b9162618cfa189da51f5f961e2a6e7c919f2c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 21:13:08 +0100 +Subject: ACPI: bus: Indicate support for the Generic Event Device thru _OSC + +From: Armin Wolf + +[ Upstream commit a8a967a243d71dd635ede076020f665a4df51c63 ] + +A device driver for the Generic Event Device (ACPI0013) already +exists for quite some time, but support for it was never reported +thru _OSC. + +Fix this by setting bit 11 ("Generic Event Device support") when +evaluating _OSC. + +Fixes: 3db80c230da1 ("ACPI: implement Generic Event Device") +Signed-off-by: Armin Wolf +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/bus.c | 1 + + include/linux/acpi.h | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c +index aee91fa2a4596..9486c1be7258e 100644 +--- a/drivers/acpi/bus.c ++++ b/drivers/acpi/bus.c +@@ -322,6 +322,7 @@ static void acpi_bus_osc_negotiate_platform_control(void) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT; + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_OVER_16_PSTATES_SUPPORT; ++ capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_GED_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_PRMT)) + capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PRM_SUPPORT; + if (IS_ENABLED(CONFIG_ACPI_FFH)) +diff --git a/include/linux/acpi.h b/include/linux/acpi.h +index 7658d06b5bccf..60517f4650a3b 100644 +--- a/include/linux/acpi.h ++++ b/include/linux/acpi.h +@@ -575,6 +575,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context); + #define OSC_SB_OSLPI_SUPPORT 0x00000100 + #define OSC_SB_FAST_THERMAL_SAMPLING_SUPPORT 0x00000200 + #define OSC_SB_OVER_16_PSTATES_SUPPORT 0x00000400 ++#define OSC_SB_GED_SUPPORT 0x00000800 + #define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT 0x00001000 + #define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00002000 + #define OSC_SB_CPC_FLEXIBLE_ADR_SPACE 0x00004000 +-- +2.43.0 + diff --git a/queue-6.8/acpi-disable-wstringop-truncation.patch b/queue-6.8/acpi-disable-wstringop-truncation.patch new file mode 100644 index 00000000000..89afd59c057 --- /dev/null +++ b/queue-6.8/acpi-disable-wstringop-truncation.patch @@ -0,0 +1,48 @@ +From 8e84bb57fdd9cfc14962b0d31c8891a56c56f725 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 16:00:55 +0200 +Subject: ACPI: disable -Wstringop-truncation + +From: Arnd Bergmann + +[ Upstream commit a3403d304708f60565582d60af4316289d0316a0 ] + +gcc -Wstringop-truncation warns about copying a string that results in a +missing nul termination: + +drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table': +drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation] + 60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation] + 61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +The code works as intended, and the warning could be addressed by using +a memcpy(), but turning the warning off for this file works equally well +and may be easier to merge. + +Fixes: 47c08729bf1c ("ACPICA: Fix for LoadTable operator, input strings") +Link: https://lore.kernel.org/lkml/CAJZ5v0hoUfv54KW7y4223Mn9E7D4xvR7whRFNLTBqCZMUxT50Q@mail.gmail.com/#t +Signed-off-by: Arnd Bergmann +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/acpica/Makefile | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/acpi/acpica/Makefile b/drivers/acpi/acpica/Makefile +index 30f3fc13c29d1..8d18af396de92 100644 +--- a/drivers/acpi/acpica/Makefile ++++ b/drivers/acpi/acpica/Makefile +@@ -5,6 +5,7 @@ + + ccflags-y := -D_LINUX -DBUILDING_ACPICA + ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT ++CFLAGS_tbfind.o += $(call cc-disable-warning, stringop-truncation) + + # use acpi.o to put all files here into acpi.o modparam namespace + obj-y += acpi.o +-- +2.43.0 + diff --git a/queue-6.8/acpi-fix-generic-initiator-affinity-_osc-bit.patch b/queue-6.8/acpi-fix-generic-initiator-affinity-_osc-bit.patch new file mode 100644 index 00000000000..211ce3a3dc0 --- /dev/null +++ b/queue-6.8/acpi-fix-generic-initiator-affinity-_osc-bit.patch @@ -0,0 +1,40 @@ +From 707d70359d0f2c5befaef7f2dc3a41e758ddbca6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 21:13:09 +0100 +Subject: ACPI: Fix Generic Initiator Affinity _OSC bit + +From: Armin Wolf + +[ Upstream commit d0d4f1474e36b195eaad477373127ae621334c01 ] + +The ACPI spec says bit 17 should be used to indicate support +for Generic Initiator Affinity Structure in SRAT, but we currently +set bit 13 ("Interrupt ResourceSource support"). + +Fix this by actually setting bit 17 when evaluating _OSC. + +Fixes: 01aabca2fd54 ("ACPI: Let ACPI know we support Generic Initiator Affinity Structures") +Signed-off-by: Armin Wolf +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + include/linux/acpi.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/acpi.h b/include/linux/acpi.h +index 60517f4650a3b..01ff2dd313680 100644 +--- a/include/linux/acpi.h ++++ b/include/linux/acpi.h +@@ -577,8 +577,8 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context); + #define OSC_SB_OVER_16_PSTATES_SUPPORT 0x00000400 + #define OSC_SB_GED_SUPPORT 0x00000800 + #define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT 0x00001000 +-#define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00002000 + #define OSC_SB_CPC_FLEXIBLE_ADR_SPACE 0x00004000 ++#define OSC_SB_GENERIC_INITIATOR_SUPPORT 0x00020000 + #define OSC_SB_NATIVE_USB4_SUPPORT 0x00040000 + #define OSC_SB_PRM_SUPPORT 0x00200000 + #define OSC_SB_FFH_OPR_SUPPORT 0x00400000 +-- +2.43.0 + diff --git a/queue-6.8/acpi-lpss-advertise-number-of-chip-selects-via-prope.patch b/queue-6.8/acpi-lpss-advertise-number-of-chip-selects-via-prope.patch new file mode 100644 index 00000000000..776b9daebda --- /dev/null +++ b/queue-6.8/acpi-lpss-advertise-number-of-chip-selects-via-prope.patch @@ -0,0 +1,35 @@ +From 3c9d0a5dc4161b4c747b121f3eb521489e113564 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 4 Apr 2024 15:06:58 +0300 +Subject: ACPI: LPSS: Advertise number of chip selects via property + +From: Andy Shevchenko + +[ Upstream commit 07b73ee599428b41d0240f2f7b31b524eba07dd0 ] + +Advertise number of chip selects via property for Intel Braswell. + +Fixes: 620c803f42de ("ACPI: LPSS: Provide an SSP type to the driver") +Signed-off-by: Andy Shevchenko +Reviewed-by: Kuppuswamy Sathyanarayanan +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/acpi/acpi_lpss.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c +index 04e273167e92a..8e01792228d1e 100644 +--- a/drivers/acpi/acpi_lpss.c ++++ b/drivers/acpi/acpi_lpss.c +@@ -325,6 +325,7 @@ static const struct lpss_device_desc bsw_i2c_dev_desc = { + + static const struct property_entry bsw_spi_properties[] = { + PROPERTY_ENTRY_U32("intel,spi-pxa2xx-type", LPSS_BSW_SSP), ++ PROPERTY_ENTRY_U32("num-cs", 2), + { } + }; + +-- +2.43.0 + diff --git a/queue-6.8/af_packet-do-not-call-packet_read_pending-from-tpack.patch b/queue-6.8/af_packet-do-not-call-packet_read_pending-from-tpack.patch new file mode 100644 index 00000000000..65eecf69ed9 --- /dev/null +++ b/queue-6.8/af_packet-do-not-call-packet_read_pending-from-tpack.patch @@ -0,0 +1,49 @@ +From ba5d49f83f3062590a0635a208feda1a803f8459 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 15 May 2024 16:33:58 +0000 +Subject: af_packet: do not call packet_read_pending() from + tpacket_destruct_skb() + +From: Eric Dumazet + +[ Upstream commit 581073f626e387d3e7eed55c48c8495584ead7ba ] + +trafgen performance considerably sank on hosts with many cores +after the blamed commit. + +packet_read_pending() is very expensive, and calling it +in af_packet fast path defeats Daniel intent in commit +b013840810c2 ("packet: use percpu mmap tx frame pending refcount") + +tpacket_destruct_skb() makes room for one packet, we can immediately +wakeup a producer, no need to completely drain the tx ring. + +Fixes: 89ed5b519004 ("af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET") +Signed-off-by: Eric Dumazet +Cc: Neil Horman +Cc: Daniel Borkmann +Reviewed-by: Willem de Bruijn +Link: https://lore.kernel.org/r/20240515163358.4105915-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/packet/af_packet.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c +index e6a8701a38dbe..91c9dc0108a2d 100644 +--- a/net/packet/af_packet.c ++++ b/net/packet/af_packet.c +@@ -2522,8 +2522,7 @@ static void tpacket_destruct_skb(struct sk_buff *skb) + ts = __packet_set_timestamp(po, ph, skb); + __packet_set_status(po, ph, TP_STATUS_AVAILABLE | ts); + +- if (!packet_read_pending(&po->tx_ring)) +- complete(&po->skb_completion); ++ complete(&po->skb_completion); + } + + sock_wfree(skb); +-- +2.43.0 + diff --git a/queue-6.8/af_unix-fix-data-races-in-unix_release_sock-unix_str.patch b/queue-6.8/af_unix-fix-data-races-in-unix_release_sock-unix_str.patch new file mode 100644 index 00000000000..2ab40984854 --- /dev/null +++ b/queue-6.8/af_unix-fix-data-races-in-unix_release_sock-unix_str.patch @@ -0,0 +1,76 @@ +From 0fc774a6b713faa7902f7d58ac0791d756beb7df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 01:14:46 -0700 +Subject: af_unix: Fix data races in unix_release_sock/unix_stream_sendmsg + +From: Breno Leitao + +[ Upstream commit 540bf24fba16b88c1b3b9353927204b4f1074e25 ] + +A data-race condition has been identified in af_unix. In one data path, +the write function unix_release_sock() atomically writes to +sk->sk_shutdown using WRITE_ONCE. However, on the reader side, +unix_stream_sendmsg() does not read it atomically. Consequently, this +issue is causing the following KCSAN splat to occur: + + BUG: KCSAN: data-race in unix_release_sock / unix_stream_sendmsg + + write (marked) to 0xffff88867256ddbb of 1 bytes by task 7270 on cpu 28: + unix_release_sock (net/unix/af_unix.c:640) + unix_release (net/unix/af_unix.c:1050) + sock_close (net/socket.c:659 net/socket.c:1421) + __fput (fs/file_table.c:422) + __fput_sync (fs/file_table.c:508) + __se_sys_close (fs/open.c:1559 fs/open.c:1541) + __x64_sys_close (fs/open.c:1541) + x64_sys_call (arch/x86/entry/syscall_64.c:33) + do_syscall_64 (arch/x86/entry/common.c:?) + entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130) + + read to 0xffff88867256ddbb of 1 bytes by task 989 on cpu 14: + unix_stream_sendmsg (net/unix/af_unix.c:2273) + __sock_sendmsg (net/socket.c:730 net/socket.c:745) + ____sys_sendmsg (net/socket.c:2584) + __sys_sendmmsg (net/socket.c:2638 net/socket.c:2724) + __x64_sys_sendmmsg (net/socket.c:2753 net/socket.c:2750 net/socket.c:2750) + x64_sys_call (arch/x86/entry/syscall_64.c:33) + do_syscall_64 (arch/x86/entry/common.c:?) + entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130) + + value changed: 0x01 -> 0x03 + +The line numbers are related to commit dd5a440a31fa ("Linux 6.9-rc7"). + +Commit e1d09c2c2f57 ("af_unix: Fix data races around sk->sk_shutdown.") +addressed a comparable issue in the past regarding sk->sk_shutdown. +However, it overlooked resolving this particular data path. +This patch only offending unix_stream_sendmsg() function, since the +other reads seem to be protected by unix_state_lock() as discussed in +Link: https://lore.kernel.org/all/20240508173324.53565-1-kuniyu@amazon.com/ + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Signed-off-by: Breno Leitao +Reviewed-by: Kuniyuki Iwashima +Link: https://lore.kernel.org/r/20240509081459.2807828-1-leitao@debian.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/unix/af_unix.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c +index 9df15a7bc2569..eb90a255507ef 100644 +--- a/net/unix/af_unix.c ++++ b/net/unix/af_unix.c +@@ -2209,7 +2209,7 @@ static int unix_stream_sendmsg(struct socket *sock, struct msghdr *msg, + goto out_err; + } + +- if (sk->sk_shutdown & SEND_SHUTDOWN) ++ if (READ_ONCE(sk->sk_shutdown) & SEND_SHUTDOWN) + goto pipe_err; + + while (sent < len) { +-- +2.43.0 + diff --git a/queue-6.8/alsa-emu10k1-make-e-mu-fpga-writes-potentially-more-.patch b/queue-6.8/alsa-emu10k1-make-e-mu-fpga-writes-potentially-more-.patch new file mode 100644 index 00000000000..85dc0f0e821 --- /dev/null +++ b/queue-6.8/alsa-emu10k1-make-e-mu-fpga-writes-potentially-more-.patch @@ -0,0 +1,40 @@ +From af3facde327d95a30aeb2a63a02f594c491e802e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 28 Apr 2024 11:37:16 +0200 +Subject: ALSA: emu10k1: make E-MU FPGA writes potentially more reliable + +From: Oswald Buddenhagen + +[ Upstream commit 15c7e87aa88f0ab2d51c2e2123b127a6d693ca21 ] + +We did not delay after the second strobe signal, so another immediately +following access could potentially corrupt the written value. + +This is a purely speculative fix with no supporting evidence, but after +taking out the spinlocks around the writes, it seems plausible that a +modern processor could be actually too fast. Also, it's just cleaner to +be consistent. + +Signed-off-by: Oswald Buddenhagen +Signed-off-by: Takashi Iwai +Message-ID: <20240428093716.3198666-7-oswald.buddenhagen@gmx.de> +Signed-off-by: Sasha Levin +--- + sound/pci/emu10k1/io.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c +index 74df2330015f6..5cb8acf5b158c 100644 +--- a/sound/pci/emu10k1/io.c ++++ b/sound/pci/emu10k1/io.c +@@ -285,6 +285,7 @@ static void snd_emu1010_fpga_write_locked(struct snd_emu10k1 *emu, u32 reg, u32 + outw(value, emu->port + A_GPIO); + udelay(10); + outw(value | 0x80 , emu->port + A_GPIO); /* High bit clocks the value into the fpga. */ ++ udelay(10); + } + + void snd_emu1010_fpga_write(struct snd_emu10k1 *emu, u32 reg, u32 value) +-- +2.43.0 + diff --git a/queue-6.8/alsa-hda-cs35l41-remove-speaker-id-for-lenovo-legion.patch b/queue-6.8/alsa-hda-cs35l41-remove-speaker-id-for-lenovo-legion.patch new file mode 100644 index 00000000000..197d8698c78 --- /dev/null +++ b/queue-6.8/alsa-hda-cs35l41-remove-speaker-id-for-lenovo-legion.patch @@ -0,0 +1,44 @@ +From 0a0030494234ddfda2cb78e817afc6ac16243fbb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 12:08:13 +0100 +Subject: ALSA: hda: cs35l41: Remove Speaker ID for Lenovo Legion slim 7 + 16ARHA7 + +From: Stefan Binding + +[ Upstream commit 4a1a8065f5d3565677347d34a908ff2d0803b14f ] + +These laptops do not have _DSD and must be added by configuration +table, however, the initial entries for them are incorrect: +Neither laptop contains a Speaker ID GPIO. +This issue would not affect audio playback, but may affect which files +are loaded when loading firmware. + +Fixes: b67a7dc418aa ("ALSA: hda/realtek: Add sound quirks for Lenovo Legion slim 7 16ARHA7 models") + +Signed-off-by: Stefan Binding +Signed-off-by: Takashi Iwai +Message-ID: <20240411110813.330483-8-sbinding@opensource.cirrus.com> +Signed-off-by: Sasha Levin +--- + sound/pci/hda/cs35l41_hda_property.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c +index 4d1f8734d13f3..c2067e8083c0f 100644 +--- a/sound/pci/hda/cs35l41_hda_property.c ++++ b/sound/pci/hda/cs35l41_hda_property.c +@@ -99,8 +99,8 @@ static const struct cs35l41_config cs35l41_config_table[] = { + { "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 }, + { "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, + { "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, +- { "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, +- { "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, ++ { "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, ++ { "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, + { "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, + { "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, + { "17AA38B4", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, +-- +2.43.0 + diff --git a/queue-6.8/alsa-hda-cs35l56-exit-cache-only-after-cs35l56_wait_.patch b/queue-6.8/alsa-hda-cs35l56-exit-cache-only-after-cs35l56_wait_.patch new file mode 100644 index 00000000000..6adcba59553 --- /dev/null +++ b/queue-6.8/alsa-hda-cs35l56-exit-cache-only-after-cs35l56_wait_.patch @@ -0,0 +1,51 @@ +From 62b93ba86a659fe84c5bbdf9cf2dd9d9335de628 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 11:18:01 +0100 +Subject: ALSA: hda: cs35l56: Exit cache-only after + cs35l56_wait_for_firmware_boot() + +From: Richard Fitzgerald + +[ Upstream commit 73580ec607dfe125b140ed30c7c0a074db78c558 ] + +Adds calls to disable regmap cache-only after a successful return from +cs35l56_wait_for_firmware_boot(). + +This is to prepare for a change in the shared ASoC module that will +leave regmap in cache-only mode after cs35l56_system_reset(). This is +to prevent register accesses going to the hardware while it is +rebooting. + +Signed-off-by: Richard Fitzgerald +Link: https://msgid.link/r/20240408101803.43183-3-rf@opensource.cirrus.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/pci/hda/cs35l56_hda.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c +index 43a445bd961fb..de58a953b48d2 100644 +--- a/sound/pci/hda/cs35l56_hda.c ++++ b/sound/pci/hda/cs35l56_hda.c +@@ -629,6 +629,8 @@ static int cs35l56_hda_fw_load(struct cs35l56_hda *cs35l56) + ret = cs35l56_wait_for_firmware_boot(&cs35l56->base); + if (ret) + goto err_powered_up; ++ ++ regcache_cache_only(cs35l56->base.regmap, false); + } + + /* Disable auto-hibernate so that runtime_pm has control */ +@@ -978,6 +980,8 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int id) + if (ret) + goto err; + ++ regcache_cache_only(cs35l56->base.regmap, false); ++ + ret = cs35l56_set_patch(&cs35l56->base); + if (ret) + goto err; +-- +2.43.0 + diff --git a/queue-6.8/alsa-hda-intel-dsp-config-harden-i2c-i2s-codec-detec.patch b/queue-6.8/alsa-hda-intel-dsp-config-harden-i2c-i2s-codec-detec.patch new file mode 100644 index 00000000000..0d4c3d3a9a1 --- /dev/null +++ b/queue-6.8/alsa-hda-intel-dsp-config-harden-i2c-i2s-codec-detec.patch @@ -0,0 +1,84 @@ +From 492937afe960ee35864ea06539bfb67ba687170d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 10:28:18 -0500 +Subject: ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pierre-Louis Bossart + +[ Upstream commit 79ac4c1443eaec0d09355307043a9149287f23c1 ] + +The SOF driver is selected whenever specific I2C/I2S HIDs are reported +as 'present' in the ACPI DSDT. In some cases, an HID is reported but +the hardware does not actually rely on I2C/I2S. This false positive +leads to an invalid selection of the SOF driver and as a result an +invalid topology is loaded. + +This patch hardens the detection with a check that the NHLT table is +consistent with the report of an I2S-based codec in DSDT. This table +should expose at least one SSP endpoint configured for an I2S-codec +connection. + +Tested on Huawei Matebook D14 (NBLB-WAX9N) using an HDaudio codec with +an invalid ES8336 ACPI HID reported: + +[ 7.858249] snd_hda_intel 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040380 +[ 7.858312] snd_hda_intel 0000:00:1f.3: snd_intel_dsp_find_config: no valid SSP found for HID ESSX8336, skipped + +Reported-by: Mauro Carvalho Chehab +Tested-by: Mauro Carvalho Chehab +Closes: https://github.com/thesofproject/linux/issues/4934 +Signed-off-by: Pierre-Louis Bossart +Reviewed-by: Bard Liao +Reviewed-by: Péter Ujfalusi +Message-ID: <20240426152818.38443-1-pierre-louis.bossart@linux.intel.com> +Signed-off-by: Takashi Iwai +Signed-off-by: Sasha Levin +--- + sound/hda/intel-dsp-config.c | 27 +++++++++++++++++++++++++-- + 1 file changed, 25 insertions(+), 2 deletions(-) + +diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c +index 6a384b922e4fa..d1f6cdcf1866e 100644 +--- a/sound/hda/intel-dsp-config.c ++++ b/sound/hda/intel-dsp-config.c +@@ -557,9 +557,32 @@ static const struct config_entry *snd_intel_dsp_find_config + if (table->codec_hid) { + int i; + +- for (i = 0; i < table->codec_hid->num_codecs; i++) +- if (acpi_dev_present(table->codec_hid->codecs[i], NULL, -1)) ++ for (i = 0; i < table->codec_hid->num_codecs; i++) { ++ struct nhlt_acpi_table *nhlt; ++ bool ssp_found = false; ++ ++ if (!acpi_dev_present(table->codec_hid->codecs[i], NULL, -1)) ++ continue; ++ ++ nhlt = intel_nhlt_init(&pci->dev); ++ if (!nhlt) { ++ dev_warn(&pci->dev, "%s: NHLT table not found, skipped HID %s\n", ++ __func__, table->codec_hid->codecs[i]); ++ continue; ++ } ++ ++ if (intel_nhlt_has_endpoint_type(nhlt, NHLT_LINK_SSP) && ++ intel_nhlt_ssp_endpoint_mask(nhlt, NHLT_DEVICE_I2S)) ++ ssp_found = true; ++ ++ intel_nhlt_free(nhlt); ++ ++ if (ssp_found) + break; ++ ++ dev_warn(&pci->dev, "%s: no valid SSP found for HID %s, skipped\n", ++ __func__, table->codec_hid->codecs[i]); ++ } + if (i == table->codec_hid->num_codecs) + continue; + } +-- +2.43.0 + diff --git a/queue-6.8/arm-configs-sunxi-enable-drm_dw_hdmi.patch b/queue-6.8/arm-configs-sunxi-enable-drm_dw_hdmi.patch new file mode 100644 index 00000000000..8dbb8d5a84b --- /dev/null +++ b/queue-6.8/arm-configs-sunxi-enable-drm_dw_hdmi.patch @@ -0,0 +1,41 @@ +From 6b299dbb4d14a5408456ad6e12e465887ed196fb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 12:56:23 +0200 +Subject: ARM: configs: sunxi: Enable DRM_DW_HDMI + +From: Maxime Ripard + +[ Upstream commit deff401b14e2d832b25b55862ad6c73378fe034e ] + +Commit 4fc8cb47fcfd ("drm/display: Move HDMI helpers into display-helper +module") turned the DRM_DW_HDMI dependency of DRM_SUN8I_DW_HDMI into a +depends on which ended up disabling the driver in the defconfig. Make +sure it's still enabled. + +Fixes: 4fc8cb47fcfd ("drm/display: Move HDMI helpers into display-helper module") +Reported-by: Mark Brown +Reported-by: Alexander Stein +Signed-off-by: Maxime Ripard +Acked-by: Jernej Skrabec +Link: https://lore.kernel.org/r/20240403-fix-dw-hdmi-kconfig-v1-5-afbc4a835c38@kernel.org +Signed-off-by: Jernej Skrabec +Signed-off-by: Sasha Levin +--- + arch/arm/configs/sunxi_defconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig +index bddc82f789421..a83d29fed1756 100644 +--- a/arch/arm/configs/sunxi_defconfig ++++ b/arch/arm/configs/sunxi_defconfig +@@ -110,6 +110,7 @@ CONFIG_DRM_PANEL_LVDS=y + CONFIG_DRM_PANEL_SIMPLE=y + CONFIG_DRM_PANEL_EDP=y + CONFIG_DRM_SIMPLE_BRIDGE=y ++CONFIG_DRM_DW_HDMI=y + CONFIG_DRM_LIMA=y + CONFIG_FB_SIMPLE=y + CONFIG_BACKLIGHT_CLASS_DEVICE=y +-- +2.43.0 + diff --git a/queue-6.8/arm64-remove-unnecessary-irqflags-alternative.h-incl.patch b/queue-6.8/arm64-remove-unnecessary-irqflags-alternative.h-incl.patch new file mode 100644 index 00000000000..8ad782327fa --- /dev/null +++ b/queue-6.8/arm64-remove-unnecessary-irqflags-alternative.h-incl.patch @@ -0,0 +1,37 @@ +From c414bd597d2a6d5696d2d7ce617454fb4efba4e1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 14 Mar 2024 14:38:19 +0800 +Subject: arm64: Remove unnecessary irqflags alternative.h include + +From: Jinjie Ruan + +[ Upstream commit 98631c4904bf6380834c8585ce50451f00eb5389 ] + +Since commit 20af807d806d ("arm64: Avoid cpus_have_const_cap() for +ARM64_HAS_GIC_PRIO_MASKING"), the alternative.h include is not used, +so remove it. + +Fixes: 20af807d806d ("arm64: Avoid cpus_have_const_cap() for ARM64_HAS_GIC_PRIO_MASKING") +Signed-off-by: Jinjie Ruan +Link: https://lore.kernel.org/r/20240314063819.2636445-1-ruanjinjie@huawei.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + arch/arm64/include/asm/irqflags.h | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/arch/arm64/include/asm/irqflags.h b/arch/arm64/include/asm/irqflags.h +index 0a7186a93882d..d4d7451c2c129 100644 +--- a/arch/arm64/include/asm/irqflags.h ++++ b/arch/arm64/include/asm/irqflags.h +@@ -5,7 +5,6 @@ + #ifndef __ASM_IRQFLAGS_H + #define __ASM_IRQFLAGS_H + +-#include + #include + #include + #include +-- +2.43.0 + diff --git a/queue-6.8/asoc-acp-support-microphone-from-device-acer-315-24p.patch b/queue-6.8/asoc-acp-support-microphone-from-device-acer-315-24p.patch new file mode 100644 index 00000000000..aab5a71a15c --- /dev/null +++ b/queue-6.8/asoc-acp-support-microphone-from-device-acer-315-24p.patch @@ -0,0 +1,40 @@ +From 01c7a068664290dde7548fcea14676ec8ad661b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 18:24:54 +0300 +Subject: ASoC: acp: Support microphone from device Acer 315-24p + +From: end.to.start + +[ Upstream commit 4b9a474c7c820391c0913d64431ae9e1f52a5143 ] + +This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working + +Signed-off-by: end.to.start +Link: https://msgid.link/r/20240408152454.45532-1-end.to.start@mail.ru +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c +index 69c68d8e7a6b5..1760b5d42460a 100644 +--- a/sound/soc/amd/yc/acp6x-mach.c ++++ b/sound/soc/amd/yc/acp6x-mach.c +@@ -430,6 +430,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { + DMI_MATCH(DMI_BOARD_NAME, "MRID6"), + } + }, ++ { ++ .driver_data = &acp6x_card, ++ .matches = { ++ DMI_MATCH(DMI_BOARD_VENDOR, "MDC"), ++ DMI_MATCH(DMI_BOARD_NAME, "Herbag_MDU"), ++ } ++ }, + { + .driver_data = &acp6x_card, + .matches = { +-- +2.43.0 + diff --git a/queue-6.8/asoc-cs35l41-update-dsp1rx5-6-sources-for-dsp-config.patch b/queue-6.8/asoc-cs35l41-update-dsp1rx5-6-sources-for-dsp-config.patch new file mode 100644 index 00000000000..cfd357a8595 --- /dev/null +++ b/queue-6.8/asoc-cs35l41-update-dsp1rx5-6-sources-for-dsp-config.patch @@ -0,0 +1,77 @@ +From b9f2bfc5e2cc63a8794f6a1852d96f625e7ba4d7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 15:26:48 +0100 +Subject: ASoC: cs35l41: Update DSP1RX5/6 Sources for DSP config + +From: Stefan Binding + +[ Upstream commit eefb831d2e4dd58d58002a2ef75ff989e073230d ] + +Currently, all ASoC systems are set to use VPMON for DSP1RX5_SRC, +however, this is required only for internal boost systems. +External boost systems require VBSTMON instead of VPMON to be the +input to DSP1RX5_SRC. +Shared Boost Active acts like Internal boost (requires VPMON). +Shared Boost Passive acts like External boost (requires VBSTMON) +All systems require DSP1RX6_SRC to be set to VBSTMON. + +Signed-off-by: Stefan Binding +Reviewed-by: Richard Fitzgerald +Link: https://msgid.link/r/20240411142648.650921-1-sbinding@opensource.cirrus.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/cs35l41.c | 26 ++++++++++++++++++++------ + 1 file changed, 20 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c +index dfb4ce53491bb..f8e57a2fc3e32 100644 +--- a/sound/soc/codecs/cs35l41.c ++++ b/sound/soc/codecs/cs35l41.c +@@ -1094,6 +1094,7 @@ static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cf + static int cs35l41_dsp_init(struct cs35l41_private *cs35l41) + { + struct wm_adsp *dsp; ++ uint32_t dsp1rx5_src; + int ret; + + dsp = &cs35l41->dsp; +@@ -1113,16 +1114,29 @@ static int cs35l41_dsp_init(struct cs35l41_private *cs35l41) + return ret; + } + +- ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX5_SRC, +- CS35L41_INPUT_SRC_VPMON); ++ switch (cs35l41->hw_cfg.bst_type) { ++ case CS35L41_INT_BOOST: ++ case CS35L41_SHD_BOOST_ACTV: ++ dsp1rx5_src = CS35L41_INPUT_SRC_VPMON; ++ break; ++ case CS35L41_EXT_BOOST: ++ case CS35L41_SHD_BOOST_PASS: ++ dsp1rx5_src = CS35L41_INPUT_SRC_VBSTMON; ++ break; ++ default: ++ dev_err(cs35l41->dev, "wm_halo_init failed - Invalid Boost Type: %d\n", ++ cs35l41->hw_cfg.bst_type); ++ goto err_dsp; ++ } ++ ++ ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX5_SRC, dsp1rx5_src); + if (ret < 0) { +- dev_err(cs35l41->dev, "Write INPUT_SRC_VPMON failed: %d\n", ret); ++ dev_err(cs35l41->dev, "Write DSP1RX5_SRC: %d failed: %d\n", dsp1rx5_src, ret); + goto err_dsp; + } +- ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX6_SRC, +- CS35L41_INPUT_SRC_CLASSH); ++ ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX6_SRC, CS35L41_INPUT_SRC_VBSTMON); + if (ret < 0) { +- dev_err(cs35l41->dev, "Write INPUT_SRC_CLASSH failed: %d\n", ret); ++ dev_err(cs35l41->dev, "Write CS35L41_INPUT_SRC_VBSTMON failed: %d\n", ret); + goto err_dsp; + } + ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX7_SRC, +-- +2.43.0 + diff --git a/queue-6.8/asoc-cs35l56-fix-usages-of-device_get_named_child_no.patch b/queue-6.8/asoc-cs35l56-fix-usages-of-device_get_named_child_no.patch new file mode 100644 index 00000000000..0e75d822393 --- /dev/null +++ b/queue-6.8/asoc-cs35l56-fix-usages-of-device_get_named_child_no.patch @@ -0,0 +1,91 @@ +From af2a8218d56fe187fb64d62dd198f2f44b16d5f6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 10:29:39 -0500 +Subject: ASoC: cs35l56: fix usages of device_get_named_child_node() + +From: Pierre-Louis Bossart + +[ Upstream commit fbd741f0993203d07b2b6562d68d1e5e4745b59b ] + +The documentation for device_get_named_child_node() mentions this +important point: + +" +The caller is responsible for calling fwnode_handle_put() on the +returned fwnode pointer. +" + +Add fwnode_handle_put() to avoid leaked references. + +Signed-off-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20240426152939.38471-1-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/cs35l56.c | 13 +++++++++++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c +index 6dd0319bc843c..ea72afe3f906f 100644 +--- a/sound/soc/codecs/cs35l56.c ++++ b/sound/soc/codecs/cs35l56.c +@@ -1297,6 +1297,7 @@ static int cs35l56_try_get_broken_sdca_spkid_gpio(struct cs35l56_private *cs35l5 + "spk-id-gpios", ACPI_TYPE_PACKAGE, &obj); + if (ret) { + dev_dbg(cs35l56->base.dev, "Could not get spk-id-gpios package: %d\n", ret); ++ fwnode_handle_put(af01_fwnode); + return -ENOENT; + } + +@@ -1304,6 +1305,7 @@ static int cs35l56_try_get_broken_sdca_spkid_gpio(struct cs35l56_private *cs35l5 + if (obj->package.count != 4) { + dev_warn(cs35l56->base.dev, "Unexpected spk-id element count %d\n", + obj->package.count); ++ fwnode_handle_put(af01_fwnode); + return -ENOENT; + } + +@@ -1318,6 +1320,7 @@ static int cs35l56_try_get_broken_sdca_spkid_gpio(struct cs35l56_private *cs35l5 + */ + ret = acpi_dev_add_driver_gpios(adev, cs35l56_af01_spkid_gpios_mapping); + if (ret) { ++ fwnode_handle_put(af01_fwnode); + return dev_err_probe(cs35l56->base.dev, ret, + "Failed to add gpio mapping to AF01\n"); + } +@@ -1325,14 +1328,17 @@ static int cs35l56_try_get_broken_sdca_spkid_gpio(struct cs35l56_private *cs35l5 + ret = devm_add_action_or_reset(cs35l56->base.dev, + cs35l56_acpi_dev_release_driver_gpios, + adev); +- if (ret) ++ if (ret) { ++ fwnode_handle_put(af01_fwnode); + return ret; ++ } + + dev_dbg(cs35l56->base.dev, "Added spk-id-gpios mapping to AF01\n"); + } + + desc = fwnode_gpiod_get_index(af01_fwnode, "spk-id", 0, GPIOD_IN, NULL); + if (IS_ERR(desc)) { ++ fwnode_handle_put(af01_fwnode); + ret = PTR_ERR(desc); + return dev_err_probe(cs35l56->base.dev, ret, "Get GPIO from AF01 failed\n"); + } +@@ -1341,9 +1347,12 @@ static int cs35l56_try_get_broken_sdca_spkid_gpio(struct cs35l56_private *cs35l5 + gpiod_put(desc); + + if (ret < 0) { ++ fwnode_handle_put(af01_fwnode); + dev_err_probe(cs35l56->base.dev, ret, "Error reading spk-id GPIO\n"); + return ret; +- } ++ } ++ ++ fwnode_handle_put(af01_fwnode); + + dev_info(cs35l56->base.dev, "Got spk-id from AF01\n"); + +-- +2.43.0 + diff --git a/queue-6.8/asoc-da7219-aad-fix-usage-of-device_get_named_child_.patch b/queue-6.8/asoc-da7219-aad-fix-usage-of-device_get_named_child_.patch new file mode 100644 index 00000000000..8044cb16877 --- /dev/null +++ b/queue-6.8/asoc-da7219-aad-fix-usage-of-device_get_named_child_.patch @@ -0,0 +1,55 @@ +From b4c8b8eec2247f87dfeb8d20263ce54ecd3f1606 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 10:30:33 -0500 +Subject: ASoC: da7219-aad: fix usage of device_get_named_child_node() + +From: Pierre-Louis Bossart + +[ Upstream commit e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76 ] + +The documentation for device_get_named_child_node() mentions this +important point: + +" +The caller is responsible for calling fwnode_handle_put() on the +returned fwnode pointer. +" + +Add fwnode_handle_put() to avoid a leaked reference. + +Signed-off-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/20240426153033.38500-1-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/da7219-aad.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c +index 6bc068cdcbe2a..15e5e3eb592b3 100644 +--- a/sound/soc/codecs/da7219-aad.c ++++ b/sound/soc/codecs/da7219-aad.c +@@ -671,8 +671,10 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) + return NULL; + + aad_pdata = devm_kzalloc(dev, sizeof(*aad_pdata), GFP_KERNEL); +- if (!aad_pdata) ++ if (!aad_pdata) { ++ fwnode_handle_put(aad_np); + return NULL; ++ } + + aad_pdata->irq = i2c->irq; + +@@ -753,6 +755,8 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) + else + aad_pdata->adc_1bit_rpt = DA7219_AAD_ADC_1BIT_RPT_1; + ++ fwnode_handle_put(aad_np); ++ + return aad_pdata; + } + +-- +2.43.0 + diff --git a/queue-6.8/asoc-dt-bindings-rt5645-add-cbj-sleeve-gpio-property.patch b/queue-6.8/asoc-dt-bindings-rt5645-add-cbj-sleeve-gpio-property.patch new file mode 100644 index 00000000000..7dc553c9269 --- /dev/null +++ b/queue-6.8/asoc-dt-bindings-rt5645-add-cbj-sleeve-gpio-property.patch @@ -0,0 +1,48 @@ +From 35431e9a446c60d5c56e0109a74e88766e378965 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 17:10:57 +0800 +Subject: ASoC: dt-bindings: rt5645: add cbj sleeve gpio property + +From: Derek Fang + +[ Upstream commit 306b38e3fa727d22454a148a364123709e356600 ] + +Add an optional gpio property to control external CBJ circuits +to avoid some electric noise caused by sleeve/ring2 contacts floating. + +Signed-off-by: Derek Fang + +Link: https://msgid.link/r/20240408091057.14165-2-derek.fang@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + Documentation/devicetree/bindings/sound/rt5645.txt | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/Documentation/devicetree/bindings/sound/rt5645.txt b/Documentation/devicetree/bindings/sound/rt5645.txt +index 41a62fd2ae1ff..c1fa379f5f3ea 100644 +--- a/Documentation/devicetree/bindings/sound/rt5645.txt ++++ b/Documentation/devicetree/bindings/sound/rt5645.txt +@@ -20,6 +20,11 @@ Optional properties: + a GPIO spec for the external headphone detect pin. If jd-mode = 0, + we will get the JD status by getting the value of hp-detect-gpios. + ++- cbj-sleeve-gpios: ++ a GPIO spec to control the external combo jack circuit to tie the sleeve/ring2 ++ contacts to the ground or floating. It could avoid some electric noise from the ++ active speaker jacks. ++ + - realtek,in2-differential + Boolean. Indicate MIC2 input are differential, rather than single-ended. + +@@ -68,6 +73,7 @@ codec: rt5650@1a { + compatible = "realtek,rt5650"; + reg = <0x1a>; + hp-detect-gpios = <&gpio 19 0>; ++ cbj-sleeve-gpios = <&gpio 20 0>; + interrupt-parent = <&gpio>; + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; + realtek,dmic-en = "true"; +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-avs-fix-asrc-module-initialization.patch b/queue-6.8/asoc-intel-avs-fix-asrc-module-initialization.patch new file mode 100644 index 00000000000..21ab25dac33 --- /dev/null +++ b/queue-6.8/asoc-intel-avs-fix-asrc-module-initialization.patch @@ -0,0 +1,36 @@ +From 616b704e0a372ebd2b7847458f5945c286e01607 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 11:09:21 +0200 +Subject: ASoC: Intel: avs: Fix ASRC module initialization + +From: Cezary Rojewski + +[ Upstream commit 9d2e26f31c7cc3fa495c423af9b4902ec0dc7be3 ] + +The ASRC module configuration consists of several reserved fields. Zero +them out when initializing the module to avoid sending invalid data. + +Fixes: 274d79e51875 ("ASoC: Intel: avs: Configure modules according to their type") +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240405090929.1184068-6-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/avs/path.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/soc/intel/avs/path.c b/sound/soc/intel/avs/path.c +index 3aa16ee8d34c1..2fae84727a3bd 100644 +--- a/sound/soc/intel/avs/path.c ++++ b/sound/soc/intel/avs/path.c +@@ -367,6 +367,7 @@ static int avs_asrc_create(struct avs_dev *adev, struct avs_path_module *mod) + struct avs_tplg_module *t = mod->template; + struct avs_asrc_cfg cfg; + ++ memset(&cfg, 0, sizeof(cfg)); + cfg.base.cpc = t->cfg_base->cpc; + cfg.base.ibs = t->cfg_base->ibs; + cfg.base.obs = t->cfg_base->obs; +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-avs-fix-potential-integer-overflow.patch b/queue-6.8/asoc-intel-avs-fix-potential-integer-overflow.patch new file mode 100644 index 00000000000..006ad7adb0b --- /dev/null +++ b/queue-6.8/asoc-intel-avs-fix-potential-integer-overflow.patch @@ -0,0 +1,41 @@ +From 207daf0b83f044e47c98ab1fdfa86b46275782f6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 11:09:23 +0200 +Subject: ASoC: Intel: avs: Fix potential integer overflow + +From: Cezary Rojewski + +[ Upstream commit c7e832cabe635df47c2bf6df7801e97bf3045b1e ] + +While stream_tag for CLDMA on SKL-based platforms is always 1, function +hda_cldma_setup() uses AZX_SD_CTL_STRM() macro which does: + stream_tag << 20 + +what combined with stream_tag type of 'unsigned int' generates a +potential overflow issue. Update the field type to fix that. + +Fixes: 45864e49a05a ("ASoC: Intel: avs: Implement CLDMA transfer") +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240405090929.1184068-8-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/avs/cldma.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/intel/avs/cldma.c b/sound/soc/intel/avs/cldma.c +index d7a9390b5e483..585579840b646 100644 +--- a/sound/soc/intel/avs/cldma.c ++++ b/sound/soc/intel/avs/cldma.c +@@ -35,7 +35,7 @@ struct hda_cldma { + + unsigned int buffer_size; + unsigned int num_periods; +- unsigned int stream_tag; ++ unsigned char stream_tag; + void __iomem *sd_addr; + + struct snd_dma_buffer dmab_data; +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-avs-restore-stream-decoupling-on-prepare.patch b/queue-6.8/asoc-intel-avs-restore-stream-decoupling-on-prepare.patch new file mode 100644 index 00000000000..9e33d6a753f --- /dev/null +++ b/queue-6.8/asoc-intel-avs-restore-stream-decoupling-on-prepare.patch @@ -0,0 +1,57 @@ +From 952585c010b6be34f42615c38c13a261c27f8831 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 11:09:17 +0200 +Subject: ASoC: Intel: avs: Restore stream decoupling on prepare +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Amadeusz Sławiński + +[ Upstream commit 680507581e025d16a0b6d3782603ca8c598fbe2b ] + +Revert changes from commit b87b8f43afd5 ("ASoC: Intel: avs: Drop +superfluous stream decoupling") to restore working streaming during S3. + +Fixes: b87b8f43afd5 ("ASoC: Intel: avs: Drop superfluous stream decoupling") +Signed-off-by: Amadeusz Sławiński +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240405090929.1184068-2-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/avs/pcm.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c +index 4dfc5a1ebb7c2..f25a293c0915d 100644 +--- a/sound/soc/intel/avs/pcm.c ++++ b/sound/soc/intel/avs/pcm.c +@@ -356,6 +356,7 @@ static int avs_dai_hda_be_prepare(struct snd_pcm_substream *substream, struct sn + stream_info->sig_bits); + format_val = snd_hdac_stream_format(runtime->channels, bits, runtime->rate); + ++ snd_hdac_ext_stream_decouple(bus, link_stream, true); + snd_hdac_ext_stream_reset(link_stream); + snd_hdac_ext_stream_setup(link_stream, format_val); + +@@ -611,6 +612,7 @@ static int avs_dai_fe_prepare(struct snd_pcm_substream *substream, struct snd_so + struct avs_dev *adev = to_avs_dev(dai->dev); + struct hdac_ext_stream *host_stream; + unsigned int format_val; ++ struct hdac_bus *bus; + unsigned int bits; + int ret; + +@@ -620,6 +622,8 @@ static int avs_dai_fe_prepare(struct snd_pcm_substream *substream, struct snd_so + if (hdac_stream(host_stream)->prepared) + return 0; + ++ bus = hdac_stream(host_stream)->bus; ++ snd_hdac_ext_stream_decouple(bus, data->host_stream, true); + snd_hdac_stream_reset(hdac_stream(host_stream)); + + stream_info = snd_soc_dai_get_pcm_stream(dai, substream->stream); +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-avs-ssm4567-do-not-ignore-route-checks.patch b/queue-6.8/asoc-intel-avs-ssm4567-do-not-ignore-route-checks.patch new file mode 100644 index 00000000000..f52e2823a9c --- /dev/null +++ b/queue-6.8/asoc-intel-avs-ssm4567-do-not-ignore-route-checks.patch @@ -0,0 +1,36 @@ +From 76c2dce5efa157b8b1197b8bc41a02f31044d41e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 8 Mar 2024 10:05:00 +0100 +Subject: ASoC: Intel: avs: ssm4567: Do not ignore route checks + +From: Cezary Rojewski + +[ Upstream commit e6719d48ba6329536c459dcee5a571e535687094 ] + +A copy-paste from intel/boards/skl_nau88l25_ssm4567.c made the avs's +equivalent disable route checks as well. Such behavior is not desired. + +Fixes: 69ea14efe99b ("ASoC: Intel: avs: Add ssm4567 machine board") +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240308090502.2136760-4-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/avs/boards/ssm4567.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/sound/soc/intel/avs/boards/ssm4567.c b/sound/soc/intel/avs/boards/ssm4567.c +index 4a0e136835ff5..b64be685dc23b 100644 +--- a/sound/soc/intel/avs/boards/ssm4567.c ++++ b/sound/soc/intel/avs/boards/ssm4567.c +@@ -172,7 +172,6 @@ static int avs_ssm4567_probe(struct platform_device *pdev) + card->dapm_routes = card_base_routes; + card->num_dapm_routes = ARRAY_SIZE(card_base_routes); + card->fully_routed = true; +- card->disable_route_checks = true; + + ret = snd_soc_fixup_dai_links_platform_name(card, pname); + if (ret) +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-avs-test-result-of-avs_get_module_entry.patch b/queue-6.8/asoc-intel-avs-test-result-of-avs_get_module_entry.patch new file mode 100644 index 00000000000..14e3fb7eab9 --- /dev/null +++ b/queue-6.8/asoc-intel-avs-test-result-of-avs_get_module_entry.patch @@ -0,0 +1,59 @@ +From dc2a54a9666e90bea2b67ccf92171489fff6b280 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 11:09:24 +0200 +Subject: ASoC: Intel: avs: Test result of avs_get_module_entry() + +From: Cezary Rojewski + +[ Upstream commit 41bf4525fadb3d8df3860420d6ac9025c51a3bac ] + +While PROBE_MOD_UUID is always part of the base AudioDSP firmware +manifest, from maintenance point of view it is better to check the +result. + +Fixes: dab8d000e25c ("ASoC: Intel: avs: Add data probing requests") +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240405090929.1184068-9-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/avs/probes.c | 14 +++++++++----- + 1 file changed, 9 insertions(+), 5 deletions(-) + +diff --git a/sound/soc/intel/avs/probes.c b/sound/soc/intel/avs/probes.c +index 817e543036f29..7e781a3156909 100644 +--- a/sound/soc/intel/avs/probes.c ++++ b/sound/soc/intel/avs/probes.c +@@ -19,8 +19,11 @@ static int avs_dsp_init_probe(struct avs_dev *adev, union avs_connector_node_id + struct avs_probe_cfg cfg = {{0}}; + struct avs_module_entry mentry; + u8 dummy; ++ int ret; + +- avs_get_module_entry(adev, &AVS_PROBE_MOD_UUID, &mentry); ++ ret = avs_get_module_entry(adev, &AVS_PROBE_MOD_UUID, &mentry); ++ if (ret) ++ return ret; + + /* + * Probe module uses no cycles, audio data format and input and output +@@ -39,11 +42,12 @@ static int avs_dsp_init_probe(struct avs_dev *adev, union avs_connector_node_id + static void avs_dsp_delete_probe(struct avs_dev *adev) + { + struct avs_module_entry mentry; ++ int ret; + +- avs_get_module_entry(adev, &AVS_PROBE_MOD_UUID, &mentry); +- +- /* There is only ever one probe module instance. */ +- avs_dsp_delete_module(adev, mentry.module_id, 0, INVALID_PIPELINE_ID, 0); ++ ret = avs_get_module_entry(adev, &AVS_PROBE_MOD_UUID, &mentry); ++ if (!ret) ++ /* There is only ever one probe module instance. */ ++ avs_dsp_delete_module(adev, mentry.module_id, 0, INVALID_PIPELINE_ID, 0); + } + + static inline struct hdac_ext_stream *avs_compr_get_host_stream(struct snd_compr_stream *cstream) +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-bytcr_rt5640-apply-asus-t100ta-quirk-to-a.patch b/queue-6.8/asoc-intel-bytcr_rt5640-apply-asus-t100ta-quirk-to-a.patch new file mode 100644 index 00000000000..d1f66b1d560 --- /dev/null +++ b/queue-6.8/asoc-intel-bytcr_rt5640-apply-asus-t100ta-quirk-to-a.patch @@ -0,0 +1,71 @@ +From c2876a1ab9ad7c007bb680050df1832f3de01f3a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 7 Apr 2024 21:15:59 +0200 +Subject: ASoC: Intel: bytcr_rt5640: Apply Asus T100TA quirk to Asus T100TAM + too + +From: Hans de Goede + +[ Upstream commit e50729d742ec364895f1c389c32315984a987aa5 ] + +The Asus T100TA quirk has been using an exact match on a product-name of +"T100TA" but there are also T100TAM variants with a slightly higher +clocked CPU and a metal backside which need the same quirk. + +Sort the existing T100TA (stereo speakers) below the more specific +T100TAF (mono speaker) quirk and switch from exact matching to +substring matching so that the T100TA quirk will also match on +the T100TAM models. + +Signed-off-by: Hans de Goede +Link: https://msgid.link/r/20240407191559.21596-1-hdegoede@redhat.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/boards/bytcr_rt5640.c | 14 ++++++++------ + 1 file changed, 8 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c +index 05f38d1f7d824..b41a1147f1c34 100644 +--- a/sound/soc/intel/boards/bytcr_rt5640.c ++++ b/sound/soc/intel/boards/bytcr_rt5640.c +@@ -636,28 +636,30 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { + BYT_RT5640_USE_AMCR0F28), + }, + { ++ /* Asus T100TAF, unlike other T100TA* models this one has a mono speaker */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"), ++ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TAF"), + }, + .driver_data = (void *)(BYT_RT5640_IN1_MAP | + BYT_RT5640_JD_SRC_JD2_IN4N | + BYT_RT5640_OVCD_TH_2000UA | + BYT_RT5640_OVCD_SF_0P75 | ++ BYT_RT5640_MONO_SPEAKER | ++ BYT_RT5640_DIFF_MIC | ++ BYT_RT5640_SSP0_AIF2 | + BYT_RT5640_MCLK_EN), + }, + { ++ /* Asus T100TA and T100TAM, must come after T100TAF (mono spk) match */ + .matches = { +- DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), +- DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TAF"), ++ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_MATCH(DMI_PRODUCT_NAME, "T100TA"), + }, + .driver_data = (void *)(BYT_RT5640_IN1_MAP | + BYT_RT5640_JD_SRC_JD2_IN4N | + BYT_RT5640_OVCD_TH_2000UA | + BYT_RT5640_OVCD_SF_0P75 | +- BYT_RT5640_MONO_SPEAKER | +- BYT_RT5640_DIFF_MIC | +- BYT_RT5640_SSP0_AIF2 | + BYT_RT5640_MCLK_EN), + }, + { +-- +2.43.0 + diff --git a/queue-6.8/asoc-intel-disable-route-checks-for-skylake-boards.patch b/queue-6.8/asoc-intel-disable-route-checks-for-skylake-boards.patch new file mode 100644 index 00000000000..c7ca1011311 --- /dev/null +++ b/queue-6.8/asoc-intel-disable-route-checks-for-skylake-boards.patch @@ -0,0 +1,209 @@ +From d2628d952c59c697a2877370e8102e5f57b76d0c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 8 Mar 2024 10:04:58 +0100 +Subject: ASoC: Intel: Disable route checks for Skylake boards + +From: Cezary Rojewski + +[ Upstream commit 0cb3b7fd530b8c107443218ce6db5cb6e7b5dbe1 ] + +Topology files that are propagated to the world and utilized by the +skylake-driver carry shortcomings in their SectionGraphs. + +Since commit daa480bde6b3 ("ASoC: soc-core: tidyup for +snd_soc_dapm_add_routes()") route checks are no longer permissive. Probe +failures for Intel boards have been partially addressed by commit +a22ae72b86a4 ("ASoC: soc-core: disable route checks for legacy devices") +and its follow up but only skl_nau88l25_ssm4567.c is patched. Fix the +problem for the rest of the boards. + +Link: https://lore.kernel.org/all/20200309192744.18380-1-pierre-louis.bossart@linux.intel.com/ +Fixes: daa480bde6b3 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()") +Signed-off-by: Cezary Rojewski +Link: https://msgid.link/r/20240308090502.2136760-2-cezary.rojewski@intel.com +Reviewed-by: Pierre-Louis Bossart +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/intel/boards/bxt_da7219_max98357a.c | 1 + + sound/soc/intel/boards/bxt_rt298.c | 1 + + sound/soc/intel/boards/glk_rt5682_max98357a.c | 2 ++ + sound/soc/intel/boards/kbl_da7219_max98357a.c | 1 + + sound/soc/intel/boards/kbl_da7219_max98927.c | 4 ++++ + sound/soc/intel/boards/kbl_rt5660.c | 1 + + sound/soc/intel/boards/kbl_rt5663_max98927.c | 2 ++ + sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 1 + + sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 ++ + sound/soc/intel/boards/skl_nau88l25_max98357a.c | 1 + + sound/soc/intel/boards/skl_rt286.c | 1 + + 11 files changed, 17 insertions(+) + +diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c +index 540f7a29310a9..3fe3f38c6cb69 100644 +--- a/sound/soc/intel/boards/bxt_da7219_max98357a.c ++++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c +@@ -768,6 +768,7 @@ static struct snd_soc_card broxton_audio_card = { + .dapm_routes = audio_map, + .num_dapm_routes = ARRAY_SIZE(audio_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = bxt_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/bxt_rt298.c b/sound/soc/intel/boards/bxt_rt298.c +index c0eb65c14aa97..afc499be8db26 100644 +--- a/sound/soc/intel/boards/bxt_rt298.c ++++ b/sound/soc/intel/boards/bxt_rt298.c +@@ -574,6 +574,7 @@ static struct snd_soc_card broxton_rt298 = { + .dapm_routes = broxton_rt298_map, + .num_dapm_routes = ARRAY_SIZE(broxton_rt298_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = bxt_card_late_probe, + + }; +diff --git a/sound/soc/intel/boards/glk_rt5682_max98357a.c b/sound/soc/intel/boards/glk_rt5682_max98357a.c +index 657e4658234ce..4098b2d32f9bc 100644 +--- a/sound/soc/intel/boards/glk_rt5682_max98357a.c ++++ b/sound/soc/intel/boards/glk_rt5682_max98357a.c +@@ -649,6 +649,8 @@ static int geminilake_audio_probe(struct platform_device *pdev) + card = &glk_audio_card_rt5682_m98357a; + card->dev = &pdev->dev; + snd_soc_card_set_drvdata(card, ctx); ++ if (!snd_soc_acpi_sof_parent(&pdev->dev)) ++ card->disable_route_checks = true; + + /* override platform name, if required */ + mach = pdev->dev.platform_data; +diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c +index a5d8965303a88..9dbc15f9d1c9b 100644 +--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c ++++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c +@@ -639,6 +639,7 @@ static struct snd_soc_card kabylake_audio_card_da7219_m98357a = { + .dapm_routes = kabylake_map, + .num_dapm_routes = ARRAY_SIZE(kabylake_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/kbl_da7219_max98927.c b/sound/soc/intel/boards/kbl_da7219_max98927.c +index 98c11ec0adc01..e662da5af83b5 100644 +--- a/sound/soc/intel/boards/kbl_da7219_max98927.c ++++ b/sound/soc/intel/boards/kbl_da7219_max98927.c +@@ -1036,6 +1036,7 @@ static struct snd_soc_card kbl_audio_card_da7219_m98927 = { + .codec_conf = max98927_codec_conf, + .num_configs = ARRAY_SIZE(max98927_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +@@ -1054,6 +1055,7 @@ static struct snd_soc_card kbl_audio_card_max98927 = { + .codec_conf = max98927_codec_conf, + .num_configs = ARRAY_SIZE(max98927_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +@@ -1071,6 +1073,7 @@ static struct snd_soc_card kbl_audio_card_da7219_m98373 = { + .codec_conf = max98373_codec_conf, + .num_configs = ARRAY_SIZE(max98373_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +@@ -1088,6 +1091,7 @@ static struct snd_soc_card kbl_audio_card_max98373 = { + .codec_conf = max98373_codec_conf, + .num_configs = ARRAY_SIZE(max98373_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/kbl_rt5660.c b/sound/soc/intel/boards/kbl_rt5660.c +index 30e0aca161cd5..894d127c482a3 100644 +--- a/sound/soc/intel/boards/kbl_rt5660.c ++++ b/sound/soc/intel/boards/kbl_rt5660.c +@@ -518,6 +518,7 @@ static struct snd_soc_card kabylake_audio_card_rt5660 = { + .dapm_routes = kabylake_rt5660_map, + .num_dapm_routes = ARRAY_SIZE(kabylake_rt5660_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c +index 9071b1f1cbd00..646e8ff8e9619 100644 +--- a/sound/soc/intel/boards/kbl_rt5663_max98927.c ++++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c +@@ -966,6 +966,7 @@ static struct snd_soc_card kabylake_audio_card_rt5663_m98927 = { + .codec_conf = max98927_codec_conf, + .num_configs = ARRAY_SIZE(max98927_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +@@ -982,6 +983,7 @@ static struct snd_soc_card kabylake_audio_card_rt5663 = { + .dapm_routes = kabylake_5663_map, + .num_dapm_routes = ARRAY_SIZE(kabylake_5663_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +index 178fe9c37df62..924d5d1de03ac 100644 +--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c ++++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +@@ -791,6 +791,7 @@ static struct snd_soc_card kabylake_audio_card = { + .codec_conf = max98927_codec_conf, + .num_configs = ARRAY_SIZE(max98927_codec_conf), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = kabylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/skl_hda_dsp_generic.c b/sound/soc/intel/boards/skl_hda_dsp_generic.c +index 6e172719c9795..4aa7fd2a05e46 100644 +--- a/sound/soc/intel/boards/skl_hda_dsp_generic.c ++++ b/sound/soc/intel/boards/skl_hda_dsp_generic.c +@@ -227,6 +227,8 @@ static int skl_hda_audio_probe(struct platform_device *pdev) + ctx->common_hdmi_codec_drv = mach->mach_params.common_hdmi_codec_drv; + + hda_soc_card.dev = &pdev->dev; ++ if (!snd_soc_acpi_sof_parent(&pdev->dev)) ++ hda_soc_card.disable_route_checks = true; + + if (mach->mach_params.dmic_num > 0) { + snprintf(hda_soc_components, sizeof(hda_soc_components), +diff --git a/sound/soc/intel/boards/skl_nau88l25_max98357a.c b/sound/soc/intel/boards/skl_nau88l25_max98357a.c +index 0e7025834594a..e4630c33176e2 100644 +--- a/sound/soc/intel/boards/skl_nau88l25_max98357a.c ++++ b/sound/soc/intel/boards/skl_nau88l25_max98357a.c +@@ -654,6 +654,7 @@ static struct snd_soc_card skylake_audio_card = { + .dapm_routes = skylake_map, + .num_dapm_routes = ARRAY_SIZE(skylake_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = skylake_card_late_probe, + }; + +diff --git a/sound/soc/intel/boards/skl_rt286.c b/sound/soc/intel/boards/skl_rt286.c +index c59c60e280916..9a80442749081 100644 +--- a/sound/soc/intel/boards/skl_rt286.c ++++ b/sound/soc/intel/boards/skl_rt286.c +@@ -523,6 +523,7 @@ static struct snd_soc_card skylake_rt286 = { + .dapm_routes = skylake_rt286_map, + .num_dapm_routes = ARRAY_SIZE(skylake_rt286_map), + .fully_routed = true, ++ .disable_route_checks = true, + .late_probe = skylake_card_late_probe, + }; + +-- +2.43.0 + diff --git a/queue-6.8/asoc-kirkwood-fix-potential-null-dereference.patch b/queue-6.8/asoc-kirkwood-fix-potential-null-dereference.patch new file mode 100644 index 00000000000..915fcd575ac --- /dev/null +++ b/queue-6.8/asoc-kirkwood-fix-potential-null-dereference.patch @@ -0,0 +1,41 @@ +From 4b2e8becd3e924a290c9d64dc36363739a22c3b2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 20:33:37 +0300 +Subject: ASoC: kirkwood: Fix potential NULL dereference + +From: Aleksandr Mishin + +[ Upstream commit ea60ab95723f5738e7737b56dda95e6feefa5b50 ] + +In kirkwood_dma_hw_params() mv_mbus_dram_info() returns NULL if +CONFIG_PLAT_ORION macro is not defined. +Fix this bug by adding NULL check. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: bb6a40fc5a83 ("ASoC: kirkwood: Fix reference to PCM buffer address") +Signed-off-by: Aleksandr Mishin +Link: https://msgid.link/r/20240328173337.21406-1-amishin@t-argos.ru +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/kirkwood/kirkwood-dma.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c +index dd2f806526c10..ef00792e1d49a 100644 +--- a/sound/soc/kirkwood/kirkwood-dma.c ++++ b/sound/soc/kirkwood/kirkwood-dma.c +@@ -182,6 +182,9 @@ static int kirkwood_dma_hw_params(struct snd_soc_component *component, + const struct mbus_dram_target_info *dram = mv_mbus_dram_info(); + unsigned long addr = substream->runtime->dma_addr; + ++ if (!dram) ++ return 0; ++ + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + kirkwood_dma_conf_mbus_windows(priv->io, + KIRKWOOD_PLAYBACK_WIN, addr, dram); +-- +2.43.0 + diff --git a/queue-6.8/asoc-mediatek-assign-dummy-when-codec-not-specified-.patch b/queue-6.8/asoc-mediatek-assign-dummy-when-codec-not-specified-.patch new file mode 100644 index 00000000000..ba8e01b93b5 --- /dev/null +++ b/queue-6.8/asoc-mediatek-assign-dummy-when-codec-not-specified-.patch @@ -0,0 +1,45 @@ +From def621b24576769ad196dd47c80b36f187f345cd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 13 Mar 2024 12:01:29 +0100 +Subject: ASoC: mediatek: Assign dummy when codec not specified for a DAI link + +From: AngeloGioacchino Del Regno + +[ Upstream commit 5f39231888c63f0a7708abc86b51b847476379d8 ] + +MediaTek sound card drivers are checking whether a DAI link is present +and used on a board to assign the correct parameters and this is done +by checking the codec DAI names at probe time. + +If no real codec is present, assign the dummy codec to the DAI link +to avoid NULL pointer during string comparison. + +Fixes: 4302187d955f ("ASoC: mediatek: common: add soundcard driver common code") +Signed-off-by: AngeloGioacchino Del Regno +Link: https://msgid.link/r/20240313110147.1267793-5-angelogioacchino.delregno@collabora.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/mediatek/common/mtk-soundcard-driver.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/sound/soc/mediatek/common/mtk-soundcard-driver.c b/sound/soc/mediatek/common/mtk-soundcard-driver.c +index a58e1e3674dec..000a086a8cf44 100644 +--- a/sound/soc/mediatek/common/mtk-soundcard-driver.c ++++ b/sound/soc/mediatek/common/mtk-soundcard-driver.c +@@ -22,7 +22,11 @@ static int set_card_codec_info(struct snd_soc_card *card, + + codec_node = of_get_child_by_name(sub_node, "codec"); + if (!codec_node) { +- dev_dbg(dev, "%s no specified codec\n", dai_link->name); ++ dev_dbg(dev, "%s no specified codec: setting dummy.\n", dai_link->name); ++ ++ dai_link->codecs = &snd_soc_dummy_dlc; ++ dai_link->num_codecs = 1; ++ dai_link->dynamic = 1; + return 0; + } + +-- +2.43.0 + diff --git a/queue-6.8/asoc-rt5645-fix-the-electric-noise-due-to-the-cbj-co.patch b/queue-6.8/asoc-rt5645-fix-the-electric-noise-due-to-the-cbj-co.patch new file mode 100644 index 00000000000..389b0b2513a --- /dev/null +++ b/queue-6.8/asoc-rt5645-fix-the-electric-noise-due-to-the-cbj-co.patch @@ -0,0 +1,105 @@ +From 4796abff65864026c5f00da03850989a3abdc562 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 17:10:56 +0800 +Subject: ASoC: rt5645: Fix the electric noise due to the CBJ contacts floating + +From: Derek Fang + +[ Upstream commit 103abab975087e1f01b76fcb54c91dbb65dbc249 ] + +The codec leaves tie combo jack's sleeve/ring2 to floating status +default. It would cause electric noise while connecting the active +speaker jack during boot or shutdown. +This patch requests a gpio to control the additional jack circuit +to tie the contacts to the ground or floating. + +Signed-off-by: Derek Fang + +Link: https://msgid.link/r/20240408091057.14165-1-derek.fang@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt5645.c | 25 +++++++++++++++++++++++++ + 1 file changed, 25 insertions(+) + +diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c +index 20191a4473c2d..0384e237a548e 100644 +--- a/sound/soc/codecs/rt5645.c ++++ b/sound/soc/codecs/rt5645.c +@@ -444,6 +444,7 @@ struct rt5645_priv { + struct regmap *regmap; + struct i2c_client *i2c; + struct gpio_desc *gpiod_hp_det; ++ struct gpio_desc *gpiod_cbj_sleeve; + struct snd_soc_jack *hp_jack; + struct snd_soc_jack *mic_jack; + struct snd_soc_jack *btn_jack; +@@ -3186,6 +3187,9 @@ static int rt5645_jack_detect(struct snd_soc_component *component, int jack_inse + regmap_update_bits(rt5645->regmap, RT5645_IN1_CTRL2, + RT5645_CBJ_MN_JD, 0); + ++ if (rt5645->gpiod_cbj_sleeve) ++ gpiod_set_value(rt5645->gpiod_cbj_sleeve, 1); ++ + msleep(600); + regmap_read(rt5645->regmap, RT5645_IN1_CTRL3, &val); + val &= 0x7; +@@ -3202,6 +3206,8 @@ static int rt5645_jack_detect(struct snd_soc_component *component, int jack_inse + snd_soc_dapm_disable_pin(dapm, "Mic Det Power"); + snd_soc_dapm_sync(dapm); + rt5645->jack_type = SND_JACK_HEADPHONE; ++ if (rt5645->gpiod_cbj_sleeve) ++ gpiod_set_value(rt5645->gpiod_cbj_sleeve, 0); + } + if (rt5645->pdata.level_trigger_irq) + regmap_update_bits(rt5645->regmap, RT5645_IRQ_CTRL2, +@@ -3229,6 +3235,9 @@ static int rt5645_jack_detect(struct snd_soc_component *component, int jack_inse + if (rt5645->pdata.level_trigger_irq) + regmap_update_bits(rt5645->regmap, RT5645_IRQ_CTRL2, + RT5645_JD_1_1_MASK, RT5645_JD_1_1_INV); ++ ++ if (rt5645->gpiod_cbj_sleeve) ++ gpiod_set_value(rt5645->gpiod_cbj_sleeve, 0); + } + + return rt5645->jack_type; +@@ -4012,6 +4021,16 @@ static int rt5645_i2c_probe(struct i2c_client *i2c) + return ret; + } + ++ rt5645->gpiod_cbj_sleeve = devm_gpiod_get_optional(&i2c->dev, "cbj-sleeve", ++ GPIOD_OUT_LOW); ++ ++ if (IS_ERR(rt5645->gpiod_cbj_sleeve)) { ++ ret = PTR_ERR(rt5645->gpiod_cbj_sleeve); ++ dev_info(&i2c->dev, "failed to initialize gpiod, ret=%d\n", ret); ++ if (ret != -ENOENT) ++ return ret; ++ } ++ + for (i = 0; i < ARRAY_SIZE(rt5645->supplies); i++) + rt5645->supplies[i].supply = rt5645_supply_names[i]; + +@@ -4259,6 +4278,9 @@ static void rt5645_i2c_remove(struct i2c_client *i2c) + cancel_delayed_work_sync(&rt5645->jack_detect_work); + cancel_delayed_work_sync(&rt5645->rcclock_work); + ++ if (rt5645->gpiod_cbj_sleeve) ++ gpiod_set_value(rt5645->gpiod_cbj_sleeve, 0); ++ + regulator_bulk_disable(ARRAY_SIZE(rt5645->supplies), rt5645->supplies); + } + +@@ -4274,6 +4296,9 @@ static void rt5645_i2c_shutdown(struct i2c_client *i2c) + 0); + msleep(20); + regmap_write(rt5645->regmap, RT5645_RESET, 0); ++ ++ if (rt5645->gpiod_cbj_sleeve) ++ gpiod_set_value(rt5645->gpiod_cbj_sleeve, 0); + } + + static int __maybe_unused rt5645_sys_suspend(struct device *dev) +-- +2.43.0 + diff --git a/queue-6.8/asoc-rt715-add-vendor-clear-control-register.patch b/queue-6.8/asoc-rt715-add-vendor-clear-control-register.patch new file mode 100644 index 00000000000..b2bd82001ad --- /dev/null +++ b/queue-6.8/asoc-rt715-add-vendor-clear-control-register.patch @@ -0,0 +1,38 @@ +From fad5ea7e17912d9c66e250cdee3cf741d6924005 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 06:27:23 +0000 +Subject: ASoC: rt715: add vendor clear control register + +From: Jack Yu + +[ Upstream commit cebfbc89ae2552dbb58cd9b8206a5c8e0e6301e9 ] + +Add vendor clear control register in readable register's +callback function. This prevents an access failure reported +in Intel CI tests. + +Signed-off-by: Jack Yu +Closes: https://github.com/thesofproject/linux/issues/4860 +Tested-by: Pierre-Louis Bossart +Link: https://lore.kernel.org/r/6a103ce9134d49d8b3941172c87a7bd4@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt715-sdw.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c +index 21f37babd148a..376585f5a8dd8 100644 +--- a/sound/soc/codecs/rt715-sdw.c ++++ b/sound/soc/codecs/rt715-sdw.c +@@ -111,6 +111,7 @@ static bool rt715_readable_register(struct device *dev, unsigned int reg) + case 0x839d: + case 0x83a7: + case 0x83a9: ++ case 0x752001: + case 0x752039: + return true; + default: +-- +2.43.0 + diff --git a/queue-6.8/asoc-rt715-sdca-volume-step-modification.patch b/queue-6.8/asoc-rt715-sdca-volume-step-modification.patch new file mode 100644 index 00000000000..57dd7c80747 --- /dev/null +++ b/queue-6.8/asoc-rt715-sdca-volume-step-modification.patch @@ -0,0 +1,61 @@ +From 524ee1a051275e2f4e74b10bce5843aa252f74e5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 06:59:35 +0000 +Subject: ASoC: rt715-sdca: volume step modification + +From: Jack Yu + +[ Upstream commit bda16500dd0b05e2e047093b36cbe0873c95aeae ] + +Volume step (dB/step) modification to fix format error +which shown in amixer control. + +Signed-off-by: Jack Yu +Link: https://lore.kernel.org/r/b1f546ad16dc4c7abb7daa7396e8345c@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt715-sdca.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/sound/soc/codecs/rt715-sdca.c b/sound/soc/codecs/rt715-sdca.c +index 4533eedd7e189..27d17e3cc8027 100644 +--- a/sound/soc/codecs/rt715-sdca.c ++++ b/sound/soc/codecs/rt715-sdca.c +@@ -316,7 +316,7 @@ static int rt715_sdca_set_amp_gain_8ch_get(struct snd_kcontrol *kcontrol, + return 0; + } + +-static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -17625, 375, 0); ++static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -1725, 75, 0); + static const DECLARE_TLV_DB_SCALE(mic_vol_tlv, 0, 1000, 0); + + static int rt715_sdca_get_volsw(struct snd_kcontrol *kcontrol, +@@ -477,7 +477,7 @@ static const struct snd_kcontrol_new rt715_sdca_snd_controls[] = { + RT715_SDCA_FU_VOL_CTRL, CH_01), + SDW_SDCA_CTL(FUN_MIC_ARRAY, RT715_SDCA_FU_ADC7_27_VOL, + RT715_SDCA_FU_VOL_CTRL, CH_02), +- 0x2f, 0x7f, 0, ++ 0x2f, 0x3f, 0, + rt715_sdca_set_amp_gain_get, rt715_sdca_set_amp_gain_put, + in_vol_tlv), + RT715_SDCA_EXT_TLV("FU02 Capture Volume", +@@ -485,13 +485,13 @@ static const struct snd_kcontrol_new rt715_sdca_snd_controls[] = { + RT715_SDCA_FU_VOL_CTRL, CH_01), + rt715_sdca_set_amp_gain_4ch_get, + rt715_sdca_set_amp_gain_4ch_put, +- in_vol_tlv, 4, 0x7f), ++ in_vol_tlv, 4, 0x3f), + RT715_SDCA_EXT_TLV("FU06 Capture Volume", + SDW_SDCA_CTL(FUN_MIC_ARRAY, RT715_SDCA_FU_ADC10_11_VOL, + RT715_SDCA_FU_VOL_CTRL, CH_01), + rt715_sdca_set_amp_gain_4ch_get, + rt715_sdca_set_amp_gain_4ch_put, +- in_vol_tlv, 4, 0x7f), ++ in_vol_tlv, 4, 0x3f), + /* MIC Boost Control */ + RT715_SDCA_BOOST_EXT_TLV("FU0E Boost", + SDW_SDCA_CTL(FUN_MIC_ARRAY, RT715_SDCA_FU_DMIC_GAIN_EN, +-- +2.43.0 + diff --git a/queue-6.8/asoc-rt722-sdca-add-headset-microphone-vrefo-setting.patch b/queue-6.8/asoc-rt722-sdca-add-headset-microphone-vrefo-setting.patch new file mode 100644 index 00000000000..2547ca066d0 --- /dev/null +++ b/queue-6.8/asoc-rt722-sdca-add-headset-microphone-vrefo-setting.patch @@ -0,0 +1,96 @@ +From 0c7b65bd422feb35e9380c05a26cb3e93cd35623 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 06:47:34 +0000 +Subject: ASoC: rt722-sdca: add headset microphone vrefo setting + +From: Jack Yu + +[ Upstream commit 140e0762ca055d1aa84b17847cde5d9e47f56f76 ] + +Add vrefo settings to fix jd and headset mic recording issue. + +Signed-off-by: Jack Yu +Link: https://msgid.link/r/727219ed45d3485ba8f4646700aaa8a8@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt722-sdca.c | 25 +++++++++++++++++++------ + sound/soc/codecs/rt722-sdca.h | 3 +++ + 2 files changed, 22 insertions(+), 6 deletions(-) + +diff --git a/sound/soc/codecs/rt722-sdca.c b/sound/soc/codecs/rt722-sdca.c +index 4338cdb3a7917..9ff607984ea19 100644 +--- a/sound/soc/codecs/rt722-sdca.c ++++ b/sound/soc/codecs/rt722-sdca.c +@@ -1438,9 +1438,12 @@ static void rt722_sdca_jack_preset(struct rt722_sdca_priv *rt722) + int loop_check, chk_cnt = 100, ret; + unsigned int calib_status = 0; + +- /* Read eFuse */ +- rt722_sdca_index_write(rt722, RT722_VENDOR_SPK_EFUSE, RT722_DC_CALIB_CTRL, +- 0x4808); ++ /* Config analog bias */ ++ rt722_sdca_index_write(rt722, RT722_VENDOR_REG, RT722_ANALOG_BIAS_CTL3, ++ 0xa081); ++ /* GE related settings */ ++ rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_GE_RELATED_CTL2, ++ 0xa009); + /* Button A, B, C, D bypass mode */ + rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_UMP_HID_CTL4, + 0xcf00); +@@ -1474,9 +1477,6 @@ static void rt722_sdca_jack_preset(struct rt722_sdca_priv *rt722) + if ((calib_status & 0x0040) == 0x0) + break; + } +- /* Release HP-JD, EN_CBJ_TIE_GL/R open, en_osw gating auto done bit */ +- rt722_sdca_index_write(rt722, RT722_VENDOR_REG, RT722_DIGITAL_MISC_CTRL4, +- 0x0010); + /* Set ADC09 power entity floating control */ + rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_ADC0A_08_PDE_FLOAT_CTL, + 0x2a12); +@@ -1489,8 +1489,21 @@ static void rt722_sdca_jack_preset(struct rt722_sdca_priv *rt722) + /* Set DAC03 and HP power entity floating control */ + rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_DAC03_HP_PDE_FLOAT_CTL, + 0x4040); ++ rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_ENT_FLOAT_CTRL_1, ++ 0x4141); ++ rt722_sdca_index_write(rt722, RT722_VENDOR_HDA_CTL, RT722_FLOAT_CTRL_1, ++ 0x0101); + /* Fine tune PDE40 latency */ + regmap_write(rt722->regmap, 0x2f58, 0x07); ++ regmap_write(rt722->regmap, 0x2f03, 0x06); ++ /* MIC VRefo */ ++ rt722_sdca_index_update_bits(rt722, RT722_VENDOR_REG, ++ RT722_COMBO_JACK_AUTO_CTL1, 0x0200, 0x0200); ++ rt722_sdca_index_update_bits(rt722, RT722_VENDOR_REG, ++ RT722_VREFO_GAT, 0x4000, 0x4000); ++ /* Release HP-JD, EN_CBJ_TIE_GL/R open, en_osw gating auto done bit */ ++ rt722_sdca_index_write(rt722, RT722_VENDOR_REG, RT722_DIGITAL_MISC_CTRL4, ++ 0x0010); + } + + int rt722_sdca_io_init(struct device *dev, struct sdw_slave *slave) +diff --git a/sound/soc/codecs/rt722-sdca.h b/sound/soc/codecs/rt722-sdca.h +index 44af8901352eb..2464361a7958c 100644 +--- a/sound/soc/codecs/rt722-sdca.h ++++ b/sound/soc/codecs/rt722-sdca.h +@@ -69,6 +69,7 @@ struct rt722_sdca_dmic_kctrl_priv { + #define RT722_COMBO_JACK_AUTO_CTL2 0x46 + #define RT722_COMBO_JACK_AUTO_CTL3 0x47 + #define RT722_DIGITAL_MISC_CTRL4 0x4a ++#define RT722_VREFO_GAT 0x63 + #define RT722_FSM_CTL 0x67 + #define RT722_SDCA_INTR_REC 0x82 + #define RT722_SW_CONFIG1 0x8a +@@ -127,6 +128,8 @@ struct rt722_sdca_dmic_kctrl_priv { + #define RT722_UMP_HID_CTL6 0x66 + #define RT722_UMP_HID_CTL7 0x67 + #define RT722_UMP_HID_CTL8 0x68 ++#define RT722_FLOAT_CTRL_1 0x70 ++#define RT722_ENT_FLOAT_CTRL_1 0x76 + + /* Parameter & Verb control 01 (0x1a)(NID:20h) */ + #define RT722_HIDDEN_REG_SW_RESET (0x1 << 14) +-- +2.43.0 + diff --git a/queue-6.8/asoc-rt722-sdca-modify-channel-number-to-support-4-c.patch b/queue-6.8/asoc-rt722-sdca-modify-channel-number-to-support-4-c.patch new file mode 100644 index 00000000000..7dcf464fd99 --- /dev/null +++ b/queue-6.8/asoc-rt722-sdca-modify-channel-number-to-support-4-c.patch @@ -0,0 +1,36 @@ +From 7c48e5f7cb3d68c019abea773df82fc0ecb57315 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 06:47:43 +0000 +Subject: ASoC: rt722-sdca: modify channel number to support 4 channels + +From: Jack Yu + +[ Upstream commit cb9946971d7cb717b726710e1a9fa4ded00b9135 ] + +Channel numbers of dmic supports 4 channels, modify channels_max +regarding to this issue. + +Signed-off-by: Jack Yu +Link: https://msgid.link/r/6a9b1d1fb2ea4f04b2157799f04053b1@realtek.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/rt722-sdca.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/sound/soc/codecs/rt722-sdca.c b/sound/soc/codecs/rt722-sdca.c +index 0e1c65a20392a..4338cdb3a7917 100644 +--- a/sound/soc/codecs/rt722-sdca.c ++++ b/sound/soc/codecs/rt722-sdca.c +@@ -1329,7 +1329,7 @@ static struct snd_soc_dai_driver rt722_sdca_dai[] = { + .capture = { + .stream_name = "DP6 DMic Capture", + .channels_min = 1, +- .channels_max = 2, ++ .channels_max = 4, + .rates = RT722_STEREO_RATES, + .formats = RT722_FORMATS, + }, +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-intel-hda-dai-fix-channel-map-configuration.patch b/queue-6.8/asoc-sof-intel-hda-dai-fix-channel-map-configuration.patch new file mode 100644 index 00000000000..97058a8c2ca --- /dev/null +++ b/queue-6.8/asoc-sof-intel-hda-dai-fix-channel-map-configuration.patch @@ -0,0 +1,92 @@ +From 87fb1be3effe0dc602622c5668f62e14ae5ae95d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 10:18:12 -0500 +Subject: ASoC: SOF: Intel: hda-dai: fix channel map configuration for + aggregated dailink + +From: Pierre-Louis Bossart + +[ Upstream commit 831045513c8a2ef14c3cf39b33d1ccedf588c4a8 ] + +The existing code derives the channel map used to program the HDaudio +link DMA from the hw_params, but that is not quite right in the case +of aggregation. The code in soc-pcm.c splits the hw_params depending +on the codec_ch_map, and we need to reconstruct the channel-map to +insert the data in the right places. + +This issue is seen only on amplifier feedback capture where the data +from the second amplifier was replaced by that of the first amplifier. + +Note that the loop iterator of the macro for_each_rtd_cpu_dais() is +reused in a following loop. This is different to all existing usages +of that macro, hence the use of a boolean flag to avoid an access to +an uninitialized variable. + +Fixes: 2960ee5c4814 ("ASoC: SOF: Intel: hda-dai: add helpers for SoundWire callbacks") +Reviewed-by: Bard Liao +Reviewed-by: Rander Wang +Signed-off-by: Pierre-Louis Bossart +Link: https://msgid.link/r/20240402151828.175002-2-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/intel/hda-dai.c | 31 +++++++++++++++++++++++++++++-- + 1 file changed, 29 insertions(+), 2 deletions(-) + +diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c +index f4cbc0ad5de3b..0e665c0840d71 100644 +--- a/sound/soc/sof/intel/hda-dai.c ++++ b/sound/soc/sof/intel/hda-dai.c +@@ -434,10 +434,17 @@ int sdw_hda_dai_hw_params(struct snd_pcm_substream *substream, + int link_id) + { + struct snd_soc_dapm_widget *w = snd_soc_dai_get_widget(cpu_dai, substream->stream); ++ struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); + const struct hda_dai_widget_dma_ops *ops; ++ struct snd_soc_dai_link_ch_map *ch_maps; + struct hdac_ext_stream *hext_stream; ++ struct snd_soc_dai *dai; + struct snd_sof_dev *sdev; ++ bool cpu_dai_found = false; ++ int cpu_dai_id; ++ int ch_mask; + int ret; ++ int j; + + ret = non_hda_dai_hw_params(substream, params, cpu_dai); + if (ret < 0) { +@@ -452,9 +459,29 @@ int sdw_hda_dai_hw_params(struct snd_pcm_substream *substream, + if (!hext_stream) + return -ENODEV; + +- /* in the case of SoundWire we need to program the PCMSyCM registers */ ++ /* ++ * in the case of SoundWire we need to program the PCMSyCM registers. In case ++ * of aggregated devices, we need to define the channel mask for each sublink ++ * by reconstructing the split done in soc-pcm.c ++ */ ++ for_each_rtd_cpu_dais(rtd, cpu_dai_id, dai) { ++ if (dai == cpu_dai) { ++ cpu_dai_found = true; ++ break; ++ } ++ } ++ ++ if (!cpu_dai_found) ++ return -ENODEV; ++ ++ ch_mask = 0; ++ for_each_link_ch_maps(rtd->dai_link, j, ch_maps) { ++ if (ch_maps->cpu == cpu_dai_id) ++ ch_mask |= ch_maps->ch_mask; ++ } ++ + ret = hdac_bus_eml_sdw_map_stream_ch(sof_to_bus(sdev), link_id, cpu_dai->id, +- GENMASK(params_channels(params) - 1, 0), ++ ch_mask, + hdac_stream(hext_stream)->stream_tag, + substream->stream); + if (ret < 0) { +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-intel-lnl-correct-rom_status_reg.patch b/queue-6.8/asoc-sof-intel-lnl-correct-rom_status_reg.patch new file mode 100644 index 00000000000..d46e87a6763 --- /dev/null +++ b/queue-6.8/asoc-sof-intel-lnl-correct-rom_status_reg.patch @@ -0,0 +1,79 @@ +From f6329f07ebce2ac336f803a02cc1970fc684bf00 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:52:06 +0300 +Subject: ASoC: SOF: Intel: lnl: Correct rom_status_reg + +From: Peter Ujfalusi + +[ Upstream commit b852574c671a9983dd51c81582c8c5085f3dc382 ] + +ACE2 architecture changed the place where the ROM updates the status code +from the shared SRAM window (and HFFLGP1QW0 in ACE1) to HFDSC register for +the status and HFDEC (HFDSC + 4) for the error code. + +The rom_status_reg is not used on LNL because it was wrongly assigned based +on older platform convention (SRAM window) and it was giving inconsistent +readings. + +Add new header file for lnl specific register definitions. + +Fixes: 64a63d9914a5 ("ASoC: SOF: Intel: LNL: Add support for Lunarlake platform") +Signed-off-by: Peter Ujfalusi +Reviewed-by: Rander Wang +Reviewed-by: Kai Vehmanen +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Liam Girdwood +Link: https://msgid.link/r/20240403105210.17949-4-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/intel/lnl.c | 3 ++- + sound/soc/sof/intel/lnl.h | 15 +++++++++++++++ + 2 files changed, 17 insertions(+), 1 deletion(-) + create mode 100644 sound/soc/sof/intel/lnl.h + +diff --git a/sound/soc/sof/intel/lnl.c b/sound/soc/sof/intel/lnl.c +index 555a51c688dc6..d6c4d6cd20b05 100644 +--- a/sound/soc/sof/intel/lnl.c ++++ b/sound/soc/sof/intel/lnl.c +@@ -16,6 +16,7 @@ + #include "hda-ipc.h" + #include "../sof-audio.h" + #include "mtl.h" ++#include "lnl.h" + #include + + /* LunarLake ops */ +@@ -176,7 +177,7 @@ const struct sof_intel_dsp_desc lnl_chip_info = { + .ipc_ack = MTL_DSP_REG_HFIPCXIDA, + .ipc_ack_mask = MTL_DSP_REG_HFIPCXIDA_DONE, + .ipc_ctl = MTL_DSP_REG_HFIPCXCTL, +- .rom_status_reg = MTL_DSP_ROM_STS, ++ .rom_status_reg = LNL_DSP_REG_HFDSC, + .rom_init_timeout = 300, + .ssp_count = MTL_SSP_COUNT, + .d0i3_offset = MTL_HDA_VS_D0I3C, +diff --git a/sound/soc/sof/intel/lnl.h b/sound/soc/sof/intel/lnl.h +new file mode 100644 +index 0000000000000..4f4734fe7e089 +--- /dev/null ++++ b/sound/soc/sof/intel/lnl.h +@@ -0,0 +1,15 @@ ++/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ ++/* ++ * This file is provided under a dual BSD/GPLv2 license. When using or ++ * redistributing this file, you may do so under either license. ++ * ++ * Copyright(c) 2024 Intel Corporation. All rights reserved. ++ */ ++ ++#ifndef __SOF_INTEL_LNL_H ++#define __SOF_INTEL_LNL_H ++ ++#define LNL_DSP_REG_HFDSC 0x160200 /* DSP core0 status */ ++#define LNL_DSP_REG_HFDEC 0x160204 /* DSP core0 error */ ++ ++#endif /* __SOF_INTEL_LNL_H */ +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-intel-mtl-correct-rom_status_reg.patch b/queue-6.8/asoc-sof-intel-mtl-correct-rom_status_reg.patch new file mode 100644 index 00000000000..ca230b37457 --- /dev/null +++ b/queue-6.8/asoc-sof-intel-mtl-correct-rom_status_reg.patch @@ -0,0 +1,71 @@ +From 4f36b6d9b38b24909e370c65377b4eff76aebd18 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:52:05 +0300 +Subject: ASoC: SOF: Intel: mtl: Correct rom_status_reg + +From: Peter Ujfalusi + +[ Upstream commit 1f1b820dc3c65b6883da3130ba3b8624dcbf87db ] + +ACE1 architecture changed the place where the ROM updates the status code +from the shared SRAM window to HFFLGP1QW0 register for the status and +HFFLGP1QW0 + 4 for the error code. + +The rom_status_reg is not used on MTL because it was wrongly assigned based +on older platform convention (SRAM window) and it was giving inconsistent +readings. + +Fixes: 064520e8aeaa ("ASoC: SOF: Intel: Add support for MeteorLake (MTL)") +Signed-off-by: Peter Ujfalusi +Reviewed-by: Rander Wang +Reviewed-by: Kai Vehmanen +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Liam Girdwood +Link: https://msgid.link/r/20240403105210.17949-3-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/intel/mtl.c | 4 ++-- + sound/soc/sof/intel/mtl.h | 4 ++-- + 2 files changed, 4 insertions(+), 4 deletions(-) + +diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c +index 060c34988e90d..1454e2a98c3b0 100644 +--- a/sound/soc/sof/intel/mtl.c ++++ b/sound/soc/sof/intel/mtl.c +@@ -727,7 +727,7 @@ const struct sof_intel_dsp_desc mtl_chip_info = { + .ipc_ack = MTL_DSP_REG_HFIPCXIDA, + .ipc_ack_mask = MTL_DSP_REG_HFIPCXIDA_DONE, + .ipc_ctl = MTL_DSP_REG_HFIPCXCTL, +- .rom_status_reg = MTL_DSP_ROM_STS, ++ .rom_status_reg = MTL_DSP_REG_HFFLGPXQWY, + .rom_init_timeout = 300, + .ssp_count = MTL_SSP_COUNT, + .ssp_base_offset = CNL_SSP_BASE_OFFSET, +@@ -755,7 +755,7 @@ const struct sof_intel_dsp_desc arl_s_chip_info = { + .ipc_ack = MTL_DSP_REG_HFIPCXIDA, + .ipc_ack_mask = MTL_DSP_REG_HFIPCXIDA_DONE, + .ipc_ctl = MTL_DSP_REG_HFIPCXCTL, +- .rom_status_reg = MTL_DSP_ROM_STS, ++ .rom_status_reg = MTL_DSP_REG_HFFLGPXQWY, + .rom_init_timeout = 300, + .ssp_count = MTL_SSP_COUNT, + .ssp_base_offset = CNL_SSP_BASE_OFFSET, +diff --git a/sound/soc/sof/intel/mtl.h b/sound/soc/sof/intel/mtl.h +index ea8c1b83f7127..3c56427a966bf 100644 +--- a/sound/soc/sof/intel/mtl.h ++++ b/sound/soc/sof/intel/mtl.h +@@ -70,8 +70,8 @@ + #define MTL_DSP_ROM_STS MTL_SRAM_WINDOW_OFFSET(0) /* ROM status */ + #define MTL_DSP_ROM_ERROR (MTL_SRAM_WINDOW_OFFSET(0) + 0x4) /* ROM error code */ + +-#define MTL_DSP_REG_HFFLGPXQWY 0x163200 /* ROM debug status */ +-#define MTL_DSP_REG_HFFLGPXQWY_ERROR 0x163204 /* ROM debug error code */ ++#define MTL_DSP_REG_HFFLGPXQWY 0x163200 /* DSP core0 status */ ++#define MTL_DSP_REG_HFFLGPXQWY_ERROR 0x163204 /* DSP core0 error */ + #define MTL_DSP_REG_HfIMRIS1 0x162088 + #define MTL_DSP_REG_HfIMRIS1_IU_MASK BIT(0) + +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-intel-mtl-disable-interrupts-when-firmware-.patch b/queue-6.8/asoc-sof-intel-mtl-disable-interrupts-when-firmware-.patch new file mode 100644 index 00000000000..ff24f409e14 --- /dev/null +++ b/queue-6.8/asoc-sof-intel-mtl-disable-interrupts-when-firmware-.patch @@ -0,0 +1,40 @@ +From a8416e11594d94fff7febdb92064f86964f8fec4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:52:07 +0300 +Subject: ASoC: SOF: Intel: mtl: Disable interrupts when firmware boot failed + +From: Peter Ujfalusi + +[ Upstream commit 26187f44aabdf3df7609b7c78724a059c230a2ad ] + +In case of error during the firmware boot we need to disable the interrupts +which were enabled as part of the boot sequence. + +Fixes: 064520e8aeaa ("ASoC: SOF: Intel: Add support for MeteorLake (MTL)") +Signed-off-by: Peter Ujfalusi +Reviewed-by: Rander Wang +Reviewed-by: Kai Vehmanen +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Liam Girdwood +Link: https://msgid.link/r/20240403105210.17949-5-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/intel/mtl.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c +index 1454e2a98c3b0..fbd7cf77e8174 100644 +--- a/sound/soc/sof/intel/mtl.c ++++ b/sound/soc/sof/intel/mtl.c +@@ -503,6 +503,7 @@ int mtl_dsp_cl_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot) + dump_msg = kasprintf(GFP_KERNEL, "Boot iteration failed: %d/%d", + hda->boot_iteration, HDA_FW_BOOT_ATTEMPTS); + snd_sof_dsp_dbg_dump(sdev, dump_msg, flags); ++ mtl_enable_interrupts(sdev, false); + mtl_dsp_core_power_down(sdev, SOF_DSP_PRIMARY_CORE); + + kfree(dump_msg); +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-intel-mtl-implement-firmware-boot-state-che.patch b/queue-6.8/asoc-sof-intel-mtl-implement-firmware-boot-state-che.patch new file mode 100644 index 00000000000..b17f73c39fa --- /dev/null +++ b/queue-6.8/asoc-sof-intel-mtl-implement-firmware-boot-state-che.patch @@ -0,0 +1,88 @@ +From c767b6784f728d34322d840c2cbd8ef42c797a1b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:52:08 +0300 +Subject: ASoC: SOF: Intel: mtl: Implement firmware boot state check + +From: Peter Ujfalusi + +[ Upstream commit 6b1c1c47e76f0161bda2b1ac2e86a219fe70244f ] + +With the corrected rom_status_reg values we can now add a check for target +boot status for firmware booting. +With the check now we can identify failed firmware boots (IMR boots) and +we can use the fallback to purge boot the DSP. + +Fixes: 064520e8aeaa ("ASoC: SOF: Intel: Add support for MeteorLake (MTL)") +Signed-off-by: Peter Ujfalusi +Reviewed-by: Rander Wang +Reviewed-by: Kai Vehmanen +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Liam Girdwood +Link: https://msgid.link/r/20240403105210.17949-6-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/intel/mtl.c | 37 ++++++++++++++++++++++++++++++++----- + 1 file changed, 32 insertions(+), 5 deletions(-) + +diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c +index fbd7cf77e8174..05023763080d9 100644 +--- a/sound/soc/sof/intel/mtl.c ++++ b/sound/soc/sof/intel/mtl.c +@@ -439,7 +439,7 @@ int mtl_dsp_cl_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot) + { + struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata; + const struct sof_intel_dsp_desc *chip = hda->desc; +- unsigned int status; ++ unsigned int status, target_status; + u32 ipc_hdr, flags; + char *dump_msg; + int ret; +@@ -485,13 +485,40 @@ int mtl_dsp_cl_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot) + + mtl_enable_ipc_interrupts(sdev); + ++ if (chip->rom_status_reg == MTL_DSP_ROM_STS) { ++ /* ++ * Workaround: when the ROM status register is pointing to ++ * the SRAM window (MTL_DSP_ROM_STS) the platform cannot catch ++ * ROM_INIT_DONE because of a very short timing window. ++ * Follow the recommendations and skip target state waiting. ++ */ ++ return 0; ++ } ++ + /* +- * ACE workaround: don't wait for ROM INIT. +- * The platform cannot catch ROM_INIT_DONE because of a very short +- * timing window. Follow the recommendations and skip this part. ++ * step 7: ++ * - Cold/Full boot: wait for ROM init to proceed to download the firmware ++ * - IMR boot: wait for ROM firmware entered (firmware booted up from IMR) + */ ++ if (imr_boot) ++ target_status = FSR_STATE_FW_ENTERED; ++ else ++ target_status = FSR_STATE_INIT_DONE; + +- return 0; ++ ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR, ++ chip->rom_status_reg, status, ++ (FSR_TO_STATE_CODE(status) == target_status), ++ HDA_DSP_REG_POLL_INTERVAL_US, ++ chip->rom_init_timeout * ++ USEC_PER_MSEC); ++ ++ if (!ret) ++ return 0; ++ ++ if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS) ++ dev_err(sdev->dev, ++ "%s: timeout with rom_status_reg (%#x) read\n", ++ __func__, chip->rom_status_reg); + + err: + flags = SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_OPTIONAL; +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-ipc4-pcm-introduce-generic-sof_ipc4_pcm_str.patch b/queue-6.8/asoc-sof-ipc4-pcm-introduce-generic-sof_ipc4_pcm_str.patch new file mode 100644 index 00000000000..c3d611b5948 --- /dev/null +++ b/queue-6.8/asoc-sof-ipc4-pcm-introduce-generic-sof_ipc4_pcm_str.patch @@ -0,0 +1,156 @@ +From 7bc0b8be9f44fbf3d337e8d46f302f8b6fbeee85 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 14:00:35 +0300 +Subject: ASoC: SOF: ipc4-pcm: Introduce generic sof_ipc4_pcm_stream_priv + +From: Peter Ujfalusi + +[ Upstream commit 551af3280c16166244425bbb1d73028f3a907e1f ] + +Using the sof_ipc4_timestamp_info struct directly as sps->private data +is too restrictive, add a new generic sof_ipc4_pcm_stream_priv struct +containing the time_info to allow new information to be stored in a +generic way. + +Signed-off-by: Peter Ujfalusi +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Ranjani Sridharan +Link: https://msgid.link/r/20240409110036.9411-4-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/ipc4-pcm.c | 43 ++++++++++++++++++++++++++++++++-------- + 1 file changed, 35 insertions(+), 8 deletions(-) + +diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c +index 3f8b9443496ce..d07c1b06207a5 100644 +--- a/sound/soc/sof/ipc4-pcm.c ++++ b/sound/soc/sof/ipc4-pcm.c +@@ -37,6 +37,22 @@ struct sof_ipc4_timestamp_info { + snd_pcm_sframes_t delay; + }; + ++/** ++ * struct sof_ipc4_pcm_stream_priv - IPC4 specific private data ++ * @time_info: pointer to time info struct if it is supported, otherwise NULL ++ */ ++struct sof_ipc4_pcm_stream_priv { ++ struct sof_ipc4_timestamp_info *time_info; ++}; ++ ++static inline struct sof_ipc4_timestamp_info * ++sof_ipc4_sps_to_time_info(struct snd_sof_pcm_stream *sps) ++{ ++ struct sof_ipc4_pcm_stream_priv *stream_priv = sps->private; ++ ++ return stream_priv->time_info; ++} ++ + static int sof_ipc4_set_multi_pipeline_state(struct snd_sof_dev *sdev, u32 state, + struct ipc4_pipeline_set_state_data *trigger_list) + { +@@ -435,7 +451,7 @@ static int sof_ipc4_trigger_pipelines(struct snd_soc_component *component, + * Invalidate the stream_start_offset to make sure that it is + * going to be updated if the stream resumes + */ +- time_info = spcm->stream[substream->stream].private; ++ time_info = sof_ipc4_sps_to_time_info(&spcm->stream[substream->stream]); + if (time_info) + time_info->stream_start_offset = SOF_IPC4_INVALID_STREAM_POSITION; + +@@ -689,12 +705,16 @@ static int sof_ipc4_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd, + static void sof_ipc4_pcm_free(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm) + { + struct snd_sof_pcm_stream_pipeline_list *pipeline_list; ++ struct sof_ipc4_pcm_stream_priv *stream_priv; + int stream; + + for_each_pcm_streams(stream) { + pipeline_list = &spcm->stream[stream].pipeline_list; + kfree(pipeline_list->pipelines); + pipeline_list->pipelines = NULL; ++ ++ stream_priv = spcm->stream[stream].private; ++ kfree(stream_priv->time_info); + kfree(spcm->stream[stream].private); + spcm->stream[stream].private = NULL; + } +@@ -704,6 +724,7 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + { + struct snd_sof_pcm_stream_pipeline_list *pipeline_list; + struct sof_ipc4_fw_data *ipc4_data = sdev->private; ++ struct sof_ipc4_pcm_stream_priv *stream_priv; + struct sof_ipc4_timestamp_info *time_info; + bool support_info = true; + u32 abi_version; +@@ -732,6 +753,14 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + return -ENOMEM; + } + ++ stream_priv = kzalloc(sizeof(*stream_priv), GFP_KERNEL); ++ if (!stream_priv) { ++ sof_ipc4_pcm_free(sdev, spcm); ++ return -ENOMEM; ++ } ++ ++ spcm->stream[stream].private = stream_priv; ++ + if (!support_info) + continue; + +@@ -741,7 +770,7 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + return -ENOMEM; + } + +- spcm->stream[stream].private = time_info; ++ stream_priv->time_info = time_info; + } + + return 0; +@@ -778,7 +807,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc + return; + } + +- time_info = sps->private; ++ time_info = sof_ipc4_sps_to_time_info(sps); + time_info->host_copier = host_copier; + time_info->dai_copier = dai_copier; + time_info->llp_offset = offsetof(struct sof_ipc4_fw_registers, +@@ -832,7 +861,7 @@ static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component, + if (!spcm) + return -EINVAL; + +- time_info = spcm->stream[substream->stream].private; ++ time_info = sof_ipc4_sps_to_time_info(&spcm->stream[substream->stream]); + /* delay calculation is not supported by current fw_reg ABI */ + if (!time_info) + return 0; +@@ -911,7 +940,7 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component, + return -EOPNOTSUPP; + + sps = &spcm->stream[substream->stream]; +- time_info = sps->private; ++ time_info = sof_ipc4_sps_to_time_info(sps); + if (!time_info) + return -EOPNOTSUPP; + +@@ -1013,15 +1042,13 @@ static snd_pcm_sframes_t sof_ipc4_pcm_delay(struct snd_soc_component *component, + { + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); + struct sof_ipc4_timestamp_info *time_info; +- struct snd_sof_pcm_stream *sps; + struct snd_sof_pcm *spcm; + + spcm = snd_sof_find_spcm_dai(component, rtd); + if (!spcm) + return 0; + +- sps = &spcm->stream[substream->stream]; +- time_info = sps->private; ++ time_info = sof_ipc4_sps_to_time_info(&spcm->stream[substream->stream]); + /* + * Report the stored delay value calculated in the pointer callback. + * In the unlikely event that the calculation was skipped/aborted, the +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-snd_sof_pc.patch b/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-snd_sof_pc.patch new file mode 100644 index 00000000000..dbfbc222346 --- /dev/null +++ b/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-snd_sof_pc.patch @@ -0,0 +1,117 @@ +From ad36dcd8cb39bf5de574785c53215233e14b88f7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 14:00:33 +0300 +Subject: ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream + pointer + +From: Peter Ujfalusi + +[ Upstream commit 965e49cdf8c19f21b8308adeded3a8139cff5c84 ] + +Throughout the file the pointer for snd_sof_pcm_stream is named either +'stream' or (wrongly) 'spcm' which confuses the reader. + +Use 'sps' for the pointer name as it is the most common name used in SOF +codebase. + +Signed-off-by: Peter Ujfalusi +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Ranjani Sridharan +Link: https://msgid.link/r/20240409110036.9411-2-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/ipc4-pcm.c | 22 +++++++++++----------- + 1 file changed, 11 insertions(+), 11 deletions(-) + +diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c +index a99fced908251..31133c5dcbf50 100644 +--- a/sound/soc/sof/ipc4-pcm.c ++++ b/sound/soc/sof/ipc4-pcm.c +@@ -747,7 +747,7 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + return 0; + } + +-static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pcm_stream *spcm) ++static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pcm_stream *sps) + { + struct sof_ipc4_copier *host_copier = NULL; + struct sof_ipc4_copier *dai_copier = NULL; +@@ -758,7 +758,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc + int i; + + /* find host & dai to locate info in memory window */ +- for_each_dapm_widgets(spcm->list, i, widget) { ++ for_each_dapm_widgets(sps->list, i, widget) { + struct snd_sof_widget *swidget = widget->dobj.private; + + if (!swidget) +@@ -778,7 +778,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc + return; + } + +- info = spcm->private; ++ info = sps->private; + info->host_copier = host_copier; + info->dai_copier = dai_copier; + info->llp_offset = offsetof(struct sof_ipc4_fw_registers, llp_gpdma_reading_slots) + +@@ -847,7 +847,7 @@ static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component, + + static int sof_ipc4_get_stream_start_offset(struct snd_sof_dev *sdev, + struct snd_pcm_substream *substream, +- struct snd_sof_pcm_stream *stream, ++ struct snd_sof_pcm_stream *sps, + struct sof_ipc4_timestamp_info *time_info) + { + struct sof_ipc4_copier *host_copier = time_info->host_copier; +@@ -901,7 +901,7 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component, + struct sof_ipc4_timestamp_info *time_info; + struct sof_ipc4_llp_reading_slot llp; + snd_pcm_uframes_t head_cnt, tail_cnt; +- struct snd_sof_pcm_stream *stream; ++ struct snd_sof_pcm_stream *sps; + u64 dai_cnt, host_cnt, host_ptr; + struct snd_sof_pcm *spcm; + int ret; +@@ -910,8 +910,8 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component, + if (!spcm) + return -EOPNOTSUPP; + +- stream = &spcm->stream[substream->stream]; +- time_info = stream->private; ++ sps = &spcm->stream[substream->stream]; ++ time_info = sps->private; + if (!time_info) + return -EOPNOTSUPP; + +@@ -921,7 +921,7 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component, + * the statistics is complete. And it will not change after the first initiailization. + */ + if (time_info->stream_start_offset == SOF_IPC4_INVALID_STREAM_POSITION) { +- ret = sof_ipc4_get_stream_start_offset(sdev, substream, stream, time_info); ++ ret = sof_ipc4_get_stream_start_offset(sdev, substream, sps, time_info); + if (ret < 0) + return -EOPNOTSUPP; + } +@@ -1013,15 +1013,15 @@ static snd_pcm_sframes_t sof_ipc4_pcm_delay(struct snd_soc_component *component, + { + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); + struct sof_ipc4_timestamp_info *time_info; +- struct snd_sof_pcm_stream *stream; ++ struct snd_sof_pcm_stream *sps; + struct snd_sof_pcm *spcm; + + spcm = snd_sof_find_spcm_dai(component, rtd); + if (!spcm) + return 0; + +- stream = &spcm->stream[substream->stream]; +- time_info = stream->private; ++ sps = &spcm->stream[substream->stream]; ++ time_info = sps->private; + /* + * Report the stored delay value calculated in the pointer callback. + * In the unlikely event that the calculation was skipped/aborted, the +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-sof_ipc4_t.patch b/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-sof_ipc4_t.patch new file mode 100644 index 00000000000..b1d8abd507f --- /dev/null +++ b/queue-6.8/asoc-sof-ipc4-pcm-use-consistent-name-for-sof_ipc4_t.patch @@ -0,0 +1,127 @@ +From bff073cdd4b13a4a65e82decc291168e3b5321b8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 14:00:34 +0300 +Subject: ASoC: SOF: ipc4-pcm: Use consistent name for sof_ipc4_timestamp_info + pointer + +From: Peter Ujfalusi + +[ Upstream commit 36e980050b0733829e4e0f97b97f7907ba9f00bb ] + +The pointer to sof_ipc4_timestamp_info named most of the time as +'time_info' only to be named as 'stream_info' or 'info' in two function. + +Use the consistent name of 'time_info' throughout the file. + +Signed-off-by: Peter Ujfalusi +Reviewed-by: Pierre-Louis Bossart +Reviewed-by: Ranjani Sridharan +Link: https://msgid.link/r/20240409110036.9411-3-peter.ujfalusi@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/ipc4-pcm.c | 40 ++++++++++++++++++++-------------------- + 1 file changed, 20 insertions(+), 20 deletions(-) + +diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c +index 31133c5dcbf50..3f8b9443496ce 100644 +--- a/sound/soc/sof/ipc4-pcm.c ++++ b/sound/soc/sof/ipc4-pcm.c +@@ -704,7 +704,7 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + { + struct snd_sof_pcm_stream_pipeline_list *pipeline_list; + struct sof_ipc4_fw_data *ipc4_data = sdev->private; +- struct sof_ipc4_timestamp_info *stream_info; ++ struct sof_ipc4_timestamp_info *time_info; + bool support_info = true; + u32 abi_version; + u32 abi_offset; +@@ -735,13 +735,13 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm + if (!support_info) + continue; + +- stream_info = kzalloc(sizeof(*stream_info), GFP_KERNEL); +- if (!stream_info) { ++ time_info = kzalloc(sizeof(*time_info), GFP_KERNEL); ++ if (!time_info) { + sof_ipc4_pcm_free(sdev, spcm); + return -ENOMEM; + } + +- spcm->stream[stream].private = stream_info; ++ spcm->stream[stream].private = time_info; + } + + return 0; +@@ -752,7 +752,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc + struct sof_ipc4_copier *host_copier = NULL; + struct sof_ipc4_copier *dai_copier = NULL; + struct sof_ipc4_llp_reading_slot llp_slot; +- struct sof_ipc4_timestamp_info *info; ++ struct sof_ipc4_timestamp_info *time_info; + struct snd_soc_dapm_widget *widget; + struct snd_sof_dai *dai; + int i; +@@ -778,44 +778,44 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc + return; + } + +- info = sps->private; +- info->host_copier = host_copier; +- info->dai_copier = dai_copier; +- info->llp_offset = offsetof(struct sof_ipc4_fw_registers, llp_gpdma_reading_slots) + +- sdev->fw_info_box.offset; ++ time_info = sps->private; ++ time_info->host_copier = host_copier; ++ time_info->dai_copier = dai_copier; ++ time_info->llp_offset = offsetof(struct sof_ipc4_fw_registers, ++ llp_gpdma_reading_slots) + sdev->fw_info_box.offset; + + /* find llp slot used by current dai */ + for (i = 0; i < SOF_IPC4_MAX_LLP_GPDMA_READING_SLOTS; i++) { +- sof_mailbox_read(sdev, info->llp_offset, &llp_slot, sizeof(llp_slot)); ++ sof_mailbox_read(sdev, time_info->llp_offset, &llp_slot, sizeof(llp_slot)); + if (llp_slot.node_id == dai_copier->data.gtw_cfg.node_id) + break; + +- info->llp_offset += sizeof(llp_slot); ++ time_info->llp_offset += sizeof(llp_slot); + } + + if (i < SOF_IPC4_MAX_LLP_GPDMA_READING_SLOTS) + return; + + /* if no llp gpdma slot is used, check aggregated sdw slot */ +- info->llp_offset = offsetof(struct sof_ipc4_fw_registers, llp_sndw_reading_slots) + +- sdev->fw_info_box.offset; ++ time_info->llp_offset = offsetof(struct sof_ipc4_fw_registers, ++ llp_sndw_reading_slots) + sdev->fw_info_box.offset; + for (i = 0; i < SOF_IPC4_MAX_LLP_SNDW_READING_SLOTS; i++) { +- sof_mailbox_read(sdev, info->llp_offset, &llp_slot, sizeof(llp_slot)); ++ sof_mailbox_read(sdev, time_info->llp_offset, &llp_slot, sizeof(llp_slot)); + if (llp_slot.node_id == dai_copier->data.gtw_cfg.node_id) + break; + +- info->llp_offset += sizeof(llp_slot); ++ time_info->llp_offset += sizeof(llp_slot); + } + + if (i < SOF_IPC4_MAX_LLP_SNDW_READING_SLOTS) + return; + + /* check EVAD slot */ +- info->llp_offset = offsetof(struct sof_ipc4_fw_registers, llp_evad_reading_slot) + +- sdev->fw_info_box.offset; +- sof_mailbox_read(sdev, info->llp_offset, &llp_slot, sizeof(llp_slot)); ++ time_info->llp_offset = offsetof(struct sof_ipc4_fw_registers, ++ llp_evad_reading_slot) + sdev->fw_info_box.offset; ++ sof_mailbox_read(sdev, time_info->llp_offset, &llp_slot, sizeof(llp_slot)); + if (llp_slot.node_id != dai_copier->data.gtw_cfg.node_id) +- info->llp_offset = 0; ++ time_info->llp_offset = 0; + } + + static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component, +-- +2.43.0 + diff --git a/queue-6.8/asoc-sof-pcm-restrict-dsp-d0i3-during-s0ix-to-ipc3.patch b/queue-6.8/asoc-sof-pcm-restrict-dsp-d0i3-during-s0ix-to-ipc3.patch new file mode 100644 index 00000000000..a5ce6e98ad8 --- /dev/null +++ b/queue-6.8/asoc-sof-pcm-restrict-dsp-d0i3-during-s0ix-to-ipc3.patch @@ -0,0 +1,84 @@ +From 4819fce3a528a09ee0ec9b8f194e187161356b97 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 14:41:46 -0500 +Subject: ASoC: SOF: pcm: Restrict DSP D0i3 during S0ix to IPC3 + +From: Ranjani Sridharan + +[ Upstream commit 90a2353080eedec855d63f6aadfda14104ee9b06 ] + +Introduce a new field in struct sof_ipc_pcm_ops that can be used to +restrict DSP D0i3 during S0ix suspend to IPC3. With IPC4, all streams +must be stopped before S0ix suspend. + +Reviewed-by: Uday M Bhat +Reviewed-by: Bard Liao +Signed-off-by: Ranjani Sridharan +Signed-off-by: Pierre-Louis Bossart +Link: https://msgid.link/r/20240408194147.28919-3-pierre-louis.bossart@linux.intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/sof/ipc3-pcm.c | 1 + + sound/soc/sof/pcm.c | 13 ++++++------- + sound/soc/sof/sof-audio.h | 2 ++ + 3 files changed, 9 insertions(+), 7 deletions(-) + +diff --git a/sound/soc/sof/ipc3-pcm.c b/sound/soc/sof/ipc3-pcm.c +index 330f04bcd75d2..a7cf52fd76455 100644 +--- a/sound/soc/sof/ipc3-pcm.c ++++ b/sound/soc/sof/ipc3-pcm.c +@@ -409,4 +409,5 @@ const struct sof_ipc_pcm_ops ipc3_pcm_ops = { + .trigger = sof_ipc3_pcm_trigger, + .dai_link_fixup = sof_ipc3_pcm_dai_link_fixup, + .reset_hw_params_during_stop = true, ++ .d0i3_supported_in_s0ix = true, + }; +diff --git a/sound/soc/sof/pcm.c b/sound/soc/sof/pcm.c +index f03cee94bce62..8804e00e7251b 100644 +--- a/sound/soc/sof/pcm.c ++++ b/sound/soc/sof/pcm.c +@@ -325,14 +325,13 @@ static int sof_pcm_trigger(struct snd_soc_component *component, + ipc_first = true; + break; + case SNDRV_PCM_TRIGGER_SUSPEND: +- if (sdev->system_suspend_target == SOF_SUSPEND_S0IX && ++ /* ++ * If DSP D0I3 is allowed during S0iX, set the suspend_ignored flag for ++ * D0I3-compatible streams to keep the firmware pipeline running ++ */ ++ if (pcm_ops && pcm_ops->d0i3_supported_in_s0ix && ++ sdev->system_suspend_target == SOF_SUSPEND_S0IX && + spcm->stream[substream->stream].d0i3_compatible) { +- /* +- * trap the event, not sending trigger stop to +- * prevent the FW pipelines from being stopped, +- * and mark the flag to ignore the upcoming DAPM +- * PM events. +- */ + spcm->stream[substream->stream].suspend_ignored = true; + return 0; + } +diff --git a/sound/soc/sof/sof-audio.h b/sound/soc/sof/sof-audio.h +index 85b26e3fefa8f..05e2a899d746c 100644 +--- a/sound/soc/sof/sof-audio.h ++++ b/sound/soc/sof/sof-audio.h +@@ -116,6 +116,7 @@ struct snd_sof_dai_config_data { + * triggers. The FW keeps the host DMA running in this case and + * therefore the host must do the same and should stop the DMA during + * hw_free. ++ * @d0i3_supported_in_s0ix: Allow DSP D0I3 during S0iX + */ + struct sof_ipc_pcm_ops { + int (*hw_params)(struct snd_soc_component *component, struct snd_pcm_substream *substream, +@@ -135,6 +136,7 @@ struct sof_ipc_pcm_ops { + bool reset_hw_params_during_stop; + bool ipc_first_on_start; + bool platform_stop_during_hw_free; ++ bool d0i3_supported_in_s0ix; + }; + + /** +-- +2.43.0 + diff --git a/queue-6.8/asoc-tracing-export-snd_soc_dapm_dir_out-to-its-valu.patch b/queue-6.8/asoc-tracing-export-snd_soc_dapm_dir_out-to-its-valu.patch new file mode 100644 index 00000000000..bebe9f6ba3d --- /dev/null +++ b/queue-6.8/asoc-tracing-export-snd_soc_dapm_dir_out-to-its-valu.patch @@ -0,0 +1,48 @@ +From f904744e6a4361f8978ab48c94b89afb6d80504d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 00:03:03 -0400 +Subject: ASoC: tracing: Export SND_SOC_DAPM_DIR_OUT to its value + +From: Steven Rostedt + +[ Upstream commit 58300f8d6a48e58d1843199be743f819e2791ea3 ] + +The string SND_SOC_DAPM_DIR_OUT is printed in the snd_soc_dapm_path trace +event instead of its value: + + (((REC->path_dir) == SND_SOC_DAPM_DIR_OUT) ? "->" : "<-") + +User space cannot parse this, as it has no idea what SND_SOC_DAPM_DIR_OUT +is. Use TRACE_DEFINE_ENUM() to convert it to its value: + + (((REC->path_dir) == 1) ? "->" : "<-") + +So that user space tools, such as perf and trace-cmd, can parse it +correctly. + +Reported-by: Luca Ceresoli +Fixes: 6e588a0d839b5 ("ASoC: dapm: Consolidate path trace events") +Signed-off-by: Steven Rostedt (Google) +Link: https://lore.kernel.org/r/20240416000303.04670cdf@rorschach.local.home +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + include/trace/events/asoc.h | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h +index 4d8ef71090af1..97a434d021356 100644 +--- a/include/trace/events/asoc.h ++++ b/include/trace/events/asoc.h +@@ -12,6 +12,8 @@ + #define DAPM_DIRECT "(direct)" + #define DAPM_ARROW(dir) (((dir) == SND_SOC_DAPM_DIR_OUT) ? "->" : "<-") + ++TRACE_DEFINE_ENUM(SND_SOC_DAPM_DIR_OUT); ++ + struct snd_soc_jack; + struct snd_soc_card; + struct snd_soc_dapm_widget; +-- +2.43.0 + diff --git a/queue-6.8/ax25-fix-reference-count-leak-issue-of-net_device.patch b/queue-6.8/ax25-fix-reference-count-leak-issue-of-net_device.patch new file mode 100644 index 00000000000..13e8b014ed9 --- /dev/null +++ b/queue-6.8/ax25-fix-reference-count-leak-issue-of-net_device.patch @@ -0,0 +1,53 @@ +From 0e8a4a77c6290bfc8e86f93df3ef84396b188121 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 17:37:02 +0800 +Subject: ax25: Fix reference count leak issue of net_device + +From: Duoming Zhou + +[ Upstream commit 36e56b1b002bb26440403053f19f9e1a8bc075b2 ] + +There is a reference count leak issue of the object "net_device" in +ax25_dev_device_down(). When the ax25 device is shutting down, the +ax25_dev_device_down() drops the reference count of net_device one +or zero times depending on if we goto unlock_put or not, which will +cause memory leak. + +In order to solve the above issue, decrease the reference count of +net_device after dev->ax25_ptr is set to null. + +Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs") +Suggested-by: Dan Carpenter +Signed-off-by: Duoming Zhou +Reviewed-by: Dan Carpenter +Link: https://lore.kernel.org/r/7ce3b23a40d9084657ba1125432f0ecc380cbc80.1715247018.git.duoming@zju.edu.cn +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ax25/ax25_dev.c | 7 +------ + 1 file changed, 1 insertion(+), 6 deletions(-) + +diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c +index 52ccc37d5687a..c9d55b99a7a57 100644 +--- a/net/ax25/ax25_dev.c ++++ b/net/ax25/ax25_dev.c +@@ -118,15 +118,10 @@ void ax25_dev_device_down(struct net_device *dev) + list_for_each_entry(s, &ax25_dev_list, list) { + if (s == ax25_dev) { + list_del(&s->list); +- goto unlock_put; ++ break; + } + } +- dev->ax25_ptr = NULL; +- spin_unlock_bh(&ax25_dev_lock); +- ax25_dev_put(ax25_dev); +- return; + +-unlock_put: + dev->ax25_ptr = NULL; + spin_unlock_bh(&ax25_dev_lock); + netdev_put(dev, &ax25_dev->dev_tracker); +-- +2.43.0 + diff --git a/queue-6.8/ax25-fix-reference-count-leak-issues-of-ax25_dev.patch b/queue-6.8/ax25-fix-reference-count-leak-issues-of-ax25_dev.patch new file mode 100644 index 00000000000..3a5ff7418df --- /dev/null +++ b/queue-6.8/ax25-fix-reference-count-leak-issues-of-ax25_dev.patch @@ -0,0 +1,74 @@ +From 315ea86c9d08c413504042560aad94272bc9e0ad Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 17:36:47 +0800 +Subject: ax25: Fix reference count leak issues of ax25_dev + +From: Duoming Zhou + +[ Upstream commit b505e0319852b08a3a716b64620168eab21f4ced ] + +The ax25_addr_ax25dev() and ax25_dev_device_down() exist a reference +count leak issue of the object "ax25_dev". + +Memory leak issue in ax25_addr_ax25dev(): + +The reference count of the object "ax25_dev" can be increased multiple +times in ax25_addr_ax25dev(). This will cause a memory leak. + +Memory leak issues in ax25_dev_device_down(): + +The reference count of ax25_dev is set to 1 in ax25_dev_device_up() and +then increase the reference count when ax25_dev is added to ax25_dev_list. +As a result, the reference count of ax25_dev is 2. But when the device is +shutting down. The ax25_dev_device_down() drops the reference count once +or twice depending on if we goto unlock_put or not, which will cause +memory leak. + +As for the issue of ax25_addr_ax25dev(), it is impossible for one pointer +to be on a list twice. So add a break in ax25_addr_ax25dev(). As for the +issue of ax25_dev_device_down(), increase the reference count of ax25_dev +once in ax25_dev_device_up() and decrease the reference count of ax25_dev +after it is removed from the ax25_dev_list. + +Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs") +Suggested-by: Dan Carpenter +Signed-off-by: Duoming Zhou +Reviewed-by: Dan Carpenter +Link: https://lore.kernel.org/r/361bbf2a4b091e120006279ec3b382d73c4a0c17.1715247018.git.duoming@zju.edu.cn +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ax25/ax25_dev.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c +index f16ee5c09d07a..52ccc37d5687a 100644 +--- a/net/ax25/ax25_dev.c ++++ b/net/ax25/ax25_dev.c +@@ -39,6 +39,7 @@ ax25_dev *ax25_addr_ax25dev(ax25_address *addr) + if (ax25cmp(addr, (const ax25_address *)ax25_dev->dev->dev_addr) == 0) { + res = ax25_dev; + ax25_dev_hold(ax25_dev); ++ break; + } + spin_unlock_bh(&ax25_dev_lock); + +@@ -88,7 +89,6 @@ void ax25_dev_device_up(struct net_device *dev) + list_add(&ax25_dev->list, &ax25_dev_list); + dev->ax25_ptr = ax25_dev; + spin_unlock_bh(&ax25_dev_lock); +- ax25_dev_hold(ax25_dev); + + ax25_register_dev_sysctl(ax25_dev); + } +@@ -129,7 +129,6 @@ void ax25_dev_device_down(struct net_device *dev) + unlock_put: + dev->ax25_ptr = NULL; + spin_unlock_bh(&ax25_dev_lock); +- ax25_dev_put(ax25_dev); + netdev_put(dev, &ax25_dev->dev_tracker); + ax25_dev_put(ax25_dev); + } +-- +2.43.0 + diff --git a/queue-6.8/ax25-use-kernel-universal-linked-list-to-implement-a.patch b/queue-6.8/ax25-use-kernel-universal-linked-list-to-implement-a.patch new file mode 100644 index 00000000000..ae4a3a04106 --- /dev/null +++ b/queue-6.8/ax25-use-kernel-universal-linked-list-to-implement-a.patch @@ -0,0 +1,163 @@ +From 06169debcb4fb1df01a171e4cd0f29aaf4393c43 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 17:36:33 +0800 +Subject: ax25: Use kernel universal linked list to implement ax25_dev_list + +From: Duoming Zhou + +[ Upstream commit a7d6e36b9ad052926ba2ecba3a59d8bb67dabcb4 ] + +The origin ax25_dev_list implements its own single linked list, +which is complicated and error-prone. For example, when deleting +the node of ax25_dev_list in ax25_dev_device_down(), we have to +operate on the head node and other nodes separately. + +This patch uses kernel universal linked list to replace original +ax25_dev_list, which make the operation of ax25_dev_list easier. + +We should do "dev->ax25_ptr = ax25_dev;" and "dev->ax25_ptr = NULL;" +while holding the spinlock, otherwise the ax25_dev_device_up() and +ax25_dev_device_down() could race. + +Suggested-by: Dan Carpenter +Signed-off-by: Duoming Zhou +Reviewed-by: Dan Carpenter +Link: https://lore.kernel.org/r/85bba3af651ca0e1a519da8d0d715b949891171c.1715247018.git.duoming@zju.edu.cn +Signed-off-by: Jakub Kicinski +Stable-dep-of: b505e0319852 ("ax25: Fix reference count leak issues of ax25_dev") +Signed-off-by: Sasha Levin +--- + include/net/ax25.h | 3 +-- + net/ax25/ax25_dev.c | 40 +++++++++++++++------------------------- + 2 files changed, 16 insertions(+), 27 deletions(-) + +diff --git a/include/net/ax25.h b/include/net/ax25.h +index 0d939e5aee4ec..c2a85fd3f5ea4 100644 +--- a/include/net/ax25.h ++++ b/include/net/ax25.h +@@ -216,7 +216,7 @@ typedef struct { + struct ctl_table; + + typedef struct ax25_dev { +- struct ax25_dev *next; ++ struct list_head list; + + struct net_device *dev; + netdevice_tracker dev_tracker; +@@ -330,7 +330,6 @@ int ax25_addr_size(const ax25_digi *); + void ax25_digi_invert(const ax25_digi *, ax25_digi *); + + /* ax25_dev.c */ +-extern ax25_dev *ax25_dev_list; + extern spinlock_t ax25_dev_lock; + + #if IS_ENABLED(CONFIG_AX25) +diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c +index 282ec581c0720..f16ee5c09d07a 100644 +--- a/net/ax25/ax25_dev.c ++++ b/net/ax25/ax25_dev.c +@@ -22,11 +22,12 @@ + #include + #include + #include ++#include + #include + #include + #include + +-ax25_dev *ax25_dev_list; ++static LIST_HEAD(ax25_dev_list); + DEFINE_SPINLOCK(ax25_dev_lock); + + ax25_dev *ax25_addr_ax25dev(ax25_address *addr) +@@ -34,7 +35,7 @@ ax25_dev *ax25_addr_ax25dev(ax25_address *addr) + ax25_dev *ax25_dev, *res = NULL; + + spin_lock_bh(&ax25_dev_lock); +- for (ax25_dev = ax25_dev_list; ax25_dev != NULL; ax25_dev = ax25_dev->next) ++ list_for_each_entry(ax25_dev, &ax25_dev_list, list) + if (ax25cmp(addr, (const ax25_address *)ax25_dev->dev->dev_addr) == 0) { + res = ax25_dev; + ax25_dev_hold(ax25_dev); +@@ -59,7 +60,6 @@ void ax25_dev_device_up(struct net_device *dev) + } + + refcount_set(&ax25_dev->refcount, 1); +- dev->ax25_ptr = ax25_dev; + ax25_dev->dev = dev; + netdev_hold(dev, &ax25_dev->dev_tracker, GFP_KERNEL); + ax25_dev->forward = NULL; +@@ -85,8 +85,8 @@ void ax25_dev_device_up(struct net_device *dev) + #endif + + spin_lock_bh(&ax25_dev_lock); +- ax25_dev->next = ax25_dev_list; +- ax25_dev_list = ax25_dev; ++ list_add(&ax25_dev->list, &ax25_dev_list); ++ dev->ax25_ptr = ax25_dev; + spin_unlock_bh(&ax25_dev_lock); + ax25_dev_hold(ax25_dev); + +@@ -111,32 +111,25 @@ void ax25_dev_device_down(struct net_device *dev) + /* + * Remove any packet forwarding that points to this device. + */ +- for (s = ax25_dev_list; s != NULL; s = s->next) ++ list_for_each_entry(s, &ax25_dev_list, list) + if (s->forward == dev) + s->forward = NULL; + +- if ((s = ax25_dev_list) == ax25_dev) { +- ax25_dev_list = s->next; +- goto unlock_put; +- } +- +- while (s != NULL && s->next != NULL) { +- if (s->next == ax25_dev) { +- s->next = ax25_dev->next; ++ list_for_each_entry(s, &ax25_dev_list, list) { ++ if (s == ax25_dev) { ++ list_del(&s->list); + goto unlock_put; + } +- +- s = s->next; + } +- spin_unlock_bh(&ax25_dev_lock); + dev->ax25_ptr = NULL; ++ spin_unlock_bh(&ax25_dev_lock); + ax25_dev_put(ax25_dev); + return; + + unlock_put: ++ dev->ax25_ptr = NULL; + spin_unlock_bh(&ax25_dev_lock); + ax25_dev_put(ax25_dev); +- dev->ax25_ptr = NULL; + netdev_put(dev, &ax25_dev->dev_tracker); + ax25_dev_put(ax25_dev); + } +@@ -200,16 +193,13 @@ struct net_device *ax25_fwd_dev(struct net_device *dev) + */ + void __exit ax25_dev_free(void) + { +- ax25_dev *s, *ax25_dev; ++ ax25_dev *s, *n; + + spin_lock_bh(&ax25_dev_lock); +- ax25_dev = ax25_dev_list; +- while (ax25_dev != NULL) { +- s = ax25_dev; +- netdev_put(ax25_dev->dev, &ax25_dev->dev_tracker); +- ax25_dev = ax25_dev->next; ++ list_for_each_entry_safe(s, n, &ax25_dev_list, list) { ++ netdev_put(s->dev, &s->dev_tracker); ++ list_del(&s->list); + kfree(s); + } +- ax25_dev_list = NULL; + spin_unlock_bh(&ax25_dev_lock); + } +-- +2.43.0 + diff --git a/queue-6.8/bitops-add-missing-prototype-check.patch b/queue-6.8/bitops-add-missing-prototype-check.patch new file mode 100644 index 00000000000..7c5a15a52f7 --- /dev/null +++ b/queue-6.8/bitops-add-missing-prototype-check.patch @@ -0,0 +1,40 @@ +From 9e808869cfd5c10e96d221562bee3ab712402d35 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 16:23:41 +0100 +Subject: bitops: add missing prototype check + +From: Alexander Lobakin + +[ Upstream commit 72cc1980a0ef3ccad0d539e7dace63d0d7d432a4 ] + +Commit 8238b4579866 ("wait_on_bit: add an acquire memory barrier") added +a new bitop, test_bit_acquire(), with proper wrapping in order to try to +optimize it at compile-time, but missed the list of bitops used for +checking their prototypes a bit below. +The functions added have consistent prototypes, so that no more changes +are required and no functional changes take place. + +Fixes: 8238b4579866 ("wait_on_bit: add an acquire memory barrier") +Reviewed-by: Przemek Kitszel +Signed-off-by: Alexander Lobakin +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/linux/bitops.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/include/linux/bitops.h b/include/linux/bitops.h +index 2ba557e067fe6..f7f5a783da2aa 100644 +--- a/include/linux/bitops.h ++++ b/include/linux/bitops.h +@@ -80,6 +80,7 @@ __check_bitop_pr(__test_and_set_bit); + __check_bitop_pr(__test_and_clear_bit); + __check_bitop_pr(__test_and_change_bit); + __check_bitop_pr(test_bit); ++__check_bitop_pr(test_bit_acquire); + + #undef __check_bitop_pr + +-- +2.43.0 + diff --git a/queue-6.8/block-fix-and-simplify-blkdevparts-cmdline-parsing.patch b/queue-6.8/block-fix-and-simplify-blkdevparts-cmdline-parsing.patch new file mode 100644 index 00000000000..abb68012ce5 --- /dev/null +++ b/queue-6.8/block-fix-and-simplify-blkdevparts-cmdline-parsing.patch @@ -0,0 +1,208 @@ +From 2dff7709610c917b99d2c37942bbb0076b3717af Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 21 Apr 2024 16:39:52 +0900 +Subject: block: fix and simplify blkdevparts= cmdline parsing + +From: INAGAKI Hiroshi + +[ Upstream commit bc2e07dfd2c49aaa4b52302cf7b55cf94e025f79 ] + +Fix the cmdline parsing of the "blkdevparts=" parameter using strsep(), +which makes the code simpler. + +Before commit 146afeb235cc ("block: use strscpy() to instead of +strncpy()"), we used a strncpy() to copy a block device name and partition +names. The commit simply replaced a strncpy() and NULL termination with +a strscpy(). It did not update calculations of length passed to strscpy(). +While the length passed to strncpy() is just a length of valid characters +without NULL termination ('\0'), strscpy() takes it as a length of the +destination buffer, including a NULL termination. + +Since the source buffer is not necessarily NULL terminated, the current +code copies "length - 1" characters and puts a NULL character in the +destination buffer. It replaces the last character with NULL and breaks +the parsing. + +As an example, that buffer will be passed to parse_parts() and breaks +parsing sub-partitions due to the missing ')' at the end, like the +following. + +example (Check Point V-80 & OpenWrt): + +- Linux Kernel 6.6 + + [ 0.000000] Kernel command line: console=ttyS0,115200 earlycon=uart8250,mmio32,0xf0512000 crashkernel=30M mvpp2x.queue_mode=1 blkdevparts=mmcblk1:48M@10M(kernel-1),1M(dtb-1),720M(rootfs-1),48M(kernel-2),1M(dtb-2),720M(rootfs-2),300M(default_sw),650M(logs),1M(preset_cfg),1M(adsl),-(storage) maxcpus=4 + ... + [ 0.884016] mmc1: new HS200 MMC card at address 0001 + [ 0.889951] mmcblk1: mmc1:0001 004GA0 3.69 GiB + [ 0.895043] cmdline partition format is invalid. + [ 0.895704] mmcblk1: p1 + [ 0.903447] mmcblk1boot0: mmc1:0001 004GA0 2.00 MiB + [ 0.908667] mmcblk1boot1: mmc1:0001 004GA0 2.00 MiB + [ 0.913765] mmcblk1rpmb: mmc1:0001 004GA0 512 KiB, chardev (248:0) + + 1. "48M@10M(kernel-1),..." is passed to strscpy() with length=17 + from parse_parts() + 2. strscpy() returns -E2BIG and the destination buffer has + "48M@10M(kernel-1\0" + 3. "48M@10M(kernel-1\0" is passed to parse_subpart() + 4. parse_subpart() fails to find ')' when parsing a partition name, + and returns error + +- Linux Kernel 6.1 + + [ 0.000000] Kernel command line: console=ttyS0,115200 earlycon=uart8250,mmio32,0xf0512000 crashkernel=30M mvpp2x.queue_mode=1 blkdevparts=mmcblk1:48M@10M(kernel-1),1M(dtb-1),720M(rootfs-1),48M(kernel-2),1M(dtb-2),720M(rootfs-2),300M(default_sw),650M(logs),1M(preset_cfg),1M(adsl),-(storage) maxcpus=4 + ... + [ 0.953142] mmc1: new HS200 MMC card at address 0001 + [ 0.959114] mmcblk1: mmc1:0001 004GA0 3.69 GiB + [ 0.964259] mmcblk1: p1(kernel-1) p2(dtb-1) p3(rootfs-1) p4(kernel-2) p5(dtb-2) 6(rootfs-2) p7(default_sw) p8(logs) p9(preset_cfg) p10(adsl) p11(storage) + [ 0.979174] mmcblk1boot0: mmc1:0001 004GA0 2.00 MiB + [ 0.984674] mmcblk1boot1: mmc1:0001 004GA0 2.00 MiB + [ 0.989926] mmcblk1rpmb: mmc1:0001 004GA0 512 KiB, chardev (248:0 + +By the way, strscpy() takes a length of destination buffer and it is +often confusing when copying characters with a specified length. Using +strsep() helps to separate the string by the specified character. Then, +we can use strscpy() naturally with the size of the destination buffer. + +Separating the string on the fly is also useful to omit the redundant +string copy, reducing memory usage and improve the code readability. + +Fixes: 146afeb235cc ("block: use strscpy() to instead of strncpy()") +Suggested-by: Naohiro Aota +Signed-off-by: INAGAKI Hiroshi +Reviewed-by: Daniel Golle +Link: https://lore.kernel.org/r/20240421074005.565-1-musashino.open@gmail.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/partitions/cmdline.c | 49 ++++++++++---------------------------- + 1 file changed, 12 insertions(+), 37 deletions(-) + +diff --git a/block/partitions/cmdline.c b/block/partitions/cmdline.c +index c03bc105e5753..152c85df92b20 100644 +--- a/block/partitions/cmdline.c ++++ b/block/partitions/cmdline.c +@@ -70,8 +70,8 @@ static int parse_subpart(struct cmdline_subpart **subpart, char *partdef) + } + + if (*partdef == '(') { +- int length; +- char *next = strchr(++partdef, ')'); ++ partdef++; ++ char *next = strsep(&partdef, ")"); + + if (!next) { + pr_warn("cmdline partition format is invalid."); +@@ -79,11 +79,7 @@ static int parse_subpart(struct cmdline_subpart **subpart, char *partdef) + goto fail; + } + +- length = min_t(int, next - partdef, +- sizeof(new_subpart->name) - 1); +- strscpy(new_subpart->name, partdef, length); +- +- partdef = ++next; ++ strscpy(new_subpart->name, next, sizeof(new_subpart->name)); + } else + new_subpart->name[0] = '\0'; + +@@ -117,14 +113,12 @@ static void free_subpart(struct cmdline_parts *parts) + } + } + +-static int parse_parts(struct cmdline_parts **parts, const char *bdevdef) ++static int parse_parts(struct cmdline_parts **parts, char *bdevdef) + { + int ret = -EINVAL; + char *next; +- int length; + struct cmdline_subpart **next_subpart; + struct cmdline_parts *newparts; +- char buf[BDEVNAME_SIZE + 32 + 4]; + + *parts = NULL; + +@@ -132,28 +126,19 @@ static int parse_parts(struct cmdline_parts **parts, const char *bdevdef) + if (!newparts) + return -ENOMEM; + +- next = strchr(bdevdef, ':'); ++ next = strsep(&bdevdef, ":"); + if (!next) { + pr_warn("cmdline partition has no block device."); + goto fail; + } + +- length = min_t(int, next - bdevdef, sizeof(newparts->name) - 1); +- strscpy(newparts->name, bdevdef, length); ++ strscpy(newparts->name, next, sizeof(newparts->name)); + newparts->nr_subparts = 0; + + next_subpart = &newparts->subpart; + +- while (next && *(++next)) { +- bdevdef = next; +- next = strchr(bdevdef, ','); +- +- length = (!next) ? (sizeof(buf) - 1) : +- min_t(int, next - bdevdef, sizeof(buf) - 1); +- +- strscpy(buf, bdevdef, length); +- +- ret = parse_subpart(next_subpart, buf); ++ while ((next = strsep(&bdevdef, ","))) { ++ ret = parse_subpart(next_subpart, next); + if (ret) + goto fail; + +@@ -199,24 +184,17 @@ static int cmdline_parts_parse(struct cmdline_parts **parts, + + *parts = NULL; + +- next = pbuf = buf = kstrdup(cmdline, GFP_KERNEL); ++ pbuf = buf = kstrdup(cmdline, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + next_parts = parts; + +- while (next && *pbuf) { +- next = strchr(pbuf, ';'); +- if (next) +- *next = '\0'; +- +- ret = parse_parts(next_parts, pbuf); ++ while ((next = strsep(&pbuf, ";"))) { ++ ret = parse_parts(next_parts, next); + if (ret) + goto fail; + +- if (next) +- pbuf = ++next; +- + next_parts = &(*next_parts)->next_parts; + } + +@@ -250,7 +228,6 @@ static struct cmdline_parts *bdev_parts; + static int add_part(int slot, struct cmdline_subpart *subpart, + struct parsed_partitions *state) + { +- int label_min; + struct partition_meta_info *info; + char tmp[sizeof(info->volname) + 4]; + +@@ -262,9 +239,7 @@ static int add_part(int slot, struct cmdline_subpart *subpart, + + info = &state->parts[slot].info; + +- label_min = min_t(int, sizeof(info->volname) - 1, +- sizeof(subpart->name)); +- strscpy(info->volname, subpart->name, label_min); ++ strscpy(info->volname, subpart->name, sizeof(info->volname)); + + snprintf(tmp, sizeof(tmp), "(%s)", info->volname); + strlcat(state->pp_buf, tmp, PAGE_SIZE); +-- +2.43.0 + diff --git a/queue-6.8/block-refine-the-eof-check-in-blkdev_iomap_begin.patch b/queue-6.8/block-refine-the-eof-check-in-blkdev_iomap_begin.patch new file mode 100644 index 00000000000..9d290c42143 --- /dev/null +++ b/queue-6.8/block-refine-the-eof-check-in-blkdev_iomap_begin.patch @@ -0,0 +1,43 @@ +From 3427a534dd6828f07e22a444279e1be0593de925 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 3 May 2024 10:10:42 +0200 +Subject: block: refine the EOF check in blkdev_iomap_begin + +From: Christoph Hellwig + +[ Upstream commit 0c12028aec837f5a002009bbf68d179d506510e8 ] + +blkdev_iomap_begin rounds down the offset to the logical block size +before stashing it in iomap->offset and checking that it still is +inside the inode size. + +Check the i_size check to the raw pos value so that we don't try a +zero size write if iter->pos is unaligned. + +Fixes: 487c607df790 ("block: use iomap for writes to block devices") +Reported-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com +Signed-off-by: Christoph Hellwig +Tested-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com +Link: https://lore.kernel.org/r/20240503081042.2078062-1-hch@lst.de +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/fops.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/block/fops.c b/block/fops.c +index 0cf8cf72cdfa1..799821040601a 100644 +--- a/block/fops.c ++++ b/block/fops.c +@@ -387,7 +387,7 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, + + iomap->bdev = bdev; + iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev)); +- if (iomap->offset >= isize) ++ if (offset >= isize) + return -EIO; + iomap->type = IOMAP_MAPPED; + iomap->addr = iomap->offset; +-- +2.43.0 + diff --git a/queue-6.8/block-support-to-account-io_ticks-precisely.patch b/queue-6.8/block-support-to-account-io_ticks-precisely.patch new file mode 100644 index 00000000000..9c14b1b1007 --- /dev/null +++ b/queue-6.8/block-support-to-account-io_ticks-precisely.patch @@ -0,0 +1,152 @@ +From 06c8a0af336b99a53e5c9c687c0d13ff927599ce Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 20:37:16 +0800 +Subject: block: support to account io_ticks precisely + +From: Yu Kuai + +[ Upstream commit 99dc422335d8b2bd4d105797241d3e715bae90e9 ] + +Currently, io_ticks is accounted based on sampling, specifically +update_io_ticks() will always account io_ticks by 1 jiffies from +bdev_start_io_acct()/blk_account_io_start(), and the result can be +inaccurate, for example(HZ is 250): + +Test script: +fio -filename=/dev/sda -bs=4k -rw=write -direct=1 -name=test -thinktime=4ms + +Test result: util is about 90%, while the disk is really idle. + +This behaviour is introduced by commit 5b18b5a73760 ("block: delete +part_round_stats and switch to less precise counting"), however, there +was a key point that is missed that this patch also improve performance +a lot: + +Before the commit: +part_round_stats: + if (part->stamp != now) + stats |= 1; + + part_in_flight() + -> there can be lots of task here in 1 jiffies. + part_round_stats_single() + __part_stat_add() + part->stamp = now; + +After the commit: +update_io_ticks: + stamp = part->bd_stamp; + if (time_after(now, stamp)) + if (try_cmpxchg()) + __part_stat_add() + -> only one task can reach here in 1 jiffies. + +Hence in order to account io_ticks precisely, we only need to know if +there are IO inflight at most once in one jiffies. Noted that for +rq-based device, iterating tags should not be used here because +'tags->lock' is grabbed in blk_mq_find_and_get_req(), hence +part_stat_lock_inc/dec() and part_in_flight() is used to trace inflight. +The additional overhead is quite little: + + - per cpu add/dec for each IO for rq-based device; + - per cpu sum for each jiffies; + +And it's verified by null-blk that there are no performance degration +under heavy IO pressure. + +Fixes: 5b18b5a73760 ("block: delete part_round_stats and switch to less precise counting") +Signed-off-by: Yu Kuai +Link: https://lore.kernel.org/r/20240509123717.3223892-2-yukuai1@huaweicloud.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + block/blk-core.c | 9 +++++---- + block/blk-merge.c | 2 ++ + block/blk-mq.c | 4 ++++ + block/blk.h | 1 + + block/genhd.c | 2 +- + 5 files changed, 13 insertions(+), 5 deletions(-) + +diff --git a/block/blk-core.c b/block/blk-core.c +index 99d684085719d..923b7d91e6dc5 100644 +--- a/block/blk-core.c ++++ b/block/blk-core.c +@@ -976,10 +976,11 @@ void update_io_ticks(struct block_device *part, unsigned long now, bool end) + unsigned long stamp; + again: + stamp = READ_ONCE(part->bd_stamp); +- if (unlikely(time_after(now, stamp))) { +- if (likely(try_cmpxchg(&part->bd_stamp, &stamp, now))) +- __part_stat_add(part, io_ticks, end ? now - stamp : 1); +- } ++ if (unlikely(time_after(now, stamp)) && ++ likely(try_cmpxchg(&part->bd_stamp, &stamp, now)) && ++ (end || part_in_flight(part))) ++ __part_stat_add(part, io_ticks, now - stamp); ++ + if (part->bd_partno) { + part = bdev_whole(part); + goto again; +diff --git a/block/blk-merge.c b/block/blk-merge.c +index 2d470cf2173e2..925c5eaac5815 100644 +--- a/block/blk-merge.c ++++ b/block/blk-merge.c +@@ -779,6 +779,8 @@ static void blk_account_io_merge_request(struct request *req) + if (blk_do_io_stat(req)) { + part_stat_lock(); + part_stat_inc(req->part, merges[op_stat_group(req_op(req))]); ++ part_stat_local_dec(req->part, ++ in_flight[op_is_write(req_op(req))]); + part_stat_unlock(); + } + } +diff --git a/block/blk-mq.c b/block/blk-mq.c +index 25d2f3239eb65..f1d071810893e 100644 +--- a/block/blk-mq.c ++++ b/block/blk-mq.c +@@ -998,6 +998,8 @@ static inline void blk_account_io_done(struct request *req, u64 now) + update_io_ticks(req->part, jiffies, true); + part_stat_inc(req->part, ios[sgrp]); + part_stat_add(req->part, nsecs[sgrp], now - req->start_time_ns); ++ part_stat_local_dec(req->part, ++ in_flight[op_is_write(req_op(req))]); + part_stat_unlock(); + } + } +@@ -1020,6 +1022,8 @@ static inline void blk_account_io_start(struct request *req) + + part_stat_lock(); + update_io_ticks(req->part, jiffies, false); ++ part_stat_local_inc(req->part, ++ in_flight[op_is_write(req_op(req))]); + part_stat_unlock(); + } + } +diff --git a/block/blk.h b/block/blk.h +index 1ef920f72e0f8..1154e87a4022d 100644 +--- a/block/blk.h ++++ b/block/blk.h +@@ -344,6 +344,7 @@ static inline bool blk_do_io_stat(struct request *rq) + } + + void update_io_ticks(struct block_device *part, unsigned long now, bool end); ++unsigned int part_in_flight(struct block_device *part); + + static inline void req_set_nomerge(struct request_queue *q, struct request *req) + { +diff --git a/block/genhd.c b/block/genhd.c +index d0471f469f7d0..2e4c2521584a1 100644 +--- a/block/genhd.c ++++ b/block/genhd.c +@@ -118,7 +118,7 @@ static void part_stat_read_all(struct block_device *part, + } + } + +-static unsigned int part_in_flight(struct block_device *part) ++unsigned int part_in_flight(struct block_device *part) + { + unsigned int inflight = 0; + int cpu; +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-compute-le-flow-credits-based-on-recvbuf-s.patch b/queue-6.8/bluetooth-compute-le-flow-credits-based-on-recvbuf-s.patch new file mode 100644 index 00000000000..435d49ac16a --- /dev/null +++ b/queue-6.8/bluetooth-compute-le-flow-credits-based-on-recvbuf-s.patch @@ -0,0 +1,388 @@ +From baf6ac1c9f7e6f2ad29672587c80e3d201fabe73 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 1 May 2024 12:08:58 +0200 +Subject: Bluetooth: compute LE flow credits based on recvbuf space + +From: Sebastian Urban + +[ Upstream commit ce60b9231b66710b6ee24042ded26efee120ecfc ] + +Previously LE flow credits were returned to the +sender even if the socket's receive buffer was +full. This meant that no back-pressure +was applied to the sender, thus it continued to +send data, resulting in data loss without any +error being reported. Furthermore, the amount +of credits was essentially fixed to a small +amount, leading to reduced performance. + +This is fixed by computing the number of returned +LE flow credits based on the estimated available +space in the receive buffer of an L2CAP socket. +Consequently, if the receive buffer is full, no +credits are returned until the buffer is read and +thus cleared by user-space. + +Since the computation of available receive buffer +space can only be performed approximately (due to +sk_buff overhead) and the receive buffer size may +be changed by user-space after flow credits have +been sent, superfluous received data is temporary +stored within l2cap_pinfo. This is necessary +because Bluetooth LE provides no retransmission +mechanism once the data has been acked by the +physical layer. + +If receive buffer space estimation is not possible +at the moment, we fall back to providing credits +for one full packet as before. This is currently +the case during connection setup, when MPS is not +yet available. + +Fixes: b1c325c23d75 ("Bluetooth: Implement returning of LE L2CAP credits") +Signed-off-by: Sebastian Urban +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/l2cap.h | 11 ++++- + net/bluetooth/l2cap_core.c | 56 ++++++++++++++++++--- + net/bluetooth/l2cap_sock.c | 91 ++++++++++++++++++++++++++++------- + 3 files changed, 132 insertions(+), 26 deletions(-) + +diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h +index a4278aa618ab1..3434cfc26b6af 100644 +--- a/include/net/bluetooth/l2cap.h ++++ b/include/net/bluetooth/l2cap.h +@@ -548,6 +548,9 @@ struct l2cap_chan { + __u16 tx_credits; + __u16 rx_credits; + ++ /* estimated available receive buffer space or -1 if unknown */ ++ ssize_t rx_avail; ++ + __u8 tx_state; + __u8 rx_state; + +@@ -682,10 +685,15 @@ struct l2cap_user { + /* ----- L2CAP socket info ----- */ + #define l2cap_pi(sk) ((struct l2cap_pinfo *) sk) + ++struct l2cap_rx_busy { ++ struct list_head list; ++ struct sk_buff *skb; ++}; ++ + struct l2cap_pinfo { + struct bt_sock bt; + struct l2cap_chan *chan; +- struct sk_buff *rx_busy_skb; ++ struct list_head rx_busy; + }; + + enum { +@@ -943,6 +951,7 @@ int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, + int l2cap_chan_reconfigure(struct l2cap_chan *chan, __u16 mtu); + int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len); + void l2cap_chan_busy(struct l2cap_chan *chan, int busy); ++void l2cap_chan_rx_avail(struct l2cap_chan *chan, ssize_t rx_avail); + int l2cap_chan_check_security(struct l2cap_chan *chan, bool initiator); + void l2cap_chan_set_defaults(struct l2cap_chan *chan); + int l2cap_ertm_init(struct l2cap_chan *chan); +diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c +index 3f7a82f10fe98..44454115c10ad 100644 +--- a/net/bluetooth/l2cap_core.c ++++ b/net/bluetooth/l2cap_core.c +@@ -457,6 +457,9 @@ struct l2cap_chan *l2cap_chan_create(void) + /* Set default lock nesting level */ + atomic_set(&chan->nesting, L2CAP_NESTING_NORMAL); + ++ /* Available receive buffer space is initially unknown */ ++ chan->rx_avail = -1; ++ + write_lock(&chan_list_lock); + list_add(&chan->global_l, &chan_list); + write_unlock(&chan_list_lock); +@@ -538,6 +541,28 @@ void l2cap_chan_set_defaults(struct l2cap_chan *chan) + } + EXPORT_SYMBOL_GPL(l2cap_chan_set_defaults); + ++static __u16 l2cap_le_rx_credits(struct l2cap_chan *chan) ++{ ++ size_t sdu_len = chan->sdu ? chan->sdu->len : 0; ++ ++ if (chan->mps == 0) ++ return 0; ++ ++ /* If we don't know the available space in the receiver buffer, give ++ * enough credits for a full packet. ++ */ ++ if (chan->rx_avail == -1) ++ return (chan->imtu / chan->mps) + 1; ++ ++ /* If we know how much space is available in the receive buffer, give ++ * out as many credits as would fill the buffer. ++ */ ++ if (chan->rx_avail <= sdu_len) ++ return 0; ++ ++ return DIV_ROUND_UP(chan->rx_avail - sdu_len, chan->mps); ++} ++ + static void l2cap_le_flowctl_init(struct l2cap_chan *chan, u16 tx_credits) + { + chan->sdu = NULL; +@@ -546,8 +571,7 @@ static void l2cap_le_flowctl_init(struct l2cap_chan *chan, u16 tx_credits) + chan->tx_credits = tx_credits; + /* Derive MPS from connection MTU to stop HCI fragmentation */ + chan->mps = min_t(u16, chan->imtu, chan->conn->mtu - L2CAP_HDR_SIZE); +- /* Give enough credits for a full packet */ +- chan->rx_credits = (chan->imtu / chan->mps) + 1; ++ chan->rx_credits = l2cap_le_rx_credits(chan); + + skb_queue_head_init(&chan->tx_q); + } +@@ -559,7 +583,7 @@ static void l2cap_ecred_init(struct l2cap_chan *chan, u16 tx_credits) + /* L2CAP implementations shall support a minimum MPS of 64 octets */ + if (chan->mps < L2CAP_ECRED_MIN_MPS) { + chan->mps = L2CAP_ECRED_MIN_MPS; +- chan->rx_credits = (chan->imtu / chan->mps) + 1; ++ chan->rx_credits = l2cap_le_rx_credits(chan); + } + } + +@@ -6513,9 +6537,7 @@ static void l2cap_chan_le_send_credits(struct l2cap_chan *chan) + { + struct l2cap_conn *conn = chan->conn; + struct l2cap_le_credits pkt; +- u16 return_credits; +- +- return_credits = (chan->imtu / chan->mps) + 1; ++ u16 return_credits = l2cap_le_rx_credits(chan); + + if (chan->rx_credits >= return_credits) + return; +@@ -6534,6 +6556,19 @@ static void l2cap_chan_le_send_credits(struct l2cap_chan *chan) + l2cap_send_cmd(conn, chan->ident, L2CAP_LE_CREDITS, sizeof(pkt), &pkt); + } + ++void l2cap_chan_rx_avail(struct l2cap_chan *chan, ssize_t rx_avail) ++{ ++ if (chan->rx_avail == rx_avail) ++ return; ++ ++ BT_DBG("chan %p has %zd bytes avail for rx", chan, rx_avail); ++ ++ chan->rx_avail = rx_avail; ++ ++ if (chan->state == BT_CONNECTED) ++ l2cap_chan_le_send_credits(chan); ++} ++ + static int l2cap_ecred_recv(struct l2cap_chan *chan, struct sk_buff *skb) + { + int err; +@@ -6543,6 +6578,12 @@ static int l2cap_ecred_recv(struct l2cap_chan *chan, struct sk_buff *skb) + /* Wait recv to confirm reception before updating the credits */ + err = chan->ops->recv(chan, skb); + ++ if (err < 0 && chan->rx_avail != -1) { ++ BT_ERR("Queueing received LE L2CAP data failed"); ++ l2cap_send_disconn_req(chan, ECONNRESET); ++ return err; ++ } ++ + /* Update credits whenever an SDU is received */ + l2cap_chan_le_send_credits(chan); + +@@ -6565,7 +6606,8 @@ static int l2cap_ecred_data_rcv(struct l2cap_chan *chan, struct sk_buff *skb) + } + + chan->rx_credits--; +- BT_DBG("rx_credits %u -> %u", chan->rx_credits + 1, chan->rx_credits); ++ BT_DBG("chan %p: rx_credits %u -> %u", ++ chan, chan->rx_credits + 1, chan->rx_credits); + + /* Update if remote had run out of credits, this should only happens + * if the remote is not using the entire MPS. +diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c +index 5cc83f906c123..8645461d45e81 100644 +--- a/net/bluetooth/l2cap_sock.c ++++ b/net/bluetooth/l2cap_sock.c +@@ -1131,6 +1131,34 @@ static int l2cap_sock_sendmsg(struct socket *sock, struct msghdr *msg, + return err; + } + ++static void l2cap_publish_rx_avail(struct l2cap_chan *chan) ++{ ++ struct sock *sk = chan->data; ++ ssize_t avail = sk->sk_rcvbuf - atomic_read(&sk->sk_rmem_alloc); ++ int expected_skbs, skb_overhead; ++ ++ if (avail <= 0) { ++ l2cap_chan_rx_avail(chan, 0); ++ return; ++ } ++ ++ if (!chan->mps) { ++ l2cap_chan_rx_avail(chan, -1); ++ return; ++ } ++ ++ /* Correct available memory by estimated sk_buff overhead. ++ * This is significant due to small transfer sizes. However, accept ++ * at least one full packet if receive space is non-zero. ++ */ ++ expected_skbs = DIV_ROUND_UP(avail, chan->mps); ++ skb_overhead = expected_skbs * sizeof(struct sk_buff); ++ if (skb_overhead < avail) ++ l2cap_chan_rx_avail(chan, avail - skb_overhead); ++ else ++ l2cap_chan_rx_avail(chan, -1); ++} ++ + static int l2cap_sock_recvmsg(struct socket *sock, struct msghdr *msg, + size_t len, int flags) + { +@@ -1167,28 +1195,33 @@ static int l2cap_sock_recvmsg(struct socket *sock, struct msghdr *msg, + else + err = bt_sock_recvmsg(sock, msg, len, flags); + +- if (pi->chan->mode != L2CAP_MODE_ERTM) ++ if (pi->chan->mode != L2CAP_MODE_ERTM && ++ pi->chan->mode != L2CAP_MODE_LE_FLOWCTL && ++ pi->chan->mode != L2CAP_MODE_EXT_FLOWCTL) + return err; + +- /* Attempt to put pending rx data in the socket buffer */ +- + lock_sock(sk); + +- if (!test_bit(CONN_LOCAL_BUSY, &pi->chan->conn_state)) +- goto done; ++ l2cap_publish_rx_avail(pi->chan); + +- if (pi->rx_busy_skb) { +- if (!__sock_queue_rcv_skb(sk, pi->rx_busy_skb)) +- pi->rx_busy_skb = NULL; +- else ++ /* Attempt to put pending rx data in the socket buffer */ ++ while (!list_empty(&pi->rx_busy)) { ++ struct l2cap_rx_busy *rx_busy = ++ list_first_entry(&pi->rx_busy, ++ struct l2cap_rx_busy, ++ list); ++ if (__sock_queue_rcv_skb(sk, rx_busy->skb) < 0) + goto done; ++ list_del(&rx_busy->list); ++ kfree(rx_busy); + } + + /* Restore data flow when half of the receive buffer is + * available. This avoids resending large numbers of + * frames. + */ +- if (atomic_read(&sk->sk_rmem_alloc) <= sk->sk_rcvbuf >> 1) ++ if (test_bit(CONN_LOCAL_BUSY, &pi->chan->conn_state) && ++ atomic_read(&sk->sk_rmem_alloc) <= sk->sk_rcvbuf >> 1) + l2cap_chan_busy(pi->chan, 0); + + done: +@@ -1449,17 +1482,20 @@ static struct l2cap_chan *l2cap_sock_new_connection_cb(struct l2cap_chan *chan) + static int l2cap_sock_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) + { + struct sock *sk = chan->data; ++ struct l2cap_pinfo *pi = l2cap_pi(sk); + int err; + + lock_sock(sk); + +- if (l2cap_pi(sk)->rx_busy_skb) { ++ if (chan->mode == L2CAP_MODE_ERTM && !list_empty(&pi->rx_busy)) { + err = -ENOMEM; + goto done; + } + + if (chan->mode != L2CAP_MODE_ERTM && +- chan->mode != L2CAP_MODE_STREAMING) { ++ chan->mode != L2CAP_MODE_STREAMING && ++ chan->mode != L2CAP_MODE_LE_FLOWCTL && ++ chan->mode != L2CAP_MODE_EXT_FLOWCTL) { + /* Even if no filter is attached, we could potentially + * get errors from security modules, etc. + */ +@@ -1470,7 +1506,9 @@ static int l2cap_sock_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) + + err = __sock_queue_rcv_skb(sk, skb); + +- /* For ERTM, handle one skb that doesn't fit into the recv ++ l2cap_publish_rx_avail(chan); ++ ++ /* For ERTM and LE, handle a skb that doesn't fit into the recv + * buffer. This is important to do because the data frames + * have already been acked, so the skb cannot be discarded. + * +@@ -1479,8 +1517,18 @@ static int l2cap_sock_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) + * acked and reassembled until there is buffer space + * available. + */ +- if (err < 0 && chan->mode == L2CAP_MODE_ERTM) { +- l2cap_pi(sk)->rx_busy_skb = skb; ++ if (err < 0 && ++ (chan->mode == L2CAP_MODE_ERTM || ++ chan->mode == L2CAP_MODE_LE_FLOWCTL || ++ chan->mode == L2CAP_MODE_EXT_FLOWCTL)) { ++ struct l2cap_rx_busy *rx_busy = ++ kmalloc(sizeof(*rx_busy), GFP_KERNEL); ++ if (!rx_busy) { ++ err = -ENOMEM; ++ goto done; ++ } ++ rx_busy->skb = skb; ++ list_add_tail(&rx_busy->list, &pi->rx_busy); + l2cap_chan_busy(chan, 1); + err = 0; + } +@@ -1706,6 +1754,8 @@ static const struct l2cap_ops l2cap_chan_ops = { + + static void l2cap_sock_destruct(struct sock *sk) + { ++ struct l2cap_rx_busy *rx_busy, *next; ++ + BT_DBG("sk %p", sk); + + if (l2cap_pi(sk)->chan) { +@@ -1713,9 +1763,10 @@ static void l2cap_sock_destruct(struct sock *sk) + l2cap_chan_put(l2cap_pi(sk)->chan); + } + +- if (l2cap_pi(sk)->rx_busy_skb) { +- kfree_skb(l2cap_pi(sk)->rx_busy_skb); +- l2cap_pi(sk)->rx_busy_skb = NULL; ++ list_for_each_entry_safe(rx_busy, next, &l2cap_pi(sk)->rx_busy, list) { ++ kfree_skb(rx_busy->skb); ++ list_del(&rx_busy->list); ++ kfree(rx_busy); + } + + skb_queue_purge(&sk->sk_receive_queue); +@@ -1799,6 +1850,8 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent) + + chan->data = sk; + chan->ops = &l2cap_chan_ops; ++ ++ l2cap_publish_rx_avail(chan); + } + + static struct proto l2cap_proto = { +@@ -1820,6 +1873,8 @@ static struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock, + sk->sk_destruct = l2cap_sock_destruct; + sk->sk_sndtimeo = L2CAP_CONN_TIMEOUT; + ++ INIT_LIST_HEAD(&l2cap_pi(sk)->rx_busy); ++ + chan = l2cap_chan_create(); + if (!chan) { + sk_free(sk); +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-hci-remove-hci_amp-support.patch b/queue-6.8/bluetooth-hci-remove-hci_amp-support.patch new file mode 100644 index 00000000000..072639c300f --- /dev/null +++ b/queue-6.8/bluetooth-hci-remove-hci_amp-support.patch @@ -0,0 +1,1398 @@ +From c0c9e5340420396e34d2e01f6f5fdbe309fbf053 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 18:33:52 -0400 +Subject: Bluetooth: HCI: Remove HCI_AMP support + +From: Luiz Augusto von Dentz + +[ Upstream commit 84a4bb6548a29326564f0e659fb8064503ecc1c7 ] + +Since BT_HS has been remove HCI_AMP controllers no longer has any use so +remove it along with the capability of creating AMP controllers. + +Since we no longer need to differentiate between AMP and Primary +controllers, as only HCI_PRIMARY is left, this also remove +hdev->dev_type altogether. + +Fixes: e7b02296fb40 ("Bluetooth: Remove BT_HS") +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Sasha Levin +--- + drivers/bluetooth/btmrvl_main.c | 9 -- + drivers/bluetooth/btrsi.c | 1 - + drivers/bluetooth/btsdio.c | 8 -- + drivers/bluetooth/btusb.c | 5 -- + drivers/bluetooth/hci_bcm4377.c | 1 - + drivers/bluetooth/hci_ldisc.c | 6 -- + drivers/bluetooth/hci_serdev.c | 5 -- + drivers/bluetooth/hci_uart.h | 1 - + drivers/bluetooth/hci_vhci.c | 10 +-- + drivers/bluetooth/virtio_bt.c | 2 - + include/net/bluetooth/hci.h | 114 ------------------------ + include/net/bluetooth/hci_core.h | 46 +--------- + include/uapi/linux/virtio_bt.h | 1 - + net/bluetooth/hci_conn.c | 3 +- + net/bluetooth/hci_core.c | 132 +++------------------------ + net/bluetooth/hci_event.c | 147 ------------------------------- + net/bluetooth/hci_sock.c | 5 +- + net/bluetooth/hci_sync.c | 112 +---------------------- + net/bluetooth/l2cap_core.c | 21 +---- + net/bluetooth/mgmt.c | 84 ++++++------------ + 20 files changed, 49 insertions(+), 664 deletions(-) + +diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c +index 9658b33c824a7..18f34998a1204 100644 +--- a/drivers/bluetooth/btmrvl_main.c ++++ b/drivers/bluetooth/btmrvl_main.c +@@ -121,13 +121,6 @@ int btmrvl_process_event(struct btmrvl_private *priv, struct sk_buff *skb) + ((event->data[2] == MODULE_BROUGHT_UP) || + (event->data[2] == MODULE_ALREADY_UP)) ? + "Bring-up succeed" : "Bring-up failed"); +- +- if (event->length > 3 && event->data[3]) +- priv->btmrvl_dev.dev_type = HCI_AMP; +- else +- priv->btmrvl_dev.dev_type = HCI_PRIMARY; +- +- BT_DBG("dev_type: %d", priv->btmrvl_dev.dev_type); + } else if (priv->btmrvl_dev.sendcmdflag && + event->data[1] == MODULE_SHUTDOWN_REQ) { + BT_DBG("EVENT:%s", (event->data[2]) ? +@@ -686,8 +679,6 @@ int btmrvl_register_hdev(struct btmrvl_private *priv) + hdev->wakeup = btmrvl_wakeup; + SET_HCIDEV_DEV(hdev, &card->func->dev); + +- hdev->dev_type = priv->btmrvl_dev.dev_type; +- + ret = hci_register_dev(hdev); + if (ret < 0) { + BT_ERR("Can not register HCI device"); +diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c +index 634cf8f5ed2db..0c91d7635ac39 100644 +--- a/drivers/bluetooth/btrsi.c ++++ b/drivers/bluetooth/btrsi.c +@@ -134,7 +134,6 @@ static int rsi_hci_attach(void *priv, struct rsi_proto_ops *ops) + hdev->bus = HCI_USB; + + hci_set_drvdata(hdev, h_adapter); +- hdev->dev_type = HCI_PRIMARY; + hdev->open = rsi_hci_open; + hdev->close = rsi_hci_close; + hdev->flush = rsi_hci_flush; +diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c +index f19d31ee37ea8..fdcfe9c50313e 100644 +--- a/drivers/bluetooth/btsdio.c ++++ b/drivers/bluetooth/btsdio.c +@@ -32,9 +32,6 @@ static const struct sdio_device_id btsdio_table[] = { + /* Generic Bluetooth Type-B SDIO device */ + { SDIO_DEVICE_CLASS(SDIO_CLASS_BT_B) }, + +- /* Generic Bluetooth AMP controller */ +- { SDIO_DEVICE_CLASS(SDIO_CLASS_BT_AMP) }, +- + { } /* Terminating entry */ + }; + +@@ -319,11 +316,6 @@ static int btsdio_probe(struct sdio_func *func, + hdev->bus = HCI_SDIO; + hci_set_drvdata(hdev, data); + +- if (id->class == SDIO_CLASS_BT_AMP) +- hdev->dev_type = HCI_AMP; +- else +- hdev->dev_type = HCI_PRIMARY; +- + data->hdev = hdev; + + SET_HCIDEV_DEV(hdev, &func->dev); +diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c +index effa546296486..a1b82abe06c5f 100644 +--- a/drivers/bluetooth/btusb.c ++++ b/drivers/bluetooth/btusb.c +@@ -4314,11 +4314,6 @@ static int btusb_probe(struct usb_interface *intf, + hdev->bus = HCI_USB; + hci_set_drvdata(hdev, data); + +- if (id->driver_info & BTUSB_AMP) +- hdev->dev_type = HCI_AMP; +- else +- hdev->dev_type = HCI_PRIMARY; +- + data->hdev = hdev; + + SET_HCIDEV_DEV(hdev, &intf->dev); +diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c +index 9a7243d5db71f..0c2f15235b4cd 100644 +--- a/drivers/bluetooth/hci_bcm4377.c ++++ b/drivers/bluetooth/hci_bcm4377.c +@@ -2361,7 +2361,6 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) + bcm4377->hdev = hdev; + + hdev->bus = HCI_PCI; +- hdev->dev_type = HCI_PRIMARY; + hdev->open = bcm4377_hci_open; + hdev->close = bcm4377_hci_close; + hdev->send = bcm4377_hci_send_frame; +diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c +index a26367e9fb197..17a2f158a0dfa 100644 +--- a/drivers/bluetooth/hci_ldisc.c ++++ b/drivers/bluetooth/hci_ldisc.c +@@ -667,11 +667,6 @@ static int hci_uart_register_dev(struct hci_uart *hu) + if (!test_bit(HCI_UART_RESET_ON_INIT, &hu->hdev_flags)) + set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks); + +- if (test_bit(HCI_UART_CREATE_AMP, &hu->hdev_flags)) +- hdev->dev_type = HCI_AMP; +- else +- hdev->dev_type = HCI_PRIMARY; +- + /* Only call open() for the protocol after hdev is fully initialized as + * open() (or a timer/workqueue it starts) may attempt to reference it. + */ +@@ -722,7 +717,6 @@ static int hci_uart_set_flags(struct hci_uart *hu, unsigned long flags) + { + unsigned long valid_flags = BIT(HCI_UART_RAW_DEVICE) | + BIT(HCI_UART_RESET_ON_INIT) | +- BIT(HCI_UART_CREATE_AMP) | + BIT(HCI_UART_INIT_PENDING) | + BIT(HCI_UART_EXT_CONFIG) | + BIT(HCI_UART_VND_DETECT); +diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c +index 214fff876eae5..0eaec878fa1d8 100644 +--- a/drivers/bluetooth/hci_serdev.c ++++ b/drivers/bluetooth/hci_serdev.c +@@ -366,11 +366,6 @@ int hci_uart_register_device_priv(struct hci_uart *hu, + if (test_bit(HCI_UART_EXT_CONFIG, &hu->hdev_flags)) + set_bit(HCI_QUIRK_EXTERNAL_CONFIG, &hdev->quirks); + +- if (test_bit(HCI_UART_CREATE_AMP, &hu->hdev_flags)) +- hdev->dev_type = HCI_AMP; +- else +- hdev->dev_type = HCI_PRIMARY; +- + if (test_bit(HCI_UART_INIT_PENDING, &hu->hdev_flags)) + return 0; + +diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h +index 68c8c7e95d64d..00bf7ae82c5b7 100644 +--- a/drivers/bluetooth/hci_uart.h ++++ b/drivers/bluetooth/hci_uart.h +@@ -37,7 +37,6 @@ + + #define HCI_UART_RAW_DEVICE 0 + #define HCI_UART_RESET_ON_INIT 1 +-#define HCI_UART_CREATE_AMP 2 + #define HCI_UART_INIT_PENDING 3 + #define HCI_UART_EXT_CONFIG 4 + #define HCI_UART_VND_DETECT 5 +diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c +index 572d68d52965f..28750a40f0ed5 100644 +--- a/drivers/bluetooth/hci_vhci.c ++++ b/drivers/bluetooth/hci_vhci.c +@@ -384,17 +384,10 @@ static int __vhci_create_device(struct vhci_data *data, __u8 opcode) + { + struct hci_dev *hdev; + struct sk_buff *skb; +- __u8 dev_type; + + if (data->hdev) + return -EBADFD; + +- /* bits 0-1 are dev_type (Primary or AMP) */ +- dev_type = opcode & 0x03; +- +- if (dev_type != HCI_PRIMARY && dev_type != HCI_AMP) +- return -EINVAL; +- + /* bits 2-5 are reserved (must be zero) */ + if (opcode & 0x3c) + return -EINVAL; +@@ -412,7 +405,6 @@ static int __vhci_create_device(struct vhci_data *data, __u8 opcode) + data->hdev = hdev; + + hdev->bus = HCI_VIRTUAL; +- hdev->dev_type = dev_type; + hci_set_drvdata(hdev, data); + + hdev->open = vhci_open_dev; +@@ -634,7 +626,7 @@ static void vhci_open_timeout(struct work_struct *work) + struct vhci_data *data = container_of(work, struct vhci_data, + open_timeout.work); + +- vhci_create_device(data, amp ? HCI_AMP : HCI_PRIMARY); ++ vhci_create_device(data, 0x00); + } + + static int vhci_open(struct inode *inode, struct file *file) +diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c +index 2ac70b560c46d..18208e152a367 100644 +--- a/drivers/bluetooth/virtio_bt.c ++++ b/drivers/bluetooth/virtio_bt.c +@@ -274,7 +274,6 @@ static int virtbt_probe(struct virtio_device *vdev) + + switch (type) { + case VIRTIO_BT_CONFIG_TYPE_PRIMARY: +- case VIRTIO_BT_CONFIG_TYPE_AMP: + break; + default: + return -EINVAL; +@@ -303,7 +302,6 @@ static int virtbt_probe(struct virtio_device *vdev) + vbt->hdev = hdev; + + hdev->bus = HCI_VIRTIO; +- hdev->dev_type = type; + hci_set_drvdata(hdev, vbt); + + hdev->open = virtbt_open; +diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h +index f9db2d1ca5d37..55f95a93c0d7c 100644 +--- a/include/net/bluetooth/hci.h ++++ b/include/net/bluetooth/hci.h +@@ -33,9 +33,6 @@ + #define HCI_MAX_FRAME_SIZE (HCI_MAX_ACL_SIZE + 4) + + #define HCI_LINK_KEY_SIZE 16 +-#define HCI_AMP_LINK_KEY_SIZE (2 * HCI_LINK_KEY_SIZE) +- +-#define HCI_MAX_AMP_ASSOC_SIZE 672 + + #define HCI_MAX_CPB_DATA_SIZE 252 + +@@ -71,26 +68,6 @@ + #define HCI_SMD 9 + #define HCI_VIRTIO 10 + +-/* HCI controller types */ +-#define HCI_PRIMARY 0x00 +-#define HCI_AMP 0x01 +- +-/* First BR/EDR Controller shall have ID = 0 */ +-#define AMP_ID_BREDR 0x00 +- +-/* AMP controller types */ +-#define AMP_TYPE_BREDR 0x00 +-#define AMP_TYPE_80211 0x01 +- +-/* AMP controller status */ +-#define AMP_STATUS_POWERED_DOWN 0x00 +-#define AMP_STATUS_BLUETOOTH_ONLY 0x01 +-#define AMP_STATUS_NO_CAPACITY 0x02 +-#define AMP_STATUS_LOW_CAPACITY 0x03 +-#define AMP_STATUS_MEDIUM_CAPACITY 0x04 +-#define AMP_STATUS_HIGH_CAPACITY 0x05 +-#define AMP_STATUS_FULL_CAPACITY 0x06 +- + /* HCI device quirks */ + enum { + /* When this quirk is set, the HCI Reset command is send when +@@ -527,7 +504,6 @@ enum { + #define ESCO_LINK 0x02 + /* Low Energy links do not have defined link type. Use invented one */ + #define LE_LINK 0x80 +-#define AMP_LINK 0x81 + #define ISO_LINK 0x82 + #define INVALID_LINK 0xff + +@@ -943,56 +919,6 @@ struct hci_cp_io_capability_neg_reply { + __u8 reason; + } __packed; + +-#define HCI_OP_CREATE_PHY_LINK 0x0435 +-struct hci_cp_create_phy_link { +- __u8 phy_handle; +- __u8 key_len; +- __u8 key_type; +- __u8 key[HCI_AMP_LINK_KEY_SIZE]; +-} __packed; +- +-#define HCI_OP_ACCEPT_PHY_LINK 0x0436 +-struct hci_cp_accept_phy_link { +- __u8 phy_handle; +- __u8 key_len; +- __u8 key_type; +- __u8 key[HCI_AMP_LINK_KEY_SIZE]; +-} __packed; +- +-#define HCI_OP_DISCONN_PHY_LINK 0x0437 +-struct hci_cp_disconn_phy_link { +- __u8 phy_handle; +- __u8 reason; +-} __packed; +- +-struct ext_flow_spec { +- __u8 id; +- __u8 stype; +- __le16 msdu; +- __le32 sdu_itime; +- __le32 acc_lat; +- __le32 flush_to; +-} __packed; +- +-#define HCI_OP_CREATE_LOGICAL_LINK 0x0438 +-#define HCI_OP_ACCEPT_LOGICAL_LINK 0x0439 +-struct hci_cp_create_accept_logical_link { +- __u8 phy_handle; +- struct ext_flow_spec tx_flow_spec; +- struct ext_flow_spec rx_flow_spec; +-} __packed; +- +-#define HCI_OP_DISCONN_LOGICAL_LINK 0x043a +-struct hci_cp_disconn_logical_link { +- __le16 log_handle; +-} __packed; +- +-#define HCI_OP_LOGICAL_LINK_CANCEL 0x043b +-struct hci_cp_logical_link_cancel { +- __u8 phy_handle; +- __u8 flow_spec_id; +-} __packed; +- + #define HCI_OP_ENHANCED_SETUP_SYNC_CONN 0x043d + struct hci_coding_format { + __u8 id; +@@ -1614,46 +1540,6 @@ struct hci_rp_read_enc_key_size { + __u8 key_size; + } __packed; + +-#define HCI_OP_READ_LOCAL_AMP_INFO 0x1409 +-struct hci_rp_read_local_amp_info { +- __u8 status; +- __u8 amp_status; +- __le32 total_bw; +- __le32 max_bw; +- __le32 min_latency; +- __le32 max_pdu; +- __u8 amp_type; +- __le16 pal_cap; +- __le16 max_assoc_size; +- __le32 max_flush_to; +- __le32 be_flush_to; +-} __packed; +- +-#define HCI_OP_READ_LOCAL_AMP_ASSOC 0x140a +-struct hci_cp_read_local_amp_assoc { +- __u8 phy_handle; +- __le16 len_so_far; +- __le16 max_len; +-} __packed; +-struct hci_rp_read_local_amp_assoc { +- __u8 status; +- __u8 phy_handle; +- __le16 rem_len; +- __u8 frag[]; +-} __packed; +- +-#define HCI_OP_WRITE_REMOTE_AMP_ASSOC 0x140b +-struct hci_cp_write_remote_amp_assoc { +- __u8 phy_handle; +- __le16 len_so_far; +- __le16 rem_len; +- __u8 frag[]; +-} __packed; +-struct hci_rp_write_remote_amp_assoc { +- __u8 status; +- __u8 phy_handle; +-} __packed; +- + #define HCI_OP_GET_MWS_TRANSPORT_CONFIG 0x140c + + #define HCI_OP_ENABLE_DUT_MODE 0x1803 +diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h +index b1c8489ff93e4..762b049bdabf1 100644 +--- a/include/net/bluetooth/hci_core.h ++++ b/include/net/bluetooth/hci_core.h +@@ -126,7 +126,6 @@ enum suspended_state { + struct hci_conn_hash { + struct list_head list; + unsigned int acl_num; +- unsigned int amp_num; + unsigned int sco_num; + unsigned int iso_num; + unsigned int le_num; +@@ -341,14 +340,6 @@ struct adv_monitor { + /* Default authenticated payload timeout 30s */ + #define DEFAULT_AUTH_PAYLOAD_TIMEOUT 0x0bb8 + +-struct amp_assoc { +- __u16 len; +- __u16 offset; +- __u16 rem_len; +- __u16 len_so_far; +- __u8 data[HCI_MAX_AMP_ASSOC_SIZE]; +-}; +- + #define HCI_MAX_PAGES 3 + + struct hci_dev { +@@ -361,7 +352,6 @@ struct hci_dev { + unsigned long flags; + __u16 id; + __u8 bus; +- __u8 dev_type; + bdaddr_t bdaddr; + bdaddr_t setup_addr; + bdaddr_t public_addr; +@@ -467,21 +457,6 @@ struct hci_dev { + __u16 sniff_min_interval; + __u16 sniff_max_interval; + +- __u8 amp_status; +- __u32 amp_total_bw; +- __u32 amp_max_bw; +- __u32 amp_min_latency; +- __u32 amp_max_pdu; +- __u8 amp_type; +- __u16 amp_pal_cap; +- __u16 amp_assoc_size; +- __u32 amp_max_flush_to; +- __u32 amp_be_flush_to; +- +- struct amp_assoc loc_assoc; +- +- __u8 flow_ctl_mode; +- + unsigned int auto_accept_delay; + + unsigned long quirks; +@@ -501,11 +476,6 @@ struct hci_dev { + unsigned int le_pkts; + unsigned int iso_pkts; + +- __u16 block_len; +- __u16 block_mtu; +- __u16 num_blocks; +- __u16 block_cnt; +- + unsigned long acl_last_tx; + unsigned long sco_last_tx; + unsigned long le_last_tx; +@@ -778,7 +748,6 @@ struct hci_conn { + void *l2cap_data; + void *sco_data; + void *iso_data; +- struct amp_mgr *amp_mgr; + + struct list_head link_list; + struct hci_conn *parent; +@@ -805,7 +774,6 @@ struct hci_chan { + struct sk_buff_head data_q; + unsigned int sent; + __u8 state; +- bool amp; + }; + + struct hci_conn_params { +@@ -1014,9 +982,6 @@ static inline void hci_conn_hash_add(struct hci_dev *hdev, struct hci_conn *c) + case ACL_LINK: + h->acl_num++; + break; +- case AMP_LINK: +- h->amp_num++; +- break; + case LE_LINK: + h->le_num++; + if (c->role == HCI_ROLE_SLAVE) +@@ -1043,9 +1008,6 @@ static inline void hci_conn_hash_del(struct hci_dev *hdev, struct hci_conn *c) + case ACL_LINK: + h->acl_num--; + break; +- case AMP_LINK: +- h->amp_num--; +- break; + case LE_LINK: + h->le_num--; + if (c->role == HCI_ROLE_SLAVE) +@@ -1067,8 +1029,6 @@ static inline unsigned int hci_conn_num(struct hci_dev *hdev, __u8 type) + switch (type) { + case ACL_LINK: + return h->acl_num; +- case AMP_LINK: +- return h->amp_num; + case LE_LINK: + return h->le_num; + case SCO_LINK: +@@ -1085,7 +1045,7 @@ static inline unsigned int hci_conn_count(struct hci_dev *hdev) + { + struct hci_conn_hash *c = &hdev->conn_hash; + +- return c->acl_num + c->amp_num + c->sco_num + c->le_num + c->iso_num; ++ return c->acl_num + c->sco_num + c->le_num + c->iso_num; + } + + static inline bool hci_conn_valid(struct hci_dev *hdev, struct hci_conn *conn) +@@ -1611,10 +1571,6 @@ static inline void hci_conn_drop(struct hci_conn *conn) + } + break; + +- case AMP_LINK: +- timeo = conn->disc_timeout; +- break; +- + default: + timeo = 0; + break; +diff --git a/include/uapi/linux/virtio_bt.h b/include/uapi/linux/virtio_bt.h +index af798f4c96804..3cc7d633456b6 100644 +--- a/include/uapi/linux/virtio_bt.h ++++ b/include/uapi/linux/virtio_bt.h +@@ -13,7 +13,6 @@ + + enum virtio_bt_config_type { + VIRTIO_BT_CONFIG_TYPE_PRIMARY = 0, +- VIRTIO_BT_CONFIG_TYPE_AMP = 1, + }; + + enum virtio_bt_config_vendor { +diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c +index 0a80fd6257c65..7f78fc6c29cf5 100644 +--- a/net/bluetooth/hci_conn.c ++++ b/net/bluetooth/hci_conn.c +@@ -1173,8 +1173,7 @@ struct hci_dev *hci_get_route(bdaddr_t *dst, bdaddr_t *src, uint8_t src_type) + + list_for_each_entry(d, &hci_dev_list, list) { + if (!test_bit(HCI_UP, &d->flags) || +- hci_dev_test_flag(d, HCI_USER_CHANNEL) || +- d->dev_type != HCI_PRIMARY) ++ hci_dev_test_flag(d, HCI_USER_CHANNEL)) + continue; + + /* Simple routing: +diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c +index 101ea9137dfef..3817d6369f0cc 100644 +--- a/net/bluetooth/hci_core.c ++++ b/net/bluetooth/hci_core.c +@@ -395,11 +395,6 @@ int hci_inquiry(void __user *arg) + goto done; + } + +- if (hdev->dev_type != HCI_PRIMARY) { +- err = -EOPNOTSUPP; +- goto done; +- } +- + if (!hci_dev_test_flag(hdev, HCI_BREDR_ENABLED)) { + err = -EOPNOTSUPP; + goto done; +@@ -752,11 +747,6 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg) + goto done; + } + +- if (hdev->dev_type != HCI_PRIMARY) { +- err = -EOPNOTSUPP; +- goto done; +- } +- + if (!hci_dev_test_flag(hdev, HCI_BREDR_ENABLED)) { + err = -EOPNOTSUPP; + goto done; +@@ -910,7 +900,7 @@ int hci_get_dev_info(void __user *arg) + + strscpy(di.name, hdev->name, sizeof(di.name)); + di.bdaddr = hdev->bdaddr; +- di.type = (hdev->bus & 0x0f) | ((hdev->dev_type & 0x03) << 4); ++ di.type = (hdev->bus & 0x0f); + di.flags = flags; + di.pkt_type = hdev->pkt_type; + if (lmp_bredr_capable(hdev)) { +@@ -995,8 +985,7 @@ static void hci_power_on(struct work_struct *work) + */ + if (hci_dev_test_flag(hdev, HCI_RFKILLED) || + hci_dev_test_flag(hdev, HCI_UNCONFIGURED) || +- (hdev->dev_type == HCI_PRIMARY && +- !bacmp(&hdev->bdaddr, BDADDR_ANY) && ++ (!bacmp(&hdev->bdaddr, BDADDR_ANY) && + !bacmp(&hdev->static_addr, BDADDR_ANY))) { + hci_dev_clear_flag(hdev, HCI_AUTO_OFF); + hci_dev_do_close(hdev); +@@ -2604,21 +2593,7 @@ int hci_register_dev(struct hci_dev *hdev) + if (!hdev->open || !hdev->close || !hdev->send) + return -EINVAL; + +- /* Do not allow HCI_AMP devices to register at index 0, +- * so the index can be used as the AMP controller ID. +- */ +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- id = ida_alloc_max(&hci_index_ida, HCI_MAX_ID - 1, GFP_KERNEL); +- break; +- case HCI_AMP: +- id = ida_alloc_range(&hci_index_ida, 1, HCI_MAX_ID - 1, +- GFP_KERNEL); +- break; +- default: +- return -EINVAL; +- } +- ++ id = ida_alloc_max(&hci_index_ida, HCI_MAX_ID - 1, GFP_KERNEL); + if (id < 0) + return id; + +@@ -2670,12 +2645,10 @@ int hci_register_dev(struct hci_dev *hdev) + hci_dev_set_flag(hdev, HCI_SETUP); + hci_dev_set_flag(hdev, HCI_AUTO_OFF); + +- if (hdev->dev_type == HCI_PRIMARY) { +- /* Assume BR/EDR support until proven otherwise (such as +- * through reading supported features during init. +- */ +- hci_dev_set_flag(hdev, HCI_BREDR_ENABLED); +- } ++ /* Assume BR/EDR support until proven otherwise (such as ++ * through reading supported features during init. ++ */ ++ hci_dev_set_flag(hdev, HCI_BREDR_ENABLED); + + write_lock(&hci_dev_list_lock); + list_add(&hdev->list, &hci_dev_list); +@@ -3211,17 +3184,7 @@ static void hci_queue_acl(struct hci_chan *chan, struct sk_buff_head *queue, + + hci_skb_pkt_type(skb) = HCI_ACLDATA_PKT; + +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- hci_add_acl_hdr(skb, conn->handle, flags); +- break; +- case HCI_AMP: +- hci_add_acl_hdr(skb, chan->handle, flags); +- break; +- default: +- bt_dev_err(hdev, "unknown dev_type %d", hdev->dev_type); +- return; +- } ++ hci_add_acl_hdr(skb, conn->handle, flags); + + list = skb_shinfo(skb)->frag_list; + if (!list) { +@@ -3381,9 +3344,6 @@ static inline void hci_quote_sent(struct hci_conn *conn, int num, int *quote) + case ACL_LINK: + cnt = hdev->acl_cnt; + break; +- case AMP_LINK: +- cnt = hdev->block_cnt; +- break; + case SCO_LINK: + case ESCO_LINK: + cnt = hdev->sco_cnt; +@@ -3581,12 +3541,6 @@ static void hci_prio_recalculate(struct hci_dev *hdev, __u8 type) + + } + +-static inline int __get_blocks(struct hci_dev *hdev, struct sk_buff *skb) +-{ +- /* Calculate count of blocks used by this packet */ +- return DIV_ROUND_UP(skb->len - HCI_ACL_HDR_SIZE, hdev->block_len); +-} +- + static void __check_timeout(struct hci_dev *hdev, unsigned int cnt, u8 type) + { + unsigned long last_tx; +@@ -3700,81 +3654,15 @@ static void hci_sched_acl_pkt(struct hci_dev *hdev) + hci_prio_recalculate(hdev, ACL_LINK); + } + +-static void hci_sched_acl_blk(struct hci_dev *hdev) +-{ +- unsigned int cnt = hdev->block_cnt; +- struct hci_chan *chan; +- struct sk_buff *skb; +- int quote; +- u8 type; +- +- BT_DBG("%s", hdev->name); +- +- if (hdev->dev_type == HCI_AMP) +- type = AMP_LINK; +- else +- type = ACL_LINK; +- +- __check_timeout(hdev, cnt, type); +- +- while (hdev->block_cnt > 0 && +- (chan = hci_chan_sent(hdev, type, "e))) { +- u32 priority = (skb_peek(&chan->data_q))->priority; +- while (quote > 0 && (skb = skb_peek(&chan->data_q))) { +- int blocks; +- +- BT_DBG("chan %p skb %p len %d priority %u", chan, skb, +- skb->len, skb->priority); +- +- /* Stop if priority has changed */ +- if (skb->priority < priority) +- break; +- +- skb = skb_dequeue(&chan->data_q); +- +- blocks = __get_blocks(hdev, skb); +- if (blocks > hdev->block_cnt) +- return; +- +- hci_conn_enter_active_mode(chan->conn, +- bt_cb(skb)->force_active); +- +- hci_send_frame(hdev, skb); +- hdev->acl_last_tx = jiffies; +- +- hdev->block_cnt -= blocks; +- quote -= blocks; +- +- chan->sent += blocks; +- chan->conn->sent += blocks; +- } +- } +- +- if (cnt != hdev->block_cnt) +- hci_prio_recalculate(hdev, type); +-} +- + static void hci_sched_acl(struct hci_dev *hdev) + { + BT_DBG("%s", hdev->name); + + /* No ACL link over BR/EDR controller */ +- if (!hci_conn_num(hdev, ACL_LINK) && hdev->dev_type == HCI_PRIMARY) +- return; +- +- /* No AMP link over AMP controller */ +- if (!hci_conn_num(hdev, AMP_LINK) && hdev->dev_type == HCI_AMP) ++ if (!hci_conn_num(hdev, ACL_LINK)) + return; + +- switch (hdev->flow_ctl_mode) { +- case HCI_FLOW_CTL_MODE_PACKET_BASED: +- hci_sched_acl_pkt(hdev); +- break; +- +- case HCI_FLOW_CTL_MODE_BLOCK_BASED: +- hci_sched_acl_blk(hdev); +- break; +- } ++ hci_sched_acl_pkt(hdev); + } + + static void hci_sched_le(struct hci_dev *hdev) +diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c +index 4de8f0dc1a523..33fac5cab1a8d 100644 +--- a/net/bluetooth/hci_event.c ++++ b/net/bluetooth/hci_event.c +@@ -913,21 +913,6 @@ static u8 hci_cc_read_local_ext_features(struct hci_dev *hdev, void *data, + return rp->status; + } + +-static u8 hci_cc_read_flow_control_mode(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_rp_read_flow_control_mode *rp = data; +- +- bt_dev_dbg(hdev, "status 0x%2.2x", rp->status); +- +- if (rp->status) +- return rp->status; +- +- hdev->flow_ctl_mode = rp->mode; +- +- return rp->status; +-} +- + static u8 hci_cc_read_buffer_size(struct hci_dev *hdev, void *data, + struct sk_buff *skb) + { +@@ -1071,28 +1056,6 @@ static u8 hci_cc_write_page_scan_type(struct hci_dev *hdev, void *data, + return rp->status; + } + +-static u8 hci_cc_read_data_block_size(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_rp_read_data_block_size *rp = data; +- +- bt_dev_dbg(hdev, "status 0x%2.2x", rp->status); +- +- if (rp->status) +- return rp->status; +- +- hdev->block_mtu = __le16_to_cpu(rp->max_acl_len); +- hdev->block_len = __le16_to_cpu(rp->block_len); +- hdev->num_blocks = __le16_to_cpu(rp->num_blocks); +- +- hdev->block_cnt = hdev->num_blocks; +- +- BT_DBG("%s blk mtu %d cnt %d len %d", hdev->name, hdev->block_mtu, +- hdev->block_cnt, hdev->block_len); +- +- return rp->status; +-} +- + static u8 hci_cc_read_clock(struct hci_dev *hdev, void *data, + struct sk_buff *skb) + { +@@ -1127,30 +1090,6 @@ static u8 hci_cc_read_clock(struct hci_dev *hdev, void *data, + return rp->status; + } + +-static u8 hci_cc_read_local_amp_info(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_rp_read_local_amp_info *rp = data; +- +- bt_dev_dbg(hdev, "status 0x%2.2x", rp->status); +- +- if (rp->status) +- return rp->status; +- +- hdev->amp_status = rp->amp_status; +- hdev->amp_total_bw = __le32_to_cpu(rp->total_bw); +- hdev->amp_max_bw = __le32_to_cpu(rp->max_bw); +- hdev->amp_min_latency = __le32_to_cpu(rp->min_latency); +- hdev->amp_max_pdu = __le32_to_cpu(rp->max_pdu); +- hdev->amp_type = rp->amp_type; +- hdev->amp_pal_cap = __le16_to_cpu(rp->pal_cap); +- hdev->amp_assoc_size = __le16_to_cpu(rp->max_assoc_size); +- hdev->amp_be_flush_to = __le32_to_cpu(rp->be_flush_to); +- hdev->amp_max_flush_to = __le32_to_cpu(rp->max_flush_to); +- +- return rp->status; +-} +- + static u8 hci_cc_read_inq_rsp_tx_power(struct hci_dev *hdev, void *data, + struct sk_buff *skb) + { +@@ -4121,12 +4060,6 @@ static const struct hci_cc { + HCI_CC(HCI_OP_READ_PAGE_SCAN_TYPE, hci_cc_read_page_scan_type, + sizeof(struct hci_rp_read_page_scan_type)), + HCI_CC_STATUS(HCI_OP_WRITE_PAGE_SCAN_TYPE, hci_cc_write_page_scan_type), +- HCI_CC(HCI_OP_READ_DATA_BLOCK_SIZE, hci_cc_read_data_block_size, +- sizeof(struct hci_rp_read_data_block_size)), +- HCI_CC(HCI_OP_READ_FLOW_CONTROL_MODE, hci_cc_read_flow_control_mode, +- sizeof(struct hci_rp_read_flow_control_mode)), +- HCI_CC(HCI_OP_READ_LOCAL_AMP_INFO, hci_cc_read_local_amp_info, +- sizeof(struct hci_rp_read_local_amp_info)), + HCI_CC(HCI_OP_READ_CLOCK, hci_cc_read_clock, + sizeof(struct hci_rp_read_clock)), + HCI_CC(HCI_OP_READ_ENC_KEY_SIZE, hci_cc_read_enc_key_size, +@@ -4461,11 +4394,6 @@ static void hci_num_comp_pkts_evt(struct hci_dev *hdev, void *data, + flex_array_size(ev, handles, ev->num))) + return; + +- if (hdev->flow_ctl_mode != HCI_FLOW_CTL_MODE_PACKET_BASED) { +- bt_dev_err(hdev, "wrong event for mode %d", hdev->flow_ctl_mode); +- return; +- } +- + bt_dev_dbg(hdev, "num %d", ev->num); + + for (i = 0; i < ev->num; i++) { +@@ -4533,78 +4461,6 @@ static void hci_num_comp_pkts_evt(struct hci_dev *hdev, void *data, + queue_work(hdev->workqueue, &hdev->tx_work); + } + +-static struct hci_conn *__hci_conn_lookup_handle(struct hci_dev *hdev, +- __u16 handle) +-{ +- struct hci_chan *chan; +- +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- return hci_conn_hash_lookup_handle(hdev, handle); +- case HCI_AMP: +- chan = hci_chan_lookup_handle(hdev, handle); +- if (chan) +- return chan->conn; +- break; +- default: +- bt_dev_err(hdev, "unknown dev_type %d", hdev->dev_type); +- break; +- } +- +- return NULL; +-} +- +-static void hci_num_comp_blocks_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_num_comp_blocks *ev = data; +- int i; +- +- if (!hci_ev_skb_pull(hdev, skb, HCI_EV_NUM_COMP_BLOCKS, +- flex_array_size(ev, handles, ev->num_hndl))) +- return; +- +- if (hdev->flow_ctl_mode != HCI_FLOW_CTL_MODE_BLOCK_BASED) { +- bt_dev_err(hdev, "wrong event for mode %d", +- hdev->flow_ctl_mode); +- return; +- } +- +- bt_dev_dbg(hdev, "num_blocks %d num_hndl %d", ev->num_blocks, +- ev->num_hndl); +- +- for (i = 0; i < ev->num_hndl; i++) { +- struct hci_comp_blocks_info *info = &ev->handles[i]; +- struct hci_conn *conn = NULL; +- __u16 handle, block_count; +- +- handle = __le16_to_cpu(info->handle); +- block_count = __le16_to_cpu(info->blocks); +- +- conn = __hci_conn_lookup_handle(hdev, handle); +- if (!conn) +- continue; +- +- conn->sent -= block_count; +- +- switch (conn->type) { +- case ACL_LINK: +- case AMP_LINK: +- hdev->block_cnt += block_count; +- if (hdev->block_cnt > hdev->num_blocks) +- hdev->block_cnt = hdev->num_blocks; +- break; +- +- default: +- bt_dev_err(hdev, "unknown type %d conn %p", +- conn->type, conn); +- break; +- } +- } +- +- queue_work(hdev->workqueue, &hdev->tx_work); +-} +- + static void hci_mode_change_evt(struct hci_dev *hdev, void *data, + struct sk_buff *skb) + { +@@ -7512,9 +7368,6 @@ static const struct hci_ev { + /* [0x3e = HCI_EV_LE_META] */ + HCI_EV_REQ_VL(HCI_EV_LE_META, hci_le_meta_evt, + sizeof(struct hci_ev_le_meta), HCI_MAX_EVENT_SIZE), +- /* [0x48 = HCI_EV_NUM_COMP_BLOCKS] */ +- HCI_EV(HCI_EV_NUM_COMP_BLOCKS, hci_num_comp_blocks_evt, +- sizeof(struct hci_ev_num_comp_blocks)), + /* [0xff = HCI_EV_VENDOR] */ + HCI_EV_VL(HCI_EV_VENDOR, msft_vendor_evt, 0, HCI_MAX_EVENT_SIZE), + }; +diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c +index 703b84bd48d5b..69c2ba1e843eb 100644 +--- a/net/bluetooth/hci_sock.c ++++ b/net/bluetooth/hci_sock.c +@@ -485,7 +485,7 @@ static struct sk_buff *create_monitor_event(struct hci_dev *hdev, int event) + return NULL; + + ni = skb_put(skb, HCI_MON_NEW_INDEX_SIZE); +- ni->type = hdev->dev_type; ++ ni->type = 0x00; /* Old hdev->dev_type */ + ni->bus = hdev->bus; + bacpy(&ni->bdaddr, &hdev->bdaddr); + memcpy_and_pad(ni->name, sizeof(ni->name), hdev->name, +@@ -1007,9 +1007,6 @@ static int hci_sock_bound_ioctl(struct sock *sk, unsigned int cmd, + if (hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) + return -EOPNOTSUPP; + +- if (hdev->dev_type != HCI_PRIMARY) +- return -EOPNOTSUPP; +- + switch (cmd) { + case HCISETRAW: + if (!capable(CAP_NET_ADMIN)) +diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c +index 40b71bc505730..513b538ef9448 100644 +--- a/net/bluetooth/hci_sync.c ++++ b/net/bluetooth/hci_sync.c +@@ -3488,10 +3488,6 @@ static int hci_unconf_init_sync(struct hci_dev *hdev) + /* Read Local Supported Features. */ + static int hci_read_local_features_sync(struct hci_dev *hdev) + { +- /* Not all AMP controllers support this command */ +- if (hdev->dev_type == HCI_AMP && !(hdev->commands[14] & 0x20)) +- return 0; +- + return __hci_cmd_sync_status(hdev, HCI_OP_READ_LOCAL_FEATURES, + 0, NULL, HCI_CMD_TIMEOUT); + } +@@ -3526,51 +3522,6 @@ static int hci_read_local_cmds_sync(struct hci_dev *hdev) + return 0; + } + +-/* Read Local AMP Info */ +-static int hci_read_local_amp_info_sync(struct hci_dev *hdev) +-{ +- return __hci_cmd_sync_status(hdev, HCI_OP_READ_LOCAL_AMP_INFO, +- 0, NULL, HCI_CMD_TIMEOUT); +-} +- +-/* Read Data Blk size */ +-static int hci_read_data_block_size_sync(struct hci_dev *hdev) +-{ +- return __hci_cmd_sync_status(hdev, HCI_OP_READ_DATA_BLOCK_SIZE, +- 0, NULL, HCI_CMD_TIMEOUT); +-} +- +-/* Read Flow Control Mode */ +-static int hci_read_flow_control_mode_sync(struct hci_dev *hdev) +-{ +- return __hci_cmd_sync_status(hdev, HCI_OP_READ_FLOW_CONTROL_MODE, +- 0, NULL, HCI_CMD_TIMEOUT); +-} +- +-/* Read Location Data */ +-static int hci_read_location_data_sync(struct hci_dev *hdev) +-{ +- return __hci_cmd_sync_status(hdev, HCI_OP_READ_LOCATION_DATA, +- 0, NULL, HCI_CMD_TIMEOUT); +-} +- +-/* AMP Controller init stage 1 command sequence */ +-static const struct hci_init_stage amp_init1[] = { +- /* HCI_OP_READ_LOCAL_VERSION */ +- HCI_INIT(hci_read_local_version_sync), +- /* HCI_OP_READ_LOCAL_COMMANDS */ +- HCI_INIT(hci_read_local_cmds_sync), +- /* HCI_OP_READ_LOCAL_AMP_INFO */ +- HCI_INIT(hci_read_local_amp_info_sync), +- /* HCI_OP_READ_DATA_BLOCK_SIZE */ +- HCI_INIT(hci_read_data_block_size_sync), +- /* HCI_OP_READ_FLOW_CONTROL_MODE */ +- HCI_INIT(hci_read_flow_control_mode_sync), +- /* HCI_OP_READ_LOCATION_DATA */ +- HCI_INIT(hci_read_location_data_sync), +- {} +-}; +- + static int hci_init1_sync(struct hci_dev *hdev) + { + int err; +@@ -3584,28 +3535,9 @@ static int hci_init1_sync(struct hci_dev *hdev) + return err; + } + +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- hdev->flow_ctl_mode = HCI_FLOW_CTL_MODE_PACKET_BASED; +- return hci_init_stage_sync(hdev, br_init1); +- case HCI_AMP: +- hdev->flow_ctl_mode = HCI_FLOW_CTL_MODE_BLOCK_BASED; +- return hci_init_stage_sync(hdev, amp_init1); +- default: +- bt_dev_err(hdev, "Unknown device type %d", hdev->dev_type); +- break; +- } +- +- return 0; ++ return hci_init_stage_sync(hdev, br_init1); + } + +-/* AMP Controller init stage 2 command sequence */ +-static const struct hci_init_stage amp_init2[] = { +- /* HCI_OP_READ_LOCAL_FEATURES */ +- HCI_INIT(hci_read_local_features_sync), +- {} +-}; +- + /* Read Buffer Size (ACL mtu, max pkt, etc.) */ + static int hci_read_buffer_size_sync(struct hci_dev *hdev) + { +@@ -3863,9 +3795,6 @@ static int hci_init2_sync(struct hci_dev *hdev) + + bt_dev_dbg(hdev, ""); + +- if (hdev->dev_type == HCI_AMP) +- return hci_init_stage_sync(hdev, amp_init2); +- + err = hci_init_stage_sync(hdev, hci_init2); + if (err) + return err; +@@ -4703,13 +4632,6 @@ static int hci_init_sync(struct hci_dev *hdev) + if (err < 0) + return err; + +- /* HCI_PRIMARY covers both single-mode LE, BR/EDR and dual-mode +- * BR/EDR/LE type controllers. AMP controllers only need the +- * first two stages of init. +- */ +- if (hdev->dev_type != HCI_PRIMARY) +- return 0; +- + err = hci_init3_sync(hdev); + if (err < 0) + return err; +@@ -4938,12 +4860,8 @@ int hci_dev_open_sync(struct hci_dev *hdev) + * In case of user channel usage, it is not important + * if a public address or static random address is + * available. +- * +- * This check is only valid for BR/EDR controllers +- * since AMP controllers do not have an address. + */ + if (!hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && +- hdev->dev_type == HCI_PRIMARY && + !bacmp(&hdev->bdaddr, BDADDR_ANY) && + !bacmp(&hdev->static_addr, BDADDR_ANY)) { + ret = -EADDRNOTAVAIL; +@@ -4978,8 +4896,7 @@ int hci_dev_open_sync(struct hci_dev *hdev) + !hci_dev_test_flag(hdev, HCI_CONFIG) && + !hci_dev_test_flag(hdev, HCI_UNCONFIGURED) && + !hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && +- hci_dev_test_flag(hdev, HCI_MGMT) && +- hdev->dev_type == HCI_PRIMARY) { ++ hci_dev_test_flag(hdev, HCI_MGMT)) { + ret = hci_powered_update_sync(hdev); + mgmt_power_on(hdev, ret); + } +@@ -5124,8 +5041,7 @@ int hci_dev_close_sync(struct hci_dev *hdev) + + auto_off = hci_dev_test_and_clear_flag(hdev, HCI_AUTO_OFF); + +- if (!auto_off && hdev->dev_type == HCI_PRIMARY && +- !hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && ++ if (!auto_off && !hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && + hci_dev_test_flag(hdev, HCI_MGMT)) + __mgmt_power_off(hdev); + +@@ -5187,9 +5103,6 @@ int hci_dev_close_sync(struct hci_dev *hdev) + hdev->flags &= BIT(HCI_RAW); + hci_dev_clear_volatile_flags(hdev); + +- /* Controller radio is available but is currently powered down */ +- hdev->amp_status = AMP_STATUS_POWERED_DOWN; +- + memset(hdev->eir, 0, sizeof(hdev->eir)); + memset(hdev->dev_class, 0, sizeof(hdev->dev_class)); + bacpy(&hdev->random_addr, BDADDR_ANY); +@@ -5226,8 +5139,7 @@ static int hci_power_on_sync(struct hci_dev *hdev) + */ + if (hci_dev_test_flag(hdev, HCI_RFKILLED) || + hci_dev_test_flag(hdev, HCI_UNCONFIGURED) || +- (hdev->dev_type == HCI_PRIMARY && +- !bacmp(&hdev->bdaddr, BDADDR_ANY) && ++ (!bacmp(&hdev->bdaddr, BDADDR_ANY) && + !bacmp(&hdev->static_addr, BDADDR_ANY))) { + hci_dev_clear_flag(hdev, HCI_AUTO_OFF); + hci_dev_close_sync(hdev); +@@ -5329,27 +5241,11 @@ int hci_stop_discovery_sync(struct hci_dev *hdev) + return 0; + } + +-static int hci_disconnect_phy_link_sync(struct hci_dev *hdev, u16 handle, +- u8 reason) +-{ +- struct hci_cp_disconn_phy_link cp; +- +- memset(&cp, 0, sizeof(cp)); +- cp.phy_handle = HCI_PHY_HANDLE(handle); +- cp.reason = reason; +- +- return __hci_cmd_sync_status(hdev, HCI_OP_DISCONN_PHY_LINK, +- sizeof(cp), &cp, HCI_CMD_TIMEOUT); +-} +- + static int hci_disconnect_sync(struct hci_dev *hdev, struct hci_conn *conn, + u8 reason) + { + struct hci_cp_disconnect cp; + +- if (conn->type == AMP_LINK) +- return hci_disconnect_phy_link_sync(hdev, conn->handle, reason); +- + if (test_bit(HCI_CONN_BIG_CREATED, &conn->flags)) { + /* This is a BIS connection, hci_conn_del will + * do the necessary cleanup. +diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c +index 44454115c10ad..4a633c1b68825 100644 +--- a/net/bluetooth/l2cap_core.c ++++ b/net/bluetooth/l2cap_core.c +@@ -3930,7 +3930,7 @@ static inline int l2cap_command_rej(struct l2cap_conn *conn, + } + + static void l2cap_connect(struct l2cap_conn *conn, struct l2cap_cmd_hdr *cmd, +- u8 *data, u8 rsp_code, u8 amp_id) ++ u8 *data, u8 rsp_code) + { + struct l2cap_conn_req *req = (struct l2cap_conn_req *) data; + struct l2cap_conn_rsp rsp; +@@ -4009,17 +4009,8 @@ static void l2cap_connect(struct l2cap_conn *conn, struct l2cap_cmd_hdr *cmd, + status = L2CAP_CS_AUTHOR_PEND; + chan->ops->defer(chan); + } else { +- /* Force pending result for AMP controllers. +- * The connection will succeed after the +- * physical link is up. +- */ +- if (amp_id == AMP_ID_BREDR) { +- l2cap_state_change(chan, BT_CONFIG); +- result = L2CAP_CR_SUCCESS; +- } else { +- l2cap_state_change(chan, BT_CONNECT2); +- result = L2CAP_CR_PEND; +- } ++ l2cap_state_change(chan, BT_CONNECT2); ++ result = L2CAP_CR_PEND; + status = L2CAP_CS_NO_INFO; + } + } else { +@@ -4084,7 +4075,7 @@ static int l2cap_connect_req(struct l2cap_conn *conn, + mgmt_device_connected(hdev, hcon, NULL, 0); + hci_dev_unlock(hdev); + +- l2cap_connect(conn, cmd, data, L2CAP_CONN_RSP, 0); ++ l2cap_connect(conn, cmd, data, L2CAP_CONN_RSP); + return 0; + } + +@@ -7495,10 +7486,6 @@ void l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 flags) + struct l2cap_conn *conn = hcon->l2cap_data; + int len; + +- /* For AMP controller do not create l2cap conn */ +- if (!conn && hcon->hdev->dev_type != HCI_PRIMARY) +- goto drop; +- + if (!conn) + conn = l2cap_conn_add(hcon); + +diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c +index b8e05ddeedba9..d58d3e13910fa 100644 +--- a/net/bluetooth/mgmt.c ++++ b/net/bluetooth/mgmt.c +@@ -443,8 +443,7 @@ static int read_index_list(struct sock *sk, struct hci_dev *hdev, void *data, + + count = 0; + list_for_each_entry(d, &hci_dev_list, list) { +- if (d->dev_type == HCI_PRIMARY && +- !hci_dev_test_flag(d, HCI_UNCONFIGURED)) ++ if (!hci_dev_test_flag(d, HCI_UNCONFIGURED)) + count++; + } + +@@ -468,8 +467,7 @@ static int read_index_list(struct sock *sk, struct hci_dev *hdev, void *data, + if (test_bit(HCI_QUIRK_RAW_DEVICE, &d->quirks)) + continue; + +- if (d->dev_type == HCI_PRIMARY && +- !hci_dev_test_flag(d, HCI_UNCONFIGURED)) { ++ if (!hci_dev_test_flag(d, HCI_UNCONFIGURED)) { + rp->index[count++] = cpu_to_le16(d->id); + bt_dev_dbg(hdev, "Added hci%u", d->id); + } +@@ -503,8 +501,7 @@ static int read_unconf_index_list(struct sock *sk, struct hci_dev *hdev, + + count = 0; + list_for_each_entry(d, &hci_dev_list, list) { +- if (d->dev_type == HCI_PRIMARY && +- hci_dev_test_flag(d, HCI_UNCONFIGURED)) ++ if (hci_dev_test_flag(d, HCI_UNCONFIGURED)) + count++; + } + +@@ -528,8 +525,7 @@ static int read_unconf_index_list(struct sock *sk, struct hci_dev *hdev, + if (test_bit(HCI_QUIRK_RAW_DEVICE, &d->quirks)) + continue; + +- if (d->dev_type == HCI_PRIMARY && +- hci_dev_test_flag(d, HCI_UNCONFIGURED)) { ++ if (hci_dev_test_flag(d, HCI_UNCONFIGURED)) { + rp->index[count++] = cpu_to_le16(d->id); + bt_dev_dbg(hdev, "Added hci%u", d->id); + } +@@ -561,10 +557,8 @@ static int read_ext_index_list(struct sock *sk, struct hci_dev *hdev, + read_lock(&hci_dev_list_lock); + + count = 0; +- list_for_each_entry(d, &hci_dev_list, list) { +- if (d->dev_type == HCI_PRIMARY || d->dev_type == HCI_AMP) +- count++; +- } ++ list_for_each_entry(d, &hci_dev_list, list) ++ count++; + + rp = kmalloc(struct_size(rp, entry, count), GFP_ATOMIC); + if (!rp) { +@@ -585,16 +579,10 @@ static int read_ext_index_list(struct sock *sk, struct hci_dev *hdev, + if (test_bit(HCI_QUIRK_RAW_DEVICE, &d->quirks)) + continue; + +- if (d->dev_type == HCI_PRIMARY) { +- if (hci_dev_test_flag(d, HCI_UNCONFIGURED)) +- rp->entry[count].type = 0x01; +- else +- rp->entry[count].type = 0x00; +- } else if (d->dev_type == HCI_AMP) { +- rp->entry[count].type = 0x02; +- } else { +- continue; +- } ++ if (hci_dev_test_flag(d, HCI_UNCONFIGURED)) ++ rp->entry[count].type = 0x01; ++ else ++ rp->entry[count].type = 0x00; + + rp->entry[count].bus = d->bus; + rp->entry[count++].index = cpu_to_le16(d->id); +@@ -9325,23 +9313,14 @@ void mgmt_index_added(struct hci_dev *hdev) + if (test_bit(HCI_QUIRK_RAW_DEVICE, &hdev->quirks)) + return; + +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- if (hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) { +- mgmt_index_event(MGMT_EV_UNCONF_INDEX_ADDED, hdev, +- NULL, 0, HCI_MGMT_UNCONF_INDEX_EVENTS); +- ev.type = 0x01; +- } else { +- mgmt_index_event(MGMT_EV_INDEX_ADDED, hdev, NULL, 0, +- HCI_MGMT_INDEX_EVENTS); +- ev.type = 0x00; +- } +- break; +- case HCI_AMP: +- ev.type = 0x02; +- break; +- default: +- return; ++ if (hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) { ++ mgmt_index_event(MGMT_EV_UNCONF_INDEX_ADDED, hdev, NULL, 0, ++ HCI_MGMT_UNCONF_INDEX_EVENTS); ++ ev.type = 0x01; ++ } else { ++ mgmt_index_event(MGMT_EV_INDEX_ADDED, hdev, NULL, 0, ++ HCI_MGMT_INDEX_EVENTS); ++ ev.type = 0x00; + } + + ev.bus = hdev->bus; +@@ -9358,25 +9337,16 @@ void mgmt_index_removed(struct hci_dev *hdev) + if (test_bit(HCI_QUIRK_RAW_DEVICE, &hdev->quirks)) + return; + +- switch (hdev->dev_type) { +- case HCI_PRIMARY: +- mgmt_pending_foreach(0, hdev, cmd_complete_rsp, &status); ++ mgmt_pending_foreach(0, hdev, cmd_complete_rsp, &status); + +- if (hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) { +- mgmt_index_event(MGMT_EV_UNCONF_INDEX_REMOVED, hdev, +- NULL, 0, HCI_MGMT_UNCONF_INDEX_EVENTS); +- ev.type = 0x01; +- } else { +- mgmt_index_event(MGMT_EV_INDEX_REMOVED, hdev, NULL, 0, +- HCI_MGMT_INDEX_EVENTS); +- ev.type = 0x00; +- } +- break; +- case HCI_AMP: +- ev.type = 0x02; +- break; +- default: +- return; ++ if (hci_dev_test_flag(hdev, HCI_UNCONFIGURED)) { ++ mgmt_index_event(MGMT_EV_UNCONF_INDEX_REMOVED, hdev, NULL, 0, ++ HCI_MGMT_UNCONF_INDEX_EVENTS); ++ ev.type = 0x01; ++ } else { ++ mgmt_index_event(MGMT_EV_INDEX_REMOVED, hdev, NULL, 0, ++ HCI_MGMT_INDEX_EVENTS); ++ ev.type = 0x00; + } + + ev.bus = hdev->bus; +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-hci_conn-hci_sync-use-__counted_by-to-avoi.patch b/queue-6.8/bluetooth-hci_conn-hci_sync-use-__counted_by-to-avoi.patch new file mode 100644 index 00000000000..fcb388fc7f6 --- /dev/null +++ b/queue-6.8/bluetooth-hci_conn-hci_sync-use-__counted_by-to-avoi.patch @@ -0,0 +1,335 @@ +From cb197936bd99116a5f72e1f8a1be4e163c9495df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 16:52:46 -0600 +Subject: Bluetooth: hci_conn, hci_sync: Use __counted_by() to avoid -Wfamnae + warnings + +From: Gustavo A. R. Silva + +[ Upstream commit c4585edf708edb5277a3cc4b8581ccb833f3307d ] + +Prepare for the coming implementation by GCC and Clang of the +__counted_by attribute. Flexible array members annotated with +__counted_by can have their accesses bounds-checked at run-time +via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE +(for strcpy/memcpy-family functions). + +Also, -Wflex-array-member-not-at-end is coming in GCC-14, and we are +getting ready to enable it globally. + +So, use the `DEFINE_FLEX()` helper for multiple on-stack definitions +of a flexible structure where the size of the flexible-array member +is known at compile-time, and refactor the rest of the code, +accordingly. + +Notice that, due to the use of `__counted_by()` in `struct +hci_cp_le_create_cis`, the for loop in function `hci_cs_le_create_cis()` +had to be modified. Once the index `i`, through which `cp->cis[i]` is +accessed, falls in the interval [0, cp->num_cis), `cp->num_cis` cannot +be decremented all the way down to zero while accessing `cp->cis[]`: + +net/bluetooth/hci_event.c:4310: +4310 for (i = 0; cp->num_cis; cp->num_cis--, i++) { + ... +4314 handle = __le16_to_cpu(cp->cis[i].cis_handle); + +otherwise, only half (one iteration before `cp->num_cis == i`) or half +plus one (one iteration before `cp->num_cis < i`) of the items in the +array will be accessed before running into an out-of-bounds issue. So, +in order to avoid this, set `cp->num_cis` to zero just after the for +loop. + +Also, make use of `aux_num_cis` variable to update `cmd->num_cis` after +a `list_for_each_entry_rcu()` loop. + +With these changes, fix the following warnings: +net/bluetooth/hci_sync.c:1239:56: warning: structure containing a flexible +array member is not at the end of another structure +[-Wflex-array-member-not-at-end] +net/bluetooth/hci_sync.c:1415:51: warning: structure containing a flexible +array member is not at the end of another structure +[-Wflex-array-member-not-at-end] +net/bluetooth/hci_sync.c:1731:51: warning: structure containing a flexible +array member is not at the end of another structure +[-Wflex-array-member-not-at-end] +net/bluetooth/hci_sync.c:6497:45: warning: structure containing a flexible +array member is not at the end of another structure +[-Wflex-array-member-not-at-end] + +Link: https://github.com/KSPP/linux/issues/202 +Signed-off-by: Gustavo A. R. Silva +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: e77f43d531af ("Bluetooth: hci_core: Fix not handling hdev->le_num_of_adv_sets=1") +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/hci.h | 8 ++-- + net/bluetooth/hci_event.c | 3 +- + net/bluetooth/hci_sync.c | 84 +++++++++++++++---------------------- + 3 files changed, 40 insertions(+), 55 deletions(-) + +diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h +index 55f95a93c0d7c..9eb3d2360b1ae 100644 +--- a/include/net/bluetooth/hci.h ++++ b/include/net/bluetooth/hci.h +@@ -1920,7 +1920,7 @@ struct hci_cp_le_set_ext_adv_data { + __u8 operation; + __u8 frag_pref; + __u8 length; +- __u8 data[]; ++ __u8 data[] __counted_by(length); + } __packed; + + #define HCI_OP_LE_SET_EXT_SCAN_RSP_DATA 0x2038 +@@ -1929,7 +1929,7 @@ struct hci_cp_le_set_ext_scan_rsp_data { + __u8 operation; + __u8 frag_pref; + __u8 length; +- __u8 data[]; ++ __u8 data[] __counted_by(length); + } __packed; + + #define HCI_OP_LE_SET_EXT_ADV_ENABLE 0x2039 +@@ -1955,7 +1955,7 @@ struct hci_cp_le_set_per_adv_data { + __u8 handle; + __u8 operation; + __u8 length; +- __u8 data[]; ++ __u8 data[] __counted_by(length); + } __packed; + + #define HCI_OP_LE_SET_PER_ADV_ENABLE 0x2040 +@@ -2056,7 +2056,7 @@ struct hci_cis { + + struct hci_cp_le_create_cis { + __u8 num_cis; +- struct hci_cis cis[]; ++ struct hci_cis cis[] __counted_by(num_cis); + } __packed; + + #define HCI_OP_LE_REMOVE_CIG 0x2065 +diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c +index 33fac5cab1a8d..cce73749f2dce 100644 +--- a/net/bluetooth/hci_event.c ++++ b/net/bluetooth/hci_event.c +@@ -4250,7 +4250,7 @@ static void hci_cs_le_create_cis(struct hci_dev *hdev, u8 status) + hci_dev_lock(hdev); + + /* Remove connection if command failed */ +- for (i = 0; cp->num_cis; cp->num_cis--, i++) { ++ for (i = 0; i < cp->num_cis; i++) { + struct hci_conn *conn; + u16 handle; + +@@ -4266,6 +4266,7 @@ static void hci_cs_le_create_cis(struct hci_dev *hdev, u8 status) + hci_conn_del(conn); + } + } ++ cp->num_cis = 0; + + if (pending) + hci_le_create_cis_pending(hdev); +diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c +index 513b538ef9448..0525e38ba20a3 100644 +--- a/net/bluetooth/hci_sync.c ++++ b/net/bluetooth/hci_sync.c +@@ -1235,31 +1235,27 @@ int hci_setup_ext_adv_instance_sync(struct hci_dev *hdev, u8 instance) + + static int hci_set_ext_scan_rsp_data_sync(struct hci_dev *hdev, u8 instance) + { +- struct { +- struct hci_cp_le_set_ext_scan_rsp_data cp; +- u8 data[HCI_MAX_EXT_AD_LENGTH]; +- } pdu; ++ DEFINE_FLEX(struct hci_cp_le_set_ext_scan_rsp_data, pdu, data, length, ++ HCI_MAX_EXT_AD_LENGTH); + u8 len; + struct adv_info *adv = NULL; + int err; + +- memset(&pdu, 0, sizeof(pdu)); +- + if (instance) { + adv = hci_find_adv_instance(hdev, instance); + if (!adv || !adv->scan_rsp_changed) + return 0; + } + +- len = eir_create_scan_rsp(hdev, instance, pdu.data); ++ len = eir_create_scan_rsp(hdev, instance, pdu->data); + +- pdu.cp.handle = instance; +- pdu.cp.length = len; +- pdu.cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; +- pdu.cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; ++ pdu->handle = instance; ++ pdu->length = len; ++ pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; ++ pdu->frag_pref = LE_SET_ADV_DATA_NO_FRAG; + + err = __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_EXT_SCAN_RSP_DATA, +- sizeof(pdu.cp) + len, &pdu.cp, ++ struct_size(pdu, data, len), pdu, + HCI_CMD_TIMEOUT); + if (err) + return err; +@@ -1267,7 +1263,7 @@ static int hci_set_ext_scan_rsp_data_sync(struct hci_dev *hdev, u8 instance) + if (adv) { + adv->scan_rsp_changed = false; + } else { +- memcpy(hdev->scan_rsp_data, pdu.data, len); ++ memcpy(hdev->scan_rsp_data, pdu->data, len); + hdev->scan_rsp_data_len = len; + } + +@@ -1411,14 +1407,10 @@ static int hci_set_per_adv_params_sync(struct hci_dev *hdev, u8 instance, + + static int hci_set_per_adv_data_sync(struct hci_dev *hdev, u8 instance) + { +- struct { +- struct hci_cp_le_set_per_adv_data cp; +- u8 data[HCI_MAX_PER_AD_LENGTH]; +- } pdu; ++ DEFINE_FLEX(struct hci_cp_le_set_per_adv_data, pdu, data, length, ++ HCI_MAX_PER_AD_LENGTH); + u8 len; + +- memset(&pdu, 0, sizeof(pdu)); +- + if (instance) { + struct adv_info *adv = hci_find_adv_instance(hdev, instance); + +@@ -1426,14 +1418,14 @@ static int hci_set_per_adv_data_sync(struct hci_dev *hdev, u8 instance) + return 0; + } + +- len = eir_create_per_adv_data(hdev, instance, pdu.data); ++ len = eir_create_per_adv_data(hdev, instance, pdu->data); + +- pdu.cp.length = len; +- pdu.cp.handle = instance; +- pdu.cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; ++ pdu->length = len; ++ pdu->handle = instance; ++ pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; + + return __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_PER_ADV_DATA, +- sizeof(pdu.cp) + len, &pdu, ++ struct_size(pdu, data, len), pdu, + HCI_CMD_TIMEOUT); + } + +@@ -1727,31 +1719,27 @@ int hci_le_terminate_big_sync(struct hci_dev *hdev, u8 handle, u8 reason) + + static int hci_set_ext_adv_data_sync(struct hci_dev *hdev, u8 instance) + { +- struct { +- struct hci_cp_le_set_ext_adv_data cp; +- u8 data[HCI_MAX_EXT_AD_LENGTH]; +- } pdu; ++ DEFINE_FLEX(struct hci_cp_le_set_ext_adv_data, pdu, data, length, ++ HCI_MAX_EXT_AD_LENGTH); + u8 len; + struct adv_info *adv = NULL; + int err; + +- memset(&pdu, 0, sizeof(pdu)); +- + if (instance) { + adv = hci_find_adv_instance(hdev, instance); + if (!adv || !adv->adv_data_changed) + return 0; + } + +- len = eir_create_adv_data(hdev, instance, pdu.data); ++ len = eir_create_adv_data(hdev, instance, pdu->data); + +- pdu.cp.length = len; +- pdu.cp.handle = instance; +- pdu.cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; +- pdu.cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; ++ pdu->length = len; ++ pdu->handle = instance; ++ pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; ++ pdu->frag_pref = LE_SET_ADV_DATA_NO_FRAG; + + err = __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_EXT_ADV_DATA, +- sizeof(pdu.cp) + len, &pdu.cp, ++ struct_size(pdu, data, len), pdu, + HCI_CMD_TIMEOUT); + if (err) + return err; +@@ -1760,7 +1748,7 @@ static int hci_set_ext_adv_data_sync(struct hci_dev *hdev, u8 instance) + if (adv) { + adv->adv_data_changed = false; + } else { +- memcpy(hdev->adv_data, pdu.data, len); ++ memcpy(hdev->adv_data, pdu->data, len); + hdev->adv_data_len = len; + } + +@@ -6358,10 +6346,8 @@ static int hci_le_create_conn_sync(struct hci_dev *hdev, void *data) + + int hci_le_create_cis_sync(struct hci_dev *hdev) + { +- struct { +- struct hci_cp_le_create_cis cp; +- struct hci_cis cis[0x1f]; +- } cmd; ++ DEFINE_FLEX(struct hci_cp_le_create_cis, cmd, cis, num_cis, 0x1f); ++ size_t aux_num_cis = 0; + struct hci_conn *conn; + u8 cig = BT_ISO_QOS_CIG_UNSET; + +@@ -6388,8 +6374,6 @@ int hci_le_create_cis_sync(struct hci_dev *hdev) + * remains pending. + */ + +- memset(&cmd, 0, sizeof(cmd)); +- + hci_dev_lock(hdev); + + rcu_read_lock(); +@@ -6426,7 +6410,7 @@ int hci_le_create_cis_sync(struct hci_dev *hdev) + goto done; + + list_for_each_entry_rcu(conn, &hdev->conn_hash.list, list) { +- struct hci_cis *cis = &cmd.cis[cmd.cp.num_cis]; ++ struct hci_cis *cis = &cmd->cis[aux_num_cis]; + + if (hci_conn_check_create_cis(conn) || + conn->iso_qos.ucast.cig != cig) +@@ -6435,25 +6419,25 @@ int hci_le_create_cis_sync(struct hci_dev *hdev) + set_bit(HCI_CONN_CREATE_CIS, &conn->flags); + cis->acl_handle = cpu_to_le16(conn->parent->handle); + cis->cis_handle = cpu_to_le16(conn->handle); +- cmd.cp.num_cis++; ++ aux_num_cis++; + +- if (cmd.cp.num_cis >= ARRAY_SIZE(cmd.cis)) ++ if (aux_num_cis >= 0x1f) + break; + } ++ cmd->num_cis = aux_num_cis; + + done: + rcu_read_unlock(); + + hci_dev_unlock(hdev); + +- if (!cmd.cp.num_cis) ++ if (!aux_num_cis) + return 0; + + /* Wait for HCI_LE_CIS_Established */ + return __hci_cmd_sync_status_sk(hdev, HCI_OP_LE_CREATE_CIS, +- sizeof(cmd.cp) + sizeof(cmd.cis[0]) * +- cmd.cp.num_cis, &cmd, +- HCI_EVT_LE_CIS_ESTABLISHED, ++ struct_size(cmd, cis, cmd->num_cis), ++ cmd, HCI_EVT_LE_CIS_ESTABLISHED, + conn->conn_timeout, NULL); + } + +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-hci_core-fix-not-handling-hdev-le_num_of_a.patch b/queue-6.8/bluetooth-hci_core-fix-not-handling-hdev-le_num_of_a.patch new file mode 100644 index 00000000000..25dffb9a05e --- /dev/null +++ b/queue-6.8/bluetooth-hci_core-fix-not-handling-hdev-le_num_of_a.patch @@ -0,0 +1,134 @@ +From 0fd8836ab8edf922b9728d27fbd43cfca8c67bbf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 16:07:55 -0400 +Subject: Bluetooth: hci_core: Fix not handling hdev->le_num_of_adv_sets=1 + +From: Luiz Augusto von Dentz + +[ Upstream commit e77f43d531af41e9ce299eab10dcae8fa5dbc293 ] + +If hdev->le_num_of_adv_sets is set to 1 it means that only handle 0x00 +can be used, but since the MGMT interface instances start from 1 +(instance 0 means all instances in case of MGMT_OP_REMOVE_ADVERTISING) +the code needs to map the instance to handle otherwise users will not be +able to advertise as instance 1 would attempt to use handle 0x01. + +Fixes: 1d0fac2c38ed ("Bluetooth: Use controller sets when available") +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/hci_core.h | 1 + + net/bluetooth/hci_core.c | 9 +++++++++ + net/bluetooth/hci_sync.c | 17 ++++++++--------- + 3 files changed, 18 insertions(+), 9 deletions(-) + +diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h +index 762b049bdabf1..5277c6d5134ca 100644 +--- a/include/net/bluetooth/hci_core.h ++++ b/include/net/bluetooth/hci_core.h +@@ -246,6 +246,7 @@ struct adv_info { + bool periodic; + __u8 mesh; + __u8 instance; ++ __u8 handle; + __u32 flags; + __u16 timeout; + __u16 remaining_time; +diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c +index 3817d6369f0cc..e946ac46a1762 100644 +--- a/net/bluetooth/hci_core.c ++++ b/net/bluetooth/hci_core.c +@@ -1727,6 +1727,15 @@ struct adv_info *hci_add_adv_instance(struct hci_dev *hdev, u8 instance, + + adv->pending = true; + adv->instance = instance; ++ ++ /* If controller support only one set and the instance is set to ++ * 1 then there is no option other than using handle 0x00. ++ */ ++ if (hdev->le_num_of_adv_sets == 1 && instance == 1) ++ adv->handle = 0x00; ++ else ++ adv->handle = instance; ++ + list_add(&adv->list, &hdev->adv_instances); + hdev->adv_instance_cnt++; + } +diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c +index 0525e38ba20a3..097d1c8713d8c 100644 +--- a/net/bluetooth/hci_sync.c ++++ b/net/bluetooth/hci_sync.c +@@ -1043,11 +1043,10 @@ static int hci_disable_ext_adv_instance_sync(struct hci_dev *hdev, u8 instance) + struct hci_cp_ext_adv_set *set; + u8 data[sizeof(*cp) + sizeof(*set) * 1]; + u8 size; ++ struct adv_info *adv = NULL; + + /* If request specifies an instance that doesn't exist, fail */ + if (instance > 0) { +- struct adv_info *adv; +- + adv = hci_find_adv_instance(hdev, instance); + if (!adv) + return -EINVAL; +@@ -1066,7 +1065,7 @@ static int hci_disable_ext_adv_instance_sync(struct hci_dev *hdev, u8 instance) + cp->num_of_sets = !!instance; + cp->enable = 0x00; + +- set->handle = instance; ++ set->handle = adv ? adv->handle : instance; + + size = sizeof(*cp) + sizeof(*set) * cp->num_of_sets; + +@@ -1249,7 +1248,7 @@ static int hci_set_ext_scan_rsp_data_sync(struct hci_dev *hdev, u8 instance) + + len = eir_create_scan_rsp(hdev, instance, pdu->data); + +- pdu->handle = instance; ++ pdu->handle = adv ? adv->handle : instance; + pdu->length = len; + pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; + pdu->frag_pref = LE_SET_ADV_DATA_NO_FRAG; +@@ -1331,7 +1330,7 @@ int hci_enable_ext_advertising_sync(struct hci_dev *hdev, u8 instance) + + memset(set, 0, sizeof(*set)); + +- set->handle = instance; ++ set->handle = adv ? adv->handle : instance; + + /* Set duration per instance since controller is responsible for + * scheduling it. +@@ -1410,10 +1409,10 @@ static int hci_set_per_adv_data_sync(struct hci_dev *hdev, u8 instance) + DEFINE_FLEX(struct hci_cp_le_set_per_adv_data, pdu, data, length, + HCI_MAX_PER_AD_LENGTH); + u8 len; ++ struct adv_info *adv = NULL; + + if (instance) { +- struct adv_info *adv = hci_find_adv_instance(hdev, instance); +- ++ adv = hci_find_adv_instance(hdev, instance); + if (!adv || !adv->periodic) + return 0; + } +@@ -1421,7 +1420,7 @@ static int hci_set_per_adv_data_sync(struct hci_dev *hdev, u8 instance) + len = eir_create_per_adv_data(hdev, instance, pdu->data); + + pdu->length = len; +- pdu->handle = instance; ++ pdu->handle = adv ? adv->handle : instance; + pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; + + return __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_PER_ADV_DATA, +@@ -1734,7 +1733,7 @@ static int hci_set_ext_adv_data_sync(struct hci_dev *hdev, u8 instance) + len = eir_create_adv_data(hdev, instance, pdu->data); + + pdu->length = len; +- pdu->handle = instance; ++ pdu->handle = adv ? adv->handle : instance; + pdu->operation = LE_SET_ADV_DATA_OP_COMPLETE; + pdu->frag_pref = LE_SET_ADV_DATA_NO_FRAG; + +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-hci_event-remove-code-to-removed-config_bt.patch b/queue-6.8/bluetooth-hci_event-remove-code-to-removed-config_bt.patch new file mode 100644 index 00000000000..6c01c6ed372 --- /dev/null +++ b/queue-6.8/bluetooth-hci_event-remove-code-to-removed-config_bt.patch @@ -0,0 +1,206 @@ +From 61ce0231ac77f0bd3e5026eef39b82148f51dc38 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 7 Feb 2024 14:42:11 +0100 +Subject: Bluetooth: hci_event: Remove code to removed CONFIG_BT_HS + +From: Lukas Bulwahn + +[ Upstream commit f4b0c2b4cd78b75acde56c2ee5aa732b6fb2a6a9 ] + +Commit cec9f3c5561d ("Bluetooth: Remove BT_HS") removes config BT_HS, but +misses two "ifdef BT_HS" blocks in hci_event.c. + +Remove this dead code from this removed config option. + +Signed-off-by: Lukas Bulwahn +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: 84a4bb6548a2 ("Bluetooth: HCI: Remove HCI_AMP support") +Signed-off-by: Sasha Levin +--- + net/bluetooth/hci_event.c | 163 -------------------------------------- + 1 file changed, 163 deletions(-) + +diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c +index c19d78e5d2053..4de8f0dc1a523 100644 +--- a/net/bluetooth/hci_event.c ++++ b/net/bluetooth/hci_event.c +@@ -5697,150 +5697,6 @@ static void hci_remote_oob_data_request_evt(struct hci_dev *hdev, void *edata, + hci_dev_unlock(hdev); + } + +-#if IS_ENABLED(CONFIG_BT_HS) +-static void hci_chan_selected_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_channel_selected *ev = data; +- struct hci_conn *hcon; +- +- bt_dev_dbg(hdev, "handle 0x%2.2x", ev->phy_handle); +- +- hcon = hci_conn_hash_lookup_handle(hdev, ev->phy_handle); +- if (!hcon) +- return; +- +- amp_read_loc_assoc_final_data(hdev, hcon); +-} +- +-static void hci_phy_link_complete_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_phy_link_complete *ev = data; +- struct hci_conn *hcon, *bredr_hcon; +- +- bt_dev_dbg(hdev, "handle 0x%2.2x status 0x%2.2x", ev->phy_handle, +- ev->status); +- +- hci_dev_lock(hdev); +- +- hcon = hci_conn_hash_lookup_handle(hdev, ev->phy_handle); +- if (!hcon) +- goto unlock; +- +- if (!hcon->amp_mgr) +- goto unlock; +- +- if (ev->status) { +- hci_conn_del(hcon); +- goto unlock; +- } +- +- bredr_hcon = hcon->amp_mgr->l2cap_conn->hcon; +- +- hcon->state = BT_CONNECTED; +- bacpy(&hcon->dst, &bredr_hcon->dst); +- +- hci_conn_hold(hcon); +- hcon->disc_timeout = HCI_DISCONN_TIMEOUT; +- hci_conn_drop(hcon); +- +- hci_debugfs_create_conn(hcon); +- hci_conn_add_sysfs(hcon); +- +- amp_physical_cfm(bredr_hcon, hcon); +- +-unlock: +- hci_dev_unlock(hdev); +-} +- +-static void hci_loglink_complete_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_logical_link_complete *ev = data; +- struct hci_conn *hcon; +- struct hci_chan *hchan; +- struct amp_mgr *mgr; +- +- bt_dev_dbg(hdev, "log_handle 0x%4.4x phy_handle 0x%2.2x status 0x%2.2x", +- le16_to_cpu(ev->handle), ev->phy_handle, ev->status); +- +- hcon = hci_conn_hash_lookup_handle(hdev, ev->phy_handle); +- if (!hcon) +- return; +- +- /* Create AMP hchan */ +- hchan = hci_chan_create(hcon); +- if (!hchan) +- return; +- +- hchan->handle = le16_to_cpu(ev->handle); +- hchan->amp = true; +- +- BT_DBG("hcon %p mgr %p hchan %p", hcon, hcon->amp_mgr, hchan); +- +- mgr = hcon->amp_mgr; +- if (mgr && mgr->bredr_chan) { +- struct l2cap_chan *bredr_chan = mgr->bredr_chan; +- +- l2cap_chan_lock(bredr_chan); +- +- bredr_chan->conn->mtu = hdev->block_mtu; +- l2cap_logical_cfm(bredr_chan, hchan, 0); +- hci_conn_hold(hcon); +- +- l2cap_chan_unlock(bredr_chan); +- } +-} +- +-static void hci_disconn_loglink_complete_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_disconn_logical_link_complete *ev = data; +- struct hci_chan *hchan; +- +- bt_dev_dbg(hdev, "handle 0x%4.4x status 0x%2.2x", +- le16_to_cpu(ev->handle), ev->status); +- +- if (ev->status) +- return; +- +- hci_dev_lock(hdev); +- +- hchan = hci_chan_lookup_handle(hdev, le16_to_cpu(ev->handle)); +- if (!hchan || !hchan->amp) +- goto unlock; +- +- amp_destroy_logical_link(hchan, ev->reason); +- +-unlock: +- hci_dev_unlock(hdev); +-} +- +-static void hci_disconn_phylink_complete_evt(struct hci_dev *hdev, void *data, +- struct sk_buff *skb) +-{ +- struct hci_ev_disconn_phy_link_complete *ev = data; +- struct hci_conn *hcon; +- +- bt_dev_dbg(hdev, "status 0x%2.2x", ev->status); +- +- if (ev->status) +- return; +- +- hci_dev_lock(hdev); +- +- hcon = hci_conn_hash_lookup_handle(hdev, ev->phy_handle); +- if (hcon && hcon->type == AMP_LINK) { +- hcon->state = BT_CLOSED; +- hci_disconn_cfm(hcon, ev->reason); +- hci_conn_del(hcon); +- } +- +- hci_dev_unlock(hdev); +-} +-#endif +- + static void le_conn_update_addr(struct hci_conn *conn, bdaddr_t *bdaddr, + u8 bdaddr_type, bdaddr_t *local_rpa) + { +@@ -7656,25 +7512,6 @@ static const struct hci_ev { + /* [0x3e = HCI_EV_LE_META] */ + HCI_EV_REQ_VL(HCI_EV_LE_META, hci_le_meta_evt, + sizeof(struct hci_ev_le_meta), HCI_MAX_EVENT_SIZE), +-#if IS_ENABLED(CONFIG_BT_HS) +- /* [0x40 = HCI_EV_PHY_LINK_COMPLETE] */ +- HCI_EV(HCI_EV_PHY_LINK_COMPLETE, hci_phy_link_complete_evt, +- sizeof(struct hci_ev_phy_link_complete)), +- /* [0x41 = HCI_EV_CHANNEL_SELECTED] */ +- HCI_EV(HCI_EV_CHANNEL_SELECTED, hci_chan_selected_evt, +- sizeof(struct hci_ev_channel_selected)), +- /* [0x42 = HCI_EV_DISCONN_PHY_LINK_COMPLETE] */ +- HCI_EV(HCI_EV_DISCONN_LOGICAL_LINK_COMPLETE, +- hci_disconn_loglink_complete_evt, +- sizeof(struct hci_ev_disconn_logical_link_complete)), +- /* [0x45 = HCI_EV_LOGICAL_LINK_COMPLETE] */ +- HCI_EV(HCI_EV_LOGICAL_LINK_COMPLETE, hci_loglink_complete_evt, +- sizeof(struct hci_ev_logical_link_complete)), +- /* [0x46 = HCI_EV_DISCONN_LOGICAL_LINK_COMPLETE] */ +- HCI_EV(HCI_EV_DISCONN_PHY_LINK_COMPLETE, +- hci_disconn_phylink_complete_evt, +- sizeof(struct hci_ev_disconn_phy_link_complete)), +-#endif + /* [0x48 = HCI_EV_NUM_COMP_BLOCKS] */ + HCI_EV(HCI_EV_NUM_COMP_BLOCKS, hci_num_comp_blocks_evt, + sizeof(struct hci_ev_num_comp_blocks)), +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-iso-add-hcon-for-listening-bis-sk.patch b/queue-6.8/bluetooth-iso-add-hcon-for-listening-bis-sk.patch new file mode 100644 index 00000000000..f5a69211e41 --- /dev/null +++ b/queue-6.8/bluetooth-iso-add-hcon-for-listening-bis-sk.patch @@ -0,0 +1,195 @@ +From bbb36ab0e15b74ae207c162b941401ac723913e8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Feb 2024 15:14:41 +0200 +Subject: Bluetooth: ISO: Add hcon for listening bis sk + +From: Iulia Tanasescu + +[ Upstream commit 02171da6e86a73e1b343b36722f5d9d5c04b3539 ] + +This creates a hcon instance at bis listen, before the PA sync +procedure is started. + +Signed-off-by: Iulia Tanasescu +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: a5b862c6a221 ("Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init()") +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/hci_core.h | 6 ++--- + net/bluetooth/hci_conn.c | 32 ++++++++++++++++++++----- + net/bluetooth/iso.c | 41 ++++++++++++++++++++++++-------- + 3 files changed, 60 insertions(+), 19 deletions(-) + +diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h +index 8504e10f51700..b1c8489ff93e4 100644 +--- a/include/net/bluetooth/hci_core.h ++++ b/include/net/bluetooth/hci_core.h +@@ -1,7 +1,7 @@ + /* + BlueZ - Bluetooth protocol stack for Linux + Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved. +- Copyright 2023 NXP ++ Copyright 2023-2024 NXP + + Written 2000,2001 by Maxim Krasnyansky + +@@ -1533,8 +1533,8 @@ struct hci_conn *hci_connect_cis(struct hci_dev *hdev, bdaddr_t *dst, + struct hci_conn *hci_connect_bis(struct hci_dev *hdev, bdaddr_t *dst, + __u8 dst_type, struct bt_iso_qos *qos, + __u8 data_len, __u8 *data); +-int hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, __u8 dst_type, +- __u8 sid, struct bt_iso_qos *qos); ++struct hci_conn *hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, ++ __u8 dst_type, __u8 sid, struct bt_iso_qos *qos); + int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon, + struct bt_iso_qos *qos, + __u16 sync_handle, __u8 num_bis, __u8 bis[]); +diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c +index 9a369bc14fd57..0a80fd6257c65 100644 +--- a/net/bluetooth/hci_conn.c ++++ b/net/bluetooth/hci_conn.c +@@ -1,7 +1,7 @@ + /* + BlueZ - Bluetooth protocol stack for Linux + Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved. +- Copyright 2023 NXP ++ Copyright 2023-2024 NXP + + Written 2000,2001 by Maxim Krasnyansky + +@@ -2086,18 +2086,31 @@ static int create_pa_sync(struct hci_dev *hdev, void *data) + return hci_update_passive_scan_sync(hdev); + } + +-int hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, __u8 dst_type, +- __u8 sid, struct bt_iso_qos *qos) ++struct hci_conn *hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, ++ __u8 dst_type, __u8 sid, ++ struct bt_iso_qos *qos) + { + struct hci_cp_le_pa_create_sync *cp; ++ struct hci_conn *conn; ++ int err; + + if (hci_dev_test_and_set_flag(hdev, HCI_PA_SYNC)) +- return -EBUSY; ++ return ERR_PTR(-EBUSY); ++ ++ conn = hci_conn_add_unset(hdev, ISO_LINK, dst, HCI_ROLE_SLAVE); ++ if (!conn) ++ return ERR_PTR(-ENOMEM); ++ ++ conn->iso_qos = *qos; ++ conn->state = BT_LISTEN; ++ ++ hci_conn_hold(conn); + + cp = kzalloc(sizeof(*cp), GFP_KERNEL); + if (!cp) { + hci_dev_clear_flag(hdev, HCI_PA_SYNC); +- return -ENOMEM; ++ hci_conn_drop(conn); ++ return ERR_PTR(-ENOMEM); + } + + cp->options = qos->bcast.options; +@@ -2109,7 +2122,14 @@ int hci_pa_create_sync(struct hci_dev *hdev, bdaddr_t *dst, __u8 dst_type, + cp->sync_cte_type = qos->bcast.sync_cte_type; + + /* Queue start pa_create_sync and scan */ +- return hci_cmd_sync_queue(hdev, create_pa_sync, cp, create_pa_complete); ++ err = hci_cmd_sync_queue(hdev, create_pa_sync, cp, create_pa_complete); ++ if (err < 0) { ++ hci_conn_drop(conn); ++ kfree(cp); ++ return ERR_PTR(err); ++ } ++ ++ return conn; + } + + int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon, +diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c +index 6d217df75c62c..71a484269fc4f 100644 +--- a/net/bluetooth/iso.c ++++ b/net/bluetooth/iso.c +@@ -3,7 +3,7 @@ + * BlueZ - Bluetooth protocol stack for Linux + * + * Copyright (C) 2022 Intel Corporation +- * Copyright 2023 NXP ++ * Copyright 2023-2024 NXP + */ + + #include +@@ -690,11 +690,8 @@ static void iso_sock_cleanup_listen(struct sock *parent) + iso_sock_kill(sk); + } + +- /* If listening socket stands for a PA sync connection, +- * properly disconnect the hcon and socket. +- */ +- if (iso_pi(parent)->conn && iso_pi(parent)->conn->hcon && +- test_bit(HCI_CONN_PA_SYNC, &iso_pi(parent)->conn->hcon->flags)) { ++ /* If listening socket has a hcon, properly disconnect it */ ++ if (iso_pi(parent)->conn && iso_pi(parent)->conn->hcon) { + iso_sock_disconn(parent); + return; + } +@@ -1076,6 +1073,8 @@ static int iso_listen_bis(struct sock *sk) + { + struct hci_dev *hdev; + int err = 0; ++ struct iso_conn *conn; ++ struct hci_conn *hcon; + + BT_DBG("%pMR -> %pMR (SID 0x%2.2x)", &iso_pi(sk)->src, + &iso_pi(sk)->dst, iso_pi(sk)->bc_sid); +@@ -1096,18 +1095,40 @@ static int iso_listen_bis(struct sock *sk) + if (!hdev) + return -EHOSTUNREACH; + ++ hci_dev_lock(hdev); ++ + /* Fail if user set invalid QoS */ + if (iso_pi(sk)->qos_user_set && !check_bcast_qos(&iso_pi(sk)->qos)) { + iso_pi(sk)->qos = default_qos; +- return -EINVAL; ++ err = -EINVAL; ++ goto unlock; + } + +- err = hci_pa_create_sync(hdev, &iso_pi(sk)->dst, +- le_addr_type(iso_pi(sk)->dst_type), +- iso_pi(sk)->bc_sid, &iso_pi(sk)->qos); ++ hcon = hci_pa_create_sync(hdev, &iso_pi(sk)->dst, ++ le_addr_type(iso_pi(sk)->dst_type), ++ iso_pi(sk)->bc_sid, &iso_pi(sk)->qos); ++ if (IS_ERR(hcon)) { ++ err = PTR_ERR(hcon); ++ goto unlock; ++ } ++ ++ conn = iso_conn_add(hcon); ++ if (!conn) { ++ hci_conn_drop(hcon); ++ err = -ENOMEM; ++ goto unlock; ++ } ++ ++ err = iso_chan_add(conn, sk, NULL); ++ if (err) { ++ hci_conn_drop(hcon); ++ goto unlock; ++ } + + hci_dev_put(hdev); + ++unlock: ++ hci_dev_unlock(hdev); + return err; + } + +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-iso-clean-up-returns-values-in-iso_connect.patch b/queue-6.8/bluetooth-iso-clean-up-returns-values-in-iso_connect.patch new file mode 100644 index 00000000000..c4d850750ea --- /dev/null +++ b/queue-6.8/bluetooth-iso-clean-up-returns-values-in-iso_connect.patch @@ -0,0 +1,64 @@ +From bf04edadd27b602d786827e985b701469db36ec2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 2 Mar 2024 11:30:43 +0300 +Subject: Bluetooth: ISO: Clean up returns values in iso_connect_ind() + +From: Dan Carpenter + +[ Upstream commit 18d88f0fd8c0fade7ae08c2778d6c6447b11f16a ] + +This function either returns 0 or HCI_LM_ACCEPT. Make it clearer which +returns are which and delete the "lm" variable because it is no longer +required. + +Signed-off-by: Dan Carpenter +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: a5b862c6a221 ("Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init()") +Signed-off-by: Sasha Levin +--- + net/bluetooth/iso.c | 9 +++------ + 1 file changed, 3 insertions(+), 6 deletions(-) + +diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c +index 71a484269fc4f..6bed4aa8291de 100644 +--- a/net/bluetooth/iso.c ++++ b/net/bluetooth/iso.c +@@ -1904,7 +1904,6 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + struct hci_evt_le_big_info_adv_report *ev2; + struct hci_ev_le_per_adv_report *ev3; + struct sock *sk; +- int lm = 0; + + bt_dev_dbg(hdev, "bdaddr %pMR", bdaddr); + +@@ -1948,7 +1947,7 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + + if (sk && test_bit(BT_SK_PA_SYNC_TERM, + &iso_pi(sk)->flags)) +- return lm; ++ return 0; + } + + if (sk) { +@@ -2035,16 +2034,14 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + + done: + if (!sk) +- return lm; +- +- lm |= HCI_LM_ACCEPT; ++ return 0; + + if (test_bit(BT_SK_DEFER_SETUP, &bt_sk(sk)->flags)) + *flags |= HCI_PROTO_DEFER; + + sock_put(sk); + +- return lm; ++ return HCI_LM_ACCEPT; + } + + static void iso_connect_cfm(struct hci_conn *hcon, __u8 status) +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-iso-make-iso_get_sock_listen-generic.patch b/queue-6.8/bluetooth-iso-make-iso_get_sock_listen-generic.patch new file mode 100644 index 00000000000..5ef784eab1f --- /dev/null +++ b/queue-6.8/bluetooth-iso-make-iso_get_sock_listen-generic.patch @@ -0,0 +1,198 @@ +From 05c71104a0a32790fbf5789a01fa6f36404c237d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 14:39:30 +0300 +Subject: Bluetooth: ISO: Make iso_get_sock_listen generic + +From: Iulia Tanasescu + +[ Upstream commit 311527e9dafdcae0c5a20d62f4f84ad01b33b5f4 ] + +This makes iso_get_sock_listen more generic, to return matching socket +in the state provided as argument. + +Signed-off-by: Iulia Tanasescu +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: a5b862c6a221 ("Bluetooth: L2CAP: Fix div-by-zero in l2cap_le_flowctl_init()") +Signed-off-by: Sasha Levin +--- + include/net/bluetooth/bluetooth.h | 2 +- + net/bluetooth/iso.c | 75 +++++++++++++++++-------------- + 2 files changed, 43 insertions(+), 34 deletions(-) + +diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h +index eaec5d6caa29d..b3228bd6cd6be 100644 +--- a/include/net/bluetooth/bluetooth.h ++++ b/include/net/bluetooth/bluetooth.h +@@ -285,7 +285,7 @@ void bt_err_ratelimited(const char *fmt, ...); + bt_err_ratelimited("%s: " fmt, bt_dev_name(hdev), ##__VA_ARGS__) + + /* Connection and socket states */ +-enum { ++enum bt_sock_state { + BT_CONNECTED = 1, /* Equal to TCP_ESTABLISHED to make net code happy */ + BT_OPEN, + BT_BOUND, +diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c +index 6bed4aa8291de..6cb41f9d174e2 100644 +--- a/net/bluetooth/iso.c ++++ b/net/bluetooth/iso.c +@@ -85,8 +85,9 @@ static void iso_sock_disconn(struct sock *sk); + + typedef bool (*iso_sock_match_t)(struct sock *sk, void *data); + +-static struct sock *iso_get_sock_listen(bdaddr_t *src, bdaddr_t *dst, +- iso_sock_match_t match, void *data); ++static struct sock *iso_get_sock(bdaddr_t *src, bdaddr_t *dst, ++ enum bt_sock_state state, ++ iso_sock_match_t match, void *data); + + /* ---- ISO timers ---- */ + #define ISO_CONN_TIMEOUT (HZ * 40) +@@ -233,10 +234,11 @@ static void iso_conn_del(struct hci_conn *hcon, int err) + * terminated are not processed anymore. + */ + if (test_bit(BT_SK_PA_SYNC, &iso_pi(sk)->flags)) { +- parent = iso_get_sock_listen(&hcon->src, +- &hcon->dst, +- iso_match_conn_sync_handle, +- hcon); ++ parent = iso_get_sock(&hcon->src, ++ &hcon->dst, ++ BT_LISTEN, ++ iso_match_conn_sync_handle, ++ hcon); + + if (parent) { + set_bit(BT_SK_PA_SYNC_TERM, +@@ -581,22 +583,23 @@ static struct sock *__iso_get_sock_listen_by_sid(bdaddr_t *ba, bdaddr_t *bc, + return NULL; + } + +-/* Find socket listening: ++/* Find socket in given state: + * source bdaddr (Unicast) + * destination bdaddr (Broadcast only) + * match func - pass NULL to ignore + * match func data - pass -1 to ignore + * Returns closest match. + */ +-static struct sock *iso_get_sock_listen(bdaddr_t *src, bdaddr_t *dst, +- iso_sock_match_t match, void *data) ++static struct sock *iso_get_sock(bdaddr_t *src, bdaddr_t *dst, ++ enum bt_sock_state state, ++ iso_sock_match_t match, void *data) + { + struct sock *sk = NULL, *sk1 = NULL; + + read_lock(&iso_sk_list.lock); + + sk_for_each(sk, &iso_sk_list.head) { +- if (sk->sk_state != BT_LISTEN) ++ if (sk->sk_state != state) + continue; + + /* Match Broadcast destination */ +@@ -1777,32 +1780,37 @@ static void iso_conn_ready(struct iso_conn *conn) + HCI_EVT_LE_BIG_SYNC_ESTABILISHED); + + /* Get reference to PA sync parent socket, if it exists */ +- parent = iso_get_sock_listen(&hcon->src, +- &hcon->dst, +- iso_match_pa_sync_flag, NULL); ++ parent = iso_get_sock(&hcon->src, &hcon->dst, ++ BT_LISTEN, ++ iso_match_pa_sync_flag, ++ NULL); + if (!parent && ev) +- parent = iso_get_sock_listen(&hcon->src, +- &hcon->dst, +- iso_match_big, ev); ++ parent = iso_get_sock(&hcon->src, ++ &hcon->dst, ++ BT_LISTEN, ++ iso_match_big, ev); + } else if (test_bit(HCI_CONN_PA_SYNC_FAILED, &hcon->flags)) { + ev2 = hci_recv_event_data(hcon->hdev, + HCI_EV_LE_PA_SYNC_ESTABLISHED); + if (ev2) +- parent = iso_get_sock_listen(&hcon->src, +- &hcon->dst, +- iso_match_sid, ev2); ++ parent = iso_get_sock(&hcon->src, ++ &hcon->dst, ++ BT_LISTEN, ++ iso_match_sid, ev2); + } else if (test_bit(HCI_CONN_PA_SYNC, &hcon->flags)) { + ev3 = hci_recv_event_data(hcon->hdev, + HCI_EVT_LE_BIG_INFO_ADV_REPORT); + if (ev3) +- parent = iso_get_sock_listen(&hcon->src, +- &hcon->dst, +- iso_match_sync_handle, ev3); ++ parent = iso_get_sock(&hcon->src, ++ &hcon->dst, ++ BT_LISTEN, ++ iso_match_sync_handle, ++ ev3); + } + + if (!parent) +- parent = iso_get_sock_listen(&hcon->src, +- BDADDR_ANY, NULL, NULL); ++ parent = iso_get_sock(&hcon->src, BDADDR_ANY, ++ BT_LISTEN, NULL, NULL); + + if (!parent) + return; +@@ -1923,8 +1931,8 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + */ + ev1 = hci_recv_event_data(hdev, HCI_EV_LE_PA_SYNC_ESTABLISHED); + if (ev1) { +- sk = iso_get_sock_listen(&hdev->bdaddr, bdaddr, iso_match_sid, +- ev1); ++ sk = iso_get_sock(&hdev->bdaddr, bdaddr, BT_LISTEN, ++ iso_match_sid, ev1); + if (sk && !ev1->status) + iso_pi(sk)->sync_handle = le16_to_cpu(ev1->handle); + +@@ -1934,12 +1942,12 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + ev2 = hci_recv_event_data(hdev, HCI_EVT_LE_BIG_INFO_ADV_REPORT); + if (ev2) { + /* Try to get PA sync listening socket, if it exists */ +- sk = iso_get_sock_listen(&hdev->bdaddr, bdaddr, +- iso_match_pa_sync_flag, NULL); ++ sk = iso_get_sock(&hdev->bdaddr, bdaddr, BT_LISTEN, ++ iso_match_pa_sync_flag, NULL); + + if (!sk) { +- sk = iso_get_sock_listen(&hdev->bdaddr, bdaddr, +- iso_match_sync_handle, ev2); ++ sk = iso_get_sock(&hdev->bdaddr, bdaddr, BT_LISTEN, ++ iso_match_sync_handle, ev2); + + /* If PA Sync is in process of terminating, + * do not handle any more BIGInfo adv reports. +@@ -1979,8 +1987,8 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + u8 *base; + struct hci_conn *hcon; + +- sk = iso_get_sock_listen(&hdev->bdaddr, bdaddr, +- iso_match_sync_handle_pa_report, ev3); ++ sk = iso_get_sock(&hdev->bdaddr, bdaddr, BT_LISTEN, ++ iso_match_sync_handle_pa_report, ev3); + if (!sk) + goto done; + +@@ -2029,7 +2037,8 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags) + hcon->le_per_adv_data_len = 0; + } + } else { +- sk = iso_get_sock_listen(&hdev->bdaddr, BDADDR_ANY, NULL, NULL); ++ sk = iso_get_sock(&hdev->bdaddr, BDADDR_ANY, ++ BT_LISTEN, NULL, NULL); + } + + done: +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-qca-fix-error-code-in-qca_read_fw_build_in.patch b/queue-6.8/bluetooth-qca-fix-error-code-in-qca_read_fw_build_in.patch new file mode 100644 index 00000000000..e29bb884396 --- /dev/null +++ b/queue-6.8/bluetooth-qca-fix-error-code-in-qca_read_fw_build_in.patch @@ -0,0 +1,39 @@ +From b4ba1e3925a7716e261ea1b39b86cc703df7d555 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 4 May 2024 14:25:43 +0300 +Subject: Bluetooth: qca: Fix error code in qca_read_fw_build_info() + +From: Dan Carpenter + +[ Upstream commit a189f0ee6685457528db7a36ded3085e5d13ddc3 ] + +Return -ENOMEM on allocation failure. Don't return success. + +Fixes: cda0d6a198e2 ("Bluetooth: qca: fix info leak when fetching fw build id") +Signed-off-by: Dan Carpenter +Reviewed-by: Johan Hovold +Signed-off-by: Luiz Augusto von Dentz +Signed-off-by: Sasha Levin +--- + drivers/bluetooth/btqca.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c +index 638074992c829..35fb26cbf2294 100644 +--- a/drivers/bluetooth/btqca.c ++++ b/drivers/bluetooth/btqca.c +@@ -148,8 +148,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev) + } + + build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL); +- if (!build_label) ++ if (!build_label) { ++ err = -ENOMEM; + goto out; ++ } + + hci_set_fw_info(hdev, "%s", build_label); + +-- +2.43.0 + diff --git a/queue-6.8/bluetooth-remove-usage-of-the-deprecated-ida_simple_.patch b/queue-6.8/bluetooth-remove-usage-of-the-deprecated-ida_simple_.patch new file mode 100644 index 00000000000..d526681092e --- /dev/null +++ b/queue-6.8/bluetooth-remove-usage-of-the-deprecated-ida_simple_.patch @@ -0,0 +1,85 @@ +From 0d27ec4e5f88616a7e38b1948444fe1eb3e9ba1f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Jan 2024 21:12:19 +0100 +Subject: Bluetooth: Remove usage of the deprecated ida_simple_xx() API + +From: Christophe JAILLET + +[ Upstream commit 9c16d0c8d93e3d2a95c5ed927b061f244db75579 ] + +ida_alloc() and ida_free() should be preferred to the deprecated +ida_simple_get() and ida_simple_remove(). + +Note that the upper limit of ida_simple_get() is exclusive, but the one of +ida_alloc_max() is inclusive. So a -1 has been added when needed. + +Signed-off-by: Christophe JAILLET +Signed-off-by: Luiz Augusto von Dentz +Stable-dep-of: 84a4bb6548a2 ("Bluetooth: HCI: Remove HCI_AMP support") +Signed-off-by: Sasha Levin +--- + net/bluetooth/hci_core.c | 9 +++++---- + net/bluetooth/hci_sock.c | 4 ++-- + 2 files changed, 7 insertions(+), 6 deletions(-) + +diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c +index befe645d3f9bf..101ea9137dfef 100644 +--- a/net/bluetooth/hci_core.c ++++ b/net/bluetooth/hci_core.c +@@ -2609,10 +2609,11 @@ int hci_register_dev(struct hci_dev *hdev) + */ + switch (hdev->dev_type) { + case HCI_PRIMARY: +- id = ida_simple_get(&hci_index_ida, 0, HCI_MAX_ID, GFP_KERNEL); ++ id = ida_alloc_max(&hci_index_ida, HCI_MAX_ID - 1, GFP_KERNEL); + break; + case HCI_AMP: +- id = ida_simple_get(&hci_index_ida, 1, HCI_MAX_ID, GFP_KERNEL); ++ id = ida_alloc_range(&hci_index_ida, 1, HCI_MAX_ID - 1, ++ GFP_KERNEL); + break; + default: + return -EINVAL; +@@ -2711,7 +2712,7 @@ int hci_register_dev(struct hci_dev *hdev) + destroy_workqueue(hdev->workqueue); + destroy_workqueue(hdev->req_workqueue); + err: +- ida_simple_remove(&hci_index_ida, hdev->id); ++ ida_free(&hci_index_ida, hdev->id); + + return error; + } +@@ -2793,7 +2794,7 @@ void hci_release_dev(struct hci_dev *hdev) + hci_dev_unlock(hdev); + + ida_destroy(&hdev->unset_handle_ida); +- ida_simple_remove(&hci_index_ida, hdev->id); ++ ida_free(&hci_index_ida, hdev->id); + kfree_skb(hdev->sent_cmd); + kfree_skb(hdev->req_skb); + kfree_skb(hdev->recv_event); +diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c +index 3f5f0932330d2..703b84bd48d5b 100644 +--- a/net/bluetooth/hci_sock.c ++++ b/net/bluetooth/hci_sock.c +@@ -101,7 +101,7 @@ static bool hci_sock_gen_cookie(struct sock *sk) + int id = hci_pi(sk)->cookie; + + if (!id) { +- id = ida_simple_get(&sock_cookie_ida, 1, 0, GFP_KERNEL); ++ id = ida_alloc_min(&sock_cookie_ida, 1, GFP_KERNEL); + if (id < 0) + id = 0xffffffff; + +@@ -119,7 +119,7 @@ static void hci_sock_free_cookie(struct sock *sk) + + if (id) { + hci_pi(sk)->cookie = 0xffffffff; +- ida_simple_remove(&sock_cookie_ida, id); ++ ida_free(&sock_cookie_ida, id); + } + } + +-- +2.43.0 + diff --git a/queue-6.8/bnxt_re-avoid-shift-undefined-behavior-in-bnxt_qplib.patch b/queue-6.8/bnxt_re-avoid-shift-undefined-behavior-in-bnxt_qplib.patch new file mode 100644 index 00000000000..ddb8d9f142e --- /dev/null +++ b/queue-6.8/bnxt_re-avoid-shift-undefined-behavior-in-bnxt_qplib.patch @@ -0,0 +1,122 @@ +From 08001fcedd8af5d1ddb601734efab7bed3f3d748 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 May 2024 12:39:28 +0200 +Subject: bnxt_re: avoid shift undefined behavior in bnxt_qplib_alloc_init_hwq + +From: Michal Schmidt + +[ Upstream commit 78cfd17142ef70599d6409cbd709d94b3da58659 ] + +Undefined behavior is triggered when bnxt_qplib_alloc_init_hwq is called +with hwq_attr->aux_depth != 0 and hwq_attr->aux_stride == 0. +In that case, "roundup_pow_of_two(hwq_attr->aux_stride)" gets called. +roundup_pow_of_two is documented as undefined for 0. + +Fix it in the one caller that had this combination. + +The undefined behavior was detected by UBSAN: + UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13 + shift exponent 64 is too large for 64-bit type 'long unsigned int' + CPU: 24 PID: 1075 Comm: (udev-worker) Not tainted 6.9.0-rc6+ #4 + Hardware name: Abacus electric, s.r.o. - servis@abacus.cz Super Server/H12SSW-iN, BIOS 2.7 10/25/2023 + Call Trace: + + dump_stack_lvl+0x5d/0x80 + ubsan_epilogue+0x5/0x30 + __ubsan_handle_shift_out_of_bounds.cold+0x61/0xec + __roundup_pow_of_two+0x25/0x35 [bnxt_re] + bnxt_qplib_alloc_init_hwq+0xa1/0x470 [bnxt_re] + bnxt_qplib_create_qp+0x19e/0x840 [bnxt_re] + bnxt_re_create_qp+0x9b1/0xcd0 [bnxt_re] + ? srso_alias_return_thunk+0x5/0xfbef5 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? __kmalloc+0x1b6/0x4f0 + ? create_qp.part.0+0x128/0x1c0 [ib_core] + ? __pfx_bnxt_re_create_qp+0x10/0x10 [bnxt_re] + create_qp.part.0+0x128/0x1c0 [ib_core] + ib_create_qp_kernel+0x50/0xd0 [ib_core] + create_mad_qp+0x8e/0xe0 [ib_core] + ? __pfx_qp_event_handler+0x10/0x10 [ib_core] + ib_mad_init_device+0x2be/0x680 [ib_core] + add_client_context+0x10d/0x1a0 [ib_core] + enable_device_and_get+0xe0/0x1d0 [ib_core] + ib_register_device+0x53c/0x630 [ib_core] + ? srso_alias_return_thunk+0x5/0xfbef5 + bnxt_re_probe+0xbd8/0xe50 [bnxt_re] + ? __pfx_bnxt_re_probe+0x10/0x10 [bnxt_re] + auxiliary_bus_probe+0x49/0x80 + ? driver_sysfs_add+0x57/0xc0 + really_probe+0xde/0x340 + ? pm_runtime_barrier+0x54/0x90 + ? __pfx___driver_attach+0x10/0x10 + __driver_probe_device+0x78/0x110 + driver_probe_device+0x1f/0xa0 + __driver_attach+0xba/0x1c0 + bus_for_each_dev+0x8f/0xe0 + bus_add_driver+0x146/0x220 + driver_register+0x72/0xd0 + __auxiliary_driver_register+0x6e/0xd0 + ? __pfx_bnxt_re_mod_init+0x10/0x10 [bnxt_re] + bnxt_re_mod_init+0x3e/0xff0 [bnxt_re] + ? __pfx_bnxt_re_mod_init+0x10/0x10 [bnxt_re] + do_one_initcall+0x5b/0x310 + do_init_module+0x90/0x250 + init_module_from_file+0x86/0xc0 + idempotent_init_module+0x121/0x2b0 + __x64_sys_finit_module+0x5e/0xb0 + do_syscall_64+0x82/0x160 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? syscall_exit_to_user_mode_prepare+0x149/0x170 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? syscall_exit_to_user_mode+0x75/0x230 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? do_syscall_64+0x8e/0x160 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? __count_memcg_events+0x69/0x100 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? count_memcg_events.constprop.0+0x1a/0x30 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? handle_mm_fault+0x1f0/0x300 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? do_user_addr_fault+0x34e/0x640 + ? srso_alias_return_thunk+0x5/0xfbef5 + ? srso_alias_return_thunk+0x5/0xfbef5 + entry_SYSCALL_64_after_hwframe+0x76/0x7e + RIP: 0033:0x7f4e5132821d + Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d e3 db 0c 00 f7 d8 64 89 01 48 + RSP: 002b:00007ffca9c906a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 + RAX: ffffffffffffffda RBX: 0000563ec8a8f130 RCX: 00007f4e5132821d + RDX: 0000000000000000 RSI: 00007f4e518fa07d RDI: 000000000000003b + RBP: 00007ffca9c90760 R08: 00007f4e513f6b20 R09: 00007ffca9c906f0 + R10: 0000563ec8a8faa0 R11: 0000000000000246 R12: 00007f4e518fa07d + R13: 0000000000020000 R14: 0000563ec8409e90 R15: 0000563ec8a8fa60 + + ---[ end trace ]--- + +Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation") +Signed-off-by: Michal Schmidt +Link: https://lore.kernel.org/r/20240507103929.30003-1-mschmidt@redhat.com +Acked-by: Selvin Xavier +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c +index 439d0c7c5d0ca..04258676d0726 100644 +--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c ++++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c +@@ -1013,7 +1013,8 @@ int bnxt_qplib_create_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp) + hwq_attr.stride = sizeof(struct sq_sge); + hwq_attr.depth = bnxt_qplib_get_depth(sq); + hwq_attr.aux_stride = psn_sz; +- hwq_attr.aux_depth = bnxt_qplib_set_sq_size(sq, qp->wqe_mode); ++ hwq_attr.aux_depth = psn_sz ? bnxt_qplib_set_sq_size(sq, qp->wqe_mode) ++ : 0; + /* Update msn tbl size */ + if (BNXT_RE_HW_RETX(qp->dev_cap_flags) && psn_sz) { + hwq_attr.aux_depth = roundup_pow_of_two(bnxt_qplib_set_sq_size(sq, qp->wqe_mode)); +-- +2.43.0 + diff --git a/queue-6.8/bpf-add-bpf_prog_type_cgroup_skb-attach-type-enforce.patch b/queue-6.8/bpf-add-bpf_prog_type_cgroup_skb-attach-type-enforce.patch new file mode 100644 index 00000000000..e5f6ec1210c --- /dev/null +++ b/queue-6.8/bpf-add-bpf_prog_type_cgroup_skb-attach-type-enforce.patch @@ -0,0 +1,50 @@ +From 9d7a4243945e9c7c3fec23acbeda079319d2e650 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 16:16:18 -0700 +Subject: bpf: Add BPF_PROG_TYPE_CGROUP_SKB attach type enforcement in + BPF_LINK_CREATE + +From: Stanislav Fomichev + +[ Upstream commit 543576ec15b17c0c93301ac8297333c7b6e84ac7 ] + +bpf_prog_attach uses attach_type_to_prog_type to enforce proper +attach type for BPF_PROG_TYPE_CGROUP_SKB. link_create uses +bpf_prog_get and relies on bpf_prog_attach_check_attach_type +to properly verify prog_type <> attach_type association. + +Add missing attach_type enforcement for the link_create case. +Otherwise, it's currently possible to attach cgroup_skb prog +types to other cgroup hooks. + +Fixes: af6eea57437a ("bpf: Implement bpf_link-based cgroup BPF program attachment") +Link: https://lore.kernel.org/bpf/0000000000004792a90615a1dde0@google.com/ +Reported-by: syzbot+838346b979830606c854@syzkaller.appspotmail.com +Signed-off-by: Stanislav Fomichev +Acked-by: Eduard Zingerman +Link: https://lore.kernel.org/r/20240426231621.2716876-2-sdf@google.com +Signed-off-by: Martin KaFai Lau +Signed-off-by: Sasha Levin +--- + kernel/bpf/syscall.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c +index 0f90b6b27430d..1860ba343726d 100644 +--- a/kernel/bpf/syscall.c ++++ b/kernel/bpf/syscall.c +@@ -3852,6 +3852,11 @@ static int bpf_prog_attach_check_attach_type(const struct bpf_prog *prog, + * check permissions at attach time. + */ + return -EPERM; ++ ++ ptype = attach_type_to_prog_type(attach_type); ++ if (prog->type != ptype) ++ return -EINVAL; ++ + return prog->enforce_expected_attach_type && + prog->expected_attach_type != attach_type ? + -EINVAL : 0; +-- +2.43.0 + diff --git a/queue-6.8/bpf-fix-verifier-assumptions-about-socket-sk.patch b/queue-6.8/bpf-fix-verifier-assumptions-about-socket-sk.patch new file mode 100644 index 00000000000..b330f8c8c13 --- /dev/null +++ b/queue-6.8/bpf-fix-verifier-assumptions-about-socket-sk.patch @@ -0,0 +1,220 @@ +From 9bc63519164743eb5f4582f93166731827a9149f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 17:25:44 -0700 +Subject: bpf: Fix verifier assumptions about socket->sk + +From: Alexei Starovoitov + +[ Upstream commit 0db63c0b86e981a1e97d2596d64ceceba1a5470e ] + +The verifier assumes that 'sk' field in 'struct socket' is valid +and non-NULL when 'socket' pointer itself is trusted and non-NULL. +That may not be the case when socket was just created and +passed to LSM socket_accept hook. +Fix this verifier assumption and adjust tests. + +Reported-by: Liam Wisehart +Acked-by: Kumar Kartikeya Dwivedi +Fixes: 6fcd486b3a0a ("bpf: Refactor RCU enforcement in the verifier.") +Signed-off-by: Alexei Starovoitov +Link: https://lore.kernel.org/r/20240427002544.68803-1-alexei.starovoitov@gmail.com +Signed-off-by: Martin KaFai Lau +Signed-off-by: Sasha Levin +--- + kernel/bpf/verifier.c | 23 +++++++++++++++---- + .../bpf/progs/bench_local_storage_create.c | 5 ++-- + .../selftests/bpf/progs/local_storage.c | 20 ++++++++-------- + .../testing/selftests/bpf/progs/lsm_cgroup.c | 8 +++++-- + 4 files changed, 38 insertions(+), 18 deletions(-) + +diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c +index 68ec508057466..6edfcc3375082 100644 +--- a/kernel/bpf/verifier.c ++++ b/kernel/bpf/verifier.c +@@ -2328,6 +2328,8 @@ static void mark_btf_ld_reg(struct bpf_verifier_env *env, + regs[regno].type = PTR_TO_BTF_ID | flag; + regs[regno].btf = btf; + regs[regno].btf_id = btf_id; ++ if (type_may_be_null(flag)) ++ regs[regno].id = ++env->id_gen; + } + + #define DEF_NOT_SUBREG (0) +@@ -5322,8 +5324,6 @@ static int check_map_kptr_access(struct bpf_verifier_env *env, u32 regno, + */ + mark_btf_ld_reg(env, cur_regs(env), value_regno, PTR_TO_BTF_ID, kptr_field->kptr.btf, + kptr_field->kptr.btf_id, btf_ld_kptr_type(env, kptr_field)); +- /* For mark_ptr_or_null_reg */ +- val_reg->id = ++env->id_gen; + } else if (class == BPF_STX) { + val_reg = reg_state(env, value_regno); + if (!register_is_null(val_reg) && +@@ -5634,7 +5634,8 @@ static bool is_trusted_reg(const struct bpf_reg_state *reg) + return true; + + /* Types listed in the reg2btf_ids are always trusted */ +- if (reg2btf_ids[base_type(reg->type)]) ++ if (reg2btf_ids[base_type(reg->type)] && ++ !bpf_type_has_unsafe_modifiers(reg->type)) + return true; + + /* If a register is not referenced, it is trusted if it has the +@@ -6244,6 +6245,7 @@ static int bpf_map_direct_read(struct bpf_map *map, int off, int size, u64 *val, + #define BTF_TYPE_SAFE_RCU(__type) __PASTE(__type, __safe_rcu) + #define BTF_TYPE_SAFE_RCU_OR_NULL(__type) __PASTE(__type, __safe_rcu_or_null) + #define BTF_TYPE_SAFE_TRUSTED(__type) __PASTE(__type, __safe_trusted) ++#define BTF_TYPE_SAFE_TRUSTED_OR_NULL(__type) __PASTE(__type, __safe_trusted_or_null) + + /* + * Allow list few fields as RCU trusted or full trusted. +@@ -6307,7 +6309,7 @@ BTF_TYPE_SAFE_TRUSTED(struct dentry) { + struct inode *d_inode; + }; + +-BTF_TYPE_SAFE_TRUSTED(struct socket) { ++BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct socket) { + struct sock *sk; + }; + +@@ -6342,11 +6344,20 @@ static bool type_is_trusted(struct bpf_verifier_env *env, + BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED(struct linux_binprm)); + BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED(struct file)); + BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED(struct dentry)); +- BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED(struct socket)); + + return btf_nested_type_is_trusted(&env->log, reg, field_name, btf_id, "__safe_trusted"); + } + ++static bool type_is_trusted_or_null(struct bpf_verifier_env *env, ++ struct bpf_reg_state *reg, ++ const char *field_name, u32 btf_id) ++{ ++ BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct socket)); ++ ++ return btf_nested_type_is_trusted(&env->log, reg, field_name, btf_id, ++ "__safe_trusted_or_null"); ++} ++ + static int check_ptr_to_btf_access(struct bpf_verifier_env *env, + struct bpf_reg_state *regs, + int regno, int off, int size, +@@ -6455,6 +6466,8 @@ static int check_ptr_to_btf_access(struct bpf_verifier_env *env, + */ + if (type_is_trusted(env, reg, field_name, btf_id)) { + flag |= PTR_TRUSTED; ++ } else if (type_is_trusted_or_null(env, reg, field_name, btf_id)) { ++ flag |= PTR_TRUSTED | PTR_MAYBE_NULL; + } else if (in_rcu_cs(env) && !type_may_be_null(reg->type)) { + if (type_is_rcu(env, reg, field_name, btf_id)) { + /* ignore __rcu tag and mark it MEM_RCU */ +diff --git a/tools/testing/selftests/bpf/progs/bench_local_storage_create.c b/tools/testing/selftests/bpf/progs/bench_local_storage_create.c +index e4bfbba6c1936..c8ec0d0368e4a 100644 +--- a/tools/testing/selftests/bpf/progs/bench_local_storage_create.c ++++ b/tools/testing/selftests/bpf/progs/bench_local_storage_create.c +@@ -61,14 +61,15 @@ SEC("lsm.s/socket_post_create") + int BPF_PROG(socket_post_create, struct socket *sock, int family, int type, + int protocol, int kern) + { ++ struct sock *sk = sock->sk; + struct storage *stg; + __u32 pid; + + pid = bpf_get_current_pid_tgid() >> 32; +- if (pid != bench_pid) ++ if (pid != bench_pid || !sk) + return 0; + +- stg = bpf_sk_storage_get(&sk_storage_map, sock->sk, NULL, ++ stg = bpf_sk_storage_get(&sk_storage_map, sk, NULL, + BPF_LOCAL_STORAGE_GET_F_CREATE); + + if (stg) +diff --git a/tools/testing/selftests/bpf/progs/local_storage.c b/tools/testing/selftests/bpf/progs/local_storage.c +index e5e3a8b8dd075..637e75df2e146 100644 +--- a/tools/testing/selftests/bpf/progs/local_storage.c ++++ b/tools/testing/selftests/bpf/progs/local_storage.c +@@ -140,11 +140,12 @@ int BPF_PROG(socket_bind, struct socket *sock, struct sockaddr *address, + { + __u32 pid = bpf_get_current_pid_tgid() >> 32; + struct local_storage *storage; ++ struct sock *sk = sock->sk; + +- if (pid != monitored_pid) ++ if (pid != monitored_pid || !sk) + return 0; + +- storage = bpf_sk_storage_get(&sk_storage_map, sock->sk, 0, 0); ++ storage = bpf_sk_storage_get(&sk_storage_map, sk, 0, 0); + if (!storage) + return 0; + +@@ -155,24 +156,24 @@ int BPF_PROG(socket_bind, struct socket *sock, struct sockaddr *address, + /* This tests that we can associate multiple elements + * with the local storage. + */ +- storage = bpf_sk_storage_get(&sk_storage_map2, sock->sk, 0, ++ storage = bpf_sk_storage_get(&sk_storage_map2, sk, 0, + BPF_LOCAL_STORAGE_GET_F_CREATE); + if (!storage) + return 0; + +- if (bpf_sk_storage_delete(&sk_storage_map2, sock->sk)) ++ if (bpf_sk_storage_delete(&sk_storage_map2, sk)) + return 0; + +- storage = bpf_sk_storage_get(&sk_storage_map2, sock->sk, 0, ++ storage = bpf_sk_storage_get(&sk_storage_map2, sk, 0, + BPF_LOCAL_STORAGE_GET_F_CREATE); + if (!storage) + return 0; + +- if (bpf_sk_storage_delete(&sk_storage_map, sock->sk)) ++ if (bpf_sk_storage_delete(&sk_storage_map, sk)) + return 0; + + /* Ensure that the sk_storage_map is disconnected from the storage. */ +- if (!sock->sk->sk_bpf_storage || sock->sk->sk_bpf_storage->smap) ++ if (!sk->sk_bpf_storage || sk->sk_bpf_storage->smap) + return 0; + + sk_storage_result = 0; +@@ -185,11 +186,12 @@ int BPF_PROG(socket_post_create, struct socket *sock, int family, int type, + { + __u32 pid = bpf_get_current_pid_tgid() >> 32; + struct local_storage *storage; ++ struct sock *sk = sock->sk; + +- if (pid != monitored_pid) ++ if (pid != monitored_pid || !sk) + return 0; + +- storage = bpf_sk_storage_get(&sk_storage_map, sock->sk, 0, ++ storage = bpf_sk_storage_get(&sk_storage_map, sk, 0, + BPF_LOCAL_STORAGE_GET_F_CREATE); + if (!storage) + return 0; +diff --git a/tools/testing/selftests/bpf/progs/lsm_cgroup.c b/tools/testing/selftests/bpf/progs/lsm_cgroup.c +index 02c11d16b692a..d7598538aa2da 100644 +--- a/tools/testing/selftests/bpf/progs/lsm_cgroup.c ++++ b/tools/testing/selftests/bpf/progs/lsm_cgroup.c +@@ -103,11 +103,15 @@ static __always_inline int real_bind(struct socket *sock, + int addrlen) + { + struct sockaddr_ll sa = {}; ++ struct sock *sk = sock->sk; + +- if (sock->sk->__sk_common.skc_family != AF_PACKET) ++ if (!sk) ++ return 1; ++ ++ if (sk->__sk_common.skc_family != AF_PACKET) + return 1; + +- if (sock->sk->sk_kern_sock) ++ if (sk->sk_kern_sock) + return 1; + + bpf_probe_read_kernel(&sa, sizeof(sa), address); +-- +2.43.0 + diff --git a/queue-6.8/bpf-pack-struct-bpf_fib_lookup.patch b/queue-6.8/bpf-pack-struct-bpf_fib_lookup.patch new file mode 100644 index 00000000000..a1673debab2 --- /dev/null +++ b/queue-6.8/bpf-pack-struct-bpf_fib_lookup.patch @@ -0,0 +1,74 @@ +From 494586d006e4bcefa1935504ee6f3ecdec570c2b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 14:33:03 +0200 +Subject: bpf: Pack struct bpf_fib_lookup + +From: Anton Protopopov + +[ Upstream commit f91717007217d975aa975ddabd91ae1a107b9bff ] + +The struct bpf_fib_lookup is supposed to be of size 64. A recent commit +59b418c7063d ("bpf: Add a check for struct bpf_fib_lookup size") added +a static assertion to check this property so that future changes to the +structure will not accidentally break this assumption. + +As it immediately turned out, on some 32-bit arm systems, when AEABI=n, +the total size of the structure was equal to 68, see [1]. This happened +because the bpf_fib_lookup structure contains a union of two 16-bit +fields: + + union { + __u16 tot_len; + __u16 mtu_result; + }; + +which was supposed to compile to a 16-bit-aligned 16-bit field. On the +aforementioned setups it was instead both aligned and padded to 32-bits. + +Declare this inner union as __attribute__((packed, aligned(2))) such +that it always is of size 2 and is aligned to 16 bits. + + [1] https://lore.kernel.org/all/CA+G9fYtsoP51f-oP_Sp5MOq-Ffv8La2RztNpwvE6+R1VtFiLrw@mail.gmail.com/#t + +Reported-by: Naresh Kamboju +Fixes: e1850ea9bd9e ("bpf: bpf_fib_lookup return MTU value as output when looked up") +Signed-off-by: Anton Protopopov +Signed-off-by: Andrii Nakryiko +Reviewed-by: Alexander Lobakin +Acked-by: Daniel Borkmann +Link: https://lore.kernel.org/bpf/20240403123303.1452184-1-aspsk@isovalent.com +Signed-off-by: Sasha Levin +--- + include/uapi/linux/bpf.h | 2 +- + tools/include/uapi/linux/bpf.h | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h +index 754e68ca8744c..83f31916e2635 100644 +--- a/include/uapi/linux/bpf.h ++++ b/include/uapi/linux/bpf.h +@@ -7040,7 +7040,7 @@ struct bpf_fib_lookup { + + /* output: MTU value */ + __u16 mtu_result; +- }; ++ } __attribute__((packed, aligned(2))); + /* input: L3 device index for lookup + * output: device index from FIB lookup + */ +diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h +index 7f24d898efbb4..a12f597a1c47f 100644 +--- a/tools/include/uapi/linux/bpf.h ++++ b/tools/include/uapi/linux/bpf.h +@@ -7039,7 +7039,7 @@ struct bpf_fib_lookup { + + /* output: MTU value */ + __u16 mtu_result; +- }; ++ } __attribute__((packed, aligned(2))); + /* input: L3 device index for lookup + * output: device index from FIB lookup + */ +-- +2.43.0 + diff --git a/queue-6.8/bpf-prevent-r10-register-from-being-marked-as-precis.patch b/queue-6.8/bpf-prevent-r10-register-from-being-marked-as-precis.patch new file mode 100644 index 00000000000..10b4e3e4a32 --- /dev/null +++ b/queue-6.8/bpf-prevent-r10-register-from-being-marked-as-precis.patch @@ -0,0 +1,58 @@ +From 1e0d726a089d6dad3642dc5661115280f216f0cb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 4 Apr 2024 14:45:35 -0700 +Subject: bpf: prevent r10 register from being marked as precise + +From: Andrii Nakryiko + +[ Upstream commit 1f2a74b41ea8b902687eb97c4e7e3f558801865b ] + +r10 is a special register that is not under BPF program's control and is +always effectively precise. The rest of precision logic assumes that +only r0-r9 SCALAR registers are marked as precise, so prevent r10 from +being marked precise. + +This can happen due to signed cast instruction allowing to do something +like `r0 = (s8)r10;`, which later, if r0 needs to be precise, would lead +to an attempt to mark r10 as precise. + +Prevent this with an extra check during instruction backtracking. + +Fixes: 8100928c8814 ("bpf: Support new sign-extension mov insns") +Reported-by: syzbot+148110ee7cf72f39f33e@syzkaller.appspotmail.com +Signed-off-by: Andrii Nakryiko +Acked-by: Yonghong Song +Link: https://lore.kernel.org/r/20240404214536.3551295-1-andrii@kernel.org +Signed-off-by: Alexei Starovoitov +Signed-off-by: Sasha Levin +--- + kernel/bpf/verifier.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c +index 11bc3af33f34f..68ec508057466 100644 +--- a/kernel/bpf/verifier.c ++++ b/kernel/bpf/verifier.c +@@ -3584,7 +3584,8 @@ static int backtrack_insn(struct bpf_verifier_env *env, int idx, int subseq_idx, + * sreg needs precision before this insn + */ + bt_clear_reg(bt, dreg); +- bt_set_reg(bt, sreg); ++ if (sreg != BPF_REG_FP) ++ bt_set_reg(bt, sreg); + } else { + /* dreg = K + * dreg needs precision after this insn. +@@ -3600,7 +3601,8 @@ static int backtrack_insn(struct bpf_verifier_env *env, int idx, int subseq_idx, + * both dreg and sreg need precision + * before this insn + */ +- bt_set_reg(bt, sreg); ++ if (sreg != BPF_REG_FP) ++ bt_set_reg(bt, sreg); + } /* else dreg += K + * dreg still needs precision before this insn + */ +-- +2.43.0 + diff --git a/queue-6.8/bpf-x86-fix-probe_mem-runtime-load-check.patch b/queue-6.8/bpf-x86-fix-probe_mem-runtime-load-check.patch new file mode 100644 index 00000000000..71a83d1830a --- /dev/null +++ b/queue-6.8/bpf-x86-fix-probe_mem-runtime-load-check.patch @@ -0,0 +1,166 @@ +From ace23d39074bca1359874d5cebb459e6846766a6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 10:02:09 +0000 +Subject: bpf, x86: Fix PROBE_MEM runtime load check + +From: Puranjay Mohan + +[ Upstream commit b599d7d26d6ad1fc9975218574bc2ca6d0293cfd ] + +When a load is marked PROBE_MEM - e.g. due to PTR_UNTRUSTED access - the +address being loaded from is not necessarily valid. The BPF jit sets up +exception handlers for each such load which catch page faults and 0 out +the destination register. + +If the address for the load is outside kernel address space, the load +will escape the exception handling and crash the kernel. To prevent this +from happening, the emits some instruction to verify that addr is > end +of userspace addresses. + +x86 has a legacy vsyscall ABI where a page at address 0xffffffffff600000 +is mapped with user accessible permissions. The addresses in this page +are considered userspace addresses by the fault handler. Therefore, a +BPF program accessing this page will crash the kernel. + +This patch fixes the runtime checks to also check that the PROBE_MEM +address is below VSYSCALL_ADDR. + +Example BPF program: + + SEC("fentry/tcp_v4_connect") + int BPF_PROG(fentry_tcp_v4_connect, struct sock *sk) + { + *(volatile unsigned long *)&sk->sk_tsq_flags; + return 0; + } + +BPF Assembly: + + 0: (79) r1 = *(u64 *)(r1 +0) + 1: (79) r1 = *(u64 *)(r1 +344) + 2: (b7) r0 = 0 + 3: (95) exit + + x86-64 JIT + ========== + + BEFORE AFTER + ------ ----- + + 0: nopl 0x0(%rax,%rax,1) 0: nopl 0x0(%rax,%rax,1) + 5: xchg %ax,%ax 5: xchg %ax,%ax + 7: push %rbp 7: push %rbp + 8: mov %rsp,%rbp 8: mov %rsp,%rbp + b: mov 0x0(%rdi),%rdi b: mov 0x0(%rdi),%rdi +------------------------------------------------------------------------------- + f: movabs $0x100000000000000,%r11 f: movabs $0xffffffffff600000,%r10 +19: add $0x2a0,%rdi 19: mov %rdi,%r11 +20: cmp %r11,%rdi 1c: add $0x2a0,%r11 +23: jae 0x0000000000000029 23: sub %r10,%r11 +25: xor %edi,%edi 26: movabs $0x100000000a00000,%r10 +27: jmp 0x000000000000002d 30: cmp %r10,%r11 +29: mov 0x0(%rdi),%rdi 33: ja 0x0000000000000039 +--------------------------------\ 35: xor %edi,%edi +2d: xor %eax,%eax \ 37: jmp 0x0000000000000040 +2f: leave \ 39: mov 0x2a0(%rdi),%rdi +30: ret \-------------------------------------------- + 40: xor %eax,%eax + 42: leave + 43: ret + +Signed-off-by: Puranjay Mohan +Link: https://lore.kernel.org/r/20240424100210.11982-3-puranjay@kernel.org +Signed-off-by: Alexei Starovoitov +Signed-off-by: Sasha Levin +--- + arch/x86/net/bpf_jit_comp.c | 57 ++++++++++++++++--------------------- + 1 file changed, 25 insertions(+), 32 deletions(-) + +diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c +index df484885ccd4a..f415c2cf53582 100644 +--- a/arch/x86/net/bpf_jit_comp.c ++++ b/arch/x86/net/bpf_jit_comp.c +@@ -1585,36 +1585,41 @@ st: if (is_imm8(insn->off)) + if (BPF_MODE(insn->code) == BPF_PROBE_MEM || + BPF_MODE(insn->code) == BPF_PROBE_MEMSX) { + /* Conservatively check that src_reg + insn->off is a kernel address: +- * src_reg + insn->off >= TASK_SIZE_MAX + PAGE_SIZE +- * src_reg is used as scratch for src_reg += insn->off and restored +- * after emit_ldx if necessary ++ * src_reg + insn->off > TASK_SIZE_MAX + PAGE_SIZE ++ * and ++ * src_reg + insn->off < VSYSCALL_ADDR + */ + +- u64 limit = TASK_SIZE_MAX + PAGE_SIZE; ++ u64 limit = TASK_SIZE_MAX + PAGE_SIZE - VSYSCALL_ADDR; + u8 *end_of_jmp; + +- /* At end of these emitted checks, insn->off will have been added +- * to src_reg, so no need to do relative load with insn->off offset +- */ +- insn_off = 0; ++ /* movabsq r10, VSYSCALL_ADDR */ ++ emit_mov_imm64(&prog, BPF_REG_AX, (long)VSYSCALL_ADDR >> 32, ++ (u32)(long)VSYSCALL_ADDR); + +- /* movabsq r11, limit */ +- EMIT2(add_1mod(0x48, AUX_REG), add_1reg(0xB8, AUX_REG)); +- EMIT((u32)limit, 4); +- EMIT(limit >> 32, 4); ++ /* mov src_reg, r11 */ ++ EMIT_mov(AUX_REG, src_reg); + + if (insn->off) { +- /* add src_reg, insn->off */ +- maybe_emit_1mod(&prog, src_reg, true); +- EMIT2_off32(0x81, add_1reg(0xC0, src_reg), insn->off); ++ /* add r11, insn->off */ ++ maybe_emit_1mod(&prog, AUX_REG, true); ++ EMIT2_off32(0x81, add_1reg(0xC0, AUX_REG), insn->off); + } + +- /* cmp src_reg, r11 */ +- maybe_emit_mod(&prog, src_reg, AUX_REG, true); +- EMIT2(0x39, add_2reg(0xC0, src_reg, AUX_REG)); ++ /* sub r11, r10 */ ++ maybe_emit_mod(&prog, AUX_REG, BPF_REG_AX, true); ++ EMIT2(0x29, add_2reg(0xC0, AUX_REG, BPF_REG_AX)); ++ ++ /* movabsq r10, limit */ ++ emit_mov_imm64(&prog, BPF_REG_AX, (long)limit >> 32, ++ (u32)(long)limit); ++ ++ /* cmp r10, r11 */ ++ maybe_emit_mod(&prog, AUX_REG, BPF_REG_AX, true); ++ EMIT2(0x39, add_2reg(0xC0, AUX_REG, BPF_REG_AX)); + +- /* if unsigned '>=', goto load */ +- EMIT2(X86_JAE, 0); ++ /* if unsigned '>', goto load */ ++ EMIT2(X86_JA, 0); + end_of_jmp = prog; + + /* xor dst_reg, dst_reg */ +@@ -1640,18 +1645,6 @@ st: if (is_imm8(insn->off)) + /* populate jmp_offset for JMP above */ + start_of_ldx[-1] = prog - start_of_ldx; + +- if (insn->off && src_reg != dst_reg) { +- /* sub src_reg, insn->off +- * Restore src_reg after "add src_reg, insn->off" in prev +- * if statement. But if src_reg == dst_reg, emit_ldx +- * above already clobbered src_reg, so no need to restore. +- * If add src_reg, insn->off was unnecessary, no need to +- * restore either. +- */ +- maybe_emit_1mod(&prog, src_reg, true); +- EMIT2_off32(0x81, add_1reg(0xE8, src_reg), insn->off); +- } +- + if (!bpf_prog->aux->extable) + break; + +-- +2.43.0 + diff --git a/queue-6.8/bpftool-fix-missing-pids-during-link-show.patch b/queue-6.8/bpftool-fix-missing-pids-during-link-show.patch new file mode 100644 index 00000000000..686f5c8ecd1 --- /dev/null +++ b/queue-6.8/bpftool-fix-missing-pids-during-link-show.patch @@ -0,0 +1,89 @@ +From 746b457a60fe264b40d0159057758f376947e969 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 11 Mar 2024 19:32:49 -0700 +Subject: bpftool: Fix missing pids during link show + +From: Yonghong Song + +[ Upstream commit fe879bb42f8a6513ed18e9d22efb99cb35590201 ] + +Current 'bpftool link' command does not show pids, e.g., + $ tools/build/bpftool/bpftool link + ... + 4: tracing prog 23 + prog_type lsm attach_type lsm_mac + target_obj_id 1 target_btf_id 31320 + +Hack the following change to enable normal libbpf debug output, + --- a/tools/bpf/bpftool/pids.c + +++ b/tools/bpf/bpftool/pids.c + @@ -121,9 +121,9 @@ int build_obj_refs_table(struct hashmap **map, enum bpf_obj_type type) + /* we don't want output polluted with libbpf errors if bpf_iter is not + * supported + */ + - default_print = libbpf_set_print(libbpf_print_none); + + /* default_print = libbpf_set_print(libbpf_print_none); */ + err = pid_iter_bpf__load(skel); + - libbpf_set_print(default_print); + + /* libbpf_set_print(default_print); */ + +Rerun the above bpftool command: + $ tools/build/bpftool/bpftool link + libbpf: prog 'iter': BPF program load failed: Permission denied + libbpf: prog 'iter': -- BEGIN PROG LOAD LOG -- + 0: R1=ctx() R10=fp0 + ; struct task_struct *task = ctx->task; @ pid_iter.bpf.c:69 + 0: (79) r6 = *(u64 *)(r1 +8) ; R1=ctx() R6_w=ptr_or_null_task_struct(id=1) + ; struct file *file = ctx->file; @ pid_iter.bpf.c:68 + ... + ; struct bpf_link *link = (struct bpf_link *) file->private_data; @ pid_iter.bpf.c:103 + 80: (79) r3 = *(u64 *)(r8 +432) ; R3_w=scalar() R8=ptr_file() + ; if (link->type == bpf_core_enum_value(enum bpf_link_type___local, @ pid_iter.bpf.c:105 + 81: (61) r1 = *(u32 *)(r3 +12) + R3 invalid mem access 'scalar' + processed 39 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 2 + -- END PROG LOAD LOG -- + libbpf: prog 'iter': failed to load: -13 + ... + +The 'file->private_data' returns a 'void' type and this caused subsequent 'link->type' +(insn #81) failed in verification. + +To fix the issue, restore the previous BPF_CORE_READ so old kernels can also work. +With this patch, the 'bpftool link' runs successfully with 'pids'. + $ tools/build/bpftool/bpftool link + ... + 4: tracing prog 23 + prog_type lsm attach_type lsm_mac + target_obj_id 1 target_btf_id 31320 + pids systemd(1) + +Fixes: 44ba7b30e84f ("bpftool: Use a local copy of BPF_LINK_TYPE_PERF_EVENT in pid_iter.bpf.c") +Signed-off-by: Yonghong Song +Signed-off-by: Andrii Nakryiko +Tested-by: Quentin Monnet +Reviewed-by: Quentin Monnet +Link: https://lore.kernel.org/bpf/20240312023249.3776718-1-yonghong.song@linux.dev +Signed-off-by: Sasha Levin +--- + tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/bpf/bpftool/skeleton/pid_iter.bpf.c b/tools/bpf/bpftool/skeleton/pid_iter.bpf.c +index 26004f0c5a6ae..7bdbcac3cf628 100644 +--- a/tools/bpf/bpftool/skeleton/pid_iter.bpf.c ++++ b/tools/bpf/bpftool/skeleton/pid_iter.bpf.c +@@ -102,8 +102,8 @@ int iter(struct bpf_iter__task_file *ctx) + BPF_LINK_TYPE_PERF_EVENT___local)) { + struct bpf_link *link = (struct bpf_link *) file->private_data; + +- if (link->type == bpf_core_enum_value(enum bpf_link_type___local, +- BPF_LINK_TYPE_PERF_EVENT___local)) { ++ if (BPF_CORE_READ(link, type) == bpf_core_enum_value(enum bpf_link_type___local, ++ BPF_LINK_TYPE_PERF_EVENT___local)) { + e.has_bpf_cookie = true; + e.bpf_cookie = get_bpf_cookie(link); + } +-- +2.43.0 + diff --git a/queue-6.8/bpftool-mount-bpffs-on-provided-dir-instead-of-paren.patch b/queue-6.8/bpftool-mount-bpffs-on-provided-dir-instead-of-paren.patch new file mode 100644 index 00000000000..f85228f3bc4 --- /dev/null +++ b/queue-6.8/bpftool-mount-bpffs-on-provided-dir-instead-of-paren.patch @@ -0,0 +1,264 @@ +From 2c45f62e14de72c6d26b95d0a1f575a54e93d174 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 00:52:19 +0530 +Subject: bpftool: Mount bpffs on provided dir instead of parent dir + +From: Sahil Siddiq + +[ Upstream commit 478a535ae54ad3831371904d93b5dfc403222e17 ] + +When pinning programs/objects under PATH (eg: during "bpftool prog +loadall") the bpffs is mounted on the parent dir of PATH in the +following situations: +- the given dir exists but it is not bpffs. +- the given dir doesn't exist and the parent dir is not bpffs. + +Mounting on the parent dir can also have the unintentional side- +effect of hiding other files located under the parent dir. + +If the given dir exists but is not bpffs, then the bpffs should +be mounted on the given dir and not its parent dir. + +Similarly, if the given dir doesn't exist and its parent dir is not +bpffs, then the given dir should be created and the bpffs should be +mounted on this new dir. + +Fixes: 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog loadall") +Signed-off-by: Sahil Siddiq +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/2da44d24-74ae-a564-1764-afccf395eeec@isovalent.com/T/#t +Link: https://lore.kernel.org/bpf/20240404192219.52373-1-icegambit91@gmail.com + +Closes: https://github.com/libbpf/bpftool/issues/100 + +Changes since v1: + - Split "mount_bpffs_for_pin" into two functions. + This is done to improve maintainability and readability. + +Changes since v2: +- mount_bpffs_for_pin: rename to "create_and_mount_bpffs_dir". +- mount_bpffs_given_file: rename to "mount_bpffs_given_file". +- create_and_mount_bpffs_dir: + - introduce "dir_exists" boolean. + - remove new dir if "mnt_fs" fails. +- improve error handling and error messages. + +Changes since v3: +- Rectify function name. +- Improve error messages and formatting. +- mount_bpffs_for_file: + - Check if dir exists before block_mount check. + +Changes since v4: +- Use strdup instead of strcpy. +- create_and_mount_bpffs_dir: + - Use S_IRWXU instead of 0700. +- Improve error handling and formatting. + +Signed-off-by: Sasha Levin +--- + tools/bpf/bpftool/common.c | 96 +++++++++++++++++++++++++++++----- + tools/bpf/bpftool/iter.c | 2 +- + tools/bpf/bpftool/main.h | 3 +- + tools/bpf/bpftool/prog.c | 5 +- + tools/bpf/bpftool/struct_ops.c | 2 +- + 5 files changed, 92 insertions(+), 16 deletions(-) + +diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c +index cc6e6aae2447d..958e92acca8e2 100644 +--- a/tools/bpf/bpftool/common.c ++++ b/tools/bpf/bpftool/common.c +@@ -244,29 +244,101 @@ int open_obj_pinned_any(const char *path, enum bpf_obj_type exp_type) + return fd; + } + +-int mount_bpffs_for_pin(const char *name, bool is_dir) ++int create_and_mount_bpffs_dir(const char *dir_name) + { + char err_str[ERR_MAX_LEN]; +- char *file; +- char *dir; ++ bool dir_exists; + int err = 0; + +- if (is_dir && is_bpffs(name)) ++ if (is_bpffs(dir_name)) + return err; + +- file = malloc(strlen(name) + 1); +- if (!file) { ++ dir_exists = access(dir_name, F_OK) == 0; ++ ++ if (!dir_exists) { ++ char *temp_name; ++ char *parent_name; ++ ++ temp_name = strdup(dir_name); ++ if (!temp_name) { ++ p_err("mem alloc failed"); ++ return -1; ++ } ++ ++ parent_name = dirname(temp_name); ++ ++ if (is_bpffs(parent_name)) { ++ /* nothing to do if already mounted */ ++ free(temp_name); ++ return err; ++ } ++ ++ if (access(parent_name, F_OK) == -1) { ++ p_err("can't create dir '%s' to pin BPF object: parent dir '%s' doesn't exist", ++ dir_name, parent_name); ++ free(temp_name); ++ return -1; ++ } ++ ++ free(temp_name); ++ } ++ ++ if (block_mount) { ++ p_err("no BPF file system found, not mounting it due to --nomount option"); ++ return -1; ++ } ++ ++ if (!dir_exists) { ++ err = mkdir(dir_name, S_IRWXU); ++ if (err) { ++ p_err("failed to create dir '%s': %s", dir_name, strerror(errno)); ++ return err; ++ } ++ } ++ ++ err = mnt_fs(dir_name, "bpf", err_str, ERR_MAX_LEN); ++ if (err) { ++ err_str[ERR_MAX_LEN - 1] = '\0'; ++ p_err("can't mount BPF file system on given dir '%s': %s", ++ dir_name, err_str); ++ ++ if (!dir_exists) ++ rmdir(dir_name); ++ } ++ ++ return err; ++} ++ ++int mount_bpffs_for_file(const char *file_name) ++{ ++ char err_str[ERR_MAX_LEN]; ++ char *temp_name; ++ char *dir; ++ int err = 0; ++ ++ if (access(file_name, F_OK) != -1) { ++ p_err("can't pin BPF object: path '%s' already exists", file_name); ++ return -1; ++ } ++ ++ temp_name = strdup(file_name); ++ if (!temp_name) { + p_err("mem alloc failed"); + return -1; + } + +- strcpy(file, name); +- dir = dirname(file); ++ dir = dirname(temp_name); + + if (is_bpffs(dir)) + /* nothing to do if already mounted */ + goto out_free; + ++ if (access(dir, F_OK) == -1) { ++ p_err("can't pin BPF object: dir '%s' doesn't exist", dir); ++ err = -1; ++ goto out_free; ++ } ++ + if (block_mount) { + p_err("no BPF file system found, not mounting it due to --nomount option"); + err = -1; +@@ -276,12 +348,12 @@ int mount_bpffs_for_pin(const char *name, bool is_dir) + err = mnt_fs(dir, "bpf", err_str, ERR_MAX_LEN); + if (err) { + err_str[ERR_MAX_LEN - 1] = '\0'; +- p_err("can't mount BPF file system to pin the object (%s): %s", +- name, err_str); ++ p_err("can't mount BPF file system to pin the object '%s': %s", ++ file_name, err_str); + } + + out_free: +- free(file); ++ free(temp_name); + return err; + } + +@@ -289,7 +361,7 @@ int do_pin_fd(int fd, const char *name) + { + int err; + +- err = mount_bpffs_for_pin(name, false); ++ err = mount_bpffs_for_file(name); + if (err) + return err; + +diff --git a/tools/bpf/bpftool/iter.c b/tools/bpf/bpftool/iter.c +index 6b0e5202ca7a9..5c39c2ed36a2b 100644 +--- a/tools/bpf/bpftool/iter.c ++++ b/tools/bpf/bpftool/iter.c +@@ -76,7 +76,7 @@ static int do_pin(int argc, char **argv) + goto close_obj; + } + +- err = mount_bpffs_for_pin(path, false); ++ err = mount_bpffs_for_file(path); + if (err) + goto close_link; + +diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h +index b8bb08d10dec9..9eb764fe4cc8b 100644 +--- a/tools/bpf/bpftool/main.h ++++ b/tools/bpf/bpftool/main.h +@@ -142,7 +142,8 @@ const char *get_fd_type_name(enum bpf_obj_type type); + char *get_fdinfo(int fd, const char *key); + int open_obj_pinned(const char *path, bool quiet); + int open_obj_pinned_any(const char *path, enum bpf_obj_type exp_type); +-int mount_bpffs_for_pin(const char *name, bool is_dir); ++int mount_bpffs_for_file(const char *file_name); ++int create_and_mount_bpffs_dir(const char *dir_name); + int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(int *, char ***)); + int do_pin_fd(int fd, const char *name); + +diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c +index 9cb42a3366c07..4c4cf16a40ba7 100644 +--- a/tools/bpf/bpftool/prog.c ++++ b/tools/bpf/bpftool/prog.c +@@ -1778,7 +1778,10 @@ static int load_with_options(int argc, char **argv, bool first_prog_only) + goto err_close_obj; + } + +- err = mount_bpffs_for_pin(pinfile, !first_prog_only); ++ if (first_prog_only) ++ err = mount_bpffs_for_file(pinfile); ++ else ++ err = create_and_mount_bpffs_dir(pinfile); + if (err) + goto err_close_obj; + +diff --git a/tools/bpf/bpftool/struct_ops.c b/tools/bpf/bpftool/struct_ops.c +index d573f2640d8e9..aa43dead249cb 100644 +--- a/tools/bpf/bpftool/struct_ops.c ++++ b/tools/bpf/bpftool/struct_ops.c +@@ -515,7 +515,7 @@ static int do_register(int argc, char **argv) + if (argc == 1) + linkdir = GET_ARG(); + +- if (linkdir && mount_bpffs_for_pin(linkdir, true)) { ++ if (linkdir && create_and_mount_bpffs_dir(linkdir)) { + p_err("can't mount bpffs for pinning"); + return -1; + } +-- +2.43.0 + diff --git a/queue-6.8/btrfs-take-the-cleaner_mutex-earlier-in-qgroup-disab.patch b/queue-6.8/btrfs-take-the-cleaner_mutex-earlier-in-qgroup-disab.patch new file mode 100644 index 00000000000..b4b10b9a8df --- /dev/null +++ b/queue-6.8/btrfs-take-the-cleaner_mutex-earlier-in-qgroup-disab.patch @@ -0,0 +1,263 @@ +From 83e6684c0c59079291acc828c6ec90cc9f42305d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 14:38:48 -0400 +Subject: btrfs: take the cleaner_mutex earlier in qgroup disable + +From: Josef Bacik + +[ Upstream commit 0f2b8098d72a93890e69aa24ec549ef4bc34f4db ] + +One of my CI runs popped the following lockdep splat + +====================================================== +WARNING: possible circular locking dependency detected +6.9.0-rc4+ #1 Not tainted +------------------------------------------------------ +btrfs/471533 is trying to acquire lock: +ffff92ba46980850 (&fs_info->cleaner_mutex){+.+.}-{3:3}, at: btrfs_quota_disable+0x54/0x4c0 + +but task is already holding lock: +ffff92ba46980bd0 (&fs_info->subvol_sem){++++}-{3:3}, at: btrfs_ioctl+0x1c8f/0x2600 + +which lock already depends on the new lock. + +the existing dependency chain (in reverse order) is: + +-> #2 (&fs_info->subvol_sem){++++}-{3:3}: + down_read+0x42/0x170 + btrfs_rename+0x607/0xb00 + btrfs_rename2+0x2e/0x70 + vfs_rename+0xaf8/0xfc0 + do_renameat2+0x586/0x600 + __x64_sys_rename+0x43/0x50 + do_syscall_64+0x95/0x180 + entry_SYSCALL_64_after_hwframe+0x76/0x7e + +-> #1 (&sb->s_type->i_mutex_key#16){++++}-{3:3}: + down_write+0x3f/0xc0 + btrfs_inode_lock+0x40/0x70 + prealloc_file_extent_cluster+0x1b0/0x370 + relocate_file_extent_cluster+0xb2/0x720 + relocate_data_extent+0x107/0x160 + relocate_block_group+0x442/0x550 + btrfs_relocate_block_group+0x2cb/0x4b0 + btrfs_relocate_chunk+0x50/0x1b0 + btrfs_balance+0x92f/0x13d0 + btrfs_ioctl+0x1abf/0x2600 + __x64_sys_ioctl+0x97/0xd0 + do_syscall_64+0x95/0x180 + entry_SYSCALL_64_after_hwframe+0x76/0x7e + +-> #0 (&fs_info->cleaner_mutex){+.+.}-{3:3}: + __lock_acquire+0x13e7/0x2180 + lock_acquire+0xcb/0x2e0 + __mutex_lock+0xbe/0xc00 + btrfs_quota_disable+0x54/0x4c0 + btrfs_ioctl+0x206b/0x2600 + __x64_sys_ioctl+0x97/0xd0 + do_syscall_64+0x95/0x180 + entry_SYSCALL_64_after_hwframe+0x76/0x7e + +other info that might help us debug this: + +Chain exists of: + &fs_info->cleaner_mutex --> &sb->s_type->i_mutex_key#16 --> &fs_info->subvol_sem + + Possible unsafe locking scenario: + + CPU0 CPU1 + ---- ---- + lock(&fs_info->subvol_sem); + lock(&sb->s_type->i_mutex_key#16); + lock(&fs_info->subvol_sem); + lock(&fs_info->cleaner_mutex); + + *** DEADLOCK *** + +2 locks held by btrfs/471533: + #0: ffff92ba4319e420 (sb_writers#14){.+.+}-{0:0}, at: btrfs_ioctl+0x3b5/0x2600 + #1: ffff92ba46980bd0 (&fs_info->subvol_sem){++++}-{3:3}, at: btrfs_ioctl+0x1c8f/0x2600 + +stack backtrace: +CPU: 1 PID: 471533 Comm: btrfs Kdump: loaded Not tainted 6.9.0-rc4+ #1 +Call Trace: + + dump_stack_lvl+0x77/0xb0 + check_noncircular+0x148/0x160 + ? lock_acquire+0xcb/0x2e0 + __lock_acquire+0x13e7/0x2180 + lock_acquire+0xcb/0x2e0 + ? btrfs_quota_disable+0x54/0x4c0 + ? lock_is_held_type+0x9a/0x110 + __mutex_lock+0xbe/0xc00 + ? btrfs_quota_disable+0x54/0x4c0 + ? srso_return_thunk+0x5/0x5f + ? lock_acquire+0xcb/0x2e0 + ? btrfs_quota_disable+0x54/0x4c0 + ? btrfs_quota_disable+0x54/0x4c0 + btrfs_quota_disable+0x54/0x4c0 + btrfs_ioctl+0x206b/0x2600 + ? srso_return_thunk+0x5/0x5f + ? __do_sys_statfs+0x61/0x70 + __x64_sys_ioctl+0x97/0xd0 + do_syscall_64+0x95/0x180 + ? srso_return_thunk+0x5/0x5f + ? reacquire_held_locks+0xd1/0x1f0 + ? do_user_addr_fault+0x307/0x8a0 + ? srso_return_thunk+0x5/0x5f + ? lock_acquire+0xcb/0x2e0 + ? srso_return_thunk+0x5/0x5f + ? srso_return_thunk+0x5/0x5f + ? find_held_lock+0x2b/0x80 + ? srso_return_thunk+0x5/0x5f + ? lock_release+0xca/0x2a0 + ? srso_return_thunk+0x5/0x5f + ? do_user_addr_fault+0x35c/0x8a0 + ? srso_return_thunk+0x5/0x5f + ? trace_hardirqs_off+0x4b/0xc0 + ? srso_return_thunk+0x5/0x5f + ? lockdep_hardirqs_on_prepare+0xde/0x190 + ? srso_return_thunk+0x5/0x5f + +This happens because when we call rename we already have the inode mutex +held, and then we acquire the subvol_sem if we are a subvolume. This +makes the dependency + +inode lock -> subvol sem + +When we're running data relocation we will preallocate space for the +data relocation inode, and we always run the relocation under the +->cleaner_mutex. This now creates the dependency of + +cleaner_mutex -> inode lock (from the prealloc) -> subvol_sem + +Qgroup delete is doing this in the opposite order, it is acquiring the +subvol_sem and then it is acquiring the cleaner_mutex, which results in +this lockdep splat. This deadlock can't happen in reality, because we +won't ever rename the data reloc inode, nor is the data reloc inode a +subvolume. + +However this is fairly easy to fix, simply take the cleaner mutex in the +case where we are disabling qgroups before we take the subvol_sem. This +resolves the lockdep splat. + +Reviewed-by: Filipe Manana +Signed-off-by: Josef Bacik +Reviewed-by: David Sterba +Signed-off-by: David Sterba +Signed-off-by: Sasha Levin +--- + fs/btrfs/ioctl.c | 33 ++++++++++++++++++++++++++++++--- + fs/btrfs/qgroup.c | 21 ++++++++------------- + 2 files changed, 38 insertions(+), 16 deletions(-) + +diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c +index 6b93fae74403d..8851ba7a1e271 100644 +--- a/fs/btrfs/ioctl.c ++++ b/fs/btrfs/ioctl.c +@@ -3722,15 +3722,43 @@ static long btrfs_ioctl_quota_ctl(struct file *file, void __user *arg) + goto drop_write; + } + +- down_write(&fs_info->subvol_sem); +- + switch (sa->cmd) { + case BTRFS_QUOTA_CTL_ENABLE: + case BTRFS_QUOTA_CTL_ENABLE_SIMPLE_QUOTA: ++ down_write(&fs_info->subvol_sem); + ret = btrfs_quota_enable(fs_info, sa); ++ up_write(&fs_info->subvol_sem); + break; + case BTRFS_QUOTA_CTL_DISABLE: ++ /* ++ * Lock the cleaner mutex to prevent races with concurrent ++ * relocation, because relocation may be building backrefs for ++ * blocks of the quota root while we are deleting the root. This ++ * is like dropping fs roots of deleted snapshots/subvolumes, we ++ * need the same protection. ++ * ++ * This also prevents races between concurrent tasks trying to ++ * disable quotas, because we will unlock and relock ++ * qgroup_ioctl_lock across BTRFS_FS_QUOTA_ENABLED changes. ++ * ++ * We take this here because we have the dependency of ++ * ++ * inode_lock -> subvol_sem ++ * ++ * because of rename. With relocation we can prealloc extents, ++ * so that makes the dependency chain ++ * ++ * cleaner_mutex -> inode_lock -> subvol_sem ++ * ++ * so we must take the cleaner_mutex here before we take the ++ * subvol_sem. The deadlock can't actually happen, but this ++ * quiets lockdep. ++ */ ++ mutex_lock(&fs_info->cleaner_mutex); ++ down_write(&fs_info->subvol_sem); + ret = btrfs_quota_disable(fs_info); ++ up_write(&fs_info->subvol_sem); ++ mutex_unlock(&fs_info->cleaner_mutex); + break; + default: + ret = -EINVAL; +@@ -3738,7 +3766,6 @@ static long btrfs_ioctl_quota_ctl(struct file *file, void __user *arg) + } + + kfree(sa); +- up_write(&fs_info->subvol_sem); + drop_write: + mnt_drop_write_file(file); + return ret; +diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c +index 82d4559eb4b1e..cacc12d0ff33f 100644 +--- a/fs/btrfs/qgroup.c ++++ b/fs/btrfs/qgroup.c +@@ -1342,16 +1342,10 @@ int btrfs_quota_disable(struct btrfs_fs_info *fs_info) + lockdep_assert_held_write(&fs_info->subvol_sem); + + /* +- * Lock the cleaner mutex to prevent races with concurrent relocation, +- * because relocation may be building backrefs for blocks of the quota +- * root while we are deleting the root. This is like dropping fs roots +- * of deleted snapshots/subvolumes, we need the same protection. +- * +- * This also prevents races between concurrent tasks trying to disable +- * quotas, because we will unlock and relock qgroup_ioctl_lock across +- * BTRFS_FS_QUOTA_ENABLED changes. ++ * Relocation will mess with backrefs, so make sure we have the ++ * cleaner_mutex held to protect us from relocate. + */ +- mutex_lock(&fs_info->cleaner_mutex); ++ lockdep_assert_held(&fs_info->cleaner_mutex); + + mutex_lock(&fs_info->qgroup_ioctl_lock); + if (!fs_info->quota_root) +@@ -1373,9 +1367,13 @@ int btrfs_quota_disable(struct btrfs_fs_info *fs_info) + clear_bit(BTRFS_FS_QUOTA_ENABLED, &fs_info->flags); + btrfs_qgroup_wait_for_completion(fs_info, false); + ++ /* ++ * We have nothing held here and no trans handle, just return the error ++ * if there is one. ++ */ + ret = flush_reservations(fs_info); + if (ret) +- goto out_unlock_cleaner; ++ return ret; + + /* + * 1 For the root item +@@ -1439,9 +1437,6 @@ int btrfs_quota_disable(struct btrfs_fs_info *fs_info) + btrfs_end_transaction(trans); + else if (trans) + ret = btrfs_commit_transaction(trans); +-out_unlock_cleaner: +- mutex_unlock(&fs_info->cleaner_mutex); +- + return ret; + } + +-- +2.43.0 + diff --git a/queue-6.8/clk-mediatek-mt8365-mm-fix-dpi0-parent.patch b/queue-6.8/clk-mediatek-mt8365-mm-fix-dpi0-parent.patch new file mode 100644 index 00000000000..4824020b553 --- /dev/null +++ b/queue-6.8/clk-mediatek-mt8365-mm-fix-dpi0-parent.patch @@ -0,0 +1,52 @@ +From 361c86f27cf94f1ebd53e7c25fd94e4e5f0e8440 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 16:17:00 +0200 +Subject: clk: mediatek: mt8365-mm: fix DPI0 parent + +From: Alexandre Mergnat + +[ Upstream commit 4c0c087772d7e29bc2489ddb068d5167140bfc38 ] + +To have a working display through DPI, a workaround has been +implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to +the DPI node. Shortly, that add an extra clock. + +It seems consistent to have the "dpi0_sel" as parent. +Additionnaly, "vpll_dpix" isn't used/managed. + +Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel". + +The new clock tree is: + +clk26m + lvdspll + lvdspll_X (2, 4, 8, 16) + dpi0_sel + mm_dpi0_dpi0 + +Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC") +Signed-off-by: Alexandre Mergnat +Link: https://lore.kernel.org/r/20231023-display-support-v3-12-53388f3ed34b@baylibre.com +Reviewed-by: AngeloGioacchino Del Regno +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/mediatek/clk-mt8365-mm.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/mediatek/clk-mt8365-mm.c b/drivers/clk/mediatek/clk-mt8365-mm.c +index 01a2ef8f594ef..3f62ec7507336 100644 +--- a/drivers/clk/mediatek/clk-mt8365-mm.c ++++ b/drivers/clk/mediatek/clk-mt8365-mm.c +@@ -53,7 +53,7 @@ static const struct mtk_gate mm_clks[] = { + GATE_MM0(CLK_MM_MM_DSI0, "mm_dsi0", "mm_sel", 17), + GATE_MM0(CLK_MM_MM_DISP_RDMA1, "mm_disp_rdma1", "mm_sel", 18), + GATE_MM0(CLK_MM_MM_MDP_RDMA1, "mm_mdp_rdma1", "mm_sel", 19), +- GATE_MM0(CLK_MM_DPI0_DPI0, "mm_dpi0_dpi0", "vpll_dpix", 20), ++ GATE_MM0(CLK_MM_DPI0_DPI0, "mm_dpi0_dpi0", "dpi0_sel", 20), + GATE_MM0(CLK_MM_MM_FAKE, "mm_fake", "mm_sel", 21), + GATE_MM0(CLK_MM_MM_SMI_COMMON, "mm_smi_common", "mm_sel", 22), + GATE_MM0(CLK_MM_MM_SMI_LARB0, "mm_smi_larb0", "mm_sel", 23), +-- +2.43.0 + diff --git a/queue-6.8/clk-mediatek-pllfh-don-t-log-error-for-missing-fhctl.patch b/queue-6.8/clk-mediatek-pllfh-don-t-log-error-for-missing-fhctl.patch new file mode 100644 index 00000000000..fb3ece214aa --- /dev/null +++ b/queue-6.8/clk-mediatek-pllfh-don-t-log-error-for-missing-fhctl.patch @@ -0,0 +1,52 @@ +From b30be55443a9f574e5dd3a76fe6c3c10f0dd7424 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 8 Mar 2024 15:29:56 -0500 +Subject: clk: mediatek: pllfh: Don't log error for missing fhctl node +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit bb7b3c8e7180f36de75cdea200ab7127f93f58cc ] + +Support for fhctl clocks in apmixedsys was introduced at a later point +and to this moment only one mt6795 based platform has a fhctl DT node +present. Therefore the fhctl support in apmixedsys should be seen as +optional and not cause an error when it is missing. + +Change the message's log level to warning. The warning level is chosen +so that it will still alert the fact that fhctl support might be +unintentionally missing, but without implying that this is necessarily +an issue. + +Even if the FHCTL DT nodes are added to all current platforms moving +forward, since those changes won't be backported, this ensures stable +kernel releases won't have live with this error. + +Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") +Signed-off-by: Nícolas F. R. A. Prado +Link: https://lore.kernel.org/r/20240308-mtk-fhctl-no-node-error-v1-1-51e446eb149a@collabora.com +Reviewed-by: AngeloGioacchino Del Regno +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/mediatek/clk-pllfh.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/mediatek/clk-pllfh.c b/drivers/clk/mediatek/clk-pllfh.c +index 3a2b3f90be25d..094ec8a26d668 100644 +--- a/drivers/clk/mediatek/clk-pllfh.c ++++ b/drivers/clk/mediatek/clk-pllfh.c +@@ -68,7 +68,7 @@ void fhctl_parse_dt(const u8 *compatible_node, struct mtk_pllfh_data *pllfhs, + + node = of_find_compatible_node(NULL, NULL, compatible_node); + if (!node) { +- pr_err("cannot find \"%s\"\n", compatible_node); ++ pr_warn("cannot find \"%s\"\n", compatible_node); + return; + } + +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-apss-ipq-pll-fix-pll-rate-for-ipq5018.patch b/queue-6.8/clk-qcom-apss-ipq-pll-fix-pll-rate-for-ipq5018.patch new file mode 100644 index 00000000000..f231fe27e37 --- /dev/null +++ b/queue-6.8/clk-qcom-apss-ipq-pll-fix-pll-rate-for-ipq5018.patch @@ -0,0 +1,48 @@ +From acf8c335c354037cffa35aadf442aebfede248b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 14:34:11 +0100 +Subject: clk: qcom: apss-ipq-pll: fix PLL rate for IPQ5018 + +From: Gabor Juhos + +[ Upstream commit c55f7ee2ec239b6afd8639c7ac06493876deb0ea ] + +According to ipq5018.dtsi, the maximum supported rate by the +CPU is 1.008 GHz on the IPQ5018 platform, however the current +configuration of the PLL results in 1.2 GHz rate. + +Change the 'L' value in the PLL configuration to limit the +rate to 1.008 GHz. The downstream kernel also uses the same +value [1]. Also add a comment to indicate the desired +frequency. + +[1] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4/drivers/clk/qcom/apss-ipq5018.c?ref_type=heads#L151 + +Fixes: 50492f929486 ("clk: qcom: apss-ipq-pll: add support for IPQ5018") +Signed-off-by: Gabor Juhos +Reviewed-by: Konrad Dybcio +Link: https://lore.kernel.org/r/20240326-fix-ipq5018-apss-pll-rate-v1-1-82ab31c9da7e@gmail.com +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/apss-ipq-pll.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c +index 678b805f13d45..5e3da5558f4e0 100644 +--- a/drivers/clk/qcom/apss-ipq-pll.c ++++ b/drivers/clk/qcom/apss-ipq-pll.c +@@ -73,8 +73,9 @@ static struct clk_alpha_pll ipq_pll_stromer_plus = { + }, + }; + ++/* 1.008 GHz configuration */ + static const struct alpha_pll_config ipq5018_pll_config = { +- .l = 0x32, ++ .l = 0x2a, + .config_ctl_val = 0x4001075b, + .config_ctl_hi_val = 0x304, + .main_output_mask = BIT(0), +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-clk-alpha-pll-remove-invalid-stromer-regist.patch b/queue-6.8/clk-qcom-clk-alpha-pll-remove-invalid-stromer-regist.patch new file mode 100644 index 00000000000..f0c37fedaca --- /dev/null +++ b/queue-6.8/clk-qcom-clk-alpha-pll-remove-invalid-stromer-regist.patch @@ -0,0 +1,51 @@ +From d7072865a8c7dc1491f2a61692ba8c2083cd9c4f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 11 Mar 2024 19:45:19 +0100 +Subject: clk: qcom: clk-alpha-pll: remove invalid Stromer register offset + +From: Gabor Juhos + +[ Upstream commit 4f2bc4acbb1916b8cd2ce4bb3ba7b1cd7cb705fa ] + +The offset of the CONFIG_CTL_U register defined for the Stromer +PLL is wrong. It is not aligned on a 4 bytes boundary which might +causes errors in regmap operations. + +Maybe the intention behind of using the 0xff value was to indicate +that the register is not implemented in the PLL, but this is not +verified anywhere in the code. Moreover, this value is not used +even in other register offset arrays despite that those PLLs also +have unimplemented registers. + +Additionally, on the Stromer PLLs the current code only touches +the CONFIG_CTL_U register if the result of pll_has_64bit_config() +is true which condition is not affected by the change. + +Due to the reasons above, simply remove the CONFIG_CTL_U entry +from the Stromer specific array. + +Fixes: e47a4f55f240 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs") +Signed-off-by: Gabor Juhos +Reviewed-by: Konrad Dybcio +Link: https://lore.kernel.org/r/20240311-alpha-pll-stromer-cleanup-v1-1-f7c0c5607cca@gmail.com +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/clk-alpha-pll.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c +index 05898d2a8b22c..58ae732959803 100644 +--- a/drivers/clk/qcom/clk-alpha-pll.c ++++ b/drivers/clk/qcom/clk-alpha-pll.c +@@ -212,7 +212,6 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = { + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_USER_CTL_U] = 0x1c, + [PLL_OFF_CONFIG_CTL] = 0x20, +- [PLL_OFF_CONFIG_CTL_U] = 0xff, + [PLL_OFF_TEST_CTL] = 0x30, + [PLL_OFF_TEST_CTL_U] = 0x34, + [PLL_OFF_STATUS] = 0x28, +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-dispcc-sm6350-fix-displayport-clocks.patch b/queue-6.8/clk-qcom-dispcc-sm6350-fix-displayport-clocks.patch new file mode 100644 index 00000000000..567b376e1f6 --- /dev/null +++ b/queue-6.8/clk-qcom-dispcc-sm6350-fix-displayport-clocks.patch @@ -0,0 +1,65 @@ +From 71099b96b7c9fc1d56d96428335c2bedef2ba414 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 04:39:30 +0300 +Subject: clk: qcom: dispcc-sm6350: fix DisplayPort clocks + +From: Dmitry Baryshkov + +[ Upstream commit 1113501cfb46d5c0eb960f0a8a9f6c0f91dc6fb6 ] + +On SM6350 DisplayPort link clocks use frequency tables inherited from +the vendor kernel, it is not applicable in the upstream kernel. Drop +frequency tables and use clk_byte2_ops for those clocks. + +This fixes frequency selection in the OPP core (which otherwise attempts +to use invalid 810 KHz as DP link rate), also fixing the following +message: +msm-dp-display ae90000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22 + +Fixes: 837519775f1d ("clk: qcom: Add display clock controller driver for SM6350") +Reviewed-by: Neil Armstrong +Tested-by: Luca Weiss +Reviewed-by: Konrad Dybcio +Signed-off-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-2-b44038f3fa96@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/dispcc-sm6350.c | 11 +---------- + 1 file changed, 1 insertion(+), 10 deletions(-) + +diff --git a/drivers/clk/qcom/dispcc-sm6350.c b/drivers/clk/qcom/dispcc-sm6350.c +index ea6f54ed846ec..441f042f5ea45 100644 +--- a/drivers/clk/qcom/dispcc-sm6350.c ++++ b/drivers/clk/qcom/dispcc-sm6350.c +@@ -221,26 +221,17 @@ static struct clk_rcg2 disp_cc_mdss_dp_crypto_clk_src = { + }, + }; + +-static const struct freq_tbl ftbl_disp_cc_mdss_dp_link_clk_src[] = { +- F(162000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(270000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(540000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(810000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0), +- { } +-}; +- + static struct clk_rcg2 disp_cc_mdss_dp_link_clk_src = { + .cmd_rcgr = 0x10f8, + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_0, +- .freq_tbl = ftbl_disp_cc_mdss_dp_link_clk_src, + .clkr.hw.init = &(struct clk_init_data){ + .name = "disp_cc_mdss_dp_link_clk_src", + .parent_data = disp_cc_parent_data_0, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_0), + .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-dispcc-sm8450-fix-displayport-clocks.patch b/queue-6.8/clk-qcom-dispcc-sm8450-fix-displayport-clocks.patch new file mode 100644 index 00000000000..c5361d4c265 --- /dev/null +++ b/queue-6.8/clk-qcom-dispcc-sm8450-fix-displayport-clocks.patch @@ -0,0 +1,109 @@ +From fd56563b3d2679512f42e7d2ee7b8a44b7e98b77 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 04:39:29 +0300 +Subject: clk: qcom: dispcc-sm8450: fix DisplayPort clocks + +From: Dmitry Baryshkov + +[ Upstream commit e801038a02ce1e8c652a0b668dd233a4ee48aeb7 ] + +On SM8450 DisplayPort link clocks use frequency tables inherited from +the vendor kernel, it is not applicable in the upstream kernel. Drop +frequency tables and use clk_byte2_ops for those clocks. + +This fixes frequency selection in the OPP core (which otherwise attempts +to use invalid 810 KHz as DP link rate), also fixing the following +message: +msm-dp-display ae90000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22 + +Fixes: 16fb89f92ec4 ("clk: qcom: Add support for Display Clock Controller on SM8450") +Reviewed-by: Neil Armstrong +Reviewed-by: Konrad Dybcio +Signed-off-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-1-b44038f3fa96@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/dispcc-sm8450.c | 20 ++++---------------- + 1 file changed, 4 insertions(+), 16 deletions(-) + +diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8450.c +index 2c4aecd75186b..239cc726c7e29 100644 +--- a/drivers/clk/qcom/dispcc-sm8450.c ++++ b/drivers/clk/qcom/dispcc-sm8450.c +@@ -309,26 +309,17 @@ static struct clk_rcg2 disp_cc_mdss_dptx0_aux_clk_src = { + }, + }; + +-static const struct freq_tbl ftbl_disp_cc_mdss_dptx0_link_clk_src[] = { +- F(162000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(270000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(540000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(810000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- { } +-}; +- + static struct clk_rcg2 disp_cc_mdss_dptx0_link_clk_src = { + .cmd_rcgr = 0x819c, + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx0_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -382,13 +373,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx1_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx1_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -442,13 +432,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx2_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx2_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -502,13 +491,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx3_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx3_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-dispcc-sm8550-fix-displayport-clocks.patch b/queue-6.8/clk-qcom-dispcc-sm8550-fix-displayport-clocks.patch new file mode 100644 index 00000000000..408e46ff8ac --- /dev/null +++ b/queue-6.8/clk-qcom-dispcc-sm8550-fix-displayport-clocks.patch @@ -0,0 +1,110 @@ +From 308317fa8819d2e015673957baad63f53ff39132 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 04:39:31 +0300 +Subject: clk: qcom: dispcc-sm8550: fix DisplayPort clocks + +From: Dmitry Baryshkov + +[ Upstream commit e90b5139da8465a15c3820b4b67ca9468dce93b4 ] + +On SM8550 DisplayPort link clocks use frequency tables inherited from +the vendor kernel, it is not applicable in the upstream kernel. Drop +frequency tables and use clk_byte2_ops for those clocks. + +This fixes frequency selection in the OPP core (which otherwise attempts +to use invalid 810 KHz as DP link rate), also fixing the following +message: +msm-dp-display ae90000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22 + +Fixes: 90114ca11476 ("clk: qcom: add SM8550 DISPCC driver") +Reviewed-by: Neil Armstrong +Tested-by: Neil Armstrong # on SM8550-HDK +Reviewed-by: Konrad Dybcio +Signed-off-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-3-b44038f3fa96@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/dispcc-sm8550.c | 20 ++++---------------- + 1 file changed, 4 insertions(+), 16 deletions(-) + +diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c +index f96d8b81fd9ad..c9b8c2eb5c64a 100644 +--- a/drivers/clk/qcom/dispcc-sm8550.c ++++ b/drivers/clk/qcom/dispcc-sm8550.c +@@ -345,26 +345,17 @@ static struct clk_rcg2 disp_cc_mdss_dptx0_aux_clk_src = { + }, + }; + +-static const struct freq_tbl ftbl_disp_cc_mdss_dptx0_link_clk_src[] = { +- F(162000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(270000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(540000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(810000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- { } +-}; +- + static struct clk_rcg2 disp_cc_mdss_dptx0_link_clk_src = { + .cmd_rcgr = 0x8170, + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_7, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx0_link_clk_src", + .parent_data = disp_cc_parent_data_7, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_7), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -418,13 +409,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx1_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx1_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -478,13 +468,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx2_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx2_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -538,13 +527,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx3_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(struct clk_init_data) { + .name = "disp_cc_mdss_dptx3_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-dispcc-sm8650-fix-displayport-clocks.patch b/queue-6.8/clk-qcom-dispcc-sm8650-fix-displayport-clocks.patch new file mode 100644 index 00000000000..2be98410453 --- /dev/null +++ b/queue-6.8/clk-qcom-dispcc-sm8650-fix-displayport-clocks.patch @@ -0,0 +1,110 @@ +From 7a209907b265c3029d9ea02f42b37294960b46c4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 04:39:32 +0300 +Subject: clk: qcom: dispcc-sm8650: fix DisplayPort clocks + +From: Dmitry Baryshkov + +[ Upstream commit 615a292ee4d51303246278f3fa33cc38700fe00e ] + +On SM8650 DisplayPort link clocks use frequency tables inherited from +the vendor kernel, it is not applicable in the upstream kernel. Drop +frequency tables and use clk_byte2_ops for those clocks. + +This fixes frequency selection in the OPP core (which otherwise attempts +to use invalid 810 KHz as DP link rate), also fixing the following +message: +msm-dp-display af54000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22 + +Fixes: 9e939f008338 ("clk: qcom: add the SM8650 Display Clock Controller driver") +Reviewed-by: Neil Armstrong +Tested-by: Neil Armstrong # on SM8650-HDK +Reviewed-by: Konrad Dybcio +Signed-off-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-4-b44038f3fa96@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/dispcc-sm8650.c | 20 ++++---------------- + 1 file changed, 4 insertions(+), 16 deletions(-) + +diff --git a/drivers/clk/qcom/dispcc-sm8650.c b/drivers/clk/qcom/dispcc-sm8650.c +index f3b1d9d16baea..c9b139faf1a8f 100644 +--- a/drivers/clk/qcom/dispcc-sm8650.c ++++ b/drivers/clk/qcom/dispcc-sm8650.c +@@ -343,26 +343,17 @@ static struct clk_rcg2 disp_cc_mdss_dptx0_aux_clk_src = { + }, + }; + +-static const struct freq_tbl ftbl_disp_cc_mdss_dptx0_link_clk_src[] = { +- F(162000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(270000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(540000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- F(810000, P_DP0_PHY_PLL_LINK_CLK, 1, 0, 0), +- { } +-}; +- + static struct clk_rcg2 disp_cc_mdss_dptx0_link_clk_src = { + .cmd_rcgr = 0x8170, + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_7, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(const struct clk_init_data) { + .name = "disp_cc_mdss_dptx0_link_clk_src", + .parent_data = disp_cc_parent_data_7, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_7), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -416,13 +407,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx1_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(const struct clk_init_data) { + .name = "disp_cc_mdss_dptx1_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -476,13 +466,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx2_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(const struct clk_init_data) { + .name = "disp_cc_mdss_dptx2_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +@@ -536,13 +525,12 @@ static struct clk_rcg2 disp_cc_mdss_dptx3_link_clk_src = { + .mnd_width = 0, + .hid_width = 5, + .parent_map = disp_cc_parent_map_3, +- .freq_tbl = ftbl_disp_cc_mdss_dptx0_link_clk_src, + .clkr.hw.init = &(const struct clk_init_data) { + .name = "disp_cc_mdss_dptx3_link_clk_src", + .parent_data = disp_cc_parent_data_3, + .num_parents = ARRAY_SIZE(disp_cc_parent_data_3), + .flags = CLK_SET_RATE_PARENT, +- .ops = &clk_rcg2_ops, ++ .ops = &clk_byte2_ops, + }, + }; + +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-fix-sc_camcc_8280xp-dependencies.patch b/queue-6.8/clk-qcom-fix-sc_camcc_8280xp-dependencies.patch new file mode 100644 index 00000000000..4fada97c030 --- /dev/null +++ b/queue-6.8/clk-qcom-fix-sc_camcc_8280xp-dependencies.patch @@ -0,0 +1,46 @@ +From 64ce76a41f3a052a3d8fd8e804756be8e137cc98 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 18 Mar 2024 08:18:10 -0700 +Subject: clk: qcom: Fix SC_CAMCC_8280XP dependencies + +From: Nathan Chancellor + +[ Upstream commit e00f2540a581f8b8c165e5ae8afe52e4ad038550 ] + +CONFIG_SC_GCC_8280XP depends on ARM64 but it is selected by +CONFIG_SC_CAMCC_8280XP, which can be selected on ARM, resulting in a +Kconfig warning. + +WARNING: unmet direct dependencies detected for SC_GCC_8280XP + Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) + Selected by [y]: + - SC_CAMCC_8280XP [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] + +Add the same dependencies to CONFIG_SC_CAMCC_8280XP to resolve the +warning. + +Fixes: ff93872a9c61 ("clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC") +Signed-off-by: Nathan Chancellor +Reviewed-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240318-fix-some-qcom-kconfig-deps-v1-1-ea0773e3df5a@kernel.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig +index 2a9da0939377a..67f1151a3d2b0 100644 +--- a/drivers/clk/qcom/Kconfig ++++ b/drivers/clk/qcom/Kconfig +@@ -439,6 +439,7 @@ config SC_CAMCC_7280 + + config SC_CAMCC_8280XP + tristate "SC8280XP Camera Clock Controller" ++ depends on ARM64 || COMPILE_TEST + select SC_GCC_8280XP + help + Support for the camera clock controller on Qualcomm Technologies, Inc +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-fix-sm_gpucc_8650-dependencies.patch b/queue-6.8/clk-qcom-fix-sm_gpucc_8650-dependencies.patch new file mode 100644 index 00000000000..cd969383fd1 --- /dev/null +++ b/queue-6.8/clk-qcom-fix-sm_gpucc_8650-dependencies.patch @@ -0,0 +1,46 @@ +From c612466d9652ff53cb33eca9333b18d3103a8dda Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 18 Mar 2024 08:18:11 -0700 +Subject: clk: qcom: Fix SM_GPUCC_8650 dependencies + +From: Nathan Chancellor + +[ Upstream commit 07fb0a76bb757990b99fc2ab78ad7d1709cc441d ] + +CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by +CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a +Kconfig warning. + +WARNING: unmet direct dependencies detected for SM_GCC_8650 + Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) + Selected by [y]: + - SM_GPUCC_8650 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] + +Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the +warning. + +Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver") +Signed-off-by: Nathan Chancellor +Reviewed-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240318-fix-some-qcom-kconfig-deps-v1-2-ea0773e3df5a@kernel.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig +index 67f1151a3d2b0..be35803c7a4bf 100644 +--- a/drivers/clk/qcom/Kconfig ++++ b/drivers/clk/qcom/Kconfig +@@ -1070,6 +1070,7 @@ config SM_GPUCC_8550 + + config SM_GPUCC_8650 + tristate "SM8650 Graphics Clock Controller" ++ depends on ARM64 || COMPILE_TEST + select SM_GCC_8650 + help + Support for the graphics clock controller on SM8650 devices. +-- +2.43.0 + diff --git a/queue-6.8/clk-qcom-mmcc-msm8998-fix-venus-clock-issue.patch b/queue-6.8/clk-qcom-mmcc-msm8998-fix-venus-clock-issue.patch new file mode 100644 index 00000000000..93b77a9cbbe --- /dev/null +++ b/queue-6.8/clk-qcom-mmcc-msm8998-fix-venus-clock-issue.patch @@ -0,0 +1,114 @@ +From a0080c9f9745f7c734e5d5c019592c32ed6499ae Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 17:07:07 +0200 +Subject: clk: qcom: mmcc-msm8998: fix venus clock issue + +From: Marc Gonzalez + +[ Upstream commit e20ae5ae9f0c843aded4f06f3d1cab7384789e92 ] + +Right now, msm8998 video decoder (venus) is non-functional: + +$ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm + (+) Video --vid=1 (*) (vp9 854x480 29.970fps) + Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz) +[ffmpeg/video] vp9_v4l2m2m: output VIDIOC_REQBUFS failed: Connection timed out +[ffmpeg/video] vp9_v4l2m2m: no v4l2 output context's buffers +[ffmpeg/video] vp9_v4l2m2m: can't configure decoder +Could not open codec. +Software decoding fallback is disabled. +Exiting... (Quit) + +Bryan O'Donoghue suggested the proper fix: +- Set required register offsets in venus GDSC structs. +- Set HW_CTRL flag. + +$ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm + (+) Video --vid=1 (*) (vp9 854x480 29.970fps) + Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz) +[ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl +[ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl +... +Using hardware decoding (v4l2m2m-copy). +VO: [null] 854x480 nv12 +Exiting... (End of file) +real 0m3.315s +user 0m1.277s +sys 0m0.453s + +NOTES: + +GDSC = Globally Distributed Switch Controller + +Use same code as mmcc-msm8996 with: +s/venus_gdsc/video_top_gdsc/ +s/venus_core0_gdsc/video_subcore0_gdsc/ +s/venus_core1_gdsc/video_subcore1_gdsc/ + +https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8996.h +https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8998.h + +0x1024 = MMSS_VIDEO GDSCR (undocumented) +0x1028 = MMSS_VIDEO_CORE_CBCR +0x1030 = MMSS_VIDEO_AHB_CBCR +0x1034 = MMSS_VIDEO_AXI_CBCR +0x1038 = MMSS_VIDEO_MAXI_CBCR +0x1040 = MMSS_VIDEO_SUBCORE0 GDSCR (undocumented) +0x1044 = MMSS_VIDEO_SUBCORE1 GDSCR (undocumented) +0x1048 = MMSS_VIDEO_SUBCORE0_CBCR +0x104c = MMSS_VIDEO_SUBCORE1_CBCR + +Fixes: d14b15b5931c2b ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver") +Reviewed-by: Bryan O'Donoghue +Signed-off-by: Marc Gonzalez +Reviewed-by: Jeffrey Hugo +Link: https://lore.kernel.org/r/ff4e2e34-a677-4c39-8c29-83655c5512ae@freebox.fr +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/clk/qcom/mmcc-msm8998.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/clk/qcom/mmcc-msm8998.c b/drivers/clk/qcom/mmcc-msm8998.c +index 1180e48c687ac..275fb3b71ede4 100644 +--- a/drivers/clk/qcom/mmcc-msm8998.c ++++ b/drivers/clk/qcom/mmcc-msm8998.c +@@ -2535,6 +2535,8 @@ static struct clk_branch vmem_ahb_clk = { + + static struct gdsc video_top_gdsc = { + .gdscr = 0x1024, ++ .cxcs = (unsigned int []){ 0x1028, 0x1034, 0x1038 }, ++ .cxc_count = 3, + .pd = { + .name = "video_top", + }, +@@ -2543,20 +2545,26 @@ static struct gdsc video_top_gdsc = { + + static struct gdsc video_subcore0_gdsc = { + .gdscr = 0x1040, ++ .cxcs = (unsigned int []){ 0x1048 }, ++ .cxc_count = 1, + .pd = { + .name = "video_subcore0", + }, + .parent = &video_top_gdsc.pd, + .pwrsts = PWRSTS_OFF_ON, ++ .flags = HW_CTRL, + }; + + static struct gdsc video_subcore1_gdsc = { + .gdscr = 0x1044, ++ .cxcs = (unsigned int []){ 0x104c }, ++ .cxc_count = 1, + .pd = { + .name = "video_subcore1", + }, + .parent = &video_top_gdsc.pd, + .pwrsts = PWRSTS_OFF_ON, ++ .flags = HW_CTRL, + }; + + static struct gdsc mdss_gdsc = { +-- +2.43.0 + diff --git a/queue-6.8/clk-renesas-r8a779a0-fix-canfd-parent-clock.patch b/queue-6.8/clk-renesas-r8a779a0-fix-canfd-parent-clock.patch new file mode 100644 index 00000000000..44177fc7830 --- /dev/null +++ b/queue-6.8/clk-renesas-r8a779a0-fix-canfd-parent-clock.patch @@ -0,0 +1,40 @@ +From 92515460dc5ae0dfd25e1d7ff6da3778a22449df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 17:00:51 +0200 +Subject: clk: renesas: r8a779a0: Fix CANFD parent clock +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Geert Uytterhoeven + +[ Upstream commit 3b23118bdbd898dc2f4de8f549d598d492c42ba8 ] + +According to Figure 52A.1 ("RS-CANFD Module Block Diagram (in classical +CAN mode)") in the R-Car V3U Series User’s Manual Rev. 0.5, the parent +clock for the CANFD peripheral module clock is the S3D2 clock. + +Fixes: 9b621b6adff53346 ("clk: renesas: r8a779a0: Add CANFD module clock") +Signed-off-by: Geert Uytterhoeven +Link: https://lore.kernel.org/r/aef9300f44c9141b1465343f91c5cc7303249b6e.1713279523.git.geert+renesas@glider.be +Signed-off-by: Sasha Levin +--- + drivers/clk/renesas/r8a779a0-cpg-mssr.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c +index 4c2872f45387f..ff3f85e906fe1 100644 +--- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c ++++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c +@@ -139,7 +139,7 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = { + DEF_MOD("avb3", 214, R8A779A0_CLK_S3D2), + DEF_MOD("avb4", 215, R8A779A0_CLK_S3D2), + DEF_MOD("avb5", 216, R8A779A0_CLK_S3D2), +- DEF_MOD("canfd0", 328, R8A779A0_CLK_CANFD), ++ DEF_MOD("canfd0", 328, R8A779A0_CLK_S3D2), + DEF_MOD("csi40", 331, R8A779A0_CLK_CSI0), + DEF_MOD("csi41", 400, R8A779A0_CLK_CSI0), + DEF_MOD("csi42", 401, R8A779A0_CLK_CSI0), +-- +2.43.0 + diff --git a/queue-6.8/clk-renesas-r9a07g043-add-clock-and-reset-entry-for-.patch b/queue-6.8/clk-renesas-r9a07g043-add-clock-and-reset-entry-for-.patch new file mode 100644 index 00000000000..aabe982691c --- /dev/null +++ b/queue-6.8/clk-renesas-r9a07g043-add-clock-and-reset-entry-for-.patch @@ -0,0 +1,59 @@ +From ee204dc54f49b1317eac40d383579e7e8748f2df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 21:09:52 +0100 +Subject: clk: renesas: r9a07g043: Add clock and reset entry for PLIC + +From: Lad Prabhakar + +[ Upstream commit 44019387fce230beda35b83da3a2c9fc5787704e ] + +Add the missing clock and reset entry for PLIC. Also add +R9A07G043_NCEPLIC_ACLK to the critical clocks list. + +Fixes: 95d48d270305ad2c ("clk: renesas: r9a07g043: Add support for RZ/Five SoC") +Signed-off-by: Lad Prabhakar +Reviewed-by: Geert Uytterhoeven +Link: https://lore.kernel.org/r/20240403200952.633084-1-prabhakar.mahadev-lad.rj@bp.renesas.com +Signed-off-by: Geert Uytterhoeven +Signed-off-by: Sasha Levin +--- + drivers/clk/renesas/r9a07g043-cpg.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/drivers/clk/renesas/r9a07g043-cpg.c b/drivers/clk/renesas/r9a07g043-cpg.c +index 075ade0925d45..9ad7ceb3ab1ba 100644 +--- a/drivers/clk/renesas/r9a07g043-cpg.c ++++ b/drivers/clk/renesas/r9a07g043-cpg.c +@@ -265,6 +265,10 @@ static struct rzg2l_mod_clk r9a07g043_mod_clks[] = { + 0x5a8, 1), + DEF_MOD("tsu_pclk", R9A07G043_TSU_PCLK, R9A07G043_CLK_TSU, + 0x5ac, 0), ++#ifdef CONFIG_RISCV ++ DEF_MOD("nceplic_aclk", R9A07G043_NCEPLIC_ACLK, R9A07G043_CLK_P1, ++ 0x608, 0), ++#endif + }; + + static struct rzg2l_reset r9a07g043_resets[] = { +@@ -318,6 +322,10 @@ static struct rzg2l_reset r9a07g043_resets[] = { + DEF_RST(R9A07G043_ADC_PRESETN, 0x8a8, 0), + DEF_RST(R9A07G043_ADC_ADRST_N, 0x8a8, 1), + DEF_RST(R9A07G043_TSU_PRESETN, 0x8ac, 0), ++#ifdef CONFIG_RISCV ++ DEF_RST(R9A07G043_NCEPLIC_ARESETN, 0x908, 0), ++#endif ++ + }; + + static const unsigned int r9a07g043_crit_mod_clks[] __initconst = { +@@ -327,6 +335,7 @@ static const unsigned int r9a07g043_crit_mod_clks[] __initconst = { + #endif + #ifdef CONFIG_RISCV + MOD_CLK_BASE + R9A07G043_IAX45_CLK, ++ MOD_CLK_BASE + R9A07G043_NCEPLIC_ACLK, + #endif + MOD_CLK_BASE + R9A07G043_DMAC_ACLK, + }; +-- +2.43.0 + diff --git a/queue-6.8/clk-rs9-fix-wrong-default-value-for-clock-amplitude.patch b/queue-6.8/clk-rs9-fix-wrong-default-value-for-clock-amplitude.patch new file mode 100644 index 00000000000..05680749d08 --- /dev/null +++ b/queue-6.8/clk-rs9-fix-wrong-default-value-for-clock-amplitude.patch @@ -0,0 +1,72 @@ +From fe414b299a882164e25c0d0c9adab571a026c13f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 16:03:48 +0200 +Subject: clk: rs9: fix wrong default value for clock amplitude + +From: Catalin Popescu + +[ Upstream commit 1758c68c81b8b881818fcebaaeb91055362a82f8 ] + +According to 9FGV0241, 9FGV0441 & 9FGV0841 datasheets, the default +value for the clock amplitude is 0.8V, while the driver assumes 0.7V. + +Additionally, define constants for default values for both clock +amplitude and spread spectrum and use them. + +Fixes: 892e0ddea1aa ("clk: rs9: Add Renesas 9-series PCIe clock generator driver") +Signed-off-by: Catalin Popescu +Reviewed-by: Marek Vasut +Link: https://lore.kernel.org/r/20240415140348.2887619-1-catalin.popescu@leica-geosystems.com +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-renesas-pcie.c | 10 ++++++---- + 1 file changed, 6 insertions(+), 4 deletions(-) + +diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pcie.c +index 53e21ac302e6d..4c3a5e4eb77ac 100644 +--- a/drivers/clk/clk-renesas-pcie.c ++++ b/drivers/clk/clk-renesas-pcie.c +@@ -25,10 +25,12 @@ + #define RS9_REG_SS_AMP_0V7 0x1 + #define RS9_REG_SS_AMP_0V8 0x2 + #define RS9_REG_SS_AMP_0V9 0x3 ++#define RS9_REG_SS_AMP_DEFAULT RS9_REG_SS_AMP_0V8 + #define RS9_REG_SS_AMP_MASK 0x3 + #define RS9_REG_SS_SSC_100 0 + #define RS9_REG_SS_SSC_M025 (1 << 3) + #define RS9_REG_SS_SSC_M050 (3 << 3) ++#define RS9_REG_SS_SSC_DEFAULT RS9_REG_SS_SSC_100 + #define RS9_REG_SS_SSC_MASK (3 << 3) + #define RS9_REG_SS_SSC_LOCK BIT(5) + #define RS9_REG_SR 0x2 +@@ -205,8 +207,8 @@ static int rs9_get_common_config(struct rs9_driver_data *rs9) + int ret; + + /* Set defaults */ +- rs9->pll_amplitude = RS9_REG_SS_AMP_0V7; +- rs9->pll_ssc = RS9_REG_SS_SSC_100; ++ rs9->pll_amplitude = RS9_REG_SS_AMP_DEFAULT; ++ rs9->pll_ssc = RS9_REG_SS_SSC_DEFAULT; + + /* Output clock amplitude */ + ret = of_property_read_u32(np, "renesas,out-amplitude-microvolt", +@@ -247,13 +249,13 @@ static void rs9_update_config(struct rs9_driver_data *rs9) + int i; + + /* If amplitude is non-default, update it. */ +- if (rs9->pll_amplitude != RS9_REG_SS_AMP_0V7) { ++ if (rs9->pll_amplitude != RS9_REG_SS_AMP_DEFAULT) { + regmap_update_bits(rs9->regmap, RS9_REG_SS, RS9_REG_SS_AMP_MASK, + rs9->pll_amplitude); + } + + /* If SSC is non-default, update it. */ +- if (rs9->pll_ssc != RS9_REG_SS_SSC_100) { ++ if (rs9->pll_ssc != RS9_REG_SS_SSC_DEFAULT) { + regmap_update_bits(rs9->regmap, RS9_REG_SS, RS9_REG_SS_SSC_MASK, + rs9->pll_ssc); + } +-- +2.43.0 + diff --git a/queue-6.8/clk-samsung-exynosautov9-fix-wrong-pll-clock-id-valu.patch b/queue-6.8/clk-samsung-exynosautov9-fix-wrong-pll-clock-id-valu.patch new file mode 100644 index 00000000000..36099d227cc --- /dev/null +++ b/queue-6.8/clk-samsung-exynosautov9-fix-wrong-pll-clock-id-valu.patch @@ -0,0 +1,47 @@ +From 262f0336ca845b749a9832b452d88d15a5f9ea17 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 18:10:00 +0900 +Subject: clk: samsung: exynosautov9: fix wrong pll clock id value + +From: Jaewon Kim + +[ Upstream commit 04ee3a0b44e3d18cf6b0c712d14b98624877fd26 ] + +All PLL id values of CMU_TOP were incorrectly set to FOUT_SHARED0_PLL. +It modified to the correct PLL clock id value. + +Fixes: 6587c62f69dc ("clk: samsung: add top clock support for Exynos Auto v9 SoC") +Signed-off-by: Jaewon Kim +Reviewed-by: Sam Protsenko +Link: https://lore.kernel.org/r/20240328091000.17660-1-jaewon02.kim@samsung.com +Signed-off-by: Krzysztof Kozlowski +Signed-off-by: Sasha Levin +--- + drivers/clk/samsung/clk-exynosautov9.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/clk/samsung/clk-exynosautov9.c b/drivers/clk/samsung/clk-exynosautov9.c +index e9c06eb93e666..f04bacacab2cb 100644 +--- a/drivers/clk/samsung/clk-exynosautov9.c ++++ b/drivers/clk/samsung/clk-exynosautov9.c +@@ -352,13 +352,13 @@ static const struct samsung_pll_clock top_pll_clks[] __initconst = { + /* CMU_TOP_PURECLKCOMP */ + PLL(pll_0822x, FOUT_SHARED0_PLL, "fout_shared0_pll", "oscclk", + PLL_LOCKTIME_PLL_SHARED0, PLL_CON3_PLL_SHARED0, NULL), +- PLL(pll_0822x, FOUT_SHARED0_PLL, "fout_shared1_pll", "oscclk", ++ PLL(pll_0822x, FOUT_SHARED1_PLL, "fout_shared1_pll", "oscclk", + PLL_LOCKTIME_PLL_SHARED1, PLL_CON3_PLL_SHARED1, NULL), +- PLL(pll_0822x, FOUT_SHARED0_PLL, "fout_shared2_pll", "oscclk", ++ PLL(pll_0822x, FOUT_SHARED2_PLL, "fout_shared2_pll", "oscclk", + PLL_LOCKTIME_PLL_SHARED2, PLL_CON3_PLL_SHARED2, NULL), +- PLL(pll_0822x, FOUT_SHARED0_PLL, "fout_shared3_pll", "oscclk", ++ PLL(pll_0822x, FOUT_SHARED3_PLL, "fout_shared3_pll", "oscclk", + PLL_LOCKTIME_PLL_SHARED3, PLL_CON3_PLL_SHARED3, NULL), +- PLL(pll_0822x, FOUT_SHARED0_PLL, "fout_shared4_pll", "oscclk", ++ PLL(pll_0822x, FOUT_SHARED4_PLL, "fout_shared4_pll", "oscclk", + PLL_LOCKTIME_PLL_SHARED4, PLL_CON3_PLL_SHARED4, NULL), + }; + +-- +2.43.0 + diff --git a/queue-6.8/cppc_cpufreq-fix-possible-null-pointer-dereference.patch b/queue-6.8/cppc_cpufreq-fix-possible-null-pointer-dereference.patch new file mode 100644 index 00000000000..da2e61173b1 --- /dev/null +++ b/queue-6.8/cppc_cpufreq-fix-possible-null-pointer-dereference.patch @@ -0,0 +1,65 @@ +From f74371f4a004bc5a3e202c790a55920c0fb30424 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 12:35:36 +0300 +Subject: cppc_cpufreq: Fix possible null pointer dereference + +From: Aleksandr Mishin + +[ Upstream commit cf7de25878a1f4508c69dc9f6819c21ba177dbfe ] + +cppc_cpufreq_get_rate() and hisi_cppc_cpufreq_get_rate() can be called from +different places with various parameters. So cpufreq_cpu_get() can return +null as 'policy' in some circumstances. +Fix this bug by adding null return check. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: a28b2bfc099c ("cppc_cpufreq: replace per-cpu data array with a list") +Signed-off-by: Aleksandr Mishin +Signed-off-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/cppc_cpufreq.c | 14 ++++++++++++-- + 1 file changed, 12 insertions(+), 2 deletions(-) + +diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c +index 64420d9cfd1ed..15f1d41920a33 100644 +--- a/drivers/cpufreq/cppc_cpufreq.c ++++ b/drivers/cpufreq/cppc_cpufreq.c +@@ -741,10 +741,15 @@ static unsigned int cppc_cpufreq_get_rate(unsigned int cpu) + { + struct cppc_perf_fb_ctrs fb_ctrs_t0 = {0}, fb_ctrs_t1 = {0}; + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); +- struct cppc_cpudata *cpu_data = policy->driver_data; ++ struct cppc_cpudata *cpu_data; + u64 delivered_perf; + int ret; + ++ if (!policy) ++ return -ENODEV; ++ ++ cpu_data = policy->driver_data; ++ + cpufreq_cpu_put(policy); + + ret = cppc_get_perf_ctrs(cpu, &fb_ctrs_t0); +@@ -822,10 +827,15 @@ static struct cpufreq_driver cppc_cpufreq_driver = { + static unsigned int hisi_cppc_cpufreq_get_rate(unsigned int cpu) + { + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); +- struct cppc_cpudata *cpu_data = policy->driver_data; ++ struct cppc_cpudata *cpu_data; + u64 desired_perf; + int ret; + ++ if (!policy) ++ return -ENODEV; ++ ++ cpu_data = policy->driver_data; ++ + cpufreq_cpu_put(policy); + + ret = cppc_get_desired_perf(cpu, &desired_perf); +-- +2.43.0 + diff --git a/queue-6.8/cpu-ignore-mitigations-kernel-parameter-if-cpu_mitig.patch b/queue-6.8/cpu-ignore-mitigations-kernel-parameter-if-cpu_mitig.patch new file mode 100644 index 00000000000..9bada3aeefd --- /dev/null +++ b/queue-6.8/cpu-ignore-mitigations-kernel-parameter-if-cpu_mitig.patch @@ -0,0 +1,136 @@ +From f88b9bd7107877f57822e210c957db7e434a6a2e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 17:05:55 -0700 +Subject: cpu: Ignore "mitigations" kernel parameter if CPU_MITIGATIONS=n + +From: Sean Christopherson + +[ Upstream commit ce0abef6a1d540acef85068e0e82bdf1fbeeb0e9 ] + +Explicitly disallow enabling mitigations at runtime for kernels that were +built with CONFIG_CPU_MITIGATIONS=n, as some architectures may omit code +entirely if mitigations are disabled at compile time. + +E.g. on x86, a large pile of Kconfigs are buried behind CPU_MITIGATIONS, +and trying to provide sane behavior for retroactively enabling mitigations +is extremely difficult, bordering on impossible. E.g. page table isolation +and call depth tracking require build-time support, BHI mitigations will +still be off without additional kernel parameters, etc. + + [ bp: Touchups. ] + +Signed-off-by: Sean Christopherson +Signed-off-by: Borislav Petkov (AMD) +Acked-by: Borislav Petkov (AMD) +Link: https://lore.kernel.org/r/20240420000556.2645001-3-seanjc@google.com +Signed-off-by: Sasha Levin +--- + Documentation/admin-guide/kernel-parameters.txt | 3 +++ + arch/x86/Kconfig | 8 ++++++-- + include/linux/cpu.h | 11 +++++++++++ + kernel/cpu.c | 14 ++++++++++---- + 4 files changed, 30 insertions(+), 6 deletions(-) + +diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt +index 31fdaf4fe9dd8..9bfc972af2403 100644 +--- a/Documentation/admin-guide/kernel-parameters.txt ++++ b/Documentation/admin-guide/kernel-parameters.txt +@@ -3399,6 +3399,9 @@ + arch-independent options, each of which is an + aggregation of existing arch-specific options. + ++ Note, "mitigations" is supported if and only if the ++ kernel was built with CPU_MITIGATIONS=y. ++ + off + Disable all optional CPU mitigations. This + improves system performance, but it may also +diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig +index 6f49999a6b838..bfccf1213871b 100644 +--- a/arch/x86/Kconfig ++++ b/arch/x86/Kconfig +@@ -2474,9 +2474,13 @@ menuconfig CPU_MITIGATIONS + help + Say Y here to enable options which enable mitigations for hardware + vulnerabilities (usually related to speculative execution). ++ Mitigations can be disabled or restricted to SMT systems at runtime ++ via the "mitigations" kernel parameter. + +- If you say N, all mitigations will be disabled. You really +- should know what you are doing to say so. ++ If you say N, all mitigations will be disabled. This CANNOT be ++ overridden at runtime. ++ ++ Say 'Y', unless you really know what you are doing. + + if CPU_MITIGATIONS + +diff --git a/include/linux/cpu.h b/include/linux/cpu.h +index 8654714421a0d..75f0344bd3b94 100644 +--- a/include/linux/cpu.h ++++ b/include/linux/cpu.h +@@ -219,7 +219,18 @@ void cpuhp_report_idle_dead(void); + static inline void cpuhp_report_idle_dead(void) { } + #endif /* #ifdef CONFIG_HOTPLUG_CPU */ + ++#ifdef CONFIG_CPU_MITIGATIONS + extern bool cpu_mitigations_off(void); + extern bool cpu_mitigations_auto_nosmt(void); ++#else ++static inline bool cpu_mitigations_off(void) ++{ ++ return true; ++} ++static inline bool cpu_mitigations_auto_nosmt(void) ++{ ++ return false; ++} ++#endif + + #endif /* _LINUX_CPU_H_ */ +diff --git a/kernel/cpu.c b/kernel/cpu.c +index f8a0406ce8ba5..bac70ea54e349 100644 +--- a/kernel/cpu.c ++++ b/kernel/cpu.c +@@ -3196,6 +3196,7 @@ void __init boot_cpu_hotplug_init(void) + this_cpu_write(cpuhp_state.target, CPUHP_ONLINE); + } + ++#ifdef CONFIG_CPU_MITIGATIONS + /* + * These are used for a global "mitigations=" cmdline option for toggling + * optional CPU mitigations. +@@ -3206,9 +3207,7 @@ enum cpu_mitigations { + CPU_MITIGATIONS_AUTO_NOSMT, + }; + +-static enum cpu_mitigations cpu_mitigations __ro_after_init = +- IS_ENABLED(CONFIG_CPU_MITIGATIONS) ? CPU_MITIGATIONS_AUTO : +- CPU_MITIGATIONS_OFF; ++static enum cpu_mitigations cpu_mitigations __ro_after_init = CPU_MITIGATIONS_AUTO; + + static int __init mitigations_parse_cmdline(char *arg) + { +@@ -3224,7 +3223,6 @@ static int __init mitigations_parse_cmdline(char *arg) + + return 0; + } +-early_param("mitigations", mitigations_parse_cmdline); + + /* mitigations=off */ + bool cpu_mitigations_off(void) +@@ -3239,3 +3237,11 @@ bool cpu_mitigations_auto_nosmt(void) + return cpu_mitigations == CPU_MITIGATIONS_AUTO_NOSMT; + } + EXPORT_SYMBOL_GPL(cpu_mitigations_auto_nosmt); ++#else ++static int __init mitigations_parse_cmdline(char *arg) ++{ ++ pr_crit("Kernel compiled without mitigations, ignoring 'mitigations'; system may still be vulnerable\n"); ++ return 0; ++} ++#endif ++early_param("mitigations", mitigations_parse_cmdline); +-- +2.43.0 + diff --git a/queue-6.8/cpufreq-brcmstb-avs-cpufreq-iso-c90-forbids-mixed-de.patch b/queue-6.8/cpufreq-brcmstb-avs-cpufreq-iso-c90-forbids-mixed-de.patch new file mode 100644 index 00000000000..c7958eecf3d --- /dev/null +++ b/queue-6.8/cpufreq-brcmstb-avs-cpufreq-iso-c90-forbids-mixed-de.patch @@ -0,0 +1,44 @@ +From 13c42b60f2b21251246683d8048aab61963c48db Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 15:02:20 +1000 +Subject: cpufreq: brcmstb-avs-cpufreq: ISO C90 forbids mixed declarations + +From: Portia Stephens + +[ Upstream commit fa7bd98f3c8b33fb68c6b2bc69cff32b63db69f8 ] + +There is a compile warning because a NULL pointer check was added before +a struct was declared. This moves the NULL pointer check to after the +struct is declared and moves the struct assignment to after the NULL +pointer check. + +Fixes: f661017e6d32 ("cpufreq: brcmstb-avs-cpufreq: add check for cpufreq_cpu_get's return value") +Signed-off-by: Portia Stephens +Acked-by: Florian Fainelli +Signed-off-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/brcmstb-avs-cpufreq.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c +index 1a1857b0a6f48..ea8438550b490 100644 +--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c ++++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c +@@ -481,9 +481,12 @@ static bool brcm_avs_is_firmware_loaded(struct private_data *priv) + static unsigned int brcm_avs_cpufreq_get(unsigned int cpu) + { + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); ++ struct private_data *priv; ++ + if (!policy) + return 0; +- struct private_data *priv = policy->driver_data; ++ ++ priv = policy->driver_data; + + cpufreq_cpu_put(policy); + +-- +2.43.0 + diff --git a/queue-6.8/cpufreq-exit-callback-is-optional.patch b/queue-6.8/cpufreq-exit-callback-is-optional.patch new file mode 100644 index 00000000000..98681e71e80 --- /dev/null +++ b/queue-6.8/cpufreq-exit-callback-is-optional.patch @@ -0,0 +1,58 @@ +From a270c29d7626aeeb38b259956b143adbd14a1cc7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 11:19:20 +0530 +Subject: cpufreq: exit() callback is optional + +From: Viresh Kumar + +[ Upstream commit b8f85833c05730d631576008daaa34096bc7f3ce ] + +The exit() callback is optional and shouldn't be called without checking +a valid pointer first. + +Also, we must clear freq_table pointer even if the exit() callback isn't +present. + +Signed-off-by: Viresh Kumar +Fixes: 91a12e91dc39 ("cpufreq: Allow light-weight tear down and bring up of CPUs") +Fixes: f339f3541701 ("cpufreq: Rearrange locking in cpufreq_remove_dev()") +Reported-by: Lizhe +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/cpufreq.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c +index 3c2c955fbbbd6..86f1bc7754ea6 100644 +--- a/drivers/cpufreq/cpufreq.c ++++ b/drivers/cpufreq/cpufreq.c +@@ -1670,10 +1670,13 @@ static void __cpufreq_offline(unsigned int cpu, struct cpufreq_policy *policy) + */ + if (cpufreq_driver->offline) { + cpufreq_driver->offline(policy); +- } else if (cpufreq_driver->exit) { +- cpufreq_driver->exit(policy); +- policy->freq_table = NULL; ++ return; + } ++ ++ if (cpufreq_driver->exit) ++ cpufreq_driver->exit(policy); ++ ++ policy->freq_table = NULL; + } + + static int cpufreq_offline(unsigned int cpu) +@@ -1731,7 +1734,7 @@ static void cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif) + } + + /* We did light-weight exit earlier, do full tear down now */ +- if (cpufreq_driver->offline) ++ if (cpufreq_driver->offline && cpufreq_driver->exit) + cpufreq_driver->exit(policy); + + up_write(&policy->rwsem); +-- +2.43.0 + diff --git a/queue-6.8/crypto-bcm-fix-pointer-arithmetic.patch b/queue-6.8/crypto-bcm-fix-pointer-arithmetic.patch new file mode 100644 index 00000000000..cc803bd308c --- /dev/null +++ b/queue-6.8/crypto-bcm-fix-pointer-arithmetic.patch @@ -0,0 +1,40 @@ +From 4330d42c3e31adb6892adf717923b3c44e272bbd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 22 Mar 2024 23:59:15 +0300 +Subject: crypto: bcm - Fix pointer arithmetic + +From: Aleksandr Mishin + +[ Upstream commit 2b3460cbf454c6b03d7429e9ffc4fe09322eb1a9 ] + +In spu2_dump_omd() value of ptr is increased by ciph_key_len +instead of hash_iv_len which could lead to going beyond the +buffer boundaries. +Fix this bug by changing ciph_key_len to hash_iv_len. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver") +Signed-off-by: Aleksandr Mishin +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/bcm/spu2.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c +index 07989bb8c220a..3fdc64b5a65e7 100644 +--- a/drivers/crypto/bcm/spu2.c ++++ b/drivers/crypto/bcm/spu2.c +@@ -495,7 +495,7 @@ static void spu2_dump_omd(u8 *omd, u16 hash_key_len, u16 ciph_key_len, + if (hash_iv_len) { + packet_log(" Hash IV Length %u bytes\n", hash_iv_len); + packet_dump(" hash IV: ", ptr, hash_iv_len); +- ptr += ciph_key_len; ++ ptr += hash_iv_len; + } + + if (ciph_iv_len) { +-- +2.43.0 + diff --git a/queue-6.8/crypto-ccp-drop-platform-ifdef-checks.patch b/queue-6.8/crypto-ccp-drop-platform-ifdef-checks.patch new file mode 100644 index 00000000000..b5deefcaa87 --- /dev/null +++ b/queue-6.8/crypto-ccp-drop-platform-ifdef-checks.patch @@ -0,0 +1,94 @@ +From d64478648c142223eadf794005dd6346c9c715ac Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 10:06:42 +0200 +Subject: crypto: ccp - drop platform ifdef checks + +From: Arnd Bergmann + +[ Upstream commit 42c2d7d02977ef09d434b1f5b354f5bc6c1027ab ] + +When both ACPI and OF are disabled, the dev_vdata variable is unused: + +drivers/crypto/ccp/sp-platform.c:33:34: error: unused variable 'dev_vdata' [-Werror,-Wunused-const-variable] + +This is not a useful configuration, and there is not much point in saving +a few bytes when only one of the two is enabled, so just remove all +these ifdef checks and rely on of_match_node() and acpi_match_device() +returning NULL when these subsystems are disabled. + +Fixes: 6c5063434098 ("crypto: ccp - Add ACPI support") +Signed-off-by: Arnd Bergmann +Acked-by: Tom Lendacky +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/ccp/sp-platform.c | 14 ++------------ + 1 file changed, 2 insertions(+), 12 deletions(-) + +diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platform.c +index 4733012377601..ff6ceb4feee04 100644 +--- a/drivers/crypto/ccp/sp-platform.c ++++ b/drivers/crypto/ccp/sp-platform.c +@@ -39,44 +39,38 @@ static const struct sp_dev_vdata dev_vdata[] = { + }, + }; + +-#ifdef CONFIG_ACPI + static const struct acpi_device_id sp_acpi_match[] = { + { "AMDI0C00", (kernel_ulong_t)&dev_vdata[0] }, + { }, + }; + MODULE_DEVICE_TABLE(acpi, sp_acpi_match); +-#endif + +-#ifdef CONFIG_OF + static const struct of_device_id sp_of_match[] = { + { .compatible = "amd,ccp-seattle-v1a", + .data = (const void *)&dev_vdata[0] }, + { }, + }; + MODULE_DEVICE_TABLE(of, sp_of_match); +-#endif + + static struct sp_dev_vdata *sp_get_of_version(struct platform_device *pdev) + { +-#ifdef CONFIG_OF + const struct of_device_id *match; + + match = of_match_node(sp_of_match, pdev->dev.of_node); + if (match && match->data) + return (struct sp_dev_vdata *)match->data; +-#endif ++ + return NULL; + } + + static struct sp_dev_vdata *sp_get_acpi_version(struct platform_device *pdev) + { +-#ifdef CONFIG_ACPI + const struct acpi_device_id *match; + + match = acpi_match_device(sp_acpi_match, &pdev->dev); + if (match && match->driver_data) + return (struct sp_dev_vdata *)match->driver_data; +-#endif ++ + return NULL; + } + +@@ -212,12 +206,8 @@ static int sp_platform_resume(struct platform_device *pdev) + static struct platform_driver sp_platform_driver = { + .driver = { + .name = "ccp", +-#ifdef CONFIG_ACPI + .acpi_match_table = sp_acpi_match, +-#endif +-#ifdef CONFIG_OF + .of_match_table = sp_of_match, +-#endif + }, + .probe = sp_platform_probe, + .remove_new = sp_platform_remove, +-- +2.43.0 + diff --git a/queue-6.8/crypto-octeontx2-add-missing-check-for-dma_map_singl.patch b/queue-6.8/crypto-octeontx2-add-missing-check-for-dma_map_singl.patch new file mode 100644 index 00000000000..5add2a2cb9f --- /dev/null +++ b/queue-6.8/crypto-octeontx2-add-missing-check-for-dma_map_singl.patch @@ -0,0 +1,39 @@ +From 5e8b8868a4e14d9f5b5ab9c0fd7407d93a49225c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 01:59:14 +0000 +Subject: crypto: octeontx2 - add missing check for dma_map_single + +From: Chen Ni + +[ Upstream commit 6a6d6a3a328a59ed0d8ae2e65696ef38e49133a0 ] + +Add check for dma_map_single() and return error if it fails in order +to avoid invalid dma address. + +Fixes: e92971117c2c ("crypto: octeontx2 - add ctx_val workaround") +Signed-off-by: Chen Ni +Reviewed-by: Bharat Bhushan +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/marvell/octeontx2/cn10k_cpt.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/crypto/marvell/octeontx2/cn10k_cpt.c b/drivers/crypto/marvell/octeontx2/cn10k_cpt.c +index 79b4e74804f6d..6bfc59e677478 100644 +--- a/drivers/crypto/marvell/octeontx2/cn10k_cpt.c ++++ b/drivers/crypto/marvell/octeontx2/cn10k_cpt.c +@@ -138,6 +138,10 @@ int cn10k_cpt_hw_ctx_init(struct pci_dev *pdev, + return -ENOMEM; + cptr_dma = dma_map_single(&pdev->dev, hctx, CN10K_CPT_HW_CTX_SIZE, + DMA_BIDIRECTIONAL); ++ if (dma_mapping_error(&pdev->dev, cptr_dma)) { ++ kfree(hctx); ++ return -ENOMEM; ++ } + + cn10k_cpt_hw_ctx_set(hctx, 1); + er_ctx->hw_ctx = hctx; +-- +2.43.0 + diff --git a/queue-6.8/crypto-qat-improve-error-logging-to-be-consistent-ac.patch b/queue-6.8/crypto-qat-improve-error-logging-to-be-consistent-ac.patch new file mode 100644 index 00000000000..fd75b559a04 --- /dev/null +++ b/queue-6.8/crypto-qat-improve-error-logging-to-be-consistent-ac.patch @@ -0,0 +1,37 @@ +From adcfb2e029bc04e964d3ec9f72ae1e6bccd3be7d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 13:24:03 +0100 +Subject: crypto: qat - improve error logging to be consistent across features + +From: Adam Guerin + +[ Upstream commit d281a28bd2a94d72c440457e05a2f04a52f15947 ] + +Improve error logging in rate limiting feature. Staying consistent with +the error logging found in the telemetry feature. + +Fixes: d9fb8408376e ("crypto: qat - add rate limiting feature to qat_4xxx") +Signed-off-by: Adam Guerin +Reviewed-by: Giovanni Cabiddu +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/intel/qat/qat_common/adf_rl.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/crypto/intel/qat/qat_common/adf_rl.c b/drivers/crypto/intel/qat/qat_common/adf_rl.c +index d4f2db3c53d8c..e10f0024f4b85 100644 +--- a/drivers/crypto/intel/qat/qat_common/adf_rl.c ++++ b/drivers/crypto/intel/qat/qat_common/adf_rl.c +@@ -1125,7 +1125,7 @@ int adf_rl_start(struct adf_accel_dev *accel_dev) + } + + if ((fw_caps & RL_CAPABILITY_MASK) != RL_CAPABILITY_VALUE) { +- dev_info(&GET_DEV(accel_dev), "not supported\n"); ++ dev_info(&GET_DEV(accel_dev), "feature not supported by FW\n"); + ret = -EOPNOTSUPP; + goto ret_free; + } +-- +2.43.0 + diff --git a/queue-6.8/crypto-qat-improve-error-message-in-adf_get_arbiter_.patch b/queue-6.8/crypto-qat-improve-error-message-in-adf_get_arbiter_.patch new file mode 100644 index 00000000000..4df86b2de96 --- /dev/null +++ b/queue-6.8/crypto-qat-improve-error-message-in-adf_get_arbiter_.patch @@ -0,0 +1,50 @@ +From 2fc284f054e3a3003d87e94228054103c8f75ef2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 13:24:02 +0100 +Subject: crypto: qat - improve error message in adf_get_arbiter_mapping() + +From: Adam Guerin + +[ Upstream commit 4a4fc6c0c7fe29f2538013a57ebd7813ec6c12a8 ] + +Improve error message to be more readable. + +Fixes: 5da6a2d5353e ("crypto: qat - generate dynamically arbiter mappings") +Signed-off-by: Adam Guerin +Reviewed-by: Giovanni Cabiddu +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c | 2 +- + drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c b/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c +index 7909b51e97c30..7b8abfb797fff 100644 +--- a/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c ++++ b/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c +@@ -296,7 +296,7 @@ static const u32 *adf_get_arbiter_mapping(struct adf_accel_dev *accel_dev) + { + if (adf_gen4_init_thd2arb_map(accel_dev)) + dev_warn(&GET_DEV(accel_dev), +- "Generate of the thread to arbiter map failed"); ++ "Failed to generate thread to arbiter mapping"); + + return GET_HW_DATA(accel_dev)->thd_to_arb_map; + } +diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c +index e171cddf6f025..7a5c5f9711c8b 100644 +--- a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c ++++ b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c +@@ -208,7 +208,7 @@ static const u32 *adf_get_arbiter_mapping(struct adf_accel_dev *accel_dev) + { + if (adf_gen4_init_thd2arb_map(accel_dev)) + dev_warn(&GET_DEV(accel_dev), +- "Generate of the thread to arbiter map failed"); ++ "Failed to generate thread to arbiter mapping"); + + return GET_HW_DATA(accel_dev)->thd_to_arb_map; + } +-- +2.43.0 + diff --git a/queue-6.8/crypto-qat-specify-firmware-files-for-402xx.patch b/queue-6.8/crypto-qat-specify-firmware-files-for-402xx.patch new file mode 100644 index 00000000000..9a508c74654 --- /dev/null +++ b/queue-6.8/crypto-qat-specify-firmware-files-for-402xx.patch @@ -0,0 +1,43 @@ +From 483d96869e5a2555ecc952f4e4b7d91b9e9eff26 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 15:13:17 +0100 +Subject: crypto: qat - specify firmware files for 402xx + +From: Giovanni Cabiddu + +[ Upstream commit a3dc1f2b6b932a13f139d3be3c765155542c1070 ] + +The 4xxx driver can probe 4xxx and 402xx devices. However, the driver +only specifies the firmware images required for 4xxx. +This might result in external tools missing these binaries, if required, +in the initramfs. + +Specify the firmware image used by 402xx with the MODULE_FIRMWARE() +macros in the 4xxx driver. + +Fixes: a3e8c919b993 ("crypto: qat - add support for 402xx devices") +Signed-off-by: Giovanni Cabiddu +Reviewed-by: Damian Muszynski +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/intel/qat/qat_4xxx/adf_drv.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c +index 9762f2bf7727f..d26564cebdec4 100644 +--- a/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c ++++ b/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c +@@ -197,7 +197,9 @@ module_pci_driver(adf_driver); + MODULE_LICENSE("Dual BSD/GPL"); + MODULE_AUTHOR("Intel"); + MODULE_FIRMWARE(ADF_4XXX_FW); ++MODULE_FIRMWARE(ADF_402XX_FW); + MODULE_FIRMWARE(ADF_4XXX_MMP); ++MODULE_FIRMWARE(ADF_402XX_MMP); + MODULE_DESCRIPTION("Intel(R) QuickAssist Technology"); + MODULE_VERSION(ADF_DRV_VERSION); + MODULE_SOFTDEP("pre: crypto-intel_qat"); +-- +2.43.0 + diff --git a/queue-6.8/crypto-qat-validate-slices-count-returned-by-fw.patch b/queue-6.8/crypto-qat-validate-slices-count-returned-by-fw.patch new file mode 100644 index 00000000000..e3c34de6776 --- /dev/null +++ b/queue-6.8/crypto-qat-validate-slices-count-returned-by-fw.patch @@ -0,0 +1,101 @@ +From 02e653b7e214a745414a26a63d9d33dd4a0855b2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 12:33:37 +0200 +Subject: crypto: qat - validate slices count returned by FW + +From: Lucas Segarra Fernandez + +[ Upstream commit 483fd65ce29317044d1d00757e3fd23503b6b04c ] + +The function adf_send_admin_tl_start() enables the telemetry (TL) +feature on a QAT device by sending the ICP_QAT_FW_TL_START message to +the firmware. This triggers the FW to start writing TL data to a DMA +buffer in memory and returns an array containing the number of +accelerators of each type (slices) supported by this HW. +The pointer to this array is stored in the adf_tl_hw_data data +structure called slice_cnt. + +The array slice_cnt is then used in the function tl_print_dev_data() +to report in debugfs only statistics about the supported accelerators. +An incorrect value of the elements in slice_cnt might lead to an out +of bounds memory read. +At the moment, there isn't an implementation of FW that returns a wrong +value, but for robustness validate the slice count array returned by FW. + +Fixes: 69e7649f7cc2 ("crypto: qat - add support for device telemetry") +Signed-off-by: Lucas Segarra Fernandez +Reviewed-by: Damian Muszynski +Reviewed-by: Giovanni Cabiddu +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + .../crypto/intel/qat/qat_common/adf_gen4_tl.c | 1 + + .../intel/qat/qat_common/adf_telemetry.c | 21 +++++++++++++++++++ + .../intel/qat/qat_common/adf_telemetry.h | 1 + + 3 files changed, 23 insertions(+) + +diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_tl.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_tl.c +index 7fc7a77f6aed9..c7ad8cf07863b 100644 +--- a/drivers/crypto/intel/qat/qat_common/adf_gen4_tl.c ++++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_tl.c +@@ -149,5 +149,6 @@ void adf_gen4_init_tl_data(struct adf_tl_hw_data *tl_data) + tl_data->sl_exec_counters = sl_exec_counters; + tl_data->rp_counters = rp_counters; + tl_data->num_rp_counters = ARRAY_SIZE(rp_counters); ++ tl_data->max_sl_cnt = ADF_GEN4_TL_MAX_SLICES_PER_TYPE; + } + EXPORT_SYMBOL_GPL(adf_gen4_init_tl_data); +diff --git a/drivers/crypto/intel/qat/qat_common/adf_telemetry.c b/drivers/crypto/intel/qat/qat_common/adf_telemetry.c +index 2ff714d11bd2f..74fb0c2ed2412 100644 +--- a/drivers/crypto/intel/qat/qat_common/adf_telemetry.c ++++ b/drivers/crypto/intel/qat/qat_common/adf_telemetry.c +@@ -41,6 +41,20 @@ static int validate_tl_data(struct adf_tl_hw_data *tl_data) + return 0; + } + ++static int validate_tl_slice_counters(struct icp_qat_fw_init_admin_slice_cnt *slice_count, ++ u8 max_slices_per_type) ++{ ++ u8 *sl_counter = (u8 *)slice_count; ++ int i; ++ ++ for (i = 0; i < ADF_TL_SL_CNT_COUNT; i++) { ++ if (sl_counter[i] > max_slices_per_type) ++ return -EINVAL; ++ } ++ ++ return 0; ++} ++ + static int adf_tl_alloc_mem(struct adf_accel_dev *accel_dev) + { + struct adf_tl_hw_data *tl_data = &GET_TL_DATA(accel_dev); +@@ -214,6 +228,13 @@ int adf_tl_run(struct adf_accel_dev *accel_dev, int state) + return ret; + } + ++ ret = validate_tl_slice_counters(&telemetry->slice_cnt, tl_data->max_sl_cnt); ++ if (ret) { ++ dev_err(dev, "invalid value returned by FW\n"); ++ adf_send_admin_tl_stop(accel_dev); ++ return ret; ++ } ++ + telemetry->hbuffs = state; + atomic_set(&telemetry->state, state); + +diff --git a/drivers/crypto/intel/qat/qat_common/adf_telemetry.h b/drivers/crypto/intel/qat/qat_common/adf_telemetry.h +index 9be81cd3b8860..e54a406cc1b4a 100644 +--- a/drivers/crypto/intel/qat/qat_common/adf_telemetry.h ++++ b/drivers/crypto/intel/qat/qat_common/adf_telemetry.h +@@ -40,6 +40,7 @@ struct adf_tl_hw_data { + u8 num_dev_counters; + u8 num_rp_counters; + u8 max_rp; ++ u8 max_sl_cnt; + }; + + struct adf_telemetry { +-- +2.43.0 + diff --git a/queue-6.8/crypto-x86-nh-avx2-add-missing-vzeroupper.patch b/queue-6.8/crypto-x86-nh-avx2-add-missing-vzeroupper.patch new file mode 100644 index 00000000000..a511d61504b --- /dev/null +++ b/queue-6.8/crypto-x86-nh-avx2-add-missing-vzeroupper.patch @@ -0,0 +1,36 @@ +From b2bfa84c34c5826d6c83e96d271de7594847b17e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 20:26:08 -0400 +Subject: crypto: x86/nh-avx2 - add missing vzeroupper + +From: Eric Biggers + +[ Upstream commit 4ad096cca942959871d8ff73826d30f81f856f6e ] + +Since nh_avx2() uses ymm registers, execute vzeroupper before returning +from it. This is necessary to avoid reducing the performance of SSE +code. + +Fixes: 0f961f9f670e ("crypto: x86/nhpoly1305 - add AVX2 accelerated NHPoly1305") +Signed-off-by: Eric Biggers +Acked-by: Tim Chen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + arch/x86/crypto/nh-avx2-x86_64.S | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/x86/crypto/nh-avx2-x86_64.S b/arch/x86/crypto/nh-avx2-x86_64.S +index ef73a3ab87263..791386d9a83aa 100644 +--- a/arch/x86/crypto/nh-avx2-x86_64.S ++++ b/arch/x86/crypto/nh-avx2-x86_64.S +@@ -154,5 +154,6 @@ SYM_TYPED_FUNC_START(nh_avx2) + vpaddq T1, T0, T0 + vpaddq T4, T0, T0 + vmovdqu T0, (HASH) ++ vzeroupper + RET + SYM_FUNC_END(nh_avx2) +-- +2.43.0 + diff --git a/queue-6.8/crypto-x86-sha256-avx2-add-missing-vzeroupper.patch b/queue-6.8/crypto-x86-sha256-avx2-add-missing-vzeroupper.patch new file mode 100644 index 00000000000..efa81088836 --- /dev/null +++ b/queue-6.8/crypto-x86-sha256-avx2-add-missing-vzeroupper.patch @@ -0,0 +1,37 @@ +From e3a3dd97f5f82141b3f2036ce382ae6b9ff7c6de Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 20:26:09 -0400 +Subject: crypto: x86/sha256-avx2 - add missing vzeroupper + +From: Eric Biggers + +[ Upstream commit 57ce8a4e162599cf9adafef1f29763160a8e5564 ] + +Since sha256_transform_rorx() uses ymm registers, execute vzeroupper +before returning from it. This is necessary to avoid reducing the +performance of SSE code. + +Fixes: d34a460092d8 ("crypto: sha256 - Optimized sha256 x86_64 routine using AVX2's RORX instructions") +Signed-off-by: Eric Biggers +Acked-by: Tim Chen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + arch/x86/crypto/sha256-avx2-asm.S | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/x86/crypto/sha256-avx2-asm.S b/arch/x86/crypto/sha256-avx2-asm.S +index 9918212faf914..0ffb072be9561 100644 +--- a/arch/x86/crypto/sha256-avx2-asm.S ++++ b/arch/x86/crypto/sha256-avx2-asm.S +@@ -716,6 +716,7 @@ SYM_TYPED_FUNC_START(sha256_transform_rorx) + popq %r13 + popq %r12 + popq %rbx ++ vzeroupper + RET + SYM_FUNC_END(sha256_transform_rorx) + +-- +2.43.0 + diff --git a/queue-6.8/crypto-x86-sha512-avx2-add-missing-vzeroupper.patch b/queue-6.8/crypto-x86-sha512-avx2-add-missing-vzeroupper.patch new file mode 100644 index 00000000000..64091603639 --- /dev/null +++ b/queue-6.8/crypto-x86-sha512-avx2-add-missing-vzeroupper.patch @@ -0,0 +1,37 @@ +From 7924c8d0221de2bab55826c27abea59814ed866f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 20:26:10 -0400 +Subject: crypto: x86/sha512-avx2 - add missing vzeroupper + +From: Eric Biggers + +[ Upstream commit 6a24fdfe1edbafacdacd53516654d99068f20eec ] + +Since sha512_transform_rorx() uses ymm registers, execute vzeroupper +before returning from it. This is necessary to avoid reducing the +performance of SSE code. + +Fixes: e01d69cb0195 ("crypto: sha512 - Optimized SHA512 x86_64 assembly routine using AVX instructions.") +Signed-off-by: Eric Biggers +Acked-by: Tim Chen +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + arch/x86/crypto/sha512-avx2-asm.S | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-avx2-asm.S +index f08496cd68708..24973f42c43ff 100644 +--- a/arch/x86/crypto/sha512-avx2-asm.S ++++ b/arch/x86/crypto/sha512-avx2-asm.S +@@ -680,6 +680,7 @@ SYM_TYPED_FUNC_START(sha512_transform_rorx) + pop %r12 + pop %rbx + ++ vzeroupper + RET + SYM_FUNC_END(sha512_transform_rorx) + +-- +2.43.0 + diff --git a/queue-6.8/dev_printk-add-and-use-dev_no_printk.patch b/queue-6.8/dev_printk-add-and-use-dev_no_printk.patch new file mode 100644 index 00000000000..2d2c1964bac --- /dev/null +++ b/queue-6.8/dev_printk-add-and-use-dev_no_printk.patch @@ -0,0 +1,98 @@ +From 97b826e245876efe31d123e3f0ee873952fa3d57 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Feb 2024 15:00:03 +0100 +Subject: dev_printk: Add and use dev_no_printk() + +From: Geert Uytterhoeven + +[ Upstream commit c26ec799042a3888935d59b599f33e41efedf5f8 ] + +When printk-indexing is enabled, each dev_printk() invocation emits a +pi_entry structure. This is even true when the dev_printk() is +protected by an always-false check, as is typically the case for debug +messages: while the actual code to print the message is optimized out by +the compiler, the pi_entry structure is still emitted. + +Avoid emitting pi_entry structures for unavailable dev_printk() kernel +messages by: + 1. Introducing a dev_no_printk() helper, mimicked after the existing + no_printk() helper, which calls _dev_printk() instead of + dev_printk(), + 2. Replacing all "if (0) dev_printk(...)" constructs by calls to the + new helper. + +This reduces the size of an arm64 defconfig kernel with +CONFIG_PRINTK_INDEX=y by 957 KiB. + +Fixes: ad7d61f159db7397 ("printk: index: Add indexing support to dev_printk") +Signed-off-by: Geert Uytterhoeven +Reviewed-by: Andy Shevchenko +Reviewed-by: Xiubo Li +Reviewed-by: Chris Down +Reviewed-by: Petr Mladek +Link: https://lore.kernel.org/r/8583d54f1687c801c6cda8edddf2cf0344c6e883.1709127473.git.geert+renesas@glider.be +Signed-off-by: Petr Mladek +Signed-off-by: Sasha Levin +--- + include/linux/dev_printk.h | 25 +++++++++++++------------ + 1 file changed, 13 insertions(+), 12 deletions(-) + +diff --git a/include/linux/dev_printk.h b/include/linux/dev_printk.h +index 6bfe70decc9fb..ae80a303c216b 100644 +--- a/include/linux/dev_printk.h ++++ b/include/linux/dev_printk.h +@@ -129,6 +129,16 @@ void _dev_info(const struct device *dev, const char *fmt, ...) + _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ + }) + ++/* ++ * Dummy dev_printk for disabled debugging statements to use whilst maintaining ++ * gcc's format checking. ++ */ ++#define dev_no_printk(level, dev, fmt, ...) \ ++ ({ \ ++ if (0) \ ++ _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ ++ }) ++ + /* + * #defines for all the dev_ macros to prefix with whatever + * possible use of #define dev_fmt(fmt) ... +@@ -158,10 +168,7 @@ void _dev_info(const struct device *dev, const char *fmt, ...) + dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__) + #else + #define dev_dbg(dev, fmt, ...) \ +-({ \ +- if (0) \ +- dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ +-}) ++ dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__) + #endif + + #ifdef CONFIG_PRINTK +@@ -247,20 +254,14 @@ do { \ + } while (0) + #else + #define dev_dbg_ratelimited(dev, fmt, ...) \ +-do { \ +- if (0) \ +- dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ +-} while (0) ++ dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__) + #endif + + #ifdef VERBOSE_DEBUG + #define dev_vdbg dev_dbg + #else + #define dev_vdbg(dev, fmt, ...) \ +-({ \ +- if (0) \ +- dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ +-}) ++ dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__) + #endif + + /* +-- +2.43.0 + diff --git a/queue-6.8/dlm-fix-user-space-lock-decision-to-copy-lvb.patch b/queue-6.8/dlm-fix-user-space-lock-decision-to-copy-lvb.patch new file mode 100644 index 00000000000..aea2712cae5 --- /dev/null +++ b/queue-6.8/dlm-fix-user-space-lock-decision-to-copy-lvb.patch @@ -0,0 +1,143 @@ +From fcd6fede0cfc7bd4f2b3711532bc71905217aba1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 11:48:33 -0400 +Subject: dlm: fix user space lock decision to copy lvb + +From: Alexander Aring + +[ Upstream commit ad191e0eeebf64a60ca2d16ca01a223d2b1dd25e ] + +This patch fixes the copy lvb decision for user space lock requests. +Checking dlm_lvb_operations is done earlier, where granted/requested +lock modes are available to use in the matrix. + +The decision had been moved to the wrong location, where granted mode +and requested mode where the same, which causes the dlm_lvb_operations +matix to produce the wrong copy decision. For PW or EX requests, the +caller could get invalid lvb data. + +Fixes: 61bed0baa4db ("fs: dlm: use a non-static queue for callbacks") +Signed-off-by: Alexander Aring +Signed-off-by: David Teigland +Signed-off-by: Sasha Levin +--- + fs/dlm/ast.c | 14 ++++++++++++++ + fs/dlm/dlm_internal.h | 1 + + fs/dlm/user.c | 15 ++------------- + 3 files changed, 17 insertions(+), 13 deletions(-) + +diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c +index 1f2f70a1b824e..decedc4ee15f6 100644 +--- a/fs/dlm/ast.c ++++ b/fs/dlm/ast.c +@@ -12,6 +12,7 @@ + #include + + #include "dlm_internal.h" ++#include "lvb_table.h" + #include "memory.h" + #include "lock.h" + #include "user.h" +@@ -42,6 +43,7 @@ int dlm_enqueue_lkb_callback(struct dlm_lkb *lkb, uint32_t flags, int mode, + struct dlm_ls *ls = lkb->lkb_resource->res_ls; + int rv = DLM_ENQUEUE_CALLBACK_SUCCESS; + struct dlm_callback *cb; ++ int copy_lvb = 0; + int prev_mode; + + if (flags & DLM_CB_BAST) { +@@ -73,6 +75,17 @@ int dlm_enqueue_lkb_callback(struct dlm_lkb *lkb, uint32_t flags, int mode, + goto out; + } + } ++ } else if (flags & DLM_CB_CAST) { ++ if (test_bit(DLM_DFL_USER_BIT, &lkb->lkb_dflags)) { ++ if (lkb->lkb_last_cast) ++ prev_mode = lkb->lkb_last_cb->mode; ++ else ++ prev_mode = -1; ++ ++ if (!status && lkb->lkb_lksb->sb_lvbptr && ++ dlm_lvb_operations[prev_mode + 1][mode + 1]) ++ copy_lvb = 1; ++ } + } + + cb = dlm_allocate_cb(); +@@ -85,6 +98,7 @@ int dlm_enqueue_lkb_callback(struct dlm_lkb *lkb, uint32_t flags, int mode, + cb->mode = mode; + cb->sb_status = status; + cb->sb_flags = (sbflags & 0x000000FF); ++ cb->copy_lvb = copy_lvb; + kref_init(&cb->ref); + if (!test_and_set_bit(DLM_IFL_CB_PENDING_BIT, &lkb->lkb_iflags)) + rv = DLM_ENQUEUE_CALLBACK_NEED_SCHED; +diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h +index dfc444dad3298..511d0b984f580 100644 +--- a/fs/dlm/dlm_internal.h ++++ b/fs/dlm/dlm_internal.h +@@ -222,6 +222,7 @@ struct dlm_callback { + int sb_status; /* copy to lksb status */ + uint8_t sb_flags; /* copy to lksb flags */ + int8_t mode; /* rq mode of bast, gr mode of cast */ ++ int copy_lvb; + + struct list_head list; + struct kref ref; +diff --git a/fs/dlm/user.c b/fs/dlm/user.c +index 9f9b68448830e..12a483deeef5e 100644 +--- a/fs/dlm/user.c ++++ b/fs/dlm/user.c +@@ -21,7 +21,6 @@ + #include "dlm_internal.h" + #include "lockspace.h" + #include "lock.h" +-#include "lvb_table.h" + #include "user.h" + #include "ast.h" + #include "config.h" +@@ -806,8 +805,7 @@ static ssize_t device_read(struct file *file, char __user *buf, size_t count, + struct dlm_lkb *lkb; + DECLARE_WAITQUEUE(wait, current); + struct dlm_callback *cb; +- int rv, ret, copy_lvb = 0; +- int old_mode, new_mode; ++ int rv, ret; + + if (count == sizeof(struct dlm_device_version)) { + rv = copy_version_to_user(buf, count); +@@ -864,9 +862,6 @@ static ssize_t device_read(struct file *file, char __user *buf, size_t count, + + lkb = list_first_entry(&proc->asts, struct dlm_lkb, lkb_cb_list); + +- /* rem_lkb_callback sets a new lkb_last_cast */ +- old_mode = lkb->lkb_last_cast->mode; +- + rv = dlm_dequeue_lkb_callback(lkb, &cb); + switch (rv) { + case DLM_DEQUEUE_CALLBACK_EMPTY: +@@ -895,12 +890,6 @@ static ssize_t device_read(struct file *file, char __user *buf, size_t count, + if (cb->flags & DLM_CB_BAST) { + trace_dlm_bast(lkb->lkb_resource->res_ls, lkb, cb->mode); + } else if (cb->flags & DLM_CB_CAST) { +- new_mode = cb->mode; +- +- if (!cb->sb_status && lkb->lkb_lksb->sb_lvbptr && +- dlm_lvb_operations[old_mode + 1][new_mode + 1]) +- copy_lvb = 1; +- + lkb->lkb_lksb->sb_status = cb->sb_status; + lkb->lkb_lksb->sb_flags = cb->sb_flags; + trace_dlm_ast(lkb->lkb_resource->res_ls, lkb); +@@ -908,7 +897,7 @@ static ssize_t device_read(struct file *file, char __user *buf, size_t count, + + ret = copy_result_to_user(lkb->lkb_ua, + test_bit(DLM_PROC_FLAGS_COMPAT, &proc->flags), +- cb->flags, cb->mode, copy_lvb, buf, count); ++ cb->flags, cb->mode, cb->copy_lvb, buf, count); + + kref_put(&cb->ref, dlm_release_callback); + +-- +2.43.0 + diff --git a/queue-6.8/dm-delay-fix-hung-task-introduced-by-kthread-mode.patch b/queue-6.8/dm-delay-fix-hung-task-introduced-by-kthread-mode.patch new file mode 100644 index 00000000000..b0d3bb5da20 --- /dev/null +++ b/queue-6.8/dm-delay-fix-hung-task-introduced-by-kthread-mode.patch @@ -0,0 +1,43 @@ +From 7c5226d5c8620a4b1838cbae958ea483f65b19ed Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 09:25:23 +0200 +Subject: dm-delay: fix hung task introduced by kthread mode + +From: Joel Colledge + +[ Upstream commit d14646f23300a5fc85be867bafdc0702c2002789 ] + +If the worker thread is not woken due to a bio, then it is not woken at +all. This causes the hung task check to trigger. This occurs, for +instance, when no bios are submitted. Also when a delay of 0 is +configured, delay_bio() returns without waking the worker. + +Prevent the hung task check from triggering by creating the thread with +kthread_run() instead of using kthread_create() directly. + +Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq") +Signed-off-by: Joel Colledge +Reviewed-by: Benjamin Marzinski +Signed-off-by: Mike Snitzer +Signed-off-by: Sasha Levin +--- + drivers/md/dm-delay.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/md/dm-delay.c b/drivers/md/dm-delay.c +index eec0daa4b227a..4ba12d5369949 100644 +--- a/drivers/md/dm-delay.c ++++ b/drivers/md/dm-delay.c +@@ -269,8 +269,7 @@ static int delay_ctr(struct dm_target *ti, unsigned int argc, char **argv) + * In case of small requested delays, use kthread instead of + * timers and workqueue to achieve better latency. + */ +- dc->worker = kthread_create(&flush_worker_fn, dc, +- "dm-delay-flush-worker"); ++ dc->worker = kthread_run(&flush_worker_fn, dc, "dm-delay-flush-worker"); + if (IS_ERR(dc->worker)) { + ret = PTR_ERR(dc->worker); + dc->worker = NULL; +-- +2.43.0 + diff --git a/queue-6.8/dm-delay-fix-max_delay-calculations.patch b/queue-6.8/dm-delay-fix-max_delay-calculations.patch new file mode 100644 index 00000000000..2457a0b681f --- /dev/null +++ b/queue-6.8/dm-delay-fix-max_delay-calculations.patch @@ -0,0 +1,51 @@ +From 2b03ce8b7380cd7ed966f353783644e56f708357 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 17:55:44 -0400 +Subject: dm-delay: fix max_delay calculations + +From: Benjamin Marzinski + +[ Upstream commit 64eb88d6caee2c8eb806a68dab3f184f14f818a4 ] + +delay_ctr() pointlessly compared max_delay in cases where multiple delay +classes were initialized identically. Also, when write delays were +configured different than read delays, delay_ctr() never compared their +value against max_delay. Fix these issues. + +Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq") +Signed-off-by: Benjamin Marzinski +Signed-off-by: Mike Snitzer +Signed-off-by: Sasha Levin +--- + drivers/md/dm-delay.c | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/drivers/md/dm-delay.c b/drivers/md/dm-delay.c +index 4ba12d5369949..2ac43d1f1b92c 100644 +--- a/drivers/md/dm-delay.c ++++ b/drivers/md/dm-delay.c +@@ -242,19 +242,18 @@ static int delay_ctr(struct dm_target *ti, unsigned int argc, char **argv) + ret = delay_class_ctr(ti, &dc->flush, argv); + if (ret) + goto bad; +- max_delay = max(max_delay, dc->write.delay); +- max_delay = max(max_delay, dc->flush.delay); + goto out; + } + + ret = delay_class_ctr(ti, &dc->write, argv + 3); + if (ret) + goto bad; ++ max_delay = max(max_delay, dc->write.delay); ++ + if (argc == 6) { + ret = delay_class_ctr(ti, &dc->flush, argv + 3); + if (ret) + goto bad; +- max_delay = max(max_delay, dc->flush.delay); + goto out; + } + +-- +2.43.0 + diff --git a/queue-6.8/dm-delay-fix-workqueue-delay_timer-race.patch b/queue-6.8/dm-delay-fix-workqueue-delay_timer-race.patch new file mode 100644 index 00000000000..61c7a4d1136 --- /dev/null +++ b/queue-6.8/dm-delay-fix-workqueue-delay_timer-race.patch @@ -0,0 +1,55 @@ +From c16fad1e8e5abdf96db76c406ef7b8528020c01b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 May 2024 17:16:23 -0400 +Subject: dm-delay: fix workqueue delay_timer race + +From: Benjamin Marzinski + +[ Upstream commit 8d24790ed08ab4e619ce58ed4a1b353ab77ffdc5 ] + +delay_timer could be pending when delay_dtr() is called. It needs to be +shut down before kdelayd_wq is destroyed, so it won't try queueing more +work to kdelayd_wq while that's getting destroyed. + +Also the del_timer_sync() call in delay_presuspend() doesn't protect +against the timer getting immediately rearmed by the queued call to +flush_delayed_bios(), but there's no real harm if that does happen. +timer_delete() is less work, and is basically just as likely to stop a +pointless call to flush_delayed_bios(). + +Fixes: 26b9f228703f ("dm: delay target") +Signed-off-by: Benjamin Marzinski +Signed-off-by: Mike Snitzer +Signed-off-by: Sasha Levin +--- + drivers/md/dm-delay.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/md/dm-delay.c b/drivers/md/dm-delay.c +index 5eabdb06c6498..eec0daa4b227a 100644 +--- a/drivers/md/dm-delay.c ++++ b/drivers/md/dm-delay.c +@@ -154,8 +154,10 @@ static void delay_dtr(struct dm_target *ti) + { + struct delay_c *dc = ti->private; + +- if (dc->kdelayd_wq) ++ if (dc->kdelayd_wq) { ++ timer_shutdown_sync(&dc->delay_timer); + destroy_workqueue(dc->kdelayd_wq); ++ } + + if (dc->read.dev) + dm_put_device(ti, dc->read.dev); +@@ -335,7 +337,7 @@ static void delay_presuspend(struct dm_target *ti) + mutex_unlock(&delayed_bios_lock); + + if (!delay_is_fast(dc)) +- del_timer_sync(&dc->delay_timer); ++ timer_delete(&dc->delay_timer); + flush_delayed_bios(dc, true); + } + +-- +2.43.0 + diff --git a/queue-6.8/dmaengine-xilinx-xdma-clarify-kdoc-in-xdma-driver.patch b/queue-6.8/dmaengine-xilinx-xdma-clarify-kdoc-in-xdma-driver.patch new file mode 100644 index 00000000000..82487991150 --- /dev/null +++ b/queue-6.8/dmaengine-xilinx-xdma-clarify-kdoc-in-xdma-driver.patch @@ -0,0 +1,50 @@ +From f6e4f06b263ffe2c810988069b1c2193bcfffc96 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 10:58:50 +0100 +Subject: dmaengine: xilinx: xdma: Clarify kdoc in XDMA driver + +From: Miquel Raynal + +[ Upstream commit 7a71c6dc21d5ae83ab27c39a67845d6d23ac271f ] + +Clarify the kernel doc of xdma_fill_descs(), especially how big chunks +will be handled. + +Signed-off-by: Miquel Raynal +Signed-off-by: Louis Chauvet +Link: https://lore.kernel.org/stable/20240327-digigram-xdma-fixes-v1-3-45f4a52c0283%40bootlin.com +Link: https://lore.kernel.org/r/20240327-digigram-xdma-fixes-v1-3-45f4a52c0283@bootlin.com +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/dma/xilinx/xdma.c | 14 ++++++++------ + 1 file changed, 8 insertions(+), 6 deletions(-) + +diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c +index 5a3a3293b21b5..313b217388fe9 100644 +--- a/drivers/dma/xilinx/xdma.c ++++ b/drivers/dma/xilinx/xdma.c +@@ -554,12 +554,14 @@ static void xdma_synchronize(struct dma_chan *chan) + } + + /** +- * xdma_fill_descs - Fill hardware descriptors with contiguous memory block addresses +- * @sw_desc: tx descriptor state container +- * @src_addr: Value for a ->src_addr field of a first descriptor +- * @dst_addr: Value for a ->dst_addr field of a first descriptor +- * @size: Total size of a contiguous memory block +- * @filled_descs_num: Number of filled hardware descriptors for corresponding sw_desc ++ * xdma_fill_descs() - Fill hardware descriptors for one contiguous memory chunk. ++ * More than one descriptor will be used if the size is bigger ++ * than XDMA_DESC_BLEN_MAX. ++ * @sw_desc: Descriptor container ++ * @src_addr: First value for the ->src_addr field ++ * @dst_addr: First value for the ->dst_addr field ++ * @size: Size of the contiguous memory block ++ * @filled_descs_num: Index of the first descriptor to take care of in @sw_desc + */ + static inline u32 xdma_fill_descs(struct xdma_desc *sw_desc, u64 src_addr, + u64 dst_addr, u32 size, u32 filled_descs_num) +-- +2.43.0 + diff --git a/queue-6.8/dpll-fix-return-value-check-for-kmemdup.patch b/queue-6.8/dpll-fix-return-value-check-for-kmemdup.patch new file mode 100644 index 00000000000..3f23671fa5b --- /dev/null +++ b/queue-6.8/dpll-fix-return-value-check-for-kmemdup.patch @@ -0,0 +1,40 @@ +From 5bd0f74401778ce13b9eecb573c90345543a2741 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 11:28:24 +0800 +Subject: dpll: fix return value check for kmemdup + +From: Chen Ni + +[ Upstream commit ad506586cb69292b6ac59ab95468aadd54b19ab7 ] + +The return value of kmemdup() is dst->freq_supported, not +src->freq_supported. Update the check accordingly. + +Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") +Signed-off-by: Chen Ni +Reviewed-by: Przemek Kitszel +Reviewed-by: Arkadiusz Kubalewski +Reviewed-by: Jiri Pirko +Link: https://lore.kernel.org/r/20240513032824.2410459-1-nichen@iscas.ac.cn +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/dpll/dpll_core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c +index a6856730ca90f..22c2f1375e867 100644 +--- a/drivers/dpll/dpll_core.c ++++ b/drivers/dpll/dpll_core.c +@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, + sizeof(*src->freq_supported); + dst->freq_supported = kmemdup(src->freq_supported, + freq_size, GFP_KERNEL); +- if (!src->freq_supported) ++ if (!dst->freq_supported) + return -ENOMEM; + } + if (src->board_label) { +-- +2.43.0 + diff --git a/queue-6.8/drivers-perf-hisi-hns3-actually-use-devm_add_action_.patch b/queue-6.8/drivers-perf-hisi-hns3-actually-use-devm_add_action_.patch new file mode 100644 index 00000000000..ed5d3778bc2 --- /dev/null +++ b/queue-6.8/drivers-perf-hisi-hns3-actually-use-devm_add_action_.patch @@ -0,0 +1,43 @@ +From 9a0771ee4e6412fcffefc34c950432fb6981a161 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 20:46:27 +0800 +Subject: drivers/perf: hisi: hns3: Actually use devm_add_action_or_reset() + +From: Hao Chen + +[ Upstream commit 582c1aeee0a9e73010cf1c4cef338709860deeb0 ] + +pci_alloc_irq_vectors() allocates an irq vector. When devm_add_action() +fails, the irq vector is not freed, which leads to a memory leak. + +Replace the devm_add_action with devm_add_action_or_reset to ensure +the irq vector can be destroyed when it fails. + +Fixes: 66637ab137b4 ("drivers/perf: hisi: add driver for HNS3 PMU") +Signed-off-by: Hao Chen +Signed-off-by: Junhao He +Reviewed-by: Jijie Shao +Acked-by: Jonathan Cameron +Link: https://lore.kernel.org/r/20240425124627.13764-4-hejunhao3@huawei.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + drivers/perf/hisilicon/hns3_pmu.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/perf/hisilicon/hns3_pmu.c b/drivers/perf/hisilicon/hns3_pmu.c +index cbdd53b0a0342..60062eaa342aa 100644 +--- a/drivers/perf/hisilicon/hns3_pmu.c ++++ b/drivers/perf/hisilicon/hns3_pmu.c +@@ -1527,7 +1527,7 @@ static int hns3_pmu_irq_register(struct pci_dev *pdev, + return ret; + } + +- ret = devm_add_action(&pdev->dev, hns3_pmu_free_irq, pdev); ++ ret = devm_add_action_or_reset(&pdev->dev, hns3_pmu_free_irq, pdev); + if (ret) { + pci_err(pdev, "failed to add free irq action, ret = %d.\n", ret); + return ret; +-- +2.43.0 + diff --git a/queue-6.8/drivers-perf-hisi-hns3-fix-out-of-bound-access-when-.patch b/queue-6.8/drivers-perf-hisi-hns3-fix-out-of-bound-access-when-.patch new file mode 100644 index 00000000000..9be4a337693 --- /dev/null +++ b/queue-6.8/drivers-perf-hisi-hns3-fix-out-of-bound-access-when-.patch @@ -0,0 +1,70 @@ +From c71ea91d874156b9cb7fd597b1150ef84bfe2953 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 20:46:26 +0800 +Subject: drivers/perf: hisi: hns3: Fix out-of-bound access when valid event + group + +From: Junhao He + +[ Upstream commit 81bdd60a3d1d3b05e6cc6674845afb1694dd3a0e ] + +The perf tool allows users to create event groups through following +cmd [1], but the driver does not check whether the array index is out +of bounds when writing data to the event_group array. If the number of +events in an event_group is greater than HNS3_PMU_MAX_HW_EVENTS, the +memory write overflow of event_group array occurs. + +Add array index check to fix the possible array out of bounds violation, +and return directly when write new events are written to array bounds. + +There are 9 different events in an event_group. +[1] perf stat -e '{pmu/event1/, ... ,pmu/event9/} + +Fixes: 66637ab137b4 ("drivers/perf: hisi: add driver for HNS3 PMU") +Signed-off-by: Junhao He +Signed-off-by: Hao Chen +Acked-by: Jonathan Cameron +Reviewed-by: Jijie Shao +Link: https://lore.kernel.org/r/20240425124627.13764-3-hejunhao3@huawei.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + drivers/perf/hisilicon/hns3_pmu.c | 14 +++++++++++++- + 1 file changed, 13 insertions(+), 1 deletion(-) + +diff --git a/drivers/perf/hisilicon/hns3_pmu.c b/drivers/perf/hisilicon/hns3_pmu.c +index 16869bf5bf4cc..cbdd53b0a0342 100644 +--- a/drivers/perf/hisilicon/hns3_pmu.c ++++ b/drivers/perf/hisilicon/hns3_pmu.c +@@ -1085,15 +1085,27 @@ static bool hns3_pmu_validate_event_group(struct perf_event *event) + return false; + + for (num = 0; num < counters; num++) { ++ /* ++ * If we find a related event, then it's a valid group ++ * since we don't need to allocate a new counter for it. ++ */ + if (hns3_pmu_cmp_event(event_group[num], sibling)) + break; + } + ++ /* ++ * Otherwise it's a new event but if there's no available counter, ++ * fail the check since we cannot schedule all the events in ++ * the group simultaneously. ++ */ ++ if (num == HNS3_PMU_MAX_HW_EVENTS) ++ return false; ++ + if (num == counters) + event_group[counters++] = sibling; + } + +- return counters <= HNS3_PMU_MAX_HW_EVENTS; ++ return true; + } + + static u32 hns3_pmu_get_filter_condition(struct perf_event *event) +-- +2.43.0 + diff --git a/queue-6.8/drivers-perf-hisi_pcie-fix-out-of-bound-access-when-.patch b/queue-6.8/drivers-perf-hisi_pcie-fix-out-of-bound-access-when-.patch new file mode 100644 index 00000000000..4107d3b1625 --- /dev/null +++ b/queue-6.8/drivers-perf-hisi_pcie-fix-out-of-bound-access-when-.patch @@ -0,0 +1,69 @@ +From 7c76d147d3557c70c2ce0a76681481703e24f6a7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 20:46:25 +0800 +Subject: drivers/perf: hisi_pcie: Fix out-of-bound access when valid event + group + +From: Junhao He + +[ Upstream commit 77fce82678ea5fd51442e62febec2004f79e041b ] + +The perf tool allows users to create event groups through following +cmd [1], but the driver does not check whether the array index is out of +bounds when writing data to the event_group array. If the number of events +in an event_group is greater than HISI_PCIE_MAX_COUNTERS, the memory write +overflow of event_group array occurs. + +Add array index check to fix the possible array out of bounds violation, +and return directly when write new events are written to array bounds. + +There are 9 different events in an event_group. +[1] perf stat -e '{pmu/event1/, ... ,pmu/event9/}' + +Fixes: 8404b0fbc7fb ("drivers/perf: hisi: Add driver for HiSilicon PCIe PMU") +Signed-off-by: Junhao He +Reviewed-by: Jijie Shao +Acked-by: Jonathan Cameron +Link: https://lore.kernel.org/r/20240425124627.13764-2-hejunhao3@huawei.com +Signed-off-by: Will Deacon +Signed-off-by: Sasha Levin +--- + drivers/perf/hisilicon/hisi_pcie_pmu.c | 14 +++++++++++++- + 1 file changed, 13 insertions(+), 1 deletion(-) + +diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c +index b90ba8aca3fa5..ec4d5fc30781c 100644 +--- a/drivers/perf/hisilicon/hisi_pcie_pmu.c ++++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c +@@ -337,15 +337,27 @@ static bool hisi_pcie_pmu_validate_event_group(struct perf_event *event) + return false; + + for (num = 0; num < counters; num++) { ++ /* ++ * If we find a related event, then it's a valid group ++ * since we don't need to allocate a new counter for it. ++ */ + if (hisi_pcie_pmu_cmp_event(event_group[num], sibling)) + break; + } + ++ /* ++ * Otherwise it's a new event but if there's no available counter, ++ * fail the check since we cannot schedule all the events in ++ * the group simultaneously. ++ */ ++ if (num == HISI_PCIE_MAX_COUNTERS) ++ return false; ++ + if (num == counters) + event_group[counters++] = sibling; + } + +- return counters <= HISI_PCIE_MAX_COUNTERS; ++ return true; + } + + static int hisi_pcie_pmu_event_init(struct perf_event *event) +-- +2.43.0 + diff --git a/queue-6.8/drivers-virt-acrn-fix-pfnmap-pte-checks-in-acrn_vm_r.patch b/queue-6.8/drivers-virt-acrn-fix-pfnmap-pte-checks-in-acrn_vm_r.patch new file mode 100644 index 00000000000..ee8f1680315 --- /dev/null +++ b/queue-6.8/drivers-virt-acrn-fix-pfnmap-pte-checks-in-acrn_vm_r.patch @@ -0,0 +1,195 @@ +From ffee58b28b1707edb88607b910b680989838ecc4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 17:55:25 +0200 +Subject: drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map() + +From: David Hildenbrand + +[ Upstream commit 3d6586008f7b638f91f3332602592caa8b00b559 ] + +Patch series "mm: follow_pte() improvements and acrn follow_pte() fixes". + +Patch #1 fixes a bunch of issues I spotted in the acrn driver. It +compiles, that's all I know. I'll appreciate some review and testing from +acrn folks. + +Patch #2+#3 improve follow_pte(), passing a VMA instead of the MM, adding +more sanity checks, and improving the documentation. Gave it a quick test +on x86-64 using VM_PAT that ends up using follow_pte(). + +This patch (of 3): + +We currently miss handling various cases, resulting in a dangerous +follow_pte() (previously follow_pfn()) usage. + +(1) We're not checking PTE write permissions. + +Maybe we should simply always require pte_write() like we do for +pin_user_pages_fast(FOLL_WRITE)? Hard to tell, so let's check for +ACRN_MEM_ACCESS_WRITE for now. + +(2) We're not rejecting refcounted pages. + +As we are not using MMU notifiers, messing with refcounted pages is +dangerous and can result in use-after-free. Let's make sure to reject them. + +(3) We are only looking at the first PTE of a bigger range. + +We only lookup a single PTE, but memmap->len may span a larger area. +Let's loop over all involved PTEs and make sure the PFN range is +actually contiguous. Reject everything else: it couldn't have worked +either way, and rather made use access PFNs we shouldn't be accessing. + +Link: https://lkml.kernel.org/r/20240410155527.474777-1-david@redhat.com +Link: https://lkml.kernel.org/r/20240410155527.474777-2-david@redhat.com +Fixes: 8a6e85f75a83 ("virt: acrn: obtain pa from VMA with PFNMAP flag") +Signed-off-by: David Hildenbrand +Cc: Alex Williamson +Cc: Christoph Hellwig +Cc: Fei Li +Cc: Gerald Schaefer +Cc: Heiko Carstens +Cc: Ingo Molnar +Cc: Paolo Bonzini +Cc: Yonghua Huang +Cc: Sean Christopherson +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + drivers/virt/acrn/mm.c | 63 +++++++++++++++++++++++++++++++----------- + 1 file changed, 47 insertions(+), 16 deletions(-) + +diff --git a/drivers/virt/acrn/mm.c b/drivers/virt/acrn/mm.c +index 69c3f619f8819..9c75de0656d8d 100644 +--- a/drivers/virt/acrn/mm.c ++++ b/drivers/virt/acrn/mm.c +@@ -155,23 +155,29 @@ int acrn_vm_memseg_unmap(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + { + struct vm_memory_region_batch *regions_info; +- int nr_pages, i = 0, order, nr_regions = 0; ++ int nr_pages, i, order, nr_regions = 0; + struct vm_memory_mapping *region_mapping; + struct vm_memory_region_op *vm_region; + struct page **pages = NULL, *page; + void *remap_vaddr; + int ret, pinned; + u64 user_vm_pa; +- unsigned long pfn; + struct vm_area_struct *vma; + + if (!vm || !memmap) + return -EINVAL; + ++ /* Get the page number of the map region */ ++ nr_pages = memmap->len >> PAGE_SHIFT; ++ if (!nr_pages) ++ return -EINVAL; ++ + mmap_read_lock(current->mm); + vma = vma_lookup(current->mm, memmap->vma_base); + if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) { ++ unsigned long start_pfn, cur_pfn; + spinlock_t *ptl; ++ bool writable; + pte_t *ptep; + + if ((memmap->vma_base + memmap->len) > vma->vm_end) { +@@ -179,25 +185,53 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + return -EINVAL; + } + +- ret = follow_pte(vma->vm_mm, memmap->vma_base, &ptep, &ptl); +- if (ret < 0) { +- mmap_read_unlock(current->mm); ++ for (i = 0; i < nr_pages; i++) { ++ ret = follow_pte(vma->vm_mm, ++ memmap->vma_base + i * PAGE_SIZE, ++ &ptep, &ptl); ++ if (ret) ++ break; ++ ++ cur_pfn = pte_pfn(ptep_get(ptep)); ++ if (i == 0) ++ start_pfn = cur_pfn; ++ writable = !!pte_write(ptep_get(ptep)); ++ pte_unmap_unlock(ptep, ptl); ++ ++ /* Disallow write access if the PTE is not writable. */ ++ if (!writable && ++ (memmap->attr & ACRN_MEM_ACCESS_WRITE)) { ++ ret = -EFAULT; ++ break; ++ } ++ ++ /* Disallow refcounted pages. */ ++ if (pfn_valid(cur_pfn) && ++ !PageReserved(pfn_to_page(cur_pfn))) { ++ ret = -EFAULT; ++ break; ++ } ++ ++ /* Disallow non-contiguous ranges. */ ++ if (cur_pfn != start_pfn + i) { ++ ret = -EINVAL; ++ break; ++ } ++ } ++ mmap_read_unlock(current->mm); ++ ++ if (ret) { + dev_dbg(acrn_dev.this_device, + "Failed to lookup PFN at VMA:%pK.\n", (void *)memmap->vma_base); + return ret; + } +- pfn = pte_pfn(ptep_get(ptep)); +- pte_unmap_unlock(ptep, ptl); +- mmap_read_unlock(current->mm); + + return acrn_mm_region_add(vm, memmap->user_vm_pa, +- PFN_PHYS(pfn), memmap->len, ++ PFN_PHYS(start_pfn), memmap->len, + ACRN_MEM_TYPE_WB, memmap->attr); + } + mmap_read_unlock(current->mm); + +- /* Get the page number of the map region */ +- nr_pages = memmap->len >> PAGE_SHIFT; + pages = vzalloc(array_size(nr_pages, sizeof(*pages))); + if (!pages) + return -ENOMEM; +@@ -241,12 +275,11 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + mutex_unlock(&vm->regions_mapping_lock); + + /* Calculate count of vm_memory_region_op */ +- while (i < nr_pages) { ++ for (i = 0; i < nr_pages; i += 1 << order) { + page = pages[i]; + VM_BUG_ON_PAGE(PageTail(page), page); + order = compound_order(page); + nr_regions++; +- i += 1 << order; + } + + /* Prepare the vm_memory_region_batch */ +@@ -263,8 +296,7 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + regions_info->vmid = vm->vmid; + regions_info->regions_gpa = virt_to_phys(vm_region); + user_vm_pa = memmap->user_vm_pa; +- i = 0; +- while (i < nr_pages) { ++ for (i = 0; i < nr_pages; i += 1 << order) { + u32 region_size; + + page = pages[i]; +@@ -280,7 +312,6 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + + vm_region++; + user_vm_pa += region_size; +- i += 1 << order; + } + + /* Inform the ACRN Hypervisor to set up EPT mappings */ +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-add-dtbclk-access-to-dcn315.patch b/queue-6.8/drm-amd-display-add-dtbclk-access-to-dcn315.patch new file mode 100644 index 00000000000..e011322fec1 --- /dev/null +++ b/queue-6.8/drm-amd-display-add-dtbclk-access-to-dcn315.patch @@ -0,0 +1,55 @@ +From 2472a5de81babded8ebce25f732e1f4c12cc1e2d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 21:07:46 -0400 +Subject: drm/amd/display: Add dtbclk access to dcn315 + +From: Swapnil Patel + +[ Upstream commit a01b64f31d65bdc917d1afb4cec9915beb6931be ] + +[Why & How] + +Currently DCN315 clk manager is missing code to enable/disable dtbclk. +Because of this, "optimized_required" flag is constantly set +and this prevents FreeSync from engaging for certain high bandwidth +display Modes which require DTBCLK. + +Reviewed-by: Dmytro Laktyushkin +Acked-by: Aurabindo Pillai +Signed-off-by: Swapnil Patel +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + .../drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c +index 644da46373209..5506cf9b3672f 100644 +--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c ++++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c +@@ -145,6 +145,10 @@ static void dcn315_update_clocks(struct clk_mgr *clk_mgr_base, + */ + clk_mgr_base->clks.zstate_support = new_clocks->zstate_support; + if (safe_to_lower) { ++ if (clk_mgr_base->clks.dtbclk_en && !new_clocks->dtbclk_en) { ++ dcn315_smu_set_dtbclk(clk_mgr, false); ++ clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en; ++ } + /* check that we're not already in lower */ + if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_LOW_POWER) { + display_count = dcn315_get_active_display_cnt_wa(dc, context); +@@ -160,6 +164,10 @@ static void dcn315_update_clocks(struct clk_mgr *clk_mgr_base, + } + } + } else { ++ if (!clk_mgr_base->clks.dtbclk_en && new_clocks->dtbclk_en) { ++ dcn315_smu_set_dtbclk(clk_mgr, true); ++ clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en; ++ } + /* check that we're not already in D0 */ + if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_MISSION_MODE) { + union display_idle_optimization_u idle_info = { 0 }; +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-add-vco-speed-parameter-for-dcn31-fp.patch b/queue-6.8/drm-amd-display-add-vco-speed-parameter-for-dcn31-fp.patch new file mode 100644 index 00000000000..2c34fe62a1a --- /dev/null +++ b/queue-6.8/drm-amd-display-add-vco-speed-parameter-for-dcn31-fp.patch @@ -0,0 +1,43 @@ +From 8720a724d545660869f7de4dfb0954a3787df8a2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 11:19:03 -0600 +Subject: drm/amd/display: Add VCO speed parameter for DCN31 FPU + +From: Rodrigo Siqueira + +[ Upstream commit 0e62103bdcbc88281e16add299a946fb3bd02fbe ] + +Add VCO speed parameters in the bounding box array. + +Acked-by: Wayne Lin +Signed-off-by: Rodrigo Siqueira +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c +index deb6d162a2d5c..7307b7b8d8ad7 100644 +--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c ++++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c +@@ -291,6 +291,7 @@ static struct _vcs_dpi_soc_bounding_box_st dcn3_15_soc = { + .do_urgent_latency_adjustment = false, + .urgent_latency_adjustment_fabric_clock_component_us = 0, + .urgent_latency_adjustment_fabric_clock_reference_mhz = 0, ++ .dispclk_dppclk_vco_speed_mhz = 2400.0, + .num_chans = 4, + .dummy_pstate_latency_us = 10.0 + }; +@@ -438,6 +439,7 @@ static struct _vcs_dpi_soc_bounding_box_st dcn3_16_soc = { + .do_urgent_latency_adjustment = false, + .urgent_latency_adjustment_fabric_clock_component_us = 0, + .urgent_latency_adjustment_fabric_clock_reference_mhz = 0, ++ .dispclk_dppclk_vco_speed_mhz = 2500.0, + }; + + void dcn31_zero_pipe_dcc_fraction(display_e2e_pipe_params_st *pipes, +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-allocate-zero-bw-after-bw-alloc-enab.patch b/queue-6.8/drm-amd-display-allocate-zero-bw-after-bw-alloc-enab.patch new file mode 100644 index 00000000000..aad8c9a7dd7 --- /dev/null +++ b/queue-6.8/drm-amd-display-allocate-zero-bw-after-bw-alloc-enab.patch @@ -0,0 +1,62 @@ +From 3751b357def7d16d8588fba102eb144d759a0fed Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 10:46:35 -0400 +Subject: drm/amd/display: Allocate zero bw after bw alloc enable + +From: Meenakshikumar Somasundaram + +[ Upstream commit 46fe9cb1a9e62f4e6229f48ae303ef8e6c1fdc64 ] + +[Why] +During DP tunnel creation, CM preallocates BW and reduces +estimated BW of other DPIA. CM release preallocation only +when allocation is complete. Display mode validation logic +validates timings based on bw available per host router. +In multi display setup, this causes bw allocation failure +when allocation greater than estimated bw. + +[How] +Do zero alloc to make the CM to release preallocation and +update estimated BW correctly for all DPIAs per host router. + +Reviewed-by: PeiChen Huang +Acked-by: Aurabindo Pillai +Signed-off-by: Meenakshikumar Somasundaram +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + .../amd/display/dc/link/protocols/link_dp_dpia_bw.c | 10 +++++++++- + 1 file changed, 9 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c +index 5491b707cec88..5a965c26bf209 100644 +--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c ++++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c +@@ -270,7 +270,7 @@ static void set_usb4_req_bw_req(struct dc_link *link, int req_bw) + + /* Error check whether requested and allocated are equal */ + req_bw = requested_bw * (Kbps_TO_Gbps / link->dpia_bw_alloc_config.bw_granularity); +- if (req_bw == link->dpia_bw_alloc_config.allocated_bw) { ++ if (req_bw && (req_bw == link->dpia_bw_alloc_config.allocated_bw)) { + DC_LOG_ERROR("%s: Request bw equals to allocated bw for link(%d)\n", + __func__, link->link_index); + } +@@ -341,6 +341,14 @@ bool link_dp_dpia_set_dptx_usb4_bw_alloc_support(struct dc_link *link) + ret = true; + init_usb4_bw_struct(link); + link->dpia_bw_alloc_config.bw_alloc_enabled = true; ++ ++ /* ++ * During DP tunnel creation, CM preallocates BW and reduces estimated BW of other ++ * DPIA. CM release preallocation only when allocation is complete. Do zero alloc ++ * to make the CM to release preallocation and update estimated BW correctly for ++ * all DPIAs per host router ++ */ ++ link_dp_dpia_allocate_usb4_bandwidth_for_stream(link, 0); + } + } + +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-disable-seamless-boot-on-128b-132b-e.patch b/queue-6.8/drm-amd-display-disable-seamless-boot-on-128b-132b-e.patch new file mode 100644 index 00000000000..376794b6b68 --- /dev/null +++ b/queue-6.8/drm-amd-display-disable-seamless-boot-on-128b-132b-e.patch @@ -0,0 +1,43 @@ +From 809b3791438dee41068abbe562437e9036ebede2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 16:59:36 -0400 +Subject: drm/amd/display: Disable seamless boot on 128b/132b encoding + +From: Sung Joon Kim + +[ Upstream commit 6f0c228ed9184287031a66b46a79e5a3d2e73a86 ] + +[why] +preOS will not support display mode programming and link training +for UHBR rates. + +[how] +If we detect a sink that's UHBR capable, disable seamless boot + +Reviewed-by: Anthony Koo +Acked-by: Wayne Lin +Signed-off-by: Sung Joon Kim +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c +index 3c3d613c5f00e..040b5c2a57586 100644 +--- a/drivers/gpu/drm/amd/display/dc/core/dc.c ++++ b/drivers/gpu/drm/amd/display/dc/core/dc.c +@@ -1804,6 +1804,9 @@ bool dc_validate_boot_timing(const struct dc *dc, + return false; + } + ++ if (link->dpcd_caps.channel_coding_cap.bits.DP_128b_132b_SUPPORTED) ++ return false; ++ + if (dc->link_srv->edp_is_ilr_optimization_required(link, crtc_timing)) { + DC_LOG_EVENT_LINK_TRAINING("Seamless boot disabled to optimize eDP link rate\n"); + return false; +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-ensure-that-dmcub-support-flag-is-se.patch b/queue-6.8/drm-amd-display-ensure-that-dmcub-support-flag-is-se.patch new file mode 100644 index 00000000000..d4429e537ed --- /dev/null +++ b/queue-6.8/drm-amd-display-ensure-that-dmcub-support-flag-is-se.patch @@ -0,0 +1,36 @@ +From 7bfd116bd7767e12b17aea9c3bdf84ccdd1099f6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 17:38:08 -0600 +Subject: drm/amd/display: Ensure that dmcub support flag is set for DCN20 + +From: Rodrigo Siqueira + +[ Upstream commit be53bd4f00aa4c7db9f41116224c027b4cfce8e3 ] + +In the DCN20 resource initialization, ensure that DMCUB support starts +configured as true. + +Signed-off-by: Rodrigo Siqueira +Acked-by: Aurabindo Pillai +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c +index f9c5bc624be30..f81f6110913d3 100644 +--- a/drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c +@@ -2451,6 +2451,7 @@ static bool dcn20_resource_construct( + dc->caps.post_blend_color_processing = true; + dc->caps.force_dp_tps4_for_cp2520 = true; + dc->caps.extended_aux_timeout_support = true; ++ dc->caps.dmcub_support = true; + + /* Color pipeline capabilities */ + dc->caps.color.dpp.dcn_arch = 1; +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-fix-dc-mode-screen-flickering-on-dcn.patch b/queue-6.8/drm-amd-display-fix-dc-mode-screen-flickering-on-dcn.patch new file mode 100644 index 00000000000..ea97a299c62 --- /dev/null +++ b/queue-6.8/drm-amd-display-fix-dc-mode-screen-flickering-on-dcn.patch @@ -0,0 +1,61 @@ +From 364cdb4a56d9896b8f5771175669e005e1973401 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 17:17:04 -0400 +Subject: drm/amd/display: Fix DC mode screen flickering on DCN321 + +From: Leo Ma + +[ Upstream commit ce649bd2d834db83ecc2756a362c9a1ec61658a5 ] + +[Why && How] +Screen flickering saw on 4K@60 eDP with high refresh rate external +monitor when booting up in DC mode. DC Mode Capping is disabled +which caused wrong UCLK being used. + +Reviewed-by: Alvin Lee +Acked-by: Wayne Lin +Signed-off-by: Leo Ma +Tested-by: Daniel Wheeler +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + .../amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 15 ++++++++++++--- + 1 file changed, 12 insertions(+), 3 deletions(-) + +diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c +index bbdbc78161a00..39c63565baa9a 100644 +--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c ++++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c +@@ -696,8 +696,12 @@ static void dcn32_update_clocks(struct clk_mgr *clk_mgr_base, + * since we calculate mode support based on softmax being the max UCLK + * frequency. + */ +- dcn32_smu_set_hard_min_by_freq(clk_mgr, PPCLK_UCLK, +- dc->clk_mgr->bw_params->dc_mode_softmax_memclk); ++ if (dc->debug.disable_dc_mode_overwrite) { ++ dcn30_smu_set_hard_max_by_freq(clk_mgr, PPCLK_UCLK, dc->clk_mgr->bw_params->max_memclk_mhz); ++ dcn32_smu_set_hard_min_by_freq(clk_mgr, PPCLK_UCLK, dc->clk_mgr->bw_params->max_memclk_mhz); ++ } else ++ dcn32_smu_set_hard_min_by_freq(clk_mgr, PPCLK_UCLK, ++ dc->clk_mgr->bw_params->dc_mode_softmax_memclk); + } else { + dcn32_smu_set_hard_min_by_freq(clk_mgr, PPCLK_UCLK, dc->clk_mgr->bw_params->max_memclk_mhz); + } +@@ -730,8 +734,13 @@ static void dcn32_update_clocks(struct clk_mgr *clk_mgr_base, + /* set UCLK to requested value if P-State switching is supported, or to re-enable P-State switching */ + if (clk_mgr_base->clks.p_state_change_support && + (update_uclk || !clk_mgr_base->clks.prev_p_state_change_support) && +- !dc->work_arounds.clock_update_disable_mask.uclk) ++ !dc->work_arounds.clock_update_disable_mask.uclk) { ++ if (dc->clk_mgr->dc_mode_softmax_enabled && dc->debug.disable_dc_mode_overwrite) ++ dcn30_smu_set_hard_max_by_freq(clk_mgr, PPCLK_UCLK, ++ max((int)dc->clk_mgr->bw_params->dc_mode_softmax_memclk, khz_to_mhz_ceil(clk_mgr_base->clks.dramclk_khz))); ++ + dcn32_smu_set_hard_min_by_freq(clk_mgr, PPCLK_UCLK, khz_to_mhz_ceil(clk_mgr_base->clks.dramclk_khz)); ++ } + + if (clk_mgr_base->clks.num_ways != new_clocks->num_ways && + clk_mgr_base->clks.num_ways > new_clocks->num_ways) { +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-fix-potential-index-out-of-bounds-in.patch b/queue-6.8/drm-amd-display-fix-potential-index-out-of-bounds-in.patch new file mode 100644 index 00000000000..3a490494546 --- /dev/null +++ b/queue-6.8/drm-amd-display-fix-potential-index-out-of-bounds-in.patch @@ -0,0 +1,58 @@ +From e3b5b896fc579af09234468a3b9d1e21c2479e45 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Feb 2024 18:38:08 +0530 +Subject: drm/amd/display: Fix potential index out of bounds in color + transformation function + +From: Srinivasan Shanmugam + +[ Upstream commit 63ae548f1054a0b71678d0349c7dc9628ddd42ca ] + +Fixes index out of bounds issue in the color transformation function. +The issue could occur when the index 'i' exceeds the number of transfer +function points (TRANSFER_FUNC_POINTS). + +The fix adds a check to ensure 'i' is within bounds before accessing the +transfer function points. If 'i' is out of bounds, an error message is +logged and the function returns false to indicate an error. + +Reported by smatch: +drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:405 cm_helper_translate_curve_to_hw_format() error: buffer overflow 'output_tf->tf_pts.red' 1025 <= s32max +drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:406 cm_helper_translate_curve_to_hw_format() error: buffer overflow 'output_tf->tf_pts.green' 1025 <= s32max +drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:407 cm_helper_translate_curve_to_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max + +Fixes: b629596072e5 ("drm/amd/display: Build unity lut for shaper") +Cc: Vitaly Prosyak +Cc: Charlene Liu +Cc: Harry Wentland +Cc: Rodrigo Siqueira +Cc: Roman Li +Cc: Aurabindo Pillai +Cc: Tom Chung +Signed-off-by: Srinivasan Shanmugam +Reviewed-by: Tom Chung +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c +index 3538973bd0c6c..c0372aa4ec838 100644 +--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c ++++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c +@@ -382,6 +382,11 @@ bool cm_helper_translate_curve_to_hw_format(struct dc_context *ctx, + i += increment) { + if (j == hw_points - 1) + break; ++ if (i >= TRANSFER_FUNC_POINTS) { ++ DC_LOG_ERROR("Index out of bounds: i=%d, TRANSFER_FUNC_POINTS=%d\n", ++ i, TRANSFER_FUNC_POINTS); ++ return false; ++ } + rgb_resulted[j].red = output_tf->tf_pts.red[i]; + rgb_resulted[j].green = output_tf->tf_pts.green[i]; + rgb_resulted[j].blue = output_tf->tf_pts.blue[i]; +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-remove-redundant-condition-in-dcn35_.patch b/queue-6.8/drm-amd-display-remove-redundant-condition-in-dcn35_.patch new file mode 100644 index 00000000000..a92209730dc --- /dev/null +++ b/queue-6.8/drm-amd-display-remove-redundant-condition-in-dcn35_.patch @@ -0,0 +1,51 @@ +From 3e3196e940d06d41669569954135a914e1fb2189 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 24 Feb 2024 09:23:53 +0530 +Subject: drm/amd/display: Remove redundant condition in + dcn35_calc_blocks_to_gate() + +From: Srinivasan Shanmugam + +[ Upstream commit a43dbeaba81eb645a12a004c67722c632ed0d94b ] + +pipe_ctx->plane_res.mpcc_inst is of a type that can only hold values +between 0 and 255, so it's always greater than or equal to 0. + +Thus the condition 'pipe_ctx->plane_res.mpcc_inst >= 0' was always true +and has been removed. + +Fixes the below: +drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn35/dcn35_hwseq.c:1023 dcn35_calc_blocks_to_gate() warn: always true condition '(pipe_ctx->plane_res.mpcc_inst >= 0) => (0-255 >= 0)' + +Fixes: 6f8b7565cca4 ("drm/amd/display: Add DCN35 HWSEQ") +Cc: Qingqing Zhuo +Cc: Harry Wentland +Cc: Rodrigo Siqueira +Cc: Roman Li +Cc: Aurabindo Pillai +Cc: Tom Chung +Signed-off-by: Srinivasan Shanmugam +Reviewed-by: Rodrigo Siqueira +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c +index 46cbb5a6c8e74..1a3c212ae63c8 100644 +--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c ++++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c +@@ -999,8 +999,7 @@ void dcn35_calc_blocks_to_gate(struct dc *dc, struct dc_state *context, + if (pipe_ctx->plane_res.dpp) + update_state->pg_pipe_res_update[PG_DPP][pipe_ctx->plane_res.hubp->inst] = false; + +- if ((pipe_ctx->plane_res.dpp || pipe_ctx->stream_res.opp) && +- pipe_ctx->plane_res.mpcc_inst >= 0) ++ if (pipe_ctx->plane_res.dpp || pipe_ctx->stream_res.opp) + update_state->pg_pipe_res_update[PG_MPCC][pipe_ctx->plane_res.mpcc_inst] = false; + + if (pipe_ctx->stream_res.dsc) +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-display-set-color_mgmt_changed-to-true-on-un.patch b/queue-6.8/drm-amd-display-set-color_mgmt_changed-to-true-on-un.patch new file mode 100644 index 00000000000..18b6d1b772c --- /dev/null +++ b/queue-6.8/drm-amd-display-set-color_mgmt_changed-to-true-on-un.patch @@ -0,0 +1,37 @@ +From c55c36ce4d3f03c2a18f4d6bf8c86ac53cd7f535 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 Nov 2023 04:21:55 +0000 +Subject: drm/amd/display: Set color_mgmt_changed to true on unsuspend + +From: Joshua Ashton + +[ Upstream commit 2eb9dd497a698dc384c0dd3e0311d541eb2e13dd ] + +Otherwise we can end up with a frame on unsuspend where color management +is not applied when userspace has not committed themselves. + +Fixes re-applying color management on Steam Deck/Gamescope on S3 resume. + +Signed-off-by: Joshua Ashton +Reviewed-by: Harry Wentland +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +index 9044214dfdbdf..c4ba397f8cef5 100644 +--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c ++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +@@ -3010,6 +3010,7 @@ static int dm_resume(void *handle) + dc_stream_release(dm_new_crtc_state->stream); + dm_new_crtc_state->stream = NULL; + } ++ dm_new_crtc_state->base.color_mgmt_changed = true; + } + + for_each_new_plane_in_state(dm->cached_state, plane, new_plane_state, i) { +-- +2.43.0 + diff --git a/queue-6.8/drm-amd-pm-restore-config-space-after-reset.patch b/queue-6.8/drm-amd-pm-restore-config-space-after-reset.patch new file mode 100644 index 00000000000..fc9e939cc5f --- /dev/null +++ b/queue-6.8/drm-amd-pm-restore-config-space-after-reset.patch @@ -0,0 +1,73 @@ +From 1d48b97cfaaf74c0961fe29aff591f5f4b0675c2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 13:11:14 +0530 +Subject: drm/amd/pm: Restore config space after reset + +From: Lijo Lazar + +[ Upstream commit 30d1cda8ce31ab49051ff7159280c542a738b23d ] + +During mode-2 reset, pci config space registers are affected at device +side. However, certain platforms have switches which assign virtual BAR +addresses and returns the same even after device is reset. This +affects pci_restore_state() as it doesn't issue another config write, if +the value read is same as the saved value. + +Add a workaround to write saved config space values from driver side. +Presently, these switches are in platforms with SMU v13.0.6 SOCs, hence +restrict the workaround only to those. + +Signed-off-by: Lijo Lazar +Reviewed-by: Asad Kamal +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 25 +++++++++++++++++++ + 1 file changed, 25 insertions(+) + +diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +index 78491b04df108..ddb11eb8c3f53 100644 +--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c ++++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +@@ -2205,6 +2205,17 @@ static ssize_t smu_v13_0_6_get_gpu_metrics(struct smu_context *smu, void **table + return sizeof(*gpu_metrics); + } + ++static void smu_v13_0_6_restore_pci_config(struct smu_context *smu) ++{ ++ struct amdgpu_device *adev = smu->adev; ++ int i; ++ ++ for (i = 0; i < 16; i++) ++ pci_write_config_dword(adev->pdev, i * 4, ++ adev->pdev->saved_config_space[i]); ++ pci_restore_msi_state(adev->pdev); ++} ++ + static int smu_v13_0_6_mode2_reset(struct smu_context *smu) + { + int ret = 0, index; +@@ -2226,6 +2237,20 @@ static int smu_v13_0_6_mode2_reset(struct smu_context *smu) + /* Restore the config space saved during init */ + amdgpu_device_load_pci_state(adev->pdev); + ++ /* Certain platforms have switches which assign virtual BAR values to ++ * devices. OS uses the virtual BAR values and device behind the switch ++ * is assgined another BAR value. When device's config space registers ++ * are queried, switch returns the virtual BAR values. When mode-2 reset ++ * is performed, switch is unaware of it, and will continue to return ++ * the same virtual values to the OS.This affects ++ * pci_restore_config_space() API as it doesn't write the value saved if ++ * the current value read from config space is the same as what is ++ * saved. As a workaround, make sure the config space is restored ++ * always. ++ */ ++ if (!(adev->flags & AMD_IS_APU)) ++ smu_v13_0_6_restore_pci_config(smu); ++ + dev_dbg(smu->adev->dev, "wait for reset ack\n"); + do { + ret = smu_cmn_wait_for_response(smu); +-- +2.43.0 + diff --git a/queue-6.8/drm-amdgpu-fix-the-ring-buffer-size-for-queue-vm-flu.patch b/queue-6.8/drm-amdgpu-fix-the-ring-buffer-size-for-queue-vm-flu.patch new file mode 100644 index 00000000000..0767018907b --- /dev/null +++ b/queue-6.8/drm-amdgpu-fix-the-ring-buffer-size-for-queue-vm-flu.patch @@ -0,0 +1,94 @@ +From 2cf0de0729cfa34e9f93df9a84fbec0d35ce608c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 25 Mar 2024 15:33:34 +0800 +Subject: drm/amdgpu: Fix the ring buffer size for queue VM flush +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Prike Liang + +[ Upstream commit fe93b0927bc58cb1d64230f45744e527d9d8482c ] + +Here are the corrections needed for the queue ring buffer size +calculation for the following cases: +- Remove the KIQ VM flush ring usage. +- Add the invalidate TLBs packet for gfx10 and gfx11 queue. +- There's no VM flush and PFP sync, so remove the gfx9 real + ring and compute ring buffer usage. + +Signed-off-by: Prike Liang +Reviewed-by: Christian König +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +-- + drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 +-- + drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 -- + 3 files changed, 2 insertions(+), 6 deletions(-) + +diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +index dcdecb18b2306..42392a97daff2 100644 +--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c ++++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +@@ -9194,7 +9194,7 @@ static const struct amdgpu_ring_funcs gfx_v10_0_ring_funcs_gfx = { + 7 + /* PIPELINE_SYNC */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* VM_FLUSH */ ++ 4 + /* VM_FLUSH */ + 8 + /* FENCE for VM_FLUSH */ + 20 + /* GDS switch */ + 4 + /* double SWITCH_BUFFER, +@@ -9285,7 +9285,6 @@ static const struct amdgpu_ring_funcs gfx_v10_0_ring_funcs_kiq = { + 7 + /* gfx_v10_0_ring_emit_pipeline_sync */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* gfx_v10_0_ring_emit_vm_flush */ + 8 + 8 + 8, /* gfx_v10_0_ring_emit_fence_kiq x3 for user fence, vm fence */ + .emit_ib_size = 7, /* gfx_v10_0_ring_emit_ib_compute */ + .emit_ib = gfx_v10_0_ring_emit_ib_compute, +diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +index 0afe86bcc932b..6a6fc422e44da 100644 +--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c ++++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +@@ -6110,7 +6110,7 @@ static const struct amdgpu_ring_funcs gfx_v11_0_ring_funcs_gfx = { + 7 + /* PIPELINE_SYNC */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* VM_FLUSH */ ++ 4 + /* VM_FLUSH */ + 8 + /* FENCE for VM_FLUSH */ + 20 + /* GDS switch */ + 5 + /* COND_EXEC */ +@@ -6195,7 +6195,6 @@ static const struct amdgpu_ring_funcs gfx_v11_0_ring_funcs_kiq = { + 7 + /* gfx_v11_0_ring_emit_pipeline_sync */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* gfx_v11_0_ring_emit_vm_flush */ + 8 + 8 + 8, /* gfx_v11_0_ring_emit_fence_kiq x3 for user fence, vm fence */ + .emit_ib_size = 7, /* gfx_v11_0_ring_emit_ib_compute */ + .emit_ib = gfx_v11_0_ring_emit_ib_compute, +diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +index 3bc6943365a4f..153932c1f64f3 100644 +--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c ++++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +@@ -6991,7 +6991,6 @@ static const struct amdgpu_ring_funcs gfx_v9_0_ring_funcs_compute = { + 7 + /* gfx_v9_0_ring_emit_pipeline_sync */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* gfx_v9_0_ring_emit_vm_flush */ + 8 + 8 + 8 + /* gfx_v9_0_ring_emit_fence x3 for user fence, vm fence */ + 7 + /* gfx_v9_0_emit_mem_sync */ + 5 + /* gfx_v9_0_emit_wave_limit for updating mmSPI_WCL_PIPE_PERCENT_GFX register */ +@@ -7029,7 +7028,6 @@ static const struct amdgpu_ring_funcs gfx_v9_0_ring_funcs_kiq = { + 7 + /* gfx_v9_0_ring_emit_pipeline_sync */ + SOC15_FLUSH_GPU_TLB_NUM_WREG * 5 + + SOC15_FLUSH_GPU_TLB_NUM_REG_WAIT * 7 + +- 2 + /* gfx_v9_0_ring_emit_vm_flush */ + 8 + 8 + 8, /* gfx_v9_0_ring_emit_fence_kiq x3 for user fence, vm fence */ + .emit_ib_size = 7, /* gfx_v9_0_ring_emit_ib_compute */ + .emit_fence = gfx_v9_0_ring_emit_fence_kiq, +-- +2.43.0 + diff --git a/queue-6.8/drm-amdgpu-fix-vram-memory-accounting.patch b/queue-6.8/drm-amdgpu-fix-vram-memory-accounting.patch new file mode 100644 index 00000000000..4ac9ac562b2 --- /dev/null +++ b/queue-6.8/drm-amdgpu-fix-vram-memory-accounting.patch @@ -0,0 +1,37 @@ +From 5d849505c4fd25d06559f5176567182e13ec4bcb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 14:40:37 -0400 +Subject: drm/amdgpu: Fix VRAM memory accounting + +From: Mukul Joshi + +[ Upstream commit f06446ef23216090d1ee8ede1a7d7ae430c22dcc ] + +Subtract the VRAM pinned memory when checking for available memory +in amdgpu_amdkfd_reserve_mem_limit function since that memory is not +available for use. + +Signed-off-by: Mukul Joshi +Reviewed-by: Felix Kuehling +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +index daa66eb4f722b..b1e2dd52e643d 100644 +--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c ++++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +@@ -220,7 +220,7 @@ int amdgpu_amdkfd_reserve_mem_limit(struct amdgpu_device *adev, + (kfd_mem_limit.ttm_mem_used + ttm_mem_needed > + kfd_mem_limit.max_ttm_mem_limit) || + (adev && xcp_id >= 0 && adev->kfd.vram_used[xcp_id] + vram_needed > +- vram_size - reserved_for_pt)) { ++ vram_size - reserved_for_pt - atomic64_read(&adev->vram_pin_size))) { + ret = -ENOMEM; + goto release; + } +-- +2.43.0 + diff --git a/queue-6.8/drm-amdgpu-mes-fix-use-after-free-issue.patch b/queue-6.8/drm-amdgpu-mes-fix-use-after-free-issue.patch new file mode 100644 index 00000000000..6f896f42f51 --- /dev/null +++ b/queue-6.8/drm-amdgpu-mes-fix-use-after-free-issue.patch @@ -0,0 +1,41 @@ +From f5a9b1a8c9d115a73cba526a71a77afa277dc474 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 16:22:54 +0800 +Subject: drm/amdgpu/mes: fix use-after-free issue +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Jack Xiao + +[ Upstream commit 948255282074d9367e01908b3f5dcf8c10fc9c3d ] + +Delete fence fallback timer to fix the ramdom +use-after-free issue. + +v2: move to amdgpu_mes.c + +Signed-off-by: Jack Xiao +Acked-by: Lijo Lazar +Acked-by: Christian König +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c +index da48b6da01072..420e5bc44e306 100644 +--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c ++++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c +@@ -1129,6 +1129,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev, + return; + + amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id); ++ del_timer_sync(&ring->fence_drv.fallback_timer); + amdgpu_ring_fini(ring); + kfree(ring); + } +-- +2.43.0 + diff --git a/queue-6.8/drm-amdgpu-update-bo-eviction-priorities.patch b/queue-6.8/drm-amdgpu-update-bo-eviction-priorities.patch new file mode 100644 index 00000000000..327ebfd93a5 --- /dev/null +++ b/queue-6.8/drm-amdgpu-update-bo-eviction-priorities.patch @@ -0,0 +1,44 @@ +From 2be74edaa9652ce96639fc5dc750b84877aa4d21 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 13:56:42 -0400 +Subject: drm/amdgpu: Update BO eviction priorities +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Felix Kuehling + +[ Upstream commit b0b13d532105e0e682d95214933bb8483a063184 ] + +Make SVM BOs more likely to get evicted than other BOs. These BOs +opportunistically use available VRAM, but can fall back relatively +seamlessly to system memory. It also avoids SVM migrations evicting +other, more important BOs as they will evict other SVM allocations +first. + +Signed-off-by: Felix Kuehling +Acked-by: Mukul Joshi +Tested-by: Mukul Joshi +Reviewed-by: Christian König +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +index 9e5526046aa15..3af505e8cbbc3 100644 +--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c ++++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +@@ -608,6 +608,8 @@ int amdgpu_bo_create(struct amdgpu_device *adev, + else + amdgpu_bo_placement_from_domain(bo, bp->domain); + if (bp->type == ttm_bo_type_kernel) ++ bo->tbo.priority = 2; ++ else if (!(bp->flags & AMDGPU_GEM_CREATE_DISCARDABLE)) + bo->tbo.priority = 1; + + if (!bp->destroy) +-- +2.43.0 + diff --git a/queue-6.8/drm-amdkfd-add-vram-accounting-for-svm-migration.patch b/queue-6.8/drm-amdkfd-add-vram-accounting-for-svm-migration.patch new file mode 100644 index 00000000000..ad4c0c90885 --- /dev/null +++ b/queue-6.8/drm-amdkfd-add-vram-accounting-for-svm-migration.patch @@ -0,0 +1,76 @@ +From 25f7540e08a2caa429dc2cc8203daa8a33c8ca50 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 15:13:58 -0400 +Subject: drm/amdkfd: Add VRAM accounting for SVM migration + +From: Mukul Joshi + +[ Upstream commit 1e214f7faaf5d842754cd5cfcd76308bfedab3b5 ] + +Do VRAM accounting when doing migrations to vram to make sure +there is enough available VRAM and migrating to VRAM doesn't evict +other possible non-unified memory BOs. If migrating to VRAM fails, +driver can fall back to using system memory seamlessly. + +Signed-off-by: Mukul Joshi +Reviewed-by: Felix Kuehling +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 16 +++++++++++++++- + drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- + 2 files changed, 16 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c +index bdc01ca9609a7..5c8d81bfce7ab 100644 +--- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c ++++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c +@@ -509,10 +509,19 @@ svm_migrate_ram_to_vram(struct svm_range *prange, uint32_t best_loc, + start = start_mgr << PAGE_SHIFT; + end = (last_mgr + 1) << PAGE_SHIFT; + ++ r = amdgpu_amdkfd_reserve_mem_limit(node->adev, ++ prange->npages * PAGE_SIZE, ++ KFD_IOC_ALLOC_MEM_FLAGS_VRAM, ++ node->xcp ? node->xcp->id : 0); ++ if (r) { ++ dev_dbg(node->adev->dev, "failed to reserve VRAM, r: %ld\n", r); ++ return -ENOSPC; ++ } ++ + r = svm_range_vram_node_new(node, prange, true); + if (r) { + dev_dbg(node->adev->dev, "fail %ld to alloc vram\n", r); +- return r; ++ goto out; + } + ttm_res_offset = (start_mgr - prange->start + prange->offset) << PAGE_SHIFT; + +@@ -545,6 +554,11 @@ svm_migrate_ram_to_vram(struct svm_range *prange, uint32_t best_loc, + svm_range_vram_node_free(prange); + } + ++out: ++ amdgpu_amdkfd_unreserve_mem_limit(node->adev, ++ prange->npages * PAGE_SIZE, ++ KFD_IOC_ALLOC_MEM_FLAGS_VRAM, ++ node->xcp ? node->xcp->id : 0); + return r < 0 ? r : 0; + } + +diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c +index c50a0dc9c9c07..33205078202b5 100644 +--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c ++++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c +@@ -3424,7 +3424,7 @@ svm_range_trigger_migration(struct mm_struct *mm, struct svm_range *prange, + mm, KFD_MIGRATE_TRIGGER_PREFETCH); + *migrated = !r; + +- return r; ++ return 0; + } + + int svm_range_schedule_evict_svm_bo(struct amdgpu_amdkfd_fence *fence) +-- +2.43.0 + diff --git a/queue-6.8/drm-amdkfd-flush-the-process-wq-before-creating-a-kf.patch b/queue-6.8/drm-amdkfd-flush-the-process-wq-before-creating-a-kf.patch new file mode 100644 index 00000000000..2b5811e46ac --- /dev/null +++ b/queue-6.8/drm-amdkfd-flush-the-process-wq-before-creating-a-kf.patch @@ -0,0 +1,61 @@ +From e49ba0829046b79ce6aa8ee00de12212e33c9ef4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 14:14:13 +0100 +Subject: drm/amdkfd: Flush the process wq before creating a kfd_process + +From: Lancelot SIX + +[ Upstream commit f5b9053398e70a0c10aa9cb4dd5910ab6bc457c5 ] + +There is a race condition when re-creating a kfd_process for a process. +This has been observed when a process under the debugger executes +exec(3). In this scenario: +- The process executes exec. + - This will eventually release the process's mm, which will cause the + kfd_process object associated with the process to be freed + (kfd_process_free_notifier decrements the reference count to the + kfd_process to 0). This causes kfd_process_ref_release to enqueue + kfd_process_wq_release to the kfd_process_wq. +- The debugger receives the PTRACE_EVENT_EXEC notification, and tries to + re-enable AMDGPU traps (KFD_IOC_DBG_TRAP_ENABLE). + - When handling this request, KFD tries to re-create a kfd_process. + This eventually calls kfd_create_process and kobject_init_and_add. + +At this point the call to kobject_init_and_add can fail because the +old kfd_process.kobj has not been freed yet by kfd_process_wq_release. + +This patch proposes to avoid this race by making sure to drain +kfd_process_wq before creating a new kfd_process object. This way, we +know that any cleanup task is done executing when we reach +kobject_init_and_add. + +Signed-off-by: Lancelot SIX +Reviewed-by: Felix Kuehling +Signed-off-by: Alex Deucher +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/amd/amdkfd/kfd_process.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c +index 58c1fe5421934..451bb058cc620 100644 +--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c ++++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c +@@ -829,6 +829,14 @@ struct kfd_process *kfd_create_process(struct task_struct *thread) + if (process) { + pr_debug("Process already found\n"); + } else { ++ /* If the process just called exec(3), it is possible that the ++ * cleanup of the kfd_process (following the release of the mm ++ * of the old process image) is still in the cleanup work queue. ++ * Make sure to drain any job before trying to recreate any ++ * resource for this process. ++ */ ++ flush_workqueue(kfd_process_wq); ++ + process = create_process(thread); + if (IS_ERR(process)) + goto out; +-- +2.43.0 + diff --git a/queue-6.8/drm-arm-malidp-fix-a-possible-null-pointer-dereferen.patch b/queue-6.8/drm-arm-malidp-fix-a-possible-null-pointer-dereferen.patch new file mode 100644 index 00000000000..2d6d6cdf395 --- /dev/null +++ b/queue-6.8/drm-arm-malidp-fix-a-possible-null-pointer-dereferen.patch @@ -0,0 +1,42 @@ +From 5ed83dd67a229133200b8871666cee14bde4e3ab Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 7 Apr 2024 14:30:53 +0800 +Subject: drm/arm/malidp: fix a possible null pointer dereference + +From: Huai-Yuan Liu + +[ Upstream commit a1f95aede6285dba6dd036d907196f35ae3a11ea ] + +In malidp_mw_connector_reset, new memory is allocated with kzalloc, but +no check is performed. In order to prevent null pointer dereferencing, +ensure that mw_state is checked before calling +__drm_atomic_helper_connector_reset. + +Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector") +Signed-off-by: Huai-Yuan Liu +Signed-off-by: Liviu Dudau +Link: https://patchwork.freedesktop.org/patch/msgid/20240407063053.5481-1-qq810974084@gmail.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/arm/malidp_mw.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c +index 626709bec6f5f..2577f0cef8fcd 100644 +--- a/drivers/gpu/drm/arm/malidp_mw.c ++++ b/drivers/gpu/drm/arm/malidp_mw.c +@@ -72,7 +72,10 @@ static void malidp_mw_connector_reset(struct drm_connector *connector) + __drm_atomic_helper_connector_destroy_state(connector->state); + + kfree(connector->state); +- __drm_atomic_helper_connector_reset(connector, &mw_state->base); ++ connector->state = NULL; ++ ++ if (mw_state) ++ __drm_atomic_helper_connector_reset(connector, &mw_state->base); + } + + static enum drm_connector_status +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-anx7625-don-t-log-an-error-when-dsi-host-.patch b/queue-6.8/drm-bridge-anx7625-don-t-log-an-error-when-dsi-host-.patch new file mode 100644 index 00000000000..cccbafe6a98 --- /dev/null +++ b/queue-6.8/drm-bridge-anx7625-don-t-log-an-error-when-dsi-host-.patch @@ -0,0 +1,49 @@ +From e32c3a6b232b15b877ea9830651408acc8b3d842 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:29 -0400 +Subject: drm/bridge: anx7625: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit ef4a9204d594fe959cdbc7418273caf4001535c8 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found") +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Neil Armstrong +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-1-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c +index 29d91493b101a..4ee5614a26236 100644 +--- a/drivers/gpu/drm/bridge/analogix/anx7625.c ++++ b/drivers/gpu/drm/bridge/analogix/anx7625.c +@@ -2076,10 +2076,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx) + }; + + host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); +- if (!host) { +- DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); +- return -EPROBE_DEFER; +- } ++ if (!host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n"); + + dsi = devm_mipi_dsi_device_register_full(dev, host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-anx7625-update-audio-status-while-detecti.patch b/queue-6.8/drm-bridge-anx7625-update-audio-status-while-detecti.patch new file mode 100644 index 00000000000..ece9976d680 --- /dev/null +++ b/queue-6.8/drm-bridge-anx7625-update-audio-status-while-detecti.patch @@ -0,0 +1,54 @@ +From 9715b27daf2db6fc01b92ac483fd5a4ddf62560f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 07:21:35 +0000 +Subject: drm/bridge: anx7625: Update audio status while detecting + +From: Hsin-Te Yuan + +[ Upstream commit a665b4e60369867cddf50f37f16169a3e2f434ad ] + +Previously, the audio status was not updated during detection, leading +to a persistent audio despite hot plugging events. To resolve this +issue, update the audio status during detection. + +Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") +Signed-off-by: Hsin-Te Yuan +Reviewed-by: Robert Foss +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240416-anx7625-v3-1-f916ae31bdd7@chromium.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/analogix/anx7625.c | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c +index 4ee5614a26236..c1191ef5e8e67 100644 +--- a/drivers/gpu/drm/bridge/analogix/anx7625.c ++++ b/drivers/gpu/drm/bridge/analogix/anx7625.c +@@ -2479,15 +2479,22 @@ static void anx7625_bridge_atomic_disable(struct drm_bridge *bridge, + mutex_unlock(&ctx->aux_lock); + } + ++static void ++anx7625_audio_update_connector_status(struct anx7625_data *ctx, ++ enum drm_connector_status status); ++ + static enum drm_connector_status + anx7625_bridge_detect(struct drm_bridge *bridge) + { + struct anx7625_data *ctx = bridge_to_anx7625(bridge); + struct device *dev = ctx->dev; ++ enum drm_connector_status status; + + DRM_DEV_DEBUG_DRIVER(dev, "drm bridge detect\n"); + +- return anx7625_sink_detect(ctx); ++ status = anx7625_sink_detect(ctx); ++ anx7625_audio_update_connector_status(ctx, status); ++ return status; + } + + static struct edid *anx7625_bridge_get_edid(struct drm_bridge *bridge, +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-cdns-mhdp8546-fix-possible-null-pointer-d.patch b/queue-6.8/drm-bridge-cdns-mhdp8546-fix-possible-null-pointer-d.patch new file mode 100644 index 00000000000..eb25bd27eac --- /dev/null +++ b/queue-6.8/drm-bridge-cdns-mhdp8546-fix-possible-null-pointer-d.patch @@ -0,0 +1,43 @@ +From 1bcbf83f796add815419ffdc664e4fdd5ff40281 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 15:58:10 +0300 +Subject: drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference + +From: Aleksandr Mishin + +[ Upstream commit 935a92a1c400285545198ca2800a4c6c519c650a ] + +In cdns_mhdp_atomic_enable(), the return value of drm_mode_duplicate() is +assigned to mhdp_state->current_mode, and there is a dereference of it in +drm_mode_set_name(), which will lead to a NULL pointer dereference on +failure of drm_mode_duplicate(). + +Fix this bug add a check of mhdp_state->current_mode. + +Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") +Signed-off-by: Aleksandr Mishin +Reviewed-by: Robert Foss +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240408125810.21899-1-amishin@t-argos.ru +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +index 7d470527455b1..bab8844c6fefb 100644 +--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c ++++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +@@ -2057,6 +2057,9 @@ static void cdns_mhdp_atomic_enable(struct drm_bridge *bridge, + mhdp_state = to_cdns_mhdp_bridge_state(new_state); + + mhdp_state->current_mode = drm_mode_duplicate(bridge->dev, mode); ++ if (!mhdp_state->current_mode) ++ return; ++ + drm_mode_set_name(mhdp_state->current_mode); + + dev_dbg(mhdp->dev, "%s: Enabling mode %s\n", __func__, mode->name); +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-dpc3433-don-t-log-an-error-when-dsi-host-.patch b/queue-6.8/drm-bridge-dpc3433-don-t-log-an-error-when-dsi-host-.patch new file mode 100644 index 00000000000..91a18401255 --- /dev/null +++ b/queue-6.8/drm-bridge-dpc3433-don-t-log-an-error-when-dsi-host-.patch @@ -0,0 +1,80 @@ +From d1502b0b6d43e6435dd21422330a6b5c119ab069 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:35 -0400 +Subject: drm/bridge: dpc3433: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit 24f4f575214de776539d346b99b8717bffa8ebba ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Also move the "failed to attach" error message so that it's only printed +when the devm_mipi_dsi_attach() call fails. + +Fixes: 6352cd451ddb ("drm: bridge: Add TI DLPC3433 DSI to DMD bridge") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-7-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +++++++++-------- + 1 file changed, 9 insertions(+), 8 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c +index ca3348109bcd2..6b559e0713012 100644 +--- a/drivers/gpu/drm/bridge/ti-dlpc3433.c ++++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c +@@ -319,12 +319,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) + .channel = 0, + .node = NULL, + }; ++ int ret; + + host = of_find_mipi_dsi_host_by_node(dlpc->host_node); +- if (!host) { +- DRM_DEV_ERROR(dev, "failed to find dsi host\n"); +- return -EPROBE_DEFER; +- } ++ if (!host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); + + dlpc->dsi = mipi_dsi_device_register_full(host, &info); + if (IS_ERR(dlpc->dsi)) { +@@ -336,7 +335,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) + dlpc->dsi->format = MIPI_DSI_FMT_RGB565; + dlpc->dsi->lanes = dlpc->dsi_lanes; + +- return devm_mipi_dsi_attach(dev, dlpc->dsi); ++ ret = devm_mipi_dsi_attach(dev, dlpc->dsi); ++ if (ret) ++ DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); ++ ++ return ret; + } + + static int dlpc3433_probe(struct i2c_client *client) +@@ -367,10 +370,8 @@ static int dlpc3433_probe(struct i2c_client *client) + drm_bridge_add(&dlpc->bridge); + + ret = dlpc_host_attach(dlpc); +- if (ret) { +- DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); ++ if (ret) + goto err_remove_bridge; +- } + + return 0; + +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-fix-improper-bridge-init-order-with-pre_e.patch b/queue-6.8/drm-bridge-fix-improper-bridge-init-order-with-pre_e.patch new file mode 100644 index 00000000000..74a50033545 --- /dev/null +++ b/queue-6.8/drm-bridge-fix-improper-bridge-init-order-with-pre_e.patch @@ -0,0 +1,154 @@ +From 14558add760a64dd6f1499688edef89ed5ba378b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 28 Mar 2023 22:37:51 +0530 +Subject: drm/bridge: Fix improper bridge init order with pre_enable_prev_first + +From: Jagan Teki + +[ Upstream commit e18aeeda0b6905c333df5a0566b99f5c84426098 ] + +For a given bridge pipeline if any bridge sets pre_enable_prev_first +flag then the pre_enable for the previous bridge will be called before +pre_enable of this bridge and opposite is done for post_disable. + +These are the potential bridge flags to alter bridge init order in order +to satisfy the MIPI DSI host and downstream panel or bridge to function. +However the existing pre_enable_prev_first logic with associated bridge +ordering has broken for both pre_enable and post_disable calls. + +[pre_enable] + +The altered bridge ordering has failed if two consecutive bridges on a +given pipeline enables the pre_enable_prev_first flag. + +Example: +- Panel +- Bridge 1 +- Bridge 2 pre_enable_prev_first +- Bridge 3 +- Bridge 4 pre_enable_prev_first +- Bridge 5 pre_enable_prev_first +- Bridge 6 +- Encoder + +In this example, Bridge 4 and Bridge 5 have pre_enable_prev_first. + +The logic looks for a bridge which enabled pre_enable_prev_first flag +on each iteration and assigned the previou bridge to limit pointer +if the bridge doesn't enable pre_enable_prev_first flags. + +If control found Bridge 2 is pre_enable_prev_first then the iteration +looks for Bridge 3 and found it is not pre_enable_prev_first and assigns +it's previous Bridge 4 to limit pointer and calls pre_enable of Bridge 3 +and Bridge 2 and assign iter pointer with limit which is Bridge 4. + +Here is the actual problem, for the next iteration control look for +Bridge 5 instead of Bridge 4 has iter pointer in previous iteration +moved to Bridge 4 so this iteration skips the Bridge 4. The iteration +found Bridge 6 doesn't pre_enable_prev_first flags so the limit assigned +to Encoder. From next iteration Encoder skips as it is the last bridge +for reverse order pipeline. + +So, the resulting pre_enable bridge order would be, +- Panel, Bridge 1, Bridge 3, Bridge 2, Bridge 6, Bridge 5. + +This patch fixes this by assigning limit to next pointer instead of +previous bridge since the iteration always looks for bridge that does +NOT request prev so assigning next makes sure the last bridge on a +given iteration what exactly the limit bridge is. + +So, the resulting pre_enable bridge order with fix would be, +- Panel, Bridge 1, Bridge 3, Bridge 2, Bridge 6, Bridge 5, Bridge 4, + Encoder. + +[post_disable] + +The altered bridge ordering has failed if two consecutive bridges on a +given pipeline enables the pre_enable_prev_first flag. + +Example: +- Panel +- Bridge 1 +- Bridge 2 pre_enable_prev_first +- Bridge 3 +- Bridge 4 pre_enable_prev_first +- Bridge 5 pre_enable_prev_first +- Bridge 6 +- Encoder + +In this example Bridge 5 and Bridge 4 have pre_enable_prev_first. + +The logic looks for a bridge which enabled pre_enable_prev_first flags +on each iteration and assigned the previou bridge to next and next to +limit pointer if the bridge does enable pre_enable_prev_first flag. + +If control starts from Bridge 6 then it found next Bridge 5 is +pre_enable_prev_first and immediately the next assigned to previous +Bridge 6 and limit assignments to next Bridge 6 and call post_enable +of Bridge 6 even though the next consecutive Bridge 5 is enabled with +pre_enable_prev_first. This clearly misses the logic to find the state +of next conducive bridge as everytime the next and limit assigns +previous bridge if given bridge enabled pre_enable_prev_first. + +So, the resulting post_disable bridge order would be, +- Encoder, Bridge 6, Bridge 5, Bridge 4, Bridge 3, Bridge 2, Bridge 1, + Panel. + +This patch fixes this by assigning next with previou bridge only if the +bridge doesn't enable pre_enable_prev_first flag and the next further +assign it to limit. This way we can find the bridge that NOT requested +prev to disable last. + +So, the resulting pre_enable bridge order with fix would be, +- Encoder, Bridge 4, Bridge 5, Bridge 6, Bridge 2, Bridge 3, Bridge 1, + Panel. + +Validated the bridge init ordering by incorporating dummy bridges in +the sun6i-mipi-dsi pipeline + +Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") +Signed-off-by: Jagan Teki +Tested-by: Michael Trimarchi +Reviewed-by: Dave Stevenson +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20230328170752.1102347-1-jagan@amarulasolutions.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/drm_bridge.c | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c +index 4f6f8c662d3fe..ac502ea20089b 100644 +--- a/drivers/gpu/drm/drm_bridge.c ++++ b/drivers/gpu/drm/drm_bridge.c +@@ -687,11 +687,17 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, + */ + list_for_each_entry_from(next, &encoder->bridge_chain, + chain_node) { +- if (next->pre_enable_prev_first) { ++ if (!next->pre_enable_prev_first) { + next = list_prev_entry(next, chain_node); + limit = next; + break; + } ++ ++ if (list_is_last(&next->chain_node, ++ &encoder->bridge_chain)) { ++ limit = next; ++ break; ++ } + } + + /* Call these bridges in reverse order */ +@@ -774,7 +780,7 @@ void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge, + /* Found first bridge that does NOT + * request prev to be enabled first + */ +- limit = list_prev_entry(next, chain_node); ++ limit = next; + break; + } + } +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-icn6211-don-t-log-an-error-when-dsi-host-.patch b/queue-6.8/drm-bridge-icn6211-don-t-log-an-error-when-dsi-host-.patch new file mode 100644 index 00000000000..0e7c6673176 --- /dev/null +++ b/queue-6.8/drm-bridge-icn6211-don-t-log-an-error-when-dsi-host-.patch @@ -0,0 +1,49 @@ +From bd73f4fe3509fe90c34be4cb0d8cc0ff4205bb7a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:30 -0400 +Subject: drm/bridge: icn6211: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit 275fafe58faa7fdb10fa245412696ecef676aac5 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-2-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c +index 82d23e4df09eb..ff3284b6b1a37 100644 +--- a/drivers/gpu/drm/bridge/chipone-icn6211.c ++++ b/drivers/gpu/drm/bridge/chipone-icn6211.c +@@ -563,10 +563,8 @@ static int chipone_dsi_host_attach(struct chipone *icn) + + host = of_find_mipi_dsi_host_by_node(host_node); + of_node_put(host_node); +- if (!host) { +- dev_err(dev, "failed to find dsi host\n"); +- return -EPROBE_DEFER; +- } ++ if (!host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); + + dsi = mipi_dsi_device_register_full(host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-lt8912b-don-t-log-an-error-when-dsi-host-.patch b/queue-6.8/drm-bridge-lt8912b-don-t-log-an-error-when-dsi-host-.patch new file mode 100644 index 00000000000..ee53e62659e --- /dev/null +++ b/queue-6.8/drm-bridge-lt8912b-don-t-log-an-error-when-dsi-host-.patch @@ -0,0 +1,49 @@ +From 0c6f05704d19b9264fe5a534559ad3542c6df8cf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:31 -0400 +Subject: drm/bridge: lt8912b: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit b3b4695ff47c4964d4ccb930890c9ffd8e455e20 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-3-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c +index 97d4af3d13653..0b5b98d3e5f6f 100644 +--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c ++++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c +@@ -494,10 +494,8 @@ static int lt8912_attach_dsi(struct lt8912 *lt) + }; + + host = of_find_mipi_dsi_host_by_node(lt->host_node); +- if (!host) { +- dev_err(dev, "failed to find dsi host\n"); +- return -EPROBE_DEFER; +- } ++ if (!host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); + + dsi = devm_mipi_dsi_device_register_full(dev, host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-lt9611-don-t-log-an-error-when-dsi-host-c.patch b/queue-6.8/drm-bridge-lt9611-don-t-log-an-error-when-dsi-host-c.patch new file mode 100644 index 00000000000..e315e483d21 --- /dev/null +++ b/queue-6.8/drm-bridge-lt9611-don-t-log-an-error-when-dsi-host-c.patch @@ -0,0 +1,50 @@ +From e9b601553b4938605cc8e6df91567e8bcdd9933d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:32 -0400 +Subject: drm/bridge: lt9611: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit cd0a2c6a081ff67007323725b9ff07d9934b1ed8 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Reviewed-by: Dmitry Baryshkov +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-4-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c +index 9663601ce0981..89bdd938757e1 100644 +--- a/drivers/gpu/drm/bridge/lontium-lt9611.c ++++ b/drivers/gpu/drm/bridge/lontium-lt9611.c +@@ -760,10 +760,8 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, + int ret; + + host = of_find_mipi_dsi_host_by_node(dsi_node); +- if (!host) { +- dev_err(lt9611->dev, "failed to find dsi host\n"); +- return ERR_PTR(-EPROBE_DEFER); +- } ++ if (!host) ++ return ERR_PTR(dev_err_probe(lt9611->dev, -EPROBE_DEFER, "failed to find dsi host\n")); + + dsi = devm_mipi_dsi_device_register_full(dev, host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-lt9611uxc-don-t-log-an-error-when-dsi-hos.patch b/queue-6.8/drm-bridge-lt9611uxc-don-t-log-an-error-when-dsi-hos.patch new file mode 100644 index 00000000000..e8ac03b35c7 --- /dev/null +++ b/queue-6.8/drm-bridge-lt9611uxc-don-t-log-an-error-when-dsi-hos.patch @@ -0,0 +1,51 @@ +From b63ee8610d6d6c637f89f815fd180b339940c816 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:33 -0400 +Subject: drm/bridge: lt9611uxc: Don't log an error when DSI host can't be + found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit 6d9e877cde7e9b516a9a99751b8222c87557436d ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Reviewed-by: Dmitry Baryshkov +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-5-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +index e971b75e90ad0..b803899126d54 100644 +--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c ++++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +@@ -265,10 +265,8 @@ static struct mipi_dsi_device *lt9611uxc_attach_dsi(struct lt9611uxc *lt9611uxc, + int ret; + + host = of_find_mipi_dsi_host_by_node(dsi_node); +- if (!host) { +- dev_err(dev, "failed to find dsi host\n"); +- return ERR_PTR(-EPROBE_DEFER); +- } ++ if (!host) ++ return ERR_PTR(dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n")); + + dsi = devm_mipi_dsi_device_register_full(dev, host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-bridge-tc358775-don-t-log-an-error-when-dsi-host.patch b/queue-6.8/drm-bridge-tc358775-don-t-log-an-error-when-dsi-host.patch new file mode 100644 index 00000000000..dbf05d572e0 --- /dev/null +++ b/queue-6.8/drm-bridge-tc358775-don-t-log-an-error-when-dsi-host.patch @@ -0,0 +1,49 @@ +From 5fbc9b8351c84bb64f18935ed87a200447923e60 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:34 -0400 +Subject: drm/bridge: tc358775: Don't log an error when DSI host can't be found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit 272377aa0e3dddeec3f568c8bb9d12c7a79d8ef5 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-6-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/tc358775.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c +index 90a89d70d8328..fea4f00a20f83 100644 +--- a/drivers/gpu/drm/bridge/tc358775.c ++++ b/drivers/gpu/drm/bridge/tc358775.c +@@ -610,10 +610,8 @@ static int tc_attach_host(struct tc_data *tc) + }; + + host = of_find_mipi_dsi_host_by_node(tc->host_node); +- if (!host) { +- dev_err(dev, "failed to find dsi host\n"); +- return -EPROBE_DEFER; +- } ++ if (!host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); + + dsi = devm_mipi_dsi_device_register_full(dev, host, &info); + if (IS_ERR(dsi)) { +-- +2.43.0 + diff --git a/queue-6.8/drm-ci-update-device-type-for-volteer-devices.patch b/queue-6.8/drm-ci-update-device-type-for-volteer-devices.patch new file mode 100644 index 00000000000..b69dfa683fc --- /dev/null +++ b/queue-6.8/drm-ci-update-device-type-for-volteer-devices.patch @@ -0,0 +1,52 @@ +From 9ea9b242ac507afd77195352e1583ef3c9dbaca0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 07:48:41 +0530 +Subject: drm/ci: update device type for volteer devices + +From: Vignesh Raman + +[ Upstream commit a2c71b711e7efc6478976233768bdbc3386e6dce ] + +Volteer devices in the collabora lab are categorized under the +asus-cx9400-volteer device type. The majority of these units +has an Intel Core i5-1130G7 CPU, while some of them have a +Intel Core i7-1160G7 CPU instead. So due to this difference, +new device type template is added for the Intel Core i5-1130G7 +and i7-1160G7 variants of the Acer Chromebook Spin 514 (CP514-2H) +volteer Chromebooks. So update the same in drm-ci. + +https://gitlab.collabora.com/lava/lava/-/merge_requests/149 + +Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory") +Reviewed-by: David Heidelberg +Signed-off-by: Vignesh Raman +Acked-by: Helen Koike +Signed-off-by: Helen Koike +Link: https://patchwork.freedesktop.org/patch/msgid/20240307021841.100561-1-vignesh.raman@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/ci/test.yml | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml +index 9faf76e55a56a..da381257e7e54 100644 +--- a/drivers/gpu/drm/ci/test.yml ++++ b/drivers/gpu/drm/ci/test.yml +@@ -237,11 +237,11 @@ i915:cml: + i915:tgl: + extends: + - .i915 +- parallel: 8 ++ parallel: 5 + variables: +- DEVICE_TYPE: asus-cx9400-volteer ++ DEVICE_TYPE: acer-cp514-2h-1130g7-volteer + GPU_VERSION: tgl +- RUNNER_TAG: mesa-ci-x86-64-lava-asus-cx9400-volteer ++ RUNNER_TAG: mesa-ci-x86-64-lava-acer-cp514-2h-1130g7-volteer + + .amdgpu: + extends: +-- +2.43.0 + diff --git a/queue-6.8/drm-dp-don-t-attempt-aux-transfers-when-edp-panels-a.patch b/queue-6.8/drm-dp-don-t-attempt-aux-transfers-when-edp-panels-a.patch new file mode 100644 index 00000000000..603317c4e2b --- /dev/null +++ b/queue-6.8/drm-dp-don-t-attempt-aux-transfers-when-edp-panels-a.patch @@ -0,0 +1,180 @@ +From 7f13072d645e513ccbeaf0349d79104bb4e8b3c1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 2 Feb 2024 14:11:16 -0800 +Subject: drm/dp: Don't attempt AUX transfers when eDP panels are not powered + +From: Douglas Anderson + +[ Upstream commit 8df1ddb5bf11ab820ad991e164dab82c0960add9 ] + +If an eDP panel is not powered on then any attempts to talk to it over +the DP AUX channel will timeout. Unfortunately these attempts may be +quite slow. Userspace can initiate these attempts either via a +/dev/drm_dp_auxN device or via the created i2c device. + +Making the DP AUX drivers timeout faster is a difficult proposition. +In theory we could just poll the panel's HPD line in the AUX transfer +function and immediately return an error there. However, this is +easier said than done. For one thing, there's no hard requirement to +hook the HPD line up for eDP panels and it's OK to just delay a fixed +amount. For another thing, the HPD line may not be fast to probe. On +parade-ps8640 we need to wait for the bridge chip's firmware to boot +before we can get the HPD line and this is a slow process. + +The fact that the transfers are taking so long to timeout is causing +real problems. The open source fwupd daemon sometimes scans DP busses +looking for devices whose firmware need updating. If it happens to +scan while a panel is turned off this scan can take a long time. The +fwupd daemon could try to be smarter and only scan when eDP panels are +turned on, but we can also improve the behavior in the kernel. + +Let's let eDP panels drivers specify that a panel is turned off and +then modify the common AUX transfer code not to attempt a transfer in +this case. + +Tested-by: Steev Klimaszewski +Reviewed-by: Hsin-Yi Wang +Tested-by: Eizan Miyamoto +Acked-by: Neil Armstrong +Signed-off-by: Douglas Anderson +Link: https://patchwork.freedesktop.org/patch/msgid/20240202141109.1.I24277520ac754ea538c9b14578edc94e1df11b48@changeid +Stable-dep-of: 5e842d55bad7 ("drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert") +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/display/drm_dp_helper.c | 35 +++++++++++++++++++ + drivers/gpu/drm/panel/panel-edp.c | 3 ++ + .../gpu/drm/panel/panel-samsung-atna33xc20.c | 2 ++ + include/drm/display/drm_dp_helper.h | 6 ++++ + 4 files changed, 46 insertions(+) + +diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c +index 26c188ce5f1c3..fb80843e7f2df 100644 +--- a/drivers/gpu/drm/display/drm_dp_helper.c ++++ b/drivers/gpu/drm/display/drm_dp_helper.c +@@ -532,6 +532,15 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, + + mutex_lock(&aux->hw_mutex); + ++ /* ++ * If the device attached to the aux bus is powered down then there's ++ * no reason to attempt a transfer. Error out immediately. ++ */ ++ if (aux->powered_down) { ++ ret = -EBUSY; ++ goto unlock; ++ } ++ + /* + * The specification doesn't give any recommendation on how often to + * retry native transactions. We used to retry 7 times like for +@@ -599,6 +608,29 @@ int drm_dp_dpcd_probe(struct drm_dp_aux *aux, unsigned int offset) + } + EXPORT_SYMBOL(drm_dp_dpcd_probe); + ++/** ++ * drm_dp_dpcd_set_powered() - Set whether the DP device is powered ++ * @aux: DisplayPort AUX channel; for convenience it's OK to pass NULL here ++ * and the function will be a no-op. ++ * @powered: true if powered; false if not ++ * ++ * If the endpoint device on the DP AUX bus is known to be powered down ++ * then this function can be called to make future transfers fail immediately ++ * instead of needing to time out. ++ * ++ * If this function is never called then a device defaults to being powered. ++ */ ++void drm_dp_dpcd_set_powered(struct drm_dp_aux *aux, bool powered) ++{ ++ if (!aux) ++ return; ++ ++ mutex_lock(&aux->hw_mutex); ++ aux->powered_down = !powered; ++ mutex_unlock(&aux->hw_mutex); ++} ++EXPORT_SYMBOL(drm_dp_dpcd_set_powered); ++ + /** + * drm_dp_dpcd_read() - read a series of bytes from the DPCD + * @aux: DisplayPort AUX channel (SST or MST) +@@ -1858,6 +1890,9 @@ static int drm_dp_i2c_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, + struct drm_dp_aux_msg msg; + int err = 0; + ++ if (aux->powered_down) ++ return -EBUSY; ++ + dp_aux_i2c_transfer_size = clamp(dp_aux_i2c_transfer_size, 1, DP_AUX_MAX_PAYLOAD_BYTES); + + memset(&msg, 0, sizeof(msg)); +diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c +index e5e3f0b9ca61d..49b8a2484d92b 100644 +--- a/drivers/gpu/drm/panel/panel-edp.c ++++ b/drivers/gpu/drm/panel/panel-edp.c +@@ -397,6 +397,7 @@ static int panel_edp_suspend(struct device *dev) + { + struct panel_edp *p = dev_get_drvdata(dev); + ++ drm_dp_dpcd_set_powered(p->aux, false); + gpiod_set_value_cansleep(p->enable_gpio, 0); + regulator_disable(p->supply); + p->unprepared_time = ktime_get_boottime(); +@@ -453,6 +454,7 @@ static int panel_edp_prepare_once(struct panel_edp *p) + } + + gpiod_set_value_cansleep(p->enable_gpio, 1); ++ drm_dp_dpcd_set_powered(p->aux, true); + + delay = p->desc->delay.hpd_reliable; + if (p->no_hpd) +@@ -489,6 +491,7 @@ static int panel_edp_prepare_once(struct panel_edp *p) + return 0; + + error: ++ drm_dp_dpcd_set_powered(p->aux, false); + gpiod_set_value_cansleep(p->enable_gpio, 0); + regulator_disable(p->supply); + p->unprepared_time = ktime_get_boottime(); +diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +index 5703f4712d96e..76c2a8f6718c8 100644 +--- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c ++++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +@@ -72,6 +72,7 @@ static int atana33xc20_suspend(struct device *dev) + if (p->el3_was_on) + atana33xc20_wait(p->el_on3_off_time, 150); + ++ drm_dp_dpcd_set_powered(p->aux, false); + ret = regulator_disable(p->supply); + if (ret) + return ret; +@@ -93,6 +94,7 @@ static int atana33xc20_resume(struct device *dev) + ret = regulator_enable(p->supply); + if (ret) + return ret; ++ drm_dp_dpcd_set_powered(p->aux, true); + p->powered_on_time = ktime_get_boottime(); + + if (p->no_hpd) { +diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h +index 863b2e7add29e..472359a9d6756 100644 +--- a/include/drm/display/drm_dp_helper.h ++++ b/include/drm/display/drm_dp_helper.h +@@ -463,9 +463,15 @@ struct drm_dp_aux { + * @is_remote: Is this AUX CH actually using sideband messaging. + */ + bool is_remote; ++ ++ /** ++ * @powered_down: If true then the remote endpoint is powered down. ++ */ ++ bool powered_down; + }; + + int drm_dp_dpcd_probe(struct drm_dp_aux *aux, unsigned int offset); ++void drm_dp_dpcd_set_powered(struct drm_dp_aux *aux, bool powered); + ssize_t drm_dp_dpcd_read(struct drm_dp_aux *aux, unsigned int offset, + void *buffer, size_t size); + ssize_t drm_dp_dpcd_write(struct drm_dp_aux *aux, unsigned int offset, +-- +2.43.0 + diff --git a/queue-6.8/drm-edid-parse-topology-block-for-all-dispid-structu.patch b/queue-6.8/drm-edid-parse-topology-block-for-all-dispid-structu.patch new file mode 100644 index 00000000000..d2757b8b05c --- /dev/null +++ b/queue-6.8/drm-edid-parse-topology-block-for-all-dispid-structu.patch @@ -0,0 +1,83 @@ +From 673ab51f036689522f869035ceb4f0adb56199f8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 21:01:39 +0300 +Subject: drm/edid: Parse topology block for all DispID structure v1.x +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Ville Syrjälä + +[ Upstream commit e0a200ab4b72afd581bd6f82fc1ef510a4fb5478 ] + +DisplayID spec v1.3 revision history notes do claim that +the toplogy block was added in v1.3 so requiring structure +v1.2 would seem correct, but there is at least one EDID in +edid.tv with a topology block and structure v1.0. And +there are also EDIDs with DisplayID structure v1.3 which +seems to be totally incorrect as DisplayID spec v1.3 lists +structure v1.2 as the only legal value. + +Unfortunately I couldn't find copies of DisplayID spec +v1.0-v1.2 anywhere (even on vesa.org), so I'll have to +go on empirical evidence alone. + +We used to parse the topology block on all v1.x +structures until the check for structure v2.0 was added. +Let's go back to doing that as the evidence does suggest +that there are DisplayIDs in the wild that would miss +out on the topology stuff otherwise. + +Also toss out DISPLAY_ID_STRUCTURE_VER_12 entirely as +it doesn't appear we can really use it for anything. + +I *think* we could technically skip all the structure +version checks as the block tags shouldn't conflict +between v2.0 and v1.x. But no harm in having a bit of +extra sanity checks I guess. + +So far I'm not aware of any user reported regressions +from overly strict check, but I do know that it broke +igt/kms_tiled_display's fake DisplayID as that one +gets generated with structure v1.0. + +Cc: Jani Nikula +Cc: Dmitry Osipenko +Fixes: c5a486af9df7 ("drm/edid: parse Tiled Display Topology Data Block for DisplayID 2.0") +Signed-off-by: Ville Syrjälä +Link: https://patchwork.freedesktop.org/patch/msgid/20240410180139.21352-1-ville.syrjala@linux.intel.com +Acked-by: Jani Nikula +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/drm_edid.c | 2 +- + include/drm/drm_displayid.h | 1 - + 2 files changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c +index 69c68804023ff..9ef9a70a836c7 100644 +--- a/drivers/gpu/drm/drm_edid.c ++++ b/drivers/gpu/drm/drm_edid.c +@@ -7345,7 +7345,7 @@ static void drm_parse_tiled_block(struct drm_connector *connector, + static bool displayid_is_tiled_block(const struct displayid_iter *iter, + const struct displayid_block *block) + { +- return (displayid_version(iter) == DISPLAY_ID_STRUCTURE_VER_12 && ++ return (displayid_version(iter) < DISPLAY_ID_STRUCTURE_VER_20 && + block->tag == DATA_BLOCK_TILED_DISPLAY) || + (displayid_version(iter) == DISPLAY_ID_STRUCTURE_VER_20 && + block->tag == DATA_BLOCK_2_TILED_DISPLAY_TOPOLOGY); +diff --git a/include/drm/drm_displayid.h b/include/drm/drm_displayid.h +index 566497eeb3b81..bc1f6b378195f 100644 +--- a/include/drm/drm_displayid.h ++++ b/include/drm/drm_displayid.h +@@ -30,7 +30,6 @@ struct drm_edid; + #define VESA_IEEE_OUI 0x3a0292 + + /* DisplayID Structure versions */ +-#define DISPLAY_ID_STRUCTURE_VER_12 0x12 + #define DISPLAY_ID_STRUCTURE_VER_20 0x20 + + /* DisplayID Structure v1r2 Data Blocks */ +-- +2.43.0 + diff --git a/queue-6.8/drm-etnaviv-fix-tx-clock-gating-on-some-gc7000-varia.patch b/queue-6.8/drm-etnaviv-fix-tx-clock-gating-on-some-gc7000-varia.patch new file mode 100644 index 00000000000..5528a63f199 --- /dev/null +++ b/queue-6.8/drm-etnaviv-fix-tx-clock-gating-on-some-gc7000-varia.patch @@ -0,0 +1,43 @@ +From 1096549729d48e602a1ce33e088935767ad35a7e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 18 Mar 2024 07:32:07 -0500 +Subject: drm/etnaviv: fix tx clock gating on some GC7000 variants + +From: Derek Foreman + +[ Upstream commit d7a5c9de99b3a9a43dce49f2084eb69b5f6a9752 ] + +commit 4bce244272513 ("drm/etnaviv: disable tx clock gating for GC7000 +rev6203") accidentally applied the fix for i.MX8MN errata ERR050226 to +GC2000 instead of GC7000, failing to disable tx clock gating for GC7000 +rev 0x6023 as intended. + +Additional clean-up further propagated this issue, partially breaking +the clock gating fixes added for GC7000 rev 6202 in commit 432f51e7deeda +("drm/etnaviv: add clock gating workaround for GC7000 r6202"). + +Signed-off-by: Derek Foreman +Signed-off-by: Lucas Stach +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +index 9b8445d2a128f..89cb6799b547f 100644 +--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c ++++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +@@ -632,8 +632,8 @@ static void etnaviv_gpu_enable_mlcg(struct etnaviv_gpu *gpu) + /* Disable TX clock gating on affected core revisions. */ + if (etnaviv_is_model_rev(gpu, GC4000, 0x5222) || + etnaviv_is_model_rev(gpu, GC2000, 0x5108) || +- etnaviv_is_model_rev(gpu, GC2000, 0x6202) || +- etnaviv_is_model_rev(gpu, GC2000, 0x6203)) ++ etnaviv_is_model_rev(gpu, GC7000, 0x6202) || ++ etnaviv_is_model_rev(gpu, GC7000, 0x6203)) + pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_TX; + + /* Disable SE and RA clock gating on affected core revisions. */ +-- +2.43.0 + diff --git a/queue-6.8/drm-imagination-avoid-woverflow-warning.patch b/queue-6.8/drm-imagination-avoid-woverflow-warning.patch new file mode 100644 index 00000000000..f10cbffc271 --- /dev/null +++ b/queue-6.8/drm-imagination-avoid-woverflow-warning.patch @@ -0,0 +1,64 @@ +From de67326dae6c327b968567c3d61adf476df69a53 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 22 Mar 2024 14:01:09 +0100 +Subject: drm/imagination: avoid -Woverflow warning + +From: Arnd Bergmann + +[ Upstream commit 07b9d0144fff9af08b8dcd0ae134510bfd539e42 ] + +The array size calculation in pvr_vm_mips_fini() appears to be incorrect based on +taking the size of the pointer rather than the size of the array, which manifests +as a warning about signed integer overflow: + +In file included from include/linux/kernel.h:16, + from drivers/gpu/drm/imagination/pvr_rogue_fwif.h:10, + from drivers/gpu/drm/imagination/pvr_ccb.h:7, + from drivers/gpu/drm/imagination/pvr_device.h:7, + from drivers/gpu/drm/imagination/pvr_vm_mips.c:4: +drivers/gpu/drm/imagination/pvr_vm_mips.c: In function 'pvr_vm_mips_fini': +include/linux/array_size.h:11:25: error: overflow in conversion from 'long unsigned int' to 'int' changes value from '18446744073709551615' to '-1' [-Werror=overflow] + 11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) + | ^ +drivers/gpu/drm/imagination/pvr_vm_mips.c:106:24: note: in expansion of macro 'ARRAY_SIZE' + 106 | for (page_nr = ARRAY_SIZE(mips_data->pt_pages) - 1; page_nr >= 0; page_nr--) { + | ^~~~~~~~~~ + +Just use the number of array elements directly here, and in the corresponding +init function for consistency. + +Fixes: 927f3e0253c1 ("drm/imagination: Implement MIPS firmware processor and MMU support") +Reviewed-by: Donald Robson +Link: https://lore.kernel.org/lkml/9df9e4f87727399928c068dbbf614c9895ae15f9.camel@imgtec.com/ +Signed-off-by: Arnd Bergmann +Signed-off-by: Matt Coster +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/imagination/pvr_vm_mips.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/imagination/pvr_vm_mips.c b/drivers/gpu/drm/imagination/pvr_vm_mips.c +index b7fef3c797e6c..4f99b4af871c0 100644 +--- a/drivers/gpu/drm/imagination/pvr_vm_mips.c ++++ b/drivers/gpu/drm/imagination/pvr_vm_mips.c +@@ -46,7 +46,7 @@ pvr_vm_mips_init(struct pvr_device *pvr_dev) + if (!mips_data) + return -ENOMEM; + +- for (page_nr = 0; page_nr < ARRAY_SIZE(mips_data->pt_pages); page_nr++) { ++ for (page_nr = 0; page_nr < PVR_MIPS_PT_PAGE_COUNT; page_nr++) { + mips_data->pt_pages[page_nr] = alloc_page(GFP_KERNEL | __GFP_ZERO); + if (!mips_data->pt_pages[page_nr]) { + err = -ENOMEM; +@@ -102,7 +102,7 @@ pvr_vm_mips_fini(struct pvr_device *pvr_dev) + int page_nr; + + vunmap(mips_data->pt); +- for (page_nr = ARRAY_SIZE(mips_data->pt_pages) - 1; page_nr >= 0; page_nr--) { ++ for (page_nr = PVR_MIPS_PT_PAGE_COUNT - 1; page_nr >= 0; page_nr--) { + dma_unmap_page(from_pvr_device(pvr_dev)->dev, + mips_data->pt_dma_addr[page_nr], PAGE_SIZE, DMA_TO_DEVICE); + +-- +2.43.0 + diff --git a/queue-6.8/drm-lcdif-do-not-disable-clocks-on-already-suspended.patch b/queue-6.8/drm-lcdif-do-not-disable-clocks-on-already-suspended.patch new file mode 100644 index 00000000000..ed264cbef26 --- /dev/null +++ b/queue-6.8/drm-lcdif-do-not-disable-clocks-on-already-suspended.patch @@ -0,0 +1,61 @@ +From d98580424fb182f2c95d19be352917df7fc3b67b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Feb 2024 09:26:27 +0100 +Subject: drm/lcdif: Do not disable clocks on already suspended hardware + +From: Marek Vasut + +[ Upstream commit 172695f145fb4798ab605e8a73f6e87711930124 ] + +In case the LCDIF is enabled in DT but unused, the clocks used by the +LCDIF are not enabled. Those clocks may even have a use count of 0 in +case there are no other users of those clocks. This can happen e.g. in +case the LCDIF drives HDMI bridge which has no panel plugged into the +HDMI connector. + +Do not attempt to disable clocks in the suspend callback and re-enable +clocks in the resume callback unless the LCDIF is enabled and was in +use before the system entered suspend, otherwise the driver might end +up trying to disable clocks which are already disabled with use count +0, and would trigger a warning from clock core about this condition. + +Note that the lcdif_rpm_suspend() and lcdif_rpm_resume() functions +internally perform the clocks disable and enable operations and act +as runtime PM hooks too. + +Reviewed-by: Liu Ying +Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant") +Signed-off-by: Marek Vasut +Link: https://patchwork.freedesktop.org/patch/msgid/20240226082644.32603-1-marex@denx.de +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/mxsfb/lcdif_drv.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c +index 18de2f17e2491..6494e82707569 100644 +--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c ++++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c +@@ -340,6 +340,9 @@ static int __maybe_unused lcdif_suspend(struct device *dev) + if (ret) + return ret; + ++ if (pm_runtime_suspended(dev)) ++ return 0; ++ + return lcdif_rpm_suspend(dev); + } + +@@ -347,7 +350,8 @@ static int __maybe_unused lcdif_resume(struct device *dev) + { + struct drm_device *drm = dev_get_drvdata(dev); + +- lcdif_rpm_resume(dev); ++ if (!pm_runtime_suspended(dev)) ++ lcdif_rpm_resume(dev); + + return drm_mode_config_helper_resume(drm); + } +-- +2.43.0 + diff --git a/queue-6.8/drm-mediatek-add-0-size-check-to-mtk_drm_gem_obj.patch b/queue-6.8/drm-mediatek-add-0-size-check-to-mtk_drm_gem_obj.patch new file mode 100644 index 00000000000..b67bd290fb4 --- /dev/null +++ b/queue-6.8/drm-mediatek-add-0-size-check-to-mtk_drm_gem_obj.patch @@ -0,0 +1,44 @@ +From 53d8da60d84dcd6c2d7313a7749b29f107c3837b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 13:00:51 -0500 +Subject: drm/mediatek: Add 0 size check to mtk_drm_gem_obj + +From: Justin Green + +[ Upstream commit 1e4350095e8ab2577ee05f8c3b044e661b5af9a0 ] + +Add a check to mtk_drm_gem_init if we attempt to allocate a GEM object +of 0 bytes. Currently, no such check exists and the kernel will panic if +a userspace application attempts to allocate a 0x0 GBM buffer. + +Tested by attempting to allocate a 0x0 GBM buffer on an MT8188 and +verifying that we now return EINVAL. + +Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") +Signed-off-by: Justin Green +Reviewed-by: AngeloGioacchino Del Regno +Reviewed-by: CK Hu +Link: https://patchwork.kernel.org/project/dri-devel/patch/20240307180051.4104425-1-greenjustin@chromium.org/ +Signed-off-by: Chun-Kuang Hu +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c +index 4f2e3feabc0f8..1bf229615b018 100644 +--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c ++++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c +@@ -38,6 +38,9 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev, + + size = round_up(size, PAGE_SIZE); + ++ if (size == 0) ++ return ERR_PTR(-EINVAL); ++ + mtk_gem_obj = kzalloc(sizeof(*mtk_gem_obj), GFP_KERNEL); + if (!mtk_gem_obj) + return ERR_PTR(-ENOMEM); +-- +2.43.0 + diff --git a/queue-6.8/drm-mediatek-init-ddp_comp-with-devm_kcalloc.patch b/queue-6.8/drm-mediatek-init-ddp_comp-with-devm_kcalloc.patch new file mode 100644 index 00000000000..7a01ab51f31 --- /dev/null +++ b/queue-6.8/drm-mediatek-init-ddp_comp-with-devm_kcalloc.patch @@ -0,0 +1,60 @@ +From 8903dec4902dc079e6d3288a4a54417f7ec682cc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 09:22:49 -0700 +Subject: drm/mediatek: Init `ddp_comp` with devm_kcalloc() + +From: Douglas Anderson + +[ Upstream commit 01a2c5123e27b3c4685bf2fc4c2e879f6e0c7b33 ] + +In the case where `conn_routes` is true we allocate an extra slot in +the `ddp_comp` array but mtk_drm_crtc_create() never seemed to +initialize it in the test case I ran. For me, this caused a later +crash when we looped through the array in mtk_drm_crtc_mode_valid(). +This showed up for me when I booted with `slub_debug=FZPUA` which +poisons the memory initially. Without `slub_debug` I couldn't +reproduce, presumably because the later code handles the value being +NULL and in most cases (not guaranteed in all cases) the memory the +allocator returned started out as 0. + +It really doesn't hurt to initialize the array with devm_kcalloc() +since the array is small and the overhead of initting a handful of +elements to 0 is small. In general initting memory to zero is a safer +practice and usually it's suggested to only use the non-initting alloc +functions if you really need to. + +Let's switch the function to use an allocation function that zeros the +memory. For me, this avoids the crash. + +Fixes: 01389b324c97 ("drm/mediatek: Add connector dynamic selection capability") +Signed-off-by: Douglas Anderson +Reviewed-by: CK Hu +Link: https://patchwork.kernel.org/project/dri-devel/patch/20240328092248.1.I2e73c38c0f264ee2fa4a09cdd83994e37ba9f541@changeid/ +Signed-off-by: Chun-Kuang Hu +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +index 3d17de34d72bd..d398fa1871165 100644 +--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c ++++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +@@ -992,10 +992,10 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, + + mtk_crtc->mmsys_dev = priv->mmsys_dev; + mtk_crtc->ddp_comp_nr = path_len; +- mtk_crtc->ddp_comp = devm_kmalloc_array(dev, +- mtk_crtc->ddp_comp_nr + (conn_routes ? 1 : 0), +- sizeof(*mtk_crtc->ddp_comp), +- GFP_KERNEL); ++ mtk_crtc->ddp_comp = devm_kcalloc(dev, ++ mtk_crtc->ddp_comp_nr + (conn_routes ? 1 : 0), ++ sizeof(*mtk_crtc->ddp_comp), ++ GFP_KERNEL); + if (!mtk_crtc->ddp_comp) + return -ENOMEM; + +-- +2.43.0 + diff --git a/queue-6.8/drm-meson-vclk-fix-calculation-of-59.94-fractional-r.patch b/queue-6.8/drm-meson-vclk-fix-calculation-of-59.94-fractional-r.patch new file mode 100644 index 00000000000..fa5106ffac5 --- /dev/null +++ b/queue-6.8/drm-meson-vclk-fix-calculation-of-59.94-fractional-r.patch @@ -0,0 +1,65 @@ +From ec52289abe4cf779d3019e421ab69dd068b39771 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Jan 2024 23:07:04 +0000 +Subject: drm/meson: vclk: fix calculation of 59.94 fractional rates + +From: Christian Hewitt + +[ Upstream commit bfbc68e4d8695497f858a45a142665e22a512ea3 ] + +Playing 4K media with 59.94 fractional rate (typically VP9) causes the screen to lose +sync with the following error reported in the system log: + +[ 89.610280] Fatal Error, invalid HDMI vclk freq 593406 + +Modetest shows the following: + +3840x2160 59.94 3840 4016 4104 4400 2160 2168 2178 2250 593407 flags: xxxx, xxxx, +drm calculated value -------------------------------------^ + +Change the fractional rate calculation to stop DIV_ROUND_CLOSEST rounding down which +results in vclk freq failing to match correctly. + +Fixes: e5fab2ec9ca4 ("drm/meson: vclk: add support for YUV420 setup") +Signed-off-by: Christian Hewitt +Reviewed-by: Neil Armstrong +Link: https://lore.kernel.org/r/20240109230704.4120561-1-christianshewitt@gmail.com +Signed-off-by: Neil Armstrong +Link: https://patchwork.freedesktop.org/patch/msgid/20240109230704.4120561-1-christianshewitt@gmail.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/meson/meson_vclk.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c +index 2a82119eb58ed..2a942dc6a6dc2 100644 +--- a/drivers/gpu/drm/meson/meson_vclk.c ++++ b/drivers/gpu/drm/meson/meson_vclk.c +@@ -790,13 +790,13 @@ meson_vclk_vic_supported_freq(struct meson_drm *priv, unsigned int phy_freq, + FREQ_1000_1001(params[i].pixel_freq)); + DRM_DEBUG_DRIVER("i = %d phy_freq = %d alt = %d\n", + i, params[i].phy_freq, +- FREQ_1000_1001(params[i].phy_freq/10)*10); ++ FREQ_1000_1001(params[i].phy_freq/1000)*1000); + /* Match strict frequency */ + if (phy_freq == params[i].phy_freq && + vclk_freq == params[i].vclk_freq) + return MODE_OK; + /* Match 1000/1001 variant */ +- if (phy_freq == (FREQ_1000_1001(params[i].phy_freq/10)*10) && ++ if (phy_freq == (FREQ_1000_1001(params[i].phy_freq/1000)*1000) && + vclk_freq == FREQ_1000_1001(params[i].vclk_freq)) + return MODE_OK; + } +@@ -1070,7 +1070,7 @@ void meson_vclk_setup(struct meson_drm *priv, unsigned int target, + + for (freq = 0 ; params[freq].pixel_freq ; ++freq) { + if ((phy_freq == params[freq].phy_freq || +- phy_freq == FREQ_1000_1001(params[freq].phy_freq/10)*10) && ++ phy_freq == FREQ_1000_1001(params[freq].phy_freq/1000)*1000) && + (vclk_freq == params[freq].vclk_freq || + vclk_freq == FREQ_1000_1001(params[freq].vclk_freq))) { + if (vclk_freq != params[freq].vclk_freq) +-- +2.43.0 + diff --git a/queue-6.8/drm-mipi-dsi-use-correct-return-type-for-the-dsc-fun.patch b/queue-6.8/drm-mipi-dsi-use-correct-return-type-for-the-dsc-fun.patch new file mode 100644 index 00000000000..890d4d8bafe --- /dev/null +++ b/queue-6.8/drm-mipi-dsi-use-correct-return-type-for-the-dsc-fun.patch @@ -0,0 +1,69 @@ +From d0960dd129ac6c979e8e7211c1a02260dc18cd84 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 02:53:51 +0300 +Subject: drm/mipi-dsi: use correct return type for the DSC functions + +From: Dmitry Baryshkov + +[ Upstream commit de1c705c50326acaceaf1f02bc5bf6f267c572bd ] + +The functions mipi_dsi_compression_mode() and +mipi_dsi_picture_parameter_set() return 0-or-error rather than a buffer +size. Follow example of other similar MIPI DSI functions and use int +return type instead of size_t. + +Fixes: f4dea1aaa9a1 ("drm/dsi: add helpers for DSI compression mode and PPS packets") +Reviewed-by: Marijn Suijten +Reviewed-by: Jessica Zhang +Signed-off-by: Dmitry Baryshkov +Link: https://patchwork.freedesktop.org/patch/msgid/20240408-lg-sw43408-panel-v5-2-4e092da22991@linaro.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/drm_mipi_dsi.c | 6 +++--- + include/drm/drm_mipi_dsi.h | 6 +++--- + 2 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c +index 843a6dbda93a0..52a93149363b4 100644 +--- a/drivers/gpu/drm/drm_mipi_dsi.c ++++ b/drivers/gpu/drm/drm_mipi_dsi.c +@@ -654,7 +654,7 @@ EXPORT_SYMBOL(mipi_dsi_set_maximum_return_packet_size); + * + * Return: 0 on success or a negative error code on failure. + */ +-ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable) ++int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable) + { + /* Note: Needs updating for non-default PPS or algorithm */ + u8 tx[2] = { enable << 0, 0 }; +@@ -679,8 +679,8 @@ EXPORT_SYMBOL(mipi_dsi_compression_mode); + * + * Return: 0 on success or a negative error code on failure. + */ +-ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, +- const struct drm_dsc_picture_parameter_set *pps) ++int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, ++ const struct drm_dsc_picture_parameter_set *pps) + { + struct mipi_dsi_msg msg = { + .channel = dsi->channel, +diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h +index c0aec0d4d664e..3011d33eccbd2 100644 +--- a/include/drm/drm_mipi_dsi.h ++++ b/include/drm/drm_mipi_dsi.h +@@ -241,9 +241,9 @@ int mipi_dsi_shutdown_peripheral(struct mipi_dsi_device *dsi); + int mipi_dsi_turn_on_peripheral(struct mipi_dsi_device *dsi); + int mipi_dsi_set_maximum_return_packet_size(struct mipi_dsi_device *dsi, + u16 value); +-ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable); +-ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, +- const struct drm_dsc_picture_parameter_set *pps); ++int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable); ++int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi, ++ const struct drm_dsc_picture_parameter_set *pps); + + ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, + size_t size); +-- +2.43.0 + diff --git a/queue-6.8/drm-msm-dp-allow-voltage-swing-pre-emphasis-of-3.patch b/queue-6.8/drm-msm-dp-allow-voltage-swing-pre-emphasis-of-3.patch new file mode 100644 index 00000000000..387b3ff182a --- /dev/null +++ b/queue-6.8/drm-msm-dp-allow-voltage-swing-pre-emphasis-of-3.patch @@ -0,0 +1,138 @@ +From c1f0594ad604fc58da2e8d4c994990c02421f924 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 3 Feb 2024 15:47:25 +0200 +Subject: drm/msm/dp: allow voltage swing / pre emphasis of 3 + +From: Dmitry Baryshkov + +[ Upstream commit 22578178e5dd6d3aa4490879df8b6c2977d980be ] + +Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and +pre-emphasis to 2, while the real maximum value for the sum of the +voltage swing and pre-emphasis is 3. Fix the DP code to remove this +limitation. + +Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") +Signed-off-by: Dmitry Baryshkov +Reviewed-by: Kuogee Hsieh +Tested-by: Kuogee Hsieh +Patchwork: https://patchwork.freedesktop.org/patch/577006/ +Link: https://lore.kernel.org/r/20240203-dp-swing-3-v1-1-6545e1706196@linaro.org +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/msm/dp/dp_ctrl.c | 6 +++--- + drivers/gpu/drm/msm/dp/dp_link.c | 22 +++++++++++----------- + drivers/gpu/drm/msm/dp/dp_link.h | 14 +------------- + 3 files changed, 15 insertions(+), 27 deletions(-) + +diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c +index fb588fde298a2..780e9747be1fb 100644 +--- a/drivers/gpu/drm/msm/dp/dp_ctrl.c ++++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c +@@ -1019,14 +1019,14 @@ static int dp_ctrl_update_vx_px(struct dp_ctrl_private *ctrl) + if (ret) + return ret; + +- if (voltage_swing_level >= DP_TRAIN_VOLTAGE_SWING_MAX) { ++ if (voltage_swing_level >= DP_TRAIN_LEVEL_MAX) { + drm_dbg_dp(ctrl->drm_dev, + "max. voltage swing level reached %d\n", + voltage_swing_level); + max_level_reached |= DP_TRAIN_MAX_SWING_REACHED; + } + +- if (pre_emphasis_level >= DP_TRAIN_PRE_EMPHASIS_MAX) { ++ if (pre_emphasis_level >= DP_TRAIN_LEVEL_MAX) { + drm_dbg_dp(ctrl->drm_dev, + "max. pre-emphasis level reached %d\n", + pre_emphasis_level); +@@ -1117,7 +1117,7 @@ static int dp_ctrl_link_train_1(struct dp_ctrl_private *ctrl, + } + + if (ctrl->link->phy_params.v_level >= +- DP_TRAIN_VOLTAGE_SWING_MAX) { ++ DP_TRAIN_LEVEL_MAX) { + DRM_ERROR_RATELIMITED("max v_level reached\n"); + return -EAGAIN; + } +diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c +index 49dfac1fd1ef2..ea911d9244be7 100644 +--- a/drivers/gpu/drm/msm/dp/dp_link.c ++++ b/drivers/gpu/drm/msm/dp/dp_link.c +@@ -1109,6 +1109,7 @@ int dp_link_get_colorimetry_config(struct dp_link *dp_link) + int dp_link_adjust_levels(struct dp_link *dp_link, u8 *link_status) + { + int i; ++ u8 max_p_level; + int v_max = 0, p_max = 0; + struct dp_link_private *link; + +@@ -1140,30 +1141,29 @@ int dp_link_adjust_levels(struct dp_link *dp_link, u8 *link_status) + * Adjust the voltage swing and pre-emphasis level combination to within + * the allowable range. + */ +- if (dp_link->phy_params.v_level > DP_TRAIN_VOLTAGE_SWING_MAX) { ++ if (dp_link->phy_params.v_level > DP_TRAIN_LEVEL_MAX) { + drm_dbg_dp(link->drm_dev, + "Requested vSwingLevel=%d, change to %d\n", + dp_link->phy_params.v_level, +- DP_TRAIN_VOLTAGE_SWING_MAX); +- dp_link->phy_params.v_level = DP_TRAIN_VOLTAGE_SWING_MAX; ++ DP_TRAIN_LEVEL_MAX); ++ dp_link->phy_params.v_level = DP_TRAIN_LEVEL_MAX; + } + +- if (dp_link->phy_params.p_level > DP_TRAIN_PRE_EMPHASIS_MAX) { ++ if (dp_link->phy_params.p_level > DP_TRAIN_LEVEL_MAX) { + drm_dbg_dp(link->drm_dev, + "Requested preEmphasisLevel=%d, change to %d\n", + dp_link->phy_params.p_level, +- DP_TRAIN_PRE_EMPHASIS_MAX); +- dp_link->phy_params.p_level = DP_TRAIN_PRE_EMPHASIS_MAX; ++ DP_TRAIN_LEVEL_MAX); ++ dp_link->phy_params.p_level = DP_TRAIN_LEVEL_MAX; + } + +- if ((dp_link->phy_params.p_level > DP_TRAIN_PRE_EMPHASIS_LVL_1) +- && (dp_link->phy_params.v_level == +- DP_TRAIN_VOLTAGE_SWING_LVL_2)) { ++ max_p_level = DP_TRAIN_LEVEL_MAX - dp_link->phy_params.v_level; ++ if (dp_link->phy_params.p_level > max_p_level) { + drm_dbg_dp(link->drm_dev, + "Requested preEmphasisLevel=%d, change to %d\n", + dp_link->phy_params.p_level, +- DP_TRAIN_PRE_EMPHASIS_LVL_1); +- dp_link->phy_params.p_level = DP_TRAIN_PRE_EMPHASIS_LVL_1; ++ max_p_level); ++ dp_link->phy_params.p_level = max_p_level; + } + + drm_dbg_dp(link->drm_dev, "adjusted: v_level=%d, p_level=%d\n", +diff --git a/drivers/gpu/drm/msm/dp/dp_link.h b/drivers/gpu/drm/msm/dp/dp_link.h +index 9dd4dd9265304..79c3a02b8dacd 100644 +--- a/drivers/gpu/drm/msm/dp/dp_link.h ++++ b/drivers/gpu/drm/msm/dp/dp_link.h +@@ -19,19 +19,7 @@ struct dp_link_info { + unsigned long capabilities; + }; + +-enum dp_link_voltage_level { +- DP_TRAIN_VOLTAGE_SWING_LVL_0 = 0, +- DP_TRAIN_VOLTAGE_SWING_LVL_1 = 1, +- DP_TRAIN_VOLTAGE_SWING_LVL_2 = 2, +- DP_TRAIN_VOLTAGE_SWING_MAX = DP_TRAIN_VOLTAGE_SWING_LVL_2, +-}; +- +-enum dp_link_preemaphasis_level { +- DP_TRAIN_PRE_EMPHASIS_LVL_0 = 0, +- DP_TRAIN_PRE_EMPHASIS_LVL_1 = 1, +- DP_TRAIN_PRE_EMPHASIS_LVL_2 = 2, +- DP_TRAIN_PRE_EMPHASIS_MAX = DP_TRAIN_PRE_EMPHASIS_LVL_2, +-}; ++#define DP_TRAIN_LEVEL_MAX 3 + + struct dp_link_test_video { + u32 test_video_pattern; +-- +2.43.0 + diff --git a/queue-6.8/drm-msm-dp-avoid-a-long-timeout-for-aux-transfer-if-.patch b/queue-6.8/drm-msm-dp-avoid-a-long-timeout-for-aux-transfer-if-.patch new file mode 100644 index 00000000000..2972f9dbf8b --- /dev/null +++ b/queue-6.8/drm-msm-dp-avoid-a-long-timeout-for-aux-transfer-if-.patch @@ -0,0 +1,133 @@ +From 5acfd8c4c7d6bcb4ae854680a35bf524bbc342f6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 15 Mar 2024 14:36:29 -0700 +Subject: drm/msm/dp: Avoid a long timeout for AUX transfer if nothing + connected + +From: Douglas Anderson + +[ Upstream commit 5d1a7493343cc00d9019880b686e4e0a0f649531 ] + +As documented in the description of the transfer() function of +"struct drm_dp_aux", the transfer() function can be called at any time +regardless of the state of the DP port. Specifically if the kernel has +the DP AUX character device enabled and userspace accesses +"/dev/drm_dp_auxN" directly then the AUX transfer function will be +called regardless of whether a DP device is connected. + +For eDP panels we have a special rule where we wait (with a 5 second +timeout) for HPD to go high. This rule was important before all panels +drivers were converted to call wait_hpd_asserted() and actually can be +removed in a future commit. + +For external DP devices we never checked for HPD. That means that +trying to access the DP AUX character device (AKA `hexdump -C +/dev/drm_dp_auxN`) would very, very slowly timeout. Specifically on my +system: + $ time hexdump -C /dev/drm_dp_aux0 + hexdump: /dev/drm_dp_aux0: Connection timed out + real 0m8.200s +We want access to the drm_dp_auxN character device to fail faster than +8 seconds when no DP cable is plugged in. + +Let's add a test to make transfers fail right away if a device isn't +plugged in. Rather than testing the HPD line directly, we have the +dp_display module tell us when AUX transfers should be enabled so we +can handle cases where HPD is signaled out of band like with Type C. + +Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") +Signed-off-by: Douglas Anderson +Reviewed-by: Guenter Roeck +Reviewed-by: Abhinav Kumar +Patchwork: https://patchwork.freedesktop.org/patch/583127/ +Link: https://lore.kernel.org/r/20240315143621.v2.1.I16aff881c9fe82b5e0fc06ca312da017aa7b5b3e@changeid +Signed-off-by: Dmitry Baryshkov +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/msm/dp/dp_aux.c | 20 ++++++++++++++++++++ + drivers/gpu/drm/msm/dp/dp_aux.h | 1 + + drivers/gpu/drm/msm/dp/dp_display.c | 4 ++++ + 3 files changed, 25 insertions(+) + +diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c +index 03f4951c49f42..e67a80d56948c 100644 +--- a/drivers/gpu/drm/msm/dp/dp_aux.c ++++ b/drivers/gpu/drm/msm/dp/dp_aux.c +@@ -35,6 +35,7 @@ struct dp_aux_private { + bool no_send_stop; + bool initted; + bool is_edp; ++ bool enable_xfers; + u32 offset; + u32 segment; + +@@ -301,6 +302,17 @@ static ssize_t dp_aux_transfer(struct drm_dp_aux *dp_aux, + goto exit; + } + ++ /* ++ * If we're using DP and an external display isn't connected then the ++ * transfer won't succeed. Return right away. If we don't do this we ++ * can end up with long timeouts if someone tries to access the DP AUX ++ * character device when no DP device is connected. ++ */ ++ if (!aux->is_edp && !aux->enable_xfers) { ++ ret = -ENXIO; ++ goto exit; ++ } ++ + /* + * For eDP it's important to give a reasonably long wait here for HPD + * to be asserted. This is because the panel driver may have _just_ +@@ -433,6 +445,14 @@ irqreturn_t dp_aux_isr(struct drm_dp_aux *dp_aux) + return IRQ_HANDLED; + } + ++void dp_aux_enable_xfers(struct drm_dp_aux *dp_aux, bool enabled) ++{ ++ struct dp_aux_private *aux; ++ ++ aux = container_of(dp_aux, struct dp_aux_private, dp_aux); ++ aux->enable_xfers = enabled; ++} ++ + void dp_aux_reconfig(struct drm_dp_aux *dp_aux) + { + struct dp_aux_private *aux; +diff --git a/drivers/gpu/drm/msm/dp/dp_aux.h b/drivers/gpu/drm/msm/dp/dp_aux.h +index 511305da4f66d..f3052cb43306b 100644 +--- a/drivers/gpu/drm/msm/dp/dp_aux.h ++++ b/drivers/gpu/drm/msm/dp/dp_aux.h +@@ -12,6 +12,7 @@ + int dp_aux_register(struct drm_dp_aux *dp_aux); + void dp_aux_unregister(struct drm_dp_aux *dp_aux); + irqreturn_t dp_aux_isr(struct drm_dp_aux *dp_aux); ++void dp_aux_enable_xfers(struct drm_dp_aux *dp_aux, bool enabled); + void dp_aux_init(struct drm_dp_aux *dp_aux); + void dp_aux_deinit(struct drm_dp_aux *dp_aux); + void dp_aux_reconfig(struct drm_dp_aux *dp_aux); +diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c +index 78464c395c3d9..0840860336790 100644 +--- a/drivers/gpu/drm/msm/dp/dp_display.c ++++ b/drivers/gpu/drm/msm/dp/dp_display.c +@@ -565,6 +565,8 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data) + int ret; + struct platform_device *pdev = dp->dp_display.pdev; + ++ dp_aux_enable_xfers(dp->aux, true); ++ + mutex_lock(&dp->event_mutex); + + state = dp->hpd_state; +@@ -630,6 +632,8 @@ static int dp_hpd_unplug_handle(struct dp_display_private *dp, u32 data) + u32 state; + struct platform_device *pdev = dp->dp_display.pdev; + ++ dp_aux_enable_xfers(dp->aux, false); ++ + mutex_lock(&dp->event_mutex); + + state = dp->hpd_state; +-- +2.43.0 + diff --git a/queue-6.8/drm-nouveau-dp-fix-incorrect-return-code-in-r535_dp_.patch b/queue-6.8/drm-nouveau-dp-fix-incorrect-return-code-in-r535_dp_.patch new file mode 100644 index 00000000000..b53d7fe81f5 --- /dev/null +++ b/queue-6.8/drm-nouveau-dp-fix-incorrect-return-code-in-r535_dp_.patch @@ -0,0 +1,48 @@ +From 1898e92841734675e599b4b1e82b5823b38df9e1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 15 Mar 2024 17:20:56 -0400 +Subject: drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer() + +From: Lyude Paul + +[ Upstream commit 97252d0a4bfbb07079503d059f7522d305fe0f7a ] + +I've recently been seeing some unexplained GSP errors on my RTX 6000 from +failed aux transactions: + + [ 132.915867] nouveau 0000:1f:00.0: gsp: cli:0xc1d00002 obj:0x00730000 + ctrl cmd:0x00731341 failed: 0x0000ffff + +While the cause of these is not yet clear, these messages made me notice +that the aux transactions causing these transactions were succeeding - not +failing. As it turns out, this is because we're currently not returning the +correct variable when r535_dp_aux_xfer() hits an error - causing us to +never propagate GSP errors for failed aux transactions to userspace. + +So, let's fix that. + +Fixes: 4ae3a20102b2 ("nouveau/gsp: don't free ctrl messages on errors") +Signed-off-by: Lyude Paul +Reviewed-by: Dave Airlie +Link: https://patchwork.freedesktop.org/patch/msgid/20240315212104.776936-1-lyude@redhat.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c +index 6a0a4d3b8902d..027867c2a8c5b 100644 +--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c ++++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c +@@ -1080,7 +1080,7 @@ r535_dp_aux_xfer(struct nvkm_outp *outp, u8 type, u32 addr, u8 *data, u8 *psize) + ret = nvkm_gsp_rm_ctrl_push(&disp->rm.objcom, &ctrl, sizeof(*ctrl)); + if (ret) { + nvkm_gsp_rm_ctrl_done(&disp->rm.objcom, ctrl); +- return PTR_ERR(ctrl); ++ return ret; + } + + memcpy(data, ctrl->data, size); +-- +2.43.0 + diff --git a/queue-6.8/drm-omapdrm-fix-console-by-implementing-fb_dirty.patch b/queue-6.8/drm-omapdrm-fix-console-by-implementing-fb_dirty.patch new file mode 100644 index 00000000000..867fb5a7fc2 --- /dev/null +++ b/queue-6.8/drm-omapdrm-fix-console-by-implementing-fb_dirty.patch @@ -0,0 +1,54 @@ +From 7078e5acdca520714403553f73a6cc52c67793f3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Feb 2024 08:35:31 +0200 +Subject: drm/omapdrm: Fix console by implementing fb_dirty + +From: Tony Lindgren + +[ Upstream commit 632bac50544c0929ced9eed41e7d04c08adecbb0 ] + +The framebuffer console stopped updating with commit f231af498c29 +("drm/fb-helper: Disconnect damage worker from update logic"). + +Let's fix the issue by implementing fb_dirty similar to what was done +with commit 039a72ce7e57 ("drm/i915/fbdev: Implement fb_dirty for intel +custom fb helper"). + +Fixes: f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic") +Reviewed-by: Thomas Zimmermann +Signed-off-by: Tony Lindgren +Signed-off-by: Tomi Valkeinen +Link: https://patchwork.freedesktop.org/patch/msgid/20240228063540.4444-2-tony@atomide.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/omapdrm/omap_fbdev.c | 12 ++++++++++++ + 1 file changed, 12 insertions(+) + +diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c +index 6b08b137af1ad..7c5af3de1e727 100644 +--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c ++++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c +@@ -238,8 +238,20 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, + return ret; + } + ++static int omap_fbdev_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip) ++{ ++ if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2)) ++ return 0; ++ ++ if (helper->fb->funcs->dirty) ++ return helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1); ++ ++ return 0; ++} ++ + static const struct drm_fb_helper_funcs omap_fb_helper_funcs = { + .fb_probe = omap_fbdev_create, ++ .fb_dirty = omap_fbdev_dirty, + }; + + static struct drm_fb_helper *get_fb(struct fb_info *fbi) +-- +2.43.0 + diff --git a/queue-6.8/drm-omapdrm-fix-console-with-deferred-ops.patch b/queue-6.8/drm-omapdrm-fix-console-with-deferred-ops.patch new file mode 100644 index 00000000000..61d8415942d --- /dev/null +++ b/queue-6.8/drm-omapdrm-fix-console-with-deferred-ops.patch @@ -0,0 +1,156 @@ +From d9b0444b273eadad0a299b7aeb51a135b69dd184 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Feb 2024 08:35:32 +0200 +Subject: drm/omapdrm: Fix console with deferred ops + +From: Tony Lindgren + +[ Upstream commit 01c0cce88c5480cc2505b79330246ef12eda938f ] + +Commit 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") +stopped console from updating for command mode displays because there is +no damage handling in fb_sys_write() unlike we had earlier in +drm_fb_helper_sys_write(). + +Let's fix the issue by adding FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS and +FB_DMAMEM_HELPERS_DEFERRED as suggested by Thomas. We cannot use the +FB_DEFAULT_DEFERRED_OPS as fb_deferred_io_mmap() won't work properly +for write-combine. + +Fixes: 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") +Suggested-by: Thomas Zimmermann +Reviewed-by: Thomas Zimmermann +Signed-off-by: Tony Lindgren +Signed-off-by: Tomi Valkeinen +Link: https://patchwork.freedesktop.org/patch/msgid/20240228063540.4444-3-tony@atomide.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/omapdrm/Kconfig | 2 +- + drivers/gpu/drm/omapdrm/omap_fbdev.c | 28 ++++++++++++++++++++++------ + drivers/video/fbdev/core/Kconfig | 6 ++++++ + include/linux/fb.h | 4 ++++ + 4 files changed, 33 insertions(+), 7 deletions(-) + +diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig +index b715301ec79f6..6c49270cb290a 100644 +--- a/drivers/gpu/drm/omapdrm/Kconfig ++++ b/drivers/gpu/drm/omapdrm/Kconfig +@@ -4,7 +4,7 @@ config DRM_OMAP + depends on DRM && OF + depends on ARCH_OMAP2PLUS + select DRM_KMS_HELPER +- select FB_DMAMEM_HELPERS if DRM_FBDEV_EMULATION ++ select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION + select VIDEOMODE_HELPERS + select HDMI + default n +diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c +index 7c5af3de1e727..523be34682caf 100644 +--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c ++++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c +@@ -51,6 +51,10 @@ static void pan_worker(struct work_struct *work) + omap_gem_roll(bo, fbi->var.yoffset * npages); + } + ++FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS(omap_fbdev, ++ drm_fb_helper_damage_range, ++ drm_fb_helper_damage_area) ++ + static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, + struct fb_info *fbi) + { +@@ -78,11 +82,9 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, + + static int omap_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) + { +- struct drm_fb_helper *helper = info->par; +- struct drm_framebuffer *fb = helper->fb; +- struct drm_gem_object *bo = drm_gem_fb_get_obj(fb, 0); ++ vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); + +- return drm_gem_mmap_obj(bo, omap_gem_mmap_size(bo), vma); ++ return fb_deferred_io_mmap(info, vma); + } + + static void omap_fbdev_fb_destroy(struct fb_info *info) +@@ -94,6 +96,7 @@ static void omap_fbdev_fb_destroy(struct fb_info *info) + + DBG(); + ++ fb_deferred_io_cleanup(info); + drm_fb_helper_fini(helper); + + omap_gem_unpin(bo); +@@ -104,15 +107,19 @@ static void omap_fbdev_fb_destroy(struct fb_info *info) + kfree(fbdev); + } + ++/* ++ * For now, we cannot use FB_DEFAULT_DEFERRED_OPS and fb_deferred_io_mmap() ++ * because we use write-combine. ++ */ + static const struct fb_ops omap_fb_ops = { + .owner = THIS_MODULE, +- __FB_DEFAULT_DMAMEM_OPS_RDWR, ++ __FB_DEFAULT_DEFERRED_OPS_RDWR(omap_fbdev), + .fb_check_var = drm_fb_helper_check_var, + .fb_set_par = drm_fb_helper_set_par, + .fb_setcmap = drm_fb_helper_setcmap, + .fb_blank = drm_fb_helper_blank, + .fb_pan_display = omap_fbdev_pan_display, +- __FB_DEFAULT_DMAMEM_OPS_DRAW, ++ __FB_DEFAULT_DEFERRED_OPS_DRAW(omap_fbdev), + .fb_ioctl = drm_fb_helper_ioctl, + .fb_mmap = omap_fbdev_fb_mmap, + .fb_destroy = omap_fbdev_fb_destroy, +@@ -213,6 +220,15 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, + fbi->fix.smem_start = dma_addr; + fbi->fix.smem_len = bo->size; + ++ /* deferred I/O */ ++ helper->fbdefio.delay = HZ / 20; ++ helper->fbdefio.deferred_io = drm_fb_helper_deferred_io; ++ ++ fbi->fbdefio = &helper->fbdefio; ++ ret = fb_deferred_io_init(fbi); ++ if (ret) ++ goto fail; ++ + /* if we have DMM, then we can use it for scrolling by just + * shuffling pages around in DMM rather than doing sw blit. + */ +diff --git a/drivers/video/fbdev/core/Kconfig b/drivers/video/fbdev/core/Kconfig +index 21053bf00dc58..c0a5e4cbe0ac2 100644 +--- a/drivers/video/fbdev/core/Kconfig ++++ b/drivers/video/fbdev/core/Kconfig +@@ -144,6 +144,12 @@ config FB_DMAMEM_HELPERS + select FB_SYS_IMAGEBLIT + select FB_SYSMEM_FOPS + ++config FB_DMAMEM_HELPERS_DEFERRED ++ bool ++ depends on FB_CORE ++ select FB_DEFERRED_IO ++ select FB_DMAMEM_HELPERS ++ + config FB_IOMEM_FOPS + tristate + depends on FB_CORE +diff --git a/include/linux/fb.h b/include/linux/fb.h +index 05dc9624897df..25ca209e4d21d 100644 +--- a/include/linux/fb.h ++++ b/include/linux/fb.h +@@ -686,6 +686,10 @@ extern int fb_deferred_io_fsync(struct file *file, loff_t start, + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) + ++#define FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS(__prefix, __damage_range, __damage_area) \ ++ __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ ++ __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) ++ + /* + * Initializes struct fb_ops for deferred I/O. + */ +-- +2.43.0 + diff --git a/queue-6.8/drm-panel-atna33xc20-fix-unbalanced-regulator-in-the.patch b/queue-6.8/drm-panel-atna33xc20-fix-unbalanced-regulator-in-the.patch new file mode 100644 index 00000000000..114de11e21c --- /dev/null +++ b/queue-6.8/drm-panel-atna33xc20-fix-unbalanced-regulator-in-the.patch @@ -0,0 +1,74 @@ +From 4ac62577b4bef3bd4a0e3dcbd302ef61300f4994 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 13 Mar 2024 14:12:14 -0700 +Subject: drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD + doesn't assert + +From: Douglas Anderson + +[ Upstream commit 5e842d55bad7794823a50f24fd645b58f2ef93ab ] + +When the atna33xc20 driver was first written the resume code never +returned an error. If there was a problem waiting for HPD it just +printed a warning and moved on. This changed in response to review +feedback [1] on a future patch but I accidentally didn't account for +rolling back the regulator enable in the error cases. Do so now. + +[1] https://lore.kernel.org/all/5f3cf3a6-1cc2-63e4-f76b-4ee686764705@linaro.org/ + +Fixes: 3b5765df375c ("drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_aux") +Acked-by: Jessica Zhang +Signed-off-by: Douglas Anderson +Link: https://patchwork.freedesktop.org/patch/msgid/20240313-homestarpanel-regulator-v1-1-b8e3a336da12@chromium.org +Signed-off-by: Sasha Levin +--- + .../gpu/drm/panel/panel-samsung-atna33xc20.c | 22 +++++++++++-------- + 1 file changed, 13 insertions(+), 9 deletions(-) + +diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +index 76c2a8f6718c8..9c336c71562b9 100644 +--- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c ++++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +@@ -109,19 +109,17 @@ static int atana33xc20_resume(struct device *dev) + if (hpd_asserted < 0) + ret = hpd_asserted; + +- if (ret) ++ if (ret) { + dev_warn(dev, "Error waiting for HPD GPIO: %d\n", ret); +- +- return ret; +- } +- +- if (p->aux->wait_hpd_asserted) { ++ goto error; ++ } ++ } else if (p->aux->wait_hpd_asserted) { + ret = p->aux->wait_hpd_asserted(p->aux, HPD_MAX_US); + +- if (ret) ++ if (ret) { + dev_warn(dev, "Controller error waiting for HPD: %d\n", ret); +- +- return ret; ++ goto error; ++ } + } + + /* +@@ -133,6 +131,12 @@ static int atana33xc20_resume(struct device *dev) + * right times. + */ + return 0; ++ ++error: ++ drm_dp_dpcd_set_powered(p->aux, false); ++ regulator_disable(p->supply); ++ ++ return ret; + } + + static int atana33xc20_disable(struct drm_panel *panel) +-- +2.43.0 + diff --git a/queue-6.8/drm-panel-ltk050h3146w-add-mipi_dsi_mode_video-to-lt.patch b/queue-6.8/drm-panel-ltk050h3146w-add-mipi_dsi_mode_video-to-lt.patch new file mode 100644 index 00000000000..8952341712f --- /dev/null +++ b/queue-6.8/drm-panel-ltk050h3146w-add-mipi_dsi_mode_video-to-lt.patch @@ -0,0 +1,44 @@ +From 6d5f574d1009c38db6199b9efa553ecadc01f8cd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 14:12:31 +0100 +Subject: drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W + flags + +From: Heiko Stuebner + +[ Upstream commit 80cc8c0d09e6bab3bd016ddaccd0570cadbe1891 ] + +Similar to other variants, the LTK050H3148W wants to run in video mode +when displaying data. So far only the Synopsis DSI driver was using this +panel and it is always switching to video mode, independent of this flag +being set. + +Other DSI drivers might handle this differently, so add the flag. + +Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant") +Signed-off-by: Heiko Stuebner +Reviewed-by: Quentin Schulz +Acked-by: Jessica Zhang +Link: https://patchwork.freedesktop.org/patch/msgid/20240320131232.327196-1-heiko@sntech.de +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +index 30919c872ac8d..a50f5330a6614 100644 +--- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c ++++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +@@ -326,7 +326,8 @@ static const struct drm_display_mode ltk050h3148w_mode = { + static const struct ltk050h3146w_desc ltk050h3148w_data = { + .mode = <k050h3148w_mode, + .init = ltk050h3148w_init_sequence, +- .mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_VIDEO_BURST, ++ .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | ++ MIPI_DSI_MODE_VIDEO_BURST, + }; + + static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx) +-- +2.43.0 + diff --git a/queue-6.8/drm-panel-ltk050h3146w-drop-duplicate-commands-from-.patch b/queue-6.8/drm-panel-ltk050h3146w-drop-duplicate-commands-from-.patch new file mode 100644 index 00000000000..2490a5f2d0c --- /dev/null +++ b/queue-6.8/drm-panel-ltk050h3146w-drop-duplicate-commands-from-.patch @@ -0,0 +1,41 @@ +From 25862977b562bb13cdd36bfaaa9008c5dff7be11 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 14:12:32 +0100 +Subject: drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W + init + +From: Heiko Stuebner + +[ Upstream commit 55679cc22e60e8ec23b2340248389022798416cd ] + +The init sequence specifies the 0x11 and 0x29 dsi commands, which are +the exit-sleep and display-on commands. + +In the actual prepare step the driver already uses the appropriate +function calls for those, so drop the duplicates. + +Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant") +Signed-off-by: Heiko Stuebner +Reviewed-by: Quentin Schulz +Link: https://patchwork.freedesktop.org/patch/msgid/20240320131232.327196-2-heiko@sntech.de +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +index a50f5330a6614..8e0f5c3e3b98e 100644 +--- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c ++++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +@@ -295,8 +295,6 @@ static int ltk050h3148w_init_sequence(struct ltk050h3146w *ctx) + mipi_dsi_dcs_write_seq(dsi, 0xbd, 0x00); + mipi_dsi_dcs_write_seq(dsi, 0xc6, 0xef); + mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x02); +- mipi_dsi_dcs_write_seq(dsi, 0x11); +- mipi_dsi_dcs_write_seq(dsi, 0x29); + + ret = mipi_dsi_dcs_set_tear_on(dsi, 1); + if (ret < 0) { +-- +2.43.0 + diff --git a/queue-6.8/drm-panel-novatek-nt35950-don-t-log-an-error-when-ds.patch b/queue-6.8/drm-panel-novatek-nt35950-don-t-log-an-error-when-ds.patch new file mode 100644 index 00000000000..e6c959418fe --- /dev/null +++ b/queue-6.8/drm-panel-novatek-nt35950-don-t-log-an-error-when-ds.patch @@ -0,0 +1,49 @@ +From a7951993be703e26e8560aa0d41e6a074b2b2721 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 17:49:36 -0400 +Subject: drm/panel: novatek-nt35950: Don't log an error when DSI host can't be + found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Nícolas F. R. A. Prado + +[ Upstream commit 5ff5505b9a2d827cae3f95dceba258c963138175 ] + +Given that failing to find a DSI host causes the driver to defer probe, +make use of dev_err_probe() to log the reason. This makes the defer +probe reason available and avoids alerting userspace about something +that is not necessarily an error. + +Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") +Suggested-by: AngeloGioacchino Del Regno +Reviewed-by: Laurent Pinchart +Signed-off-by: Nícolas F. R. A. Prado +Signed-off-by: Robert Foss +Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-8-619a28148e5c@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++---- + 1 file changed, 2 insertions(+), 4 deletions(-) + +diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c +index 648ce92014265..028fdac293f77 100644 +--- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c ++++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c +@@ -556,10 +556,8 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) + } + dsi_r_host = of_find_mipi_dsi_host_by_node(dsi_r); + of_node_put(dsi_r); +- if (!dsi_r_host) { +- dev_err(dev, "Cannot get secondary DSI host\n"); +- return -EPROBE_DEFER; +- } ++ if (!dsi_r_host) ++ return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n"); + + nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info); + if (!nt->dsi[1]) { +-- +2.43.0 + diff --git a/queue-6.8/drm-panel-simple-add-missing-innolux-g121x1-l03-form.patch b/queue-6.8/drm-panel-simple-add-missing-innolux-g121x1-l03-form.patch new file mode 100644 index 00000000000..4336c1e48de --- /dev/null +++ b/queue-6.8/drm-panel-simple-add-missing-innolux-g121x1-l03-form.patch @@ -0,0 +1,50 @@ +From 7873f831df30b731c9606edd06e3b3ba17153b59 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 11:27:36 +0100 +Subject: drm/panel: simple: Add missing Innolux G121X1-L03 format, flags, + connector + +From: Marek Vasut + +[ Upstream commit 11ac72d033b9f577e8ba0c7a41d1c312bb232593 ] + +The .bpc = 6 implies .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , +add the missing bus_format. Add missing connector type and bus_flags +as well. + +Documentation [1] 1.4 GENERAL SPECIFICATI0NS indicates this panel is +capable of both RGB 18bit/24bit panel, the current configuration uses +18bit mode, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , .bpc = 6. + +Support for the 24bit mode would require another entry in panel-simple +with .bus_format = MEDIA_BUS_FMT_RGB666_1X7X4_SPWG and .bpc = 8, which +is out of scope of this fix. + +[1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf + +Fixes: f8fa17ba812b ("drm/panel: simple: Add support for Innolux G121X1-L03") +Signed-off-by: Marek Vasut +Acked-by: Jessica Zhang +Link: https://patchwork.freedesktop.org/patch/msgid/20240328102746.17868-2-marex@denx.de +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/panel/panel-simple.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c +index 72fdab8adb088..228c5c48e1588 100644 +--- a/drivers/gpu/drm/panel/panel-simple.c ++++ b/drivers/gpu/drm/panel/panel-simple.c +@@ -2564,6 +2564,9 @@ static const struct panel_desc innolux_g121x1_l03 = { + .unprepare = 200, + .disable = 400, + }, ++ .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, ++ .bus_flags = DRM_BUS_FLAG_DE_HIGH, ++ .connector_type = DRM_MODE_CONNECTOR_LVDS, + }; + + static const struct display_timing innolux_g156hce_l01_timings = { +-- +2.43.0 + diff --git a/queue-6.8/drm-rockchip-vop2-do-not-divide-height-twice-for-yuv.patch b/queue-6.8/drm-rockchip-vop2-do-not-divide-height-twice-for-yuv.patch new file mode 100644 index 00000000000..304fc238752 --- /dev/null +++ b/queue-6.8/drm-rockchip-vop2-do-not-divide-height-twice-for-yuv.patch @@ -0,0 +1,83 @@ +From 4b498028ddad3fb6d0aa6611bd48cd96ea87c621 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 14 Apr 2024 14:27:06 -0400 +Subject: drm/rockchip: vop2: Do not divide height twice for YUV + +From: Detlev Casanova + +[ Upstream commit e80c219f52861e756181d7f88b0d341116daac2b ] + +For the cbcr format, gt2 and gt4 are computed again after src_h has been +divided by vsub. + +As src_h as already been divided by 2 before, introduce cbcr_src_h and +cbcr_src_w to keep a copy of those values to be used for cbcr gt2 and +gt4 computation. + +This fixes yuv planes being unaligned vertically when down scaling to +1080 pixels from 2160. + +Signed-off-by: Detlev Casanova +Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") +Acked-by: Andy Yan +Signed-off-by: Heiko Stuebner +Link: https://patchwork.freedesktop.org/patch/msgid/20240414182706.655270-1-detlev.casanova@collabora.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 22 +++++++++++--------- + 1 file changed, 12 insertions(+), 10 deletions(-) + +diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +index fdd768bbd487c..62ebbdb16253d 100644 +--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c ++++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +@@ -706,6 +706,8 @@ static void vop2_setup_scale(struct vop2 *vop2, const struct vop2_win *win, + const struct drm_format_info *info; + u16 hor_scl_mode, ver_scl_mode; + u16 hscl_filter_mode, vscl_filter_mode; ++ uint16_t cbcr_src_w = src_w; ++ uint16_t cbcr_src_h = src_h; + u8 gt2 = 0; + u8 gt4 = 0; + u32 val; +@@ -763,27 +765,27 @@ static void vop2_setup_scale(struct vop2 *vop2, const struct vop2_win *win, + vop2_win_write(win, VOP2_WIN_YRGB_VSCL_FILTER_MODE, vscl_filter_mode); + + if (info->is_yuv) { +- src_w /= info->hsub; +- src_h /= info->vsub; ++ cbcr_src_w /= info->hsub; ++ cbcr_src_h /= info->vsub; + + gt4 = 0; + gt2 = 0; + +- if (src_h >= (4 * dst_h)) { ++ if (cbcr_src_h >= (4 * dst_h)) { + gt4 = 1; +- src_h >>= 2; +- } else if (src_h >= (2 * dst_h)) { ++ cbcr_src_h >>= 2; ++ } else if (cbcr_src_h >= (2 * dst_h)) { + gt2 = 1; +- src_h >>= 1; ++ cbcr_src_h >>= 1; + } + +- hor_scl_mode = scl_get_scl_mode(src_w, dst_w); +- ver_scl_mode = scl_get_scl_mode(src_h, dst_h); ++ hor_scl_mode = scl_get_scl_mode(cbcr_src_w, dst_w); ++ ver_scl_mode = scl_get_scl_mode(cbcr_src_h, dst_h); + +- val = vop2_scale_factor(src_w, dst_w); ++ val = vop2_scale_factor(cbcr_src_w, dst_w); + vop2_win_write(win, VOP2_WIN_SCALE_CBCR_X, val); + +- val = vop2_scale_factor(src_h, dst_h); ++ val = vop2_scale_factor(cbcr_src_h, dst_h); + vop2_win_write(win, VOP2_WIN_SCALE_CBCR_Y, val); + + vop2_win_write(win, VOP2_WIN_VSD_CBCR_GT4, gt4); +-- +2.43.0 + diff --git a/queue-6.8/drm-vc4-fix-possible-null-pointer-dereference.patch b/queue-6.8/drm-vc4-fix-possible-null-pointer-dereference.patch new file mode 100644 index 00000000000..37bc4bea2b9 --- /dev/null +++ b/queue-6.8/drm-vc4-fix-possible-null-pointer-dereference.patch @@ -0,0 +1,39 @@ +From 82ac352cac1cb72ca83553510f2d5ad7161b46c3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 10:56:22 +0300 +Subject: drm: vc4: Fix possible null pointer dereference + +From: Aleksandr Mishin + +[ Upstream commit c534b63bede6cb987c2946ed4d0b0013a52c5ba7 ] + +In vc4_hdmi_audio_init() of_get_address() may return +NULL which is later dereferenced. Fix this bug by adding NULL check. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: bb7d78568814 ("drm/vc4: Add HDMI audio support") +Signed-off-by: Aleksandr Mishin +Signed-off-by: Maxime Ripard +Link: https://patchwork.freedesktop.org/patch/msgid/20240409075622.11783-1-amishin@t-argos.ru +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/vc4/vc4_hdmi.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c +index f827f26543641..eff47465707be 100644 +--- a/drivers/gpu/drm/vc4/vc4_hdmi.c ++++ b/drivers/gpu/drm/vc4/vc4_hdmi.c +@@ -2739,6 +2739,8 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi) + index = 1; + + addr = of_get_address(dev->of_node, index, NULL, NULL); ++ if (!addr) ++ return -EINVAL; + + vc4_hdmi->audio.dma_data.addr = be32_to_cpup(addr) + mai_data->offset; + vc4_hdmi->audio.dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; +-- +2.43.0 + diff --git a/queue-6.8/dt-bindings-rockchip-grf-add-missing-type-to-pcie-ph.patch b/queue-6.8/dt-bindings-rockchip-grf-add-missing-type-to-pcie-ph.patch new file mode 100644 index 00000000000..c138cca5e54 --- /dev/null +++ b/queue-6.8/dt-bindings-rockchip-grf-add-missing-type-to-pcie-ph.patch @@ -0,0 +1,37 @@ +From a4209bfb00ab0b7e91f5552c936275e1949243e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 1 Apr 2024 15:49:58 -0500 +Subject: dt-bindings: rockchip: grf: Add missing type to 'pcie-phy' node + +From: Rob Herring + +[ Upstream commit d41201c90f825f19a46afbfb502f22f612d8ccc4 ] + +'pcie-phy' is missing any type. Add 'type: object' to indicate it's a +node. + +Signed-off-by: Rob Herring +Reviewed-by: Heiko Stuebner +Acked-by: Conor Dooley +Link: https://lore.kernel.org/r/20240401204959.1698106-1-robh@kernel.org +Signed-off-by: Heiko Stuebner +Signed-off-by: Sasha Levin +--- + Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml +index 9793ea6f0fe65..575555810c2c2 100644 +--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml ++++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml +@@ -165,6 +165,7 @@ allOf: + unevaluatedProperties: false + + pcie-phy: ++ type: object + description: + Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt + +-- +2.43.0 + diff --git a/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-add-loongs.patch b/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-add-loongs.patch new file mode 100644 index 00000000000..4bf2d291da1 --- /dev/null +++ b/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-add-loongs.patch @@ -0,0 +1,40 @@ +From 3657a03002c7c9984bc57e507d973ab4e8bf8e77 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 09:59:01 +0800 +Subject: dt-bindings: thermal: loongson,ls2k-thermal: Add Loongson-2K0500 + compatible + +From: Binbin Zhou + +[ Upstream commit 25c7d8472f6e90390931e93f59135478af3e5d86 ] + +The thermal on the Loongson-2K0500 shares the design with the +Loongson-2K1000. Define corresponding compatible string, having the +loongson,ls2k1000-thermal as a fallback. + +Signed-off-by: Binbin Zhou +Acked-by: Rob Herring +Acked-by: Huacai Chen +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/26524a63abd2d032e4c45efe6ce3fedb46841768.1713837379.git.zhoubinbin@loongson.cn +Stable-dep-of: c8c435368577 ("dt-bindings: thermal: loongson,ls2k-thermal: Fix incorrect compatible definition") +Signed-off-by: Sasha Levin +--- + .../devicetree/bindings/thermal/loongson,ls2k-thermal.yaml | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml +index b634f57cd011d..9748a479dcd4d 100644 +--- a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml ++++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml +@@ -20,6 +20,7 @@ properties: + - loongson,ls2k1000-thermal + - items: + - enum: ++ - loongson,ls2k0500-thermal + - loongson,ls2k2000-thermal + - const: loongson,ls2k1000-thermal + +-- +2.43.0 + diff --git a/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-fix-incorr.patch b/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-fix-incorr.patch new file mode 100644 index 00000000000..ebd159ae478 --- /dev/null +++ b/queue-6.8/dt-bindings-thermal-loongson-ls2k-thermal-fix-incorr.patch @@ -0,0 +1,83 @@ +From c1bf873ff9819f3c20d15ca5f8f4adb0a57f60d3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 09:59:02 +0800 +Subject: dt-bindings: thermal: loongson,ls2k-thermal: Fix incorrect compatible + definition + +From: Binbin Zhou + +[ Upstream commit c8c4353685778e75e186103411e9d01a4a3f2b90 ] + +The temperature output register of the Loongson-2K2000 is defined in the +chip configuration domain, which is different from the Loongson-2K1000, +so it can't be fallbacked. + +We need to use two groups of registers to describe it: the first group +is the high and low temperature threshold setting register; the second +group is the temperature output register. + +It is true that this fix will cause ABI corruption, but it is necessary +otherwise the Loongson-2K2000 temperature sensor will not work properly. + +Fixes: 72684d99a854 ("thermal: dt-bindings: add loongson-2 thermal") +Cc: Yinbo Zhu +Signed-off-by: Binbin Zhou +Reviewed-by: Krzysztof Kozlowski +Acked-by: Huacai Chen +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/5198999d679f1a1c3457385acb9fadfc85da1f1e.1713837379.git.zhoubinbin@loongson.cn +Signed-off-by: Sasha Levin +--- + .../thermal/loongson,ls2k-thermal.yaml | 23 +++++++++++++++++-- + 1 file changed, 21 insertions(+), 2 deletions(-) + +diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml +index 9748a479dcd4d..ca81c8afba79c 100644 +--- a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml ++++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml +@@ -18,14 +18,15 @@ properties: + oneOf: + - enum: + - loongson,ls2k1000-thermal ++ - loongson,ls2k2000-thermal + - items: + - enum: + - loongson,ls2k0500-thermal +- - loongson,ls2k2000-thermal + - const: loongson,ls2k1000-thermal + + reg: +- maxItems: 1 ++ minItems: 1 ++ maxItems: 2 + + interrupts: + maxItems: 1 +@@ -39,6 +40,24 @@ required: + - interrupts + - '#thermal-sensor-cells' + ++if: ++ properties: ++ compatible: ++ contains: ++ enum: ++ - loongson,ls2k2000-thermal ++ ++then: ++ properties: ++ reg: ++ minItems: 2 ++ maxItems: 2 ++ ++else: ++ properties: ++ reg: ++ maxItems: 1 ++ + unevaluatedProperties: false + + examples: +-- +2.43.0 + diff --git a/queue-6.8/ecryptfs-fix-buffer-size-for-tag-66-packet.patch b/queue-6.8/ecryptfs-fix-buffer-size-for-tag-66-packet.patch new file mode 100644 index 00000000000..992d67921da --- /dev/null +++ b/queue-6.8/ecryptfs-fix-buffer-size-for-tag-66-packet.patch @@ -0,0 +1,116 @@ +From 6b9991e441949914cca36d425d21ab7e3f3a273f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 17 Mar 2024 07:46:00 -0700 +Subject: ecryptfs: Fix buffer size for tag 66 packet + +From: Brian Kubisiak + +[ Upstream commit 85a6a1aff08ec9f5b929d345d066e2830e8818e5 ] + +The 'TAG 66 Packet Format' description is missing the cipher code and +checksum fields that are packed into the message packet. As a result, +the buffer allocated for the packet is 3 bytes too small and +write_tag_66_packet() will write up to 3 bytes past the end of the +buffer. + +Fix this by increasing the size of the allocation so the whole packet +will always fit in the buffer. + +This fixes the below kasan slab-out-of-bounds bug: + + BUG: KASAN: slab-out-of-bounds in ecryptfs_generate_key_packet_set+0x7d6/0xde0 + Write of size 1 at addr ffff88800afbb2a5 by task touch/181 + + CPU: 0 PID: 181 Comm: touch Not tainted 6.6.13-gnu #1 4c9534092be820851bb687b82d1f92a426598dc6 + Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2/GNU Guix 04/01/2014 + Call Trace: + + dump_stack_lvl+0x4c/0x70 + print_report+0xc5/0x610 + ? ecryptfs_generate_key_packet_set+0x7d6/0xde0 + ? kasan_complete_mode_report_info+0x44/0x210 + ? ecryptfs_generate_key_packet_set+0x7d6/0xde0 + kasan_report+0xc2/0x110 + ? ecryptfs_generate_key_packet_set+0x7d6/0xde0 + __asan_store1+0x62/0x80 + ecryptfs_generate_key_packet_set+0x7d6/0xde0 + ? __pfx_ecryptfs_generate_key_packet_set+0x10/0x10 + ? __alloc_pages+0x2e2/0x540 + ? __pfx_ovl_open+0x10/0x10 [overlay 30837f11141636a8e1793533a02e6e2e885dad1d] + ? dentry_open+0x8f/0xd0 + ecryptfs_write_metadata+0x30a/0x550 + ? __pfx_ecryptfs_write_metadata+0x10/0x10 + ? ecryptfs_get_lower_file+0x6b/0x190 + ecryptfs_initialize_file+0x77/0x150 + ecryptfs_create+0x1c2/0x2f0 + path_openat+0x17cf/0x1ba0 + ? __pfx_path_openat+0x10/0x10 + do_filp_open+0x15e/0x290 + ? __pfx_do_filp_open+0x10/0x10 + ? __kasan_check_write+0x18/0x30 + ? _raw_spin_lock+0x86/0xf0 + ? __pfx__raw_spin_lock+0x10/0x10 + ? __kasan_check_write+0x18/0x30 + ? alloc_fd+0xf4/0x330 + do_sys_openat2+0x122/0x160 + ? __pfx_do_sys_openat2+0x10/0x10 + __x64_sys_openat+0xef/0x170 + ? __pfx___x64_sys_openat+0x10/0x10 + do_syscall_64+0x60/0xd0 + entry_SYSCALL_64_after_hwframe+0x6e/0xd8 + RIP: 0033:0x7f00a703fd67 + Code: 25 00 00 41 00 3d 00 00 41 00 74 37 64 8b 04 25 18 00 00 00 85 c0 75 5b 44 89 e2 48 89 ee bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 0f 87 85 00 00 00 48 83 c4 68 5d 41 5c c3 0f 1f + RSP: 002b:00007ffc088e30b0 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 + RAX: ffffffffffffffda RBX: 00007ffc088e3368 RCX: 00007f00a703fd67 + RDX: 0000000000000941 RSI: 00007ffc088e48d7 RDI: 00000000ffffff9c + RBP: 00007ffc088e48d7 R08: 0000000000000001 R09: 0000000000000000 + R10: 00000000000001b6 R11: 0000000000000246 R12: 0000000000000941 + R13: 0000000000000000 R14: 00007ffc088e48d7 R15: 00007f00a7180040 + + + Allocated by task 181: + kasan_save_stack+0x2f/0x60 + kasan_set_track+0x29/0x40 + kasan_save_alloc_info+0x25/0x40 + __kasan_kmalloc+0xc5/0xd0 + __kmalloc+0x66/0x160 + ecryptfs_generate_key_packet_set+0x6d2/0xde0 + ecryptfs_write_metadata+0x30a/0x550 + ecryptfs_initialize_file+0x77/0x150 + ecryptfs_create+0x1c2/0x2f0 + path_openat+0x17cf/0x1ba0 + do_filp_open+0x15e/0x290 + do_sys_openat2+0x122/0x160 + __x64_sys_openat+0xef/0x170 + do_syscall_64+0x60/0xd0 + entry_SYSCALL_64_after_hwframe+0x6e/0xd8 + +Fixes: dddfa461fc89 ("[PATCH] eCryptfs: Public key; packet management") +Signed-off-by: Brian Kubisiak +Link: https://lore.kernel.org/r/5j2q56p6qkhezva6b2yuqfrsurmvrrqtxxzrnp3wqu7xrz22i7@hoecdztoplbl +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/ecryptfs/keystore.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c +index 3fe41964c0d8d..7f9f68c00ef63 100644 +--- a/fs/ecryptfs/keystore.c ++++ b/fs/ecryptfs/keystore.c +@@ -300,9 +300,11 @@ write_tag_66_packet(char *signature, u8 cipher_code, + * | Key Identifier Size | 1 or 2 bytes | + * | Key Identifier | arbitrary | + * | File Encryption Key Size | 1 or 2 bytes | ++ * | Cipher Code | 1 byte | + * | File Encryption Key | arbitrary | ++ * | Checksum | 2 bytes | + */ +- data_len = (5 + ECRYPTFS_SIG_SIZE_HEX + crypt_stat->key_size); ++ data_len = (8 + ECRYPTFS_SIG_SIZE_HEX + crypt_stat->key_size); + *packet = kmalloc(data_len, GFP_KERNEL); + message = *packet; + if (!message) { +-- +2.43.0 + diff --git a/queue-6.8/edac-skx_common-allow-decoding-of-sgx-addresses.patch b/queue-6.8/edac-skx_common-allow-decoding-of-sgx-addresses.patch new file mode 100644 index 00000000000..30fa6ba2547 --- /dev/null +++ b/queue-6.8/edac-skx_common-allow-decoding-of-sgx-addresses.patch @@ -0,0 +1,43 @@ +From 324901ce4456b92255bcde0e0fc1e561ed2d9991 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 20:04:19 +0800 +Subject: EDAC/skx_common: Allow decoding of SGX addresses + +From: Qiuxu Zhuo + +[ Upstream commit e0d335077831196bffe6a634ffe385fc684192ca ] + +There are no "struct page" associations with SGX pages, causing the check +pfn_to_online_page() to fail. This results in the inability to decode the +SGX addresses and warning messages like: + + Invalid address 0x34cc9a98840 in IA32_MC17_ADDR + +Add an additional check to allow the decoding of the error address and to +skip the warning message, if the error address is an SGX address. + +Fixes: 1e92af09fab1 ("EDAC/skx_common: Filter out the invalid address") +Signed-off-by: Qiuxu Zhuo +Signed-off-by: Tony Luck +Link: https://lore.kernel.org/r/20240408120419.50234-1-qiuxu.zhuo@intel.com +Signed-off-by: Sasha Levin +--- + drivers/edac/skx_common.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c +index 9c5b6f8bd8bd5..27996b7924c82 100644 +--- a/drivers/edac/skx_common.c ++++ b/drivers/edac/skx_common.c +@@ -648,7 +648,7 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val, + memset(&res, 0, sizeof(res)); + res.mce = mce; + res.addr = mce->addr & MCI_ADDR_PHYSADDR; +- if (!pfn_to_online_page(res.addr >> PAGE_SHIFT)) { ++ if (!pfn_to_online_page(res.addr >> PAGE_SHIFT) && !arch_is_platform_page(res.addr)) { + pr_err("Invalid address 0x%llx in IA32_MC%d_ADDR\n", mce->addr, mce->bank); + return NOTIFY_DONE; + } +-- +2.43.0 + diff --git a/queue-6.8/edac-versal-do-not-register-for-noc-errors.patch b/queue-6.8/edac-versal-do-not-register-for-noc-errors.patch new file mode 100644 index 00000000000..f796654613a --- /dev/null +++ b/queue-6.8/edac-versal-do-not-register-for-noc-errors.patch @@ -0,0 +1,46 @@ +From 9e0d657d7cc2953f45e720c0e03de7390f07e04f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 17:49:40 +0530 +Subject: EDAC/versal: Do not register for NOC errors + +From: Shubhrajyoti Datta + +[ Upstream commit edbe59428eb0da09958769326a6566d4c9242ae7 ] + +The NOC errors are not handled in the driver. Remove the request for +registration. + +Signed-off-by: Shubhrajyoti Datta +Signed-off-by: Borislav Petkov (AMD) +Link: https://lore.kernel.org/r/20240425121942.26378-2-shubhrajyoti.datta@amd.com +Signed-off-by: Sasha Levin +--- + drivers/edac/versal_edac.c | 5 +---- + 1 file changed, 1 insertion(+), 4 deletions(-) + +diff --git a/drivers/edac/versal_edac.c b/drivers/edac/versal_edac.c +index a840c6922e5b9..4d5b68b6be673 100644 +--- a/drivers/edac/versal_edac.c ++++ b/drivers/edac/versal_edac.c +@@ -1006,8 +1006,7 @@ static int mc_probe(struct platform_device *pdev) + } + + rc = xlnx_register_event(PM_NOTIFY_CB, VERSAL_EVENT_ERROR_PMC_ERR1, +- XPM_EVENT_ERROR_MASK_DDRMC_CR | XPM_EVENT_ERROR_MASK_DDRMC_NCR | +- XPM_EVENT_ERROR_MASK_NOC_CR | XPM_EVENT_ERROR_MASK_NOC_NCR, ++ XPM_EVENT_ERROR_MASK_DDRMC_CR | XPM_EVENT_ERROR_MASK_DDRMC_NCR, + false, err_callback, mci); + if (rc) { + if (rc == -EACCES) +@@ -1044,8 +1043,6 @@ static int mc_remove(struct platform_device *pdev) + + xlnx_unregister_event(PM_NOTIFY_CB, VERSAL_EVENT_ERROR_PMC_ERR1, + XPM_EVENT_ERROR_MASK_DDRMC_CR | +- XPM_EVENT_ERROR_MASK_NOC_CR | +- XPM_EVENT_ERROR_MASK_NOC_NCR | + XPM_EVENT_ERROR_MASK_DDRMC_NCR, err_callback, mci); + edac_mc_del_mc(&pdev->dev); + edac_mc_free(mci); +-- +2.43.0 + diff --git a/queue-6.8/enetc-avoid-truncating-error-message.patch b/queue-6.8/enetc-avoid-truncating-error-message.patch new file mode 100644 index 00000000000..7d03b9e8637 --- /dev/null +++ b/queue-6.8/enetc-avoid-truncating-error-message.patch @@ -0,0 +1,41 @@ +From 894360a18dd53f34c4ede9d05b28e73109cb1f87 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 23:38:01 +0100 +Subject: enetc: avoid truncating error message + +From: Arnd Bergmann + +[ Upstream commit 9046d581ed586f3c715357638ca12c0e84402002 ] + +As clang points out, the error message in enetc_setup_xdp_prog() +still does not fit in the buffer and will be truncated: + +drivers/net/ethernet/freescale/enetc/enetc.c:2771:3: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 87 [-Werror,-Wformat-truncation] + +Replace it with an even shorter message that should fit. + +Fixes: f968c56417f0 ("net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN") +Signed-off-by: Arnd Bergmann +Link: https://lore.kernel.org/r/20240326223825.4084412-3-arnd@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c +index bfdbdab443ae0..5e6e1f7196f87 100644 +--- a/drivers/net/ethernet/freescale/enetc/enetc.c ++++ b/drivers/net/ethernet/freescale/enetc/enetc.c +@@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog, + if (priv->min_num_stack_tx_queues + num_xdp_tx_queues > + priv->num_tx_rings) { + NL_SET_ERR_MSG_FMT_MOD(extack, +- "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)", ++ "Reserving %d XDP TXQs leaves under %d for stack (total %d)", + num_xdp_tx_queues, + priv->min_num_stack_tx_queues, + priv->num_tx_rings); +-- +2.43.0 + diff --git a/queue-6.8/epoll-be-better-about-file-lifetimes.patch b/queue-6.8/epoll-be-better-about-file-lifetimes.patch new file mode 100644 index 00000000000..fe32e3be6fe --- /dev/null +++ b/queue-6.8/epoll-be-better-about-file-lifetimes.patch @@ -0,0 +1,94 @@ +From 0385671ecc332810d1bd350ed1a28a1c3ff1b12a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 3 May 2024 13:36:09 -0700 +Subject: epoll: be better about file lifetimes + +From: Linus Torvalds + +[ Upstream commit 4efaa5acf0a1d2b5947f98abb3acf8bfd966422b ] + +epoll can call out to vfs_poll() with a file pointer that may race with +the last 'fput()'. That would make f_count go down to zero, and while +the ep->mtx locking means that the resulting file pointer tear-down will +be blocked until the poll returns, it means that f_count is already +dead, and any use of it won't actually get a reference to the file any +more: it's dead regardless. + +Make sure we have a valid ref on the file pointer before we call down to +vfs_poll() from the epoll routines. + +Link: https://lore.kernel.org/lkml/0000000000002d631f0615918f1e@google.com/ +Reported-by: syzbot+045b454ab35fd82a35fb@syzkaller.appspotmail.com +Reviewed-by: Jens Axboe +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + fs/eventpoll.c | 38 +++++++++++++++++++++++++++++++++++++- + 1 file changed, 37 insertions(+), 1 deletion(-) + +diff --git a/fs/eventpoll.c b/fs/eventpoll.c +index 3534d36a14740..c5a9a483fb538 100644 +--- a/fs/eventpoll.c ++++ b/fs/eventpoll.c +@@ -875,6 +875,34 @@ static __poll_t __ep_eventpoll_poll(struct file *file, poll_table *wait, int dep + return res; + } + ++/* ++ * The ffd.file pointer may be in the process of being torn down due to ++ * being closed, but we may not have finished eventpoll_release() yet. ++ * ++ * Normally, even with the atomic_long_inc_not_zero, the file may have ++ * been free'd and then gotten re-allocated to something else (since ++ * files are not RCU-delayed, they are SLAB_TYPESAFE_BY_RCU). ++ * ++ * But for epoll, users hold the ep->mtx mutex, and as such any file in ++ * the process of being free'd will block in eventpoll_release_file() ++ * and thus the underlying file allocation will not be free'd, and the ++ * file re-use cannot happen. ++ * ++ * For the same reason we can avoid a rcu_read_lock() around the ++ * operation - 'ffd.file' cannot go away even if the refcount has ++ * reached zero (but we must still not call out to ->poll() functions ++ * etc). ++ */ ++static struct file *epi_fget(const struct epitem *epi) ++{ ++ struct file *file; ++ ++ file = epi->ffd.file; ++ if (!atomic_long_inc_not_zero(&file->f_count)) ++ file = NULL; ++ return file; ++} ++ + /* + * Differs from ep_eventpoll_poll() in that internal callers already have + * the ep->mtx so we need to start from depth=1, such that mutex_lock_nested() +@@ -883,14 +911,22 @@ static __poll_t __ep_eventpoll_poll(struct file *file, poll_table *wait, int dep + static __poll_t ep_item_poll(const struct epitem *epi, poll_table *pt, + int depth) + { +- struct file *file = epi->ffd.file; ++ struct file *file = epi_fget(epi); + __poll_t res; + ++ /* ++ * We could return EPOLLERR | EPOLLHUP or something, but let's ++ * treat this more as "file doesn't exist, poll didn't happen". ++ */ ++ if (!file) ++ return 0; ++ + pt->_key = epi->event.events; + if (!is_file_epoll(file)) + res = vfs_poll(file, pt); + else + res = __ep_eventpoll_poll(file, pt, depth); ++ fput(file); + return res & epi->event.events; + } + +-- +2.43.0 + diff --git a/queue-6.8/eth-sungem-remove-.ndo_poll_controller-to-avoid-dead.patch b/queue-6.8/eth-sungem-remove-.ndo_poll_controller-to-avoid-dead.patch new file mode 100644 index 00000000000..589277af1a0 --- /dev/null +++ b/queue-6.8/eth-sungem-remove-.ndo_poll_controller-to-avoid-dead.patch @@ -0,0 +1,67 @@ +From e8c57ebea8f2e962019888177b32653537debee1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 06:45:04 -0700 +Subject: eth: sungem: remove .ndo_poll_controller to avoid deadlocks + +From: Jakub Kicinski + +[ Upstream commit ac0a230f719b02432d8c7eba7615ebd691da86f4 ] + +Erhard reports netpoll warnings from sungem: + + netpoll_send_skb_on_dev(): eth0 enabled interrupts in poll (gem_start_xmit+0x0/0x398) + WARNING: CPU: 1 PID: 1 at net/core/netpoll.c:370 netpoll_send_skb+0x1fc/0x20c + +gem_poll_controller() disables interrupts, which may sleep. +We can't sleep in netpoll, it has interrupts disabled completely. +Strangely, gem_poll_controller() doesn't even poll the completions, +and instead acts as if an interrupt has fired so it just schedules +NAPI and exits. None of this has been necessary for years, since +netpoll invokes NAPI directly. + +Fixes: fe09bb619096 ("sungem: Spring cleaning and GRO support") +Reported-and-tested-by: Erhard Furtner +Link: https://lore.kernel.org/all/20240428125306.2c3080ef@legion +Reviewed-by: Eric Dumazet +Link: https://lore.kernel.org/r/20240508134504.3560956-1-kuba@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/sun/sungem.c | 14 -------------- + 1 file changed, 14 deletions(-) + +diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c +index 9bd1df8308d24..d3a2fbb14140e 100644 +--- a/drivers/net/ethernet/sun/sungem.c ++++ b/drivers/net/ethernet/sun/sungem.c +@@ -949,17 +949,6 @@ static irqreturn_t gem_interrupt(int irq, void *dev_id) + return IRQ_HANDLED; + } + +-#ifdef CONFIG_NET_POLL_CONTROLLER +-static void gem_poll_controller(struct net_device *dev) +-{ +- struct gem *gp = netdev_priv(dev); +- +- disable_irq(gp->pdev->irq); +- gem_interrupt(gp->pdev->irq, dev); +- enable_irq(gp->pdev->irq); +-} +-#endif +- + static void gem_tx_timeout(struct net_device *dev, unsigned int txqueue) + { + struct gem *gp = netdev_priv(dev); +@@ -2839,9 +2828,6 @@ static const struct net_device_ops gem_netdev_ops = { + .ndo_change_mtu = gem_change_mtu, + .ndo_validate_addr = eth_validate_addr, + .ndo_set_mac_address = gem_set_mac_address, +-#ifdef CONFIG_NET_POLL_CONTROLLER +- .ndo_poll_controller = gem_poll_controller, +-#endif + }; + + static int gem_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) +-- +2.43.0 + diff --git a/queue-6.8/ext4-avoid-excessive-credit-estimate-in-ext4_tmpfile.patch b/queue-6.8/ext4-avoid-excessive-credit-estimate-in-ext4_tmpfile.patch new file mode 100644 index 00000000000..5f090caa8ad --- /dev/null +++ b/queue-6.8/ext4-avoid-excessive-credit-estimate-in-ext4_tmpfile.patch @@ -0,0 +1,52 @@ +From 0adbf257de967be6e246391c8097a5fb30f089e8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 12:53:20 +0100 +Subject: ext4: avoid excessive credit estimate in ext4_tmpfile() + +From: Jan Kara + +[ Upstream commit 35a1f12f0ca857fee1d7a04ef52cbd5f1f84de13 ] + +A user with minimum journal size (1024 blocks these days) complained +about the following error triggered by generic/697 test in +ext4_tmpfile(): + +run fstests generic/697 at 2024-02-28 05:34:46 +JBD2: vfstest wants too many credits credits:260 rsv_credits:0 max:256 +EXT4-fs error (device loop0) in __ext4_new_inode:1083: error 28 + +Indeed the credit estimate in ext4_tmpfile() is huge. +EXT4_MAXQUOTAS_INIT_BLOCKS() is 219, then 10 credits from ext4_tmpfile() +itself and then ext4_xattr_credits_for_new_inode() adds more credits +needed for security attributes and ACLs. Now the +EXT4_MAXQUOTAS_INIT_BLOCKS() is in fact unnecessary because we've +already initialized quotas with dquot_init() shortly before and so +EXT4_MAXQUOTAS_TRANS_BLOCKS() is enough (which boils down to 3 credits). + +Fixes: af51a2ac36d1 ("ext4: ->tmpfile() support") +Signed-off-by: Jan Kara +Tested-by: Luis Henriques +Tested-by: Disha Goel +Link: https://lore.kernel.org/r/20240307115320.28949-1-jack@suse.cz +Signed-off-by: Theodore Ts'o +Signed-off-by: Sasha Levin +--- + fs/ext4/namei.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c +index 05b647e6bc195..58fee3c6febcb 100644 +--- a/fs/ext4/namei.c ++++ b/fs/ext4/namei.c +@@ -2898,7 +2898,7 @@ static int ext4_tmpfile(struct mnt_idmap *idmap, struct inode *dir, + inode = ext4_new_inode_start_handle(idmap, dir, mode, + NULL, 0, NULL, + EXT4_HT_DIR, +- EXT4_MAXQUOTAS_INIT_BLOCKS(dir->i_sb) + ++ EXT4_MAXQUOTAS_TRANS_BLOCKS(dir->i_sb) + + 4 + EXT4_XATTR_TRANS_BLOCKS); + handle = ext4_journal_current_handle(); + err = PTR_ERR(inode); +-- +2.43.0 + diff --git a/queue-6.8/ext4-fix-potential-unnitialized-variable.patch b/queue-6.8/ext4-fix-potential-unnitialized-variable.patch new file mode 100644 index 00000000000..65a96934b95 --- /dev/null +++ b/queue-6.8/ext4-fix-potential-unnitialized-variable.patch @@ -0,0 +1,40 @@ +From 51d09bf513c65d48702e53905b680d0e13883462 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 17 Apr 2024 21:10:40 +0300 +Subject: ext4: fix potential unnitialized variable + +From: Dan Carpenter + +[ Upstream commit 3f4830abd236d0428e50451e1ecb62e14c365e9b ] + +Smatch complains "err" can be uninitialized in the caller. + + fs/ext4/indirect.c:349 ext4_alloc_branch() + error: uninitialized symbol 'err'. + +Set the error to zero on the success path. + +Fixes: 8016e29f4362 ("ext4: fast commit recovery path") +Signed-off-by: Dan Carpenter +Link: https://lore.kernel.org/r/363a4673-0fb8-4adf-b4fb-90a499077276@moroto.mountain +Signed-off-by: Theodore Ts'o +Signed-off-by: Sasha Levin +--- + fs/ext4/mballoc.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c +index cf407425d0f30..00b0839b534da 100644 +--- a/fs/ext4/mballoc.c ++++ b/fs/ext4/mballoc.c +@@ -6119,6 +6119,7 @@ ext4_mb_new_blocks_simple(struct ext4_allocation_request *ar, int *errp) + ext4_mb_mark_bb(sb, block, 1, true); + ar->len = 1; + ++ *errp = 0; + return block; + } + +-- +2.43.0 + diff --git a/queue-6.8/ext4-remove-the-redundant-folio_wait_stable.patch b/queue-6.8/ext4-remove-the-redundant-folio_wait_stable.patch new file mode 100644 index 00000000000..2d0cd1a375e --- /dev/null +++ b/queue-6.8/ext4-remove-the-redundant-folio_wait_stable.patch @@ -0,0 +1,42 @@ +From b965dfdcacf0d42c357301adb12c62012f6072d7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 10:30:05 +0800 +Subject: ext4: remove the redundant folio_wait_stable() + +From: Zhang Yi + +[ Upstream commit df0b5afc62f3368d657a8fe4a8d393ac481474c2 ] + +__filemap_get_folio() with FGP_WRITEBEGIN parameter has already wait +for stable folio, so remove the redundant folio_wait_stable() in +ext4_da_write_begin(), it was left over from the commit cc883236b792 +("ext4: drop unnecessary journal handle in delalloc write") that +removed the retry getting page logic. + +Fixes: cc883236b792 ("ext4: drop unnecessary journal handle in delalloc write") +Signed-off-by: Zhang Yi +Reviewed-by: Jan Kara +Link: https://lore.kernel.org/r/20240419023005.2719050-1-yi.zhang@huaweicloud.com +Signed-off-by: Theodore Ts'o +Signed-off-by: Sasha Levin +--- + fs/ext4/inode.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c +index 2ccf3b5e3a7c4..31604907af50e 100644 +--- a/fs/ext4/inode.c ++++ b/fs/ext4/inode.c +@@ -2887,9 +2887,6 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping, + if (IS_ERR(folio)) + return PTR_ERR(folio); + +- /* In case writeback began while the folio was unlocked */ +- folio_wait_stable(folio); +- + #ifdef CONFIG_FS_ENCRYPTION + ret = ext4_block_write_begin(folio, pos, len, ext4_da_get_block_prep); + #else +-- +2.43.0 + diff --git a/queue-6.8/fbdev-sh7760fb-allow-modular-build.patch b/queue-6.8/fbdev-sh7760fb-allow-modular-build.patch new file mode 100644 index 00000000000..943a08f9ae3 --- /dev/null +++ b/queue-6.8/fbdev-sh7760fb-allow-modular-build.patch @@ -0,0 +1,50 @@ +From 9a4e137345e24d6961e72ce394faec1af1c61647 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 9 Feb 2024 21:39:38 -0800 +Subject: fbdev: sh7760fb: allow modular build + +From: Randy Dunlap + +[ Upstream commit 51084f89d687e14d96278241e5200cde4b0985c7 ] + +There is no reason to prohibit sh7760fb from being built as a +loadable module as suggested by Geert, so change the config symbol +from bool to tristate to allow that and change the FB dependency as +needed. + +Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") +Suggested-by: Geert Uytterhoeven +Signed-off-by: Randy Dunlap +Cc: Thomas Zimmermann +Cc: Javier Martinez Canillas +Cc: John Paul Adrian Glaubitz +Cc: Sam Ravnborg +Cc: Helge Deller +Cc: linux-fbdev@vger.kernel.org +Cc: dri-devel@lists.freedesktop.org +Acked-by: John Paul Adrian Glaubitz +Acked-by: Javier Martinez Canillas +Signed-off-by: Helge Deller +Signed-off-by: Sasha Levin +--- + drivers/video/fbdev/Kconfig | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig +index ba4ab33f6094b..411bf2b2c4d03 100644 +--- a/drivers/video/fbdev/Kconfig ++++ b/drivers/video/fbdev/Kconfig +@@ -1680,8 +1680,8 @@ config FB_COBALT + select FB_IOMEM_HELPERS + + config FB_SH7760 +- bool "SH7760/SH7763/SH7720/SH7721 LCDC support" +- depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ ++ tristate "SH7760/SH7763/SH7720/SH7721 LCDC support" ++ depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ + || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) + select FB_IOMEM_HELPERS + help +-- +2.43.0 + diff --git a/queue-6.8/fbdev-shmobile-fix-snprintf-truncation.patch b/queue-6.8/fbdev-shmobile-fix-snprintf-truncation.patch new file mode 100644 index 00000000000..a932dbb9ceb --- /dev/null +++ b/queue-6.8/fbdev-shmobile-fix-snprintf-truncation.patch @@ -0,0 +1,40 @@ +From 6904fe8f2031859eb98c4519dbb39be6f3a9301b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 23:38:00 +0100 +Subject: fbdev: shmobile: fix snprintf truncation + +From: Arnd Bergmann + +[ Upstream commit 26c8cfb9d1e4b252336d23dd5127a8cbed414a32 ] + +The name of the overlay does not fit into the fixed-length field: + +drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 + +Make it short enough by changing the string. + +Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") +Signed-off-by: Arnd Bergmann +Reviewed-by: Laurent Pinchart +Signed-off-by: Helge Deller +Signed-off-by: Sasha Levin +--- + drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c +index eb2297b37504c..d35d2cf999988 100644 +--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c ++++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c +@@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) + */ + info->fix = sh_mobile_lcdc_overlay_fix; + snprintf(info->fix.id, sizeof(info->fix.id), +- "SH Mobile LCDC Overlay %u", ovl->index); ++ "SHMobile ovl %u", ovl->index); + info->fix.smem_start = ovl->dma_handle; + info->fix.smem_len = ovl->fb_size; + info->fix.line_length = ovl->pitch; +-- +2.43.0 + diff --git a/queue-6.8/fbdev-sisfb-hide-unused-variables.patch b/queue-6.8/fbdev-sisfb-hide-unused-variables.patch new file mode 100644 index 00000000000..66c42e79a32 --- /dev/null +++ b/queue-6.8/fbdev-sisfb-hide-unused-variables.patch @@ -0,0 +1,68 @@ +From 7bf7f8f14f5185e2755011784c5224864fc064bf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 10:06:31 +0200 +Subject: fbdev: sisfb: hide unused variables + +From: Arnd Bergmann + +[ Upstream commit 688cf598665851b9e8cb5083ff1d208ce43d10ff ] + +Building with W=1 shows that a couple of variables in this driver are only +used in certain configurations: + +drivers/video/fbdev/sis/init301.c:239:28: error: 'SiS_Part2CLVX_6' defined but not used [-Werror=unused-const-variable=] + 239 | static const unsigned char SiS_Part2CLVX_6[] = { /* 1080i */ + | ^~~~~~~~~~~~~~~ +drivers/video/fbdev/sis/init301.c:230:28: error: 'SiS_Part2CLVX_5' defined but not used [-Werror=unused-const-variable=] + 230 | static const unsigned char SiS_Part2CLVX_5[] = { /* 750p */ + | ^~~~~~~~~~~~~~~ +drivers/video/fbdev/sis/init301.c:211:28: error: 'SiS_Part2CLVX_4' defined but not used [-Werror=unused-const-variable=] + 211 | static const unsigned char SiS_Part2CLVX_4[] = { /* PAL */ + | ^~~~~~~~~~~~~~~ +drivers/video/fbdev/sis/init301.c:192:28: error: 'SiS_Part2CLVX_3' defined but not used [-Werror=unused-const-variable=] + 192 | static const unsigned char SiS_Part2CLVX_3[] = { /* NTSC, 525i, 525p */ + | ^~~~~~~~~~~~~~~ +drivers/video/fbdev/sis/init301.c:184:28: error: 'SiS_Part2CLVX_2' defined but not used [-Werror=unused-const-variable=] + 184 | static const unsigned char SiS_Part2CLVX_2[] = { + | ^~~~~~~~~~~~~~~ +drivers/video/fbdev/sis/init301.c:176:28: error: 'SiS_Part2CLVX_1' defined but not used [-Werror=unused-const-variable=] + 176 | static const unsigned char SiS_Part2CLVX_1[] = { + | ^~~~~~~~~~~~~~~ + +This started showing up after the definitions were moved into the +source file from the header, which was not flagged by the compiler. +Move the definition into the appropriate #ifdef block that already +exists next to them. + +Fixes: 5908986ef348 ("video: fbdev: sis: avoid mismatched prototypes") +Signed-off-by: Arnd Bergmann +Signed-off-by: Helge Deller +Signed-off-by: Sasha Levin +--- + drivers/video/fbdev/sis/init301.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c +index a8fb41f1a2580..09329072004f4 100644 +--- a/drivers/video/fbdev/sis/init301.c ++++ b/drivers/video/fbdev/sis/init301.c +@@ -172,7 +172,7 @@ static const unsigned char SiS_HiTVGroup3_2[] = { + }; + + /* 301C / 302ELV extended Part2 TV registers (4 tap scaler) */ +- ++#ifdef CONFIG_FB_SIS_315 + static const unsigned char SiS_Part2CLVX_1[] = { + 0x00,0x00, + 0x00,0x20,0x00,0x00,0x7F,0x20,0x02,0x7F,0x7D,0x20,0x04,0x7F,0x7D,0x1F,0x06,0x7E, +@@ -245,7 +245,6 @@ static const unsigned char SiS_Part2CLVX_6[] = { /* 1080i */ + 0xFF,0xFF, + }; + +-#ifdef CONFIG_FB_SIS_315 + /* 661 et al LCD data structure (2.03.00) */ + static const unsigned char SiS_LCDStruct661[] = { + /* 1024x768 */ +-- +2.43.0 + diff --git a/queue-6.8/firmware-qcom-qcm-fix-unused-qcom_scm_qseecom_allowl.patch b/queue-6.8/firmware-qcom-qcm-fix-unused-qcom_scm_qseecom_allowl.patch new file mode 100644 index 00000000000..5463d5f5a7e --- /dev/null +++ b/queue-6.8/firmware-qcom-qcm-fix-unused-qcom_scm_qseecom_allowl.patch @@ -0,0 +1,44 @@ +From 2a79f95324cbb02ace0321bdb841cb7f73ed6f7a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 20 Nov 2023 19:56:23 +0100 +Subject: firmware: qcom: qcm: fix unused qcom_scm_qseecom_allowlist +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Krzysztof Kozlowski + +[ Upstream commit e478c5fb6aa10af7b7edbff69bc8aef6fbb5f0ed ] + +For !OF builds, the qcom_scm_qseecom_allowlist is unused: + + drivers/firmware/qcom/qcom_scm.c:1652:34: error: ‘qcom_scm_qseecom_allowlist’ defined but not used [-Werror=unused-const-variable=] + +Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface") +Reported-by: kernel test robot +Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/ +Signed-off-by: Krzysztof Kozlowski +Acked-by: Maximilian Luz +Link: https://lore.kernel.org/r/20231120185623.338608-1-krzysztof.kozlowski@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/firmware/qcom/qcom_scm.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c +index 90283f160a228..ca381cb2ee979 100644 +--- a/drivers/firmware/qcom/qcom_scm.c ++++ b/drivers/firmware/qcom/qcom_scm.c +@@ -1624,7 +1624,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); + * We do not yet support re-entrant calls via the qseecom interface. To prevent + + any potential issues with this, only allow validated machines for now. + */ +-static const struct of_device_id qcom_scm_qseecom_allowlist[] = { ++static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { + { .compatible = "lenovo,thinkpad-x13s", }, + { } + }; +-- +2.43.0 + diff --git a/queue-6.8/firmware-qcom-scm-fix-__scm-and-waitq-completion-var.patch b/queue-6.8/firmware-qcom-scm-fix-__scm-and-waitq-completion-var.patch new file mode 100644 index 00000000000..28974702b4d --- /dev/null +++ b/queue-6.8/firmware-qcom-scm-fix-__scm-and-waitq-completion-var.patch @@ -0,0 +1,70 @@ +From 596adfcab831efdc233df811dc4c46f609944c84 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 21 Mar 2024 20:54:02 +0530 +Subject: firmware: qcom: scm: Fix __scm and waitq completion variable + initialization + +From: Mukesh Ojha + +[ Upstream commit 2e4955167ec5c04534cebea9e8273a907e7a75e1 ] + +It is possible qcom_scm_is_available() gives wrong indication that +if __scm is initialized while __scm->dev is not and similar issue +is also possible with __scm->waitq_comp. + +Fix this appropriately by the use of release barrier and read barrier +that will make sure if __scm is initialized so, is all of its field +variable. + +Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver") +Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") +Signed-off-by: Mukesh Ojha +Link: https://lore.kernel.org/r/1711034642-22860-4-git-send-email-quic_mojha@quicinc.com +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/firmware/qcom/qcom_scm.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c +index ca381cb2ee979..29c24578ad2bf 100644 +--- a/drivers/firmware/qcom/qcom_scm.c ++++ b/drivers/firmware/qcom/qcom_scm.c +@@ -1713,7 +1713,7 @@ static int qcom_scm_qseecom_init(struct qcom_scm *scm) + */ + bool qcom_scm_is_available(void) + { +- return !!__scm; ++ return !!READ_ONCE(__scm); + } + EXPORT_SYMBOL_GPL(qcom_scm_is_available); + +@@ -1794,10 +1794,12 @@ static int qcom_scm_probe(struct platform_device *pdev) + if (!scm) + return -ENOMEM; + ++ scm->dev = &pdev->dev; + ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); + if (ret < 0) + return ret; + ++ init_completion(&scm->waitq_comp); + mutex_init(&scm->scm_bw_lock); + + scm->path = devm_of_icc_get(&pdev->dev, NULL); +@@ -1829,10 +1831,8 @@ static int qcom_scm_probe(struct platform_device *pdev) + if (ret) + return ret; + +- __scm = scm; +- __scm->dev = &pdev->dev; +- +- init_completion(&__scm->waitq_comp); ++ /* Let all above stores be available after this */ ++ smp_store_release(&__scm, scm); + + irq = platform_get_irq_optional(pdev, 0); + if (irq < 0) { +-- +2.43.0 + diff --git a/queue-6.8/firmware-raspberrypi-use-correct-device-for-dma-mapp.patch b/queue-6.8/firmware-raspberrypi-use-correct-device-for-dma-mapp.patch new file mode 100644 index 00000000000..0c0ed36427c --- /dev/null +++ b/queue-6.8/firmware-raspberrypi-use-correct-device-for-dma-mapp.patch @@ -0,0 +1,65 @@ +From 5d631df7c92b0948f2ca05715a8f0ed5b1fc8f6a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 21:58:06 +0200 +Subject: firmware: raspberrypi: Use correct device for DMA mappings + +From: Laurent Pinchart + +[ Upstream commit df518a0ae1b982a4dcf2235464016c0c4576a34d ] + +The buffer used to transfer data over the mailbox interface is mapped +using the client's device. This is incorrect, as the device performing +the DMA transfer is the mailbox itself. Fix it by using the mailbox +controller device instead. + +This requires including the mailbox_controller.h header to dereference +the mbox_chan and mbox_controller structures. The header is not meant to +be included by clients. This could be fixed by extending the client API +with a function to access the controller's device. + +Fixes: 4e3d60656a72 ("ARM: bcm2835: Add the Raspberry Pi firmware driver") +Signed-off-by: Laurent Pinchart +Reviewed-by: Stefan Wahren +Tested-by: Ivan T. Ivanov +Link: https://lore.kernel.org/r/20240326195807.15163-3-laurent.pinchart@ideasonboard.com +Signed-off-by: Florian Fainelli +Signed-off-by: Sasha Levin +--- + drivers/firmware/raspberrypi.c | 7 ++++--- + 1 file changed, 4 insertions(+), 3 deletions(-) + +diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c +index 322aada20f742..ac34876a97f8b 100644 +--- a/drivers/firmware/raspberrypi.c ++++ b/drivers/firmware/raspberrypi.c +@@ -9,6 +9,7 @@ + #include + #include + #include ++#include + #include + #include + #include +@@ -97,8 +98,8 @@ int rpi_firmware_property_list(struct rpi_firmware *fw, + if (size & 3) + return -EINVAL; + +- buf = dma_alloc_coherent(fw->cl.dev, PAGE_ALIGN(size), &bus_addr, +- GFP_ATOMIC); ++ buf = dma_alloc_coherent(fw->chan->mbox->dev, PAGE_ALIGN(size), ++ &bus_addr, GFP_ATOMIC); + if (!buf) + return -ENOMEM; + +@@ -126,7 +127,7 @@ int rpi_firmware_property_list(struct rpi_firmware *fw, + ret = -EINVAL; + } + +- dma_free_coherent(fw->cl.dev, PAGE_ALIGN(size), buf, bus_addr); ++ dma_free_coherent(fw->chan->mbox->dev, PAGE_ALIGN(size), buf, bus_addr); + + return ret; + } +-- +2.43.0 + diff --git a/queue-6.8/fpga-dfl-pci-add-pci-subdevice-id-for-intel-d5005-ca.patch b/queue-6.8/fpga-dfl-pci-add-pci-subdevice-id-for-intel-d5005-ca.patch new file mode 100644 index 00000000000..6b5fe539d15 --- /dev/null +++ b/queue-6.8/fpga-dfl-pci-add-pci-subdevice-id-for-intel-d5005-ca.patch @@ -0,0 +1,51 @@ +From 0cc27a08299773854565af5dd00ec63a9ed90158 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 19:02:57 -0400 +Subject: fpga: dfl-pci: add PCI subdevice ID for Intel D5005 card + +From: Peter Colberg + +[ Upstream commit bb1dbeceb1c20cfd81271e1bd69892ebd1ee38e0 ] + +Add PCI subdevice ID for the Intel D5005 Stratix 10 FPGA card as +used with the Open FPGA Stack (OFS) FPGA Interface Manager (FIM). + +Unlike the Intel D5005 PAC FIM which exposed a separate PCI device ID, +the OFS FIM reuses the same device ID for all DFL-based FPGA cards +and differentiates on the subdevice ID. The subdevice ID values were +chosen as the numeric part of the FPGA card names in hexadecimal. + +Signed-off-by: Peter Colberg +Reviewed-by: Matthew Gerlach +Acked-by: Xu Yilun +Link: https://lore.kernel.org/r/20240422230257.1959-1-peter.colberg@intel.com +Signed-off-by: Xu Yilun +Signed-off-by: Sasha Levin +--- + drivers/fpga/dfl-pci.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c +index 98b8fd16183e4..80cac3a5f9767 100644 +--- a/drivers/fpga/dfl-pci.c ++++ b/drivers/fpga/dfl-pci.c +@@ -78,6 +78,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev) + #define PCIE_DEVICE_ID_SILICOM_PAC_N5011 0x1001 + #define PCIE_DEVICE_ID_INTEL_DFL 0xbcce + /* PCI Subdevice ID for PCIE_DEVICE_ID_INTEL_DFL */ ++#define PCIE_SUBDEVICE_ID_INTEL_D5005 0x138d + #define PCIE_SUBDEVICE_ID_INTEL_N6000 0x1770 + #define PCIE_SUBDEVICE_ID_INTEL_N6001 0x1771 + #define PCIE_SUBDEVICE_ID_INTEL_C6100 0x17d4 +@@ -101,6 +102,8 @@ static struct pci_device_id cci_pcie_id_tbl[] = { + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_PAC_D5005_VF),}, + {PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK, PCIE_DEVICE_ID_SILICOM_PAC_N5010),}, + {PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK, PCIE_DEVICE_ID_SILICOM_PAC_N5011),}, ++ {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL, ++ PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_D5005),}, + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL, + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_N6000),}, + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL_VF, +-- +2.43.0 + diff --git a/queue-6.8/gfs2-do_xmote-fixes.patch b/queue-6.8/gfs2-do_xmote-fixes.patch new file mode 100644 index 00000000000..c3491320123 --- /dev/null +++ b/queue-6.8/gfs2-do_xmote-fixes.patch @@ -0,0 +1,128 @@ +From 6fd5de79a753fa5794590382098d375dedee6947 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 11:23:04 +0200 +Subject: gfs2: do_xmote fixes + +From: Andreas Gruenbacher + +[ Upstream commit 9947a06d29c0a30da88cdc6376ca5fd87083e130 ] + +Function do_xmote() is called with the glock spinlock held. Commit +86934198eefa added a 'goto skip_inval' statement at the beginning of the +function to further below where the glock spinlock is expected not to be +held anymore. Then it added code there that requires the glock spinlock +to be held. This doesn't make sense; fix this up by dropping and +retaking the spinlock where needed. + +In addition, when ->lm_lock() returned an error, do_xmote() didn't fail +the locking operation, and simply left the glock hanging; fix that as +well. (This is a much older error.) + +Fixes: 86934198eefa ("gfs2: Clear flags when withdraw prevents xmote") +Signed-off-by: Andreas Gruenbacher +Signed-off-by: Sasha Levin +--- + fs/gfs2/glock.c | 44 +++++++++++++++++++++++++------------------- + 1 file changed, 25 insertions(+), 19 deletions(-) + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index 0c719fcd4fbc5..2507fe34cbdf0 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -713,6 +713,7 @@ __acquires(&gl->gl_lockref.lock) + { + const struct gfs2_glock_operations *glops = gl->gl_ops; + struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; ++ struct lm_lockstruct *ls = &sdp->sd_lockstruct; + unsigned int lck_flags = (unsigned int)(gh ? gh->gh_flags : 0); + int ret; + +@@ -741,6 +742,9 @@ __acquires(&gl->gl_lockref.lock) + (gl->gl_state == LM_ST_EXCLUSIVE) || + (lck_flags & (LM_FLAG_TRY|LM_FLAG_TRY_1CB))) + clear_bit(GLF_BLOCKING, &gl->gl_flags); ++ if (!glops->go_inval && !glops->go_sync) ++ goto skip_inval; ++ + spin_unlock(&gl->gl_lockref.lock); + if (glops->go_sync) { + ret = glops->go_sync(gl); +@@ -753,6 +757,7 @@ __acquires(&gl->gl_lockref.lock) + fs_err(sdp, "Error %d syncing glock \n", ret); + gfs2_dump_glock(NULL, gl, true); + } ++ spin_lock(&gl->gl_lockref.lock); + goto skip_inval; + } + } +@@ -773,9 +778,10 @@ __acquires(&gl->gl_lockref.lock) + glops->go_inval(gl, target == LM_ST_DEFERRED ? 0 : DIO_METADATA); + clear_bit(GLF_INVALIDATE_IN_PROGRESS, &gl->gl_flags); + } ++ spin_lock(&gl->gl_lockref.lock); + + skip_inval: +- gfs2_glock_hold(gl); ++ gl->gl_lockref.count++; + /* + * Check for an error encountered since we called go_sync and go_inval. + * If so, we can't withdraw from the glock code because the withdraw +@@ -817,37 +823,37 @@ __acquires(&gl->gl_lockref.lock) + */ + clear_bit(GLF_LOCK, &gl->gl_flags); + clear_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags); +- gfs2_glock_queue_work(gl, GL_GLOCK_DFT_HOLD); +- goto out; ++ __gfs2_glock_queue_work(gl, GL_GLOCK_DFT_HOLD); ++ return; + } else { + clear_bit(GLF_INVALIDATE_IN_PROGRESS, &gl->gl_flags); + } + } + +- if (sdp->sd_lockstruct.ls_ops->lm_lock) { +- struct lm_lockstruct *ls = &sdp->sd_lockstruct; ++ if (ls->ls_ops->lm_lock) { ++ spin_unlock(&gl->gl_lockref.lock); ++ ret = ls->ls_ops->lm_lock(gl, target, lck_flags); ++ spin_lock(&gl->gl_lockref.lock); + +- /* lock_dlm */ +- ret = sdp->sd_lockstruct.ls_ops->lm_lock(gl, target, lck_flags); + if (ret == -EINVAL && gl->gl_target == LM_ST_UNLOCKED && + target == LM_ST_UNLOCKED && + test_bit(DFL_UNMOUNT, &ls->ls_recover_flags)) { +- spin_lock(&gl->gl_lockref.lock); +- finish_xmote(gl, target); +- __gfs2_glock_queue_work(gl, 0); +- spin_unlock(&gl->gl_lockref.lock); ++ /* ++ * The lockspace has been released and the lock has ++ * been unlocked implicitly. ++ */ + } else if (ret) { + fs_err(sdp, "lm_lock ret %d\n", ret); +- GLOCK_BUG_ON(gl, !gfs2_withdrawing_or_withdrawn(sdp)); ++ target = gl->gl_state | LM_OUT_ERROR; ++ } else { ++ /* The operation will be completed asynchronously. */ ++ return; + } +- } else { /* lock_nolock */ +- spin_lock(&gl->gl_lockref.lock); +- finish_xmote(gl, target); +- __gfs2_glock_queue_work(gl, 0); +- spin_unlock(&gl->gl_lockref.lock); + } +-out: +- spin_lock(&gl->gl_lockref.lock); ++ ++ /* Complete the operation now. */ ++ finish_xmote(gl, target); ++ __gfs2_glock_queue_work(gl, 0); + } + + /** +-- +2.43.0 + diff --git a/queue-6.8/gfs2-don-t-forget-to-complete-delayed-withdraw.patch b/queue-6.8/gfs2-don-t-forget-to-complete-delayed-withdraw.patch new file mode 100644 index 00000000000..51a736966cc --- /dev/null +++ b/queue-6.8/gfs2-don-t-forget-to-complete-delayed-withdraw.patch @@ -0,0 +1,39 @@ +From 7f8340b58cdd059adf2fc99a8c8dc1ade63f30db Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Jan 2024 11:49:44 +0100 +Subject: gfs2: Don't forget to complete delayed withdraw + +From: Andreas Gruenbacher + +[ Upstream commit b01189333ee91c1ae6cd96dfd1e3a3c2e69202f0 ] + +Commit fffe9bee14b0 ("gfs2: Delay withdraw from atomic context") +switched from gfs2_withdraw() to gfs2_withdraw_delayed() in +gfs2_ail_error(), but failed to then check if a delayed withdraw had +occurred. Fix that by adding the missing check in __gfs2_ail_flush(), +where the spin locks are already dropped and a withdraw is possible. + +Fixes: fffe9bee14b0 ("gfs2: Delay withdraw from atomic context") +Signed-off-by: Andreas Gruenbacher +Signed-off-by: Sasha Levin +--- + fs/gfs2/glops.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c +index 45653cbc8a87d..e0e8dfeee777d 100644 +--- a/fs/gfs2/glops.c ++++ b/fs/gfs2/glops.c +@@ -82,6 +82,9 @@ static void __gfs2_ail_flush(struct gfs2_glock *gl, bool fsync, + GLOCK_BUG_ON(gl, !fsync && atomic_read(&gl->gl_ail_count)); + spin_unlock(&sdp->sd_ail_lock); + gfs2_log_unlock(sdp); ++ ++ if (gfs2_withdrawing(sdp)) ++ gfs2_withdraw(sdp); + } + + +-- +2.43.0 + diff --git a/queue-6.8/gfs2-finish_xmote-cleanup.patch b/queue-6.8/gfs2-finish_xmote-cleanup.patch new file mode 100644 index 00000000000..bd4bf65df08 --- /dev/null +++ b/queue-6.8/gfs2-finish_xmote-cleanup.patch @@ -0,0 +1,108 @@ +From 34821d884eeeb1694b55addf75a4340d7a00325d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 19:16:58 +0200 +Subject: gfs2: finish_xmote cleanup + +From: Andreas Gruenbacher + +[ Upstream commit 1cd28e15864054f3c48baee9eecda1c0441c48ac ] + +Currently, function finish_xmote() takes and releases the glock +spinlock. However, all of its callers immediately take that spinlock +again, so it makes more sense to take the spin lock before calling +finish_xmote() already. + +With that, thaw_glock() is the only place that sets the GLF_HAVE_REPLY +flag outside of the glock spinlock, but it also takes that spinlock +immediately thereafter. Change that to set the bit when the spinlock is +already held. This allows to switch from test_and_clear_bit() to +test_bit() and clear_bit() in glock_work_func(). + +Signed-off-by: Andreas Gruenbacher +Stable-dep-of: 9947a06d29c0 ("gfs2: do_xmote fixes") +Signed-off-by: Sasha Levin +--- + fs/gfs2/glock.c | 21 +++++++++++++-------- + 1 file changed, 13 insertions(+), 8 deletions(-) + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index 1bf0d751ece0a..0c719fcd4fbc5 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -617,7 +617,6 @@ static void finish_xmote(struct gfs2_glock *gl, unsigned int ret) + struct gfs2_holder *gh; + unsigned state = ret & LM_OUT_ST_MASK; + +- spin_lock(&gl->gl_lockref.lock); + trace_gfs2_glock_state_change(gl, state); + state_change(gl, state); + gh = find_first_waiter(gl); +@@ -665,7 +664,6 @@ static void finish_xmote(struct gfs2_glock *gl, unsigned int ret) + gl->gl_target, state); + GLOCK_BUG_ON(gl, 1); + } +- spin_unlock(&gl->gl_lockref.lock); + return; + } + +@@ -688,7 +686,6 @@ static void finish_xmote(struct gfs2_glock *gl, unsigned int ret) + } + out: + clear_bit(GLF_LOCK, &gl->gl_flags); +- spin_unlock(&gl->gl_lockref.lock); + } + + static bool is_system_glock(struct gfs2_glock *gl) +@@ -835,15 +832,19 @@ __acquires(&gl->gl_lockref.lock) + if (ret == -EINVAL && gl->gl_target == LM_ST_UNLOCKED && + target == LM_ST_UNLOCKED && + test_bit(DFL_UNMOUNT, &ls->ls_recover_flags)) { ++ spin_lock(&gl->gl_lockref.lock); + finish_xmote(gl, target); +- gfs2_glock_queue_work(gl, 0); ++ __gfs2_glock_queue_work(gl, 0); ++ spin_unlock(&gl->gl_lockref.lock); + } else if (ret) { + fs_err(sdp, "lm_lock ret %d\n", ret); + GLOCK_BUG_ON(gl, !gfs2_withdrawing_or_withdrawn(sdp)); + } + } else { /* lock_nolock */ ++ spin_lock(&gl->gl_lockref.lock); + finish_xmote(gl, target); +- gfs2_glock_queue_work(gl, 0); ++ __gfs2_glock_queue_work(gl, 0); ++ spin_unlock(&gl->gl_lockref.lock); + } + out: + spin_lock(&gl->gl_lockref.lock); +@@ -1099,11 +1100,12 @@ static void glock_work_func(struct work_struct *work) + struct gfs2_glock *gl = container_of(work, struct gfs2_glock, gl_work.work); + unsigned int drop_refs = 1; + +- if (test_and_clear_bit(GLF_REPLY_PENDING, &gl->gl_flags)) { ++ spin_lock(&gl->gl_lockref.lock); ++ if (test_bit(GLF_REPLY_PENDING, &gl->gl_flags)) { ++ clear_bit(GLF_REPLY_PENDING, &gl->gl_flags); + finish_xmote(gl, gl->gl_reply); + drop_refs++; + } +- spin_lock(&gl->gl_lockref.lock); + if (test_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && + gl->gl_state != LM_ST_UNLOCKED && + gl->gl_demote_state != LM_ST_EXCLUSIVE) { +@@ -2176,8 +2178,11 @@ static void thaw_glock(struct gfs2_glock *gl) + return; + if (!lockref_get_not_dead(&gl->gl_lockref)) + return; ++ ++ spin_lock(&gl->gl_lockref.lock); + set_bit(GLF_REPLY_PENDING, &gl->gl_flags); +- gfs2_glock_queue_work(gl, 0); ++ __gfs2_glock_queue_work(gl, 0); ++ spin_unlock(&gl->gl_lockref.lock); + } + + /** +-- +2.43.0 + diff --git a/queue-6.8/gfs2-fix-ignore-unlock-failures-after-withdraw.patch b/queue-6.8/gfs2-fix-ignore-unlock-failures-after-withdraw.patch new file mode 100644 index 00000000000..973026a4716 --- /dev/null +++ b/queue-6.8/gfs2-fix-ignore-unlock-failures-after-withdraw.patch @@ -0,0 +1,63 @@ +From 9f45c663a8141e877b41ac630dc2613ff02a5395 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 13:47:51 +0200 +Subject: gfs2: Fix "ignore unlock failures after withdraw" + +From: Andreas Gruenbacher + +[ Upstream commit 5d9231111966b6c5a65016d58dcbeab91055bc91 ] + +Commit 3e11e53041502 tries to suppress dlm_lock() lock conversion errors +that occur when the lockspace has already been released. + +It does that by setting and checking the SDF_SKIP_DLM_UNLOCK flag. This +conflicts with the intended meaning of the SDF_SKIP_DLM_UNLOCK flag, so +check whether the lockspace is still allocated instead. + +(Given the current DLM API, checking for this kind of error after the +fact seems easier that than to make sure that the lockspace is still +allocated before calling dlm_lock(). Changing the DLM API so that users +maintain the lockspace references themselves would be an option.) + +Fixes: 3e11e53041502 ("GFS2: ignore unlock failures after withdraw") +Signed-off-by: Andreas Gruenbacher +Signed-off-by: Sasha Levin +--- + fs/gfs2/glock.c | 4 +++- + fs/gfs2/util.c | 1 - + 2 files changed, 3 insertions(+), 2 deletions(-) + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index 34540f9d011ca..385561cd4f4c7 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -802,11 +802,13 @@ __acquires(&gl->gl_lockref.lock) + } + + if (sdp->sd_lockstruct.ls_ops->lm_lock) { ++ struct lm_lockstruct *ls = &sdp->sd_lockstruct; ++ + /* lock_dlm */ + ret = sdp->sd_lockstruct.ls_ops->lm_lock(gl, target, lck_flags); + if (ret == -EINVAL && gl->gl_target == LM_ST_UNLOCKED && + target == LM_ST_UNLOCKED && +- test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags)) { ++ test_bit(DFL_UNMOUNT, &ls->ls_recover_flags)) { + finish_xmote(gl, target); + gfs2_glock_queue_work(gl, 0); + } else if (ret) { +diff --git a/fs/gfs2/util.c b/fs/gfs2/util.c +index f52141ce94853..fc3ecb180ac53 100644 +--- a/fs/gfs2/util.c ++++ b/fs/gfs2/util.c +@@ -350,7 +350,6 @@ int gfs2_withdraw(struct gfs2_sbd *sdp) + fs_err(sdp, "telling LM to unmount\n"); + lm->lm_unmount(sdp); + } +- set_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags); + fs_err(sdp, "File system withdrawn\n"); + dump_stack(); + clear_bit(SDF_WITHDRAW_IN_PROG, &sdp->sd_flags); +-- +2.43.0 + diff --git a/queue-6.8/gfs2-fix-potential-glock-use-after-free-on-unmount.patch b/queue-6.8/gfs2-fix-potential-glock-use-after-free-on-unmount.patch new file mode 100644 index 00000000000..294790b1ba6 --- /dev/null +++ b/queue-6.8/gfs2-fix-potential-glock-use-after-free-on-unmount.patch @@ -0,0 +1,227 @@ +From c5da52d924303e8a382c46cde54044b86aa2ec36 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 04:50:18 +0200 +Subject: gfs2: Fix potential glock use-after-free on unmount + +From: Andreas Gruenbacher + +[ Upstream commit d98779e687726d8f8860f1c54b5687eec5f63a73 ] + +When a DLM lockspace is released and there ares still locks in that +lockspace, DLM will unlock those locks automatically. Commit +fb6791d100d1b started exploiting this behavior to speed up filesystem +unmount: gfs2 would simply free glocks it didn't want to unlock and then +release the lockspace. This didn't take the bast callbacks for +asynchronous lock contention notifications into account, which remain +active until until a lock is unlocked or its lockspace is released. + +To prevent those callbacks from accessing deallocated objects, put the +glocks that should not be unlocked on the sd_dead_glocks list, release +the lockspace, and only then free those glocks. + +As an additional measure, ignore unexpected ast and bast callbacks if +the receiving glock is dead. + +Fixes: fb6791d100d1b ("GFS2: skip dlm_unlock calls in unmount") +Signed-off-by: Andreas Gruenbacher +Cc: David Teigland +Signed-off-by: Sasha Levin +--- + fs/gfs2/glock.c | 35 ++++++++++++++++++++++++++++++++--- + fs/gfs2/glock.h | 1 + + fs/gfs2/incore.h | 1 + + fs/gfs2/lock_dlm.c | 32 ++++++++++++++++++++++---------- + fs/gfs2/ops_fstype.c | 1 + + fs/gfs2/super.c | 3 --- + 6 files changed, 57 insertions(+), 16 deletions(-) + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index 5d5b3235d4e59..1bf0d751ece0a 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -166,18 +166,45 @@ static bool glock_blocked_by_withdraw(struct gfs2_glock *gl) + return true; + } + +-void gfs2_glock_free(struct gfs2_glock *gl) ++static void __gfs2_glock_free(struct gfs2_glock *gl) + { +- struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; +- + rhashtable_remove_fast(&gl_hash_table, &gl->gl_node, ht_parms); + smp_mb(); + wake_up_glock(gl); + call_rcu(&gl->gl_rcu, gfs2_glock_dealloc); ++} ++ ++void gfs2_glock_free(struct gfs2_glock *gl) { ++ struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; ++ ++ __gfs2_glock_free(gl); + if (atomic_dec_and_test(&sdp->sd_glock_disposal)) + wake_up(&sdp->sd_kill_wait); + } + ++void gfs2_glock_free_later(struct gfs2_glock *gl) { ++ struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; ++ ++ spin_lock(&lru_lock); ++ list_add(&gl->gl_lru, &sdp->sd_dead_glocks); ++ spin_unlock(&lru_lock); ++ if (atomic_dec_and_test(&sdp->sd_glock_disposal)) ++ wake_up(&sdp->sd_kill_wait); ++} ++ ++static void gfs2_free_dead_glocks(struct gfs2_sbd *sdp) ++{ ++ struct list_head *list = &sdp->sd_dead_glocks; ++ ++ while(!list_empty(list)) { ++ struct gfs2_glock *gl; ++ ++ gl = list_first_entry(list, struct gfs2_glock, gl_lru); ++ list_del_init(&gl->gl_lru); ++ __gfs2_glock_free(gl); ++ } ++} ++ + /** + * gfs2_glock_hold() - increment reference count on glock + * @gl: The glock to hold +@@ -2226,6 +2253,8 @@ void gfs2_gl_hash_clear(struct gfs2_sbd *sdp) + wait_event_timeout(sdp->sd_kill_wait, + atomic_read(&sdp->sd_glock_disposal) == 0, + HZ * 600); ++ gfs2_lm_unmount(sdp); ++ gfs2_free_dead_glocks(sdp); + glock_hash_walk(dump_glock_func, sdp); + } + +diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h +index 0114f3e0ebe01..86987a59a0580 100644 +--- a/fs/gfs2/glock.h ++++ b/fs/gfs2/glock.h +@@ -252,6 +252,7 @@ void gfs2_gl_dq_holders(struct gfs2_sbd *sdp); + void gfs2_glock_thaw(struct gfs2_sbd *sdp); + void gfs2_glock_add_to_lru(struct gfs2_glock *gl); + void gfs2_glock_free(struct gfs2_glock *gl); ++void gfs2_glock_free_later(struct gfs2_glock *gl); + + int __init gfs2_glock_init(void); + void gfs2_glock_exit(void); +diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h +index 95a334d64da2a..60abd7050c998 100644 +--- a/fs/gfs2/incore.h ++++ b/fs/gfs2/incore.h +@@ -838,6 +838,7 @@ struct gfs2_sbd { + /* For quiescing the filesystem */ + struct gfs2_holder sd_freeze_gh; + struct mutex sd_freeze_mutex; ++ struct list_head sd_dead_glocks; + + char sd_fsname[GFS2_FSNAME_LEN + 3 * sizeof(int) + 2]; + char sd_table_name[GFS2_FSNAME_LEN]; +diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c +index d1ac5d0679ea6..e028e55e67d95 100644 +--- a/fs/gfs2/lock_dlm.c ++++ b/fs/gfs2/lock_dlm.c +@@ -121,6 +121,11 @@ static void gdlm_ast(void *arg) + struct gfs2_glock *gl = arg; + unsigned ret = gl->gl_state; + ++ /* If the glock is dead, we only react to a dlm_unlock() reply. */ ++ if (__lockref_is_dead(&gl->gl_lockref) && ++ gl->gl_lksb.sb_status != -DLM_EUNLOCK) ++ return; ++ + gfs2_update_reply_times(gl); + BUG_ON(gl->gl_lksb.sb_flags & DLM_SBF_DEMOTED); + +@@ -171,6 +176,9 @@ static void gdlm_bast(void *arg, int mode) + { + struct gfs2_glock *gl = arg; + ++ if (__lockref_is_dead(&gl->gl_lockref)) ++ return; ++ + switch (mode) { + case DLM_LOCK_EX: + gfs2_glock_cb(gl, LM_ST_UNLOCKED); +@@ -291,8 +299,12 @@ static void gdlm_put_lock(struct gfs2_glock *gl) + struct lm_lockstruct *ls = &sdp->sd_lockstruct; + int error; + +- if (gl->gl_lksb.sb_lkid == 0) +- goto out_free; ++ BUG_ON(!__lockref_is_dead(&gl->gl_lockref)); ++ ++ if (gl->gl_lksb.sb_lkid == 0) { ++ gfs2_glock_free(gl); ++ return; ++ } + + clear_bit(GLF_BLOCKING, &gl->gl_flags); + gfs2_glstats_inc(gl, GFS2_LKS_DCOUNT); +@@ -300,13 +312,17 @@ static void gdlm_put_lock(struct gfs2_glock *gl) + gfs2_update_request_times(gl); + + /* don't want to call dlm if we've unmounted the lock protocol */ +- if (test_bit(DFL_UNMOUNT, &ls->ls_recover_flags)) +- goto out_free; ++ if (test_bit(DFL_UNMOUNT, &ls->ls_recover_flags)) { ++ gfs2_glock_free(gl); ++ return; ++ } + /* don't want to skip dlm_unlock writing the lvb when lock has one */ + + if (test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags) && +- !gl->gl_lksb.sb_lvbptr) +- goto out_free; ++ !gl->gl_lksb.sb_lvbptr) { ++ gfs2_glock_free_later(gl); ++ return; ++ } + + again: + error = dlm_unlock(ls->ls_dlm, gl->gl_lksb.sb_lkid, DLM_LKF_VALBLK, +@@ -321,10 +337,6 @@ static void gdlm_put_lock(struct gfs2_glock *gl) + gl->gl_name.ln_type, + (unsigned long long)gl->gl_name.ln_number, error); + } +- return; +- +-out_free: +- gfs2_glock_free(gl); + } + + static void gdlm_cancel(struct gfs2_glock *gl) +diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c +index 1281e60be6390..db0df091a6a76 100644 +--- a/fs/gfs2/ops_fstype.c ++++ b/fs/gfs2/ops_fstype.c +@@ -136,6 +136,7 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) + atomic_set(&sdp->sd_log_in_flight, 0); + init_waitqueue_head(&sdp->sd_log_flush_wait); + mutex_init(&sdp->sd_freeze_mutex); ++ INIT_LIST_HEAD(&sdp->sd_dead_glocks); + + return sdp; + +diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c +index e5f79466340d2..2d780b4701a23 100644 +--- a/fs/gfs2/super.c ++++ b/fs/gfs2/super.c +@@ -646,10 +646,7 @@ static void gfs2_put_super(struct super_block *sb) + gfs2_gl_hash_clear(sdp); + truncate_inode_pages_final(&sdp->sd_aspace); + gfs2_delete_debugfs_file(sdp); +- /* Unmount the locking protocol */ +- gfs2_lm_unmount(sdp); + +- /* At this point, we're through participating in the lockspace */ + gfs2_sys_fs_del(sdp); + free_sbd(sdp); + } +-- +2.43.0 + diff --git a/queue-6.8/gfs2-remove-ill-placed-consistency-check.patch b/queue-6.8/gfs2-remove-ill-placed-consistency-check.patch new file mode 100644 index 00000000000..f2694d6486c --- /dev/null +++ b/queue-6.8/gfs2-remove-ill-placed-consistency-check.patch @@ -0,0 +1,37 @@ +From 7cdec1ddaabf85f804d65c0ff70dda7ffbc8457f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 04:24:56 +0200 +Subject: gfs2: Remove ill-placed consistency check + +From: Andreas Gruenbacher + +[ Upstream commit 59f60005797b4018d7b46620037e0c53d690795e ] + +This consistency check was originally added by commit 9287c6452d2b1 +("gfs2: Fix occasional glock use-after-free"). It is ill-placed in +gfs2_glock_free() because if it holds there, it must equally hold in +__gfs2_glock_put() already. Either way, the check doesn't seem +necessary anymore. + +Signed-off-by: Andreas Gruenbacher +Stable-dep-of: d98779e68772 ("gfs2: Fix potential glock use-after-free on unmount") +Signed-off-by: Sasha Levin +--- + fs/gfs2/glock.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index 385561cd4f4c7..5d5b3235d4e59 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -170,7 +170,6 @@ void gfs2_glock_free(struct gfs2_glock *gl) + { + struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; + +- gfs2_glock_assert_withdraw(gl, atomic_read(&gl->gl_revokes) == 0); + rhashtable_remove_fast(&gl_hash_table, &gl->gl_node, ht_parms); + smp_mb(); + wake_up_glock(gl); +-- +2.43.0 + diff --git a/queue-6.8/gpio-nuvoton-fix-sgpio-irq-handle-error.patch b/queue-6.8/gpio-nuvoton-fix-sgpio-irq-handle-error.patch new file mode 100644 index 00000000000..f02eb845a2f --- /dev/null +++ b/queue-6.8/gpio-nuvoton-fix-sgpio-irq-handle-error.patch @@ -0,0 +1,55 @@ +From 245ed9ba2ecb0e9cdf6f5c6d6afd48420fb1411d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 14:42:44 +0800 +Subject: gpio: nuvoton: Fix sgpio irq handle error + +From: Jim Liu + +[ Upstream commit 7f45fe2ea3b8c85787976293126a4a7133b107de ] + +The generic_handle_domain_irq() function calls irq_resolve_mapping(). +Thus delete a duplicative irq_find_mapping() call +so that a stack trace and an RCU stall will be avoided. + +Fixes: c4f8457d17ce ("gpio: nuvoton: Add Nuvoton NPCM sgpio driver") +Signed-off-by: Jim Liu +Reviewed-by: Linus Walleij +Reviewed-by: Dan Carpenter +Link: https://lore.kernel.org/r/20240506064244.1645922-1-JJLIU0@nuvoton.com +Signed-off-by: Bartosz Golaszewski +Signed-off-by: Sasha Levin +--- + drivers/gpio/gpio-npcm-sgpio.c | 10 ++++------ + 1 file changed, 4 insertions(+), 6 deletions(-) + +diff --git a/drivers/gpio/gpio-npcm-sgpio.c b/drivers/gpio/gpio-npcm-sgpio.c +index d31788b43abcc..2605706145434 100644 +--- a/drivers/gpio/gpio-npcm-sgpio.c ++++ b/drivers/gpio/gpio-npcm-sgpio.c +@@ -434,7 +434,7 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc) + struct gpio_chip *gc = irq_desc_get_handler_data(desc); + struct irq_chip *ic = irq_desc_get_chip(desc); + struct npcm_sgpio *gpio = gpiochip_get_data(gc); +- unsigned int i, j, girq; ++ unsigned int i, j; + unsigned long reg; + + chained_irq_enter(ic, desc); +@@ -443,11 +443,9 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc) + const struct npcm_sgpio_bank *bank = &npcm_sgpio_banks[i]; + + reg = ioread8(bank_reg(gpio, bank, EVENT_STS)); +- for_each_set_bit(j, ®, 8) { +- girq = irq_find_mapping(gc->irq.domain, +- i * 8 + gpio->nout_sgpio + j); +- generic_handle_domain_irq(gc->irq.domain, girq); +- } ++ for_each_set_bit(j, ®, 8) ++ generic_handle_domain_irq(gc->irq.domain, ++ i * 8 + gpio->nout_sgpio + j); + } + + chained_irq_exit(ic, desc); +-- +2.43.0 + diff --git a/queue-6.8/hid-amd_sfh-handle-no-sensors-in-pm-operations.patch b/queue-6.8/hid-amd_sfh-handle-no-sensors-in-pm-operations.patch new file mode 100644 index 00000000000..e892246a950 --- /dev/null +++ b/queue-6.8/hid-amd_sfh-handle-no-sensors-in-pm-operations.patch @@ -0,0 +1,52 @@ +From b73f2d1ef4fbe8b1d5ba32e9cec51263bf5e7631 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 May 2024 12:40:44 +0530 +Subject: HID: amd_sfh: Handle "no sensors" in PM operations + +From: Basavaraj Natikar + +[ Upstream commit 077e3e3bc84a51891e732507bbbd9acf6e0e4c8b ] + +Resume or suspend each sensor device based on the num_hid_devices. +Therefore, add a check to handle the special case where no sensors are +present. + +Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality") +Signed-off-by: Basavaraj Natikar +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 10 ++++++++++ + 1 file changed, 10 insertions(+) + +diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c +index 9dbe6f4cb2942..c89e6a2a58736 100644 +--- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c ++++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c +@@ -227,6 +227,11 @@ static void amd_sfh_resume(struct amd_mp2_dev *mp2) + struct amd_mp2_sensor_info info; + int i, status; + ++ if (!cl_data->is_any_sensor_enabled) { ++ amd_sfh_clear_intr(mp2); ++ return; ++ } ++ + for (i = 0; i < cl_data->num_hid_devices; i++) { + if (cl_data->sensor_sts[i] == SENSOR_DISABLED) { + info.sensor_idx = cl_data->sensor_idx[i]; +@@ -252,6 +257,11 @@ static void amd_sfh_suspend(struct amd_mp2_dev *mp2) + struct amdtp_cl_data *cl_data = mp2->cl_data; + int i, status; + ++ if (!cl_data->is_any_sensor_enabled) { ++ amd_sfh_clear_intr(mp2); ++ return; ++ } ++ + for (i = 0; i < cl_data->num_hid_devices; i++) { + if (cl_data->sensor_idx[i] != HPD_IDX && + cl_data->sensor_sts[i] == SENSOR_ENABLED) { +-- +2.43.0 + diff --git a/queue-6.8/hid-intel-ish-hid-ipc-add-check-for-pci_alloc_irq_ve.patch b/queue-6.8/hid-intel-ish-hid-ipc-add-check-for-pci_alloc_irq_ve.patch new file mode 100644 index 00000000000..0314db6280c --- /dev/null +++ b/queue-6.8/hid-intel-ish-hid-ipc-add-check-for-pci_alloc_irq_ve.patch @@ -0,0 +1,41 @@ +From 4bff0033298bcdbc6d9cdc5a3b4eba4de6a13fdf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 29 Apr 2024 16:54:22 +0800 +Subject: HID: intel-ish-hid: ipc: Add check for pci_alloc_irq_vectors + +From: Chen Ni + +[ Upstream commit 6baa4524027fd64d7ca524e1717c88c91a354b93 ] + +Add a check for the return value of pci_alloc_irq_vectors() and return +error if it fails. + +[jkosina@suse.com: reworded changelog based on Srinivas' suggestion] +Fixes: 74fbc7d371d9 ("HID: intel-ish-hid: add MSI interrupt support") +Signed-off-by: Chen Ni +Acked-by: Srinivas Pandruvada +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/intel-ish-hid/ipc/pci-ish.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c +index 65e7eeb2fa64e..ce5576ef3c861 100644 +--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c ++++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c +@@ -172,6 +172,11 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent) + + /* request and enable interrupt */ + ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); ++ if (ret < 0) { ++ dev_err(dev, "ISH: Failed to allocate IRQ vectors\n"); ++ return ret; ++ } ++ + if (!pdev->msi_enabled && !pdev->msix_enabled) + irq_flag = IRQF_SHARED; + +-- +2.43.0 + diff --git a/queue-6.8/hid-mcp-2221-cancel-delayed_work-only-when-config_ii.patch b/queue-6.8/hid-mcp-2221-cancel-delayed_work-only-when-config_ii.patch new file mode 100644 index 00000000000..52f5770403c --- /dev/null +++ b/queue-6.8/hid-mcp-2221-cancel-delayed_work-only-when-config_ii.patch @@ -0,0 +1,40 @@ +From b1854d6414b484737a69472fb795bd7c3b12c36d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 14:14:06 +0200 +Subject: HID: mcp-2221: cancel delayed_work only when CONFIG_IIO is enabled + +From: Abdelrahman Morsy + +[ Upstream commit 3cba9cfcc1520a2307a29f6fab887bcfc121c417 ] + +If the device is unplugged and CONFIG_IIO is not supported, this will +result in a warning message at kernel/workqueue. + +Only cancel delayed work in mcp2221_remove(), when CONFIG_IIO is enabled. + +Signed-off-by: Abdelrahman Morsy +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/hid-mcp2221.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c +index f9cceaeffd081..da5ea5a23b087 100644 +--- a/drivers/hid/hid-mcp2221.c ++++ b/drivers/hid/hid-mcp2221.c +@@ -944,9 +944,11 @@ static void mcp2221_hid_unregister(void *ptr) + /* This is needed to be sure hid_hw_stop() isn't called twice by the subsystem */ + static void mcp2221_remove(struct hid_device *hdev) + { ++#if IS_REACHABLE(CONFIG_IIO) + struct mcp2221 *mcp = hid_get_drvdata(hdev); + + cancel_delayed_work_sync(&mcp->init_work); ++#endif + } + + #if IS_REACHABLE(CONFIG_IIO) +-- +2.43.0 + diff --git a/queue-6.8/hid-nintendo-fix-n64-controller-being-identified-as-.patch b/queue-6.8/hid-nintendo-fix-n64-controller-being-identified-as-.patch new file mode 100644 index 00000000000..a2fa8aa2640 --- /dev/null +++ b/queue-6.8/hid-nintendo-fix-n64-controller-being-identified-as-.patch @@ -0,0 +1,51 @@ +From d6db4e8cd9e85bd87adfd05b5213af4056b540f6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Feb 2024 22:39:31 +0000 +Subject: HID: nintendo: Fix N64 controller being identified as mouse + +From: Nuno Pereira + +[ Upstream commit 8db8c77059e75a0f418b10ede39dd82a9eb031fa ] + +This patch is regarding the recent addition of support for the NSO +controllers to hid-nintendo. All controllers are working correctly with the +exception of the N64 controller, which is being identified as a mouse by +udev. This results in the joystick controlling the mouse cursor and the +controller not being detected by games. + +The reason for this is because the N64's C buttons have been attributed to +BTN_FORWARD, BTN_BACK, BTN_LEFT, BTN_RIGHT, which are buttons typically +attributed to mice. + +This patch changes those buttons to controller buttons, making the +controller be correctly identified as such. + +Signed-off-by: Nuno Pereira +Signed-off-by: Jiri Kosina +Signed-off-by: Sasha Levin +--- + drivers/hid/hid-nintendo.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c +index ccc4032fb2b03..4b2c81b49b80e 100644 +--- a/drivers/hid/hid-nintendo.c ++++ b/drivers/hid/hid-nintendo.c +@@ -481,10 +481,10 @@ static const struct joycon_ctlr_button_mapping n64con_button_mappings[] = { + { BTN_TR, JC_BTN_R, }, + { BTN_TR2, JC_BTN_LSTICK, }, /* ZR */ + { BTN_START, JC_BTN_PLUS, }, +- { BTN_FORWARD, JC_BTN_Y, }, /* C UP */ +- { BTN_BACK, JC_BTN_ZR, }, /* C DOWN */ +- { BTN_LEFT, JC_BTN_X, }, /* C LEFT */ +- { BTN_RIGHT, JC_BTN_MINUS, }, /* C RIGHT */ ++ { BTN_SELECT, JC_BTN_Y, }, /* C UP */ ++ { BTN_X, JC_BTN_ZR, }, /* C DOWN */ ++ { BTN_Y, JC_BTN_X, }, /* C LEFT */ ++ { BTN_C, JC_BTN_MINUS, }, /* C RIGHT */ + { BTN_MODE, JC_BTN_HOME, }, + { BTN_Z, JC_BTN_CAP, }, + { /* sentinel */ }, +-- +2.43.0 + diff --git a/queue-6.8/hwrng-stm32-put-ip-into-rpm-suspend-on-failure.patch b/queue-6.8/hwrng-stm32-put-ip-into-rpm-suspend-on-failure.patch new file mode 100644 index 00000000000..d02c9574f49 --- /dev/null +++ b/queue-6.8/hwrng-stm32-put-ip-into-rpm-suspend-on-failure.patch @@ -0,0 +1,56 @@ +From f4d089bf216917225d49292d748e44ea74c7df3d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 07:01:13 +0200 +Subject: hwrng: stm32 - put IP into RPM suspend on failure + +From: Marek Vasut + +[ Upstream commit da62ed5c019cc48648f37c7a07e6a56cf637a795 ] + +In case of an irrecoverable failure, put the IP into RPM suspend +to avoid RPM imbalance. I did not trigger this case, but it seems +it should be done based on reading the code. + +Fixes: b17bc6eb7c2b ("hwrng: stm32 - rework error handling in stm32_rng_read()") +Signed-off-by: Marek Vasut +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/char/hw_random/stm32-rng.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c +index 1cc61ef8ee54c..b6182f86d8a4b 100644 +--- a/drivers/char/hw_random/stm32-rng.c ++++ b/drivers/char/hw_random/stm32-rng.c +@@ -220,7 +220,8 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait) + if (err && i > RNG_NB_RECOVER_TRIES) { + dev_err((struct device *)priv->rng.priv, + "Couldn't recover from seed error\n"); +- return -ENOTRECOVERABLE; ++ retval = -ENOTRECOVERABLE; ++ goto exit_rpm; + } + + continue; +@@ -238,7 +239,8 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait) + if (err && i > RNG_NB_RECOVER_TRIES) { + dev_err((struct device *)priv->rng.priv, + "Couldn't recover from seed error"); +- return -ENOTRECOVERABLE; ++ retval = -ENOTRECOVERABLE; ++ goto exit_rpm; + } + + continue; +@@ -250,6 +252,7 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait) + max -= sizeof(u32); + } + ++exit_rpm: + pm_runtime_mark_last_busy((struct device *) priv->rng.priv); + pm_runtime_put_sync_autosuspend((struct device *) priv->rng.priv); + +-- +2.43.0 + diff --git a/queue-6.8/hwrng-stm32-repair-clock-handling.patch b/queue-6.8/hwrng-stm32-repair-clock-handling.patch new file mode 100644 index 00000000000..d4376e90ba2 --- /dev/null +++ b/queue-6.8/hwrng-stm32-repair-clock-handling.patch @@ -0,0 +1,79 @@ +From 369ff70c10c83ececb8af3f1212d7fb15aeb0873 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 07:01:14 +0200 +Subject: hwrng: stm32 - repair clock handling + +From: Marek Vasut + +[ Upstream commit c819d7b836c5dfca0854d3e56664293601f2176d ] + +The clock management in this driver does not seem to be correct. The +struct hwrng .init callback enables the clock, but there is no matching +.cleanup callback to disable the clock. The clock get disabled as some +later point by runtime PM suspend callback. + +Furthermore, both runtime PM and sleep suspend callbacks access registers +first and disable clock which are used for register access second. If the +IP is already in RPM suspend and the system enters sleep state, the sleep +callback will attempt to access registers while the register clock are +already disabled. This bug has been fixed once before already in commit +9bae54942b13 ("hwrng: stm32 - fix pm_suspend issue"), and regressed in +commit ff4e46104f2e ("hwrng: stm32 - rework power management sequences") . + +Fix this slightly differently, disable register clock at the end of .init +callback, this way the IP is disabled after .init. On every access to the +IP, which really is only stm32_rng_read(), do pm_runtime_get_sync() which +is already done in stm32_rng_read() to bring the IP from RPM suspend, and +pm_runtime_mark_last_busy()/pm_runtime_put_sync_autosuspend() to put it +back into RPM suspend. + +Change sleep suspend/resume callbacks to enable and disable register clock +around register access, as those cannot use the RPM suspend/resume callbacks +due to slightly different initialization in those sleep callbacks. This way, +the register access should always be performed with clock surely enabled. + +Fixes: ff4e46104f2e ("hwrng: stm32 - rework power management sequences") +Signed-off-by: Marek Vasut +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/char/hw_random/stm32-rng.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c +index b6182f86d8a4b..0e903d6e22e30 100644 +--- a/drivers/char/hw_random/stm32-rng.c ++++ b/drivers/char/hw_random/stm32-rng.c +@@ -363,6 +363,8 @@ static int stm32_rng_init(struct hwrng *rng) + return -EINVAL; + } + ++ clk_disable_unprepare(priv->clk); ++ + return 0; + } + +@@ -387,6 +389,11 @@ static int __maybe_unused stm32_rng_runtime_suspend(struct device *dev) + static int __maybe_unused stm32_rng_suspend(struct device *dev) + { + struct stm32_rng_private *priv = dev_get_drvdata(dev); ++ int err; ++ ++ err = clk_prepare_enable(priv->clk); ++ if (err) ++ return err; + + if (priv->data->has_cond_reset) { + priv->pm_conf.nscr = readl_relaxed(priv->base + RNG_NSCR); +@@ -468,6 +475,8 @@ static int __maybe_unused stm32_rng_resume(struct device *dev) + writel_relaxed(reg, priv->base + RNG_CR); + } + ++ clk_disable_unprepare(priv->clk); ++ + return 0; + } + +-- +2.43.0 + diff --git a/queue-6.8/hwrng-stm32-use-logical-or-in-conditional.patch b/queue-6.8/hwrng-stm32-use-logical-or-in-conditional.patch new file mode 100644 index 00000000000..50b25445ed8 --- /dev/null +++ b/queue-6.8/hwrng-stm32-use-logical-or-in-conditional.patch @@ -0,0 +1,37 @@ +From 0681c3be65ca59d7882655ff8295bb79d786c821 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 07:01:12 +0200 +Subject: hwrng: stm32 - use logical OR in conditional + +From: Marek Vasut + +[ Upstream commit 31b57788a5024d3a114b28dad224a93831b90b5f ] + +The conditional is used to check whether err is non-zero OR whether +reg variable is non-zero after clearing bits from it. This should be +done using logical OR, not bitwise OR, fix it. + +Fixes: 6b85a7e141cb ("hwrng: stm32 - implement STM32MP13x support") +Signed-off-by: Marek Vasut +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/char/hw_random/stm32-rng.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c +index 379bc245c5202..1cc61ef8ee54c 100644 +--- a/drivers/char/hw_random/stm32-rng.c ++++ b/drivers/char/hw_random/stm32-rng.c +@@ -353,7 +353,7 @@ static int stm32_rng_init(struct hwrng *rng) + err = readl_relaxed_poll_timeout_atomic(priv->base + RNG_SR, reg, + reg & RNG_SR_DRDY, + 10, 100000); +- if (err | (reg & ~RNG_SR_DRDY)) { ++ if (err || (reg & ~RNG_SR_DRDY)) { + clk_disable_unprepare(priv->clk); + dev_err((struct device *)priv->rng.priv, + "%s: timeout:%x SR: %x!\n", __func__, err, reg); +-- +2.43.0 + diff --git a/queue-6.8/ib-mlx5-use-__iowrite64_copy-for-write-combining-sto.patch b/queue-6.8/ib-mlx5-use-__iowrite64_copy-for-write-combining-sto.patch new file mode 100644 index 00000000000..7f489482b08 --- /dev/null +++ b/queue-6.8/ib-mlx5-use-__iowrite64_copy-for-write-combining-sto.patch @@ -0,0 +1,83 @@ +From ec4ed7c877ed261fc7c9d3bb292fa8f4024d268a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 13:46:19 -0300 +Subject: IB/mlx5: Use __iowrite64_copy() for write combining stores + +From: Jason Gunthorpe + +[ Upstream commit ef302283ddfceaba2657923af3f90fd58e6dff06 ] + +mlx5 has a built in self-test at driver startup to evaluate if the +platform supports write combining to generate a 64 byte PCIe TLP or +not. This has proven necessary because a lot of common scenarios end up +with broken write combining (especially inside virtual machines) and there +is other way to learn this information. + +This self test has been consistently failing on new ARM64 CPU +designs (specifically with NVIDIA Grace's implementation of Neoverse +V2). The C loop around writeq() generates some pretty terrible ARM64 +assembly, but historically this has worked on a lot of existing ARM64 CPUs +till now. + +We see it succeed about 1 time in 10,000 on the worst effected +systems. The CPU architects speculate that the load instructions +interspersed with the stores makes the WC buffers statistically flush too +often and thus the generation of large TLPs becomes infrequent. This makes +the boot up test unreliable in that it indicates no write-combining, +however userspace would be fine since it uses a ST4 instruction. + +Further, S390 has similar issues where only the special zpci_memcpy_toio() +will actually generate large TLPs, and the open coded loop does not +trigger it at all. + +Fix both ARM64 and S390 by switching to __iowrite64_copy() which now +provides architecture specific variants that have a high change of +generating a large TLP with write combining. x86 continues to use a +similar writeq loop in the generate __iowrite64_copy(). + +Fixes: 11f552e21755 ("IB/mlx5: Test write combining support") +Link: https://lore.kernel.org/r/6-v3-1893cd8b9369+1925-mlx5_arm_wc_jgg@nvidia.com +Tested-by: Niklas Schnelle +Acked-by: Leon Romanovsky +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/mem.c | 8 +++----- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/drivers/infiniband/hw/mlx5/mem.c b/drivers/infiniband/hw/mlx5/mem.c +index 96ffbbaf0a73d..5a22be14d958f 100644 +--- a/drivers/infiniband/hw/mlx5/mem.c ++++ b/drivers/infiniband/hw/mlx5/mem.c +@@ -30,6 +30,7 @@ + * SOFTWARE. + */ + ++#include + #include + #include "mlx5_ib.h" + #include +@@ -108,7 +109,6 @@ static int post_send_nop(struct mlx5_ib_dev *dev, struct ib_qp *ibqp, u64 wr_id, + __be32 mmio_wqe[16] = {}; + unsigned long flags; + unsigned int idx; +- int i; + + if (unlikely(dev->mdev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR)) + return -EIO; +@@ -148,10 +148,8 @@ static int post_send_nop(struct mlx5_ib_dev *dev, struct ib_qp *ibqp, u64 wr_id, + * we hit doorbell + */ + wmb(); +- for (i = 0; i < 8; i++) +- mlx5_write64(&mmio_wqe[i * 2], +- bf->bfreg->map + bf->offset + i * 8); +- io_stop_wc(); ++ __iowrite64_copy(bf->bfreg->map + bf->offset, mmio_wqe, ++ sizeof(mmio_wqe) / 8); + + bf->offset ^= bf->buf_size; + +-- +2.43.0 + diff --git a/queue-6.8/ice-fix-package-download-algorithm.patch b/queue-6.8/ice-fix-package-download-algorithm.patch new file mode 100644 index 00000000000..ffb39cccee5 --- /dev/null +++ b/queue-6.8/ice-fix-package-download-algorithm.patch @@ -0,0 +1,56 @@ +From 60a23668f65ffb5e55a49fac903dcd6aab5adf56 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 10:19:07 -0700 +Subject: ice: Fix package download algorithm + +From: Dan Nowlin + +[ Upstream commit 6d51d44ecddb5c2962688ef06e55e4fbc949f04a ] + +Previously, the driver assumed that all signature segments would contain +one or more buffers to download. In the future, there will be signature +segments that will contain no buffers to download. + +Correct download flow to allow for signature segments that have zero +download buffers and skip the download in this case. + +Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment") +Reviewed-by: Przemek Kitszel +Signed-off-by: Dan Nowlin +Signed-off-by: Paul Greenwalt +Reviewed-by: Paul Menzel +Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) +Signed-off-by: Tony Nguyen +Link: https://lore.kernel.org/r/20240508171908.2760776-1-anthony.l.nguyen@intel.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/ice/ice_ddp.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c b/drivers/net/ethernet/intel/ice/ice_ddp.c +index 8b7504a9df316..90b9e28ddba91 100644 +--- a/drivers/net/ethernet/intel/ice/ice_ddp.c ++++ b/drivers/net/ethernet/intel/ice/ice_ddp.c +@@ -1424,14 +1424,14 @@ ice_dwnld_sign_and_cfg_segs(struct ice_hw *hw, struct ice_pkg_hdr *pkg_hdr, + goto exit; + } + +- conf_idx = le32_to_cpu(seg->signed_seg_idx); +- start = le32_to_cpu(seg->signed_buf_start); + count = le32_to_cpu(seg->signed_buf_count); +- + state = ice_download_pkg_sig_seg(hw, seg); +- if (state) ++ if (state || !count) + goto exit; + ++ conf_idx = le32_to_cpu(seg->signed_seg_idx); ++ start = le32_to_cpu(seg->signed_buf_start); ++ + state = ice_download_pkg_config_seg(hw, pkg_hdr, conf_idx, start, + count); + +-- +2.43.0 + diff --git a/queue-6.8/ice-make-ice_vsi_cfg_rxq-static.patch b/queue-6.8/ice-make-ice_vsi_cfg_rxq-static.patch new file mode 100644 index 00000000000..59fa10fe2a7 --- /dev/null +++ b/queue-6.8/ice-make-ice_vsi_cfg_rxq-static.patch @@ -0,0 +1,236 @@ +From 10ad19c98a598a3a5db8182045d41126e16f04c3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Jan 2024 12:58:45 +0100 +Subject: ice: make ice_vsi_cfg_rxq() static + +From: Maciej Fijalkowski + +[ Upstream commit 3e5fb691faee1d43ee13d4ce2666b0a05e1555b3 ] + +Currently, XSK control path in ice driver calls directly +ice_vsi_cfg_rxq() whereas we have ice_vsi_cfg_single_rxq() for that +purpose. Use the latter from XSK side and make ice_vsi_cfg_rxq() static. + +ice_vsi_cfg_rxq() resides in ice_base.c and is rather big, so to reduce +the code churn let us move two callers of it from ice_lib.c to +ice_base.c. + +Signed-off-by: Maciej Fijalkowski +Acked-by: Magnus Karlsson +Reviewed-by: Simon Horman +Tested-by: Chandan Kumar Rout (A Contingent Worker at Intel) +Signed-off-by: Tony Nguyen +Stable-dep-of: e77f43d531af ("Bluetooth: hci_core: Fix not handling hdev->le_num_of_adv_sets=1") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/ice/ice_base.c | 58 ++++++++++++++++++++++- + drivers/net/ethernet/intel/ice/ice_base.h | 3 +- + drivers/net/ethernet/intel/ice/ice_lib.c | 56 ---------------------- + drivers/net/ethernet/intel/ice/ice_lib.h | 4 -- + drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +- + 5 files changed, 60 insertions(+), 63 deletions(-) + +diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c +index c979192e44d10..9263754c9525d 100644 +--- a/drivers/net/ethernet/intel/ice/ice_base.c ++++ b/drivers/net/ethernet/intel/ice/ice_base.c +@@ -536,7 +536,7 @@ static void ice_xsk_pool_fill_cb(struct ice_rx_ring *ring) + * + * Return 0 on success and a negative value on error. + */ +-int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) ++static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) + { + struct device *dev = ice_pf_to_dev(ring->vsi->back); + u32 num_bufs = ICE_RX_DESC_UNUSED(ring); +@@ -631,6 +631,62 @@ int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) + return 0; + } + ++int ice_vsi_cfg_single_rxq(struct ice_vsi *vsi, u16 q_idx) ++{ ++ if (q_idx >= vsi->num_rxq) ++ return -EINVAL; ++ ++ return ice_vsi_cfg_rxq(vsi->rx_rings[q_idx]); ++} ++ ++/** ++ * ice_vsi_cfg_frame_size - setup max frame size and Rx buffer length ++ * @vsi: VSI ++ */ ++static void ice_vsi_cfg_frame_size(struct ice_vsi *vsi) ++{ ++ if (!vsi->netdev || test_bit(ICE_FLAG_LEGACY_RX, vsi->back->flags)) { ++ vsi->max_frame = ICE_MAX_FRAME_LEGACY_RX; ++ vsi->rx_buf_len = ICE_RXBUF_1664; ++#if (PAGE_SIZE < 8192) ++ } else if (!ICE_2K_TOO_SMALL_WITH_PADDING && ++ (vsi->netdev->mtu <= ETH_DATA_LEN)) { ++ vsi->max_frame = ICE_RXBUF_1536 - NET_IP_ALIGN; ++ vsi->rx_buf_len = ICE_RXBUF_1536 - NET_IP_ALIGN; ++#endif ++ } else { ++ vsi->max_frame = ICE_AQ_SET_MAC_FRAME_SIZE_MAX; ++ vsi->rx_buf_len = ICE_RXBUF_3072; ++ } ++} ++ ++/** ++ * ice_vsi_cfg_rxqs - Configure the VSI for Rx ++ * @vsi: the VSI being configured ++ * ++ * Return 0 on success and a negative value on error ++ * Configure the Rx VSI for operation. ++ */ ++int ice_vsi_cfg_rxqs(struct ice_vsi *vsi) ++{ ++ u16 i; ++ ++ if (vsi->type == ICE_VSI_VF) ++ goto setup_rings; ++ ++ ice_vsi_cfg_frame_size(vsi); ++setup_rings: ++ /* set up individual rings */ ++ ice_for_each_rxq(vsi, i) { ++ int err = ice_vsi_cfg_rxq(vsi->rx_rings[i]); ++ ++ if (err) ++ return err; ++ } ++ ++ return 0; ++} ++ + /** + * __ice_vsi_get_qs - helper function for assigning queues from PF to VSI + * @qs_cfg: gathered variables needed for pf->vsi queues assignment +diff --git a/drivers/net/ethernet/intel/ice/ice_base.h b/drivers/net/ethernet/intel/ice/ice_base.h +index 17321ba75602d..85e6076445602 100644 +--- a/drivers/net/ethernet/intel/ice/ice_base.h ++++ b/drivers/net/ethernet/intel/ice/ice_base.h +@@ -6,7 +6,8 @@ + + #include "ice.h" + +-int ice_vsi_cfg_rxq(struct ice_rx_ring *ring); ++int ice_vsi_cfg_single_rxq(struct ice_vsi *vsi, u16 q_idx); ++int ice_vsi_cfg_rxqs(struct ice_vsi *vsi); + int __ice_vsi_get_qs(struct ice_qs_cfg *qs_cfg); + int + ice_vsi_ctrl_one_rx_ring(struct ice_vsi *vsi, bool ena, u16 rxq_idx, bool wait); +diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c +index cfc20684f25ab..27b3423c9ff23 100644 +--- a/drivers/net/ethernet/intel/ice/ice_lib.c ++++ b/drivers/net/ethernet/intel/ice/ice_lib.c +@@ -1671,27 +1671,6 @@ static void ice_vsi_set_rss_flow_fld(struct ice_vsi *vsi) + } + } + +-/** +- * ice_vsi_cfg_frame_size - setup max frame size and Rx buffer length +- * @vsi: VSI +- */ +-static void ice_vsi_cfg_frame_size(struct ice_vsi *vsi) +-{ +- if (!vsi->netdev || test_bit(ICE_FLAG_LEGACY_RX, vsi->back->flags)) { +- vsi->max_frame = ICE_MAX_FRAME_LEGACY_RX; +- vsi->rx_buf_len = ICE_RXBUF_1664; +-#if (PAGE_SIZE < 8192) +- } else if (!ICE_2K_TOO_SMALL_WITH_PADDING && +- (vsi->netdev->mtu <= ETH_DATA_LEN)) { +- vsi->max_frame = ICE_RXBUF_1536 - NET_IP_ALIGN; +- vsi->rx_buf_len = ICE_RXBUF_1536 - NET_IP_ALIGN; +-#endif +- } else { +- vsi->max_frame = ICE_AQ_SET_MAC_FRAME_SIZE_MAX; +- vsi->rx_buf_len = ICE_RXBUF_3072; +- } +-} +- + /** + * ice_pf_state_is_nominal - checks the PF for nominal state + * @pf: pointer to PF to check +@@ -1795,14 +1774,6 @@ ice_write_qrxflxp_cntxt(struct ice_hw *hw, u16 pf_q, u32 rxdid, u32 prio, + wr32(hw, QRXFLXP_CNTXT(pf_q), regval); + } + +-int ice_vsi_cfg_single_rxq(struct ice_vsi *vsi, u16 q_idx) +-{ +- if (q_idx >= vsi->num_rxq) +- return -EINVAL; +- +- return ice_vsi_cfg_rxq(vsi->rx_rings[q_idx]); +-} +- + int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, u16 q_idx) + { + DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); +@@ -1815,33 +1786,6 @@ int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, u + return ice_vsi_cfg_txq(vsi, tx_rings[q_idx], qg_buf); + } + +-/** +- * ice_vsi_cfg_rxqs - Configure the VSI for Rx +- * @vsi: the VSI being configured +- * +- * Return 0 on success and a negative value on error +- * Configure the Rx VSI for operation. +- */ +-int ice_vsi_cfg_rxqs(struct ice_vsi *vsi) +-{ +- u16 i; +- +- if (vsi->type == ICE_VSI_VF) +- goto setup_rings; +- +- ice_vsi_cfg_frame_size(vsi); +-setup_rings: +- /* set up individual rings */ +- ice_for_each_rxq(vsi, i) { +- int err = ice_vsi_cfg_rxq(vsi->rx_rings[i]); +- +- if (err) +- return err; +- } +- +- return 0; +-} +- + /** + * ice_vsi_cfg_txqs - Configure the VSI for Tx + * @vsi: the VSI being configured +diff --git a/drivers/net/ethernet/intel/ice/ice_lib.h b/drivers/net/ethernet/intel/ice/ice_lib.h +index bfcfc582a4c04..95505a501a935 100644 +--- a/drivers/net/ethernet/intel/ice/ice_lib.h ++++ b/drivers/net/ethernet/intel/ice/ice_lib.h +@@ -54,12 +54,8 @@ bool ice_pf_state_is_nominal(struct ice_pf *pf); + + void ice_update_eth_stats(struct ice_vsi *vsi); + +-int ice_vsi_cfg_single_rxq(struct ice_vsi *vsi, u16 q_idx); +- + int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, u16 q_idx); + +-int ice_vsi_cfg_rxqs(struct ice_vsi *vsi); +- + int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi); + + void ice_vsi_cfg_msix(struct ice_vsi *vsi); +diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c +index 2eecd0f39aa69..9e01f410af772 100644 +--- a/drivers/net/ethernet/intel/ice/ice_xsk.c ++++ b/drivers/net/ethernet/intel/ice/ice_xsk.c +@@ -250,7 +250,7 @@ static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx) + ice_tx_xsk_pool(vsi, q_idx); + } + +- err = ice_vsi_cfg_rxq(rx_ring); ++ err = ice_vsi_cfg_single_rxq(vsi, q_idx); + if (err) + return err; + +-- +2.43.0 + diff --git a/queue-6.8/ice-make-ice_vsi_cfg_txq-static.patch b/queue-6.8/ice-make-ice_vsi_cfg_txq-static.patch new file mode 100644 index 00000000000..34d2a08cce1 --- /dev/null +++ b/queue-6.8/ice-make-ice_vsi_cfg_txq-static.patch @@ -0,0 +1,310 @@ +From 1161ff03388c24afc76924ced87459ff0fb74ecf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Jan 2024 12:58:46 +0100 +Subject: ice: make ice_vsi_cfg_txq() static + +From: Maciej Fijalkowski + +[ Upstream commit a292ba981324ec790eb671df1c64fae5c98c4b3d ] + +Currently, XSK control path in ice driver calls directly +ice_vsi_cfg_txq() whereas we have ice_vsi_cfg_single_txq() for that +purpose. Use the latter from XSK side and make ice_vsi_cfg_txq() static. + +ice_vsi_cfg_txq() resides in ice_base.c and is rather big, so to reduce +the code churn let us move the callers of it from ice_lib.c to +ice_base.c. + +This change puts ice_qp_ena() on nice diet due to the checks and +operations that ice_vsi_cfg_single_{r,t}xq() do internally. + +add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-182 (-182) +Function old new delta +ice_xsk_pool_setup 2165 1983 -182 +Total: Before=472597, After=472415, chg -0.04% + +Signed-off-by: Maciej Fijalkowski +Acked-by: Magnus Karlsson +Reviewed-by: Simon Horman +Tested-by: Chandan Kumar Rout (A Contingent Worker at Intel) +Signed-off-by: Tony Nguyen +Stable-dep-of: e77f43d531af ("Bluetooth: hci_core: Fix not handling hdev->le_num_of_adv_sets=1") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/ice/ice_base.c | 76 ++++++++++++++++++++++- + drivers/net/ethernet/intel/ice/ice_base.h | 7 ++- + drivers/net/ethernet/intel/ice/ice_lib.c | 73 ---------------------- + drivers/net/ethernet/intel/ice/ice_lib.h | 6 -- + drivers/net/ethernet/intel/ice/ice_xsk.c | 20 +----- + 5 files changed, 82 insertions(+), 100 deletions(-) + +diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c +index 9263754c9525d..d2fd315556a39 100644 +--- a/drivers/net/ethernet/intel/ice/ice_base.c ++++ b/drivers/net/ethernet/intel/ice/ice_base.c +@@ -882,7 +882,7 @@ void ice_vsi_free_q_vectors(struct ice_vsi *vsi) + * @ring: Tx ring to be configured + * @qg_buf: queue group buffer + */ +-int ++static int + ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring, + struct ice_aqc_add_tx_qgrp *qg_buf) + { +@@ -953,6 +953,80 @@ ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring, + return 0; + } + ++int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, ++ u16 q_idx) ++{ ++ DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); ++ ++ if (q_idx >= vsi->alloc_txq || !tx_rings || !tx_rings[q_idx]) ++ return -EINVAL; ++ ++ qg_buf->num_txqs = 1; ++ ++ return ice_vsi_cfg_txq(vsi, tx_rings[q_idx], qg_buf); ++} ++ ++/** ++ * ice_vsi_cfg_txqs - Configure the VSI for Tx ++ * @vsi: the VSI being configured ++ * @rings: Tx ring array to be configured ++ * @count: number of Tx ring array elements ++ * ++ * Return 0 on success and a negative value on error ++ * Configure the Tx VSI for operation. ++ */ ++static int ++ice_vsi_cfg_txqs(struct ice_vsi *vsi, struct ice_tx_ring **rings, u16 count) ++{ ++ DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); ++ int err = 0; ++ u16 q_idx; ++ ++ qg_buf->num_txqs = 1; ++ ++ for (q_idx = 0; q_idx < count; q_idx++) { ++ err = ice_vsi_cfg_txq(vsi, rings[q_idx], qg_buf); ++ if (err) ++ break; ++ } ++ ++ return err; ++} ++ ++/** ++ * ice_vsi_cfg_lan_txqs - Configure the VSI for Tx ++ * @vsi: the VSI being configured ++ * ++ * Return 0 on success and a negative value on error ++ * Configure the Tx VSI for operation. ++ */ ++int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi) ++{ ++ return ice_vsi_cfg_txqs(vsi, vsi->tx_rings, vsi->num_txq); ++} ++ ++/** ++ * ice_vsi_cfg_xdp_txqs - Configure Tx queues dedicated for XDP in given VSI ++ * @vsi: the VSI being configured ++ * ++ * Return 0 on success and a negative value on error ++ * Configure the Tx queues dedicated for XDP in given VSI for operation. ++ */ ++int ice_vsi_cfg_xdp_txqs(struct ice_vsi *vsi) ++{ ++ int ret; ++ int i; ++ ++ ret = ice_vsi_cfg_txqs(vsi, vsi->xdp_rings, vsi->num_xdp_txq); ++ if (ret) ++ return ret; ++ ++ ice_for_each_rxq(vsi, i) ++ ice_tx_xsk_pool(vsi, i); ++ ++ return 0; ++} ++ + /** + * ice_cfg_itr - configure the initial interrupt throttle values + * @hw: pointer to the HW structure +diff --git a/drivers/net/ethernet/intel/ice/ice_base.h b/drivers/net/ethernet/intel/ice/ice_base.h +index 85e6076445602..b711bc921928d 100644 +--- a/drivers/net/ethernet/intel/ice/ice_base.h ++++ b/drivers/net/ethernet/intel/ice/ice_base.h +@@ -15,9 +15,10 @@ int ice_vsi_wait_one_rx_ring(struct ice_vsi *vsi, bool ena, u16 rxq_idx); + int ice_vsi_alloc_q_vectors(struct ice_vsi *vsi); + void ice_vsi_map_rings_to_vectors(struct ice_vsi *vsi); + void ice_vsi_free_q_vectors(struct ice_vsi *vsi); +-int +-ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring, +- struct ice_aqc_add_tx_qgrp *qg_buf); ++int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, ++ u16 q_idx); ++int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi); ++int ice_vsi_cfg_xdp_txqs(struct ice_vsi *vsi); + void ice_cfg_itr(struct ice_hw *hw, struct ice_q_vector *q_vector); + void + ice_cfg_txq_interrupt(struct ice_vsi *vsi, u16 txq, u16 msix_idx, u16 itr_idx); +diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c +index 27b3423c9ff23..15bdf6ef3c099 100644 +--- a/drivers/net/ethernet/intel/ice/ice_lib.c ++++ b/drivers/net/ethernet/intel/ice/ice_lib.c +@@ -1774,79 +1774,6 @@ ice_write_qrxflxp_cntxt(struct ice_hw *hw, u16 pf_q, u32 rxdid, u32 prio, + wr32(hw, QRXFLXP_CNTXT(pf_q), regval); + } + +-int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, u16 q_idx) +-{ +- DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); +- +- if (q_idx >= vsi->alloc_txq || !tx_rings || !tx_rings[q_idx]) +- return -EINVAL; +- +- qg_buf->num_txqs = 1; +- +- return ice_vsi_cfg_txq(vsi, tx_rings[q_idx], qg_buf); +-} +- +-/** +- * ice_vsi_cfg_txqs - Configure the VSI for Tx +- * @vsi: the VSI being configured +- * @rings: Tx ring array to be configured +- * @count: number of Tx ring array elements +- * +- * Return 0 on success and a negative value on error +- * Configure the Tx VSI for operation. +- */ +-static int +-ice_vsi_cfg_txqs(struct ice_vsi *vsi, struct ice_tx_ring **rings, u16 count) +-{ +- DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); +- int err = 0; +- u16 q_idx; +- +- qg_buf->num_txqs = 1; +- +- for (q_idx = 0; q_idx < count; q_idx++) { +- err = ice_vsi_cfg_txq(vsi, rings[q_idx], qg_buf); +- if (err) +- break; +- } +- +- return err; +-} +- +-/** +- * ice_vsi_cfg_lan_txqs - Configure the VSI for Tx +- * @vsi: the VSI being configured +- * +- * Return 0 on success and a negative value on error +- * Configure the Tx VSI for operation. +- */ +-int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi) +-{ +- return ice_vsi_cfg_txqs(vsi, vsi->tx_rings, vsi->num_txq); +-} +- +-/** +- * ice_vsi_cfg_xdp_txqs - Configure Tx queues dedicated for XDP in given VSI +- * @vsi: the VSI being configured +- * +- * Return 0 on success and a negative value on error +- * Configure the Tx queues dedicated for XDP in given VSI for operation. +- */ +-int ice_vsi_cfg_xdp_txqs(struct ice_vsi *vsi) +-{ +- int ret; +- int i; +- +- ret = ice_vsi_cfg_txqs(vsi, vsi->xdp_rings, vsi->num_xdp_txq); +- if (ret) +- return ret; +- +- ice_for_each_rxq(vsi, i) +- ice_tx_xsk_pool(vsi, i); +- +- return 0; +-} +- + /** + * ice_intrl_usec_to_reg - convert interrupt rate limit to register value + * @intrl: interrupt rate limit in usecs +diff --git a/drivers/net/ethernet/intel/ice/ice_lib.h b/drivers/net/ethernet/intel/ice/ice_lib.h +index 95505a501a935..b5a1ed7cc4b17 100644 +--- a/drivers/net/ethernet/intel/ice/ice_lib.h ++++ b/drivers/net/ethernet/intel/ice/ice_lib.h +@@ -54,10 +54,6 @@ bool ice_pf_state_is_nominal(struct ice_pf *pf); + + void ice_update_eth_stats(struct ice_vsi *vsi); + +-int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, u16 q_idx); +- +-int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi); +- + void ice_vsi_cfg_msix(struct ice_vsi *vsi); + + int ice_vsi_start_all_rx_rings(struct ice_vsi *vsi); +@@ -68,8 +64,6 @@ int + ice_vsi_stop_lan_tx_rings(struct ice_vsi *vsi, enum ice_disq_rst_src rst_src, + u16 rel_vmvf_num); + +-int ice_vsi_cfg_xdp_txqs(struct ice_vsi *vsi); +- + int ice_vsi_stop_xdp_tx_rings(struct ice_vsi *vsi); + + void ice_cfg_sw_lldp(struct ice_vsi *vsi, bool tx, bool create); +diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c +index 9e01f410af772..1857220d27fee 100644 +--- a/drivers/net/ethernet/intel/ice/ice_xsk.c ++++ b/drivers/net/ethernet/intel/ice/ice_xsk.c +@@ -218,32 +218,17 @@ static int ice_qp_dis(struct ice_vsi *vsi, u16 q_idx) + */ + static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx) + { +- DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); +- u16 size = __struct_size(qg_buf); + struct ice_q_vector *q_vector; +- struct ice_tx_ring *tx_ring; +- struct ice_rx_ring *rx_ring; + int err; + +- if (q_idx >= vsi->num_rxq || q_idx >= vsi->num_txq) +- return -EINVAL; +- +- qg_buf->num_txqs = 1; +- +- tx_ring = vsi->tx_rings[q_idx]; +- rx_ring = vsi->rx_rings[q_idx]; +- q_vector = rx_ring->q_vector; +- +- err = ice_vsi_cfg_txq(vsi, tx_ring, qg_buf); ++ err = ice_vsi_cfg_single_txq(vsi, vsi->tx_rings, q_idx); + if (err) + return err; + + if (ice_is_xdp_ena_vsi(vsi)) { + struct ice_tx_ring *xdp_ring = vsi->xdp_rings[q_idx]; + +- memset(qg_buf, 0, size); +- qg_buf->num_txqs = 1; +- err = ice_vsi_cfg_txq(vsi, xdp_ring, qg_buf); ++ err = ice_vsi_cfg_single_txq(vsi, vsi->xdp_rings, q_idx); + if (err) + return err; + ice_set_ring_xdp(xdp_ring); +@@ -254,6 +239,7 @@ static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx) + if (err) + return err; + ++ q_vector = vsi->rx_rings[q_idx]->q_vector; + ice_qvec_cfg_msix(vsi, q_vector); + + err = ice_vsi_ctrl_one_rx_ring(vsi, true, q_idx, true); +-- +2.43.0 + diff --git a/queue-6.8/idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch b/queue-6.8/idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch new file mode 100644 index 00000000000..6b07113cfdb --- /dev/null +++ b/queue-6.8/idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch @@ -0,0 +1,53 @@ +From ee0c64df3b188a089ce105749641dfa59f69e234 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 15 May 2024 11:24:14 +0200 +Subject: idpf: don't skip over ethtool tcp-data-split setting + +From: Michal Schmidt + +[ Upstream commit 67708158e732bf03d076fba1e3d4453fbf8292a2 ] + +Disabling tcp-data-split on idpf silently fails: + # ethtool -G $NETDEV tcp-data-split off + # ethtool -g $NETDEV | grep 'TCP data split' + TCP data split: on + +But it works if you also change 'tx' or 'rx': + # ethtool -G $NETDEV tcp-data-split off tx 256 + # ethtool -g $NETDEV | grep 'TCP data split' + TCP data split: off + +The bug is in idpf_set_ringparam, where it takes a shortcut out if the +TX and RX sizes are not changing. Fix it by checking also if the +tcp-data-split setting remains unchanged. Only then can the soft reset +be skipped. + +Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam") +Reported-by: Xu Du +Closes: https://issues.redhat.com/browse/RHEL-36182 +Signed-off-by: Michal Schmidt +Reviewed-by: Alexander Lobakin +Link: https://lore.kernel.org/r/20240515092414.158079-1-mschmidt@redhat.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c +index 986d429d11755..6972d728431cb 100644 +--- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c ++++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c +@@ -376,7 +376,8 @@ static int idpf_set_ringparam(struct net_device *netdev, + new_tx_count); + + if (new_tx_count == vport->txq_desc_count && +- new_rx_count == vport->rxq_desc_count) ++ new_rx_count == vport->rxq_desc_count && ++ kring->tcp_data_split == idpf_vport_get_hsplit(vport)) + goto unlock_mutex; + + if (!idpf_vport_set_hsplit(vport, kring->tcp_data_split)) { +-- +2.43.0 + diff --git a/queue-6.8/input-amimouse-mark-driver-struct-with-__refdata-to-.patch b/queue-6.8/input-amimouse-mark-driver-struct-with-__refdata-to-.patch new file mode 100644 index 00000000000..67a7941a328 --- /dev/null +++ b/queue-6.8/input-amimouse-mark-driver-struct-with-__refdata-to-.patch @@ -0,0 +1,51 @@ +From ff54c87a8f2fb5c4f10e98d3c11a9b0c19c7edc5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 11:46:32 -0700 +Subject: Input: amimouse - mark driver struct with __refdata to prevent + section mismatch +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 0537c8eef4f699aacdeb67c6181c66cccd63c7f5 ] + +As described in the added code comment, a reference to .exit.text is ok +for drivers registered via module_platform_driver_probe(). Make this +explicit to prevent the following section mismatch warning + + WARNING: modpost: drivers/input/mouse/amimouse: section mismatch in reference: amimouse_driver+0x8 (section: .data) -> amimouse_remove (section: .exit.text) + +that triggers on an allmodconfig W=1 build. + +Signed-off-by: Uwe Kleine-König +Link: https://lore.kernel.org/r/2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/mouse/amimouse.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/drivers/input/mouse/amimouse.c b/drivers/input/mouse/amimouse.c +index cda0c3ff5a288..2fbbaeb76d708 100644 +--- a/drivers/input/mouse/amimouse.c ++++ b/drivers/input/mouse/amimouse.c +@@ -132,7 +132,13 @@ static void __exit amimouse_remove(struct platform_device *pdev) + input_unregister_device(dev); + } + +-static struct platform_driver amimouse_driver = { ++/* ++ * amimouse_remove() lives in .exit.text. For drivers registered via ++ * module_platform_driver_probe() this is ok because they cannot get unbound at ++ * runtime. So mark the driver struct with __refdata to prevent modpost ++ * triggering a section mismatch warning. ++ */ ++static struct platform_driver amimouse_driver __refdata = { + .remove_new = __exit_p(amimouse_remove), + .driver = { + .name = "amiga-mouse", +-- +2.43.0 + diff --git a/queue-6.8/input-xpad-add-support-for-asus-rog-raikiri.patch b/queue-6.8/input-xpad-add-support-for-asus-rog-raikiri.patch new file mode 100644 index 00000000000..7c95a218636 --- /dev/null +++ b/queue-6.8/input-xpad-add-support-for-asus-rog-raikiri.patch @@ -0,0 +1,42 @@ +From 6be6d65bb5310d150f5bb0d598157d525bb5ec48 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 20:53:45 -0700 +Subject: Input: xpad - add support for ASUS ROG RAIKIRI + +From: Vicki Pfau + +[ Upstream commit be81415a32ef6d8a8a85529fcfac03d05b3e757d ] + +Add the VID/PID for ASUS ROG RAIKIRI to xpad_device and the VID to xpad_table + +Signed-off-by: Vicki Pfau +Link: https://lore.kernel.org/r/20240404035345.159643-1-vi@endrift.com +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/joystick/xpad.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c +index 1fad51b51b0e1..c2de2f063cb8d 100644 +--- a/drivers/input/joystick/xpad.c ++++ b/drivers/input/joystick/xpad.c +@@ -207,6 +207,7 @@ static const struct xpad_device { + { 0x0738, 0xcb29, "Saitek Aviator Stick AV8R02", 0, XTYPE_XBOX360 }, + { 0x0738, 0xf738, "Super SFIV FightStick TE S", 0, XTYPE_XBOX360 }, + { 0x07ff, 0xffff, "Mad Catz GamePad", 0, XTYPE_XBOX360 }, ++ { 0x0b05, 0x1a38, "ASUS ROG RAIKIRI", 0, XTYPE_XBOXONE }, + { 0x0c12, 0x0005, "Intec wireless", 0, XTYPE_XBOX }, + { 0x0c12, 0x8801, "Nyko Xbox Controller", 0, XTYPE_XBOX }, + { 0x0c12, 0x8802, "Zeroplus Xbox Controller", 0, XTYPE_XBOX }, +@@ -482,6 +483,7 @@ static const struct usb_device_id xpad_table[] = { + { USB_DEVICE(0x0738, 0x4540) }, /* Mad Catz Beat Pad */ + XPAD_XBOXONE_VENDOR(0x0738), /* Mad Catz FightStick TE 2 */ + XPAD_XBOX360_VENDOR(0x07ff), /* Mad Catz Gamepad */ ++ XPAD_XBOXONE_VENDOR(0x0b05), /* ASUS controllers */ + XPAD_XBOX360_VENDOR(0x0c12), /* Zeroplus X-Box 360 controllers */ + XPAD_XBOX360_VENDOR(0x0e6f), /* 0x0e6f Xbox 360 controllers */ + XPAD_XBOXONE_VENDOR(0x0e6f), /* 0x0e6f Xbox One controllers */ +-- +2.43.0 + diff --git a/queue-6.8/io-wq-write-next_work-before-dropping-acct_lock.patch b/queue-6.8/io-wq-write-next_work-before-dropping-acct_lock.patch new file mode 100644 index 00000000000..7b9394a14c6 --- /dev/null +++ b/queue-6.8/io-wq-write-next_work-before-dropping-acct_lock.patch @@ -0,0 +1,76 @@ +From 82d4d4305a30f55f8e74dfdace629e165420d199 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 22:10:53 -0400 +Subject: io-wq: write next_work before dropping acct_lock + +From: Gabriel Krisman Bertazi + +[ Upstream commit 068c27e32e51e94e4a9eb30ae85f4097a3602980 ] + +Commit 361aee450c6e ("io-wq: add intermediate work step between pending +list and active work") closed a race between a cancellation and the work +being removed from the wq for execution. To ensure the request is +always reachable by the cancellation, we need to move it within the wq +lock, which also synchronizes the cancellation. But commit +42abc95f05bf ("io-wq: decouple work_list protection from the big +wqe->lock") replaced the wq lock here and accidentally reintroduced the +race by releasing the acct_lock too early. + +In other words: + + worker | cancellation +work = io_get_next_work() | +raw_spin_unlock(&acct->lock); | + | + | io_acct_cancel_pending_work + | io_wq_worker_cancel() +worker->next_work = work + +Using acct_lock is still enough since we synchronize on it on +io_acct_cancel_pending_work. + +Fixes: 42abc95f05bf ("io-wq: decouple work_list protection from the big wqe->lock") +Signed-off-by: Gabriel Krisman Bertazi +Link: https://lore.kernel.org/r/20240416021054.3940-2-krisman@suse.de +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + io_uring/io-wq.c | 13 ++++++++----- + 1 file changed, 8 insertions(+), 5 deletions(-) + +diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c +index 522196dfb0ff5..318ed067dbf64 100644 +--- a/io_uring/io-wq.c ++++ b/io_uring/io-wq.c +@@ -564,10 +564,7 @@ static void io_worker_handle_work(struct io_wq_acct *acct, + * clear the stalled flag. + */ + work = io_get_next_work(acct, worker); +- raw_spin_unlock(&acct->lock); + if (work) { +- __io_worker_busy(wq, worker); +- + /* + * Make sure cancelation can find this, even before + * it becomes the active work. That avoids a window +@@ -578,9 +575,15 @@ static void io_worker_handle_work(struct io_wq_acct *acct, + raw_spin_lock(&worker->lock); + worker->next_work = work; + raw_spin_unlock(&worker->lock); +- } else { +- break; + } ++ ++ raw_spin_unlock(&acct->lock); ++ ++ if (!work) ++ break; ++ ++ __io_worker_busy(wq, worker); ++ + io_assign_current_work(worker, work); + __set_current_state(TASK_RUNNING); + +-- +2.43.0 + diff --git a/queue-6.8/io_uring-net-ensure-async-prep-handlers-always-initi.patch b/queue-6.8/io_uring-net-ensure-async-prep-handlers-always-initi.patch new file mode 100644 index 00000000000..cacef3e39d8 --- /dev/null +++ b/queue-6.8/io_uring-net-ensure-async-prep-handlers-always-initi.patch @@ -0,0 +1,64 @@ +From dc4905638f68b47c8cd9a9d5294298a16e61e9ff Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 15 Mar 2024 16:36:23 -0600 +Subject: io_uring/net: ensure async prep handlers always initialize ->done_io + +From: Jens Axboe + +[ Upstream commit f3a640cca951ef9715597e68f5363afc0f452a88 ] + +If we get a request with IOSQE_ASYNC set, then we first run the prep +async handlers. But if we then fail setting it up and want to post +a CQE with -EINVAL, we use ->done_io. This was previously guarded with +REQ_F_PARTIAL_IO, and the normal setup handlers do set it up before any +potential errors, but we need to cover the async setup too. + +Fixes: 9817ad85899f ("io_uring/net: remove dependency on REQ_F_PARTIAL_IO for sr->done_io") +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + io_uring/net.c | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/io_uring/net.c b/io_uring/net.c +index 099ab92cca0b7..dbabe0058f1cb 100644 +--- a/io_uring/net.c ++++ b/io_uring/net.c +@@ -311,7 +311,10 @@ int io_send_prep_async(struct io_kiocb *req) + struct io_async_msghdr *io; + int ret; + +- if (!zc->addr || req_has_async_data(req)) ++ if (req_has_async_data(req)) ++ return 0; ++ zc->done_io = 0; ++ if (!zc->addr) + return 0; + io = io_msg_alloc_async_prep(req); + if (!io) +@@ -338,8 +341,10 @@ static int io_setup_async_addr(struct io_kiocb *req, + + int io_sendmsg_prep_async(struct io_kiocb *req) + { ++ struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg); + int ret; + ++ sr->done_io = 0; + if (!io_msg_alloc_async_prep(req)) + return -ENOMEM; + ret = io_sendmsg_copy_hdr(req, req->async_data); +@@ -586,9 +591,11 @@ static int io_recvmsg_copy_hdr(struct io_kiocb *req, + + int io_recvmsg_prep_async(struct io_kiocb *req) + { ++ struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg); + struct io_async_msghdr *iomsg; + int ret; + ++ sr->done_io = 0; + if (!io_msg_alloc_async_prep(req)) + return -ENOMEM; + iomsg = req->async_data; +-- +2.43.0 + diff --git a/queue-6.8/io_uring-net-fix-sendzc-lazy-wake-polling.patch b/queue-6.8/io_uring-net-fix-sendzc-lazy-wake-polling.patch new file mode 100644 index 00000000000..57344d03459 --- /dev/null +++ b/queue-6.8/io_uring-net-fix-sendzc-lazy-wake-polling.patch @@ -0,0 +1,37 @@ +From fc3cda5abb19518c5069a060a31feec44d4b4f81 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 16:42:30 +0100 +Subject: io_uring/net: fix sendzc lazy wake polling + +From: Pavel Begunkov + +[ Upstream commit ef42b85a5609cd822ca0a68dd2bef2b12b5d1ca3 ] + +SEND[MSG]_ZC produces multiple CQEs via notifications, LAZY_WAKE doesn't +handle it and so disable LAZY_WAKE for sendzc polling. It should be +fine, sends are not likely to be polled in the first place. + +Fixes: 6ce4a93dbb5b ("io_uring/poll: use IOU_F_TWQ_LAZY_WAKE for wakeups") +Signed-off-by: Pavel Begunkov +Link: https://lore.kernel.org/r/5b360fb352d91e3aec751d75c87dfb4753a084ee.1714488419.git.asml.silence@gmail.com +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + io_uring/net.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/io_uring/net.c b/io_uring/net.c +index d193b87d0a03b..099ab92cca0b7 100644 +--- a/io_uring/net.c ++++ b/io_uring/net.c +@@ -1022,6 +1022,7 @@ int io_send_zc_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + struct io_kiocb *notif; + + zc->done_io = 0; ++ req->flags |= REQ_F_POLL_NO_LAZY; + + if (unlikely(READ_ONCE(sqe->__pad2[0]) || READ_ONCE(sqe->addr3))) + return -EINVAL; +-- +2.43.0 + diff --git a/queue-6.8/io_uring-net-remove-dependency-on-req_f_partial_io-f.patch b/queue-6.8/io_uring-net-remove-dependency-on-req_f_partial_io-f.patch new file mode 100644 index 00000000000..c6d316b588f --- /dev/null +++ b/queue-6.8/io_uring-net-remove-dependency-on-req_f_partial_io-f.patch @@ -0,0 +1,92 @@ +From 7932d3556b9f048bc597157506f623eaa1215e45 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 12:43:22 -0700 +Subject: io_uring/net: remove dependency on REQ_F_PARTIAL_IO for sr->done_io + +From: Jens Axboe + +[ Upstream commit 9817ad85899fb695f875610fb743cb18cf087582 ] + +Ensure that prep handlers always initialize sr->done_io before any +potential failure conditions, and with that, we now it's always been +set even for the failure case. + +With that, we don't need to use the REQ_F_PARTIAL_IO flag to gate on that. +Additionally, we should not overwrite req->cqe.res unless sr->done_io is +actually positive. + +Signed-off-by: Jens Axboe +Stable-dep-of: ef42b85a5609 ("io_uring/net: fix sendzc lazy wake polling") +Signed-off-by: Sasha Levin +--- + io_uring/net.c | 12 +++++++----- + 1 file changed, 7 insertions(+), 5 deletions(-) + +diff --git a/io_uring/net.c b/io_uring/net.c +index 46ea09e1e3829..d193b87d0a03b 100644 +--- a/io_uring/net.c ++++ b/io_uring/net.c +@@ -359,6 +359,8 @@ int io_sendmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + { + struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg); + ++ sr->done_io = 0; ++ + if (req->opcode == IORING_OP_SEND) { + if (READ_ONCE(sqe->__pad3[0])) + return -EINVAL; +@@ -381,7 +383,6 @@ int io_sendmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + if (req->ctx->compat) + sr->msg_flags |= MSG_CMSG_COMPAT; + #endif +- sr->done_io = 0; + return 0; + } + +@@ -603,6 +604,8 @@ int io_recvmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + { + struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg); + ++ sr->done_io = 0; ++ + if (unlikely(sqe->file_index || sqe->addr2)) + return -EINVAL; + +@@ -639,7 +642,6 @@ int io_recvmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + if (req->ctx->compat) + sr->msg_flags |= MSG_CMSG_COMPAT; + #endif +- sr->done_io = 0; + sr->nr_multishot_loops = 0; + return 0; + } +@@ -1019,6 +1021,8 @@ int io_send_zc_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + struct io_ring_ctx *ctx = req->ctx; + struct io_kiocb *notif; + ++ zc->done_io = 0; ++ + if (unlikely(READ_ONCE(sqe->__pad2[0]) || READ_ONCE(sqe->addr3))) + return -EINVAL; + /* we don't support IOSQE_CQE_SKIP_SUCCESS just yet */ +@@ -1071,8 +1075,6 @@ int io_send_zc_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) + if (zc->msg_flags & MSG_DONTWAIT) + req->flags |= REQ_F_NOWAIT; + +- zc->done_io = 0; +- + #ifdef CONFIG_COMPAT + if (req->ctx->compat) + zc->msg_flags |= MSG_CMSG_COMPAT; +@@ -1318,7 +1320,7 @@ void io_sendrecv_fail(struct io_kiocb *req) + { + struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg); + +- if (req->flags & REQ_F_PARTIAL_IO) ++ if (sr->done_io) + req->cqe.res = sr->done_io; + + if ((req->flags & REQ_F_NEED_CLEANUP) && +-- +2.43.0 + diff --git a/queue-6.8/io_uring-use-the-right-type-for-work_llist-empty-che.patch b/queue-6.8/io_uring-use-the-right-type-for-work_llist-empty-che.patch new file mode 100644 index 00000000000..520f82df438 --- /dev/null +++ b/queue-6.8/io_uring-use-the-right-type-for-work_llist-empty-che.patch @@ -0,0 +1,37 @@ +From 58f1bcaa03a98da7b633b6f8ca0a97a70912cc92 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 25 Mar 2024 18:53:33 -0600 +Subject: io_uring: use the right type for work_llist empty check + +From: Jens Axboe + +[ Upstream commit 22537c9f79417fed70b352d54d01d2586fee9521 ] + +io_task_work_pending() uses wq_list_empty() on ctx->work_llist, but it's +not an io_wq_work_list, it's a struct llist_head. They both have +->first as head-of-list, and it turns out the checks are identical. But +be proper and use the right helper. + +Fixes: dac6a0eae793 ("io_uring: ensure iopoll runs local task work as well") +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + io_uring/io_uring.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h +index d5495710c1787..c0cff024db7b4 100644 +--- a/io_uring/io_uring.h ++++ b/io_uring/io_uring.h +@@ -301,7 +301,7 @@ static inline int io_run_task_work(void) + + static inline bool io_task_work_pending(struct io_ring_ctx *ctx) + { +- return task_work_pending(current) || !wq_list_empty(&ctx->work_llist); ++ return task_work_pending(current) || !llist_empty(&ctx->work_llist); + } + + static inline void io_tw_lock(struct io_ring_ctx *ctx, struct io_tw_state *ts) +-- +2.43.0 + diff --git a/queue-6.8/iommu-undo-pasid-attachment-only-for-the-devices-tha.patch b/queue-6.8/iommu-undo-pasid-attachment-only-for-the-devices-tha.patch new file mode 100644 index 00000000000..7901a700abd --- /dev/null +++ b/queue-6.8/iommu-undo-pasid-attachment-only-for-the-devices-tha.patch @@ -0,0 +1,86 @@ +From db432e3de2a92b9db3db00f776191b6590a01dbe Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 05:29:57 -0700 +Subject: iommu: Undo pasid attachment only for the devices that have succeeded + +From: Yi Liu + +[ Upstream commit b025dea63cded0d82bccd591fa105d39efc6435d ] + +There is no error handling now in __iommu_set_group_pasid(), it relies on +its caller to loop all the devices to undo the pasid attachment. This is +not self-contained and has drawbacks. It would result in unnecessary +remove_dev_pasid() calls on the devices that have not been attached to the +new domain. But the remove_dev_pasid() callback would get the new domain +from the group->pasid_array. So for such devices, the iommu driver won't +find the attachment under the domain, hence unable to do cleanup. This may +not be a real problem today. But it depends on the implementation of the +underlying iommu driver. e.g. the intel iommu driver would warn for such +devices. Such warnings are unnecessary. + +To solve the above problem, it is necessary to handle the error within +__iommu_set_group_pasid(). It only loops the devices that have attached +to the new domain, and undo it. + +Fixes: 16603704559c ("iommu: Add attach/detach_dev_pasid iommu interfaces") +Suggested-by: Jason Gunthorpe +Reviewed-by: Jason Gunthorpe +Reviewed-by: Kevin Tian +Signed-off-by: Yi Liu +Reviewed-by: Lu Baolu +Link: https://lore.kernel.org/r/20240328122958.83332-2-yi.l.liu@intel.com +Signed-off-by: Joerg Roedel +Signed-off-by: Sasha Levin +--- + drivers/iommu/iommu.c | 21 +++++++++++++++------ + 1 file changed, 15 insertions(+), 6 deletions(-) + +diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c +index ad33161f2374b..e606d250d1d55 100644 +--- a/drivers/iommu/iommu.c ++++ b/drivers/iommu/iommu.c +@@ -3510,15 +3510,26 @@ EXPORT_SYMBOL_GPL(iommu_group_dma_owner_claimed); + static int __iommu_set_group_pasid(struct iommu_domain *domain, + struct iommu_group *group, ioasid_t pasid) + { +- struct group_device *device; +- int ret = 0; ++ struct group_device *device, *last_gdev; ++ int ret; + + for_each_group_device(group, device) { + ret = domain->ops->set_dev_pasid(domain, device->dev, pasid); + if (ret) +- break; ++ goto err_revert; + } + ++ return 0; ++ ++err_revert: ++ last_gdev = device; ++ for_each_group_device(group, device) { ++ const struct iommu_ops *ops = dev_iommu_ops(device->dev); ++ ++ if (device == last_gdev) ++ break; ++ ops->remove_dev_pasid(device->dev, pasid); ++ } + return ret; + } + +@@ -3576,10 +3587,8 @@ int iommu_attach_device_pasid(struct iommu_domain *domain, + } + + ret = __iommu_set_group_pasid(domain, group, pasid); +- if (ret) { +- __iommu_remove_group_pasid(group, pasid); ++ if (ret) + xa_erase(&group->pasid_array, pasid); +- } + out_unlock: + mutex_unlock(&group->mutex); + return ret; +-- +2.43.0 + diff --git a/queue-6.8/ipv6-sr-add-missing-seg6_local_exit.patch b/queue-6.8/ipv6-sr-add-missing-seg6_local_exit.patch new file mode 100644 index 00000000000..e5a34dd5268 --- /dev/null +++ b/queue-6.8/ipv6-sr-add-missing-seg6_local_exit.patch @@ -0,0 +1,38 @@ +From 5afbcef623684e76460c613875e0f2f6aacfebf6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 21:18:10 +0800 +Subject: ipv6: sr: add missing seg6_local_exit + +From: Hangbin Liu + +[ Upstream commit 3321687e321307629c71b664225b861ebf3e5753 ] + +Currently, we only call seg6_local_exit() in seg6_init() if +seg6_local_init() failed. But forgot to call it in seg6_exit(). + +Fixes: d1df6fd8a1d2 ("ipv6: sr: define core operations for seg6local lightweight tunnel") +Signed-off-by: Hangbin Liu +Reviewed-by: Sabrina Dubroca +Reviewed-by: David Ahern +Link: https://lore.kernel.org/r/20240509131812.1662197-2-liuhangbin@gmail.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ipv6/seg6.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c +index 35508abd76f43..5423f1f2aa626 100644 +--- a/net/ipv6/seg6.c ++++ b/net/ipv6/seg6.c +@@ -564,6 +564,7 @@ void seg6_exit(void) + seg6_hmac_exit(); + #endif + #ifdef CONFIG_IPV6_SEG6_LWTUNNEL ++ seg6_local_exit(); + seg6_iptunnel_exit(); + #endif + unregister_pernet_subsys(&ip6_segments_ops); +-- +2.43.0 + diff --git a/queue-6.8/ipv6-sr-fix-incorrect-unregister-order.patch b/queue-6.8/ipv6-sr-fix-incorrect-unregister-order.patch new file mode 100644 index 00000000000..3ddafcc376c --- /dev/null +++ b/queue-6.8/ipv6-sr-fix-incorrect-unregister-order.patch @@ -0,0 +1,39 @@ +From 2f3bcf44e23baa2cbb44fd96317920e95594714e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 21:18:11 +0800 +Subject: ipv6: sr: fix incorrect unregister order + +From: Hangbin Liu + +[ Upstream commit 6e370a771d2985107e82d0f6174381c1acb49c20 ] + +Commit 5559cea2d5aa ("ipv6: sr: fix possible use-after-free and +null-ptr-deref") changed the register order in seg6_init(). But the +unregister order in seg6_exit() is not updated. + +Fixes: 5559cea2d5aa ("ipv6: sr: fix possible use-after-free and null-ptr-deref") +Signed-off-by: Hangbin Liu +Reviewed-by: Sabrina Dubroca +Reviewed-by: David Ahern +Link: https://lore.kernel.org/r/20240509131812.1662197-3-liuhangbin@gmail.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ipv6/seg6.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c +index 5423f1f2aa626..c4ef96c8fdaca 100644 +--- a/net/ipv6/seg6.c ++++ b/net/ipv6/seg6.c +@@ -567,6 +567,6 @@ void seg6_exit(void) + seg6_local_exit(); + seg6_iptunnel_exit(); + #endif +- unregister_pernet_subsys(&ip6_segments_ops); + genl_unregister_family(&seg6_genl_family); ++ unregister_pernet_subsys(&ip6_segments_ops); + } +-- +2.43.0 + diff --git a/queue-6.8/ipv6-sr-fix-invalid-unregister-error-path.patch b/queue-6.8/ipv6-sr-fix-invalid-unregister-error-path.patch new file mode 100644 index 00000000000..dbe2b2be64f --- /dev/null +++ b/queue-6.8/ipv6-sr-fix-invalid-unregister-error-path.patch @@ -0,0 +1,46 @@ +From 178efe373c6ba7af0fddf7365f39330c2d053e25 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 21:18:12 +0800 +Subject: ipv6: sr: fix invalid unregister error path + +From: Hangbin Liu + +[ Upstream commit 160e9d2752181fcf18c662e74022d77d3164cd45 ] + +The error path of seg6_init() is wrong in case CONFIG_IPV6_SEG6_LWTUNNEL +is not defined. In that case if seg6_hmac_init() fails, the +genl_unregister_family() isn't called. + +This issue exist since commit 46738b1317e1 ("ipv6: sr: add option to control +lwtunnel support"), and commit 5559cea2d5aa ("ipv6: sr: fix possible +use-after-free and null-ptr-deref") replaced unregister_pernet_subsys() +with genl_unregister_family() in this error path. + +Fixes: 46738b1317e1 ("ipv6: sr: add option to control lwtunnel support") +Reported-by: Guillaume Nault +Signed-off-by: Hangbin Liu +Reviewed-by: Sabrina Dubroca +Reviewed-by: David Ahern +Link: https://lore.kernel.org/r/20240509131812.1662197-4-liuhangbin@gmail.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ipv6/seg6.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c +index c4ef96c8fdaca..a31521e270f78 100644 +--- a/net/ipv6/seg6.c ++++ b/net/ipv6/seg6.c +@@ -551,6 +551,8 @@ int __init seg6_init(void) + #endif + #ifdef CONFIG_IPV6_SEG6_LWTUNNEL + out_unregister_genl: ++#endif ++#if IS_ENABLED(CONFIG_IPV6_SEG6_LWTUNNEL) || IS_ENABLED(CONFIG_IPV6_SEG6_HMAC) + genl_unregister_family(&seg6_genl_family); + #endif + out_unregister_pernet: +-- +2.43.0 + diff --git a/queue-6.8/irqchip-alpine-msi-fix-off-by-one-in-allocation-erro.patch b/queue-6.8/irqchip-alpine-msi-fix-off-by-one-in-allocation-erro.patch new file mode 100644 index 00000000000..ec0ebb8bb77 --- /dev/null +++ b/queue-6.8/irqchip-alpine-msi-fix-off-by-one-in-allocation-erro.patch @@ -0,0 +1,40 @@ +From 6577f98a5ad8123a34e0801ff611572beb7e75e7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 22:23:05 +0800 +Subject: irqchip/alpine-msi: Fix off-by-one in allocation error path + +From: Zenghui Yu + +[ Upstream commit ff3669a71afa06208de58d6bea1cc49d5e3fcbd1 ] + +When alpine_msix_gic_domain_alloc() fails, there is an off-by-one in the +number of interrupts to be freed. + +Fix it by passing the number of successfully allocated interrupts, instead +of the relative index of the last allocated one. + +Fixes: 3841245e8498 ("irqchip/alpine-msi: Fix freeing of interrupts on allocation error path") +Signed-off-by: Zenghui Yu +Signed-off-by: Thomas Gleixner +Link: https://lore.kernel.org/r/20240327142305.1048-1-yuzenghui@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/irqchip/irq-alpine-msi.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c +index 9c8b1349ee17b..a1430ab60a8a3 100644 +--- a/drivers/irqchip/irq-alpine-msi.c ++++ b/drivers/irqchip/irq-alpine-msi.c +@@ -165,7 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain, + return 0; + + err_sgi: +- irq_domain_free_irqs_parent(domain, virq, i - 1); ++ irq_domain_free_irqs_parent(domain, virq, i); + alpine_msix_free_sgi(priv, sgi, nr_irqs); + return err; + } +-- +2.43.0 + diff --git a/queue-6.8/irqchip-loongson-pch-msi-fix-off-by-one-on-allocatio.patch b/queue-6.8/irqchip-loongson-pch-msi-fix-off-by-one-on-allocatio.patch new file mode 100644 index 00000000000..38dae85cbb9 --- /dev/null +++ b/queue-6.8/irqchip-loongson-pch-msi-fix-off-by-one-on-allocatio.patch @@ -0,0 +1,41 @@ +From d9ac1b0cf396788eb6e76f54183eabea76b9ac1d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 22:23:34 +0800 +Subject: irqchip/loongson-pch-msi: Fix off-by-one on allocation error path + +From: Zenghui Yu + +[ Upstream commit b327708798809328f21da8dc14cc8883d1e8a4b3 ] + +When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one +in the number of interrupts to be freed. + +Fix it by passing the number of successfully allocated interrupts, instead of the +relative index of the last allocated one. + +Fixes: 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller") +Signed-off-by: Zenghui Yu +Signed-off-by: Thomas Gleixner +Reviewed-by: Jiaxun Yang +Link: https://lore.kernel.org/r/20240327142334.1098-1-yuzenghui@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/irqchip/irq-loongson-pch-msi.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c +index 6e1e1f011bb29..dd4d699170f4e 100644 +--- a/drivers/irqchip/irq-loongson-pch-msi.c ++++ b/drivers/irqchip/irq-loongson-pch-msi.c +@@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain, + + err_hwirq: + pch_msi_free_hwirq(priv, hwirq, nr_irqs); +- irq_domain_free_irqs_parent(domain, virq, i - 1); ++ irq_domain_free_irqs_parent(domain, virq, i); + + return err; + } +-- +2.43.0 + diff --git a/queue-6.8/jffs2-prevent-xattr-node-from-overflowing-the-eraseb.patch b/queue-6.8/jffs2-prevent-xattr-node-from-overflowing-the-eraseb.patch new file mode 100644 index 00000000000..a364e3500ca --- /dev/null +++ b/queue-6.8/jffs2-prevent-xattr-node-from-overflowing-the-eraseb.patch @@ -0,0 +1,81 @@ +From 48ec4386e6a394f9ed7b719dceda137a8f2498eb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 18:53:54 +0300 +Subject: jffs2: prevent xattr node from overflowing the eraseblock + +From: Ilya Denisyev + +[ Upstream commit c6854e5a267c28300ff045480b5a7ee7f6f1d913 ] + +Add a check to make sure that the requested xattr node size is no larger +than the eraseblock minus the cleanmarker. + +Unlike the usual inode nodes, the xattr nodes aren't split into parts +and spread across multiple eraseblocks, which means that a xattr node +must not occupy more than one eraseblock. If the requested xattr value is +too large, the xattr node can spill onto the next eraseblock, overwriting +the nodes and causing errors such as: + +jffs2: argh. node added in wrong place at 0x0000b050(2) +jffs2: nextblock 0x0000a000, expected at 0000b00c +jffs2: error: (823) do_verify_xattr_datum: node CRC failed at 0x01e050, +read=0xfc892c93, calc=0x000000 +jffs2: notice: (823) jffs2_get_inode_nodes: Node header CRC failed +at 0x01e00c. {848f,2fc4,0fef511f,59a3d171} +jffs2: Node at 0x0000000c with length 0x00001044 would run over the +end of the erase block +jffs2: Perhaps the file system was created with the wrong erase size? +jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found +at 0x00000010: 0x1044 instead + +This breaks the filesystem and can lead to KASAN crashes such as: + +BUG: KASAN: slab-out-of-bounds in jffs2_sum_add_kvec+0x125e/0x15d0 +Read of size 4 at addr ffff88802c31e914 by task repro/830 +CPU: 0 PID: 830 Comm: repro Not tainted 6.9.0-rc3+ #1 +Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), +BIOS Arch Linux 1.16.3-1-1 04/01/2014 +Call Trace: + + dump_stack_lvl+0xc6/0x120 + print_report+0xc4/0x620 + ? __virt_addr_valid+0x308/0x5b0 + kasan_report+0xc1/0xf0 + ? jffs2_sum_add_kvec+0x125e/0x15d0 + ? jffs2_sum_add_kvec+0x125e/0x15d0 + jffs2_sum_add_kvec+0x125e/0x15d0 + jffs2_flash_direct_writev+0xa8/0xd0 + jffs2_flash_writev+0x9c9/0xef0 + ? __x64_sys_setxattr+0xc4/0x160 + ? do_syscall_64+0x69/0x140 + ? entry_SYSCALL_64_after_hwframe+0x76/0x7e + [...] + +Found by Linux Verification Center (linuxtesting.org) with Syzkaller. + +Fixes: aa98d7cf59b5 ("[JFFS2][XATTR] XATTR support on JFFS2 (version. 5)") +Signed-off-by: Ilya Denisyev +Link: https://lore.kernel.org/r/20240412155357.237803-1-dev@elkcl.ru +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/jffs2/xattr.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c +index 00224f3a8d6e7..defb4162c3d5b 100644 +--- a/fs/jffs2/xattr.c ++++ b/fs/jffs2/xattr.c +@@ -1110,6 +1110,9 @@ int do_jffs2_setxattr(struct inode *inode, int xprefix, const char *xname, + return rc; + + request = PAD(sizeof(struct jffs2_raw_xattr) + strlen(xname) + 1 + size); ++ if (request > c->sector_size - c->cleanmarker_size) ++ return -ERANGE; ++ + rc = jffs2_reserve_space(c, request, &length, + ALLOC_NORMAL, JFFS2_SUMMARY_XATTR_SIZE); + if (rc) { +-- +2.43.0 + diff --git a/queue-6.8/kunit-bail-out-early-in-__kunit_test_suites_init-if-.patch b/queue-6.8/kunit-bail-out-early-in-__kunit_test_suites_init-if-.patch new file mode 100644 index 00000000000..e5c6cef3ed9 --- /dev/null +++ b/queue-6.8/kunit-bail-out-early-in-__kunit_test_suites_init-if-.patch @@ -0,0 +1,47 @@ +From c6d41d736820d60c7bc1df7c59551a85d667a2ad Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 21 Mar 2024 10:32:00 -0400 +Subject: kunit: bail out early in __kunit_test_suites_init() if there are no + suites to test + +From: Scott Mayhew + +[ Upstream commit 5496b9b77d7420652202b73cf036e69760be5deb ] + +Commit c72a870926c2 added a mutex to prevent kunit tests from running +concurrently. Unfortunately that mutex gets locked during module load +regardless of whether the module actually has any kunit tests. This +causes a problem for kunit tests that might need to load other kernel +modules (e.g. gss_krb5_test loading the camellia module). + +So check to see if there are actually any tests to run before locking +the kunit_run_lock mutex. + +Fixes: c72a870926c2 ("kunit: add ability to run tests after boot using debugfs") +Reported-by: Nico Pache +Signed-off-by: Scott Mayhew +Reviewed-by: Rae Moar +Reviewed-by: David Gow +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + lib/kunit/test.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/lib/kunit/test.c b/lib/kunit/test.c +index 1d1475578515c..b8514dbb337c0 100644 +--- a/lib/kunit/test.c ++++ b/lib/kunit/test.c +@@ -712,6 +712,9 @@ int __kunit_test_suites_init(struct kunit_suite * const * const suites, int num_ + { + unsigned int i; + ++ if (num_suites == 0) ++ return 0; ++ + if (!kunit_enabled() && num_suites > 0) { + pr_info("kunit: disabled\n"); + return 0; +-- +2.43.0 + diff --git a/queue-6.8/kunit-fix-kthread-reference.patch b/queue-6.8/kunit-fix-kthread-reference.patch new file mode 100644 index 00000000000..657177e4a23 --- /dev/null +++ b/queue-6.8/kunit-fix-kthread-reference.patch @@ -0,0 +1,70 @@ +From d4dfc4d2e8887b54de8f3ecdec6ceaf3d96dc2f9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 09:46:20 +0200 +Subject: kunit: Fix kthread reference +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Mickaël Salaün + +[ Upstream commit f8aa1b98ce40184521ed95ec26cc115a255183b2 ] + +There is a race condition when a kthread finishes after the deadline and +before the call to kthread_stop(), which may lead to use after free. + +Cc: Brendan Higgins +Cc: Shuah Khan +Reviewed-by: Kees Cook +Fixes: adf505457032 ("kunit: fix UAF when run kfence test case test_gfpzero") +Reviewed-by: David Gow +Reviewed-by: Rae Moar +Signed-off-by: Mickaël Salaün +Link: https://lore.kernel.org/r/20240408074625.65017-3-mic@digikod.net +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + lib/kunit/try-catch.c | 9 ++++++--- + 1 file changed, 6 insertions(+), 3 deletions(-) + +diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c +index f7825991d576a..d9d1df28cc52e 100644 +--- a/lib/kunit/try-catch.c ++++ b/lib/kunit/try-catch.c +@@ -11,6 +11,7 @@ + #include + #include + #include ++#include + + #include "try-catch-impl.h" + +@@ -65,13 +66,14 @@ void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) + try_catch->context = context; + try_catch->try_completion = &try_completion; + try_catch->try_result = 0; +- task_struct = kthread_run(kunit_generic_run_threadfn_adapter, +- try_catch, +- "kunit_try_catch_thread"); ++ task_struct = kthread_create(kunit_generic_run_threadfn_adapter, ++ try_catch, "kunit_try_catch_thread"); + if (IS_ERR(task_struct)) { + try_catch->catch(try_catch->context); + return; + } ++ get_task_struct(task_struct); ++ wake_up_process(task_struct); + + time_remaining = wait_for_completion_timeout(&try_completion, + kunit_test_timeout()); +@@ -81,6 +83,7 @@ void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) + kthread_stop(task_struct); + } + ++ put_task_struct(task_struct); + exit_code = try_catch->try_result; + + if (!exit_code) +-- +2.43.0 + diff --git a/queue-6.8/kunit-fortify-fix-mismatched-kvalloc-vfree-usage.patch b/queue-6.8/kunit-fortify-fix-mismatched-kvalloc-vfree-usage.patch new file mode 100644 index 00000000000..6c1bebbd46b --- /dev/null +++ b/queue-6.8/kunit-fortify-fix-mismatched-kvalloc-vfree-usage.patch @@ -0,0 +1,64 @@ +From 332e6619f0a926d2f0937df1a7b3e80173bdfe02 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 16:06:22 -0700 +Subject: kunit/fortify: Fix mismatched kvalloc()/vfree() usage + +From: Kees Cook + +[ Upstream commit 998b18072ceb0613629c256b409f4d299829c7ec ] + +The kv*() family of tests were accidentally freeing with vfree() instead +of kvfree(). Use kvfree() instead. + +Fixes: 9124a2640148 ("kunit/fortify: Validate __alloc_size attribute results") +Link: https://lore.kernel.org/r/20240425230619.work.299-kees@kernel.org +Signed-off-by: Kees Cook +Signed-off-by: Sasha Levin +--- + lib/fortify_kunit.c | 16 ++++++++-------- + 1 file changed, 8 insertions(+), 8 deletions(-) + +diff --git a/lib/fortify_kunit.c b/lib/fortify_kunit.c +index 2e4fedc816210..7830a9e64ead7 100644 +--- a/lib/fortify_kunit.c ++++ b/lib/fortify_kunit.c +@@ -229,28 +229,28 @@ DEFINE_ALLOC_SIZE_TEST_PAIR(vmalloc) + \ + checker((expected_pages) * PAGE_SIZE, \ + kvmalloc((alloc_pages) * PAGE_SIZE, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvmalloc_node((alloc_pages) * PAGE_SIZE, gfp, NUMA_NO_NODE), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvzalloc((alloc_pages) * PAGE_SIZE, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvzalloc_node((alloc_pages) * PAGE_SIZE, gfp, NUMA_NO_NODE), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvcalloc(1, (alloc_pages) * PAGE_SIZE, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvcalloc((alloc_pages) * PAGE_SIZE, 1, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvmalloc_array(1, (alloc_pages) * PAGE_SIZE, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + checker((expected_pages) * PAGE_SIZE, \ + kvmalloc_array((alloc_pages) * PAGE_SIZE, 1, gfp), \ +- vfree(p)); \ ++ kvfree(p)); \ + \ + prev_size = (expected_pages) * PAGE_SIZE; \ + orig = kvmalloc(prev_size, gfp); \ +-- +2.43.0 + diff --git a/queue-6.8/kunit-unregister-the-device-on-error.patch b/queue-6.8/kunit-unregister-the-device-on-error.patch new file mode 100644 index 00000000000..b916a103336 --- /dev/null +++ b/queue-6.8/kunit-unregister-the-device-on-error.patch @@ -0,0 +1,39 @@ +From afc4a1e599c0c5fd8788b5ad9ab59b5c67bfed5d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 19 Apr 2024 10:25:01 -0300 +Subject: kunit: unregister the device on error + +From: Wander Lairson Costa + +[ Upstream commit fabd480b721eb30aa4e2c89507b53933069f9f6e ] + +kunit_init_device() should unregister the device on bus register error, +but mistakenly it tries to unregister the bus. + +Unregister the device instead of the bus. + +Signed-off-by: Wander Lairson Costa +Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") +Reviewed-by: Greg Kroah-Hartman +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + lib/kunit/device.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/lib/kunit/device.c b/lib/kunit/device.c +index 9ea399049749e..3a31fe9ed6fc5 100644 +--- a/lib/kunit/device.c ++++ b/lib/kunit/device.c +@@ -51,7 +51,7 @@ int kunit_bus_init(void) + + error = bus_register(&kunit_bus_type); + if (error) +- bus_unregister(&kunit_bus_type); ++ root_device_unregister(kunit_bus_device); + return error; + } + +-- +2.43.0 + diff --git a/queue-6.8/kvm-selftests-add-test-for-uaccesses-to-non-existent.patch b/queue-6.8/kvm-selftests-add-test-for-uaccesses-to-non-existent.patch new file mode 100644 index 00000000000..a915f361cfc --- /dev/null +++ b/queue-6.8/kvm-selftests-add-test-for-uaccesses-to-non-existent.patch @@ -0,0 +1,102 @@ +From 2e2af2e022ddb586d0a368ccb49dc25b2f901c0e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 17:39:59 +0000 +Subject: KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF + +From: Oliver Upton + +[ Upstream commit 160933e330f4c5a13931d725a4d952a4b9aefa71 ] + +Assert that accesses to a non-existent vgic-v2 CPU interface +consistently fail across the various KVM device attr ioctls. This also +serves as a regression test for a bug wherein KVM hits a NULL +dereference when the CPUID specified in the ioctl is invalid. + +Note that there is no need to print the observed errno, as TEST_ASSERT() +will take care of it. + +Reviewed-by: Marc Zyngier +Link: https://lore.kernel.org/r/20240424173959.3776798-3-oliver.upton@linux.dev +Signed-off-by: Oliver Upton +Signed-off-by: Sasha Levin +--- + .../testing/selftests/kvm/aarch64/vgic_init.c | 49 +++++++++++++++++++ + 1 file changed, 49 insertions(+) + +diff --git a/tools/testing/selftests/kvm/aarch64/vgic_init.c b/tools/testing/selftests/kvm/aarch64/vgic_init.c +index eef816b80993f..ca917c71ff602 100644 +--- a/tools/testing/selftests/kvm/aarch64/vgic_init.c ++++ b/tools/testing/selftests/kvm/aarch64/vgic_init.c +@@ -84,6 +84,18 @@ static struct vm_gic vm_gic_create_with_vcpus(uint32_t gic_dev_type, + return v; + } + ++static struct vm_gic vm_gic_create_barebones(uint32_t gic_dev_type) ++{ ++ struct vm_gic v; ++ ++ v.gic_dev_type = gic_dev_type; ++ v.vm = vm_create_barebones(); ++ v.gic_fd = kvm_create_device(v.vm, gic_dev_type); ++ ++ return v; ++} ++ ++ + static void vm_gic_destroy(struct vm_gic *v) + { + close(v->gic_fd); +@@ -357,6 +369,40 @@ static void test_vcpus_then_vgic(uint32_t gic_dev_type) + vm_gic_destroy(&v); + } + ++#define KVM_VGIC_V2_ATTR(offset, cpu) \ ++ (FIELD_PREP(KVM_DEV_ARM_VGIC_OFFSET_MASK, offset) | \ ++ FIELD_PREP(KVM_DEV_ARM_VGIC_CPUID_MASK, cpu)) ++ ++#define GIC_CPU_CTRL 0x00 ++ ++static void test_v2_uaccess_cpuif_no_vcpus(void) ++{ ++ struct vm_gic v; ++ u64 val = 0; ++ int ret; ++ ++ v = vm_gic_create_barebones(KVM_DEV_TYPE_ARM_VGIC_V2); ++ subtest_dist_rdist(&v); ++ ++ ret = __kvm_has_device_attr(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_CPU_REGS, ++ KVM_VGIC_V2_ATTR(GIC_CPU_CTRL, 0)); ++ TEST_ASSERT(ret && errno == EINVAL, ++ "accessed non-existent CPU interface, want errno: %i", ++ EINVAL); ++ ret = __kvm_device_attr_get(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_CPU_REGS, ++ KVM_VGIC_V2_ATTR(GIC_CPU_CTRL, 0), &val); ++ TEST_ASSERT(ret && errno == EINVAL, ++ "accessed non-existent CPU interface, want errno: %i", ++ EINVAL); ++ ret = __kvm_device_attr_set(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_CPU_REGS, ++ KVM_VGIC_V2_ATTR(GIC_CPU_CTRL, 0), &val); ++ TEST_ASSERT(ret && errno == EINVAL, ++ "accessed non-existent CPU interface, want errno: %i", ++ EINVAL); ++ ++ vm_gic_destroy(&v); ++} ++ + static void test_v3_new_redist_regions(void) + { + struct kvm_vcpu *vcpus[NR_VCPUS]; +@@ -675,6 +721,9 @@ void run_tests(uint32_t gic_dev_type) + test_vcpus_then_vgic(gic_dev_type); + test_vgic_then_vcpus(gic_dev_type); + ++ if (VGIC_DEV_IS_V2(gic_dev_type)) ++ test_v2_uaccess_cpuif_no_vcpus(); ++ + if (VGIC_DEV_IS_V3(gic_dev_type)) { + test_v3_new_redist_regions(); + test_v3_typer_accesses(); +-- +2.43.0 + diff --git a/queue-6.8/l2tp-fix-icmp-error-handling-for-udp-encap-sockets.patch b/queue-6.8/l2tp-fix-icmp-error-handling-for-udp-encap-sockets.patch new file mode 100644 index 00000000000..5796b854ecc --- /dev/null +++ b/queue-6.8/l2tp-fix-icmp-error-handling-for-udp-encap-sockets.patch @@ -0,0 +1,133 @@ +From 5813bb65e2b1f0135f527ffbecda448c733737df Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 18:22:47 +0100 +Subject: l2tp: fix ICMP error handling for UDP-encap sockets + +From: Tom Parkin + +[ Upstream commit 6e828dc60e509b79ef09882264952f341cb58425 ] + +Since commit a36e185e8c85 +("udp: Handle ICMP errors for tunnels with same destination port on both endpoints") +UDP's handling of ICMP errors has allowed for UDP-encap tunnels to +determine socket associations in scenarios where the UDP hash lookup +could not. + +Subsequently, commit d26796ae58940 +("udp: check udp sock encap_type in __udp_lib_err") +subtly tweaked the approach such that UDP ICMP error handling would be +skipped for any UDP socket which has encapsulation enabled. + +In the case of L2TP tunnel sockets using UDP-encap, this latter +modification effectively broke ICMP error reporting for the L2TP +control plane. + +To a degree this isn't catastrophic inasmuch as the L2TP control +protocol defines a reliable transport on top of the underlying packet +switching network which will eventually detect errors and time out. + +However, paying attention to the ICMP error reporting allows for more +timely detection of errors in L2TP userspace, and aids in debugging +connectivity issues. + +Reinstate ICMP error handling for UDP encap L2TP tunnels: + + * implement struct udp_tunnel_sock_cfg .encap_err_rcv in order to allow + the L2TP code to handle ICMP errors; + + * only implement error-handling for tunnels which have a managed + socket: unmanaged tunnels using a kernel socket have no userspace to + report errors back to; + + * flag the error on the socket, which allows for userspace to get an + error such as -ECONNREFUSED back from sendmsg/recvmsg; + + * pass the error into ip[v6]_icmp_error() which allows for userspace to + get extended error information via. MSG_ERRQUEUE. + +Fixes: d26796ae5894 ("udp: check udp sock encap_type in __udp_lib_err") +Signed-off-by: Tom Parkin +Link: https://lore.kernel.org/r/20240513172248.623261-1-tparkin@katalix.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/l2tp/l2tp_core.c | 44 +++++++++++++++++++++++++++++++++----------- + 1 file changed, 33 insertions(+), 11 deletions(-) + +diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c +index 8d21ff25f1602..4a0fb8731eee9 100644 +--- a/net/l2tp/l2tp_core.c ++++ b/net/l2tp/l2tp_core.c +@@ -887,22 +887,20 @@ static int l2tp_udp_recv_core(struct l2tp_tunnel *tunnel, struct sk_buff *skb) + return 1; + } + +-/* UDP encapsulation receive handler. See net/ipv4/udp.c. +- * Return codes: +- * 0 : success. +- * <0: error +- * >0: skb should be passed up to userspace as UDP. ++/* UDP encapsulation receive and error receive handlers. ++ * See net/ipv4/udp.c for details. ++ * ++ * Note that these functions are called from inside an ++ * RCU-protected region, but without the socket being locked. ++ * ++ * Hence we use rcu_dereference_sk_user_data to access the ++ * tunnel data structure rather the usual l2tp_sk_to_tunnel ++ * accessor function. + */ + int l2tp_udp_encap_recv(struct sock *sk, struct sk_buff *skb) + { + struct l2tp_tunnel *tunnel; + +- /* Note that this is called from the encap_rcv hook inside an +- * RCU-protected region, but without the socket being locked. +- * Hence we use rcu_dereference_sk_user_data to access the +- * tunnel data structure rather the usual l2tp_sk_to_tunnel +- * accessor function. +- */ + tunnel = rcu_dereference_sk_user_data(sk); + if (!tunnel) + goto pass_up; +@@ -919,6 +917,29 @@ int l2tp_udp_encap_recv(struct sock *sk, struct sk_buff *skb) + } + EXPORT_SYMBOL_GPL(l2tp_udp_encap_recv); + ++static void l2tp_udp_encap_err_recv(struct sock *sk, struct sk_buff *skb, int err, ++ __be16 port, u32 info, u8 *payload) ++{ ++ struct l2tp_tunnel *tunnel; ++ ++ tunnel = rcu_dereference_sk_user_data(sk); ++ if (!tunnel || tunnel->fd < 0) ++ return; ++ ++ sk->sk_err = err; ++ sk_error_report(sk); ++ ++ if (ip_hdr(skb)->version == IPVERSION) { ++ if (inet_test_bit(RECVERR, sk)) ++ return ip_icmp_error(sk, skb, err, port, info, payload); ++#if IS_ENABLED(CONFIG_IPV6) ++ } else { ++ if (inet6_test_bit(RECVERR6, sk)) ++ return ipv6_icmp_error(sk, skb, err, port, info, payload); ++#endif ++ } ++} ++ + /************************************************************************ + * Transmit handling + ***********************************************************************/ +@@ -1493,6 +1514,7 @@ int l2tp_tunnel_register(struct l2tp_tunnel *tunnel, struct net *net, + .sk_user_data = tunnel, + .encap_type = UDP_ENCAP_L2TPINUDP, + .encap_rcv = l2tp_udp_encap_recv, ++ .encap_err_rcv = l2tp_udp_encap_err_recv, + .encap_destroy = l2tp_udp_encap_destroy, + }; + +-- +2.43.0 + diff --git a/queue-6.8/lib-test_hmm.c-handle-src_pfns-and-dst_pfns-allocati.patch b/queue-6.8/lib-test_hmm.c-handle-src_pfns-and-dst_pfns-allocati.patch new file mode 100644 index 00000000000..b5fe188c586 --- /dev/null +++ b/queue-6.8/lib-test_hmm.c-handle-src_pfns-and-dst_pfns-allocati.patch @@ -0,0 +1,62 @@ +From 92712564ab7fdccc93c1fe1f99907876a5c183d1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 12 Mar 2024 08:59:05 +0800 +Subject: lib/test_hmm.c: handle src_pfns and dst_pfns allocation failure +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Duoming Zhou + +[ Upstream commit c2af060d1c18beaec56351cf9c9bcbbc5af341a3 ] + +The kcalloc() in dmirror_device_evict_chunk() will return null if the +physical memory has run out. As a result, if src_pfns or dst_pfns is +dereferenced, the null pointer dereference bug will happen. + +Moreover, the device is going away. If the kcalloc() fails, the pages +mapping a chunk could not be evicted. So add a __GFP_NOFAIL flag in +kcalloc(). + +Finally, as there is no need to have physically contiguous memory, Switch +kcalloc() to kvcalloc() in order to avoid failing allocations. + +Link: https://lkml.kernel.org/r/20240312005905.9939-1-duoming@zju.edu.cn +Fixes: b2ef9f5a5cb3 ("mm/hmm/test: add selftest driver for HMM") +Signed-off-by: Duoming Zhou +Cc: Jérôme Glisse +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + lib/test_hmm.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/lib/test_hmm.c b/lib/test_hmm.c +index 717dcb8301273..b823ba7cb6a15 100644 +--- a/lib/test_hmm.c ++++ b/lib/test_hmm.c +@@ -1226,8 +1226,8 @@ static void dmirror_device_evict_chunk(struct dmirror_chunk *chunk) + unsigned long *src_pfns; + unsigned long *dst_pfns; + +- src_pfns = kcalloc(npages, sizeof(*src_pfns), GFP_KERNEL); +- dst_pfns = kcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL); ++ src_pfns = kvcalloc(npages, sizeof(*src_pfns), GFP_KERNEL | __GFP_NOFAIL); ++ dst_pfns = kvcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL | __GFP_NOFAIL); + + migrate_device_range(src_pfns, start_pfn, npages); + for (i = 0; i < npages; i++) { +@@ -1250,8 +1250,8 @@ static void dmirror_device_evict_chunk(struct dmirror_chunk *chunk) + } + migrate_device_pages(src_pfns, dst_pfns, npages); + migrate_device_finalize(src_pfns, dst_pfns, npages); +- kfree(src_pfns); +- kfree(dst_pfns); ++ kvfree(src_pfns); ++ kvfree(dst_pfns); + } + + /* Removes free pages from the free list so they can't be re-allocated */ +-- +2.43.0 + diff --git a/queue-6.8/libbpf-fix-error-message-in-attach_kprobe_multi.patch b/queue-6.8/libbpf-fix-error-message-in-attach_kprobe_multi.patch new file mode 100644 index 00000000000..95431e5fbfb --- /dev/null +++ b/queue-6.8/libbpf-fix-error-message-in-attach_kprobe_multi.patch @@ -0,0 +1,37 @@ +From 187fb95062a166f34702cc2522debd37bd01fe3f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 09:55:41 +0200 +Subject: libbpf: Fix error message in attach_kprobe_multi + +From: Jiri Olsa + +[ Upstream commit 7c13ef16e87ac2e44d16c0468b1191bceb06f95c ] + +We just failed to retrieve pattern, so we need to print spec instead. + +Fixes: ddc6b04989eb ("libbpf: Add bpf_program__attach_kprobe_multi_opts function") +Reported-by: Andrii Nakryiko +Signed-off-by: Jiri Olsa +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/20240502075541.1425761-2-jolsa@kernel.org +Signed-off-by: Sasha Levin +--- + tools/lib/bpf/libbpf.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c +index 5af9cab422ca3..028d8f014c871 100644 +--- a/tools/lib/bpf/libbpf.c ++++ b/tools/lib/bpf/libbpf.c +@@ -11561,7 +11561,7 @@ static int attach_kprobe_multi(const struct bpf_program *prog, long cookie, stru + + n = sscanf(spec, "%m[a-zA-Z0-9_.*?]", &pattern); + if (n < 1) { +- pr_warn("kprobe multi pattern is invalid: %s\n", pattern); ++ pr_warn("kprobe multi pattern is invalid: %s\n", spec); + return -EINVAL; + } + +-- +2.43.0 + diff --git a/queue-6.8/libbpf-prevent-null-pointer-dereference-when-prog-to.patch b/queue-6.8/libbpf-prevent-null-pointer-dereference-when-prog-to.patch new file mode 100644 index 00000000000..9b3bc4433ec --- /dev/null +++ b/queue-6.8/libbpf-prevent-null-pointer-dereference-when-prog-to.patch @@ -0,0 +1,57 @@ +From 6149a8ab763e36efd64659422698faa0b7138350 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 14 Mar 2024 15:04:38 +0000 +Subject: libbpf: Prevent null-pointer dereference when prog to load has no BTF + +From: Quentin Monnet + +[ Upstream commit 9bf48fa19a4b1d186e08b20bf7e5de26a15644fb ] + +In bpf_objec_load_prog(), there's no guarantee that obj->btf is non-NULL +when passing it to btf__fd(), and this function does not perform any +check before dereferencing its argument (as bpf_object__btf_fd() used to +do). As a consequence, we get segmentation fault errors in bpftool (for +example) when trying to load programs that come without BTF information. + +v2: Keep btf__fd() in the fix instead of reverting to bpf_object__btf_fd(). + +Fixes: df7c3f7d3a3d ("libbpf: make uniform use of btf__fd() accessor inside libbpf") +Suggested-by: Andrii Nakryiko +Signed-off-by: Quentin Monnet +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/20240314150438.232462-1-qmo@kernel.org +Signed-off-by: Sasha Levin +--- + tools/lib/bpf/libbpf.c | 7 +++---- + 1 file changed, 3 insertions(+), 4 deletions(-) + +diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c +index 92bca96587a4a..5af9cab422ca3 100644 +--- a/tools/lib/bpf/libbpf.c ++++ b/tools/lib/bpf/libbpf.c +@@ -7456,9 +7456,9 @@ static int bpf_object_load_prog(struct bpf_object *obj, struct bpf_program *prog + char *cp, errmsg[STRERR_BUFSIZE]; + size_t log_buf_size = 0; + char *log_buf = NULL, *tmp; +- int btf_fd, ret, err; + bool own_log_buf = true; + __u32 log_level = prog->log_level; ++ int ret, err; + + if (prog->type == BPF_PROG_TYPE_UNSPEC) { + /* +@@ -7482,9 +7482,8 @@ static int bpf_object_load_prog(struct bpf_object *obj, struct bpf_program *prog + load_attr.prog_ifindex = prog->prog_ifindex; + + /* specify func_info/line_info only if kernel supports them */ +- btf_fd = btf__fd(obj->btf); +- if (btf_fd >= 0 && kernel_supports(obj, FEAT_BTF_FUNC)) { +- load_attr.prog_btf_fd = btf_fd; ++ if (obj->btf && btf__fd(obj->btf) >= 0 && kernel_supports(obj, FEAT_BTF_FUNC)) { ++ load_attr.prog_btf_fd = btf__fd(obj->btf); + load_attr.func_info = prog->func_info; + load_attr.func_info_rec_size = prog->func_info_rec_size; + load_attr.func_info_cnt = prog->func_info_cnt; +-- +2.43.0 + diff --git a/queue-6.8/libfs-add-simple_offset_empty.patch b/queue-6.8/libfs-add-simple_offset_empty.patch new file mode 100644 index 00000000000..338b53c225e --- /dev/null +++ b/queue-6.8/libfs-add-simple_offset_empty.patch @@ -0,0 +1,111 @@ +From 824d0b650c0d71b16138bc9f37a142d0589706e7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 17 Feb 2024 15:23:54 -0500 +Subject: libfs: Add simple_offset_empty() + +From: Chuck Lever + +[ Upstream commit ecba88a3b32d733d41e27973e25b2bc580f64281 ] + +For simple filesystems that use directory offset mapping, rely +strictly on the directory offset map to tell when a directory has +no children. + +After this patch is applied, the emptiness test holds only the RCU +read lock when the directory being tested has no children. + +In addition, this adds another layer of confirmation that +simple_offset_add/remove() are working as expected. + +Reviewed-by: Jan Kara +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/170820143463.6328.7872919188371286951.stgit@91.116.238.104.host.secureserver.net +Signed-off-by: Christian Brauner +Stable-dep-of: 23cdd0eed3f1 ("libfs: Fix simple_offset_rename_exchange()") +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 32 ++++++++++++++++++++++++++++++++ + include/linux/fs.h | 1 + + mm/shmem.c | 4 ++-- + 3 files changed, 35 insertions(+), 2 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index f0045db739df8..f7f92a49a4182 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -313,6 +313,38 @@ void simple_offset_remove(struct offset_ctx *octx, struct dentry *dentry) + offset_set(dentry, 0); + } + ++/** ++ * simple_offset_empty - Check if a dentry can be unlinked ++ * @dentry: dentry to be tested ++ * ++ * Returns 0 if @dentry is a non-empty directory; otherwise returns 1. ++ */ ++int simple_offset_empty(struct dentry *dentry) ++{ ++ struct inode *inode = d_inode(dentry); ++ struct offset_ctx *octx; ++ struct dentry *child; ++ unsigned long index; ++ int ret = 1; ++ ++ if (!inode || !S_ISDIR(inode->i_mode)) ++ return ret; ++ ++ index = DIR_OFFSET_MIN; ++ octx = inode->i_op->get_offset_ctx(inode); ++ xa_for_each(&octx->xa, index, child) { ++ spin_lock(&child->d_lock); ++ if (simple_positive(child)) { ++ spin_unlock(&child->d_lock); ++ ret = 0; ++ break; ++ } ++ spin_unlock(&child->d_lock); ++ } ++ ++ return ret; ++} ++ + /** + * simple_offset_rename_exchange - exchange rename with directory offsets + * @old_dir: parent of dentry being moved +diff --git a/include/linux/fs.h b/include/linux/fs.h +index 08ecac9d7b8ba..e684b9fa64819 100644 +--- a/include/linux/fs.h ++++ b/include/linux/fs.h +@@ -3266,6 +3266,7 @@ struct offset_ctx { + void simple_offset_init(struct offset_ctx *octx); + int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry); + void simple_offset_remove(struct offset_ctx *octx, struct dentry *dentry); ++int simple_offset_empty(struct dentry *dentry); + int simple_offset_rename_exchange(struct inode *old_dir, + struct dentry *old_dentry, + struct inode *new_dir, +diff --git a/mm/shmem.c b/mm/shmem.c +index 5853f3ae36e53..0e951fe9f44cc 100644 +--- a/mm/shmem.c ++++ b/mm/shmem.c +@@ -3368,7 +3368,7 @@ static int shmem_unlink(struct inode *dir, struct dentry *dentry) + + static int shmem_rmdir(struct inode *dir, struct dentry *dentry) + { +- if (!simple_empty(dentry)) ++ if (!simple_offset_empty(dentry)) + return -ENOTEMPTY; + + drop_nlink(d_inode(dentry)); +@@ -3425,7 +3425,7 @@ static int shmem_rename2(struct mnt_idmap *idmap, + return simple_offset_rename_exchange(old_dir, old_dentry, + new_dir, new_dentry); + +- if (!simple_empty(new_dentry)) ++ if (!simple_offset_empty(new_dentry)) + return -ENOTEMPTY; + + if (flags & RENAME_WHITEOUT) { +-- +2.43.0 + diff --git a/queue-6.8/libfs-add-simple_offset_rename-api.patch b/queue-6.8/libfs-add-simple_offset_rename-api.patch new file mode 100644 index 00000000000..9e7a4a09034 --- /dev/null +++ b/queue-6.8/libfs-add-simple_offset_rename-api.patch @@ -0,0 +1,85 @@ +From effb4b859c783a81290bb81f3776659afda37745 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 11:20:55 -0400 +Subject: libfs: Add simple_offset_rename() API + +From: Chuck Lever + +[ Upstream commit 5a1a25be995e1014abd01600479915683e356f5c ] + +I'm about to fix a tmpfs rename bug that requires the use of +internal simple_offset helpers that are not available in mm/shmem.c + +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/20240415152057.4605-3-cel@kernel.org +Signed-off-by: Christian Brauner +Stable-dep-of: ad191eb6d694 ("shmem: Fix shmem_rename2()") +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 21 +++++++++++++++++++++ + include/linux/fs.h | 2 ++ + mm/shmem.c | 3 +-- + 3 files changed, 24 insertions(+), 2 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index c9516f3e14bb7..bb6731fa63059 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -356,6 +356,27 @@ int simple_offset_empty(struct dentry *dentry) + return ret; + } + ++/** ++ * simple_offset_rename - handle directory offsets for rename ++ * @old_dir: parent directory of source entry ++ * @old_dentry: dentry of source entry ++ * @new_dir: parent_directory of destination entry ++ * @new_dentry: dentry of destination ++ * ++ * Caller provides appropriate serialization. ++ * ++ * Returns zero on success, a negative errno value on failure. ++ */ ++int simple_offset_rename(struct inode *old_dir, struct dentry *old_dentry, ++ struct inode *new_dir, struct dentry *new_dentry) ++{ ++ struct offset_ctx *old_ctx = old_dir->i_op->get_offset_ctx(old_dir); ++ struct offset_ctx *new_ctx = new_dir->i_op->get_offset_ctx(new_dir); ++ ++ simple_offset_remove(old_ctx, old_dentry); ++ return simple_offset_add(new_ctx, old_dentry); ++} ++ + /** + * simple_offset_rename_exchange - exchange rename with directory offsets + * @old_dir: parent of dentry being moved +diff --git a/include/linux/fs.h b/include/linux/fs.h +index 3350f875ca91c..10e32c8ef1e9c 100644 +--- a/include/linux/fs.h ++++ b/include/linux/fs.h +@@ -3268,6 +3268,8 @@ void simple_offset_init(struct offset_ctx *octx); + int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry); + void simple_offset_remove(struct offset_ctx *octx, struct dentry *dentry); + int simple_offset_empty(struct dentry *dentry); ++int simple_offset_rename(struct inode *old_dir, struct dentry *old_dentry, ++ struct inode *new_dir, struct dentry *new_dentry); + int simple_offset_rename_exchange(struct inode *old_dir, + struct dentry *old_dentry, + struct inode *new_dir, +diff --git a/mm/shmem.c b/mm/shmem.c +index 0e951fe9f44cc..935f3647bb3a1 100644 +--- a/mm/shmem.c ++++ b/mm/shmem.c +@@ -3434,8 +3434,7 @@ static int shmem_rename2(struct mnt_idmap *idmap, + return error; + } + +- simple_offset_remove(shmem_get_offset_ctx(old_dir), old_dentry); +- error = simple_offset_add(shmem_get_offset_ctx(new_dir), old_dentry); ++ error = simple_offset_rename(old_dir, old_dentry, new_dir, new_dentry); + if (error) + return error; + +-- +2.43.0 + diff --git a/queue-6.8/libfs-convert-simple-directory-offsets-to-use-a-mapl.patch b/queue-6.8/libfs-convert-simple-directory-offsets-to-use-a-mapl.patch new file mode 100644 index 00000000000..860fbcb6c0c --- /dev/null +++ b/queue-6.8/libfs-convert-simple-directory-offsets-to-use-a-mapl.patch @@ -0,0 +1,220 @@ +From 057d0ecaed534310f4cc2e37a8a1646c68c70a07 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 17 Feb 2024 15:24:16 -0500 +Subject: libfs: Convert simple directory offsets to use a Maple Tree + +From: Chuck Lever + +[ Upstream commit 0e4a862174f2a8d1653a8a9cf0815020e1d3af24 ] + +Test robot reports: +> kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_sec on: +> +> commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable directory offsets") +> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master + +Feng Tang further clarifies that: +> ... the new simple_offset_add() +> called by shmem_mknod() brings extra cost related with slab, +> specifically the 'radix_tree_node', which cause the regression. + +Willy's analysis is that, over time, the test workload causes +xa_alloc_cyclic() to fragment the underlying SLAB cache. + +This patch replaces the offset_ctx's xarray with a Maple Tree in the +hope that Maple Tree's dense node mode will handle this scenario +more scalably. + +In addition, we can widen the simple directory offset maximum to +signed long (as loff_t is also signed). + +Suggested-by: Matthew Wilcox +Reported-by: kernel test robot +Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.sang@intel.com +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/170820145616.6328.12620992971699079156.stgit@91.116.238.104.host.secureserver.net +Reviewed-by: Jan Kara +Signed-off-by: Christian Brauner +Stable-dep-of: 23cdd0eed3f1 ("libfs: Fix simple_offset_rename_exchange()") +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 47 +++++++++++++++++++++++----------------------- + include/linux/fs.h | 5 +++-- + 2 files changed, 26 insertions(+), 26 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index f7f92a49a4182..d3d31197c8e43 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -245,17 +245,17 @@ enum { + DIR_OFFSET_MIN = 2, + }; + +-static void offset_set(struct dentry *dentry, u32 offset) ++static void offset_set(struct dentry *dentry, long offset) + { +- dentry->d_fsdata = (void *)((uintptr_t)(offset)); ++ dentry->d_fsdata = (void *)offset; + } + +-static u32 dentry2offset(struct dentry *dentry) ++static long dentry2offset(struct dentry *dentry) + { +- return (u32)((uintptr_t)(dentry->d_fsdata)); ++ return (long)dentry->d_fsdata; + } + +-static struct lock_class_key simple_offset_xa_lock; ++static struct lock_class_key simple_offset_lock_class; + + /** + * simple_offset_init - initialize an offset_ctx +@@ -264,8 +264,8 @@ static struct lock_class_key simple_offset_xa_lock; + */ + void simple_offset_init(struct offset_ctx *octx) + { +- xa_init_flags(&octx->xa, XA_FLAGS_ALLOC1); +- lockdep_set_class(&octx->xa.xa_lock, &simple_offset_xa_lock); ++ mt_init_flags(&octx->mt, MT_FLAGS_ALLOC_RANGE); ++ lockdep_set_class(&octx->mt.ma_lock, &simple_offset_lock_class); + octx->next_offset = DIR_OFFSET_MIN; + } + +@@ -274,20 +274,19 @@ void simple_offset_init(struct offset_ctx *octx) + * @octx: directory offset ctx to be updated + * @dentry: new dentry being added + * +- * Returns zero on success. @so_ctx and the dentry offset are updated. ++ * Returns zero on success. @octx and the dentry's offset are updated. + * Otherwise, a negative errno value is returned. + */ + int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) + { +- static const struct xa_limit limit = XA_LIMIT(DIR_OFFSET_MIN, U32_MAX); +- u32 offset; ++ unsigned long offset; + int ret; + + if (dentry2offset(dentry) != 0) + return -EBUSY; + +- ret = xa_alloc_cyclic(&octx->xa, &offset, dentry, limit, +- &octx->next_offset, GFP_KERNEL); ++ ret = mtree_alloc_cyclic(&octx->mt, &offset, dentry, DIR_OFFSET_MIN, ++ LONG_MAX, &octx->next_offset, GFP_KERNEL); + if (ret < 0) + return ret; + +@@ -303,13 +302,13 @@ int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) + */ + void simple_offset_remove(struct offset_ctx *octx, struct dentry *dentry) + { +- u32 offset; ++ long offset; + + offset = dentry2offset(dentry); + if (offset == 0) + return; + +- xa_erase(&octx->xa, offset); ++ mtree_erase(&octx->mt, offset); + offset_set(dentry, 0); + } + +@@ -332,7 +331,7 @@ int simple_offset_empty(struct dentry *dentry) + + index = DIR_OFFSET_MIN; + octx = inode->i_op->get_offset_ctx(inode); +- xa_for_each(&octx->xa, index, child) { ++ mt_for_each(&octx->mt, child, index, LONG_MAX) { + spin_lock(&child->d_lock); + if (simple_positive(child)) { + spin_unlock(&child->d_lock); +@@ -362,8 +361,8 @@ int simple_offset_rename_exchange(struct inode *old_dir, + { + struct offset_ctx *old_ctx = old_dir->i_op->get_offset_ctx(old_dir); + struct offset_ctx *new_ctx = new_dir->i_op->get_offset_ctx(new_dir); +- u32 old_index = dentry2offset(old_dentry); +- u32 new_index = dentry2offset(new_dentry); ++ long old_index = dentry2offset(old_dentry); ++ long new_index = dentry2offset(new_dentry); + int ret; + + simple_offset_remove(old_ctx, old_dentry); +@@ -389,9 +388,9 @@ int simple_offset_rename_exchange(struct inode *old_dir, + + out_restore: + offset_set(old_dentry, old_index); +- xa_store(&old_ctx->xa, old_index, old_dentry, GFP_KERNEL); ++ mtree_store(&old_ctx->mt, old_index, old_dentry, GFP_KERNEL); + offset_set(new_dentry, new_index); +- xa_store(&new_ctx->xa, new_index, new_dentry, GFP_KERNEL); ++ mtree_store(&new_ctx->mt, new_index, new_dentry, GFP_KERNEL); + return ret; + } + +@@ -404,7 +403,7 @@ int simple_offset_rename_exchange(struct inode *old_dir, + */ + void simple_offset_destroy(struct offset_ctx *octx) + { +- xa_destroy(&octx->xa); ++ mtree_destroy(&octx->mt); + } + + /** +@@ -434,16 +433,16 @@ static loff_t offset_dir_llseek(struct file *file, loff_t offset, int whence) + + /* In this case, ->private_data is protected by f_pos_lock */ + file->private_data = NULL; +- return vfs_setpos(file, offset, U32_MAX); ++ return vfs_setpos(file, offset, LONG_MAX); + } + + static struct dentry *offset_find_next(struct offset_ctx *octx, loff_t offset) + { ++ MA_STATE(mas, &octx->mt, offset, offset); + struct dentry *child, *found = NULL; +- XA_STATE(xas, &octx->xa, offset); + + rcu_read_lock(); +- child = xas_next_entry(&xas, U32_MAX); ++ child = mas_find(&mas, LONG_MAX); + if (!child) + goto out; + spin_lock(&child->d_lock); +@@ -457,8 +456,8 @@ static struct dentry *offset_find_next(struct offset_ctx *octx, loff_t offset) + + static bool offset_dir_emit(struct dir_context *ctx, struct dentry *dentry) + { +- u32 offset = dentry2offset(dentry); + struct inode *inode = d_inode(dentry); ++ long offset = dentry2offset(dentry); + + return ctx->actor(ctx, dentry->d_name.name, dentry->d_name.len, offset, + inode->i_ino, fs_umode_to_dtype(inode->i_mode)); +diff --git a/include/linux/fs.h b/include/linux/fs.h +index e684b9fa64819..3350f875ca91c 100644 +--- a/include/linux/fs.h ++++ b/include/linux/fs.h +@@ -43,6 +43,7 @@ + #include + #include + #include ++#include + + #include + #include +@@ -3259,8 +3260,8 @@ extern ssize_t simple_write_to_buffer(void *to, size_t available, loff_t *ppos, + const void __user *from, size_t count); + + struct offset_ctx { +- struct xarray xa; +- u32 next_offset; ++ struct maple_tree mt; ++ unsigned long next_offset; + }; + + void simple_offset_init(struct offset_ctx *octx); +-- +2.43.0 + diff --git a/queue-6.8/libfs-define-a-minimum-directory-offset.patch b/queue-6.8/libfs-define-a-minimum-directory-offset.patch new file mode 100644 index 00000000000..8041cc316a4 --- /dev/null +++ b/queue-6.8/libfs-define-a-minimum-directory-offset.patch @@ -0,0 +1,70 @@ +From 8efb0e5921d1e230ea84fad54a733132a1425b5d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 17 Feb 2024 15:23:47 -0500 +Subject: libfs: Define a minimum directory offset + +From: Chuck Lever + +[ Upstream commit 7beea725a8ca412c6190090ce7c3a13b169592a1 ] + +This value is used in several places, so make it a symbolic +constant. + +Reviewed-by: Jan Kara +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/170820142741.6328.12428356024575347885.stgit@91.116.238.104.host.secureserver.net +Signed-off-by: Christian Brauner +Stable-dep-of: 23cdd0eed3f1 ("libfs: Fix simple_offset_rename_exchange()") +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 13 ++++++++----- + 1 file changed, 8 insertions(+), 5 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index 752e24c669d97..f0045db739df8 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -240,6 +240,11 @@ const struct inode_operations simple_dir_inode_operations = { + }; + EXPORT_SYMBOL(simple_dir_inode_operations); + ++/* 0 is '.', 1 is '..', so always start with offset 2 or more */ ++enum { ++ DIR_OFFSET_MIN = 2, ++}; ++ + static void offset_set(struct dentry *dentry, u32 offset) + { + dentry->d_fsdata = (void *)((uintptr_t)(offset)); +@@ -261,9 +266,7 @@ void simple_offset_init(struct offset_ctx *octx) + { + xa_init_flags(&octx->xa, XA_FLAGS_ALLOC1); + lockdep_set_class(&octx->xa.xa_lock, &simple_offset_xa_lock); +- +- /* 0 is '.', 1 is '..', so always start with offset 2 */ +- octx->next_offset = 2; ++ octx->next_offset = DIR_OFFSET_MIN; + } + + /** +@@ -276,7 +279,7 @@ void simple_offset_init(struct offset_ctx *octx) + */ + int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) + { +- static const struct xa_limit limit = XA_LIMIT(2, U32_MAX); ++ static const struct xa_limit limit = XA_LIMIT(DIR_OFFSET_MIN, U32_MAX); + u32 offset; + int ret; + +@@ -481,7 +484,7 @@ static int offset_readdir(struct file *file, struct dir_context *ctx) + return 0; + + /* In this case, ->private_data is protected by f_pos_lock */ +- if (ctx->pos == 2) ++ if (ctx->pos == DIR_OFFSET_MIN) + file->private_data = NULL; + else if (file->private_data == ERR_PTR(-ENOENT)) + return 0; +-- +2.43.0 + diff --git a/queue-6.8/libfs-fix-simple_offset_rename_exchange.patch b/queue-6.8/libfs-fix-simple_offset_rename_exchange.patch new file mode 100644 index 00000000000..6be4773fde1 --- /dev/null +++ b/queue-6.8/libfs-fix-simple_offset_rename_exchange.patch @@ -0,0 +1,85 @@ +From 8fa66426898f17fc3eaad8929df6a62cff9b4088 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 11:20:54 -0400 +Subject: libfs: Fix simple_offset_rename_exchange() + +From: Chuck Lever + +[ Upstream commit 23cdd0eed3f1fff3af323092b0b88945a7950d8e ] + +User space expects the replacement (old) directory entry to have +the same directory offset after the rename. + +Suggested-by: Christian Brauner +Fixes: a2e459555c5f ("shmem: stable directory offsets") +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/20240415152057.4605-2-cel@kernel.org +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 25 +++++++++++++++++++------ + 1 file changed, 19 insertions(+), 6 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index d3d31197c8e43..c9516f3e14bb7 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -294,6 +294,18 @@ int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) + return 0; + } + ++static int simple_offset_replace(struct offset_ctx *octx, struct dentry *dentry, ++ long offset) ++{ ++ int ret; ++ ++ ret = mtree_store(&octx->mt, offset, dentry, GFP_KERNEL); ++ if (ret) ++ return ret; ++ offset_set(dentry, offset); ++ return 0; ++} ++ + /** + * simple_offset_remove - Remove an entry to a directory's offset map + * @octx: directory offset ctx to be updated +@@ -351,6 +363,9 @@ int simple_offset_empty(struct dentry *dentry) + * @new_dir: destination parent + * @new_dentry: destination dentry + * ++ * This API preserves the directory offset values. Caller provides ++ * appropriate serialization. ++ * + * Returns zero on success. Otherwise a negative errno is returned and the + * rename is rolled back. + */ +@@ -368,11 +383,11 @@ int simple_offset_rename_exchange(struct inode *old_dir, + simple_offset_remove(old_ctx, old_dentry); + simple_offset_remove(new_ctx, new_dentry); + +- ret = simple_offset_add(new_ctx, old_dentry); ++ ret = simple_offset_replace(new_ctx, old_dentry, new_index); + if (ret) + goto out_restore; + +- ret = simple_offset_add(old_ctx, new_dentry); ++ ret = simple_offset_replace(old_ctx, new_dentry, old_index); + if (ret) { + simple_offset_remove(new_ctx, old_dentry); + goto out_restore; +@@ -387,10 +402,8 @@ int simple_offset_rename_exchange(struct inode *old_dir, + return 0; + + out_restore: +- offset_set(old_dentry, old_index); +- mtree_store(&old_ctx->mt, old_index, old_dentry, GFP_KERNEL); +- offset_set(new_dentry, new_index); +- mtree_store(&new_ctx->mt, new_index, new_dentry, GFP_KERNEL); ++ (void)simple_offset_replace(old_ctx, old_dentry, old_index); ++ (void)simple_offset_replace(new_ctx, new_dentry, new_index); + return ret; + } + +-- +2.43.0 + diff --git a/queue-6.8/libfs-re-arrange-locking-in-offset_iterate_dir.patch b/queue-6.8/libfs-re-arrange-locking-in-offset_iterate_dir.patch new file mode 100644 index 00000000000..e3f368164af --- /dev/null +++ b/queue-6.8/libfs-re-arrange-locking-in-offset_iterate_dir.patch @@ -0,0 +1,87 @@ +From 673aacfd7b960e934a2b13faf44919196a584271 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 17 Feb 2024 15:23:40 -0500 +Subject: libfs: Re-arrange locking in offset_iterate_dir() + +From: Chuck Lever + +[ Upstream commit 3f6d810665dfde0d33785420618ceb03fba0619d ] + +Liam and Matthew say that once the RCU read lock is released, +xa_state is not safe to re-use for the next xas_find() call. But the +RCU read lock must be released on each loop iteration so that +dput(), which might_sleep(), can be called safely. + +Thus we are forced to walk the offset tree with fresh state for each +directory entry. xa_find() can do this for us, though it might be a +little less efficient than maintaining xa_state locally. + +We believe that in the current code base, inode->i_rwsem provides +protection for the xa_state maintained in +offset_iterate_dir(). However, there is no guarantee that will +continue to be the case in the future. + +Since offset_iterate_dir() doesn't build xa_state locally any more, +there's no longer a strong need for offset_find_next(). Clean up by +rolling these two helpers together. + +Suggested-by: Liam R. Howlett +Message-ID: <170785993027.11135.8830043889278631735.stgit@91.116.238.104.host.secureserver.net> +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/170820142021.6328.15047865406275957018.stgit@91.116.238.104.host.secureserver.net +Reviewed-by: Jan Kara +Signed-off-by: Christian Brauner +Stable-dep-of: 23cdd0eed3f1 ("libfs: Fix simple_offset_rename_exchange()") +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/fs/libfs.c b/fs/libfs.c +index eec6031b01554..752e24c669d97 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -402,12 +402,13 @@ static loff_t offset_dir_llseek(struct file *file, loff_t offset, int whence) + return vfs_setpos(file, offset, U32_MAX); + } + +-static struct dentry *offset_find_next(struct xa_state *xas) ++static struct dentry *offset_find_next(struct offset_ctx *octx, loff_t offset) + { + struct dentry *child, *found = NULL; ++ XA_STATE(xas, &octx->xa, offset); + + rcu_read_lock(); +- child = xas_next_entry(xas, U32_MAX); ++ child = xas_next_entry(&xas, U32_MAX); + if (!child) + goto out; + spin_lock(&child->d_lock); +@@ -430,12 +431,11 @@ static bool offset_dir_emit(struct dir_context *ctx, struct dentry *dentry) + + static void *offset_iterate_dir(struct inode *inode, struct dir_context *ctx) + { +- struct offset_ctx *so_ctx = inode->i_op->get_offset_ctx(inode); +- XA_STATE(xas, &so_ctx->xa, ctx->pos); ++ struct offset_ctx *octx = inode->i_op->get_offset_ctx(inode); + struct dentry *dentry; + + while (true) { +- dentry = offset_find_next(&xas); ++ dentry = offset_find_next(octx, ctx->pos); + if (!dentry) + return ERR_PTR(-ENOENT); + +@@ -444,8 +444,8 @@ static void *offset_iterate_dir(struct inode *inode, struct dir_context *ctx) + break; + } + ++ ctx->pos = dentry2offset(dentry) + 1; + dput(dentry); +- ctx->pos = xas.xa_index + 1; + } + return NULL; + } +-- +2.43.0 + diff --git a/queue-6.8/lkdtm-disable-cfi-checking-for-perms-functions.patch b/queue-6.8/lkdtm-disable-cfi-checking-for-perms-functions.patch new file mode 100644 index 00000000000..9fdfa167ac6 --- /dev/null +++ b/queue-6.8/lkdtm-disable-cfi-checking-for-perms-functions.patch @@ -0,0 +1,59 @@ +From eace5175461d907141039df3c83e4a5833731fee Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 16:49:57 -0700 +Subject: lkdtm: Disable CFI checking for perms functions + +From: Kees Cook + +[ Upstream commit fb28a8862dc4b5bf8e44578338f35d9c6c68339d ] + +The EXEC_RODATA test plays a lot of tricks to live in the .rodata section, +and once again ran into objtool's (completely reasonable) assumptions +that executable code should live in an executable section. However, this +manifested only under CONFIG_CFI_CLANG=y, as one of the .cfi_sites was +pointing into the .rodata section. + +Since we're testing non-CFI execution properties in perms.c (and +rodata.c), we can disable CFI for the involved functions, and remove the +CFI arguments from rodata.c entirely. + +Reported-by: kernel test robot +Closes: https://lore.kernel.org/oe-lkp/202308301532.d7acf63e-oliver.sang@intel.com +Fixes: 6342a20efbd8 ("objtool: Add elf_create_section_pair()") +Link: https://lore.kernel.org/r/20240430234953.work.760-kees@kernel.org +Signed-off-by: Kees Cook +Signed-off-by: Sasha Levin +--- + drivers/misc/lkdtm/Makefile | 2 +- + drivers/misc/lkdtm/perms.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/misc/lkdtm/Makefile b/drivers/misc/lkdtm/Makefile +index 95ef971b5e1cb..b28701138b4bc 100644 +--- a/drivers/misc/lkdtm/Makefile ++++ b/drivers/misc/lkdtm/Makefile +@@ -19,7 +19,7 @@ KASAN_SANITIZE_rodata.o := n + KCSAN_SANITIZE_rodata.o := n + KCOV_INSTRUMENT_rodata.o := n + OBJECT_FILES_NON_STANDARD_rodata.o := y +-CFLAGS_REMOVE_rodata.o += $(CC_FLAGS_LTO) $(RETHUNK_CFLAGS) ++CFLAGS_REMOVE_rodata.o += $(CC_FLAGS_LTO) $(RETHUNK_CFLAGS) $(CC_FLAGS_CFI) + + OBJCOPYFLAGS := + OBJCOPYFLAGS_rodata_objcopy.o := \ +diff --git a/drivers/misc/lkdtm/perms.c b/drivers/misc/lkdtm/perms.c +index b93404d656509..5b861dbff27e9 100644 +--- a/drivers/misc/lkdtm/perms.c ++++ b/drivers/misc/lkdtm/perms.c +@@ -61,7 +61,7 @@ static void *setup_function_descriptor(func_desc_t *fdesc, void *dst) + return fdesc; + } + +-static noinline void execute_location(void *dst, bool write) ++static noinline __nocfi void execute_location(void *dst, bool write) + { + void (*func)(void); + func_desc_t fdesc; +-- +2.43.0 + diff --git a/queue-6.8/locking-atomic-x86-correct-the-definition-of-__arch_.patch b/queue-6.8/locking-atomic-x86-correct-the-definition-of-__arch_.patch new file mode 100644 index 00000000000..a68ead516af --- /dev/null +++ b/queue-6.8/locking-atomic-x86-correct-the-definition-of-__arch_.patch @@ -0,0 +1,40 @@ +From 750b3d322682c4d4783b9f9d9c681d34182879a1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 11:13:56 +0200 +Subject: locking/atomic/x86: Correct the definition of __arch_try_cmpxchg128() + +From: Uros Bizjak + +[ Upstream commit 929ad065ba2967be238dfdc0895b79fda62c7f16 ] + +Correct the definition of __arch_try_cmpxchg128(), introduced by: + + b23e139d0b66 ("arch: Introduce arch_{,try_}_cmpxchg128{,_local}()") + +Fixes: b23e139d0b66 ("arch: Introduce arch_{,try_}_cmpxchg128{,_local}()") +Signed-off-by: Uros Bizjak +Signed-off-by: Ingo Molnar +Cc: Linus Torvalds +Cc: "H. Peter Anvin" +Link: https://lore.kernel.org/r/20240408091547.90111-2-ubizjak@gmail.com +Signed-off-by: Sasha Levin +--- + arch/x86/include/asm/cmpxchg_64.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/x86/include/asm/cmpxchg_64.h b/arch/x86/include/asm/cmpxchg_64.h +index 44b08b53ab32f..c1d6cd58f8094 100644 +--- a/arch/x86/include/asm/cmpxchg_64.h ++++ b/arch/x86/include/asm/cmpxchg_64.h +@@ -62,7 +62,7 @@ static __always_inline u128 arch_cmpxchg128_local(volatile u128 *ptr, u128 old, + asm volatile(_lock "cmpxchg16b %[ptr]" \ + CC_SET(e) \ + : CC_OUT(e) (ret), \ +- [ptr] "+m" (*ptr), \ ++ [ptr] "+m" (*(_ptr)), \ + "+a" (o.low), "+d" (o.high) \ + : "b" (n.low), "c" (n.high) \ + : "memory"); \ +-- +2.43.0 + diff --git a/queue-6.8/loongarch-lately-init-pmu-after-smp-is-online.patch b/queue-6.8/loongarch-lately-init-pmu-after-smp-is-online.patch new file mode 100644 index 00000000000..52750c7db7d --- /dev/null +++ b/queue-6.8/loongarch-lately-init-pmu-after-smp-is-online.patch @@ -0,0 +1,40 @@ +From 3f9b50a94765e82e9377a3bbb55087dce314a966 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 22:17:52 +0800 +Subject: LoongArch: Lately init pmu after smp is online + +From: Bibo Mao + +[ Upstream commit f3334ebb8a2a1841c2824594dd992e66de19deb2 ] + +There is an smp function call named reset_counters() to init PMU +registers of every CPU in PMU initialization state. It requires that all +CPUs are online. However there is an early_initcall() wrapper for the +PMU init funciton init_hw_perf_events(), so that pmu init funciton is +called in do_pre_smp_initcalls() which before function smp_init(). +Function reset_counters() cannot work on other CPUs since they haven't +boot up still. + +Here replace the wrapper early_initcall() with pure_initcall(), so that +the PMU init function is called after every cpu is online. + +Signed-off-by: Bibo Mao +Signed-off-by: Huacai Chen +Signed-off-by: Sasha Levin +--- + arch/loongarch/kernel/perf_event.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/loongarch/kernel/perf_event.c b/arch/loongarch/kernel/perf_event.c +index 0491bf453cd49..cac7cba81b65f 100644 +--- a/arch/loongarch/kernel/perf_event.c ++++ b/arch/loongarch/kernel/perf_event.c +@@ -884,4 +884,4 @@ static int __init init_hw_perf_events(void) + + return 0; + } +-early_initcall(init_hw_perf_events); ++pure_initcall(init_hw_perf_events); +-- +2.43.0 + diff --git a/queue-6.8/m68k-fix-spinlock-race-in-kernel-thread-creation.patch b/queue-6.8/m68k-fix-spinlock-race-in-kernel-thread-creation.patch new file mode 100644 index 00000000000..67636e30316 --- /dev/null +++ b/queue-6.8/m68k-fix-spinlock-race-in-kernel-thread-creation.patch @@ -0,0 +1,77 @@ +From 6b9b7abf1d673e2fb6b5a636383b85181fbc92a4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 15:36:31 +1200 +Subject: m68k: Fix spinlock race in kernel thread creation + +From: Michael Schmitz + +[ Upstream commit da89ce46f02470ef08f0f580755d14d547da59ed ] + +Context switching does take care to retain the correct lock owner across +the switch from 'prev' to 'next' tasks. This does rely on interrupts +remaining disabled for the entire duration of the switch. + +This condition is guaranteed for normal process creation and context +switching between already running processes, because both 'prev' and +'next' already have interrupts disabled in their saved copies of the +status register. + +The situation is different for newly created kernel threads. The status +register is set to PS_S in copy_thread(), which does leave the IPL at 0. +Upon restoring the 'next' thread's status register in switch_to() aka +resume(), interrupts then become enabled prematurely. resume() then +returns via ret_from_kernel_thread() and schedule_tail() where run queue +lock is released (see finish_task_switch() and finish_lock_switch()). + +A timer interrupt calling scheduler_tick() before the lock is released +in finish_task_switch() will find the lock already taken, with the +current task as lock owner. This causes a spinlock recursion warning as +reported by Guenter Roeck. + +As far as I can ascertain, this race has been opened in commit +533e6903bea0 ("m68k: split ret_from_fork(), simplify kernel_thread()") +but I haven't done a detailed study of kernel history so it may well +predate that commit. + +Interrupts cannot be disabled in the saved status register copy for +kernel threads (init will complain about interrupts disabled when +finally starting user space). Disable interrupts temporarily when +switching the tasks' register sets in resume(). + +Note that a simple oriw 0x700,%sr after restoring sr is not enough here +- this leaves enough of a race for the 'spinlock recursion' warning to +still be observed. + +Tested on ARAnyM and qemu (Quadra 800 emulation). + +Fixes: 533e6903bea0 ("m68k: split ret_from_fork(), simplify kernel_thread()") +Reported-by: Guenter Roeck +Closes: https://lore.kernel.org/all/07811b26-677c-4d05-aeb4-996cd880b789@roeck-us.net +Signed-off-by: Michael Schmitz +Tested-by: Guenter Roeck +Reviewed-by: Geert Uytterhoeven +Link: https://lore.kernel.org/r/20240411033631.16335-1-schmitzmic@gmail.com +Signed-off-by: Geert Uytterhoeven +Signed-off-by: Sasha Levin +--- + arch/m68k/kernel/entry.S | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/arch/m68k/kernel/entry.S b/arch/m68k/kernel/entry.S +index 3bcdd32a6b366..338b474910f74 100644 +--- a/arch/m68k/kernel/entry.S ++++ b/arch/m68k/kernel/entry.S +@@ -430,7 +430,9 @@ resume: + movec %a0,%dfc + + /* restore status register */ +- movew %a1@(TASK_THREAD+THREAD_SR),%sr ++ movew %a1@(TASK_THREAD+THREAD_SR),%d0 ++ oriw #0x0700,%d0 ++ movew %d0,%sr + + rts + +-- +2.43.0 + diff --git a/queue-6.8/m68k-mac-fix-reboot-hang-on-mac-iici.patch b/queue-6.8/m68k-mac-fix-reboot-hang-on-mac-iici.patch new file mode 100644 index 00000000000..75f6db82747 --- /dev/null +++ b/queue-6.8/m68k-mac-fix-reboot-hang-on-mac-iici.patch @@ -0,0 +1,99 @@ +From 866004ec0a36a184ddad5823e0d54a7d86be6601 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 4 May 2024 14:31:12 +1000 +Subject: m68k: mac: Fix reboot hang on Mac IIci + +From: Finn Thain + +[ Upstream commit 265a3b322df9a973ff1fc63da70af456ab6ae1d6 ] + +Calling mac_reset() on a Mac IIci does reset the system, but what +follows is a POST failure that requires a manual reset to resolve. +Avoid that by using the 68030 asm implementation instead of the C +implementation. + +Apparently the SE/30 has a similar problem as it has used the asm +implementation since before git. This patch extends that solution to +other systems with a similar ROM. + +After this patch, the only systems still using the C implementation are +68040 systems where adb_type is either MAC_ADB_IOP or MAC_ADB_II. This +implies a 1 MiB Quadra ROM. + +This now includes the Quadra 900/950, which previously fell through to +the "should never get here" catch-all. + +Reported-and-tested-by: Stan Johnson +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Signed-off-by: Finn Thain +Reviewed-by: Geert Uytterhoeven +Link: https://lore.kernel.org/r/480ebd1249d229c6dc1f3f1c6d599b8505483fd8.1714797072.git.fthain@linux-m68k.org +Signed-off-by: Geert Uytterhoeven +Signed-off-by: Sasha Levin +--- + arch/m68k/mac/misc.c | 36 ++++++++++++++++++------------------ + 1 file changed, 18 insertions(+), 18 deletions(-) + +diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c +index 4c8f8cbfa05f3..e7f0f72c1b36e 100644 +--- a/arch/m68k/mac/misc.c ++++ b/arch/m68k/mac/misc.c +@@ -453,30 +453,18 @@ void mac_poweroff(void) + + void mac_reset(void) + { +- if (macintosh_config->adb_type == MAC_ADB_II && +- macintosh_config->ident != MAC_MODEL_SE30) { +- /* need ROMBASE in booter */ +- /* indeed, plus need to MAP THE ROM !! */ +- +- if (mac_bi_data.rombase == 0) +- mac_bi_data.rombase = 0x40800000; +- +- /* works on some */ +- rom_reset = (void *) (mac_bi_data.rombase + 0xa); +- +- local_irq_disable(); +- rom_reset(); + #ifdef CONFIG_ADB_CUDA +- } else if (macintosh_config->adb_type == MAC_ADB_EGRET || +- macintosh_config->adb_type == MAC_ADB_CUDA) { ++ if (macintosh_config->adb_type == MAC_ADB_EGRET || ++ macintosh_config->adb_type == MAC_ADB_CUDA) { + cuda_restart(); ++ } else + #endif + #ifdef CONFIG_ADB_PMU +- } else if (macintosh_config->adb_type == MAC_ADB_PB2) { ++ if (macintosh_config->adb_type == MAC_ADB_PB2) { + pmu_restart(); ++ } else + #endif +- } else if (CPU_IS_030) { +- ++ if (CPU_IS_030) { + /* 030-specific reset routine. The idea is general, but the + * specific registers to reset are '030-specific. Until I + * have a non-030 machine, I can't test anything else. +@@ -524,6 +512,18 @@ void mac_reset(void) + "jmp %/a0@\n\t" /* jump to the reset vector */ + ".chip 68k" + : : "r" (offset), "a" (rombase) : "a0"); ++ } else { ++ /* need ROMBASE in booter */ ++ /* indeed, plus need to MAP THE ROM !! */ ++ ++ if (mac_bi_data.rombase == 0) ++ mac_bi_data.rombase = 0x40800000; ++ ++ /* works on some */ ++ rom_reset = (void *)(mac_bi_data.rombase + 0xa); ++ ++ local_irq_disable(); ++ rom_reset(); + } + + /* should never get here */ +-- +2.43.0 + diff --git a/queue-6.8/macintosh-via-macii-fix-bug-sleeping-function-called.patch b/queue-6.8/macintosh-via-macii-fix-bug-sleeping-function-called.patch new file mode 100644 index 00000000000..a20febcd52b --- /dev/null +++ b/queue-6.8/macintosh-via-macii-fix-bug-sleeping-function-called.patch @@ -0,0 +1,59 @@ +From cd80b274ae741940ce24f0eca5b763a9baf9ba68 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 13 Mar 2024 13:53:41 +1100 +Subject: macintosh/via-macii: Fix "BUG: sleeping function called from invalid + context" + +From: Finn Thain + +[ Upstream commit d301a71c76ee4c384b4e03cdc320a55f5cf1df05 ] + +The via-macii ADB driver calls request_irq() after disabling hard +interrupts. But disabling interrupts isn't necessary here because the +VIA shift register interrupt was masked during VIA1 initialization. + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Signed-off-by: Finn Thain +Reviewed-by: Geert Uytterhoeven +Link: https://lore.kernel.org/r/419fcc09d0e563b425c419053d02236b044d86b0.1710298421.git.fthain@linux-m68k.org +Signed-off-by: Geert Uytterhoeven +Signed-off-by: Sasha Levin +--- + drivers/macintosh/via-macii.c | 11 +++-------- + 1 file changed, 3 insertions(+), 8 deletions(-) + +diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c +index db9270da5b8e9..b6ddf1d47cb4e 100644 +--- a/drivers/macintosh/via-macii.c ++++ b/drivers/macintosh/via-macii.c +@@ -140,24 +140,19 @@ static int macii_probe(void) + /* Initialize the driver */ + static int macii_init(void) + { +- unsigned long flags; + int err; + +- local_irq_save(flags); +- + err = macii_init_via(); + if (err) +- goto out; ++ return err; + + err = request_irq(IRQ_MAC_ADB, macii_interrupt, 0, "ADB", + macii_interrupt); + if (err) +- goto out; ++ return err; + + macii_state = idle; +-out: +- local_irq_restore(flags); +- return err; ++ return 0; + } + + /* initialize the hardware */ +-- +2.43.0 + diff --git a/queue-6.8/maple_tree-add-mtree_alloc_cyclic.patch b/queue-6.8/maple_tree-add-mtree_alloc_cyclic.patch new file mode 100644 index 00000000000..0250d1832b7 --- /dev/null +++ b/queue-6.8/maple_tree-add-mtree_alloc_cyclic.patch @@ -0,0 +1,168 @@ +From 3cb5c843cb0bff6ecc476999c0d19e7f3b82c4d0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 17 Feb 2024 15:24:01 -0500 +Subject: maple_tree: Add mtree_alloc_cyclic() + +From: Chuck Lever + +[ Upstream commit 9b6713cc75229f25552c643083cbdbfb771e5bca ] + +I need a cyclic allocator for the simple_offset implementation in +fs/libfs.c. + +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/170820144179.6328.12838600511394432325.stgit@91.116.238.104.host.secureserver.net +Signed-off-by: Christian Brauner +Stable-dep-of: 23cdd0eed3f1 ("libfs: Fix simple_offset_rename_exchange()") +Signed-off-by: Sasha Levin +--- + include/linux/maple_tree.h | 7 +++ + lib/maple_tree.c | 93 ++++++++++++++++++++++++++++++++++++++ + 2 files changed, 100 insertions(+) + +diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h +index b3d63123b945b..a53ad4dabd7e8 100644 +--- a/include/linux/maple_tree.h ++++ b/include/linux/maple_tree.h +@@ -171,6 +171,7 @@ enum maple_type { + #define MT_FLAGS_LOCK_IRQ 0x100 + #define MT_FLAGS_LOCK_BH 0x200 + #define MT_FLAGS_LOCK_EXTERN 0x300 ++#define MT_FLAGS_ALLOC_WRAPPED 0x0800 + + #define MAPLE_HEIGHT_MAX 31 + +@@ -319,6 +320,9 @@ int mtree_insert_range(struct maple_tree *mt, unsigned long first, + int mtree_alloc_range(struct maple_tree *mt, unsigned long *startp, + void *entry, unsigned long size, unsigned long min, + unsigned long max, gfp_t gfp); ++int mtree_alloc_cyclic(struct maple_tree *mt, unsigned long *startp, ++ void *entry, unsigned long range_lo, unsigned long range_hi, ++ unsigned long *next, gfp_t gfp); + int mtree_alloc_rrange(struct maple_tree *mt, unsigned long *startp, + void *entry, unsigned long size, unsigned long min, + unsigned long max, gfp_t gfp); +@@ -499,6 +503,9 @@ void *mas_find_range(struct ma_state *mas, unsigned long max); + void *mas_find_rev(struct ma_state *mas, unsigned long min); + void *mas_find_range_rev(struct ma_state *mas, unsigned long max); + int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp); ++int mas_alloc_cyclic(struct ma_state *mas, unsigned long *startp, ++ void *entry, unsigned long range_lo, unsigned long range_hi, ++ unsigned long *next, gfp_t gfp); + + bool mas_nomem(struct ma_state *mas, gfp_t gfp); + void mas_pause(struct ma_state *mas); +diff --git a/lib/maple_tree.c b/lib/maple_tree.c +index d70db05757091..fe6092a1dc353 100644 +--- a/lib/maple_tree.c ++++ b/lib/maple_tree.c +@@ -4290,6 +4290,56 @@ static inline void *mas_insert(struct ma_state *mas, void *entry) + + } + ++/** ++ * mas_alloc_cyclic() - Internal call to find somewhere to store an entry ++ * @mas: The maple state. ++ * @startp: Pointer to ID. ++ * @range_lo: Lower bound of range to search. ++ * @range_hi: Upper bound of range to search. ++ * @entry: The entry to store. ++ * @next: Pointer to next ID to allocate. ++ * @gfp: The GFP_FLAGS to use for allocations. ++ * ++ * Return: 0 if the allocation succeeded without wrapping, 1 if the ++ * allocation succeeded after wrapping, or -EBUSY if there are no ++ * free entries. ++ */ ++int mas_alloc_cyclic(struct ma_state *mas, unsigned long *startp, ++ void *entry, unsigned long range_lo, unsigned long range_hi, ++ unsigned long *next, gfp_t gfp) ++{ ++ unsigned long min = range_lo; ++ int ret = 0; ++ ++ range_lo = max(min, *next); ++ ret = mas_empty_area(mas, range_lo, range_hi, 1); ++ if ((mas->tree->ma_flags & MT_FLAGS_ALLOC_WRAPPED) && ret == 0) { ++ mas->tree->ma_flags &= ~MT_FLAGS_ALLOC_WRAPPED; ++ ret = 1; ++ } ++ if (ret < 0 && range_lo > min) { ++ ret = mas_empty_area(mas, min, range_hi, 1); ++ if (ret == 0) ++ ret = 1; ++ } ++ if (ret < 0) ++ return ret; ++ ++ do { ++ mas_insert(mas, entry); ++ } while (mas_nomem(mas, gfp)); ++ if (mas_is_err(mas)) ++ return xa_err(mas->node); ++ ++ *startp = mas->index; ++ *next = *startp + 1; ++ if (*next == 0) ++ mas->tree->ma_flags |= MT_FLAGS_ALLOC_WRAPPED; ++ ++ return ret; ++} ++EXPORT_SYMBOL(mas_alloc_cyclic); ++ + static __always_inline void mas_rewalk(struct ma_state *mas, unsigned long index) + { + retry: +@@ -6443,6 +6493,49 @@ int mtree_alloc_range(struct maple_tree *mt, unsigned long *startp, + } + EXPORT_SYMBOL(mtree_alloc_range); + ++/** ++ * mtree_alloc_cyclic() - Find somewhere to store this entry in the tree. ++ * @mt: The maple tree. ++ * @startp: Pointer to ID. ++ * @range_lo: Lower bound of range to search. ++ * @range_hi: Upper bound of range to search. ++ * @entry: The entry to store. ++ * @next: Pointer to next ID to allocate. ++ * @gfp: The GFP_FLAGS to use for allocations. ++ * ++ * Finds an empty entry in @mt after @next, stores the new index into ++ * the @id pointer, stores the entry at that index, then updates @next. ++ * ++ * @mt must be initialized with the MT_FLAGS_ALLOC_RANGE flag. ++ * ++ * Context: Any context. Takes and releases the mt.lock. May sleep if ++ * the @gfp flags permit. ++ * ++ * Return: 0 if the allocation succeeded without wrapping, 1 if the ++ * allocation succeeded after wrapping, -ENOMEM if memory could not be ++ * allocated, -EINVAL if @mt cannot be used, or -EBUSY if there are no ++ * free entries. ++ */ ++int mtree_alloc_cyclic(struct maple_tree *mt, unsigned long *startp, ++ void *entry, unsigned long range_lo, unsigned long range_hi, ++ unsigned long *next, gfp_t gfp) ++{ ++ int ret; ++ ++ MA_STATE(mas, mt, 0, 0); ++ ++ if (!mt_is_alloc(mt)) ++ return -EINVAL; ++ if (WARN_ON_ONCE(mt_is_reserved(entry))) ++ return -EINVAL; ++ mtree_lock(mt); ++ ret = mas_alloc_cyclic(&mas, startp, entry, range_lo, range_hi, ++ next, gfp); ++ mtree_unlock(mt); ++ return ret; ++} ++EXPORT_SYMBOL(mtree_alloc_cyclic); ++ + int mtree_alloc_rrange(struct maple_tree *mt, unsigned long *startp, + void *entry, unsigned long size, unsigned long min, + unsigned long max, gfp_t gfp) +-- +2.43.0 + diff --git a/queue-6.8/md-fix-resync-softlockup-when-bitmap-size-is-less-th.patch b/queue-6.8/md-fix-resync-softlockup-when-bitmap-size-is-less-th.patch new file mode 100644 index 00000000000..e6931fb2513 --- /dev/null +++ b/queue-6.8/md-fix-resync-softlockup-when-bitmap-size-is-less-th.patch @@ -0,0 +1,93 @@ +From 66957caf6196b3ac72cce1a73ecad8e0ec3f791d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 14:58:24 +0800 +Subject: md: fix resync softlockup when bitmap size is less than array size + +From: Yu Kuai + +[ Upstream commit f0e729af2eb6bee9eb58c4df1087f14ebaefe26b ] + +Is is reported that for dm-raid10, lvextend + lvchange --syncaction will +trigger following softlockup: + +kernel:watchdog: BUG: soft lockup - CPU#3 stuck for 26s! [mdX_resync:6976] +CPU: 7 PID: 3588 Comm: mdX_resync Kdump: loaded Not tainted 6.9.0-rc4-next-20240419 #1 +RIP: 0010:_raw_spin_unlock_irq+0x13/0x30 +Call Trace: + + md_bitmap_start_sync+0x6b/0xf0 + raid10_sync_request+0x25c/0x1b40 [raid10] + md_do_sync+0x64b/0x1020 + md_thread+0xa7/0x170 + kthread+0xcf/0x100 + ret_from_fork+0x30/0x50 + ret_from_fork_asm+0x1a/0x30 + +And the detailed process is as follows: + +md_do_sync + j = mddev->resync_min + while (j < max_sectors) + sectors = raid10_sync_request(mddev, j, &skipped) + if (!md_bitmap_start_sync(..., &sync_blocks)) + // md_bitmap_start_sync set sync_blocks to 0 + return sync_blocks + sectors_skippe; + // sectors = 0; + j += sectors; + // j never change + +Root cause is that commit 301867b1c168 ("md/raid10: check +slab-out-of-bounds in md_bitmap_get_counter") return early from +md_bitmap_get_counter(), without setting returned blocks. + +Fix this problem by always set returned blocks from +md_bitmap_get_counter"(), as it used to be. + +Noted that this patch just fix the softlockup problem in kernel, the +case that bitmap size doesn't match array size still need to be fixed. + +Fixes: 301867b1c168 ("md/raid10: check slab-out-of-bounds in md_bitmap_get_counter") +Reported-and-tested-by: Nigel Croxon +Closes: https://lore.kernel.org/all/71ba5272-ab07-43ba-8232-d2da642acb4e@redhat.com/ +Signed-off-by: Yu Kuai +Link: https://lore.kernel.org/r/20240422065824.2516-1-yukuai1@huaweicloud.com +Signed-off-by: Song Liu +Signed-off-by: Sasha Levin +--- + drivers/md/md-bitmap.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c +index a4976ceae8688..ee67da44641b5 100644 +--- a/drivers/md/md-bitmap.c ++++ b/drivers/md/md-bitmap.c +@@ -1427,7 +1427,7 @@ __acquires(bitmap->lock) + sector_t chunk = offset >> bitmap->chunkshift; + unsigned long page = chunk >> PAGE_COUNTER_SHIFT; + unsigned long pageoff = (chunk & PAGE_COUNTER_MASK) << COUNTER_BYTE_SHIFT; +- sector_t csize; ++ sector_t csize = ((sector_t)1) << bitmap->chunkshift; + int err; + + if (page >= bitmap->pages) { +@@ -1436,6 +1436,7 @@ __acquires(bitmap->lock) + * End-of-device while looking for a whole page or + * user set a huge number to sysfs bitmap_set_bits. + */ ++ *blocks = csize - (offset & (csize - 1)); + return NULL; + } + err = md_bitmap_checkpage(bitmap, page, create, 0); +@@ -1444,8 +1445,7 @@ __acquires(bitmap->lock) + bitmap->bp[page].map == NULL) + csize = ((sector_t)1) << (bitmap->chunkshift + + PAGE_COUNTER_SHIFT); +- else +- csize = ((sector_t)1) << bitmap->chunkshift; ++ + *blocks = csize - (offset & (csize - 1)); + + if (err < 0) +-- +2.43.0 + diff --git a/queue-6.8/media-atomisp-ssh_css-fix-a-null-pointer-dereference.patch b/queue-6.8/media-atomisp-ssh_css-fix-a-null-pointer-dereference.patch new file mode 100644 index 00000000000..b35f19d7d80 --- /dev/null +++ b/queue-6.8/media-atomisp-ssh_css-fix-a-null-pointer-dereference.patch @@ -0,0 +1,52 @@ +From 3c9a93fcf86e937215c462613bcd85adc8d71ef5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Jan 2024 16:13:00 +0100 +Subject: media: atomisp: ssh_css: Fix a null-pointer dereference in + load_video_binaries + +From: Zhipeng Lu + +[ Upstream commit 3b621e9e9e148c0928ab109ac3d4b81487469acb ] + +The allocation failure of mycs->yuv_scaler_binary in load_video_binaries() +is followed with a dereference of mycs->yuv_scaler_binary after the +following call chain: + +sh_css_pipe_load_binaries() + |-> load_video_binaries(mycs->yuv_scaler_binary == NULL) + | + |-> sh_css_pipe_unload_binaries() + |-> unload_video_binaries() + +In unload_video_binaries(), it calls to ia_css_binary_unload with argument +&pipe->pipe_settings.video.yuv_scaler_binary[i], which refers to the +same memory slot as mycs->yuv_scaler_binary. Thus, a null-pointer +dereference is triggered. + +Link: https://lore.kernel.org/r/20240118151303.3828292-1-alexious@zju.edu.cn + +Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") +Signed-off-by: Zhipeng Lu +Reviewed-by: Andy Shevchenko +Signed-off-by: Hans de Goede +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/staging/media/atomisp/pci/sh_css.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c +index f35c90809414c..638f08b3f21be 100644 +--- a/drivers/staging/media/atomisp/pci/sh_css.c ++++ b/drivers/staging/media/atomisp/pci/sh_css.c +@@ -4719,6 +4719,7 @@ static int load_video_binaries(struct ia_css_pipe *pipe) + sizeof(struct ia_css_binary), + GFP_KERNEL); + if (!mycs->yuv_scaler_binary) { ++ mycs->num_yuv_scaler = 0; + err = -ENOMEM; + return err; + } +-- +2.43.0 + diff --git a/queue-6.8/media-cadence-csi2rx-configure-dphy-before-starting-.patch b/queue-6.8/media-cadence-csi2rx-configure-dphy-before-starting-.patch new file mode 100644 index 00000000000..56988f90784 --- /dev/null +++ b/queue-6.8/media-cadence-csi2rx-configure-dphy-before-starting-.patch @@ -0,0 +1,91 @@ +From bdfaf9e93149bf1e773431323d573edd4e440bb5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 23 Feb 2024 13:53:01 +0530 +Subject: media: cadence: csi2rx: configure DPHY before starting source stream + +From: Pratyush Yadav + +[ Upstream commit fd64dda48f7e3f67ada1e1fe47e784ab350da72e ] + +When the source device is operating above 1.5 Gbps per lane, it needs to +send the Skew Calibration Sequence before sending any HS data. If the +DPHY is initialized after the source stream is started, then it might +miss the sequence and not be able to receive data properly. Move the +start of source subdev to the end of the sequence to make sure +everything is ready to receive data before the source starts streaming. + +Signed-off-by: Pratyush Yadav +Fixes: 3295cf1241d3 ("media: cadence: Add support for external dphy") +Tested-by: Julien Massot +Tested-by: Changhuang Liang +Reviewed-by: Julien Massot +Reviewed-by: Changhuang Liang +Signed-off-by: Jai Luthra +Signed-off-by: Sakari Ailus +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/platform/cadence/cdns-csi2rx.c | 26 +++++++++++--------- + 1 file changed, 14 insertions(+), 12 deletions(-) + +diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c +index 0ea5fa956fe9a..5be75bd4add39 100644 +--- a/drivers/media/platform/cadence/cdns-csi2rx.c ++++ b/drivers/media/platform/cadence/cdns-csi2rx.c +@@ -235,10 +235,6 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) + + writel(reg, csi2rx->base + CSI2RX_STATIC_CFG_REG); + +- ret = v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, true); +- if (ret) +- goto err_disable_pclk; +- + /* Enable DPHY clk and data lanes. */ + if (csi2rx->dphy) { + reg = CSI2RX_DPHY_CL_EN | CSI2RX_DPHY_CL_RST; +@@ -248,6 +244,13 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) + } + + writel(reg, csi2rx->base + CSI2RX_DPHY_LANE_CTRL_REG); ++ ++ ret = csi2rx_configure_ext_dphy(csi2rx); ++ if (ret) { ++ dev_err(csi2rx->dev, ++ "Failed to configure external DPHY: %d\n", ret); ++ goto err_disable_pclk; ++ } + } + + /* +@@ -287,14 +290,9 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) + + reset_control_deassert(csi2rx->sys_rst); + +- if (csi2rx->dphy) { +- ret = csi2rx_configure_ext_dphy(csi2rx); +- if (ret) { +- dev_err(csi2rx->dev, +- "Failed to configure external DPHY: %d\n", ret); +- goto err_disable_sysclk; +- } +- } ++ ret = v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, true); ++ if (ret) ++ goto err_disable_sysclk; + + clk_disable_unprepare(csi2rx->p_clk); + +@@ -308,6 +306,10 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) + clk_disable_unprepare(csi2rx->pixel_clk[i - 1]); + } + ++ if (csi2rx->dphy) { ++ writel(0, csi2rx->base + CSI2RX_DPHY_LANE_CTRL_REG); ++ phy_power_off(csi2rx->dphy); ++ } + err_disable_pclk: + clk_disable_unprepare(csi2rx->p_clk); + +-- +2.43.0 + diff --git a/queue-6.8/media-dt-bindings-ovti-ov2680-fix-the-power-supply-n.patch b/queue-6.8/media-dt-bindings-ovti-ov2680-fix-the-power-supply-n.patch new file mode 100644 index 00000000000..6a79a0092fc --- /dev/null +++ b/queue-6.8/media-dt-bindings-ovti-ov2680-fix-the-power-supply-n.patch @@ -0,0 +1,77 @@ +From 1ba2c33ee8d5cd303609186b24dd96376bfe0f3b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 14:40:27 -0300 +Subject: media: dt-bindings: ovti,ov2680: Fix the power supply names + +From: Fabio Estevam + +[ Upstream commit e2f6ea61b6f3e4ebbb7dff857eea6220c18cd17b ] + +The original .txt bindings had the OV2680 power supply names correct, +but the transition from .txt to yaml spelled them incorrectly. + +Fix the OV2680 power supply names as the original .txt bindings +as these are the names used by the OV2680 driver and in devicetree. + +Fixes: 57226cd8c8bf ("media: dt-bindings: ov2680: convert bindings to yaml") +Signed-off-by: Fabio Estevam +Reviewed-by: Rob Herring +Signed-off-by: Sakari Ailus +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + .../bindings/media/i2c/ovti,ov2680.yaml | 18 +++++++++--------- + 1 file changed, 9 insertions(+), 9 deletions(-) + +diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml +index cf456f8d9ddcb..c87677f5e2a25 100644 +--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml ++++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml +@@ -37,15 +37,15 @@ properties: + active low. + maxItems: 1 + +- dovdd-supply: ++ DOVDD-supply: + description: + Definition of the regulator used as interface power supply. + +- avdd-supply: ++ AVDD-supply: + description: + Definition of the regulator used as analog power supply. + +- dvdd-supply: ++ DVDD-supply: + description: + Definition of the regulator used as digital power supply. + +@@ -59,9 +59,9 @@ required: + - reg + - clocks + - clock-names +- - dovdd-supply +- - avdd-supply +- - dvdd-supply ++ - DOVDD-supply ++ - AVDD-supply ++ - DVDD-supply + - reset-gpios + - port + +@@ -82,9 +82,9 @@ examples: + clock-names = "xvclk"; + reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; + +- dovdd-supply = <&sw2_reg>; +- dvdd-supply = <&sw2_reg>; +- avdd-supply = <®_peri_3p15v>; ++ DOVDD-supply = <&sw2_reg>; ++ DVDD-supply = <&sw2_reg>; ++ AVDD-supply = <®_peri_3p15v>; + + port { + ov2680_to_mipi: endpoint { +-- +2.43.0 + diff --git a/queue-6.8/media-i2c-et8ek8-don-t-strip-remove-function-when-dr.patch b/queue-6.8/media-i2c-et8ek8-don-t-strip-remove-function-when-dr.patch new file mode 100644 index 00000000000..a925ab6d786 --- /dev/null +++ b/queue-6.8/media-i2c-et8ek8-don-t-strip-remove-function-when-dr.patch @@ -0,0 +1,57 @@ +From ff416450769218046bae64503c7669be2c691554 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 24 Mar 2024 17:00:44 +0100 +Subject: media: i2c: et8ek8: Don't strip remove function when driver is + builtin +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 545b215736c5c4b354e182d99c578a472ac9bfce ] + +Using __exit for the remove function results in the remove callback +being discarded with CONFIG_VIDEO_ET8EK8=y. When such a device gets +unbound (e.g. using sysfs or hotplug), the driver is just removed +without the cleanup being performed. This results in resource leaks. Fix +it by compiling in the remove callback unconditionally. + +This also fixes a W=1 modpost warning: + + WARNING: modpost: drivers/media/i2c/et8ek8/et8ek8: section mismatch in reference: et8ek8_i2c_driver+0x10 (section: .data) -> et8ek8_remove (section: .exit.text) + +Fixes: c5254e72b8ed ("[media] media: Driver for Toshiba et8ek8 5MP sensor") +Signed-off-by: Uwe Kleine-König +Signed-off-by: Sakari Ailus +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c +index f548b1bb75fb9..e932d25ca7b3a 100644 +--- a/drivers/media/i2c/et8ek8/et8ek8_driver.c ++++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c +@@ -1475,7 +1475,7 @@ static int et8ek8_probe(struct i2c_client *client) + return ret; + } + +-static void __exit et8ek8_remove(struct i2c_client *client) ++static void et8ek8_remove(struct i2c_client *client) + { + struct v4l2_subdev *subdev = i2c_get_clientdata(client); + struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev); +@@ -1517,7 +1517,7 @@ static struct i2c_driver et8ek8_i2c_driver = { + .of_match_table = et8ek8_of_table, + }, + .probe = et8ek8_probe, +- .remove = __exit_p(et8ek8_remove), ++ .remove = et8ek8_remove, + .id_table = et8ek8_id_table, + }; + +-- +2.43.0 + diff --git a/queue-6.8/media-ipu3-cio2-request-irq-earlier.patch b/queue-6.8/media-ipu3-cio2-request-irq-earlier.patch new file mode 100644 index 00000000000..1096a70a102 --- /dev/null +++ b/queue-6.8/media-ipu3-cio2-request-irq-earlier.patch @@ -0,0 +1,52 @@ +From 538bcf66b9f3628c77f6a3b3d3d1416ec4b28a49 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 20 Dec 2022 16:01:20 +0200 +Subject: media: ipu3-cio2: Request IRQ earlier + +From: Sakari Ailus + +[ Upstream commit a069f79bfa6ec1ea0744981ea8425c8a25322579 ] + +Call devm_request_irq() before registering the async notifier, as otherwise +it would be possible to use the device before the interrupts could be +delivered to the driver. + +Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") +Signed-off-by: Sakari Ailus +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c +index ed08bf4178f08..d5478779b3103 100644 +--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c ++++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c +@@ -1789,11 +1789,6 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, + + v4l2_async_nf_init(&cio2->notifier, &cio2->v4l2_dev); + +- /* Register notifier for subdevices we care */ +- r = cio2_parse_firmware(cio2); +- if (r) +- goto fail_clean_notifier; +- + r = devm_request_irq(dev, pci_dev->irq, cio2_irq, IRQF_SHARED, + CIO2_NAME, cio2); + if (r) { +@@ -1801,6 +1796,11 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, + goto fail_clean_notifier; + } + ++ /* Register notifier for subdevices we care */ ++ r = cio2_parse_firmware(cio2); ++ if (r) ++ goto fail_clean_notifier; ++ + pm_runtime_put_noidle(dev); + pm_runtime_allow(dev); + +-- +2.43.0 + diff --git a/queue-6.8/media-ngene-add-dvb_ca_en50221_init-return-value-che.patch b/queue-6.8/media-ngene-add-dvb_ca_en50221_init-return-value-che.patch new file mode 100644 index 00000000000..c2372c98d2f --- /dev/null +++ b/queue-6.8/media-ngene-add-dvb_ca_en50221_init-return-value-che.patch @@ -0,0 +1,40 @@ +From b0ee4dc6a8c32278c88d167cc39e422df9d3a4a9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 14:15:53 +0300 +Subject: media: ngene: Add dvb_ca_en50221_init return value check + +From: Aleksandr Burakov + +[ Upstream commit 9bb1fd7eddcab2d28cfc11eb20f1029154dac718 ] + +The return value of dvb_ca_en50221_init() is not checked here that may +cause undefined behavior in case of nonzero value return. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: 25aee3debe04 ("[media] Rename media/dvb as media/pci") +Signed-off-by: Aleksandr Burakov +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/pci/ngene/ngene-core.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c +index 7481f553f9595..24ec576dc3bff 100644 +--- a/drivers/media/pci/ngene/ngene-core.c ++++ b/drivers/media/pci/ngene/ngene-core.c +@@ -1488,7 +1488,9 @@ static int init_channel(struct ngene_channel *chan) + } + + if (dev->ci.en && (io & NGENE_IO_TSOUT)) { +- dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1); ++ ret = dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1); ++ if (ret != 0) ++ goto err; + set_transfer(chan, 1); + chan->dev->channel[2].DataFormatFlags = DF_SWAP32; + set_transfer(&chan->dev->channel[2], 1); +-- +2.43.0 + diff --git a/queue-6.8/media-radio-shark2-avoid-led_names-truncations.patch b/queue-6.8/media-radio-shark2-avoid-led_names-truncations.patch new file mode 100644 index 00000000000..06e768f3b83 --- /dev/null +++ b/queue-6.8/media-radio-shark2-avoid-led_names-truncations.patch @@ -0,0 +1,40 @@ +From ee509c23cdf93bd1ca1a8dac465a526c0a8e5e58 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 25 Mar 2024 14:50:24 +0000 +Subject: media: radio-shark2: Avoid led_names truncations +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Ricardo Ribalda + +[ Upstream commit 1820e16a3019b6258e6009d34432946a6ddd0a90 ] + +Increase the size of led_names so it can fit any valid v4l2 device name. + +Fixes: +drivers/media/radio/radio-shark2.c:197:17: warning: ‘%s’ directive output may be truncated writing up to 35 bytes into a region of size 32 [-Wformat-truncation=] + +Signed-off-by: Ricardo Ribalda +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/radio/radio-shark2.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio-shark2.c +index f1c5c0a6a335c..e3e6aa87fe081 100644 +--- a/drivers/media/radio/radio-shark2.c ++++ b/drivers/media/radio/radio-shark2.c +@@ -62,7 +62,7 @@ struct shark_device { + #ifdef SHARK_USE_LEDS + struct work_struct led_work; + struct led_classdev leds[NO_LEDS]; +- char led_names[NO_LEDS][32]; ++ char led_names[NO_LEDS][64]; + atomic_t brightness[NO_LEDS]; + unsigned long brightness_new; + #endif +-- +2.43.0 + diff --git a/queue-6.8/media-rcar-vin-work-around-wenum-compare-conditional.patch b/queue-6.8/media-rcar-vin-work-around-wenum-compare-conditional.patch new file mode 100644 index 00000000000..8763de55c48 --- /dev/null +++ b/queue-6.8/media-rcar-vin-work-around-wenum-compare-conditional.patch @@ -0,0 +1,47 @@ +From 0427bd5fd2a6dd28b29cf3678ceeeb851b569ec7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 22 Mar 2024 14:33:46 +0100 +Subject: media: rcar-vin: work around -Wenum-compare-conditional warning +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Arnd Bergmann + +[ Upstream commit 1a742c6010d136cb6c441a0f1dd2bfbfae3c4df2 ] + +clang-19 warns about mixing two enum types here: + +drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] +drivers/media/platform/renesas/rcar-vin/rcar-core.c:216:18: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] +drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] +drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] + +This one is intentional, and there is already a cast to work around another +warning, so address this by adding another cast. + +Fixes: 406bb586dec0 ("media: rcar-vin: Add r8a779a0 support") +Signed-off-by: Arnd Bergmann +Reviewed-by: Niklas Söderlund +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/platform/renesas/rcar-vin/rcar-vin.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-vin.h b/drivers/media/platform/renesas/rcar-vin/rcar-vin.h +index 792336dada447..997a66318a293 100644 +--- a/drivers/media/platform/renesas/rcar-vin/rcar-vin.h ++++ b/drivers/media/platform/renesas/rcar-vin/rcar-vin.h +@@ -59,7 +59,7 @@ enum rvin_isp_id { + + #define RVIN_REMOTES_MAX \ + (((unsigned int)RVIN_CSI_MAX) > ((unsigned int)RVIN_ISP_MAX) ? \ +- RVIN_CSI_MAX : RVIN_ISP_MAX) ++ (unsigned int)RVIN_CSI_MAX : (unsigned int)RVIN_ISP_MAX) + + /** + * enum rvin_dma_state - DMA states +-- +2.43.0 + diff --git a/queue-6.8/media-uvcvideo-add-quirk-for-logitech-rally-bar.patch b/queue-6.8/media-uvcvideo-add-quirk-for-logitech-rally-bar.patch new file mode 100644 index 00000000000..b72c32fb686 --- /dev/null +++ b/queue-6.8/media-uvcvideo-add-quirk-for-logitech-rally-bar.patch @@ -0,0 +1,106 @@ +From ec3b151e8422b5672dbece4cc35cd77f87ae7906 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 4 Apr 2024 18:00:49 +0000 +Subject: media: uvcvideo: Add quirk for Logitech Rally Bar + +From: Ricardo Ribalda + +[ Upstream commit 07731053d11f7647d5d8bc23caac997a4d562dfe ] + +Logitech Rally Bar devices, despite behaving as UVC cameras, have a +different power management system that the other cameras from Logitech. + +USB_QUIRK_RESET_RESUME is applied to all the UVC cameras from Logitech +at the usb core. Unfortunately, USB_QUIRK_RESET_RESUME causes undesired +USB disconnects in the Rally Bar that make them completely unusable. + +There is an open discussion about if we should fix this in the core or +add a quirk in the UVC driver. In order to enable this hardware, let's +land this patch first, and we can revert it later if there is a +different conclusion. + +Fixes: e387ef5c47dd ("usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams") +Acked-by: Greg Kroah-Hartman +Reviewed-by: Devinder Khroad +Reviewed-by: Sergey Senozhatsky +Reviewed-by: Laurent Pinchart +Signed-off-by: Ricardo Ribalda +Link: https://lore.kernel.org/r/20240404-rallybar-v6-1-6d67bb6b69af@chromium.org +Signed-off-by: Laurent Pinchart +Signed-off-by: Sasha Levin +--- + drivers/media/usb/uvc/uvc_driver.c | 31 ++++++++++++++++++++++++++++++ + drivers/media/usb/uvc/uvcvideo.h | 1 + + 2 files changed, 32 insertions(+) + +diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c +index bbd90123a4e76..91a41aa3ced24 100644 +--- a/drivers/media/usb/uvc/uvc_driver.c ++++ b/drivers/media/usb/uvc/uvc_driver.c +@@ -14,6 +14,7 @@ + #include + #include + #include ++#include + #include + #include + #include +@@ -2232,6 +2233,9 @@ static int uvc_probe(struct usb_interface *intf, + goto error; + } + ++ if (dev->quirks & UVC_QUIRK_NO_RESET_RESUME) ++ udev->quirks &= ~USB_QUIRK_RESET_RESUME; ++ + uvc_dbg(dev, PROBE, "UVC device initialized\n"); + usb_enable_autosuspend(udev); + return 0; +@@ -2574,6 +2578,33 @@ static const struct usb_device_id uvc_ids[] = { + .bInterfaceSubClass = 1, + .bInterfaceProtocol = 0, + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTORE_CTRLS_ON_INIT) }, ++ /* Logitech Rally Bar Huddle */ ++ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE ++ | USB_DEVICE_ID_MATCH_INT_INFO, ++ .idVendor = 0x046d, ++ .idProduct = 0x087c, ++ .bInterfaceClass = USB_CLASS_VIDEO, ++ .bInterfaceSubClass = 1, ++ .bInterfaceProtocol = 0, ++ .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_NO_RESET_RESUME) }, ++ /* Logitech Rally Bar */ ++ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE ++ | USB_DEVICE_ID_MATCH_INT_INFO, ++ .idVendor = 0x046d, ++ .idProduct = 0x089b, ++ .bInterfaceClass = USB_CLASS_VIDEO, ++ .bInterfaceSubClass = 1, ++ .bInterfaceProtocol = 0, ++ .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_NO_RESET_RESUME) }, ++ /* Logitech Rally Bar Mini */ ++ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE ++ | USB_DEVICE_ID_MATCH_INT_INFO, ++ .idVendor = 0x046d, ++ .idProduct = 0x08d3, ++ .bInterfaceClass = USB_CLASS_VIDEO, ++ .bInterfaceSubClass = 1, ++ .bInterfaceProtocol = 0, ++ .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_NO_RESET_RESUME) }, + /* Chicony CNF7129 (Asus EEE 100HE) */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, +diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h +index 6fb0a78b1b009..88218693f6f0b 100644 +--- a/drivers/media/usb/uvc/uvcvideo.h ++++ b/drivers/media/usb/uvc/uvcvideo.h +@@ -73,6 +73,7 @@ + #define UVC_QUIRK_FORCE_Y8 0x00000800 + #define UVC_QUIRK_FORCE_BPP 0x00001000 + #define UVC_QUIRK_WAKE_AUTOSUSPEND 0x00002000 ++#define UVC_QUIRK_NO_RESET_RESUME 0x00004000 + + /* Format flags */ + #define UVC_FMT_FLAG_COMPRESSED 0x00000001 +-- +2.43.0 + diff --git a/queue-6.8/media-v4l2-subdev-fix-stream-handling-for-crop-api.patch b/queue-6.8/media-v4l2-subdev-fix-stream-handling-for-crop-api.patch new file mode 100644 index 00000000000..429f9873532 --- /dev/null +++ b/queue-6.8/media-v4l2-subdev-fix-stream-handling-for-crop-api.patch @@ -0,0 +1,47 @@ +From 428458abc5de263da8d272abc03c3c080f0c2fcb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 02:37:25 +0300 +Subject: media: v4l2-subdev: Fix stream handling for crop API + +From: Laurent Pinchart + +[ Upstream commit 34d7bf1c8e59f5fbf438ee32c96389ebe41ca2e8 ] + +When support for streams was added to the V4L2 subdev API, the +v4l2_subdev_crop structure was extended with a stream field, but the +field was not handled in the core code that translates the +VIDIOC_SUBDEV_[GS]_CROP ioctls to the selection API. Fix it. + +Fixes: 2f91e10ee6fd ("media: subdev: add stream based configuration") +Signed-off-by: Laurent Pinchart +Reviewed-by: Tomi Valkeinen +Signed-off-by: Sakari Ailus +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/media/v4l2-core/v4l2-subdev.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c +index 4c6198c48dd61..45836f0a2b0a7 100644 +--- a/drivers/media/v4l2-core/v4l2-subdev.c ++++ b/drivers/media/v4l2-core/v4l2-subdev.c +@@ -732,6 +732,7 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, + memset(&sel, 0, sizeof(sel)); + sel.which = crop->which; + sel.pad = crop->pad; ++ sel.stream = crop->stream; + sel.target = V4L2_SEL_TGT_CROP; + + rval = v4l2_subdev_call( +@@ -756,6 +757,7 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, + memset(&sel, 0, sizeof(sel)); + sel.which = crop->which; + sel.pad = crop->pad; ++ sel.stream = crop->stream; + sel.target = V4L2_SEL_TGT_CROP; + sel.r = crop->rect; + +-- +2.43.0 + diff --git a/queue-6.8/mlx5-avoid-truncating-error-message.patch b/queue-6.8/mlx5-avoid-truncating-error-message.patch new file mode 100644 index 00000000000..93a3df6cb0f --- /dev/null +++ b/queue-6.8/mlx5-avoid-truncating-error-message.patch @@ -0,0 +1,41 @@ +From 5f8d93ffc961accb20fb99d4a439875b3282d3af Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 23:38:03 +0100 +Subject: mlx5: avoid truncating error message + +From: Arnd Bergmann + +[ Upstream commit b324a960354b872431d25959ad384ab66a7116ec ] + +clang warns that one error message is too long for its destination buffer: + +drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 94 [-Werror,-Wformat-truncation-non-kprintf] + +Reword it to be a bit shorter so it always fits. + +Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload") +Signed-off-by: Arnd Bergmann +Reviewed-by: Subbaraya Sundeep +Link: https://lore.kernel.org/r/20240326223825.4084412-5-arnd@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +index 1b9bc32efd6fa..c5ea1d1d2b035 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +@@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ + "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", + addr, vid, vport_num); + NL_SET_ERR_MSG_FMT_MOD(extack, +- "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", ++ "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)\n", + addr, vid, vport_num); + return -EINVAL; + } +-- +2.43.0 + diff --git a/queue-6.8/mlx5-stop-warning-for-64kb-pages.patch b/queue-6.8/mlx5-stop-warning-for-64kb-pages.patch new file mode 100644 index 00000000000..100a87663d4 --- /dev/null +++ b/queue-6.8/mlx5-stop-warning-for-64kb-pages.patch @@ -0,0 +1,57 @@ +From 370949ae1f3609f2627d8f51c4a41a9f6fb950ea Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 15:30:46 +0100 +Subject: mlx5: stop warning for 64KB pages + +From: Arnd Bergmann + +[ Upstream commit a5535e5336943b33689f558199366102387b7bbf ] + +When building with 64KB pages, clang points out that xsk->chunk_size +can never be PAGE_SIZE: + +drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:19:22: error: result of comparison of constant 65536 with expression of type 'u16' (aka 'unsigned short') is always false [-Werror,-Wtautological-constant-out-of-range-compare] + if (xsk->chunk_size > PAGE_SIZE || + ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~ + +In older versions of this code, using PAGE_SIZE was the only +possibility, so this would have never worked on 64KB page kernels, +but the patch apparently did not address this case completely. + +As Maxim Mikityanskiy suggested, 64KB chunks are really not all that +useful, so just shut up the warning by adding a cast. + +Fixes: 282c0c798f8e ("net/mlx5e: Allow XSK frames smaller than a page") +Link: https://lore.kernel.org/netdev/20211013150232.2942146-1-arnd@kernel.org/ +Link: https://lore.kernel.org/lkml/a7b27541-0ebb-4f2d-bd06-270a4d404613@app.fastmail.com/ +Signed-off-by: Arnd Bergmann +Acked-by: Maxim Mikityanskiy +Reviewed-by: Justin Stitt +Reviewed-by: Tariq Toukan +Link: https://lore.kernel.org/r/20240328143051.1069575-9-arnd@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c +index 82e6abbc17342..c969b8e709804 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c +@@ -28,8 +28,10 @@ bool mlx5e_validate_xsk_param(struct mlx5e_params *params, + struct mlx5e_xsk_param *xsk, + struct mlx5_core_dev *mdev) + { +- /* AF_XDP doesn't support frames larger than PAGE_SIZE. */ +- if (xsk->chunk_size > PAGE_SIZE || xsk->chunk_size < MLX5E_MIN_XSK_CHUNK_SIZE) { ++ /* AF_XDP doesn't support frames larger than PAGE_SIZE, ++ * and xsk->chunk_size is limited to 65535 bytes. ++ */ ++ if ((size_t)xsk->chunk_size > PAGE_SIZE || xsk->chunk_size < MLX5E_MIN_XSK_CHUNK_SIZE) { + mlx5_core_err(mdev, "XSK chunk size %u out of bounds [%u, %lu]\n", xsk->chunk_size, + MLX5E_MIN_XSK_CHUNK_SIZE, PAGE_SIZE); + return false; +-- +2.43.0 + diff --git a/queue-6.8/mm-ksm-fix-ksm-exec-support-for-prctl.patch b/queue-6.8/mm-ksm-fix-ksm-exec-support-for-prctl.patch new file mode 100644 index 00000000000..23c2fe2cb33 --- /dev/null +++ b/queue-6.8/mm-ksm-fix-ksm-exec-support-for-prctl.patch @@ -0,0 +1,116 @@ +From 9ae4fefd1c29f56da8cb968ae0259640fd856106 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 19:10:08 +0800 +Subject: mm/ksm: fix ksm exec support for prctl + +From: Jinjiang Tu + +[ Upstream commit 3a9e567ca45fb5280065283d10d9a11f0db61d2b ] + +Patch series "mm/ksm: fix ksm exec support for prctl", v4. + +commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits +MMF_VM_MERGE_ANY flag when a task calls execve(). However, it doesn't +create the mm_slot, so ksmd will not try to scan this task. The first +patch fixes the issue. + +The second patch refactors to prepare for the third patch. The third +patch extends the selftests of ksm to verfity the deduplication really +happens after fork/exec inherits ths KSM setting. + +This patch (of 3): + +commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits +MMF_VM_MERGE_ANY flag when a task calls execve(). Howerver, it doesn't +create the mm_slot, so ksmd will not try to scan this task. + +To fix it, allocate and add the mm_slot to ksm_mm_head in __bprm_mm_init() +when the mm has MMF_VM_MERGE_ANY flag. + +Link: https://lkml.kernel.org/r/20240328111010.1502191-1-tujinjiang@huawei.com +Link: https://lkml.kernel.org/r/20240328111010.1502191-2-tujinjiang@huawei.com +Fixes: 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") +Signed-off-by: Jinjiang Tu +Reviewed-by: David Hildenbrand +Cc: Johannes Weiner +Cc: Kefeng Wang +Cc: Nanyong Sun +Cc: Rik van Riel +Cc: Stefan Roesch +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + fs/exec.c | 11 +++++++++++ + include/linux/ksm.h | 13 +++++++++++++ + 2 files changed, 24 insertions(+) + +diff --git a/fs/exec.c b/fs/exec.c +index 5ee2545c3e183..f11cfd7bce0b1 100644 +--- a/fs/exec.c ++++ b/fs/exec.c +@@ -67,6 +67,7 @@ + #include + #include + #include ++#include + + #include + #include +@@ -267,6 +268,14 @@ static int __bprm_mm_init(struct linux_binprm *bprm) + goto err_free; + } + ++ /* ++ * Need to be called with mmap write lock ++ * held, to avoid race with ksmd. ++ */ ++ err = ksm_execve(mm); ++ if (err) ++ goto err_ksm; ++ + /* + * Place the stack at the largest stack address the architecture + * supports. Later, we'll move this to an appropriate place. We don't +@@ -288,6 +297,8 @@ static int __bprm_mm_init(struct linux_binprm *bprm) + bprm->p = vma->vm_end - sizeof(void *); + return 0; + err: ++ ksm_exit(mm); ++err_ksm: + mmap_write_unlock(mm); + err_free: + bprm->vma = NULL; +diff --git a/include/linux/ksm.h b/include/linux/ksm.h +index 401348e9f92b4..7e2b1de3996ac 100644 +--- a/include/linux/ksm.h ++++ b/include/linux/ksm.h +@@ -59,6 +59,14 @@ static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm) + return 0; + } + ++static inline int ksm_execve(struct mm_struct *mm) ++{ ++ if (test_bit(MMF_VM_MERGE_ANY, &mm->flags)) ++ return __ksm_enter(mm); ++ ++ return 0; ++} ++ + static inline void ksm_exit(struct mm_struct *mm) + { + if (test_bit(MMF_VM_MERGEABLE, &mm->flags)) +@@ -107,6 +115,11 @@ static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm) + return 0; + } + ++static inline int ksm_execve(struct mm_struct *mm) ++{ ++ return 0; ++} ++ + static inline void ksm_exit(struct mm_struct *mm) + { + } +-- +2.43.0 + diff --git a/queue-6.8/mm-slub-kunit-use-inverted-data-to-corrupt-kmem-cach.patch b/queue-6.8/mm-slub-kunit-use-inverted-data-to-corrupt-kmem-cach.patch new file mode 100644 index 00000000000..b83d632f20b --- /dev/null +++ b/queue-6.8/mm-slub-kunit-use-inverted-data-to-corrupt-kmem-cach.patch @@ -0,0 +1,69 @@ +From 5f55866107f1775e15554f77c6c8884314f76ef1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 06:38:39 -0700 +Subject: mm/slub, kunit: Use inverted data to corrupt kmem cache + +From: Guenter Roeck + +[ Upstream commit b1080c667b3b2c8c38a7fa83ca5567124887abae ] + +Two failure patterns are seen randomly when running slub_kunit tests with +CONFIG_SLAB_FREELIST_RANDOM and CONFIG_SLAB_FREELIST_HARDENED enabled. + +Pattern 1: + # test_clobber_zone: pass:1 fail:0 skip:0 total:1 + ok 1 test_clobber_zone + # test_next_pointer: EXPECTATION FAILED at lib/slub_kunit.c:72 + Expected 3 == slab_errors, but + slab_errors == 0 (0x0) + # test_next_pointer: EXPECTATION FAILED at lib/slub_kunit.c:84 + Expected 2 == slab_errors, but + slab_errors == 0 (0x0) + # test_next_pointer: pass:0 fail:1 skip:0 total:1 + not ok 2 test_next_pointer + +In this case, test_next_pointer() overwrites p[s->offset], but the data +at p[s->offset] is already 0x12. + +Pattern 2: + ok 1 test_clobber_zone + # test_next_pointer: EXPECTATION FAILED at lib/slub_kunit.c:72 + Expected 3 == slab_errors, but + slab_errors == 2 (0x2) + # test_next_pointer: pass:0 fail:1 skip:0 total:1 + not ok 2 test_next_pointer + +In this case, p[s->offset] has a value other than 0x12, but one of the +expected failures is nevertheless missing. + +Invert data instead of writing a fixed value to corrupt the cache data +structures to fix the problem. + +Fixes: 1f9f78b1b376 ("mm/slub, kunit: add a KUnit test for SLUB debugging functionality") +Cc: Oliver Glitta +Cc: Vlastimil Babka +CC: Daniel Latypov +Cc: Marco Elver +Signed-off-by: Guenter Roeck +Signed-off-by: Vlastimil Babka +Signed-off-by: Sasha Levin +--- + lib/slub_kunit.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c +index d4a3730b08fa7..4ce9604388069 100644 +--- a/lib/slub_kunit.c ++++ b/lib/slub_kunit.c +@@ -55,7 +55,7 @@ static void test_next_pointer(struct kunit *test) + + ptr_addr = (unsigned long *)(p + s->offset); + tmp = *ptr_addr; +- p[s->offset] = 0x12; ++ p[s->offset] = ~p[s->offset]; + + /* + * Expecting three errors. +-- +2.43.0 + diff --git a/queue-6.8/mm-userfaultfd-do-not-place-zeropages-when-zeropages.patch b/queue-6.8/mm-userfaultfd-do-not-place-zeropages-when-zeropages.patch new file mode 100644 index 00000000000..fc82cf4f0e0 --- /dev/null +++ b/queue-6.8/mm-userfaultfd-do-not-place-zeropages-when-zeropages.patch @@ -0,0 +1,95 @@ +From 1a6e0bc5723868841619e86a37767c7d9f0c1938 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 18:14:40 +0200 +Subject: mm/userfaultfd: Do not place zeropages when zeropages are disallowed + +From: David Hildenbrand + +[ Upstream commit 90a7592da14951bd21f74a53246ba30955a648aa ] + +s390x must disable shared zeropages for processes running VMs, because +the VMs could end up making use of "storage keys" or protected +virtualization, which are incompatible with shared zeropages. + +Yet, with userfaultfd it is possible to insert shared zeropages into +such processes. Let's fallback to simply allocating a fresh zeroed +anonymous folio and insert that instead. + +mm_forbids_zeropage() was introduced in commit 593befa6ab74 ("mm: introduce +mm_forbids_zeropage function"), briefly before userfaultfd went +upstream. + +Note that we don't want to fail the UFFDIO_ZEROPAGE request like we do +for hugetlb, it would be rather unexpected. Further, we also +cannot really indicated "not supported" to user space ahead of time: it +could be that the MM disallows zeropages after userfaultfd was already +registered. + +[ agordeev: Fixed checkpatch complaints ] + +Fixes: c1a4de99fada ("userfaultfd: mcopy_atomic|mfill_zeropage: UFFDIO_COPY|UFFDIO_ZEROPAGE preparation") +Reviewed-by: Peter Xu +Link: https://lore.kernel.org/r/20240411161441.910170-2-david@redhat.com +Signed-off-by: David Hildenbrand +Signed-off-by: Alexander Gordeev +Signed-off-by: Sasha Levin +--- + mm/userfaultfd.c | 35 +++++++++++++++++++++++++++++++++++ + 1 file changed, 35 insertions(+) + +diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c +index 313f1c42768a6..aa8f5a6c324ee 100644 +--- a/mm/userfaultfd.c ++++ b/mm/userfaultfd.c +@@ -213,6 +213,38 @@ static int mfill_atomic_pte_copy(pmd_t *dst_pmd, + goto out; + } + ++static int mfill_atomic_pte_zeroed_folio(pmd_t *dst_pmd, ++ struct vm_area_struct *dst_vma, ++ unsigned long dst_addr) ++{ ++ struct folio *folio; ++ int ret = -ENOMEM; ++ ++ folio = vma_alloc_zeroed_movable_folio(dst_vma, dst_addr); ++ if (!folio) ++ return ret; ++ ++ if (mem_cgroup_charge(folio, dst_vma->vm_mm, GFP_KERNEL)) ++ goto out_put; ++ ++ /* ++ * The memory barrier inside __folio_mark_uptodate makes sure that ++ * zeroing out the folio become visible before mapping the page ++ * using set_pte_at(). See do_anonymous_page(). ++ */ ++ __folio_mark_uptodate(folio); ++ ++ ret = mfill_atomic_install_pte(dst_pmd, dst_vma, dst_addr, ++ &folio->page, true, 0); ++ if (ret) ++ goto out_put; ++ ++ return 0; ++out_put: ++ folio_put(folio); ++ return ret; ++} ++ + static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, + struct vm_area_struct *dst_vma, + unsigned long dst_addr) +@@ -221,6 +253,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, + spinlock_t *ptl; + int ret; + ++ if (mm_forbids_zeropage(dst_vma->vm_mm)) ++ return mfill_atomic_pte_zeroed_folio(dst_pmd, dst_vma, dst_addr); ++ + _dst_pte = pte_mkspecial(pfn_pte(my_zero_pfn(dst_addr), + dst_vma->vm_page_prot)); + ret = -EAGAIN; +-- +2.43.0 + diff --git a/queue-6.8/modules-drop-the-.export_symbol-section-from-the-fin.patch b/queue-6.8/modules-drop-the-.export_symbol-section-from-the-fin.patch new file mode 100644 index 00000000000..5be4042e1c1 --- /dev/null +++ b/queue-6.8/modules-drop-the-.export_symbol-section-from-the-fin.patch @@ -0,0 +1,35 @@ +From 43fd623459c057b2459d3319787237ea4b00fdd0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 17 Apr 2024 13:35:30 +0800 +Subject: modules: Drop the .export_symbol section from the final modules + +From: Wang Yao + +[ Upstream commit 8fe51b45c5645c259f759479c374648e9dfeaa03 ] + +Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") +forget drop the .export_symbol section from the final modules. + +Fixes: ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") +Signed-off-by: Wang Yao +Signed-off-by: Masahiro Yamada +Signed-off-by: Sasha Levin +--- + scripts/module.lds.S | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/scripts/module.lds.S b/scripts/module.lds.S +index bf5bcf2836d81..89ff01a22634f 100644 +--- a/scripts/module.lds.S ++++ b/scripts/module.lds.S +@@ -13,6 +13,7 @@ SECTIONS { + /DISCARD/ : { + *(.discard) + *(.discard.*) ++ *(.export_symbol) + } + + __ksymtab 0 : { *(SORT(___ksymtab+*)) } +-- +2.43.0 + diff --git a/queue-6.8/mptcp-avoid-some-duplicate-code-in-socket-option-han.patch b/queue-6.8/mptcp-avoid-some-duplicate-code-in-socket-option-han.patch new file mode 100644 index 00000000000..380455a9e47 --- /dev/null +++ b/queue-6.8/mptcp-avoid-some-duplicate-code-in-socket-option-han.patch @@ -0,0 +1,66 @@ +From 8f4a2a492019fac74d902155d0efa5341e4b98ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 18:43:45 +0100 +Subject: mptcp: avoid some duplicate code in socket option handling + +From: Paolo Abeni + +[ Upstream commit a74762675f700a5473ebe54a671a0788a5b23cc9 ] + +The mptcp_get_int_option() helper is needless open-coded in a +couple of places, replace the duplicate code with the helper +call. + +Signed-off-by: Paolo Abeni +Reviewed-by: Mat Martineau +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: David S. Miller +Stable-dep-of: bd11dc4fb969 ("mptcp: fix full TCP keep-alive support") +Signed-off-by: Sasha Levin +--- + net/mptcp/sockopt.c | 20 ++++++++------------ + 1 file changed, 8 insertions(+), 12 deletions(-) + +diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c +index f361d02f94b7e..82d0cd0819f09 100644 +--- a/net/mptcp/sockopt.c ++++ b/net/mptcp/sockopt.c +@@ -627,13 +627,11 @@ static int mptcp_setsockopt_sol_tcp_cork(struct mptcp_sock *msk, sockptr_t optva + { + struct mptcp_subflow_context *subflow; + struct sock *sk = (struct sock *)msk; +- int val; +- +- if (optlen < sizeof(int)) +- return -EINVAL; ++ int val, ret; + +- if (copy_from_sockptr(&val, optval, sizeof(val))) +- return -EFAULT; ++ ret = mptcp_get_int_option(msk, optval, optlen, &val); ++ if (ret) ++ return ret; + + lock_sock(sk); + sockopt_seq_inc(msk); +@@ -657,13 +655,11 @@ static int mptcp_setsockopt_sol_tcp_nodelay(struct mptcp_sock *msk, sockptr_t op + { + struct mptcp_subflow_context *subflow; + struct sock *sk = (struct sock *)msk; +- int val; +- +- if (optlen < sizeof(int)) +- return -EINVAL; ++ int val, ret; + +- if (copy_from_sockptr(&val, optval, sizeof(val))) +- return -EFAULT; ++ ret = mptcp_get_int_option(msk, optval, optlen, &val); ++ if (ret) ++ return ret; + + lock_sock(sk); + sockopt_seq_inc(msk); +-- +2.43.0 + diff --git a/queue-6.8/mptcp-cleanup-sol_tcp-handling.patch b/queue-6.8/mptcp-cleanup-sol_tcp-handling.patch new file mode 100644 index 00000000000..f75caf1de21 --- /dev/null +++ b/queue-6.8/mptcp-cleanup-sol_tcp-handling.patch @@ -0,0 +1,157 @@ +From 42d8a05907bb7cb4d2365c53a5e54164174712d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 18:43:47 +0100 +Subject: mptcp: cleanup SOL_TCP handling + +From: Paolo Abeni + +[ Upstream commit 7f71a337b5152ea0e7bef408d1af53778a919316 ] + +Most TCP-level socket options get an integer from user space, and +set the corresponding field under the msk-level socket lock. + +Reduce the code duplication moving such operations in the common code. + +Signed-off-by: Paolo Abeni +Reviewed-by: Mat Martineau +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: David S. Miller +Stable-dep-of: bd11dc4fb969 ("mptcp: fix full TCP keep-alive support") +Signed-off-by: Sasha Levin +--- + net/mptcp/sockopt.c | 75 ++++++++++++++++++--------------------------- + 1 file changed, 30 insertions(+), 45 deletions(-) + +diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c +index f2fe28a3912a9..b0a61ec8c2448 100644 +--- a/net/mptcp/sockopt.c ++++ b/net/mptcp/sockopt.c +@@ -622,18 +622,11 @@ static int mptcp_setsockopt_sol_tcp_congestion(struct mptcp_sock *msk, sockptr_t + return ret; + } + +-static int mptcp_setsockopt_sol_tcp_cork(struct mptcp_sock *msk, sockptr_t optval, +- unsigned int optlen) ++static int __mptcp_setsockopt_sol_tcp_cork(struct mptcp_sock *msk, int val) + { + struct mptcp_subflow_context *subflow; + struct sock *sk = (struct sock *)msk; +- int val, ret; + +- ret = mptcp_get_int_option(msk, optval, optlen, &val); +- if (ret) +- return ret; +- +- lock_sock(sk); + sockopt_seq_inc(msk); + msk->cork = !!val; + mptcp_for_each_subflow(msk, subflow) { +@@ -645,23 +638,15 @@ static int mptcp_setsockopt_sol_tcp_cork(struct mptcp_sock *msk, sockptr_t optva + } + if (!val) + mptcp_check_and_set_pending(sk); +- release_sock(sk); + + return 0; + } + +-static int mptcp_setsockopt_sol_tcp_nodelay(struct mptcp_sock *msk, sockptr_t optval, +- unsigned int optlen) ++static int __mptcp_setsockopt_sol_tcp_nodelay(struct mptcp_sock *msk, int val) + { + struct mptcp_subflow_context *subflow; + struct sock *sk = (struct sock *)msk; +- int val, ret; + +- ret = mptcp_get_int_option(msk, optval, optlen, &val); +- if (ret) +- return ret; +- +- lock_sock(sk); + sockopt_seq_inc(msk); + msk->nodelay = !!val; + mptcp_for_each_subflow(msk, subflow) { +@@ -673,8 +658,6 @@ static int mptcp_setsockopt_sol_tcp_nodelay(struct mptcp_sock *msk, sockptr_t op + } + if (val) + mptcp_check_and_set_pending(sk); +- release_sock(sk); +- + return 0; + } + +@@ -797,35 +780,10 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + int ret, val; + + switch (optname) { +- case TCP_INQ: +- ret = mptcp_get_int_option(msk, optval, optlen, &val); +- if (ret) +- return ret; +- if (val < 0 || val > 1) +- return -EINVAL; +- +- lock_sock(sk); +- msk->recvmsg_inq = !!val; +- release_sock(sk); +- return 0; + case TCP_ULP: + return -EOPNOTSUPP; +- case TCP_NOTSENT_LOWAT: +- ret = mptcp_get_int_option(msk, optval, optlen, &val); +- if (ret) +- return ret; +- +- lock_sock(sk); +- WRITE_ONCE(msk->notsent_lowat, val); +- mptcp_write_space(sk); +- release_sock(sk); +- return 0; + case TCP_CONGESTION: + return mptcp_setsockopt_sol_tcp_congestion(msk, optval, optlen); +- case TCP_CORK: +- return mptcp_setsockopt_sol_tcp_cork(msk, optval, optlen); +- case TCP_NODELAY: +- return mptcp_setsockopt_sol_tcp_nodelay(msk, optval, optlen); + case TCP_DEFER_ACCEPT: + /* See tcp.c: TCP_DEFER_ACCEPT does not fail */ + mptcp_setsockopt_first_sf_only(msk, SOL_TCP, optname, optval, optlen); +@@ -838,7 +796,34 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + optval, optlen); + } + +- return -EOPNOTSUPP; ++ ret = mptcp_get_int_option(msk, optval, optlen, &val); ++ if (ret) ++ return ret; ++ ++ lock_sock(sk); ++ switch (optname) { ++ case TCP_INQ: ++ if (val < 0 || val > 1) ++ ret = -EINVAL; ++ else ++ msk->recvmsg_inq = !!val; ++ break; ++ case TCP_NOTSENT_LOWAT: ++ WRITE_ONCE(msk->notsent_lowat, val); ++ mptcp_write_space(sk); ++ break; ++ case TCP_CORK: ++ ret = __mptcp_setsockopt_sol_tcp_cork(msk, val); ++ break; ++ case TCP_NODELAY: ++ ret = __mptcp_setsockopt_sol_tcp_nodelay(msk, val); ++ break; ++ default: ++ ret = -ENOPROTOOPT; ++ } ++ ++ release_sock(sk); ++ return ret; + } + + int mptcp_setsockopt(struct sock *sk, int level, int optname, +-- +2.43.0 + diff --git a/queue-6.8/mptcp-cleanup-writer-wake-up.patch b/queue-6.8/mptcp-cleanup-writer-wake-up.patch new file mode 100644 index 00000000000..4f43a8e1306 --- /dev/null +++ b/queue-6.8/mptcp-cleanup-writer-wake-up.patch @@ -0,0 +1,104 @@ +From e1ff0d5c87a68d0fde4cf00df535e1747b96e2c3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 18:43:44 +0100 +Subject: mptcp: cleanup writer wake-up + +From: Paolo Abeni + +[ Upstream commit 037db6ea57da7a134a8183dead92d64ef92babee ] + +After commit 5cf92bbadc58 ("mptcp: re-enable sndbuf autotune"), the +MPTCP_NOSPACE bit is redundant: it is always set and cleared together with +SOCK_NOSPACE. + +Let's drop the first and always relay on the latter, dropping a bunch +of useless code. + +Signed-off-by: Paolo Abeni +Reviewed-by: Mat Martineau +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: David S. Miller +Stable-dep-of: bd11dc4fb969 ("mptcp: fix full TCP keep-alive support") +Signed-off-by: Sasha Levin +--- + net/mptcp/protocol.c | 15 +++------------ + net/mptcp/protocol.h | 16 ++++++---------- + 2 files changed, 9 insertions(+), 22 deletions(-) + +diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c +index 74c1faec271d1..fcd85adc621c1 100644 +--- a/net/mptcp/protocol.c ++++ b/net/mptcp/protocol.c +@@ -1687,15 +1687,6 @@ static void __mptcp_subflow_push_pending(struct sock *sk, struct sock *ssk, bool + } + } + +-static void mptcp_set_nospace(struct sock *sk) +-{ +- /* enable autotune */ +- set_bit(SOCK_NOSPACE, &sk->sk_socket->flags); +- +- /* will be cleared on avail space */ +- set_bit(MPTCP_NOSPACE, &mptcp_sk(sk)->flags); +-} +- + static int mptcp_disconnect(struct sock *sk, int flags); + + static int mptcp_sendmsg_fastopen(struct sock *sk, struct msghdr *msg, +@@ -1869,7 +1860,7 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) + continue; + + wait_for_memory: +- mptcp_set_nospace(sk); ++ set_bit(SOCK_NOSPACE, &sk->sk_socket->flags); + __mptcp_push_pending(sk, msg->msg_flags); + ret = sk_stream_wait_memory(sk, &timeo); + if (ret) +@@ -3944,8 +3935,8 @@ static __poll_t mptcp_check_writeable(struct mptcp_sock *msk) + if (sk_stream_is_writeable(sk)) + return EPOLLOUT | EPOLLWRNORM; + +- mptcp_set_nospace(sk); +- smp_mb__after_atomic(); /* msk->flags is changed by write_space cb */ ++ set_bit(SOCK_NOSPACE, &sk->sk_socket->flags); ++ smp_mb__after_atomic(); /* NOSPACE is changed by mptcp_write_space() */ + if (sk_stream_is_writeable(sk)) + return EPOLLOUT | EPOLLWRNORM; + +diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h +index 07f6242afc1ae..6b83869ef7938 100644 +--- a/net/mptcp/protocol.h ++++ b/net/mptcp/protocol.h +@@ -113,10 +113,9 @@ + #define MPTCP_RST_TRANSIENT BIT(0) + + /* MPTCP socket atomic flags */ +-#define MPTCP_NOSPACE 1 +-#define MPTCP_WORK_RTX 2 +-#define MPTCP_FALLBACK_DONE 4 +-#define MPTCP_WORK_CLOSE_SUBFLOW 5 ++#define MPTCP_WORK_RTX 1 ++#define MPTCP_FALLBACK_DONE 2 ++#define MPTCP_WORK_CLOSE_SUBFLOW 3 + + /* MPTCP socket release cb flags */ + #define MPTCP_PUSH_PENDING 1 +@@ -792,12 +791,9 @@ static inline bool mptcp_data_fin_enabled(const struct mptcp_sock *msk) + + static inline void mptcp_write_space(struct sock *sk) + { +- if (sk_stream_is_writeable(sk)) { +- /* pairs with memory barrier in mptcp_poll */ +- smp_mb(); +- if (test_and_clear_bit(MPTCP_NOSPACE, &mptcp_sk(sk)->flags)) +- sk_stream_write_space(sk); +- } ++ /* pairs with memory barrier in mptcp_poll */ ++ smp_mb(); ++ sk_stream_write_space(sk); + } + + static inline void __mptcp_sync_sndbuf(struct sock *sk) +-- +2.43.0 + diff --git a/queue-6.8/mptcp-fix-full-tcp-keep-alive-support.patch b/queue-6.8/mptcp-fix-full-tcp-keep-alive-support.patch new file mode 100644 index 00000000000..0e1f9fab86b --- /dev/null +++ b/queue-6.8/mptcp-fix-full-tcp-keep-alive-support.patch @@ -0,0 +1,157 @@ +From 8b9315c5244bd68763092e634d85184fe3aa66c0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 18:13:26 -0700 +Subject: mptcp: fix full TCP keep-alive support + +From: Matthieu Baerts (NGI0) + +[ Upstream commit bd11dc4fb969ec148e50cd87f88a78246dbc4d0b ] + +SO_KEEPALIVE support has been added a while ago, as part of a series +"adding SOL_SOCKET" support. To have a full control of this keep-alive +feature, it is important to also support TCP_KEEP* socket options at the +SOL_TCP level. + +Supporting them on the setsockopt() part is easy, it is just a matter of +remembering each value in the MPTCP sock structure, and calling +tcp_sock_set_keep*() helpers on each subflow. If the value is not +modified (0), calling these helpers will not do anything. For the +getsockopt() part, the corresponding value from the MPTCP sock structure +or the default one is simply returned. All of this is very similar to +other TCP_* socket options supported by MPTCP. + +It looks important for kernels supporting SO_KEEPALIVE, to also support +TCP_KEEP* options as well: some apps seem to (wrongly) consider that if +the former is supported, the latter ones will be supported as well. But +also, not having this simple and isolated change is preventing MPTCP +support in some apps, and libraries like GoLang [1]. This is why this +patch is seen as a fix. + +Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/383 +Fixes: 1b3e7ede1365 ("mptcp: setsockopt: handle SO_KEEPALIVE and SO_PRIORITY") +Link: https://github.com/golang/go/issues/56539 [1] +Acked-by: Paolo Abeni +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: Mat Martineau +Link: https://lore.kernel.org/r/20240514011335.176158-3-martineau@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/mptcp/protocol.h | 3 +++ + net/mptcp/sockopt.c | 58 ++++++++++++++++++++++++++++++++++++++++++++ + 2 files changed, 61 insertions(+) + +diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h +index 2f17f295d7c8b..5f4c10c41c77d 100644 +--- a/net/mptcp/protocol.h ++++ b/net/mptcp/protocol.h +@@ -306,6 +306,9 @@ struct mptcp_sock { + free_first:1, + rcvspace_init:1; + u32 notsent_lowat; ++ int keepalive_cnt; ++ int keepalive_idle; ++ int keepalive_intvl; + struct work_struct work; + struct sk_buff *ooo_last_skb; + struct rb_root out_of_order_queue; +diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c +index b0a61ec8c2448..47aa826ba5fea 100644 +--- a/net/mptcp/sockopt.c ++++ b/net/mptcp/sockopt.c +@@ -622,6 +622,31 @@ static int mptcp_setsockopt_sol_tcp_congestion(struct mptcp_sock *msk, sockptr_t + return ret; + } + ++static int __mptcp_setsockopt_set_val(struct mptcp_sock *msk, int max, ++ int (*set_val)(struct sock *, int), ++ int *msk_val, int val) ++{ ++ struct mptcp_subflow_context *subflow; ++ int err = 0; ++ ++ mptcp_for_each_subflow(msk, subflow) { ++ struct sock *ssk = mptcp_subflow_tcp_sock(subflow); ++ int ret; ++ ++ lock_sock(ssk); ++ ret = set_val(ssk, val); ++ err = err ? : ret; ++ release_sock(ssk); ++ } ++ ++ if (!err) { ++ *msk_val = val; ++ sockopt_seq_inc(msk); ++ } ++ ++ return err; ++} ++ + static int __mptcp_setsockopt_sol_tcp_cork(struct mptcp_sock *msk, int val) + { + struct mptcp_subflow_context *subflow; +@@ -818,6 +843,22 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + case TCP_NODELAY: + ret = __mptcp_setsockopt_sol_tcp_nodelay(msk, val); + break; ++ case TCP_KEEPIDLE: ++ ret = __mptcp_setsockopt_set_val(msk, MAX_TCP_KEEPIDLE, ++ &tcp_sock_set_keepidle_locked, ++ &msk->keepalive_idle, val); ++ break; ++ case TCP_KEEPINTVL: ++ ret = __mptcp_setsockopt_set_val(msk, MAX_TCP_KEEPINTVL, ++ &tcp_sock_set_keepintvl, ++ &msk->keepalive_intvl, val); ++ break; ++ case TCP_KEEPCNT: ++ ret = __mptcp_setsockopt_set_val(msk, MAX_TCP_KEEPCNT, ++ &tcp_sock_set_keepcnt, ++ &msk->keepalive_cnt, ++ val); ++ break; + default: + ret = -ENOPROTOOPT; + } +@@ -1320,6 +1361,8 @@ static int mptcp_put_int_option(struct mptcp_sock *msk, char __user *optval, + static int mptcp_getsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + char __user *optval, int __user *optlen) + { ++ struct sock *sk = (void *)msk; ++ + switch (optname) { + case TCP_ULP: + case TCP_CONGESTION: +@@ -1338,6 +1381,18 @@ static int mptcp_getsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + return mptcp_put_int_option(msk, optval, optlen, msk->cork); + case TCP_NODELAY: + return mptcp_put_int_option(msk, optval, optlen, msk->nodelay); ++ case TCP_KEEPIDLE: ++ return mptcp_put_int_option(msk, optval, optlen, ++ msk->keepalive_idle ? : ++ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_keepalive_time) / HZ); ++ case TCP_KEEPINTVL: ++ return mptcp_put_int_option(msk, optval, optlen, ++ msk->keepalive_intvl ? : ++ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_keepalive_intvl) / HZ); ++ case TCP_KEEPCNT: ++ return mptcp_put_int_option(msk, optval, optlen, ++ msk->keepalive_cnt ? : ++ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_keepalive_probes)); + case TCP_NOTSENT_LOWAT: + return mptcp_put_int_option(msk, optval, optlen, msk->notsent_lowat); + } +@@ -1455,6 +1510,9 @@ static void sync_socket_options(struct mptcp_sock *msk, struct sock *ssk) + tcp_set_congestion_control(ssk, msk->ca_name, false, true); + __tcp_sock_set_cork(ssk, !!msk->cork); + __tcp_sock_set_nodelay(ssk, !!msk->nodelay); ++ tcp_sock_set_keepidle_locked(ssk, msk->keepalive_idle); ++ tcp_sock_set_keepintvl(ssk, msk->keepalive_intvl); ++ tcp_sock_set_keepcnt(ssk, msk->keepalive_cnt); + + inet_assign_bit(TRANSPARENT, ssk, inet_test_bit(TRANSPARENT, sk)); + inet_assign_bit(FREEBIND, ssk, inet_test_bit(FREEBIND, sk)); +-- +2.43.0 + diff --git a/queue-6.8/mptcp-implement-tcp_notsent_lowat-support.patch b/queue-6.8/mptcp-implement-tcp_notsent_lowat-support.patch new file mode 100644 index 00000000000..2d49aecf959 --- /dev/null +++ b/queue-6.8/mptcp-implement-tcp_notsent_lowat-support.patch @@ -0,0 +1,202 @@ +From 2a46eda8186692bbbf798c05afd9481c5d708887 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 18:43:46 +0100 +Subject: mptcp: implement TCP_NOTSENT_LOWAT support + +From: Paolo Abeni + +[ Upstream commit 29b5e5ef87397963ca38d3eec0d296ad1c979bbc ] + +Add support for such socket option storing the user-space provided +value in a new msk field, and using such data to implement the +_mptcp_stream_memory_free() helper, similar to the TCP one. + +To avoid adding more indirect calls in the fast path, open-code +a variant of sk_stream_memory_free() in mptcp_sendmsg() and add +direct calls to the mptcp stream memory free helper where possible. + +Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/464 +Signed-off-by: Paolo Abeni +Reviewed-by: Mat Martineau +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: David S. Miller +Stable-dep-of: bd11dc4fb969 ("mptcp: fix full TCP keep-alive support") +Signed-off-by: Sasha Levin +--- + net/mptcp/protocol.c | 39 ++++++++++++++++++++++++++++++++++----- + net/mptcp/protocol.h | 28 +++++++++++++++++++++++++++- + net/mptcp/sockopt.c | 12 ++++++++++++ + 3 files changed, 73 insertions(+), 6 deletions(-) + +diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c +index fcd85adc621c1..54e29ab911f0d 100644 +--- a/net/mptcp/protocol.c ++++ b/net/mptcp/protocol.c +@@ -1757,6 +1757,30 @@ static int do_copy_data_nocache(struct sock *sk, int copy, + return 0; + } + ++/* open-code sk_stream_memory_free() plus sent limit computation to ++ * avoid indirect calls in fast-path. ++ * Called under the msk socket lock, so we can avoid a bunch of ONCE ++ * annotations. ++ */ ++static u32 mptcp_send_limit(const struct sock *sk) ++{ ++ const struct mptcp_sock *msk = mptcp_sk(sk); ++ u32 limit, not_sent; ++ ++ if (sk->sk_wmem_queued >= READ_ONCE(sk->sk_sndbuf)) ++ return 0; ++ ++ limit = mptcp_notsent_lowat(sk); ++ if (limit == UINT_MAX) ++ return UINT_MAX; ++ ++ not_sent = msk->write_seq - msk->snd_nxt; ++ if (not_sent >= limit) ++ return 0; ++ ++ return limit - not_sent; ++} ++ + static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) + { + struct mptcp_sock *msk = mptcp_sk(sk); +@@ -1801,6 +1825,12 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) + struct mptcp_data_frag *dfrag; + bool dfrag_collapsed; + size_t psize, offset; ++ u32 copy_limit; ++ ++ /* ensure fitting the notsent_lowat() constraint */ ++ copy_limit = mptcp_send_limit(sk); ++ if (!copy_limit) ++ goto wait_for_memory; + + /* reuse tail pfrag, if possible, or carve a new one from the + * page allocator +@@ -1808,9 +1838,6 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) + dfrag = mptcp_pending_tail(sk); + dfrag_collapsed = mptcp_frag_can_collapse_to(msk, pfrag, dfrag); + if (!dfrag_collapsed) { +- if (!sk_stream_memory_free(sk)) +- goto wait_for_memory; +- + if (!mptcp_page_frag_refill(sk, pfrag)) + goto wait_for_memory; + +@@ -1825,6 +1852,7 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) + offset = dfrag->offset + dfrag->data_len; + psize = pfrag->size - offset; + psize = min_t(size_t, psize, msg_data_left(msg)); ++ psize = min_t(size_t, psize, copy_limit); + total_ts = psize + frag_truesize; + + if (!sk_wmem_schedule(sk, total_ts)) +@@ -3761,6 +3789,7 @@ static struct proto mptcp_prot = { + .unhash = mptcp_unhash, + .get_port = mptcp_get_port, + .forward_alloc_get = mptcp_forward_alloc_get, ++ .stream_memory_free = mptcp_stream_memory_free, + .sockets_allocated = &mptcp_sockets_allocated, + + .memory_allocated = &tcp_memory_allocated, +@@ -3932,12 +3961,12 @@ static __poll_t mptcp_check_writeable(struct mptcp_sock *msk) + { + struct sock *sk = (struct sock *)msk; + +- if (sk_stream_is_writeable(sk)) ++ if (__mptcp_stream_is_writeable(sk, 1)) + return EPOLLOUT | EPOLLWRNORM; + + set_bit(SOCK_NOSPACE, &sk->sk_socket->flags); + smp_mb__after_atomic(); /* NOSPACE is changed by mptcp_write_space() */ +- if (sk_stream_is_writeable(sk)) ++ if (__mptcp_stream_is_writeable(sk, 1)) + return EPOLLOUT | EPOLLWRNORM; + + return 0; +diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h +index 6b83869ef7938..2f17f295d7c8b 100644 +--- a/net/mptcp/protocol.h ++++ b/net/mptcp/protocol.h +@@ -305,6 +305,7 @@ struct mptcp_sock { + in_accept_queue:1, + free_first:1, + rcvspace_init:1; ++ u32 notsent_lowat; + struct work_struct work; + struct sk_buff *ooo_last_skb; + struct rb_root out_of_order_queue; +@@ -789,11 +790,36 @@ static inline bool mptcp_data_fin_enabled(const struct mptcp_sock *msk) + READ_ONCE(msk->write_seq) == READ_ONCE(msk->snd_nxt); + } + ++static inline u32 mptcp_notsent_lowat(const struct sock *sk) ++{ ++ struct net *net = sock_net(sk); ++ u32 val; ++ ++ val = READ_ONCE(mptcp_sk(sk)->notsent_lowat); ++ return val ?: READ_ONCE(net->ipv4.sysctl_tcp_notsent_lowat); ++} ++ ++static inline bool mptcp_stream_memory_free(const struct sock *sk, int wake) ++{ ++ const struct mptcp_sock *msk = mptcp_sk(sk); ++ u32 notsent_bytes; ++ ++ notsent_bytes = READ_ONCE(msk->write_seq) - READ_ONCE(msk->snd_nxt); ++ return (notsent_bytes << wake) < mptcp_notsent_lowat(sk); ++} ++ ++static inline bool __mptcp_stream_is_writeable(const struct sock *sk, int wake) ++{ ++ return mptcp_stream_memory_free(sk, wake) && ++ __sk_stream_is_writeable(sk, wake); ++} ++ + static inline void mptcp_write_space(struct sock *sk) + { + /* pairs with memory barrier in mptcp_poll */ + smp_mb(); +- sk_stream_write_space(sk); ++ if (mptcp_stream_memory_free(sk, 1)) ++ sk_stream_write_space(sk); + } + + static inline void __mptcp_sync_sndbuf(struct sock *sk) +diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c +index 82d0cd0819f09..f2fe28a3912a9 100644 +--- a/net/mptcp/sockopt.c ++++ b/net/mptcp/sockopt.c +@@ -810,6 +810,16 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + return 0; + case TCP_ULP: + return -EOPNOTSUPP; ++ case TCP_NOTSENT_LOWAT: ++ ret = mptcp_get_int_option(msk, optval, optlen, &val); ++ if (ret) ++ return ret; ++ ++ lock_sock(sk); ++ WRITE_ONCE(msk->notsent_lowat, val); ++ mptcp_write_space(sk); ++ release_sock(sk); ++ return 0; + case TCP_CONGESTION: + return mptcp_setsockopt_sol_tcp_congestion(msk, optval, optlen); + case TCP_CORK: +@@ -1343,6 +1353,8 @@ static int mptcp_getsockopt_sol_tcp(struct mptcp_sock *msk, int optname, + return mptcp_put_int_option(msk, optval, optlen, msk->cork); + case TCP_NODELAY: + return mptcp_put_int_option(msk, optval, optlen, msk->nodelay); ++ case TCP_NOTSENT_LOWAT: ++ return mptcp_put_int_option(msk, optval, optlen, msk->notsent_lowat); + } + return -EOPNOTSUPP; + } +-- +2.43.0 + diff --git a/queue-6.8/mptcp-so_keepalive-fix-getsockopt-support.patch b/queue-6.8/mptcp-so_keepalive-fix-getsockopt-support.patch new file mode 100644 index 00000000000..efdef7a2121 --- /dev/null +++ b/queue-6.8/mptcp-so_keepalive-fix-getsockopt-support.patch @@ -0,0 +1,53 @@ +From 6b5ee0cfd8bcd90038e0b49764c78a621d6916b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 18:13:25 -0700 +Subject: mptcp: SO_KEEPALIVE: fix getsockopt support + +From: Matthieu Baerts (NGI0) + +[ Upstream commit a65198136eaa15b74ee0abf73f12ef83d469a334 ] + +SO_KEEPALIVE support has to be set on each subflow: on each TCP socket, +where sk_prot->keepalive is defined. Technically, nothing has to be done +on the MPTCP socket. That's why mptcp_sol_socket_sync_intval() was +called instead of mptcp_sol_socket_intval(). + +Except that when nothing is done on the MPTCP socket, the +getsockopt(SO_KEEPALIVE), handled in net/core/sock.c:sk_getsockopt(), +will not know if SO_KEEPALIVE has been set on the different subflows or +not. + +The fix is simple: simply call mptcp_sol_socket_intval() which will end +up calling net/core/sock.c:sk_setsockopt() where the SOCK_KEEPOPEN flag +will be set, the one used in sk_getsockopt(). + +So now, getsockopt(SO_KEEPALIVE) on an MPTCP socket will return the same +value as the one previously set with setsockopt(SO_KEEPALIVE). + +Fixes: 1b3e7ede1365 ("mptcp: setsockopt: handle SO_KEEPALIVE and SO_PRIORITY") +Acked-by: Paolo Abeni +Signed-off-by: Matthieu Baerts (NGI0) +Signed-off-by: Mat Martineau +Link: https://lore.kernel.org/r/20240514011335.176158-2-martineau@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/mptcp/sockopt.c | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c +index ef3edba754a32..f361d02f94b7e 100644 +--- a/net/mptcp/sockopt.c ++++ b/net/mptcp/sockopt.c +@@ -181,8 +181,6 @@ static int mptcp_setsockopt_sol_socket_int(struct mptcp_sock *msk, int optname, + + switch (optname) { + case SO_KEEPALIVE: +- mptcp_sol_socket_sync_intval(msk, optname, val); +- return 0; + case SO_DEBUG: + case SO_MARK: + case SO_PRIORITY: +-- +2.43.0 + diff --git a/queue-6.8/mtd-core-report-error-if-first-mtd_otp_size-call-fai.patch b/queue-6.8/mtd-core-report-error-if-first-mtd_otp_size-call-fai.patch new file mode 100644 index 00000000000..a6c2d20f350 --- /dev/null +++ b/queue-6.8/mtd-core-report-error-if-first-mtd_otp_size-call-fai.patch @@ -0,0 +1,44 @@ +From aab4581e2cc2e9e4ca88e6aab3d3aa7e3a58ca3a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 13 Mar 2024 19:34:24 +0200 +Subject: mtd: core: Report error if first mtd_otp_size() call fails in + mtd_otp_nvmem_add() + +From: Aapo Vienamo + +[ Upstream commit d44f0bbbd8d182debcce88bda55b05269f3d33d6 ] + +Jump to the error reporting code in mtd_otp_nvmem_add() if the +mtd_otp_size() call fails. Without this fix, the error is not logged. + +Signed-off-by: Aapo Vienamo +Reviewed-by: Mika Westerberg +Reviewed-by: Michael Walle +Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support") +Signed-off-by: Miquel Raynal +Link: https://lore.kernel.org/linux-mtd/20240313173425.1325790-2-aapo.vienamo@linux.intel.com +Signed-off-by: Sasha Levin +--- + drivers/mtd/mtdcore.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c +index 0de87bc638405..6d5c755411de0 100644 +--- a/drivers/mtd/mtdcore.c ++++ b/drivers/mtd/mtdcore.c +@@ -956,8 +956,10 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd) + + if (mtd->_get_user_prot_info && mtd->_read_user_prot_reg) { + size = mtd_otp_size(mtd, true); +- if (size < 0) +- return size; ++ if (size < 0) { ++ err = size; ++ goto err; ++ } + + if (size > 0) { + nvmem = mtd_otp_nvmem_register(mtd, "user-otp", size, +-- +2.43.0 + diff --git a/queue-6.8/mtd-rawnand-hynix-fixed-typo.patch b/queue-6.8/mtd-rawnand-hynix-fixed-typo.patch new file mode 100644 index 00000000000..05ba5ee9564 --- /dev/null +++ b/queue-6.8/mtd-rawnand-hynix-fixed-typo.patch @@ -0,0 +1,43 @@ +From b99e6ae9c853ac87685ede9dcdff1841b0b737b2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 13 Mar 2024 13:27:20 +0300 +Subject: mtd: rawnand: hynix: fixed typo + +From: Maxim Korotkov + +[ Upstream commit 6819db94e1cd3ce24a432f3616cd563ed0c4eaba ] + +The function hynix_nand_rr_init() should probably return an error code. +Judging by the usage, it seems that the return code is passed up +the call stack. +Right now, it always returns 0 and the function hynix_nand_cleanup() +in hynix_nand_init() has never been called. + +Found by RASU JSC and Linux Verification Center (linuxtesting.org) + +Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs") + +Signed-off-by: Maxim Korotkov +Signed-off-by: Miquel Raynal +Link: https://lore.kernel.org/linux-mtd/20240313102721.1991299-1-korotkov.maxim.s@gmail.com +Signed-off-by: Sasha Levin +--- + drivers/mtd/nand/raw/nand_hynix.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/mtd/nand/raw/nand_hynix.c b/drivers/mtd/nand/raw/nand_hynix.c +index 39076735a3fbb..9695f07b5eb26 100644 +--- a/drivers/mtd/nand/raw/nand_hynix.c ++++ b/drivers/mtd/nand/raw/nand_hynix.c +@@ -402,7 +402,7 @@ static int hynix_nand_rr_init(struct nand_chip *chip) + if (ret) + pr_warn("failed to initialize read-retry infrastructure"); + +- return 0; ++ return ret; + } + + static void hynix_nand_extract_oobsize(struct nand_chip *chip, +-- +2.43.0 + diff --git a/queue-6.8/net-bridge-mst-fix-vlan-use-after-free.patch b/queue-6.8/net-bridge-mst-fix-vlan-use-after-free.patch new file mode 100644 index 00000000000..07ee6a0b512 --- /dev/null +++ b/queue-6.8/net-bridge-mst-fix-vlan-use-after-free.patch @@ -0,0 +1,123 @@ +From e75a40b41c593c029785c556a606318b28049c6c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 14:06:27 +0300 +Subject: net: bridge: mst: fix vlan use-after-free + +From: Nikolay Aleksandrov + +[ Upstream commit 3a7c1661ae1383364cd6092d851f5e5da64d476b ] + +syzbot reported a suspicious rcu usage[1] in bridge's mst code. While +fixing it I noticed that nothing prevents a vlan to be freed while +walking the list from the same path (br forward delay timer). Fix the rcu +usage and also make sure we are not accessing freed memory by making +br_mst_vlan_set_state use rcu read lock. + +[1] + WARNING: suspicious RCU usage + 6.9.0-rc6-syzkaller #0 Not tainted + ----------------------------- + net/bridge/br_private.h:1599 suspicious rcu_dereference_protected() usage! + ... + stack backtrace: + CPU: 1 PID: 8017 Comm: syz-executor.1 Not tainted 6.9.0-rc6-syzkaller #0 + Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 + Call Trace: + + __dump_stack lib/dump_stack.c:88 [inline] + dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 + lockdep_rcu_suspicious+0x221/0x340 kernel/locking/lockdep.c:6712 + nbp_vlan_group net/bridge/br_private.h:1599 [inline] + br_mst_set_state+0x1ea/0x650 net/bridge/br_mst.c:105 + br_set_state+0x28a/0x7b0 net/bridge/br_stp.c:47 + br_forward_delay_timer_expired+0x176/0x440 net/bridge/br_stp_timer.c:88 + call_timer_fn+0x18e/0x650 kernel/time/timer.c:1793 + expire_timers kernel/time/timer.c:1844 [inline] + __run_timers kernel/time/timer.c:2418 [inline] + __run_timer_base+0x66a/0x8e0 kernel/time/timer.c:2429 + run_timer_base kernel/time/timer.c:2438 [inline] + run_timer_softirq+0xb7/0x170 kernel/time/timer.c:2448 + __do_softirq+0x2c6/0x980 kernel/softirq.c:554 + invoke_softirq kernel/softirq.c:428 [inline] + __irq_exit_rcu+0xf2/0x1c0 kernel/softirq.c:633 + irq_exit_rcu+0x9/0x30 kernel/softirq.c:645 + instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1043 [inline] + sysvec_apic_timer_interrupt+0xa6/0xc0 arch/x86/kernel/apic/apic.c:1043 + + + asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:702 + RIP: 0010:lock_acquire+0x264/0x550 kernel/locking/lockdep.c:5758 + Code: 2b 00 74 08 4c 89 f7 e8 ba d1 84 00 f6 44 24 61 02 0f 85 85 01 00 00 41 f7 c7 00 02 00 00 74 01 fb 48 c7 44 24 40 0e 36 e0 45 <4b> c7 44 25 00 00 00 00 00 43 c7 44 25 09 00 00 00 00 43 c7 44 25 + RSP: 0018:ffffc90013657100 EFLAGS: 00000206 + RAX: 0000000000000001 RBX: 1ffff920026cae2c RCX: 0000000000000001 + RDX: dffffc0000000000 RSI: ffffffff8bcaca00 RDI: ffffffff8c1eaa60 + RBP: ffffc90013657260 R08: ffffffff92efe507 R09: 1ffffffff25dfca0 + R10: dffffc0000000000 R11: fffffbfff25dfca1 R12: 1ffff920026cae28 + R13: dffffc0000000000 R14: ffffc90013657160 R15: 0000000000000246 + +Fixes: ec7328b59176 ("net: bridge: mst: Multiple Spanning Tree (MST) mode") +Reported-by: syzbot+fa04eb8a56fd923fc5d8@syzkaller.appspotmail.com +Closes: https://syzkaller.appspot.com/bug?extid=fa04eb8a56fd923fc5d8 +Signed-off-by: Nikolay Aleksandrov +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/bridge/br_mst.c | 16 ++++++++++------ + 1 file changed, 10 insertions(+), 6 deletions(-) + +diff --git a/net/bridge/br_mst.c b/net/bridge/br_mst.c +index ee680adcee179..3c66141d34d62 100644 +--- a/net/bridge/br_mst.c ++++ b/net/bridge/br_mst.c +@@ -78,7 +78,7 @@ static void br_mst_vlan_set_state(struct net_bridge_port *p, struct net_bridge_v + { + struct net_bridge_vlan_group *vg = nbp_vlan_group(p); + +- if (v->state == state) ++ if (br_vlan_get_state(v) == state) + return; + + br_vlan_set_state(v, state); +@@ -100,11 +100,12 @@ int br_mst_set_state(struct net_bridge_port *p, u16 msti, u8 state, + }; + struct net_bridge_vlan_group *vg; + struct net_bridge_vlan *v; +- int err; ++ int err = 0; + ++ rcu_read_lock(); + vg = nbp_vlan_group(p); + if (!vg) +- return 0; ++ goto out; + + /* MSTI 0 (CST) state changes are notified via the regular + * SWITCHDEV_ATTR_ID_PORT_STP_STATE. +@@ -112,17 +113,20 @@ int br_mst_set_state(struct net_bridge_port *p, u16 msti, u8 state, + if (msti) { + err = switchdev_port_attr_set(p->dev, &attr, extack); + if (err && err != -EOPNOTSUPP) +- return err; ++ goto out; + } + +- list_for_each_entry(v, &vg->vlan_list, vlist) { ++ err = 0; ++ list_for_each_entry_rcu(v, &vg->vlan_list, vlist) { + if (v->brvlan->msti != msti) + continue; + + br_mst_vlan_set_state(p, v, state); + } + +- return 0; ++out: ++ rcu_read_unlock(); ++ return err; + } + + static void br_mst_vlan_sync_state(struct net_bridge_vlan *pv, u16 msti) +-- +2.43.0 + diff --git a/queue-6.8/net-bridge-xmit-make-sure-we-have-at-least-eth-heade.patch b/queue-6.8/net-bridge-xmit-make-sure-we-have-at-least-eth-heade.patch new file mode 100644 index 00000000000..e178fc96f3d --- /dev/null +++ b/queue-6.8/net-bridge-xmit-make-sure-we-have-at-least-eth-heade.patch @@ -0,0 +1,90 @@ +From 32cdfb5bbfd405faf91ae20b9ed284eb6930987c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 13:34:19 +0300 +Subject: net: bridge: xmit: make sure we have at least eth header len bytes + +From: Nikolay Aleksandrov + +[ Upstream commit 8bd67ebb50c0145fd2ca8681ab65eb7e8cde1afc ] + +syzbot triggered an uninit value[1] error in bridge device's xmit path +by sending a short (less than ETH_HLEN bytes) skb. To fix it check if +we can actually pull that amount instead of assuming. + +Tested with dropwatch: + drop at: br_dev_xmit+0xb93/0x12d0 [bridge] (0xffffffffc06739b3) + origin: software + timestamp: Mon May 13 11:31:53 2024 778214037 nsec + protocol: 0x88a8 + length: 2 + original length: 2 + drop reason: PKT_TOO_SMALL + +[1] +BUG: KMSAN: uninit-value in br_dev_xmit+0x61d/0x1cb0 net/bridge/br_device.c:65 + br_dev_xmit+0x61d/0x1cb0 net/bridge/br_device.c:65 + __netdev_start_xmit include/linux/netdevice.h:4903 [inline] + netdev_start_xmit include/linux/netdevice.h:4917 [inline] + xmit_one net/core/dev.c:3531 [inline] + dev_hard_start_xmit+0x247/0xa20 net/core/dev.c:3547 + __dev_queue_xmit+0x34db/0x5350 net/core/dev.c:4341 + dev_queue_xmit include/linux/netdevice.h:3091 [inline] + __bpf_tx_skb net/core/filter.c:2136 [inline] + __bpf_redirect_common net/core/filter.c:2180 [inline] + __bpf_redirect+0x14a6/0x1620 net/core/filter.c:2187 + ____bpf_clone_redirect net/core/filter.c:2460 [inline] + bpf_clone_redirect+0x328/0x470 net/core/filter.c:2432 + ___bpf_prog_run+0x13fe/0xe0f0 kernel/bpf/core.c:1997 + __bpf_prog_run512+0xb5/0xe0 kernel/bpf/core.c:2238 + bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline] + __bpf_prog_run include/linux/filter.h:657 [inline] + bpf_prog_run include/linux/filter.h:664 [inline] + bpf_test_run+0x499/0xc30 net/bpf/test_run.c:425 + bpf_prog_test_run_skb+0x14ea/0x1f20 net/bpf/test_run.c:1058 + bpf_prog_test_run+0x6b7/0xad0 kernel/bpf/syscall.c:4269 + __sys_bpf+0x6aa/0xd90 kernel/bpf/syscall.c:5678 + __do_sys_bpf kernel/bpf/syscall.c:5767 [inline] + __se_sys_bpf kernel/bpf/syscall.c:5765 [inline] + __x64_sys_bpf+0xa0/0xe0 kernel/bpf/syscall.c:5765 + x64_sys_call+0x96b/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:322 + do_syscall_x64 arch/x86/entry/common.c:52 [inline] + do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 + entry_SYSCALL_64_after_hwframe+0x77/0x7f + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Reported-by: syzbot+a63a1f6a062033cf0f40@syzkaller.appspotmail.com +Closes: https://syzkaller.appspot.com/bug?extid=a63a1f6a062033cf0f40 +Signed-off-by: Nikolay Aleksandrov +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/bridge/br_device.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c +index 65cee0ad3c1b6..79b822be6c2e5 100644 +--- a/net/bridge/br_device.c ++++ b/net/bridge/br_device.c +@@ -27,6 +27,7 @@ EXPORT_SYMBOL_GPL(nf_br_ops); + /* net device transmit always called with BH disabled */ + netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) + { ++ enum skb_drop_reason reason = pskb_may_pull_reason(skb, ETH_HLEN); + struct net_bridge_mcast_port *pmctx_null = NULL; + struct net_bridge *br = netdev_priv(dev); + struct net_bridge_mcast *brmctx = &br->multicast_ctx; +@@ -38,6 +39,11 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) + const unsigned char *dest; + u16 vid = 0; + ++ if (unlikely(reason != SKB_NOT_DROPPED_YET)) { ++ kfree_skb_reason(skb, reason); ++ return NETDEV_TX_OK; ++ } ++ + memset(skb->cb, 0, sizeof(struct br_input_skb_cb)); + br_tc_skb_miss_set(skb, false); + +-- +2.43.0 + diff --git a/queue-6.8/net-dsa-mv88e6xxx-add-support-for-model-specific-pre.patch b/queue-6.8/net-dsa-mv88e6xxx-add-support-for-model-specific-pre.patch new file mode 100644 index 00000000000..c0ef4a8d984 --- /dev/null +++ b/queue-6.8/net-dsa-mv88e6xxx-add-support-for-model-specific-pre.patch @@ -0,0 +1,234 @@ +From df0d9b593f5c3c720cc3246b3b5d5c020a14a432 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 09:47:48 +0200 +Subject: net: dsa: mv88e6xxx: Add support for model-specific pre- and + post-reset handlers + +From: Matthias Schiffer + +[ Upstream commit 0fdd27b9d6d7c60bd319d3497ad797934bab13cb ] + +Instead of calling mv88e6xxx_g2_eeprom_wait() directly from +mv88e6xxx_hardware_reset(), add configurable pre- and post-reset hard +reset handlers. Initially, the handlers are set to +mv88e6xxx_g2_eeprom_wait() for all families that have get/set_eeprom() +to match the existing behavior. No functional change intended (except +for additional error messages on failure). + +Fixes: 6ccf50d4d474 ("net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent") +Signed-off-by: Matthias Schiffer +Reviewed-by: Andrew Lunn +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/dsa/mv88e6xxx/chip.c | 50 +++++++++++++++++++++++++++++--- + drivers/net/dsa/mv88e6xxx/chip.h | 6 ++++ + 2 files changed, 52 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c +index 967d9136313f4..77bb681cb2be9 100644 +--- a/drivers/net/dsa/mv88e6xxx/chip.c ++++ b/drivers/net/dsa/mv88e6xxx/chip.c +@@ -3135,6 +3135,7 @@ static int mv88e6xxx_software_reset(struct mv88e6xxx_chip *chip) + static void mv88e6xxx_hardware_reset(struct mv88e6xxx_chip *chip) + { + struct gpio_desc *gpiod = chip->reset; ++ int err; + + /* If there is a GPIO connected to the reset pin, toggle it */ + if (gpiod) { +@@ -3143,17 +3144,26 @@ static void mv88e6xxx_hardware_reset(struct mv88e6xxx_chip *chip) + * mid-byte, causing the first EEPROM read after the reset + * from the wrong location resulting in the switch booting + * to wrong mode and inoperable. ++ * For this reason, switch families with EEPROM support ++ * generally wait for EEPROM loads to complete as their pre- ++ * and post-reset handlers. + */ +- if (chip->info->ops->get_eeprom) +- mv88e6xxx_g2_eeprom_wait(chip); ++ if (chip->info->ops->hardware_reset_pre) { ++ err = chip->info->ops->hardware_reset_pre(chip); ++ if (err) ++ dev_err(chip->dev, "pre-reset error: %d\n", err); ++ } + + gpiod_set_value_cansleep(gpiod, 1); + usleep_range(10000, 20000); + gpiod_set_value_cansleep(gpiod, 0); + usleep_range(10000, 20000); + +- if (chip->info->ops->get_eeprom) +- mv88e6xxx_g2_eeprom_wait(chip); ++ if (chip->info->ops->hardware_reset_post) { ++ err = chip->info->ops->hardware_reset_post(chip); ++ if (err) ++ dev_err(chip->dev, "post-reset error: %d\n", err); ++ } + } + } + +@@ -4380,6 +4390,8 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4570,6 +4582,8 @@ static const struct mv88e6xxx_ops mv88e6172_ops = { + .watchdog_ops = &mv88e6097_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4670,6 +4684,8 @@ static const struct mv88e6xxx_ops mv88e6176_ops = { + .watchdog_ops = &mv88e6097_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4764,6 +4780,8 @@ static const struct mv88e6xxx_ops mv88e6190_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4822,6 +4840,8 @@ static const struct mv88e6xxx_ops mv88e6190x_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4878,6 +4898,8 @@ static const struct mv88e6xxx_ops mv88e6191_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4937,6 +4959,8 @@ static const struct mv88e6xxx_ops mv88e6240_ops = { + .watchdog_ops = &mv88e6097_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -4990,6 +5014,8 @@ static const struct mv88e6xxx_ops mv88e6250_ops = { + .watchdog_ops = &mv88e6250_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6250_g1_reset, + .vtu_getnext = mv88e6185_g1_vtu_getnext, + .vtu_loadpurge = mv88e6185_g1_vtu_loadpurge, +@@ -5037,6 +5063,8 @@ static const struct mv88e6xxx_ops mv88e6290_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -5096,6 +5124,8 @@ static const struct mv88e6xxx_ops mv88e6320_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .vtu_getnext = mv88e6185_g1_vtu_getnext, + .vtu_loadpurge = mv88e6185_g1_vtu_loadpurge, +@@ -5142,6 +5172,8 @@ static const struct mv88e6xxx_ops mv88e6321_ops = { + .set_egress_port = mv88e6095_g1_set_egress_port, + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .vtu_getnext = mv88e6185_g1_vtu_getnext, + .vtu_loadpurge = mv88e6185_g1_vtu_loadpurge, +@@ -5192,6 +5224,8 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -5347,6 +5381,8 @@ static const struct mv88e6xxx_ops mv88e6352_ops = { + .watchdog_ops = &mv88e6097_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -5409,6 +5445,8 @@ static const struct mv88e6xxx_ops mv88e6390_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -5471,6 +5509,8 @@ static const struct mv88e6xxx_ops mv88e6390x_ops = { + .watchdog_ops = &mv88e6390_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6390_g1_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +@@ -5536,6 +5576,8 @@ static const struct mv88e6xxx_ops mv88e6393x_ops = { + .watchdog_ops = &mv88e6393x_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6393x_port_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, ++ .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, + .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6390_g1_rmu_disable, + .atu_get_hash = mv88e6165_g1_atu_get_hash, +diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/drivers/net/dsa/mv88e6xxx/chip.h +index 85eb293381a7e..c34caf9815c5c 100644 +--- a/drivers/net/dsa/mv88e6xxx/chip.h ++++ b/drivers/net/dsa/mv88e6xxx/chip.h +@@ -487,6 +487,12 @@ struct mv88e6xxx_ops { + int (*ppu_enable)(struct mv88e6xxx_chip *chip); + int (*ppu_disable)(struct mv88e6xxx_chip *chip); + ++ /* Additional handlers to run before and after hard reset, to make sure ++ * that the switch and EEPROM are in a good state. ++ */ ++ int (*hardware_reset_pre)(struct mv88e6xxx_chip *chip); ++ int (*hardware_reset_post)(struct mv88e6xxx_chip *chip); ++ + /* Switch Software Reset */ + int (*reset)(struct mv88e6xxx_chip *chip); + +-- +2.43.0 + diff --git a/queue-6.8/net-dsa-mv88e6xxx-avoid-eeprom-timeout-without-eepro.patch b/queue-6.8/net-dsa-mv88e6xxx-avoid-eeprom-timeout-without-eepro.patch new file mode 100644 index 00000000000..7c43f48b51b --- /dev/null +++ b/queue-6.8/net-dsa-mv88e6xxx-avoid-eeprom-timeout-without-eepro.patch @@ -0,0 +1,173 @@ +From a3b2048ffa17eddcdac159bfbdc6ad6d2ff16bfa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 09:47:49 +0200 +Subject: net: dsa: mv88e6xxx: Avoid EEPROM timeout without EEPROM on + 88E6250-family switches + +From: Matthias Schiffer + +[ Upstream commit e44894e2aa4eb311ceda134de8b6f51ff979211b ] + +88E6250-family switches have the quirk that the EEPROM Running flag can +get stuck at 1 when no EEPROM is connected, causing +mv88e6xxx_g2_eeprom_wait() to time out. We still want to wait for the +EEPROM however, to avoid interrupting a transfer and leaving the EEPROM +in an invalid state. + +The condition to wait for recommended by the hardware spec is the EEInt +flag, however this flag is cleared on read, so before the hardware reset, +is may have been cleared already even though the EEPROM has been read +successfully. + +For this reason, we revive the mv88e6xxx_g1_wait_eeprom_done() function +that was removed in commit 6ccf50d4d474 +("net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent") in a +slightly refactored form, and introduce a new +mv88e6xxx_g1_wait_eeprom_done_prereset() that additionally handles this +case by triggering another EEPROM reload that can be waited on. + +On other switch models without this quirk, mv88e6xxx_g2_eeprom_wait() is +kept, as it avoids the additional reload. + +Fixes: 6ccf50d4d474 ("net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent") +Signed-off-by: Matthias Schiffer +Reviewed-by: Andrew Lunn +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/dsa/mv88e6xxx/chip.c | 4 +- + drivers/net/dsa/mv88e6xxx/global1.c | 89 +++++++++++++++++++++++++++++ + drivers/net/dsa/mv88e6xxx/global1.h | 2 + + 3 files changed, 93 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c +index 77bb681cb2be9..2ad9e4cd7b304 100644 +--- a/drivers/net/dsa/mv88e6xxx/chip.c ++++ b/drivers/net/dsa/mv88e6xxx/chip.c +@@ -5014,8 +5014,8 @@ static const struct mv88e6xxx_ops mv88e6250_ops = { + .watchdog_ops = &mv88e6250_watchdog_ops, + .mgmt_rsvd2cpu = mv88e6352_g2_mgmt_rsvd2cpu, + .pot_clear = mv88e6xxx_g2_pot_clear, +- .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, +- .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, ++ .hardware_reset_pre = mv88e6250_g1_wait_eeprom_done_prereset, ++ .hardware_reset_post = mv88e6xxx_g1_wait_eeprom_done, + .reset = mv88e6250_g1_reset, + .vtu_getnext = mv88e6185_g1_vtu_getnext, + .vtu_loadpurge = mv88e6185_g1_vtu_loadpurge, +diff --git a/drivers/net/dsa/mv88e6xxx/global1.c b/drivers/net/dsa/mv88e6xxx/global1.c +index 49444a72ff095..9820cd5967574 100644 +--- a/drivers/net/dsa/mv88e6xxx/global1.c ++++ b/drivers/net/dsa/mv88e6xxx/global1.c +@@ -75,6 +75,95 @@ static int mv88e6xxx_g1_wait_init_ready(struct mv88e6xxx_chip *chip) + return mv88e6xxx_g1_wait_bit(chip, MV88E6XXX_G1_STS, bit, 1); + } + ++static int mv88e6250_g1_eeprom_reload(struct mv88e6xxx_chip *chip) ++{ ++ /* MV88E6185_G1_CTL1_RELOAD_EEPROM is also valid for 88E6250 */ ++ int bit = __bf_shf(MV88E6185_G1_CTL1_RELOAD_EEPROM); ++ u16 val; ++ int err; ++ ++ err = mv88e6xxx_g1_read(chip, MV88E6XXX_G1_CTL1, &val); ++ if (err) ++ return err; ++ ++ val |= MV88E6185_G1_CTL1_RELOAD_EEPROM; ++ ++ err = mv88e6xxx_g1_write(chip, MV88E6XXX_G1_CTL1, val); ++ if (err) ++ return err; ++ ++ return mv88e6xxx_g1_wait_bit(chip, MV88E6XXX_G1_CTL1, bit, 0); ++} ++ ++/* Returns 0 when done, -EBUSY when waiting, other negative codes on error */ ++static int mv88e6xxx_g1_is_eeprom_done(struct mv88e6xxx_chip *chip) ++{ ++ u16 val; ++ int err; ++ ++ err = mv88e6xxx_g1_read(chip, MV88E6XXX_G1_STS, &val); ++ if (err < 0) { ++ dev_err(chip->dev, "Error reading status"); ++ return err; ++ } ++ ++ /* If the switch is still resetting, it may not ++ * respond on the bus, and so MDIO read returns ++ * 0xffff. Differentiate between that, and waiting for ++ * the EEPROM to be done by bit 0 being set. ++ */ ++ if (val == 0xffff || !(val & BIT(MV88E6XXX_G1_STS_IRQ_EEPROM_DONE))) ++ return -EBUSY; ++ ++ return 0; ++} ++ ++/* As the EEInt (EEPROM done) flag clears on read if the status register, this ++ * function must be called directly after a hard reset or EEPROM ReLoad request, ++ * or the done condition may have been missed ++ */ ++int mv88e6xxx_g1_wait_eeprom_done(struct mv88e6xxx_chip *chip) ++{ ++ const unsigned long timeout = jiffies + 1 * HZ; ++ int ret; ++ ++ /* Wait up to 1 second for the switch to finish reading the ++ * EEPROM. ++ */ ++ while (time_before(jiffies, timeout)) { ++ ret = mv88e6xxx_g1_is_eeprom_done(chip); ++ if (ret != -EBUSY) ++ return ret; ++ } ++ ++ dev_err(chip->dev, "Timeout waiting for EEPROM done"); ++ return -ETIMEDOUT; ++} ++ ++int mv88e6250_g1_wait_eeprom_done_prereset(struct mv88e6xxx_chip *chip) ++{ ++ int ret; ++ ++ ret = mv88e6xxx_g1_is_eeprom_done(chip); ++ if (ret != -EBUSY) ++ return ret; ++ ++ /* Pre-reset, we don't know the state of the switch - when ++ * mv88e6xxx_g1_is_eeprom_done() returns -EBUSY, that may be because ++ * the switch is actually busy reading the EEPROM, or because ++ * MV88E6XXX_G1_STS_IRQ_EEPROM_DONE has been cleared by an unrelated ++ * status register read already. ++ * ++ * To account for the latter case, trigger another EEPROM reload for ++ * another chance at seeing the done flag. ++ */ ++ ret = mv88e6250_g1_eeprom_reload(chip); ++ if (ret) ++ return ret; ++ ++ return mv88e6xxx_g1_wait_eeprom_done(chip); ++} ++ + /* Offset 0x01: Switch MAC Address Register Bytes 0 & 1 + * Offset 0x02: Switch MAC Address Register Bytes 2 & 3 + * Offset 0x03: Switch MAC Address Register Bytes 4 & 5 +diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h +index 1095261f5b490..3dbb7a1b8fe11 100644 +--- a/drivers/net/dsa/mv88e6xxx/global1.h ++++ b/drivers/net/dsa/mv88e6xxx/global1.h +@@ -282,6 +282,8 @@ int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr); + int mv88e6185_g1_reset(struct mv88e6xxx_chip *chip); + int mv88e6352_g1_reset(struct mv88e6xxx_chip *chip); + int mv88e6250_g1_reset(struct mv88e6xxx_chip *chip); ++int mv88e6xxx_g1_wait_eeprom_done(struct mv88e6xxx_chip *chip); ++int mv88e6250_g1_wait_eeprom_done_prereset(struct mv88e6xxx_chip *chip); + + int mv88e6185_g1_ppu_enable(struct mv88e6xxx_chip *chip); + int mv88e6185_g1_ppu_disable(struct mv88e6xxx_chip *chip); +-- +2.43.0 + diff --git a/queue-6.8/net-ethernet-cortina-locking-fixes.patch b/queue-6.8/net-ethernet-cortina-locking-fixes.patch new file mode 100644 index 00000000000..9f46eea94e4 --- /dev/null +++ b/queue-6.8/net-ethernet-cortina-locking-fixes.patch @@ -0,0 +1,86 @@ +From 5dedeafa09bd0de035fd0e8c456e493f677e9bb1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 09:44:54 +0200 +Subject: net: ethernet: cortina: Locking fixes + +From: Linus Walleij + +[ Upstream commit 812552808f7ff71133fc59768cdc253c5b8ca1bf ] + +This fixes a probably long standing problem in the Cortina +Gemini ethernet driver: there are some paths in the code +where the IRQ registers are written without taking the proper +locks. + +Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") +Signed-off-by: Linus Walleij +Reviewed-by: Simon Horman +Link: https://lore.kernel.org/r/20240509-gemini-ethernet-locking-v1-1-afd00a528b95@linaro.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/cortina/gemini.c | 12 ++++++++++-- + 1 file changed, 10 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c +index 705c3eb19cd3f..d1fbadbf86d4a 100644 +--- a/drivers/net/ethernet/cortina/gemini.c ++++ b/drivers/net/ethernet/cortina/gemini.c +@@ -1107,10 +1107,13 @@ static void gmac_tx_irq_enable(struct net_device *netdev, + { + struct gemini_ethernet_port *port = netdev_priv(netdev); + struct gemini_ethernet *geth = port->geth; ++ unsigned long flags; + u32 val, mask; + + netdev_dbg(netdev, "%s device %d\n", __func__, netdev->dev_id); + ++ spin_lock_irqsave(&geth->irq_lock, flags); ++ + mask = GMAC0_IRQ0_TXQ0_INTS << (6 * netdev->dev_id + txq); + + if (en) +@@ -1119,6 +1122,8 @@ static void gmac_tx_irq_enable(struct net_device *netdev, + val = readl(geth->base + GLOBAL_INTERRUPT_ENABLE_0_REG); + val = en ? val | mask : val & ~mask; + writel(val, geth->base + GLOBAL_INTERRUPT_ENABLE_0_REG); ++ ++ spin_unlock_irqrestore(&geth->irq_lock, flags); + } + + static void gmac_tx_irq(struct net_device *netdev, unsigned int txq_num) +@@ -1415,15 +1420,19 @@ static unsigned int gmac_rx(struct net_device *netdev, unsigned int budget) + union gmac_rxdesc_3 word3; + struct page *page = NULL; + unsigned int page_offs; ++ unsigned long flags; + unsigned short r, w; + union dma_rwptr rw; + dma_addr_t mapping; + int frag_nr = 0; + ++ spin_lock_irqsave(&geth->irq_lock, flags); + rw.bits32 = readl(ptr_reg); + /* Reset interrupt as all packages until here are taken into account */ + writel(DEFAULT_Q0_INT_BIT << netdev->dev_id, + geth->base + GLOBAL_INTERRUPT_STATUS_1_REG); ++ spin_unlock_irqrestore(&geth->irq_lock, flags); ++ + r = rw.bits.rptr; + w = rw.bits.wptr; + +@@ -1726,10 +1735,9 @@ static irqreturn_t gmac_irq(int irq, void *data) + gmac_update_hw_stats(netdev); + + if (val & (GMAC0_RX_OVERRUN_INT_BIT << (netdev->dev_id * 8))) { ++ spin_lock(&geth->irq_lock); + writel(GMAC0_RXDERR_INT_BIT << (netdev->dev_id * 8), + geth->base + GLOBAL_INTERRUPT_STATUS_4_REG); +- +- spin_lock(&geth->irq_lock); + u64_stats_update_begin(&port->ir_stats_syncp); + ++port->stats.rx_fifo_errors; + u64_stats_update_end(&port->ir_stats_syncp); +-- +2.43.0 + diff --git a/queue-6.8/net-ethernet-mediatek-split-tx-and-rx-fields-in-mtk_.patch b/queue-6.8/net-ethernet-mediatek-split-tx-and-rx-fields-in-mtk_.patch new file mode 100644 index 00000000000..0a2972adcb9 --- /dev/null +++ b/queue-6.8/net-ethernet-mediatek-split-tx-and-rx-fields-in-mtk_.patch @@ -0,0 +1,618 @@ +From 32c9e28cf561a34f68953cdd69ef8c4112366885 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 11:43:34 +0100 +Subject: net: ethernet: mediatek: split tx and rx fields in mtk_soc_data + struct + +From: Lorenzo Bianconi + +[ Upstream commit ecb51fa37ee22f137a87fa140b1e9f1759949f9a ] + +Split tx and rx fields in mtk_soc_data struct. This is a preliminary +patch to roll back to ADMAv1 for MT7986 and MT7981 SoC in order to fix a +hw hang if the device receives a corrupted packet when using ADMAv2.0. + +Fixes: 197c9e9b17b1 ("net: ethernet: mtk_eth_soc: introduce support for mt7986 chipset") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Daniel Golle +Reviewed-by: Przemek Kitszel +Link: https://lore.kernel.org/r/70a799b1f060ec2f57883e88ccb420ac0fb0abb5.1715164770.git.daniel@makrotopia.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mediatek/mtk_eth_soc.c | 210 ++++++++++++-------- + drivers/net/ethernet/mediatek/mtk_eth_soc.h | 29 +-- + 2 files changed, 139 insertions(+), 100 deletions(-) + +diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c +index caa13b9cedff0..3eefb735ce197 100644 +--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c ++++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c +@@ -1139,7 +1139,7 @@ static int mtk_init_fq_dma(struct mtk_eth *eth) + eth->scratch_ring = eth->sram_base; + else + eth->scratch_ring = dma_alloc_coherent(eth->dma_dev, +- cnt * soc->txrx.txd_size, ++ cnt * soc->tx.desc_size, + ð->phy_scratch_ring, + GFP_KERNEL); + if (unlikely(!eth->scratch_ring)) +@@ -1155,17 +1155,17 @@ static int mtk_init_fq_dma(struct mtk_eth *eth) + if (unlikely(dma_mapping_error(eth->dma_dev, dma_addr))) + return -ENOMEM; + +- phy_ring_tail = eth->phy_scratch_ring + soc->txrx.txd_size * (cnt - 1); ++ phy_ring_tail = eth->phy_scratch_ring + soc->tx.desc_size * (cnt - 1); + + for (i = 0; i < cnt; i++) { + dma_addr_t addr = dma_addr + i * MTK_QDMA_PAGE_SIZE; + struct mtk_tx_dma_v2 *txd; + +- txd = eth->scratch_ring + i * soc->txrx.txd_size; ++ txd = eth->scratch_ring + i * soc->tx.desc_size; + txd->txd1 = addr; + if (i < cnt - 1) + txd->txd2 = eth->phy_scratch_ring + +- (i + 1) * soc->txrx.txd_size; ++ (i + 1) * soc->tx.desc_size; + + txd->txd3 = TX_DMA_PLEN0(MTK_QDMA_PAGE_SIZE); + if (MTK_HAS_CAPS(soc->caps, MTK_36BIT_DMA)) +@@ -1416,7 +1416,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev, + if (itxd == ring->last_free) + return -ENOMEM; + +- itx_buf = mtk_desc_to_tx_buf(ring, itxd, soc->txrx.txd_size); ++ itx_buf = mtk_desc_to_tx_buf(ring, itxd, soc->tx.desc_size); + memset(itx_buf, 0, sizeof(*itx_buf)); + + txd_info.addr = dma_map_single(eth->dma_dev, skb->data, txd_info.size, +@@ -1457,7 +1457,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev, + + memset(&txd_info, 0, sizeof(struct mtk_tx_dma_desc_info)); + txd_info.size = min_t(unsigned int, frag_size, +- soc->txrx.dma_max_len); ++ soc->tx.dma_max_len); + txd_info.qid = queue; + txd_info.last = i == skb_shinfo(skb)->nr_frags - 1 && + !(frag_size - txd_info.size); +@@ -1470,7 +1470,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev, + mtk_tx_set_dma_desc(dev, txd, &txd_info); + + tx_buf = mtk_desc_to_tx_buf(ring, txd, +- soc->txrx.txd_size); ++ soc->tx.desc_size); + if (new_desc) + memset(tx_buf, 0, sizeof(*tx_buf)); + tx_buf->data = (void *)MTK_DMA_DUMMY_DESC; +@@ -1513,7 +1513,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev, + } else { + int next_idx; + +- next_idx = NEXT_DESP_IDX(txd_to_idx(ring, txd, soc->txrx.txd_size), ++ next_idx = NEXT_DESP_IDX(txd_to_idx(ring, txd, soc->tx.desc_size), + ring->dma_size); + mtk_w32(eth, next_idx, MT7628_TX_CTX_IDX0); + } +@@ -1522,7 +1522,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev, + + err_dma: + do { +- tx_buf = mtk_desc_to_tx_buf(ring, itxd, soc->txrx.txd_size); ++ tx_buf = mtk_desc_to_tx_buf(ring, itxd, soc->tx.desc_size); + + /* unmap dma */ + mtk_tx_unmap(eth, tx_buf, NULL, false); +@@ -1547,7 +1547,7 @@ static int mtk_cal_txd_req(struct mtk_eth *eth, struct sk_buff *skb) + for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { + frag = &skb_shinfo(skb)->frags[i]; + nfrags += DIV_ROUND_UP(skb_frag_size(frag), +- eth->soc->txrx.dma_max_len); ++ eth->soc->tx.dma_max_len); + } + } else { + nfrags += skb_shinfo(skb)->nr_frags; +@@ -1654,7 +1654,7 @@ static struct mtk_rx_ring *mtk_get_rx_ring(struct mtk_eth *eth) + + ring = ð->rx_ring[i]; + idx = NEXT_DESP_IDX(ring->calc_idx, ring->dma_size); +- rxd = ring->dma + idx * eth->soc->txrx.rxd_size; ++ rxd = ring->dma + idx * eth->soc->rx.desc_size; + if (rxd->rxd2 & RX_DMA_DONE) { + ring->calc_idx_update = true; + return ring; +@@ -1822,7 +1822,7 @@ static int mtk_xdp_submit_frame(struct mtk_eth *eth, struct xdp_frame *xdpf, + } + htxd = txd; + +- tx_buf = mtk_desc_to_tx_buf(ring, txd, soc->txrx.txd_size); ++ tx_buf = mtk_desc_to_tx_buf(ring, txd, soc->tx.desc_size); + memset(tx_buf, 0, sizeof(*tx_buf)); + htx_buf = tx_buf; + +@@ -1841,7 +1841,7 @@ static int mtk_xdp_submit_frame(struct mtk_eth *eth, struct xdp_frame *xdpf, + goto unmap; + + tx_buf = mtk_desc_to_tx_buf(ring, txd, +- soc->txrx.txd_size); ++ soc->tx.desc_size); + memset(tx_buf, 0, sizeof(*tx_buf)); + n_desc++; + } +@@ -1879,7 +1879,7 @@ static int mtk_xdp_submit_frame(struct mtk_eth *eth, struct xdp_frame *xdpf, + } else { + int idx; + +- idx = txd_to_idx(ring, txd, soc->txrx.txd_size); ++ idx = txd_to_idx(ring, txd, soc->tx.desc_size); + mtk_w32(eth, NEXT_DESP_IDX(idx, ring->dma_size), + MT7628_TX_CTX_IDX0); + } +@@ -1890,7 +1890,7 @@ static int mtk_xdp_submit_frame(struct mtk_eth *eth, struct xdp_frame *xdpf, + + unmap: + while (htxd != txd) { +- tx_buf = mtk_desc_to_tx_buf(ring, htxd, soc->txrx.txd_size); ++ tx_buf = mtk_desc_to_tx_buf(ring, htxd, soc->tx.desc_size); + mtk_tx_unmap(eth, tx_buf, NULL, false); + + htxd->txd3 = TX_DMA_LS0 | TX_DMA_OWNER_CPU; +@@ -2021,7 +2021,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, + goto rx_done; + + idx = NEXT_DESP_IDX(ring->calc_idx, ring->dma_size); +- rxd = ring->dma + idx * eth->soc->txrx.rxd_size; ++ rxd = ring->dma + idx * eth->soc->rx.desc_size; + data = ring->data[idx]; + + if (!mtk_rx_get_desc(eth, &trxd, rxd)) +@@ -2156,7 +2156,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, + rxdcsum = &trxd.rxd4; + } + +- if (*rxdcsum & eth->soc->txrx.rx_dma_l4_valid) ++ if (*rxdcsum & eth->soc->rx.dma_l4_valid) + skb->ip_summed = CHECKSUM_UNNECESSARY; + else + skb_checksum_none_assert(skb); +@@ -2280,7 +2280,7 @@ static int mtk_poll_tx_qdma(struct mtk_eth *eth, int budget, + break; + + tx_buf = mtk_desc_to_tx_buf(ring, desc, +- eth->soc->txrx.txd_size); ++ eth->soc->tx.desc_size); + if (!tx_buf->data) + break; + +@@ -2331,7 +2331,7 @@ static int mtk_poll_tx_pdma(struct mtk_eth *eth, int budget, + } + mtk_tx_unmap(eth, tx_buf, &bq, true); + +- desc = ring->dma + cpu * eth->soc->txrx.txd_size; ++ desc = ring->dma + cpu * eth->soc->tx.desc_size; + ring->last_free = desc; + atomic_inc(&ring->free_count); + +@@ -2421,7 +2421,7 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget) + do { + int rx_done; + +- mtk_w32(eth, eth->soc->txrx.rx_irq_done_mask, ++ mtk_w32(eth, eth->soc->rx.irq_done_mask, + reg_map->pdma.irq_status); + rx_done = mtk_poll_rx(napi, budget - rx_done_total, eth); + rx_done_total += rx_done; +@@ -2437,10 +2437,10 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget) + return budget; + + } while (mtk_r32(eth, reg_map->pdma.irq_status) & +- eth->soc->txrx.rx_irq_done_mask); ++ eth->soc->rx.irq_done_mask); + + if (napi_complete_done(napi, rx_done_total)) +- mtk_rx_irq_enable(eth, eth->soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_enable(eth, eth->soc->rx.irq_done_mask); + + return rx_done_total; + } +@@ -2449,7 +2449,7 @@ static int mtk_tx_alloc(struct mtk_eth *eth) + { + const struct mtk_soc_data *soc = eth->soc; + struct mtk_tx_ring *ring = ð->tx_ring; +- int i, sz = soc->txrx.txd_size; ++ int i, sz = soc->tx.desc_size; + struct mtk_tx_dma_v2 *txd; + int ring_size; + u32 ofs, val; +@@ -2572,14 +2572,14 @@ static void mtk_tx_clean(struct mtk_eth *eth) + } + if (!MTK_HAS_CAPS(soc->caps, MTK_SRAM) && ring->dma) { + dma_free_coherent(eth->dma_dev, +- ring->dma_size * soc->txrx.txd_size, ++ ring->dma_size * soc->tx.desc_size, + ring->dma, ring->phys); + ring->dma = NULL; + } + + if (ring->dma_pdma) { + dma_free_coherent(eth->dma_dev, +- ring->dma_size * soc->txrx.txd_size, ++ ring->dma_size * soc->tx.desc_size, + ring->dma_pdma, ring->phys_pdma); + ring->dma_pdma = NULL; + } +@@ -2634,15 +2634,15 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag) + if (!MTK_HAS_CAPS(eth->soc->caps, MTK_SRAM) || + rx_flag != MTK_RX_FLAGS_NORMAL) { + ring->dma = dma_alloc_coherent(eth->dma_dev, +- rx_dma_size * eth->soc->txrx.rxd_size, +- &ring->phys, GFP_KERNEL); ++ rx_dma_size * eth->soc->rx.desc_size, ++ &ring->phys, GFP_KERNEL); + } else { + struct mtk_tx_ring *tx_ring = ð->tx_ring; + + ring->dma = tx_ring->dma + tx_ring_size * +- eth->soc->txrx.txd_size * (ring_no + 1); ++ eth->soc->tx.desc_size * (ring_no + 1); + ring->phys = tx_ring->phys + tx_ring_size * +- eth->soc->txrx.txd_size * (ring_no + 1); ++ eth->soc->tx.desc_size * (ring_no + 1); + } + + if (!ring->dma) +@@ -2653,7 +2653,7 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag) + dma_addr_t dma_addr; + void *data; + +- rxd = ring->dma + i * eth->soc->txrx.rxd_size; ++ rxd = ring->dma + i * eth->soc->rx.desc_size; + if (ring->page_pool) { + data = mtk_page_pool_get_buff(ring->page_pool, + &dma_addr, GFP_KERNEL); +@@ -2744,7 +2744,7 @@ static void mtk_rx_clean(struct mtk_eth *eth, struct mtk_rx_ring *ring, bool in_ + if (!ring->data[i]) + continue; + +- rxd = ring->dma + i * eth->soc->txrx.rxd_size; ++ rxd = ring->dma + i * eth->soc->rx.desc_size; + if (!rxd->rxd1) + continue; + +@@ -2761,7 +2761,7 @@ static void mtk_rx_clean(struct mtk_eth *eth, struct mtk_rx_ring *ring, bool in_ + + if (!in_sram && ring->dma) { + dma_free_coherent(eth->dma_dev, +- ring->dma_size * eth->soc->txrx.rxd_size, ++ ring->dma_size * eth->soc->rx.desc_size, + ring->dma, ring->phys); + ring->dma = NULL; + } +@@ -3124,7 +3124,7 @@ static void mtk_dma_free(struct mtk_eth *eth) + netdev_reset_queue(eth->netdev[i]); + if (!MTK_HAS_CAPS(soc->caps, MTK_SRAM) && eth->scratch_ring) { + dma_free_coherent(eth->dma_dev, +- MTK_QDMA_RING_SIZE * soc->txrx.txd_size, ++ MTK_QDMA_RING_SIZE * soc->tx.desc_size, + eth->scratch_ring, eth->phy_scratch_ring); + eth->scratch_ring = NULL; + eth->phy_scratch_ring = 0; +@@ -3174,7 +3174,7 @@ static irqreturn_t mtk_handle_irq_rx(int irq, void *_eth) + + eth->rx_events++; + if (likely(napi_schedule_prep(ð->rx_napi))) { +- mtk_rx_irq_disable(eth, eth->soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_disable(eth, eth->soc->rx.irq_done_mask); + __napi_schedule(ð->rx_napi); + } + +@@ -3200,9 +3200,9 @@ static irqreturn_t mtk_handle_irq(int irq, void *_eth) + const struct mtk_reg_map *reg_map = eth->soc->reg_map; + + if (mtk_r32(eth, reg_map->pdma.irq_mask) & +- eth->soc->txrx.rx_irq_done_mask) { ++ eth->soc->rx.irq_done_mask) { + if (mtk_r32(eth, reg_map->pdma.irq_status) & +- eth->soc->txrx.rx_irq_done_mask) ++ eth->soc->rx.irq_done_mask) + mtk_handle_irq_rx(irq, _eth); + } + if (mtk_r32(eth, reg_map->tx_irq_mask) & MTK_TX_DONE_INT) { +@@ -3220,10 +3220,10 @@ static void mtk_poll_controller(struct net_device *dev) + struct mtk_eth *eth = mac->hw; + + mtk_tx_irq_disable(eth, MTK_TX_DONE_INT); +- mtk_rx_irq_disable(eth, eth->soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_disable(eth, eth->soc->rx.irq_done_mask); + mtk_handle_irq_rx(eth->irq[2], dev); + mtk_tx_irq_enable(eth, MTK_TX_DONE_INT); +- mtk_rx_irq_enable(eth, eth->soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_enable(eth, eth->soc->rx.irq_done_mask); + } + #endif + +@@ -3387,7 +3387,7 @@ static int mtk_open(struct net_device *dev) + napi_enable(ð->tx_napi); + napi_enable(ð->rx_napi); + mtk_tx_irq_enable(eth, MTK_TX_DONE_INT); +- mtk_rx_irq_enable(eth, soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_enable(eth, soc->rx.irq_done_mask); + refcount_set(ð->dma_refcnt, 1); + } + else +@@ -3471,7 +3471,7 @@ static int mtk_stop(struct net_device *dev) + mtk_gdm_config(eth, MTK_GDMA_DROP_ALL); + + mtk_tx_irq_disable(eth, MTK_TX_DONE_INT); +- mtk_rx_irq_disable(eth, eth->soc->txrx.rx_irq_done_mask); ++ mtk_rx_irq_disable(eth, eth->soc->rx.irq_done_mask); + napi_disable(ð->tx_napi); + napi_disable(ð->rx_napi); + +@@ -3947,9 +3947,9 @@ static int mtk_hw_init(struct mtk_eth *eth, bool reset) + + /* FE int grouping */ + mtk_w32(eth, MTK_TX_DONE_INT, reg_map->pdma.int_grp); +- mtk_w32(eth, eth->soc->txrx.rx_irq_done_mask, reg_map->pdma.int_grp + 4); ++ mtk_w32(eth, eth->soc->rx.irq_done_mask, reg_map->pdma.int_grp + 4); + mtk_w32(eth, MTK_TX_DONE_INT, reg_map->qdma.int_grp); +- mtk_w32(eth, eth->soc->txrx.rx_irq_done_mask, reg_map->qdma.int_grp + 4); ++ mtk_w32(eth, eth->soc->rx.irq_done_mask, reg_map->qdma.int_grp + 4); + mtk_w32(eth, 0x21021000, MTK_FE_INT_GRP); + + if (mtk_is_netsys_v3_or_greater(eth)) { +@@ -5039,11 +5039,15 @@ static const struct mtk_soc_data mt2701_data = { + .required_clks = MT7623_CLKS_BITMAP, + .required_pctl = true, + .version = 1, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +@@ -5059,11 +5063,15 @@ static const struct mtk_soc_data mt7621_data = { + .offload_version = 1, + .hash_offset = 2, + .foe_entry_size = MTK_FOE_ENTRY_V1_SIZE, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +@@ -5081,11 +5089,15 @@ static const struct mtk_soc_data mt7622_data = { + .hash_offset = 2, + .has_accounting = true, + .foe_entry_size = MTK_FOE_ENTRY_V1_SIZE, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +@@ -5102,11 +5114,15 @@ static const struct mtk_soc_data mt7623_data = { + .hash_offset = 2, + .foe_entry_size = MTK_FOE_ENTRY_V1_SIZE, + .disable_pll_modes = true, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +@@ -5121,11 +5137,15 @@ static const struct mtk_soc_data mt7629_data = { + .required_pctl = false, + .has_accounting = true, + .version = 1, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +@@ -5143,11 +5163,15 @@ static const struct mtk_soc_data mt7981_data = { + .hash_offset = 4, + .has_accounting = true, + .foe_entry_size = MTK_FOE_ENTRY_V2_SIZE, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma_v2), +- .rxd_size = sizeof(struct mtk_rx_dma_v2), +- .rx_irq_done_mask = MTK_RX_DONE_INT_V2, +- .rx_dma_l4_valid = RX_DMA_L4_VALID_V2, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma_v2), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, ++ .dma_len_offset = 8, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma_v2), ++ .irq_done_mask = MTK_RX_DONE_INT_V2, ++ .dma_l4_valid = RX_DMA_L4_VALID_V2, + .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, + .dma_len_offset = 8, + }, +@@ -5165,11 +5189,15 @@ static const struct mtk_soc_data mt7986_data = { + .hash_offset = 4, + .has_accounting = true, + .foe_entry_size = MTK_FOE_ENTRY_V2_SIZE, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma_v2), +- .rxd_size = sizeof(struct mtk_rx_dma_v2), +- .rx_irq_done_mask = MTK_RX_DONE_INT_V2, +- .rx_dma_l4_valid = RX_DMA_L4_VALID_V2, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma_v2), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, ++ .dma_len_offset = 8, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma_v2), ++ .irq_done_mask = MTK_RX_DONE_INT_V2, ++ .dma_l4_valid = RX_DMA_L4_VALID_V2, + .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, + .dma_len_offset = 8, + }, +@@ -5187,11 +5215,15 @@ static const struct mtk_soc_data mt7988_data = { + .hash_offset = 4, + .has_accounting = true, + .foe_entry_size = MTK_FOE_ENTRY_V3_SIZE, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma_v2), +- .rxd_size = sizeof(struct mtk_rx_dma_v2), +- .rx_irq_done_mask = MTK_RX_DONE_INT_V2, +- .rx_dma_l4_valid = RX_DMA_L4_VALID_V2, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma_v2), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, ++ .dma_len_offset = 8, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma_v2), ++ .irq_done_mask = MTK_RX_DONE_INT_V2, ++ .dma_l4_valid = RX_DMA_L4_VALID_V2, + .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, + .dma_len_offset = 8, + }, +@@ -5204,11 +5236,15 @@ static const struct mtk_soc_data rt5350_data = { + .required_clks = MT7628_CLKS_BITMAP, + .required_pctl = false, + .version = 1, +- .txrx = { +- .txd_size = sizeof(struct mtk_tx_dma), +- .rxd_size = sizeof(struct mtk_rx_dma), +- .rx_irq_done_mask = MTK_RX_DONE_INT, +- .rx_dma_l4_valid = RX_DMA_L4_VALID_PDMA, ++ .tx = { ++ .desc_size = sizeof(struct mtk_tx_dma), ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, ++ }, ++ .rx = { ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, ++ .dma_l4_valid = RX_DMA_L4_VALID_PDMA, + .dma_max_len = MTK_TX_DMA_BUF_LEN, + .dma_len_offset = 16, + }, +diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h +index 9ae3b8a71d0e6..39b50de1decbf 100644 +--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h ++++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h +@@ -327,8 +327,8 @@ + /* QDMA descriptor txd3 */ + #define TX_DMA_OWNER_CPU BIT(31) + #define TX_DMA_LS0 BIT(30) +-#define TX_DMA_PLEN0(x) (((x) & eth->soc->txrx.dma_max_len) << eth->soc->txrx.dma_len_offset) +-#define TX_DMA_PLEN1(x) ((x) & eth->soc->txrx.dma_max_len) ++#define TX_DMA_PLEN0(x) (((x) & eth->soc->tx.dma_max_len) << eth->soc->tx.dma_len_offset) ++#define TX_DMA_PLEN1(x) ((x) & eth->soc->tx.dma_max_len) + #define TX_DMA_SWC BIT(14) + #define TX_DMA_PQID GENMASK(3, 0) + #define TX_DMA_ADDR64_MASK GENMASK(3, 0) +@@ -348,8 +348,8 @@ + /* QDMA descriptor rxd2 */ + #define RX_DMA_DONE BIT(31) + #define RX_DMA_LSO BIT(30) +-#define RX_DMA_PREP_PLEN0(x) (((x) & eth->soc->txrx.dma_max_len) << eth->soc->txrx.dma_len_offset) +-#define RX_DMA_GET_PLEN0(x) (((x) >> eth->soc->txrx.dma_len_offset) & eth->soc->txrx.dma_max_len) ++#define RX_DMA_PREP_PLEN0(x) (((x) & eth->soc->rx.dma_max_len) << eth->soc->rx.dma_len_offset) ++#define RX_DMA_GET_PLEN0(x) (((x) >> eth->soc->rx.dma_len_offset) & eth->soc->rx.dma_max_len) + #define RX_DMA_VTAG BIT(15) + #define RX_DMA_ADDR64_MASK GENMASK(3, 0) + #if IS_ENABLED(CONFIG_64BIT) +@@ -1153,10 +1153,9 @@ struct mtk_reg_map { + * @foe_entry_size Foe table entry size. + * @has_accounting Bool indicating support for accounting of + * offloaded flows. +- * @txd_size Tx DMA descriptor size. +- * @rxd_size Rx DMA descriptor size. +- * @rx_irq_done_mask Rx irq done register mask. +- * @rx_dma_l4_valid Rx DMA valid register mask. ++ * @desc_size Tx/Rx DMA descriptor size. ++ * @irq_done_mask Rx irq done register mask. ++ * @dma_l4_valid Rx DMA valid register mask. + * @dma_max_len Max DMA tx/rx buffer length. + * @dma_len_offset Tx/Rx DMA length field offset. + */ +@@ -1174,13 +1173,17 @@ struct mtk_soc_data { + bool has_accounting; + bool disable_pll_modes; + struct { +- u32 txd_size; +- u32 rxd_size; +- u32 rx_irq_done_mask; +- u32 rx_dma_l4_valid; ++ u32 desc_size; + u32 dma_max_len; + u32 dma_len_offset; +- } txrx; ++ } tx; ++ struct { ++ u32 desc_size; ++ u32 irq_done_mask; ++ u32 dma_l4_valid; ++ u32 dma_max_len; ++ u32 dma_len_offset; ++ } rx; + }; + + #define MTK_DMA_MONITOR_TIMEOUT msecs_to_jiffies(1000) +-- +2.43.0 + diff --git a/queue-6.8/net-ethernet-mediatek-use-admav1-instead-of-admav2.0.patch b/queue-6.8/net-ethernet-mediatek-use-admav1-instead-of-admav2.0.patch new file mode 100644 index 00000000000..e7ab2cb70e9 --- /dev/null +++ b/queue-6.8/net-ethernet-mediatek-use-admav1-instead-of-admav2.0.patch @@ -0,0 +1,138 @@ +From 300e86cfc703275271012b1faf3d759551a01dcc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 11:43:56 +0100 +Subject: net: ethernet: mediatek: use ADMAv1 instead of ADMAv2.0 on MT7981 and + MT7986 + +From: Daniel Golle + +[ Upstream commit 5e69ff84f3e6cc54502a902043847b37ed78afd4 ] + +ADMAv2.0 is plagued by RX hangs which can't easily detected and happen upon +receival of a corrupted Ethernet frame. + +Use ADMAv1 instead which is also still present and usable, and doesn't +suffer from that problem. + +Fixes: 197c9e9b17b1 ("net: ethernet: mtk_eth_soc: introduce support for mt7986 chipset") +Co-developed-by: Lorenzo Bianconi +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Daniel Golle +Link: https://lore.kernel.org/r/57cef74bbd0c243366ad1ff4221e3f72f437ec80.1715164770.git.daniel@makrotopia.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mediatek/mtk_eth_soc.c | 46 ++++++++++----------- + 1 file changed, 23 insertions(+), 23 deletions(-) + +diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c +index 3eefb735ce197..d7d73295f0dc4 100644 +--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c ++++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c +@@ -110,16 +110,16 @@ static const struct mtk_reg_map mt7986_reg_map = { + .tx_irq_mask = 0x461c, + .tx_irq_status = 0x4618, + .pdma = { +- .rx_ptr = 0x6100, +- .rx_cnt_cfg = 0x6104, +- .pcrx_ptr = 0x6108, +- .glo_cfg = 0x6204, +- .rst_idx = 0x6208, +- .delay_irq = 0x620c, +- .irq_status = 0x6220, +- .irq_mask = 0x6228, +- .adma_rx_dbg0 = 0x6238, +- .int_grp = 0x6250, ++ .rx_ptr = 0x4100, ++ .rx_cnt_cfg = 0x4104, ++ .pcrx_ptr = 0x4108, ++ .glo_cfg = 0x4204, ++ .rst_idx = 0x4208, ++ .delay_irq = 0x420c, ++ .irq_status = 0x4220, ++ .irq_mask = 0x4228, ++ .adma_rx_dbg0 = 0x4238, ++ .int_grp = 0x4250, + }, + .qdma = { + .qtx_cfg = 0x4400, +@@ -1107,7 +1107,7 @@ static bool mtk_rx_get_desc(struct mtk_eth *eth, struct mtk_rx_dma_v2 *rxd, + rxd->rxd1 = READ_ONCE(dma_rxd->rxd1); + rxd->rxd3 = READ_ONCE(dma_rxd->rxd3); + rxd->rxd4 = READ_ONCE(dma_rxd->rxd4); +- if (mtk_is_netsys_v2_or_greater(eth)) { ++ if (mtk_is_netsys_v3_or_greater(eth)) { + rxd->rxd5 = READ_ONCE(dma_rxd->rxd5); + rxd->rxd6 = READ_ONCE(dma_rxd->rxd6); + } +@@ -2028,7 +2028,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, + break; + + /* find out which mac the packet come from. values start at 1 */ +- if (mtk_is_netsys_v2_or_greater(eth)) { ++ if (mtk_is_netsys_v3_or_greater(eth)) { + u32 val = RX_DMA_GET_SPORT_V2(trxd.rxd5); + + switch (val) { +@@ -2140,7 +2140,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, + skb->dev = netdev; + bytes += skb->len; + +- if (mtk_is_netsys_v2_or_greater(eth)) { ++ if (mtk_is_netsys_v3_or_greater(eth)) { + reason = FIELD_GET(MTK_RXD5_PPE_CPU_REASON, trxd.rxd5); + hash = trxd.rxd5 & MTK_RXD5_FOE_ENTRY; + if (hash != MTK_RXD5_FOE_ENTRY) +@@ -2690,7 +2690,7 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag) + + rxd->rxd3 = 0; + rxd->rxd4 = 0; +- if (mtk_is_netsys_v2_or_greater(eth)) { ++ if (mtk_is_netsys_v3_or_greater(eth)) { + rxd->rxd5 = 0; + rxd->rxd6 = 0; + rxd->rxd7 = 0; +@@ -3893,7 +3893,7 @@ static int mtk_hw_init(struct mtk_eth *eth, bool reset) + else + mtk_hw_reset(eth); + +- if (mtk_is_netsys_v2_or_greater(eth)) { ++ if (mtk_is_netsys_v3_or_greater(eth)) { + /* Set FE to PDMAv2 if necessary */ + val = mtk_r32(eth, MTK_FE_GLO_MISC); + mtk_w32(eth, val | BIT(4), MTK_FE_GLO_MISC); +@@ -5169,11 +5169,11 @@ static const struct mtk_soc_data mt7981_data = { + .dma_len_offset = 8, + }, + .rx = { +- .desc_size = sizeof(struct mtk_rx_dma_v2), +- .irq_done_mask = MTK_RX_DONE_INT_V2, ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, + .dma_l4_valid = RX_DMA_L4_VALID_V2, +- .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, +- .dma_len_offset = 8, ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, + }, + }; + +@@ -5195,11 +5195,11 @@ static const struct mtk_soc_data mt7986_data = { + .dma_len_offset = 8, + }, + .rx = { +- .desc_size = sizeof(struct mtk_rx_dma_v2), +- .irq_done_mask = MTK_RX_DONE_INT_V2, ++ .desc_size = sizeof(struct mtk_rx_dma), ++ .irq_done_mask = MTK_RX_DONE_INT, + .dma_l4_valid = RX_DMA_L4_VALID_V2, +- .dma_max_len = MTK_TX_DMA_BUF_LEN_V2, +- .dma_len_offset = 8, ++ .dma_max_len = MTK_TX_DMA_BUF_LEN, ++ .dma_len_offset = 16, + }, + }; + +-- +2.43.0 + diff --git a/queue-6.8/net-fec-remove-.ndo_poll_controller-to-avoid-deadloc.patch b/queue-6.8/net-fec-remove-.ndo_poll_controller-to-avoid-deadloc.patch new file mode 100644 index 00000000000..375f4c08266 --- /dev/null +++ b/queue-6.8/net-fec-remove-.ndo_poll_controller-to-avoid-deadloc.patch @@ -0,0 +1,75 @@ +From 5b187ae04083bac72f78b6d217256cb9e65a062e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 11 May 2024 14:20:09 +0800 +Subject: net: fec: remove .ndo_poll_controller to avoid deadlocks + +From: Wei Fang + +[ Upstream commit c2e0c58b25a0a0c37ec643255558c5af4450c9f5 ] + +There is a deadlock issue found in sungem driver, please refer to the +commit ac0a230f719b ("eth: sungem: remove .ndo_poll_controller to avoid +deadlocks"). The root cause of the issue is that netpoll is in atomic +context and disable_irq() is called by .ndo_poll_controller interface +of sungem driver, however, disable_irq() might sleep. After analyzing +the implementation of fec_poll_controller(), the fec driver should have +the same issue. Due to the fec driver uses NAPI for TX completions, the +.ndo_poll_controller is unnecessary to be implemented in the fec driver, +so fec_poll_controller() can be safely removed. + +Fixes: 7f5c6addcdc0 ("net/fec: add poll controller function for fec nic") +Signed-off-by: Wei Fang +Link: https://lore.kernel.org/r/20240511062009.652918-1-wei.fang@nxp.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/freescale/fec_main.c | 26 ----------------------- + 1 file changed, 26 deletions(-) + +diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c +index 8decb1b072c5e..e92a830330590 100644 +--- a/drivers/net/ethernet/freescale/fec_main.c ++++ b/drivers/net/ethernet/freescale/fec_main.c +@@ -3678,29 +3678,6 @@ fec_set_mac_address(struct net_device *ndev, void *p) + return 0; + } + +-#ifdef CONFIG_NET_POLL_CONTROLLER +-/** +- * fec_poll_controller - FEC Poll controller function +- * @dev: The FEC network adapter +- * +- * Polled functionality used by netconsole and others in non interrupt mode +- * +- */ +-static void fec_poll_controller(struct net_device *dev) +-{ +- int i; +- struct fec_enet_private *fep = netdev_priv(dev); +- +- for (i = 0; i < FEC_IRQ_NUM; i++) { +- if (fep->irq[i] > 0) { +- disable_irq(fep->irq[i]); +- fec_enet_interrupt(fep->irq[i], dev); +- enable_irq(fep->irq[i]); +- } +- } +-} +-#endif +- + static inline void fec_enet_set_netdev_features(struct net_device *netdev, + netdev_features_t features) + { +@@ -4007,9 +3984,6 @@ static const struct net_device_ops fec_netdev_ops = { + .ndo_tx_timeout = fec_timeout, + .ndo_set_mac_address = fec_set_mac_address, + .ndo_eth_ioctl = phy_do_ioctl_running, +-#ifdef CONFIG_NET_POLL_CONTROLLER +- .ndo_poll_controller = fec_poll_controller, +-#endif + .ndo_set_features = fec_set_features, + .ndo_bpf = fec_enet_bpf, + .ndo_xdp_xmit = fec_enet_xdp_xmit, +-- +2.43.0 + diff --git a/queue-6.8/net-give-more-chances-to-rcu-in-netdev_wait_allrefs_.patch b/queue-6.8/net-give-more-chances-to-rcu-in-netdev_wait_allrefs_.patch new file mode 100644 index 00000000000..f536ee51505 --- /dev/null +++ b/queue-6.8/net-give-more-chances-to-rcu-in-netdev_wait_allrefs_.patch @@ -0,0 +1,54 @@ +From e25341a508c81a6effa9a7e7d9cebe68bd4e60d1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 06:42:22 +0000 +Subject: net: give more chances to rcu in netdev_wait_allrefs_any() + +From: Eric Dumazet + +[ Upstream commit cd42ba1c8ac9deb9032add6adf491110e7442040 ] + +This came while reviewing commit c4e86b4363ac ("net: add two more +call_rcu_hurry()"). + +Paolo asked if adding one synchronize_rcu() would help. + +While synchronize_rcu() does not help, making sure to call +rcu_barrier() before msleep(wait) is definitely helping +to make sure lazy call_rcu() are completed. + +Instead of waiting ~100 seconds in my tests, the ref_tracker +splats occurs one time only, and netdev_wait_allrefs_any() +latency is reduced to the strict minimum. + +Ideally we should audit our call_rcu() users to make sure +no refcount (or cascading call_rcu()) is held too long, +because rcu_barrier() is quite expensive. + +Fixes: 0e4be9e57e8c ("net: use exponential backoff in netdev_wait_allrefs") +Signed-off-by: Eric Dumazet +Link: https://lore.kernel.org/all/28bbf698-befb-42f6-b561-851c67f464aa@kernel.org/T/#m76d73ed6b03cd930778ac4d20a777f22a08d6824 +Reviewed-by: Jiri Pirko +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/core/dev.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/net/core/dev.c b/net/core/dev.c +index c365aa06f886f..a32811aebde59 100644 +--- a/net/core/dev.c ++++ b/net/core/dev.c +@@ -10455,8 +10455,9 @@ static struct net_device *netdev_wait_allrefs_any(struct list_head *list) + rebroadcast_time = jiffies; + } + ++ rcu_barrier(); ++ + if (!wait) { +- rcu_barrier(); + wait = WAIT_REFS_MIN_MSECS; + } else { + msleep(wait); +-- +2.43.0 + diff --git a/queue-6.8/net-ipv6-fix-wrong-start-position-when-receive-hop-b.patch b/queue-6.8/net-ipv6-fix-wrong-start-position-when-receive-hop-b.patch new file mode 100644 index 00000000000..e11a0330804 --- /dev/null +++ b/queue-6.8/net-ipv6-fix-wrong-start-position-when-receive-hop-b.patch @@ -0,0 +1,41 @@ +From 4ab3437ee7e628cb236b2fc09940598ec3258226 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 17:19:17 +0800 +Subject: net: ipv6: fix wrong start position when receive hop-by-hop fragment + +From: gaoxingwang + +[ Upstream commit 1cd354fe1e4864eeaff62f66ee513080ec946f20 ] + +In IPv6, ipv6_rcv_core will parse the hop-by-hop type extension header and increase skb->transport_header by one extension header length. +But if there are more other extension headers like fragment header at this time, the skb->transport_header points to the second extension header, +not the transport layer header or the first extension header. + +This will result in the start and nexthdrp variable not pointing to the same position in ipv6frag_thdr_trunced, +and ipv6_skip_exthdr returning incorrect offset and frag_off.Sometimes,the length of the last sharded packet is smaller than the calculated incorrect offset, resulting in packet loss. +We can use network header to offset and calculate the correct position to solve this problem. + +Fixes: 9d9e937b1c8b (ipv6/netfilter: Discard first fragment not including all headers) +Signed-off-by: Gao Xingwang +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv6/reassembly.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c +index 5ebc47da1000c..2af98edef87ee 100644 +--- a/net/ipv6/reassembly.c ++++ b/net/ipv6/reassembly.c +@@ -369,7 +369,7 @@ static int ipv6_frag_rcv(struct sk_buff *skb) + * the source of the fragment, with the Pointer field set to zero. + */ + nexthdr = hdr->nexthdr; +- if (ipv6frag_thdr_truncated(skb, skb_transport_offset(skb), &nexthdr)) { ++ if (ipv6frag_thdr_truncated(skb, skb_network_offset(skb) + sizeof(struct ipv6hdr), &nexthdr)) { + __IP6_INC_STATS(net, __in6_dev_get_safely(skb->dev), + IPSTATS_MIB_INHDRERRORS); + icmpv6_param_prob(skb, ICMPV6_HDR_INCOMP, 0); +-- +2.43.0 + diff --git a/queue-6.8/net-micrel-fix-receiving-the-timestamp-in-the-frame-.patch b/queue-6.8/net-micrel-fix-receiving-the-timestamp-in-the-frame-.patch new file mode 100644 index 00000000000..b18585d04e1 --- /dev/null +++ b/queue-6.8/net-micrel-fix-receiving-the-timestamp-in-the-frame-.patch @@ -0,0 +1,44 @@ +From 3ed495c025bd76eae3f2cedb7282c49af88805bc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 21:21:57 +0200 +Subject: net: micrel: Fix receiving the timestamp in the frame for lan8841 + +From: Horatiu Vultur + +[ Upstream commit aea27a92a41dae14843f92c79e9e42d8f570105c ] + +The blamed commit started to use the ptp workqueue to get the second +part of the timestamp. And when the port was set down, then this +workqueue is stopped. But if the config option NETWORK_PHY_TIMESTAMPING +is not enabled, then the ptp_clock is not initialized so then it would +crash when it would try to access the delayed work. +So then basically by setting up and then down the port, it would crash. +The fix consists in checking if the ptp_clock is initialized and only +then cancel the delayed work. + +Fixes: cc7554954848 ("net: micrel: Change to receive timestamp in the frame for lan8841") +Signed-off-by: Horatiu Vultur +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/phy/micrel.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c +index 1f950c824418f..827db6a6ff397 100644 +--- a/drivers/net/phy/micrel.c ++++ b/drivers/net/phy/micrel.c +@@ -4635,7 +4635,8 @@ static int lan8841_suspend(struct phy_device *phydev) + struct kszphy_priv *priv = phydev->priv; + struct kszphy_ptp_priv *ptp_priv = &priv->ptp_priv; + +- ptp_cancel_worker_sync(ptp_priv->ptp_clock); ++ if (ptp_priv->ptp_clock) ++ ptp_cancel_worker_sync(ptp_priv->ptp_clock); + + return genphy_suspend(phydev); + } +-- +2.43.0 + diff --git a/queue-6.8/net-mlx5-add-a-timeout-to-acquire-the-command-queue-.patch b/queue-6.8/net-mlx5-add-a-timeout-to-acquire-the-command-queue-.patch new file mode 100644 index 00000000000..519ab04b106 --- /dev/null +++ b/queue-6.8/net-mlx5-add-a-timeout-to-acquire-the-command-queue-.patch @@ -0,0 +1,156 @@ +From bd5cc254c31315eb24c779245acc089a70a9a5a6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 14:29:50 +0300 +Subject: net/mlx5: Add a timeout to acquire the command queue semaphore + +From: Akiva Goldberger + +[ Upstream commit 485d65e1357123a697c591a5aeb773994b247ad7 ] + +Prevent forced completion handling on an entry that has not yet been +assigned an index, causing an out of bounds access on idx = -22. +Instead of waiting indefinitely for the sem, blocking flow now waits for +index to be allocated or a sem acquisition timeout before beginning the +timer for FW completion. + +Kernel log example: +mlx5_core 0000:06:00.0: wait_func_handle_exec_timeout:1128:(pid 185911): cmd[-22]: CREATE_UCTX(0xa04) No done completion + +Fixes: 8e715cd613a1 ("net/mlx5: Set command entry semaphore up once got index free") +Signed-off-by: Akiva Goldberger +Reviewed-by: Moshe Shemesh +Signed-off-by: Tariq Toukan +Link: https://lore.kernel.org/r/20240509112951.590184-5-tariqt@nvidia.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 41 +++++++++++++++---- + include/linux/mlx5/driver.h | 1 + + 2 files changed, 33 insertions(+), 9 deletions(-) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +index 4957412ff1f65..511e7fee39ac5 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +@@ -969,19 +969,32 @@ static void cmd_work_handler(struct work_struct *work) + bool poll_cmd = ent->polling; + struct mlx5_cmd_layout *lay; + struct mlx5_core_dev *dev; +- unsigned long cb_timeout; +- struct semaphore *sem; ++ unsigned long timeout; + unsigned long flags; + int alloc_ret; + int cmd_mode; + ++ complete(&ent->handling); ++ + dev = container_of(cmd, struct mlx5_core_dev, cmd); +- cb_timeout = msecs_to_jiffies(mlx5_tout_ms(dev, CMD)); ++ timeout = msecs_to_jiffies(mlx5_tout_ms(dev, CMD)); + +- complete(&ent->handling); +- sem = ent->page_queue ? &cmd->vars.pages_sem : &cmd->vars.sem; +- down(sem); + if (!ent->page_queue) { ++ if (down_timeout(&cmd->vars.sem, timeout)) { ++ mlx5_core_warn(dev, "%s(0x%x) timed out while waiting for a slot.\n", ++ mlx5_command_str(ent->op), ent->op); ++ if (ent->callback) { ++ ent->callback(-EBUSY, ent->context); ++ mlx5_free_cmd_msg(dev, ent->out); ++ free_msg(dev, ent->in); ++ cmd_ent_put(ent); ++ } else { ++ ent->ret = -EBUSY; ++ complete(&ent->done); ++ } ++ complete(&ent->slotted); ++ return; ++ } + alloc_ret = cmd_alloc_index(cmd, ent); + if (alloc_ret < 0) { + mlx5_core_err_rl(dev, "failed to allocate command entry\n"); +@@ -994,10 +1007,11 @@ static void cmd_work_handler(struct work_struct *work) + ent->ret = -EAGAIN; + complete(&ent->done); + } +- up(sem); ++ up(&cmd->vars.sem); + return; + } + } else { ++ down(&cmd->vars.pages_sem); + ent->idx = cmd->vars.max_reg_cmds; + spin_lock_irqsave(&cmd->alloc_lock, flags); + clear_bit(ent->idx, &cmd->vars.bitmask); +@@ -1005,6 +1019,8 @@ static void cmd_work_handler(struct work_struct *work) + spin_unlock_irqrestore(&cmd->alloc_lock, flags); + } + ++ complete(&ent->slotted); ++ + lay = get_inst(cmd, ent->idx); + ent->lay = lay; + memset(lay, 0, sizeof(*lay)); +@@ -1023,7 +1039,7 @@ static void cmd_work_handler(struct work_struct *work) + ent->ts1 = ktime_get_ns(); + cmd_mode = cmd->mode; + +- if (ent->callback && schedule_delayed_work(&ent->cb_timeout_work, cb_timeout)) ++ if (ent->callback && schedule_delayed_work(&ent->cb_timeout_work, timeout)) + cmd_ent_get(ent); + set_bit(MLX5_CMD_ENT_STATE_PENDING_COMP, &ent->state); + +@@ -1143,6 +1159,9 @@ static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent) + ent->ret = -ECANCELED; + goto out_err; + } ++ ++ wait_for_completion(&ent->slotted); ++ + if (cmd->mode == CMD_MODE_POLLING || ent->polling) + wait_for_completion(&ent->done); + else if (!wait_for_completion_timeout(&ent->done, timeout)) +@@ -1157,6 +1176,9 @@ static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent) + } else if (err == -ECANCELED) { + mlx5_core_warn(dev, "%s(0x%x) canceled on out of queue timeout.\n", + mlx5_command_str(ent->op), ent->op); ++ } else if (err == -EBUSY) { ++ mlx5_core_warn(dev, "%s(0x%x) timeout while waiting for command semaphore.\n", ++ mlx5_command_str(ent->op), ent->op); + } + mlx5_core_dbg(dev, "err %d, delivery status %s(%d)\n", + err, deliv_status_to_str(ent->status), ent->status); +@@ -1208,6 +1230,7 @@ static int mlx5_cmd_invoke(struct mlx5_core_dev *dev, struct mlx5_cmd_msg *in, + ent->polling = force_polling; + + init_completion(&ent->handling); ++ init_completion(&ent->slotted); + if (!callback) + init_completion(&ent->done); + +@@ -1225,7 +1248,7 @@ static int mlx5_cmd_invoke(struct mlx5_core_dev *dev, struct mlx5_cmd_msg *in, + return 0; /* mlx5_cmd_comp_handler() will put(ent) */ + + err = wait_func(dev, ent); +- if (err == -ETIMEDOUT || err == -ECANCELED) ++ if (err == -ETIMEDOUT || err == -ECANCELED || err == -EBUSY) + goto out_free; + + ds = ent->ts2 - ent->ts1; +diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h +index 41f03b352401e..38d425a187fa3 100644 +--- a/include/linux/mlx5/driver.h ++++ b/include/linux/mlx5/driver.h +@@ -861,6 +861,7 @@ struct mlx5_cmd_work_ent { + void *context; + int idx; + struct completion handling; ++ struct completion slotted; + struct completion done; + struct mlx5_cmd *cmd; + struct work_struct work; +-- +2.43.0 + diff --git a/queue-6.8/net-mlx5-discard-command-completions-in-internal-err.patch b/queue-6.8/net-mlx5-discard-command-completions-in-internal-err.patch new file mode 100644 index 00000000000..3ad46bb4b32 --- /dev/null +++ b/queue-6.8/net-mlx5-discard-command-completions-in-internal-err.patch @@ -0,0 +1,75 @@ +From c66aa1c86b52215c9bd62032087557420f8b93d9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 14:29:51 +0300 +Subject: net/mlx5: Discard command completions in internal error + +From: Akiva Goldberger + +[ Upstream commit db9b31aa9bc56ff0d15b78f7e827d61c4a096e40 ] + +Fix use after free when FW completion arrives while device is in +internal error state. Avoid calling completion handler in this case, +since the device will flush the command interface and trigger all +completions manually. + +Kernel log: +------------[ cut here ]------------ +refcount_t: underflow; use-after-free. +... +RIP: 0010:refcount_warn_saturate+0xd8/0xe0 +... +Call Trace: + +? __warn+0x79/0x120 +? refcount_warn_saturate+0xd8/0xe0 +? report_bug+0x17c/0x190 +? handle_bug+0x3c/0x60 +? exc_invalid_op+0x14/0x70 +? asm_exc_invalid_op+0x16/0x20 +? refcount_warn_saturate+0xd8/0xe0 +cmd_ent_put+0x13b/0x160 [mlx5_core] +mlx5_cmd_comp_handler+0x5f9/0x670 [mlx5_core] +cmd_comp_notifier+0x1f/0x30 [mlx5_core] +notifier_call_chain+0x35/0xb0 +atomic_notifier_call_chain+0x16/0x20 +mlx5_eq_async_int+0xf6/0x290 [mlx5_core] +notifier_call_chain+0x35/0xb0 +atomic_notifier_call_chain+0x16/0x20 +irq_int_handler+0x19/0x30 [mlx5_core] +__handle_irq_event_percpu+0x4b/0x160 +handle_irq_event+0x2e/0x80 +handle_edge_irq+0x98/0x230 +__common_interrupt+0x3b/0xa0 +common_interrupt+0x7b/0xa0 + + +asm_common_interrupt+0x22/0x40 + +Fixes: 51d138c2610a ("net/mlx5: Fix health error state handling") +Signed-off-by: Akiva Goldberger +Reviewed-by: Moshe Shemesh +Signed-off-by: Tariq Toukan +Link: https://lore.kernel.org/r/20240509112951.590184-6-tariqt@nvidia.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +index 511e7fee39ac5..20768ef2e9d2b 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +@@ -1634,6 +1634,9 @@ static int cmd_comp_notifier(struct notifier_block *nb, + dev = container_of(cmd, struct mlx5_core_dev, cmd); + eqe = data; + ++ if (dev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR) ++ return NOTIFY_DONE; ++ + mlx5_cmd_comp_handler(dev, be32_to_cpu(eqe->data.cmd.vector), false); + + return NOTIFY_OK; +-- +2.43.0 + diff --git a/queue-6.8/net-mlx5-fix-peer-devlink-set-for-sf-representor-dev.patch b/queue-6.8/net-mlx5-fix-peer-devlink-set-for-sf-representor-dev.patch new file mode 100644 index 00000000000..93bfe68be55 --- /dev/null +++ b/queue-6.8/net-mlx5-fix-peer-devlink-set-for-sf-representor-dev.patch @@ -0,0 +1,166 @@ +From 90072d3191518eaff778fa710f0dbe028486f77c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 14:29:48 +0300 +Subject: net/mlx5: Fix peer devlink set for SF representor devlink port + +From: Shay Drory + +[ Upstream commit 3c453e8cc672de1f9c662948dba43176bc68d7f0 ] + +The cited patch change register devlink flow, and neglect to reflect +the changes for peer devlink set logic. Peer devlink set is +triggering a call trace if done after devl_register.[1] + +Hence, align peer devlink set logic with register devlink flow. + +[1] +WARNING: CPU: 4 PID: 3394 at net/devlink/core.c:155 devlink_rel_nested_in_add+0x177/0x180 +CPU: 4 PID: 3394 Comm: kworker/u40:1 Not tainted 6.9.0-rc4_for_linust_min_debug_2024_04_16_14_08 #1 +Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 +Workqueue: mlx5_vhca_event0 mlx5_vhca_state_work_handler [mlx5_core] +RIP: 0010:devlink_rel_nested_in_add+0x177/0x180 +Call Trace: + + ? __warn+0x78/0x120 + ? devlink_rel_nested_in_add+0x177/0x180 + ? report_bug+0x16d/0x180 + ? handle_bug+0x3c/0x60 + ? exc_invalid_op+0x14/0x70 + ? asm_exc_invalid_op+0x16/0x20 + ? devlink_port_init+0x30/0x30 + ? devlink_port_type_clear+0x50/0x50 + ? devlink_rel_nested_in_add+0x177/0x180 + ? devlink_rel_nested_in_add+0xdd/0x180 + mlx5_sf_mdev_event+0x74/0xb0 [mlx5_core] + notifier_call_chain+0x35/0xb0 + blocking_notifier_call_chain+0x3d/0x60 + mlx5_blocking_notifier_call_chain+0x22/0x30 [mlx5_core] + mlx5_sf_dev_probe+0x185/0x3e0 [mlx5_core] + auxiliary_bus_probe+0x38/0x80 + ? driver_sysfs_add+0x51/0x80 + really_probe+0xc5/0x3a0 + ? driver_probe_device+0x90/0x90 + __driver_probe_device+0x80/0x160 + driver_probe_device+0x1e/0x90 + __device_attach_driver+0x7d/0x100 + bus_for_each_drv+0x80/0xd0 + __device_attach+0xbc/0x1f0 + bus_probe_device+0x86/0xa0 + device_add+0x64f/0x860 + __auxiliary_device_add+0x3b/0xa0 + mlx5_sf_dev_add+0x139/0x330 [mlx5_core] + mlx5_sf_dev_state_change_handler+0x1e4/0x250 [mlx5_core] + notifier_call_chain+0x35/0xb0 + blocking_notifier_call_chain+0x3d/0x60 + mlx5_vhca_state_work_handler+0x151/0x200 [mlx5_core] + process_one_work+0x13f/0x2e0 + worker_thread+0x2bd/0x3c0 + ? rescuer_thread+0x410/0x410 + kthread+0xc4/0xf0 + ? kthread_complete_and_exit+0x20/0x20 + ret_from_fork+0x2d/0x50 + ? kthread_complete_and_exit+0x20/0x20 + ret_from_fork_asm+0x11/0x20 + + +Fixes: bf729988303a ("net/mlx5: Restore mistakenly dropped parts in register devlink flow") +Fixes: c6e77aa9dd82 ("net/mlx5: Register devlink first under devlink lock") +Signed-off-by: Shay Drory +Reviewed-by: Moshe Shemesh +Signed-off-by: Tariq Toukan +Reviewed-by: Simon Horman +Link: https://lore.kernel.org/r/20240509112951.590184-3-tariqt@nvidia.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + .../net/ethernet/mellanox/mlx5/core/main.c | 14 +++++--------- + .../mellanox/mlx5/core/sf/dev/driver.c | 19 ++++++++----------- + 2 files changed, 13 insertions(+), 20 deletions(-) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c +index e285823bd08f0..0288e19e3a68e 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c +@@ -1680,6 +1680,8 @@ int mlx5_init_one_light(struct mlx5_core_dev *dev) + struct devlink *devlink = priv_to_devlink(dev); + int err; + ++ devl_lock(devlink); ++ devl_register(devlink); + dev->state = MLX5_DEVICE_STATE_UP; + err = mlx5_function_enable(dev, true, mlx5_tout_ms(dev, FW_PRE_INIT_TIMEOUT)); + if (err) { +@@ -1693,27 +1695,21 @@ int mlx5_init_one_light(struct mlx5_core_dev *dev) + goto query_hca_caps_err; + } + +- devl_lock(devlink); +- devl_register(devlink); +- + err = mlx5_devlink_params_register(priv_to_devlink(dev)); + if (err) { + mlx5_core_warn(dev, "mlx5_devlink_param_reg err = %d\n", err); +- goto params_reg_err; ++ goto query_hca_caps_err; + } + + devl_unlock(devlink); + return 0; + +-params_reg_err: +- devl_unregister(devlink); +- devl_unlock(devlink); + query_hca_caps_err: +- devl_unregister(devlink); +- devl_unlock(devlink); + mlx5_function_disable(dev, true); + out: + dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR; ++ devl_unregister(devlink); ++ devl_unlock(devlink); + return err; + } + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c +index 7ebe712808275..b2986175d9afe 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c +@@ -60,6 +60,13 @@ static int mlx5_sf_dev_probe(struct auxiliary_device *adev, const struct auxilia + goto remap_err; + } + ++ /* Peer devlink logic expects to work on unregistered devlink instance. */ ++ err = mlx5_core_peer_devlink_set(sf_dev, devlink); ++ if (err) { ++ mlx5_core_warn(mdev, "mlx5_core_peer_devlink_set err=%d\n", err); ++ goto peer_devlink_set_err; ++ } ++ + if (MLX5_ESWITCH_MANAGER(sf_dev->parent_mdev)) + err = mlx5_init_one_light(mdev); + else +@@ -69,20 +76,10 @@ static int mlx5_sf_dev_probe(struct auxiliary_device *adev, const struct auxilia + goto init_one_err; + } + +- err = mlx5_core_peer_devlink_set(sf_dev, devlink); +- if (err) { +- mlx5_core_warn(mdev, "mlx5_core_peer_devlink_set err=%d\n", err); +- goto peer_devlink_set_err; +- } +- + return 0; + +-peer_devlink_set_err: +- if (mlx5_dev_is_lightweight(sf_dev->mdev)) +- mlx5_uninit_one_light(sf_dev->mdev); +- else +- mlx5_uninit_one(sf_dev->mdev); + init_one_err: ++peer_devlink_set_err: + iounmap(mdev->iseg); + remap_err: + mlx5_mdev_uninit(mdev); +-- +2.43.0 + diff --git a/queue-6.8/net-mlx5-reload-only-ib-representors-upon-lag-disabl.patch b/queue-6.8/net-mlx5-reload-only-ib-representors-upon-lag-disabl.patch new file mode 100644 index 00000000000..43ab57a0365 --- /dev/null +++ b/queue-6.8/net-mlx5-reload-only-ib-representors-upon-lag-disabl.patch @@ -0,0 +1,222 @@ +From bfe719e41e630dec0cefed6fe7fc7a169bdc2cce Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 14:29:49 +0300 +Subject: net/mlx5: Reload only IB representors upon lag disable/enable + +From: Maher Sanalla + +[ Upstream commit 0f06228d4a2dcc1fca5b3ddb0eefa09c05b102c4 ] + +On lag disable, the bond IB device along with all of its +representors are destroyed, and then the slaves' representors get reloaded. + +In case the slave IB representor load fails, the eswitch error flow +unloads all representors, including ethernet representors, where the +netdevs get detached and removed from lag bond. Such flow is inaccurate +as the lag driver is not responsible for loading/unloading ethernet +representors. Furthermore, the flow described above begins by holding +lag lock to prevent bond changes during disable flow. However, when +reaching the ethernet representors detachment from lag, the lag lock is +required again, triggering the following deadlock: + +Call trace: +__switch_to+0xf4/0x148 +__schedule+0x2c8/0x7d0 +schedule+0x50/0xe0 +schedule_preempt_disabled+0x18/0x28 +__mutex_lock.isra.13+0x2b8/0x570 +__mutex_lock_slowpath+0x1c/0x28 +mutex_lock+0x4c/0x68 +mlx5_lag_remove_netdev+0x3c/0x1a0 [mlx5_core] +mlx5e_uplink_rep_disable+0x70/0xa0 [mlx5_core] +mlx5e_detach_netdev+0x6c/0xb0 [mlx5_core] +mlx5e_netdev_change_profile+0x44/0x138 [mlx5_core] +mlx5e_netdev_attach_nic_profile+0x28/0x38 [mlx5_core] +mlx5e_vport_rep_unload+0x184/0x1b8 [mlx5_core] +mlx5_esw_offloads_rep_load+0xd8/0xe0 [mlx5_core] +mlx5_eswitch_reload_reps+0x74/0xd0 [mlx5_core] +mlx5_disable_lag+0x130/0x138 [mlx5_core] +mlx5_lag_disable_change+0x6c/0x70 [mlx5_core] // hold ldev->lock +mlx5_devlink_eswitch_mode_set+0xc0/0x410 [mlx5_core] +devlink_nl_cmd_eswitch_set_doit+0xdc/0x180 +genl_family_rcv_msg_doit.isra.17+0xe8/0x138 +genl_rcv_msg+0xe4/0x220 +netlink_rcv_skb+0x44/0x108 +genl_rcv+0x40/0x58 +netlink_unicast+0x198/0x268 +netlink_sendmsg+0x1d4/0x418 +sock_sendmsg+0x54/0x60 +__sys_sendto+0xf4/0x120 +__arm64_sys_sendto+0x30/0x40 +el0_svc_common+0x8c/0x120 +do_el0_svc+0x30/0xa0 +el0_svc+0x20/0x30 +el0_sync_handler+0x90/0xb8 +el0_sync+0x160/0x180 + +Thus, upon lag enable/disable, load and unload only the IB representors +of the slaves preventing the deadlock mentioned above. + +While at it, refactor the mlx5_esw_offloads_rep_load() function to have +a static helper method for its internal logic, in symmetry with the +representor unload design. + +Fixes: 598fe77df855 ("net/mlx5: Lag, Create shared FDB when in switchdev mode") +Co-developed-by: Mark Bloch +Signed-off-by: Mark Bloch +Signed-off-by: Maher Sanalla +Signed-off-by: Tariq Toukan +Reviewed-by: Simon Horman +Link: https://lore.kernel.org/r/20240509112951.590184-4-tariqt@nvidia.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + .../net/ethernet/mellanox/mlx5/core/eswitch.h | 4 +-- + .../mellanox/mlx5/core/eswitch_offloads.c | 28 ++++++++++++------- + .../net/ethernet/mellanox/mlx5/core/lag/lag.c | 6 ++-- + .../ethernet/mellanox/mlx5/core/lag/mpesw.c | 4 +-- + 4 files changed, 25 insertions(+), 17 deletions(-) + +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h +index 349e28a6dd8df..ef55674876cb4 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h ++++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h +@@ -833,7 +833,7 @@ int mlx5_eswitch_offloads_single_fdb_add_one(struct mlx5_eswitch *master_esw, + struct mlx5_eswitch *slave_esw, int max_slaves); + void mlx5_eswitch_offloads_single_fdb_del_one(struct mlx5_eswitch *master_esw, + struct mlx5_eswitch *slave_esw); +-int mlx5_eswitch_reload_reps(struct mlx5_eswitch *esw); ++int mlx5_eswitch_reload_ib_reps(struct mlx5_eswitch *esw); + + bool mlx5_eswitch_block_encap(struct mlx5_core_dev *dev); + void mlx5_eswitch_unblock_encap(struct mlx5_core_dev *dev); +@@ -925,7 +925,7 @@ mlx5_eswitch_offloads_single_fdb_del_one(struct mlx5_eswitch *master_esw, + static inline int mlx5_eswitch_get_npeers(struct mlx5_eswitch *esw) { return 0; } + + static inline int +-mlx5_eswitch_reload_reps(struct mlx5_eswitch *esw) ++mlx5_eswitch_reload_ib_reps(struct mlx5_eswitch *esw) + { + return 0; + } +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +index e3cce110e52fd..58529d1a98b37 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +@@ -2501,6 +2501,16 @@ void esw_offloads_cleanup(struct mlx5_eswitch *esw) + esw_offloads_cleanup_reps(esw); + } + ++static int __esw_offloads_load_rep(struct mlx5_eswitch *esw, ++ struct mlx5_eswitch_rep *rep, u8 rep_type) ++{ ++ if (atomic_cmpxchg(&rep->rep_data[rep_type].state, ++ REP_REGISTERED, REP_LOADED) == REP_REGISTERED) ++ return esw->offloads.rep_ops[rep_type]->load(esw->dev, rep); ++ ++ return 0; ++} ++ + static void __esw_offloads_unload_rep(struct mlx5_eswitch *esw, + struct mlx5_eswitch_rep *rep, u8 rep_type) + { +@@ -2525,13 +2535,11 @@ static int mlx5_esw_offloads_rep_load(struct mlx5_eswitch *esw, u16 vport_num) + int err; + + rep = mlx5_eswitch_get_rep(esw, vport_num); +- for (rep_type = 0; rep_type < NUM_REP_TYPES; rep_type++) +- if (atomic_cmpxchg(&rep->rep_data[rep_type].state, +- REP_REGISTERED, REP_LOADED) == REP_REGISTERED) { +- err = esw->offloads.rep_ops[rep_type]->load(esw->dev, rep); +- if (err) +- goto err_reps; +- } ++ for (rep_type = 0; rep_type < NUM_REP_TYPES; rep_type++) { ++ err = __esw_offloads_load_rep(esw, rep, rep_type); ++ if (err) ++ goto err_reps; ++ } + + return 0; + +@@ -3276,7 +3284,7 @@ static void esw_destroy_offloads_acl_tables(struct mlx5_eswitch *esw) + esw_vport_destroy_offloads_acl_tables(esw, vport); + } + +-int mlx5_eswitch_reload_reps(struct mlx5_eswitch *esw) ++int mlx5_eswitch_reload_ib_reps(struct mlx5_eswitch *esw) + { + struct mlx5_eswitch_rep *rep; + unsigned long i; +@@ -3289,13 +3297,13 @@ int mlx5_eswitch_reload_reps(struct mlx5_eswitch *esw) + if (atomic_read(&rep->rep_data[REP_ETH].state) != REP_LOADED) + return 0; + +- ret = mlx5_esw_offloads_rep_load(esw, MLX5_VPORT_UPLINK); ++ ret = __esw_offloads_load_rep(esw, rep, REP_IB); + if (ret) + return ret; + + mlx5_esw_for_each_rep(esw, i, rep) { + if (atomic_read(&rep->rep_data[REP_ETH].state) == REP_LOADED) +- mlx5_esw_offloads_rep_load(esw, rep->vport); ++ __esw_offloads_load_rep(esw, rep, REP_IB); + } + + return 0; +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +index 69d482f7c5a29..37598d116f3b8 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +@@ -814,7 +814,7 @@ void mlx5_disable_lag(struct mlx5_lag *ldev) + if (shared_fdb) + for (i = 0; i < ldev->ports; i++) + if (!(ldev->pf[i].dev->priv.flags & MLX5_PRIV_FLAGS_DISABLE_ALL_ADEV)) +- mlx5_eswitch_reload_reps(ldev->pf[i].dev->priv.eswitch); ++ mlx5_eswitch_reload_ib_reps(ldev->pf[i].dev->priv.eswitch); + } + + static bool mlx5_shared_fdb_supported(struct mlx5_lag *ldev) +@@ -922,7 +922,7 @@ static void mlx5_do_bond(struct mlx5_lag *ldev) + mlx5_rescan_drivers_locked(dev0); + + for (i = 0; i < ldev->ports; i++) { +- err = mlx5_eswitch_reload_reps(ldev->pf[i].dev->priv.eswitch); ++ err = mlx5_eswitch_reload_ib_reps(ldev->pf[i].dev->priv.eswitch); + if (err) + break; + } +@@ -933,7 +933,7 @@ static void mlx5_do_bond(struct mlx5_lag *ldev) + mlx5_deactivate_lag(ldev); + mlx5_lag_add_devices(ldev); + for (i = 0; i < ldev->ports; i++) +- mlx5_eswitch_reload_reps(ldev->pf[i].dev->priv.eswitch); ++ mlx5_eswitch_reload_ib_reps(ldev->pf[i].dev->priv.eswitch); + mlx5_core_err(dev0, "Failed to enable lag\n"); + return; + } +diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c +index 82889f30506ea..571ea26edd0ca 100644 +--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c ++++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c +@@ -99,7 +99,7 @@ static int enable_mpesw(struct mlx5_lag *ldev) + dev0->priv.flags &= ~MLX5_PRIV_FLAGS_DISABLE_IB_ADEV; + mlx5_rescan_drivers_locked(dev0); + for (i = 0; i < ldev->ports; i++) { +- err = mlx5_eswitch_reload_reps(ldev->pf[i].dev->priv.eswitch); ++ err = mlx5_eswitch_reload_ib_reps(ldev->pf[i].dev->priv.eswitch); + if (err) + goto err_rescan_drivers; + } +@@ -113,7 +113,7 @@ static int enable_mpesw(struct mlx5_lag *ldev) + err_add_devices: + mlx5_lag_add_devices(ldev); + for (i = 0; i < ldev->ports; i++) +- mlx5_eswitch_reload_reps(ldev->pf[i].dev->priv.eswitch); ++ mlx5_eswitch_reload_ib_reps(ldev->pf[i].dev->priv.eswitch); + mlx5_mpesw_metadata_cleanup(ldev); + return err; + } +-- +2.43.0 + diff --git a/queue-6.8/net-openvswitch-fix-overwriting-ct-original-tuple-fo.patch b/queue-6.8/net-openvswitch-fix-overwriting-ct-original-tuple-fo.patch new file mode 100644 index 00000000000..846d19ff521 --- /dev/null +++ b/queue-6.8/net-openvswitch-fix-overwriting-ct-original-tuple-fo.patch @@ -0,0 +1,86 @@ +From fb95506316ae95a9a44c35c2363070baaa71fcbb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 11:38:05 +0200 +Subject: net: openvswitch: fix overwriting ct original tuple for ICMPv6 + +From: Ilya Maximets + +[ Upstream commit 7c988176b6c16c516474f6fceebe0f055af5eb56 ] + +OVS_PACKET_CMD_EXECUTE has 3 main attributes: + - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. + - OVS_PACKET_ATTR_PACKET - Binary packet content. + - OVS_PACKET_ATTR_ACTIONS - Actions to execute on the packet. + +OVS_PACKET_ATTR_KEY is parsed first to populate sw_flow_key structure +with the metadata like conntrack state, input port, recirculation id, +etc. Then the packet itself gets parsed to populate the rest of the +keys from the packet headers. + +Whenever the packet parsing code starts parsing the ICMPv6 header, it +first zeroes out fields in the key corresponding to Neighbor Discovery +information even if it is not an ND packet. + +It is an 'ipv6.nd' field. However, the 'ipv6' is a union that shares +the space between 'nd' and 'ct_orig' that holds the original tuple +conntrack metadata parsed from the OVS_PACKET_ATTR_KEY. + +ND packets should not normally have conntrack state, so it's fine to +share the space, but normal ICMPv6 Echo packets or maybe other types of +ICMPv6 can have the state attached and it should not be overwritten. + +The issue results in all but the last 4 bytes of the destination +address being wiped from the original conntrack tuple leading to +incorrect packet matching and potentially executing wrong actions +in case this packet recirculates within the datapath or goes back +to userspace. + +ND fields should not be accessed in non-ND packets, so not clearing +them should be fine. Executing memset() only for actual ND packets to +avoid the issue. + +Initializing the whole thing before parsing is needed because ND packet +may not contain all the options. + +The issue only affects the OVS_PACKET_CMD_EXECUTE path and doesn't +affect packets entering OVS datapath from network interfaces, because +in this case CT metadata is populated from skb after the packet is +already parsed. + +Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to sw_flow_key.") +Reported-by: Antonin Bas +Closes: https://github.com/openvswitch/ovs-issues/issues/327 +Signed-off-by: Ilya Maximets +Acked-by: Aaron Conole +Acked-by: Eelco Chaudron +Link: https://lore.kernel.org/r/20240509094228.1035477-1-i.maximets@ovn.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/openvswitch/flow.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c +index 33b21a0c05481..8a848ce72e291 100644 +--- a/net/openvswitch/flow.c ++++ b/net/openvswitch/flow.c +@@ -561,7 +561,6 @@ static int parse_icmpv6(struct sk_buff *skb, struct sw_flow_key *key, + */ + key->tp.src = htons(icmp->icmp6_type); + key->tp.dst = htons(icmp->icmp6_code); +- memset(&key->ipv6.nd, 0, sizeof(key->ipv6.nd)); + + if (icmp->icmp6_code == 0 && + (icmp->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION || +@@ -570,6 +569,8 @@ static int parse_icmpv6(struct sk_buff *skb, struct sw_flow_key *key, + struct nd_msg *nd; + int offset; + ++ memset(&key->ipv6.nd, 0, sizeof(key->ipv6.nd)); ++ + /* In order to process neighbor discovery options, we need the + * entire packet. + */ +-- +2.43.0 + diff --git a/queue-6.8/net-qrtr-ns-fix-module-refcnt.patch b/queue-6.8/net-qrtr-ns-fix-module-refcnt.patch new file mode 100644 index 00000000000..343d7d97e14 --- /dev/null +++ b/queue-6.8/net-qrtr-ns-fix-module-refcnt.patch @@ -0,0 +1,83 @@ +From e327622673132c9dfab8215fb97d3ec3251a2c08 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 10:31:46 -0700 +Subject: net: qrtr: ns: Fix module refcnt + +From: Chris Lew + +[ Upstream commit fd76e5ccc48f9f54eb44909dd7c0b924005f1582 ] + +The qrtr protocol core logic and the qrtr nameservice are combined into +a single module. Neither the core logic or nameservice provide much +functionality by themselves; combining the two into a single module also +prevents any possible issues that may stem from client modules loading +inbetween qrtr and the ns. + +Creating a socket takes two references to the module that owns the +socket protocol. Since the ns needs to create the control socket, this +creates a scenario where there are always two references to the qrtr +module. This prevents the execution of 'rmmod' for qrtr. + +To resolve this, forcefully put the module refcount for the socket +opened by the nameservice. + +Fixes: a365023a76f2 ("net: qrtr: combine nameservice into main module") +Reported-by: Jeffrey Hugo +Tested-by: Jeffrey Hugo +Signed-off-by: Chris Lew +Reviewed-by: Manivannan Sadhasivam +Reviewed-by: Jeffrey Hugo +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/qrtr/ns.c | 27 +++++++++++++++++++++++++++ + 1 file changed, 27 insertions(+) + +diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c +index abb0c70ffc8b0..654a3cc0d3479 100644 +--- a/net/qrtr/ns.c ++++ b/net/qrtr/ns.c +@@ -725,6 +725,24 @@ int qrtr_ns_init(void) + if (ret < 0) + goto err_wq; + ++ /* As the qrtr ns socket owner and creator is the same module, we have ++ * to decrease the qrtr module reference count to guarantee that it ++ * remains zero after the ns socket is created, otherwise, executing ++ * "rmmod" command is unable to make the qrtr module deleted after the ++ * qrtr module is inserted successfully. ++ * ++ * However, the reference count is increased twice in ++ * sock_create_kern(): one is to increase the reference count of owner ++ * of qrtr socket's proto_ops struct; another is to increment the ++ * reference count of owner of qrtr proto struct. Therefore, we must ++ * decrement the module reference count twice to ensure that it keeps ++ * zero after server's listening socket is created. Of course, we ++ * must bump the module reference count twice as well before the socket ++ * is closed. ++ */ ++ module_put(qrtr_ns.sock->ops->owner); ++ module_put(qrtr_ns.sock->sk->sk_prot_creator->owner); ++ + return 0; + + err_wq: +@@ -739,6 +757,15 @@ void qrtr_ns_remove(void) + { + cancel_work_sync(&qrtr_ns.work); + destroy_workqueue(qrtr_ns.workqueue); ++ ++ /* sock_release() expects the two references that were put during ++ * qrtr_ns_init(). This function is only called during module remove, ++ * so try_stop_module() has already set the refcnt to 0. Use ++ * __module_get() instead of try_module_get() to successfully take two ++ * references. ++ */ ++ __module_get(qrtr_ns.sock->ops->owner); ++ __module_get(qrtr_ns.sock->sk->sk_prot_creator->owner); + sock_release(qrtr_ns.sock); + } + EXPORT_SYMBOL_GPL(qrtr_ns_remove); +-- +2.43.0 + diff --git a/queue-6.8/net-stmmac-est-per-tx-queue-error-count-for-hlbf.patch b/queue-6.8/net-stmmac-est-per-tx-queue-error-count-for-hlbf.patch new file mode 100644 index 00000000000..0a268013f49 --- /dev/null +++ b/queue-6.8/net-stmmac-est-per-tx-queue-error-count-for-hlbf.patch @@ -0,0 +1,65 @@ +From f935d1506fc558208227db7b10a27caf4364e497 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 27 Jan 2024 12:04:42 +0800 +Subject: net: stmmac: est: Per Tx-queue error count for HLBF + +From: Rohan G Thomas + +[ Upstream commit fd5a6a71313e27c4f601526081b69d4e76f03dea ] + +Keep per Tx-queue error count on Head-Of-Line Blocking due to frame +size(HLBF) error. The MAC raises HLBF error on one or more queues +when none of the time Intervals of open-gates in the GCL is greater +than or equal to the duration needed for frame transmission and by +default drops those packets that causes HLBF error. EST_FRM_SZ_ERR +register provides the One Hot encoded Queue numbers that have the +Frame Size related error. + +Signed-off-by: Rohan G Thomas +Signed-off-by: David S. Miller +Stable-dep-of: 36ac9e7f2e57 ("net: stmmac: move the EST lock to struct stmmac_priv") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/stmicro/stmmac/common.h | 1 + + drivers/net/ethernet/stmicro/stmmac/stmmac_est.c | 6 ++++++ + 2 files changed, 7 insertions(+) + +diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h +index 2706761955fea..618d455b457c7 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/common.h ++++ b/drivers/net/ethernet/stmicro/stmmac/common.h +@@ -226,6 +226,7 @@ struct stmmac_extra_stats { + unsigned long mtl_est_btre; + unsigned long mtl_est_btrlm; + unsigned long max_sdu_txq_drop[MTL_MAX_TX_QUEUES]; ++ unsigned long mtl_est_txq_hlbf[MTL_MAX_TX_QUEUES]; + /* per queue statistics */ + struct stmmac_txq_stats txq_stats[MTL_MAX_TX_QUEUES]; + struct stmmac_rxq_stats rxq_stats[MTL_MAX_RX_QUEUES]; +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_est.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_est.c +index 4da6ccc17c205..c9693f77e1f61 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_est.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_est.c +@@ -81,6 +81,7 @@ static void est_irq_status(struct stmmac_priv *priv, struct net_device *dev, + u32 status, value, feqn, hbfq, hbfs, btrl, btrl_max; + void __iomem *est_addr = priv->estaddr; + u32 txqcnt_mask = BIT(txqcnt) - 1; ++ int i; + + status = readl(est_addr + EST_STATUS); + +@@ -125,6 +126,11 @@ static void est_irq_status(struct stmmac_priv *priv, struct net_device *dev, + + x->mtl_est_hlbf++; + ++ for (i = 0; i < txqcnt; i++) { ++ if (feqn & BIT(i)) ++ x->mtl_est_txq_hlbf[i]++; ++ } ++ + /* Clear Interrupt */ + writel(feqn, est_addr + EST_FRM_SZ_ERR); + +-- +2.43.0 + diff --git a/queue-6.8/net-stmmac-move-the-est-lock-to-struct-stmmac_priv.patch b/queue-6.8/net-stmmac-move-the-est-lock-to-struct-stmmac_priv.patch new file mode 100644 index 00000000000..8d0b3c74965 --- /dev/null +++ b/queue-6.8/net-stmmac-move-the-est-lock-to-struct-stmmac_priv.patch @@ -0,0 +1,192 @@ +From c01976f237f15de7626d5be568946f1e2ca19aeb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 09:43:45 +0800 +Subject: net: stmmac: move the EST lock to struct stmmac_priv + +From: Xiaolei Wang + +[ Upstream commit 36ac9e7f2e5786bd37c5cd91132e1f39c29b8197 ] + +Reinitialize the whole EST structure would also reset the mutex +lock which is embedded in the EST structure, and then trigger +the following warning. To address this, move the lock to struct +stmmac_priv. We also need to reacquire the mutex lock when doing +this initialization. + +DEBUG_LOCKS_WARN_ON(lock->magic != lock) +WARNING: CPU: 3 PID: 505 at kernel/locking/mutex.c:587 __mutex_lock+0xd84/0x1068 + Modules linked in: + CPU: 3 PID: 505 Comm: tc Not tainted 6.9.0-rc6-00053-g0106679839f7-dirty #29 + Hardware name: NXP i.MX8MPlus EVK board (DT) + pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) + pc : __mutex_lock+0xd84/0x1068 + lr : __mutex_lock+0xd84/0x1068 + sp : ffffffc0864e3570 + x29: ffffffc0864e3570 x28: ffffffc0817bdc78 x27: 0000000000000003 + x26: ffffff80c54f1808 x25: ffffff80c9164080 x24: ffffffc080d723ac + x23: 0000000000000000 x22: 0000000000000002 x21: 0000000000000000 + x20: 0000000000000000 x19: ffffffc083bc3000 x18: ffffffffffffffff + x17: ffffffc08117b080 x16: 0000000000000002 x15: ffffff80d2d40000 + x14: 00000000000002da x13: ffffff80d2d404b8 x12: ffffffc082b5a5c8 + x11: ffffffc082bca680 x10: ffffffc082bb2640 x9 : ffffffc082bb2698 + x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 0000000000000001 + x5 : ffffff8178fe0d48 x4 : 0000000000000000 x3 : 0000000000000027 + x2 : ffffff8178fe0d50 x1 : 0000000000000000 x0 : 0000000000000000 + Call trace: + __mutex_lock+0xd84/0x1068 + mutex_lock_nested+0x28/0x34 + tc_setup_taprio+0x118/0x68c + stmmac_setup_tc+0x50/0xf0 + taprio_change+0x868/0xc9c + +Fixes: b2aae654a479 ("net: stmmac: add mutex lock to protect est parameters") +Signed-off-by: Xiaolei Wang +Reviewed-by: Simon Horman +Reviewed-by: Serge Semin +Reviewed-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240513014346.1718740-2-xiaolei.wang@windriver.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ + .../net/ethernet/stmicro/stmmac/stmmac_ptp.c | 8 ++++---- + .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 18 ++++++++++-------- + include/linux/stmmac.h | 1 - + 4 files changed, 16 insertions(+), 13 deletions(-) + +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h +index f155e4841c62b..1db1359d154f3 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h +@@ -260,6 +260,8 @@ struct stmmac_priv { + struct stmmac_extra_stats xstats ____cacheline_aligned_in_smp; + struct stmmac_safety_stats sstats; + struct plat_stmmacenet_data *plat; ++ /* Protect est parameters */ ++ struct mutex est_lock; + struct dma_features dma_cap; + struct stmmac_counters mmc; + int hw_cap_support; +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +index e04830a3a1fb1..0c5aab6dd7a73 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +@@ -70,11 +70,11 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta) + /* If EST is enabled, disabled it before adjust ptp time. */ + if (priv->plat->est && priv->plat->est->enable) { + est_rst = true; +- mutex_lock(&priv->plat->est->lock); ++ mutex_lock(&priv->est_lock); + priv->plat->est->enable = false; + stmmac_est_configure(priv, priv, priv->plat->est, + priv->plat->clk_ptp_rate); +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + } + + write_lock_irqsave(&priv->ptp_lock, flags); +@@ -87,7 +87,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta) + ktime_t current_time_ns, basetime; + u64 cycle_time; + +- mutex_lock(&priv->plat->est->lock); ++ mutex_lock(&priv->est_lock); + priv->ptp_clock_ops.gettime64(&priv->ptp_clock_ops, ¤t_time); + current_time_ns = timespec64_to_ktime(current_time); + time.tv_nsec = priv->plat->est->btr_reserve[0]; +@@ -104,7 +104,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta) + priv->plat->est->enable = true; + ret = stmmac_est_configure(priv, priv, priv->plat->est, + priv->plat->clk_ptp_rate); +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + if (ret) + netdev_err(priv->dev, "failed to configure EST\n"); + } +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +index cce00719937db..620c16e9be3a6 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +@@ -1004,17 +1004,19 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + if (!plat->est) + return -ENOMEM; + +- mutex_init(&priv->plat->est->lock); ++ mutex_init(&priv->est_lock); + } else { ++ mutex_lock(&priv->est_lock); + memset(plat->est, 0, sizeof(*plat->est)); ++ mutex_unlock(&priv->est_lock); + } + + size = qopt->num_entries; + +- mutex_lock(&priv->plat->est->lock); ++ mutex_lock(&priv->est_lock); + priv->plat->est->gcl_size = size; + priv->plat->est->enable = qopt->cmd == TAPRIO_CMD_REPLACE; +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + + for (i = 0; i < size; i++) { + s64 delta_ns = qopt->entries[i].interval; +@@ -1045,7 +1047,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + priv->plat->est->gcl[i] = delta_ns | (gates << wid); + } + +- mutex_lock(&priv->plat->est->lock); ++ mutex_lock(&priv->est_lock); + /* Adjust for real system time */ + priv->ptp_clock_ops.gettime64(&priv->ptp_clock_ops, ¤t_time); + current_time_ns = timespec64_to_ktime(current_time); +@@ -1068,7 +1070,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + tc_taprio_map_maxsdu_txq(priv, qopt); + + if (fpe && !priv->dma_cap.fpesel) { +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + return -EOPNOTSUPP; + } + +@@ -1079,7 +1081,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + + ret = stmmac_est_configure(priv, priv, priv->plat->est, + priv->plat->clk_ptp_rate); +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + if (ret) { + netdev_err(priv->dev, "failed to configure EST\n"); + goto disable; +@@ -1096,7 +1098,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + + disable: + if (priv->plat->est) { +- mutex_lock(&priv->plat->est->lock); ++ mutex_lock(&priv->est_lock); + priv->plat->est->enable = false; + stmmac_est_configure(priv, priv, priv->plat->est, + priv->plat->clk_ptp_rate); +@@ -1105,7 +1107,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv, + priv->xstats.max_sdu_txq_drop[i] = 0; + priv->xstats.mtl_est_txq_hlbf[i] = 0; + } +- mutex_unlock(&priv->plat->est->lock); ++ mutex_unlock(&priv->est_lock); + } + + priv->plat->fpe_cfg->enable = false; +diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h +index dfa1828cd756a..c0d74f97fd187 100644 +--- a/include/linux/stmmac.h ++++ b/include/linux/stmmac.h +@@ -117,7 +117,6 @@ struct stmmac_axi { + + #define EST_GCL 1024 + struct stmmac_est { +- struct mutex lock; + int enable; + u32 btr_reserve[2]; + u32 btr_offset[2]; +-- +2.43.0 + diff --git a/queue-6.8/net-stmmac-offload-queuemaxsdu-from-tc-taprio.patch b/queue-6.8/net-stmmac-offload-queuemaxsdu-from-tc-taprio.patch new file mode 100644 index 00000000000..1b813c47b22 --- /dev/null +++ b/queue-6.8/net-stmmac-offload-queuemaxsdu-from-tc-taprio.patch @@ -0,0 +1,158 @@ +From 742d01192c6840e1d5a750c606b387b2de5096f4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 27 Jan 2024 12:04:41 +0800 +Subject: net: stmmac: Offload queueMaxSDU from tc-taprio + +From: Rohan G Thomas + +[ Upstream commit c5c3e1bfc9e0ee72af528df8d773980f4855938a ] + +Add support for configuring queueMaxSDU. As DWMAC IPs doesn't support +queueMaxSDU table handle this in the SW. The maximum 802.3 frame size +that is allowed to be transmitted by any queue is queueMaxSDU + +16 bytes (i.e. 6 bytes SA + 6 bytes DA + 4 bytes FCS). + +Inspired from intel i225 driver. + +Signed-off-by: Rohan G Thomas +Signed-off-by: David S. Miller +Stable-dep-of: 36ac9e7f2e57 ("net: stmmac: move the EST lock to struct stmmac_priv") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/stmicro/stmmac/common.h | 1 + + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 22 ++++++++++++++++ + .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 25 +++++++++++++++++++ + include/linux/stmmac.h | 1 + + 4 files changed, 49 insertions(+) + +diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h +index 5a1d46dcd5de0..2706761955fea 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/common.h ++++ b/drivers/net/ethernet/stmicro/stmmac/common.h +@@ -225,6 +225,7 @@ struct stmmac_extra_stats { + unsigned long mtl_est_hlbf; + unsigned long mtl_est_btre; + unsigned long mtl_est_btrlm; ++ unsigned long max_sdu_txq_drop[MTL_MAX_TX_QUEUES]; + /* per queue statistics */ + struct stmmac_txq_stats txq_stats[MTL_MAX_TX_QUEUES]; + struct stmmac_rxq_stats rxq_stats[MTL_MAX_RX_QUEUES]; +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +index 83b732c30c1bb..12f4c0da838da 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +@@ -2491,6 +2491,13 @@ static bool stmmac_xdp_xmit_zc(struct stmmac_priv *priv, u32 queue, u32 budget) + if (!xsk_tx_peek_desc(pool, &xdp_desc)) + break; + ++ if (priv->plat->est && priv->plat->est->enable && ++ priv->plat->est->max_sdu[queue] && ++ xdp_desc.len > priv->plat->est->max_sdu[queue]) { ++ priv->xstats.max_sdu_txq_drop[queue]++; ++ continue; ++ } ++ + if (likely(priv->extend_desc)) + tx_desc = (struct dma_desc *)(tx_q->dma_etx + entry); + else if (tx_q->tbs & STMMAC_TBS_AVAIL) +@@ -4485,6 +4492,13 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) + return stmmac_tso_xmit(skb, dev); + } + ++ if (priv->plat->est && priv->plat->est->enable && ++ priv->plat->est->max_sdu[queue] && ++ skb->len > priv->plat->est->max_sdu[queue]){ ++ priv->xstats.max_sdu_txq_drop[queue]++; ++ goto max_sdu_err; ++ } ++ + if (unlikely(stmmac_tx_avail(priv, queue) < nfrags + 1)) { + if (!netif_tx_queue_stopped(netdev_get_tx_queue(dev, queue))) { + netif_tx_stop_queue(netdev_get_tx_queue(priv->dev, +@@ -4702,6 +4716,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) + + dma_map_err: + netdev_err(priv->dev, "Tx DMA map failed\n"); ++max_sdu_err: + dev_kfree_skb(skb); + priv->xstats.tx_dropped++; + return NETDEV_TX_OK; +@@ -4858,6 +4873,13 @@ static int stmmac_xdp_xmit_xdpf(struct stmmac_priv *priv, int queue, + if (stmmac_tx_avail(priv, queue) < STMMAC_TX_THRESH(priv)) + return STMMAC_XDP_CONSUMED; + ++ if (priv->plat->est && priv->plat->est->enable && ++ priv->plat->est->max_sdu[queue] && ++ xdpf->len > priv->plat->est->max_sdu[queue]) { ++ priv->xstats.max_sdu_txq_drop[queue]++; ++ return STMMAC_XDP_CONSUMED; ++ } ++ + if (likely(priv->extend_desc)) + tx_desc = (struct dma_desc *)(tx_q->dma_etx + entry); + else if (tx_q->tbs & STMMAC_TBS_AVAIL) +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +index 26fa33e5ec34f..07aa3a3089dc2 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +@@ -915,6 +915,28 @@ struct timespec64 stmmac_calc_tas_basetime(ktime_t old_base_time, + return time; + } + ++static void tc_taprio_map_maxsdu_txq(struct stmmac_priv *priv, ++ struct tc_taprio_qopt_offload *qopt) ++{ ++ struct plat_stmmacenet_data *plat = priv->plat; ++ u32 num_tc = qopt->mqprio.qopt.num_tc; ++ u32 offset, count, i, j; ++ ++ /* QueueMaxSDU received from the driver corresponds to the Linux traffic ++ * class. Map queueMaxSDU per Linux traffic class to DWMAC Tx queues. ++ */ ++ for (i = 0; i < num_tc; i++) { ++ if (!qopt->max_sdu[i]) ++ continue; ++ ++ offset = qopt->mqprio.qopt.offset[i]; ++ count = qopt->mqprio.qopt.count[i]; ++ ++ for (j = offset; j < offset + count; j++) ++ plat->est->max_sdu[j] = qopt->max_sdu[i] + ETH_HLEN - ETH_TLEN; ++ } ++} ++ + static int tc_setup_taprio(struct stmmac_priv *priv, + struct tc_taprio_qopt_offload *qopt) + { +@@ -1045,6 +1067,8 @@ static int tc_setup_taprio(struct stmmac_priv *priv, + + priv->plat->est->ter = qopt->cycle_time_extension; + ++ tc_taprio_map_maxsdu_txq(priv, qopt); ++ + if (fpe && !priv->dma_cap.fpesel) { + mutex_unlock(&priv->plat->est->lock); + return -EOPNOTSUPP; +@@ -1126,6 +1150,7 @@ static int tc_query_caps(struct stmmac_priv *priv, + return -EOPNOTSUPP; + + caps->gate_mask_per_txq = true; ++ caps->supports_queue_max_sdu = true; + + return 0; + } +diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h +index dee5ad6e48c5a..dfa1828cd756a 100644 +--- a/include/linux/stmmac.h ++++ b/include/linux/stmmac.h +@@ -127,6 +127,7 @@ struct stmmac_est { + u32 gcl_unaligned[EST_GCL]; + u32 gcl[EST_GCL]; + u32 gcl_size; ++ u32 max_sdu[MTL_MAX_TX_QUEUES]; + }; + + struct stmmac_rxq_cfg { +-- +2.43.0 + diff --git a/queue-6.8/net-stmmac-report-taprio-offload-status.patch b/queue-6.8/net-stmmac-report-taprio-offload-status.patch new file mode 100644 index 00000000000..fc9d680abdb --- /dev/null +++ b/queue-6.8/net-stmmac-report-taprio-offload-status.patch @@ -0,0 +1,123 @@ +From a3ebc3404fefda7bd3db1d8b659350c6dd6c7fff Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 27 Jan 2024 12:04:43 +0800 +Subject: net: stmmac: Report taprio offload status + +From: Rohan G Thomas + +[ Upstream commit 5ca63ffdb94ba2bac4c23c8609aabd7edd03c312 ] + +Report taprio offload status. This includes per txq and global +counters of window_drops and tx_overruns. + +Window_drops count include count of frames dropped because of +queueMaxSDU setting and HLBF error. Transmission overrun counter +inform the user application whether any packets are currently being +transmitted on a particular queue during a gate-close event.DWMAC IPs +takes care Transmission overrun won't happen hence this is always 0. + +Signed-off-by: Rohan G Thomas +Signed-off-by: David S. Miller +Stable-dep-of: 36ac9e7f2e57 ("net: stmmac: move the EST lock to struct stmmac_priv") +Signed-off-by: Sasha Levin +--- + .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 62 +++++++++++++++++-- + 1 file changed, 58 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +index 07aa3a3089dc2..cce00719937db 100644 +--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c ++++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +@@ -937,8 +937,8 @@ static void tc_taprio_map_maxsdu_txq(struct stmmac_priv *priv, + } + } + +-static int tc_setup_taprio(struct stmmac_priv *priv, +- struct tc_taprio_qopt_offload *qopt) ++static int tc_taprio_configure(struct stmmac_priv *priv, ++ struct tc_taprio_qopt_offload *qopt) + { + u32 size, wid = priv->dma_cap.estwid, dep = priv->dma_cap.estdep; + struct plat_stmmacenet_data *plat = priv->plat; +@@ -990,8 +990,6 @@ static int tc_setup_taprio(struct stmmac_priv *priv, + + if (qopt->cmd == TAPRIO_CMD_DESTROY) + goto disable; +- else if (qopt->cmd != TAPRIO_CMD_REPLACE) +- return -EOPNOTSUPP; + + if (qopt->num_entries >= dep) + return -EINVAL; +@@ -1102,6 +1100,11 @@ static int tc_setup_taprio(struct stmmac_priv *priv, + priv->plat->est->enable = false; + stmmac_est_configure(priv, priv, priv->plat->est, + priv->plat->clk_ptp_rate); ++ /* Reset taprio status */ ++ for (i = 0; i < priv->plat->tx_queues_to_use; i++) { ++ priv->xstats.max_sdu_txq_drop[i] = 0; ++ priv->xstats.mtl_est_txq_hlbf[i] = 0; ++ } + mutex_unlock(&priv->plat->est->lock); + } + +@@ -1119,6 +1122,57 @@ static int tc_setup_taprio(struct stmmac_priv *priv, + return ret; + } + ++static void tc_taprio_stats(struct stmmac_priv *priv, ++ struct tc_taprio_qopt_offload *qopt) ++{ ++ u64 window_drops = 0; ++ int i = 0; ++ ++ for (i = 0; i < priv->plat->tx_queues_to_use; i++) ++ window_drops += priv->xstats.max_sdu_txq_drop[i] + ++ priv->xstats.mtl_est_txq_hlbf[i]; ++ qopt->stats.window_drops = window_drops; ++ ++ /* Transmission overrun doesn't happen for stmmac, hence always 0 */ ++ qopt->stats.tx_overruns = 0; ++} ++ ++static void tc_taprio_queue_stats(struct stmmac_priv *priv, ++ struct tc_taprio_qopt_offload *qopt) ++{ ++ struct tc_taprio_qopt_queue_stats *q_stats = &qopt->queue_stats; ++ int queue = qopt->queue_stats.queue; ++ ++ q_stats->stats.window_drops = priv->xstats.max_sdu_txq_drop[queue] + ++ priv->xstats.mtl_est_txq_hlbf[queue]; ++ ++ /* Transmission overrun doesn't happen for stmmac, hence always 0 */ ++ q_stats->stats.tx_overruns = 0; ++} ++ ++static int tc_setup_taprio(struct stmmac_priv *priv, ++ struct tc_taprio_qopt_offload *qopt) ++{ ++ int err = 0; ++ ++ switch (qopt->cmd) { ++ case TAPRIO_CMD_REPLACE: ++ case TAPRIO_CMD_DESTROY: ++ err = tc_taprio_configure(priv, qopt); ++ break; ++ case TAPRIO_CMD_STATS: ++ tc_taprio_stats(priv, qopt); ++ break; ++ case TAPRIO_CMD_QUEUE_STATS: ++ tc_taprio_queue_stats(priv, qopt); ++ break; ++ default: ++ err = -EOPNOTSUPP; ++ } ++ ++ return err; ++} ++ + static int tc_setup_etf(struct stmmac_priv *priv, + struct tc_etf_qopt_offload *qopt) + { +-- +2.43.0 + diff --git a/queue-6.8/net-txgbe-fix-gpio-interrupt-blocking.patch b/queue-6.8/net-txgbe-fix-gpio-interrupt-blocking.patch new file mode 100644 index 00000000000..ed57cb13529 --- /dev/null +++ b/queue-6.8/net-txgbe-fix-gpio-interrupt-blocking.patch @@ -0,0 +1,91 @@ +From 58f290154df0fb171f3ebfdeb4008236c6da8d7c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 17:29:55 +0800 +Subject: net: txgbe: fix GPIO interrupt blocking + +From: Jiawen Wu + +[ Upstream commit b4a2496c17ed645f8d51061047c9c249b58c74ba ] + +The register of GPIO interrupt status is masked before MAC IRQ +is enabled. This is because of hardware deficiency. So manually +clear the interrupt status before using them. Otherwise, GPIO +interrupts will never be reported again. There is a workaround for +clearing interrupts to set GPIO EOI in txgbe_up_complete(). + +Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller") +Signed-off-by: Jiawen Wu +Link: https://lore.kernel.org/r/20240301092956.18544-1-jiawenwu@trustnetic.com +Signed-off-by: Paolo Abeni +Signed-off-by: Sasha Levin +--- + .../net/ethernet/wangxun/txgbe/txgbe_main.c | 1 + + .../net/ethernet/wangxun/txgbe/txgbe_phy.c | 27 +++++++++++++++++++ + .../net/ethernet/wangxun/txgbe/txgbe_phy.h | 1 + + 3 files changed, 29 insertions(+) + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +index 88ea20946e6ec..8c7a74981b907 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +@@ -81,6 +81,7 @@ static void txgbe_up_complete(struct wx *wx) + { + struct net_device *netdev = wx->netdev; + ++ txgbe_reinit_gpio_intr(wx); + wx_control_hw(wx, true); + wx_configure_vectors(wx); + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +index 3c9bb4ab98681..93295916b1d2b 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +@@ -491,6 +491,33 @@ irqreturn_t txgbe_gpio_irq_handler(int irq, void *data) + return IRQ_HANDLED; + } + ++void txgbe_reinit_gpio_intr(struct wx *wx) ++{ ++ struct txgbe *txgbe = wx->priv; ++ irq_hw_number_t hwirq; ++ unsigned long gpioirq; ++ struct gpio_chip *gc; ++ unsigned long flags; ++ ++ /* for gpio interrupt pending before irq enable */ ++ gpioirq = rd32(wx, WX_GPIO_INTSTATUS); ++ ++ gc = txgbe->gpio; ++ for_each_set_bit(hwirq, &gpioirq, gc->ngpio) { ++ int gpio = irq_find_mapping(gc->irq.domain, hwirq); ++ struct irq_data *d = irq_get_irq_data(gpio); ++ u32 irq_type = irq_get_trigger_type(gpio); ++ ++ txgbe_gpio_irq_ack(d); ++ ++ if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) { ++ raw_spin_lock_irqsave(&wx->gpio_lock, flags); ++ txgbe_toggle_trigger(gc, hwirq); ++ raw_spin_unlock_irqrestore(&wx->gpio_lock, flags); ++ } ++ } ++} ++ + static int txgbe_gpio_init(struct txgbe *txgbe) + { + struct gpio_irq_chip *girq; +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h +index 9855d44076cb8..8a026d804fe24 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h +@@ -5,6 +5,7 @@ + #define _TXGBE_PHY_H_ + + irqreturn_t txgbe_gpio_irq_handler(int irq, void *data); ++void txgbe_reinit_gpio_intr(struct wx *wx); + irqreturn_t txgbe_link_irq_handler(int irq, void *data); + int txgbe_init_phy(struct txgbe *txgbe); + void txgbe_remove_phy(struct txgbe *txgbe); +-- +2.43.0 + diff --git a/queue-6.8/net-txgbe-fix-to-clear-interrupt-status-after-handli.patch b/queue-6.8/net-txgbe-fix-to-clear-interrupt-status-after-handli.patch new file mode 100644 index 00000000000..060a3bb4ed4 --- /dev/null +++ b/queue-6.8/net-txgbe-fix-to-clear-interrupt-status-after-handli.patch @@ -0,0 +1,41 @@ +From d210ed3d48b6919433f99b47f6f1779befba7ae7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 17:29:56 +0800 +Subject: net: txgbe: fix to clear interrupt status after handling IRQ + +From: Jiawen Wu + +[ Upstream commit 0e71862a20d58b6e8d4c39de1d72c8919c4dccd1 ] + +GPIO EOI is not set to clear interrupt status after handling the +interrupt. It should be done in irq_chip->irq_ack, but this function +is not called in handle_nested_irq(). So executing function +txgbe_gpio_irq_ack() manually in txgbe_gpio_irq_handler(). + +Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller") +Signed-off-by: Jiawen Wu +Link: https://lore.kernel.org/r/20240301092956.18544-2-jiawenwu@trustnetic.com +Signed-off-by: Paolo Abeni +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +index bae0a8ee70142..3c9bb4ab98681 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +@@ -475,8 +475,10 @@ irqreturn_t txgbe_gpio_irq_handler(int irq, void *data) + gc = txgbe->gpio; + for_each_set_bit(hwirq, &gpioirq, gc->ngpio) { + int gpio = irq_find_mapping(gc->irq.domain, hwirq); ++ struct irq_data *d = irq_get_irq_data(gpio); + u32 irq_type = irq_get_trigger_type(gpio); + ++ txgbe_gpio_irq_ack(d); + handle_nested_irq(gpio); + + if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) { +-- +2.43.0 + diff --git a/queue-6.8/net-txgbe-fix-to-control-vlan-strip.patch b/queue-6.8/net-txgbe-fix-to-control-vlan-strip.patch new file mode 100644 index 00000000000..c1bb74205f2 --- /dev/null +++ b/queue-6.8/net-txgbe-fix-to-control-vlan-strip.patch @@ -0,0 +1,278 @@ +From 3a81d6d321d165c7b5de03164b0947160239a203 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 17 May 2024 14:51:40 +0800 +Subject: net: txgbe: fix to control VLAN strip + +From: Jiawen Wu + +[ Upstream commit 1d3c6414950badaa38002af3b5857e01a21f01e9 ] + +When VLAN tag strip is changed to enable or disable, the hardware requires +the Rx ring to be in a disabled state, otherwise the feature cannot be +changed. + +Fixes: f3b03c655f67 ("net: wangxun: Implement vlan add and kill functions") +Signed-off-by: Jiawen Wu +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 ++ + drivers/net/ethernet/wangxun/libwx/wx_lib.c | 6 ++-- + drivers/net/ethernet/wangxun/libwx/wx_type.h | 22 ++++++++++++++ + .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c | 18 +++++++---- + .../ethernet/wangxun/txgbe/txgbe_ethtool.c | 18 +++++++---- + .../net/ethernet/wangxun/txgbe/txgbe_main.c | 30 +++++++++++++++++++ + .../net/ethernet/wangxun/txgbe/txgbe_type.h | 1 + + 7 files changed, 84 insertions(+), 13 deletions(-) + +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c +index 945c13d1a9829..c09a6f7445754 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c +@@ -1958,6 +1958,8 @@ int wx_sw_init(struct wx *wx) + return -ENOMEM; + } + ++ bitmap_zero(wx->state, WX_STATE_NBITS); ++ + return 0; + } + EXPORT_SYMBOL(wx_sw_init); +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +index 25ac86919395b..c87afe5de1dd8 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +@@ -2692,9 +2692,9 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features) + + netdev->features = features; + +- if (changed & +- (NETIF_F_HW_VLAN_CTAG_RX | +- NETIF_F_HW_VLAN_STAG_RX)) ++ if (wx->mac.type == wx_mac_sp && changed & NETIF_F_HW_VLAN_CTAG_RX) ++ wx->do_reset(netdev); ++ else if (changed & (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_FILTER)) + wx_set_rx_mode(netdev); + + return 0; +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h +index 1fdeb464d5f4a..5aaf7b1fa2db9 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_type.h ++++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h +@@ -982,8 +982,13 @@ struct wx_hw_stats { + u64 qmprc; + }; + ++enum wx_state { ++ WX_STATE_RESETTING, ++ WX_STATE_NBITS, /* must be last */ ++}; + struct wx { + unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)]; ++ DECLARE_BITMAP(state, WX_STATE_NBITS); + + void *priv; + u8 __iomem *hw_addr; +@@ -1071,6 +1076,8 @@ struct wx { + u64 hw_csum_rx_good; + u64 hw_csum_rx_error; + u64 alloc_rx_buff_failed; ++ ++ void (*do_reset)(struct net_device *netdev); + }; + + #define WX_INTR_ALL (~0ULL) +@@ -1131,4 +1138,19 @@ static inline struct wx *phylink_to_wx(struct phylink_config *config) + return container_of(config, struct wx, phylink_config); + } + ++static inline int wx_set_state_reset(struct wx *wx) ++{ ++ u8 timeout = 50; ++ ++ while (test_and_set_bit(WX_STATE_RESETTING, wx->state)) { ++ timeout--; ++ if (!timeout) ++ return -EBUSY; ++ ++ usleep_range(1000, 2000); ++ } ++ ++ return 0; ++} ++ + #endif /* _WX_TYPE_H_ */ +diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c +index 786a652ae64f3..46a5a3e952021 100644 +--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c ++++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c +@@ -52,7 +52,7 @@ static int ngbe_set_ringparam(struct net_device *netdev, + struct wx *wx = netdev_priv(netdev); + u32 new_rx_count, new_tx_count; + struct wx_ring *temp_ring; +- int i; ++ int i, err = 0; + + new_tx_count = clamp_t(u32, ring->tx_pending, WX_MIN_TXD, WX_MAX_TXD); + new_tx_count = ALIGN(new_tx_count, WX_REQ_TX_DESCRIPTOR_MULTIPLE); +@@ -64,6 +64,10 @@ static int ngbe_set_ringparam(struct net_device *netdev, + new_rx_count == wx->rx_ring_count) + return 0; + ++ err = wx_set_state_reset(wx); ++ if (err) ++ return err; ++ + if (!netif_running(wx->netdev)) { + for (i = 0; i < wx->num_tx_queues; i++) + wx->tx_ring[i]->count = new_tx_count; +@@ -72,14 +76,16 @@ static int ngbe_set_ringparam(struct net_device *netdev, + wx->tx_ring_count = new_tx_count; + wx->rx_ring_count = new_rx_count; + +- return 0; ++ goto clear_reset; + } + + /* allocate temporary buffer to store rings in */ + i = max_t(int, wx->num_tx_queues, wx->num_rx_queues); + temp_ring = kvmalloc_array(i, sizeof(struct wx_ring), GFP_KERNEL); +- if (!temp_ring) +- return -ENOMEM; ++ if (!temp_ring) { ++ err = -ENOMEM; ++ goto clear_reset; ++ } + + ngbe_down(wx); + +@@ -89,7 +95,9 @@ static int ngbe_set_ringparam(struct net_device *netdev, + wx_configure(wx); + ngbe_up(wx); + +- return 0; ++clear_reset: ++ clear_bit(WX_STATE_RESETTING, wx->state); ++ return err; + } + + static int ngbe_set_channels(struct net_device *dev, +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_ethtool.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_ethtool.c +index db675512ce4dc..31fde3fa7c6b5 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_ethtool.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_ethtool.c +@@ -19,7 +19,7 @@ static int txgbe_set_ringparam(struct net_device *netdev, + struct wx *wx = netdev_priv(netdev); + u32 new_rx_count, new_tx_count; + struct wx_ring *temp_ring; +- int i; ++ int i, err = 0; + + new_tx_count = clamp_t(u32, ring->tx_pending, WX_MIN_TXD, WX_MAX_TXD); + new_tx_count = ALIGN(new_tx_count, WX_REQ_TX_DESCRIPTOR_MULTIPLE); +@@ -31,6 +31,10 @@ static int txgbe_set_ringparam(struct net_device *netdev, + new_rx_count == wx->rx_ring_count) + return 0; + ++ err = wx_set_state_reset(wx); ++ if (err) ++ return err; ++ + if (!netif_running(wx->netdev)) { + for (i = 0; i < wx->num_tx_queues; i++) + wx->tx_ring[i]->count = new_tx_count; +@@ -39,14 +43,16 @@ static int txgbe_set_ringparam(struct net_device *netdev, + wx->tx_ring_count = new_tx_count; + wx->rx_ring_count = new_rx_count; + +- return 0; ++ goto clear_reset; + } + + /* allocate temporary buffer to store rings in */ + i = max_t(int, wx->num_tx_queues, wx->num_rx_queues); + temp_ring = kvmalloc_array(i, sizeof(struct wx_ring), GFP_KERNEL); +- if (!temp_ring) +- return -ENOMEM; ++ if (!temp_ring) { ++ err = -ENOMEM; ++ goto clear_reset; ++ } + + txgbe_down(wx); + +@@ -55,7 +61,9 @@ static int txgbe_set_ringparam(struct net_device *netdev, + + txgbe_up(wx); + +- return 0; ++clear_reset: ++ clear_bit(WX_STATE_RESETTING, wx->state); ++ return err; + } + + static int txgbe_set_channels(struct net_device *dev, +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +index 5f2966b6b7f34..88ea20946e6ec 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +@@ -268,6 +268,8 @@ static int txgbe_sw_init(struct wx *wx) + wx->tx_work_limit = TXGBE_DEFAULT_TX_WORK; + wx->rx_work_limit = TXGBE_DEFAULT_RX_WORK; + ++ wx->do_reset = txgbe_do_reset; ++ + return 0; + } + +@@ -420,6 +422,34 @@ int txgbe_setup_tc(struct net_device *dev, u8 tc) + return 0; + } + ++static void txgbe_reinit_locked(struct wx *wx) ++{ ++ int err = 0; ++ ++ netif_trans_update(wx->netdev); ++ ++ err = wx_set_state_reset(wx); ++ if (err) { ++ wx_err(wx, "wait device reset timeout\n"); ++ return; ++ } ++ ++ txgbe_down(wx); ++ txgbe_up(wx); ++ ++ clear_bit(WX_STATE_RESETTING, wx->state); ++} ++ ++void txgbe_do_reset(struct net_device *netdev) ++{ ++ struct wx *wx = netdev_priv(netdev); ++ ++ if (netif_running(netdev)) ++ txgbe_reinit_locked(wx); ++ else ++ txgbe_reset(wx); ++} ++ + static const struct net_device_ops txgbe_netdev_ops = { + .ndo_open = txgbe_open, + .ndo_stop = txgbe_close, +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h +index 1b4ff50d58571..f434a7865cb7b 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h +@@ -134,6 +134,7 @@ extern char txgbe_driver_name[]; + void txgbe_down(struct wx *wx); + void txgbe_up(struct wx *wx); + int txgbe_setup_tc(struct net_device *dev, u8 tc); ++void txgbe_do_reset(struct net_device *netdev); + + #define NODE_PROP(_NAME, _PROP) \ + (const struct software_node) { \ +-- +2.43.0 + diff --git a/queue-6.8/net-txgbe-move-interrupt-codes-to-a-separate-file.patch b/queue-6.8/net-txgbe-move-interrupt-codes-to-a-separate-file.patch new file mode 100644 index 00000000000..196f9de7333 --- /dev/null +++ b/queue-6.8/net-txgbe-move-interrupt-codes-to-a-separate-file.patch @@ -0,0 +1,339 @@ +From 2cb820c1ed25da0fcc040e9ef45554cd63dfe181 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Jan 2024 14:22:12 +0800 +Subject: net: txgbe: move interrupt codes to a separate file + +From: Jiawen Wu + +[ Upstream commit 63aabc3ef1961a5eb3049d02a323b3b7fabb9a23 ] + +In order to change the interrupt response structure, there will be a +lot of code added next. Move these interrupt codes to a new file, to +make the codes cleaner. + +Signed-off-by: Jiawen Wu +Signed-off-by: David S. Miller +Stable-dep-of: 1d3c6414950b ("net: txgbe: fix to control VLAN strip") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/txgbe/Makefile | 1 + + .../net/ethernet/wangxun/txgbe/txgbe_irq.c | 137 ++++++++++++++++++ + .../net/ethernet/wangxun/txgbe/txgbe_irq.h | 5 + + .../net/ethernet/wangxun/txgbe/txgbe_main.c | 128 +--------------- + 4 files changed, 144 insertions(+), 127 deletions(-) + create mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c + create mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h + +diff --git a/drivers/net/ethernet/wangxun/txgbe/Makefile b/drivers/net/ethernet/wangxun/txgbe/Makefile +index 7507f762edfe5..42718875277c8 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/Makefile ++++ b/drivers/net/ethernet/wangxun/txgbe/Makefile +@@ -9,4 +9,5 @@ obj-$(CONFIG_TXGBE) += txgbe.o + txgbe-objs := txgbe_main.o \ + txgbe_hw.o \ + txgbe_phy.o \ ++ txgbe_irq.o \ + txgbe_ethtool.o +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c +new file mode 100644 +index 0000000000000..d26ee4cb17678 +--- /dev/null ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c +@@ -0,0 +1,137 @@ ++// SPDX-License-Identifier: GPL-2.0 ++/* Copyright (c) 2015 - 2024 Beijing WangXun Technology Co., Ltd. */ ++ ++#include ++ ++#include "../libwx/wx_type.h" ++#include "../libwx/wx_lib.h" ++#include "../libwx/wx_hw.h" ++#include "txgbe_type.h" ++#include "txgbe_irq.h" ++ ++/** ++ * txgbe_irq_enable - Enable default interrupt generation settings ++ * @wx: pointer to private structure ++ * @queues: enable irqs for queues ++ **/ ++void txgbe_irq_enable(struct wx *wx, bool queues) ++{ ++ wr32(wx, WX_PX_MISC_IEN, TXGBE_PX_MISC_IEN_MASK); ++ ++ /* unmask interrupt */ ++ wx_intr_enable(wx, TXGBE_INTR_MISC); ++ if (queues) ++ wx_intr_enable(wx, TXGBE_INTR_QALL(wx)); ++} ++ ++/** ++ * txgbe_intr - msi/legacy mode Interrupt Handler ++ * @irq: interrupt number ++ * @data: pointer to a network interface device structure ++ **/ ++static irqreturn_t txgbe_intr(int __always_unused irq, void *data) ++{ ++ struct wx_q_vector *q_vector; ++ struct wx *wx = data; ++ struct pci_dev *pdev; ++ u32 eicr; ++ ++ q_vector = wx->q_vector[0]; ++ pdev = wx->pdev; ++ ++ eicr = wx_misc_isb(wx, WX_ISB_VEC0); ++ if (!eicr) { ++ /* shared interrupt alert! ++ * the interrupt that we masked before the ICR read. ++ */ ++ if (netif_running(wx->netdev)) ++ txgbe_irq_enable(wx, true); ++ return IRQ_NONE; /* Not our interrupt */ ++ } ++ wx->isb_mem[WX_ISB_VEC0] = 0; ++ if (!(pdev->msi_enabled)) ++ wr32(wx, WX_PX_INTA, 1); ++ ++ wx->isb_mem[WX_ISB_MISC] = 0; ++ /* would disable interrupts here but it is auto disabled */ ++ napi_schedule_irqoff(&q_vector->napi); ++ ++ /* re-enable link(maybe) and non-queue interrupts, no flush. ++ * txgbe_poll will re-enable the queue interrupts ++ */ ++ if (netif_running(wx->netdev)) ++ txgbe_irq_enable(wx, false); ++ ++ return IRQ_HANDLED; ++} ++ ++/** ++ * txgbe_request_msix_irqs - Initialize MSI-X interrupts ++ * @wx: board private structure ++ * ++ * Allocate MSI-X vectors and request interrupts from the kernel. ++ **/ ++static int txgbe_request_msix_irqs(struct wx *wx) ++{ ++ struct net_device *netdev = wx->netdev; ++ int vector, err; ++ ++ for (vector = 0; vector < wx->num_q_vectors; vector++) { ++ struct wx_q_vector *q_vector = wx->q_vector[vector]; ++ struct msix_entry *entry = &wx->msix_q_entries[vector]; ++ ++ if (q_vector->tx.ring && q_vector->rx.ring) ++ snprintf(q_vector->name, sizeof(q_vector->name) - 1, ++ "%s-TxRx-%d", netdev->name, entry->entry); ++ else ++ /* skip this unused q_vector */ ++ continue; ++ ++ err = request_irq(entry->vector, wx_msix_clean_rings, 0, ++ q_vector->name, q_vector); ++ if (err) { ++ wx_err(wx, "request_irq failed for MSIX interrupt %s Error: %d\n", ++ q_vector->name, err); ++ goto free_queue_irqs; ++ } ++ } ++ ++ return 0; ++ ++free_queue_irqs: ++ while (vector) { ++ vector--; ++ free_irq(wx->msix_q_entries[vector].vector, ++ wx->q_vector[vector]); ++ } ++ wx_reset_interrupt_capability(wx); ++ return err; ++} ++ ++/** ++ * txgbe_request_irq - initialize interrupts ++ * @wx: board private structure ++ * ++ * Attempt to configure interrupts using the best available ++ * capabilities of the hardware and kernel. ++ **/ ++int txgbe_request_irq(struct wx *wx) ++{ ++ struct net_device *netdev = wx->netdev; ++ struct pci_dev *pdev = wx->pdev; ++ int err; ++ ++ if (pdev->msix_enabled) ++ err = txgbe_request_msix_irqs(wx); ++ else if (pdev->msi_enabled) ++ err = request_irq(wx->pdev->irq, &txgbe_intr, 0, ++ netdev->name, wx); ++ else ++ err = request_irq(wx->pdev->irq, &txgbe_intr, IRQF_SHARED, ++ netdev->name, wx); ++ ++ if (err) ++ wx_err(wx, "request_irq failed, Error %d\n", err); ++ ++ return err; ++} +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h +new file mode 100644 +index 0000000000000..02c536421f7df +--- /dev/null ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h +@@ -0,0 +1,5 @@ ++/* SPDX-License-Identifier: GPL-2.0 */ ++/* Copyright (c) 2015 - 2024 Beijing WangXun Technology Co., Ltd. */ ++ ++void txgbe_irq_enable(struct wx *wx, bool queues); ++int txgbe_request_irq(struct wx *wx); +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +index c13c43e07a993..10388c2016031 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +@@ -17,6 +17,7 @@ + #include "txgbe_type.h" + #include "txgbe_hw.h" + #include "txgbe_phy.h" ++#include "txgbe_irq.h" + #include "txgbe_ethtool.h" + + char txgbe_driver_name[] = "txgbe"; +@@ -76,133 +77,6 @@ static int txgbe_enumerate_functions(struct wx *wx) + return physfns; + } + +-/** +- * txgbe_irq_enable - Enable default interrupt generation settings +- * @wx: pointer to private structure +- * @queues: enable irqs for queues +- **/ +-static void txgbe_irq_enable(struct wx *wx, bool queues) +-{ +- wr32(wx, WX_PX_MISC_IEN, TXGBE_PX_MISC_IEN_MASK); +- +- /* unmask interrupt */ +- wx_intr_enable(wx, TXGBE_INTR_MISC); +- if (queues) +- wx_intr_enable(wx, TXGBE_INTR_QALL(wx)); +-} +- +-/** +- * txgbe_intr - msi/legacy mode Interrupt Handler +- * @irq: interrupt number +- * @data: pointer to a network interface device structure +- **/ +-static irqreturn_t txgbe_intr(int __always_unused irq, void *data) +-{ +- struct wx_q_vector *q_vector; +- struct wx *wx = data; +- struct pci_dev *pdev; +- u32 eicr; +- +- q_vector = wx->q_vector[0]; +- pdev = wx->pdev; +- +- eicr = wx_misc_isb(wx, WX_ISB_VEC0); +- if (!eicr) { +- /* shared interrupt alert! +- * the interrupt that we masked before the ICR read. +- */ +- if (netif_running(wx->netdev)) +- txgbe_irq_enable(wx, true); +- return IRQ_NONE; /* Not our interrupt */ +- } +- wx->isb_mem[WX_ISB_VEC0] = 0; +- if (!(pdev->msi_enabled)) +- wr32(wx, WX_PX_INTA, 1); +- +- wx->isb_mem[WX_ISB_MISC] = 0; +- /* would disable interrupts here but it is auto disabled */ +- napi_schedule_irqoff(&q_vector->napi); +- +- /* re-enable link(maybe) and non-queue interrupts, no flush. +- * txgbe_poll will re-enable the queue interrupts +- */ +- if (netif_running(wx->netdev)) +- txgbe_irq_enable(wx, false); +- +- return IRQ_HANDLED; +-} +- +-/** +- * txgbe_request_msix_irqs - Initialize MSI-X interrupts +- * @wx: board private structure +- * +- * Allocate MSI-X vectors and request interrupts from the kernel. +- **/ +-static int txgbe_request_msix_irqs(struct wx *wx) +-{ +- struct net_device *netdev = wx->netdev; +- int vector, err; +- +- for (vector = 0; vector < wx->num_q_vectors; vector++) { +- struct wx_q_vector *q_vector = wx->q_vector[vector]; +- struct msix_entry *entry = &wx->msix_q_entries[vector]; +- +- if (q_vector->tx.ring && q_vector->rx.ring) +- snprintf(q_vector->name, sizeof(q_vector->name) - 1, +- "%s-TxRx-%d", netdev->name, entry->entry); +- else +- /* skip this unused q_vector */ +- continue; +- +- err = request_irq(entry->vector, wx_msix_clean_rings, 0, +- q_vector->name, q_vector); +- if (err) { +- wx_err(wx, "request_irq failed for MSIX interrupt %s Error: %d\n", +- q_vector->name, err); +- goto free_queue_irqs; +- } +- } +- +- return 0; +- +-free_queue_irqs: +- while (vector) { +- vector--; +- free_irq(wx->msix_q_entries[vector].vector, +- wx->q_vector[vector]); +- } +- wx_reset_interrupt_capability(wx); +- return err; +-} +- +-/** +- * txgbe_request_irq - initialize interrupts +- * @wx: board private structure +- * +- * Attempt to configure interrupts using the best available +- * capabilities of the hardware and kernel. +- **/ +-static int txgbe_request_irq(struct wx *wx) +-{ +- struct net_device *netdev = wx->netdev; +- struct pci_dev *pdev = wx->pdev; +- int err; +- +- if (pdev->msix_enabled) +- err = txgbe_request_msix_irqs(wx); +- else if (pdev->msi_enabled) +- err = request_irq(wx->pdev->irq, &txgbe_intr, 0, +- netdev->name, wx); +- else +- err = request_irq(wx->pdev->irq, &txgbe_intr, IRQF_SHARED, +- netdev->name, wx); +- +- if (err) +- wx_err(wx, "request_irq failed, Error %d\n", err); +- +- return err; +-} +- + static void txgbe_up_complete(struct wx *wx) + { + struct net_device *netdev = wx->netdev; +-- +2.43.0 + diff --git a/queue-6.8/net-txgbe-use-irq_domain-for-interrupt-controller.patch b/queue-6.8/net-txgbe-use-irq_domain-for-interrupt-controller.patch new file mode 100644 index 00000000000..607003e8525 --- /dev/null +++ b/queue-6.8/net-txgbe-use-irq_domain-for-interrupt-controller.patch @@ -0,0 +1,500 @@ +From ed884515e0a89019e780c6edadc143e17dc28733 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Jan 2024 14:22:13 +0800 +Subject: net: txgbe: use irq_domain for interrupt controller + +From: Jiawen Wu + +[ Upstream commit aefd013624a10f39b0bfaee8432a235128705380 ] + +In the current interrupt controller, the MAC interrupt acts as the +parent interrupt in the GPIO IRQ chip. But when the number of Rx/Tx +ring changes, the PCI IRQ vector needs to be reallocated. Then this +interrupt controller would be corrupted. So use irq_domain structure +to avoid the above problem. + +Signed-off-by: Jiawen Wu +Signed-off-by: David S. Miller +Stable-dep-of: 1d3c6414950b ("net: txgbe: fix to control VLAN strip") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 - + drivers/net/ethernet/wangxun/libwx/wx_lib.c | 20 ++- + drivers/net/ethernet/wangxun/libwx/wx_type.h | 1 - + .../net/ethernet/wangxun/txgbe/txgbe_irq.c | 132 ++++++++++++++++++ + .../net/ethernet/wangxun/txgbe/txgbe_irq.h | 2 + + .../net/ethernet/wangxun/txgbe/txgbe_main.c | 12 +- + .../net/ethernet/wangxun/txgbe/txgbe_phy.c | 59 +++----- + .../net/ethernet/wangxun/txgbe/txgbe_phy.h | 2 + + .../net/ethernet/wangxun/txgbe/txgbe_type.h | 17 +++ + 9 files changed, 193 insertions(+), 54 deletions(-) + +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c +index 1db754615cca3..945c13d1a9829 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c +@@ -1958,8 +1958,6 @@ int wx_sw_init(struct wx *wx) + return -ENOMEM; + } + +- wx->msix_in_use = false; +- + return 0; + } + EXPORT_SYMBOL(wx_sw_init); +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +index b2d5c3f05eed5..25ac86919395b 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +@@ -1614,14 +1614,12 @@ static int wx_acquire_msix_vectors(struct wx *wx) + /* One for non-queue interrupts */ + nvecs += 1; + +- if (!wx->msix_in_use) { +- wx->msix_entry = kcalloc(1, sizeof(struct msix_entry), +- GFP_KERNEL); +- if (!wx->msix_entry) { +- kfree(wx->msix_q_entries); +- wx->msix_q_entries = NULL; +- return -ENOMEM; +- } ++ wx->msix_entry = kcalloc(1, sizeof(struct msix_entry), ++ GFP_KERNEL); ++ if (!wx->msix_entry) { ++ kfree(wx->msix_q_entries); ++ wx->msix_q_entries = NULL; ++ return -ENOMEM; + } + + nvecs = pci_alloc_irq_vectors_affinity(wx->pdev, nvecs, +@@ -1931,10 +1929,8 @@ void wx_reset_interrupt_capability(struct wx *wx) + if (pdev->msix_enabled) { + kfree(wx->msix_q_entries); + wx->msix_q_entries = NULL; +- if (!wx->msix_in_use) { +- kfree(wx->msix_entry); +- wx->msix_entry = NULL; +- } ++ kfree(wx->msix_entry); ++ wx->msix_entry = NULL; + } + pci_free_irq_vectors(wx->pdev); + } +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h +index b4dc4f3411174..1fdeb464d5f4a 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_type.h ++++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h +@@ -1047,7 +1047,6 @@ struct wx { + unsigned int queues_per_pool; + struct msix_entry *msix_q_entries; + struct msix_entry *msix_entry; +- bool msix_in_use; + struct wx_ring_feature ring_feature[RING_F_ARRAY_SIZE]; + + /* misc interrupt status block */ +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c +index d26ee4cb17678..b3e3605d1edb3 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c +@@ -1,12 +1,14 @@ + // SPDX-License-Identifier: GPL-2.0 + /* Copyright (c) 2015 - 2024 Beijing WangXun Technology Co., Ltd. */ + ++#include + #include + + #include "../libwx/wx_type.h" + #include "../libwx/wx_lib.h" + #include "../libwx/wx_hw.h" + #include "txgbe_type.h" ++#include "txgbe_phy.h" + #include "txgbe_irq.h" + + /** +@@ -135,3 +137,133 @@ int txgbe_request_irq(struct wx *wx) + + return err; + } ++ ++static int txgbe_request_gpio_irq(struct txgbe *txgbe) ++{ ++ txgbe->gpio_irq = irq_find_mapping(txgbe->misc.domain, TXGBE_IRQ_GPIO); ++ return request_threaded_irq(txgbe->gpio_irq, NULL, ++ txgbe_gpio_irq_handler, ++ IRQF_ONESHOT, "txgbe-gpio-irq", txgbe); ++} ++ ++static int txgbe_request_link_irq(struct txgbe *txgbe) ++{ ++ txgbe->link_irq = irq_find_mapping(txgbe->misc.domain, TXGBE_IRQ_LINK); ++ return request_threaded_irq(txgbe->link_irq, NULL, ++ txgbe_link_irq_handler, ++ IRQF_ONESHOT, "txgbe-link-irq", txgbe); ++} ++ ++static const struct irq_chip txgbe_irq_chip = { ++ .name = "txgbe-misc-irq", ++}; ++ ++static int txgbe_misc_irq_domain_map(struct irq_domain *d, ++ unsigned int irq, ++ irq_hw_number_t hwirq) ++{ ++ struct txgbe *txgbe = d->host_data; ++ ++ irq_set_chip_data(irq, txgbe); ++ irq_set_chip(irq, &txgbe->misc.chip); ++ irq_set_nested_thread(irq, true); ++ irq_set_noprobe(irq); ++ ++ return 0; ++} ++ ++static const struct irq_domain_ops txgbe_misc_irq_domain_ops = { ++ .map = txgbe_misc_irq_domain_map, ++}; ++ ++static irqreturn_t txgbe_misc_irq_handle(int irq, void *data) ++{ ++ struct txgbe *txgbe = data; ++ struct wx *wx = txgbe->wx; ++ unsigned int nhandled = 0; ++ unsigned int sub_irq; ++ u32 eicr; ++ ++ eicr = wx_misc_isb(wx, WX_ISB_MISC); ++ if (eicr & TXGBE_PX_MISC_GPIO) { ++ sub_irq = irq_find_mapping(txgbe->misc.domain, TXGBE_IRQ_GPIO); ++ handle_nested_irq(sub_irq); ++ nhandled++; ++ } ++ if (eicr & (TXGBE_PX_MISC_ETH_LK | TXGBE_PX_MISC_ETH_LKDN | ++ TXGBE_PX_MISC_ETH_AN)) { ++ sub_irq = irq_find_mapping(txgbe->misc.domain, TXGBE_IRQ_LINK); ++ handle_nested_irq(sub_irq); ++ nhandled++; ++ } ++ ++ wx_intr_enable(wx, TXGBE_INTR_MISC); ++ return (nhandled > 0 ? IRQ_HANDLED : IRQ_NONE); ++} ++ ++static void txgbe_del_irq_domain(struct txgbe *txgbe) ++{ ++ int hwirq, virq; ++ ++ for (hwirq = 0; hwirq < txgbe->misc.nirqs; hwirq++) { ++ virq = irq_find_mapping(txgbe->misc.domain, hwirq); ++ irq_dispose_mapping(virq); ++ } ++ ++ irq_domain_remove(txgbe->misc.domain); ++} ++ ++void txgbe_free_misc_irq(struct txgbe *txgbe) ++{ ++ free_irq(txgbe->gpio_irq, txgbe); ++ free_irq(txgbe->link_irq, txgbe); ++ free_irq(txgbe->misc.irq, txgbe); ++ txgbe_del_irq_domain(txgbe); ++} ++ ++int txgbe_setup_misc_irq(struct txgbe *txgbe) ++{ ++ struct wx *wx = txgbe->wx; ++ int hwirq, err; ++ ++ txgbe->misc.nirqs = 2; ++ txgbe->misc.domain = irq_domain_add_simple(NULL, txgbe->misc.nirqs, 0, ++ &txgbe_misc_irq_domain_ops, txgbe); ++ if (!txgbe->misc.domain) ++ return -ENOMEM; ++ ++ for (hwirq = 0; hwirq < txgbe->misc.nirqs; hwirq++) ++ irq_create_mapping(txgbe->misc.domain, hwirq); ++ ++ txgbe->misc.chip = txgbe_irq_chip; ++ if (wx->pdev->msix_enabled) ++ txgbe->misc.irq = wx->msix_entry->vector; ++ else ++ txgbe->misc.irq = wx->pdev->irq; ++ ++ err = request_threaded_irq(txgbe->misc.irq, NULL, ++ txgbe_misc_irq_handle, ++ IRQF_ONESHOT, ++ wx->netdev->name, txgbe); ++ if (err) ++ goto del_misc_irq; ++ ++ err = txgbe_request_gpio_irq(txgbe); ++ if (err) ++ goto free_msic_irq; ++ ++ err = txgbe_request_link_irq(txgbe); ++ if (err) ++ goto free_gpio_irq; ++ ++ return 0; ++ ++free_gpio_irq: ++ free_irq(txgbe->gpio_irq, txgbe); ++free_msic_irq: ++ free_irq(txgbe->misc.irq, txgbe); ++del_misc_irq: ++ txgbe_del_irq_domain(txgbe); ++ ++ return err; ++} +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h +index 02c536421f7df..b77945e7a0f26 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.h +@@ -3,3 +3,5 @@ + + void txgbe_irq_enable(struct wx *wx, bool queues); + int txgbe_request_irq(struct wx *wx); ++void txgbe_free_misc_irq(struct txgbe *txgbe); ++int txgbe_setup_misc_irq(struct txgbe *txgbe); +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +index 10388c2016031..5f2966b6b7f34 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +@@ -392,6 +392,7 @@ static void txgbe_shutdown(struct pci_dev *pdev) + int txgbe_setup_tc(struct net_device *dev, u8 tc) + { + struct wx *wx = netdev_priv(dev); ++ struct txgbe *txgbe = wx->priv; + + /* Hardware has to reinitialize queues and interrupts to + * match packet buffer alignment. Unfortunately, the +@@ -402,6 +403,7 @@ int txgbe_setup_tc(struct net_device *dev, u8 tc) + else + txgbe_reset(wx); + ++ txgbe_free_misc_irq(txgbe); + wx_clear_interrupt_scheme(wx); + + if (tc) +@@ -410,6 +412,7 @@ int txgbe_setup_tc(struct net_device *dev, u8 tc) + netdev_reset_tc(dev); + + wx_init_interrupt_scheme(wx); ++ txgbe_setup_misc_irq(txgbe); + + if (netif_running(dev)) + txgbe_open(dev); +@@ -626,10 +629,14 @@ static int txgbe_probe(struct pci_dev *pdev, + txgbe->wx = wx; + wx->priv = txgbe; + +- err = txgbe_init_phy(txgbe); ++ err = txgbe_setup_misc_irq(txgbe); + if (err) + goto err_release_hw; + ++ err = txgbe_init_phy(txgbe); ++ if (err) ++ goto err_free_misc_irq; ++ + err = register_netdev(netdev); + if (err) + goto err_remove_phy; +@@ -656,6 +663,8 @@ static int txgbe_probe(struct pci_dev *pdev, + + err_remove_phy: + txgbe_remove_phy(txgbe); ++err_free_misc_irq: ++ txgbe_free_misc_irq(txgbe); + err_release_hw: + wx_clear_interrupt_scheme(wx); + wx_control_hw(wx, false); +@@ -688,6 +697,7 @@ static void txgbe_remove(struct pci_dev *pdev) + unregister_netdev(netdev); + + txgbe_remove_phy(txgbe); ++ txgbe_free_misc_irq(txgbe); + + pci_release_selected_regions(pdev, + pci_select_bars(pdev, IORESOURCE_MEM)); +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +index 1b84d495d14e8..bae0a8ee70142 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +@@ -292,6 +292,21 @@ static int txgbe_phylink_init(struct txgbe *txgbe) + return 0; + } + ++irqreturn_t txgbe_link_irq_handler(int irq, void *data) ++{ ++ struct txgbe *txgbe = data; ++ struct wx *wx = txgbe->wx; ++ u32 status; ++ bool up; ++ ++ status = rd32(wx, TXGBE_CFG_PORT_ST); ++ up = !!(status & TXGBE_CFG_PORT_ST_LINK_UP); ++ ++ phylink_mac_change(wx->phylink, up); ++ ++ return IRQ_HANDLED; ++} ++ + static int txgbe_gpio_get(struct gpio_chip *chip, unsigned int offset) + { + struct wx *wx = gpiochip_get_data(chip); +@@ -437,7 +452,7 @@ static int txgbe_gpio_set_type(struct irq_data *d, unsigned int type) + } + + static const struct irq_chip txgbe_gpio_irq_chip = { +- .name = "txgbe_gpio_irq", ++ .name = "txgbe-gpio-irq", + .irq_ack = txgbe_gpio_irq_ack, + .irq_mask = txgbe_gpio_irq_mask, + .irq_unmask = txgbe_gpio_irq_unmask, +@@ -446,20 +461,14 @@ static const struct irq_chip txgbe_gpio_irq_chip = { + GPIOCHIP_IRQ_RESOURCE_HELPERS, + }; + +-static void txgbe_irq_handler(struct irq_desc *desc) ++irqreturn_t txgbe_gpio_irq_handler(int irq, void *data) + { +- struct irq_chip *chip = irq_desc_get_chip(desc); +- struct wx *wx = irq_desc_get_handler_data(desc); +- struct txgbe *txgbe = wx->priv; ++ struct txgbe *txgbe = data; ++ struct wx *wx = txgbe->wx; + irq_hw_number_t hwirq; + unsigned long gpioirq; + struct gpio_chip *gc; + unsigned long flags; +- u32 eicr; +- +- eicr = wx_misc_isb(wx, WX_ISB_MISC); +- +- chained_irq_enter(chip, desc); + + gpioirq = rd32(wx, WX_GPIO_INTSTATUS); + +@@ -468,7 +477,7 @@ static void txgbe_irq_handler(struct irq_desc *desc) + int gpio = irq_find_mapping(gc->irq.domain, hwirq); + u32 irq_type = irq_get_trigger_type(gpio); + +- generic_handle_domain_irq(gc->irq.domain, hwirq); ++ handle_nested_irq(gpio); + + if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) { + raw_spin_lock_irqsave(&wx->gpio_lock, flags); +@@ -477,17 +486,7 @@ static void txgbe_irq_handler(struct irq_desc *desc) + } + } + +- chained_irq_exit(chip, desc); +- +- if (eicr & (TXGBE_PX_MISC_ETH_LK | TXGBE_PX_MISC_ETH_LKDN | +- TXGBE_PX_MISC_ETH_AN)) { +- u32 reg = rd32(wx, TXGBE_CFG_PORT_ST); +- +- phylink_mac_change(wx->phylink, !!(reg & TXGBE_CFG_PORT_ST_LINK_UP)); +- } +- +- /* unmask interrupt */ +- wx_intr_enable(wx, TXGBE_INTR_MISC); ++ return IRQ_HANDLED; + } + + static int txgbe_gpio_init(struct txgbe *txgbe) +@@ -524,19 +523,6 @@ static int txgbe_gpio_init(struct txgbe *txgbe) + + girq = &gc->irq; + gpio_irq_chip_set_chip(girq, &txgbe_gpio_irq_chip); +- girq->parent_handler = txgbe_irq_handler; +- girq->parent_handler_data = wx; +- girq->num_parents = 1; +- girq->parents = devm_kcalloc(dev, girq->num_parents, +- sizeof(*girq->parents), GFP_KERNEL); +- if (!girq->parents) +- return -ENOMEM; +- +- /* now only suuported on MSI-X interrupt */ +- if (!wx->msix_entry) +- return -EPERM; +- +- girq->parents[0] = wx->msix_entry->vector; + girq->default_type = IRQ_TYPE_NONE; + girq->handler = handle_bad_irq; + +@@ -754,8 +740,6 @@ int txgbe_init_phy(struct txgbe *txgbe) + goto err_unregister_i2c; + } + +- wx->msix_in_use = true; +- + return 0; + + err_unregister_i2c: +@@ -788,5 +772,4 @@ void txgbe_remove_phy(struct txgbe *txgbe) + phylink_destroy(txgbe->wx->phylink); + xpcs_destroy(txgbe->xpcs); + software_node_unregister_node_group(txgbe->nodes.group); +- txgbe->wx->msix_in_use = false; + } +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h +index 1ab592124986a..9855d44076cb8 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.h +@@ -4,6 +4,8 @@ + #ifndef _TXGBE_PHY_H_ + #define _TXGBE_PHY_H_ + ++irqreturn_t txgbe_gpio_irq_handler(int irq, void *data); ++irqreturn_t txgbe_link_irq_handler(int irq, void *data); + int txgbe_init_phy(struct txgbe *txgbe); + void txgbe_remove_phy(struct txgbe *txgbe); + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h +index 270a6fd9ad0b0..1b4ff50d58571 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h +@@ -5,6 +5,7 @@ + #define _TXGBE_TYPE_H_ + + #include ++#include + + /* Device IDs */ + #define TXGBE_DEV_ID_SP1000 0x1001 +@@ -169,15 +170,31 @@ struct txgbe_nodes { + const struct software_node *group[SWNODE_MAX + 1]; + }; + ++enum txgbe_misc_irqs { ++ TXGBE_IRQ_GPIO = 0, ++ TXGBE_IRQ_LINK, ++ TXGBE_IRQ_MAX ++}; ++ ++struct txgbe_irq { ++ struct irq_chip chip; ++ struct irq_domain *domain; ++ int nirqs; ++ int irq; ++}; ++ + struct txgbe { + struct wx *wx; + struct txgbe_nodes nodes; ++ struct txgbe_irq misc; + struct dw_xpcs *xpcs; + struct platform_device *sfp_dev; + struct platform_device *i2c_dev; + struct clk_lookup *clock; + struct clk *clk; + struct gpio_chip *gpio; ++ unsigned int gpio_irq; ++ unsigned int link_irq; + }; + + #endif /* _TXGBE_TYPE_H_ */ +-- +2.43.0 + diff --git a/queue-6.8/net-usb-qmi_wwan-add-telit-fn920c04-compositions.patch b/queue-6.8/net-usb-qmi_wwan-add-telit-fn920c04-compositions.patch new file mode 100644 index 00000000000..38ee87a4cda --- /dev/null +++ b/queue-6.8/net-usb-qmi_wwan-add-telit-fn920c04-compositions.patch @@ -0,0 +1,108 @@ +From b2f962f1a3493eb66bdd0a45beca4ba8f8216bdc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 13:12:07 +0200 +Subject: net: usb: qmi_wwan: add Telit FN920C04 compositions + +From: Daniele Palmas + +[ Upstream commit 0b8fe5bd73249dc20be2e88a12041f8920797b59 ] + +Add the following Telit FN920C04 compositions: + +0x10a0: rmnet + tty (AT/NMEA) + tty (AT) + tty (diag) +T: Bus=03 Lev=01 Prnt=03 Port=06 Cnt=01 Dev#= 5 Spd=480 MxCh= 0 +D: Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 +P: Vendor=1bc7 ProdID=10a0 Rev=05.15 +S: Manufacturer=Telit Cinterion +S: Product=FN920 +S: SerialNumber=92c4c4d8 +C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=500mA +I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=50 Driver=qmi_wwan +E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=32ms +I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option +E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms +I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option +E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms +I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option +E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms + +0x10a4: rmnet + tty (AT) + tty (AT) + tty (diag) +T: Bus=03 Lev=01 Prnt=03 Port=06 Cnt=01 Dev#= 8 Spd=480 MxCh= 0 +D: Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 +P: Vendor=1bc7 ProdID=10a4 Rev=05.15 +S: Manufacturer=Telit Cinterion +S: Product=FN920 +S: SerialNumber=92c4c4d8 +C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=500mA +I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=50 Driver=qmi_wwan +E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=32ms +I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option +E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms +I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option +E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms +I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option +E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms + +0x10a9: rmnet + tty (AT) + tty (diag) + DPL (data packet logging) + adb +T: Bus=03 Lev=01 Prnt=03 Port=06 Cnt=01 Dev#= 9 Spd=480 MxCh= 0 +D: Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 +P: Vendor=1bc7 ProdID=10a9 Rev=05.15 +S: Manufacturer=Telit Cinterion +S: Product=FN920 +S: SerialNumber=92c4c4d8 +C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA +I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=50 Driver=qmi_wwan +E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=32ms +I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option +E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms +I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option +E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +I: If#= 3 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=80 Driver=(none) +E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms +I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) +E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms +E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms + +Signed-off-by: Daniele Palmas +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/usb/qmi_wwan.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c +index edc34402e787f..a5469cf5cf670 100644 +--- a/drivers/net/usb/qmi_wwan.c ++++ b/drivers/net/usb/qmi_wwan.c +@@ -1368,6 +1368,9 @@ static const struct usb_device_id products[] = { + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1060, 2)}, /* Telit LN920 */ + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1070, 2)}, /* Telit FN990 */ + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1080, 2)}, /* Telit FE990 */ ++ {QMI_QUIRK_SET_DTR(0x1bc7, 0x10a0, 0)}, /* Telit FN920C04 */ ++ {QMI_QUIRK_SET_DTR(0x1bc7, 0x10a4, 0)}, /* Telit FN920C04 */ ++ {QMI_QUIRK_SET_DTR(0x1bc7, 0x10a9, 0)}, /* Telit FN920C04 */ + {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)}, /* Telit ME910 */ + {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)}, /* Telit ME910 dual modem */ + {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */ +-- +2.43.0 + diff --git a/queue-6.8/net-usb-smsc95xx-stop-lying-about-skb-truesize.patch b/queue-6.8/net-usb-smsc95xx-stop-lying-about-skb-truesize.patch new file mode 100644 index 00000000000..620cd12ba22 --- /dev/null +++ b/queue-6.8/net-usb-smsc95xx-stop-lying-about-skb-truesize.patch @@ -0,0 +1,87 @@ +From 52778f7b1af7913a370bb02881fab41934db9975 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 08:33:13 +0000 +Subject: net: usb: smsc95xx: stop lying about skb->truesize + +From: Eric Dumazet + +[ Upstream commit d50729f1d60bca822ef6d9c1a5fb28d486bd7593 ] + +Some usb drivers try to set small skb->truesize and break +core networking stacks. + +In this patch, I removed one of the skb->truesize override. + +I also replaced one skb_clone() by an allocation of a fresh +and small skb, to get minimally sized skbs, like we did +in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize +in rx path") and 4ce62d5b2f7a ("net: usb: ax88179_178a: +stop lying about skb->truesize") + +v3: also fix a sparse error ( https://lore.kernel.org/oe-kbuild-all/202405091310.KvncIecx-lkp@intel.com/ ) +v2: leave the skb_trim() game because smsc95xx_rx_csum_offload() + needs the csum part. (Jakub) + While we are it, use get_unaligned() in smsc95xx_rx_csum_offload(). + +Fixes: 2f7ca802bdae ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver") +Signed-off-by: Eric Dumazet +Cc: Steve Glendinning +Cc: UNGLinuxDriver@microchip.com +Reviewed-by: Simon Horman +Link: https://lore.kernel.org/r/20240509083313.2113832-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/usb/smsc95xx.c | 15 +++++++-------- + 1 file changed, 7 insertions(+), 8 deletions(-) + +diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c +index 2fa46baa589e5..cbea246664795 100644 +--- a/drivers/net/usb/smsc95xx.c ++++ b/drivers/net/usb/smsc95xx.c +@@ -1810,9 +1810,11 @@ static int smsc95xx_reset_resume(struct usb_interface *intf) + + static void smsc95xx_rx_csum_offload(struct sk_buff *skb) + { +- skb->csum = *(u16 *)(skb_tail_pointer(skb) - 2); ++ u16 *csum_ptr = (u16 *)(skb_tail_pointer(skb) - 2); ++ ++ skb->csum = (__force __wsum)get_unaligned(csum_ptr); + skb->ip_summed = CHECKSUM_COMPLETE; +- skb_trim(skb, skb->len - 2); ++ skb_trim(skb, skb->len - 2); /* remove csum */ + } + + static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) +@@ -1870,25 +1872,22 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) + if (dev->net->features & NETIF_F_RXCSUM) + smsc95xx_rx_csum_offload(skb); + skb_trim(skb, skb->len - 4); /* remove fcs */ +- skb->truesize = size + sizeof(struct sk_buff); + + return 1; + } + +- ax_skb = skb_clone(skb, GFP_ATOMIC); ++ ax_skb = netdev_alloc_skb_ip_align(dev->net, size); + if (unlikely(!ax_skb)) { + netdev_warn(dev->net, "Error allocating skb\n"); + return 0; + } + +- ax_skb->len = size; +- ax_skb->data = packet; +- skb_set_tail_pointer(ax_skb, size); ++ skb_put(ax_skb, size); ++ memcpy(ax_skb->data, packet, size); + + if (dev->net->features & NETIF_F_RXCSUM) + smsc95xx_rx_csum_offload(ax_skb); + skb_trim(ax_skb, ax_skb->len - 4); /* remove fcs */ +- ax_skb->truesize = size + sizeof(struct sk_buff); + + usbnet_skb_return(dev, ax_skb); + } +-- +2.43.0 + diff --git a/queue-6.8/net-usb-sr9700-stop-lying-about-skb-truesize.patch b/queue-6.8/net-usb-sr9700-stop-lying-about-skb-truesize.patch new file mode 100644 index 00000000000..de9c04126de --- /dev/null +++ b/queue-6.8/net-usb-sr9700-stop-lying-about-skb-truesize.patch @@ -0,0 +1,59 @@ +From 188fc13e84a2aa37cc877a99e2899c769e03f107 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 14:39:39 +0000 +Subject: net: usb: sr9700: stop lying about skb->truesize + +From: Eric Dumazet + +[ Upstream commit 05417aa9c0c038da2464a0c504b9d4f99814a23b ] + +Some usb drivers set small skb->truesize and break +core networking stacks. + +In this patch, I removed one of the skb->truesize override. + +I also replaced one skb_clone() by an allocation of a fresh +and small skb, to get minimally sized skbs, like we did +in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize +in rx path") and 4ce62d5b2f7a ("net: usb: ax88179_178a: +stop lying about skb->truesize") + +Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") +Signed-off-by: Eric Dumazet +Link: https://lore.kernel.org/r/20240506143939.3673865-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/usb/sr9700.c | 10 +++------- + 1 file changed, 3 insertions(+), 7 deletions(-) + +diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c +index 3164451e1010c..0a662e42ed965 100644 +--- a/drivers/net/usb/sr9700.c ++++ b/drivers/net/usb/sr9700.c +@@ -421,19 +421,15 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) + skb_pull(skb, 3); + skb->len = len; + skb_set_tail_pointer(skb, len); +- skb->truesize = len + sizeof(struct sk_buff); + return 2; + } + +- /* skb_clone is used for address align */ +- sr_skb = skb_clone(skb, GFP_ATOMIC); ++ sr_skb = netdev_alloc_skb_ip_align(dev->net, len); + if (!sr_skb) + return 0; + +- sr_skb->len = len; +- sr_skb->data = skb->data + 3; +- skb_set_tail_pointer(sr_skb, len); +- sr_skb->truesize = len + sizeof(struct sk_buff); ++ skb_put(sr_skb, len); ++ memcpy(sr_skb->data, skb->data + 3, len); + usbnet_skb_return(dev, sr_skb); + + skb_pull(skb, len + SR_RX_OVERHEAD); +-- +2.43.0 + diff --git a/queue-6.8/net-wangxun-fix-to-change-rx-features.patch b/queue-6.8/net-wangxun-fix-to-change-rx-features.patch new file mode 100644 index 00000000000..4397e88bb90 --- /dev/null +++ b/queue-6.8/net-wangxun-fix-to-change-rx-features.patch @@ -0,0 +1,47 @@ +From e43d099316e16416ea1660e4a8d721bb967d2fe2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 17 May 2024 14:51:38 +0800 +Subject: net: wangxun: fix to change Rx features + +From: Jiawen Wu + +[ Upstream commit 68067f065ee730c7c67b361c3c81808d25d5a90b ] + +Fix the issue where some Rx features cannot be changed. + +When using ethtool -K to turn off rx offload, it returns error and +displays "Could not change any device features". And netdev->features +is not assigned a new value to actually configure the hardware. + +Fixes: 6dbedcffcf54 ("net: libwx: Implement xx_set_features ops") +Signed-off-by: Jiawen Wu +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/libwx/wx_lib.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +index 08d3e4069c5fa..6aa6073476f7d 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +@@ -2694,12 +2694,14 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features) + wx->rss_enabled = false; + } + ++ netdev->features = features; ++ + if (changed & + (NETIF_F_HW_VLAN_CTAG_RX | + NETIF_F_HW_VLAN_STAG_RX)) + wx_set_rx_mode(netdev); + +- return 1; ++ return 0; + } + EXPORT_SYMBOL(wx_set_features); + +-- +2.43.0 + diff --git a/queue-6.8/net-wangxun-match-vlan-ctag-and-stag-features.patch b/queue-6.8/net-wangxun-match-vlan-ctag-and-stag-features.patch new file mode 100644 index 00000000000..c88e23e8610 --- /dev/null +++ b/queue-6.8/net-wangxun-match-vlan-ctag-and-stag-features.patch @@ -0,0 +1,123 @@ +From 1eab723086c309f6ef9b39a29aab6a359c2640d2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 17 May 2024 14:51:39 +0800 +Subject: net: wangxun: match VLAN CTAG and STAG features + +From: Jiawen Wu + +[ Upstream commit ac71ab7816b675f1c9614015bd87bfccb456c394 ] + +Hardware requires VLAN CTAG and STAG configuration always matches. And +whether VLAN CTAG or STAG changes, the configuration needs to be changed +as well. + +Fixes: 6670f1ece2c8 ("net: txgbe: Add netdev features support") +Signed-off-by: Jiawen Wu +Reviewed-by: Sai Krishna +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/libwx/wx_lib.c | 46 +++++++++++++++++++ + drivers/net/ethernet/wangxun/libwx/wx_lib.h | 2 + + drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 1 + + .../net/ethernet/wangxun/txgbe/txgbe_main.c | 1 + + 4 files changed, 50 insertions(+) + +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +index 6aa6073476f7d..b2d5c3f05eed5 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c ++++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c +@@ -2705,6 +2705,52 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features) + } + EXPORT_SYMBOL(wx_set_features); + ++#define NETIF_VLAN_STRIPPING_FEATURES (NETIF_F_HW_VLAN_CTAG_RX | \ ++ NETIF_F_HW_VLAN_STAG_RX) ++ ++#define NETIF_VLAN_INSERTION_FEATURES (NETIF_F_HW_VLAN_CTAG_TX | \ ++ NETIF_F_HW_VLAN_STAG_TX) ++ ++#define NETIF_VLAN_FILTERING_FEATURES (NETIF_F_HW_VLAN_CTAG_FILTER | \ ++ NETIF_F_HW_VLAN_STAG_FILTER) ++ ++netdev_features_t wx_fix_features(struct net_device *netdev, ++ netdev_features_t features) ++{ ++ netdev_features_t changed = netdev->features ^ features; ++ struct wx *wx = netdev_priv(netdev); ++ ++ if (changed & NETIF_VLAN_STRIPPING_FEATURES) { ++ if ((features & NETIF_VLAN_STRIPPING_FEATURES) != NETIF_VLAN_STRIPPING_FEATURES && ++ (features & NETIF_VLAN_STRIPPING_FEATURES) != 0) { ++ features &= ~NETIF_VLAN_STRIPPING_FEATURES; ++ features |= netdev->features & NETIF_VLAN_STRIPPING_FEATURES; ++ wx_err(wx, "802.1Q and 802.1ad VLAN stripping must be either both on or both off."); ++ } ++ } ++ ++ if (changed & NETIF_VLAN_INSERTION_FEATURES) { ++ if ((features & NETIF_VLAN_INSERTION_FEATURES) != NETIF_VLAN_INSERTION_FEATURES && ++ (features & NETIF_VLAN_INSERTION_FEATURES) != 0) { ++ features &= ~NETIF_VLAN_INSERTION_FEATURES; ++ features |= netdev->features & NETIF_VLAN_INSERTION_FEATURES; ++ wx_err(wx, "802.1Q and 802.1ad VLAN insertion must be either both on or both off."); ++ } ++ } ++ ++ if (changed & NETIF_VLAN_FILTERING_FEATURES) { ++ if ((features & NETIF_VLAN_FILTERING_FEATURES) != NETIF_VLAN_FILTERING_FEATURES && ++ (features & NETIF_VLAN_FILTERING_FEATURES) != 0) { ++ features &= ~NETIF_VLAN_FILTERING_FEATURES; ++ features |= netdev->features & NETIF_VLAN_FILTERING_FEATURES; ++ wx_err(wx, "802.1Q and 802.1ad VLAN filtering must be either both on or both off."); ++ } ++ } ++ ++ return features; ++} ++EXPORT_SYMBOL(wx_fix_features); ++ + void wx_set_ring(struct wx *wx, u32 new_tx_count, + u32 new_rx_count, struct wx_ring *temp_ring) + { +diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.h b/drivers/net/ethernet/wangxun/libwx/wx_lib.h +index ec909e876720c..c41b29ea812ff 100644 +--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.h ++++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.h +@@ -30,6 +30,8 @@ int wx_setup_resources(struct wx *wx); + void wx_get_stats64(struct net_device *netdev, + struct rtnl_link_stats64 *stats); + int wx_set_features(struct net_device *netdev, netdev_features_t features); ++netdev_features_t wx_fix_features(struct net_device *netdev, ++ netdev_features_t features); + void wx_set_ring(struct wx *wx, u32 new_tx_count, + u32 new_rx_count, struct wx_ring *temp_ring); + +diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c +index fdd6b4f70b7a5..e894e01d030d1 100644 +--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c ++++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c +@@ -499,6 +499,7 @@ static const struct net_device_ops ngbe_netdev_ops = { + .ndo_start_xmit = wx_xmit_frame, + .ndo_set_rx_mode = wx_set_rx_mode, + .ndo_set_features = wx_set_features, ++ .ndo_fix_features = wx_fix_features, + .ndo_validate_addr = eth_validate_addr, + .ndo_set_mac_address = wx_set_mac, + .ndo_get_stats64 = wx_get_stats64, +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +index 3b151c410a5c2..c13c43e07a993 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +@@ -550,6 +550,7 @@ static const struct net_device_ops txgbe_netdev_ops = { + .ndo_start_xmit = wx_xmit_frame, + .ndo_set_rx_mode = wx_set_rx_mode, + .ndo_set_features = wx_set_features, ++ .ndo_fix_features = wx_fix_features, + .ndo_validate_addr = eth_validate_addr, + .ndo_set_mac_address = wx_set_mac, + .ndo_get_stats64 = wx_get_stats64, +-- +2.43.0 + diff --git a/queue-6.8/netrom-fix-possible-dead-lock-in-nr_rt_ioctl.patch b/queue-6.8/netrom-fix-possible-dead-lock-in-nr_rt_ioctl.patch new file mode 100644 index 00000000000..d50e77eff72 --- /dev/null +++ b/queue-6.8/netrom-fix-possible-dead-lock-in-nr_rt_ioctl.patch @@ -0,0 +1,192 @@ +From c3343e75c346e3e1f04989cb04701c485c751d1c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 15 May 2024 14:29:34 +0000 +Subject: netrom: fix possible dead-lock in nr_rt_ioctl() + +From: Eric Dumazet + +[ Upstream commit e03e7f20ebf7e1611d40d1fdc1bde900fd3335f6 ] + +syzbot loves netrom, and found a possible deadlock in nr_rt_ioctl [1] + +Make sure we always acquire nr_node_list_lock before nr_node_lock(nr_node) + +[1] +WARNING: possible circular locking dependency detected +6.9.0-rc7-syzkaller-02147-g654de42f3fc6 #0 Not tainted +------------------------------------------------------ +syz-executor350/5129 is trying to acquire lock: + ffff8880186e2070 (&nr_node->node_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] + ffff8880186e2070 (&nr_node->node_lock){+...}-{2:2}, at: nr_node_lock include/net/netrom.h:152 [inline] + ffff8880186e2070 (&nr_node->node_lock){+...}-{2:2}, at: nr_dec_obs net/netrom/nr_route.c:464 [inline] + ffff8880186e2070 (&nr_node->node_lock){+...}-{2:2}, at: nr_rt_ioctl+0x1bb/0x1090 net/netrom/nr_route.c:697 + +but task is already holding lock: + ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] + ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: nr_dec_obs net/netrom/nr_route.c:462 [inline] + ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: nr_rt_ioctl+0x10a/0x1090 net/netrom/nr_route.c:697 + +which lock already depends on the new lock. + +the existing dependency chain (in reverse order) is: + +-> #1 (nr_node_list_lock){+...}-{2:2}: + lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 + __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] + _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 + spin_lock_bh include/linux/spinlock.h:356 [inline] + nr_remove_node net/netrom/nr_route.c:299 [inline] + nr_del_node+0x4b4/0x820 net/netrom/nr_route.c:355 + nr_rt_ioctl+0xa95/0x1090 net/netrom/nr_route.c:683 + sock_do_ioctl+0x158/0x460 net/socket.c:1222 + sock_ioctl+0x629/0x8e0 net/socket.c:1341 + vfs_ioctl fs/ioctl.c:51 [inline] + __do_sys_ioctl fs/ioctl.c:904 [inline] + __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:890 + do_syscall_x64 arch/x86/entry/common.c:52 [inline] + do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 + entry_SYSCALL_64_after_hwframe+0x77/0x7f + +-> #0 (&nr_node->node_lock){+...}-{2:2}: + check_prev_add kernel/locking/lockdep.c:3134 [inline] + check_prevs_add kernel/locking/lockdep.c:3253 [inline] + validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 + __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 + lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 + __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] + _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 + spin_lock_bh include/linux/spinlock.h:356 [inline] + nr_node_lock include/net/netrom.h:152 [inline] + nr_dec_obs net/netrom/nr_route.c:464 [inline] + nr_rt_ioctl+0x1bb/0x1090 net/netrom/nr_route.c:697 + sock_do_ioctl+0x158/0x460 net/socket.c:1222 + sock_ioctl+0x629/0x8e0 net/socket.c:1341 + vfs_ioctl fs/ioctl.c:51 [inline] + __do_sys_ioctl fs/ioctl.c:904 [inline] + __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:890 + do_syscall_x64 arch/x86/entry/common.c:52 [inline] + do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 + entry_SYSCALL_64_after_hwframe+0x77/0x7f + +other info that might help us debug this: + + Possible unsafe locking scenario: + + CPU0 CPU1 + ---- ---- + lock(nr_node_list_lock); + lock(&nr_node->node_lock); + lock(nr_node_list_lock); + lock(&nr_node->node_lock); + + *** DEADLOCK *** + +1 lock held by syz-executor350/5129: + #0: ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] + #0: ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: nr_dec_obs net/netrom/nr_route.c:462 [inline] + #0: ffffffff8f7053b8 (nr_node_list_lock){+...}-{2:2}, at: nr_rt_ioctl+0x10a/0x1090 net/netrom/nr_route.c:697 + +stack backtrace: +CPU: 0 PID: 5129 Comm: syz-executor350 Not tainted 6.9.0-rc7-syzkaller-02147-g654de42f3fc6 #0 +Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 +Call Trace: + + __dump_stack lib/dump_stack.c:88 [inline] + dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 + check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 + check_prev_add kernel/locking/lockdep.c:3134 [inline] + check_prevs_add kernel/locking/lockdep.c:3253 [inline] + validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 + __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 + lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 + __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] + _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 + spin_lock_bh include/linux/spinlock.h:356 [inline] + nr_node_lock include/net/netrom.h:152 [inline] + nr_dec_obs net/netrom/nr_route.c:464 [inline] + nr_rt_ioctl+0x1bb/0x1090 net/netrom/nr_route.c:697 + sock_do_ioctl+0x158/0x460 net/socket.c:1222 + sock_ioctl+0x629/0x8e0 net/socket.c:1341 + vfs_ioctl fs/ioctl.c:51 [inline] + __do_sys_ioctl fs/ioctl.c:904 [inline] + __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:890 + do_syscall_x64 arch/x86/entry/common.c:52 [inline] + do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 + entry_SYSCALL_64_after_hwframe+0x77/0x7f + +Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") +Reported-by: syzbot +Signed-off-by: Eric Dumazet +Reviewed-by: Simon Horman +Link: https://lore.kernel.org/r/20240515142934.3708038-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/netrom/nr_route.c | 19 +++++++------------ + 1 file changed, 7 insertions(+), 12 deletions(-) + +diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c +index 70480869ad1c5..bd2b17b219ae9 100644 +--- a/net/netrom/nr_route.c ++++ b/net/netrom/nr_route.c +@@ -285,22 +285,14 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic, + return 0; + } + +-static inline void __nr_remove_node(struct nr_node *nr_node) ++static void nr_remove_node_locked(struct nr_node *nr_node) + { ++ lockdep_assert_held(&nr_node_list_lock); ++ + hlist_del_init(&nr_node->node_node); + nr_node_put(nr_node); + } + +-#define nr_remove_node_locked(__node) \ +- __nr_remove_node(__node) +- +-static void nr_remove_node(struct nr_node *nr_node) +-{ +- spin_lock_bh(&nr_node_list_lock); +- __nr_remove_node(nr_node); +- spin_unlock_bh(&nr_node_list_lock); +-} +- + static inline void __nr_remove_neigh(struct nr_neigh *nr_neigh) + { + hlist_del_init(&nr_neigh->neigh_node); +@@ -339,6 +331,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n + return -EINVAL; + } + ++ spin_lock_bh(&nr_node_list_lock); + nr_node_lock(nr_node); + for (i = 0; i < nr_node->count; i++) { + if (nr_node->routes[i].neighbour == nr_neigh) { +@@ -352,7 +345,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n + nr_node->count--; + + if (nr_node->count == 0) { +- nr_remove_node(nr_node); ++ nr_remove_node_locked(nr_node); + } else { + switch (i) { + case 0: +@@ -367,12 +360,14 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n + nr_node_put(nr_node); + } + nr_node_unlock(nr_node); ++ spin_unlock_bh(&nr_node_list_lock); + + return 0; + } + } + nr_neigh_put(nr_neigh); + nr_node_unlock(nr_node); ++ spin_unlock_bh(&nr_node_list_lock); + nr_node_put(nr_node); + + return -EINVAL; +-- +2.43.0 + diff --git a/queue-6.8/nfsd-don-t-create-nfsv4recoverydir-in-nfsdfs-when-no.patch b/queue-6.8/nfsd-don-t-create-nfsv4recoverydir-in-nfsdfs-when-no.patch new file mode 100644 index 00000000000..48073a9c95e --- /dev/null +++ b/queue-6.8/nfsd-don-t-create-nfsv4recoverydir-in-nfsdfs-when-no.patch @@ -0,0 +1,68 @@ +From 4fd94d6dde766640695efc41733e9643be840b35 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 17 Apr 2024 07:23:02 +1000 +Subject: nfsd: don't create nfsv4recoverydir in nfsdfs when not used. + +From: NeilBrown + +[ Upstream commit 0770249b90f9d9f69714b76adc36cf6c895bc1f9 ] + +When CONFIG_NFSD_LEGACY_CLIENT_TRACKING is not set, the virtual file + /proc/fs/nfsd/nfsv4recoverydir +is created but responds EINVAL to any access. +This is not useful, is somewhat surprising, and it causes ltp to +complain. + +The only known user of this file is in nfs-utils, which handles +non-existence and read-failure equally well. So there is nothing to +gain from leaving the file present but inaccessible. + +So this patch removes the file when its content is not available - i.e. +when that config option is not selected. + +Also remove the #ifdef which hides some of the enum values when +CONFIG_NFSD_V$ not selection. simple_fill_super() quietly ignores array +entries that are not present, so having slots in the array that don't +get used is perfectly acceptable. So there is no value in this #ifdef. + +Reported-by: Petr Vorel +Reviewed-by: Jeff Layton +Fixes: 74fd48739d04 ("nfsd: new Kconfig option for legacy client tracking") +Signed-off-by: NeilBrown +Reviewed-by: Petr Vorel +Signed-off-by: Chuck Lever +Signed-off-by: Sasha Levin +--- + fs/nfsd/nfsctl.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c +index ea3c8114245c2..d8f54eb7455e3 100644 +--- a/fs/nfsd/nfsctl.c ++++ b/fs/nfsd/nfsctl.c +@@ -48,12 +48,10 @@ enum { + NFSD_MaxBlkSize, + NFSD_MaxConnections, + NFSD_Filecache, +-#ifdef CONFIG_NFSD_V4 + NFSD_Leasetime, + NFSD_Gracetime, + NFSD_RecoveryDir, + NFSD_V4EndGrace, +-#endif + NFSD_MaxReserved + }; + +@@ -1359,7 +1357,9 @@ static int nfsd_fill_super(struct super_block *sb, struct fs_context *fc) + #ifdef CONFIG_NFSD_V4 + [NFSD_Leasetime] = {"nfsv4leasetime", &transaction_ops, S_IWUSR|S_IRUSR}, + [NFSD_Gracetime] = {"nfsv4gracetime", &transaction_ops, S_IWUSR|S_IRUSR}, ++#ifdef CONFIG_NFSD_LEGACY_CLIENT_TRACKING + [NFSD_RecoveryDir] = {"nfsv4recoverydir", &transaction_ops, S_IWUSR|S_IRUSR}, ++#endif + [NFSD_V4EndGrace] = {"v4_end_grace", &transaction_ops, S_IWUSR|S_IRUGO}, + #endif + /* last one */ {""} +-- +2.43.0 + diff --git a/queue-6.8/nilfs2-fix-out-of-range-warning.patch b/queue-6.8/nilfs2-fix-out-of-range-warning.patch new file mode 100644 index 00000000000..866de995f3f --- /dev/null +++ b/queue-6.8/nilfs2-fix-out-of-range-warning.patch @@ -0,0 +1,45 @@ +From 5b7007bfe9dac0e804c6d45dfc90f006f35db870 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 15:30:44 +0100 +Subject: nilfs2: fix out-of-range warning + +From: Arnd Bergmann + +[ Upstream commit c473bcdd80d4ab2ae79a7a509a6712818366e32a ] + +clang-14 points out that v_size is always smaller than a 64KB +page size if that is configured by the CPU architecture: + +fs/nilfs2/ioctl.c:63:19: error: result of comparison of constant 65536 with expression of type '__u16' (aka 'unsigned short') is always false [-Werror,-Wtautological-constant-out-of-range-compare] + if (argv->v_size > PAGE_SIZE) + ~~~~~~~~~~~~ ^ ~~~~~~~~~ + +This is ok, so just shut up that warning with a cast. + +Signed-off-by: Arnd Bergmann +Link: https://lore.kernel.org/r/20240328143051.1069575-7-arnd@kernel.org +Fixes: 3358b4aaa84f ("nilfs2: fix problems of memory allocation in ioctl") +Acked-by: Ryusuke Konishi +Reviewed-by: Justin Stitt +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/nilfs2/ioctl.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c +index cfb6aca5ec383..d6e3f20e8872e 100644 +--- a/fs/nilfs2/ioctl.c ++++ b/fs/nilfs2/ioctl.c +@@ -60,7 +60,7 @@ static int nilfs_ioctl_wrap_copy(struct the_nilfs *nilfs, + if (argv->v_nmembs == 0) + return 0; + +- if (argv->v_size > PAGE_SIZE) ++ if ((size_t)argv->v_size > PAGE_SIZE) + return -EINVAL; + + /* +-- +2.43.0 + diff --git a/queue-6.8/nilfs2-make-superblock-data-array-index-computation-.patch b/queue-6.8/nilfs2-make-superblock-data-array-index-computation-.patch new file mode 100644 index 00000000000..20cee82b9e1 --- /dev/null +++ b/queue-6.8/nilfs2-make-superblock-data-array-index-computation-.patch @@ -0,0 +1,73 @@ +From 1a2b8f7bac3225b1cebdde61de11e1026227d182 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 17:00:19 +0900 +Subject: nilfs2: make superblock data array index computation sparse friendly + +From: Ryusuke Konishi + +[ Upstream commit 91d743a9c8299de1fc1b47428d8bb4c85face00f ] + +Upon running sparse, "warning: dubious: x & !y" is output at an array +index calculation within nilfs_load_super_block(). + +The calculation is not wrong, but to eliminate the sparse warning, replace +it with an equivalent calculation. + +Also, add a comment to make it easier to understand what the unintuitive +array index calculation is doing and whether it's correct. + +Link: https://lkml.kernel.org/r/20240430080019.4242-3-konishi.ryusuke@gmail.com +Fixes: e339ad31f599 ("nilfs2: introduce secondary super block") +Signed-off-by: Ryusuke Konishi +Cc: Bart Van Assche +Cc: Jens Axboe +Cc: kernel test robot +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + fs/nilfs2/the_nilfs.c | 20 ++++++++++++++++++-- + 1 file changed, 18 insertions(+), 2 deletions(-) + +diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c +index 71400496ed365..3e3c1d32da180 100644 +--- a/fs/nilfs2/the_nilfs.c ++++ b/fs/nilfs2/the_nilfs.c +@@ -592,7 +592,7 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, + struct nilfs_super_block **sbp = nilfs->ns_sbp; + struct buffer_head **sbh = nilfs->ns_sbh; + u64 sb2off, devsize = bdev_nr_bytes(nilfs->ns_bdev); +- int valid[2], swp = 0; ++ int valid[2], swp = 0, older; + + if (devsize < NILFS_SEG_MIN_BLOCKS * NILFS_MIN_BLOCK_SIZE + 4096) { + nilfs_err(sb, "device size too small"); +@@ -648,9 +648,25 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, + if (swp) + nilfs_swap_super_block(nilfs); + ++ /* ++ * Calculate the array index of the older superblock data. ++ * If one has been dropped, set index 0 pointing to the remaining one, ++ * otherwise set index 1 pointing to the old one (including if both ++ * are the same). ++ * ++ * Divided case valid[0] valid[1] swp -> older ++ * ------------------------------------------------------------- ++ * Both SBs are invalid 0 0 N/A (Error) ++ * SB1 is invalid 0 1 1 0 ++ * SB2 is invalid 1 0 0 0 ++ * SB2 is newer 1 1 1 0 ++ * SB2 is older or the same 1 1 0 1 ++ */ ++ older = valid[1] ^ swp; ++ + nilfs->ns_sbwcount = 0; + nilfs->ns_sbwtime = le64_to_cpu(sbp[0]->s_wtime); +- nilfs->ns_prot_seq = le64_to_cpu(sbp[valid[1] & !swp]->s_last_seq); ++ nilfs->ns_prot_seq = le64_to_cpu(sbp[older]->s_last_seq); + *sbpp = sbp[0]; + return 0; + } +-- +2.43.0 + diff --git a/queue-6.8/null_blk-fix-missing-mutex_destroy-at-module-removal.patch b/queue-6.8/null_blk-fix-missing-mutex_destroy-at-module-removal.patch new file mode 100644 index 00000000000..f001fa4f75a --- /dev/null +++ b/queue-6.8/null_blk-fix-missing-mutex_destroy-at-module-removal.patch @@ -0,0 +1,37 @@ +From a9fdd79c7111aa87b5eab6933eb5c1716f5f96e2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 19:16:35 +0200 +Subject: null_blk: Fix missing mutex_destroy() at module removal + +From: Zhu Yanjun + +[ Upstream commit 07d1b99825f40f9c0d93e6b99d79a08d0717bac1 ] + +When a mutex lock is not used any more, the function mutex_destroy +should be called to mark the mutex lock uninitialized. + +Fixes: f2298c0403b0 ("null_blk: multi queue aware block test driver") +Signed-off-by: Zhu Yanjun +Link: https://lore.kernel.org/r/20240425171635.4227-1-yanjun.zhu@linux.dev +Signed-off-by: Jens Axboe +Signed-off-by: Sasha Levin +--- + drivers/block/null_blk/main.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c +index 36755f263e8ec..3584f389b92ce 100644 +--- a/drivers/block/null_blk/main.c ++++ b/drivers/block/null_blk/main.c +@@ -2372,6 +2372,8 @@ static void __exit null_exit(void) + + if (g_queue_mode == NULL_Q_MQ && shared_tags) + blk_mq_free_tag_set(&tag_set); ++ ++ mutex_destroy(&lock); + } + + module_init(null_init); +-- +2.43.0 + diff --git a/queue-6.8/nvme-cancel-pending-i-o-if-nvme-controller-is-in-ter.patch b/queue-6.8/nvme-cancel-pending-i-o-if-nvme-controller-is-in-ter.patch new file mode 100644 index 00000000000..01df0ed618c --- /dev/null +++ b/queue-6.8/nvme-cancel-pending-i-o-if-nvme-controller-is-in-ter.patch @@ -0,0 +1,126 @@ +From 79f5dfbf40ab638d2acb11d815be819ac2c865d3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 19:33:00 +0530 +Subject: nvme: cancel pending I/O if nvme controller is in terminal state + +From: Nilay Shroff + +[ Upstream commit 25bb3534ee21e39eb9301c4edd7182eb83cb0d07 ] + +While I/O is running, if the pci bus error occurs then +in-flight I/O can not complete. Worst, if at this time, +user (logically) hot-unplug the nvme disk then the +nvme_remove() code path can't forward progress until +in-flight I/O is cancelled. So these sequence of events +may potentially hang hot-unplug code path indefinitely. +This patch helps cancel the pending/in-flight I/O from the +nvme request timeout handler in case the nvme controller +is in the terminal (DEAD/DELETING/DELETING_NOIO) state and +that helps nvme_remove() code path forward progress and +finish successfully. + +Link: https://lore.kernel.org/all/199be893-5dfa-41e5-b6f2-40ac90ebccc4@linux.ibm.com/ +Signed-off-by: Nilay Shroff +Reviewed-by: Sagi Grimberg +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/host/core.c | 21 --------------------- + drivers/nvme/host/nvme.h | 21 +++++++++++++++++++++ + drivers/nvme/host/pci.c | 8 +++++++- + 3 files changed, 28 insertions(+), 22 deletions(-) + +diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c +index 26153cb7647d7..3cc79817e4d75 100644 +--- a/drivers/nvme/host/core.c ++++ b/drivers/nvme/host/core.c +@@ -619,27 +619,6 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl, + } + EXPORT_SYMBOL_GPL(nvme_change_ctrl_state); + +-/* +- * Returns true for sink states that can't ever transition back to live. +- */ +-static bool nvme_state_terminal(struct nvme_ctrl *ctrl) +-{ +- switch (nvme_ctrl_state(ctrl)) { +- case NVME_CTRL_NEW: +- case NVME_CTRL_LIVE: +- case NVME_CTRL_RESETTING: +- case NVME_CTRL_CONNECTING: +- return false; +- case NVME_CTRL_DELETING: +- case NVME_CTRL_DELETING_NOIO: +- case NVME_CTRL_DEAD: +- return true; +- default: +- WARN_ONCE(1, "Unhandled ctrl state:%d", ctrl->state); +- return true; +- } +-} +- + /* + * Waits for the controller state to be resetting, or returns false if it is + * not possible to ever transition to that state. +diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h +index 738719085e054..2a7bf574284f6 100644 +--- a/drivers/nvme/host/nvme.h ++++ b/drivers/nvme/host/nvme.h +@@ -745,6 +745,27 @@ static inline bool nvme_is_aen_req(u16 qid, __u16 command_id) + nvme_tag_from_cid(command_id) >= NVME_AQ_BLK_MQ_DEPTH; + } + ++/* ++ * Returns true for sink states that can't ever transition back to live. ++ */ ++static inline bool nvme_state_terminal(struct nvme_ctrl *ctrl) ++{ ++ switch (nvme_ctrl_state(ctrl)) { ++ case NVME_CTRL_NEW: ++ case NVME_CTRL_LIVE: ++ case NVME_CTRL_RESETTING: ++ case NVME_CTRL_CONNECTING: ++ return false; ++ case NVME_CTRL_DELETING: ++ case NVME_CTRL_DELETING_NOIO: ++ case NVME_CTRL_DEAD: ++ return true; ++ default: ++ WARN_ONCE(1, "Unhandled ctrl state:%d", ctrl->state); ++ return true; ++ } ++} ++ + void nvme_complete_rq(struct request *req); + void nvme_complete_batch_req(struct request *req); + +diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c +index 02565dc99ad85..710043086dffa 100644 +--- a/drivers/nvme/host/pci.c ++++ b/drivers/nvme/host/pci.c +@@ -1286,6 +1286,9 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) + u32 csts = readl(dev->bar + NVME_REG_CSTS); + u8 opcode; + ++ if (nvme_state_terminal(&dev->ctrl)) ++ goto disable; ++ + /* If PCI error recovery process is happening, we cannot reset or + * the recovery mechanism will surely fail. + */ +@@ -1390,8 +1393,11 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) + return BLK_EH_RESET_TIMER; + + disable: +- if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_RESETTING)) ++ if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_RESETTING)) { ++ if (nvme_state_terminal(&dev->ctrl)) ++ nvme_dev_disable(dev, true); + return BLK_EH_DONE; ++ } + + nvme_dev_disable(dev, false); + if (nvme_try_sched_reset(&dev->ctrl)) +-- +2.43.0 + diff --git a/queue-6.8/nvme-find-numa-distance-only-if-controller-has-valid.patch b/queue-6.8/nvme-find-numa-distance-only-if-controller-has-valid.patch new file mode 100644 index 00000000000..b103da486b4 --- /dev/null +++ b/queue-6.8/nvme-find-numa-distance-only-if-controller-has-valid.patch @@ -0,0 +1,47 @@ +From 793aca2a695a27f0637f3990e1482bda90d39eb3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 13:49:23 +0530 +Subject: nvme: find numa distance only if controller has valid numa id + +From: Nilay Shroff + +[ Upstream commit 863fe60ed27f2c85172654a63c5b827e72c8b2e6 ] + +On system where native nvme multipath is configured and iopolicy +is set to numa but the nvme controller numa node id is undefined +or -1 (NUMA_NO_NODE) then avoid calculating node distance for +finding optimal io path. In such case we may access numa distance +table with invalid index and that may potentially refer to incorrect +memory. So this patch ensures that if the nvme controller numa node +id is -1 then instead of calculating node distance for finding optimal +io path, we set the numa node distance of such controller to default 10 +(LOCAL_DISTANCE). + +Link: https://lore.kernel.org/all/20240413090614.678353-1-nilay@linux.ibm.com/ +Signed-off-by: Nilay Shroff +Reviewed-by: Christoph Hellwig +Reviewed-by: Sagi Grimberg +Reviewed-by: Chaitanya Kulkarni +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/host/multipath.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c +index 74de1e64aeead..75386d3e0f981 100644 +--- a/drivers/nvme/host/multipath.c ++++ b/drivers/nvme/host/multipath.c +@@ -247,7 +247,8 @@ static struct nvme_ns *__nvme_find_path(struct nvme_ns_head *head, int node) + if (nvme_path_is_disabled(ns)) + continue; + +- if (READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) ++ if (ns->ctrl->numa_node != NUMA_NO_NODE && ++ READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_NUMA) + distance = node_distance(node, ns->ctrl->numa_node); + else + distance = LOCAL_DISTANCE; +-- +2.43.0 + diff --git a/queue-6.8/nvme-tcp-strict-pdu-pacing-to-avoid-send-stalls-on-t.patch b/queue-6.8/nvme-tcp-strict-pdu-pacing-to-avoid-send-stalls-on-t.patch new file mode 100644 index 00000000000..2f8996989ab --- /dev/null +++ b/queue-6.8/nvme-tcp-strict-pdu-pacing-to-avoid-send-stalls-on-t.patch @@ -0,0 +1,62 @@ +From b854b203ecc0c196c9bc87140cc96452ad761b86 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 12:39:45 +0200 +Subject: nvme-tcp: strict pdu pacing to avoid send stalls on TLS + +From: Hannes Reinecke + +[ Upstream commit 50abcc179e0c9ca667feb223b26ea406d5c4c556 ] + +TLS requires a strict pdu pacing via MSG_EOR to signal the end +of a record and subsequent encryption. If we do not set MSG_EOR +at the end of a sequence the record won't be closed, encryption +doesn't start, and we end up with a send stall as the message +will never be passed on to the TCP layer. +So do not check for the queue status when TLS is enabled but +rather make the MSG_MORE setting dependent on the current +request only. + +Signed-off-by: Hannes Reinecke +Reviewed-by: Sagi Grimberg +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/host/tcp.c | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c +index a6d596e056021..6eeb96578d1b4 100644 +--- a/drivers/nvme/host/tcp.c ++++ b/drivers/nvme/host/tcp.c +@@ -352,12 +352,18 @@ static inline void nvme_tcp_send_all(struct nvme_tcp_queue *queue) + } while (ret > 0); + } + +-static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue) ++static inline bool nvme_tcp_queue_has_pending(struct nvme_tcp_queue *queue) + { + return !list_empty(&queue->send_list) || + !llist_empty(&queue->req_list); + } + ++static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue) ++{ ++ return !nvme_tcp_tls(&queue->ctrl->ctrl) && ++ nvme_tcp_queue_has_pending(queue); ++} ++ + static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req, + bool sync, bool last) + { +@@ -378,7 +384,7 @@ static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req, + mutex_unlock(&queue->send_mutex); + } + +- if (last && nvme_tcp_queue_more(queue)) ++ if (last && nvme_tcp_queue_has_pending(queue)) + queue_work_on(queue->io_cpu, nvme_tcp_wq, &queue->io_work); + } + +-- +2.43.0 + diff --git a/queue-6.8/nvmet-auth-replace-pr_debug-with-pr_err-to-report-an.patch b/queue-6.8/nvmet-auth-replace-pr_debug-with-pr_err-to-report-an.patch new file mode 100644 index 00000000000..f4dd63dffea --- /dev/null +++ b/queue-6.8/nvmet-auth-replace-pr_debug-with-pr_err-to-report-an.patch @@ -0,0 +1,41 @@ +From 681cf745dc03f69a0637e878792ac05158ffa189 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 11:48:42 +0200 +Subject: nvmet-auth: replace pr_debug() with pr_err() to report an error. + +From: Maurizio Lombardi + +[ Upstream commit 445f9119e70368ccc964575c2a6d3176966a9d65 ] + +In nvmet_auth_host_hash(), if a mismatch is detected in the hash length +the kernel should print an error. + +Signed-off-by: Maurizio Lombardi +Reviewed-by: Sagi Grimberg +Reviewed-by: Chaitanya Kulkarni +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/auth.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c +index 9e51c064b0728..fb518b00f71f6 100644 +--- a/drivers/nvme/target/auth.c ++++ b/drivers/nvme/target/auth.c +@@ -285,9 +285,9 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, + } + + if (shash_len != crypto_shash_digestsize(shash_tfm)) { +- pr_debug("%s: hash len mismatch (len %d digest %d)\n", +- __func__, shash_len, +- crypto_shash_digestsize(shash_tfm)); ++ pr_err("%s: hash len mismatch (len %d digest %d)\n", ++ __func__, shash_len, ++ crypto_shash_digestsize(shash_tfm)); + ret = -EINVAL; + goto out_free_tfm; + } +-- +2.43.0 + diff --git a/queue-6.8/nvmet-auth-return-the-error-code-to-the-nvmet_auth_h.patch b/queue-6.8/nvmet-auth-return-the-error-code-to-the-nvmet_auth_h.patch new file mode 100644 index 00000000000..e8821b11fe8 --- /dev/null +++ b/queue-6.8/nvmet-auth-return-the-error-code-to-the-nvmet_auth_h.patch @@ -0,0 +1,38 @@ +From ce2c667b3fc26690223e4a3d4680b33795e9ef7b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 11:48:41 +0200 +Subject: nvmet-auth: return the error code to the nvmet_auth_host_hash() + callers + +From: Maurizio Lombardi + +[ Upstream commit 46b8f9f74f6d500871985e22eb19560b21f3bc81 ] + +If the nvmet_auth_host_hash() function fails, the error code should +be returned to its callers. + +Signed-off-by: Maurizio Lombardi +Reviewed-by: Sagi Grimberg +Reviewed-by: Chaitanya Kulkarni +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/auth.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c +index 3ddbc3880cac8..9e51c064b0728 100644 +--- a/drivers/nvme/target/auth.c ++++ b/drivers/nvme/target/auth.c +@@ -370,7 +370,7 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, + nvme_auth_free_key(transformed_key); + out_free_tfm: + crypto_free_shash(shash_tfm); +- return 0; ++ return ret; + } + + int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response, +-- +2.43.0 + diff --git a/queue-6.8/nvmet-fix-nvme-status-code-when-namespace-is-disable.patch b/queue-6.8/nvmet-fix-nvme-status-code-when-namespace-is-disable.patch new file mode 100644 index 00000000000..987a6761d48 --- /dev/null +++ b/queue-6.8/nvmet-fix-nvme-status-code-when-namespace-is-disable.patch @@ -0,0 +1,94 @@ +From 60b7e0adb197fe47de884b14095203c759e5fbb2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 28 Apr 2024 12:25:40 +0300 +Subject: nvmet: fix nvme status code when namespace is disabled + +From: Sagi Grimberg + +[ Upstream commit 505363957fad35f7aed9a2b0d8dad73451a80fb5 ] + +If the user disabled a nvmet namespace, it is removed from the subsystem +namespaces list. When nvmet processes a command directed to an nsid that +was disabled, it cannot differentiate between a nsid that is disabled +vs. a non-existent namespace, and resorts to return NVME_SC_INVALID_NS +with the dnr bit set. + +This translates to a non-retryable status for the host, which translates +to a user error. We should expect disabled namespaces to not cause an +I/O error in a multipath environment. + +Address this by searching a configfs item for the namespace nvmet failed +to find, and if we found one, conclude that the namespace is disabled +(perhaps temporarily). Return NVME_SC_INTERNAL_PATH_ERROR in this case +and keep DNR bit cleared. + +Reported-by: Jirong Feng +Tested-by: Jirong Feng +Signed-off-by: Sagi Grimberg +Reviewed-by: Christoph Hellwig +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/configfs.c | 13 +++++++++++++ + drivers/nvme/target/core.c | 5 ++++- + drivers/nvme/target/nvmet.h | 1 + + 3 files changed, 18 insertions(+), 1 deletion(-) + +diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c +index 2482a0db25043..b7bfee4b77a84 100644 +--- a/drivers/nvme/target/configfs.c ++++ b/drivers/nvme/target/configfs.c +@@ -728,6 +728,19 @@ static struct configfs_attribute *nvmet_ns_attrs[] = { + NULL, + }; + ++bool nvmet_subsys_nsid_exists(struct nvmet_subsys *subsys, u32 nsid) ++{ ++ struct config_item *ns_item; ++ char name[4] = {}; ++ ++ if (sprintf(name, "%u", nsid) <= 0) ++ return false; ++ mutex_lock(&subsys->namespaces_group.cg_subsys->su_mutex); ++ ns_item = config_group_find_item(&subsys->namespaces_group, name); ++ mutex_unlock(&subsys->namespaces_group.cg_subsys->su_mutex); ++ return ns_item != NULL; ++} ++ + static void nvmet_ns_release(struct config_item *item) + { + struct nvmet_ns *ns = to_nvmet_ns(item); +diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c +index 8658e9c08534d..7a6b3d37cca70 100644 +--- a/drivers/nvme/target/core.c ++++ b/drivers/nvme/target/core.c +@@ -425,10 +425,13 @@ void nvmet_stop_keep_alive_timer(struct nvmet_ctrl *ctrl) + u16 nvmet_req_find_ns(struct nvmet_req *req) + { + u32 nsid = le32_to_cpu(req->cmd->common.nsid); ++ struct nvmet_subsys *subsys = nvmet_req_subsys(req); + +- req->ns = xa_load(&nvmet_req_subsys(req)->namespaces, nsid); ++ req->ns = xa_load(&subsys->namespaces, nsid); + if (unlikely(!req->ns)) { + req->error_loc = offsetof(struct nvme_common_command, nsid); ++ if (nvmet_subsys_nsid_exists(subsys, nsid)) ++ return NVME_SC_INTERNAL_PATH_ERROR; + return NVME_SC_INVALID_NS | NVME_SC_DNR; + } + +diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h +index 6c8acebe1a1a6..477416abf85ab 100644 +--- a/drivers/nvme/target/nvmet.h ++++ b/drivers/nvme/target/nvmet.h +@@ -542,6 +542,7 @@ void nvmet_subsys_disc_changed(struct nvmet_subsys *subsys, + struct nvmet_host *host); + void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, + u8 event_info, u8 log_page); ++bool nvmet_subsys_nsid_exists(struct nvmet_subsys *subsys, u32 nsid); + + #define NVMET_QUEUE_SIZE 1024 + #define NVMET_NR_QUEUES 128 +-- +2.43.0 + diff --git a/queue-6.8/nvmet-prevent-sprintf-overflow-in-nvmet_subsys_nsid_.patch b/queue-6.8/nvmet-prevent-sprintf-overflow-in-nvmet_subsys_nsid_.patch new file mode 100644 index 00000000000..44691dbfb73 --- /dev/null +++ b/queue-6.8/nvmet-prevent-sprintf-overflow-in-nvmet_subsys_nsid_.patch @@ -0,0 +1,49 @@ +From dcd8ac068a3b16afc44c4793b06083ce4b0efd98 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 10:43:04 +0300 +Subject: nvmet: prevent sprintf() overflow in nvmet_subsys_nsid_exists() + +From: Dan Carpenter + +[ Upstream commit d15dcd0f1a4753b57e66c64c8dc2a9779ff96aab ] + +The nsid value is a u32 that comes from nvmet_req_find_ns(). It's +endian data and we're on an error path and both of those raise red +flags. So let's make this safer. + +1) Make the buffer large enough for any u32. +2) Remove the unnecessary initialization. +3) Use snprintf() instead of sprintf() for even more safety. +4) The sprintf() function returns the number of bytes printed, not + counting the NUL terminator. It is impossible for the return value to + be <= 0 so delete that. + +Fixes: 505363957fad ("nvmet: fix nvme status code when namespace is disabled") +Signed-off-by: Dan Carpenter +Reviewed-by: Sagi Grimberg +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/configfs.c | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c +index b7bfee4b77a84..3ef6bc655661d 100644 +--- a/drivers/nvme/target/configfs.c ++++ b/drivers/nvme/target/configfs.c +@@ -731,10 +731,9 @@ static struct configfs_attribute *nvmet_ns_attrs[] = { + bool nvmet_subsys_nsid_exists(struct nvmet_subsys *subsys, u32 nsid) + { + struct config_item *ns_item; +- char name[4] = {}; ++ char name[12]; + +- if (sprintf(name, "%u", nsid) <= 0) +- return false; ++ snprintf(name, sizeof(name), "%u", nsid); + mutex_lock(&subsys->namespaces_group.cg_subsys->su_mutex); + ns_item = config_group_find_item(&subsys->namespaces_group, name); + mutex_unlock(&subsys->namespaces_group.cg_subsys->su_mutex); +-- +2.43.0 + diff --git a/queue-6.8/nvmet-tcp-fix-possible-memory-leak-when-tearing-down.patch b/queue-6.8/nvmet-tcp-fix-possible-memory-leak-when-tearing-down.patch new file mode 100644 index 00000000000..f5904cfe51f --- /dev/null +++ b/queue-6.8/nvmet-tcp-fix-possible-memory-leak-when-tearing-down.patch @@ -0,0 +1,65 @@ +From 6e78062453eea76eeed55d82c4fdbd5030845dab Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 28 Apr 2024 11:49:49 +0300 +Subject: nvmet-tcp: fix possible memory leak when tearing down a controller + +From: Sagi Grimberg + +[ Upstream commit 6825bdde44340c5a9121f6d6fa25cc885bd9e821 ] + +When we teardown the controller, we wait for pending I/Os to complete +(sq->ref on all queues to drop to zero) and then we go over the commands, +and free their command buffers in case they are still fetching data from +the host (e.g. processing nvme writes) and have yet to take a reference +on the sq. + +However, we may miss the case where commands have failed before executing +and are queued for sending a response, but will never occur because the +queue socket is already down. In this case we may miss deallocating command +buffers. + +Solve this by freeing all commands buffers as nvmet_tcp_free_cmd_buffers is +idempotent anyways. + +Reported-by: Yi Zhang +Tested-by: Yi Zhang +Signed-off-by: Sagi Grimberg +Reviewed-by: Christoph Hellwig +Signed-off-by: Keith Busch +Signed-off-by: Sasha Levin +--- + drivers/nvme/target/tcp.c | 11 ++++------- + 1 file changed, 4 insertions(+), 7 deletions(-) + +diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c +index c8655fc5aa5b8..8d4531a1606d1 100644 +--- a/drivers/nvme/target/tcp.c ++++ b/drivers/nvme/target/tcp.c +@@ -348,6 +348,7 @@ static int nvmet_tcp_check_ddgst(struct nvmet_tcp_queue *queue, void *pdu) + return 0; + } + ++/* If cmd buffers are NULL, no operation is performed */ + static void nvmet_tcp_free_cmd_buffers(struct nvmet_tcp_cmd *cmd) + { + kfree(cmd->iov); +@@ -1580,13 +1581,9 @@ static void nvmet_tcp_free_cmd_data_in_buffers(struct nvmet_tcp_queue *queue) + struct nvmet_tcp_cmd *cmd = queue->cmds; + int i; + +- for (i = 0; i < queue->nr_cmds; i++, cmd++) { +- if (nvmet_tcp_need_data_in(cmd)) +- nvmet_tcp_free_cmd_buffers(cmd); +- } +- +- if (!queue->nr_cmds && nvmet_tcp_need_data_in(&queue->connect)) +- nvmet_tcp_free_cmd_buffers(&queue->connect); ++ for (i = 0; i < queue->nr_cmds; i++, cmd++) ++ nvmet_tcp_free_cmd_buffers(cmd); ++ nvmet_tcp_free_cmd_buffers(&queue->connect); + } + + static void nvmet_tcp_release_queue_work(struct work_struct *w) +-- +2.43.0 + diff --git a/queue-6.8/of-module-add-buffer-overflow-check-in-of_modalias.patch b/queue-6.8/of-module-add-buffer-overflow-check-in-of_modalias.patch new file mode 100644 index 00000000000..458b0ed13d9 --- /dev/null +++ b/queue-6.8/of-module-add-buffer-overflow-check-in-of_modalias.patch @@ -0,0 +1,50 @@ +From 139ddf0215b34468771bb550dfe96ef8cddaae05 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 14 Apr 2024 11:51:39 +0300 +Subject: of: module: add buffer overflow check in of_modalias() + +From: Sergey Shtylyov + +[ Upstream commit cf7385cb26ac4f0ee6c7385960525ad534323252 ] + +In of_modalias(), if the buffer happens to be too small even for the 1st +snprintf() call, the len parameter will become negative and str parameter +(if not NULL initially) will point beyond the buffer's end. Add the buffer +overflow check after the 1st snprintf() call and fix such check after the +strlen() call (accounting for the terminating NUL char). + +Fixes: bc575064d688 ("of/device: use of_property_for_each_string to parse compatible strings") +Signed-off-by: Sergey Shtylyov +Link: https://lore.kernel.org/r/bbfc6be0-c687-62b6-d015-5141b93f313e@omp.ru +Signed-off-by: Rob Herring +Signed-off-by: Sasha Levin +--- + drivers/of/module.c | 7 ++++--- + 1 file changed, 4 insertions(+), 3 deletions(-) + +diff --git a/drivers/of/module.c b/drivers/of/module.c +index f58e624953a20..780fd82a7ecc5 100644 +--- a/drivers/of/module.c ++++ b/drivers/of/module.c +@@ -29,14 +29,15 @@ ssize_t of_modalias(const struct device_node *np, char *str, ssize_t len) + csize = snprintf(str, len, "of:N%pOFn%c%s", np, 'T', + of_node_get_device_type(np)); + tsize = csize; ++ if (csize >= len) ++ csize = len > 0 ? len - 1 : 0; + len -= csize; +- if (str) +- str += csize; ++ str += csize; + + of_property_for_each_string(np, "compatible", p, compat) { + csize = strlen(compat) + 1; + tsize += csize; +- if (csize > len) ++ if (csize >= len) + continue; + + csize = snprintf(str, len, "C%s", compat); +-- +2.43.0 + diff --git a/queue-6.8/openpromfs-finish-conversion-to-the-new-mount-api.patch b/queue-6.8/openpromfs-finish-conversion-to-the-new-mount-api.patch new file mode 100644 index 00000000000..050c18d7684 --- /dev/null +++ b/queue-6.8/openpromfs-finish-conversion-to-the-new-mount-api.patch @@ -0,0 +1,58 @@ +From ed741c647fbdd8b08632d53d6c91ff48a571dadd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 16:33:11 -0600 +Subject: openpromfs: finish conversion to the new mount API + +From: Eric Sandeen + +[ Upstream commit 8f27829974b025d4df2e78894105d75e3bf349f0 ] + +The original mount API conversion inexplicably left out the change +from ->remount_fs to ->reconfigure; do that now. + +Fixes: 7ab2fa7693c3 ("vfs: Convert openpromfs to use the new mount API") +Signed-off-by: Eric Sandeen +Link: https://lore.kernel.org/r/90b968aa-c979-420f-ba37-5acc3391b28f@redhat.com +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/openpromfs/inode.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/fs/openpromfs/inode.c b/fs/openpromfs/inode.c +index c4b65a6d41cc3..5cf1809d47bdb 100644 +--- a/fs/openpromfs/inode.c ++++ b/fs/openpromfs/inode.c +@@ -355,10 +355,10 @@ static struct inode *openprom_iget(struct super_block *sb, ino_t ino) + return inode; + } + +-static int openprom_remount(struct super_block *sb, int *flags, char *data) ++static int openpromfs_reconfigure(struct fs_context *fc) + { +- sync_filesystem(sb); +- *flags |= SB_NOATIME; ++ sync_filesystem(fc->root->d_sb); ++ fc->sb_flags |= SB_NOATIME; + return 0; + } + +@@ -366,7 +366,6 @@ static const struct super_operations openprom_sops = { + .alloc_inode = openprom_alloc_inode, + .free_inode = openprom_free_inode, + .statfs = simple_statfs, +- .remount_fs = openprom_remount, + }; + + static int openprom_fill_super(struct super_block *s, struct fs_context *fc) +@@ -415,6 +414,7 @@ static int openpromfs_get_tree(struct fs_context *fc) + + static const struct fs_context_operations openpromfs_context_ops = { + .get_tree = openpromfs_get_tree, ++ .reconfigure = openpromfs_reconfigure, + }; + + static int openpromfs_init_fs_context(struct fs_context *fc) +-- +2.43.0 + diff --git a/queue-6.8/openrisc-traps-don-t-send-signals-to-kernel-mode-thr.patch b/queue-6.8/openrisc-traps-don-t-send-signals-to-kernel-mode-thr.patch new file mode 100644 index 00000000000..23fb8cca255 --- /dev/null +++ b/queue-6.8/openrisc-traps-don-t-send-signals-to-kernel-mode-thr.patch @@ -0,0 +1,91 @@ +From fc658e186d3a2b4a4efc2c6dad3d026df55af964 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 30 Mar 2024 14:42:49 +0000 +Subject: openrisc: traps: Don't send signals to kernel mode threads + +From: Stafford Horne + +[ Upstream commit c88cfb5cea5f8f9868ef02cc9ce9183a26dcf20f ] + +OpenRISC exception handling sends signals to user processes on floating +point exceptions and trap instructions (for debugging) among others. +There is a bug where the trap handling logic may send signals to kernel +threads, we should not send these signals to kernel threads, if that +happens we treat it as an error. + +This patch adds conditions to die if the kernel receives these +exceptions in kernel mode code. + +Fixes: 27267655c531 ("openrisc: Support floating point user api") +Signed-off-by: Stafford Horne +Signed-off-by: Sasha Levin +--- + arch/openrisc/kernel/traps.c | 48 ++++++++++++++++++++++-------------- + 1 file changed, 29 insertions(+), 19 deletions(-) + +diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c +index 9370888c9a7e3..90554a5558fbc 100644 +--- a/arch/openrisc/kernel/traps.c ++++ b/arch/openrisc/kernel/traps.c +@@ -180,29 +180,39 @@ asmlinkage void unhandled_exception(struct pt_regs *regs, int ea, int vector) + + asmlinkage void do_fpe_trap(struct pt_regs *regs, unsigned long address) + { +- int code = FPE_FLTUNK; +- unsigned long fpcsr = regs->fpcsr; +- +- if (fpcsr & SPR_FPCSR_IVF) +- code = FPE_FLTINV; +- else if (fpcsr & SPR_FPCSR_OVF) +- code = FPE_FLTOVF; +- else if (fpcsr & SPR_FPCSR_UNF) +- code = FPE_FLTUND; +- else if (fpcsr & SPR_FPCSR_DZF) +- code = FPE_FLTDIV; +- else if (fpcsr & SPR_FPCSR_IXF) +- code = FPE_FLTRES; +- +- /* Clear all flags */ +- regs->fpcsr &= ~SPR_FPCSR_ALLF; +- +- force_sig_fault(SIGFPE, code, (void __user *)regs->pc); ++ if (user_mode(regs)) { ++ int code = FPE_FLTUNK; ++ unsigned long fpcsr = regs->fpcsr; ++ ++ if (fpcsr & SPR_FPCSR_IVF) ++ code = FPE_FLTINV; ++ else if (fpcsr & SPR_FPCSR_OVF) ++ code = FPE_FLTOVF; ++ else if (fpcsr & SPR_FPCSR_UNF) ++ code = FPE_FLTUND; ++ else if (fpcsr & SPR_FPCSR_DZF) ++ code = FPE_FLTDIV; ++ else if (fpcsr & SPR_FPCSR_IXF) ++ code = FPE_FLTRES; ++ ++ /* Clear all flags */ ++ regs->fpcsr &= ~SPR_FPCSR_ALLF; ++ ++ force_sig_fault(SIGFPE, code, (void __user *)regs->pc); ++ } else { ++ pr_emerg("KERNEL: Illegal fpe exception 0x%.8lx\n", regs->pc); ++ die("Die:", regs, SIGFPE); ++ } + } + + asmlinkage void do_trap(struct pt_regs *regs, unsigned long address) + { +- force_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)regs->pc); ++ if (user_mode(regs)) { ++ force_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)regs->pc); ++ } else { ++ pr_emerg("KERNEL: Illegal trap exception 0x%.8lx\n", regs->pc); ++ die("Die:", regs, SIGILL); ++ } + } + + asmlinkage void do_unaligned_access(struct pt_regs *regs, unsigned long address) +-- +2.43.0 + diff --git a/queue-6.8/overflow-change-define_flex-to-take-__counted_by-mem.patch b/queue-6.8/overflow-change-define_flex-to-take-__counted_by-mem.patch new file mode 100644 index 00000000000..a7cf93cae96 --- /dev/null +++ b/queue-6.8/overflow-change-define_flex-to-take-__counted_by-mem.patch @@ -0,0 +1,293 @@ +From 361898361b9e04d4fe0528ecd658a180165c3b58 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 6 Mar 2024 15:51:36 -0800 +Subject: overflow: Change DEFINE_FLEX to take __counted_by member + +From: Kees Cook + +[ Upstream commit d8e45f2929b94099913eb66c3ebb18b5063e9421 ] + +The norm should be flexible array structures with __counted_by +annotations, so DEFINE_FLEX() is updated to expect that. Rename +the non-annotated version to DEFINE_RAW_FLEX(), and update the +few existing users. Additionally add selftests for the macros. + +Reviewed-by: Gustavo A. R. Silva +Link: https://lore.kernel.org/r/20240306235128.it.933-kees@kernel.org +Reviewed-by: Przemek Kitszel +Signed-off-by: Kees Cook +Stable-dep-of: e77f43d531af ("Bluetooth: hci_core: Fix not handling hdev->le_num_of_adv_sets=1") +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/intel/ice/ice_base.c | 4 ++-- + drivers/net/ethernet/intel/ice/ice_common.c | 4 ++-- + drivers/net/ethernet/intel/ice/ice_ddp.c | 8 +++---- + drivers/net/ethernet/intel/ice/ice_lag.c | 6 ++--- + drivers/net/ethernet/intel/ice/ice_sched.c | 4 ++-- + drivers/net/ethernet/intel/ice/ice_switch.c | 10 ++++----- + include/linux/overflow.h | 25 +++++++++++++++++---- + lib/overflow_kunit.c | 19 ++++++++++++++++ + 8 files changed, 58 insertions(+), 22 deletions(-) + +diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c +index d2fd315556a39..a545a7917e4fc 100644 +--- a/drivers/net/ethernet/intel/ice/ice_base.c ++++ b/drivers/net/ethernet/intel/ice/ice_base.c +@@ -956,7 +956,7 @@ ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring, + int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, + u16 q_idx) + { +- DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); + + if (q_idx >= vsi->alloc_txq || !tx_rings || !tx_rings[q_idx]) + return -EINVAL; +@@ -978,7 +978,7 @@ int ice_vsi_cfg_single_txq(struct ice_vsi *vsi, struct ice_tx_ring **tx_rings, + static int + ice_vsi_cfg_txqs(struct ice_vsi *vsi, struct ice_tx_ring **rings, u16 count) + { +- DEFINE_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_add_tx_qgrp, qg_buf, txqs, 1); + int err = 0; + u16 q_idx; + +diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c +index 10c32cd80fff6..ce50a322daa91 100644 +--- a/drivers/net/ethernet/intel/ice/ice_common.c ++++ b/drivers/net/ethernet/intel/ice/ice_common.c +@@ -4700,7 +4700,7 @@ ice_dis_vsi_txq(struct ice_port_info *pi, u16 vsi_handle, u8 tc, u8 num_queues, + enum ice_disq_rst_src rst_src, u16 vmvf_num, + struct ice_sq_cd *cd) + { +- DEFINE_FLEX(struct ice_aqc_dis_txq_item, qg_list, q_id, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_dis_txq_item, qg_list, q_id, 1); + u16 i, buf_size = __struct_size(qg_list); + struct ice_q_ctx *q_ctx; + int status = -ENOENT; +@@ -4922,7 +4922,7 @@ int + ice_dis_vsi_rdma_qset(struct ice_port_info *pi, u16 count, u32 *qset_teid, + u16 *q_id) + { +- DEFINE_FLEX(struct ice_aqc_dis_txq_item, qg_list, q_id, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_dis_txq_item, qg_list, q_id, 1); + u16 qg_size = __struct_size(qg_list); + struct ice_hw *hw; + int status = 0; +diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c b/drivers/net/ethernet/intel/ice/ice_ddp.c +index 90b9e28ddba91..1bf8ee98f06f9 100644 +--- a/drivers/net/ethernet/intel/ice/ice_ddp.c ++++ b/drivers/net/ethernet/intel/ice/ice_ddp.c +@@ -1934,8 +1934,8 @@ static enum ice_ddp_state ice_init_pkg_info(struct ice_hw *hw, + */ + static enum ice_ddp_state ice_get_pkg_info(struct ice_hw *hw) + { +- DEFINE_FLEX(struct ice_aqc_get_pkg_info_resp, pkg_info, pkg_info, +- ICE_PKG_CNT); ++ DEFINE_RAW_FLEX(struct ice_aqc_get_pkg_info_resp, pkg_info, pkg_info, ++ ICE_PKG_CNT); + u16 size = __struct_size(pkg_info); + u32 i; + +@@ -1986,8 +1986,8 @@ static enum ice_ddp_state ice_chk_pkg_compat(struct ice_hw *hw, + struct ice_pkg_hdr *ospkg, + struct ice_seg **seg) + { +- DEFINE_FLEX(struct ice_aqc_get_pkg_info_resp, pkg, pkg_info, +- ICE_PKG_CNT); ++ DEFINE_RAW_FLEX(struct ice_aqc_get_pkg_info_resp, pkg, pkg_info, ++ ICE_PKG_CNT); + u16 size = __struct_size(pkg); + enum ice_ddp_state state; + u32 i; +diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c +index a7a342809935f..f0e76f0a6d603 100644 +--- a/drivers/net/ethernet/intel/ice/ice_lag.c ++++ b/drivers/net/ethernet/intel/ice/ice_lag.c +@@ -491,7 +491,7 @@ static void + ice_lag_move_vf_node_tc(struct ice_lag *lag, u8 oldport, u8 newport, + u16 vsi_num, u8 tc) + { +- DEFINE_FLEX(struct ice_aqc_move_elem, buf, teid, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_move_elem, buf, teid, 1); + struct device *dev = ice_pf_to_dev(lag->pf); + u16 numq, valq, num_moved, qbuf_size; + u16 buf_size = __struct_size(buf); +@@ -849,7 +849,7 @@ static void + ice_lag_reclaim_vf_tc(struct ice_lag *lag, struct ice_hw *src_hw, u16 vsi_num, + u8 tc) + { +- DEFINE_FLEX(struct ice_aqc_move_elem, buf, teid, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_move_elem, buf, teid, 1); + struct device *dev = ice_pf_to_dev(lag->pf); + u16 numq, valq, num_moved, qbuf_size; + u16 buf_size = __struct_size(buf); +@@ -1873,7 +1873,7 @@ static void + ice_lag_move_vf_nodes_tc_sync(struct ice_lag *lag, struct ice_hw *dest_hw, + u16 vsi_num, u8 tc) + { +- DEFINE_FLEX(struct ice_aqc_move_elem, buf, teid, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_move_elem, buf, teid, 1); + struct device *dev = ice_pf_to_dev(lag->pf); + u16 numq, valq, num_moved, qbuf_size; + u16 buf_size = __struct_size(buf); +diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c +index d174a4eeb899c..a1525992d14bc 100644 +--- a/drivers/net/ethernet/intel/ice/ice_sched.c ++++ b/drivers/net/ethernet/intel/ice/ice_sched.c +@@ -237,7 +237,7 @@ static int + ice_sched_remove_elems(struct ice_hw *hw, struct ice_sched_node *parent, + u32 node_teid) + { +- DEFINE_FLEX(struct ice_aqc_delete_elem, buf, teid, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_delete_elem, buf, teid, 1); + u16 buf_size = __struct_size(buf); + u16 num_groups_removed = 0; + int status; +@@ -2219,7 +2219,7 @@ int + ice_sched_move_nodes(struct ice_port_info *pi, struct ice_sched_node *parent, + u16 num_items, u32 *list) + { +- DEFINE_FLEX(struct ice_aqc_move_elem, buf, teid, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_move_elem, buf, teid, 1); + u16 buf_len = __struct_size(buf); + struct ice_sched_node *node; + u16 i, grps_movd = 0; +diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c +index ba0ef91e4c19c..b4ea935e83005 100644 +--- a/drivers/net/ethernet/intel/ice/ice_switch.c ++++ b/drivers/net/ethernet/intel/ice/ice_switch.c +@@ -1812,7 +1812,7 @@ ice_aq_alloc_free_vsi_list(struct ice_hw *hw, u16 *vsi_list_id, + enum ice_sw_lkup_type lkup_type, + enum ice_adminq_opc opc) + { +- DEFINE_FLEX(struct ice_aqc_alloc_free_res_elem, sw_buf, elem, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_alloc_free_res_elem, sw_buf, elem, 1); + u16 buf_len = __struct_size(sw_buf); + struct ice_aqc_res_elem *vsi_ele; + int status; +@@ -2081,7 +2081,7 @@ ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u64 *r_assoc, + */ + int ice_alloc_recipe(struct ice_hw *hw, u16 *rid) + { +- DEFINE_FLEX(struct ice_aqc_alloc_free_res_elem, sw_buf, elem, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_alloc_free_res_elem, sw_buf, elem, 1); + u16 buf_len = __struct_size(sw_buf); + int status; + +@@ -4420,7 +4420,7 @@ int + ice_alloc_res_cntr(struct ice_hw *hw, u8 type, u8 alloc_shared, u16 num_items, + u16 *counter_id) + { +- DEFINE_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); + u16 buf_len = __struct_size(buf); + int status; + +@@ -4448,7 +4448,7 @@ int + ice_free_res_cntr(struct ice_hw *hw, u8 type, u8 alloc_shared, u16 num_items, + u16 counter_id) + { +- DEFINE_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); + u16 buf_len = __struct_size(buf); + int status; + +@@ -4478,7 +4478,7 @@ ice_free_res_cntr(struct ice_hw *hw, u8 type, u8 alloc_shared, u16 num_items, + */ + int ice_share_res(struct ice_hw *hw, u16 type, u8 shared, u16 res_id) + { +- DEFINE_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); ++ DEFINE_RAW_FLEX(struct ice_aqc_alloc_free_res_elem, buf, elem, 1); + u16 buf_len = __struct_size(buf); + u16 res_type; + int status; +diff --git a/include/linux/overflow.h b/include/linux/overflow.h +index 51af56522915e..ab4fa77516236 100644 +--- a/include/linux/overflow.h ++++ b/include/linux/overflow.h +@@ -321,7 +321,7 @@ static inline size_t __must_check size_sub(size_t minuend, size_t subtrahend) + * @count: Number of elements in the array; must be compile-time const. + * @initializer: initializer expression (could be empty for no init). + */ +-#define _DEFINE_FLEX(type, name, member, count, initializer) \ ++#define _DEFINE_FLEX(type, name, member, count, initializer...) \ + _Static_assert(__builtin_constant_p(count), \ + "onstack flex array members require compile-time const count"); \ + union { \ +@@ -331,8 +331,8 @@ static inline size_t __must_check size_sub(size_t minuend, size_t subtrahend) + type *name = (type *)&name##_u + + /** +- * DEFINE_FLEX() - Define an on-stack instance of structure with a trailing +- * flexible array member. ++ * DEFINE_RAW_FLEX() - Define an on-stack instance of structure with a trailing ++ * flexible array member, when it does not have a __counted_by annotation. + * + * @type: structure type name, including "struct" keyword. + * @name: Name for a variable to define. +@@ -343,7 +343,24 @@ static inline size_t __must_check size_sub(size_t minuend, size_t subtrahend) + * flexible array member. + * Use __struct_size(@name) to get compile-time size of it afterwards. + */ +-#define DEFINE_FLEX(type, name, member, count) \ ++#define DEFINE_RAW_FLEX(type, name, member, count) \ + _DEFINE_FLEX(type, name, member, count, = {}) + ++/** ++ * DEFINE_FLEX() - Define an on-stack instance of structure with a trailing ++ * flexible array member. ++ * ++ * @TYPE: structure type name, including "struct" keyword. ++ * @NAME: Name for a variable to define. ++ * @MEMBER: Name of the array member. ++ * @COUNTER: Name of the __counted_by member. ++ * @COUNT: Number of elements in the array; must be compile-time const. ++ * ++ * Define a zeroed, on-stack, instance of @TYPE structure with a trailing ++ * flexible array member. ++ * Use __struct_size(@NAME) to get compile-time size of it afterwards. ++ */ ++#define DEFINE_FLEX(TYPE, NAME, MEMBER, COUNTER, COUNT) \ ++ _DEFINE_FLEX(TYPE, NAME, MEMBER, COUNT, = { .obj.COUNTER = COUNT, }) ++ + #endif /* __LINUX_OVERFLOW_H */ +diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c +index c527f6b757894..c85c8b121d350 100644 +--- a/lib/overflow_kunit.c ++++ b/lib/overflow_kunit.c +@@ -1113,6 +1113,24 @@ static void castable_to_type_test(struct kunit *test) + #undef TEST_CASTABLE_TO_TYPE + } + ++struct foo { ++ int a; ++ u32 counter; ++ s16 array[] __counted_by(counter); ++}; ++ ++static void DEFINE_FLEX_test(struct kunit *test) ++{ ++ DEFINE_RAW_FLEX(struct foo, two, array, 2); ++ DEFINE_FLEX(struct foo, eight, array, counter, 8); ++ DEFINE_FLEX(struct foo, empty, array, counter, 0); ++ ++ KUNIT_EXPECT_EQ(test, __struct_size(two), ++ sizeof(struct foo) + sizeof(s16) + sizeof(s16)); ++ KUNIT_EXPECT_EQ(test, __struct_size(eight), 24); ++ KUNIT_EXPECT_EQ(test, __struct_size(empty), sizeof(struct foo)); ++} ++ + static struct kunit_case overflow_test_cases[] = { + KUNIT_CASE(u8_u8__u8_overflow_test), + KUNIT_CASE(s8_s8__s8_overflow_test), +@@ -1135,6 +1153,7 @@ static struct kunit_case overflow_test_cases[] = { + KUNIT_CASE(overflows_type_test), + KUNIT_CASE(same_type_test), + KUNIT_CASE(castable_to_type_test), ++ KUNIT_CASE(DEFINE_FLEX_test), + {} + }; + +-- +2.43.0 + diff --git a/queue-6.8/parisc-add-missing-export-of-__cmpxchg_u8.patch b/queue-6.8/parisc-add-missing-export-of-__cmpxchg_u8.patch new file mode 100644 index 00000000000..28873203cc7 --- /dev/null +++ b/queue-6.8/parisc-add-missing-export-of-__cmpxchg_u8.patch @@ -0,0 +1,36 @@ +From 9e661431c214ee68e6d257dc6a083209ca91bc03 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 1 Apr 2024 22:35:54 -0400 +Subject: parisc: add missing export of __cmpxchg_u8() + +From: Al Viro + +[ Upstream commit c57e5dccb06decf3cb6c272ab138c033727149b5 ] + +__cmpxchg_u8() had been added (initially) for the sake of +drivers/phy/ti/phy-tusb1210.c; the thing is, that drivers is +modular, so we need an export + +Fixes: b344d6a83d01 "parisc: add support for cmpxchg on u8 pointers" +Signed-off-by: Al Viro +Signed-off-by: Paul E. McKenney +Signed-off-by: Sasha Levin +--- + arch/parisc/kernel/parisc_ksyms.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/parisc/kernel/parisc_ksyms.c b/arch/parisc/kernel/parisc_ksyms.c +index 6f0c92e8149d8..dcf61cbd31470 100644 +--- a/arch/parisc/kernel/parisc_ksyms.c ++++ b/arch/parisc/kernel/parisc_ksyms.c +@@ -22,6 +22,7 @@ EXPORT_SYMBOL(memset); + #include + EXPORT_SYMBOL(__xchg8); + EXPORT_SYMBOL(__xchg32); ++EXPORT_SYMBOL(__cmpxchg_u8); + EXPORT_SYMBOL(__cmpxchg_u32); + EXPORT_SYMBOL(__cmpxchg_u64); + #ifdef CONFIG_SMP +-- +2.43.0 + diff --git a/queue-6.8/platform-x86-isst-add-grand-ridge-to-hpm-cpu-list.patch b/queue-6.8/platform-x86-isst-add-grand-ridge-to-hpm-cpu-list.patch new file mode 100644 index 00000000000..b42281cfc92 --- /dev/null +++ b/queue-6.8/platform-x86-isst-add-grand-ridge-to-hpm-cpu-list.patch @@ -0,0 +1,39 @@ +From a41f4a4723c8af90ce98594f78f28fe5e38d0aba Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 14:22:22 -0700 +Subject: platform/x86: ISST: Add Grand Ridge to HPM CPU list +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Srinivas Pandruvada + +[ Upstream commit 515a3c3a5489a890c7c3c1df3855eb4868a27598 ] + +Add Grand Ridge (ATOM_CRESTMONT) to hpm_cpu_ids, so that MSR 0x54 can be +used. + +Signed-off-by: Srinivas Pandruvada +Link: https://lore.kernel.org/r/20240422212222.3881606-1-srinivas.pandruvada@linux.intel.com +Reviewed-by: Ilpo Järvinen +Signed-off-by: Ilpo Järvinen +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c +index 30951f7131cd9..1accdaaf282c5 100644 +--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c ++++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c +@@ -721,6 +721,7 @@ static struct miscdevice isst_if_char_driver = { + static const struct x86_cpu_id hpm_cpu_ids[] = { + X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_D, NULL), + X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_X, NULL), ++ X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT, NULL), + X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT_X, NULL), + {} + }; +-- +2.43.0 + diff --git a/queue-6.8/platform-x86-xiaomi-wmi-fix-race-condition-when-repo.patch b/queue-6.8/platform-x86-xiaomi-wmi-fix-race-condition-when-repo.patch new file mode 100644 index 00000000000..8c2938c8c64 --- /dev/null +++ b/queue-6.8/platform-x86-xiaomi-wmi-fix-race-condition-when-repo.patch @@ -0,0 +1,95 @@ +From 57f56754525eabaae5411b280404fc86692c9314 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 16:30:57 +0200 +Subject: platform/x86: xiaomi-wmi: Fix race condition when reporting key + events + +From: Armin Wolf + +[ Upstream commit 290680c2da8061e410bcaec4b21584ed951479af ] + +Multiple WMI events can be received concurrently, so multiple instances +of xiaomi_wmi_notify() can be active at the same time. Since the input +device is shared between those handlers, the key input sequence can be +disturbed. + +Fix this by protecting the key input sequence with a mutex. + +Compile-tested only. + +Fixes: edb73f4f0247 ("platform/x86: wmi: add Xiaomi WMI key driver") +Signed-off-by: Armin Wolf +Link: https://lore.kernel.org/r/20240402143059.8456-2-W_Armin@gmx.de +Reviewed-by: Kuppuswamy Sathyanarayanan +Reviewed-by: Hans de Goede +Signed-off-by: Hans de Goede +Signed-off-by: Sasha Levin +--- + drivers/platform/x86/xiaomi-wmi.c | 18 ++++++++++++++++++ + 1 file changed, 18 insertions(+) + +diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c +index 54a2546bb93bf..be80f0bda9484 100644 +--- a/drivers/platform/x86/xiaomi-wmi.c ++++ b/drivers/platform/x86/xiaomi-wmi.c +@@ -2,8 +2,10 @@ + /* WMI driver for Xiaomi Laptops */ + + #include ++#include + #include + #include ++#include + #include + + #include +@@ -20,12 +22,21 @@ + + struct xiaomi_wmi { + struct input_dev *input_dev; ++ struct mutex key_lock; /* Protects the key event sequence */ + unsigned int key_code; + }; + ++static void xiaomi_mutex_destroy(void *data) ++{ ++ struct mutex *lock = data; ++ ++ mutex_destroy(lock); ++} ++ + static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) + { + struct xiaomi_wmi *data; ++ int ret; + + if (wdev == NULL || context == NULL) + return -EINVAL; +@@ -35,6 +46,11 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) + return -ENOMEM; + dev_set_drvdata(&wdev->dev, data); + ++ mutex_init(&data->key_lock); ++ ret = devm_add_action_or_reset(&wdev->dev, xiaomi_mutex_destroy, &data->key_lock); ++ if (ret < 0) ++ return ret; ++ + data->input_dev = devm_input_allocate_device(&wdev->dev); + if (data->input_dev == NULL) + return -ENOMEM; +@@ -59,10 +75,12 @@ static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy) + if (data == NULL) + return; + ++ mutex_lock(&data->key_lock); + input_report_key(data->input_dev, data->key_code, 1); + input_sync(data->input_dev); + input_report_key(data->input_dev, data->key_code, 0); + input_sync(data->input_dev); ++ mutex_unlock(&data->key_lock); + } + + static const struct wmi_device_id xiaomi_wmi_id_table[] = { +-- +2.43.0 + diff --git a/queue-6.8/powerpc-fsl-soc-hide-unused-const-variable.patch b/queue-6.8/powerpc-fsl-soc-hide-unused-const-variable.patch new file mode 100644 index 00000000000..508c4e0f302 --- /dev/null +++ b/queue-6.8/powerpc-fsl-soc-hide-unused-const-variable.patch @@ -0,0 +1,48 @@ +From e0cb3d31a8a6223d6e04fc2845ba142eac4b8500 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 10:06:19 +0200 +Subject: powerpc/fsl-soc: hide unused const variable + +From: Arnd Bergmann + +[ Upstream commit 01acaf3aa75e1641442cc23d8fe0a7bb4226efb1 ] + +vmpic_msi_feature is only used conditionally, which triggers a rare +-Werror=unused-const-variable= warning with gcc: + +arch/powerpc/sysdev/fsl_msi.c:567:37: error: 'vmpic_msi_feature' defined but not used [-Werror=unused-const-variable=] + 567 | static const struct fsl_msi_feature vmpic_msi_feature = + +Hide this one in the same #ifdef as the reference so we can turn on +the warning by default. + +Fixes: 305bcf26128e ("powerpc/fsl-soc: use CONFIG_EPAPR_PARAVIRT for hcalls") +Signed-off-by: Arnd Bergmann +Reviewed-by: Christophe Leroy +Signed-off-by: Michael Ellerman +Link: https://msgid.link/20240403080702.3509288-2-arnd@kernel.org +Signed-off-by: Sasha Levin +--- + arch/powerpc/sysdev/fsl_msi.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c +index 558ec68d768e6..60a2c5925161a 100644 +--- a/arch/powerpc/sysdev/fsl_msi.c ++++ b/arch/powerpc/sysdev/fsl_msi.c +@@ -566,10 +566,12 @@ static const struct fsl_msi_feature ipic_msi_feature = { + .msiir_offset = 0x38, + }; + ++#ifdef CONFIG_EPAPR_PARAVIRT + static const struct fsl_msi_feature vmpic_msi_feature = { + .fsl_pic_ip = FSL_PIC_IP_VMPIC, + .msiir_offset = 0, + }; ++#endif + + static const struct of_device_id fsl_of_msi_ids[] = { + { +-- +2.43.0 + diff --git a/queue-6.8/printk-let-no_printk-use-_printk.patch b/queue-6.8/printk-let-no_printk-use-_printk.patch new file mode 100644 index 00000000000..3ad3fa086ce --- /dev/null +++ b/queue-6.8/printk-let-no_printk-use-_printk.patch @@ -0,0 +1,55 @@ +From fb128a2c514cedca4700c5fcac2dee5d97adaaa8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Feb 2024 15:00:02 +0100 +Subject: printk: Let no_printk() use _printk() + +From: Geert Uytterhoeven + +[ Upstream commit 8522f6b760ca588928eede740d5d69dd1e936b49 ] + +When printk-indexing is enabled, each printk() invocation emits a +pi_entry structure, containing the format string and other information +related to its location in the kernel sources. This is even true for +no_printk(): while the actual code to print the message is optimized out +by the compiler due to the always-false check, the pi_entry structure is +still emitted. + +As the main purpose of no_printk() is to provide a helper to maintain +printf()-style format checking when debugging is disabled, this leads to +the inclusion in the index of lots of printk formats that cannot be +emitted by the current kernel. + +Fix this by switching no_printk() from printk() to _printk(). + +This reduces the size of an arm64 defconfig kernel with +CONFIG_PRINTK_INDEX=y by 576 KiB. + +Fixes: 337015573718b161 ("printk: Userspace format indexing support") +Signed-off-by: Geert Uytterhoeven +Reviewed-by: Andy Shevchenko +Reviewed-by: Xiubo Li +Reviewed-by: Chris Down +Reviewed-by: Petr Mladek +Link: https://lore.kernel.org/r/56cf92edccffea970e1f40a075334dd6cf5bb2a4.1709127473.git.geert+renesas@glider.be +Signed-off-by: Petr Mladek +Signed-off-by: Sasha Levin +--- + include/linux/printk.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/printk.h b/include/linux/printk.h +index 955e31860095e..2fde40cc96778 100644 +--- a/include/linux/printk.h ++++ b/include/linux/printk.h +@@ -126,7 +126,7 @@ struct va_format { + #define no_printk(fmt, ...) \ + ({ \ + if (0) \ +- printk(fmt, ##__VA_ARGS__); \ ++ _printk(fmt, ##__VA_ARGS__); \ + 0; \ + }) + +-- +2.43.0 + diff --git a/queue-6.8/ptp-ocp-fix-dpll-functions.patch b/queue-6.8/ptp-ocp-fix-dpll-functions.patch new file mode 100644 index 00000000000..df5a5f38f2a --- /dev/null +++ b/queue-6.8/ptp-ocp-fix-dpll-functions.patch @@ -0,0 +1,55 @@ +From b720238de5d92c24454c6372839931faf2c80aa9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 8 May 2024 13:21:11 +0000 +Subject: ptp: ocp: fix DPLL functions + +From: Vadim Fedorenko + +[ Upstream commit a2c78977950da00aca83a3f8865d1f54e715770d ] + +In ptp_ocp driver pin actions assume sma_nr starts with 1, but for DPLL +subsystem callback 0-based index was used. Fix it providing proper index. + +Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops") +Signed-off-by: Vadim Fedorenko +Link: https://lore.kernel.org/r/20240508132111.11545-1-vadim.fedorenko@linux.dev +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/ptp/ptp_ocp.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c +index 5f858e426bbd5..05b8f325a887d 100644 +--- a/drivers/ptp/ptp_ocp.c ++++ b/drivers/ptp/ptp_ocp.c +@@ -4277,7 +4277,7 @@ static int ptp_ocp_dpll_direction_set(const struct dpll_pin *pin, + return -EOPNOTSUPP; + mode = direction == DPLL_PIN_DIRECTION_INPUT ? + SMA_MODE_IN : SMA_MODE_OUT; +- return ptp_ocp_sma_store_val(bp, 0, mode, sma_nr); ++ return ptp_ocp_sma_store_val(bp, 0, mode, sma_nr + 1); + } + + static int ptp_ocp_dpll_frequency_set(const struct dpll_pin *pin, +@@ -4298,7 +4298,7 @@ static int ptp_ocp_dpll_frequency_set(const struct dpll_pin *pin, + tbl = bp->sma_op->tbl[sma->mode]; + for (i = 0; tbl[i].name; i++) + if (tbl[i].frequency == frequency) +- return ptp_ocp_sma_store_val(bp, i, sma->mode, sma_nr); ++ return ptp_ocp_sma_store_val(bp, i, sma->mode, sma_nr + 1); + return -EINVAL; + } + +@@ -4315,7 +4315,7 @@ static int ptp_ocp_dpll_frequency_get(const struct dpll_pin *pin, + u32 val; + int i; + +- val = bp->sma_op->get(bp, sma_nr); ++ val = bp->sma_op->get(bp, sma_nr + 1); + tbl = bp->sma_op->tbl[sma->mode]; + for (i = 0; tbl[i].name; i++) + if (val == tbl[i].value) { +-- +2.43.0 + diff --git a/queue-6.8/pwm-drop-duplicate-check-against-chip-npwm-in-of_pwm.patch b/queue-6.8/pwm-drop-duplicate-check-against-chip-npwm-in-of_pwm.patch new file mode 100644 index 00000000000..ed6cbdf4087 --- /dev/null +++ b/queue-6.8/pwm-drop-duplicate-check-against-chip-npwm-in-of_pwm.patch @@ -0,0 +1,42 @@ +From 73391bd5ddba01f97b6da2bc794b0e13a846b1f9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Jan 2024 22:34:35 +0100 +Subject: pwm: Drop duplicate check against chip->npwm in + of_pwm_xlate_with_flags() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 91bb23493f8fd115e362d075ebaa3e6f12d1439d ] + +args->args[0] is passed as parameter "index" to pwm_request_from_chip(). +The latter function also checks for index >= npwm, so +of_pwm_xlate_with_flags() doesn't need to do that. + +Link: https://lore.kernel.org/r/b06e445a6ed62a339add727eccb969a33d678386.1704835845.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/core.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index 606d9ef0c7097..b025d90e201c9 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -111,9 +111,6 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg + if (args->args_count < 1) + return ERR_PTR(-EINVAL); + +- if (args->args[0] >= chip->npwm) +- return ERR_PTR(-EINVAL); +- + pwm = pwm_request_from_chip(chip, args->args[0], NULL); + if (IS_ERR(pwm)) + return pwm; +-- +2.43.0 + diff --git a/queue-6.8/pwm-drop-useless-member-.of_pwm_n_cells-of-struct-pw.patch b/queue-6.8/pwm-drop-useless-member-.of_pwm_n_cells-of-struct-pw.patch new file mode 100644 index 00000000000..7b97bbb02a8 --- /dev/null +++ b/queue-6.8/pwm-drop-useless-member-.of_pwm_n_cells-of-struct-pw.patch @@ -0,0 +1,161 @@ +From 1bcda8bb43067813132da1677d5bf03f06d20c42 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Jan 2024 22:34:32 +0100 +Subject: pwm: Drop useless member .of_pwm_n_cells of struct pwm_chip +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 4e77431cda4973f03d063c47f6ea313dfceebf16 ] + +Apart from the two of_xlate implementations this member is write-only. +In the of_xlate functions of_pwm_xlate_with_flags() and +of_pwm_single_xlate() it's more sensible to check for args->args_count +because this is what is actually used in the device tree. + +Acked-by: Douglas Anderson +Link: https://lore.kernel.org/r/53d8c545aa8f79a920358be9e72e382b3981bdc4.1704835845.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 - + drivers/pwm/core.c | 22 +++------------------- + drivers/pwm/pwm-clps711x.c | 1 - + drivers/pwm/pwm-cros-ec.c | 1 - + drivers/pwm/pwm-pxa.c | 4 +--- + include/linux/pwm.h | 2 -- + 6 files changed, 4 insertions(+), 27 deletions(-) + +diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c +index 62cc3893dca5d..1f6e929c2f6a3 100644 +--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c ++++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c +@@ -1591,7 +1591,6 @@ static int ti_sn_pwm_probe(struct auxiliary_device *adev, + pdata->pchip.ops = &ti_sn_pwm_ops; + pdata->pchip.npwm = 1; + pdata->pchip.of_xlate = of_pwm_single_xlate; +- pdata->pchip.of_pwm_n_cells = 1; + + devm_pm_runtime_enable(&adev->dev); + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index f2728ee787d7a..31f210872a079 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -107,9 +107,6 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg + { + struct pwm_device *pwm; + +- if (chip->of_pwm_n_cells < 2) +- return ERR_PTR(-EINVAL); +- + /* flags in the third cell are optional */ + if (args->args_count < 2) + return ERR_PTR(-EINVAL); +@@ -124,10 +121,8 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg + pwm->args.period = args->args[1]; + pwm->args.polarity = PWM_POLARITY_NORMAL; + +- if (chip->of_pwm_n_cells >= 3) { +- if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) +- pwm->args.polarity = PWM_POLARITY_INVERSED; +- } ++ if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) ++ pwm->args.polarity = PWM_POLARITY_INVERSED; + + return pwm; + } +@@ -138,9 +133,6 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) + { + struct pwm_device *pwm; + +- if (chip->of_pwm_n_cells < 1) +- return ERR_PTR(-EINVAL); +- + /* validate that one cell is specified, optionally with flags */ + if (args->args_count != 1 && args->args_count != 2) + return ERR_PTR(-EINVAL); +@@ -164,16 +156,8 @@ static void of_pwmchip_add(struct pwm_chip *chip) + if (!chip->dev || !chip->dev->of_node) + return; + +- if (!chip->of_xlate) { +- u32 pwm_cells; +- +- if (of_property_read_u32(chip->dev->of_node, "#pwm-cells", +- &pwm_cells)) +- pwm_cells = 2; +- ++ if (!chip->of_xlate) + chip->of_xlate = of_pwm_xlate_with_flags; +- chip->of_pwm_n_cells = pwm_cells; +- } + + of_node_get(chip->dev->of_node); + } +diff --git a/drivers/pwm/pwm-clps711x.c b/drivers/pwm/pwm-clps711x.c +index 42179b3f7ec39..06562d4bb9633 100644 +--- a/drivers/pwm/pwm-clps711x.c ++++ b/drivers/pwm/pwm-clps711x.c +@@ -103,7 +103,6 @@ static int clps711x_pwm_probe(struct platform_device *pdev) + priv->chip.dev = &pdev->dev; + priv->chip.npwm = 2; + priv->chip.of_xlate = clps711x_pwm_xlate; +- priv->chip.of_pwm_n_cells = 1; + + spin_lock_init(&priv->lock); + +diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c +index 5fe303b8656de..339cedf3a7b18 100644 +--- a/drivers/pwm/pwm-cros-ec.c ++++ b/drivers/pwm/pwm-cros-ec.c +@@ -279,7 +279,6 @@ static int cros_ec_pwm_probe(struct platform_device *pdev) + chip->dev = dev; + chip->ops = &cros_ec_pwm_ops; + chip->of_xlate = cros_ec_pwm_xlate; +- chip->of_pwm_n_cells = 1; + + if (ec_pwm->use_pwm_type) { + chip->npwm = CROS_EC_PWM_DT_COUNT; +diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c +index 76685f926c758..61b74fa1d3481 100644 +--- a/drivers/pwm/pwm-pxa.c ++++ b/drivers/pwm/pwm-pxa.c +@@ -180,10 +180,8 @@ static int pwm_probe(struct platform_device *pdev) + pc->chip.ops = &pxa_pwm_ops; + pc->chip.npwm = (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1; + +- if (IS_ENABLED(CONFIG_OF)) { ++ if (IS_ENABLED(CONFIG_OF)) + pc->chip.of_xlate = of_pwm_single_xlate; +- pc->chip.of_pwm_n_cells = 1; +- } + + pc->mmio_base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(pc->mmio_base)) +diff --git a/include/linux/pwm.h b/include/linux/pwm.h +index fcc2c4496f731..8ffe9ae7a23a9 100644 +--- a/include/linux/pwm.h ++++ b/include/linux/pwm.h +@@ -271,7 +271,6 @@ struct pwm_ops { + * @id: unique number of this PWM chip + * @npwm: number of PWMs controlled by this chip + * @of_xlate: request a PWM device given a device tree PWM specifier +- * @of_pwm_n_cells: number of cells expected in the device tree PWM specifier + * @atomic: can the driver's ->apply() be called in atomic context + * @pwms: array of PWM devices allocated by the framework + */ +@@ -284,7 +283,6 @@ struct pwm_chip { + + struct pwm_device * (*of_xlate)(struct pwm_chip *chip, + const struct of_phandle_args *args); +- unsigned int of_pwm_n_cells; + bool atomic; + + /* only used internally by the PWM framework */ +-- +2.43.0 + diff --git a/queue-6.8/pwm-fix-setting-period-with-pwm-cells-1-and-of_pwm_s.patch b/queue-6.8/pwm-fix-setting-period-with-pwm-cells-1-and-of_pwm_s.patch new file mode 100644 index 00000000000..f9740c98035 --- /dev/null +++ b/queue-6.8/pwm-fix-setting-period-with-pwm-cells-1-and-of_pwm_s.patch @@ -0,0 +1,44 @@ +From 19f8db5c9d2cd4ee3bb40dcefa1b19134c5fba82 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 11:35:40 +0100 +Subject: pwm: Fix setting period with #pwm-cells = <1> and + of_pwm_single_xlate() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 73dfe970c038d0548beccc5bfb2707e1d543b01f ] + +For drivers making use of of_pwm_single_xlate() (i.e. those that don't +pass a hwpwm index) and also don't pass flags, setting period was +wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers. + +Reported-by: Karel Balej +Link: https://lore.kernel.org/r/D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz +Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references without period") +Tested-by: Karel Balej +Link: https://lore.kernel.org/r/20240329103544.545290-2-u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Signed-off-by: Sasha Levin +--- + drivers/pwm/core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index 830a697826af5..9d2dc5e1c8aac 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -443,7 +443,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) + if (IS_ERR(pwm)) + return pwm; + +- if (args->args_count > 1) ++ if (args->args_count > 0) + pwm->args.period = args->args[0]; + + pwm->args.polarity = PWM_POLARITY_NORMAL; +-- +2.43.0 + diff --git a/queue-6.8/pwm-let-the-of_xlate-callbacks-accept-references-wit.patch b/queue-6.8/pwm-let-the-of_xlate-callbacks-accept-references-wit.patch new file mode 100644 index 00000000000..9694fd53319 --- /dev/null +++ b/queue-6.8/pwm-let-the-of_xlate-callbacks-accept-references-wit.patch @@ -0,0 +1,79 @@ +From 82fe02654b49366cd5714e8badfa381e0452ebcc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Jan 2024 22:34:33 +0100 +Subject: pwm: Let the of_xlate callbacks accept references without period +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 40ade0c2e7940becad70a0643ba90488b905b468 ] + +With this extension of_pwm_xlate_with_flags() is suitable to replace the +custom xlate function of the pwm-clps711x driver. + +While touching these very similar functions align their implementations. + +Link: https://lore.kernel.org/r/127622315d07d9d419ae8e6373c7e5be7fab7a62.1704835845.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/core.c | 20 +++++++++----------- + 1 file changed, 9 insertions(+), 11 deletions(-) + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index 31f210872a079..606d9ef0c7097 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -107,8 +107,8 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg + { + struct pwm_device *pwm; + +- /* flags in the third cell are optional */ +- if (args->args_count < 2) ++ /* period in the second cell and flags in the third cell are optional */ ++ if (args->args_count < 1) + return ERR_PTR(-EINVAL); + + if (args->args[0] >= chip->npwm) +@@ -118,9 +118,10 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg + if (IS_ERR(pwm)) + return pwm; + +- pwm->args.period = args->args[1]; +- pwm->args.polarity = PWM_POLARITY_NORMAL; ++ if (args->args_count > 1) ++ pwm->args.period = args->args[1]; + ++ pwm->args.polarity = PWM_POLARITY_NORMAL; + if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) + pwm->args.polarity = PWM_POLARITY_INVERSED; + +@@ -133,18 +134,15 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) + { + struct pwm_device *pwm; + +- /* validate that one cell is specified, optionally with flags */ +- if (args->args_count != 1 && args->args_count != 2) +- return ERR_PTR(-EINVAL); +- + pwm = pwm_request_from_chip(chip, 0, NULL); + if (IS_ERR(pwm)) + return pwm; + +- pwm->args.period = args->args[0]; +- pwm->args.polarity = PWM_POLARITY_NORMAL; ++ if (args->args_count > 1) ++ pwm->args.period = args->args[0]; + +- if (args->args_count == 2 && args->args[1] & PWM_POLARITY_INVERTED) ++ pwm->args.polarity = PWM_POLARITY_NORMAL; ++ if (args->args_count > 1 && args->args[1] & PWM_POLARITY_INVERTED) + pwm->args.polarity = PWM_POLARITY_INVERSED; + + return pwm; +-- +2.43.0 + diff --git a/queue-6.8/pwm-meson-add-check-for-error-from-clk_round_rate.patch b/queue-6.8/pwm-meson-add-check-for-error-from-clk_round_rate.patch new file mode 100644 index 00000000000..8bc18047175 --- /dev/null +++ b/queue-6.8/pwm-meson-add-check-for-error-from-clk_round_rate.patch @@ -0,0 +1,62 @@ +From 77559b64b5b1d2143e8075f648e368b7b7bb7815 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 20:12:52 +0300 +Subject: pwm: meson: Add check for error from clk_round_rate() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: George Stark + +[ Upstream commit 3e551115aee079931b82e1ec78c05f3d5033473f ] + +clk_round_rate() can return not only zero if requested frequency can not +be provided but also negative error code so add check for it too. + +Also change type of variable holding clk_round_rate() result from +unsigned long to long. It's safe due to clk_round_rate() returns long. + +Fixes: 329db102a26d ("pwm: meson: make full use of common clock framework") +Signed-off-by: Dmitry Rokosov +Signed-off-by: George Stark +Link: https://lore.kernel.org/r/20240425171253.2752877-3-gnstark@salutedevices.com +Signed-off-by: Uwe Kleine-König +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-meson.c | 11 ++++++----- + 1 file changed, 6 insertions(+), 5 deletions(-) + +diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c +index 8f67d6ba443de..6fefa80af0a4c 100644 +--- a/drivers/pwm/pwm-meson.c ++++ b/drivers/pwm/pwm-meson.c +@@ -149,7 +149,7 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + struct meson_pwm *meson = to_meson_pwm(chip); + struct meson_pwm_channel *channel = &meson->channels[pwm->hwpwm]; + unsigned int cnt, duty_cnt; +- unsigned long fin_freq; ++ long fin_freq; + u64 duty, period, freq; + + duty = state->duty_cycle; +@@ -169,12 +169,13 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + freq = ULONG_MAX; + + fin_freq = clk_round_rate(channel->clk, freq); +- if (fin_freq == 0) { +- dev_err(pwmchip_parent(chip), "invalid source clock frequency\n"); +- return -EINVAL; ++ if (fin_freq <= 0) { ++ dev_err(pwmchip_parent(chip), ++ "invalid source clock frequency %llu\n", freq); ++ return fin_freq ? fin_freq : -EINVAL; + } + +- dev_dbg(pwmchip_parent(chip), "fin_freq: %lu Hz\n", fin_freq); ++ dev_dbg(pwmchip_parent(chip), "fin_freq: %ld Hz\n", fin_freq); + + cnt = div_u64(fin_freq * period, NSEC_PER_SEC); + if (cnt > 0xffff) { +-- +2.43.0 + diff --git a/queue-6.8/pwm-meson-change-prototype-of-a-few-helpers-to-prepa.patch b/queue-6.8/pwm-meson-change-prototype-of-a-few-helpers-to-prepa.patch new file mode 100644 index 00000000000..3b95c818966 --- /dev/null +++ b/queue-6.8/pwm-meson-change-prototype-of-a-few-helpers-to-prepa.patch @@ -0,0 +1,162 @@ +From 54bbb661f204f369c266ed10014cfb5fcba07743 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 14 Feb 2024 10:31:57 +0100 +Subject: pwm: meson: Change prototype of a few helpers to prepare further + changes +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit b647dcfde1b5683abf7a939897888ca2786ac6c6 ] + +This prepares the driver for further changes that will make it harder to +determine the pwm_chip from a given meson_pwm. To just not have to do +that, rework meson_pwm_calc(), meson_pwm_enable(), meson_pwm_disable() +and meson_pwm_init_channels() to take a pwm_chip. + +Link: https://lore.kernel.org/r/157084e1dd464da0097edba880240868c1c0b27e.1707900770.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-meson.c | 38 +++++++++++++++++++++----------------- + 1 file changed, 21 insertions(+), 17 deletions(-) + +diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c +index 2971bbf3b5e7c..7ce41811537dd 100644 +--- a/drivers/pwm/pwm-meson.c ++++ b/drivers/pwm/pwm-meson.c +@@ -143,9 +143,10 @@ static void meson_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) + clk_disable_unprepare(channel->clk); + } + +-static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, ++static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) + { ++ struct meson_pwm *meson = to_meson_pwm(chip); + struct meson_pwm_channel *channel = &meson->channels[pwm->hwpwm]; + unsigned int cnt, duty_cnt; + unsigned long fin_freq; +@@ -169,19 +170,19 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, + + fin_freq = clk_round_rate(channel->clk, freq); + if (fin_freq == 0) { +- dev_err(meson->chip.dev, "invalid source clock frequency\n"); ++ dev_err(chip->dev, "invalid source clock frequency\n"); + return -EINVAL; + } + +- dev_dbg(meson->chip.dev, "fin_freq: %lu Hz\n", fin_freq); ++ dev_dbg(chip->dev, "fin_freq: %lu Hz\n", fin_freq); + + cnt = div_u64(fin_freq * period, NSEC_PER_SEC); + if (cnt > 0xffff) { +- dev_err(meson->chip.dev, "unable to get period cnt\n"); ++ dev_err(chip->dev, "unable to get period cnt\n"); + return -EINVAL; + } + +- dev_dbg(meson->chip.dev, "period=%llu cnt=%u\n", period, cnt); ++ dev_dbg(chip->dev, "period=%llu cnt=%u\n", period, cnt); + + if (duty == period) { + channel->hi = cnt; +@@ -192,7 +193,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, + } else { + duty_cnt = div_u64(fin_freq * duty, NSEC_PER_SEC); + +- dev_dbg(meson->chip.dev, "duty=%llu duty_cnt=%u\n", duty, duty_cnt); ++ dev_dbg(chip->dev, "duty=%llu duty_cnt=%u\n", duty, duty_cnt); + + channel->hi = duty_cnt; + channel->lo = cnt - duty_cnt; +@@ -203,8 +204,9 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, + return 0; + } + +-static void meson_pwm_enable(struct meson_pwm *meson, struct pwm_device *pwm) ++static void meson_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) + { ++ struct meson_pwm *meson = to_meson_pwm(chip); + struct meson_pwm_channel *channel = &meson->channels[pwm->hwpwm]; + struct meson_pwm_channel_data *channel_data; + unsigned long flags; +@@ -215,7 +217,7 @@ static void meson_pwm_enable(struct meson_pwm *meson, struct pwm_device *pwm) + + err = clk_set_rate(channel->clk, channel->rate); + if (err) +- dev_err(meson->chip.dev, "setting clock rate failed\n"); ++ dev_err(chip->dev, "setting clock rate failed\n"); + + spin_lock_irqsave(&meson->lock, flags); + +@@ -230,8 +232,9 @@ static void meson_pwm_enable(struct meson_pwm *meson, struct pwm_device *pwm) + spin_unlock_irqrestore(&meson->lock, flags); + } + +-static void meson_pwm_disable(struct meson_pwm *meson, struct pwm_device *pwm) ++static void meson_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm) + { ++ struct meson_pwm *meson = to_meson_pwm(chip); + unsigned long flags; + u32 value; + +@@ -269,16 +272,16 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, + channel->hi = ~0; + channel->lo = 0; + +- meson_pwm_enable(meson, pwm); ++ meson_pwm_enable(chip, pwm); + } else { +- meson_pwm_disable(meson, pwm); ++ meson_pwm_disable(chip, pwm); + } + } else { +- err = meson_pwm_calc(meson, pwm, state); ++ err = meson_pwm_calc(chip, pwm, state); + if (err < 0) + return err; + +- meson_pwm_enable(meson, pwm); ++ meson_pwm_enable(chip, pwm); + } + + return 0; +@@ -432,10 +435,11 @@ static const struct of_device_id meson_pwm_matches[] = { + }; + MODULE_DEVICE_TABLE(of, meson_pwm_matches); + +-static int meson_pwm_init_channels(struct meson_pwm *meson) ++static int meson_pwm_init_channels(struct pwm_chip *chip) + { ++ struct meson_pwm *meson = to_meson_pwm(chip); + struct clk_parent_data mux_parent_data[MESON_MAX_MUX_PARENTS] = {}; +- struct device *dev = meson->chip.dev; ++ struct device *dev = chip->dev; + unsigned int i; + char name[255]; + int err; +@@ -445,7 +449,7 @@ static int meson_pwm_init_channels(struct meson_pwm *meson) + mux_parent_data[i].name = meson->data->parent_names[i]; + } + +- for (i = 0; i < meson->chip.npwm; i++) { ++ for (i = 0; i < chip->npwm; i++) { + struct meson_pwm_channel *channel = &meson->channels[i]; + struct clk_parent_data div_parent = {}, gate_parent = {}; + struct clk_init_data init = {}; +@@ -543,7 +547,7 @@ static int meson_pwm_probe(struct platform_device *pdev) + + meson->data = of_device_get_match_data(&pdev->dev); + +- err = meson_pwm_init_channels(meson); ++ err = meson_pwm_init_channels(&meson->chip); + if (err < 0) + return err; + +-- +2.43.0 + diff --git a/queue-6.8/pwm-meson-make-use-of-pwmchip_parent-accessor.patch b/queue-6.8/pwm-meson-make-use-of-pwmchip_parent-accessor.patch new file mode 100644 index 00000000000..79fc533e09d --- /dev/null +++ b/queue-6.8/pwm-meson-make-use-of-pwmchip_parent-accessor.patch @@ -0,0 +1,91 @@ +From a3b5c88dda459f67816a268c149fdf889bb41b40 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 14 Feb 2024 10:31:58 +0100 +Subject: pwm: meson: Make use of pwmchip_parent() accessor +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit e369035a98894a7327e78ebd01ec859c6654fc52 ] + +struct pwm_chip::dev is about to change. To not have to touch this +driver in the same commit as struct pwm_chip::dev, use the accessor +function provided for exactly this purpose. + +Link: https://lore.kernel.org/r/02d5f32001c4d0817fa79f5831cfd16b7e345f00.1707900770.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-meson.c | 16 ++++++++-------- + 1 file changed, 8 insertions(+), 8 deletions(-) + +diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c +index 7ce41811537dd..8f67d6ba443de 100644 +--- a/drivers/pwm/pwm-meson.c ++++ b/drivers/pwm/pwm-meson.c +@@ -122,7 +122,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) + { + struct meson_pwm *meson = to_meson_pwm(chip); + struct meson_pwm_channel *channel = &meson->channels[pwm->hwpwm]; +- struct device *dev = chip->dev; ++ struct device *dev = pwmchip_parent(chip); + int err; + + err = clk_prepare_enable(channel->clk); +@@ -170,19 +170,19 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + + fin_freq = clk_round_rate(channel->clk, freq); + if (fin_freq == 0) { +- dev_err(chip->dev, "invalid source clock frequency\n"); ++ dev_err(pwmchip_parent(chip), "invalid source clock frequency\n"); + return -EINVAL; + } + +- dev_dbg(chip->dev, "fin_freq: %lu Hz\n", fin_freq); ++ dev_dbg(pwmchip_parent(chip), "fin_freq: %lu Hz\n", fin_freq); + + cnt = div_u64(fin_freq * period, NSEC_PER_SEC); + if (cnt > 0xffff) { +- dev_err(chip->dev, "unable to get period cnt\n"); ++ dev_err(pwmchip_parent(chip), "unable to get period cnt\n"); + return -EINVAL; + } + +- dev_dbg(chip->dev, "period=%llu cnt=%u\n", period, cnt); ++ dev_dbg(pwmchip_parent(chip), "period=%llu cnt=%u\n", period, cnt); + + if (duty == period) { + channel->hi = cnt; +@@ -193,7 +193,7 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + } else { + duty_cnt = div_u64(fin_freq * duty, NSEC_PER_SEC); + +- dev_dbg(chip->dev, "duty=%llu duty_cnt=%u\n", duty, duty_cnt); ++ dev_dbg(pwmchip_parent(chip), "duty=%llu duty_cnt=%u\n", duty, duty_cnt); + + channel->hi = duty_cnt; + channel->lo = cnt - duty_cnt; +@@ -217,7 +217,7 @@ static void meson_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) + + err = clk_set_rate(channel->clk, channel->rate); + if (err) +- dev_err(chip->dev, "setting clock rate failed\n"); ++ dev_err(pwmchip_parent(chip), "setting clock rate failed\n"); + + spin_lock_irqsave(&meson->lock, flags); + +@@ -439,7 +439,7 @@ static int meson_pwm_init_channels(struct pwm_chip *chip) + { + struct meson_pwm *meson = to_meson_pwm(chip); + struct clk_parent_data mux_parent_data[MESON_MAX_MUX_PARENTS] = {}; +- struct device *dev = chip->dev; ++ struct device *dev = pwmchip_parent(chip); + unsigned int i; + char name[255]; + int err; +-- +2.43.0 + diff --git a/queue-6.8/pwm-meson-use-mul_u64_u64_div_u64-for-frequency-calc.patch b/queue-6.8/pwm-meson-use-mul_u64_u64_div_u64-for-frequency-calc.patch new file mode 100644 index 00000000000..c6e892956c1 --- /dev/null +++ b/queue-6.8/pwm-meson-use-mul_u64_u64_div_u64-for-frequency-calc.patch @@ -0,0 +1,51 @@ +From f8de4b86120fe69a421c549d3c4bd53c597655c1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 20:12:53 +0300 +Subject: pwm: meson: Use mul_u64_u64_div_u64() for frequency calculating +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: George Stark + +[ Upstream commit 32c44e1fa921aebf8a5ef9f778534a30aab39313 ] + +While calculating frequency for the given period u64 numbers are +multiplied before division what can lead to overflow in theory so use +secure mul_u64_u64_div_u64() which handles overflow correctly. + +Fixes: 329db102a26d ("pwm: meson: make full use of common clock framework") +Suggested-by: Uwe Kleine-König +Signed-off-by: George Stark +Link: https://lore.kernel.org/r/20240425171253.2752877-4-gnstark@salutedevices.com +Signed-off-by: Uwe Kleine-König +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-meson.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c +index 6fefa80af0a4c..52ac3277f4204 100644 +--- a/drivers/pwm/pwm-meson.c ++++ b/drivers/pwm/pwm-meson.c +@@ -177,7 +177,7 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + + dev_dbg(pwmchip_parent(chip), "fin_freq: %ld Hz\n", fin_freq); + +- cnt = div_u64(fin_freq * period, NSEC_PER_SEC); ++ cnt = mul_u64_u64_div_u64(fin_freq, period, NSEC_PER_SEC); + if (cnt > 0xffff) { + dev_err(pwmchip_parent(chip), "unable to get period cnt\n"); + return -EINVAL; +@@ -192,7 +192,7 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, + channel->hi = 0; + channel->lo = cnt; + } else { +- duty_cnt = div_u64(fin_freq * duty, NSEC_PER_SEC); ++ duty_cnt = mul_u64_u64_div_u64(fin_freq, duty, NSEC_PER_SEC); + + dev_dbg(pwmchip_parent(chip), "duty=%llu duty_cnt=%u\n", duty, duty_cnt); + +-- +2.43.0 + diff --git a/queue-6.8/pwm-provide-an-inline-function-to-get-the-parent-dev.patch b/queue-6.8/pwm-provide-an-inline-function-to-get-the-parent-dev.patch new file mode 100644 index 00000000000..50a984610aa --- /dev/null +++ b/queue-6.8/pwm-provide-an-inline-function-to-get-the-parent-dev.patch @@ -0,0 +1,227 @@ +From ed3d3b51d1004e6c333ae295e76ea9b26d1f8257 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 14 Feb 2024 10:30:48 +0100 +Subject: pwm: Provide an inline function to get the parent device of a given + chip +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 4e59267c7a20eb1c1ad9106e682cb6a0d8eb3111 ] + +Currently a pwm_chip stores in its struct device *dev member a pointer +to the parent device. Preparing a change that embeds a full struct +device in struct pwm_chip, this accessor function should be used in all +drivers directly accessing chip->dev now. This way struct pwm_chip and +this new function can be changed without having to touch all drivers in +the same change set. + +Make use of this function in the framework's core sources. + +Reviewed-by: Greg Kroah-Hartman +Link: https://lore.kernel.org/r/cc30090d2f9762bed9854a55612144bccc910781.1707900770.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/core.c | 42 +++++++++++++++++++++--------------------- + drivers/pwm/sysfs.c | 4 ++-- + include/linux/pwm.h | 5 +++++ + 3 files changed, 28 insertions(+), 23 deletions(-) + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index 1b4c3d0caa824..830a697826af5 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -71,18 +71,18 @@ static void pwm_apply_debug(struct pwm_device *pwm, + + if (s2.polarity != state->polarity && + state->duty_cycle < state->period) +- dev_warn(chip->dev, ".apply ignored .polarity\n"); ++ dev_warn(pwmchip_parent(chip), ".apply ignored .polarity\n"); + + if (state->enabled && + last->polarity == state->polarity && + last->period > s2.period && + last->period <= state->period) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + ".apply didn't pick the best available period (requested: %llu, applied: %llu, possible: %llu)\n", + state->period, s2.period, last->period); + + if (state->enabled && state->period < s2.period) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + ".apply is supposed to round down period (requested: %llu, applied: %llu)\n", + state->period, s2.period); + +@@ -91,20 +91,20 @@ static void pwm_apply_debug(struct pwm_device *pwm, + last->period == s2.period && + last->duty_cycle > s2.duty_cycle && + last->duty_cycle <= state->duty_cycle) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + ".apply didn't pick the best available duty cycle (requested: %llu/%llu, applied: %llu/%llu, possible: %llu/%llu)\n", + state->duty_cycle, state->period, + s2.duty_cycle, s2.period, + last->duty_cycle, last->period); + + if (state->enabled && state->duty_cycle < s2.duty_cycle) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + ".apply is supposed to round down duty_cycle (requested: %llu/%llu, applied: %llu/%llu)\n", + state->duty_cycle, state->period, + s2.duty_cycle, s2.period); + + if (!state->enabled && s2.enabled && s2.duty_cycle > 0) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + "requested disabled, but yielded enabled with duty > 0\n"); + + /* reapply the state that the driver reported being configured. */ +@@ -112,7 +112,7 @@ static void pwm_apply_debug(struct pwm_device *pwm, + trace_pwm_apply(pwm, &s1, err); + if (err) { + *last = s1; +- dev_err(chip->dev, "failed to reapply current setting\n"); ++ dev_err(pwmchip_parent(chip), "failed to reapply current setting\n"); + return; + } + +@@ -127,7 +127,7 @@ static void pwm_apply_debug(struct pwm_device *pwm, + s1.polarity != last->polarity || + (s1.enabled && s1.period != last->period) || + (s1.enabled && s1.duty_cycle != last->duty_cycle)) { +- dev_err(chip->dev, ++ dev_err(pwmchip_parent(chip), + ".apply is not idempotent (ena=%d pol=%d %llu/%llu) -> (ena=%d pol=%d %llu/%llu)\n", + s1.enabled, s1.polarity, s1.duty_cycle, s1.period, + last->enabled, last->polarity, last->duty_cycle, +@@ -318,7 +318,7 @@ static struct pwm_chip *pwmchip_find_by_name(const char *name) + mutex_lock(&pwm_lock); + + idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) { +- const char *chip_name = dev_name(chip->dev); ++ const char *chip_name = dev_name(pwmchip_parent(chip)); + + if (chip_name && strcmp(chip_name, name) == 0) { + mutex_unlock(&pwm_lock); +@@ -456,19 +456,19 @@ EXPORT_SYMBOL_GPL(of_pwm_single_xlate); + + static void of_pwmchip_add(struct pwm_chip *chip) + { +- if (!chip->dev || !chip->dev->of_node) ++ if (!pwmchip_parent(chip) || !pwmchip_parent(chip)->of_node) + return; + + if (!chip->of_xlate) + chip->of_xlate = of_pwm_xlate_with_flags; + +- of_node_get(chip->dev->of_node); ++ of_node_get(pwmchip_parent(chip)->of_node); + } + + static void of_pwmchip_remove(struct pwm_chip *chip) + { +- if (chip->dev) +- of_node_put(chip->dev->of_node); ++ if (pwmchip_parent(chip)) ++ of_node_put(pwmchip_parent(chip)->of_node); + } + + static bool pwm_ops_check(const struct pwm_chip *chip) +@@ -479,7 +479,7 @@ static bool pwm_ops_check(const struct pwm_chip *chip) + return false; + + if (IS_ENABLED(CONFIG_PWM_DEBUG) && !ops->get_state) +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + "Please implement the .get_state() callback\n"); + + return true; +@@ -500,7 +500,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) + unsigned int i; + int ret; + +- if (!chip || !chip->dev || !chip->ops || !chip->npwm) ++ if (!chip || !pwmchip_parent(chip) || !chip->ops || !chip->npwm) + return -EINVAL; + + if (!pwm_ops_check(chip)) +@@ -594,15 +594,15 @@ static struct device_link *pwm_device_link_add(struct device *dev, + * impact the PM sequence ordering: the PWM supplier may get + * suspended before the consumer. + */ +- dev_warn(pwm->chip->dev, ++ dev_warn(pwmchip_parent(pwm->chip), + "No consumer device specified to create a link to\n"); + return NULL; + } + +- dl = device_link_add(dev, pwm->chip->dev, DL_FLAG_AUTOREMOVE_CONSUMER); ++ dl = device_link_add(dev, pwmchip_parent(pwm->chip), DL_FLAG_AUTOREMOVE_CONSUMER); + if (!dl) { + dev_err(dev, "failed to create device link to %s\n", +- dev_name(pwm->chip->dev)); ++ dev_name(pwmchip_parent(pwm->chip))); + return ERR_PTR(-EINVAL); + } + +@@ -617,7 +617,7 @@ static struct pwm_chip *fwnode_to_pwmchip(struct fwnode_handle *fwnode) + mutex_lock(&pwm_lock); + + idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) +- if (chip->dev && device_match_fwnode(chip->dev, fwnode)) { ++ if (pwmchip_parent(chip) && device_match_fwnode(pwmchip_parent(chip), fwnode)) { + mutex_unlock(&pwm_lock); + return chip; + } +@@ -1085,8 +1085,8 @@ static int pwm_seq_show(struct seq_file *s, void *v) + + seq_printf(s, "%s%d: %s/%s, %d PWM device%s\n", + (char *)s->private, chip->id, +- chip->dev->bus ? chip->dev->bus->name : "no-bus", +- dev_name(chip->dev), chip->npwm, ++ pwmchip_parent(chip)->bus ? pwmchip_parent(chip)->bus->name : "no-bus", ++ dev_name(pwmchip_parent(chip)), chip->npwm, + (chip->npwm != 1) ? "s" : ""); + + pwm_dbg_show(chip, s); +diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c +index 1698609d91c8a..3f434a771fb52 100644 +--- a/drivers/pwm/sysfs.c ++++ b/drivers/pwm/sysfs.c +@@ -509,10 +509,10 @@ void pwmchip_sysfs_export(struct pwm_chip *chip) + * If device_create() fails the pwm_chip is still usable by + * the kernel it's just not exported. + */ +- parent = device_create(&pwm_class, chip->dev, MKDEV(0, 0), chip, ++ parent = device_create(&pwm_class, pwmchip_parent(chip), MKDEV(0, 0), chip, + "pwmchip%d", chip->id); + if (IS_ERR(parent)) { +- dev_warn(chip->dev, ++ dev_warn(pwmchip_parent(chip), + "device_create failed for pwm_chip sysfs export\n"); + } + } +diff --git a/include/linux/pwm.h b/include/linux/pwm.h +index 8ffe9ae7a23a9..07af6910bdced 100644 +--- a/include/linux/pwm.h ++++ b/include/linux/pwm.h +@@ -289,6 +289,11 @@ struct pwm_chip { + struct pwm_device *pwms; + }; + ++static inline struct device *pwmchip_parent(const struct pwm_chip *chip) ++{ ++ return chip->dev; ++} ++ + #if IS_ENABLED(CONFIG_PWM) + /* PWM user APIs */ + int pwm_apply_might_sleep(struct pwm_device *pwm, const struct pwm_state *state); +-- +2.43.0 + diff --git a/queue-6.8/pwm-reorder-symbols-in-core.c.patch b/queue-6.8/pwm-reorder-symbols-in-core.c.patch new file mode 100644 index 00000000000..3cf1ec22c9c --- /dev/null +++ b/queue-6.8/pwm-reorder-symbols-in-core.c.patch @@ -0,0 +1,1023 @@ +From 752e9c18669a5204f6bc22b1bf9bbcabe9dae085 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Jan 2024 13:08:23 +0100 +Subject: pwm: Reorder symbols in core.c +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 62928315adfe32442b119cff42788891db89a575 ] + +This moves the functions called by pwm consumers above the functions +called by pwm providers. When character device support is added later +this is hooked into the chip registration functions. As the needed +callbacks are a kind of consumer and make use of the consumer functions, +having this order is more natural and prevents having to add +declarations for static functions. + +Also move the global variables for pwm tables to the respective +functions to have them properly grouped. + +Link: https://lore.kernel.org/r/eed83de07bdfb69b5ceba0b9aed757ee612dea8f.1706182805.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 3e551115aee0 ("pwm: meson: Add check for error from clk_round_rate()") +Signed-off-by: Sasha Levin +--- + drivers/pwm/core.c | 825 +++++++++++++++++++++++---------------------- + 1 file changed, 413 insertions(+), 412 deletions(-) + +diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c +index b025d90e201c9..1b4c3d0caa824 100644 +--- a/drivers/pwm/core.c ++++ b/drivers/pwm/core.c +@@ -24,256 +24,358 @@ + #define CREATE_TRACE_POINTS + #include + +-static DEFINE_MUTEX(pwm_lookup_lock); +-static LIST_HEAD(pwm_lookup_list); +- + /* protects access to pwm_chips */ + static DEFINE_MUTEX(pwm_lock); + + static DEFINE_IDR(pwm_chips); + +-static struct pwm_chip *pwmchip_find_by_name(const char *name) ++static void pwm_apply_debug(struct pwm_device *pwm, ++ const struct pwm_state *state) + { +- struct pwm_chip *chip; +- unsigned long id, tmp; +- +- if (!name) +- return NULL; +- +- mutex_lock(&pwm_lock); ++ struct pwm_state *last = &pwm->last; ++ struct pwm_chip *chip = pwm->chip; ++ struct pwm_state s1 = { 0 }, s2 = { 0 }; ++ int err; + +- idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) { +- const char *chip_name = dev_name(chip->dev); ++ if (!IS_ENABLED(CONFIG_PWM_DEBUG)) ++ return; + +- if (chip_name && strcmp(chip_name, name) == 0) { +- mutex_unlock(&pwm_lock); +- return chip; +- } +- } ++ /* No reasonable diagnosis possible without .get_state() */ ++ if (!chip->ops->get_state) ++ return; + +- mutex_unlock(&pwm_lock); ++ /* ++ * *state was just applied. Read out the hardware state and do some ++ * checks. ++ */ + +- return NULL; +-} ++ err = chip->ops->get_state(chip, pwm, &s1); ++ trace_pwm_get(pwm, &s1, err); ++ if (err) ++ /* If that failed there isn't much to debug */ ++ return; + +-static int pwm_device_request(struct pwm_device *pwm, const char *label) +-{ +- int err; +- struct pwm_chip *chip = pwm->chip; +- const struct pwm_ops *ops = chip->ops; ++ /* ++ * The lowlevel driver either ignored .polarity (which is a bug) or as ++ * best effort inverted .polarity and fixed .duty_cycle respectively. ++ * Undo this inversion and fixup for further tests. ++ */ ++ if (s1.enabled && s1.polarity != state->polarity) { ++ s2.polarity = state->polarity; ++ s2.duty_cycle = s1.period - s1.duty_cycle; ++ s2.period = s1.period; ++ s2.enabled = s1.enabled; ++ } else { ++ s2 = s1; ++ } + +- if (test_bit(PWMF_REQUESTED, &pwm->flags)) +- return -EBUSY; ++ if (s2.polarity != state->polarity && ++ state->duty_cycle < state->period) ++ dev_warn(chip->dev, ".apply ignored .polarity\n"); + +- if (!try_module_get(chip->owner)) +- return -ENODEV; ++ if (state->enabled && ++ last->polarity == state->polarity && ++ last->period > s2.period && ++ last->period <= state->period) ++ dev_warn(chip->dev, ++ ".apply didn't pick the best available period (requested: %llu, applied: %llu, possible: %llu)\n", ++ state->period, s2.period, last->period); + +- if (ops->request) { +- err = ops->request(chip, pwm); +- if (err) { +- module_put(chip->owner); +- return err; +- } +- } ++ if (state->enabled && state->period < s2.period) ++ dev_warn(chip->dev, ++ ".apply is supposed to round down period (requested: %llu, applied: %llu)\n", ++ state->period, s2.period); + +- if (ops->get_state) { +- /* +- * Zero-initialize state because most drivers are unaware of +- * .usage_power. The other members of state are supposed to be +- * set by lowlevel drivers. We still initialize the whole +- * structure for simplicity even though this might paper over +- * faulty implementations of .get_state(). +- */ +- struct pwm_state state = { 0, }; ++ if (state->enabled && ++ last->polarity == state->polarity && ++ last->period == s2.period && ++ last->duty_cycle > s2.duty_cycle && ++ last->duty_cycle <= state->duty_cycle) ++ dev_warn(chip->dev, ++ ".apply didn't pick the best available duty cycle (requested: %llu/%llu, applied: %llu/%llu, possible: %llu/%llu)\n", ++ state->duty_cycle, state->period, ++ s2.duty_cycle, s2.period, ++ last->duty_cycle, last->period); + +- err = ops->get_state(chip, pwm, &state); +- trace_pwm_get(pwm, &state, err); ++ if (state->enabled && state->duty_cycle < s2.duty_cycle) ++ dev_warn(chip->dev, ++ ".apply is supposed to round down duty_cycle (requested: %llu/%llu, applied: %llu/%llu)\n", ++ state->duty_cycle, state->period, ++ s2.duty_cycle, s2.period); + +- if (!err) +- pwm->state = state; ++ if (!state->enabled && s2.enabled && s2.duty_cycle > 0) ++ dev_warn(chip->dev, ++ "requested disabled, but yielded enabled with duty > 0\n"); + +- if (IS_ENABLED(CONFIG_PWM_DEBUG)) +- pwm->last = pwm->state; ++ /* reapply the state that the driver reported being configured. */ ++ err = chip->ops->apply(chip, pwm, &s1); ++ trace_pwm_apply(pwm, &s1, err); ++ if (err) { ++ *last = s1; ++ dev_err(chip->dev, "failed to reapply current setting\n"); ++ return; + } + +- set_bit(PWMF_REQUESTED, &pwm->flags); +- pwm->label = label; ++ *last = (struct pwm_state){ 0 }; ++ err = chip->ops->get_state(chip, pwm, last); ++ trace_pwm_get(pwm, last, err); ++ if (err) ++ return; + +- return 0; ++ /* reapplication of the current state should give an exact match */ ++ if (s1.enabled != last->enabled || ++ s1.polarity != last->polarity || ++ (s1.enabled && s1.period != last->period) || ++ (s1.enabled && s1.duty_cycle != last->duty_cycle)) { ++ dev_err(chip->dev, ++ ".apply is not idempotent (ena=%d pol=%d %llu/%llu) -> (ena=%d pol=%d %llu/%llu)\n", ++ s1.enabled, s1.polarity, s1.duty_cycle, s1.period, ++ last->enabled, last->polarity, last->duty_cycle, ++ last->period); ++ } + } + +-struct pwm_device * +-of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *args) ++/** ++ * __pwm_apply() - atomically apply a new state to a PWM device ++ * @pwm: PWM device ++ * @state: new state to apply ++ */ ++static int __pwm_apply(struct pwm_device *pwm, const struct pwm_state *state) + { +- struct pwm_device *pwm; ++ struct pwm_chip *chip; ++ int err; + +- /* period in the second cell and flags in the third cell are optional */ +- if (args->args_count < 1) +- return ERR_PTR(-EINVAL); ++ if (!pwm || !state || !state->period || ++ state->duty_cycle > state->period) ++ return -EINVAL; + +- pwm = pwm_request_from_chip(chip, args->args[0], NULL); +- if (IS_ERR(pwm)) +- return pwm; ++ chip = pwm->chip; + +- if (args->args_count > 1) +- pwm->args.period = args->args[1]; ++ if (state->period == pwm->state.period && ++ state->duty_cycle == pwm->state.duty_cycle && ++ state->polarity == pwm->state.polarity && ++ state->enabled == pwm->state.enabled && ++ state->usage_power == pwm->state.usage_power) ++ return 0; + +- pwm->args.polarity = PWM_POLARITY_NORMAL; +- if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) +- pwm->args.polarity = PWM_POLARITY_INVERSED; ++ err = chip->ops->apply(chip, pwm, state); ++ trace_pwm_apply(pwm, state, err); ++ if (err) ++ return err; + +- return pwm; ++ pwm->state = *state; ++ ++ /* ++ * only do this after pwm->state was applied as some ++ * implementations of .get_state depend on this ++ */ ++ pwm_apply_debug(pwm, state); ++ ++ return 0; + } +-EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags); + +-struct pwm_device * +-of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) ++/** ++ * pwm_apply_might_sleep() - atomically apply a new state to a PWM device ++ * Cannot be used in atomic context. ++ * @pwm: PWM device ++ * @state: new state to apply ++ */ ++int pwm_apply_might_sleep(struct pwm_device *pwm, const struct pwm_state *state) + { +- struct pwm_device *pwm; +- +- pwm = pwm_request_from_chip(chip, 0, NULL); +- if (IS_ERR(pwm)) +- return pwm; ++ int err; + +- if (args->args_count > 1) +- pwm->args.period = args->args[0]; ++ /* ++ * Some lowlevel driver's implementations of .apply() make use of ++ * mutexes, also with some drivers only returning when the new ++ * configuration is active calling pwm_apply_might_sleep() from atomic context ++ * is a bad idea. So make it explicit that calling this function might ++ * sleep. ++ */ ++ might_sleep(); + +- pwm->args.polarity = PWM_POLARITY_NORMAL; +- if (args->args_count > 1 && args->args[1] & PWM_POLARITY_INVERTED) +- pwm->args.polarity = PWM_POLARITY_INVERSED; ++ if (IS_ENABLED(CONFIG_PWM_DEBUG) && pwm->chip->atomic) { ++ /* ++ * Catch any drivers that have been marked as atomic but ++ * that will sleep anyway. ++ */ ++ non_block_start(); ++ err = __pwm_apply(pwm, state); ++ non_block_end(); ++ } else { ++ err = __pwm_apply(pwm, state); ++ } + +- return pwm; ++ return err; + } +-EXPORT_SYMBOL_GPL(of_pwm_single_xlate); ++EXPORT_SYMBOL_GPL(pwm_apply_might_sleep); + +-static void of_pwmchip_add(struct pwm_chip *chip) ++/** ++ * pwm_apply_atomic() - apply a new state to a PWM device from atomic context ++ * Not all PWM devices support this function, check with pwm_might_sleep(). ++ * @pwm: PWM device ++ * @state: new state to apply ++ */ ++int pwm_apply_atomic(struct pwm_device *pwm, const struct pwm_state *state) + { +- if (!chip->dev || !chip->dev->of_node) +- return; +- +- if (!chip->of_xlate) +- chip->of_xlate = of_pwm_xlate_with_flags; ++ WARN_ONCE(!pwm->chip->atomic, ++ "sleeping PWM driver used in atomic context\n"); + +- of_node_get(chip->dev->of_node); ++ return __pwm_apply(pwm, state); + } ++EXPORT_SYMBOL_GPL(pwm_apply_atomic); + +-static void of_pwmchip_remove(struct pwm_chip *chip) ++/** ++ * pwm_adjust_config() - adjust the current PWM config to the PWM arguments ++ * @pwm: PWM device ++ * ++ * This function will adjust the PWM config to the PWM arguments provided ++ * by the DT or PWM lookup table. This is particularly useful to adapt ++ * the bootloader config to the Linux one. ++ */ ++int pwm_adjust_config(struct pwm_device *pwm) + { +- if (chip->dev) +- of_node_put(chip->dev->of_node); +-} ++ struct pwm_state state; ++ struct pwm_args pargs; + +-static bool pwm_ops_check(const struct pwm_chip *chip) +-{ +- const struct pwm_ops *ops = chip->ops; ++ pwm_get_args(pwm, &pargs); ++ pwm_get_state(pwm, &state); + +- if (!ops->apply) +- return false; ++ /* ++ * If the current period is zero it means that either the PWM driver ++ * does not support initial state retrieval or the PWM has not yet ++ * been configured. ++ * ++ * In either case, we setup the new period and polarity, and assign a ++ * duty cycle of 0. ++ */ ++ if (!state.period) { ++ state.duty_cycle = 0; ++ state.period = pargs.period; ++ state.polarity = pargs.polarity; + +- if (IS_ENABLED(CONFIG_PWM_DEBUG) && !ops->get_state) +- dev_warn(chip->dev, +- "Please implement the .get_state() callback\n"); ++ return pwm_apply_might_sleep(pwm, &state); ++ } + +- return true; ++ /* ++ * Adjust the PWM duty cycle/period based on the period value provided ++ * in PWM args. ++ */ ++ if (pargs.period != state.period) { ++ u64 dutycycle = (u64)state.duty_cycle * pargs.period; ++ ++ do_div(dutycycle, state.period); ++ state.duty_cycle = dutycycle; ++ state.period = pargs.period; ++ } ++ ++ /* ++ * If the polarity changed, we should also change the duty cycle. ++ */ ++ if (pargs.polarity != state.polarity) { ++ state.polarity = pargs.polarity; ++ state.duty_cycle = state.period - state.duty_cycle; ++ } ++ ++ return pwm_apply_might_sleep(pwm, &state); + } ++EXPORT_SYMBOL_GPL(pwm_adjust_config); + + /** +- * __pwmchip_add() - register a new PWM chip +- * @chip: the PWM chip to add +- * @owner: reference to the module providing the chip. +- * +- * Register a new PWM chip. @owner is supposed to be THIS_MODULE, use the +- * pwmchip_add wrapper to do this right. ++ * pwm_capture() - capture and report a PWM signal ++ * @pwm: PWM device ++ * @result: structure to fill with capture result ++ * @timeout: time to wait, in milliseconds, before giving up on capture + * + * Returns: 0 on success or a negative error code on failure. + */ +-int __pwmchip_add(struct pwm_chip *chip, struct module *owner) ++int pwm_capture(struct pwm_device *pwm, struct pwm_capture *result, ++ unsigned long timeout) + { +- unsigned int i; +- int ret; ++ int err; + +- if (!chip || !chip->dev || !chip->ops || !chip->npwm) ++ if (!pwm || !pwm->chip->ops) + return -EINVAL; + +- if (!pwm_ops_check(chip)) +- return -EINVAL; ++ if (!pwm->chip->ops->capture) ++ return -ENOSYS; + +- chip->owner = owner; ++ mutex_lock(&pwm_lock); ++ err = pwm->chip->ops->capture(pwm->chip, pwm, result, timeout); ++ mutex_unlock(&pwm_lock); + +- chip->pwms = kcalloc(chip->npwm, sizeof(*chip->pwms), GFP_KERNEL); +- if (!chip->pwms) +- return -ENOMEM; ++ return err; ++} ++EXPORT_SYMBOL_GPL(pwm_capture); + +- mutex_lock(&pwm_lock); ++static struct pwm_chip *pwmchip_find_by_name(const char *name) ++{ ++ struct pwm_chip *chip; ++ unsigned long id, tmp; + +- ret = idr_alloc(&pwm_chips, chip, 0, 0, GFP_KERNEL); +- if (ret < 0) { +- mutex_unlock(&pwm_lock); +- kfree(chip->pwms); +- return ret; +- } ++ if (!name) ++ return NULL; + +- chip->id = ret; ++ mutex_lock(&pwm_lock); + +- for (i = 0; i < chip->npwm; i++) { +- struct pwm_device *pwm = &chip->pwms[i]; ++ idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) { ++ const char *chip_name = dev_name(chip->dev); + +- pwm->chip = chip; +- pwm->hwpwm = i; ++ if (chip_name && strcmp(chip_name, name) == 0) { ++ mutex_unlock(&pwm_lock); ++ return chip; ++ } + } + + mutex_unlock(&pwm_lock); + +- if (IS_ENABLED(CONFIG_OF)) +- of_pwmchip_add(chip); +- +- pwmchip_sysfs_export(chip); +- +- return 0; ++ return NULL; + } +-EXPORT_SYMBOL_GPL(__pwmchip_add); + +-/** +- * pwmchip_remove() - remove a PWM chip +- * @chip: the PWM chip to remove +- * +- * Removes a PWM chip. +- */ +-void pwmchip_remove(struct pwm_chip *chip) ++static int pwm_device_request(struct pwm_device *pwm, const char *label) + { +- pwmchip_sysfs_unexport(chip); +- +- if (IS_ENABLED(CONFIG_OF)) +- of_pwmchip_remove(chip); ++ int err; ++ struct pwm_chip *chip = pwm->chip; ++ const struct pwm_ops *ops = chip->ops; + +- mutex_lock(&pwm_lock); ++ if (test_bit(PWMF_REQUESTED, &pwm->flags)) ++ return -EBUSY; + +- idr_remove(&pwm_chips, chip->id); ++ if (!try_module_get(chip->owner)) ++ return -ENODEV; + +- mutex_unlock(&pwm_lock); ++ if (ops->request) { ++ err = ops->request(chip, pwm); ++ if (err) { ++ module_put(chip->owner); ++ return err; ++ } ++ } + +- kfree(chip->pwms); +-} +-EXPORT_SYMBOL_GPL(pwmchip_remove); ++ if (ops->get_state) { ++ /* ++ * Zero-initialize state because most drivers are unaware of ++ * .usage_power. The other members of state are supposed to be ++ * set by lowlevel drivers. We still initialize the whole ++ * structure for simplicity even though this might paper over ++ * faulty implementations of .get_state(). ++ */ ++ struct pwm_state state = { 0, }; + +-static void devm_pwmchip_remove(void *data) +-{ +- struct pwm_chip *chip = data; ++ err = ops->get_state(chip, pwm, &state); ++ trace_pwm_get(pwm, &state, err); + +- pwmchip_remove(chip); +-} ++ if (!err) ++ pwm->state = state; + +-int __devm_pwmchip_add(struct device *dev, struct pwm_chip *chip, struct module *owner) +-{ +- int ret; ++ if (IS_ENABLED(CONFIG_PWM_DEBUG)) ++ pwm->last = pwm->state; ++ } + +- ret = __pwmchip_add(chip, owner); +- if (ret) +- return ret; ++ set_bit(PWMF_REQUESTED, &pwm->flags); ++ pwm->label = label; + +- return devm_add_action_or_reset(dev, devm_pwmchip_remove, chip); ++ return 0; + } +-EXPORT_SYMBOL_GPL(__devm_pwmchip_add); + + /** + * pwm_request_from_chip() - request a PWM device relative to a PWM chip +@@ -307,301 +409,179 @@ struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, + } + EXPORT_SYMBOL_GPL(pwm_request_from_chip); + +-static void pwm_apply_debug(struct pwm_device *pwm, +- const struct pwm_state *state) +-{ +- struct pwm_state *last = &pwm->last; +- struct pwm_chip *chip = pwm->chip; +- struct pwm_state s1 = { 0 }, s2 = { 0 }; +- int err; +- +- if (!IS_ENABLED(CONFIG_PWM_DEBUG)) +- return; +- +- /* No reasonable diagnosis possible without .get_state() */ +- if (!chip->ops->get_state) +- return; +- +- /* +- * *state was just applied. Read out the hardware state and do some +- * checks. +- */ +- +- err = chip->ops->get_state(chip, pwm, &s1); +- trace_pwm_get(pwm, &s1, err); +- if (err) +- /* If that failed there isn't much to debug */ +- return; +- +- /* +- * The lowlevel driver either ignored .polarity (which is a bug) or as +- * best effort inverted .polarity and fixed .duty_cycle respectively. +- * Undo this inversion and fixup for further tests. +- */ +- if (s1.enabled && s1.polarity != state->polarity) { +- s2.polarity = state->polarity; +- s2.duty_cycle = s1.period - s1.duty_cycle; +- s2.period = s1.period; +- s2.enabled = s1.enabled; +- } else { +- s2 = s1; +- } +- +- if (s2.polarity != state->polarity && +- state->duty_cycle < state->period) +- dev_warn(chip->dev, ".apply ignored .polarity\n"); +- +- if (state->enabled && +- last->polarity == state->polarity && +- last->period > s2.period && +- last->period <= state->period) +- dev_warn(chip->dev, +- ".apply didn't pick the best available period (requested: %llu, applied: %llu, possible: %llu)\n", +- state->period, s2.period, last->period); +- +- if (state->enabled && state->period < s2.period) +- dev_warn(chip->dev, +- ".apply is supposed to round down period (requested: %llu, applied: %llu)\n", +- state->period, s2.period); +- +- if (state->enabled && +- last->polarity == state->polarity && +- last->period == s2.period && +- last->duty_cycle > s2.duty_cycle && +- last->duty_cycle <= state->duty_cycle) +- dev_warn(chip->dev, +- ".apply didn't pick the best available duty cycle (requested: %llu/%llu, applied: %llu/%llu, possible: %llu/%llu)\n", +- state->duty_cycle, state->period, +- s2.duty_cycle, s2.period, +- last->duty_cycle, last->period); +- +- if (state->enabled && state->duty_cycle < s2.duty_cycle) +- dev_warn(chip->dev, +- ".apply is supposed to round down duty_cycle (requested: %llu/%llu, applied: %llu/%llu)\n", +- state->duty_cycle, state->period, +- s2.duty_cycle, s2.period); +- +- if (!state->enabled && s2.enabled && s2.duty_cycle > 0) +- dev_warn(chip->dev, +- "requested disabled, but yielded enabled with duty > 0\n"); +- +- /* reapply the state that the driver reported being configured. */ +- err = chip->ops->apply(chip, pwm, &s1); +- trace_pwm_apply(pwm, &s1, err); +- if (err) { +- *last = s1; +- dev_err(chip->dev, "failed to reapply current setting\n"); +- return; +- } + +- *last = (struct pwm_state){ 0 }; +- err = chip->ops->get_state(chip, pwm, last); +- trace_pwm_get(pwm, last, err); +- if (err) +- return; ++struct pwm_device * ++of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *args) ++{ ++ struct pwm_device *pwm; + +- /* reapplication of the current state should give an exact match */ +- if (s1.enabled != last->enabled || +- s1.polarity != last->polarity || +- (s1.enabled && s1.period != last->period) || +- (s1.enabled && s1.duty_cycle != last->duty_cycle)) { +- dev_err(chip->dev, +- ".apply is not idempotent (ena=%d pol=%d %llu/%llu) -> (ena=%d pol=%d %llu/%llu)\n", +- s1.enabled, s1.polarity, s1.duty_cycle, s1.period, +- last->enabled, last->polarity, last->duty_cycle, +- last->period); +- } +-} ++ /* period in the second cell and flags in the third cell are optional */ ++ if (args->args_count < 1) ++ return ERR_PTR(-EINVAL); + +-/** +- * __pwm_apply() - atomically apply a new state to a PWM device +- * @pwm: PWM device +- * @state: new state to apply +- */ +-static int __pwm_apply(struct pwm_device *pwm, const struct pwm_state *state) +-{ +- struct pwm_chip *chip; +- int err; ++ pwm = pwm_request_from_chip(chip, args->args[0], NULL); ++ if (IS_ERR(pwm)) ++ return pwm; + +- if (!pwm || !state || !state->period || +- state->duty_cycle > state->period) +- return -EINVAL; ++ if (args->args_count > 1) ++ pwm->args.period = args->args[1]; + +- chip = pwm->chip; ++ pwm->args.polarity = PWM_POLARITY_NORMAL; ++ if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) ++ pwm->args.polarity = PWM_POLARITY_INVERSED; + +- if (state->period == pwm->state.period && +- state->duty_cycle == pwm->state.duty_cycle && +- state->polarity == pwm->state.polarity && +- state->enabled == pwm->state.enabled && +- state->usage_power == pwm->state.usage_power) +- return 0; ++ return pwm; ++} ++EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags); + +- err = chip->ops->apply(chip, pwm, state); +- trace_pwm_apply(pwm, state, err); +- if (err) +- return err; ++struct pwm_device * ++of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) ++{ ++ struct pwm_device *pwm; + +- pwm->state = *state; ++ pwm = pwm_request_from_chip(chip, 0, NULL); ++ if (IS_ERR(pwm)) ++ return pwm; + +- /* +- * only do this after pwm->state was applied as some +- * implementations of .get_state depend on this +- */ +- pwm_apply_debug(pwm, state); ++ if (args->args_count > 1) ++ pwm->args.period = args->args[0]; + +- return 0; ++ pwm->args.polarity = PWM_POLARITY_NORMAL; ++ if (args->args_count > 1 && args->args[1] & PWM_POLARITY_INVERTED) ++ pwm->args.polarity = PWM_POLARITY_INVERSED; ++ ++ return pwm; + } ++EXPORT_SYMBOL_GPL(of_pwm_single_xlate); + +-/** +- * pwm_apply_might_sleep() - atomically apply a new state to a PWM device +- * Cannot be used in atomic context. +- * @pwm: PWM device +- * @state: new state to apply +- */ +-int pwm_apply_might_sleep(struct pwm_device *pwm, const struct pwm_state *state) ++static void of_pwmchip_add(struct pwm_chip *chip) + { +- int err; ++ if (!chip->dev || !chip->dev->of_node) ++ return; + +- /* +- * Some lowlevel driver's implementations of .apply() make use of +- * mutexes, also with some drivers only returning when the new +- * configuration is active calling pwm_apply_might_sleep() from atomic context +- * is a bad idea. So make it explicit that calling this function might +- * sleep. +- */ +- might_sleep(); ++ if (!chip->of_xlate) ++ chip->of_xlate = of_pwm_xlate_with_flags; + +- if (IS_ENABLED(CONFIG_PWM_DEBUG) && pwm->chip->atomic) { +- /* +- * Catch any drivers that have been marked as atomic but +- * that will sleep anyway. +- */ +- non_block_start(); +- err = __pwm_apply(pwm, state); +- non_block_end(); +- } else { +- err = __pwm_apply(pwm, state); +- } ++ of_node_get(chip->dev->of_node); ++} + +- return err; ++static void of_pwmchip_remove(struct pwm_chip *chip) ++{ ++ if (chip->dev) ++ of_node_put(chip->dev->of_node); + } +-EXPORT_SYMBOL_GPL(pwm_apply_might_sleep); + +-/** +- * pwm_apply_atomic() - apply a new state to a PWM device from atomic context +- * Not all PWM devices support this function, check with pwm_might_sleep(). +- * @pwm: PWM device +- * @state: new state to apply +- */ +-int pwm_apply_atomic(struct pwm_device *pwm, const struct pwm_state *state) ++static bool pwm_ops_check(const struct pwm_chip *chip) + { +- WARN_ONCE(!pwm->chip->atomic, +- "sleeping PWM driver used in atomic context\n"); ++ const struct pwm_ops *ops = chip->ops; + +- return __pwm_apply(pwm, state); ++ if (!ops->apply) ++ return false; ++ ++ if (IS_ENABLED(CONFIG_PWM_DEBUG) && !ops->get_state) ++ dev_warn(chip->dev, ++ "Please implement the .get_state() callback\n"); ++ ++ return true; + } +-EXPORT_SYMBOL_GPL(pwm_apply_atomic); + + /** +- * pwm_capture() - capture and report a PWM signal +- * @pwm: PWM device +- * @result: structure to fill with capture result +- * @timeout: time to wait, in milliseconds, before giving up on capture ++ * __pwmchip_add() - register a new PWM chip ++ * @chip: the PWM chip to add ++ * @owner: reference to the module providing the chip. ++ * ++ * Register a new PWM chip. @owner is supposed to be THIS_MODULE, use the ++ * pwmchip_add wrapper to do this right. + * + * Returns: 0 on success or a negative error code on failure. + */ +-int pwm_capture(struct pwm_device *pwm, struct pwm_capture *result, +- unsigned long timeout) ++int __pwmchip_add(struct pwm_chip *chip, struct module *owner) + { +- int err; ++ unsigned int i; ++ int ret; + +- if (!pwm || !pwm->chip->ops) ++ if (!chip || !chip->dev || !chip->ops || !chip->npwm) + return -EINVAL; + +- if (!pwm->chip->ops->capture) +- return -ENOSYS; ++ if (!pwm_ops_check(chip)) ++ return -EINVAL; ++ ++ chip->owner = owner; ++ ++ chip->pwms = kcalloc(chip->npwm, sizeof(*chip->pwms), GFP_KERNEL); ++ if (!chip->pwms) ++ return -ENOMEM; + + mutex_lock(&pwm_lock); +- err = pwm->chip->ops->capture(pwm->chip, pwm, result, timeout); ++ ++ ret = idr_alloc(&pwm_chips, chip, 0, 0, GFP_KERNEL); ++ if (ret < 0) { ++ mutex_unlock(&pwm_lock); ++ kfree(chip->pwms); ++ return ret; ++ } ++ ++ chip->id = ret; ++ ++ for (i = 0; i < chip->npwm; i++) { ++ struct pwm_device *pwm = &chip->pwms[i]; ++ ++ pwm->chip = chip; ++ pwm->hwpwm = i; ++ } ++ + mutex_unlock(&pwm_lock); + +- return err; ++ if (IS_ENABLED(CONFIG_OF)) ++ of_pwmchip_add(chip); ++ ++ pwmchip_sysfs_export(chip); ++ ++ return 0; + } +-EXPORT_SYMBOL_GPL(pwm_capture); ++EXPORT_SYMBOL_GPL(__pwmchip_add); + + /** +- * pwm_adjust_config() - adjust the current PWM config to the PWM arguments +- * @pwm: PWM device ++ * pwmchip_remove() - remove a PWM chip ++ * @chip: the PWM chip to remove + * +- * This function will adjust the PWM config to the PWM arguments provided +- * by the DT or PWM lookup table. This is particularly useful to adapt +- * the bootloader config to the Linux one. ++ * Removes a PWM chip. + */ +-int pwm_adjust_config(struct pwm_device *pwm) ++void pwmchip_remove(struct pwm_chip *chip) + { +- struct pwm_state state; +- struct pwm_args pargs; +- +- pwm_get_args(pwm, &pargs); +- pwm_get_state(pwm, &state); +- +- /* +- * If the current period is zero it means that either the PWM driver +- * does not support initial state retrieval or the PWM has not yet +- * been configured. +- * +- * In either case, we setup the new period and polarity, and assign a +- * duty cycle of 0. +- */ +- if (!state.period) { +- state.duty_cycle = 0; +- state.period = pargs.period; +- state.polarity = pargs.polarity; ++ pwmchip_sysfs_unexport(chip); + +- return pwm_apply_might_sleep(pwm, &state); +- } ++ if (IS_ENABLED(CONFIG_OF)) ++ of_pwmchip_remove(chip); + +- /* +- * Adjust the PWM duty cycle/period based on the period value provided +- * in PWM args. +- */ +- if (pargs.period != state.period) { +- u64 dutycycle = (u64)state.duty_cycle * pargs.period; ++ mutex_lock(&pwm_lock); + +- do_div(dutycycle, state.period); +- state.duty_cycle = dutycycle; +- state.period = pargs.period; +- } ++ idr_remove(&pwm_chips, chip->id); + +- /* +- * If the polarity changed, we should also change the duty cycle. +- */ +- if (pargs.polarity != state.polarity) { +- state.polarity = pargs.polarity; +- state.duty_cycle = state.period - state.duty_cycle; +- } ++ mutex_unlock(&pwm_lock); + +- return pwm_apply_might_sleep(pwm, &state); ++ kfree(chip->pwms); + } +-EXPORT_SYMBOL_GPL(pwm_adjust_config); ++EXPORT_SYMBOL_GPL(pwmchip_remove); + +-static struct pwm_chip *fwnode_to_pwmchip(struct fwnode_handle *fwnode) ++static void devm_pwmchip_remove(void *data) + { +- struct pwm_chip *chip; +- unsigned long id, tmp; ++ struct pwm_chip *chip = data; + +- mutex_lock(&pwm_lock); ++ pwmchip_remove(chip); ++} + +- idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) +- if (chip->dev && device_match_fwnode(chip->dev, fwnode)) { +- mutex_unlock(&pwm_lock); +- return chip; +- } ++int __devm_pwmchip_add(struct device *dev, struct pwm_chip *chip, struct module *owner) ++{ ++ int ret; + +- mutex_unlock(&pwm_lock); ++ ret = __pwmchip_add(chip, owner); ++ if (ret) ++ return ret; + +- return ERR_PTR(-EPROBE_DEFER); ++ return devm_add_action_or_reset(dev, devm_pwmchip_remove, chip); + } ++EXPORT_SYMBOL_GPL(__devm_pwmchip_add); + + static struct device_link *pwm_device_link_add(struct device *dev, + struct pwm_device *pwm) +@@ -629,6 +609,24 @@ static struct device_link *pwm_device_link_add(struct device *dev, + return dl; + } + ++static struct pwm_chip *fwnode_to_pwmchip(struct fwnode_handle *fwnode) ++{ ++ struct pwm_chip *chip; ++ unsigned long id, tmp; ++ ++ mutex_lock(&pwm_lock); ++ ++ idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) ++ if (chip->dev && device_match_fwnode(chip->dev, fwnode)) { ++ mutex_unlock(&pwm_lock); ++ return chip; ++ } ++ ++ mutex_unlock(&pwm_lock); ++ ++ return ERR_PTR(-EPROBE_DEFER); ++} ++ + /** + * of_pwm_get() - request a PWM via the PWM framework + * @dev: device for PWM consumer +@@ -763,6 +761,9 @@ static struct pwm_device *acpi_pwm_get(const struct fwnode_handle *fwnode) + return pwm; + } + ++static DEFINE_MUTEX(pwm_lookup_lock); ++static LIST_HEAD(pwm_lookup_list); ++ + /** + * pwm_add_table() - register PWM device consumers + * @table: array of consumers to register +-- +2.43.0 + diff --git a/queue-6.8/pwm-sti-prepare-removing-pwm_chip-from-driver-data.patch b/queue-6.8/pwm-sti-prepare-removing-pwm_chip-from-driver-data.patch new file mode 100644 index 00000000000..82a78b819f4 --- /dev/null +++ b/queue-6.8/pwm-sti-prepare-removing-pwm_chip-from-driver-data.patch @@ -0,0 +1,90 @@ +From 7df1452ba60252cde7f3751423ec312e0064b72d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 14 Feb 2024 10:32:38 +0100 +Subject: pwm: sti: Prepare removing pwm_chip from driver data +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 54272761ce7c475fa30a31b59b0cb89f7652b39e ] + +This prepares the driver for further changes that will drop struct +pwm_chip chip from struct sti_pwm_chip. Use the pwm_chip as driver data +instead of the sti_pwm_chip to get access to the pwm_chip in +sti_pwm_remove() without using pc->chip. + +Link: https://lore.kernel.org/r/56d53372aacff6871df4d6c6779c9dac94592696.1707900770.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Stable-dep-of: 5bb0b194aeee ("pwm: sti: Simplify probe function using devm functions") +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-sti.c | 17 ++++++++++------- + 1 file changed, 10 insertions(+), 7 deletions(-) + +diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c +index 69b1113c6b821..826eb547cc96f 100644 +--- a/drivers/pwm/pwm-sti.c ++++ b/drivers/pwm/pwm-sti.c +@@ -570,6 +570,7 @@ static int sti_pwm_probe(struct platform_device *pdev) + { + struct device *dev = &pdev->dev; + struct sti_pwm_compat_data *cdata; ++ struct pwm_chip *chip; + struct sti_pwm_chip *pc; + unsigned int i; + int irq, ret; +@@ -577,6 +578,7 @@ static int sti_pwm_probe(struct platform_device *pdev) + pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL); + if (!pc) + return -ENOMEM; ++ chip = &pc->chip; + + cdata = devm_kzalloc(dev, sizeof(*cdata), GFP_KERNEL); + if (!cdata) +@@ -653,9 +655,9 @@ static int sti_pwm_probe(struct platform_device *pdev) + return -ENOMEM; + } + +- pc->chip.dev = dev; +- pc->chip.ops = &sti_pwm_ops; +- pc->chip.npwm = max(cdata->pwm_num_devs, cdata->cpt_num_devs); ++ chip->dev = dev; ++ chip->ops = &sti_pwm_ops; ++ chip->npwm = max(cdata->pwm_num_devs, cdata->cpt_num_devs); + + for (i = 0; i < cdata->cpt_num_devs; i++) { + struct sti_cpt_ddata *ddata = &cdata->ddata[i]; +@@ -664,23 +666,24 @@ static int sti_pwm_probe(struct platform_device *pdev) + mutex_init(&ddata->lock); + } + +- ret = pwmchip_add(&pc->chip); ++ ret = pwmchip_add(chip); + if (ret < 0) { + clk_unprepare(pc->pwm_clk); + clk_unprepare(pc->cpt_clk); + return ret; + } + +- platform_set_drvdata(pdev, pc); ++ platform_set_drvdata(pdev, chip); + + return 0; + } + + static void sti_pwm_remove(struct platform_device *pdev) + { +- struct sti_pwm_chip *pc = platform_get_drvdata(pdev); ++ struct pwm_chip *chip = platform_get_drvdata(pdev); ++ struct sti_pwm_chip *pc = to_sti_pwmchip(chip); + +- pwmchip_remove(&pc->chip); ++ pwmchip_remove(chip); + + clk_unprepare(pc->pwm_clk); + clk_unprepare(pc->cpt_clk); +-- +2.43.0 + diff --git a/queue-6.8/pwm-sti-simplify-probe-function-using-devm-functions.patch b/queue-6.8/pwm-sti-simplify-probe-function-using-devm-functions.patch new file mode 100644 index 00000000000..ac785cab984 --- /dev/null +++ b/queue-6.8/pwm-sti-simplify-probe-function-using-devm-functions.patch @@ -0,0 +1,115 @@ +From df12805da7d90965cf43ff76dc6af253df45eea4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 10 Mar 2024 12:00:54 +0100 +Subject: pwm: sti: Simplify probe function using devm functions +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Uwe Kleine-König + +[ Upstream commit 5bb0b194aeee5d5da6881232f4e9989b35957c25 ] + +Instead of of_clk_get_by_name() use devm_clk_get_prepared() which has +several advantages: + + - Combines getting the clock and a call to clk_prepare(). The latter + can be dropped from sti_pwm_probe() accordingly. + - Cares for calling clk_put() which is missing in both probe's error + path and the remove function. + - Cares for calling clk_unprepare() which can be dropped from the error + paths and the remove function. (Note that not all error path got this + right.) + +With additionally using devm_pwmchip_add() instead of pwmchip_add() the +remove callback can be dropped completely. With it the last user of +platform_get_drvdata() goes away and so platform_set_drvdata() can be +dropped from the probe function, too. + +Fixes: 378fe115d19d ("pwm: sti: Add new driver for ST's PWM IP") +Link: https://lore.kernel.org/r/81f0e1d173652f435afda6719adaed1922fe059a.1710068192.git.u.kleine-koenig@pengutronix.de +Signed-off-by: Uwe Kleine-König +Signed-off-by: Sasha Levin +--- + drivers/pwm/pwm-sti.c | 39 +++------------------------------------ + 1 file changed, 3 insertions(+), 36 deletions(-) + +diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c +index 826eb547cc96f..f3df7b1895d35 100644 +--- a/drivers/pwm/pwm-sti.c ++++ b/drivers/pwm/pwm-sti.c +@@ -624,32 +624,20 @@ static int sti_pwm_probe(struct platform_device *pdev) + return ret; + + if (cdata->pwm_num_devs) { +- pc->pwm_clk = of_clk_get_by_name(dev->of_node, "pwm"); ++ pc->pwm_clk = devm_clk_get_prepared(dev, "pwm"); + if (IS_ERR(pc->pwm_clk)) { + dev_err(dev, "failed to get PWM clock\n"); + return PTR_ERR(pc->pwm_clk); + } +- +- ret = clk_prepare(pc->pwm_clk); +- if (ret) { +- dev_err(dev, "failed to prepare clock\n"); +- return ret; +- } + } + + if (cdata->cpt_num_devs) { +- pc->cpt_clk = of_clk_get_by_name(dev->of_node, "capture"); ++ pc->cpt_clk = devm_clk_get_prepared(dev, "capture"); + if (IS_ERR(pc->cpt_clk)) { + dev_err(dev, "failed to get PWM capture clock\n"); + return PTR_ERR(pc->cpt_clk); + } + +- ret = clk_prepare(pc->cpt_clk); +- if (ret) { +- dev_err(dev, "failed to prepare clock\n"); +- return ret; +- } +- + cdata->ddata = devm_kzalloc(dev, cdata->cpt_num_devs * sizeof(*cdata->ddata), GFP_KERNEL); + if (!cdata->ddata) + return -ENOMEM; +@@ -666,27 +654,7 @@ static int sti_pwm_probe(struct platform_device *pdev) + mutex_init(&ddata->lock); + } + +- ret = pwmchip_add(chip); +- if (ret < 0) { +- clk_unprepare(pc->pwm_clk); +- clk_unprepare(pc->cpt_clk); +- return ret; +- } +- +- platform_set_drvdata(pdev, chip); +- +- return 0; +-} +- +-static void sti_pwm_remove(struct platform_device *pdev) +-{ +- struct pwm_chip *chip = platform_get_drvdata(pdev); +- struct sti_pwm_chip *pc = to_sti_pwmchip(chip); +- +- pwmchip_remove(chip); +- +- clk_unprepare(pc->pwm_clk); +- clk_unprepare(pc->cpt_clk); ++ return devm_pwmchip_add(dev, chip); + } + + static const struct of_device_id sti_pwm_of_match[] = { +@@ -701,7 +669,6 @@ static struct platform_driver sti_pwm_driver = { + .of_match_table = sti_pwm_of_match, + }, + .probe = sti_pwm_probe, +- .remove_new = sti_pwm_remove, + }; + module_platform_driver(sti_pwm_driver); + +-- +2.43.0 + diff --git a/queue-6.8/qed-avoid-truncating-work-queue-length.patch b/queue-6.8/qed-avoid-truncating-work-queue-length.patch new file mode 100644 index 00000000000..50fc7554056 --- /dev/null +++ b/queue-6.8/qed-avoid-truncating-work-queue-length.patch @@ -0,0 +1,58 @@ +From aa3e802f5d804eb24935913aff84d8a9ade3f24b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 23:38:02 +0100 +Subject: qed: avoid truncating work queue length + +From: Arnd Bergmann + +[ Upstream commit 954fd908f177604d4cce77e2a88cc50b29bad5ff ] + +clang complains that the temporary string for the name passed into +alloc_workqueue() is too short for its contents: + +drivers/net/ethernet/qlogic/qed/qed_main.c:1218:3: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 18 [-Werror,-Wformat-truncation] + +There is no need for a temporary buffer, and the actual name of a workqueue +is 32 bytes (WQ_NAME_LEN), so just use the interface as intended to avoid +the truncation. + +Fixes: 59ccf86fe69a ("qed: Add driver infrastucture for handling mfw requests.") +Signed-off-by: Arnd Bergmann +Link: https://lore.kernel.org/r/20240326223825.4084412-4-arnd@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ++++----- + 1 file changed, 4 insertions(+), 5 deletions(-) + +diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c +index c278f8893042b..8159b4c315b5d 100644 +--- a/drivers/net/ethernet/qlogic/qed/qed_main.c ++++ b/drivers/net/ethernet/qlogic/qed/qed_main.c +@@ -1206,7 +1206,6 @@ static void qed_slowpath_task(struct work_struct *work) + static int qed_slowpath_wq_start(struct qed_dev *cdev) + { + struct qed_hwfn *hwfn; +- char name[NAME_SIZE]; + int i; + + if (IS_VF(cdev)) +@@ -1215,11 +1214,11 @@ static int qed_slowpath_wq_start(struct qed_dev *cdev) + for_each_hwfn(cdev, i) { + hwfn = &cdev->hwfns[i]; + +- snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x", +- cdev->pdev->bus->number, +- PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id); ++ hwfn->slowpath_wq = alloc_workqueue("slowpath-%02x:%02x.%02x", ++ 0, 0, cdev->pdev->bus->number, ++ PCI_SLOT(cdev->pdev->devfn), ++ hwfn->abs_pf_id); + +- hwfn->slowpath_wq = alloc_workqueue(name, 0, 0); + if (!hwfn->slowpath_wq) { + DP_NOTICE(hwfn, "Cannot create slowpath workqueue\n"); + return -ENOMEM; +-- +2.43.0 + diff --git a/queue-6.8/rcu-fix-buffer-overflow-in-print_cpu_stall_info.patch b/queue-6.8/rcu-fix-buffer-overflow-in-print_cpu_stall_info.patch new file mode 100644 index 00000000000..222b5a5fc28 --- /dev/null +++ b/queue-6.8/rcu-fix-buffer-overflow-in-print_cpu_stall_info.patch @@ -0,0 +1,51 @@ +From 7757a57813326223913499929819a95aa1762619 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 1 Apr 2024 22:43:15 +0300 +Subject: rcu: Fix buffer overflow in print_cpu_stall_info() + +From: Nikita Kiryushin + +[ Upstream commit 3758f7d9917bd7ef0482c4184c0ad673b4c4e069 ] + +The rcuc-starvation output from print_cpu_stall_info() might overflow the +buffer if there is a huge difference in jiffies difference. The situation +might seem improbable, but computers sometimes get very confused about +time, which can result in full-sized integers, and, in this case, +buffer overflow. + +Also, the unsigned jiffies difference is printed using %ld, which is +normally for signed integers. This is intentional for debugging purposes, +but it is not obvious from the code. + +This commit therefore changes sprintf() to snprintf() and adds a +clarifying comment about intention of %ld format. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: 245a62982502 ("rcu: Dump rcuc kthread status for CPUs not reporting quiescent state") +Signed-off-by: Nikita Kiryushin +Reviewed-by: Steven Rostedt (Google) +Signed-off-by: Paul E. McKenney +Signed-off-by: Uladzislau Rezki (Sony) +Signed-off-by: Sasha Levin +--- + kernel/rcu/tree_stall.h | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h +index 5d666428546b0..b5ec62b2d850a 100644 +--- a/kernel/rcu/tree_stall.h ++++ b/kernel/rcu/tree_stall.h +@@ -504,7 +504,8 @@ static void print_cpu_stall_info(int cpu) + rcu_dynticks_in_eqs(rcu_dynticks_snap(cpu)); + rcuc_starved = rcu_is_rcuc_kthread_starving(rdp, &j); + if (rcuc_starved) +- sprintf(buf, " rcuc=%ld jiffies(starved)", j); ++ // Print signed value, as negative values indicate a probable bug. ++ snprintf(buf, sizeof(buf), " rcuc=%ld jiffies(starved)", j); + pr_err("\t%d-%c%c%c%c: (%lu %s) idle=%04x/%ld/%#lx softirq=%u/%u fqs=%ld%s%s\n", + cpu, + "O."[!!cpu_online(cpu)], +-- +2.43.0 + diff --git a/queue-6.8/rcu-tasks-fix-show_rcu_tasks_trace_gp_kthread-buffer.patch b/queue-6.8/rcu-tasks-fix-show_rcu_tasks_trace_gp_kthread-buffer.patch new file mode 100644 index 00000000000..1856c23ced9 --- /dev/null +++ b/queue-6.8/rcu-tasks-fix-show_rcu_tasks_trace_gp_kthread-buffer.patch @@ -0,0 +1,45 @@ +From acc017d28b4e3990e90c1b9cb9c5723a5913bb92 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 20:47:47 +0300 +Subject: rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow + +From: Nikita Kiryushin + +[ Upstream commit cc5645fddb0ce28492b15520306d092730dffa48 ] + +There is a possibility of buffer overflow in +show_rcu_tasks_trace_gp_kthread() if counters, passed +to sprintf() are huge. Counter numbers, needed for this +are unrealistically high, but buffer overflow is still +possible. + +Use snprintf() with buffer size instead of sprintf(). + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: edf3775f0ad6 ("rcu-tasks: Add count for idle tasks on offline CPUs") +Signed-off-by: Nikita Kiryushin +Reviewed-by: Steven Rostedt (Google) +Signed-off-by: Paul E. McKenney +Signed-off-by: Uladzislau Rezki (Sony) +Signed-off-by: Sasha Levin +--- + kernel/rcu/tasks.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h +index 732ad5b39946a..3f64268fe9ead 100644 +--- a/kernel/rcu/tasks.h ++++ b/kernel/rcu/tasks.h +@@ -1941,7 +1941,7 @@ void show_rcu_tasks_trace_gp_kthread(void) + { + char buf[64]; + +- sprintf(buf, "N%lu h:%lu/%lu/%lu", ++ snprintf(buf, sizeof(buf), "N%lu h:%lu/%lu/%lu", + data_race(n_trc_holdouts), + data_race(n_heavy_reader_ofl_updates), + data_race(n_heavy_reader_updates), +-- +2.43.0 + diff --git a/queue-6.8/rdma-cma-fix-kmemleak-in-rdma_core-observed-during-b.patch b/queue-6.8/rdma-cma-fix-kmemleak-in-rdma_core-observed-during-b.patch new file mode 100644 index 00000000000..3aa09684996 --- /dev/null +++ b/queue-6.8/rdma-cma-fix-kmemleak-in-rdma_core-observed-during-b.patch @@ -0,0 +1,77 @@ +From 0a13459b21e4d91eed4b8af0ce1c9de5cdbfd411 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 10 May 2024 23:12:47 +0200 +Subject: RDMA/cma: Fix kmemleak in rdma_core observed during blktests + nvme/rdma use siw + +From: Zhu Yanjun + +[ Upstream commit 9c0731832d3b7420cbadba6a7f334363bc8dfb15 ] + +When running blktests nvme/rdma, the following kmemleak issue will appear. + +kmemleak: Kernel memory leak detector initialized (mempool available:36041) +kmemleak: Automatic memory scanning thread started +kmemleak: 2 new suspected memory leaks (see /sys/kernel/debug/kmemleak) +kmemleak: 8 new suspected memory leaks (see /sys/kernel/debug/kmemleak) +kmemleak: 17 new suspected memory leaks (see /sys/kernel/debug/kmemleak) +kmemleak: 4 new suspected memory leaks (see /sys/kernel/debug/kmemleak) + +unreferenced object 0xffff88855da53400 (size 192): + comm "rdma", pid 10630, jiffies 4296575922 + hex dump (first 32 bytes): + 37 00 00 00 00 00 00 00 c0 ff ff ff 1f 00 00 00 7............... + 10 34 a5 5d 85 88 ff ff 10 34 a5 5d 85 88 ff ff .4.].....4.].... + backtrace (crc 47f66721): + [] kmalloc_trace+0x30d/0x3b0 + [] alloc_gid_entry+0x47/0x380 [ib_core] + [] add_modify_gid+0x166/0x930 [ib_core] + [] ib_cache_update.part.0+0x6d8/0x910 [ib_core] + [] ib_cache_setup_one+0x24a/0x350 [ib_core] + [] ib_register_device+0x9e/0x3a0 [ib_core] + [] 0xffffffffc2a3d389 + [] nldev_newlink+0x2b8/0x520 [ib_core] + [] rdma_nl_rcv_msg+0x2c3/0x520 [ib_core] + [] +rdma_nl_rcv_skb.constprop.0.isra.0+0x23c/0x3a0 [ib_core] + [] netlink_unicast+0x445/0x710 + [] netlink_sendmsg+0x761/0xc40 + [] __sys_sendto+0x3a9/0x420 + [] __x64_sys_sendto+0xdc/0x1b0 + [] do_syscall_64+0x93/0x180 + [] entry_SYSCALL_64_after_hwframe+0x71/0x79 + +The root cause: rdma_put_gid_attr is not called when sgid_attr is set +to ERR_PTR(-ENODEV). + +Reported-and-tested-by: Yi Zhang +Closes: https://lore.kernel.org/all/19bf5745-1b3b-4b8a-81c2-20d945943aaf@linux.dev/T/ +Fixes: f8ef1be816bf ("RDMA/cma: Avoid GID lookups on iWARP devices") +Reviewed-by: Chuck Lever +Signed-off-by: Zhu Yanjun +Link: https://lore.kernel.org/r/20240510211247.31345-1-yanjun.zhu@linux.dev +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/core/cma.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c +index 1e2cd7c8716e8..64ace0b968f07 100644 +--- a/drivers/infiniband/core/cma.c ++++ b/drivers/infiniband/core/cma.c +@@ -715,8 +715,10 @@ cma_validate_port(struct ib_device *device, u32 port, + rcu_read_lock(); + ndev = rcu_dereference(sgid_attr->ndev); + if (!net_eq(dev_net(ndev), dev_addr->net) || +- ndev->ifindex != bound_if_index) ++ ndev->ifindex != bound_if_index) { ++ rdma_put_gid_attr(sgid_attr); + sgid_attr = ERR_PTR(-ENODEV); ++ } + rcu_read_unlock(); + goto out; + } +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-fix-deadlock-on-srq-async-events.patch b/queue-6.8/rdma-hns-fix-deadlock-on-srq-async-events.patch new file mode 100644 index 00000000000..aa01a9a65cb --- /dev/null +++ b/queue-6.8/rdma-hns-fix-deadlock-on-srq-async-events.patch @@ -0,0 +1,69 @@ +From 6161b31c71db1e3c3751a359181c7680a3974129 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:16:10 +0800 +Subject: RDMA/hns: Fix deadlock on SRQ async events. + +From: Chengchang Tang + +[ Upstream commit b46494b6f9c19f141114a57729e198698f40af37 ] + +xa_lock for SRQ table may be required in AEQ. Use xa_store_irq()/ +xa_erase_irq() to avoid deadlock. + +Fixes: 81fce6291d99 ("RDMA/hns: Add SRQ asynchronous event support") +Signed-off-by: Chengchang Tang +Signed-off-by: Junxian Huang +Link: https://lore.kernel.org/r/20240412091616.370789-5-huangjunxian6@hisilicon.com +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_main.c | 1 + + drivers/infiniband/hw/hns/hns_roce_srq.c | 6 +++--- + 2 files changed, 4 insertions(+), 3 deletions(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c +index b55fe6911f9f1..a33d3cedbc944 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_main.c ++++ b/drivers/infiniband/hw/hns/hns_roce_main.c +@@ -37,6 +37,7 @@ + #include + #include + #include ++#include "hnae3.h" + #include "hns_roce_common.h" + #include "hns_roce_device.h" + #include "hns_roce_hem.h" +diff --git a/drivers/infiniband/hw/hns/hns_roce_srq.c b/drivers/infiniband/hw/hns/hns_roce_srq.c +index 4abae94778544..8f48c6723e07e 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_srq.c ++++ b/drivers/infiniband/hw/hns/hns_roce_srq.c +@@ -123,7 +123,7 @@ static int alloc_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) + return ret; + } + +- ret = xa_err(xa_store(&srq_table->xa, srq->srqn, srq, GFP_KERNEL)); ++ ret = xa_err(xa_store_irq(&srq_table->xa, srq->srqn, srq, GFP_KERNEL)); + if (ret) { + ibdev_err(ibdev, "failed to store SRQC, ret = %d.\n", ret); + goto err_put; +@@ -136,7 +136,7 @@ static int alloc_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) + return 0; + + err_xa: +- xa_erase(&srq_table->xa, srq->srqn); ++ xa_erase_irq(&srq_table->xa, srq->srqn); + err_put: + hns_roce_table_put(hr_dev, &srq_table->table, srq->srqn); + +@@ -154,7 +154,7 @@ static void free_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) + dev_err(hr_dev->dev, "DESTROY_SRQ failed (%d) for SRQN %06lx\n", + ret, srq->srqn); + +- xa_erase(&srq_table->xa, srq->srqn); ++ xa_erase_irq(&srq_table->xa, srq->srqn); + + if (refcount_dec_and_test(&srq->refcount)) + complete(&srq->free); +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-fix-gmv-table-pagesize.patch b/queue-6.8/rdma-hns-fix-gmv-table-pagesize.patch new file mode 100644 index 00000000000..30dd7766ae2 --- /dev/null +++ b/queue-6.8/rdma-hns-fix-gmv-table-pagesize.patch @@ -0,0 +1,39 @@ +From 7392459fcfa70fbe2e5f1c48be7cf3a24aad01da Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:16:13 +0800 +Subject: RDMA/hns: Fix GMV table pagesize + +From: Chengchang Tang + +[ Upstream commit ee045493283403969591087bd405fa280103282a ] + +GMV's BA table only supports 4K pages. Currently, PAGESIZE is used to +calculate gmv_bt_num, which will cause an abnormal number of gmv_bt_num +in a 64K OS. + +Fixes: d6d91e46210f ("RDMA/hns: Add support for configuring GMV table") +Signed-off-by: Chengchang Tang +Signed-off-by: Junxian Huang +Link: https://lore.kernel.org/r/20240412091616.370789-8-huangjunxian6@hisilicon.com +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +index 34e58e09b15d8..9c9a707d26d67 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c ++++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +@@ -2105,7 +2105,7 @@ static void apply_func_caps(struct hns_roce_dev *hr_dev) + caps->gmv_bt_num * + (HNS_HW_PAGE_SIZE / caps->gmv_entry_sz)); + +- caps->gmv_entry_num = caps->gmv_bt_num * (PAGE_SIZE / ++ caps->gmv_entry_num = caps->gmv_bt_num * (HNS_HW_PAGE_SIZE / + caps->gmv_entry_sz); + } else { + u32 func_num = max_t(u32, 1, hr_dev->func_num); +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-fix-return-value-in-hns_roce_map_mr_sg.patch b/queue-6.8/rdma-hns-fix-return-value-in-hns_roce_map_mr_sg.patch new file mode 100644 index 00000000000..d6b5fe5eda4 --- /dev/null +++ b/queue-6.8/rdma-hns-fix-return-value-in-hns_roce_map_mr_sg.patch @@ -0,0 +1,75 @@ +From e237e30c1df29dd926b710f5fdebbf73eb5078ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 11:38:51 +0800 +Subject: RDMA/hns: Fix return value in hns_roce_map_mr_sg + +From: Zhengchao Shao + +[ Upstream commit 203b70fda63425a4eb29f03f9074859afe821a39 ] + +As described in the ib_map_mr_sg function comment, it returns the number +of sg elements that were mapped to the memory region. However, +hns_roce_map_mr_sg returns the number of pages required for mapping the +DMA area. Fix it. + +Fixes: 9b2cf76c9f05 ("RDMA/hns: Optimize PBL buffer allocation process") +Signed-off-by: Zhengchao Shao +Link: https://lore.kernel.org/r/20240411033851.2884771-1-shaozhengchao@huawei.com +Reviewed-by: Junxian Huang +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_mr.c | 15 +++++++-------- + 1 file changed, 7 insertions(+), 8 deletions(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c +index 91cd580480fe2..0d42fd197c11e 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_mr.c ++++ b/drivers/infiniband/hw/hns/hns_roce_mr.c +@@ -433,18 +433,18 @@ int hns_roce_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg, int sg_nents, + struct ib_device *ibdev = &hr_dev->ib_dev; + struct hns_roce_mr *mr = to_hr_mr(ibmr); + struct hns_roce_mtr *mtr = &mr->pbl_mtr; +- int ret = 0; ++ int ret, sg_num = 0; + + mr->npages = 0; + mr->page_list = kvcalloc(mr->pbl_mtr.hem_cfg.buf_pg_count, + sizeof(dma_addr_t), GFP_KERNEL); + if (!mr->page_list) +- return ret; ++ return sg_num; + +- ret = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, hns_roce_set_page); +- if (ret < 1) { ++ sg_num = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, hns_roce_set_page); ++ if (sg_num < 1) { + ibdev_err(ibdev, "failed to store sg pages %u %u, cnt = %d.\n", +- mr->npages, mr->pbl_mtr.hem_cfg.buf_pg_count, ret); ++ mr->npages, mr->pbl_mtr.hem_cfg.buf_pg_count, sg_num); + goto err_page_list; + } + +@@ -455,17 +455,16 @@ int hns_roce_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg, int sg_nents, + ret = hns_roce_mtr_map(hr_dev, mtr, mr->page_list, mr->npages); + if (ret) { + ibdev_err(ibdev, "failed to map sg mtr, ret = %d.\n", ret); +- ret = 0; ++ sg_num = 0; + } else { + mr->pbl_mtr.hem_cfg.buf_pg_shift = (u32)ilog2(ibmr->page_size); +- ret = mr->npages; + } + + err_page_list: + kvfree(mr->page_list); + mr->page_list = NULL; + +- return ret; ++ return sg_num; + } + + static void hns_roce_mw_free(struct hns_roce_dev *hr_dev, +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-fix-uaf-for-cq-async-event.patch b/queue-6.8/rdma-hns-fix-uaf-for-cq-async-event.patch new file mode 100644 index 00000000000..14c40093e02 --- /dev/null +++ b/queue-6.8/rdma-hns-fix-uaf-for-cq-async-event.patch @@ -0,0 +1,91 @@ +From 4b431aad179285bd2b1467a30cf3dcf966bf38cc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:16:11 +0800 +Subject: RDMA/hns: Fix UAF for cq async event + +From: Chengchang Tang + +[ Upstream commit a942ec2745ca864cd8512142100e4027dc306a42 ] + +The refcount of CQ is not protected by locks. When CQ asynchronous +events and CQ destruction are concurrent, CQ may have been released, +which will cause UAF. + +Use the xa_lock() to protect the CQ refcount. + +Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") +Signed-off-by: Chengchang Tang +Signed-off-by: Junxian Huang +Link: https://lore.kernel.org/r/20240412091616.370789-6-huangjunxian6@hisilicon.com +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_cq.c | 24 +++++++++++++----------- + 1 file changed, 13 insertions(+), 11 deletions(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_cq.c b/drivers/infiniband/hw/hns/hns_roce_cq.c +index 1b6d16af8c12b..2517c972c651a 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_cq.c ++++ b/drivers/infiniband/hw/hns/hns_roce_cq.c +@@ -151,7 +151,7 @@ static int alloc_cqc(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq) + return ret; + } + +- ret = xa_err(xa_store(&cq_table->array, hr_cq->cqn, hr_cq, GFP_KERNEL)); ++ ret = xa_err(xa_store_irq(&cq_table->array, hr_cq->cqn, hr_cq, GFP_KERNEL)); + if (ret) { + ibdev_err(ibdev, "failed to xa_store CQ, ret = %d.\n", ret); + goto err_put; +@@ -164,7 +164,7 @@ static int alloc_cqc(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq) + return 0; + + err_xa: +- xa_erase(&cq_table->array, hr_cq->cqn); ++ xa_erase_irq(&cq_table->array, hr_cq->cqn); + err_put: + hns_roce_table_put(hr_dev, &cq_table->table, hr_cq->cqn); + +@@ -183,7 +183,7 @@ static void free_cqc(struct hns_roce_dev *hr_dev, struct hns_roce_cq *hr_cq) + dev_err(dev, "DESTROY_CQ failed (%d) for CQN %06lx\n", ret, + hr_cq->cqn); + +- xa_erase(&cq_table->array, hr_cq->cqn); ++ xa_erase_irq(&cq_table->array, hr_cq->cqn); + + /* Waiting interrupt process procedure carried out */ + synchronize_irq(hr_dev->eq_table.eq[hr_cq->vector].irq); +@@ -477,13 +477,6 @@ void hns_roce_cq_event(struct hns_roce_dev *hr_dev, u32 cqn, int event_type) + struct ib_event event; + struct ib_cq *ibcq; + +- hr_cq = xa_load(&hr_dev->cq_table.array, +- cqn & (hr_dev->caps.num_cqs - 1)); +- if (!hr_cq) { +- dev_warn(dev, "async event for bogus CQ 0x%06x\n", cqn); +- return; +- } +- + if (event_type != HNS_ROCE_EVENT_TYPE_CQ_ID_INVALID && + event_type != HNS_ROCE_EVENT_TYPE_CQ_ACCESS_ERROR && + event_type != HNS_ROCE_EVENT_TYPE_CQ_OVERFLOW) { +@@ -492,7 +485,16 @@ void hns_roce_cq_event(struct hns_roce_dev *hr_dev, u32 cqn, int event_type) + return; + } + +- refcount_inc(&hr_cq->refcount); ++ xa_lock(&hr_dev->cq_table.array); ++ hr_cq = xa_load(&hr_dev->cq_table.array, ++ cqn & (hr_dev->caps.num_cqs - 1)); ++ if (hr_cq) ++ refcount_inc(&hr_cq->refcount); ++ xa_unlock(&hr_dev->cq_table.array); ++ if (!hr_cq) { ++ dev_warn(dev, "async event for bogus CQ 0x%06x\n", cqn); ++ return; ++ } + + ibcq = &hr_cq->ib_cq; + if (ibcq->event_handler) { +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-modify-the-print-level-of-cqe-error.patch b/queue-6.8/rdma-hns-modify-the-print-level-of-cqe-error.patch new file mode 100644 index 00000000000..aca7ed1d120 --- /dev/null +++ b/queue-6.8/rdma-hns-modify-the-print-level-of-cqe-error.patch @@ -0,0 +1,42 @@ +From cb6f40669e7e77bb200c4395ddeb12233c547684 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:16:16 +0800 +Subject: RDMA/hns: Modify the print level of CQE error + +From: Chengchang Tang + +[ Upstream commit 349e859952285ab9689779fb46de163f13f18f43 ] + +Too much print may lead to a panic in kernel. Change ibdev_err() to +ibdev_err_ratelimited(), and change the printing level of cqe dump +to debug level. + +Fixes: 7c044adca272 ("RDMA/hns: Simplify the cqe code of poll cq") +Signed-off-by: Chengchang Tang +Signed-off-by: Junxian Huang +Link: https://lore.kernel.org/r/20240412091616.370789-11-huangjunxian6@hisilicon.com +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +index 9c9a707d26d67..f95ec4618fbed 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c ++++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +@@ -3715,8 +3715,9 @@ static void get_cqe_status(struct hns_roce_dev *hr_dev, struct hns_roce_qp *qp, + wc->status == IB_WC_WR_FLUSH_ERR)) + return; + +- ibdev_err(&hr_dev->ib_dev, "error cqe status 0x%x:\n", cqe_status); +- print_hex_dump(KERN_ERR, "", DUMP_PREFIX_NONE, 16, 4, cqe, ++ ibdev_err_ratelimited(&hr_dev->ib_dev, "error cqe status 0x%x:\n", ++ cqe_status); ++ print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_NONE, 16, 4, cqe, + cq->cqe_size, false); + wc->vendor_err = hr_reg_read(cqe, CQE_SUB_STATUS); + +-- +2.43.0 + diff --git a/queue-6.8/rdma-hns-use-complete-parentheses-in-macros.patch b/queue-6.8/rdma-hns-use-complete-parentheses-in-macros.patch new file mode 100644 index 00000000000..4e2bc034f97 --- /dev/null +++ b/queue-6.8/rdma-hns-use-complete-parentheses-in-macros.patch @@ -0,0 +1,52 @@ +From 31afdcd7a5b0ab7b63c0037a5785a30d6243b5bc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:16:15 +0800 +Subject: RDMA/hns: Use complete parentheses in macros + +From: Chengchang Tang + +[ Upstream commit 4125269bb9b22e1d8cdf4412c81be8074dbc61ca ] + +Use complete parentheses to ensure that macro expansion does +not produce unexpected results. + +Fixes: a25d13cbe816 ("RDMA/hns: Add the interfaces to support multi hop addressing for the contexts in hip08") +Signed-off-by: Chengchang Tang +Signed-off-by: Junxian Huang +Link: https://lore.kernel.org/r/20240412091616.370789-10-huangjunxian6@hisilicon.com +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/hns/hns_roce_hem.h | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/drivers/infiniband/hw/hns/hns_roce_hem.h b/drivers/infiniband/hw/hns/hns_roce_hem.h +index 7d23d3c51da46..fea6d7d508b60 100644 +--- a/drivers/infiniband/hw/hns/hns_roce_hem.h ++++ b/drivers/infiniband/hw/hns/hns_roce_hem.h +@@ -61,16 +61,16 @@ enum { + (sizeof(struct scatterlist) + sizeof(void *))) + + #define check_whether_bt_num_3(type, hop_num) \ +- (type < HEM_TYPE_MTT && hop_num == 2) ++ ((type) < HEM_TYPE_MTT && (hop_num) == 2) + + #define check_whether_bt_num_2(type, hop_num) \ +- ((type < HEM_TYPE_MTT && hop_num == 1) || \ +- (type >= HEM_TYPE_MTT && hop_num == 2)) ++ (((type) < HEM_TYPE_MTT && (hop_num) == 1) || \ ++ ((type) >= HEM_TYPE_MTT && (hop_num) == 2)) + + #define check_whether_bt_num_1(type, hop_num) \ +- ((type < HEM_TYPE_MTT && hop_num == HNS_ROCE_HOP_NUM_0) || \ +- (type >= HEM_TYPE_MTT && hop_num == 1) || \ +- (type >= HEM_TYPE_MTT && hop_num == HNS_ROCE_HOP_NUM_0)) ++ (((type) < HEM_TYPE_MTT && (hop_num) == HNS_ROCE_HOP_NUM_0) || \ ++ ((type) >= HEM_TYPE_MTT && (hop_num) == 1) || \ ++ ((type) >= HEM_TYPE_MTT && (hop_num) == HNS_ROCE_HOP_NUM_0)) + + struct hns_roce_hem_chunk { + struct list_head list; +-- +2.43.0 + diff --git a/queue-6.8/rdma-ipoib-fix-format-truncation-compilation-errors.patch b/queue-6.8/rdma-ipoib-fix-format-truncation-compilation-errors.patch new file mode 100644 index 00000000000..660a985aac8 --- /dev/null +++ b/queue-6.8/rdma-ipoib-fix-format-truncation-compilation-errors.patch @@ -0,0 +1,66 @@ +From 56db41fa090df331825b363a368746abeb96e5fe Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 10:39:33 +0300 +Subject: RDMA/IPoIB: Fix format truncation compilation errors +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Leon Romanovsky + +[ Upstream commit 49ca2b2ef3d003402584c68ae7b3055ba72e750a ] + +Truncate the device name to store IPoIB VLAN name. + +[leonro@5b4e8fba4ddd kernel]$ make -s -j 20 allmodconfig +[leonro@5b4e8fba4ddd kernel]$ make -s -j 20 W=1 drivers/infiniband/ulp/ipoib/ +drivers/infiniband/ulp/ipoib/ipoib_vlan.c: In function ‘ipoib_vlan_add’: +drivers/infiniband/ulp/ipoib/ipoib_vlan.c:187:52: error: ‘%04x’ +directive output may be truncated writing 4 bytes into a region of size +between 0 and 15 [-Werror=format-truncation=] + 187 | snprintf(intf_name, sizeof(intf_name), "%s.%04x", + | ^~~~ +drivers/infiniband/ulp/ipoib/ipoib_vlan.c:187:48: note: directive +argument in the range [0, 65535] + 187 | snprintf(intf_name, sizeof(intf_name), "%s.%04x", + | ^~~~~~~~~ +drivers/infiniband/ulp/ipoib/ipoib_vlan.c:187:9: note: ‘snprintf’ output +between 6 and 21 bytes into a destination of size 16 + 187 | snprintf(intf_name, sizeof(intf_name), "%s.%04x", + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + 188 | ppriv->dev->name, pkey); + | ~~~~~~~~~~~~~~~~~~~~~~~ +cc1: all warnings being treated as errors +make[6]: *** [scripts/Makefile.build:244: drivers/infiniband/ulp/ipoib/ipoib_vlan.o] Error 1 +make[6]: *** Waiting for unfinished jobs.... + +Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support") +Link: https://lore.kernel.org/r/e9d3e1fef69df4c9beaf402cc3ac342bad680791.1715240029.git.leon@kernel.org +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +diff --git a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c +index 4bd161e86f8dd..562df2b3ef187 100644 +--- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c ++++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c +@@ -184,8 +184,12 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey) + + ppriv = ipoib_priv(pdev); + +- snprintf(intf_name, sizeof(intf_name), "%s.%04x", +- ppriv->dev->name, pkey); ++ /* If you increase IFNAMSIZ, update snprintf below ++ * to allow longer names. ++ */ ++ BUILD_BUG_ON(IFNAMSIZ != 16); ++ snprintf(intf_name, sizeof(intf_name), "%.10s.%04x", ppriv->dev->name, ++ pkey); + + ndev = ipoib_intf_alloc(ppriv->ca, ppriv->port, intf_name); + if (IS_ERR(ndev)) { +-- +2.43.0 + diff --git a/queue-6.8/rdma-mana_ib-boundary-check-before-installing-cq-cal.patch b/queue-6.8/rdma-mana_ib-boundary-check-before-installing-cq-cal.patch new file mode 100644 index 00000000000..f525d52d814 --- /dev/null +++ b/queue-6.8/rdma-mana_ib-boundary-check-before-installing-cq-cal.patch @@ -0,0 +1,37 @@ +From 517accf8811b3b56ec805132e5e4f489fbdd5767 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 06:12:39 -0700 +Subject: RDMA/mana_ib: boundary check before installing cq callbacks + +From: Konstantin Taranov + +[ Upstream commit f79edef79b6a2161f4124112f9b0c46891bb0b74 ] + +Add a boundary check inside mana_ib_install_cq_cb to prevent index overflow. + +Fixes: 2a31c5a7e0d8 ("RDMA/mana_ib: Introduce mana_ib_install_cq_cb helper function") +Signed-off-by: Konstantin Taranov +Link: https://lore.kernel.org/r/1714137160-5222-5-git-send-email-kotaranov@linux.microsoft.com +Reviewed-by: Long Li +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mana/cq.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c +index c9129218f1be1..89fcc09ded8a4 100644 +--- a/drivers/infiniband/hw/mana/cq.c ++++ b/drivers/infiniband/hw/mana/cq.c +@@ -81,6 +81,8 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) + struct gdma_context *gc = mdev_to_gc(mdev); + struct gdma_queue *gdma_cq; + ++ if (cq->queue.id >= gc->max_num_cqs) ++ return -EINVAL; + /* Create CQ table entry */ + WARN_ON(gc->cq_table[cq->queue.id]); + gdma_cq = kzalloc(sizeof(*gdma_cq), GFP_KERNEL); +-- +2.43.0 + diff --git a/queue-6.8/rdma-mana_ib-introduce-helpers-to-create-and-destroy.patch b/queue-6.8/rdma-mana_ib-introduce-helpers-to-create-and-destroy.patch new file mode 100644 index 00000000000..27e1432ddd7 --- /dev/null +++ b/queue-6.8/rdma-mana_ib-introduce-helpers-to-create-and-destroy.patch @@ -0,0 +1,109 @@ +From 2bd486ad95a2bdbb209e94ce432693f02092bfba Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 13:08:05 -0700 +Subject: RDMA/mana_ib: Introduce helpers to create and destroy mana queues + +From: Konstantin Taranov + +[ Upstream commit 46f5be7cd4bceb3a503c544b3dab7b75fe4bb96b ] + +Intoduce helpers to work with mana ib queues (struct mana_ib_queue). +A queue always consists of umem, gdma_region, and id. +A queue can become a WQ or a CQ. + +Signed-off-by: Konstantin Taranov +Link: https://lore.kernel.org/r/1711483688-24358-2-git-send-email-kotaranov@linux.microsoft.com +Reviewed-by: Long Li +Signed-off-by: Leon Romanovsky +Stable-dep-of: f79edef79b6a ("RDMA/mana_ib: boundary check before installing cq callbacks") +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mana/main.c | 43 ++++++++++++++++++++++++++++ + drivers/infiniband/hw/mana/mana_ib.h | 10 +++++++ + 2 files changed, 53 insertions(+) + +diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c +index 71e33feee61bb..4524c6b807487 100644 +--- a/drivers/infiniband/hw/mana/main.c ++++ b/drivers/infiniband/hw/mana/main.c +@@ -237,6 +237,49 @@ void mana_ib_dealloc_ucontext(struct ib_ucontext *ibcontext) + ibdev_dbg(ibdev, "Failed to destroy doorbell page %d\n", ret); + } + ++int mana_ib_create_queue(struct mana_ib_dev *mdev, u64 addr, u32 size, ++ struct mana_ib_queue *queue) ++{ ++ struct ib_umem *umem; ++ int err; ++ ++ queue->umem = NULL; ++ queue->id = INVALID_QUEUE_ID; ++ queue->gdma_region = GDMA_INVALID_DMA_REGION; ++ ++ umem = ib_umem_get(&mdev->ib_dev, addr, size, IB_ACCESS_LOCAL_WRITE); ++ if (IS_ERR(umem)) { ++ err = PTR_ERR(umem); ++ ibdev_dbg(&mdev->ib_dev, "Failed to get umem, %d\n", err); ++ return err; ++ } ++ ++ err = mana_ib_create_zero_offset_dma_region(mdev, umem, &queue->gdma_region); ++ if (err) { ++ ibdev_dbg(&mdev->ib_dev, "Failed to create dma region, %d\n", err); ++ goto free_umem; ++ } ++ queue->umem = umem; ++ ++ ibdev_dbg(&mdev->ib_dev, ++ "create_dma_region ret %d gdma_region 0x%llx\n", ++ err, queue->gdma_region); ++ ++ return 0; ++free_umem: ++ ib_umem_release(umem); ++ return err; ++} ++ ++void mana_ib_destroy_queue(struct mana_ib_dev *mdev, struct mana_ib_queue *queue) ++{ ++ /* Ignore return code as there is not much we can do about it. ++ * The error message is printed inside. ++ */ ++ mana_ib_gd_destroy_dma_region(mdev, queue->gdma_region); ++ ib_umem_release(queue->umem); ++} ++ + static int + mana_ib_gd_first_dma_region(struct mana_ib_dev *dev, + struct gdma_context *gc, +diff --git a/drivers/infiniband/hw/mana/mana_ib.h b/drivers/infiniband/hw/mana/mana_ib.h +index f83390eebb7d7..859fd3bfc764f 100644 +--- a/drivers/infiniband/hw/mana/mana_ib.h ++++ b/drivers/infiniband/hw/mana/mana_ib.h +@@ -45,6 +45,12 @@ struct mana_ib_adapter_caps { + u32 max_inline_data_size; + }; + ++struct mana_ib_queue { ++ struct ib_umem *umem; ++ u64 gdma_region; ++ u64 id; ++}; ++ + struct mana_ib_dev { + struct ib_device ib_dev; + struct gdma_dev *gdma_dev; +@@ -169,6 +175,10 @@ int mana_ib_create_dma_region(struct mana_ib_dev *dev, struct ib_umem *umem, + int mana_ib_gd_destroy_dma_region(struct mana_ib_dev *dev, + mana_handle_t gdma_region); + ++int mana_ib_create_queue(struct mana_ib_dev *mdev, u64 addr, u32 size, ++ struct mana_ib_queue *queue); ++void mana_ib_destroy_queue(struct mana_ib_dev *mdev, struct mana_ib_queue *queue); ++ + struct ib_wq *mana_ib_create_wq(struct ib_pd *pd, + struct ib_wq_init_attr *init_attr, + struct ib_udata *udata); +-- +2.43.0 + diff --git a/queue-6.8/rdma-mana_ib-use-struct-mana_ib_queue-for-cqs.patch b/queue-6.8/rdma-mana_ib-use-struct-mana_ib_queue-for-cqs.patch new file mode 100644 index 00000000000..e0e36c0746d --- /dev/null +++ b/queue-6.8/rdma-mana_ib-use-struct-mana_ib_queue-for-cqs.patch @@ -0,0 +1,231 @@ +From 97d3f0cbbfda05985d19cfa17991c90ddbb0fa7d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 13:08:06 -0700 +Subject: RDMA/mana_ib: Use struct mana_ib_queue for CQs + +From: Konstantin Taranov + +[ Upstream commit 60a7ac0b8bec5df9764b7460ffee91fc981e8a31 ] + +Use struct mana_ib_queue and its helpers for CQs + +Signed-off-by: Konstantin Taranov +Link: https://lore.kernel.org/r/1711483688-24358-3-git-send-email-kotaranov@linux.microsoft.com +Reviewed-by: Long Li +Signed-off-by: Leon Romanovsky +Stable-dep-of: f79edef79b6a ("RDMA/mana_ib: boundary check before installing cq callbacks") +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mana/cq.c | 52 ++++++---------------------- + drivers/infiniband/hw/mana/mana_ib.h | 4 +-- + drivers/infiniband/hw/mana/qp.c | 26 +++++++------- + 3 files changed, 24 insertions(+), 58 deletions(-) + +diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c +index 4a71e678d09c1..c9129218f1be1 100644 +--- a/drivers/infiniband/hw/mana/cq.c ++++ b/drivers/infiniband/hw/mana/cq.c +@@ -39,37 +39,13 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr, + } + + cq->cqe = attr->cqe; +- cq->umem = ib_umem_get(ibdev, ucmd.buf_addr, cq->cqe * COMP_ENTRY_SIZE, +- IB_ACCESS_LOCAL_WRITE); +- if (IS_ERR(cq->umem)) { +- err = PTR_ERR(cq->umem); +- ibdev_dbg(ibdev, "Failed to get umem for create cq, err %d\n", +- err); +- return err; +- } +- +- err = mana_ib_create_zero_offset_dma_region(mdev, cq->umem, &cq->gdma_region); ++ err = mana_ib_create_queue(mdev, ucmd.buf_addr, cq->cqe * COMP_ENTRY_SIZE, &cq->queue); + if (err) { +- ibdev_dbg(ibdev, +- "Failed to create dma region for create cq, %d\n", +- err); +- goto err_release_umem; ++ ibdev_dbg(ibdev, "Failed to create queue for create cq, %d\n", err); ++ return err; + } + +- ibdev_dbg(ibdev, +- "create_dma_region ret %d gdma_region 0x%llx\n", +- err, cq->gdma_region); +- +- /* +- * The CQ ID is not known at this time. The ID is generated at create_qp +- */ +- cq->id = INVALID_QUEUE_ID; +- + return 0; +- +-err_release_umem: +- ib_umem_release(cq->umem); +- return err; + } + + int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) +@@ -78,24 +54,16 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) + struct ib_device *ibdev = ibcq->device; + struct mana_ib_dev *mdev; + struct gdma_context *gc; +- int err; + + mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gc = mdev_to_gc(mdev); + +- err = mana_ib_gd_destroy_dma_region(mdev, cq->gdma_region); +- if (err) { +- ibdev_dbg(ibdev, +- "Failed to destroy dma region, %d\n", err); +- return err; +- } +- +- if (cq->id != INVALID_QUEUE_ID) { +- kfree(gc->cq_table[cq->id]); +- gc->cq_table[cq->id] = NULL; ++ if (cq->queue.id != INVALID_QUEUE_ID) { ++ kfree(gc->cq_table[cq->queue.id]); ++ gc->cq_table[cq->queue.id] = NULL; + } + +- ib_umem_release(cq->umem); ++ mana_ib_destroy_queue(mdev, &cq->queue); + + return 0; + } +@@ -114,7 +82,7 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) + struct gdma_queue *gdma_cq; + + /* Create CQ table entry */ +- WARN_ON(gc->cq_table[cq->id]); ++ WARN_ON(gc->cq_table[cq->queue.id]); + gdma_cq = kzalloc(sizeof(*gdma_cq), GFP_KERNEL); + if (!gdma_cq) + return -ENOMEM; +@@ -122,7 +90,7 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) + gdma_cq->cq.context = cq; + gdma_cq->type = GDMA_CQ; + gdma_cq->cq.callback = mana_ib_cq_handler; +- gdma_cq->id = cq->id; +- gc->cq_table[cq->id] = gdma_cq; ++ gdma_cq->id = cq->queue.id; ++ gc->cq_table[cq->queue.id] = gdma_cq; + return 0; + } +diff --git a/drivers/infiniband/hw/mana/mana_ib.h b/drivers/infiniband/hw/mana/mana_ib.h +index 859fd3bfc764f..6acb5c281c368 100644 +--- a/drivers/infiniband/hw/mana/mana_ib.h ++++ b/drivers/infiniband/hw/mana/mana_ib.h +@@ -88,10 +88,8 @@ struct mana_ib_mr { + + struct mana_ib_cq { + struct ib_cq ibcq; +- struct ib_umem *umem; ++ struct mana_ib_queue queue; + int cqe; +- u64 gdma_region; +- u64 id; + u32 comp_vector; + }; + +diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c +index 6e7627745c957..d7485ee6a6854 100644 +--- a/drivers/infiniband/hw/mana/qp.c ++++ b/drivers/infiniband/hw/mana/qp.c +@@ -197,7 +197,7 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd, + wq_spec.gdma_region = wq->gdma_region; + wq_spec.queue_size = wq->wq_buf_size; + +- cq_spec.gdma_region = cq->gdma_region; ++ cq_spec.gdma_region = cq->queue.gdma_region; + cq_spec.queue_size = cq->cqe * COMP_ENTRY_SIZE; + cq_spec.modr_ctx_id = 0; + eq = &mpc->ac->eqs[cq->comp_vector % gc->max_num_queues]; +@@ -213,16 +213,16 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd, + + /* The GDMA regions are now owned by the WQ object */ + wq->gdma_region = GDMA_INVALID_DMA_REGION; +- cq->gdma_region = GDMA_INVALID_DMA_REGION; ++ cq->queue.gdma_region = GDMA_INVALID_DMA_REGION; + + wq->id = wq_spec.queue_index; +- cq->id = cq_spec.queue_index; ++ cq->queue.id = cq_spec.queue_index; + + ibdev_dbg(&mdev->ib_dev, + "ret %d rx_object 0x%llx wq id %llu cq id %llu\n", +- ret, wq->rx_object, wq->id, cq->id); ++ ret, wq->rx_object, wq->id, cq->queue.id); + +- resp.entries[i].cqid = cq->id; ++ resp.entries[i].cqid = cq->queue.id; + resp.entries[i].wqid = wq->id; + + mana_ind_table[i] = wq->rx_object; +@@ -232,7 +232,7 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd, + if (ret) + goto fail; + +- gdma_cq_allocated[i] = gc->cq_table[cq->id]; ++ gdma_cq_allocated[i] = gc->cq_table[cq->queue.id]; + } + resp.num_entries = i; + +@@ -264,7 +264,7 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd, + wq = container_of(ibwq, struct mana_ib_wq, ibwq); + cq = container_of(ibcq, struct mana_ib_cq, ibcq); + +- gc->cq_table[cq->id] = NULL; ++ gc->cq_table[cq->queue.id] = NULL; + kfree(gdma_cq_allocated[i]); + + mana_destroy_wq_obj(mpc, GDMA_RQ, wq->rx_object); +@@ -374,7 +374,7 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd, + wq_spec.gdma_region = qp->sq_gdma_region; + wq_spec.queue_size = ucmd.sq_buf_size; + +- cq_spec.gdma_region = send_cq->gdma_region; ++ cq_spec.gdma_region = send_cq->queue.gdma_region; + cq_spec.queue_size = send_cq->cqe * COMP_ENTRY_SIZE; + cq_spec.modr_ctx_id = 0; + eq_vec = send_cq->comp_vector % gc->max_num_queues; +@@ -392,10 +392,10 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd, + + /* The GDMA regions are now owned by the WQ object */ + qp->sq_gdma_region = GDMA_INVALID_DMA_REGION; +- send_cq->gdma_region = GDMA_INVALID_DMA_REGION; ++ send_cq->queue.gdma_region = GDMA_INVALID_DMA_REGION; + + qp->sq_id = wq_spec.queue_index; +- send_cq->id = cq_spec.queue_index; ++ send_cq->queue.id = cq_spec.queue_index; + + /* Create CQ table entry */ + err = mana_ib_install_cq_cb(mdev, send_cq); +@@ -404,10 +404,10 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd, + + ibdev_dbg(&mdev->ib_dev, + "ret %d qp->tx_object 0x%llx sq id %llu cq id %llu\n", err, +- qp->tx_object, qp->sq_id, send_cq->id); ++ qp->tx_object, qp->sq_id, send_cq->queue.id); + + resp.sqid = qp->sq_id; +- resp.cqid = send_cq->id; ++ resp.cqid = send_cq->queue.id; + resp.tx_vp_offset = pd->tx_vp_offset; + + err = ib_copy_to_udata(udata, &resp, sizeof(resp)); +@@ -422,7 +422,7 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd, + + err_release_gdma_cq: + kfree(gdma_cq); +- gc->cq_table[send_cq->id] = NULL; ++ gc->cq_table[send_cq->queue.id] = NULL; + + err_destroy_wq_obj: + mana_destroy_wq_obj(mpc, GDMA_SQ, qp->tx_object); +-- +2.43.0 + diff --git a/queue-6.8/rdma-mlx5-adding-remote-atomic-access-flag-to-updata.patch b/queue-6.8/rdma-mlx5-adding-remote-atomic-access-flag-to-updata.patch new file mode 100644 index 00000000000..60ca7500de5 --- /dev/null +++ b/queue-6.8/rdma-mlx5-adding-remote-atomic-access-flag-to-updata.patch @@ -0,0 +1,39 @@ +From cebe62bf220c76fc27707f28ff90d8e9f053a8ef Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:36:01 +0300 +Subject: RDMA/mlx5: Adding remote atomic access flag to updatable flags + +From: Or Har-Toov + +[ Upstream commit 2ca7e93bc963d9ec2f5c24d117176851454967af ] + +Currently IB_ACCESS_REMOTE_ATOMIC is blocked from being updated via UMR +although in some cases it should be possible. These cases are checked in +mlx5r_umr_can_reconfig function. + +Fixes: ef3642c4f54d ("RDMA/mlx5: Fix error unwinds for rereg_mr") +Signed-off-by: Or Har-Toov +Link: https://lore.kernel.org/r/24dac73e2fa48cb806f33a932d97f3e402a5ea2c.1712140377.git.leon@kernel.org +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/mr.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c +index 7f7b1f59b5f05..ecc111ed5d86e 100644 +--- a/drivers/infiniband/hw/mlx5/mr.c ++++ b/drivers/infiniband/hw/mlx5/mr.c +@@ -1572,7 +1572,8 @@ static bool can_use_umr_rereg_access(struct mlx5_ib_dev *dev, + unsigned int diffs = current_access_flags ^ target_access_flags; + + if (diffs & ~(IB_ACCESS_LOCAL_WRITE | IB_ACCESS_REMOTE_WRITE | +- IB_ACCESS_REMOTE_READ | IB_ACCESS_RELAXED_ORDERING)) ++ IB_ACCESS_REMOTE_READ | IB_ACCESS_RELAXED_ORDERING | ++ IB_ACCESS_REMOTE_ATOMIC)) + return false; + return mlx5r_umr_can_reconfig(dev, current_access_flags, + target_access_flags); +-- +2.43.0 + diff --git a/queue-6.8/rdma-mlx5-change-check-for-cacheable-mkeys.patch b/queue-6.8/rdma-mlx5-change-check-for-cacheable-mkeys.patch new file mode 100644 index 00000000000..c5c52196fb9 --- /dev/null +++ b/queue-6.8/rdma-mlx5-change-check-for-cacheable-mkeys.patch @@ -0,0 +1,103 @@ +From 183eb8f43ba6bca32e65dc5e00917a04229cf676 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:36:00 +0300 +Subject: RDMA/mlx5: Change check for cacheable mkeys + +From: Or Har-Toov + +[ Upstream commit 8c1185fef68cc603b954fece2a434c9f851d6a86 ] + +umem can be NULL for user application mkeys in some cases. Therefore +umem can't be used for checking if the mkey is cacheable and it is +changed for checking a flag that indicates it. Also make sure that +all mkeys which are not returned to the cache will be destroyed. + +Fixes: dd1b913fb0d0 ("RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow") +Signed-off-by: Or Har-Toov +Link: https://lore.kernel.org/r/2690bc5c6896bcb937f89af16a1ff0343a7ab3d0.1712140377.git.leon@kernel.org +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + + drivers/infiniband/hw/mlx5/mr.c | 32 +++++++++++++++++++--------- + 2 files changed, 23 insertions(+), 10 deletions(-) + +diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h +index 989968ba74153..79ebafecca22a 100644 +--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h ++++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h +@@ -646,6 +646,7 @@ struct mlx5_ib_mkey { + /* Cacheable user Mkey must hold either a rb_key or a cache_ent. */ + struct mlx5r_cache_rb_key rb_key; + struct mlx5_cache_ent *cache_ent; ++ u8 cacheable : 1; + }; + + #define MLX5_IB_MTT_PRESENT (MLX5_IB_MTT_READ | MLX5_IB_MTT_WRITE) +diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c +index a8ee2ca1f4a17..7f7b1f59b5f05 100644 +--- a/drivers/infiniband/hw/mlx5/mr.c ++++ b/drivers/infiniband/hw/mlx5/mr.c +@@ -1158,6 +1158,7 @@ static struct mlx5_ib_mr *alloc_cacheable_mr(struct ib_pd *pd, + if (IS_ERR(mr)) + return mr; + mr->mmkey.rb_key = rb_key; ++ mr->mmkey.cacheable = true; + return mr; + } + +@@ -1168,6 +1169,7 @@ static struct mlx5_ib_mr *alloc_cacheable_mr(struct ib_pd *pd, + mr->ibmr.pd = pd; + mr->umem = umem; + mr->page_shift = order_base_2(page_size); ++ mr->mmkey.cacheable = true; + set_mr_fields(dev, mr, umem->length, access_flags, iova); + + return mr; +@@ -1835,6 +1837,23 @@ static int cache_ent_find_and_store(struct mlx5_ib_dev *dev, + return ret; + } + ++static int mlx5_revoke_mr(struct mlx5_ib_mr *mr) ++{ ++ struct mlx5_ib_dev *dev = to_mdev(mr->ibmr.device); ++ struct mlx5_cache_ent *ent = mr->mmkey.cache_ent; ++ ++ if (mr->mmkey.cacheable && !mlx5r_umr_revoke_mr(mr) && !cache_ent_find_and_store(dev, mr)) ++ return 0; ++ ++ if (ent) { ++ spin_lock_irq(&ent->mkeys_queue.lock); ++ ent->in_use--; ++ mr->mmkey.cache_ent = NULL; ++ spin_unlock_irq(&ent->mkeys_queue.lock); ++ } ++ return destroy_mkey(dev, mr); ++} ++ + int mlx5_ib_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata) + { + struct mlx5_ib_mr *mr = to_mmr(ibmr); +@@ -1880,16 +1899,9 @@ int mlx5_ib_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata) + } + + /* Stop DMA */ +- if (mr->umem && mlx5r_umr_can_load_pas(dev, mr->umem->length)) +- if (mlx5r_umr_revoke_mr(mr) || +- cache_ent_find_and_store(dev, mr)) +- mr->mmkey.cache_ent = NULL; +- +- if (!mr->mmkey.cache_ent) { +- rc = destroy_mkey(to_mdev(mr->ibmr.device), mr); +- if (rc) +- return rc; +- } ++ rc = mlx5_revoke_mr(mr); ++ if (rc) ++ return rc; + + if (mr->umem) { + bool is_odp = is_odp_mr(mr); +-- +2.43.0 + diff --git a/queue-6.8/rdma-mlx5-uncacheable-mkey-has-neither-rb_key-or-cac.patch b/queue-6.8/rdma-mlx5-uncacheable-mkey-has-neither-rb_key-or-cac.patch new file mode 100644 index 00000000000..3fb07167a37 --- /dev/null +++ b/queue-6.8/rdma-mlx5-uncacheable-mkey-has-neither-rb_key-or-cac.patch @@ -0,0 +1,38 @@ +From 2dfaa24cd2dc761f14a1ac27939d59ecb563c980 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 13:35:59 +0300 +Subject: RDMA/mlx5: Uncacheable mkey has neither rb_key or cache_ent + +From: Or Har-Toov + +[ Upstream commit 0611a8e8b475fc5230b9a24d29c8397aaab20b63 ] + +As some mkeys can't be modified with UMR due to some UMR limitations, +like the size of translation that can be updated, not all user mkeys can +be cached. + +Fixes: dd1b913fb0d0 ("RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow") +Signed-off-by: Or Har-Toov +Link: https://lore.kernel.org/r/f2742dd934ed73b2d32c66afb8e91b823063880c.1712140377.git.leon@kernel.org +Signed-off-by: Leon Romanovsky +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h +index bbe79b86c7178..989968ba74153 100644 +--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h ++++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h +@@ -643,7 +643,7 @@ struct mlx5_ib_mkey { + unsigned int ndescs; + struct wait_queue_head wait; + refcount_t usecount; +- /* User Mkey must hold either a rb_key or a cache_ent. */ ++ /* Cacheable user Mkey must hold either a rb_key or a cache_ent. */ + struct mlx5r_cache_rb_key rb_key; + struct mlx5_cache_ent *cache_ent; + }; +-- +2.43.0 + diff --git a/queue-6.8/rdma-rxe-allow-good-work-requests-to-be-executed.patch b/queue-6.8/rdma-rxe-allow-good-work-requests-to-be-executed.patch new file mode 100644 index 00000000000..12691ff2a2a --- /dev/null +++ b/queue-6.8/rdma-rxe-allow-good-work-requests-to-be-executed.patch @@ -0,0 +1,58 @@ +From b59efc718958b7ce5ce0c18c8bfb5d53f8df9bbc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 09:55:05 -0500 +Subject: RDMA/rxe: Allow good work requests to be executed + +From: Bob Pearson + +[ Upstream commit b703374837a8f8422fa3f1edcf65505421a65a6a ] + +A previous commit incorrectly added an 'if(!err)' before scheduling the +requester task in rxe_post_send_kernel(). But if there were send wrs +successfully added to the send queue before a bad wr they might never get +executed. + +This commit fixes this by scheduling the requester task if any wqes were +successfully posted in rxe_post_send_kernel() in rxe_verbs.c. + +Link: https://lore.kernel.org/r/20240329145513.35381-5-rpearsonhpe@gmail.com +Signed-off-by: Bob Pearson +Fixes: 5bf944f24129 ("RDMA/rxe: Add error messages") +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/sw/rxe/rxe_verbs.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c +index 48f86839d36a8..0930350522e38 100644 +--- a/drivers/infiniband/sw/rxe/rxe_verbs.c ++++ b/drivers/infiniband/sw/rxe/rxe_verbs.c +@@ -888,6 +888,7 @@ static int rxe_post_send_kernel(struct rxe_qp *qp, + { + int err = 0; + unsigned long flags; ++ int good = 0; + + spin_lock_irqsave(&qp->sq.sq_lock, flags); + while (ibwr) { +@@ -895,12 +896,15 @@ static int rxe_post_send_kernel(struct rxe_qp *qp, + if (err) { + *bad_wr = ibwr; + break; ++ } else { ++ good++; + } + ibwr = ibwr->next; + } + spin_unlock_irqrestore(&qp->sq.sq_lock, flags); + +- if (!err) ++ /* kickoff processing of any posted wqes */ ++ if (good) + rxe_sched_task(&qp->req.task); + + spin_lock_irqsave(&qp->state_lock, flags); +-- +2.43.0 + diff --git a/queue-6.8/rdma-rxe-fix-incorrect-rxe_put-in-error-path.patch b/queue-6.8/rdma-rxe-fix-incorrect-rxe_put-in-error-path.patch new file mode 100644 index 00000000000..02162e5e524 --- /dev/null +++ b/queue-6.8/rdma-rxe-fix-incorrect-rxe_put-in-error-path.patch @@ -0,0 +1,55 @@ +From 872ebca020d3e06bac30d0fe519a4ce4786570ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 09:55:12 -0500 +Subject: RDMA/rxe: Fix incorrect rxe_put in error path + +From: Bob Pearson + +[ Upstream commit 8776618dbbd1b6f210b31509507e1aad461d6435 ] + +In rxe_send() a ref is taken on the qp to keep it alive until the +kfree_skb() has a chance to call the skb destructor rxe_skb_tx_dtor() +which drops the reference. If the packet has an incorrect protocol the +error path just calls kfree_skb() which will call the destructor which +will drop the ref. Currently the driver also calls rxe_put() which is +incorrect. Additionally since the packets sent to rxe_send() are under the +control of the driver and it only ever produces IPV4 or IPV6 packets the +simplest fix is to remove all the code in this block. + +Link: https://lore.kernel.org/r/20240329145513.35381-12-rpearsonhpe@gmail.com +Signed-off-by: Bob Pearson +Fixes: 9eb7f8e44d13 ("IB/rxe: Move refcounting earlier in rxe_send()") +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/sw/rxe/rxe_net.c | 12 ++---------- + 1 file changed, 2 insertions(+), 10 deletions(-) + +diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c +index cd59666158b18..e5827064ab1e2 100644 +--- a/drivers/infiniband/sw/rxe/rxe_net.c ++++ b/drivers/infiniband/sw/rxe/rxe_net.c +@@ -366,18 +366,10 @@ static int rxe_send(struct sk_buff *skb, struct rxe_pkt_info *pkt) + rxe_get(pkt->qp); + atomic_inc(&pkt->qp->skb_out); + +- if (skb->protocol == htons(ETH_P_IP)) { ++ if (skb->protocol == htons(ETH_P_IP)) + err = ip_local_out(dev_net(skb_dst(skb)->dev), skb->sk, skb); +- } else if (skb->protocol == htons(ETH_P_IPV6)) { ++ else + err = ip6_local_out(dev_net(skb_dst(skb)->dev), skb->sk, skb); +- } else { +- rxe_dbg_qp(pkt->qp, "Unknown layer 3 protocol: %d\n", +- skb->protocol); +- atomic_dec(&pkt->qp->skb_out); +- rxe_put(pkt->qp); +- kfree_skb(skb); +- return -EINVAL; +- } + + if (unlikely(net_xmit_eval(err))) { + rxe_dbg_qp(pkt->qp, "error sending packet: %d\n", err); +-- +2.43.0 + diff --git a/queue-6.8/rdma-rxe-fix-seg-fault-in-rxe_comp_queue_pkt.patch b/queue-6.8/rdma-rxe-fix-seg-fault-in-rxe_comp_queue_pkt.patch new file mode 100644 index 00000000000..06ed66eaadf --- /dev/null +++ b/queue-6.8/rdma-rxe-fix-seg-fault-in-rxe_comp_queue_pkt.patch @@ -0,0 +1,52 @@ +From 985cd66e2c3441be2e1e1c95e38b5a0f36429999 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 09:55:04 -0500 +Subject: RDMA/rxe: Fix seg fault in rxe_comp_queue_pkt + +From: Bob Pearson + +[ Upstream commit 2b23b6097303ed0ba5f4bc036a1c07b6027af5c6 ] + +In rxe_comp_queue_pkt() an incoming response packet skb is enqueued to the +resp_pkts queue and then a decision is made whether to run the completer +task inline or schedule it. Finally the skb is dereferenced to bump a 'hw' +performance counter. This is wrong because if the completer task is +already running in a separate thread it may have already processed the skb +and freed it which can cause a seg fault. This has been observed +infrequently in testing at high scale. + +This patch fixes this by changing the order of enqueuing the packet until +after the counter is accessed. + +Link: https://lore.kernel.org/r/20240329145513.35381-4-rpearsonhpe@gmail.com +Signed-off-by: Bob Pearson +Fixes: 0b1e5b99a48b ("IB/rxe: Add port protocol stats") +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/sw/rxe/rxe_comp.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/infiniband/sw/rxe/rxe_comp.c b/drivers/infiniband/sw/rxe/rxe_comp.c +index d0bdc2d8adc82..acd2172bf092b 100644 +--- a/drivers/infiniband/sw/rxe/rxe_comp.c ++++ b/drivers/infiniband/sw/rxe/rxe_comp.c +@@ -131,12 +131,12 @@ void rxe_comp_queue_pkt(struct rxe_qp *qp, struct sk_buff *skb) + { + int must_sched; + +- skb_queue_tail(&qp->resp_pkts, skb); +- +- must_sched = skb_queue_len(&qp->resp_pkts) > 1; ++ must_sched = skb_queue_len(&qp->resp_pkts) > 0; + if (must_sched != 0) + rxe_counter_inc(SKB_TO_PKT(skb)->rxe, RXE_CNT_COMPLETER_SCHED); + ++ skb_queue_tail(&qp->resp_pkts, skb); ++ + if (must_sched) + rxe_sched_task(&qp->comp.task); + else +-- +2.43.0 + diff --git a/queue-6.8/regulator-irq_helpers-duplicate-irq-name.patch b/queue-6.8/regulator-irq_helpers-duplicate-irq-name.patch new file mode 100644 index 00000000000..dc45617b48d --- /dev/null +++ b/queue-6.8/regulator-irq_helpers-duplicate-irq-name.patch @@ -0,0 +1,43 @@ +From 40102d9ed876844c7d66c0ccf6b28923aa4a6a23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 7 Apr 2024 10:35:21 +0300 +Subject: regulator: irq_helpers: duplicate IRQ name + +From: Matti Vaittinen + +[ Upstream commit 7ab681ddedd4b6dd2b047c74af95221c5f827e1d ] + +The regulator IRQ helper requires caller to provide pointer to IRQ name +which is kept in memory by caller. All other data passed to the helper +in the regulator_irq_desc structure is copied. This can cause some +confusion and unnecessary complexity. + +Make the regulator_irq_helper() to copy also the provided IRQ name +information so caller can discard the name after the call to +regulator_irq_helper() completes. + +Signed-off-by: Matti Vaittinen +Link: https://msgid.link/r/ZhJMuUYwaZbBXFGP@drtxq0yyyyyyyyyyyyydy-3.rev.dnainternet.fi +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/irq_helpers.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/regulator/irq_helpers.c b/drivers/regulator/irq_helpers.c +index fe7ae0f3f46af..5ab1a0befe12f 100644 +--- a/drivers/regulator/irq_helpers.c ++++ b/drivers/regulator/irq_helpers.c +@@ -352,6 +352,9 @@ void *regulator_irq_helper(struct device *dev, + + h->irq = irq; + h->desc = *d; ++ h->desc.name = devm_kstrdup(dev, d->name, GFP_KERNEL); ++ if (!h->desc.name) ++ return ERR_PTR(-ENOMEM); + + ret = init_rdev_state(dev, h, rdev, common_errs, per_rdev_errs, + rdev_amount); +-- +2.43.0 + diff --git a/queue-6.8/regulator-qcom-refgen-fix-module-autoloading.patch b/queue-6.8/regulator-qcom-refgen-fix-module-autoloading.patch new file mode 100644 index 00000000000..5093d767794 --- /dev/null +++ b/queue-6.8/regulator-qcom-refgen-fix-module-autoloading.patch @@ -0,0 +1,36 @@ +From 6961db22de39240a96787283eecc62225bbe8496 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 19:26:14 +0200 +Subject: regulator: qcom-refgen: fix module autoloading + +From: Krzysztof Kozlowski + +[ Upstream commit ddd3f34c10002e41ed3cd89c9bd8f1d05a22506a ] + +Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded +based on the alias from of_device_id table. + +Signed-off-by: Krzysztof Kozlowski +Reviewed-by: Konrad Dybcio +Link: https://msgid.link/r/20240410172615.255424-1-krzk@kernel.org +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/qcom-refgen-regulator.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/regulator/qcom-refgen-regulator.c b/drivers/regulator/qcom-refgen-regulator.c +index 656fe330d38f0..063e12c08e75f 100644 +--- a/drivers/regulator/qcom-refgen-regulator.c ++++ b/drivers/regulator/qcom-refgen-regulator.c +@@ -140,6 +140,7 @@ static const struct of_device_id qcom_refgen_match_table[] = { + { .compatible = "qcom,sm8250-refgen-regulator", .data = &sm8250_refgen_desc }, + { } + }; ++MODULE_DEVICE_TABLE(of, qcom_refgen_match_table); + + static struct platform_driver qcom_refgen_driver = { + .probe = qcom_refgen_probe, +-- +2.43.0 + diff --git a/queue-6.8/regulator-vqmmc-ipq4019-fix-module-autoloading.patch b/queue-6.8/regulator-vqmmc-ipq4019-fix-module-autoloading.patch new file mode 100644 index 00000000000..9859ddff157 --- /dev/null +++ b/queue-6.8/regulator-vqmmc-ipq4019-fix-module-autoloading.patch @@ -0,0 +1,36 @@ +From 3b8459974122b1784f0bb7b3431b375c772f713c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 19:26:15 +0200 +Subject: regulator: vqmmc-ipq4019: fix module autoloading + +From: Krzysztof Kozlowski + +[ Upstream commit 68adb581a39ae63a0ed082c47f01fbbe515efa0e ] + +Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded +based on the alias from of_device_id table. + +Signed-off-by: Krzysztof Kozlowski +Reviewed-by: Konrad Dybcio +Link: https://msgid.link/r/20240410172615.255424-2-krzk@kernel.org +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/regulator/vqmmc-ipq4019-regulator.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/regulator/vqmmc-ipq4019-regulator.c b/drivers/regulator/vqmmc-ipq4019-regulator.c +index 086da36abc0b4..4955616517ce9 100644 +--- a/drivers/regulator/vqmmc-ipq4019-regulator.c ++++ b/drivers/regulator/vqmmc-ipq4019-regulator.c +@@ -84,6 +84,7 @@ static const struct of_device_id regulator_ipq4019_of_match[] = { + { .compatible = "qcom,vqmmc-ipq4019-regulator", }, + {}, + }; ++MODULE_DEVICE_TABLE(of, regulator_ipq4019_of_match); + + static struct platform_driver ipq4019_regulator_driver = { + .probe = ipq4019_regulator_probe, +-- +2.43.0 + diff --git a/queue-6.8/revert-net-txgbe-fix-clk_name-exceed-max_dev_id-limi.patch b/queue-6.8/revert-net-txgbe-fix-clk_name-exceed-max_dev_id-limi.patch new file mode 100644 index 00000000000..dd7123c82f1 --- /dev/null +++ b/queue-6.8/revert-net-txgbe-fix-clk_name-exceed-max_dev_id-limi.patch @@ -0,0 +1,39 @@ +From 3fe7d1dfac8d1a397cff8906bf11d23fd77b559b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 16:41:09 +0800 +Subject: Revert "net: txgbe: fix clk_name exceed MAX_DEV_ID limits" + +From: Duanqiang Wen + +[ Upstream commit edd2d250fb3bb5d70419ae82c1f9dbb9684dffd3 ] + +This reverts commit e30cef001da259e8df354b813015d0e5acc08740. +commit 99f4570cfba1 ("clkdev: Update clkdev id usage to allow +for longer names") can fix clk_name exceed MAX_DEV_ID limits, +so this commit is meaningless. + +Signed-off-by: Duanqiang Wen +Reviewed-by: Jacob Keller +Link: https://lore.kernel.org/r/20240422084109.3201-2-duanqiangwen@net-swift.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +index 29997e4b2d6ca..1b84d495d14e8 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +@@ -556,7 +556,7 @@ static int txgbe_clock_register(struct txgbe *txgbe) + char clk_name[32]; + struct clk *clk; + +- snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d", ++ snprintf(clk_name, sizeof(clk_name), "i2c_designware.%d", + pci_dev_id(pdev)); + + clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000); +-- +2.43.0 + diff --git a/queue-6.8/revert-net-txgbe-fix-i2c-dev-name-cannot-match-clkde.patch b/queue-6.8/revert-net-txgbe-fix-i2c-dev-name-cannot-match-clkde.patch new file mode 100644 index 00000000000..496573fcc54 --- /dev/null +++ b/queue-6.8/revert-net-txgbe-fix-i2c-dev-name-cannot-match-clkde.patch @@ -0,0 +1,58 @@ +From e0a6db52cb3aec40459466bcfe054f326dcb2bd0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 16:41:08 +0800 +Subject: Revert "net: txgbe: fix i2c dev name cannot match clkdev" + +From: Duanqiang Wen + +[ Upstream commit 8d6bf83f6740ba52a59e25dad360e1e87ef47666 ] + +This reverts commit c644920ce9220d83e070f575a4df711741c07f07. +when register i2c dev, txgbe shorten "i2c_designware" to "i2c_dw", +will cause this i2c dev can't match platfom driver i2c_designware_platform. + +Signed-off-by: Duanqiang Wen +Reviewed-by: Jacob Keller +Link: https://lore.kernel.org/r/20240422084109.3201-1-duanqiangwen@net-swift.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 8 +++----- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +index 8cddc9ddb3392..29997e4b2d6ca 100644 +--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c ++++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +@@ -20,8 +20,6 @@ + #include "txgbe_phy.h" + #include "txgbe_hw.h" + +-#define TXGBE_I2C_CLK_DEV_NAME "i2c_dw" +- + static int txgbe_swnodes_register(struct txgbe *txgbe) + { + struct txgbe_nodes *nodes = &txgbe->nodes; +@@ -558,8 +556,8 @@ static int txgbe_clock_register(struct txgbe *txgbe) + char clk_name[32]; + struct clk *clk; + +- snprintf(clk_name, sizeof(clk_name), "%s.%d", +- TXGBE_I2C_CLK_DEV_NAME, pci_dev_id(pdev)); ++ snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d", ++ pci_dev_id(pdev)); + + clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000); + if (IS_ERR(clk)) +@@ -621,7 +619,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe) + + info.parent = &pdev->dev; + info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]); +- info.name = TXGBE_I2C_CLK_DEV_NAME; ++ info.name = "i2c_designware"; + info.id = pci_dev_id(pdev); + + info.res = &DEFINE_RES_IRQ(pdev->irq); +-- +2.43.0 + diff --git a/queue-6.8/revert-sh-handle-calling-csum_partial-with-misaligne.patch b/queue-6.8/revert-sh-handle-calling-csum_partial-with-misaligne.patch new file mode 100644 index 00000000000..8dff0f18933 --- /dev/null +++ b/queue-6.8/revert-sh-handle-calling-csum_partial-with-misaligne.patch @@ -0,0 +1,187 @@ +From 03dd3530776641fe195088e76478cce1dd7397fc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 24 Mar 2024 16:18:04 -0700 +Subject: Revert "sh: Handle calling csum_partial with misaligned data" + +From: Guenter Roeck + +[ Upstream commit b5319c96292ff877f6b58d349acf0a9dc8d3b454 ] + +This reverts commit cadc4e1a2b4d20d0cc0e81f2c6ba0588775e54e5. + +Commit cadc4e1a2b4d ("sh: Handle calling csum_partial with misaligned +data") causes bad checksum calculations on unaligned data. Reverting +it fixes the problem. + + # Subtest: checksum + # module: checksum_kunit + 1..5 + # test_csum_fixed_random_inputs: ASSERTION FAILED at lib/checksum_kunit.c:500 + Expected ( u64)result == ( u64)expec, but + ( u64)result == 53378 (0xd082) + ( u64)expec == 33488 (0x82d0) + # test_csum_fixed_random_inputs: pass:0 fail:1 skip:0 total:1 + not ok 1 test_csum_fixed_random_inputs + # test_csum_all_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:525 + Expected ( u64)result == ( u64)expec, but + ( u64)result == 65281 (0xff01) + ( u64)expec == 65280 (0xff00) + # test_csum_all_carry_inputs: pass:0 fail:1 skip:0 total:1 + not ok 2 test_csum_all_carry_inputs + # test_csum_no_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:573 + Expected ( u64)result == ( u64)expec, but + ( u64)result == 65535 (0xffff) + ( u64)expec == 65534 (0xfffe) + # test_csum_no_carry_inputs: pass:0 fail:1 skip:0 total:1 + not ok 3 test_csum_no_carry_inputs + # test_ip_fast_csum: pass:1 fail:0 skip:0 total:1 + ok 4 test_ip_fast_csum + # test_csum_ipv6_magic: pass:1 fail:0 skip:0 total:1 + ok 5 test_csum_ipv6_magic + # checksum: pass:2 fail:3 skip:0 total:5 + # Totals: pass:2 fail:3 skip:0 total:5 +not ok 22 checksum + +Fixes: cadc4e1a2b4d ("sh: Handle calling csum_partial with misaligned data") +Signed-off-by: Guenter Roeck +Tested-by: Geert Uytterhoeven +Reviewed-by: John Paul Adrian Glaubitz +Link: https://lore.kernel.org/r/20240324231804.841099-1-linux@roeck-us.net +Signed-off-by: John Paul Adrian Glaubitz +Signed-off-by: Sasha Levin +--- + arch/sh/lib/checksum.S | 67 ++++++++++++------------------------------ + 1 file changed, 18 insertions(+), 49 deletions(-) + +diff --git a/arch/sh/lib/checksum.S b/arch/sh/lib/checksum.S +index 3e07074e00981..06fed5a21e8ba 100644 +--- a/arch/sh/lib/checksum.S ++++ b/arch/sh/lib/checksum.S +@@ -33,7 +33,8 @@ + */ + + /* +- * asmlinkage __wsum csum_partial(const void *buf, int len, __wsum sum); ++ * unsigned int csum_partial(const unsigned char *buf, int len, ++ * unsigned int sum); + */ + + .text +@@ -45,31 +46,11 @@ ENTRY(csum_partial) + * Fortunately, it is easy to convert 2-byte alignment to 4-byte + * alignment for the unrolled loop. + */ ++ mov r5, r1 + mov r4, r0 +- tst #3, r0 ! Check alignment. +- bt/s 2f ! Jump if alignment is ok. +- mov r4, r7 ! Keep a copy to check for alignment ++ tst #2, r0 ! Check alignment. ++ bt 2f ! Jump if alignment is ok. + ! +- tst #1, r0 ! Check alignment. +- bt 21f ! Jump if alignment is boundary of 2bytes. +- +- ! buf is odd +- tst r5, r5 +- add #-1, r5 +- bt 9f +- mov.b @r4+, r0 +- extu.b r0, r0 +- addc r0, r6 ! t=0 from previous tst +- mov r6, r0 +- shll8 r6 +- shlr16 r0 +- shlr8 r0 +- or r0, r6 +- mov r4, r0 +- tst #2, r0 +- bt 2f +-21: +- ! buf is 2 byte aligned (len could be 0) + add #-2, r5 ! Alignment uses up two bytes. + cmp/pz r5 ! + bt/s 1f ! Jump if we had at least two bytes. +@@ -77,17 +58,16 @@ ENTRY(csum_partial) + bra 6f + add #2, r5 ! r5 was < 2. Deal with it. + 1: ++ mov r5, r1 ! Save new len for later use. + mov.w @r4+, r0 + extu.w r0, r0 + addc r0, r6 + bf 2f + add #1, r6 + 2: +- ! buf is 4 byte aligned (len could be 0) +- mov r5, r1 + mov #-5, r0 +- shld r0, r1 +- tst r1, r1 ++ shld r0, r5 ++ tst r5, r5 + bt/s 4f ! if it's =0, go to 4f + clrt + .align 2 +@@ -109,31 +89,30 @@ ENTRY(csum_partial) + addc r0, r6 + addc r2, r6 + movt r0 +- dt r1 ++ dt r5 + bf/s 3b + cmp/eq #1, r0 +- ! here, we know r1==0 +- addc r1, r6 ! add carry to r6 ++ ! here, we know r5==0 ++ addc r5, r6 ! add carry to r6 + 4: +- mov r5, r0 ++ mov r1, r0 + and #0x1c, r0 + tst r0, r0 +- bt 6f +- ! 4 bytes or more remaining +- mov r0, r1 +- shlr2 r1 ++ bt/s 6f ++ mov r0, r5 ++ shlr2 r5 + mov #0, r2 + 5: + addc r2, r6 + mov.l @r4+, r2 + movt r0 +- dt r1 ++ dt r5 + bf/s 5b + cmp/eq #1, r0 + addc r2, r6 +- addc r1, r6 ! r1==0 here, so it means add carry-bit ++ addc r5, r6 ! r5==0 here, so it means add carry-bit + 6: +- ! 3 bytes or less remaining ++ mov r1, r5 + mov #3, r0 + and r0, r5 + tst r5, r5 +@@ -159,16 +138,6 @@ ENTRY(csum_partial) + mov #0, r0 + addc r0, r6 + 9: +- ! Check if the buffer was misaligned, if so realign sum +- mov r7, r0 +- tst #1, r0 +- bt 10f +- mov r6, r0 +- shll8 r6 +- shlr16 r0 +- shlr8 r0 +- or r0, r6 +-10: + rts + mov r6, r0 + +-- +2.43.0 + diff --git a/queue-6.8/riscv-bpf-make-some-atomic-operations-fully-ordered.patch b/queue-6.8/riscv-bpf-make-some-atomic-operations-fully-ordered.patch new file mode 100644 index 00000000000..57385857bfc --- /dev/null +++ b/queue-6.8/riscv-bpf-make-some-atomic-operations-fully-ordered.patch @@ -0,0 +1,97 @@ +From ee9e2b4209da785d198e052ecfc1e5f70e4217c8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 5 May 2024 20:16:33 +0000 +Subject: riscv, bpf: make some atomic operations fully ordered + +From: Puranjay Mohan + +[ Upstream commit 20a759df3bba35bf5c3ddec0c02ad69b603b584c ] + +The BPF atomic operations with the BPF_FETCH modifier along with +BPF_XCHG and BPF_CMPXCHG are fully ordered but the RISC-V JIT implements +all atomic operations except BPF_CMPXCHG with relaxed ordering. + +Section 8.1 of the "The RISC-V Instruction Set Manual Volume I: +Unprivileged ISA" [1], titled, "Specifying Ordering of Atomic +Instructions" says: + +| To provide more efficient support for release consistency [5], each +| atomic instruction has two bits, aq and rl, used to specify additional +| memory ordering constraints as viewed by other RISC-V harts. + +and + +| If only the aq bit is set, the atomic memory operation is treated as +| an acquire access. +| If only the rl bit is set, the atomic memory operation is treated as a +| release access. +| +| If both the aq and rl bits are set, the atomic memory operation is +| sequentially consistent. + +Fix this by setting both aq and rl bits as 1 for operations with +BPF_FETCH and BPF_XCHG. + +[1] https://riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf + +Fixes: dd642ccb45ec ("riscv, bpf: Implement more atomic operations for RV64") +Signed-off-by: Puranjay Mohan +Reviewed-by: Pu Lehui +Link: https://lore.kernel.org/r/20240505201633.123115-1-puranjay@kernel.org +Signed-off-by: Alexei Starovoitov +Signed-off-by: Sasha Levin +--- + arch/riscv/net/bpf_jit_comp64.c | 20 ++++++++++---------- + 1 file changed, 10 insertions(+), 10 deletions(-) + +diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp64.c +index 0bd747d1d00fc..29f031f68f480 100644 +--- a/arch/riscv/net/bpf_jit_comp64.c ++++ b/arch/riscv/net/bpf_jit_comp64.c +@@ -516,33 +516,33 @@ static void emit_atomic(u8 rd, u8 rs, s16 off, s32 imm, bool is64, + break; + /* src_reg = atomic_fetch_(dst_reg + off16, src_reg) */ + case BPF_ADD | BPF_FETCH: +- emit(is64 ? rv_amoadd_d(rs, rs, rd, 0, 0) : +- rv_amoadd_w(rs, rs, rd, 0, 0), ctx); ++ emit(is64 ? rv_amoadd_d(rs, rs, rd, 1, 1) : ++ rv_amoadd_w(rs, rs, rd, 1, 1), ctx); + if (!is64) + emit_zext_32(rs, ctx); + break; + case BPF_AND | BPF_FETCH: +- emit(is64 ? rv_amoand_d(rs, rs, rd, 0, 0) : +- rv_amoand_w(rs, rs, rd, 0, 0), ctx); ++ emit(is64 ? rv_amoand_d(rs, rs, rd, 1, 1) : ++ rv_amoand_w(rs, rs, rd, 1, 1), ctx); + if (!is64) + emit_zext_32(rs, ctx); + break; + case BPF_OR | BPF_FETCH: +- emit(is64 ? rv_amoor_d(rs, rs, rd, 0, 0) : +- rv_amoor_w(rs, rs, rd, 0, 0), ctx); ++ emit(is64 ? rv_amoor_d(rs, rs, rd, 1, 1) : ++ rv_amoor_w(rs, rs, rd, 1, 1), ctx); + if (!is64) + emit_zext_32(rs, ctx); + break; + case BPF_XOR | BPF_FETCH: +- emit(is64 ? rv_amoxor_d(rs, rs, rd, 0, 0) : +- rv_amoxor_w(rs, rs, rd, 0, 0), ctx); ++ emit(is64 ? rv_amoxor_d(rs, rs, rd, 1, 1) : ++ rv_amoxor_w(rs, rs, rd, 1, 1), ctx); + if (!is64) + emit_zext_32(rs, ctx); + break; + /* src_reg = atomic_xchg(dst_reg + off16, src_reg); */ + case BPF_XCHG: +- emit(is64 ? rv_amoswap_d(rs, rs, rd, 0, 0) : +- rv_amoswap_w(rs, rs, rd, 0, 0), ctx); ++ emit(is64 ? rv_amoswap_d(rs, rs, rd, 1, 1) : ++ rv_amoswap_w(rs, rs, rd, 1, 1), ctx); + if (!is64) + emit_zext_32(rs, ctx); + break; +-- +2.43.0 + diff --git a/queue-6.8/riscv-t-head-test-availability-bit-before-enabling-m.patch b/queue-6.8/riscv-t-head-test-availability-bit-before-enabling-m.patch new file mode 100644 index 00000000000..ac3e60ed007 --- /dev/null +++ b/queue-6.8/riscv-t-head-test-availability-bit-before-enabling-m.patch @@ -0,0 +1,73 @@ +From 480d70423a2d3ec89cbe91a06e0c550916350cb5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 7 Apr 2024 23:32:36 +0200 +Subject: riscv: T-Head: Test availability bit before enabling MAE errata +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Christoph Müllner + +[ Upstream commit 65b71cc35cc6631cb0a5b24f961fe64c085cb40b ] + +T-Head's memory attribute extension (XTheadMae) (non-compatible +equivalent of RVI's Svpbmt) is currently assumed for all T-Head harts. +However, QEMU recently decided to drop acceptance of guests that write +reserved bits in PTEs. +As XTheadMae uses reserved bits in PTEs and Linux applies the MAE errata +for all T-Head harts, this broke the Linux startup on QEMU emulations +of the C906 emulation. + +This patch attempts to address this issue by testing the MAE-enable bit +in the th.sxstatus CSR. This CSR is available in HW and can be +emulated in QEMU. + +This patch also makes the XTheadMae probing mechanism reliable, because +a test for the right combination of mvendorid, marchid, and mimpid +is not sufficient to enable MAE. + +Reviewed-by: Conor Dooley +Signed-off-by: Christoph Müllner +Link: https://lore.kernel.org/r/20240407213236.2121592-3-christoph.muellner@vrull.eu +Signed-off-by: Palmer Dabbelt +Signed-off-by: Sasha Levin +--- + arch/riscv/errata/thead/errata.c | 14 ++++++++++---- + 1 file changed, 10 insertions(+), 4 deletions(-) + +diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c +index 6e7ee1f16bee3..bf6a0a6318ee3 100644 +--- a/arch/riscv/errata/thead/errata.c ++++ b/arch/riscv/errata/thead/errata.c +@@ -19,6 +19,9 @@ + #include + #include + ++#define CSR_TH_SXSTATUS 0x5c0 ++#define SXSTATUS_MAEE _AC(0x200000, UL) ++ + static bool errata_probe_mae(unsigned int stage, + unsigned long arch_id, unsigned long impid) + { +@@ -28,11 +31,14 @@ static bool errata_probe_mae(unsigned int stage, + if (arch_id != 0 || impid != 0) + return false; + +- if (stage == RISCV_ALTERNATIVES_EARLY_BOOT || +- stage == RISCV_ALTERNATIVES_MODULE) +- return true; ++ if (stage != RISCV_ALTERNATIVES_EARLY_BOOT && ++ stage != RISCV_ALTERNATIVES_MODULE) ++ return false; + +- return false; ++ if (!(csr_read(CSR_TH_SXSTATUS) & SXSTATUS_MAEE)) ++ return false; ++ ++ return true; + } + + /* +-- +2.43.0 + diff --git a/queue-6.8/riscv-thead-rename-t-head-pbmt-to-mae.patch b/queue-6.8/riscv-thead-rename-t-head-pbmt-to-mae.patch new file mode 100644 index 00000000000..3f2dcf234fa --- /dev/null +++ b/queue-6.8/riscv-thead-rename-t-head-pbmt-to-mae.patch @@ -0,0 +1,138 @@ +From ed2522e7d38e3a106126dc38b98ff77150f52451 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 7 Apr 2024 23:32:35 +0200 +Subject: riscv: thead: Rename T-Head PBMT to MAE +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Christoph Müllner + +[ Upstream commit 6179d4a213006491ff0d50073256f21fad22149b ] + +T-Head's vendor extension to set page attributes has the name +MAE (memory attribute extension). +Let's rename it, so it is clear what this referes to. + +Link: https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadmae.adoc +Reviewed-by: Conor Dooley +Signed-off-by: Christoph Müllner +Link: https://lore.kernel.org/r/20240407213236.2121592-2-christoph.muellner@vrull.eu +Signed-off-by: Palmer Dabbelt +Signed-off-by: Sasha Levin +--- + arch/riscv/Kconfig.errata | 8 ++++---- + arch/riscv/errata/thead/errata.c | 10 +++++----- + arch/riscv/include/asm/errata_list.h | 20 ++++++++++---------- + 3 files changed, 19 insertions(+), 19 deletions(-) + +diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata +index 910ba8837add8..2acc7d876e1fb 100644 +--- a/arch/riscv/Kconfig.errata ++++ b/arch/riscv/Kconfig.errata +@@ -82,14 +82,14 @@ config ERRATA_THEAD + + Otherwise, please say "N" here to avoid unnecessary overhead. + +-config ERRATA_THEAD_PBMT +- bool "Apply T-Head memory type errata" ++config ERRATA_THEAD_MAE ++ bool "Apply T-Head's memory attribute extension (XTheadMae) errata" + depends on ERRATA_THEAD && 64BIT && MMU + select RISCV_ALTERNATIVE_EARLY + default y + help +- This will apply the memory type errata to handle the non-standard +- memory type bits in page-table-entries on T-Head SoCs. ++ This will apply the memory attribute extension errata to handle the ++ non-standard PTE utilization on T-Head SoCs (XTheadMae). + + If you don't know what to do here, say "Y". + +diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c +index b1c410bbc1aec..6e7ee1f16bee3 100644 +--- a/arch/riscv/errata/thead/errata.c ++++ b/arch/riscv/errata/thead/errata.c +@@ -19,10 +19,10 @@ + #include + #include + +-static bool errata_probe_pbmt(unsigned int stage, +- unsigned long arch_id, unsigned long impid) ++static bool errata_probe_mae(unsigned int stage, ++ unsigned long arch_id, unsigned long impid) + { +- if (!IS_ENABLED(CONFIG_ERRATA_THEAD_PBMT)) ++ if (!IS_ENABLED(CONFIG_ERRATA_THEAD_MAE)) + return false; + + if (arch_id != 0 || impid != 0) +@@ -140,8 +140,8 @@ static u32 thead_errata_probe(unsigned int stage, + { + u32 cpu_req_errata = 0; + +- if (errata_probe_pbmt(stage, archid, impid)) +- cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); ++ if (errata_probe_mae(stage, archid, impid)) ++ cpu_req_errata |= BIT(ERRATA_THEAD_MAE); + + errata_probe_cmo(stage, archid, impid); + +diff --git a/arch/riscv/include/asm/errata_list.h b/arch/riscv/include/asm/errata_list.h +index ea33288f8a25b..9bad9dfa2f7a1 100644 +--- a/arch/riscv/include/asm/errata_list.h ++++ b/arch/riscv/include/asm/errata_list.h +@@ -23,7 +23,7 @@ + #endif + + #ifdef CONFIG_ERRATA_THEAD +-#define ERRATA_THEAD_PBMT 0 ++#define ERRATA_THEAD_MAE 0 + #define ERRATA_THEAD_PMU 1 + #define ERRATA_THEAD_NUMBER 2 + #endif +@@ -53,20 +53,20 @@ asm(ALTERNATIVE("sfence.vma %0", "sfence.vma", SIFIVE_VENDOR_ID, \ + * in the default case. + */ + #define ALT_SVPBMT_SHIFT 61 +-#define ALT_THEAD_PBMT_SHIFT 59 ++#define ALT_THEAD_MAE_SHIFT 59 + #define ALT_SVPBMT(_val, prot) \ + asm(ALTERNATIVE_2("li %0, 0\t\nnop", \ + "li %0, %1\t\nslli %0,%0,%3", 0, \ + RISCV_ISA_EXT_SVPBMT, CONFIG_RISCV_ISA_SVPBMT, \ + "li %0, %2\t\nslli %0,%0,%4", THEAD_VENDOR_ID, \ +- ERRATA_THEAD_PBMT, CONFIG_ERRATA_THEAD_PBMT) \ ++ ERRATA_THEAD_MAE, CONFIG_ERRATA_THEAD_MAE) \ + : "=r"(_val) \ + : "I"(prot##_SVPBMT >> ALT_SVPBMT_SHIFT), \ +- "I"(prot##_THEAD >> ALT_THEAD_PBMT_SHIFT), \ ++ "I"(prot##_THEAD >> ALT_THEAD_MAE_SHIFT), \ + "I"(ALT_SVPBMT_SHIFT), \ +- "I"(ALT_THEAD_PBMT_SHIFT)) ++ "I"(ALT_THEAD_MAE_SHIFT)) + +-#ifdef CONFIG_ERRATA_THEAD_PBMT ++#ifdef CONFIG_ERRATA_THEAD_MAE + /* + * IO/NOCACHE memory types are handled together with svpbmt, + * so on T-Head chips, check if no other memory type is set, +@@ -83,11 +83,11 @@ asm volatile(ALTERNATIVE( \ + "slli t3, t3, %3\n\t" \ + "or %0, %0, t3\n\t" \ + "2:", THEAD_VENDOR_ID, \ +- ERRATA_THEAD_PBMT, CONFIG_ERRATA_THEAD_PBMT) \ ++ ERRATA_THEAD_MAE, CONFIG_ERRATA_THEAD_MAE) \ + : "+r"(_val) \ +- : "I"(_PAGE_MTMASK_THEAD >> ALT_THEAD_PBMT_SHIFT), \ +- "I"(_PAGE_PMA_THEAD >> ALT_THEAD_PBMT_SHIFT), \ +- "I"(ALT_THEAD_PBMT_SHIFT) \ ++ : "I"(_PAGE_MTMASK_THEAD >> ALT_THEAD_MAE_SHIFT), \ ++ "I"(_PAGE_PMA_THEAD >> ALT_THEAD_MAE_SHIFT), \ ++ "I"(ALT_THEAD_MAE_SHIFT) \ + : "t3") + #else + #define ALT_THEAD_PMA(_val) +-- +2.43.0 + diff --git a/queue-6.8/s390-bpf-emit-a-barrier-for-bpf_fetch-instructions.patch b/queue-6.8/s390-bpf-emit-a-barrier-for-bpf_fetch-instructions.patch new file mode 100644 index 00000000000..b451d4150d9 --- /dev/null +++ b/queue-6.8/s390-bpf-emit-a-barrier-for-bpf_fetch-instructions.patch @@ -0,0 +1,62 @@ +From b3e324aeb615add257298f81f231ad48ba897e88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 May 2024 02:02:49 +0200 +Subject: s390/bpf: Emit a barrier for BPF_FETCH instructions + +From: Ilya Leoshkevich + +[ Upstream commit 68378982f0b21de02ac3c6a11e2420badefcb4bc ] + +BPF_ATOMIC_OP() macro documentation states that "BPF_ADD | BPF_FETCH" +should be the same as atomic_fetch_add(), which is currently not the +case on s390x: the serialization instruction "bcr 14,0" is missing. +This applies to "and", "or" and "xor" variants too. + +s390x is allowed to reorder stores with subsequent fetches from +different addresses, so code relying on BPF_FETCH acting as a barrier, +for example: + + stw [%r0], 1 + afadd [%r1], %r2 + ldxw %r3, [%r4] + +may be broken. Fix it by emitting "bcr 14,0". + +Note that a separate serialization instruction is not needed for +BPF_XCHG and BPF_CMPXCHG, because COMPARE AND SWAP performs +serialization itself. + +Fixes: ba3b86b9cef0 ("s390/bpf: Implement new atomic ops") +Reported-by: Puranjay Mohan +Closes: https://lore.kernel.org/bpf/mb61p34qvq3wf.fsf@kernel.org/ +Signed-off-by: Ilya Leoshkevich +Reviewed-by: Puranjay Mohan +Link: https://lore.kernel.org/r/20240507000557.12048-1-iii@linux.ibm.com +Signed-off-by: Alexei Starovoitov +Signed-off-by: Sasha Levin +--- + arch/s390/net/bpf_jit_comp.c | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c +index 5af0402e94b88..1d168a98ae21b 100644 +--- a/arch/s390/net/bpf_jit_comp.c ++++ b/arch/s390/net/bpf_jit_comp.c +@@ -1427,8 +1427,12 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp, + EMIT6_DISP_LH(0xeb000000, is32 ? (op32) : (op64), \ + (insn->imm & BPF_FETCH) ? src_reg : REG_W0, \ + src_reg, dst_reg, off); \ +- if (is32 && (insn->imm & BPF_FETCH)) \ +- EMIT_ZERO(src_reg); \ ++ if (insn->imm & BPF_FETCH) { \ ++ /* bcr 14,0 - see atomic_fetch_{add,and,or,xor}() */ \ ++ _EMIT2(0x07e0); \ ++ if (is32) \ ++ EMIT_ZERO(src_reg); \ ++ } \ + } while (0) + case BPF_ADD: + case BPF_ADD | BPF_FETCH: +-- +2.43.0 + diff --git a/queue-6.8/s390-cio-fix-tracepoint-subchannel-type-field.patch b/queue-6.8/s390-cio-fix-tracepoint-subchannel-type-field.patch new file mode 100644 index 00000000000..a315480e146 --- /dev/null +++ b/queue-6.8/s390-cio-fix-tracepoint-subchannel-type-field.patch @@ -0,0 +1,38 @@ +From c9cd278823eebfadb4ebee550420567134652e1f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 17:04:56 +0100 +Subject: s390/cio: fix tracepoint subchannel type field + +From: Peter Oberparleiter + +[ Upstream commit 8692a24d0fae19f674d51726d179ad04ba95d958 ] + +The subchannel-type field "st" of s390_cio_stsch and s390_cio_msch +tracepoints is incorrectly filled with the subchannel-enabled SCHIB +value "ena". Fix this by assigning the correct value. + +Fixes: d1de8633d96a ("s390 cio: Rewrite trace point class s390_class_schib") +Reviewed-by: Heiko Carstens +Signed-off-by: Peter Oberparleiter +Signed-off-by: Alexander Gordeev +Signed-off-by: Sasha Levin +--- + drivers/s390/cio/trace.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/s390/cio/trace.h b/drivers/s390/cio/trace.h +index 86993de253451..a4c5c6736b310 100644 +--- a/drivers/s390/cio/trace.h ++++ b/drivers/s390/cio/trace.h +@@ -50,7 +50,7 @@ DECLARE_EVENT_CLASS(s390_class_schib, + __entry->devno = schib->pmcw.dev; + __entry->schib = *schib; + __entry->pmcw_ena = schib->pmcw.ena; +- __entry->pmcw_st = schib->pmcw.ena; ++ __entry->pmcw_st = schib->pmcw.st; + __entry->pmcw_dnv = schib->pmcw.dnv; + __entry->pmcw_dev = schib->pmcw.dev; + __entry->pmcw_lpm = schib->pmcw.lpm; +-- +2.43.0 + diff --git a/queue-6.8/s390-mm-re-enable-the-shared-zeropage-for-pv-and-ske.patch b/queue-6.8/s390-mm-re-enable-the-shared-zeropage-for-pv-and-ske.patch new file mode 100644 index 00000000000..eda8cb87493 --- /dev/null +++ b/queue-6.8/s390-mm-re-enable-the-shared-zeropage-for-pv-and-ske.patch @@ -0,0 +1,369 @@ +From 8261d1f2c90532c6a0b02a8d205ce5bb87a28a88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 18:14:41 +0200 +Subject: s390/mm: Re-enable the shared zeropage for !PV and !skeys KVM guests + +From: David Hildenbrand + +[ Upstream commit 06201e00ee3e4beacac48aab2b83eff64ebf0bc0 ] + +commit fa41ba0d08de ("s390/mm: avoid empty zero pages for KVM guests to +avoid postcopy hangs") introduced an undesired side effect when combined +with memory ballooning and VM migration: memory part of the inflated +memory balloon will consume memory. + +Assuming we have a 100GiB VM and inflated the balloon to 40GiB. Our VM +will consume ~60GiB of memory. If we now trigger a VM migration, +hypervisors like QEMU will read all VM memory. As s390x does not support +the shared zeropage, we'll end up allocating for all previously-inflated +memory part of the memory balloon: 50 GiB. So we might easily +(unexpectedly) crash the VM on the migration source. + +Even worse, hypervisors like QEMU optimize for zeropage migration to not +consume memory on the migration destination: when migrating a +"page full of zeroes", on the migration destination they check whether the +target memory is already zero (by reading the destination memory) and avoid +writing to the memory to not allocate memory: however, s390x will also +allocate memory here, implying that also on the migration destination, we +will end up allocating all previously-inflated memory part of the memory +balloon. + +This is especially bad if actual memory overcommit was not desired, when +memory ballooning is used for dynamic VM memory resizing, setting aside +some memory during boot that can be added later on demand. Alternatives +like virtio-mem that would avoid this issue are not yet available on +s390x. + +There could be ways to optimize some cases in user space: before reading +memory in an anonymous private mapping on the migration source, check via +/proc/self/pagemap if anything is already populated. Similarly check on +the migration destination before reading. While that would avoid +populating tables full of shared zeropages on all architectures, it's +harder to get right and performant, and requires user space changes. + +Further, with posctopy live migration we must place a page, so there, +"avoid touching memory to avoid allocating memory" is not really +possible. (Note that a previously we would have falsely inserted +shared zeropages into processes using UFFDIO_ZEROPAGE where +mm_forbids_zeropage() would have actually forbidden it) + +PV is currently incompatible with memory ballooning, and in the common +case, KVM guests don't make use of storage keys. Instead of zapping +zeropages when enabling storage keys / PV, that turned out to be +problematic in the past, let's do exactly the same we do with KSM pages: +trigger unsharing faults to replace the shared zeropages by proper +anonymous folios. + +What about added latency when enabling storage kes? Having a lot of +zeropages in applicable environments (PV, legacy guests, unittests) is +unexpected. Further, KSM could today already unshare the zeropages +and unmerging KSM pages when enabling storage kets would unshare the +KSM-placed zeropages in the same way, resulting in the same latency. + +[ agordeev: Fixed sparse and checkpatch complaints and error handling ] + +Reviewed-by: Christian Borntraeger +Tested-by: Christian Borntraeger +Fixes: fa41ba0d08de ("s390/mm: avoid empty zero pages for KVM guests to avoid postcopy hangs") +Signed-off-by: David Hildenbrand +Link: https://lore.kernel.org/r/20240411161441.910170-3-david@redhat.com +Signed-off-by: Alexander Gordeev +Signed-off-by: Sasha Levin +--- + arch/s390/include/asm/gmap.h | 2 +- + arch/s390/include/asm/mmu.h | 5 + + arch/s390/include/asm/mmu_context.h | 1 + + arch/s390/include/asm/pgtable.h | 16 ++- + arch/s390/kvm/kvm-s390.c | 4 +- + arch/s390/mm/gmap.c | 165 +++++++++++++++++++++------- + 6 files changed, 146 insertions(+), 47 deletions(-) + +diff --git a/arch/s390/include/asm/gmap.h b/arch/s390/include/asm/gmap.h +index 5cc46e0dde620..9725586f42597 100644 +--- a/arch/s390/include/asm/gmap.h ++++ b/arch/s390/include/asm/gmap.h +@@ -146,7 +146,7 @@ int gmap_mprotect_notify(struct gmap *, unsigned long start, + + void gmap_sync_dirty_log_pmd(struct gmap *gmap, unsigned long dirty_bitmap[4], + unsigned long gaddr, unsigned long vmaddr); +-int gmap_mark_unmergeable(void); ++int s390_disable_cow_sharing(void); + void s390_unlist_old_asce(struct gmap *gmap); + int s390_replace_asce(struct gmap *gmap); + void s390_uv_destroy_pfns(unsigned long count, unsigned long *pfns); +diff --git a/arch/s390/include/asm/mmu.h b/arch/s390/include/asm/mmu.h +index bb1b4bef1878b..4c2dc7abc2858 100644 +--- a/arch/s390/include/asm/mmu.h ++++ b/arch/s390/include/asm/mmu.h +@@ -32,6 +32,11 @@ typedef struct { + unsigned int uses_skeys:1; + /* The mmu context uses CMM. */ + unsigned int uses_cmm:1; ++ /* ++ * The mmu context allows COW-sharing of memory pages (KSM, zeropage). ++ * Note that COW-sharing during fork() is currently always allowed. ++ */ ++ unsigned int allow_cow_sharing:1; + /* The gmaps associated with this context are allowed to use huge pages. */ + unsigned int allow_gmap_hpage_1m:1; + } mm_context_t; +diff --git a/arch/s390/include/asm/mmu_context.h b/arch/s390/include/asm/mmu_context.h +index 929af18b09081..a7789a9f62186 100644 +--- a/arch/s390/include/asm/mmu_context.h ++++ b/arch/s390/include/asm/mmu_context.h +@@ -35,6 +35,7 @@ static inline int init_new_context(struct task_struct *tsk, + mm->context.has_pgste = 0; + mm->context.uses_skeys = 0; + mm->context.uses_cmm = 0; ++ mm->context.allow_cow_sharing = 1; + mm->context.allow_gmap_hpage_1m = 0; + #endif + switch (mm->context.asce_limit) { +diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h +index 12a7b86789259..0a7055518ba20 100644 +--- a/arch/s390/include/asm/pgtable.h ++++ b/arch/s390/include/asm/pgtable.h +@@ -566,10 +566,20 @@ static inline pud_t set_pud_bit(pud_t pud, pgprot_t prot) + } + + /* +- * In the case that a guest uses storage keys +- * faults should no longer be backed by zero pages ++ * As soon as the guest uses storage keys or enables PV, we deduplicate all ++ * mapped shared zeropages and prevent new shared zeropages from getting ++ * mapped. + */ +-#define mm_forbids_zeropage mm_has_pgste ++#define mm_forbids_zeropage mm_forbids_zeropage ++static inline int mm_forbids_zeropage(struct mm_struct *mm) ++{ ++#ifdef CONFIG_PGSTE ++ if (!mm->context.allow_cow_sharing) ++ return 1; ++#endif ++ return 0; ++} ++ + static inline int mm_uses_skeys(struct mm_struct *mm) + { + #ifdef CONFIG_PGSTE +diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c +index ea63ac7698891..7c17be6ad4802 100644 +--- a/arch/s390/kvm/kvm-s390.c ++++ b/arch/s390/kvm/kvm-s390.c +@@ -2631,9 +2631,7 @@ static int kvm_s390_handle_pv(struct kvm *kvm, struct kvm_pv_cmd *cmd) + if (r) + break; + +- mmap_write_lock(current->mm); +- r = gmap_mark_unmergeable(); +- mmap_write_unlock(current->mm); ++ r = s390_disable_cow_sharing(); + if (r) + break; + +diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c +index 41a4a60c5e651..3b57837f3e914 100644 +--- a/arch/s390/mm/gmap.c ++++ b/arch/s390/mm/gmap.c +@@ -2547,41 +2547,6 @@ static inline void thp_split_mm(struct mm_struct *mm) + } + #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +-/* +- * Remove all empty zero pages from the mapping for lazy refaulting +- * - This must be called after mm->context.has_pgste is set, to avoid +- * future creation of zero pages +- * - This must be called after THP was disabled. +- * +- * mm contracts with s390, that even if mm were to remove a page table, +- * racing with the loop below and so causing pte_offset_map_lock() to fail, +- * it will never insert a page table containing empty zero pages once +- * mm_forbids_zeropage(mm) i.e. mm->context.has_pgste is set. +- */ +-static int __zap_zero_pages(pmd_t *pmd, unsigned long start, +- unsigned long end, struct mm_walk *walk) +-{ +- unsigned long addr; +- +- for (addr = start; addr != end; addr += PAGE_SIZE) { +- pte_t *ptep; +- spinlock_t *ptl; +- +- ptep = pte_offset_map_lock(walk->mm, pmd, addr, &ptl); +- if (!ptep) +- break; +- if (is_zero_pfn(pte_pfn(*ptep))) +- ptep_xchg_direct(walk->mm, addr, ptep, __pte(_PAGE_INVALID)); +- pte_unmap_unlock(ptep, ptl); +- } +- return 0; +-} +- +-static const struct mm_walk_ops zap_zero_walk_ops = { +- .pmd_entry = __zap_zero_pages, +- .walk_lock = PGWALK_WRLOCK, +-}; +- + /* + * switch on pgstes for its userspace process (for kvm) + */ +@@ -2599,22 +2564,142 @@ int s390_enable_sie(void) + mm->context.has_pgste = 1; + /* split thp mappings and disable thp for future mappings */ + thp_split_mm(mm); +- walk_page_range(mm, 0, TASK_SIZE, &zap_zero_walk_ops, NULL); + mmap_write_unlock(mm); + return 0; + } + EXPORT_SYMBOL_GPL(s390_enable_sie); + +-int gmap_mark_unmergeable(void) ++static int find_zeropage_pte_entry(pte_t *pte, unsigned long addr, ++ unsigned long end, struct mm_walk *walk) ++{ ++ unsigned long *found_addr = walk->private; ++ ++ /* Return 1 of the page is a zeropage. */ ++ if (is_zero_pfn(pte_pfn(*pte))) { ++ /* ++ * Shared zeropage in e.g., a FS DAX mapping? We cannot do the ++ * right thing and likely don't care: FAULT_FLAG_UNSHARE ++ * currently only works in COW mappings, which is also where ++ * mm_forbids_zeropage() is checked. ++ */ ++ if (!is_cow_mapping(walk->vma->vm_flags)) ++ return -EFAULT; ++ ++ *found_addr = addr; ++ return 1; ++ } ++ return 0; ++} ++ ++static const struct mm_walk_ops find_zeropage_ops = { ++ .pte_entry = find_zeropage_pte_entry, ++ .walk_lock = PGWALK_WRLOCK, ++}; ++ ++/* ++ * Unshare all shared zeropages, replacing them by anonymous pages. Note that ++ * we cannot simply zap all shared zeropages, because this could later ++ * trigger unexpected userfaultfd missing events. ++ * ++ * This must be called after mm->context.allow_cow_sharing was ++ * set to 0, to avoid future mappings of shared zeropages. ++ * ++ * mm contracts with s390, that even if mm were to remove a page table, ++ * and racing with walk_page_range_vma() calling pte_offset_map_lock() ++ * would fail, it will never insert a page table containing empty zero ++ * pages once mm_forbids_zeropage(mm) i.e. ++ * mm->context.allow_cow_sharing is set to 0. ++ */ ++static int __s390_unshare_zeropages(struct mm_struct *mm) ++{ ++ struct vm_area_struct *vma; ++ VMA_ITERATOR(vmi, mm, 0); ++ unsigned long addr; ++ vm_fault_t fault; ++ int rc; ++ ++ for_each_vma(vmi, vma) { ++ /* ++ * We could only look at COW mappings, but it's more future ++ * proof to catch unexpected zeropages in other mappings and ++ * fail. ++ */ ++ if ((vma->vm_flags & VM_PFNMAP) || is_vm_hugetlb_page(vma)) ++ continue; ++ addr = vma->vm_start; ++ ++retry: ++ rc = walk_page_range_vma(vma, addr, vma->vm_end, ++ &find_zeropage_ops, &addr); ++ if (rc < 0) ++ return rc; ++ else if (!rc) ++ continue; ++ ++ /* addr was updated by find_zeropage_pte_entry() */ ++ fault = handle_mm_fault(vma, addr, ++ FAULT_FLAG_UNSHARE | FAULT_FLAG_REMOTE, ++ NULL); ++ if (fault & VM_FAULT_OOM) ++ return -ENOMEM; ++ /* ++ * See break_ksm(): even after handle_mm_fault() returned 0, we ++ * must start the lookup from the current address, because ++ * handle_mm_fault() may back out if there's any difficulty. ++ * ++ * VM_FAULT_SIGBUS and VM_FAULT_SIGSEGV are unexpected but ++ * maybe they could trigger in the future on concurrent ++ * truncation. In that case, the shared zeropage would be gone ++ * and we can simply retry and make progress. ++ */ ++ cond_resched(); ++ goto retry; ++ } ++ ++ return 0; ++} ++ ++static int __s390_disable_cow_sharing(struct mm_struct *mm) + { ++ int rc; ++ ++ if (!mm->context.allow_cow_sharing) ++ return 0; ++ ++ mm->context.allow_cow_sharing = 0; ++ ++ /* Replace all shared zeropages by anonymous pages. */ ++ rc = __s390_unshare_zeropages(mm); + /* + * Make sure to disable KSM (if enabled for the whole process or + * individual VMAs). Note that nothing currently hinders user space + * from re-enabling it. + */ +- return ksm_disable(current->mm); ++ if (!rc) ++ rc = ksm_disable(mm); ++ if (rc) ++ mm->context.allow_cow_sharing = 1; ++ return rc; ++} ++ ++/* ++ * Disable most COW-sharing of memory pages for the whole process: ++ * (1) Disable KSM and unmerge/unshare any KSM pages. ++ * (2) Disallow shared zeropages and unshare any zerpages that are mapped. ++ * ++ * Not that we currently don't bother with COW-shared pages that are shared ++ * with parent/child processes due to fork(). ++ */ ++int s390_disable_cow_sharing(void) ++{ ++ int rc; ++ ++ mmap_write_lock(current->mm); ++ rc = __s390_disable_cow_sharing(current->mm); ++ mmap_write_unlock(current->mm); ++ return rc; + } +-EXPORT_SYMBOL_GPL(gmap_mark_unmergeable); ++EXPORT_SYMBOL_GPL(s390_disable_cow_sharing); + + /* + * Enable storage key handling from now on and initialize the storage +@@ -2683,7 +2768,7 @@ int s390_enable_skey(void) + goto out_up; + + mm->context.uses_skeys = 1; +- rc = gmap_mark_unmergeable(); ++ rc = __s390_disable_cow_sharing(mm); + if (rc) { + mm->context.uses_skeys = 0; + goto out_up; +-- +2.43.0 + diff --git a/queue-6.8/samples-landlock-fix-incorrect-free-in-populate_rule.patch b/queue-6.8/samples-landlock-fix-incorrect-free-in-populate_rule.patch new file mode 100644 index 00000000000..657c80665fe --- /dev/null +++ b/queue-6.8/samples-landlock-fix-incorrect-free-in-populate_rule.patch @@ -0,0 +1,51 @@ +From 85f5d01f7a8be9654f5324fb656018230cb2dd87 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 17:56:25 +0800 +Subject: samples/landlock: Fix incorrect free in populate_ruleset_net +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Ivanov Mikhail + +[ Upstream commit 42212936d9d811c7cf6efc4804747a6c417aafd4 ] + +Pointer env_port_name changes after strsep(). Memory allocated via +strdup() will not be freed if landlock_add_rule() returns non-zero value. + +Fixes: 5e990dcef12e ("samples/landlock: Support TCP restrictions") +Signed-off-by: Ivanov Mikhail +Reviewed-by: Konstantin Meskhidze +Link: https://lore.kernel.org/r/20240326095625.3576164-1-ivanov.mikhail1@huawei-partners.com +Signed-off-by: Mickaël Salaün +Signed-off-by: Sasha Levin +--- + samples/landlock/sandboxer.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c +index 08596c0ef0707..e6c59f688573a 100644 +--- a/samples/landlock/sandboxer.c ++++ b/samples/landlock/sandboxer.c +@@ -151,7 +151,7 @@ static int populate_ruleset_net(const char *const env_var, const int ruleset_fd, + const __u64 allowed_access) + { + int ret = 1; +- char *env_port_name, *strport; ++ char *env_port_name, *env_port_name_next, *strport; + struct landlock_net_port_attr net_port = { + .allowed_access = allowed_access, + .port = 0, +@@ -163,7 +163,8 @@ static int populate_ruleset_net(const char *const env_var, const int ruleset_fd, + env_port_name = strdup(env_port_name); + unsetenv(env_var); + +- while ((strport = strsep(&env_port_name, ENV_DELIMITER))) { ++ env_port_name_next = env_port_name; ++ while ((strport = strsep(&env_port_name_next, ENV_DELIMITER))) { + net_port.port = atoi(strport); + if (landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_PORT, + &net_port, 0)) { +-- +2.43.0 + diff --git a/queue-6.8/sched-core-fix-incorrect-initialization-of-the-burst.patch b/queue-6.8/sched-core-fix-incorrect-initialization-of-the-burst.patch new file mode 100644 index 00000000000..77a178d64e1 --- /dev/null +++ b/queue-6.8/sched-core-fix-incorrect-initialization-of-the-burst.patch @@ -0,0 +1,71 @@ +From c18383d5f621f514dea6a5878d553fb384800aa3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 21:24:38 +0800 +Subject: sched/core: Fix incorrect initialization of the 'burst' parameter in + cpu_max_write() + +From: Cheng Yu + +[ Upstream commit 49217ea147df7647cb89161b805c797487783fc0 ] + +In the cgroup v2 CPU subsystem, assuming we have a +cgroup named 'test', and we set cpu.max and cpu.max.burst: + + # echo 1000000 > /sys/fs/cgroup/test/cpu.max + # echo 1000000 > /sys/fs/cgroup/test/cpu.max.burst + +then we check cpu.max and cpu.max.burst: + + # cat /sys/fs/cgroup/test/cpu.max + 1000000 100000 + # cat /sys/fs/cgroup/test/cpu.max.burst + 1000000 + +Next we set cpu.max again and check cpu.max and +cpu.max.burst: + + # echo 2000000 > /sys/fs/cgroup/test/cpu.max + # cat /sys/fs/cgroup/test/cpu.max + 2000000 100000 + + # cat /sys/fs/cgroup/test/cpu.max.burst + 1000 + +... we find that the cpu.max.burst value changed unexpectedly. + +In cpu_max_write(), the unit of the burst value returned +by tg_get_cfs_burst() is microseconds, while in cpu_max_write(), +the burst unit used for calculation should be nanoseconds, +which leads to the bug. + +To fix it, get the burst value directly from tg->cfs_bandwidth.burst. + +Fixes: f4183717b370 ("sched/fair: Introduce the burstable CFS controller") +Reported-by: Qixin Liao +Signed-off-by: Cheng Yu +Signed-off-by: Zhang Qiao +Signed-off-by: Ingo Molnar +Reviewed-by: Vincent Guittot +Tested-by: Vincent Guittot +Link: https://lore.kernel.org/r/20240424132438.514720-1-serein.chengyu@huawei.com +Signed-off-by: Sasha Levin +--- + kernel/sched/core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/kernel/sched/core.c b/kernel/sched/core.c +index 9116bcc903467..d3aef6283931e 100644 +--- a/kernel/sched/core.c ++++ b/kernel/sched/core.c +@@ -11381,7 +11381,7 @@ static ssize_t cpu_max_write(struct kernfs_open_file *of, + { + struct task_group *tg = css_tg(of_css(of)); + u64 period = tg_get_cfs_period(tg); +- u64 burst = tg_get_cfs_burst(tg); ++ u64 burst = tg->cfs_bandwidth.burst; + u64 quota; + int ret; + +-- +2.43.0 + diff --git a/queue-6.8/sched-fair-add-eas-checks-before-updating-root_domai.patch b/queue-6.8/sched-fair-add-eas-checks-before-updating-root_domai.patch new file mode 100644 index 00000000000..778d7bd0386 --- /dev/null +++ b/queue-6.8/sched-fair-add-eas-checks-before-updating-root_domai.patch @@ -0,0 +1,148 @@ +From ba2bbd9a790870e64ba072e54e314a23d19a2f19 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 14:27:23 +0530 +Subject: sched/fair: Add EAS checks before updating root_domain::overutilized + +From: Shrikanth Hegde + +[ Upstream commit be3a51e68f2f1b17250ce40d8872c7645b7a2991 ] + +root_domain::overutilized is only used for EAS(energy aware scheduler) +to decide whether to do load balance or not. It is not used if EAS +not possible. + +Currently enqueue_task_fair and task_tick_fair accesses, sometime updates +this field. In update_sd_lb_stats it is updated often. This causes cache +contention due to true sharing and burns a lot of cycles. ::overload and +::overutilized are part of the same cacheline. Updating it often invalidates +the cacheline. That causes access to ::overload to slow down due to +false sharing. Hence add EAS check before accessing/updating this field. +EAS check is optimized at compile time or it is a static branch. +Hence it shouldn't cost much. + +With the patch, both enqueue_task_fair and newidle_balance don't show +up as hot routines in perf profile. + + 6.8-rc4: + 7.18% swapper [kernel.vmlinux] [k] enqueue_task_fair + 6.78% s [kernel.vmlinux] [k] newidle_balance + + +patch: + 0.14% swapper [kernel.vmlinux] [k] enqueue_task_fair + 0.00% swapper [kernel.vmlinux] [k] newidle_balance + +While at it: trace_sched_overutilized_tp expect that second argument to +be bool. So do a int to bool conversion for that. + +Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator") +Signed-off-by: Shrikanth Hegde +Signed-off-by: Ingo Molnar +Reviewed-by: Qais Yousef +Reviewed-by: Srikar Dronamraju +Reviewed-by: Vincent Guittot +Link: https://lore.kernel.org/r/20240307085725.444486-2-sshegde@linux.ibm.com +Signed-off-by: Sasha Levin +--- + kernel/sched/fair.c | 53 +++++++++++++++++++++++++++++---------------- + 1 file changed, 34 insertions(+), 19 deletions(-) + +diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c +index aee5e7a70170c..a01269ed968a7 100644 +--- a/kernel/sched/fair.c ++++ b/kernel/sched/fair.c +@@ -6669,22 +6669,42 @@ static inline void hrtick_update(struct rq *rq) + #ifdef CONFIG_SMP + static inline bool cpu_overutilized(int cpu) + { +- unsigned long rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); +- unsigned long rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); ++ unsigned long rq_util_min, rq_util_max; ++ ++ if (!sched_energy_enabled()) ++ return false; ++ ++ rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); ++ rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); + + /* Return true only if the utilization doesn't fit CPU's capacity */ + return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu); + } + +-static inline void update_overutilized_status(struct rq *rq) ++static inline void set_rd_overutilized_status(struct root_domain *rd, ++ unsigned int status) + { +- if (!READ_ONCE(rq->rd->overutilized) && cpu_overutilized(rq->cpu)) { +- WRITE_ONCE(rq->rd->overutilized, SG_OVERUTILIZED); +- trace_sched_overutilized_tp(rq->rd, SG_OVERUTILIZED); +- } ++ if (!sched_energy_enabled()) ++ return; ++ ++ WRITE_ONCE(rd->overutilized, status); ++ trace_sched_overutilized_tp(rd, !!status); ++} ++ ++static inline void check_update_overutilized_status(struct rq *rq) ++{ ++ /* ++ * overutilized field is used for load balancing decisions only ++ * if energy aware scheduler is being used ++ */ ++ if (!sched_energy_enabled()) ++ return; ++ ++ if (!READ_ONCE(rq->rd->overutilized) && cpu_overutilized(rq->cpu)) ++ set_rd_overutilized_status(rq->rd, SG_OVERUTILIZED); + } + #else +-static inline void update_overutilized_status(struct rq *rq) { } ++static inline void check_update_overutilized_status(struct rq *rq) { } + #endif + + /* Runqueue only has SCHED_IDLE tasks enqueued */ +@@ -6785,7 +6805,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags) + * and the following generally works well enough in practice. + */ + if (!task_new) +- update_overutilized_status(rq); ++ check_update_overutilized_status(rq); + + enqueue_throttle: + assert_list_leaf_cfs_rq(rq); +@@ -10621,19 +10641,14 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd + env->fbq_type = fbq_classify_group(&sds->busiest_stat); + + if (!env->sd->parent) { +- struct root_domain *rd = env->dst_rq->rd; +- + /* update overload indicator if we are at root domain */ +- WRITE_ONCE(rd->overload, sg_status & SG_OVERLOAD); ++ WRITE_ONCE(env->dst_rq->rd->overload, sg_status & SG_OVERLOAD); + + /* Update over-utilization (tipping point, U >= 0) indicator */ +- WRITE_ONCE(rd->overutilized, sg_status & SG_OVERUTILIZED); +- trace_sched_overutilized_tp(rd, sg_status & SG_OVERUTILIZED); ++ set_rd_overutilized_status(env->dst_rq->rd, ++ sg_status & SG_OVERUTILIZED); + } else if (sg_status & SG_OVERUTILIZED) { +- struct root_domain *rd = env->dst_rq->rd; +- +- WRITE_ONCE(rd->overutilized, SG_OVERUTILIZED); +- trace_sched_overutilized_tp(rd, SG_OVERUTILIZED); ++ set_rd_overutilized_status(env->dst_rq->rd, SG_OVERUTILIZED); + } + + update_idle_cpu_scan(env, sum_util); +@@ -12639,7 +12654,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued) + task_tick_numa(rq, curr); + + update_misfit_status(curr, rq); +- update_overutilized_status(task_rq(curr)); ++ check_update_overutilized_status(task_rq(curr)); + + task_tick_core(rq, curr); + } +-- +2.43.0 + diff --git a/queue-6.8/sched-fair-allow-disabling-sched_balance_newidle-wit.patch b/queue-6.8/sched-fair-allow-disabling-sched_balance_newidle-wit.patch new file mode 100644 index 00000000000..138d097c472 --- /dev/null +++ b/queue-6.8/sched-fair-allow-disabling-sched_balance_newidle-wit.patch @@ -0,0 +1,64 @@ +From b8d37e1981c3ad96f9b367fd53b7e8eb26f1fcc6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 18:05:23 +0300 +Subject: sched/fair: Allow disabling sched_balance_newidle with + sched_relax_domain_level + +From: Vitalii Bursov + +[ Upstream commit a1fd0b9d751f840df23ef0e75b691fc00cfd4743 ] + +Change relax_domain_level checks so that it would be possible +to include or exclude all domains from newidle balancing. + +This matches the behavior described in the documentation: + + -1 no request. use system default or follow request of others. + 0 no search. + 1 search siblings (hyperthreads in a core). + +"2" enables levels 0 and 1, level_max excludes the last (level_max) +level, and level_max+1 includes all levels. + +Fixes: 1d3504fcf560 ("sched, cpuset: customize sched domains, core") +Signed-off-by: Vitalii Bursov +Signed-off-by: Ingo Molnar +Tested-by: Dietmar Eggemann +Reviewed-by: Vincent Guittot +Reviewed-by: Valentin Schneider +Link: https://lore.kernel.org/r/bd6de28e80073c79466ec6401cdeae78f0d4423d.1714488502.git.vitaly@bursov.com +Signed-off-by: Sasha Levin +--- + kernel/cgroup/cpuset.c | 2 +- + kernel/sched/topology.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c +index 927bef3a598ad..6d6e540bacbfb 100644 +--- a/kernel/cgroup/cpuset.c ++++ b/kernel/cgroup/cpuset.c +@@ -2948,7 +2948,7 @@ bool current_cpuset_is_being_rebound(void) + static int update_relax_domain_level(struct cpuset *cs, s64 val) + { + #ifdef CONFIG_SMP +- if (val < -1 || val >= sched_domain_level_max) ++ if (val < -1 || val > sched_domain_level_max + 1) + return -EINVAL; + #endif + +diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c +index 10d1391e74161..4fdab14953fc9 100644 +--- a/kernel/sched/topology.c ++++ b/kernel/sched/topology.c +@@ -1468,7 +1468,7 @@ static void set_domain_attribute(struct sched_domain *sd, + } else + request = attr->relax_domain_level; + +- if (sd->level > request) { ++ if (sd->level >= request) { + /* Turn off idle balance on this domain: */ + sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE); + } +-- +2.43.0 + diff --git a/queue-6.8/sched-isolation-fix-boot-crash-when-maxcpus-first-ho.patch b/queue-6.8/sched-isolation-fix-boot-crash-when-maxcpus-first-ho.patch new file mode 100644 index 00000000000..2636e09612f --- /dev/null +++ b/queue-6.8/sched-isolation-fix-boot-crash-when-maxcpus-first-ho.patch @@ -0,0 +1,78 @@ +From 658b604b169318055c02a9dc3f4d343414e80f6b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 13 Apr 2024 16:17:46 +0200 +Subject: sched/isolation: Fix boot crash when maxcpus < first housekeeping CPU + +From: Oleg Nesterov + +[ Upstream commit 257bf89d84121280904800acd25cc2c444c717ae ] + +housekeeping_setup() checks cpumask_intersects(present, online) to ensure +that the kernel will have at least one housekeeping CPU after smp_init(), +but this doesn't work if the maxcpus= kernel parameter limits the number of +processors available after bootup. + +For example, a kernel with "maxcpus=2 nohz_full=0-2" parameters crashes at +boot time on a virtual machine with 4 CPUs. + +Change housekeeping_setup() to use cpumask_first_and() and check that the +returned CPU number is valid and less than setup_max_cpus. + +Another corner case is "nohz_full=0" on a machine with a single CPU or with +the maxcpus=1 kernel argument. In this case non_housekeeping_mask is empty +and tick_nohz_full_setup() makes no sense. And indeed, the kernel hits the +WARN_ON(tick_nohz_full_running) in tick_sched_do_timer(). + +And how should the kernel interpret the "nohz_full=" parameter? It should +be silently ignored, but currently cpulist_parse() happily returns the +empty cpumask and this leads to the same problem. + +Change housekeeping_setup() to check cpumask_empty(non_housekeeping_mask) +and do nothing in this case. + +Signed-off-by: Oleg Nesterov +Signed-off-by: Thomas Gleixner +Signed-off-by: Ingo Molnar +Reviewed-by: Phil Auld +Acked-by: Frederic Weisbecker +Link: https://lore.kernel.org/r/20240413141746.GA10008@redhat.com +Signed-off-by: Sasha Levin +--- + kernel/sched/isolation.c | 7 ++++++- + 1 file changed, 6 insertions(+), 1 deletion(-) + +diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c +index 373d42c707bc5..82e2f7fc7c267 100644 +--- a/kernel/sched/isolation.c ++++ b/kernel/sched/isolation.c +@@ -109,6 +109,7 @@ static void __init housekeeping_setup_type(enum hk_type type, + static int __init housekeeping_setup(char *str, unsigned long flags) + { + cpumask_var_t non_housekeeping_mask, housekeeping_staging; ++ unsigned int first_cpu; + int err = 0; + + if ((flags & HK_FLAG_TICK) && !(housekeeping.flags & HK_FLAG_TICK)) { +@@ -129,7 +130,8 @@ static int __init housekeeping_setup(char *str, unsigned long flags) + cpumask_andnot(housekeeping_staging, + cpu_possible_mask, non_housekeeping_mask); + +- if (!cpumask_intersects(cpu_present_mask, housekeeping_staging)) { ++ first_cpu = cpumask_first_and(cpu_present_mask, housekeeping_staging); ++ if (first_cpu >= nr_cpu_ids || first_cpu >= setup_max_cpus) { + __cpumask_set_cpu(smp_processor_id(), housekeeping_staging); + __cpumask_clear_cpu(smp_processor_id(), non_housekeeping_mask); + if (!housekeeping.flags) { +@@ -138,6 +140,9 @@ static int __init housekeeping_setup(char *str, unsigned long flags) + } + } + ++ if (cpumask_empty(non_housekeeping_mask)) ++ goto free_housekeeping_staging; ++ + if (!housekeeping.flags) { + /* First setup call ("nohz_full=" or "isolcpus=") */ + enum hk_type type; +-- +2.43.0 + diff --git a/queue-6.8/scsi-bfa-ensure-the-copied-buf-is-nul-terminated.patch b/queue-6.8/scsi-bfa-ensure-the-copied-buf-is-nul-terminated.patch new file mode 100644 index 00000000000..510bbd4f900 --- /dev/null +++ b/queue-6.8/scsi-bfa-ensure-the-copied-buf-is-nul-terminated.patch @@ -0,0 +1,49 @@ +From a68da71686017826fe629963122da35b3cd43d4c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 21:44:20 +0700 +Subject: scsi: bfa: Ensure the copied buf is NUL terminated + +From: Bui Quang Minh + +[ Upstream commit 13d0cecb4626fae67c00c84d3c7851f6b62f7df3 ] + +Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from +userspace to that buffer. Later, we use sscanf on this buffer but we don't +ensure that the string is terminated inside the buffer, this can lead to +OOB read when using sscanf. Fix this issue by using memdup_user_nul instead +of memdup_user. + +Fixes: 9f30b674759b ("bfa: replace 2 kzalloc/copy_from_user by memdup_user") +Signed-off-by: Bui Quang Minh +Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-3-f1f1b53a10f4@gmail.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/bfa/bfad_debugfs.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c +index 52db147d9979d..f6dd077d47c9a 100644 +--- a/drivers/scsi/bfa/bfad_debugfs.c ++++ b/drivers/scsi/bfa/bfad_debugfs.c +@@ -250,7 +250,7 @@ bfad_debugfs_write_regrd(struct file *file, const char __user *buf, + unsigned long flags; + void *kern_buf; + +- kern_buf = memdup_user(buf, nbytes); ++ kern_buf = memdup_user_nul(buf, nbytes); + if (IS_ERR(kern_buf)) + return PTR_ERR(kern_buf); + +@@ -317,7 +317,7 @@ bfad_debugfs_write_regwr(struct file *file, const char __user *buf, + unsigned long flags; + void *kern_buf; + +- kern_buf = memdup_user(buf, nbytes); ++ kern_buf = memdup_user_nul(buf, nbytes); + if (IS_ERR(kern_buf)) + return PTR_ERR(kern_buf); + +-- +2.43.0 + diff --git a/queue-6.8/scsi-hpsa-fix-allocation-size-for-scsi_host-private-.patch b/queue-6.8/scsi-hpsa-fix-allocation-size-for-scsi_host-private-.patch new file mode 100644 index 00000000000..0728dc58e57 --- /dev/null +++ b/queue-6.8/scsi-hpsa-fix-allocation-size-for-scsi_host-private-.patch @@ -0,0 +1,41 @@ +From 395296beccfc459f535c7be0d7518c11f1833974 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 12 Mar 2024 20:04:47 +0300 +Subject: scsi: hpsa: Fix allocation size for Scsi_Host private data + +From: Yuri Karpov + +[ Upstream commit 504e2bed5d50610c1836046c0c195b0a6dba9c72 ] + +struct Scsi_Host private data contains pointer to struct ctlr_info. + +Restore allocation of only 8 bytes to store pointer in struct Scsi_Host +private data area. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: bbbd25499100 ("scsi: hpsa: Fix allocation size for scsi_host_alloc()") +Signed-off-by: Yuri Karpov +Link: https://lore.kernel.org/r/20240312170447.743709-1-YKarpov@ispras.ru +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/hpsa.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c +index af18d20f30794..49c57a9c110b5 100644 +--- a/drivers/scsi/hpsa.c ++++ b/drivers/scsi/hpsa.c +@@ -5850,7 +5850,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h) + { + struct Scsi_Host *sh; + +- sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info)); ++ sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info *)); + if (sh == NULL) { + dev_err(&h->pdev->dev, "scsi_host_alloc failed\n"); + return -ENOMEM; +-- +2.43.0 + diff --git a/queue-6.8/scsi-libsas-fix-the-failure-of-adding-phy-with-zero-.patch b/queue-6.8/scsi-libsas-fix-the-failure-of-adding-phy-with-zero-.patch new file mode 100644 index 00000000000..ab77328aa37 --- /dev/null +++ b/queue-6.8/scsi-libsas-fix-the-failure-of-adding-phy-with-zero-.patch @@ -0,0 +1,55 @@ +From a5c14d4a4359af9946d6909accd70e5782a046ec Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 12 Mar 2024 14:11:03 +0000 +Subject: scsi: libsas: Fix the failure of adding phy with zero-address to port + +From: Xingui Yang + +[ Upstream commit 06036a0a5db34642c5dbe22021a767141f010b7a ] + +As of commit 7d1d86518118 ("[SCSI] libsas: fix false positive 'device +attached' conditions"), reset the phy->entacted_sas_addr address to a +zero-address when the link rate is less than 1.5G. + +Currently we find that when a new device is attached, and the link rate is +less than 1.5G, but the device type is not NO_DEVICE, for example: the link +rate is SAS_PHY_RESET_IN_PROGRESS and the device type is stp. After setting +the phy->entacted_sas_addr address to the zero address, the port will +continue to be created for the phy with the zero-address, and other phys +with the zero-address will be tried to be added to the new port: + +[562240.051197] sas: ex 500e004aaaaaaa1f phy19:U:0 attached: 0000000000000000 (no device) +// phy19 is deleted but still on the parent port's phy_list +[562240.062536] sas: ex 500e004aaaaaaa1f phy0 new device attached +[562240.062616] sas: ex 500e004aaaaaaa1f phy00:U:5 attached: 0000000000000000 (stp) +[562240.062680] port-7:7:0: trying to add phy phy-7:7:19 fails: it's already part of another port + +Therefore, it should be the same as sas_get_phy_attached_dev(). Only when +device_type is SAS_PHY_UNUSED, sas_address is set to the 0 address. + +Fixes: 7d1d86518118 ("[SCSI] libsas: fix false positive 'device attached' conditions") +Signed-off-by: Xingui Yang +Link: https://lore.kernel.org/r/20240312141103.31358-5-yangxingui@huawei.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/libsas/sas_expander.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c +index f6e6db8b8aba9..e97f4e01a865a 100644 +--- a/drivers/scsi/libsas/sas_expander.c ++++ b/drivers/scsi/libsas/sas_expander.c +@@ -239,8 +239,7 @@ static void sas_set_ex_phy(struct domain_device *dev, int phy_id, + /* help some expanders that fail to zero sas_address in the 'no + * device' case + */ +- if (phy->attached_dev_type == SAS_PHY_UNUSED || +- phy->linkrate < SAS_LINK_RATE_1_5_GBPS) ++ if (phy->attached_dev_type == SAS_PHY_UNUSED) + memset(phy->attached_sas_addr, 0, SAS_ADDR_SIZE); + else + memcpy(phy->attached_sas_addr, dr->attached_sas_addr, SAS_ADDR_SIZE); +-- +2.43.0 + diff --git a/queue-6.8/scsi-qedf-ensure-the-copied-buf-is-nul-terminated.patch b/queue-6.8/scsi-qedf-ensure-the-copied-buf-is-nul-terminated.patch new file mode 100644 index 00000000000..e3f0053556a --- /dev/null +++ b/queue-6.8/scsi-qedf-ensure-the-copied-buf-is-nul-terminated.patch @@ -0,0 +1,40 @@ +From 866ecbd9579641518dbeee704acde66a70970291 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 21:44:21 +0700 +Subject: scsi: qedf: Ensure the copied buf is NUL terminated + +From: Bui Quang Minh + +[ Upstream commit d0184a375ee797eb657d74861ba0935b6e405c62 ] + +Currently, we allocate a count-sized kernel buffer and copy count from +userspace to that buffer. Later, we use kstrtouint on this buffer but we +don't ensure that the string is terminated inside the buffer, this can +lead to OOB read when using kstrtouint. Fix this issue by using +memdup_user_nul instead of memdup_user. + +Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.") +Signed-off-by: Bui Quang Minh +Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-4-f1f1b53a10f4@gmail.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/qedf/qedf_debugfs.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/scsi/qedf/qedf_debugfs.c b/drivers/scsi/qedf/qedf_debugfs.c +index 451fd236bfd05..96174353e3898 100644 +--- a/drivers/scsi/qedf/qedf_debugfs.c ++++ b/drivers/scsi/qedf/qedf_debugfs.c +@@ -170,7 +170,7 @@ qedf_dbg_debug_cmd_write(struct file *filp, const char __user *buffer, + if (!count || *ppos) + return 0; + +- kern_buf = memdup_user(buffer, count); ++ kern_buf = memdup_user_nul(buffer, count); + if (IS_ERR(kern_buf)) + return PTR_ERR(kern_buf); + +-- +2.43.0 + diff --git a/queue-6.8/scsi-qla2xxx-fix-debugfs-output-for-fw_resource_coun.patch b/queue-6.8/scsi-qla2xxx-fix-debugfs-output-for-fw_resource_coun.patch new file mode 100644 index 00000000000..0764aee3e02 --- /dev/null +++ b/queue-6.8/scsi-qla2xxx-fix-debugfs-output-for-fw_resource_coun.patch @@ -0,0 +1,43 @@ +From f749be0df270821969bf1bfcb89e5a70910f6984 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 02:00:56 +0000 +Subject: scsi: qla2xxx: Fix debugfs output for fw_resource_count + +From: Himanshu Madhani + +[ Upstream commit 998d09c5ef6183bd8137d1a892ba255b15978bb4 ] + +DebugFS output for fw_resource_count shows: + +estimate exchange used[0] high water limit [1945] n estimate iocb2 used [0] high water limit [5141] + estimate exchange2 used[0] high water limit [1945] + +Which shows incorrect display due to missing newline in seq_print(). + +[mkp: fix checkpatch warning about space before newline] + +Fixes: 5f63a163ed2f ("scsi: qla2xxx: Fix exchange oversubscription for management commands") +Signed-off-by: Himanshu Madhani +Link: https://lore.kernel.org/r/20240426020056.3639406-1-himanshu.madhani@oracle.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/qla2xxx/qla_dfs.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c +index 55ff3d7482b3e..a1545dad0c0ce 100644 +--- a/drivers/scsi/qla2xxx/qla_dfs.c ++++ b/drivers/scsi/qla2xxx/qla_dfs.c +@@ -274,7 +274,7 @@ qla_dfs_fw_resource_cnt_show(struct seq_file *s, void *unused) + seq_printf(s, "Driver: estimate iocb used [%d] high water limit [%d]\n", + iocbs_used, ha->base_qpair->fwres.iocbs_limit); + +- seq_printf(s, "estimate exchange used[%d] high water limit [%d] n", ++ seq_printf(s, "estimate exchange used[%d] high water limit [%d]\n", + exch_used, ha->base_qpair->fwres.exch_limit); + + if (ql2xenforce_iocb_limit == 2) { +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-cdns-pltfrm-perform-read-back-after-writing.patch b/queue-6.8/scsi-ufs-cdns-pltfrm-perform-read-back-after-writing.patch new file mode 100644 index 00000000000..d938b8a383b --- /dev/null +++ b/queue-6.8/scsi-ufs-cdns-pltfrm-perform-read-back-after-writing.patch @@ -0,0 +1,50 @@ +From 7f9d2d7a6fddfb46206fe39d9195cf8ddc145d02 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:48 -0500 +Subject: scsi: ufs: cdns-pltfrm: Perform read back after writing HCLKDIV + +From: Andrew Halaney + +[ Upstream commit b715c55daf598aac8fa339048e4ca8a0916b332e ] + +Currently, HCLKDIV is written to and then completed with an mb(). + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring this +bit has taken effect on the device is to perform a read back to force it to +make it all the way to the device. This is documented in device-io.rst and +a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bit hits the device. Because the mb()'s purpose +wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Fixes: d90996dae8e4 ("scsi: ufs: Add UFS platform driver for Cadence UFS") +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-6-181252004586@redhat.com +Reviewed-by: Bart Van Assche +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/host/cdns-pltfrm.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/host/cdns-pltfrm.c b/drivers/ufs/host/cdns-pltfrm.c +index bb30267da4711..66811d8d1929c 100644 +--- a/drivers/ufs/host/cdns-pltfrm.c ++++ b/drivers/ufs/host/cdns-pltfrm.c +@@ -136,7 +136,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba) + * Make sure the register was updated, + * UniPro layer will not work with an incorrect value. + */ +- mb(); ++ ufshcd_readl(hba, CDNS_UFS_REG_HCLKDIV); + + return 0; + } +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-core-mcq-fix-ufshcd_mcq_sqe_search.patch b/queue-6.8/scsi-ufs-core-mcq-fix-ufshcd_mcq_sqe_search.patch new file mode 100644 index 00000000000..84365d04b81 --- /dev/null +++ b/queue-6.8/scsi-ufs-core-mcq-fix-ufshcd_mcq_sqe_search.patch @@ -0,0 +1,50 @@ +From 2abae41705490c60dade4c159dd44639f5b5bace Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 17:07:45 -0700 +Subject: scsi: ufs: core: mcq: Fix ufshcd_mcq_sqe_search() + +From: Bart Van Assche + +[ Upstream commit 3c5d0dce8ce0a2781ac306b9ad1492b005ecbab5 ] + +Fix the calculation of the utrd pointer. This patch addresses the following +Coverity complaint: + +CID 1538170: (#1 of 1): Extra sizeof expression (SIZEOF_MISMATCH) +suspicious_pointer_arithmetic: Adding sq_head_slot * 32UL /* sizeof (struct +utp_transfer_req_desc) */ to pointer hwq->sqe_base_addr of type struct +utp_transfer_req_desc * is suspicious because adding an integral value to +this pointer automatically scales that value by the size, 32 bytes, of the +pointed-to type, struct utp_transfer_req_desc. Most likely, the +multiplication by sizeof (struct utp_transfer_req_desc) in this expression +is extraneous and should be eliminated. + +Cc: Bao D. Nguyen +Cc: Stanley Chu +Cc: Can Guo +Fixes: 8d7290348992 ("scsi: ufs: mcq: Add supporting functions for MCQ abort") +Signed-off-by: Bart Van Assche +Link: https://lore.kernel.org/r/20240410000751.1047758-1-bvanassche@acm.org +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/core/ufs-mcq.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c +index c873fd8239427..7ae3096814282 100644 +--- a/drivers/ufs/core/ufs-mcq.c ++++ b/drivers/ufs/core/ufs-mcq.c +@@ -597,8 +597,7 @@ static bool ufshcd_mcq_sqe_search(struct ufs_hba *hba, + addr = le64_to_cpu(cmd_desc_base_addr) & CQE_UCD_BA; + + while (sq_head_slot != hwq->sq_tail_slot) { +- utrd = hwq->sqe_base_addr + +- sq_head_slot * sizeof(struct utp_transfer_req_desc); ++ utrd = hwq->sqe_base_addr + sq_head_slot; + match = le64_to_cpu(utrd->command_desc_base_addr) & CQE_UCD_BA; + if (addr == match) { + ufshcd_mcq_nullify_sqe(utrd); +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-inte.patch b/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-inte.patch new file mode 100644 index 00000000000..8dc3be285ba --- /dev/null +++ b/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-inte.patch @@ -0,0 +1,53 @@ +From 316b87748b5d83fb46b880918fa9af37fddd64c1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:50 -0500 +Subject: scsi: ufs: core: Perform read back after disabling interrupts + +From: Andrew Halaney + +[ Upstream commit e4a628877119bd40164a651d20321247b6f94a8b ] + +Currently, interrupts are cleared and disabled prior to registering the +interrupt. An mb() is used to complete the clear/disable writes before the +interrupt is registered. + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring these +bits have taken effect on the device is to perform a read back to force it +to make it all the way to the device. This is documented in device-io.rst +and a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure these bits hit the device. Because the mb()'s +purpose wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Fixes: 199ef13cac7d ("scsi: ufs: avoid spurious UFS host controller interrupts") +Reviewed-by: Manivannan Sadhasivam +Reviewed-by: Bart Van Assche +Reviewed-by: Can Guo +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-8-181252004586@redhat.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/core/ufshcd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c +index 16dc63632e720..33068bbfa7a31 100644 +--- a/drivers/ufs/core/ufshcd.c ++++ b/drivers/ufs/core/ufshcd.c +@@ -10570,7 +10570,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) + * Make sure that UFS interrupts are disabled and any pending interrupt + * status is cleared before registering UFS interrupt handler. + */ +- mb(); ++ ufshcd_readl(hba, REG_INTERRUPT_ENABLE); + + /* IRQ registration */ + err = devm_request_irq(dev, irq, ufshcd_intr, IRQF_SHARED, UFSHCD, hba); +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-uic_.patch b/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-uic_.patch new file mode 100644 index 00000000000..32dd1bc0970 --- /dev/null +++ b/queue-6.8/scsi-ufs-core-perform-read-back-after-disabling-uic_.patch @@ -0,0 +1,52 @@ +From 73b94cd165caa0f34b3a3843fd781f23bfa639d4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:51 -0500 +Subject: scsi: ufs: core: Perform read back after disabling UIC_COMMAND_COMPL + +From: Andrew Halaney + +[ Upstream commit 4bf3855497b60765ca03b983d064b25e99b97657 ] + +Currently, the UIC_COMMAND_COMPL interrupt is disabled and a wmb() is used +to complete the register write before any following writes. + +wmb() ensures the writes complete in that order, but completion doesn't +mean that it isn't stored in a buffer somewhere. The recommendation for +ensuring this bit has taken effect on the device is to perform a read back +to force it to make it all the way to the device. This is documented in +device-io.rst and a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bit hits the device. Because the wmb()'s +purpose wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Fixes: d75f7fe495cf ("scsi: ufs: reduce the interrupts for power mode change requests") +Reviewed-by: Bart Van Assche +Reviewed-by: Can Guo +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-9-181252004586@redhat.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/core/ufshcd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c +index 33068bbfa7a31..24b54aa094812 100644 +--- a/drivers/ufs/core/ufshcd.c ++++ b/drivers/ufs/core/ufshcd.c +@@ -4244,7 +4244,7 @@ static int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command *cmd) + * Make sure UIC command completion interrupt is disabled before + * issuing UIC command. + */ +- wmb(); ++ ufshcd_readl(hba, REG_INTERRUPT_ENABLE); + reenable_intr = true; + } + spin_unlock_irqrestore(hba->host->host_lock, flags); +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-core-perform-read-back-after-writing-utp_ta.patch b/queue-6.8/scsi-ufs-core-perform-read-back-after-writing-utp_ta.patch new file mode 100644 index 00000000000..7535e108686 --- /dev/null +++ b/queue-6.8/scsi-ufs-core-perform-read-back-after-writing-utp_ta.patch @@ -0,0 +1,53 @@ +From 205d28978907785d6bbbbf7eb0bf6ab3b38764ea Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:49 -0500 +Subject: scsi: ufs: core: Perform read back after writing + UTP_TASK_REQ_LIST_BASE_H + +From: Andrew Halaney + +[ Upstream commit 408e28086f1c7a6423efc79926a43d7001902fae ] + +Currently, the UTP_TASK_REQ_LIST_BASE_L/UTP_TASK_REQ_LIST_BASE_H regs are +written to and then completed with an mb(). + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring these +bits have taken effect on the device is to perform a read back to force it +to make it all the way to the device. This is documented in device-io.rst +and a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bits hit the device. Because the mb()'s purpose +wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Fixes: 88441a8d355d ("scsi: ufs: core: Add hibernation callbacks") +Reviewed-by: Manivannan Sadhasivam +Reviewed-by: Bart Van Assche +Reviewed-by: Can Guo +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-7-181252004586@redhat.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/core/ufshcd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c +index 4a07a18cf835d..16dc63632e720 100644 +--- a/drivers/ufs/core/ufshcd.c ++++ b/drivers/ufs/core/ufshcd.c +@@ -10353,7 +10353,7 @@ int ufshcd_system_restore(struct device *dev) + * are updated with the latest queue addresses. Only after + * updating these addresses, we can queue the new commands. + */ +- mb(); ++ ufshcd_readl(hba, REG_UTP_TASK_REQ_LIST_BASE_H); + + /* Resuming from hibernate, assume that link was OFF */ + ufshcd_set_link_off(hba); +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-cgc-en.patch b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-cgc-en.patch new file mode 100644 index 00000000000..395dd7d4ca1 --- /dev/null +++ b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-cgc-en.patch @@ -0,0 +1,51 @@ +From 159be7fb7a851cea6029cfef4e2723046d114775 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:47 -0500 +Subject: scsi: ufs: qcom: Perform read back after writing CGC enable + +From: Andrew Halaney + +[ Upstream commit d9488511b3ac7eb48a91bc5eded7027525525e03 ] + +Currently, the CGC enable bit is written and then an mb() is used to ensure +that completes before continuing. + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring this +bit has taken effect on the device is to perform a read back to force it to +make it all the way to the device. This is documented in device-io.rst and +a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bit hits the device. Because the mb()'s purpose +wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Reviewed-by: Manivannan Sadhasivam +Reviewed-by: Can Guo +Fixes: 81c0fc51b7a7 ("ufs-qcom: add support for Qualcomm Technologies Inc platforms") +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-5-181252004586@redhat.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/host/ufs-qcom.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c +index cef410f31f449..e5a4bf1c553bb 100644 +--- a/drivers/ufs/host/ufs-qcom.c ++++ b/drivers/ufs/host/ufs-qcom.c +@@ -412,7 +412,7 @@ static void ufs_qcom_enable_hw_clk_gating(struct ufs_hba *hba) + REG_UFS_CFG2); + + /* Ensure that HW clock gating is enabled before next operations */ +- mb(); ++ ufshcd_readl(hba, REG_UFS_CFG2); + } + + static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reg_uf.patch b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reg_uf.patch new file mode 100644 index 00000000000..f4d7e2b9932 --- /dev/null +++ b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reg_uf.patch @@ -0,0 +1,51 @@ +From b8e6c4b71e83ce399dced4824c03f020405b8266 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:44 -0500 +Subject: scsi: ufs: qcom: Perform read back after writing REG_UFS_SYS1CLK_1US + +From: Andrew Halaney + +[ Upstream commit a862fafa263aea0f427d51aca6ff7fd9eeaaa8bd ] + +Currently after writing to REG_UFS_SYS1CLK_1US a mb() is used to ensure +that write has gone through to the device. + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring this +bit has taken effect on the device is to perform a read back to force it to +make it all the way to the device. This is documented in device-io.rst and +a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bit hits the device. Because the mb()'s purpose +wasn't to add extra ordering (on top of the ordering guaranteed by +writel()/readl()), it can safely be removed. + +Fixes: f06fcc7155dc ("scsi: ufs-qcom: add QUniPro hardware support and power optimizations") +Reviewed-by: Can Guo +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-2-181252004586@redhat.com +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/host/ufs-qcom.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c +index bcbcf758925be..8aa55ed45d8e0 100644 +--- a/drivers/ufs/host/ufs-qcom.c ++++ b/drivers/ufs/host/ufs-qcom.c +@@ -507,7 +507,7 @@ static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear, + * make sure above write gets applied before we return from + * this function. + */ +- mb(); ++ ufshcd_readl(hba, REG_UFS_SYS1CLK_1US); + } + + return 0; +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reset-.patch b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reset-.patch new file mode 100644 index 00000000000..57a35676c34 --- /dev/null +++ b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-reset-.patch @@ -0,0 +1,71 @@ +From 0f77b450b3f9609356a802dae437c0db33c2d519 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:43 -0500 +Subject: scsi: ufs: qcom: Perform read back after writing reset bit + +From: Andrew Halaney + +[ Upstream commit c4d28e06b0c94636f6e35d003fa9ebac0a94e1ae ] + +Currently, the reset bit for the UFS provided reset controller (used by its +phy) is written to, and then a mb() happens to try and ensure that hit the +device. Immediately afterwards a usleep_range() occurs. + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring this +bit has taken effect on the device is to perform a read back to force it to +make it all the way to the device. This is documented in device-io.rst and +a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +Let's do that to ensure the bit hits the device. By doing so and +guaranteeing the ordering against the immediately following usleep_range(), +the mb() can safely be removed. + +Fixes: 81c0fc51b7a7 ("ufs-qcom: add support for Qualcomm Technologies Inc platforms") +Reviewed-by: Manivannan Sadhasivam +Reviewed-by: Can Guo +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-1-181252004586@redhat.com +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/host/ufs-qcom.h | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h +index 9dd9a391ebb76..b9de170983c9e 100644 +--- a/drivers/ufs/host/ufs-qcom.h ++++ b/drivers/ufs/host/ufs-qcom.h +@@ -151,10 +151,10 @@ static inline void ufs_qcom_assert_reset(struct ufs_hba *hba) + ufshcd_rmwl(hba, UFS_PHY_SOFT_RESET, UFS_PHY_SOFT_RESET, REG_UFS_CFG1); + + /* +- * Make sure assertion of ufs phy reset is written to +- * register before returning ++ * Dummy read to ensure the write takes effect before doing any sort ++ * of delay + */ +- mb(); ++ ufshcd_readl(hba, REG_UFS_CFG1); + } + + static inline void ufs_qcom_deassert_reset(struct ufs_hba *hba) +@@ -162,10 +162,10 @@ static inline void ufs_qcom_deassert_reset(struct ufs_hba *hba) + ufshcd_rmwl(hba, UFS_PHY_SOFT_RESET, 0, REG_UFS_CFG1); + + /* +- * Make sure de-assertion of ufs phy reset is written to +- * register before returning ++ * Dummy read to ensure the write takes effect before doing any sort ++ * of delay + */ +- mb(); ++ ufshcd_readl(hba, REG_UFS_CFG1); + } + + /* Host controller hardware version: major.minor.step */ +-- +2.43.0 + diff --git a/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-unipro.patch b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-unipro.patch new file mode 100644 index 00000000000..b536bba9357 --- /dev/null +++ b/queue-6.8/scsi-ufs-qcom-perform-read-back-after-writing-unipro.patch @@ -0,0 +1,52 @@ +From 185f8a2aef9ff33bf89e3362eac261d7fe4955a7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 15:46:46 -0500 +Subject: scsi: ufs: qcom: Perform read back after writing unipro mode + +From: Andrew Halaney + +[ Upstream commit 823150ecf04f958213cf3bf162187cd1a91c885c ] + +Currently, the QUNIPRO_SEL bit is written to and then an mb() is used to +ensure that completes before continuing. + +mb() ensures that the write completes, but completion doesn't mean that it +isn't stored in a buffer somewhere. The recommendation for ensuring this +bit has taken effect on the device is to perform a read back to force it to +make it all the way to the device. This is documented in device-io.rst and +a talk by Will Deacon on this can be seen over here: + + https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 + +But, there's really no reason to even ensure completion before +continuing. The only requirement here is that this write is ordered to this +endpoint (which readl()/writel() guarantees already). For that reason the +mb() can be dropped altogether without anything forcing completion. + +Fixes: f06fcc7155dc ("scsi: ufs-qcom: add QUniPro hardware support and power optimizations") +Signed-off-by: Andrew Halaney +Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-4-181252004586@redhat.com +Reviewed-by: Manivannan Sadhasivam +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/ufs/host/ufs-qcom.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c +index 8aa55ed45d8e0..cef410f31f449 100644 +--- a/drivers/ufs/host/ufs-qcom.c ++++ b/drivers/ufs/host/ufs-qcom.c +@@ -284,9 +284,6 @@ static void ufs_qcom_select_unipro_mode(struct ufs_qcom_host *host) + + if (host->hw_ver.major >= 0x05) + ufshcd_rmwl(host->hba, QUNIPRO_G4_SEL, 0, REG_UFS_CFG0); +- +- /* make sure above configuration is applied before we return */ +- mb(); + } + + /* +-- +2.43.0 + diff --git a/queue-6.8/selftests-binderfs-use-the-makefile-s-rules-not-make.patch b/queue-6.8/selftests-binderfs-use-the-makefile-s-rules-not-make.patch new file mode 100644 index 00000000000..b3528e2ba9c --- /dev/null +++ b/queue-6.8/selftests-binderfs-use-the-makefile-s-rules-not-make.patch @@ -0,0 +1,71 @@ +From 1fbb7117eb8ca702e71490e063cbd68703a49451 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 18:58:20 -0700 +Subject: selftests/binderfs: use the Makefile's rules, not Make's implicit + rules + +From: John Hubbard + +[ Upstream commit 019baf635eb6ffe8d6c1343f81788f02a7e0ed98 ] + +First of all, in order to build with clang at all, one must first apply +Valentin Obst's build fix for LLVM [1]. Once that is done, then when +building with clang, via: + + make LLVM=1 -C tools/testing/selftests + +...the following error occurs: + + clang: error: cannot specify -o when generating multiple output files + +This is because clang, unlike gcc, won't accept invocations of this +form: + + clang file1.c header2.h + +While trying to fix this, I noticed that: + +a) selftests/lib.mk already avoids the problem, and + +b) The binderfs Makefile indavertently bypasses the selftests/lib.mk +build system, and quitely uses Make's implicit build rules for .c files +instead. + +The Makefile attempts to set up both a dependency and a source file, +neither of which was needed, because lib.mk is able to automatically +handle both. This line: + + binderfs_test: binderfs_test.c + +...causes Make's implicit rules to run, which builds binderfs_test +without ever looking at lib.mk. + +Fix this by simply deleting the "binderfs_test:" Makefile target and +letting lib.mk handle it instead. + +[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ + +Fixes: 6e29225af902 ("binderfs: port tests to test harness infrastructure") +Cc: Christian Brauner +Signed-off-by: John Hubbard +Reviewed-by: Christian Brauner +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/filesystems/binderfs/Makefile | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/tools/testing/selftests/filesystems/binderfs/Makefile b/tools/testing/selftests/filesystems/binderfs/Makefile +index c2f7cef919c04..eb4c3b4119348 100644 +--- a/tools/testing/selftests/filesystems/binderfs/Makefile ++++ b/tools/testing/selftests/filesystems/binderfs/Makefile +@@ -3,6 +3,4 @@ + CFLAGS += $(KHDR_INCLUDES) -pthread + TEST_GEN_PROGS := binderfs_test + +-binderfs_test: binderfs_test.c ../../kselftest.h ../../kselftest_harness.h +- + include ../../lib.mk +-- +2.43.0 + diff --git a/queue-6.8/selftests-bpf-fix-a-fd-leak-in-error-paths-in-open_n.patch b/queue-6.8/selftests-bpf-fix-a-fd-leak-in-error-paths-in-open_n.patch new file mode 100644 index 00000000000..bf90ecb3824 --- /dev/null +++ b/queue-6.8/selftests-bpf-fix-a-fd-leak-in-error-paths-in-open_n.patch @@ -0,0 +1,40 @@ +From 70fc1f5174a2e46c3114a3c621b34a6865394876 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 18:35:27 +0800 +Subject: selftests/bpf: Fix a fd leak in error paths in open_netns + +From: Geliang Tang + +[ Upstream commit 151f7442436658ee84076681d8f52e987fe147ea ] + +As Martin mentioned in review comment, there is an existing bug that +orig_netns_fd will be leaked in the later "goto fail;" case after +open("/proc/self/ns/net") in open_netns() in network_helpers.c. This +patch adds "close(token->orig_netns_fd);" before "free(token);" to +fix it. + +Fixes: a30338840fa5 ("selftests/bpf: Move open_netns() and close_netns() into network_helpers.c") +Signed-off-by: Geliang Tang +Link: https://lore.kernel.org/r/a104040b47c3c34c67f3f125cdfdde244a870d3c.1713868264.git.tanggeliang@kylinos.cn +Signed-off-by: Martin KaFai Lau +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/bpf/network_helpers.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/tools/testing/selftests/bpf/network_helpers.c b/tools/testing/selftests/bpf/network_helpers.c +index 6db27a9088e97..be96bf022316f 100644 +--- a/tools/testing/selftests/bpf/network_helpers.c ++++ b/tools/testing/selftests/bpf/network_helpers.c +@@ -461,6 +461,8 @@ struct nstoken *open_netns(const char *name) + + return token; + fail: ++ if (token->orig_netns_fd != -1) ++ close(token->orig_netns_fd); + free(token); + return NULL; + } +-- +2.43.0 + diff --git a/queue-6.8/selftests-bpf-fix-pointer-arithmetic-in-test_xdp_do_.patch b/queue-6.8/selftests-bpf-fix-pointer-arithmetic-in-test_xdp_do_.patch new file mode 100644 index 00000000000..db69a8d0617 --- /dev/null +++ b/queue-6.8/selftests-bpf-fix-pointer-arithmetic-in-test_xdp_do_.patch @@ -0,0 +1,62 @@ +From ec6cdf7bc485da54a891d4a1a685327a5674c362 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 16:50:22 +0200 +Subject: selftests/bpf: Fix pointer arithmetic in test_xdp_do_redirect +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Michal Schmidt + +[ Upstream commit e549b39a0ab8880d7ae6c6495b00fc1cb8f36174 ] + +Cast operation has a higher precedence than addition. The code here +wants to zero the 2nd half of the 64-bit metadata, but due to a pointer +arithmetic mistake, it writes the zero at offset 16 instead. + +Just adding parentheses around "data + 4" would fix this, but I think +this will be slightly better readable with array syntax. + +I was unable to test this with tools/testing/selftests/bpf/vmtest.sh, +because my glibc is newer than glibc in the provided VM image. +So I just checked the difference in the compiled code. +objdump -S tools/testing/selftests/bpf/xdp_do_redirect.test.o: + - *((__u32 *)data) = 0x42; /* metadata test value */ + + ((__u32 *)data)[0] = 0x42; /* metadata test value */ + be7: 48 8d 85 30 fc ff ff lea -0x3d0(%rbp),%rax + bee: c7 00 42 00 00 00 movl $0x42,(%rax) + - *((__u32 *)data + 4) = 0; + + ((__u32 *)data)[1] = 0; + bf4: 48 8d 85 30 fc ff ff lea -0x3d0(%rbp),%rax + - bfb: 48 83 c0 10 add $0x10,%rax + + bfb: 48 83 c0 04 add $0x4,%rax + bff: c7 00 00 00 00 00 movl $0x0,(%rax) + +Fixes: 5640b6d89434 ("selftests/bpf: fix "metadata marker" getting overwritten by the netstack") +Signed-off-by: Michal Schmidt +Signed-off-by: Andrii Nakryiko +Reviewed-by: Toke Høiland-Jørgensen +Link: https://lore.kernel.org/bpf/20240506145023.214248-1-mschmidt@redhat.com +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c b/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c +index 498d3bdaa4b0b..bad0ea167be70 100644 +--- a/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c ++++ b/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c +@@ -107,8 +107,8 @@ void test_xdp_do_redirect(void) + .attach_point = BPF_TC_INGRESS); + + memcpy(&data[sizeof(__u64)], &pkt_udp, sizeof(pkt_udp)); +- *((__u32 *)data) = 0x42; /* metadata test value */ +- *((__u32 *)data + 4) = 0; ++ ((__u32 *)data)[0] = 0x42; /* metadata test value */ ++ ((__u32 *)data)[1] = 0; + + skel = test_xdp_do_redirect__open(); + if (!ASSERT_OK_PTR(skel, "skel")) +-- +2.43.0 + diff --git a/queue-6.8/selftests-bpf-fix-umount-cgroup2-error-in-test_sockm.patch b/queue-6.8/selftests-bpf-fix-umount-cgroup2-error-in-test_sockm.patch new file mode 100644 index 00000000000..148b809ad29 --- /dev/null +++ b/queue-6.8/selftests-bpf-fix-umount-cgroup2-error-in-test_sockm.patch @@ -0,0 +1,43 @@ +From 50c617a2280ffa177d388c5831a69131b3d908e2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 13:18:40 +0800 +Subject: selftests/bpf: Fix umount cgroup2 error in test_sockmap + +From: Geliang Tang + +[ Upstream commit d75142dbeb2bd1587b9cc19f841578f541275a64 ] + +This patch fixes the following "umount cgroup2" error in test_sockmap.c: + + (cgroup_helpers.c:353: errno: Device or resource busy) umount cgroup2 + +Cgroup fd cg_fd should be closed before cleanup_cgroup_environment(). + +Fixes: 13a5f3ffd202 ("bpf: Selftests, sockmap test prog run without setting cgroup") +Signed-off-by: Geliang Tang +Acked-by: Yonghong Song +Link: https://lore.kernel.org/r/0399983bde729708773416b8488bac2cd5e022b8.1712639568.git.tanggeliang@kylinos.cn +Signed-off-by: Martin KaFai Lau +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/bpf/test_sockmap.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c +index 024a0faafb3be..43612de44fbf5 100644 +--- a/tools/testing/selftests/bpf/test_sockmap.c ++++ b/tools/testing/selftests/bpf/test_sockmap.c +@@ -2104,9 +2104,9 @@ int main(int argc, char **argv) + free(options.whitelist); + if (options.blacklist) + free(options.blacklist); ++ close(cg_fd); + if (cg_created) + cleanup_cgroup_environment(); +- close(cg_fd); + return err; + } + +-- +2.43.0 + diff --git a/queue-6.8/selftests-bpf-run-cgroup1_hierarchy-test-in-own-moun.patch b/queue-6.8/selftests-bpf-run-cgroup1_hierarchy-test-in-own-moun.patch new file mode 100644 index 00000000000..1b75f130760 --- /dev/null +++ b/queue-6.8/selftests-bpf-run-cgroup1_hierarchy-test-in-own-moun.patch @@ -0,0 +1,92 @@ +From 3c249774ebe0e7dfe7391c096b350a466a31f9d0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 29 Apr 2024 13:23:11 +0200 +Subject: selftests/bpf: Run cgroup1_hierarchy test in own mount namespace + +From: Viktor Malik + +[ Upstream commit 19468ed51488dae19254e8a67c75d583b05fa5e3 ] + +The cgroup1_hierarchy test uses setup_classid_environment to setup +cgroupv1 environment. The problem is that the environment is set in +/sys/fs/cgroup and therefore, if not run under an own mount namespace, +effectively deletes all system cgroups: + + $ ls /sys/fs/cgroup | wc -l + 27 + $ sudo ./test_progs -t cgroup1_hierarchy + #41/1 cgroup1_hierarchy/test_cgroup1_hierarchy:OK + #41/2 cgroup1_hierarchy/test_root_cgid:OK + #41/3 cgroup1_hierarchy/test_invalid_level:OK + #41/4 cgroup1_hierarchy/test_invalid_cgid:OK + #41/5 cgroup1_hierarchy/test_invalid_hid:OK + #41/6 cgroup1_hierarchy/test_invalid_cgrp_name:OK + #41/7 cgroup1_hierarchy/test_invalid_cgrp_name2:OK + #41/8 cgroup1_hierarchy/test_sleepable_prog:OK + #41 cgroup1_hierarchy:OK + Summary: 1/8 PASSED, 0 SKIPPED, 0 FAILED + $ ls /sys/fs/cgroup | wc -l + 1 + +To avoid this, run setup_cgroup_environment first which will create an +own mount namespace. This only affects the cgroupv1_hierarchy test as +all other cgroup1 test progs already run setup_cgroup_environment prior +to running setup_classid_environment. + +Also add a comment to the header of setup_classid_environment to warn +against this invalid usage in future. + +Fixes: 360769233cc9 ("selftests/bpf: Add selftests for cgroup1 hierarchy") +Signed-off-by: Viktor Malik +Signed-off-by: Andrii Nakryiko +Link: https://lore.kernel.org/bpf/20240429112311.402497-1-vmalik@redhat.com +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/bpf/cgroup_helpers.c | 3 +++ + tools/testing/selftests/bpf/prog_tests/cgroup1_hierarchy.c | 7 ++++++- + 2 files changed, 9 insertions(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c +index 19be9c63d5e84..e812876d79c7e 100644 +--- a/tools/testing/selftests/bpf/cgroup_helpers.c ++++ b/tools/testing/selftests/bpf/cgroup_helpers.c +@@ -508,6 +508,9 @@ int cgroup_setup_and_join(const char *path) { + /** + * setup_classid_environment() - Setup the cgroupv1 net_cls environment + * ++ * This function should only be called in a custom mount namespace, e.g. ++ * created by running setup_cgroup_environment. ++ * + * After calling this function, cleanup_classid_environment should be called + * once testing is complete. + * +diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup1_hierarchy.c b/tools/testing/selftests/bpf/prog_tests/cgroup1_hierarchy.c +index 74d6d7546f40f..25332e596750f 100644 +--- a/tools/testing/selftests/bpf/prog_tests/cgroup1_hierarchy.c ++++ b/tools/testing/selftests/bpf/prog_tests/cgroup1_hierarchy.c +@@ -87,9 +87,12 @@ void test_cgroup1_hierarchy(void) + goto destroy; + + /* Setup cgroup1 hierarchy */ ++ err = setup_cgroup_environment(); ++ if (!ASSERT_OK(err, "setup_cgroup_environment")) ++ goto destroy; + err = setup_classid_environment(); + if (!ASSERT_OK(err, "setup_classid_environment")) +- goto destroy; ++ goto cleanup_cgroup; + + err = join_classid(); + if (!ASSERT_OK(err, "join_cgroup1")) +@@ -153,6 +156,8 @@ void test_cgroup1_hierarchy(void) + + cleanup: + cleanup_classid_environment(); ++cleanup_cgroup: ++ cleanup_cgroup_environment(); + destroy: + test_cgroup1_hierarchy__destroy(skel); + } +-- +2.43.0 + diff --git a/queue-6.8/selftests-cgroup-skip-test_cgcore_lesser_ns_open-whe.patch b/queue-6.8/selftests-cgroup-skip-test_cgcore_lesser_ns_open-whe.patch new file mode 100644 index 00000000000..37a6e076397 --- /dev/null +++ b/queue-6.8/selftests-cgroup-skip-test_cgcore_lesser_ns_open-whe.patch @@ -0,0 +1,221 @@ +From bc3d267808c377d39810e5adfddca8b0c5a48429 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 10:44:37 +0800 +Subject: selftests: cgroup: skip test_cgcore_lesser_ns_open when cgroup2 + mounted without nsdelegate + +From: Tianchen Ding + +[ Upstream commit 4793cb599b1bdc3d356f0374c2c99ffe890ae876 ] + +The test case test_cgcore_lesser_ns_open only tasks effect when cgroup2 +is mounted with "nsdelegate" mount option. If it misses this option, or +is remounted without "nsdelegate", the test case will fail. For example, +running bpf/test_cgroup_storage first, and then run cgroup/test_core will +fail on test_cgcore_lesser_ns_open. Skip it if "nsdelegate" is not +detected in cgroup2 mount options. + +Fixes: bf35a7879f1d ("selftests: cgroup: Test open-time cgroup namespace usage for migration checks") +Signed-off-by: Tianchen Ding +Reviewed-by: Muhammad Usama Anjum +Signed-off-by: Tejun Heo +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/cgroup/cgroup_util.c | 8 +++++--- + tools/testing/selftests/cgroup/cgroup_util.h | 2 +- + tools/testing/selftests/cgroup/test_core.c | 7 ++++++- + tools/testing/selftests/cgroup/test_cpu.c | 2 +- + tools/testing/selftests/cgroup/test_cpuset.c | 2 +- + tools/testing/selftests/cgroup/test_freezer.c | 2 +- + tools/testing/selftests/cgroup/test_hugetlb_memcg.c | 2 +- + tools/testing/selftests/cgroup/test_kill.c | 2 +- + tools/testing/selftests/cgroup/test_kmem.c | 2 +- + tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- + tools/testing/selftests/cgroup/test_zswap.c | 2 +- + 11 files changed, 20 insertions(+), 13 deletions(-) + +diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c +index 0340d4ca8f51c..432db923bced0 100644 +--- a/tools/testing/selftests/cgroup/cgroup_util.c ++++ b/tools/testing/selftests/cgroup/cgroup_util.c +@@ -195,10 +195,10 @@ int cg_write_numeric(const char *cgroup, const char *control, long value) + return cg_write(cgroup, control, buf); + } + +-int cg_find_unified_root(char *root, size_t len) ++int cg_find_unified_root(char *root, size_t len, bool *nsdelegate) + { + char buf[10 * PAGE_SIZE]; +- char *fs, *mount, *type; ++ char *fs, *mount, *type, *options; + const char delim[] = "\n\t "; + + if (read_text("/proc/self/mounts", buf, sizeof(buf)) <= 0) +@@ -211,12 +211,14 @@ int cg_find_unified_root(char *root, size_t len) + for (fs = strtok(buf, delim); fs; fs = strtok(NULL, delim)) { + mount = strtok(NULL, delim); + type = strtok(NULL, delim); +- strtok(NULL, delim); ++ options = strtok(NULL, delim); + strtok(NULL, delim); + strtok(NULL, delim); + + if (strcmp(type, "cgroup2") == 0) { + strncpy(root, mount, len); ++ if (nsdelegate) ++ *nsdelegate = !!strstr(options, "nsdelegate"); + return 0; + } + } +diff --git a/tools/testing/selftests/cgroup/cgroup_util.h b/tools/testing/selftests/cgroup/cgroup_util.h +index 1df7f202214af..89e8519fb2719 100644 +--- a/tools/testing/selftests/cgroup/cgroup_util.h ++++ b/tools/testing/selftests/cgroup/cgroup_util.h +@@ -21,7 +21,7 @@ static inline int values_close(long a, long b, int err) + return abs(a - b) <= (a + b) / 100 * err; + } + +-extern int cg_find_unified_root(char *root, size_t len); ++extern int cg_find_unified_root(char *root, size_t len, bool *nsdelegate); + extern char *cg_name(const char *root, const char *name); + extern char *cg_name_indexed(const char *root, const char *name, int index); + extern char *cg_control(const char *cgroup, const char *control); +diff --git a/tools/testing/selftests/cgroup/test_core.c b/tools/testing/selftests/cgroup/test_core.c +index 80aa6b2373b96..a5672a91d273c 100644 +--- a/tools/testing/selftests/cgroup/test_core.c ++++ b/tools/testing/selftests/cgroup/test_core.c +@@ -18,6 +18,8 @@ + #include "../kselftest.h" + #include "cgroup_util.h" + ++static bool nsdelegate; ++ + static int touch_anon(char *buf, size_t size) + { + int fd; +@@ -775,6 +777,9 @@ static int test_cgcore_lesser_ns_open(const char *root) + pid_t pid; + int status; + ++ if (!nsdelegate) ++ return KSFT_SKIP; ++ + cg_test_a = cg_name(root, "cg_test_a"); + cg_test_b = cg_name(root, "cg_test_b"); + +@@ -862,7 +867,7 @@ int main(int argc, char *argv[]) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), &nsdelegate)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (cg_read_strstr(root, "cgroup.subtree_control", "memory")) +diff --git a/tools/testing/selftests/cgroup/test_cpu.c b/tools/testing/selftests/cgroup/test_cpu.c +index 24020a2c68dcd..186bf96f6a284 100644 +--- a/tools/testing/selftests/cgroup/test_cpu.c ++++ b/tools/testing/selftests/cgroup/test_cpu.c +@@ -700,7 +700,7 @@ int main(int argc, char *argv[]) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (cg_read_strstr(root, "cgroup.subtree_control", "cpu")) +diff --git a/tools/testing/selftests/cgroup/test_cpuset.c b/tools/testing/selftests/cgroup/test_cpuset.c +index b061ed1e05b4d..4034d14ba69ac 100644 +--- a/tools/testing/selftests/cgroup/test_cpuset.c ++++ b/tools/testing/selftests/cgroup/test_cpuset.c +@@ -249,7 +249,7 @@ int main(int argc, char *argv[]) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (cg_read_strstr(root, "cgroup.subtree_control", "cpuset")) +diff --git a/tools/testing/selftests/cgroup/test_freezer.c b/tools/testing/selftests/cgroup/test_freezer.c +index 8845353aca53b..8730645d363a7 100644 +--- a/tools/testing/selftests/cgroup/test_freezer.c ++++ b/tools/testing/selftests/cgroup/test_freezer.c +@@ -827,7 +827,7 @@ int main(int argc, char *argv[]) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + for (i = 0; i < ARRAY_SIZE(tests); i++) { + switch (tests[i].fn(root)) { +diff --git a/tools/testing/selftests/cgroup/test_hugetlb_memcg.c b/tools/testing/selftests/cgroup/test_hugetlb_memcg.c +index f0fefeb4cc24c..856f9508ea562 100644 +--- a/tools/testing/selftests/cgroup/test_hugetlb_memcg.c ++++ b/tools/testing/selftests/cgroup/test_hugetlb_memcg.c +@@ -214,7 +214,7 @@ int main(int argc, char **argv) + return ret; + } + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + switch (test_hugetlb_memcg(root)) { +diff --git a/tools/testing/selftests/cgroup/test_kill.c b/tools/testing/selftests/cgroup/test_kill.c +index 6153690319c9c..0e5bb6c7307a5 100644 +--- a/tools/testing/selftests/cgroup/test_kill.c ++++ b/tools/testing/selftests/cgroup/test_kill.c +@@ -276,7 +276,7 @@ int main(int argc, char *argv[]) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + for (i = 0; i < ARRAY_SIZE(tests); i++) { + switch (tests[i].fn(root)) { +diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c +index c82f974b85c94..137506db03127 100644 +--- a/tools/testing/selftests/cgroup/test_kmem.c ++++ b/tools/testing/selftests/cgroup/test_kmem.c +@@ -420,7 +420,7 @@ int main(int argc, char **argv) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + /* +diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c +index c7c9572003a8c..b462416b38061 100644 +--- a/tools/testing/selftests/cgroup/test_memcontrol.c ++++ b/tools/testing/selftests/cgroup/test_memcontrol.c +@@ -1314,7 +1314,7 @@ int main(int argc, char **argv) + char root[PATH_MAX]; + int i, proc_status, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + /* +diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c +index 47fdaa1464430..e1169d3e620f0 100644 +--- a/tools/testing/selftests/cgroup/test_zswap.c ++++ b/tools/testing/selftests/cgroup/test_zswap.c +@@ -324,7 +324,7 @@ int main(int argc, char **argv) + char root[PATH_MAX]; + int i, ret = EXIT_SUCCESS; + +- if (cg_find_unified_root(root, sizeof(root))) ++ if (cg_find_unified_root(root, sizeof(root), NULL)) + ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (!zswap_configured()) +-- +2.43.0 + diff --git a/queue-6.8/selftests-damon-_damon_sysfs-check-errors-from-nr_sc.patch b/queue-6.8/selftests-damon-_damon_sysfs-check-errors-from-nr_sc.patch new file mode 100644 index 00000000000..6b7207a95c1 --- /dev/null +++ b/queue-6.8/selftests-damon-_damon_sysfs-check-errors-from-nr_sc.patch @@ -0,0 +1,39 @@ +From 89f0cd7b80606c54ff0ad108c5aac7d355eb6ef6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 3 May 2024 11:03:10 -0700 +Subject: selftests/damon/_damon_sysfs: check errors from nr_schemes file reads + +From: SeongJae Park + +[ Upstream commit 732b8815c079199d29b0426d9372bb098c63cdc7 ] + +DAMON context staging method in _damon_sysfs.py is not checking the +returned error from nr_schemes file read. Check it. + +Link: https://lkml.kernel.org/r/20240503180318.72798-3-sj@kernel.org +Fixes: f5f0e5a2bef9 ("selftests/damon/_damon_sysfs: implement kdamonds start function") +Signed-off-by: SeongJae Park +Cc: Jonathan Corbet +Cc: Shuah Khan +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/damon/_damon_sysfs.py | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py +index e98cf4b6a4b76..f9fead3d0f018 100644 +--- a/tools/testing/selftests/damon/_damon_sysfs.py ++++ b/tools/testing/selftests/damon/_damon_sysfs.py +@@ -241,6 +241,8 @@ class DamonCtx: + nr_schemes_file = os.path.join( + self.sysfs_dir(), 'schemes', 'nr_schemes') + content, err = read_file(nr_schemes_file) ++ if err is not None: ++ return err + if int(content) != len(self.schemes): + err = write_file(nr_schemes_file, '%d' % len(self.schemes)) + if err != None: +-- +2.43.0 + diff --git a/queue-6.8/selftests-default-to-host-arch-for-llvm-builds.patch b/queue-6.8/selftests-default-to-host-arch-for-llvm-builds.patch new file mode 100644 index 00000000000..90f2212eb1a --- /dev/null +++ b/queue-6.8/selftests-default-to-host-arch-for-llvm-builds.patch @@ -0,0 +1,85 @@ +From 63f474a2ffaff7c6c0dac70e5e3a77d7d19b05bf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 29 Mar 2024 11:49:43 +0100 +Subject: selftests: default to host arch for LLVM builds + +From: Valentin Obst + +[ Upstream commit d4e6fbd245c48b272cc591d1c5e7c07aedd7f071 ] + +Align the behavior for gcc and clang builds by interpreting unset +`ARCH` and `CROSS_COMPILE` variables in `LLVM` builds as a sign that the +user wants to build for the host architecture. + +This patch preserves the properties that setting the `ARCH` variable to an +unknown value will trigger an error that complains about insufficient +information, and that a set `CROSS_COMPILE` variable will override the +target triple that is determined based on presence/absence of `ARCH`. + +When compiling with clang, i.e., `LLVM` is set, an unset `ARCH` variable in +combination with an unset `CROSS_COMPILE` variable, i.e., compiling for +the host architecture, leads to compilation failures since `lib.mk` can +not determine the clang target triple. In this case, the following error +message is displayed for each subsystem that does not set `ARCH` in its +own Makefile before including `lib.mk` (lines wrapped at 75 chrs): + + make[1]: Entering directory '/mnt/build/linux/tools/testing/selftests/ + sysctl' + ../lib.mk:33: *** Specify CROSS_COMPILE or add '--target=' option to + lib.mk. Stop. + make[1]: Leaving directory '/mnt/build/linux/tools/testing/selftests/ + sysctl' + +In the same scenario a gcc build would default to the host architecture, +i.e., it would use plain `gcc`. + +Fixes: 795285ef2425 ("selftests: Fix clang cross compilation") +Reviewed-by: Mark Brown +Signed-off-by: Valentin Obst +Reviewed-by: John Hubbard +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/lib.mk | 12 ++++++++++-- + 1 file changed, 10 insertions(+), 2 deletions(-) + +diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk +index aa646e0661f36..a8f0442a36bca 100644 +--- a/tools/testing/selftests/lib.mk ++++ b/tools/testing/selftests/lib.mk +@@ -7,6 +7,8 @@ else ifneq ($(filter -%,$(LLVM)),) + LLVM_SUFFIX := $(LLVM) + endif + ++CLANG := $(LLVM_PREFIX)clang$(LLVM_SUFFIX) ++ + CLANG_TARGET_FLAGS_arm := arm-linux-gnueabi + CLANG_TARGET_FLAGS_arm64 := aarch64-linux-gnu + CLANG_TARGET_FLAGS_hexagon := hexagon-linux-musl +@@ -18,7 +20,13 @@ CLANG_TARGET_FLAGS_riscv := riscv64-linux-gnu + CLANG_TARGET_FLAGS_s390 := s390x-linux-gnu + CLANG_TARGET_FLAGS_x86 := x86_64-linux-gnu + CLANG_TARGET_FLAGS_x86_64 := x86_64-linux-gnu +-CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH)) ++ ++# Default to host architecture if ARCH is not explicitly given. ++ifeq ($(ARCH),) ++CLANG_TARGET_FLAGS := $(shell $(CLANG) -print-target-triple) ++else ++CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH)) ++endif + + ifeq ($(CROSS_COMPILE),) + ifeq ($(CLANG_TARGET_FLAGS),) +@@ -30,7 +38,7 @@ else + CLANG_FLAGS += --target=$(notdir $(CROSS_COMPILE:%-=%)) + endif # CROSS_COMPILE + +-CC := $(LLVM_PREFIX)clang$(LLVM_SUFFIX) $(CLANG_FLAGS) -fintegrated-as ++CC := $(CLANG) $(CLANG_FLAGS) -fintegrated-as + else + CC := $(CROSS_COMPILE)gcc + endif # LLVM +-- +2.43.0 + diff --git a/queue-6.8/selftests-kcmp-remove-unused-open-mode.patch b/queue-6.8/selftests-kcmp-remove-unused-open-mode.patch new file mode 100644 index 00000000000..d417564a404 --- /dev/null +++ b/queue-6.8/selftests-kcmp-remove-unused-open-mode.patch @@ -0,0 +1,42 @@ +From 2da68e90ccaa3c1b6f19aa8862d68af726933d18 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 29 Apr 2024 23:46:09 +0000 +Subject: selftests/kcmp: remove unused open mode + +From: Edward Liaw + +[ Upstream commit eb59a58113717df04b8a8229befd8ab1e5dbf86e ] + +Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE +aren't specified. The permissions for the file are set above: + + fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); + +Link: https://lkml.kernel.org/r/20240429234610.191144-1-edliaw@google.com +Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") +Signed-off-by: Edward Liaw +Reviewed-by: Cyrill Gorcunov +Cc: Eric Biederman +Cc: Shuah Khan +Signed-off-by: Andrew Morton +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/kcmp/kcmp_test.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c +index 25110c7c0b3ed..d7a8e321bb16b 100644 +--- a/tools/testing/selftests/kcmp/kcmp_test.c ++++ b/tools/testing/selftests/kcmp/kcmp_test.c +@@ -91,7 +91,7 @@ int main(int argc, char **argv) + ksft_print_header(); + ksft_set_plan(3); + +- fd2 = open(kpath, O_RDWR, 0644); ++ fd2 = open(kpath, O_RDWR); + if (fd2 < 0) { + perror("Can't open file"); + ksft_exit_fail(); +-- +2.43.0 + diff --git a/queue-6.8/selftests-net-add-missing-config-for-amt.sh.patch b/queue-6.8/selftests-net-add-missing-config-for-amt.sh.patch new file mode 100644 index 00000000000..11609787b6d --- /dev/null +++ b/queue-6.8/selftests-net-add-missing-config-for-amt.sh.patch @@ -0,0 +1,35 @@ +From a0c048ae1a000170095de5b5833b2bc6be386d53 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 09:19:19 -0700 +Subject: selftests: net: add missing config for amt.sh + +From: Jakub Kicinski + +[ Upstream commit c499fe96d3f75a5cf50de6089dd8f1cddd1301a9 ] + +Test needs IPv6 multicast. smcroute currently crashes when trying +to install a route in a kernel without IPv6 multicast. + +Fixes: c08e8baea78e ("selftests: add amt interface selftest script") +Link: https://lore.kernel.org/r/20240509161919.3939966-1-kuba@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/net/config | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config +index 5e4390cac17ed..04de7a6ba6f31 100644 +--- a/tools/testing/selftests/net/config ++++ b/tools/testing/selftests/net/config +@@ -30,6 +30,7 @@ CONFIG_IP_GRE=m + CONFIG_NETFILTER=y + CONFIG_NETFILTER_ADVANCED=y + CONFIG_NF_CONNTRACK=m ++CONFIG_IPV6_MROUTE=y + CONFIG_IPV6_SIT=y + CONFIG_IP_DCCP=m + CONFIG_NF_NAT=m +-- +2.43.0 + diff --git a/queue-6.8/selftests-net-bridge-increase-igmp-mld-exclude-timeo.patch b/queue-6.8/selftests-net-bridge-increase-igmp-mld-exclude-timeo.patch new file mode 100644 index 00000000000..51394f66d81 --- /dev/null +++ b/queue-6.8/selftests-net-bridge-increase-igmp-mld-exclude-timeo.patch @@ -0,0 +1,82 @@ +From 329dd2e71a6ffcda2c0e13cdaa78a8dec57fcf84 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 13 May 2024 13:52:57 +0300 +Subject: selftests: net: bridge: increase IGMP/MLD exclude timeout membership + interval + +From: Nikolay Aleksandrov + +[ Upstream commit 06080ea23095afe04a2cb7a8d05fab4311782623 ] + +When running the bridge IGMP/MLD selftests on debug kernels we can get +spurious errors when setting up the IGMP/MLD exclude timeout tests +because the membership interval is just 3 seconds and the setup has 2 +seconds of sleep plus various validations, the one second that is left +is not enough. Increase the membership interval from 3 to 5 seconds to +make room for the setup validation and 2 seconds of sleep. + +Fixes: 34d7ecb3d4f7 ("selftests: net: bridge: update IGMP/MLD membership interval value") +Reported-by: Jakub Kicinski +Signed-off-by: Nikolay Aleksandrov +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/net/forwarding/bridge_igmp.sh | 6 +++--- + tools/testing/selftests/net/forwarding/bridge_mld.sh | 6 +++--- + 2 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/tools/testing/selftests/net/forwarding/bridge_igmp.sh b/tools/testing/selftests/net/forwarding/bridge_igmp.sh +index 2aa66d2a1702b..e6a3e04fd83f3 100755 +--- a/tools/testing/selftests/net/forwarding/bridge_igmp.sh ++++ b/tools/testing/selftests/net/forwarding/bridge_igmp.sh +@@ -478,10 +478,10 @@ v3exc_timeout_test() + RET=0 + local X=("192.0.2.20" "192.0.2.30") + +- # GMI should be 3 seconds ++ # GMI should be 5 seconds + ip link set dev br0 type bridge mcast_query_interval 100 \ + mcast_query_response_interval 100 \ +- mcast_membership_interval 300 ++ mcast_membership_interval 500 + + v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP + ip link set dev br0 type bridge mcast_query_interval 500 \ +@@ -489,7 +489,7 @@ v3exc_timeout_test() + mcast_membership_interval 1500 + + $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q +- sleep 3 ++ sleep 5 + bridge -j -d -s mdb show dev br0 \ + | jq -e ".[].mdb[] | \ + select(.grp == \"$TEST_GROUP\" and \ +diff --git a/tools/testing/selftests/net/forwarding/bridge_mld.sh b/tools/testing/selftests/net/forwarding/bridge_mld.sh +index e2b9ff773c6b6..f84ab2e657547 100755 +--- a/tools/testing/selftests/net/forwarding/bridge_mld.sh ++++ b/tools/testing/selftests/net/forwarding/bridge_mld.sh +@@ -478,10 +478,10 @@ mldv2exc_timeout_test() + RET=0 + local X=("2001:db8:1::20" "2001:db8:1::30") + +- # GMI should be 3 seconds ++ # GMI should be 5 seconds + ip link set dev br0 type bridge mcast_query_interval 100 \ + mcast_query_response_interval 100 \ +- mcast_membership_interval 300 ++ mcast_membership_interval 500 + + mldv2exclude_prepare $h1 + ip link set dev br0 type bridge mcast_query_interval 500 \ +@@ -489,7 +489,7 @@ mldv2exc_timeout_test() + mcast_membership_interval 1500 + + $MZ $h1 -c 1 $MZPKT_ALLOW2 -q +- sleep 3 ++ sleep 5 + bridge -j -d -s mdb show dev br0 \ + | jq -e ".[].mdb[] | \ + select(.grp == \"$TEST_GROUP\" and \ +-- +2.43.0 + diff --git a/queue-6.8/selftests-net-lib-no-need-to-record-ns-name-if-it-al.patch b/queue-6.8/selftests-net-lib-no-need-to-record-ns-name-if-it-al.patch new file mode 100644 index 00000000000..3fecbddcd8c --- /dev/null +++ b/queue-6.8/selftests-net-lib-no-need-to-record-ns-name-if-it-al.patch @@ -0,0 +1,56 @@ +From 91f9ee15bd38866cb7e0ea9578a0c175327d263d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 14 May 2024 10:33:59 +0800 +Subject: selftests/net/lib: no need to record ns name if it already exist + +From: Hangbin Liu + +[ Upstream commit 83e93942796db58652288f0391ac00072401816f ] + +There is no need to add the name to ns_list again if the netns already +recoreded. + +Fixes: 25ae948b4478 ("selftests/net: add lib.sh") +Signed-off-by: Hangbin Liu +Reviewed-by: Simon Horman +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/net/lib.sh | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh +index f9fe182dfbd44..56a9454b7ba35 100644 +--- a/tools/testing/selftests/net/lib.sh ++++ b/tools/testing/selftests/net/lib.sh +@@ -73,15 +73,17 @@ setup_ns() + local ns="" + local ns_name="" + local ns_list="" ++ local ns_exist= + for ns_name in "$@"; do + # Some test may setup/remove same netns multi times + if unset ${ns_name} 2> /dev/null; then + ns="${ns_name,,}-$(mktemp -u XXXXXX)" + eval readonly ${ns_name}="$ns" ++ ns_exist=false + else + eval ns='$'${ns_name} + cleanup_ns "$ns" +- ++ ns_exist=true + fi + + if ! ip netns add "$ns"; then +@@ -90,7 +92,7 @@ setup_ns() + return $ksft_skip + fi + ip -n "$ns" link set lo up +- ns_list="$ns_list $ns" ++ ! $ns_exist && ns_list="$ns_list $ns" + done + NS_LIST="$NS_LIST $ns_list" + } +-- +2.43.0 + diff --git a/queue-6.8/selftests-net-move-amt-to-socat-for-better-compatibi.patch b/queue-6.8/selftests-net-move-amt-to-socat-for-better-compatibi.patch new file mode 100644 index 00000000000..5b7b1b6571b --- /dev/null +++ b/queue-6.8/selftests-net-move-amt-to-socat-for-better-compatibi.patch @@ -0,0 +1,77 @@ +From 520b71e9c5f6902c249ab2a3893d3a235a0140d8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 9 May 2024 09:19:52 -0700 +Subject: selftests: net: move amt to socat for better compatibility + +From: Jakub Kicinski + +[ Upstream commit 4c639b6a7b9db236c0907aca8e92d1537076f2cd ] + +The test seems to expect that nc will exit after the first +received message. This is not the case with Ncat 7.94. +There are multiple versions of nc out there, switch +to socat for better compatibility. + +Tell socat to exit after 128 bytes and pad the message. + +Since the test sets -e make sure we don't set exit code +(|| true) and print the pass / fail rather then silently +moving over the test and just setting non-zero exit code +with no output indicating what failed. + +Fixes: c08e8baea78e ("selftests: add amt interface selftest script") +Acked-by: Paolo Abeni +Tested-by: Taehee Yoo +Link: https://lore.kernel.org/r/20240509161952.3940476-1-kuba@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/net/amt.sh | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/tools/testing/selftests/net/amt.sh b/tools/testing/selftests/net/amt.sh +index 75528788cb95e..5175a42cbe8a2 100755 +--- a/tools/testing/selftests/net/amt.sh ++++ b/tools/testing/selftests/net/amt.sh +@@ -210,8 +210,8 @@ check_features() + + test_ipv4_forward() + { +- RESULT4=$(ip netns exec "${LISTENER}" nc -w 1 -l -u 239.0.0.1 4000) +- if [ "$RESULT4" == "172.17.0.2" ]; then ++ RESULT4=$(ip netns exec "${LISTENER}" timeout 15 socat - UDP4-LISTEN:4000,readbytes=128 || true) ++ if echo "$RESULT4" | grep -q "172.17.0.2"; then + printf "TEST: %-60s [ OK ]\n" "IPv4 amt multicast forwarding" + exit 0 + else +@@ -222,8 +222,8 @@ test_ipv4_forward() + + test_ipv6_forward() + { +- RESULT6=$(ip netns exec "${LISTENER}" nc -w 1 -l -u ff0e::5:6 6000) +- if [ "$RESULT6" == "2001:db8:3::2" ]; then ++ RESULT6=$(ip netns exec "${LISTENER}" timeout 15 socat - UDP6-LISTEN:6000,readbytes=128 || true) ++ if echo "$RESULT6" | grep -q "2001:db8:3::2"; then + printf "TEST: %-60s [ OK ]\n" "IPv6 amt multicast forwarding" + exit 0 + else +@@ -236,14 +236,14 @@ send_mcast4() + { + sleep 2 + ip netns exec "${SOURCE}" bash -c \ +- 'echo 172.17.0.2 | nc -w 1 -u 239.0.0.1 4000' & ++ 'printf "%s %128s" 172.17.0.2 | nc -w 1 -u 239.0.0.1 4000' & + } + + send_mcast6() + { + sleep 2 + ip netns exec "${SOURCE}" bash -c \ +- 'echo 2001:db8:3::2 | nc -w 1 -u ff0e::5:6 6000' & ++ 'printf "%s %128s" 2001:db8:3::2 | nc -w 1 -u ff0e::5:6 6000' & + } + + check_features +-- +2.43.0 + diff --git a/queue-6.8/selftests-resctrl-fix-clang-build-failure-use-local_.patch b/queue-6.8/selftests-resctrl-fix-clang-build-failure-use-local_.patch new file mode 100644 index 00000000000..4a79c074939 --- /dev/null +++ b/queue-6.8/selftests-resctrl-fix-clang-build-failure-use-local_.patch @@ -0,0 +1,60 @@ +From aa88296c9cadec0f86e25a1d5e3ec06c86704e60 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 19:17:12 -0700 +Subject: selftests/resctrl: fix clang build failure: use LOCAL_HDRS +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: John Hubbard + +[ Upstream commit d8171aa4ca72f1a67bf3c14c59441d63c1d2585f ] + +First of all, in order to build with clang at all, one must first apply +Valentin Obst's build fix for LLVM [1]. Once that is done, then when +building with clang, via: + + make LLVM=1 -C tools/testing/selftests + +...the following error occurs: + + clang: error: cannot specify -o when generating multiple output files + +This is because clang, unlike gcc, won't accept invocations of this +form: + + clang file1.c header2.h + +Fix this by using selftests/lib.mk facilities for tracking local header +file dependencies: add them to LOCAL_HDRS, leaving only the .c files to +be passed to the compiler. + +[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ + +Fixes: 8e289f454289 ("selftests/resctrl: Add resctrl.h into build deps") +Cc: Ilpo Järvinen +Signed-off-by: John Hubbard +Acked-by: Reinette Chatre +Signed-off-by: Shuah Khan +Signed-off-by: Sasha Levin +--- + tools/testing/selftests/resctrl/Makefile | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile +index 2deac2031de9e..021863f86053a 100644 +--- a/tools/testing/selftests/resctrl/Makefile ++++ b/tools/testing/selftests/resctrl/Makefile +@@ -5,6 +5,8 @@ CFLAGS += $(KHDR_INCLUDES) + + TEST_GEN_PROGS := resctrl_tests + ++LOCAL_HDRS += $(wildcard *.h) ++ + include ../lib.mk + +-$(OUTPUT)/resctrl_tests: $(wildcard *.[ch]) ++$(OUTPUT)/resctrl_tests: $(wildcard *.c) +-- +2.43.0 + diff --git a/queue-6.8/selftests-sud_test-return-correct-emulated-syscall-v.patch b/queue-6.8/selftests-sud_test-return-correct-emulated-syscall-v.patch new file mode 100644 index 00000000000..d23c4555d38 --- /dev/null +++ b/queue-6.8/selftests-sud_test-return-correct-emulated-syscall-v.patch @@ -0,0 +1,56 @@ +From 898939becd48e798f0b8dd23c8712e09a52a75b3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 6 Dec 2023 14:44:37 +0100 +Subject: selftests: sud_test: return correct emulated syscall value on RISC-V +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Clément Léger + +[ Upstream commit 17c67ed752d6a456602b3dbb25c5ae4d3de5deab ] + +Currently, the sud_test expects the emulated syscall to return the +emulated syscall number. This assumption only works on architectures +were the syscall calling convention use the same register for syscall +number/syscall return value. This is not the case for RISC-V and thus +the return value must be also emulated using the provided ucontext. + +Signed-off-by: Clément Léger +Reviewed-by: Palmer Dabbelt +Acked-by: Palmer Dabbelt +Link: https://lore.kernel.org/r/20231206134438.473166-1-cleger@rivosinc.com +Signed-off-by: Palmer Dabbelt +Signed-off-by: Sasha Levin +--- + .../selftests/syscall_user_dispatch/sud_test.c | 14 ++++++++++++++ + 1 file changed, 14 insertions(+) + +diff --git a/tools/testing/selftests/syscall_user_dispatch/sud_test.c b/tools/testing/selftests/syscall_user_dispatch/sud_test.c +index b5d592d4099e8..d975a67673299 100644 +--- a/tools/testing/selftests/syscall_user_dispatch/sud_test.c ++++ b/tools/testing/selftests/syscall_user_dispatch/sud_test.c +@@ -158,6 +158,20 @@ static void handle_sigsys(int sig, siginfo_t *info, void *ucontext) + + /* In preparation for sigreturn. */ + SYSCALL_DISPATCH_OFF(glob_sel); ++ ++ /* ++ * The tests for argument handling assume that `syscall(x) == x`. This ++ * is a NOP on x86 because the syscall number is passed in %rax, which ++ * happens to also be the function ABI return register. Other ++ * architectures may need to swizzle the arguments around. ++ */ ++#if defined(__riscv) ++/* REG_A7 is not defined in libc headers */ ++# define REG_A7 (REG_A0 + 7) ++ ++ ((ucontext_t *)ucontext)->uc_mcontext.__gregs[REG_A0] = ++ ((ucontext_t *)ucontext)->uc_mcontext.__gregs[REG_A7]; ++#endif + } + + TEST(dispatch_and_return) +-- +2.43.0 + diff --git a/queue-6.8/series b/queue-6.8/series index 0c2afe91b80..bcde0e571a6 100644 --- a/queue-6.8/series +++ b/queue-6.8/series @@ -33,3 +33,459 @@ alsa-timer-set-lower-bound-of-start-tick-time.patch alsa-fix-deadlocks-with-kctl-removals-at-disconnection.patch keys-asymmetric-add-missing-dependency-on-crypto_sig.patch keys-asymmetric-add-missing-dependencies-of-fips_signature_selftest.patch +hid-nintendo-fix-n64-controller-being-identified-as-.patch +dmaengine-xilinx-xdma-clarify-kdoc-in-xdma-driver.patch +wifi-mac80211-don-t-use-rate-mask-for-scanning.patch +wifi-mac80211-ensure-beacon-is-non-s1g-prior-to-extr.patch +wifi-cfg80211-fix-the-order-of-arguments-for-trace-e.patch +dt-bindings-rockchip-grf-add-missing-type-to-pcie-ph.patch +hid-mcp-2221-cancel-delayed_work-only-when-config_ii.patch +net-usb-qmi_wwan-add-telit-fn920c04-compositions.patch +drm-amd-display-set-color_mgmt_changed-to-true-on-un.patch +drm-amdgpu-update-bo-eviction-priorities.patch +drm-amd-pm-restore-config-space-after-reset.patch +drm-amdkfd-add-vram-accounting-for-svm-migration.patch +drm-amdgpu-fix-the-ring-buffer-size-for-queue-vm-flu.patch +drm-amdgpu-mes-fix-use-after-free-issue.patch +revert-net-txgbe-fix-i2c-dev-name-cannot-match-clkde.patch +revert-net-txgbe-fix-clk_name-exceed-max_dev_id-limi.patch +cpu-ignore-mitigations-kernel-parameter-if-cpu_mitig.patch +loongarch-lately-init-pmu-after-smp-is-online.patch +drm-etnaviv-fix-tx-clock-gating-on-some-gc7000-varia.patch +selftests-sud_test-return-correct-emulated-syscall-v.patch +riscv-thead-rename-t-head-pbmt-to-mae.patch +riscv-t-head-test-availability-bit-before-enabling-m.patch +sched-isolation-fix-boot-crash-when-maxcpus-first-ho.patch +asoc-intel-bytcr_rt5640-apply-asus-t100ta-quirk-to-a.patch +regulator-irq_helpers-duplicate-irq-name.patch +alsa-hda-cs35l56-exit-cache-only-after-cs35l56_wait_.patch +asoc-sof-ipc4-pcm-use-consistent-name-for-snd_sof_pc.patch +asoc-sof-ipc4-pcm-use-consistent-name-for-sof_ipc4_t.patch +asoc-sof-ipc4-pcm-introduce-generic-sof_ipc4_pcm_str.patch +asoc-sof-pcm-restrict-dsp-d0i3-during-s0ix-to-ipc3.patch +asoc-acp-support-microphone-from-device-acer-315-24p.patch +asoc-rt5645-fix-the-electric-noise-due-to-the-cbj-co.patch +asoc-dt-bindings-rt5645-add-cbj-sleeve-gpio-property.patch +asoc-rt722-sdca-modify-channel-number-to-support-4-c.patch +asoc-rt722-sdca-add-headset-microphone-vrefo-setting.patch +regulator-qcom-refgen-fix-module-autoloading.patch +regulator-vqmmc-ipq4019-fix-module-autoloading.patch +asoc-cs35l41-update-dsp1rx5-6-sources-for-dsp-config.patch +asoc-rt715-add-vendor-clear-control-register.patch +asoc-rt715-sdca-volume-step-modification.patch +kvm-selftests-add-test-for-uaccesses-to-non-existent.patch +input-xpad-add-support-for-asus-rog-raikiri.patch +btrfs-take-the-cleaner_mutex-earlier-in-qgroup-disab.patch +edac-versal-do-not-register-for-noc-errors.patch +fpga-dfl-pci-add-pci-subdevice-id-for-intel-d5005-ca.patch +bpf-x86-fix-probe_mem-runtime-load-check.patch +alsa-emu10k1-make-e-mu-fpga-writes-potentially-more-.patch +softirq-fix-suspicious-rcu-usage-in-__do_softirq.patch +platform-x86-isst-add-grand-ridge-to-hpm-cpu-list.patch +asoc-da7219-aad-fix-usage-of-device_get_named_child_.patch +asoc-cs35l56-fix-usages-of-device_get_named_child_no.patch +alsa-hda-intel-dsp-config-harden-i2c-i2s-codec-detec.patch +input-amimouse-mark-driver-struct-with-__refdata-to-.patch +drm-amdgpu-fix-vram-memory-accounting.patch +drm-amd-display-ensure-that-dmcub-support-flag-is-se.patch +drm-amd-display-add-dtbclk-access-to-dcn315.patch +drm-amd-display-allocate-zero-bw-after-bw-alloc-enab.patch +drm-amd-display-add-vco-speed-parameter-for-dcn31-fp.patch +drm-amd-display-fix-dc-mode-screen-flickering-on-dcn.patch +drm-amd-display-disable-seamless-boot-on-128b-132b-e.patch +drm-amdkfd-flush-the-process-wq-before-creating-a-kf.patch +x86-mm-remove-broken-vsyscall-emulation-code-from-th.patch +nvme-find-numa-distance-only-if-controller-has-valid.patch +nvmet-auth-return-the-error-code-to-the-nvmet_auth_h.patch +nvmet-auth-replace-pr_debug-with-pr_err-to-report-an.patch +nvme-cancel-pending-i-o-if-nvme-controller-is-in-ter.patch +nvmet-tcp-fix-possible-memory-leak-when-tearing-down.patch +nvmet-fix-nvme-status-code-when-namespace-is-disable.patch +nvme-tcp-strict-pdu-pacing-to-avoid-send-stalls-on-t.patch +epoll-be-better-about-file-lifetimes.patch +nvmet-prevent-sprintf-overflow-in-nvmet_subsys_nsid_.patch +openpromfs-finish-conversion-to-the-new-mount-api.patch +crypto-bcm-fix-pointer-arithmetic.patch +firmware-qcom-qcm-fix-unused-qcom_scm_qseecom_allowl.patch +mm-slub-kunit-use-inverted-data-to-corrupt-kmem-cach.patch +firmware-raspberrypi-use-correct-device-for-dma-mapp.patch +ecryptfs-fix-buffer-size-for-tag-66-packet.patch +nilfs2-fix-out-of-range-warning.patch +parisc-add-missing-export-of-__cmpxchg_u8.patch +crypto-ccp-drop-platform-ifdef-checks.patch +crypto-x86-nh-avx2-add-missing-vzeroupper.patch +crypto-x86-sha256-avx2-add-missing-vzeroupper.patch +crypto-x86-sha512-avx2-add-missing-vzeroupper.patch +s390-cio-fix-tracepoint-subchannel-type-field.patch +io_uring-use-the-right-type-for-work_llist-empty-che.patch +rcu-tasks-fix-show_rcu_tasks_trace_gp_kthread-buffer.patch +rcu-fix-buffer-overflow-in-print_cpu_stall_info.patch +arm-configs-sunxi-enable-drm_dw_hdmi.patch +jffs2-prevent-xattr-node-from-overflowing-the-eraseb.patch +libfs-re-arrange-locking-in-offset_iterate_dir.patch +libfs-define-a-minimum-directory-offset.patch +libfs-add-simple_offset_empty.patch +maple_tree-add-mtree_alloc_cyclic.patch +libfs-convert-simple-directory-offsets-to-use-a-mapl.patch +libfs-fix-simple_offset_rename_exchange.patch +libfs-add-simple_offset_rename-api.patch +shmem-fix-shmem_rename2.patch +io-wq-write-next_work-before-dropping-acct_lock.patch +mm-userfaultfd-do-not-place-zeropages-when-zeropages.patch +s390-mm-re-enable-the-shared-zeropage-for-pv-and-ske.patch +crypto-octeontx2-add-missing-check-for-dma_map_singl.patch +crypto-qat-improve-error-message-in-adf_get_arbiter_.patch +crypto-qat-improve-error-logging-to-be-consistent-ac.patch +soc-qcom-pmic_glink-don-t-traverse-clients-list-with.patch +soc-qcom-pmic_glink-notify-clients-about-the-current.patch +firmware-qcom-scm-fix-__scm-and-waitq-completion-var.patch +soc-mediatek-cmdq-fix-typo-of-cmdq_jump_relative.patch +null_blk-fix-missing-mutex_destroy-at-module-removal.patch +crypto-qat-validate-slices-count-returned-by-fw.patch +hwrng-stm32-use-logical-or-in-conditional.patch +hwrng-stm32-put-ip-into-rpm-suspend-on-failure.patch +hwrng-stm32-repair-clock-handling.patch +kunit-fortify-fix-mismatched-kvalloc-vfree-usage.patch +io_uring-net-remove-dependency-on-req_f_partial_io-f.patch +io_uring-net-fix-sendzc-lazy-wake-polling.patch +soc-qcom-pmic_glink-make-client-lock-non-sleeping.patch +lkdtm-disable-cfi-checking-for-perms-functions.patch +md-fix-resync-softlockup-when-bitmap-size-is-less-th.patch +crypto-qat-specify-firmware-files-for-402xx.patch +block-refine-the-eof-check-in-blkdev_iomap_begin.patch +block-fix-and-simplify-blkdevparts-cmdline-parsing.patch +block-support-to-account-io_ticks-precisely.patch +wifi-ath10k-poll-service-ready-message-before-failin.patch +wifi-brcmfmac-pcie-handle-randbuf-allocation-failure.patch +wifi-ath11k-don-t-force-enable-power-save-on-non-run.patch +bpftool-fix-missing-pids-during-link-show.patch +libbpf-prevent-null-pointer-dereference-when-prog-to.patch +wifi-ath12k-use-correct-flag-field-for-320-mhz-chann.patch +wifi-mt76-mt7915-workaround-too-long-expansion-spars.patch +x86-boot-ignore-relocations-in-.notes-sections-in-wa.patch +wifi-ieee80211-fix-ieee80211_mle_basic_sta_prof_size.patch +wifi-iwlwifi-mvm-do-not-warn-on-invalid-link-on-scan.patch +wifi-iwlwifi-mvm-allocate-sta-links-only-for-active-.patch +wifi-mac80211-don-t-select-link-id-if-not-provided-i.patch +wifi-iwlwifi-implement-can_activate_links-callback.patch +wifi-iwlwifi-mvm-fix-active-link-counting-during-rec.patch +wifi-iwlwifi-mvm-select-sta-mask-only-for-active-lin.patch +wifi-iwlwifi-reconfigure-tlc-during-hw-restart.patch +wifi-iwlwifi-mvm-fix-check-in-iwl_mvm_sta_fw_id_mask.patch +sched-fair-add-eas-checks-before-updating-root_domai.patch +acpi-bus-indicate-support-for-_tfp-thru-_osc.patch +acpi-bus-indicate-support-for-more-than-16-p-states-.patch +acpi-bus-indicate-support-for-the-generic-event-devi.patch +acpi-fix-generic-initiator-affinity-_osc-bit.patch +acpi-bus-indicate-support-for-irq-resourcesource-thr.patch +enetc-avoid-truncating-error-message.patch +qed-avoid-truncating-work-queue-length.patch +mlx5-avoid-truncating-error-message.patch +mlx5-stop-warning-for-64kb-pages.patch +bitops-add-missing-prototype-check.patch +dlm-fix-user-space-lock-decision-to-copy-lvb.patch +wifi-carl9170-re-fix-fortified-memset-warning.patch +bpftool-mount-bpffs-on-provided-dir-instead-of-paren.patch +bpf-pack-struct-bpf_fib_lookup.patch +bpf-prevent-r10-register-from-being-marked-as-precis.patch +x86-microcode-amd-avoid-wformat-warning-with-clang-1.patch +scsi-ufs-qcom-perform-read-back-after-writing-reset-.patch +scsi-ufs-qcom-perform-read-back-after-writing-reg_uf.patch +scsi-ufs-qcom-perform-read-back-after-writing-unipro.patch +scsi-ufs-qcom-perform-read-back-after-writing-cgc-en.patch +scsi-ufs-cdns-pltfrm-perform-read-back-after-writing.patch +scsi-ufs-core-perform-read-back-after-writing-utp_ta.patch +scsi-ufs-core-perform-read-back-after-disabling-inte.patch +scsi-ufs-core-perform-read-back-after-disabling-uic_.patch +acpi-lpss-advertise-number-of-chip-selects-via-prope.patch +edac-skx_common-allow-decoding-of-sgx-addresses.patch +locking-atomic-x86-correct-the-definition-of-__arch_.patch +irqchip-alpine-msi-fix-off-by-one-in-allocation-erro.patch +irqchip-loongson-pch-msi-fix-off-by-one-on-allocatio.patch +acpi-disable-wstringop-truncation.patch +gfs2-don-t-forget-to-complete-delayed-withdraw.patch +gfs2-fix-ignore-unlock-failures-after-withdraw.patch +arm64-remove-unnecessary-irqflags-alternative.h-incl.patch +x86-boot-64-clear-most-of-cr4-in-startup_64-except-p.patch +selftests-bpf-fix-umount-cgroup2-error-in-test_sockm.patch +tcp-increase-the-default-tcp-scaling-ratio.patch +cpufreq-exit-callback-is-optional.patch +x86-pat-introduce-lookup_address_in_pgd_attr.patch +x86-pat-restructure-_lookup_address_cpa.patch +x86-pat-fix-w-x-violation-false-positives-when-runni.patch +udp-avoid-call-to-compute_score-on-multiple-sites.patch +openrisc-traps-don-t-send-signals-to-kernel-mode-thr.patch +cppc_cpufreq-fix-possible-null-pointer-dereference.patch +wifi-iwlwifi-mvm-init-vif-works-only-once.patch +scsi-libsas-fix-the-failure-of-adding-phy-with-zero-.patch +scsi-hpsa-fix-allocation-size-for-scsi_host-private-.patch +x86-purgatory-switch-to-the-position-independent-sma.patch +wifi-ath12k-fix-out-of-bound-access-of-qmi_invoke_ha.patch +thermal-drivers-mediatek-lvts_thermal-add-coeff-for-.patch +thermal-drivers-tsens-fix-null-pointer-dereference.patch +dt-bindings-thermal-loongson-ls2k-thermal-add-loongs.patch +dt-bindings-thermal-loongson-ls2k-thermal-fix-incorr.patch +wifi-ath10k-fix-an-error-code-problem-in-ath10k_dbg_.patch +gfs2-remove-ill-placed-consistency-check.patch +gfs2-fix-potential-glock-use-after-free-on-unmount.patch +gfs2-finish_xmote-cleanup.patch +gfs2-do_xmote-fixes.patch +thermal-debugfs-avoid-excessive-updates-of-trip-poin.patch +selftests-bpf-fix-a-fd-leak-in-error-paths-in-open_n.patch +scsi-ufs-core-mcq-fix-ufshcd_mcq_sqe_search.patch +cpufreq-brcmstb-avs-cpufreq-iso-c90-forbids-mixed-de.patch +wifi-ath10k-populate-board-data-for-wcn3990.patch +net-dsa-mv88e6xxx-add-support-for-model-specific-pre.patch +net-dsa-mv88e6xxx-avoid-eeprom-timeout-without-eepro.patch +tcp-avoid-premature-drops-in-tcp_add_backlog.patch +thermal-debugfs-create-records-for-cdev-states-as-th.patch +thermal-debugfs-pass-cooling-device-state-to-thermal.patch +pwm-sti-prepare-removing-pwm_chip-from-driver-data.patch +pwm-sti-simplify-probe-function-using-devm-functions.patch +drivers-perf-hisi_pcie-fix-out-of-bound-access-when-.patch +drivers-perf-hisi-hns3-fix-out-of-bound-access-when-.patch +drivers-perf-hisi-hns3-actually-use-devm_add_action_.patch +net-give-more-chances-to-rcu-in-netdev_wait_allrefs_.patch +macintosh-via-macii-fix-bug-sleeping-function-called.patch +wifi-carl9170-add-a-proper-sanity-check-for-endpoint.patch +bpf-fix-verifier-assumptions-about-socket-sk.patch +selftests-bpf-run-cgroup1_hierarchy-test-in-own-moun.patch +wifi-ar5523-enable-proper-endpoint-verification.patch +pwm-drop-useless-member-.of_pwm_n_cells-of-struct-pw.patch +pwm-let-the-of_xlate-callbacks-accept-references-wit.patch +pwm-drop-duplicate-check-against-chip-npwm-in-of_pwm.patch +pwm-reorder-symbols-in-core.c.patch +pwm-provide-an-inline-function-to-get-the-parent-dev.patch +pwm-meson-change-prototype-of-a-few-helpers-to-prepa.patch +pwm-meson-make-use-of-pwmchip_parent-accessor.patch +pwm-meson-add-check-for-error-from-clk_round_rate.patch +pwm-meson-use-mul_u64_u64_div_u64-for-frequency-calc.patch +bpf-add-bpf_prog_type_cgroup_skb-attach-type-enforce.patch +sh-kprobes-merge-arch_copy_kprobe-into-arch_prepare_.patch +revert-sh-handle-calling-csum_partial-with-misaligne.patch +wifi-mt76-mt7603-fix-tx-queue-of-loopback-packets.patch +wifi-mt76-mt7603-add-wpdma-tx-eof-flag-for-pse-clien.patch +wifi-mt76-mt7996-fix-size-of-txpower-mcu-command.patch +wifi-mt76-mt7925-ensure-4-byte-alignment-for-suspend.patch +wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch +wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch +libbpf-fix-error-message-in-attach_kprobe_multi.patch +wifi-nl80211-avoid-address-calculations-via-out-of-b.patch +wifi-rtw89-wow-refine-wowlan-flows-of-hci-interrupts.patch +selftests-binderfs-use-the-makefile-s-rules-not-make.patch +selftests-resctrl-fix-clang-build-failure-use-local_.patch +selftests-default-to-host-arch-for-llvm-builds.patch +kunit-fix-kthread-reference.patch +kunit-unregister-the-device-on-error.patch +kunit-bail-out-early-in-__kunit_test_suites_init-if-.patch +selftests-bpf-fix-pointer-arithmetic-in-test_xdp_do_.patch +hid-intel-ish-hid-ipc-add-check-for-pci_alloc_irq_ve.patch +scsi-bfa-ensure-the-copied-buf-is-nul-terminated.patch +scsi-qedf-ensure-the-copied-buf-is-nul-terminated.patch +scsi-qla2xxx-fix-debugfs-output-for-fw_resource_coun.patch +gpio-nuvoton-fix-sgpio-irq-handle-error.patch +x86-numa-fix-srat-lookup-of-cfmws-ranges-with-numa_f.patch +wifi-mwl8k-initialize-cmd-addr-properly.patch +hid-amd_sfh-handle-no-sensors-in-pm-operations.patch +usb-aqc111-stop-lying-about-skb-truesize.patch +net-usb-sr9700-stop-lying-about-skb-truesize.patch +m68k-fix-spinlock-race-in-kernel-thread-creation.patch +m68k-mac-fix-reboot-hang-on-mac-iici.patch +dm-delay-fix-workqueue-delay_timer-race.patch +dm-delay-fix-hung-task-introduced-by-kthread-mode.patch +dm-delay-fix-max_delay-calculations.patch +ptp-ocp-fix-dpll-functions.patch +net-ipv6-fix-wrong-start-position-when-receive-hop-b.patch +eth-sungem-remove-.ndo_poll_controller-to-avoid-dead.patch +selftests-net-add-missing-config-for-amt.sh.patch +selftests-net-move-amt-to-socat-for-better-compatibi.patch +net-ethernet-mediatek-split-tx-and-rx-fields-in-mtk_.patch +net-ethernet-mediatek-use-admav1-instead-of-admav2.0.patch +ice-fix-package-download-algorithm.patch +net-ethernet-cortina-locking-fixes.patch +af_unix-fix-data-races-in-unix_release_sock-unix_str.patch +net-usb-smsc95xx-stop-lying-about-skb-truesize.patch +net-openvswitch-fix-overwriting-ct-original-tuple-fo.patch +ipv6-sr-add-missing-seg6_local_exit.patch +ipv6-sr-fix-incorrect-unregister-order.patch +ipv6-sr-fix-invalid-unregister-error-path.patch +net-mlx5-fix-peer-devlink-set-for-sf-representor-dev.patch +net-mlx5-reload-only-ib-representors-upon-lag-disabl.patch +net-mlx5-add-a-timeout-to-acquire-the-command-queue-.patch +net-mlx5-discard-command-completions-in-internal-err.patch +s390-bpf-emit-a-barrier-for-bpf_fetch-instructions.patch +riscv-bpf-make-some-atomic-operations-fully-ordered.patch +ax25-use-kernel-universal-linked-list-to-implement-a.patch +ax25-fix-reference-count-leak-issues-of-ax25_dev.patch +ax25-fix-reference-count-leak-issue-of-net_device.patch +dpll-fix-return-value-check-for-kmemdup.patch +net-fec-remove-.ndo_poll_controller-to-avoid-deadloc.patch +mptcp-so_keepalive-fix-getsockopt-support.patch +mptcp-cleanup-writer-wake-up.patch +mptcp-avoid-some-duplicate-code-in-socket-option-han.patch +mptcp-implement-tcp_notsent_lowat-support.patch +mptcp-cleanup-sol_tcp-handling.patch +mptcp-fix-full-tcp-keep-alive-support.patch +net-stmmac-offload-queuemaxsdu-from-tc-taprio.patch +net-stmmac-est-per-tx-queue-error-count-for-hlbf.patch +net-stmmac-report-taprio-offload-status.patch +net-stmmac-move-the-est-lock-to-struct-stmmac_priv.patch +net-micrel-fix-receiving-the-timestamp-in-the-frame-.patch +bluetooth-compute-le-flow-credits-based-on-recvbuf-s.patch +bluetooth-qca-fix-error-code-in-qca_read_fw_build_in.patch +bluetooth-iso-add-hcon-for-listening-bis-sk.patch +bluetooth-iso-clean-up-returns-values-in-iso_connect.patch +bluetooth-iso-make-iso_get_sock_listen-generic.patch +bluetooth-remove-usage-of-the-deprecated-ida_simple_.patch +bluetooth-hci_event-remove-code-to-removed-config_bt.patch +bluetooth-hci-remove-hci_amp-support.patch +ice-make-ice_vsi_cfg_rxq-static.patch +ice-make-ice_vsi_cfg_txq-static.patch +overflow-change-define_flex-to-take-__counted_by-mem.patch +bluetooth-hci_conn-hci_sync-use-__counted_by-to-avoi.patch +bluetooth-hci_core-fix-not-handling-hdev-le_num_of_a.patch +drm-bridge-fix-improper-bridge-init-order-with-pre_e.patch +drm-ci-update-device-type-for-volteer-devices.patch +drm-nouveau-dp-fix-incorrect-return-code-in-r535_dp_.patch +drm-omapdrm-fix-console-by-implementing-fb_dirty.patch +drm-omapdrm-fix-console-with-deferred-ops.patch +printk-let-no_printk-use-_printk.patch +dev_printk-add-and-use-dev_no_printk.patch +drm-lcdif-do-not-disable-clocks-on-already-suspended.patch +drm-dp-don-t-attempt-aux-transfers-when-edp-panels-a.patch +drm-panel-atna33xc20-fix-unbalanced-regulator-in-the.patch +drm-amd-display-fix-potential-index-out-of-bounds-in.patch +drm-amd-display-remove-redundant-condition-in-dcn35_.patch +asoc-intel-disable-route-checks-for-skylake-boards.patch +asoc-intel-avs-ssm4567-do-not-ignore-route-checks.patch +mtd-core-report-error-if-first-mtd_otp_size-call-fai.patch +mtd-rawnand-hynix-fixed-typo.patch +drm-imagination-avoid-woverflow-warning.patch +asoc-mediatek-assign-dummy-when-codec-not-specified-.patch +drm-panel-ltk050h3146w-add-mipi_dsi_mode_video-to-lt.patch +drm-panel-ltk050h3146w-drop-duplicate-commands-from-.patch +fbdev-shmobile-fix-snprintf-truncation.patch +asoc-kirkwood-fix-potential-null-dereference.patch +drm-meson-vclk-fix-calculation-of-59.94-fractional-r.patch +drm-mediatek-add-0-size-check-to-mtk_drm_gem_obj.patch +drm-mediatek-init-ddp_comp-with-devm_kcalloc.patch +asoc-sof-intel-hda-dai-fix-channel-map-configuration.patch +powerpc-fsl-soc-hide-unused-const-variable.patch +asoc-sof-intel-mtl-correct-rom_status_reg.patch +asoc-sof-intel-lnl-correct-rom_status_reg.patch +asoc-sof-intel-mtl-disable-interrupts-when-firmware-.patch +asoc-sof-intel-mtl-implement-firmware-boot-state-che.patch +fbdev-sisfb-hide-unused-variables.patch +selftests-cgroup-skip-test_cgcore_lesser_ns_open-whe.patch +asoc-intel-avs-restore-stream-decoupling-on-prepare.patch +asoc-intel-avs-fix-asrc-module-initialization.patch +asoc-intel-avs-fix-potential-integer-overflow.patch +asoc-intel-avs-test-result-of-avs_get_module_entry.patch +media-ngene-add-dvb_ca_en50221_init-return-value-che.patch +staging-media-starfive-remove-links-when-unregisteri.patch +media-rcar-vin-work-around-wenum-compare-conditional.patch +media-radio-shark2-avoid-led_names-truncations.patch +drm-bridge-cdns-mhdp8546-fix-possible-null-pointer-d.patch +platform-x86-xiaomi-wmi-fix-race-condition-when-repo.patch +drm-msm-dp-allow-voltage-swing-pre-emphasis-of-3.patch +drm-msm-dp-avoid-a-long-timeout-for-aux-transfer-if-.patch +media-ipu3-cio2-request-irq-earlier.patch +media-dt-bindings-ovti-ov2680-fix-the-power-supply-n.patch +media-i2c-et8ek8-don-t-strip-remove-function-when-dr.patch +media-v4l2-subdev-fix-stream-handling-for-crop-api.patch +fbdev-sh7760fb-allow-modular-build.patch +media-atomisp-ssh_css-fix-a-null-pointer-dereference.patch +drm-arm-malidp-fix-a-possible-null-pointer-dereferen.patch +drm-vc4-fix-possible-null-pointer-dereference.patch +asoc-tracing-export-snd_soc_dapm_dir_out-to-its-valu.patch +drm-bridge-anx7625-don-t-log-an-error-when-dsi-host-.patch +drm-bridge-icn6211-don-t-log-an-error-when-dsi-host-.patch +drm-bridge-lt8912b-don-t-log-an-error-when-dsi-host-.patch +drm-bridge-lt9611-don-t-log-an-error-when-dsi-host-c.patch +drm-bridge-lt9611uxc-don-t-log-an-error-when-dsi-hos.patch +drm-bridge-tc358775-don-t-log-an-error-when-dsi-host.patch +drm-bridge-dpc3433-don-t-log-an-error-when-dsi-host-.patch +drm-panel-novatek-nt35950-don-t-log-an-error-when-ds.patch +drm-bridge-anx7625-update-audio-status-while-detecti.patch +drm-panel-simple-add-missing-innolux-g121x1-l03-form.patch +alsa-hda-cs35l41-remove-speaker-id-for-lenovo-legion.patch +drm-mipi-dsi-use-correct-return-type-for-the-dsc-fun.patch +media-uvcvideo-add-quirk-for-logitech-rally-bar.patch +drm-rockchip-vop2-do-not-divide-height-twice-for-yuv.patch +drm-edid-parse-topology-block-for-all-dispid-structu.patch +media-cadence-csi2rx-configure-dphy-before-starting-.patch +clk-samsung-exynosautov9-fix-wrong-pll-clock-id-valu.patch +rdma-mlx5-uncacheable-mkey-has-neither-rb_key-or-cac.patch +rdma-mlx5-change-check-for-cacheable-mkeys.patch +rdma-mlx5-adding-remote-atomic-access-flag-to-updata.patch +clk-mediatek-pllfh-don-t-log-error-for-missing-fhctl.patch +iommu-undo-pasid-attachment-only-for-the-devices-tha.patch +rdma-hns-fix-return-value-in-hns_roce_map_mr_sg.patch +rdma-hns-fix-deadlock-on-srq-async-events.patch +rdma-hns-fix-uaf-for-cq-async-event.patch +rdma-hns-fix-gmv-table-pagesize.patch +rdma-hns-use-complete-parentheses-in-macros.patch +rdma-hns-modify-the-print-level-of-cqe-error.patch +clk-mediatek-mt8365-mm-fix-dpi0-parent.patch +clk-rs9-fix-wrong-default-value-for-clock-amplitude.patch +clk-qcom-clk-alpha-pll-remove-invalid-stromer-regist.patch +rdma-rxe-fix-seg-fault-in-rxe_comp_queue_pkt.patch +rdma-rxe-allow-good-work-requests-to-be-executed.patch +rdma-rxe-fix-incorrect-rxe_put-in-error-path.patch +ib-mlx5-use-__iowrite64_copy-for-write-combining-sto.patch +clk-renesas-r8a779a0-fix-canfd-parent-clock.patch +clk-renesas-r9a07g043-add-clock-and-reset-entry-for-.patch +lib-test_hmm.c-handle-src_pfns-and-dst_pfns-allocati.patch +mm-ksm-fix-ksm-exec-support-for-prctl.patch +clk-qcom-dispcc-sm8450-fix-displayport-clocks.patch +clk-qcom-dispcc-sm6350-fix-displayport-clocks.patch +clk-qcom-dispcc-sm8550-fix-displayport-clocks.patch +clk-qcom-dispcc-sm8650-fix-displayport-clocks.patch +clk-qcom-mmcc-msm8998-fix-venus-clock-issue.patch +x86-insn-fix-push-instruction-in-x86-instruction-dec.patch +x86-insn-add-vex-versions-of-vpdpbusd-vpdpbusds-vpdp.patch +ext4-avoid-excessive-credit-estimate-in-ext4_tmpfile.patch +rdma-mana_ib-introduce-helpers-to-create-and-destroy.patch +rdma-mana_ib-use-struct-mana_ib_queue-for-cqs.patch +rdma-mana_ib-boundary-check-before-installing-cq-cal.patch +virt-acrn-stop-using-follow_pfn.patch +drivers-virt-acrn-fix-pfnmap-pte-checks-in-acrn_vm_r.patch +sunrpc-removed-redundant-procp-check.patch +nfsd-don-t-create-nfsv4recoverydir-in-nfsdfs-when-no.patch +ext4-fix-potential-unnitialized-variable.patch +ext4-remove-the-redundant-folio_wait_stable.patch +clk-qcom-fix-sc_camcc_8280xp-dependencies.patch +clk-qcom-fix-sm_gpucc_8650-dependencies.patch +clk-qcom-apss-ipq-pll-fix-pll-rate-for-ipq5018.patch +nilfs2-make-superblock-data-array-index-computation-.patch +of-module-add-buffer-overflow-check-in-of_modalias.patch +bnxt_re-avoid-shift-undefined-behavior-in-bnxt_qplib.patch +sunrpc-fix-gss_free_in_token_pages.patch +selftests-damon-_damon_sysfs-check-errors-from-nr_sc.patch +selftests-kcmp-remove-unused-open-mode.patch +rdma-ipoib-fix-format-truncation-compilation-errors.patch +rdma-cma-fix-kmemleak-in-rdma_core-observed-during-b.patch +samples-landlock-fix-incorrect-free-in-populate_rule.patch +tracing-user_events-prepare-find-delete-for-same-nam.patch +tracing-user_events-fix-non-spaced-field-matching.patch +modules-drop-the-.export_symbol-section-from-the-fin.patch +net-bridge-xmit-make-sure-we-have-at-least-eth-heade.patch +selftests-net-bridge-increase-igmp-mld-exclude-timeo.patch +net-bridge-mst-fix-vlan-use-after-free.patch +net-qrtr-ns-fix-module-refcnt.patch +selftests-net-lib-no-need-to-record-ns-name-if-it-al.patch +idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch +netrom-fix-possible-dead-lock-in-nr_rt_ioctl.patch +af_packet-do-not-call-packet_read_pending-from-tpack.patch +sched-fair-allow-disabling-sched_balance_newidle-wit.patch +sched-core-fix-incorrect-initialization-of-the-burst.patch +net-wangxun-fix-to-change-rx-features.patch +net-wangxun-match-vlan-ctag-and-stag-features.patch +net-txgbe-move-interrupt-codes-to-a-separate-file.patch +net-txgbe-use-irq_domain-for-interrupt-controller.patch +net-txgbe-fix-to-control-vlan-strip.patch +l2tp-fix-icmp-error-handling-for-udp-encap-sockets.patch +io_uring-net-ensure-async-prep-handlers-always-initi.patch +pwm-fix-setting-period-with-pwm-cells-1-and-of_pwm_s.patch +net-txgbe-fix-to-clear-interrupt-status-after-handli.patch +net-txgbe-fix-gpio-interrupt-blocking.patch diff --git a/queue-6.8/sh-kprobes-merge-arch_copy_kprobe-into-arch_prepare_.patch b/queue-6.8/sh-kprobes-merge-arch_copy_kprobe-into-arch_prepare_.patch new file mode 100644 index 00000000000..90825e83b4f --- /dev/null +++ b/queue-6.8/sh-kprobes-merge-arch_copy_kprobe-into-arch_prepare_.patch @@ -0,0 +1,53 @@ +From 84d054f4c1b340d2dade25672f31c61d0f2abb7b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 1 Mar 2024 22:02:30 +0100 +Subject: sh: kprobes: Merge arch_copy_kprobe() into arch_prepare_kprobe() + +From: Geert Uytterhoeven + +[ Upstream commit 1422ae080b66134fe192082d9b721ab7bd93fcc5 ] + +arch/sh/kernel/kprobes.c:52:16: warning: no previous prototype for 'arch_copy_kprobe' [-Wmissing-prototypes] + +Although SH kprobes support was only merged in v2.6.28, it missed the +earlier removal of the arch_copy_kprobe() callback in v2.6.15. + +Based on the powerpc part of commit 49a2a1b83ba6fa40 ("[PATCH] kprobes: +changed from using spinlock to mutex"). + +Fixes: d39f5450146ff39f ("sh: Add kprobes support.") +Signed-off-by: Geert Uytterhoeven +Reviewed-by: John Paul Adrian Glaubitz +Link: https://lore.kernel.org/r/717d47a19689cc944fae6e981a1ad7cae1642c89.1709326528.git.geert+renesas@glider.be +Signed-off-by: John Paul Adrian Glaubitz +Signed-off-by: Sasha Levin +--- + arch/sh/kernel/kprobes.c | 7 +------ + 1 file changed, 1 insertion(+), 6 deletions(-) + +diff --git a/arch/sh/kernel/kprobes.c b/arch/sh/kernel/kprobes.c +index aed1ea8e2c2f0..74051b8ddf3e7 100644 +--- a/arch/sh/kernel/kprobes.c ++++ b/arch/sh/kernel/kprobes.c +@@ -44,17 +44,12 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p) + if (OPCODE_RTE(opcode)) + return -EFAULT; /* Bad breakpoint */ + ++ memcpy(p->ainsn.insn, p->addr, MAX_INSN_SIZE * sizeof(kprobe_opcode_t)); + p->opcode = opcode; + + return 0; + } + +-void __kprobes arch_copy_kprobe(struct kprobe *p) +-{ +- memcpy(p->ainsn.insn, p->addr, MAX_INSN_SIZE * sizeof(kprobe_opcode_t)); +- p->opcode = *p->addr; +-} +- + void __kprobes arch_arm_kprobe(struct kprobe *p) + { + *p->addr = BREAKPOINT_INSTRUCTION; +-- +2.43.0 + diff --git a/queue-6.8/shmem-fix-shmem_rename2.patch b/queue-6.8/shmem-fix-shmem_rename2.patch new file mode 100644 index 00000000000..3c50947f9b1 --- /dev/null +++ b/queue-6.8/shmem-fix-shmem_rename2.patch @@ -0,0 +1,55 @@ +From d9c833db15b3cb0096afb9a2b7caa8f06c966ca5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 15 Apr 2024 11:20:56 -0400 +Subject: shmem: Fix shmem_rename2() + +From: Chuck Lever + +[ Upstream commit ad191eb6d6942bb835a0b20b647f7c53c1d99ca4 ] + +When renaming onto an existing directory entry, user space expects +the replacement entry to have the same directory offset as the +original one. + +Link: https://gitlab.alpinelinux.org/alpine/aports/-/issues/15966 +Fixes: a2e459555c5f ("shmem: stable directory offsets") +Signed-off-by: Chuck Lever +Link: https://lore.kernel.org/r/20240415152057.4605-4-cel@kernel.org +Signed-off-by: Christian Brauner +Signed-off-by: Sasha Levin +--- + fs/libfs.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/fs/libfs.c b/fs/libfs.c +index bb6731fa63059..ef700d39f0f35 100644 +--- a/fs/libfs.c ++++ b/fs/libfs.c +@@ -365,6 +365,9 @@ int simple_offset_empty(struct dentry *dentry) + * + * Caller provides appropriate serialization. + * ++ * User space expects the directory offset value of the replaced ++ * (new) directory entry to be unchanged after a rename. ++ * + * Returns zero on success, a negative errno value on failure. + */ + int simple_offset_rename(struct inode *old_dir, struct dentry *old_dentry, +@@ -372,8 +375,14 @@ int simple_offset_rename(struct inode *old_dir, struct dentry *old_dentry, + { + struct offset_ctx *old_ctx = old_dir->i_op->get_offset_ctx(old_dir); + struct offset_ctx *new_ctx = new_dir->i_op->get_offset_ctx(new_dir); ++ long new_offset = dentry2offset(new_dentry); + + simple_offset_remove(old_ctx, old_dentry); ++ ++ if (new_offset) { ++ offset_set(new_dentry, 0); ++ return simple_offset_replace(new_ctx, old_dentry, new_offset); ++ } + return simple_offset_add(new_ctx, old_dentry); + } + +-- +2.43.0 + diff --git a/queue-6.8/soc-mediatek-cmdq-fix-typo-of-cmdq_jump_relative.patch b/queue-6.8/soc-mediatek-cmdq-fix-typo-of-cmdq_jump_relative.patch new file mode 100644 index 00000000000..9393ce668f5 --- /dev/null +++ b/queue-6.8/soc-mediatek-cmdq-fix-typo-of-cmdq_jump_relative.patch @@ -0,0 +1,49 @@ +From 7f7d516b25193978440165bd4917f0a4cedc0db2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 22 Feb 2024 15:41:09 +0000 +Subject: soc: mediatek: cmdq: Fix typo of CMDQ_JUMP_RELATIVE + +From: Chun-Kuang Hu + +[ Upstream commit ed4d5ab179b9f0a60da87c650a31f1816db9b4b4 ] + +For cmdq jump command, offset 0 means relative jump and offset 1 +means absolute jump. cmdq_pkt_jump() is absolute jump, so fix the +typo of CMDQ_JUMP_RELATIVE in cmdq_pkt_jump(). + +Fixes: 946f1792d3d7 ("soc: mediatek: cmdq: add jump function") +Signed-off-by: Chun-Kuang Hu +Reviewed-by: AngeloGioacchino Del Regno +Link: https://lore.kernel.org/r/20240222154120.16959-2-chunkuang.hu@kernel.org +Signed-off-by: AngeloGioacchino Del Regno +Signed-off-by: Sasha Levin +--- + drivers/soc/mediatek/mtk-cmdq-helper.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c +index b0cd071c4719b..0b2e5690dacfa 100644 +--- a/drivers/soc/mediatek/mtk-cmdq-helper.c ++++ b/drivers/soc/mediatek/mtk-cmdq-helper.c +@@ -14,7 +14,8 @@ + #define CMDQ_POLL_ENABLE_MASK BIT(0) + #define CMDQ_EOC_IRQ_EN BIT(0) + #define CMDQ_REG_TYPE 1 +-#define CMDQ_JUMP_RELATIVE 1 ++#define CMDQ_JUMP_RELATIVE 0 ++#define CMDQ_JUMP_ABSOLUTE 1 + + struct cmdq_instruction { + union { +@@ -397,7 +398,7 @@ int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr) + struct cmdq_instruction inst = {}; + + inst.op = CMDQ_CODE_JUMP; +- inst.offset = CMDQ_JUMP_RELATIVE; ++ inst.offset = CMDQ_JUMP_ABSOLUTE; + inst.value = addr >> + cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan); + return cmdq_pkt_append_command(pkt, inst); +-- +2.43.0 + diff --git a/queue-6.8/soc-qcom-pmic_glink-don-t-traverse-clients-list-with.patch b/queue-6.8/soc-qcom-pmic_glink-don-t-traverse-clients-list-with.patch new file mode 100644 index 00000000000..79eba664457 --- /dev/null +++ b/queue-6.8/soc-qcom-pmic_glink-don-t-traverse-clients-list-with.patch @@ -0,0 +1,56 @@ +From de15738b1603d2b6442a6a05629da07b99ac0980 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 06:10:57 +0300 +Subject: soc: qcom: pmic_glink: don't traverse clients list without a lock + +From: Dmitry Baryshkov + +[ Upstream commit 635ce0db89567ba62f64b79e8c6664ba3eff6516 ] + +Take the client_lock before traversing the clients list at the +pmic_glink_state_notify_clients() function. This is required to keep the +list traversal safe from concurrent modification. + +Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") +Signed-off-by: Dmitry Baryshkov +Reviewed-by: Andrew Halaney +Reviewed-by: Mukesh Ojha +Tested-by: Xilin Wu # on QCS8550 AYN Odin 2 +Link: https://lore.kernel.org/r/20240403-pmic-glink-fix-clients-v2-1-aed4e02baacc@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/soc/qcom/pmic_glink.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c +index f913e9bd57ed4..2b2cdf4796542 100644 +--- a/drivers/soc/qcom/pmic_glink.c ++++ b/drivers/soc/qcom/pmic_glink.c +@@ -115,10 +115,12 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data, + + hdr = data; + ++ mutex_lock(&pg->client_lock); + list_for_each_entry(client, &pg->clients, node) { + if (client->id == le32_to_cpu(hdr->owner)) + client->cb(data, len, client->priv); + } ++ mutex_unlock(&pg->client_lock); + + return 0; + } +@@ -168,8 +170,10 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg) + } + + if (new_state != pg->client_state) { ++ mutex_lock(&pg->client_lock); + list_for_each_entry(client, &pg->clients, node) + client->pdr_notify(client->priv, new_state); ++ mutex_unlock(&pg->client_lock); + pg->client_state = new_state; + } + } +-- +2.43.0 + diff --git a/queue-6.8/soc-qcom-pmic_glink-make-client-lock-non-sleeping.patch b/queue-6.8/soc-qcom-pmic_glink-make-client-lock-non-sleeping.patch new file mode 100644 index 00000000000..79adc32f78f --- /dev/null +++ b/queue-6.8/soc-qcom-pmic_glink-make-client-lock-non-sleeping.patch @@ -0,0 +1,142 @@ +From 448c41bbb36c0c636f6dd1bd3803f07a43051338 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Apr 2024 20:38:57 -0700 +Subject: soc: qcom: pmic_glink: Make client-lock non-sleeping + +From: Bjorn Andersson + +[ Upstream commit 9329933699b32d467a99befa20415c4b2172389a ] + +The recently introduced commit '635ce0db8956 ("soc: qcom: pmic_glink: +don't traverse clients list without a lock")' ensured that the clients +list is not modified while traversed. + +But the callback is made from the GLINK IRQ handler and as such this +mutual exclusion can not be provided by a (sleepable) mutex. + +Replace the mutex with a spinlock. + +Fixes: 635ce0db8956 ("soc: qcom: pmic_glink: don't traverse clients list without a lock") +Signed-off-by: Bjorn Andersson +Reviewed-by: Dmitry Baryshkov +Link: https://lore.kernel.org/r/20240430-pmic-glink-sleep-while-atomic-v1-1-88fb493e8545@quicinc.com +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/soc/qcom/pmic_glink.c | 25 +++++++++++++++---------- + 1 file changed, 15 insertions(+), 10 deletions(-) + +diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c +index e85a12ec2aab1..823fd108fa039 100644 +--- a/drivers/soc/qcom/pmic_glink.c ++++ b/drivers/soc/qcom/pmic_glink.c +@@ -11,6 +11,7 @@ + #include + #include + #include ++#include + + enum { + PMIC_GLINK_CLIENT_BATT = 0, +@@ -36,7 +37,7 @@ struct pmic_glink { + unsigned int pdr_state; + + /* serializing clients list updates */ +- struct mutex client_lock; ++ spinlock_t client_lock; + struct list_head clients; + }; + +@@ -58,10 +59,11 @@ static void _devm_pmic_glink_release_client(struct device *dev, void *res) + { + struct pmic_glink_client *client = (struct pmic_glink_client *)res; + struct pmic_glink *pg = client->pg; ++ unsigned long flags; + +- mutex_lock(&pg->client_lock); ++ spin_lock_irqsave(&pg->client_lock, flags); + list_del(&client->node); +- mutex_unlock(&pg->client_lock); ++ spin_unlock_irqrestore(&pg->client_lock, flags); + } + + struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, +@@ -72,6 +74,7 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, + { + struct pmic_glink_client *client; + struct pmic_glink *pg = dev_get_drvdata(dev->parent); ++ unsigned long flags; + + client = devres_alloc(_devm_pmic_glink_release_client, sizeof(*client), GFP_KERNEL); + if (!client) +@@ -84,12 +87,12 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, + client->priv = priv; + + mutex_lock(&pg->state_lock); +- mutex_lock(&pg->client_lock); ++ spin_lock_irqsave(&pg->client_lock, flags); + + list_add(&client->node, &pg->clients); + client->pdr_notify(client->priv, pg->client_state); + +- mutex_unlock(&pg->client_lock); ++ spin_unlock_irqrestore(&pg->client_lock, flags); + mutex_unlock(&pg->state_lock); + + devres_add(dev, client); +@@ -112,6 +115,7 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data, + struct pmic_glink_client *client; + struct pmic_glink_hdr *hdr; + struct pmic_glink *pg = dev_get_drvdata(&rpdev->dev); ++ unsigned long flags; + + if (len < sizeof(*hdr)) { + dev_warn(pg->dev, "ignoring truncated message\n"); +@@ -120,12 +124,12 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data, + + hdr = data; + +- mutex_lock(&pg->client_lock); ++ spin_lock_irqsave(&pg->client_lock, flags); + list_for_each_entry(client, &pg->clients, node) { + if (client->id == le32_to_cpu(hdr->owner)) + client->cb(data, len, client->priv); + } +- mutex_unlock(&pg->client_lock); ++ spin_unlock_irqrestore(&pg->client_lock, flags); + + return 0; + } +@@ -165,6 +169,7 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg) + { + struct pmic_glink_client *client; + unsigned int new_state = pg->client_state; ++ unsigned long flags; + + if (pg->client_state != SERVREG_SERVICE_STATE_UP) { + if (pg->pdr_state == SERVREG_SERVICE_STATE_UP && pg->ept) +@@ -175,10 +180,10 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg) + } + + if (new_state != pg->client_state) { +- mutex_lock(&pg->client_lock); ++ spin_lock_irqsave(&pg->client_lock, flags); + list_for_each_entry(client, &pg->clients, node) + client->pdr_notify(client->priv, new_state); +- mutex_unlock(&pg->client_lock); ++ spin_unlock_irqrestore(&pg->client_lock, flags); + pg->client_state = new_state; + } + } +@@ -265,7 +270,7 @@ static int pmic_glink_probe(struct platform_device *pdev) + pg->dev = &pdev->dev; + + INIT_LIST_HEAD(&pg->clients); +- mutex_init(&pg->client_lock); ++ spin_lock_init(&pg->client_lock); + mutex_init(&pg->state_lock); + + match_data = (unsigned long *)of_device_get_match_data(&pdev->dev); +-- +2.43.0 + diff --git a/queue-6.8/soc-qcom-pmic_glink-notify-clients-about-the-current.patch b/queue-6.8/soc-qcom-pmic_glink-notify-clients-about-the-current.patch new file mode 100644 index 00000000000..e523a18dd61 --- /dev/null +++ b/queue-6.8/soc-qcom-pmic_glink-notify-clients-about-the-current.patch @@ -0,0 +1,48 @@ +From 64d1bdd5f40a2212529e3ab3be56b9acc9ba33db Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 06:10:58 +0300 +Subject: soc: qcom: pmic_glink: notify clients about the current state + +From: Dmitry Baryshkov + +[ Upstream commit d6cbce2cd354c9a37a558f290a8f1dfd20584f99 ] + +In case the client is registered after the pmic-glink recived a response +from the Protection Domain mapper, it is going to miss the notification +about the state. Notify clients about the current state upon +registration. + +Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") +Reviewed-by: Andrew Halaney +Signed-off-by: Dmitry Baryshkov +Reviewed-by: Mukesh Ojha +Tested-by: Xilin Wu # on QCS8550 AYN Odin 2 +Link: https://lore.kernel.org/r/20240403-pmic-glink-fix-clients-v2-2-aed4e02baacc@linaro.org +Signed-off-by: Bjorn Andersson +Signed-off-by: Sasha Levin +--- + drivers/soc/qcom/pmic_glink.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c +index 2b2cdf4796542..e85a12ec2aab1 100644 +--- a/drivers/soc/qcom/pmic_glink.c ++++ b/drivers/soc/qcom/pmic_glink.c +@@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, + client->pdr_notify = pdr; + client->priv = priv; + ++ mutex_lock(&pg->state_lock); + mutex_lock(&pg->client_lock); ++ + list_add(&client->node, &pg->clients); ++ client->pdr_notify(client->priv, pg->client_state); ++ + mutex_unlock(&pg->client_lock); ++ mutex_unlock(&pg->state_lock); + + devres_add(dev, client); + +-- +2.43.0 + diff --git a/queue-6.8/softirq-fix-suspicious-rcu-usage-in-__do_softirq.patch b/queue-6.8/softirq-fix-suspicious-rcu-usage-in-__do_softirq.patch new file mode 100644 index 00000000000..8e5684e061e --- /dev/null +++ b/queue-6.8/softirq-fix-suspicious-rcu-usage-in-__do_softirq.patch @@ -0,0 +1,102 @@ +From 5d4d440d94e212b984148f6bc7b3d413f72dd5f4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 27 Apr 2024 18:28:08 +0800 +Subject: softirq: Fix suspicious RCU usage in __do_softirq() + +From: Zqiang + +[ Upstream commit 1dd1eff161bd55968d3d46bc36def62d71fb4785 ] + +Currently, the condition "__this_cpu_read(ksoftirqd) == current" is used to +invoke rcu_softirq_qs() in ksoftirqd tasks context for non-RT kernels. + +This works correctly as long as the context is actually task context but +this condition is wrong when: + + - the current task is ksoftirqd + - the task is interrupted in a RCU read side critical section + - __do_softirq() is invoked on return from interrupt + +Syzkaller triggered the following scenario: + + -> finish_task_switch() + -> put_task_struct_rcu_user() + -> call_rcu(&task->rcu, delayed_put_task_struct) + -> __kasan_record_aux_stack() + -> pfn_valid() + -> rcu_read_lock_sched() + + __irq_exit_rcu() + -> __do_softirq)() + -> if (!IS_ENABLED(CONFIG_PREEMPT_RT) && + __this_cpu_read(ksoftirqd) == current) + -> rcu_softirq_qs() + -> RCU_LOCKDEP_WARN(lock_is_held(&rcu_sched_lock_map)) + +The rcu quiescent state is reported in the rcu-read critical section, so +the lockdep warning is triggered. + +Fix this by splitting out the inner working of __do_softirq() into a helper +function which takes an argument to distinguish between ksoftirqd task +context and interrupted context and invoke it from the relevant call sites +with the proper context information and use that for the conditional +invocation of rcu_softirq_qs(). + +Reported-by: syzbot+dce04ed6d1438ad69656@syzkaller.appspotmail.com +Suggested-by: Thomas Gleixner +Signed-off-by: Zqiang +Signed-off-by: Thomas Gleixner +Link: https://lore.kernel.org/r/20240427102808.29356-1-qiang.zhang1211@gmail.com +Link: https://lore.kernel.org/lkml/8f281a10-b85a-4586-9586-5bbc12dc784f@paulmck-laptop/T/#mea8aba4abfcb97bbf499d169ce7f30c4cff1b0e3 +Signed-off-by: Sasha Levin +--- + kernel/softirq.c | 12 ++++++++---- + 1 file changed, 8 insertions(+), 4 deletions(-) + +diff --git a/kernel/softirq.c b/kernel/softirq.c +index 210cf5f8d92c2..bd9716d7bb638 100644 +--- a/kernel/softirq.c ++++ b/kernel/softirq.c +@@ -507,7 +507,7 @@ static inline bool lockdep_softirq_start(void) { return false; } + static inline void lockdep_softirq_end(bool in_hardirq) { } + #endif + +-asmlinkage __visible void __softirq_entry __do_softirq(void) ++static void handle_softirqs(bool ksirqd) + { + unsigned long end = jiffies + MAX_SOFTIRQ_TIME; + unsigned long old_flags = current->flags; +@@ -562,8 +562,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void) + pending >>= softirq_bit; + } + +- if (!IS_ENABLED(CONFIG_PREEMPT_RT) && +- __this_cpu_read(ksoftirqd) == current) ++ if (!IS_ENABLED(CONFIG_PREEMPT_RT) && ksirqd) + rcu_softirq_qs(); + + local_irq_disable(); +@@ -583,6 +582,11 @@ asmlinkage __visible void __softirq_entry __do_softirq(void) + current_restore_flags(old_flags, PF_MEMALLOC); + } + ++asmlinkage __visible void __softirq_entry __do_softirq(void) ++{ ++ handle_softirqs(false); ++} ++ + /** + * irq_enter_rcu - Enter an interrupt context with RCU watching + */ +@@ -918,7 +922,7 @@ static void run_ksoftirqd(unsigned int cpu) + * We can safely run softirq on inline stack, as we are not deep + * in the task stack here. + */ +- __do_softirq(); ++ handle_softirqs(true); + ksoftirqd_run_end(); + cond_resched(); + return; +-- +2.43.0 + diff --git a/queue-6.8/staging-media-starfive-remove-links-when-unregisteri.patch b/queue-6.8/staging-media-starfive-remove-links-when-unregisteri.patch new file mode 100644 index 00000000000..6efac4d42e1 --- /dev/null +++ b/queue-6.8/staging-media-starfive-remove-links-when-unregisteri.patch @@ -0,0 +1,40 @@ +From 3fb754955d54a6f44b36eb7d0953d99a0ad1c3c1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 11 Mar 2024 05:03:09 -0700 +Subject: staging: media: starfive: Remove links when unregistering devices + +From: Changhuang Liang + +[ Upstream commit 810dd605e917c716f6f83e6cd8ea23d9155d32a2 ] + +Need to remove links when unregistering devices. + +Fixes: ac7da4a73b10 ("media: staging: media: starfive: camss: Register devices") + +Signed-off-by: Changhuang Liang +Signed-off-by: Hans Verkuil +Signed-off-by: Sasha Levin +--- + drivers/staging/media/starfive/camss/stf-camss.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/drivers/staging/media/starfive/camss/stf-camss.c b/drivers/staging/media/starfive/camss/stf-camss.c +index a587f860101ae..323aa70fdeaf1 100644 +--- a/drivers/staging/media/starfive/camss/stf-camss.c ++++ b/drivers/staging/media/starfive/camss/stf-camss.c +@@ -162,6 +162,12 @@ static int stfcamss_register_devs(struct stfcamss *stfcamss) + + static void stfcamss_unregister_devs(struct stfcamss *stfcamss) + { ++ struct stf_capture *cap_yuv = &stfcamss->captures[STF_CAPTURE_YUV]; ++ struct stf_isp_dev *isp_dev = &stfcamss->isp_dev; ++ ++ media_entity_remove_links(&isp_dev->subdev.entity); ++ media_entity_remove_links(&cap_yuv->video.vdev.entity); ++ + stf_isp_unregister(&stfcamss->isp_dev); + stf_capture_unregister(stfcamss); + } +-- +2.43.0 + diff --git a/queue-6.8/sunrpc-fix-gss_free_in_token_pages.patch b/queue-6.8/sunrpc-fix-gss_free_in_token_pages.patch new file mode 100644 index 00000000000..6677271f73a --- /dev/null +++ b/queue-6.8/sunrpc-fix-gss_free_in_token_pages.patch @@ -0,0 +1,78 @@ +From b91759c8d423c9322673ecd4887826ad337dec73 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 7 May 2024 09:10:41 -0400 +Subject: SUNRPC: Fix gss_free_in_token_pages() + +From: Chuck Lever + +[ Upstream commit bafa6b4d95d97877baa61883ff90f7e374427fae ] + +Dan Carpenter says: +> Commit 5866efa8cbfb ("SUNRPC: Fix svcauth_gss_proxy_init()") from Oct +> 24, 2019 (linux-next), leads to the following Smatch static checker +> warning: +> +> net/sunrpc/auth_gss/svcauth_gss.c:1039 gss_free_in_token_pages() +> warn: iterator 'i' not incremented +> +> net/sunrpc/auth_gss/svcauth_gss.c +> 1034 static void gss_free_in_token_pages(struct gssp_in_token *in_token) +> 1035 { +> 1036 u32 inlen; +> 1037 int i; +> 1038 +> --> 1039 i = 0; +> 1040 inlen = in_token->page_len; +> 1041 while (inlen) { +> 1042 if (in_token->pages[i]) +> 1043 put_page(in_token->pages[i]); +> ^ +> This puts page zero over and over. +> +> 1044 inlen -= inlen > PAGE_SIZE ? PAGE_SIZE : inlen; +> 1045 } +> 1046 +> 1047 kfree(in_token->pages); +> 1048 in_token->pages = NULL; +> 1049 } + +Based on the way that the ->pages[] array is constructed in +gss_read_proxy_verf(), we know that once the loop encounters a NULL +page pointer, the remaining array elements must also be NULL. + +Reported-by: Dan Carpenter +Suggested-by: Trond Myklebust +Fixes: 5866efa8cbfb ("SUNRPC: Fix svcauth_gss_proxy_init()") +Signed-off-by: Chuck Lever +Signed-off-by: Sasha Levin +--- + net/sunrpc/auth_gss/svcauth_gss.c | 10 ++-------- + 1 file changed, 2 insertions(+), 8 deletions(-) + +diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c +index 24de941847003..96ab50eda9c2e 100644 +--- a/net/sunrpc/auth_gss/svcauth_gss.c ++++ b/net/sunrpc/auth_gss/svcauth_gss.c +@@ -1033,17 +1033,11 @@ svcauth_gss_proc_init_verf(struct cache_detail *cd, struct svc_rqst *rqstp, + + static void gss_free_in_token_pages(struct gssp_in_token *in_token) + { +- u32 inlen; + int i; + + i = 0; +- inlen = in_token->page_len; +- while (inlen) { +- if (in_token->pages[i]) +- put_page(in_token->pages[i]); +- inlen -= inlen > PAGE_SIZE ? PAGE_SIZE : inlen; +- } +- ++ while (in_token->pages[i]) ++ put_page(in_token->pages[i++]); + kfree(in_token->pages); + in_token->pages = NULL; + } +-- +2.43.0 + diff --git a/queue-6.8/sunrpc-removed-redundant-procp-check.patch b/queue-6.8/sunrpc-removed-redundant-procp-check.patch new file mode 100644 index 00000000000..4c826c5b717 --- /dev/null +++ b/queue-6.8/sunrpc-removed-redundant-procp-check.patch @@ -0,0 +1,39 @@ +From f70671811f1fa314b468988a60015543fa2af7d9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 27 Mar 2024 14:10:44 +0700 +Subject: sunrpc: removed redundant procp check + +From: Aleksandr Aprelkov + +[ Upstream commit a576f36971ab4097b6aa76433532aa1fb5ee2d3b ] + +since vs_proc pointer is dereferenced before getting it's address there's +no need to check for NULL. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: 8e5b67731d08 ("SUNRPC: Add a callback to initialise server requests") +Signed-off-by: Aleksandr Aprelkov +Reviewed-by: Jeff Layton +Signed-off-by: Chuck Lever +Signed-off-by: Sasha Levin +--- + net/sunrpc/svc.c | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c +index b969e505c7b77..bd61e257cda6a 100644 +--- a/net/sunrpc/svc.c ++++ b/net/sunrpc/svc.c +@@ -1263,8 +1263,6 @@ svc_generic_init_request(struct svc_rqst *rqstp, + if (rqstp->rq_proc >= versp->vs_nproc) + goto err_bad_proc; + rqstp->rq_procinfo = procp = &versp->vs_proc[rqstp->rq_proc]; +- if (!procp) +- goto err_bad_proc; + + /* Initialize storage for argp and resp */ + memset(rqstp->rq_argp, 0, procp->pc_argzero); +-- +2.43.0 + diff --git a/queue-6.8/tcp-avoid-premature-drops-in-tcp_add_backlog.patch b/queue-6.8/tcp-avoid-premature-drops-in-tcp_add_backlog.patch new file mode 100644 index 00000000000..3f4a925bae1 --- /dev/null +++ b/queue-6.8/tcp-avoid-premature-drops-in-tcp_add_backlog.patch @@ -0,0 +1,87 @@ +From c563b943f751f1c254e21a35abd3171af1106b6c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 12:56:20 +0000 +Subject: tcp: avoid premature drops in tcp_add_backlog() + +From: Eric Dumazet + +[ Upstream commit ec00ed472bdb7d0af840da68c8c11bff9f4d9caa ] + +While testing TCP performance with latest trees, +I saw suspect SOCKET_BACKLOG drops. + +tcp_add_backlog() computes its limit with : + + limit = (u32)READ_ONCE(sk->sk_rcvbuf) + + (u32)(READ_ONCE(sk->sk_sndbuf) >> 1); + limit += 64 * 1024; + +This does not take into account that sk->sk_backlog.len +is reset only at the very end of __release_sock(). + +Both sk->sk_backlog.len and sk->sk_rmem_alloc could reach +sk_rcvbuf in normal conditions. + +We should double sk->sk_rcvbuf contribution in the formula +to absorb bubbles in the backlog, which happen more often +for very fast flows. + +This change maintains decent protection against abuses. + +Fixes: c377411f2494 ("net: sk_add_backlog() take rmem_alloc into account") +Signed-off-by: Eric Dumazet +Link: https://lore.kernel.org/r/20240423125620.3309458-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + net/ipv4/tcp_ipv4.c | 13 +++++++++++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c +index 68a065c0e5081..abd47159d7e4d 100644 +--- a/net/ipv4/tcp_ipv4.c ++++ b/net/ipv4/tcp_ipv4.c +@@ -2000,7 +2000,7 @@ int tcp_v4_early_demux(struct sk_buff *skb) + bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb, + enum skb_drop_reason *reason) + { +- u32 limit, tail_gso_size, tail_gso_segs; ++ u32 tail_gso_size, tail_gso_segs; + struct skb_shared_info *shinfo; + const struct tcphdr *th; + struct tcphdr *thtail; +@@ -2009,6 +2009,7 @@ bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb, + bool fragstolen; + u32 gso_segs; + u32 gso_size; ++ u64 limit; + int delta; + + /* In case all data was pulled from skb frags (in __pskb_pull_tail()), +@@ -2106,7 +2107,13 @@ bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb, + __skb_push(skb, hdrlen); + + no_coalesce: +- limit = (u32)READ_ONCE(sk->sk_rcvbuf) + (u32)(READ_ONCE(sk->sk_sndbuf) >> 1); ++ /* sk->sk_backlog.len is reset only at the end of __release_sock(). ++ * Both sk->sk_backlog.len and sk->sk_rmem_alloc could reach ++ * sk_rcvbuf in normal conditions. ++ */ ++ limit = ((u64)READ_ONCE(sk->sk_rcvbuf)) << 1; ++ ++ limit += ((u32)READ_ONCE(sk->sk_sndbuf)) >> 1; + + /* Only socket owner can try to collapse/prune rx queues + * to reduce memory overhead, so add a little headroom here. +@@ -2114,6 +2121,8 @@ bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb, + */ + limit += 64 * 1024; + ++ limit = min_t(u64, limit, UINT_MAX); ++ + if (unlikely(sk_add_backlog(sk, skb, limit))) { + bh_unlock_sock(sk); + *reason = SKB_DROP_REASON_SOCKET_BACKLOG; +-- +2.43.0 + diff --git a/queue-6.8/tcp-increase-the-default-tcp-scaling-ratio.patch b/queue-6.8/tcp-increase-the-default-tcp-scaling-ratio.patch new file mode 100644 index 00000000000..22a62bce582 --- /dev/null +++ b/queue-6.8/tcp-increase-the-default-tcp-scaling-ratio.patch @@ -0,0 +1,71 @@ +From 8024941b574f20c908380c13481b56aee8107499 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 9 Apr 2024 09:43:55 -0700 +Subject: tcp: increase the default TCP scaling ratio + +From: Hechao Li + +[ Upstream commit 697a6c8cec03c2299f850fa50322641a8bf6b915 ] + +After commit dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale"), +we noticed an application-level timeout due to reduced throughput. + +Before the commit, for a client that sets SO_RCVBUF to 65k, it takes +around 22 seconds to transfer 10M data. After the commit, it takes 40 +seconds. Because our application has a 30-second timeout, this +regression broke the application. + +The reason that it takes longer to transfer data is that +tp->scaling_ratio is initialized to a value that results in ~0.25 of +rcvbuf. In our case, SO_RCVBUF is set to 65536 by the application, which +translates to 2 * 65536 = 131,072 bytes in rcvbuf and hence a ~28k +initial receive window. + +Later, even though the scaling_ratio is updated to a more accurate +skb->len/skb->truesize, which is ~0.66 in our environment, the window +stays at ~0.25 * rcvbuf. This is because tp->window_clamp does not +change together with the tp->scaling_ratio update when autotuning is +disabled due to SO_RCVBUF. As a result, the window size is capped at the +initial window_clamp, which is also ~0.25 * rcvbuf, and never grows +bigger. + +Most modern applications let the kernel do autotuning, and benefit from +the increased scaling_ratio. But there are applications such as kafka +that has a default setting of SO_RCVBUF=64k. + +This patch increases the initial scaling_ratio from ~25% to 50% in order +to make it backward compatible with the original default +sysctl_tcp_adv_win_scale for applications setting SO_RCVBUF. + +Fixes: dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale") +Signed-off-by: Hechao Li +Reviewed-by: Tycho Andersen +Reviewed-by: Eric Dumazet +Link: https://lore.kernel.org/netdev/20240402215405.432863-1-hli@netflix.com/ +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + include/net/tcp.h | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/include/net/tcp.h b/include/net/tcp.h +index f6eba9652d010..ab62e53f187c5 100644 +--- a/include/net/tcp.h ++++ b/include/net/tcp.h +@@ -1494,11 +1494,10 @@ static inline int tcp_space_from_win(const struct sock *sk, int win) + return __tcp_space_from_win(tcp_sk(sk)->scaling_ratio, win); + } + +-/* Assume a conservative default of 1200 bytes of payload per 4K page. ++/* Assume a 50% default for skb->len/skb->truesize ratio. + * This may be adjusted later in tcp_measure_rcv_mss(). + */ +-#define TCP_DEFAULT_SCALING_RATIO ((1200 << TCP_RMEM_TO_WIN_SCALE) / \ +- SKB_TRUESIZE(4096)) ++#define TCP_DEFAULT_SCALING_RATIO (1 << (TCP_RMEM_TO_WIN_SCALE - 1)) + + static inline void tcp_scaling_ratio_init(struct sock *sk) + { +-- +2.43.0 + diff --git a/queue-6.8/thermal-debugfs-avoid-excessive-updates-of-trip-poin.patch b/queue-6.8/thermal-debugfs-avoid-excessive-updates-of-trip-poin.patch new file mode 100644 index 00000000000..e7747bee23a --- /dev/null +++ b/queue-6.8/thermal-debugfs-avoid-excessive-updates-of-trip-poin.patch @@ -0,0 +1,86 @@ +From 938626b6e0bf2dce523bcd2e8bebe4d845ca98a4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 17 Apr 2024 15:09:46 +0200 +Subject: thermal/debugfs: Avoid excessive updates of trip point statistics + +From: Rafael J. Wysocki + +[ Upstream commit 0a293c77580581c4b058eb40287acadac6ffd14a ] + +Since thermal_debug_update_temp() is called before invoking +thermal_debug_tz_trip_down() for the trips that were crossed by the +zone temperature on the way up, it updates the statistics for them +as though the current zone temperature was above the low temperature +of each of them. However, if a given trip has just been crossed on the +way down, the zone temperature is in fact below its low temperature, +but this is handled by thermal_debug_tz_trip_down() running after the +update of the trip statistics. + +The remedy is to call thermal_debug_update_temp() after +thermal_debug_tz_trip_down() has been invoked for all of the +trips in question, but then thermal_debug_tz_trip_up() needs to +be adjusted, so it does not update the statistics for the trips +that has just been crossed on the way up, as that will be taken +care of by thermal_debug_update_temp() down the road. + +Modify the code accordingly. + +Fixes: 7ef01f228c9f ("thermal/debugfs: Add thermal debugfs information for mitigation episodes") +Signed-off-by: Rafael J. Wysocki +Reviewed-by: Lukasz Luba +Acked-by: Daniel Lezcano +Signed-off-by: Sasha Levin +--- + drivers/thermal/thermal_core.c | 3 ++- + drivers/thermal/thermal_debugfs.c | 7 ------- + 2 files changed, 2 insertions(+), 8 deletions(-) + +diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c +index dfaa6341694a0..1818901d37ca8 100644 +--- a/drivers/thermal/thermal_core.c ++++ b/drivers/thermal/thermal_core.c +@@ -432,7 +432,6 @@ static void update_temperature(struct thermal_zone_device *tz) + trace_thermal_temperature(tz); + + thermal_genl_sampling_temp(tz->id, temp); +- thermal_debug_update_temp(tz); + } + + static void thermal_zone_device_check(struct work_struct *work) +@@ -476,6 +475,8 @@ void __thermal_zone_device_update(struct thermal_zone_device *tz, + for_each_trip(tz, trip) + handle_thermal_trip(tz, trip); + ++ thermal_debug_update_temp(tz); ++ + monitor_thermal_zone(tz); + } + +diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c +index 5693cc8b231aa..47ab95b3699e9 100644 +--- a/drivers/thermal/thermal_debugfs.c ++++ b/drivers/thermal/thermal_debugfs.c +@@ -555,7 +555,6 @@ void thermal_debug_tz_trip_up(struct thermal_zone_device *tz, + struct tz_episode *tze; + struct tz_debugfs *tz_dbg; + struct thermal_debugfs *thermal_dbg = tz->debugfs; +- int temperature = tz->temperature; + int trip_id = thermal_zone_trip_id(tz, trip); + ktime_t now = ktime_get(); + +@@ -624,12 +623,6 @@ void thermal_debug_tz_trip_up(struct thermal_zone_device *tz, + + tze = list_first_entry(&tz_dbg->tz_episodes, struct tz_episode, node); + tze->trip_stats[trip_id].timestamp = now; +- tze->trip_stats[trip_id].max = max(tze->trip_stats[trip_id].max, temperature); +- tze->trip_stats[trip_id].min = min(tze->trip_stats[trip_id].min, temperature); +- tze->trip_stats[trip_id].count++; +- tze->trip_stats[trip_id].avg = tze->trip_stats[trip_id].avg + +- (temperature - tze->trip_stats[trip_id].avg) / +- tze->trip_stats[trip_id].count; + + unlock: + mutex_unlock(&thermal_dbg->lock); +-- +2.43.0 + diff --git a/queue-6.8/thermal-debugfs-create-records-for-cdev-states-as-th.patch b/queue-6.8/thermal-debugfs-create-records-for-cdev-states-as-th.patch new file mode 100644 index 00000000000..47fb17be9f5 --- /dev/null +++ b/queue-6.8/thermal-debugfs-create-records-for-cdev-states-as-th.patch @@ -0,0 +1,50 @@ +From 8f242c055e873ca3e959596b954275a6a63e0a59 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 14:24:10 +0200 +Subject: thermal/debugfs: Create records for cdev states as they get used + +From: Rafael J. Wysocki + +[ Upstream commit f4ae18fcb652c6cccc834ded525ac37f91d5cdb1 ] + +Because thermal_debug_cdev_state_update() only creates a duration record +for the old state of a cooling device, if its new state is used for the +first time, there will be no record for it and cdev_dt_seq_show() will +not print the duration information for it even though it contains code +to compute the duration value in that case. + +Address this by making thermal_debug_cdev_state_update() create a +duration record for the new state if there is none. + +Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information") +Reported-by: Lukasz Luba +Signed-off-by: Rafael J. Wysocki +Reviewed-by: Lukasz Luba +Tested-by: Lukasz Luba +Signed-off-by: Sasha Levin +--- + drivers/thermal/thermal_debugfs.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c +index 47ab95b3699e9..2891d2ab4875c 100644 +--- a/drivers/thermal/thermal_debugfs.c ++++ b/drivers/thermal/thermal_debugfs.c +@@ -435,6 +435,14 @@ void thermal_debug_cdev_state_update(const struct thermal_cooling_device *cdev, + } + + cdev_dbg->current_state = new_state; ++ ++ /* ++ * Create a record for the new state if it is not there, so its ++ * duration will be printed by cdev_dt_seq_show() as expected if it ++ * runs before the next state transition. ++ */ ++ thermal_debugfs_cdev_record_get(thermal_dbg, cdev_dbg->durations, new_state); ++ + transition = (old_state << 16) | new_state; + + /* +-- +2.43.0 + diff --git a/queue-6.8/thermal-debugfs-pass-cooling-device-state-to-thermal.patch b/queue-6.8/thermal-debugfs-pass-cooling-device-state-to-thermal.patch new file mode 100644 index 00000000000..b4dd6f12963 --- /dev/null +++ b/queue-6.8/thermal-debugfs-pass-cooling-device-state-to-thermal.patch @@ -0,0 +1,131 @@ +From 59723016edf07ee01f6f5005d9ffb241a2ccd36e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 25 Apr 2024 14:24:20 +0200 +Subject: thermal/debugfs: Pass cooling device state to + thermal_debug_cdev_add() + +From: Rafael J. Wysocki + +[ Upstream commit 31a0fa0019b022024cc082ae292951a596b06f8c ] + +If cdev_dt_seq_show() runs before the first state transition of a cooling +device, it will not print any state residency information for it, even +though it might be reasonably expected to print residency information for +the initial state of the cooling device. + +For this reason, rearrange the code to get the initial state of a cooling +device at the registration time and pass it to thermal_debug_cdev_add(), +so that the latter can create a duration record for that state which will +allow cdev_dt_seq_show() to print its residency information. + +Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information") +Reported-by: Lukasz Luba +Signed-off-by: Rafael J. Wysocki +Reviewed-by: Lukasz Luba +Tested-by: Lukasz Luba +Signed-off-by: Sasha Levin +--- + drivers/thermal/thermal_core.c | 9 +++++++-- + drivers/thermal/thermal_debugfs.c | 12 ++++++++++-- + drivers/thermal/thermal_debugfs.h | 4 ++-- + 3 files changed, 19 insertions(+), 6 deletions(-) + +diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c +index 1818901d37ca8..5975bf380826d 100644 +--- a/drivers/thermal/thermal_core.c ++++ b/drivers/thermal/thermal_core.c +@@ -899,6 +899,7 @@ __thermal_cooling_device_register(struct device_node *np, + { + struct thermal_cooling_device *cdev; + struct thermal_zone_device *pos = NULL; ++ unsigned long current_state; + int id, ret; + + if (!ops || !ops->get_max_state || !ops->get_cur_state || +@@ -936,6 +937,10 @@ __thermal_cooling_device_register(struct device_node *np, + if (ret) + goto out_cdev_type; + ++ ret = cdev->ops->get_cur_state(cdev, ¤t_state); ++ if (ret) ++ goto out_cdev_type; ++ + thermal_cooling_device_setup_sysfs(cdev); + + ret = dev_set_name(&cdev->device, "cooling_device%d", cdev->id); +@@ -949,6 +954,8 @@ __thermal_cooling_device_register(struct device_node *np, + return ERR_PTR(ret); + } + ++ thermal_debug_cdev_add(cdev, current_state); ++ + /* Add 'this' new cdev to the global cdev list */ + mutex_lock(&thermal_list_lock); + +@@ -964,8 +971,6 @@ __thermal_cooling_device_register(struct device_node *np, + + mutex_unlock(&thermal_list_lock); + +- thermal_debug_cdev_add(cdev); +- + return cdev; + + out_cooling_dev: +diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c +index 2891d2ab4875c..403f74d663dce 100644 +--- a/drivers/thermal/thermal_debugfs.c ++++ b/drivers/thermal/thermal_debugfs.c +@@ -468,8 +468,9 @@ void thermal_debug_cdev_state_update(const struct thermal_cooling_device *cdev, + * Allocates a cooling device object for debug, initializes the + * statistics and create the entries in sysfs. + * @cdev: a pointer to a cooling device ++ * @state: current state of the cooling device + */ +-void thermal_debug_cdev_add(struct thermal_cooling_device *cdev) ++void thermal_debug_cdev_add(struct thermal_cooling_device *cdev, int state) + { + struct thermal_debugfs *thermal_dbg; + struct cdev_debugfs *cdev_dbg; +@@ -486,9 +487,16 @@ void thermal_debug_cdev_add(struct thermal_cooling_device *cdev) + INIT_LIST_HEAD(&cdev_dbg->durations[i]); + } + +- cdev_dbg->current_state = 0; ++ cdev_dbg->current_state = state; + cdev_dbg->timestamp = ktime_get(); + ++ /* ++ * Create a record for the initial cooling device state, so its ++ * duration will be printed by cdev_dt_seq_show() as expected if it ++ * runs before the first state transition. ++ */ ++ thermal_debugfs_cdev_record_get(thermal_dbg, cdev_dbg->durations, state); ++ + debugfs_create_file("trans_table", 0400, thermal_dbg->d_top, + thermal_dbg, &tt_fops); + +diff --git a/drivers/thermal/thermal_debugfs.h b/drivers/thermal/thermal_debugfs.h +index 155b9af5fe870..c28bd4c114124 100644 +--- a/drivers/thermal/thermal_debugfs.h ++++ b/drivers/thermal/thermal_debugfs.h +@@ -2,7 +2,7 @@ + + #ifdef CONFIG_THERMAL_DEBUGFS + void thermal_debug_init(void); +-void thermal_debug_cdev_add(struct thermal_cooling_device *cdev); ++void thermal_debug_cdev_add(struct thermal_cooling_device *cdev, int state); + void thermal_debug_cdev_remove(struct thermal_cooling_device *cdev); + void thermal_debug_cdev_state_update(const struct thermal_cooling_device *cdev, int state); + void thermal_debug_tz_add(struct thermal_zone_device *tz); +@@ -14,7 +14,7 @@ void thermal_debug_tz_trip_down(struct thermal_zone_device *tz, + void thermal_debug_update_temp(struct thermal_zone_device *tz); + #else + static inline void thermal_debug_init(void) {} +-static inline void thermal_debug_cdev_add(struct thermal_cooling_device *cdev) {} ++static inline void thermal_debug_cdev_add(struct thermal_cooling_device *cdev, int state) {} + static inline void thermal_debug_cdev_remove(struct thermal_cooling_device *cdev) {} + static inline void thermal_debug_cdev_state_update(const struct thermal_cooling_device *cdev, + int state) {} +-- +2.43.0 + diff --git a/queue-6.8/thermal-drivers-mediatek-lvts_thermal-add-coeff-for-.patch b/queue-6.8/thermal-drivers-mediatek-lvts_thermal-add-coeff-for-.patch new file mode 100644 index 00000000000..4c1049c146c --- /dev/null +++ b/queue-6.8/thermal-drivers-mediatek-lvts_thermal-add-coeff-for-.patch @@ -0,0 +1,45 @@ +From 8d954a8031ee2263fe10b21e7dd528fceb54f00a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 07:35:47 +0000 +Subject: thermal/drivers/mediatek/lvts_thermal: Add coeff for mt8192 + +From: Hsin-Te Yuan + +[ Upstream commit 7954c92ede882b0dfd52a5db90291a4151b44c1a ] + +In order for lvts_raw_to_temp to function properly on mt8192, +temperature coefficients for mt8192 need to be added. + +Fixes: 288732242db4 ("thermal/drivers/mediatek/lvts_thermal: Add mt8192 support") +Signed-off-by: Hsin-Te Yuan +Reviewed-by: AngeloGioacchino Del Regno +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/20240416-lvts_thermal-v2-1-f8a36882cc53@chromium.org +Signed-off-by: Sasha Levin +--- + drivers/thermal/mediatek/lvts_thermal.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c +index fd4bd650c77a6..4e5c213a89225 100644 +--- a/drivers/thermal/mediatek/lvts_thermal.c ++++ b/drivers/thermal/mediatek/lvts_thermal.c +@@ -1530,11 +1530,15 @@ static const struct lvts_data mt7988_lvts_ap_data = { + static const struct lvts_data mt8192_lvts_mcu_data = { + .lvts_ctrl = mt8192_lvts_mcu_data_ctrl, + .num_lvts_ctrl = ARRAY_SIZE(mt8192_lvts_mcu_data_ctrl), ++ .temp_factor = LVTS_COEFF_A_MT8195, ++ .temp_offset = LVTS_COEFF_B_MT8195, + }; + + static const struct lvts_data mt8192_lvts_ap_data = { + .lvts_ctrl = mt8192_lvts_ap_data_ctrl, + .num_lvts_ctrl = ARRAY_SIZE(mt8192_lvts_ap_data_ctrl), ++ .temp_factor = LVTS_COEFF_A_MT8195, ++ .temp_offset = LVTS_COEFF_B_MT8195, + }; + + static const struct lvts_data mt8195_lvts_mcu_data = { +-- +2.43.0 + diff --git a/queue-6.8/thermal-drivers-tsens-fix-null-pointer-dereference.patch b/queue-6.8/thermal-drivers-tsens-fix-null-pointer-dereference.patch new file mode 100644 index 00000000000..565a5a770da --- /dev/null +++ b/queue-6.8/thermal-drivers-tsens-fix-null-pointer-dereference.patch @@ -0,0 +1,42 @@ +From afaf6aa48b265c744e5f7ca9ac2b85e744a8f920 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 11 Apr 2024 14:40:21 +0300 +Subject: thermal/drivers/tsens: Fix null pointer dereference + +From: Aleksandr Mishin + +[ Upstream commit d998ddc86a27c92140b9f7984ff41e3d1d07a48f ] + +compute_intercept_slope() is called from calibrate_8960() (in tsens-8960.c) +as compute_intercept_slope(priv, p1, NULL, ONE_PT_CALIB) which lead to null +pointer dereference (if DEBUG or DYNAMIC_DEBUG set). +Fix this bug by adding null pointer check. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Fixes: dfc1193d4dbd ("thermal/drivers/tsens: Replace custom 8960 apis with generic apis") +Signed-off-by: Aleksandr Mishin +Reviewed-by: Konrad Dybcio +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/20240411114021.12203-1-amishin@t-argos.ru +Signed-off-by: Sasha Levin +--- + drivers/thermal/qcom/tsens.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c +index 6d7c16ccb44dc..4edee8d929a75 100644 +--- a/drivers/thermal/qcom/tsens.c ++++ b/drivers/thermal/qcom/tsens.c +@@ -264,7 +264,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1, + for (i = 0; i < priv->num_sensors; i++) { + dev_dbg(priv->dev, + "%s: sensor%d - data_point1:%#x data_point2:%#x\n", +- __func__, i, p1[i], p2[i]); ++ __func__, i, p1[i], p2 ? p2[i] : 0); + + if (!priv->sensor[i].slope) + priv->sensor[i].slope = SLOPE_DEFAULT; +-- +2.43.0 + diff --git a/queue-6.8/tracing-user_events-fix-non-spaced-field-matching.patch b/queue-6.8/tracing-user_events-fix-non-spaced-field-matching.patch new file mode 100644 index 00000000000..282f8c4638f --- /dev/null +++ b/queue-6.8/tracing-user_events-fix-non-spaced-field-matching.patch @@ -0,0 +1,139 @@ +From 7819813b8a415337328ab31f97cd148806de4ff4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Apr 2024 16:23:37 +0000 +Subject: tracing/user_events: Fix non-spaced field matching + +From: Beau Belgrave + +[ Upstream commit bd125a084091396f3e796bb3dc009940d9771811 ] + +When the ABI was updated to prevent same name w/different args, it +missed an important corner case when fields don't end with a space. +Typically, space is used for fields to help separate them, like +"u8 field1; u8 field2". If no spaces are used, like +"u8 field1;u8 field2", then the parsing works for the first time. +However, the match check fails on a subsequent register, leading to +confusion. + +This is because the match check uses argv_split() and assumes that all +fields will be split upon the space. When spaces are used, we get back +{ "u8", "field1;" }, without spaces we get back { "u8", "field1;u8" }. +This causes a mismatch, and the user program gets back -EADDRINUSE. + +Add a method to detect this case before calling argv_split(). If found +force a space after the field separator character ';'. This ensures all +cases work properly for matching. + +With this fix, the following are all treated as matching: +u8 field1;u8 field2 +u8 field1; u8 field2 +u8 field1;\tu8 field2 +u8 field1;\nu8 field2 + +Link: https://lore.kernel.org/linux-trace-kernel/20240423162338.292-2-beaub@linux.microsoft.com + +Fixes: ba470eebc2f6 ("tracing/user_events: Prevent same name but different args event") +Signed-off-by: Beau Belgrave +Signed-off-by: Steven Rostedt (Google) +Signed-off-by: Sasha Levin +--- + kernel/trace/trace_events_user.c | 76 +++++++++++++++++++++++++++++++- + 1 file changed, 75 insertions(+), 1 deletion(-) + +diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c +index fce5ed5fec50f..704de62f7ae16 100644 +--- a/kernel/trace/trace_events_user.c ++++ b/kernel/trace/trace_events_user.c +@@ -1923,6 +1923,80 @@ static int user_event_trace_register(struct user_event *user) + return ret; + } + ++/* ++ * Counts how many ';' without a trailing space are in the args. ++ */ ++static int count_semis_no_space(char *args) ++{ ++ int count = 0; ++ ++ while ((args = strchr(args, ';'))) { ++ args++; ++ ++ if (!isspace(*args)) ++ count++; ++ } ++ ++ return count; ++} ++ ++/* ++ * Copies the arguments while ensuring all ';' have a trailing space. ++ */ ++static char *insert_space_after_semis(char *args, int count) ++{ ++ char *fixed, *pos; ++ int len; ++ ++ len = strlen(args) + count; ++ fixed = kmalloc(len + 1, GFP_KERNEL); ++ ++ if (!fixed) ++ return NULL; ++ ++ pos = fixed; ++ ++ /* Insert a space after ';' if there is no trailing space. */ ++ while (*args) { ++ *pos = *args++; ++ ++ if (*pos++ == ';' && !isspace(*args)) ++ *pos++ = ' '; ++ } ++ ++ *pos = '\0'; ++ ++ return fixed; ++} ++ ++static char **user_event_argv_split(char *args, int *argc) ++{ ++ char **split; ++ char *fixed; ++ int count; ++ ++ /* Count how many ';' without a trailing space */ ++ count = count_semis_no_space(args); ++ ++ /* No fixup is required */ ++ if (!count) ++ return argv_split(GFP_KERNEL, args, argc); ++ ++ /* We must fixup 'field;field' to 'field; field' */ ++ fixed = insert_space_after_semis(args, count); ++ ++ if (!fixed) ++ return NULL; ++ ++ /* We do a normal split afterwards */ ++ split = argv_split(GFP_KERNEL, fixed, argc); ++ ++ /* We can free since argv_split makes a copy */ ++ kfree(fixed); ++ ++ return split; ++} ++ + /* + * Parses the event name, arguments and flags then registers if successful. + * The name buffer lifetime is owned by this method for success cases only. +@@ -1946,7 +2020,7 @@ static int user_event_parse(struct user_event_group *group, char *name, + return -EPERM; + + if (args) { +- argv = argv_split(GFP_KERNEL, args, &argc); ++ argv = user_event_argv_split(args, &argc); + + if (!argv) + return -ENOMEM; +-- +2.43.0 + diff --git a/queue-6.8/tracing-user_events-prepare-find-delete-for-same-nam.patch b/queue-6.8/tracing-user_events-prepare-find-delete-for-same-nam.patch new file mode 100644 index 00000000000..e362a83b074 --- /dev/null +++ b/queue-6.8/tracing-user_events-prepare-find-delete-for-same-nam.patch @@ -0,0 +1,234 @@ +From a4362297204c24a8c2cacd2e86d955ba6f3f8940 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 22 Feb 2024 00:18:04 +0000 +Subject: tracing/user_events: Prepare find/delete for same name events + +From: Beau Belgrave + +[ Upstream commit 1e953de9e9b4ca77a9ce0fc17a0778eba3a4ca64 ] + +The current code for finding and deleting events assumes that there will +never be cases when user_events are registered with the same name, but +different formats. Scenarios exist where programs want to use the same +name but have different formats. An example is multiple versions of a +program running side-by-side using the same event name, but with updated +formats in each version. + +This change does not yet allow for multi-format events. If user_events +are registered with the same name but different arguments the programs +see the same return values as before. This change simply makes it +possible to easily accommodate for this. + +Update find_user_event() to take in argument parameters and register +flags to accommodate future multi-format event scenarios. Have find +validate argument matching and return error pointers to cover when +an existing event has the same name but different format. Update +callers to handle error pointer logic. + +Move delete_user_event() to use hash walking directly now that +find_user_event() has changed. Delete all events found that match the +register name, stop if an error occurs and report back to the user. + +Update user_fields_match() to cover list_empty() scenarios now that +find_user_event() uses it directly. This makes the logic consistent +across several callsites. + +Link: https://lore.kernel.org/linux-trace-kernel/20240222001807.1463-2-beaub@linux.microsoft.com + +Signed-off-by: Beau Belgrave +Signed-off-by: Steven Rostedt (Google) +Stable-dep-of: bd125a084091 ("tracing/user_events: Fix non-spaced field matching") +Signed-off-by: Sasha Levin +--- + kernel/trace/trace_events_user.c | 107 +++++++++++++++++-------------- + 1 file changed, 59 insertions(+), 48 deletions(-) + +diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c +index e76f5e1efdf2d..fce5ed5fec50f 100644 +--- a/kernel/trace/trace_events_user.c ++++ b/kernel/trace/trace_events_user.c +@@ -202,6 +202,8 @@ static struct user_event_mm *user_event_mm_get(struct user_event_mm *mm); + static struct user_event_mm *user_event_mm_get_all(struct user_event *user); + static void user_event_mm_put(struct user_event_mm *mm); + static int destroy_user_event(struct user_event *user); ++static bool user_fields_match(struct user_event *user, int argc, ++ const char **argv); + + static u32 user_event_key(char *name) + { +@@ -1493,17 +1495,24 @@ static int destroy_user_event(struct user_event *user) + } + + static struct user_event *find_user_event(struct user_event_group *group, +- char *name, u32 *outkey) ++ char *name, int argc, const char **argv, ++ u32 flags, u32 *outkey) + { + struct user_event *user; + u32 key = user_event_key(name); + + *outkey = key; + +- hash_for_each_possible(group->register_table, user, node, key) +- if (!strcmp(EVENT_NAME(user), name)) ++ hash_for_each_possible(group->register_table, user, node, key) { ++ if (strcmp(EVENT_NAME(user), name)) ++ continue; ++ ++ if (user_fields_match(user, argc, argv)) + return user_event_get(user); + ++ return ERR_PTR(-EADDRINUSE); ++ } ++ + return NULL; + } + +@@ -1860,6 +1869,9 @@ static bool user_fields_match(struct user_event *user, int argc, + struct list_head *head = &user->fields; + int i = 0; + ++ if (argc == 0) ++ return list_empty(head); ++ + list_for_each_entry_reverse(field, head, link) { + if (!user_field_match(field, argc, argv, &i)) + return false; +@@ -1880,10 +1892,8 @@ static bool user_event_match(const char *system, const char *event, + match = strcmp(EVENT_NAME(user), event) == 0 && + (!system || strcmp(system, USER_EVENTS_SYSTEM) == 0); + +- if (match && argc > 0) ++ if (match) + match = user_fields_match(user, argc, argv); +- else if (match && argc == 0) +- match = list_empty(&user->fields); + + return match; + } +@@ -1922,11 +1932,11 @@ static int user_event_parse(struct user_event_group *group, char *name, + char *args, char *flags, + struct user_event **newuser, int reg_flags) + { +- int ret; +- u32 key; + struct user_event *user; ++ char **argv = NULL; + int argc = 0; +- char **argv; ++ int ret; ++ u32 key; + + /* Currently don't support any text based flags */ + if (flags != NULL) +@@ -1935,41 +1945,34 @@ static int user_event_parse(struct user_event_group *group, char *name, + if (!user_event_capable(reg_flags)) + return -EPERM; + ++ if (args) { ++ argv = argv_split(GFP_KERNEL, args, &argc); ++ ++ if (!argv) ++ return -ENOMEM; ++ } ++ + /* Prevent dyn_event from racing */ + mutex_lock(&event_mutex); +- user = find_user_event(group, name, &key); ++ user = find_user_event(group, name, argc, (const char **)argv, ++ reg_flags, &key); + mutex_unlock(&event_mutex); + +- if (user) { +- if (args) { +- argv = argv_split(GFP_KERNEL, args, &argc); +- if (!argv) { +- ret = -ENOMEM; +- goto error; +- } ++ if (argv) ++ argv_free(argv); + +- ret = user_fields_match(user, argc, (const char **)argv); +- argv_free(argv); +- +- } else +- ret = list_empty(&user->fields); +- +- if (ret) { +- *newuser = user; +- /* +- * Name is allocated by caller, free it since it already exists. +- * Caller only worries about failure cases for freeing. +- */ +- kfree(name); +- } else { +- ret = -EADDRINUSE; +- goto error; +- } ++ if (IS_ERR(user)) ++ return PTR_ERR(user); ++ ++ if (user) { ++ *newuser = user; ++ /* ++ * Name is allocated by caller, free it since it already exists. ++ * Caller only worries about failure cases for freeing. ++ */ ++ kfree(name); + + return 0; +-error: +- user_event_put(user, false); +- return ret; + } + + user = kzalloc(sizeof(*user), GFP_KERNEL_ACCOUNT); +@@ -2052,25 +2055,33 @@ static int user_event_parse(struct user_event_group *group, char *name, + } + + /* +- * Deletes a previously created event if it is no longer being used. ++ * Deletes previously created events if they are no longer being used. + */ + static int delete_user_event(struct user_event_group *group, char *name) + { +- u32 key; +- struct user_event *user = find_user_event(group, name, &key); ++ struct user_event *user; ++ struct hlist_node *tmp; ++ u32 key = user_event_key(name); ++ int ret = -ENOENT; + +- if (!user) +- return -ENOENT; ++ /* Attempt to delete all event(s) with the name passed in */ ++ hash_for_each_possible_safe(group->register_table, user, tmp, node, key) { ++ if (strcmp(EVENT_NAME(user), name)) ++ continue; + +- user_event_put(user, true); ++ if (!user_event_last_ref(user)) ++ return -EBUSY; + +- if (!user_event_last_ref(user)) +- return -EBUSY; ++ if (!user_event_capable(user->reg_flags)) ++ return -EPERM; + +- if (!user_event_capable(user->reg_flags)) +- return -EPERM; ++ ret = destroy_user_event(user); + +- return destroy_user_event(user); ++ if (ret) ++ goto out; ++ } ++out: ++ return ret; + } + + /* +-- +2.43.0 + diff --git a/queue-6.8/udp-avoid-call-to-compute_score-on-multiple-sites.patch b/queue-6.8/udp-avoid-call-to-compute_score-on-multiple-sites.patch new file mode 100644 index 00000000000..956a12d6930 --- /dev/null +++ b/queue-6.8/udp-avoid-call-to-compute_score-on-multiple-sites.patch @@ -0,0 +1,164 @@ +From a5042c3c8dbb319cc4f00aa9c2480fdc5f46b766 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:20:04 -0400 +Subject: udp: Avoid call to compute_score on multiple sites + +From: Gabriel Krisman Bertazi + +[ Upstream commit 50aee97d15113b95a68848db1f0cb2a6c09f753a ] + +We've observed a 7-12% performance regression in iperf3 UDP ipv4 and +ipv6 tests with multiple sockets on Zen3 cpus, which we traced back to +commit f0ea27e7bfe1 ("udp: re-score reuseport groups when connected +sockets are present"). The failing tests were those that would spawn +UDP sockets per-cpu on systems that have a high number of cpus. + +Unsurprisingly, it is not caused by the extra re-scoring of the reused +socket, but due to the compiler no longer inlining compute_score, once +it has the extra call site in udp4_lib_lookup2. This is augmented by +the "Safe RET" mitigation for SRSO, needed in our Zen3 cpus. + +We could just explicitly inline it, but compute_score() is quite a large +function, around 300b. Inlining in two sites would almost double +udp4_lib_lookup2, which is a silly thing to do just to workaround a +mitigation. Instead, this patch shuffles the code a bit to avoid the +multiple calls to compute_score. Since it is a static function used in +one spot, the compiler can safely fold it in, as it did before, without +increasing the text size. + +With this patch applied I ran my original iperf3 testcases. The failing +cases all looked like this (ipv4): + iperf3 -c 127.0.0.1 --udp -4 -f K -b $R -l 8920 -t 30 -i 5 -P 64 -O 2 + +where $R is either 1G/10G/0 (max, unlimited). I ran 3 times each. +baseline is v6.9-rc3. harmean == harmonic mean; CV == coefficient of +variation. + +ipv4: + 1G 10G MAX + HARMEAN (CV) HARMEAN (CV) HARMEAN (CV) +baseline 1743852.66(0.0208) 1725933.02(0.0167) 1705203.78(0.0386) +patched 1968727.61(0.0035) 1962283.22(0.0195) 1923853.50(0.0256) + +ipv6: + 1G 10G MAX + HARMEAN (CV) HARMEAN (CV) HARMEAN (CV) +baseline 1729020.03(0.0028) 1691704.49(0.0243) 1692251.34(0.0083) +patched 1900422.19(0.0067) 1900968.01(0.0067) 1568532.72(0.1519) + +This restores the performance we had before the change above with this +benchmark. We obviously don't expect any real impact when mitigations +are disabled, but just to be sure it also doesn't regresses: + +mitigations=off ipv4: + 1G 10G MAX + HARMEAN (CV) HARMEAN (CV) HARMEAN (CV) +baseline 3230279.97(0.0066) 3229320.91(0.0060) 2605693.19(0.0697) +patched 3242802.36(0.0073) 3239310.71(0.0035) 2502427.19(0.0882) + +Cc: Lorenz Bauer +Fixes: f0ea27e7bfe1 ("udp: re-score reuseport groups when connected sockets are present") +Signed-off-by: Gabriel Krisman Bertazi +Reviewed-by: Kuniyuki Iwashima +Reviewed-by: Willem de Bruijn +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + net/ipv4/udp.c | 21 ++++++++++++++++----- + net/ipv6/udp.c | 20 ++++++++++++++++---- + 2 files changed, 32 insertions(+), 9 deletions(-) + +diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c +index 9120694359af4..e980869f18176 100644 +--- a/net/ipv4/udp.c ++++ b/net/ipv4/udp.c +@@ -429,15 +429,21 @@ static struct sock *udp4_lib_lookup2(struct net *net, + { + struct sock *sk, *result; + int score, badness; ++ bool need_rescore; + + result = NULL; + badness = 0; + udp_portaddr_for_each_entry_rcu(sk, &hslot2->head) { +- score = compute_score(sk, net, saddr, sport, +- daddr, hnum, dif, sdif); ++ need_rescore = false; ++rescore: ++ score = compute_score(need_rescore ? result : sk, net, saddr, ++ sport, daddr, hnum, dif, sdif); + if (score > badness) { + badness = score; + ++ if (need_rescore) ++ continue; ++ + if (sk->sk_state == TCP_ESTABLISHED) { + result = sk; + continue; +@@ -458,9 +464,14 @@ static struct sock *udp4_lib_lookup2(struct net *net, + if (IS_ERR(result)) + continue; + +- badness = compute_score(result, net, saddr, sport, +- daddr, hnum, dif, sdif); +- ++ /* compute_score is too long of a function to be ++ * inlined, and calling it again here yields ++ * measureable overhead for some ++ * workloads. Work around it by jumping ++ * backwards to rescore 'result'. ++ */ ++ need_rescore = true; ++ goto rescore; + } + } + return result; +diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c +index 785b2d076a6b3..936b51f358a9a 100644 +--- a/net/ipv6/udp.c ++++ b/net/ipv6/udp.c +@@ -171,15 +171,21 @@ static struct sock *udp6_lib_lookup2(struct net *net, + { + struct sock *sk, *result; + int score, badness; ++ bool need_rescore; + + result = NULL; + badness = -1; + udp_portaddr_for_each_entry_rcu(sk, &hslot2->head) { +- score = compute_score(sk, net, saddr, sport, +- daddr, hnum, dif, sdif); ++ need_rescore = false; ++rescore: ++ score = compute_score(need_rescore ? result : sk, net, saddr, ++ sport, daddr, hnum, dif, sdif); + if (score > badness) { + badness = score; + ++ if (need_rescore) ++ continue; ++ + if (sk->sk_state == TCP_ESTABLISHED) { + result = sk; + continue; +@@ -200,8 +206,14 @@ static struct sock *udp6_lib_lookup2(struct net *net, + if (IS_ERR(result)) + continue; + +- badness = compute_score(sk, net, saddr, sport, +- daddr, hnum, dif, sdif); ++ /* compute_score is too long of a function to be ++ * inlined, and calling it again here yields ++ * measureable overhead for some ++ * workloads. Work around it by jumping ++ * backwards to rescore 'result'. ++ */ ++ need_rescore = true; ++ goto rescore; + } + } + return result; +-- +2.43.0 + diff --git a/queue-6.8/usb-aqc111-stop-lying-about-skb-truesize.patch b/queue-6.8/usb-aqc111-stop-lying-about-skb-truesize.patch new file mode 100644 index 00000000000..b4d5ab682da --- /dev/null +++ b/queue-6.8/usb-aqc111-stop-lying-about-skb-truesize.patch @@ -0,0 +1,55 @@ +From 75ac058251159545d319fec6234cce9c911c1ea7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 May 2024 13:55:46 +0000 +Subject: usb: aqc111: stop lying about skb->truesize + +From: Eric Dumazet + +[ Upstream commit 9aad6e45c4e7d16b2bb7c3794154b828fb4384b4 ] + +Some usb drivers try to set small skb->truesize and break +core networking stacks. + +I replace one skb_clone() by an allocation of a fresh +and small skb, to get minimally sized skbs, like we did +in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize +in rx path") and 4ce62d5b2f7a ("net: usb: ax88179_178a: +stop lying about skb->truesize") + +Fixes: 361459cd9642 ("net: usb: aqc111: Implement RX data path") +Signed-off-by: Eric Dumazet +Link: https://lore.kernel.org/r/20240506135546.3641185-1-edumazet@google.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/usb/aqc111.c | 8 +++----- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c +index 7b8afa589a53c..284375f662f1e 100644 +--- a/drivers/net/usb/aqc111.c ++++ b/drivers/net/usb/aqc111.c +@@ -1141,17 +1141,15 @@ static int aqc111_rx_fixup(struct usbnet *dev, struct sk_buff *skb) + continue; + } + +- /* Clone SKB */ +- new_skb = skb_clone(skb, GFP_ATOMIC); ++ new_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len); + + if (!new_skb) + goto err; + +- new_skb->len = pkt_len; ++ skb_put(new_skb, pkt_len); ++ memcpy(new_skb->data, skb->data, pkt_len); + skb_pull(new_skb, AQ_RX_HW_PAD); +- skb_set_tail_pointer(new_skb, new_skb->len); + +- new_skb->truesize = SKB_TRUESIZE(new_skb->len); + if (aqc111_data->rx_checksum) + aqc111_rx_checksum(new_skb, pkt_desc); + +-- +2.43.0 + diff --git a/queue-6.8/virt-acrn-stop-using-follow_pfn.patch b/queue-6.8/virt-acrn-stop-using-follow_pfn.patch new file mode 100644 index 00000000000..33b37fb3ad3 --- /dev/null +++ b/queue-6.8/virt-acrn-stop-using-follow_pfn.patch @@ -0,0 +1,71 @@ +From 65617294f4172eacfb7ab6139069c54f83cf5028 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 25 Mar 2024 07:45:40 +0800 +Subject: virt: acrn: stop using follow_pfn + +From: Christoph Hellwig + +[ Upstream commit 1b265da7ea1e1ae997fa119c2846bb389eb39c6b ] + +Patch series "remove follow_pfn". + +This series open codes follow_pfn in the only remaining caller, although +the code there remains questionable. It then also moves follow_phys into +the only user and simplifies it a bit. + +This patch (of 3): + +Switch from follow_pfn to follow_pte so that we can get rid of follow_pfn. +Note that this doesn't fix any of the pre-existing raciness and lack of +permission checking in the code. + +Link: https://lkml.kernel.org/r/20240324234542.2038726-1-hch@lst.de +Link: https://lkml.kernel.org/r/20240324234542.2038726-2-hch@lst.de +Signed-off-by: Christoph Hellwig +Reviewed-by: David Hildenbrand +Cc: Andy Lutomirski +Cc: Dave Hansen +Cc: Fei Li +Cc: Peter Zijlstra +Cc: Ingo Molnar +Signed-off-by: Andrew Morton +Stable-dep-of: 3d6586008f7b ("drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map()") +Signed-off-by: Sasha Levin +--- + drivers/virt/acrn/mm.c | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/drivers/virt/acrn/mm.c b/drivers/virt/acrn/mm.c +index fa5d9ca6be570..69c3f619f8819 100644 +--- a/drivers/virt/acrn/mm.c ++++ b/drivers/virt/acrn/mm.c +@@ -171,18 +171,24 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) + mmap_read_lock(current->mm); + vma = vma_lookup(current->mm, memmap->vma_base); + if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) { ++ spinlock_t *ptl; ++ pte_t *ptep; ++ + if ((memmap->vma_base + memmap->len) > vma->vm_end) { + mmap_read_unlock(current->mm); + return -EINVAL; + } + +- ret = follow_pfn(vma, memmap->vma_base, &pfn); +- mmap_read_unlock(current->mm); ++ ret = follow_pte(vma->vm_mm, memmap->vma_base, &ptep, &ptl); + if (ret < 0) { ++ mmap_read_unlock(current->mm); + dev_dbg(acrn_dev.this_device, + "Failed to lookup PFN at VMA:%pK.\n", (void *)memmap->vma_base); + return ret; + } ++ pfn = pte_pfn(ptep_get(ptep)); ++ pte_unmap_unlock(ptep, ptl); ++ mmap_read_unlock(current->mm); + + return acrn_mm_region_add(vm, memmap->user_vm_pa, + PFN_PHYS(pfn), memmap->len, +-- +2.43.0 + diff --git a/queue-6.8/wifi-ar5523-enable-proper-endpoint-verification.patch b/queue-6.8/wifi-ar5523-enable-proper-endpoint-verification.patch new file mode 100644 index 00000000000..2d3aab04911 --- /dev/null +++ b/queue-6.8/wifi-ar5523-enable-proper-endpoint-verification.patch @@ -0,0 +1,99 @@ +From 252831520122bffc25e6f55a41636100a11a89a8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 8 Apr 2024 05:14:25 -0700 +Subject: wifi: ar5523: enable proper endpoint verification + +From: Nikita Zhandarovich + +[ Upstream commit e120b6388d7d88635d67dcae6483f39c37111850 ] + +Syzkaller reports [1] hitting a warning about an endpoint in use +not having an expected type to it. + +Fix the issue by checking for the existence of all proper +endpoints with their according types intact. + +Sadly, this patch has not been tested on real hardware. + +[1] Syzkaller report: +------------[ cut here ]------------ +usb 1-1: BOGUS urb xfer, pipe 3 != type 1 +WARNING: CPU: 0 PID: 3643 at drivers/usb/core/urb.c:504 usb_submit_urb+0xed6/0x1880 drivers/usb/core/urb.c:504 +... +Call Trace: + + ar5523_cmd+0x41b/0x780 drivers/net/wireless/ath/ar5523/ar5523.c:275 + ar5523_cmd_read drivers/net/wireless/ath/ar5523/ar5523.c:302 [inline] + ar5523_host_available drivers/net/wireless/ath/ar5523/ar5523.c:1376 [inline] + ar5523_probe+0x14b0/0x1d10 drivers/net/wireless/ath/ar5523/ar5523.c:1655 + usb_probe_interface+0x30f/0x7f0 drivers/usb/core/driver.c:396 + call_driver_probe drivers/base/dd.c:560 [inline] + really_probe+0x249/0xb90 drivers/base/dd.c:639 + __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 + driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 + __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:936 + bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:427 + __device_attach+0x1e4/0x530 drivers/base/dd.c:1008 + bus_probe_device+0x1e8/0x2a0 drivers/base/bus.c:487 + device_add+0xbd9/0x1e90 drivers/base/core.c:3517 + usb_set_configuration+0x101d/0x1900 drivers/usb/core/message.c:2170 + usb_generic_driver_probe+0xbe/0x100 drivers/usb/core/generic.c:238 + usb_probe_device+0xd8/0x2c0 drivers/usb/core/driver.c:293 + call_driver_probe drivers/base/dd.c:560 [inline] + really_probe+0x249/0xb90 drivers/base/dd.c:639 + __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 + driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 + __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:936 + bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:427 + __device_attach+0x1e4/0x530 drivers/base/dd.c:1008 + bus_probe_device+0x1e8/0x2a0 drivers/base/bus.c:487 + device_add+0xbd9/0x1e90 drivers/base/core.c:3517 + usb_new_device.cold+0x685/0x10ad drivers/usb/core/hub.c:2573 + hub_port_connect drivers/usb/core/hub.c:5353 [inline] + hub_port_connect_change drivers/usb/core/hub.c:5497 [inline] + port_event drivers/usb/core/hub.c:5653 [inline] + hub_event+0x26cb/0x45d0 drivers/usb/core/hub.c:5735 + process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289 + worker_thread+0x669/0x1090 kernel/workqueue.c:2436 + kthread+0x2e8/0x3a0 kernel/kthread.c:376 + ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 + + +Reported-and-tested-by: syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com +Fixes: b7d572e1871d ("ar5523: Add new driver") +Signed-off-by: Nikita Zhandarovich +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240408121425.29392-1-n.zhandarovich@fintech.ru +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ar5523/ar5523.c | 14 ++++++++++++++ + 1 file changed, 14 insertions(+) + +diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c +index a742cec44e3db..91ddbe6136e00 100644 +--- a/drivers/net/wireless/ath/ar5523/ar5523.c ++++ b/drivers/net/wireless/ath/ar5523/ar5523.c +@@ -1590,6 +1590,20 @@ static int ar5523_probe(struct usb_interface *intf, + struct ar5523 *ar; + int error = -ENOMEM; + ++ static const u8 bulk_ep_addr[] = { ++ AR5523_CMD_TX_PIPE | USB_DIR_OUT, ++ AR5523_DATA_TX_PIPE | USB_DIR_OUT, ++ AR5523_CMD_RX_PIPE | USB_DIR_IN, ++ AR5523_DATA_RX_PIPE | USB_DIR_IN, ++ 0}; ++ ++ if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) { ++ dev_err(&dev->dev, ++ "Could not find all expected endpoints\n"); ++ error = -ENODEV; ++ goto out; ++ } ++ + /* + * Load firmware if the device requires it. This will return + * -ENXIO on success and we'll get called back afer the usb +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath10k-fix-an-error-code-problem-in-ath10k_dbg_.patch b/queue-6.8/wifi-ath10k-fix-an-error-code-problem-in-ath10k_dbg_.patch new file mode 100644 index 00000000000..f089a75f4a0 --- /dev/null +++ b/queue-6.8/wifi-ath10k-fix-an-error-code-problem-in-ath10k_dbg_.patch @@ -0,0 +1,43 @@ +From 5cf7cfc45a725beb4fb8c53cb33fab0efb13a3cd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 11:42:44 +0800 +Subject: wifi: ath10k: Fix an error code problem in + ath10k_dbg_sta_write_peer_debug_trigger() + +From: Su Hui + +[ Upstream commit c511a9c12674d246916bb16c479d496b76983193 ] + +Clang Static Checker (scan-build) warns: + +drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3 +Value stored to 'ret' is never read. + +Return 'ret' rather than 'count' when 'ret' stores an error code. + +Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing") +Signed-off-by: Su Hui +Acked-by: Jeff Johnson +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240422034243.938962-1-suhui@nfschina.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/debugfs_sta.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c +index 394bf3c32abff..0f6de862c3a9b 100644 +--- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c ++++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c +@@ -439,7 +439,7 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file, + } + out: + mutex_unlock(&ar->conf_mutex); +- return count; ++ return ret ?: count; + } + + static const struct file_operations fops_peer_debug_trigger = { +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath10k-poll-service-ready-message-before-failin.patch b/queue-6.8/wifi-ath10k-poll-service-ready-message-before-failin.patch new file mode 100644 index 00000000000..99ec0d50f55 --- /dev/null +++ b/queue-6.8/wifi-ath10k-poll-service-ready-message-before-failin.patch @@ -0,0 +1,81 @@ +From 22907d6a6297479f39d5a6bedd308d8ba97dc8af Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 6 Mar 2024 07:15:14 +0200 +Subject: wifi: ath10k: poll service ready message before failing + +From: Baochen Qiang + +[ Upstream commit e57b7d62a1b2f496caf0beba81cec3c90fad80d5 ] + +Currently host relies on CE interrupts to get notified that +the service ready message is ready. This results in timeout +issue if the interrupt is not fired, due to some unknown +reasons. See below logs: + +[76321.937866] ath10k_pci 0000:02:00.0: wmi service ready event not received +... +[76322.016738] ath10k_pci 0000:02:00.0: Could not init core: -110 + +And finally it causes WLAN interface bring up failure. + +Change to give it one more chance here by polling CE rings, +before failing directly. + +Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00157-QCARMSWPZ-1 + +Fixes: 5e3dd157d7e7 ("ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices") +Reported-by: James Prestwood +Tested-By: James Prestwood # on QCA6174 hw3.2 +Link: https://lore.kernel.org/linux-wireless/304ce305-fbe6-420e-ac2a-d61ae5e6ca1a@gmail.com/ +Signed-off-by: Baochen Qiang +Acked-by: Jeff Johnson +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240227030409.89702-1-quic_bqiang@quicinc.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/wmi.c | 26 +++++++++++++++++++++++--- + 1 file changed, 23 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c +index 88befe92f95dc..24f1ab2785214 100644 +--- a/drivers/net/wireless/ath/ath10k/wmi.c ++++ b/drivers/net/wireless/ath/ath10k/wmi.c +@@ -1763,12 +1763,32 @@ void ath10k_wmi_put_wmi_channel(struct ath10k *ar, struct wmi_channel *ch, + + int ath10k_wmi_wait_for_service_ready(struct ath10k *ar) + { +- unsigned long time_left; ++ unsigned long time_left, i; + + time_left = wait_for_completion_timeout(&ar->wmi.service_ready, + WMI_SERVICE_READY_TIMEOUT_HZ); +- if (!time_left) +- return -ETIMEDOUT; ++ if (!time_left) { ++ /* Sometimes the PCI HIF doesn't receive interrupt ++ * for the service ready message even if the buffer ++ * was completed. PCIe sniffer shows that it's ++ * because the corresponding CE ring doesn't fires ++ * it. Workaround here by polling CE rings once. ++ */ ++ ath10k_warn(ar, "failed to receive service ready completion, polling..\n"); ++ ++ for (i = 0; i < CE_COUNT; i++) ++ ath10k_hif_send_complete_check(ar, i, 1); ++ ++ time_left = wait_for_completion_timeout(&ar->wmi.service_ready, ++ WMI_SERVICE_READY_TIMEOUT_HZ); ++ if (!time_left) { ++ ath10k_warn(ar, "polling timed out\n"); ++ return -ETIMEDOUT; ++ } ++ ++ ath10k_warn(ar, "service ready completion received, continuing normally\n"); ++ } ++ + return 0; + } + +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath10k-populate-board-data-for-wcn3990.patch b/queue-6.8/wifi-ath10k-populate-board-data-for-wcn3990.patch new file mode 100644 index 00000000000..388df63ece1 --- /dev/null +++ b/queue-6.8/wifi-ath10k-populate-board-data-for-wcn3990.patch @@ -0,0 +1,65 @@ +From 430bbba0e6c14d0ef162d59a2e73cdb9d7b861b9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 30 Jan 2024 08:47:06 +0200 +Subject: wifi: ath10k: populate board data for WCN3990 + +From: Dmitry Baryshkov + +[ Upstream commit f1f1b5b055c9f27a2f90fd0f0521f5920e9b3c18 ] + +Specify board data size (and board.bin filename) for the WCN3990 +platform. + +Reported-by: Yongqin Liu +Fixes: 03a72288c546 ("ath10k: wmi: add hw params entry for wcn3990") +Signed-off-by: Dmitry Baryshkov +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240130-wcn3990-board-fw-v1-1-738f7c19a8c8@linaro.org +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath10k/core.c | 3 +++ + drivers/net/wireless/ath/ath10k/hw.h | 1 + + drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ + 3 files changed, 7 insertions(+) + +diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c +index 0032f8aa892ff..4e3736d7aff77 100644 +--- a/drivers/net/wireless/ath/ath10k/core.c ++++ b/drivers/net/wireless/ath/ath10k/core.c +@@ -720,6 +720,9 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { + .max_spatial_stream = 4, + .fw = { + .dir = WCN3990_HW_1_0_FW_DIR, ++ .board = WCN3990_HW_1_0_BOARD_DATA_FILE, ++ .board_size = WCN3990_BOARD_DATA_SZ, ++ .board_ext_size = WCN3990_BOARD_EXT_DATA_SZ, + }, + .sw_decrypt_mcast_mgmt = true, + .rx_desc_ops = &wcn3990_rx_desc_ops, +diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h +index 93c0730919966..9aa2d821b5078 100644 +--- a/drivers/net/wireless/ath/ath10k/hw.h ++++ b/drivers/net/wireless/ath/ath10k/hw.h +@@ -133,6 +133,7 @@ enum qca9377_chip_id_rev { + /* WCN3990 1.0 definitions */ + #define WCN3990_HW_1_0_DEV_VERSION ATH10K_HW_WCN3990 + #define WCN3990_HW_1_0_FW_DIR ATH10K_FW_DIR "/WCN3990/hw1.0" ++#define WCN3990_HW_1_0_BOARD_DATA_FILE "board.bin" + + #define ATH10K_FW_FILE_BASE "firmware" + #define ATH10K_FW_API_MAX 6 +diff --git a/drivers/net/wireless/ath/ath10k/targaddrs.h b/drivers/net/wireless/ath/ath10k/targaddrs.h +index ec556bb88d658..ba37e6c7ced08 100644 +--- a/drivers/net/wireless/ath/ath10k/targaddrs.h ++++ b/drivers/net/wireless/ath/ath10k/targaddrs.h +@@ -491,4 +491,7 @@ struct host_interest { + #define QCA4019_BOARD_DATA_SZ 12064 + #define QCA4019_BOARD_EXT_DATA_SZ 0 + ++#define WCN3990_BOARD_DATA_SZ 26328 ++#define WCN3990_BOARD_EXT_DATA_SZ 0 ++ + #endif /* __TARGADDRS_H__ */ +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath11k-don-t-force-enable-power-save-on-non-run.patch b/queue-6.8/wifi-ath11k-don-t-force-enable-power-save-on-non-run.patch new file mode 100644 index 00000000000..717c0062a1f --- /dev/null +++ b/queue-6.8/wifi-ath11k-don-t-force-enable-power-save-on-non-run.patch @@ -0,0 +1,94 @@ +From 05388d8d3b8b863795b5524894552cb9bd4e9b99 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 9 Mar 2024 19:31:15 +0800 +Subject: wifi: ath11k: don't force enable power save on non-running vdevs + +From: Baochen Qiang + +[ Upstream commit 01296b39d3515f20a1db64d3c421c592b1e264a0 ] + +Currently we force enable power save on non-running vdevs, this results +in unexpected ping latency in below scenarios: + 1. disable power save from userspace. + 2. trigger suspend/resume. + +With step 1 power save is disabled successfully and we get a good latency: + +PING 192.168.1.1 (192.168.1.1) 56(84) bytes of data. +64 bytes from 192.168.1.1: icmp_seq=1 ttl=64 time=5.13 ms +64 bytes from 192.168.1.1: icmp_seq=2 ttl=64 time=5.45 ms +64 bytes from 192.168.1.1: icmp_seq=3 ttl=64 time=5.99 ms +64 bytes from 192.168.1.1: icmp_seq=4 ttl=64 time=6.34 ms +64 bytes from 192.168.1.1: icmp_seq=5 ttl=64 time=4.47 ms +64 bytes from 192.168.1.1: icmp_seq=6 ttl=64 time=6.45 ms + +While after step 2, the latency becomes much larger: + +PING 192.168.1.1 (192.168.1.1) 56(84) bytes of data. +64 bytes from 192.168.1.1: icmp_seq=1 ttl=64 time=17.7 ms +64 bytes from 192.168.1.1: icmp_seq=2 ttl=64 time=15.0 ms +64 bytes from 192.168.1.1: icmp_seq=3 ttl=64 time=14.3 ms +64 bytes from 192.168.1.1: icmp_seq=4 ttl=64 time=16.5 ms +64 bytes from 192.168.1.1: icmp_seq=5 ttl=64 time=20.1 ms + +The reason is, with step 2, power save is force enabled due to vdev not +running, although mac80211 was trying to disable it to honor userspace +configuration: + +ath11k_pci 0000:03:00.0: wmi cmd sta powersave mode psmode 1 vdev id 0 +Call Trace: + ath11k_wmi_pdev_set_ps_mode + ath11k_mac_op_bss_info_changed + ieee80211_bss_info_change_notify + ieee80211_reconfig + ieee80211_resume + wiphy_resume + +This logic is taken from ath10k where it was added due to below comment: + + Firmware doesn't behave nicely and consumes more power than + necessary if PS is disabled on a non-started vdev. + +However we don't know whether such an issue also occurs to ath11k firmware +or not. But even if it does, it's not appropriate because it goes against +userspace, even cfg/mac80211 don't know we have enabled it in fact. + +Remove it to fix this issue. In this way we not only get a better latency, +but also, and the most important, keeps the consistency between userspace +and kernel/driver. The biggest price for that would be the power consumption, +which is not that important, compared with the consistency. + +Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30 + +Fixes: b2beffa7d9a6 ("ath11k: enable 802.11 power save mode in station mode") +Signed-off-by: Baochen Qiang +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240309113115.11498-1-quic_bqiang@quicinc.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath11k/mac.c | 9 +-------- + 1 file changed, 1 insertion(+), 8 deletions(-) + +diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c +index cc80310088ce1..a46b8e677cd1f 100644 +--- a/drivers/net/wireless/ath/ath11k/mac.c ++++ b/drivers/net/wireless/ath/ath11k/mac.c +@@ -1234,14 +1234,7 @@ static int ath11k_mac_vif_setup_ps(struct ath11k_vif *arvif) + + enable_ps = arvif->ps; + +- if (!arvif->is_started) { +- /* mac80211 can update vif powersave state while disconnected. +- * Firmware doesn't behave nicely and consumes more power than +- * necessary if PS is disabled on a non-started vdev. Hence +- * force-enable PS for non-running vdevs. +- */ +- psmode = WMI_STA_PS_MODE_ENABLED; +- } else if (enable_ps) { ++ if (enable_ps) { + psmode = WMI_STA_PS_MODE_ENABLED; + param = WMI_STA_PS_PARAM_INACTIVITY_TIME; + +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath12k-fix-out-of-bound-access-of-qmi_invoke_ha.patch b/queue-6.8/wifi-ath12k-fix-out-of-bound-access-of-qmi_invoke_ha.patch new file mode 100644 index 00000000000..3319f9bb4c4 --- /dev/null +++ b/queue-6.8/wifi-ath12k-fix-out-of-bound-access-of-qmi_invoke_ha.patch @@ -0,0 +1,72 @@ +From beff73da20eb5702a62ff3447913f70e2d28d475 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 18:30:25 +0300 +Subject: wifi: ath12k: fix out-of-bound access of qmi_invoke_handler() + +From: Karthikeyan Kathirvel + +[ Upstream commit e1bdff48a1bb4a4ac660c19c55a820968c48b3f2 ] + +Currently, there is no terminator entry for ath12k_qmi_msg_handlers hence +facing below KASAN warning, + + ================================================================== + BUG: KASAN: global-out-of-bounds in qmi_invoke_handler+0xa4/0x148 + Read of size 8 at addr ffffffd00a6428d8 by task kworker/u8:2/1273 + + CPU: 0 PID: 1273 Comm: kworker/u8:2 Not tainted 5.4.213 #0 + Workqueue: qmi_msg_handler qmi_data_ready_work + Call trace: + dump_backtrace+0x0/0x20c + show_stack+0x14/0x1c + dump_stack+0xe0/0x138 + print_address_description.isra.5+0x30/0x330 + __kasan_report+0x16c/0x1bc + kasan_report+0xc/0x14 + __asan_load8+0xa8/0xb0 + qmi_invoke_handler+0xa4/0x148 + qmi_handle_message+0x18c/0x1bc + qmi_data_ready_work+0x4ec/0x528 + process_one_work+0x2c0/0x440 + worker_thread+0x324/0x4b8 + kthread+0x210/0x228 + ret_from_fork+0x10/0x18 + + The address belongs to the variable: + ath12k_mac_mon_status_filter_default+0x4bd8/0xfffffffffffe2300 [ath12k] + [...] + ================================================================== + +Add a dummy terminator entry at the end to assist the qmi_invoke_handler() +in traversing up to the terminator entry without accessing an +out-of-boundary index. + +Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 + +Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") +Reviewed-by: Jeff Johnson +Signed-off-by: Karthikeyan Kathirvel +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240416080234.2882725-1-quic_kathirve@quicinc.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath12k/qmi.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c +index 77a132f6bbd1b..b3440a5e38af0 100644 +--- a/drivers/net/wireless/ath/ath12k/qmi.c ++++ b/drivers/net/wireless/ath/ath12k/qmi.c +@@ -2941,6 +2941,9 @@ static const struct qmi_msg_handler ath12k_qmi_msg_handlers[] = { + .decoded_size = sizeof(struct qmi_wlanfw_fw_ready_ind_msg_v01), + .fn = ath12k_qmi_msg_fw_ready_cb, + }, ++ ++ /* end of list */ ++ {}, + }; + + static int ath12k_qmi_ops_new_server(struct qmi_handle *qmi_hdl, +-- +2.43.0 + diff --git a/queue-6.8/wifi-ath12k-use-correct-flag-field-for-320-mhz-chann.patch b/queue-6.8/wifi-ath12k-use-correct-flag-field-for-320-mhz-chann.patch new file mode 100644 index 00000000000..443abfc664a --- /dev/null +++ b/queue-6.8/wifi-ath12k-use-correct-flag-field-for-320-mhz-chann.patch @@ -0,0 +1,44 @@ +From cb3188e96fdf34012c2f086df0eef7dc285af883 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 14 Mar 2024 13:46:51 -0700 +Subject: wifi: ath12k: use correct flag field for 320 MHz channels + +From: Aloka Dixit + +[ Upstream commit 020e08ae5e68cbc0791e8d842443a86eb6aa99f6 ] + +Due to an error during rebasing the patchset 320 MHz channel support got +broken. ath12k was setting the QoS bit instead of the correct flag. +WMI_PEER_EXT_320MHZ (0x2) is defined as an extended flag, replace +peer_flags by peer_flags_ext while sending peer data. + +This affected both QCN9274 and WCN7850 which use the same flag. + +Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 + +Fixes: 6734cf9b4cc7 ("wifi: ath12k: peer assoc for 320 MHz") +Signed-off-by: Aloka Dixit +Acked-by: Jeff Johnson +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240314204651.11075-1-quic_alokad@quicinc.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/ath12k/wmi.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c +index 11cc3005c0f98..035d8f247e23e 100644 +--- a/drivers/net/wireless/ath/ath12k/wmi.c ++++ b/drivers/net/wireless/ath/ath12k/wmi.c +@@ -1836,7 +1836,7 @@ static void ath12k_wmi_copy_peer_flags(struct wmi_peer_assoc_complete_cmd *cmd, + if (arg->bw_160) + cmd->peer_flags |= cpu_to_le32(WMI_PEER_160MHZ); + if (arg->bw_320) +- cmd->peer_flags |= cpu_to_le32(WMI_PEER_EXT_320MHZ); ++ cmd->peer_flags_ext |= cpu_to_le32(WMI_PEER_EXT_320MHZ); + + /* Typically if STBC is enabled for VHT it should be enabled + * for HT as well +-- +2.43.0 + diff --git a/queue-6.8/wifi-brcmfmac-pcie-handle-randbuf-allocation-failure.patch b/queue-6.8/wifi-brcmfmac-pcie-handle-randbuf-allocation-failure.patch new file mode 100644 index 00000000000..34b9818dc11 --- /dev/null +++ b/queue-6.8/wifi-brcmfmac-pcie-handle-randbuf-allocation-failure.patch @@ -0,0 +1,71 @@ +From cb0d142465a8498448996ac88c1ef4bc892a7a65 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 6 Mar 2024 22:04:37 +0800 +Subject: wifi: brcmfmac: pcie: handle randbuf allocation failure + +From: Duoming Zhou + +[ Upstream commit 316f790ebcf94bdf59f794b7cdea4068dc676d4c ] + +The kzalloc() in brcmf_pcie_download_fw_nvram() will return null +if the physical memory has run out. As a result, if we use +get_random_bytes() to generate random bytes in the randbuf, the +null pointer dereference bug will happen. + +In order to prevent allocation failure, this patch adds a separate +function using buffer on kernel stack to generate random bytes in +the randbuf, which could prevent the kernel stack from overflow. + +Fixes: 91918ce88d9f ("wifi: brcmfmac: pcie: Provide a buffer of random bytes to the device") +Suggested-by: Arnd Bergmann +Signed-off-by: Duoming Zhou +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240306140437.18177-1-duoming@zju.edu.cn +Signed-off-by: Sasha Levin +--- + .../wireless/broadcom/brcm80211/brcmfmac/pcie.c | 15 ++++++++++----- + 1 file changed, 10 insertions(+), 5 deletions(-) + +diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +index d7fb88bb6ae1a..06698a714b523 100644 +--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c ++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +@@ -1675,6 +1675,15 @@ struct brcmf_random_seed_footer { + #define BRCMF_RANDOM_SEED_MAGIC 0xfeedc0de + #define BRCMF_RANDOM_SEED_LENGTH 0x100 + ++static noinline_for_stack void ++brcmf_pcie_provide_random_bytes(struct brcmf_pciedev_info *devinfo, u32 address) ++{ ++ u8 randbuf[BRCMF_RANDOM_SEED_LENGTH]; ++ ++ get_random_bytes(randbuf, BRCMF_RANDOM_SEED_LENGTH); ++ memcpy_toio(devinfo->tcm + address, randbuf, BRCMF_RANDOM_SEED_LENGTH); ++} ++ + static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo, + const struct firmware *fw, void *nvram, + u32 nvram_len) +@@ -1717,7 +1726,6 @@ static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo, + .length = cpu_to_le32(rand_len), + .magic = cpu_to_le32(BRCMF_RANDOM_SEED_MAGIC), + }; +- void *randbuf; + + /* Some Apple chips/firmwares expect a buffer of random + * data to be present before NVRAM +@@ -1729,10 +1737,7 @@ static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo, + sizeof(footer)); + + address -= rand_len; +- randbuf = kzalloc(rand_len, GFP_KERNEL); +- get_random_bytes(randbuf, rand_len); +- memcpy_toio(devinfo->tcm + address, randbuf, rand_len); +- kfree(randbuf); ++ brcmf_pcie_provide_random_bytes(devinfo, address); + } + } else { + brcmf_dbg(PCIE, "No matching NVRAM file found %s\n", +-- +2.43.0 + diff --git a/queue-6.8/wifi-carl9170-add-a-proper-sanity-check-for-endpoint.patch b/queue-6.8/wifi-carl9170-add-a-proper-sanity-check-for-endpoint.patch new file mode 100644 index 00000000000..55f4e261b82 --- /dev/null +++ b/queue-6.8/wifi-carl9170-add-a-proper-sanity-check-for-endpoint.patch @@ -0,0 +1,97 @@ +From 7afd9515a38e3d19d76ec594a6bb0ee5c2bef0dc Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 22 Apr 2024 11:33:55 -0700 +Subject: wifi: carl9170: add a proper sanity check for endpoints + +From: Nikita Zhandarovich + +[ Upstream commit b6dd09b3dac89b45d1ea3e3bd035a3859c0369a0 ] + +Syzkaller reports [1] hitting a warning which is caused by presence +of a wrong endpoint type at the URB sumbitting stage. While there +was a check for a specific 4th endpoint, since it can switch types +between bulk and interrupt, other endpoints are trusted implicitly. +Similar warning is triggered in a couple of other syzbot issues [2]. + +Fix the issue by doing a comprehensive check of all endpoints +taking into account difference between high- and full-speed +configuration. + +[1] Syzkaller report: +... +WARNING: CPU: 0 PID: 4721 at drivers/usb/core/urb.c:504 usb_submit_urb+0xed6/0x1880 drivers/usb/core/urb.c:504 +... +Call Trace: + + carl9170_usb_send_rx_irq_urb+0x273/0x340 drivers/net/wireless/ath/carl9170/usb.c:504 + carl9170_usb_init_device drivers/net/wireless/ath/carl9170/usb.c:939 [inline] + carl9170_usb_firmware_finish drivers/net/wireless/ath/carl9170/usb.c:999 [inline] + carl9170_usb_firmware_step2+0x175/0x240 drivers/net/wireless/ath/carl9170/usb.c:1028 + request_firmware_work_func+0x130/0x240 drivers/base/firmware_loader/main.c:1107 + process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289 + worker_thread+0x669/0x1090 kernel/workqueue.c:2436 + kthread+0x2e8/0x3a0 kernel/kthread.c:376 + ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 + + +[2] Related syzkaller crashes: +Link: https://syzkaller.appspot.com/bug?extid=e394db78ae0b0032cb4d +Link: https://syzkaller.appspot.com/bug?extid=9468df99cb63a4a4c4e1 + +Reported-and-tested-by: syzbot+0ae4804973be759fa420@syzkaller.appspotmail.com +Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") +Signed-off-by: Nikita Zhandarovich +Acked-By: Christian Lamparter +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240422183355.3785-1-n.zhandarovich@fintech.ru +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/carl9170/usb.c | 32 +++++++++++++++++++++++++ + 1 file changed, 32 insertions(+) + +diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c +index c4edf83559410..a3e03580cd9ff 100644 +--- a/drivers/net/wireless/ath/carl9170/usb.c ++++ b/drivers/net/wireless/ath/carl9170/usb.c +@@ -1069,6 +1069,38 @@ static int carl9170_usb_probe(struct usb_interface *intf, + ar->usb_ep_cmd_is_bulk = true; + } + ++ /* Verify that all expected endpoints are present */ ++ if (ar->usb_ep_cmd_is_bulk) { ++ u8 bulk_ep_addr[] = { ++ AR9170_USB_EP_RX | USB_DIR_IN, ++ AR9170_USB_EP_TX | USB_DIR_OUT, ++ AR9170_USB_EP_CMD | USB_DIR_OUT, ++ 0}; ++ u8 int_ep_addr[] = { ++ AR9170_USB_EP_IRQ | USB_DIR_IN, ++ 0}; ++ if (!usb_check_bulk_endpoints(intf, bulk_ep_addr) || ++ !usb_check_int_endpoints(intf, int_ep_addr)) ++ err = -ENODEV; ++ } else { ++ u8 bulk_ep_addr[] = { ++ AR9170_USB_EP_RX | USB_DIR_IN, ++ AR9170_USB_EP_TX | USB_DIR_OUT, ++ 0}; ++ u8 int_ep_addr[] = { ++ AR9170_USB_EP_IRQ | USB_DIR_IN, ++ AR9170_USB_EP_CMD | USB_DIR_OUT, ++ 0}; ++ if (!usb_check_bulk_endpoints(intf, bulk_ep_addr) || ++ !usb_check_int_endpoints(intf, int_ep_addr)) ++ err = -ENODEV; ++ } ++ ++ if (err) { ++ carl9170_free(ar); ++ return err; ++ } ++ + usb_set_intfdata(intf, ar); + SET_IEEE80211_DEV(ar->hw, &intf->dev); + +-- +2.43.0 + diff --git a/queue-6.8/wifi-carl9170-re-fix-fortified-memset-warning.patch b/queue-6.8/wifi-carl9170-re-fix-fortified-memset-warning.patch new file mode 100644 index 00000000000..fa34e0927ab --- /dev/null +++ b/queue-6.8/wifi-carl9170-re-fix-fortified-memset-warning.patch @@ -0,0 +1,60 @@ +From b26b15d04a80eac1088e3d262b0f1d2ba073cbd3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 4 Apr 2024 09:35:58 +0300 +Subject: wifi: carl9170: re-fix fortified-memset warning + +From: Arnd Bergmann + +[ Upstream commit 066afafc10c9476ee36c47c9062527a17e763901 ] + +The carl9170_tx_release() function sometimes triggers a fortified-memset +warning in my randconfig builds: + +In file included from include/linux/string.h:254, + from drivers/net/wireless/ath/carl9170/tx.c:40: +In function 'fortify_memset_chk', + inlined from 'carl9170_tx_release' at drivers/net/wireless/ath/carl9170/tx.c:283:2, + inlined from 'kref_put' at include/linux/kref.h:65:3, + inlined from 'carl9170_tx_put_skb' at drivers/net/wireless/ath/carl9170/tx.c:342:9: +include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] + 493 | __write_overflow_field(p_size_field, size); + +Kees previously tried to avoid this by using memset_after(), but it seems +this does not fully address the problem. I noticed that the memset_after() +here is done on a different part of the union (status) than the original +cast was from (rate_driver_data), which may confuse the compiler. + +Unfortunately, the memset_after() trick does not work on driver_rates[] +because that is part of an anonymous struct, and I could not get +struct_group() to do this either. Using two separate memset() calls +on the two members does address the warning though. + +Fixes: fb5f6a0e8063b ("mac80211: Use memset_after() to clear tx status") +Link: https://lore.kernel.org/lkml/20230623152443.2296825-1-arnd@kernel.org/ +Signed-off-by: Arnd Bergmann +Reviewed-by: Kees Cook +Acked-by: Christian Lamparter +Signed-off-by: Kalle Valo +Link: https://msgid.link/20240328135509.3755090-2-arnd@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/ath/carl9170/tx.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c +index 6bb9aa2bfe654..88ef6e023f826 100644 +--- a/drivers/net/wireless/ath/carl9170/tx.c ++++ b/drivers/net/wireless/ath/carl9170/tx.c +@@ -280,7 +280,8 @@ static void carl9170_tx_release(struct kref *ref) + * carl9170_tx_fill_rateinfo() has filled the rate information + * before we get to this point. + */ +- memset_after(&txinfo->status, 0, rates); ++ memset(&txinfo->pad, 0, sizeof(txinfo->pad)); ++ memset(&txinfo->rate_driver_data, 0, sizeof(txinfo->rate_driver_data)); + + if (atomic_read(&ar->tx_total_queued)) + ar->tx_schedule = true; +-- +2.43.0 + diff --git a/queue-6.8/wifi-cfg80211-fix-the-order-of-arguments-for-trace-e.patch b/queue-6.8/wifi-cfg80211-fix-the-order-of-arguments-for-trace-e.patch new file mode 100644 index 00000000000..32eecfeb4ba --- /dev/null +++ b/queue-6.8/wifi-cfg80211-fix-the-order-of-arguments-for-trace-e.patch @@ -0,0 +1,50 @@ +From af18de18053f3d60d527ccbb25c239db858dc90e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 18:24:30 +0300 +Subject: wifi: cfg80211: fix the order of arguments for trace events of the + tx_rx_evt class + +From: Igor Artemiev + +[ Upstream commit 9ef369973cd2c97cce3388d2c0c7e3c056656e8a ] + +The declarations of the tx_rx_evt class and the rdev_set_antenna event +use the wrong order of arguments in the TP_ARGS macro. + +Fix the order of arguments in the TP_ARGS macro. + +Found by Linux Verification Center (linuxtesting.org) with SVACE. + +Signed-off-by: Igor Artemiev +Link: https://msgid.link/20240405152431.270267-1-Igor.A.Artemiev@mcst.ru +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/wireless/trace.h | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/net/wireless/trace.h b/net/wireless/trace.h +index cc3fd4177bcee..0cf8f958081eb 100644 +--- a/net/wireless/trace.h ++++ b/net/wireless/trace.h +@@ -1747,7 +1747,7 @@ TRACE_EVENT(rdev_return_void_tx_rx, + + DECLARE_EVENT_CLASS(tx_rx_evt, + TP_PROTO(struct wiphy *wiphy, u32 tx, u32 rx), +- TP_ARGS(wiphy, rx, tx), ++ TP_ARGS(wiphy, tx, rx), + TP_STRUCT__entry( + WIPHY_ENTRY + __field(u32, tx) +@@ -1764,7 +1764,7 @@ DECLARE_EVENT_CLASS(tx_rx_evt, + + DEFINE_EVENT(tx_rx_evt, rdev_set_antenna, + TP_PROTO(struct wiphy *wiphy, u32 tx, u32 rx), +- TP_ARGS(wiphy, rx, tx) ++ TP_ARGS(wiphy, tx, rx) + ); + + DECLARE_EVENT_CLASS(wiphy_netdev_id_evt, +-- +2.43.0 + diff --git a/queue-6.8/wifi-ieee80211-fix-ieee80211_mle_basic_sta_prof_size.patch b/queue-6.8/wifi-ieee80211-fix-ieee80211_mle_basic_sta_prof_size.patch new file mode 100644 index 00000000000..c92703994ff --- /dev/null +++ b/queue-6.8/wifi-ieee80211-fix-ieee80211_mle_basic_sta_prof_size.patch @@ -0,0 +1,45 @@ +From 94c3a49b117399e3d3c590d544103fc34ef7b834 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 18 Mar 2024 18:53:18 +0200 +Subject: wifi: ieee80211: fix ieee80211_mle_basic_sta_prof_size_ok() + +From: Johannes Berg + +[ Upstream commit c121514df0daa800cc500dc2738e0b8a1c54af98 ] + +If there was a possibility of an MLE basic STA profile without +subelements, we might reject it because we account for the one +octet for sta_info_len twice (it's part of itself, and in the +fixed portion). Like in ieee80211_mle_reconf_sta_prof_size_ok, +subtract 1 to adjust that. + +When reading the elements we did take this into account, and +since there are always elements, this never really mattered. + +Fixes: 7b6f08771bf6 ("wifi: ieee80211: Support validating ML station profile length") +Signed-off-by: Johannes Berg +Reviewed-by: Ilan Peer +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240318184907.00bb0b20ed60.I8c41dd6fc14c4b187ab901dea15ade73c79fb98c@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + include/linux/ieee80211.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h +index 83c4d060a5596..b69771a2e4e74 100644 +--- a/include/linux/ieee80211.h ++++ b/include/linux/ieee80211.h +@@ -5145,7 +5145,7 @@ static inline bool ieee80211_mle_basic_sta_prof_size_ok(const u8 *data, + info_len += 1; + + return prof->sta_info_len >= info_len && +- fixed + prof->sta_info_len <= len; ++ fixed + prof->sta_info_len - 1 <= len; + } + + /** +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-implement-can_activate_links-callback.patch b/queue-6.8/wifi-iwlwifi-implement-can_activate_links-callback.patch new file mode 100644 index 00000000000..48b87d732ca --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-implement-can_activate_links-callback.patch @@ -0,0 +1,80 @@ +From 85e49a7060805a02490544c4401144b81c63f25a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 23 Jan 2024 20:08:22 +0200 +Subject: wifi: iwlwifi: implement can_activate_links callback + +From: Miri Korenblit + +[ Upstream commit c4d32f2745c75c9041937767f0329f6f1051778b ] + +This callback checks if a given bitmap of active_links +will be supported by the driver or not. + +Signed-off-by: Miri Korenblit +Reviewed-by: Gregory Greenman +Reviewed-by: Johannes Berg +Link: https://msgid.link/20240123200528.a26fd48bfe3d.I03ae6b4c7fd24e8701660a68cec9403dc3469a0e@changeid +Signed-off-by: Johannes Berg +Stable-dep-of: 9737da2f00d6 ("wifi: iwlwifi: mvm: fix active link counting during recovery") +Signed-off-by: Sasha Levin +--- + .../wireless/intel/iwlwifi/mvm/mld-mac80211.c | 18 ++++++++++-------- + 1 file changed, 10 insertions(+), 8 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +index 893b69fc841b8..1da4fd1c4560b 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +@@ -254,9 +254,6 @@ __iwl_mvm_mld_assign_vif_chanctx(struct iwl_mvm *mvm, + if (!rcu_access_pointer(link_conf->chanctx_conf)) + n_active++; + +- if (n_active > iwl_mvm_max_active_links(mvm, vif)) +- return -EOPNOTSUPP; +- + if (WARN_ON_ONCE(!mvmvif->link[link_id])) + return -EINVAL; + +@@ -1122,17 +1119,12 @@ iwl_mvm_mld_change_vif_links(struct ieee80211_hw *hw, + struct ieee80211_bss_conf *old[IEEE80211_MLD_MAX_NUM_LINKS]) + { + struct iwl_mvm_vif_link_info *new_link[IEEE80211_MLD_MAX_NUM_LINKS] = {}; +- unsigned int n_active = iwl_mvm_mld_count_active_links(vif); + struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); + struct iwl_mvm *mvm = IWL_MAC80211_GET_MVM(hw); + u16 removed = old_links & ~new_links; + u16 added = new_links & ~old_links; + int err, i; + +- if (hweight16(new_links) > 1 && +- n_active > iwl_mvm_max_active_links(mvm, vif)) +- return -EOPNOTSUPP; +- + for (i = 0; i < IEEE80211_MLD_MAX_NUM_LINKS; i++) { + int r; + +@@ -1224,6 +1216,15 @@ iwl_mvm_mld_change_sta_links(struct ieee80211_hw *hw, + return ret; + } + ++static bool iwl_mvm_mld_can_activate_links(struct ieee80211_hw *hw, ++ struct ieee80211_vif *vif, ++ u16 desired_links) ++{ ++ struct iwl_mvm *mvm = IWL_MAC80211_GET_MVM(hw); ++ ++ return hweight16(desired_links) <= iwl_mvm_max_active_links(mvm, vif); ++} ++ + const struct ieee80211_ops iwl_mvm_mld_hw_ops = { + .tx = iwl_mvm_mac_tx, + .wake_tx_queue = iwl_mvm_mac_wake_tx_queue, +@@ -1318,4 +1319,5 @@ const struct ieee80211_ops iwl_mvm_mld_hw_ops = { + + .change_vif_links = iwl_mvm_mld_change_vif_links, + .change_sta_links = iwl_mvm_mld_change_sta_links, ++ .can_activate_links = iwl_mvm_mld_can_activate_links, + }; +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-allocate-sta-links-only-for-active-.patch b/queue-6.8/wifi-iwlwifi-mvm-allocate-sta-links-only-for-active-.patch new file mode 100644 index 00000000000..2516beed683 --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-allocate-sta-links-only-for-active-.patch @@ -0,0 +1,50 @@ +From 3eb521eb36712d9c095e18f86210c5d0b8efa915 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 19 Mar 2024 10:10:27 +0200 +Subject: wifi: iwlwifi: mvm: allocate STA links only for active links + +From: Johannes Berg + +[ Upstream commit 62bdd97598f8be82a24f556f78336b05d1c3e84b ] + +For the mvm driver, data structures match what's in the firmware, +we allocate FW IDs for them already etc. During link switch we +already allocate/free the STA links appropriately, but initially +we'd allocate them always. Fix this to allocate memory, a STA ID, +etc. only for active links. + +Fixes: 57974a55d995 ("wifi: iwlwifi: mvm: refactor iwl_mvm_mac_sta_state_common()") +Signed-off-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240319100755.f2093ff73465.Ie891e1cc9c9df09ae22be6aad5c143e376f40f0e@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +index 23e64a757cfe8..4ba1599ed71ca 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +@@ -582,14 +582,14 @@ static int iwl_mvm_mld_alloc_sta_links(struct iwl_mvm *mvm, + struct ieee80211_sta *sta) + { + struct iwl_mvm_sta *mvm_sta = iwl_mvm_sta_from_mac80211(sta); ++ struct ieee80211_link_sta *link_sta; + unsigned int link_id; + int ret; + + lockdep_assert_held(&mvm->mutex); + +- for (link_id = 0; link_id < ARRAY_SIZE(sta->link); link_id++) { +- if (!rcu_access_pointer(sta->link[link_id]) || +- mvm_sta->link[link_id]) ++ for_each_sta_active_link(vif, sta, link_sta, link_id) { ++ if (WARN_ON(mvm_sta->link[link_id])) + continue; + + ret = iwl_mvm_mld_alloc_sta_link(mvm, vif, sta, link_id); +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-do-not-warn-on-invalid-link-on-scan.patch b/queue-6.8/wifi-iwlwifi-mvm-do-not-warn-on-invalid-link-on-scan.patch new file mode 100644 index 00000000000..5ad46525871 --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-do-not-warn-on-invalid-link-on-scan.patch @@ -0,0 +1,44 @@ +From b31df796425d89738acb68dc98a34a0d10f46237 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 19 Mar 2024 10:10:25 +0200 +Subject: wifi: iwlwifi: mvm: Do not warn on invalid link on scan complete + +From: Ilan Peer + +[ Upstream commit 1c78d39f4ede227e50e36165b3a76bc7c37ead02 ] + +As it is possible that by the time the scan is completed the link was +already removed. + +Fixes: 3a5a5cb06700 ("wifi: iwlwifi: mvm: Correctly report TSF data in scan complete") +Signed-off-by: Ilan Peer +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240319100755.619d3574a757.I0523e92547f0288c8b0119b1fdc5e967a5a8956e@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 7 ++++++- + 1 file changed, 6 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +index 97d44354dbbb5..3dc6fb0600aae 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +@@ -3173,8 +3173,13 @@ void iwl_mvm_rx_umac_scan_complete_notif(struct iwl_mvm *mvm, + struct iwl_mvm_vif_link_info *link_info = + scan_vif->link[mvm->scan_link_id]; + +- if (!WARN_ON(!link_info)) ++ /* It is possible that by the time the scan is complete the link ++ * was already removed and is not valid. ++ */ ++ if (link_info) + memcpy(info.tsf_bssid, link_info->bssid, ETH_ALEN); ++ else ++ IWL_DEBUG_SCAN(mvm, "Scan link is no longer valid\n"); + + ieee80211_scan_completed(mvm->hw, &info); + mvm->scan_vif = NULL; +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-fix-active-link-counting-during-rec.patch b/queue-6.8/wifi-iwlwifi-mvm-fix-active-link-counting-during-rec.patch new file mode 100644 index 00000000000..288cab69217 --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-fix-active-link-counting-during-rec.patch @@ -0,0 +1,87 @@ +From a7a2884e0110c75cb66badcb70b4b1a48cf52170 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 23:26:25 +0200 +Subject: wifi: iwlwifi: mvm: fix active link counting during recovery + +From: Benjamin Berg + +[ Upstream commit 9737da2f00d6409ae48a79d4dddd9362b230aa31 ] + +During recovery, the chanctx_conf in mac80211 is still non-NULL even +though the channel context has not yet been assigned again. In that +case, the real count is actually lower. + +Switch to instead count the phy_ctx assignment and ensure that the +assignment is cleared at the start of recovery. + +Fixes: 12bacfc2c065 ("wifi: iwlwifi: handle eSR transitions") +Signed-off-by: Benjamin Berg +Reviewed-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240320232419.55f37339e7d1.I57006568a90ffb7a1232def1b2f3264dea711ba6@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + .../wireless/intel/iwlwifi/mvm/mld-mac80211.c | 20 ++++++++----------- + 1 file changed, 8 insertions(+), 12 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +index 1da4fd1c4560b..0aa54d33e3ba1 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +@@ -189,17 +189,13 @@ static void iwl_mvm_mld_mac_remove_interface(struct ieee80211_hw *hw, + mutex_unlock(&mvm->mutex); + } + +-static unsigned int iwl_mvm_mld_count_active_links(struct ieee80211_vif *vif) ++static unsigned int iwl_mvm_mld_count_active_links(struct iwl_mvm_vif *mvmvif) + { + unsigned int n_active = 0; + int i; + + for (i = 0; i < IEEE80211_MLD_MAX_NUM_LINKS; i++) { +- struct ieee80211_bss_conf *link_conf; +- +- link_conf = link_conf_dereference_protected(vif, i); +- if (link_conf && +- rcu_access_pointer(link_conf->chanctx_conf)) ++ if (mvmvif->link[i] && mvmvif->link[i]->phy_ctxt) + n_active++; + } + +@@ -245,18 +241,18 @@ __iwl_mvm_mld_assign_vif_chanctx(struct iwl_mvm *mvm, + { + u16 *phy_ctxt_id = (u16 *)ctx->drv_priv; + struct iwl_mvm_phy_ctxt *phy_ctxt = &mvm->phy_ctxts[*phy_ctxt_id]; +- unsigned int n_active = iwl_mvm_mld_count_active_links(vif); + struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); ++ unsigned int n_active = iwl_mvm_mld_count_active_links(mvmvif); + unsigned int link_id = link_conf->link_id; + int ret; + +- /* if the assigned one was not counted yet, count it now */ +- if (!rcu_access_pointer(link_conf->chanctx_conf)) +- n_active++; +- + if (WARN_ON_ONCE(!mvmvif->link[link_id])) + return -EINVAL; + ++ /* if the assigned one was not counted yet, count it now */ ++ if (!mvmvif->link[link_id]->phy_ctxt) ++ n_active++; ++ + /* mac parameters such as HE support can change at this stage + * For sta, need first to configure correct state from drv_sta_state + * and only after that update mac config. +@@ -416,7 +412,7 @@ __iwl_mvm_mld_unassign_vif_chanctx(struct iwl_mvm *mvm, + + { + struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); +- unsigned int n_active = iwl_mvm_mld_count_active_links(vif); ++ unsigned int n_active = iwl_mvm_mld_count_active_links(mvmvif); + unsigned int link_id = link_conf->link_id; + + /* shouldn't happen, but verify link_id is valid before accessing */ +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-fix-check-in-iwl_mvm_sta_fw_id_mask.patch b/queue-6.8/wifi-iwlwifi-mvm-fix-check-in-iwl_mvm_sta_fw_id_mask.patch new file mode 100644 index 00000000000..fa90e4e22eb --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-fix-check-in-iwl_mvm_sta_fw_id_mask.patch @@ -0,0 +1,41 @@ +From 84940e1b5eb6502d8901811f78e6f0d960c36d88 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 25 Mar 2024 18:08:51 +0100 +Subject: wifi: iwlwifi: mvm: fix check in iwl_mvm_sta_fw_id_mask + +From: Johannes Berg + +[ Upstream commit d69aef8084cc72df7b0f2583096d9b037c647ec8 ] + +In the previous commit, I renamed the variable to differentiate +mac80211/mvm link STA, but forgot to adjust the check. The one +from mac80211 is already non-NULL anyway, but the mvm one can +be NULL when the mac80211 isn't during link switch conditions. +Fix the check. + +Fixes: 2783ab506eaa ("wifi: iwlwifi: mvm: select STA mask only for active links") +Reviewed-by: Daniel Gabay +Reviewed-by: Miriam Rachel Korenblit +Link: https://msgid.link/20240325180850.e95b442bafe9.I8c0119fce7b00cb4f65782930d2c167ed5dd0a6e@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +index dffdd00f8ab62..36dc291d98dd6 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +@@ -36,7 +36,7 @@ u32 iwl_mvm_sta_fw_id_mask(struct iwl_mvm *mvm, struct ieee80211_sta *sta, + mvm_link_sta = + rcu_dereference_check(mvmsta->link[link_id], + lockdep_is_held(&mvm->mutex)); +- if (!link_sta) ++ if (!mvm_link_sta) + continue; + + result |= BIT(mvm_link_sta->sta_id); +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-init-vif-works-only-once.patch b/queue-6.8/wifi-iwlwifi-mvm-init-vif-works-only-once.patch new file mode 100644 index 00000000000..955d671b2c4 --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-init-vif-works-only-once.patch @@ -0,0 +1,116 @@ +From 22a725c9979e82ae733da71203c487dd45266c40 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 16 Apr 2024 13:54:05 +0300 +Subject: wifi: iwlwifi: mvm: init vif works only once + +From: Johannes Berg + +[ Upstream commit 0bcc2155983e03c41b21a356af87ae839a6b3ead ] + +It's dangerous to re-initialize works repeatedly, especially +delayed ones that have an associated timer, and even more so +if they're not necessarily canceled inbetween. This can be +the case for these workers here during FW restart scenarios, +so make sure to initialize it only once. + +While at it, also ensure it is cancelled correctly. + +Fixes: f67806140220 ("iwlwifi: mvm: disconnect in case of bad channel switch parameters") +Signed-off-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240416134215.ddf8eece5eac.I4164f5c9c444b64a9abbaab14c23858713778e35@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 19 +++++++++++++++++-- + .../wireless/intel/iwlwifi/mvm/mld-mac80211.c | 2 ++ + drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ + 3 files changed, 21 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +index e321d41d1aba2..05735817918be 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +@@ -1547,6 +1547,17 @@ static int iwl_mvm_alloc_bcast_mcast_sta(struct iwl_mvm *mvm, + IWL_STA_MULTICAST); + } + ++void iwl_mvm_mac_init_mvmvif(struct iwl_mvm *mvm, struct iwl_mvm_vif *mvmvif) ++{ ++ lockdep_assert_held(&mvm->mutex); ++ ++ if (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status)) ++ return; ++ ++ INIT_DELAYED_WORK(&mvmvif->csa_work, ++ iwl_mvm_channel_switch_disconnect_wk); ++} ++ + static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) + { +@@ -1557,6 +1568,8 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, + + mutex_lock(&mvm->mutex); + ++ iwl_mvm_mac_init_mvmvif(mvm, mvmvif); ++ + mvmvif->mvm = mvm; + + /* the first link always points to the default one */ +@@ -1632,8 +1645,6 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, + mvm->p2p_device_vif = vif; + + iwl_mvm_tcm_add_vif(mvm, vif); +- INIT_DELAYED_WORK(&mvmvif->csa_work, +- iwl_mvm_channel_switch_disconnect_wk); + + if (vif->type == NL80211_IFTYPE_MONITOR) { + mvm->monitor_on = true; +@@ -1671,6 +1682,8 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, + void iwl_mvm_prepare_mac_removal(struct iwl_mvm *mvm, + struct ieee80211_vif *vif) + { ++ struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); ++ + if (vif->type == NL80211_IFTYPE_P2P_DEVICE) { + /* + * Flush the ROC worker which will flush the OFFCHANNEL queue. +@@ -1679,6 +1692,8 @@ void iwl_mvm_prepare_mac_removal(struct iwl_mvm *mvm, + */ + flush_work(&mvm->roc_done_wk); + } ++ ++ cancel_delayed_work_sync(&mvmvif->csa_work); + } + + /* This function is doing the common part of removing the interface for +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +index 935cbe2026491..1b39c9ea55fa3 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +@@ -14,6 +14,8 @@ static int iwl_mvm_mld_mac_add_interface(struct ieee80211_hw *hw, + + mutex_lock(&mvm->mutex); + ++ iwl_mvm_mac_init_mvmvif(mvm, mvmvif); ++ + mvmvif->mvm = mvm; + + /* Not much to do here. The stack will not allow interface +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +index fe0fa9ff533d7..4653f608355cc 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +@@ -1769,6 +1769,8 @@ int iwl_mvm_load_d3_fw(struct iwl_mvm *mvm); + + int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm); + ++void iwl_mvm_mac_init_mvmvif(struct iwl_mvm *mvm, struct iwl_mvm_vif *mvmvif); ++ + /* + * FW notifications / CMD responses handlers + * Convention: iwl_mvm_rx_ +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-mvm-select-sta-mask-only-for-active-lin.patch b/queue-6.8/wifi-iwlwifi-mvm-select-sta-mask-only-for-active-lin.patch new file mode 100644 index 00000000000..ba959fc3bf0 --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-mvm-select-sta-mask-only-for-active-lin.patch @@ -0,0 +1,72 @@ +From b01a2b6478da413c2c3d159f3ffdd2f0ce3137b5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 23:26:36 +0200 +Subject: wifi: iwlwifi: mvm: select STA mask only for active links + +From: Johannes Berg + +[ Upstream commit 2783ab506eaa36dbef40bda0f96eb49fe149790e ] + +During reconfig, we might send keys, but those should be only +sent to already active link stations. Iterate only active ones +to fix that issue. + +Fixes: aea99650f731 ("wifi: iwlwifi: mvm: set STA mask for keys in MLO") +Signed-off-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240320232419.c6818d1c6033.I6357f05c55ef111002ddc169287eb356ca0c1b21@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +index 4ba1599ed71ca..dffdd00f8ab62 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +@@ -9,7 +9,9 @@ + u32 iwl_mvm_sta_fw_id_mask(struct iwl_mvm *mvm, struct ieee80211_sta *sta, + int filter_link_id) + { ++ struct ieee80211_link_sta *link_sta; + struct iwl_mvm_sta *mvmsta; ++ struct ieee80211_vif *vif; + unsigned int link_id; + u32 result = 0; + +@@ -17,26 +19,27 @@ u32 iwl_mvm_sta_fw_id_mask(struct iwl_mvm *mvm, struct ieee80211_sta *sta, + return 0; + + mvmsta = iwl_mvm_sta_from_mac80211(sta); ++ vif = mvmsta->vif; + + /* it's easy when the STA is not an MLD */ + if (!sta->valid_links) + return BIT(mvmsta->deflink.sta_id); + + /* but if it is an MLD, get the mask of all the FW STAs it has ... */ +- for (link_id = 0; link_id < ARRAY_SIZE(mvmsta->link); link_id++) { +- struct iwl_mvm_link_sta *link_sta; ++ for_each_sta_active_link(vif, sta, link_sta, link_id) { ++ struct iwl_mvm_link_sta *mvm_link_sta; + + /* unless we have a specific link in mind */ + if (filter_link_id >= 0 && link_id != filter_link_id) + continue; + +- link_sta = ++ mvm_link_sta = + rcu_dereference_check(mvmsta->link[link_id], + lockdep_is_held(&mvm->mutex)); + if (!link_sta) + continue; + +- result |= BIT(link_sta->sta_id); ++ result |= BIT(mvm_link_sta->sta_id); + } + + return result; +-- +2.43.0 + diff --git a/queue-6.8/wifi-iwlwifi-reconfigure-tlc-during-hw-restart.patch b/queue-6.8/wifi-iwlwifi-reconfigure-tlc-during-hw-restart.patch new file mode 100644 index 00000000000..3ce4b934bdd --- /dev/null +++ b/queue-6.8/wifi-iwlwifi-reconfigure-tlc-during-hw-restart.patch @@ -0,0 +1,45 @@ +From 8136f357797f1be2e7d91a2d09f69333747b4cf8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 23:26:38 +0200 +Subject: wifi: iwlwifi: reconfigure TLC during HW restart + +From: Johannes Berg + +[ Upstream commit 96833fb3c7abfd57bb3ee2de2534c5a3f52b0838 ] + +Since the HW restart flow with multi-link is very similar to +the initial association, we do need to reconfigure TLC there. +Remove the check that prevented that. + +Fixes: d2d0468f60cd ("wifi: iwlwifi: mvm: configure TLC on link activation") +Signed-off-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240320232419.a00adcfe381a.Ic798beccbb7b7d852dc976d539205353588853b0@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c | 7 +------ + 1 file changed, 1 insertion(+), 6 deletions(-) + +diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +index 0aa54d33e3ba1..935cbe2026491 100644 +--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c ++++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +@@ -292,13 +292,8 @@ __iwl_mvm_mld_assign_vif_chanctx(struct iwl_mvm *mvm, + * this needs the phy context assigned (and in FW?), and we cannot + * do it later because it needs to be initialized as soon as we're + * able to TX on the link, i.e. when active. +- * +- * Firmware restart isn't quite correct yet for MLO, but we don't +- * need to do it in that case anyway since it will happen from the +- * normal station state callback. + */ +- if (mvmvif->ap_sta && +- !test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status)) { ++ if (mvmvif->ap_sta) { + struct ieee80211_link_sta *link_sta; + + rcu_read_lock(); +-- +2.43.0 + diff --git a/queue-6.8/wifi-mac80211-don-t-select-link-id-if-not-provided-i.patch b/queue-6.8/wifi-mac80211-don-t-select-link-id-if-not-provided-i.patch new file mode 100644 index 00000000000..942f40b5b8e --- /dev/null +++ b/queue-6.8/wifi-mac80211-don-t-select-link-id-if-not-provided-i.patch @@ -0,0 +1,56 @@ +From 642b98c696262af166dfcbd763388a2ffd71ef6c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 09:14:02 +0200 +Subject: wifi: mac80211: don't select link ID if not provided in scan request + +From: Ayala Beker + +[ Upstream commit 80b0aacd1ad046b46d471cf8ed6203bbd777f988 ] + +If scan request doesn't include a link ID to be used for TSF +reporting, don't select it as it might become inactive before +scan is actually started by the driver. +Instead, let the driver select one of the active links. + +Fixes: cbde0b49f276 ("wifi: mac80211: Extend support for scanning while MLO connected") +Signed-off-by: Ayala Beker +Reviewed-by: Johannes Berg +Signed-off-by: Miri Korenblit +Link: https://msgid.link/20240320091155.a6b643a15755.Ic28ed9a611432387b7f85e9ca9a97a4ce34a6e0f@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/mac80211/scan.c | 16 ++++------------ + 1 file changed, 4 insertions(+), 12 deletions(-) + +diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c +index dd0ec34a3f8a8..d613a9e3ae1fd 100644 +--- a/net/mac80211/scan.c ++++ b/net/mac80211/scan.c +@@ -695,19 +695,11 @@ static int __ieee80211_start_scan(struct ieee80211_sub_if_data *sdata, + return -EBUSY; + + /* For an MLO connection, if a link ID was specified, validate that it +- * is indeed active. If no link ID was specified, select one of the +- * active links. ++ * is indeed active. + */ +- if (ieee80211_vif_is_mld(&sdata->vif)) { +- if (req->tsf_report_link_id >= 0) { +- if (!(sdata->vif.active_links & +- BIT(req->tsf_report_link_id))) +- return -EINVAL; +- } else { +- req->tsf_report_link_id = +- __ffs(sdata->vif.active_links); +- } +- } ++ if (ieee80211_vif_is_mld(&sdata->vif) && req->tsf_report_link_id >= 0 && ++ !(sdata->vif.active_links & BIT(req->tsf_report_link_id))) ++ return -EINVAL; + + if (!__ieee80211_can_leave_ch(sdata)) + return -EBUSY; +-- +2.43.0 + diff --git a/queue-6.8/wifi-mac80211-don-t-use-rate-mask-for-scanning.patch b/queue-6.8/wifi-mac80211-don-t-use-rate-mask-for-scanning.patch new file mode 100644 index 00000000000..ae153081d18 --- /dev/null +++ b/queue-6.8/wifi-mac80211-don-t-use-rate-mask-for-scanning.patch @@ -0,0 +1,119 @@ +From c23785873ec1e01e03bb8b8e45ea8c7babd01dd8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 26 Mar 2024 22:08:54 +0100 +Subject: wifi: mac80211: don't use rate mask for scanning + +From: Johannes Berg + +[ Upstream commit ab9177d83c040eba58387914077ebca56f14fae6 ] + +The rate mask is intended for use during operation, and +can be set to only have masks for the currently active +band. As such, it cannot be used for scanning which can +be on other bands as well. + +Simply ignore the rate masks during scanning to avoid +warnings from incorrect settings. + +Reported-by: syzbot+fdc5123366fb9c3fdc6d@syzkaller.appspotmail.com +Closes: https://syzkaller.appspot.com/bug?extid=fdc5123366fb9c3fdc6d +Co-developed-by: Dmitry Antipov +Signed-off-by: Dmitry Antipov +Tested-by: Dmitry Antipov +Link: https://msgid.link/20240326220854.9594cbb418ca.I7f86c0ba1f98cf7e27c2bacf6c2d417200ecea5c@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + include/net/mac80211.h | 3 +++ + net/mac80211/rate.c | 6 +++++- + net/mac80211/scan.c | 1 + + net/mac80211/tx.c | 13 +++++++++---- + 4 files changed, 18 insertions(+), 5 deletions(-) + +diff --git a/include/net/mac80211.h b/include/net/mac80211.h +index d400fe2e8668d..df9b578e58bb2 100644 +--- a/include/net/mac80211.h ++++ b/include/net/mac80211.h +@@ -932,6 +932,8 @@ enum mac80211_tx_info_flags { + * of their QoS TID or other priority field values. + * @IEEE80211_TX_CTRL_MCAST_MLO_FIRST_TX: first MLO TX, used mostly internally + * for sequence number assignment ++ * @IEEE80211_TX_CTRL_SCAN_TX: Indicates that this frame is transmitted ++ * due to scanning, not in normal operation on the interface. + * @IEEE80211_TX_CTRL_MLO_LINK: If not @IEEE80211_LINK_UNSPECIFIED, this + * frame should be transmitted on the specific link. This really is + * only relevant for frames that do not have data present, and is +@@ -952,6 +954,7 @@ enum mac80211_tx_control_flags { + IEEE80211_TX_CTRL_NO_SEQNO = BIT(7), + IEEE80211_TX_CTRL_DONT_REORDER = BIT(8), + IEEE80211_TX_CTRL_MCAST_MLO_FIRST_TX = BIT(9), ++ IEEE80211_TX_CTRL_SCAN_TX = BIT(10), + IEEE80211_TX_CTRL_MLO_LINK = 0xf0000000, + }; + +diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c +index 0efdaa8f2a92e..3cf252418bd38 100644 +--- a/net/mac80211/rate.c ++++ b/net/mac80211/rate.c +@@ -877,6 +877,7 @@ void ieee80211_get_tx_rates(struct ieee80211_vif *vif, + struct ieee80211_sub_if_data *sdata; + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); + struct ieee80211_supported_band *sband; ++ u32 mask = ~0; + + rate_control_fill_sta_table(sta, info, dest, max_rates); + +@@ -889,9 +890,12 @@ void ieee80211_get_tx_rates(struct ieee80211_vif *vif, + if (ieee80211_is_tx_data(skb)) + rate_control_apply_mask(sdata, sta, sband, dest, max_rates); + ++ if (!(info->control.flags & IEEE80211_TX_CTRL_SCAN_TX)) ++ mask = sdata->rc_rateidx_mask[info->band]; ++ + if (dest[0].idx < 0) + __rate_control_send_low(&sdata->local->hw, sband, sta, info, +- sdata->rc_rateidx_mask[info->band]); ++ mask); + + if (sta) + rate_fixup_ratelist(vif, sband, info, dest, max_rates); +diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c +index f9d5842601fa9..dd0ec34a3f8a8 100644 +--- a/net/mac80211/scan.c ++++ b/net/mac80211/scan.c +@@ -638,6 +638,7 @@ static void ieee80211_send_scan_probe_req(struct ieee80211_sub_if_data *sdata, + cpu_to_le16(IEEE80211_SN_TO_SEQ(sn)); + } + IEEE80211_SKB_CB(skb)->flags |= tx_flags; ++ IEEE80211_SKB_CB(skb)->control.flags |= IEEE80211_TX_CTRL_SCAN_TX; + ieee80211_tx_skb_tid_band(sdata, skb, 7, channel->band); + } + } +diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c +index 6fbb15b65902c..a8a4912bf2cb4 100644 +--- a/net/mac80211/tx.c ++++ b/net/mac80211/tx.c +@@ -701,11 +701,16 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx) + txrc.bss_conf = &tx->sdata->vif.bss_conf; + txrc.skb = tx->skb; + txrc.reported_rate.idx = -1; +- txrc.rate_idx_mask = tx->sdata->rc_rateidx_mask[info->band]; + +- if (tx->sdata->rc_has_mcs_mask[info->band]) +- txrc.rate_idx_mcs_mask = +- tx->sdata->rc_rateidx_mcs_mask[info->band]; ++ if (unlikely(info->control.flags & IEEE80211_TX_CTRL_SCAN_TX)) { ++ txrc.rate_idx_mask = ~0; ++ } else { ++ txrc.rate_idx_mask = tx->sdata->rc_rateidx_mask[info->band]; ++ ++ if (tx->sdata->rc_has_mcs_mask[info->band]) ++ txrc.rate_idx_mcs_mask = ++ tx->sdata->rc_rateidx_mcs_mask[info->band]; ++ } + + txrc.bss = (tx->sdata->vif.type == NL80211_IFTYPE_AP || + tx->sdata->vif.type == NL80211_IFTYPE_MESH_POINT || +-- +2.43.0 + diff --git a/queue-6.8/wifi-mac80211-ensure-beacon-is-non-s1g-prior-to-extr.patch b/queue-6.8/wifi-mac80211-ensure-beacon-is-non-s1g-prior-to-extr.patch new file mode 100644 index 00000000000..f2292f80c03 --- /dev/null +++ b/queue-6.8/wifi-mac80211-ensure-beacon-is-non-s1g-prior-to-extr.patch @@ -0,0 +1,42 @@ +From 55a0e0c8d0cbfb75ae76194f4d7d540a80c26adb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 28 Mar 2024 11:57:25 +1100 +Subject: wifi: mac80211: ensure beacon is non-S1G prior to extracting the + beacon timestamp field + +From: Richard Kinder + +[ Upstream commit d12b9779cc9ba29d65fbfc728eb8a037871dd331 ] + +Logic inside ieee80211_rx_mgmt_beacon accesses the +mgmt->u.beacon.timestamp field without first checking whether the beacon +received is non-S1G format. + +Fix the problem by checking the beacon is non-S1G format to avoid access +of the mgmt->u.beacon.timestamp field. + +Signed-off-by: Richard Kinder +Link: https://msgid.link/20240328005725.85355-1-richard.kinder@gmail.com +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/mac80211/mlme.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c +index ac0073c8f96f4..df26672fb3383 100644 +--- a/net/mac80211/mlme.c ++++ b/net/mac80211/mlme.c +@@ -6184,7 +6184,8 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_link_data *link, + link->u.mgd.dtim_period = elems->dtim_period; + link->u.mgd.have_beacon = true; + ifmgd->assoc_data->need_beacon = false; +- if (ieee80211_hw_check(&local->hw, TIMING_BEACON_ONLY)) { ++ if (ieee80211_hw_check(&local->hw, TIMING_BEACON_ONLY) && ++ !ieee80211_is_s1g_beacon(hdr->frame_control)) { + link->conf->sync_tsf = + le64_to_cpu(mgmt->u.beacon.timestamp); + link->conf->sync_device_ts = +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7603-add-wpdma-tx-eof-flag-for-pse-clien.patch b/queue-6.8/wifi-mt76-mt7603-add-wpdma-tx-eof-flag-for-pse-clien.patch new file mode 100644 index 00000000000..b3d25c40740 --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7603-add-wpdma-tx-eof-flag-for-pse-clien.patch @@ -0,0 +1,33 @@ +From a27783727c5ac7e2e728e2c50328653416f79858 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 3 Apr 2024 11:11:54 +0200 +Subject: wifi: mt76: mt7603: add wpdma tx eof flag for PSE client reset + +From: Felix Fietkau + +[ Upstream commit 21de5f72260b4246e2415bc900c18139bc52ea80 ] + +This flag is needed for the PSE client reset. Fixes watchdog reset issues. + +Fixes: c677dda16523 ("wifi: mt76: mt7603: improve watchdog reset reliablity") +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7603/mac.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/mac.c b/drivers/net/wireless/mediatek/mt76/mt7603/mac.c +index cf21d06257e53..dc8a77f0a1cc4 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7603/mac.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7603/mac.c +@@ -1393,6 +1393,7 @@ void mt7603_pse_client_reset(struct mt7603_dev *dev) + MT_CLIENT_RESET_TX_R_E_2_S); + + /* Start PSE client TX abort */ ++ mt76_set(dev, MT_WPDMA_GLO_CFG, MT_WPDMA_GLO_CFG_FORCE_TX_EOF); + mt76_set(dev, addr, MT_CLIENT_RESET_TX_R_E_1); + mt76_poll_msec(dev, addr, MT_CLIENT_RESET_TX_R_E_1_S, + MT_CLIENT_RESET_TX_R_E_1_S, 500); +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7603-fix-tx-queue-of-loopback-packets.patch b/queue-6.8/wifi-mt76-mt7603-fix-tx-queue-of-loopback-packets.patch new file mode 100644 index 00000000000..8ce24ea9c8a --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7603-fix-tx-queue-of-loopback-packets.patch @@ -0,0 +1,109 @@ +From 153d5f8b312540248a8702911263caa71fa7653b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 2 Apr 2024 20:14:34 +0200 +Subject: wifi: mt76: mt7603: fix tx queue of loopback packets + +From: Felix Fietkau + +[ Upstream commit b473c0e47f04d3b4ee9d05d2e79234134aad14d5 ] + +Use the correct WMM AC queue instead of the MGMT one to fix potential issues +with aggregation sequence number tracking. Drop non-bufferable packets. + +Fixes: fca9615f1a43 ("mt76: mt7603: fix up hardware queue index for PS filtered packets") +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + .../net/wireless/mediatek/mt76/mt7603/dma.c | 46 +++++++++++++------ + 1 file changed, 32 insertions(+), 14 deletions(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c +index 7a2f5d38562b4..14304b0637158 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c +@@ -4,6 +4,13 @@ + #include "mac.h" + #include "../dma.h" + ++static const u8 wmm_queue_map[] = { ++ [IEEE80211_AC_BK] = 0, ++ [IEEE80211_AC_BE] = 1, ++ [IEEE80211_AC_VI] = 2, ++ [IEEE80211_AC_VO] = 3, ++}; ++ + static void + mt7603_rx_loopback_skb(struct mt7603_dev *dev, struct sk_buff *skb) + { +@@ -22,10 +29,10 @@ mt7603_rx_loopback_skb(struct mt7603_dev *dev, struct sk_buff *skb) + struct ieee80211_sta *sta; + struct mt7603_sta *msta; + struct mt76_wcid *wcid; ++ u8 tid = 0, hwq = 0; + void *priv; + int idx; + u32 val; +- u8 tid = 0; + + if (skb->len < MT_TXD_SIZE + sizeof(struct ieee80211_hdr)) + goto free; +@@ -42,19 +49,36 @@ mt7603_rx_loopback_skb(struct mt7603_dev *dev, struct sk_buff *skb) + goto free; + + priv = msta = container_of(wcid, struct mt7603_sta, wcid); +- val = le32_to_cpu(txd[0]); +- val &= ~(MT_TXD0_P_IDX | MT_TXD0_Q_IDX); +- val |= FIELD_PREP(MT_TXD0_Q_IDX, MT_TX_HW_QUEUE_MGMT); +- txd[0] = cpu_to_le32(val); + + sta = container_of(priv, struct ieee80211_sta, drv_priv); + hdr = (struct ieee80211_hdr *)&skb->data[MT_TXD_SIZE]; +- if (ieee80211_is_data_qos(hdr->frame_control)) ++ ++ hwq = wmm_queue_map[IEEE80211_AC_BE]; ++ if (ieee80211_is_data_qos(hdr->frame_control)) { + tid = *ieee80211_get_qos_ctl(hdr) & +- IEEE80211_QOS_CTL_TAG1D_MASK; +- skb_set_queue_mapping(skb, tid_to_ac[tid]); ++ IEEE80211_QOS_CTL_TAG1D_MASK; ++ u8 qid = tid_to_ac[tid]; ++ hwq = wmm_queue_map[qid]; ++ skb_set_queue_mapping(skb, qid); ++ } else if (ieee80211_is_data(hdr->frame_control)) { ++ skb_set_queue_mapping(skb, IEEE80211_AC_BE); ++ hwq = wmm_queue_map[IEEE80211_AC_BE]; ++ } else { ++ skb_pull(skb, MT_TXD_SIZE); ++ if (!ieee80211_is_bufferable_mmpdu(skb)) ++ goto free; ++ skb_push(skb, MT_TXD_SIZE); ++ skb_set_queue_mapping(skb, MT_TXQ_PSD); ++ hwq = MT_TX_HW_QUEUE_MGMT; ++ } ++ + ieee80211_sta_set_buffered(sta, tid, true); + ++ val = le32_to_cpu(txd[0]); ++ val &= ~(MT_TXD0_P_IDX | MT_TXD0_Q_IDX); ++ val |= FIELD_PREP(MT_TXD0_Q_IDX, hwq); ++ txd[0] = cpu_to_le32(val); ++ + spin_lock_bh(&dev->ps_lock); + __skb_queue_tail(&msta->psq, skb); + if (skb_queue_len(&msta->psq) >= 64) { +@@ -151,12 +175,6 @@ static int mt7603_poll_tx(struct napi_struct *napi, int budget) + + int mt7603_dma_init(struct mt7603_dev *dev) + { +- static const u8 wmm_queue_map[] = { +- [IEEE80211_AC_BK] = 0, +- [IEEE80211_AC_BE] = 1, +- [IEEE80211_AC_VI] = 2, +- [IEEE80211_AC_VO] = 3, +- }; + int ret; + int i; + +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7915-workaround-too-long-expansion-spars.patch b/queue-6.8/wifi-mt76-mt7915-workaround-too-long-expansion-spars.patch new file mode 100644 index 00000000000..97721799e7a --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7915-workaround-too-long-expansion-spars.patch @@ -0,0 +1,62 @@ +From c6c9d6087630dbfafc91b254af2ba03367f65244 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 19 Mar 2024 16:12:47 +0100 +Subject: wifi: mt76: mt7915: workaround too long expansion sparse warnings + +From: Lorenzo Bianconi + +[ Upstream commit 2d5cde1143eca31c72547dfd589702c6b4a7e684 ] + +Fix the following sparse warnings: + +drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:1133:29: error: too long token expansion +drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:1133:29: error: too long token expansion +drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:1133:29: error: too long token expansion +drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:1133:29: error: too long token expansion + +No functional changes, compile tested only. + +Fixes: e3296759f347 ("wifi: mt76: mt7915: enable per bandwidth power limit support") +Signed-off-by: Lorenzo Bianconi +Acked-by: Felix Fietkau +Signed-off-by: Kalle Valo +Link: https://msgid.link/5457b92e41909dd75ab3db7a0e9ec372b917a386.1710858172.git.lorenzo@kernel.org +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +index 6c3696c8c7002..450f4d221184b 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +@@ -1049,6 +1049,7 @@ static ssize_t + mt7915_rate_txpower_set(struct file *file, const char __user *user_buf, + size_t count, loff_t *ppos) + { ++ int i, ret, pwr, pwr160 = 0, pwr80 = 0, pwr40 = 0, pwr20 = 0; + struct mt7915_phy *phy = file->private_data; + struct mt7915_dev *dev = phy->dev; + struct mt76_phy *mphy = phy->mt76; +@@ -1057,7 +1058,6 @@ mt7915_rate_txpower_set(struct file *file, const char __user *user_buf, + .band_idx = phy->mt76->band_idx, + }; + char buf[100]; +- int i, ret, pwr160 = 0, pwr80 = 0, pwr40 = 0, pwr20 = 0; + enum mac80211_rx_encoding mode; + u32 offs = 0, len = 0; + +@@ -1130,8 +1130,8 @@ mt7915_rate_txpower_set(struct file *file, const char __user *user_buf, + if (ret) + goto out; + +- mphy->txpower_cur = max(mphy->txpower_cur, +- max(pwr160, max(pwr80, max(pwr40, pwr20)))); ++ pwr = max3(pwr80, pwr40, pwr20); ++ mphy->txpower_cur = max3(mphy->txpower_cur, pwr160, pwr); + out: + mutex_unlock(&dev->mt76.mutex); + +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7925-ensure-4-byte-alignment-for-suspend.patch b/queue-6.8/wifi-mt76-mt7925-ensure-4-byte-alignment-for-suspend.patch new file mode 100644 index 00000000000..7f753c4fa6f --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7925-ensure-4-byte-alignment-for-suspend.patch @@ -0,0 +1,49 @@ +From 7764fd8f3eeabb4949b970422f83b638e8a5031a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 7 Mar 2024 19:08:15 +0800 +Subject: wifi: mt76: mt7925: ensure 4-byte alignment for suspend & wow command + +From: Ming Yen Hsieh + +[ Upstream commit fa46bd62c9a8ab195d9c5108a91abf0680fec10e ] + +Before sending suspend & wow command to FW, its length should be +4-bytes alignd. + +Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips") +Signed-off-by: Ming Yen Hsieh +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 1 + + drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +- + 2 files changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +index ae19174b46ee5..5809555a909d7 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c ++++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +@@ -2524,6 +2524,7 @@ int mt76_connac_mcu_set_hif_suspend(struct mt76_dev *dev, bool suspend) + __le16 tag; + __le16 len; + u8 suspend; ++ u8 pad[7]; + } __packed hif_suspend; + } req = { + .hif_suspend = { +diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h +index 2cf39276118eb..1599338e06310 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h ++++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h +@@ -535,7 +535,7 @@ struct mt7925_wow_pattern_tlv { + u8 offset; + u8 mask[MT76_CONNAC_WOW_MASK_MAX_LEN]; + u8 pattern[MT76_CONNAC_WOW_PATTEN_MAX_LEN]; +- u8 rsv[4]; ++ u8 rsv[7]; + } __packed; + + static inline enum connac3_mcu_cipher_type +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch b/queue-6.8/wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch new file mode 100644 index 00000000000..32917e5c294 --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch @@ -0,0 +1,49 @@ +From 6bbe26286734e9cf0f04f2af7b9d65ee0d056670 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 20 Mar 2024 19:09:14 +0800 +Subject: wifi: mt76: mt7996: fix potential memory leakage when reading chip + temperature + +From: Howard Hsu + +[ Upstream commit 474b9412f33be87076b40a49756662594598a85e ] + +Without this commit, reading chip temperature will cause memory leakage. + +Fixes: 6879b2e94172 ("wifi: mt76: mt7996: add thermal sensor device support") +Reported-by: Ryder Lee +Signed-off-by: Howard Hsu +Signed-off-by: Shayne Chen +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +index 25ea81ecdab9b..10d13fa45c5a1 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +@@ -3733,6 +3733,7 @@ int mt7996_mcu_get_temperature(struct mt7996_phy *phy) + } __packed * res; + struct sk_buff *skb; + int ret; ++ u32 temp; + + ret = mt76_mcu_send_and_get_msg(&phy->dev->mt76, MCU_WM_UNI_CMD(THERMAL), + &req, sizeof(req), true, &skb); +@@ -3740,8 +3741,10 @@ int mt7996_mcu_get_temperature(struct mt7996_phy *phy) + return ret; + + res = (void *)skb->data; ++ temp = le32_to_cpu(res->temperature); ++ dev_kfree_skb(skb); + +- return le32_to_cpu(res->temperature); ++ return temp; + } + + int mt7996_mcu_set_thermal_throttling(struct mt7996_phy *phy, u8 state) +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7996-fix-size-of-txpower-mcu-command.patch b/queue-6.8/wifi-mt76-mt7996-fix-size-of-txpower-mcu-command.patch new file mode 100644 index 00000000000..78021fe22f7 --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7996-fix-size-of-txpower-mcu-command.patch @@ -0,0 +1,68 @@ +From 24feb3980483657f147102b2056248ec2322ee7e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 5 Mar 2024 17:55:35 +0000 +Subject: wifi: mt76: mt7996: fix size of txpower MCU command + +From: Chad Monroe + +[ Upstream commit 66ffcb9abae68625c704b247c7d15cbbc7837391 ] + +Fixes issues with scanning and low power output at some rates. + +Fixes: f75e4779d215 ("wifi: mt76: mt7996: add txpower setting support") +Signed-off-by: Chad Monroe +Signed-off-by: Ryder Lee +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 7 +++++-- + drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h | 1 + + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +index 9e70b960086ac..25ea81ecdab9b 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +@@ -4468,7 +4468,7 @@ int mt7996_mcu_set_txpower_sku(struct mt7996_phy *phy) + u8 band_idx; + } __packed req = { + .tag = cpu_to_le16(UNI_TXPOWER_POWER_LIMIT_TABLE_CTRL), +- .len = cpu_to_le16(sizeof(req) + MT7996_SKU_RATE_NUM - 4), ++ .len = cpu_to_le16(sizeof(req) + MT7996_SKU_PATH_NUM - 4), + .power_ctrl_id = UNI_TXPOWER_POWER_LIMIT_TABLE_CTRL, + .power_limit_type = TX_POWER_LIMIT_TABLE_RATE, + .band_idx = phy->mt76->band_idx, +@@ -4483,7 +4483,7 @@ int mt7996_mcu_set_txpower_sku(struct mt7996_phy *phy) + mphy->txpower_cur = tx_power; + + skb = mt76_mcu_msg_alloc(&dev->mt76, NULL, +- sizeof(req) + MT7996_SKU_RATE_NUM); ++ sizeof(req) + MT7996_SKU_PATH_NUM); + if (!skb) + return -ENOMEM; + +@@ -4507,6 +4507,9 @@ int mt7996_mcu_set_txpower_sku(struct mt7996_phy *phy) + /* eht */ + skb_put_data(skb, &la.eht[0], sizeof(la.eht)); + ++ /* padding */ ++ skb_put_zero(skb, MT7996_SKU_PATH_NUM - MT7996_SKU_RATE_NUM); ++ + return mt76_mcu_skb_send_msg(&dev->mt76, skb, + MCU_WM_UNI_CMD(TXPOWER), true); + } +diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h +index 36d1f247d55aa..ddeb40d522c5a 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h ++++ b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h +@@ -50,6 +50,7 @@ + #define MT7996_CFEND_RATE_11B 0x03 /* 11B LP, 11M */ + + #define MT7996_SKU_RATE_NUM 417 ++#define MT7996_SKU_PATH_NUM 494 + + #define MT7996_MAX_TWT_AGRT 16 + #define MT7996_MAX_STA_TWT_AGRT 8 +-- +2.43.0 + diff --git a/queue-6.8/wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch b/queue-6.8/wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch new file mode 100644 index 00000000000..c35efd8229c --- /dev/null +++ b/queue-6.8/wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch @@ -0,0 +1,37 @@ +From a1de9980b591350e1fe66fa2a399a46fa6f7160e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 19 Mar 2024 13:05:36 +0100 +Subject: wifi: mt76: mt7996: fix uninitialized variable in + mt7996_irq_tasklet() + +From: Lorenzo Bianconi + +[ Upstream commit 1ac710a6e8545c6df7a292f167dd088880a74c05 ] + +Set intr1 to 0 in mt7996_irq_tasklet() in order to avoid possible +uninitialized variable usage if wed is not active for hif2. + +Fixes: 83eafc9251d6 ("wifi: mt76: mt7996: add wed tx support") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Felix Fietkau +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mediatek/mt76/mt7996/mmio.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c +index efd4a767eb37d..c93f82548beeb 100644 +--- a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c ++++ b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c +@@ -519,7 +519,7 @@ static void mt7996_irq_tasklet(struct tasklet_struct *t) + struct mt7996_dev *dev = from_tasklet(dev, t, mt76.irq_tasklet); + struct mtk_wed_device *wed = &dev->mt76.mmio.wed; + struct mtk_wed_device *wed_hif2 = &dev->mt76.mmio.wed_hif2; +- u32 i, intr, mask, intr1; ++ u32 i, intr, mask, intr1 = 0; + + if (dev->hif2 && mtk_wed_device_active(wed_hif2)) { + mtk_wed_device_irq_set_mask(wed_hif2, 0); +-- +2.43.0 + diff --git a/queue-6.8/wifi-mwl8k-initialize-cmd-addr-properly.patch b/queue-6.8/wifi-mwl8k-initialize-cmd-addr-properly.patch new file mode 100644 index 00000000000..717f5a06dee --- /dev/null +++ b/queue-6.8/wifi-mwl8k-initialize-cmd-addr-properly.patch @@ -0,0 +1,38 @@ +From 421701ff7a8c4709b21026bcd39f968e0d11d4a2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 4 May 2024 14:38:15 +0300 +Subject: wifi: mwl8k: initialize cmd->addr[] properly + +From: Dan Carpenter + +[ Upstream commit 1d60eabb82694e58543e2b6366dae3e7465892a5 ] + +This loop is supposed to copy the mac address to cmd->addr but the +i++ increment is missing so it copies everything to cmd->addr[0] and +only the last address is recorded. + +Fixes: 22bedad3ce11 ("net: convert multicast list to list_head") +Signed-off-by: Dan Carpenter +Signed-off-by: Kalle Valo +Link: https://msgid.link/b788be9a-15f5-4cca-a3fe-79df4c8ce7b2@moroto.mountain +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/marvell/mwl8k.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c +index 13bcb123d1223..c0ecd769ada76 100644 +--- a/drivers/net/wireless/marvell/mwl8k.c ++++ b/drivers/net/wireless/marvell/mwl8k.c +@@ -2718,7 +2718,7 @@ __mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti, + cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST); + cmd->numaddr = cpu_to_le16(mc_count); + netdev_hw_addr_list_for_each(ha, mc_list) { +- memcpy(cmd->addr[i], ha->addr, ETH_ALEN); ++ memcpy(cmd->addr[i++], ha->addr, ETH_ALEN); + } + } + +-- +2.43.0 + diff --git a/queue-6.8/wifi-nl80211-avoid-address-calculations-via-out-of-b.patch b/queue-6.8/wifi-nl80211-avoid-address-calculations-via-out-of-b.patch new file mode 100644 index 00000000000..32154f15de3 --- /dev/null +++ b/queue-6.8/wifi-nl80211-avoid-address-calculations-via-out-of-b.patch @@ -0,0 +1,70 @@ +From 0634c14f44e8fbe6b8800397a65984ff987c5a6f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 24 Apr 2024 15:01:01 -0700 +Subject: wifi: nl80211: Avoid address calculations via out of bounds array + indexing + +From: Kees Cook + +[ Upstream commit 838c7b8f1f278404d9d684c34a8cb26dc41aaaa1 ] + +Before request->channels[] can be used, request->n_channels must be set. +Additionally, address calculations for memory after the "channels" array +need to be calculated from the allocation base ("request") rather than +via the first "out of bounds" index of "channels", otherwise run-time +bounds checking will throw a warning. + +Reported-by: Nathan Chancellor +Fixes: e3eac9f32ec0 ("wifi: cfg80211: Annotate struct cfg80211_scan_request with __counted_by") +Signed-off-by: Kees Cook +Tested-by: Nathan Chancellor +Link: https://msgid.link/20240424220057.work.819-kees@kernel.org +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/wireless/nl80211.c | 14 +++++++------- + 1 file changed, 7 insertions(+), 7 deletions(-) + +diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c +index daac83aa8988e..4e7b517c78bfd 100644 +--- a/net/wireless/nl80211.c ++++ b/net/wireless/nl80211.c +@@ -9148,6 +9148,7 @@ static int nl80211_trigger_scan(struct sk_buff *skb, struct genl_info *info) + struct wiphy *wiphy; + int err, tmp, n_ssids = 0, n_channels, i; + size_t ie_len, size; ++ size_t ssids_offset, ie_offset; + + wiphy = &rdev->wiphy; + +@@ -9193,21 +9194,20 @@ static int nl80211_trigger_scan(struct sk_buff *skb, struct genl_info *info) + return -EINVAL; + + size = struct_size(request, channels, n_channels); ++ ssids_offset = size; + size = size_add(size, array_size(sizeof(*request->ssids), n_ssids)); ++ ie_offset = size; + size = size_add(size, ie_len); + request = kzalloc(size, GFP_KERNEL); + if (!request) + return -ENOMEM; ++ request->n_channels = n_channels; + + if (n_ssids) +- request->ssids = (void *)&request->channels[n_channels]; ++ request->ssids = (void *)request + ssids_offset; + request->n_ssids = n_ssids; +- if (ie_len) { +- if (n_ssids) +- request->ie = (void *)(request->ssids + n_ssids); +- else +- request->ie = (void *)(request->channels + n_channels); +- } ++ if (ie_len) ++ request->ie = (void *)request + ie_offset; + + i = 0; + if (scan_freqs) { +-- +2.43.0 + diff --git a/queue-6.8/wifi-rtw89-wow-refine-wowlan-flows-of-hci-interrupts.patch b/queue-6.8/wifi-rtw89-wow-refine-wowlan-flows-of-hci-interrupts.patch new file mode 100644 index 00000000000..976d3c24bab --- /dev/null +++ b/queue-6.8/wifi-rtw89-wow-refine-wowlan-flows-of-hci-interrupts.patch @@ -0,0 +1,108 @@ +From cbb09f6aaa2e4c81865d161a75633af1712242d4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 10:24:55 +0800 +Subject: wifi: rtw89: wow: refine WoWLAN flows of HCI interrupts and low power + mode + +From: Chih-Kang Chang + +[ Upstream commit baaf806e4632a259cc959fd1c516c2d9ed48df6d ] + +After enabling packet offload, the TX will be stuck after resume from +WoWLAN mode. And the 8852c gets error messages like + +rtw89_8852ce 0000:04:00.0: No busy txwd pages available +rtw89_8852ce 0000:04:00.0: queue 0 txwd 100 is not idle +rtw89_8852ce 0000:04:00.0: queue 0 txwd 101 is not idle +rtw89_8852ce 0000:04:00.0: queue 0 txwd 102 is not idle +rtw89_8852ce 0000:04:00.0: queue 0 txwd 103 is not idle + +If suspend/resume many times that firmware will download failed and +disconnection. + +To fix these issues, We removed the rtw89_hci_disable_intr() and +rtw89_hci_enable_intr() during rtw89_wow_swap_fw() to prevent add packet +offload can't receive c2h back due to interrupt disable. Only 8852C and +8922A needs to disable interrupt before downloading fw. + +Furthermore, we avoid using low power HCI mode on WoWLAN mode, to prevent +interrupt enabled, then get interrupt and calculate RXBD mismatched due to +software RXBD index already reset but hardware RXBD index not yet. + +Fixes: 5c12bb66b79d ("wifi: rtw89: refine packet offload flow") +Signed-off-by: Chih-Kang Chang +Signed-off-by: Ping-Ke Shih +Link: https://msgid.link/20240502022505.28966-3-pkshih@realtek.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/realtek/rtw89/ps.c | 3 ++- + drivers/net/wireless/realtek/rtw89/wow.c | 12 ++++++++++-- + 2 files changed, 12 insertions(+), 3 deletions(-) + +diff --git a/drivers/net/wireless/realtek/rtw89/ps.c b/drivers/net/wireless/realtek/rtw89/ps.c +index 917c01e5e9eda..e86d5588ec609 100644 +--- a/drivers/net/wireless/realtek/rtw89/ps.c ++++ b/drivers/net/wireless/realtek/rtw89/ps.c +@@ -54,7 +54,8 @@ static void rtw89_ps_power_mode_change_with_hci(struct rtw89_dev *rtwdev, + + static void rtw89_ps_power_mode_change(struct rtw89_dev *rtwdev, bool enter) + { +- if (rtwdev->chip->low_power_hci_modes & BIT(rtwdev->ps_mode)) ++ if (rtwdev->chip->low_power_hci_modes & BIT(rtwdev->ps_mode) && ++ !test_bit(RTW89_FLAG_WOWLAN, rtwdev->flags)) + rtw89_ps_power_mode_change_with_hci(rtwdev, enter); + else + rtw89_mac_power_mode_change(rtwdev, enter); +diff --git a/drivers/net/wireless/realtek/rtw89/wow.c b/drivers/net/wireless/realtek/rtw89/wow.c +index 5c7ca36c09b6b..abb4d1cc55d0e 100644 +--- a/drivers/net/wireless/realtek/rtw89/wow.c ++++ b/drivers/net/wireless/realtek/rtw89/wow.c +@@ -489,14 +489,17 @@ static int rtw89_wow_swap_fw(struct rtw89_dev *rtwdev, bool wow) + struct rtw89_wow_param *rtw_wow = &rtwdev->wow; + struct ieee80211_vif *wow_vif = rtw_wow->wow_vif; + struct rtw89_vif *rtwvif = (struct rtw89_vif *)wow_vif->drv_priv; ++ enum rtw89_core_chip_id chip_id = rtwdev->chip->chip_id; + const struct rtw89_chip_info *chip = rtwdev->chip; + bool include_bb = !!chip->bbmcu_nr; ++ bool disable_intr_for_dlfw = false; + struct ieee80211_sta *wow_sta; + struct rtw89_sta *rtwsta = NULL; + bool is_conn = true; + int ret; + +- rtw89_hci_disable_intr(rtwdev); ++ if (chip_id == RTL8852C || chip_id == RTL8922A) ++ disable_intr_for_dlfw = true; + + wow_sta = ieee80211_find_sta(wow_vif, rtwvif->bssid); + if (wow_sta) +@@ -504,12 +507,18 @@ static int rtw89_wow_swap_fw(struct rtw89_dev *rtwdev, bool wow) + else + is_conn = false; + ++ if (disable_intr_for_dlfw) ++ rtw89_hci_disable_intr(rtwdev); ++ + ret = rtw89_fw_download(rtwdev, fw_type, include_bb); + if (ret) { + rtw89_warn(rtwdev, "download fw failed\n"); + return ret; + } + ++ if (disable_intr_for_dlfw) ++ rtw89_hci_enable_intr(rtwdev); ++ + rtw89_phy_init_rf_reg(rtwdev, true); + + ret = rtw89_fw_h2c_role_maintain(rtwdev, rtwvif, rtwsta, +@@ -552,7 +561,6 @@ static int rtw89_wow_swap_fw(struct rtw89_dev *rtwdev, bool wow) + } + + rtw89_mac_hw_mgnt_sec(rtwdev, wow); +- rtw89_hci_enable_intr(rtwdev); + + return 0; + } +-- +2.43.0 + diff --git a/queue-6.8/x86-boot-64-clear-most-of-cr4-in-startup_64-except-p.patch b/queue-6.8/x86-boot-64-clear-most-of-cr4-in-startup_64-except-p.patch new file mode 100644 index 00000000000..8d6b79b9950 --- /dev/null +++ b/queue-6.8/x86-boot-64-clear-most-of-cr4-in-startup_64-except-p.patch @@ -0,0 +1,74 @@ +From 39126f93b3fb57b2216a9f80af1626c9d959a68e Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 10 Apr 2024 17:13:55 +0200 +Subject: x86/boot/64: Clear most of CR4 in startup_64(), except PAE, MCE and + LA57 + +From: Ard Biesheuvel + +[ Upstream commit a0025f587c685e5ff842fb0194036f2ca0b6eaf4 ] + +The early 64-bit boot code must be entered with a 1:1 mapping of the +bootable image, but it cannot operate without a 1:1 mapping of all the +assets in memory that it accesses, and therefore, it creates such +mappings for all known assets upfront, and additional ones on demand +when a page fault happens on a memory address. + +These mappings are created with the global bit G set, as the flags used +to create page table descriptors are based on __PAGE_KERNEL_LARGE_EXEC +defined by the core kernel, even though the context where these mappings +are used is very different. + +This means that the TLB maintenance carried out by the decompressor is +not sufficient if it is entered with CR4.PGE enabled, which has been +observed to happen with the stage0 bootloader of project Oak. While this +is a dubious practice if no global mappings are being used to begin +with, the decompressor is clearly at fault here for creating global +mappings and not performing the appropriate TLB maintenance. + +Since commit: + + f97b67a773cd84b ("x86/decompressor: Only call the trampoline when changing paging levels") + +CR4 is no longer modified by the decompressor if no change in the number +of paging levels is needed. Before that, CR4 would always be set to a +consistent value with PGE cleared. + +So let's reinstate a simplified version of the original logic to put CR4 +into a known state, and preserve the PAE, MCE and LA57 bits, none of +which can be modified freely at this point (PAE and LA57 cannot be +changed while running in long mode, and MCE cannot be cleared when +running under some hypervisors). + +This effectively clears PGE and works around the project Oak bug. + +Fixes: f97b67a773cd84b ("x86/decompressor: Only call the trampoline when ...") +Signed-off-by: Ard Biesheuvel +Signed-off-by: Ingo Molnar +Cc: Linus Torvalds +Cc: "H. Peter Anvin" +Link: https://lore.kernel.org/r/20240410151354.506098-2-ardb+git@google.com +Signed-off-by: Sasha Levin +--- + arch/x86/boot/compressed/head_64.S | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S +index bf4a10a5794f1..1dcb794c5479e 100644 +--- a/arch/x86/boot/compressed/head_64.S ++++ b/arch/x86/boot/compressed/head_64.S +@@ -398,6 +398,11 @@ SYM_CODE_START(startup_64) + call sev_enable + #endif + ++ /* Preserve only the CR4 bits that must be preserved, and clear the rest */ ++ movq %cr4, %rax ++ andl $(X86_CR4_PAE | X86_CR4_MCE | X86_CR4_LA57), %eax ++ movq %rax, %cr4 ++ + /* + * configure_5level_paging() updates the number of paging levels using + * a trampoline in 32-bit addressable memory if the current number does +-- +2.43.0 + diff --git a/queue-6.8/x86-boot-ignore-relocations-in-.notes-sections-in-wa.patch b/queue-6.8/x86-boot-ignore-relocations-in-.notes-sections-in-wa.patch new file mode 100644 index 00000000000..952d1274d16 --- /dev/null +++ b/queue-6.8/x86-boot-ignore-relocations-in-.notes-sections-in-wa.patch @@ -0,0 +1,54 @@ +From f9df9adb5b968227e9ad9eecc4b371a24ed8c80a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 17 Mar 2024 23:05:47 +0800 +Subject: x86/boot: Ignore relocations in .notes sections in walk_relocs() too + +From: Guixiong Wei + +[ Upstream commit 76e9762d66373354b45c33b60e9a53ef2a3c5ff2 ] + +Commit: + + aaa8736370db ("x86, relocs: Ignore relocations in .notes section") + +... only started ignoring the .notes sections in print_absolute_relocs(), +but the same logic should also by applied in walk_relocs() to avoid +such relocations. + +[ mingo: Fixed various typos in the changelog, removed extra curly braces from the code. ] + +Fixes: aaa8736370db ("x86, relocs: Ignore relocations in .notes section") +Fixes: 5ead97c84fa7 ("xen: Core Xen implementation") +Fixes: da1a679cde9b ("Add /sys/kernel/notes") +Signed-off-by: Guixiong Wei +Signed-off-by: Ingo Molnar +Reviewed-by: Kees Cook +Link: https://lore.kernel.org/r/20240317150547.24910-1-weiguixiong@bytedance.com +Signed-off-by: Sasha Levin +--- + arch/x86/tools/relocs.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c +index b029fb81ebeee..e7a44a7f617fb 100644 +--- a/arch/x86/tools/relocs.c ++++ b/arch/x86/tools/relocs.c +@@ -746,6 +746,15 @@ static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, + if (!(sec_applies->shdr.sh_flags & SHF_ALLOC)) { + continue; + } ++ ++ /* ++ * Do not perform relocations in .notes sections; any ++ * values there are meant for pre-boot consumption (e.g. ++ * startup_xen). ++ */ ++ if (sec_applies->shdr.sh_type == SHT_NOTE) ++ continue; ++ + sh_symtab = sec_symtab->symtab; + sym_strtab = sec_symtab->link->strtab; + for (j = 0; j < sec->shdr.sh_size/sizeof(Elf_Rel); j++) { +-- +2.43.0 + diff --git a/queue-6.8/x86-insn-add-vex-versions-of-vpdpbusd-vpdpbusds-vpdp.patch b/queue-6.8/x86-insn-add-vex-versions-of-vpdpbusd-vpdpbusds-vpdp.patch new file mode 100644 index 00000000000..ba04888e4c0 --- /dev/null +++ b/queue-6.8/x86-insn-add-vex-versions-of-vpdpbusd-vpdpbusds-vpdp.patch @@ -0,0 +1,75 @@ +From 3fbb7e28eb477fbaecb180a88f3041cbd10f44a4 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 13:58:46 +0300 +Subject: x86/insn: Add VEX versions of VPDPBUSD, VPDPBUSDS, VPDPWSSD and + VPDPWSSDS + +From: Adrian Hunter + +[ Upstream commit b8000264348979b60dbe479255570a40e1b3a097 ] + +The x86 instruction decoder is used not only for decoding kernel +instructions. It is also used by perf uprobes (user space probes) and by +perf tools Intel Processor Trace decoding. Consequently, it needs to +support instructions executed by user space also. + +Intel Architecture Instruction Set Extensions and Future Features manual +number 319433-044 of May 2021, documented VEX versions of instructions +VPDPBUSD, VPDPBUSDS, VPDPWSSD and VPDPWSSDS, but the opcode map has them +listed as EVEX only. + +Remove EVEX-only (ev) annotation from instructions VPDPBUSD, VPDPBUSDS, +VPDPWSSD and VPDPWSSDS, which allows them to be decoded with either a VEX +or EVEX prefix. + +Fixes: 0153d98f2dd6 ("x86/insn: Add misc instructions to x86 instruction decoder") +Signed-off-by: Adrian Hunter +Signed-off-by: Ingo Molnar +Link: https://lore.kernel.org/r/20240502105853.5338-4-adrian.hunter@intel.com +Signed-off-by: Sasha Levin +--- + arch/x86/lib/x86-opcode-map.txt | 8 ++++---- + tools/arch/x86/lib/x86-opcode-map.txt | 8 ++++---- + 2 files changed, 8 insertions(+), 8 deletions(-) + +diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt +index 940913550ed83..d1ccd06c53127 100644 +--- a/arch/x86/lib/x86-opcode-map.txt ++++ b/arch/x86/lib/x86-opcode-map.txt +@@ -698,10 +698,10 @@ AVXcode: 2 + 4d: vrcp14ss/d Vsd,Hpd,Wsd (66),(ev) + 4e: vrsqrt14ps/d Vpd,Wpd (66),(ev) + 4f: vrsqrt14ss/d Vsd,Hsd,Wsd (66),(ev) +-50: vpdpbusd Vx,Hx,Wx (66),(ev) +-51: vpdpbusds Vx,Hx,Wx (66),(ev) +-52: vdpbf16ps Vx,Hx,Wx (F3),(ev) | vpdpwssd Vx,Hx,Wx (66),(ev) | vp4dpwssd Vdqq,Hdqq,Wdq (F2),(ev) +-53: vpdpwssds Vx,Hx,Wx (66),(ev) | vp4dpwssds Vdqq,Hdqq,Wdq (F2),(ev) ++50: vpdpbusd Vx,Hx,Wx (66) ++51: vpdpbusds Vx,Hx,Wx (66) ++52: vdpbf16ps Vx,Hx,Wx (F3),(ev) | vpdpwssd Vx,Hx,Wx (66) | vp4dpwssd Vdqq,Hdqq,Wdq (F2),(ev) ++53: vpdpwssds Vx,Hx,Wx (66) | vp4dpwssds Vdqq,Hdqq,Wdq (F2),(ev) + 54: vpopcntb/w Vx,Wx (66),(ev) + 55: vpopcntd/q Vx,Wx (66),(ev) + 58: vpbroadcastd Vx,Wx (66),(v) +diff --git a/tools/arch/x86/lib/x86-opcode-map.txt b/tools/arch/x86/lib/x86-opcode-map.txt +index 940913550ed83..d1ccd06c53127 100644 +--- a/tools/arch/x86/lib/x86-opcode-map.txt ++++ b/tools/arch/x86/lib/x86-opcode-map.txt +@@ -698,10 +698,10 @@ AVXcode: 2 + 4d: vrcp14ss/d Vsd,Hpd,Wsd (66),(ev) + 4e: vrsqrt14ps/d Vpd,Wpd (66),(ev) + 4f: vrsqrt14ss/d Vsd,Hsd,Wsd (66),(ev) +-50: vpdpbusd Vx,Hx,Wx (66),(ev) +-51: vpdpbusds Vx,Hx,Wx (66),(ev) +-52: vdpbf16ps Vx,Hx,Wx (F3),(ev) | vpdpwssd Vx,Hx,Wx (66),(ev) | vp4dpwssd Vdqq,Hdqq,Wdq (F2),(ev) +-53: vpdpwssds Vx,Hx,Wx (66),(ev) | vp4dpwssds Vdqq,Hdqq,Wdq (F2),(ev) ++50: vpdpbusd Vx,Hx,Wx (66) ++51: vpdpbusds Vx,Hx,Wx (66) ++52: vdpbf16ps Vx,Hx,Wx (F3),(ev) | vpdpwssd Vx,Hx,Wx (66) | vp4dpwssd Vdqq,Hdqq,Wdq (F2),(ev) ++53: vpdpwssds Vx,Hx,Wx (66) | vp4dpwssds Vdqq,Hdqq,Wdq (F2),(ev) + 54: vpopcntb/w Vx,Wx (66),(ev) + 55: vpopcntd/q Vx,Wx (66),(ev) + 58: vpbroadcastd Vx,Wx (66),(v) +-- +2.43.0 + diff --git a/queue-6.8/x86-insn-fix-push-instruction-in-x86-instruction-dec.patch b/queue-6.8/x86-insn-fix-push-instruction-in-x86-instruction-dec.patch new file mode 100644 index 00000000000..84aa0f0318b --- /dev/null +++ b/queue-6.8/x86-insn-fix-push-instruction-in-x86-instruction-dec.patch @@ -0,0 +1,98 @@ +From 3bb7e49dd63ed0e842cceb33f58de22f4b23f8f0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 13:58:45 +0300 +Subject: x86/insn: Fix PUSH instruction in x86 instruction decoder opcode map + +From: Adrian Hunter + +[ Upstream commit 59162e0c11d7257cde15f907d19fefe26da66692 ] + +The x86 instruction decoder is used not only for decoding kernel +instructions. It is also used by perf uprobes (user space probes) and by +perf tools Intel Processor Trace decoding. Consequently, it needs to +support instructions executed by user space also. + +Opcode 0x68 PUSH instruction is currently defined as 64-bit operand size +only i.e. (d64). That was based on Intel SDM Opcode Map. However that is +contradicted by the Instruction Set Reference section for PUSH in the +same manual. + +Remove 64-bit operand size only annotation from opcode 0x68 PUSH +instruction. + +Example: + + $ cat pushw.s + .global _start + .text + _start: + pushw $0x1234 + mov $0x1,%eax # system call number (sys_exit) + int $0x80 + $ as -o pushw.o pushw.s + $ ld -s -o pushw pushw.o + $ objdump -d pushw | tail -4 + 0000000000401000 <.text>: + 401000: 66 68 34 12 pushw $0x1234 + 401004: b8 01 00 00 00 mov $0x1,%eax + 401009: cd 80 int $0x80 + $ perf record -e intel_pt//u ./pushw + [ perf record: Woken up 1 times to write data ] + [ perf record: Captured and wrote 0.014 MB perf.data ] + + Before: + + $ perf script --insn-trace=disasm + Warning: + 1 instruction trace errors + pushw 10349 [000] 10586.869237014: 401000 [unknown] (/home/ahunter/git/misc/rtit-tests/pushw) pushw $0x1234 + pushw 10349 [000] 10586.869237014: 401006 [unknown] (/home/ahunter/git/misc/rtit-tests/pushw) addb %al, (%rax) + pushw 10349 [000] 10586.869237014: 401008 [unknown] (/home/ahunter/git/misc/rtit-tests/pushw) addb %cl, %ch + pushw 10349 [000] 10586.869237014: 40100a [unknown] (/home/ahunter/git/misc/rtit-tests/pushw) addb $0x2e, (%rax) + instruction trace error type 1 time 10586.869237224 cpu 0 pid 10349 tid 10349 ip 0x40100d code 6: Trace doesn't match instruction + + After: + + $ perf script --insn-trace=disasm + pushw 10349 [000] 10586.869237014: 401000 [unknown] (./pushw) pushw $0x1234 + pushw 10349 [000] 10586.869237014: 401004 [unknown] (./pushw) movl $1, %eax + +Fixes: eb13296cfaf6 ("x86: Instruction decoder API") +Signed-off-by: Adrian Hunter +Signed-off-by: Ingo Molnar +Link: https://lore.kernel.org/r/20240502105853.5338-3-adrian.hunter@intel.com +Signed-off-by: Sasha Levin +--- + arch/x86/lib/x86-opcode-map.txt | 2 +- + tools/arch/x86/lib/x86-opcode-map.txt | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt +index 5168ee0360b24..940913550ed83 100644 +--- a/arch/x86/lib/x86-opcode-map.txt ++++ b/arch/x86/lib/x86-opcode-map.txt +@@ -148,7 +148,7 @@ AVXcode: + 65: SEG=GS (Prefix) + 66: Operand-Size (Prefix) + 67: Address-Size (Prefix) +-68: PUSH Iz (d64) ++68: PUSH Iz + 69: IMUL Gv,Ev,Iz + 6a: PUSH Ib (d64) + 6b: IMUL Gv,Ev,Ib +diff --git a/tools/arch/x86/lib/x86-opcode-map.txt b/tools/arch/x86/lib/x86-opcode-map.txt +index 5168ee0360b24..940913550ed83 100644 +--- a/tools/arch/x86/lib/x86-opcode-map.txt ++++ b/tools/arch/x86/lib/x86-opcode-map.txt +@@ -148,7 +148,7 @@ AVXcode: + 65: SEG=GS (Prefix) + 66: Operand-Size (Prefix) + 67: Address-Size (Prefix) +-68: PUSH Iz (d64) ++68: PUSH Iz + 69: IMUL Gv,Ev,Iz + 6a: PUSH Ib (d64) + 6b: IMUL Gv,Ev,Ib +-- +2.43.0 + diff --git a/queue-6.8/x86-microcode-amd-avoid-wformat-warning-with-clang-1.patch b/queue-6.8/x86-microcode-amd-avoid-wformat-warning-with-clang-1.patch new file mode 100644 index 00000000000..610b614b2c5 --- /dev/null +++ b/queue-6.8/x86-microcode-amd-avoid-wformat-warning-with-clang-1.patch @@ -0,0 +1,49 @@ +From 18af4cfb9b0f0d055df67243f1c381370742d0ca Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 5 Apr 2024 22:49:07 +0200 +Subject: x86/microcode/AMD: Avoid -Wformat warning with clang-15 + +From: Arnd Bergmann + +[ Upstream commit 9e11fc78e2df7a2649764413029441a0c897fb11 ] + +Older versions of clang show a warning for amd.c after a fix for a gcc +warning: + + arch/x86/kernel/cpu/microcode/amd.c:478:47: error: format specifies type \ + 'unsigned char' but the argument has type 'u16' (aka 'unsigned short') [-Werror,-Wformat] + "amd-ucode/microcode_amd_fam%02hhxh.bin", family); + ~~~~~~ ^~~~~~ + %02hx + +In clang-16 and higher, this warning is disabled by default, but clang-15 is +still supported, and it's trivial to avoid by adapting the types according +to the range of the passed data and the format string. + + [ bp: Massage commit message. ] + +Fixes: 2e9064faccd1 ("x86/microcode/amd: Fix snprintf() format string warning in W=1 build") +Signed-off-by: Arnd Bergmann +Signed-off-by: Borislav Petkov (AMD) +Link: https://lore.kernel.org/r/20240405204919.1003409-1-arnd@kernel.org +Signed-off-by: Sasha Levin +--- + arch/x86/kernel/cpu/microcode/amd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c +index 13b45b9c806da..620f0af713ca2 100644 +--- a/arch/x86/kernel/cpu/microcode/amd.c ++++ b/arch/x86/kernel/cpu/microcode/amd.c +@@ -465,7 +465,7 @@ static bool early_apply_microcode(u32 cpuid_1_eax, u32 old_rev, void *ucode, siz + return !__apply_microcode_amd(mc); + } + +-static bool get_builtin_microcode(struct cpio_data *cp, unsigned int family) ++static bool get_builtin_microcode(struct cpio_data *cp, u8 family) + { + char fw_name[36] = "amd-ucode/microcode_amd.bin"; + struct firmware fw; +-- +2.43.0 + diff --git a/queue-6.8/x86-mm-remove-broken-vsyscall-emulation-code-from-th.patch b/queue-6.8/x86-mm-remove-broken-vsyscall-emulation-code-from-th.patch new file mode 100644 index 00000000000..288c57f28d3 --- /dev/null +++ b/queue-6.8/x86-mm-remove-broken-vsyscall-emulation-code-from-th.patch @@ -0,0 +1,232 @@ +From b22afe13917ec98391356ad51d186ecfdba86e1b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 29 Apr 2024 10:00:51 +0200 +Subject: x86/mm: Remove broken vsyscall emulation code from the page fault + code + +From: Linus Torvalds + +[ Upstream commit 02b670c1f88e78f42a6c5aee155c7b26960ca054 ] + +The syzbot-reported stack trace from hell in this discussion thread +actually has three nested page faults: + + https://lore.kernel.org/r/000000000000d5f4fc0616e816d4@google.com + +... and I think that's actually the important thing here: + + - the first page fault is from user space, and triggers the vsyscall + emulation. + + - the second page fault is from __do_sys_gettimeofday(), and that should + just have caused the exception that then sets the return value to + -EFAULT + + - the third nested page fault is due to _raw_spin_unlock_irqrestore() -> + preempt_schedule() -> trace_sched_switch(), which then causes a BPF + trace program to run, which does that bpf_probe_read_compat(), which + causes that page fault under pagefault_disable(). + +It's quite the nasty backtrace, and there's a lot going on. + +The problem is literally the vsyscall emulation, which sets + + current->thread.sig_on_uaccess_err = 1; + +and that causes the fixup_exception() code to send the signal *despite* the +exception being caught. + +And I think that is in fact completely bogus. It's completely bogus +exactly because it sends that signal even when it *shouldn't* be sent - +like for the BPF user mode trace gathering. + +In other words, I think the whole "sig_on_uaccess_err" thing is entirely +broken, because it makes any nested page-faults do all the wrong things. + +Now, arguably, I don't think anybody should enable vsyscall emulation any +more, but this test case clearly does. + +I think we should just make the "send SIGSEGV" be something that the +vsyscall emulation does on its own, not this broken per-thread state for +something that isn't actually per thread. + +The x86 page fault code actually tried to deal with the "incorrect nesting" +by having that: + + if (in_interrupt()) + return; + +which ignores the sig_on_uaccess_err case when it happens in interrupts, +but as shown by this example, these nested page faults do not need to be +about interrupts at all. + +IOW, I think the only right thing is to remove that horrendously broken +code. + +The attached patch looks like the ObviouslyCorrect(tm) thing to do. + +NOTE! This broken code goes back to this commit in 2011: + + 4fc3490114bb ("x86-64: Set siginfo and context on vsyscall emulation faults") + +... and back then the reason was to get all the siginfo details right. +Honestly, I do not for a moment believe that it's worth getting the siginfo +details right here, but part of the commit says: + + This fixes issues with UML when vsyscall=emulate. + +... and so my patch to remove this garbage will probably break UML in this +situation. + +I do not believe that anybody should be running with vsyscall=emulate in +2024 in the first place, much less if you are doing things like UML. But +let's see if somebody screams. + +Reported-and-tested-by: syzbot+83e7f982ca045ab4405c@syzkaller.appspotmail.com +Signed-off-by: Linus Torvalds +Signed-off-by: Ingo Molnar +Tested-by: Jiri Olsa +Acked-by: Andy Lutomirski +Link: https://lore.kernel.org/r/CAHk-=wh9D6f7HUkDgZHKmDCHUQmp+Co89GP+b8+z+G56BKeyNg@mail.gmail.com +Signed-off-by: Sasha Levin +--- + arch/x86/entry/vsyscall/vsyscall_64.c | 28 ++--------------------- + arch/x86/include/asm/processor.h | 1 - + arch/x86/mm/fault.c | 33 +-------------------------- + 3 files changed, 3 insertions(+), 59 deletions(-) + +diff --git a/arch/x86/entry/vsyscall/vsyscall_64.c b/arch/x86/entry/vsyscall/vsyscall_64.c +index e0ca8120aea87..1245000a8792f 100644 +--- a/arch/x86/entry/vsyscall/vsyscall_64.c ++++ b/arch/x86/entry/vsyscall/vsyscall_64.c +@@ -98,11 +98,6 @@ static int addr_to_vsyscall_nr(unsigned long addr) + + static bool write_ok_or_segv(unsigned long ptr, size_t size) + { +- /* +- * XXX: if access_ok, get_user, and put_user handled +- * sig_on_uaccess_err, this could go away. +- */ +- + if (!access_ok((void __user *)ptr, size)) { + struct thread_struct *thread = ¤t->thread; + +@@ -120,10 +115,8 @@ static bool write_ok_or_segv(unsigned long ptr, size_t size) + bool emulate_vsyscall(unsigned long error_code, + struct pt_regs *regs, unsigned long address) + { +- struct task_struct *tsk; + unsigned long caller; + int vsyscall_nr, syscall_nr, tmp; +- int prev_sig_on_uaccess_err; + long ret; + unsigned long orig_dx; + +@@ -172,8 +165,6 @@ bool emulate_vsyscall(unsigned long error_code, + goto sigsegv; + } + +- tsk = current; +- + /* + * Check for access_ok violations and find the syscall nr. + * +@@ -234,12 +225,8 @@ bool emulate_vsyscall(unsigned long error_code, + goto do_ret; /* skip requested */ + + /* +- * With a real vsyscall, page faults cause SIGSEGV. We want to +- * preserve that behavior to make writing exploits harder. ++ * With a real vsyscall, page faults cause SIGSEGV. + */ +- prev_sig_on_uaccess_err = current->thread.sig_on_uaccess_err; +- current->thread.sig_on_uaccess_err = 1; +- + ret = -EFAULT; + switch (vsyscall_nr) { + case 0: +@@ -262,23 +249,12 @@ bool emulate_vsyscall(unsigned long error_code, + break; + } + +- current->thread.sig_on_uaccess_err = prev_sig_on_uaccess_err; +- + check_fault: + if (ret == -EFAULT) { + /* Bad news -- userspace fed a bad pointer to a vsyscall. */ + warn_bad_vsyscall(KERN_INFO, regs, + "vsyscall fault (exploit attempt?)"); +- +- /* +- * If we failed to generate a signal for any reason, +- * generate one here. (This should be impossible.) +- */ +- if (WARN_ON_ONCE(!sigismember(&tsk->pending.signal, SIGBUS) && +- !sigismember(&tsk->pending.signal, SIGSEGV))) +- goto sigsegv; +- +- return true; /* Don't emulate the ret. */ ++ goto sigsegv; + } + + regs->ax = ret; +diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h +index 26620d7642a9f..5636ad697394d 100644 +--- a/arch/x86/include/asm/processor.h ++++ b/arch/x86/include/asm/processor.h +@@ -479,7 +479,6 @@ struct thread_struct { + unsigned long iopl_emul; + + unsigned int iopl_warn:1; +- unsigned int sig_on_uaccess_err:1; + + /* + * Protection Keys Register for Userspace. Loaded immediately on +diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c +index b01df023de04c..e604d2d6cc8f9 100644 +--- a/arch/x86/mm/fault.c ++++ b/arch/x86/mm/fault.c +@@ -717,39 +717,8 @@ kernelmode_fixup_or_oops(struct pt_regs *regs, unsigned long error_code, + WARN_ON_ONCE(user_mode(regs)); + + /* Are we prepared to handle this kernel fault? */ +- if (fixup_exception(regs, X86_TRAP_PF, error_code, address)) { +- /* +- * Any interrupt that takes a fault gets the fixup. This makes +- * the below recursive fault logic only apply to a faults from +- * task context. +- */ +- if (in_interrupt()) +- return; +- +- /* +- * Per the above we're !in_interrupt(), aka. task context. +- * +- * In this case we need to make sure we're not recursively +- * faulting through the emulate_vsyscall() logic. +- */ +- if (current->thread.sig_on_uaccess_err && signal) { +- sanitize_error_code(address, &error_code); +- +- set_signal_archinfo(address, error_code); +- +- if (si_code == SEGV_PKUERR) { +- force_sig_pkuerr((void __user *)address, pkey); +- } else { +- /* XXX: hwpoison faults will set the wrong code. */ +- force_sig_fault(signal, si_code, (void __user *)address); +- } +- } +- +- /* +- * Barring that, we can do the fixup and be happy. +- */ ++ if (fixup_exception(regs, X86_TRAP_PF, error_code, address)) + return; +- } + + /* + * AMD erratum #91 manifests as a spurious page fault on a PREFETCH +-- +2.43.0 + diff --git a/queue-6.8/x86-numa-fix-srat-lookup-of-cfmws-ranges-with-numa_f.patch b/queue-6.8/x86-numa-fix-srat-lookup-of-cfmws-ranges-with-numa_f.patch new file mode 100644 index 00000000000..6143cdacc93 --- /dev/null +++ b/queue-6.8/x86-numa-fix-srat-lookup-of-cfmws-ranges-with-numa_f.patch @@ -0,0 +1,118 @@ +From 0f8be6dff9dccf9847c71e76d58c3e4563152af2 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 May 2024 15:10:09 +0200 +Subject: x86/numa: Fix SRAT lookup of CFMWS ranges with numa_fill_memblks() + +From: Robert Richter + +[ Upstream commit f9f67e5adc8dc2e1cc51ab2d3d6382fa97f074d4 ] + +For configurations that have the kconfig option NUMA_KEEP_MEMINFO +disabled, numa_fill_memblks() only returns with NUMA_NO_MEMBLK (-1). +SRAT lookup fails then because an existing SRAT memory range cannot be +found for a CFMWS address range. This causes the addition of a +duplicate numa_memblk with a different node id and a subsequent page +fault and kernel crash during boot. + +Fix this by making numa_fill_memblks() always available regardless of +NUMA_KEEP_MEMINFO. + +As Dan suggested, the fix is implemented to remove numa_fill_memblks() +from sparsemem.h and alos using __weak for the function. + +Note that the issue was initially introduced with [1]. But since +phys_to_target_node() was originally used that returned the valid node +0, an additional numa_memblk was not added. Though, the node id was +wrong too, a message is seen then in the logs: + + kernel/numa.c: pr_info_once("Unknown target node for memory at 0x%llx, assuming node 0\n", + +[1] commit fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each + CFMWS not in SRAT") + +Suggested-by: Dan Williams +Link: https://lore.kernel.org/all/66271b0072317_69102944c@dwillia2-xfh.jf.intel.com.notmuch/ +Fixes: 8f1004679987 ("ACPI/NUMA: Apply SRAT proximity domain to entire CFMWS window") +Reviewed-by: Jonathan Cameron +Reviewed-by: Alison Schofield +Reviewed-by: Dan Williams +Signed-off-by: Robert Richter +Acked-by: Borislav Petkov (AMD) +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + arch/x86/include/asm/sparsemem.h | 2 -- + arch/x86/mm/numa.c | 4 ++-- + drivers/acpi/numa/srat.c | 5 +++++ + include/linux/numa.h | 7 +------ + 4 files changed, 8 insertions(+), 10 deletions(-) + +diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h +index 1be13b2dfe8bf..64df897c0ee30 100644 +--- a/arch/x86/include/asm/sparsemem.h ++++ b/arch/x86/include/asm/sparsemem.h +@@ -37,8 +37,6 @@ extern int phys_to_target_node(phys_addr_t start); + #define phys_to_target_node phys_to_target_node + extern int memory_add_physaddr_to_nid(u64 start); + #define memory_add_physaddr_to_nid memory_add_physaddr_to_nid +-extern int numa_fill_memblks(u64 start, u64 end); +-#define numa_fill_memblks numa_fill_memblks + #endif + #endif /* __ASSEMBLY__ */ + +diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c +index 65e9a6e391c04..ce84ba86e69e9 100644 +--- a/arch/x86/mm/numa.c ++++ b/arch/x86/mm/numa.c +@@ -929,6 +929,8 @@ int memory_add_physaddr_to_nid(u64 start) + } + EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); + ++#endif ++ + static int __init cmp_memblk(const void *a, const void *b) + { + const struct numa_memblk *ma = *(const struct numa_memblk **)a; +@@ -1001,5 +1003,3 @@ int __init numa_fill_memblks(u64 start, u64 end) + } + return 0; + } +- +-#endif +diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c +index 0214518fc582f..3ca22db3ed5db 100644 +--- a/drivers/acpi/numa/srat.c ++++ b/drivers/acpi/numa/srat.c +@@ -206,6 +206,11 @@ int __init srat_disabled(void) + return acpi_numa < 0; + } + ++__weak int __init numa_fill_memblks(u64 start, u64 end) ++{ ++ return NUMA_NO_MEMBLK; ++} ++ + #if defined(CONFIG_X86) || defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) + /* + * Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for +diff --git a/include/linux/numa.h b/include/linux/numa.h +index 915033a757315..1d43371fafd2f 100644 +--- a/include/linux/numa.h ++++ b/include/linux/numa.h +@@ -36,12 +36,7 @@ int memory_add_physaddr_to_nid(u64 start); + int phys_to_target_node(u64 start); + #endif + +-#ifndef numa_fill_memblks +-static inline int __init numa_fill_memblks(u64 start, u64 end) +-{ +- return NUMA_NO_MEMBLK; +-} +-#endif ++int numa_fill_memblks(u64 start, u64 end); + + #else /* !CONFIG_NUMA */ + static inline int numa_nearest_node(int node, unsigned int state) +-- +2.43.0 + diff --git a/queue-6.8/x86-pat-fix-w-x-violation-false-positives-when-runni.patch b/queue-6.8/x86-pat-fix-w-x-violation-false-positives-when-runni.patch new file mode 100644 index 00000000000..294ec1643a2 --- /dev/null +++ b/queue-6.8/x86-pat-fix-w-x-violation-false-positives-when-runni.patch @@ -0,0 +1,144 @@ +From 04e44e3992b373f1075a5deb1992361c3b772f61 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:12:58 +0200 +Subject: x86/pat: Fix W^X violation false-positives when running as Xen PV + guest + +From: Juergen Gross + +[ Upstream commit 5bc8b0f5dac04cd4ebe47f8090a5942f2f2647ef ] + +When running as Xen PV guest in some cases W^X violation WARN()s have +been observed. Those WARN()s are produced by verify_rwx(), which looks +into the PTE to verify that writable kernel pages have the NX bit set +in order to avoid code modifications of the kernel by rogue code. + +As the NX bits of all levels of translation entries are or-ed and the +RW bits of all levels are and-ed, looking just into the PTE isn't enough +for the decision that a writable page is executable, too. + +When running as a Xen PV guest, the direct map PMDs and kernel high +map PMDs share the same set of PTEs. Xen kernel initialization will set +the NX bit in the direct map PMD entries, and not the shared PTEs. + +Fixes: 652c5bf380ad ("x86/mm: Refuse W^X violations") +Reported-by: Jason Andryuk +Signed-off-by: Juergen Gross +Signed-off-by: Ingo Molnar +Link: https://lore.kernel.org/r/20240412151258.9171-5-jgross@suse.com +Signed-off-by: Sasha Levin +--- + arch/x86/mm/pat/set_memory.c | 26 ++++++++++++++++++-------- + 1 file changed, 18 insertions(+), 8 deletions(-) + +diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c +index 9c1dccfd1f67f..b4073fb452b6a 100644 +--- a/arch/x86/mm/pat/set_memory.c ++++ b/arch/x86/mm/pat/set_memory.c +@@ -619,7 +619,8 @@ static inline pgprot_t static_protections(pgprot_t prot, unsigned long start, + * Validate strict W^X semantics. + */ + static inline pgprot_t verify_rwx(pgprot_t old, pgprot_t new, unsigned long start, +- unsigned long pfn, unsigned long npg) ++ unsigned long pfn, unsigned long npg, ++ bool nx, bool rw) + { + unsigned long end; + +@@ -641,6 +642,10 @@ static inline pgprot_t verify_rwx(pgprot_t old, pgprot_t new, unsigned long star + if ((pgprot_val(new) & (_PAGE_RW | _PAGE_NX)) != _PAGE_RW) + return new; + ++ /* Non-leaf translation entries can disable writing or execution. */ ++ if (!rw || nx) ++ return new; ++ + end = start + npg * PAGE_SIZE - 1; + WARN_ONCE(1, "CPA detected W^X violation: %016llx -> %016llx range: 0x%016lx - 0x%016lx PFN %lx\n", + (unsigned long long)pgprot_val(old), +@@ -742,7 +747,7 @@ pte_t *lookup_address(unsigned long address, unsigned int *level) + EXPORT_SYMBOL_GPL(lookup_address); + + static pte_t *_lookup_address_cpa(struct cpa_data *cpa, unsigned long address, +- unsigned int *level) ++ unsigned int *level, bool *nx, bool *rw) + { + pgd_t *pgd; + +@@ -751,7 +756,7 @@ static pte_t *_lookup_address_cpa(struct cpa_data *cpa, unsigned long address, + else + pgd = cpa->pgd + pgd_index(address); + +- return lookup_address_in_pgd(pgd, address, level); ++ return lookup_address_in_pgd_attr(pgd, address, level, nx, rw); + } + + /* +@@ -879,12 +884,13 @@ static int __should_split_large_page(pte_t *kpte, unsigned long address, + pgprot_t old_prot, new_prot, req_prot, chk_prot; + pte_t new_pte, *tmp; + enum pg_level level; ++ bool nx, rw; + + /* + * Check for races, another CPU might have split this page + * up already: + */ +- tmp = _lookup_address_cpa(cpa, address, &level); ++ tmp = _lookup_address_cpa(cpa, address, &level, &nx, &rw); + if (tmp != kpte) + return 1; + +@@ -995,7 +1001,8 @@ static int __should_split_large_page(pte_t *kpte, unsigned long address, + new_prot = static_protections(req_prot, lpaddr, old_pfn, numpages, + psize, CPA_DETECT); + +- new_prot = verify_rwx(old_prot, new_prot, lpaddr, old_pfn, numpages); ++ new_prot = verify_rwx(old_prot, new_prot, lpaddr, old_pfn, numpages, ++ nx, rw); + + /* + * If there is a conflict, split the large page. +@@ -1076,6 +1083,7 @@ __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, + pte_t *pbase = (pte_t *)page_address(base); + unsigned int i, level; + pgprot_t ref_prot; ++ bool nx, rw; + pte_t *tmp; + + spin_lock(&pgd_lock); +@@ -1083,7 +1091,7 @@ __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, + * Check for races, another CPU might have split this page + * up for us already: + */ +- tmp = _lookup_address_cpa(cpa, address, &level); ++ tmp = _lookup_address_cpa(cpa, address, &level, &nx, &rw); + if (tmp != kpte) { + spin_unlock(&pgd_lock); + return 1; +@@ -1624,10 +1632,11 @@ static int __change_page_attr(struct cpa_data *cpa, int primary) + int do_split, err; + unsigned int level; + pte_t *kpte, old_pte; ++ bool nx, rw; + + address = __cpa_addr(cpa, cpa->curpage); + repeat: +- kpte = _lookup_address_cpa(cpa, address, &level); ++ kpte = _lookup_address_cpa(cpa, address, &level, &nx, &rw); + if (!kpte) + return __cpa_process_fault(cpa, address, primary); + +@@ -1649,7 +1658,8 @@ static int __change_page_attr(struct cpa_data *cpa, int primary) + new_prot = static_protections(new_prot, address, pfn, 1, 0, + CPA_PROTECT); + +- new_prot = verify_rwx(old_prot, new_prot, address, pfn, 1); ++ new_prot = verify_rwx(old_prot, new_prot, address, pfn, 1, ++ nx, rw); + + new_prot = pgprot_clear_protnone_bits(new_prot); + +-- +2.43.0 + diff --git a/queue-6.8/x86-pat-introduce-lookup_address_in_pgd_attr.patch b/queue-6.8/x86-pat-introduce-lookup_address_in_pgd_attr.patch new file mode 100644 index 00000000000..9d4cb6bb946 --- /dev/null +++ b/queue-6.8/x86-pat-introduce-lookup_address_in_pgd_attr.patch @@ -0,0 +1,127 @@ +From 44d8e077960ded4044ea9acac6dcdb37999ec791 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:12:55 +0200 +Subject: x86/pat: Introduce lookup_address_in_pgd_attr() + +From: Juergen Gross + +[ Upstream commit ceb647b4b529fdeca9021cd34486f5a170746bda ] + +Add lookup_address_in_pgd_attr() doing the same as the already +existing lookup_address_in_pgd(), but returning the effective settings +of the NX and RW bits of all walked page table levels, too. + +This will be needed in order to match hardware behavior when looking +for effective access rights, especially for detecting writable code +pages. + +In order to avoid code duplication, let lookup_address_in_pgd() call +lookup_address_in_pgd_attr() with dummy parameters. + +Signed-off-by: Juergen Gross +Signed-off-by: Ingo Molnar +Link: https://lore.kernel.org/r/20240412151258.9171-2-jgross@suse.com +Stable-dep-of: 5bc8b0f5dac0 ("x86/pat: Fix W^X violation false-positives when running as Xen PV guest") +Signed-off-by: Sasha Levin +--- + arch/x86/include/asm/pgtable_types.h | 2 ++ + arch/x86/mm/pat/set_memory.c | 33 +++++++++++++++++++++++++--- + 2 files changed, 32 insertions(+), 3 deletions(-) + +diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h +index 9abb8cc4cd474..b786449626267 100644 +--- a/arch/x86/include/asm/pgtable_types.h ++++ b/arch/x86/include/asm/pgtable_types.h +@@ -567,6 +567,8 @@ static inline void update_page_count(int level, unsigned long pages) { } + extern pte_t *lookup_address(unsigned long address, unsigned int *level); + extern pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, + unsigned int *level); ++pte_t *lookup_address_in_pgd_attr(pgd_t *pgd, unsigned long address, ++ unsigned int *level, bool *nx, bool *rw); + extern pmd_t *lookup_pmd_address(unsigned long address); + extern phys_addr_t slow_virt_to_phys(void *__address); + extern int __init kernel_map_pages_in_pgd(pgd_t *pgd, u64 pfn, +diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c +index 135bb594df8b7..cd09ddd34eff8 100644 +--- a/arch/x86/mm/pat/set_memory.c ++++ b/arch/x86/mm/pat/set_memory.c +@@ -657,20 +657,26 @@ static inline pgprot_t verify_rwx(pgprot_t old, pgprot_t new, unsigned long star + + /* + * Lookup the page table entry for a virtual address in a specific pgd. +- * Return a pointer to the entry and the level of the mapping. ++ * Return a pointer to the entry, the level of the mapping, and the effective ++ * NX and RW bits of all page table levels. + */ +-pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, +- unsigned int *level) ++pte_t *lookup_address_in_pgd_attr(pgd_t *pgd, unsigned long address, ++ unsigned int *level, bool *nx, bool *rw) + { + p4d_t *p4d; + pud_t *pud; + pmd_t *pmd; + + *level = PG_LEVEL_NONE; ++ *nx = false; ++ *rw = true; + + if (pgd_none(*pgd)) + return NULL; + ++ *nx |= pgd_flags(*pgd) & _PAGE_NX; ++ *rw &= pgd_flags(*pgd) & _PAGE_RW; ++ + p4d = p4d_offset(pgd, address); + if (p4d_none(*p4d)) + return NULL; +@@ -679,6 +685,9 @@ pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, + if (p4d_large(*p4d) || !p4d_present(*p4d)) + return (pte_t *)p4d; + ++ *nx |= p4d_flags(*p4d) & _PAGE_NX; ++ *rw &= p4d_flags(*p4d) & _PAGE_RW; ++ + pud = pud_offset(p4d, address); + if (pud_none(*pud)) + return NULL; +@@ -687,6 +696,9 @@ pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, + if (pud_leaf(*pud) || !pud_present(*pud)) + return (pte_t *)pud; + ++ *nx |= pud_flags(*pud) & _PAGE_NX; ++ *rw &= pud_flags(*pud) & _PAGE_RW; ++ + pmd = pmd_offset(pud, address); + if (pmd_none(*pmd)) + return NULL; +@@ -695,11 +707,26 @@ pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, + if (pmd_large(*pmd) || !pmd_present(*pmd)) + return (pte_t *)pmd; + ++ *nx |= pmd_flags(*pmd) & _PAGE_NX; ++ *rw &= pmd_flags(*pmd) & _PAGE_RW; ++ + *level = PG_LEVEL_4K; + + return pte_offset_kernel(pmd, address); + } + ++/* ++ * Lookup the page table entry for a virtual address in a specific pgd. ++ * Return a pointer to the entry and the level of the mapping. ++ */ ++pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, ++ unsigned int *level) ++{ ++ bool nx, rw; ++ ++ return lookup_address_in_pgd_attr(pgd, address, level, &nx, &rw); ++} ++ + /* + * Lookup the page table entry for a virtual address. Return a pointer + * to the entry and the level of the mapping. +-- +2.43.0 + diff --git a/queue-6.8/x86-pat-restructure-_lookup_address_cpa.patch b/queue-6.8/x86-pat-restructure-_lookup_address_cpa.patch new file mode 100644 index 00000000000..57a126093bb --- /dev/null +++ b/queue-6.8/x86-pat-restructure-_lookup_address_cpa.patch @@ -0,0 +1,51 @@ +From 978dee91965e74c5326953c2d9e23b10644bbdc5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 12 Apr 2024 17:12:57 +0200 +Subject: x86/pat: Restructure _lookup_address_cpa() + +From: Juergen Gross + +[ Upstream commit 02eac06b820c3eae73e5736ae62f986d37fed991 ] + +Modify _lookup_address_cpa() to no longer use lookup_address(), but +only lookup_address_in_pgd(). + +This is done in preparation of using lookup_address_in_pgd_attr(). + +No functional change intended. + +Signed-off-by: Juergen Gross +Signed-off-by: Ingo Molnar +Link: https://lore.kernel.org/r/20240412151258.9171-4-jgross@suse.com +Stable-dep-of: 5bc8b0f5dac0 ("x86/pat: Fix W^X violation false-positives when running as Xen PV guest") +Signed-off-by: Sasha Levin +--- + arch/x86/mm/pat/set_memory.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c +index cd09ddd34eff8..9c1dccfd1f67f 100644 +--- a/arch/x86/mm/pat/set_memory.c ++++ b/arch/x86/mm/pat/set_memory.c +@@ -744,11 +744,14 @@ EXPORT_SYMBOL_GPL(lookup_address); + static pte_t *_lookup_address_cpa(struct cpa_data *cpa, unsigned long address, + unsigned int *level) + { +- if (cpa->pgd) +- return lookup_address_in_pgd(cpa->pgd + pgd_index(address), +- address, level); ++ pgd_t *pgd; ++ ++ if (!cpa->pgd) ++ pgd = pgd_offset_k(address); ++ else ++ pgd = cpa->pgd + pgd_index(address); + +- return lookup_address(address, level); ++ return lookup_address_in_pgd(pgd, address, level); + } + + /* +-- +2.43.0 + diff --git a/queue-6.8/x86-purgatory-switch-to-the-position-independent-sma.patch b/queue-6.8/x86-purgatory-switch-to-the-position-independent-sma.patch new file mode 100644 index 00000000000..f5c1b86016b --- /dev/null +++ b/queue-6.8/x86-purgatory-switch-to-the-position-independent-sma.patch @@ -0,0 +1,81 @@ +From a4ee2d74984ccf41ed98236d4a508f903d1f4563 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 18 Apr 2024 22:17:06 +0200 +Subject: x86/purgatory: Switch to the position-independent small code model + +From: Ard Biesheuvel + +[ Upstream commit cba786af84a0f9716204e09f518ce3b7ada8555e ] + +On x86, the ordinary, position dependent small and kernel code models +only support placement of the executable in 32-bit addressable memory, +due to the use of 32-bit signed immediates to generate references to +global variables. For the kernel, this implies that all global variables +must reside in the top 2 GiB of the kernel virtual address space, where +the implicit address bits 63:32 are equal to sign bit 31. + +This means the kernel code model is not suitable for other bare metal +executables such as the kexec purgatory, which can be placed arbitrarily +in the physical address space, where its address may no longer be +representable as a sign extended 32-bit quantity. For this reason, +commit + + e16c2983fba0 ("x86/purgatory: Change compiler flags from -mcmodel=kernel to -mcmodel=large to fix kexec relocation errors") + +switched to the large code model, which uses 64-bit immediates for all +symbol references, including function calls, in order to avoid relying +on any assumptions regarding proximity of symbols in the final +executable. + +The large code model is rarely used, clunky and the least likely to +operate in a similar fashion when comparing GCC and Clang, so it is best +avoided. This is especially true now that Clang 18 has started to emit +executable code in two separate sections (.text and .ltext), which +triggers an issue in the kexec loading code at runtime. + +The SUSE bugzilla fixes tag points to gcc 13 having issues with the +large model too and that perhaps the large model should simply not be +used at all. + +Instead, use the position independent small code model, which makes no +assumptions about placement but only about proximity, where all +referenced symbols must be within -/+ 2 GiB, i.e., in range for a +RIP-relative reference. Use hidden visibility to suppress the use of a +GOT, which carries absolute addresses that are not covered by static ELF +relocations, and is therefore incompatible with the kexec loader's +relocation logic. + + [ bp: Massage commit message. ] + +Fixes: e16c2983fba0 ("x86/purgatory: Change compiler flags from -mcmodel=kernel to -mcmodel=large to fix kexec relocation errors") +Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1211853 +Closes: https://github.com/ClangBuiltLinux/linux/issues/2016 +Signed-off-by: Ard Biesheuvel +Signed-off-by: Borislav Petkov (AMD) +Reviewed-by: Nathan Chancellor +Reviewed-by: Fangrui Song +Acked-by: Nick Desaulniers +Tested-by: Nathan Chancellor +Link: https://lore.kernel.org/all/20240417-x86-fix-kexec-with-llvm-18-v1-0-5383121e8fb7@kernel.org/ +Signed-off-by: Sasha Levin +--- + arch/x86/purgatory/Makefile | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile +index 08aa0f25f12a0..8d1c82795ea1d 100644 +--- a/arch/x86/purgatory/Makefile ++++ b/arch/x86/purgatory/Makefile +@@ -42,7 +42,8 @@ KCOV_INSTRUMENT := n + # make up the standalone purgatory.ro + + PURGATORY_CFLAGS_REMOVE := -mcmodel=kernel +-PURGATORY_CFLAGS := -mcmodel=large -ffreestanding -fno-zero-initialized-in-bss -g0 ++PURGATORY_CFLAGS := -mcmodel=small -ffreestanding -fno-zero-initialized-in-bss -g0 ++PURGATORY_CFLAGS += -fpic -fvisibility=hidden + PURGATORY_CFLAGS += $(DISABLE_STACKLEAK_PLUGIN) -DDISABLE_BRANCH_PROFILING + PURGATORY_CFLAGS += -fno-stack-protector + +-- +2.43.0 + -- 2.47.3