From 28dea83521f3013e67f8296806f0790a20b2948d Mon Sep 17 00:00:00 2001 From: Arran Cudbard-Bell Date: Sun, 4 Oct 2015 18:41:38 -0400 Subject: [PATCH] Fix off by one error in rlm_mschap that sometimes meant correctly formatted MS-CHAP-Error messages were not returned (sometimes is that the behaviour depended on an uninitialised byte) --- src/modules/rlm_mschap/rlm_mschap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/rlm_mschap/rlm_mschap.c b/src/modules/rlm_mschap/rlm_mschap.c index 9c2d34c29d..d6fe3d63c4 100644 --- a/src/modules/rlm_mschap/rlm_mschap.c +++ b/src/modules/rlm_mschap/rlm_mschap.c @@ -1870,7 +1870,8 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authenticate(void * instance, REQUEST *r sizeof(buffer) - 12 - (i * 2), "%02x", fr_rand() & 0xff); } - snprintf(buffer + 45, sizeof(buffer) - 45, " V=3 M=%s", inst->retry_msg); + /* E=691 R=d (9) + " C=" (3) + 32 hexits = 44 */ + snprintf(buffer + 44, sizeof(buffer) - 44, " V=3 M=%s", inst->retry_msg); } mschap_add_reply(request, *response->vp_octets, "MS-CHAP-Error", buffer, strlen(buffer)); return RLM_MODULE_REJECT; -- 2.47.3