From 2bbb9c2f7f36d0457cda5f27d7e4422219b3acd8 Mon Sep 17 00:00:00 2001 From: Isaku Yamahata Date: Thu, 9 Sep 2010 11:48:56 +0900 Subject: [PATCH] pci: don't ignore invalid parameter for pci_register_bar(). Abort when invalid value for region_num is passed to pci_register_bar. That is caller's bug. Abort instead of silently ignoring invalid value. Signed-off-by: Isaku Yamahata Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index c28b8a18355..8f48d9b080f 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -765,9 +765,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, uint32_t addr; uint64_t wmask; - if ((unsigned int)region_num >= PCI_NUM_REGIONS) - return; - + assert(region_num >= 0); + assert(region_num < PCI_NUM_REGIONS); if (size & (size-1)) { fprintf(stderr, "ERROR: PCI region size must be pow2 " "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size); -- 2.39.5