From 2c3ae11cee52dbf2bcb83528d06add7410b7494d Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Sat, 25 Apr 2020 15:46:41 +0100 Subject: [PATCH] Remove CloseHandle() from __archive_write_program_free The call to CloseHandle() is asymmetric and wrong. The handle is created during the __achive_create_child() call in __archive_write_program_open() aka the filter open callback. While CloseHandle() is already called in the filter close callback aka __archive_write_program_close(). Remove the incorrect call to CloseHandle() from the bidder free callback Signed-off-by: Emil Velikov --- libarchive/archive_write_add_filter_program.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libarchive/archive_write_add_filter_program.c b/libarchive/archive_write_add_filter_program.c index 3dac86dc3..c096e7227 100644 --- a/libarchive/archive_write_add_filter_program.c +++ b/libarchive/archive_write_add_filter_program.c @@ -196,10 +196,6 @@ __archive_write_program_free(struct archive_write_program_data *data) { if (data) { -#if defined(_WIN32) && !defined(__CYGWIN__) - if (data->child) - CloseHandle(data->child); -#endif free(data->program_name); free(data->child_buf); free(data); -- 2.47.2