From 2c42b6ce4a3ba5b781b0138517c89fb2a736ed8f Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Fri, 14 Nov 2025 23:45:26 +0100 Subject: [PATCH] ovl: remove struct ovl_cu_creds and associated functions Now that we have this all ported to a cred guard remove the struct and the associated helpers. Link: https://patch.msgid.link/20251114-work-ovl-cred-guard-copyup-v1-5-ea3fb15cf427@kernel.org Reviewed-by: Amir Goldstein Signed-off-by: Christian Brauner --- fs/overlayfs/copy_up.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 71e222e5044d2..758611ee4475f 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -724,34 +724,6 @@ static int ovl_copy_up_metadata(struct ovl_copy_up_ctx *c, struct dentry *temp) return err; } -struct ovl_cu_creds { - const struct cred *old; - struct cred *new; -}; - -static int __maybe_unused ovl_prep_cu_creds(struct dentry *dentry, struct ovl_cu_creds *cc) -{ - int err; - - cc->old = cc->new = NULL; - err = security_inode_copy_up(dentry, &cc->new); - if (err < 0) - return err; - - if (cc->new) - cc->old = override_creds(cc->new); - - return 0; -} - -static void __maybe_unused ovl_revert_cu_creds(struct ovl_cu_creds *cc) -{ - if (cc->new) { - revert_creds(cc->old); - put_cred(cc->new); - } -} - static const struct cred *ovl_prepare_copy_up_creds(struct dentry *dentry) { struct cred *copy_up_cred = NULL; -- 2.47.3