From 2c59352638eabdf172af65cbc8dea19bdbeeb815 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 7 Apr 2017 16:56:49 +0200 Subject: [PATCH] qemu: snapshot: Skip empty drives with internal snapshots The code that validates whether an internal snapshot is possible would reject an empty but not-readonly drive. Since floppies can have this property, add a check for emptiness. (cherry picked from commit eee3b4b9493a0b4e5e5fb473893a55320b4f83b1) --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6b91750acf..0a95ad76f6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13831,7 +13831,8 @@ qemuDomainSnapshotPrepare(virConnectPtr conn, case VIR_DOMAIN_SNAPSHOT_LOCATION_NONE: /* Remember seeing a disk that has snapshot disabled */ - if (!dom_disk->src->readonly) + if (!virStorageSourceIsEmpty(dom_disk->src) && + !dom_disk->src->readonly) forbid_internal = true; break; -- 2.47.3