From 2cd243171baddb68fe78dd9642824ed98362f556 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Sat, 22 Jun 2019 08:43:56 +0200 Subject: [PATCH] 4.9-stable patches added patches: tcp-refine-memory-limit-test-in-tcp_fragment.patch --- ...ne-memory-limit-test-in-tcp_fragment.patch | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 queue-4.9/tcp-refine-memory-limit-test-in-tcp_fragment.patch diff --git a/queue-4.9/tcp-refine-memory-limit-test-in-tcp_fragment.patch b/queue-4.9/tcp-refine-memory-limit-test-in-tcp_fragment.patch new file mode 100644 index 00000000000..dc70048226f --- /dev/null +++ b/queue-4.9/tcp-refine-memory-limit-test-in-tcp_fragment.patch @@ -0,0 +1,40 @@ +From b6653b3629e5b88202be3c9abc44713973f5c4b4 Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Fri, 21 Jun 2019 06:09:55 -0700 +Subject: tcp: refine memory limit test in tcp_fragment() + +From: Eric Dumazet + +commit b6653b3629e5b88202be3c9abc44713973f5c4b4 upstream. + +tcp_fragment() might be called for skbs in the write queue. + +Memory limits might have been exceeded because tcp_sendmsg() only +checks limits at full skb (64KB) boundaries. + +Therefore, we need to make sure tcp_fragment() wont punish applications +that might have setup very low SO_SNDBUF values. + +Fixes: f070ef2ac667 ("tcp: tcp_fragment() should apply sane memory limits") +Signed-off-by: Eric Dumazet +Reported-by: Christoph Paasch +Tested-by: Christoph Paasch +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman + +--- + net/ipv4/tcp_output.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/net/ipv4/tcp_output.c ++++ b/net/ipv4/tcp_output.c +@@ -1185,7 +1185,8 @@ int tcp_fragment(struct sock *sk, struct + if (nsize < 0) + nsize = 0; + +- if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf)) { ++ if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf && ++ tcp_queue != TCP_FRAG_IN_WRITE_QUEUE)) { + NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPWQUEUETOOBIG); + return -ENOMEM; + } -- 2.47.2