From 2e356b25758af3de93414f3b42630f07f1592c8f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Wolfgang=20St=C3=B6ggl?= Date: Mon, 8 Jul 2019 14:06:28 +0200 Subject: [PATCH] Fix identical inner if condition rrd_graph_helper - Fixes the following Cppcheck warning: [src/rrd_graph_helper.c:972] (warning) Identical inner 'if' condition is always true (outer condition is '!vname' and inner condition is '!vname'). [identicalInnerCondition] --- src/rrd_graph_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/rrd_graph_helper.c b/src/rrd_graph_helper.c index b1d03e4f..dde3e0ac 100644 --- a/src/rrd_graph_helper.c +++ b/src/rrd_graph_helper.c @@ -969,9 +969,7 @@ static graph_desc_t *newGraphDescription( } dprintfparsed("got positional vname and rrd: %s - %s\n", first->key, first->value); - if (!vname) { - vname = first->value; - } + vname = first->value; } } -- 2.47.2