From 2e40aad231fbb8944bc2557fd9dce0d4e8d2523e Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Mon, 10 Jul 2017 13:42:35 +0200 Subject: [PATCH] commit: Add NULL check for overlay_bs I can't see how overlay_bs could become NULL with the current code, but other code in this function already checks it and we can make Coverity happy with this check, so let's add it. Cc: qemu-stable@nongnu.org Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi (cherry picked from commit b1e1fa0c3afc7f671fbc24645bdf67949a5657e5) Signed-off-by: Michael Roth --- block/commit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/commit.c b/block/commit.c index fba25e27a89..66e3418e74d 100644 --- a/block/commit.c +++ b/block/commit.c @@ -91,7 +91,9 @@ static void commit_complete(BlockJob *job, void *opaque) /* Make sure overlay_bs and top stay around until bdrv_set_backing_hd() */ bdrv_ref(top); - bdrv_ref(overlay_bs); + if (overlay_bs) { + bdrv_ref(overlay_bs); + } /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before * the normal backing chain can be restored. */ -- 2.39.5