From 30d62da45786b589eb009fa8b5bd8c5e02c69a4e Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Sun, 16 Feb 2025 13:30:15 +0000 Subject: [PATCH] ELF: Don't fail if we could not parse some DWARF information This is in line with what has been recommended from upstream. Signed-off-by: Michael Tremer --- src/pakfire/elf.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/pakfire/elf.c b/src/pakfire/elf.c index 1a1b7579..6c97b18c 100644 --- a/src/pakfire/elf.c +++ b/src/pakfire/elf.c @@ -1132,10 +1132,6 @@ int pakfire_elf_requires(struct pakfire_elf* self, char*** requires) { #define DWARF_E_NO_DWARF 6 #endif -#ifndef DWARF_E_INVALID_DWARF -#define DWARF_E_INVALID_DWARF 16 -#endif - int pakfire_elf_foreach_source_file(struct pakfire_elf* self, pakfire_elf_foreach_source_file_callback callback, void* data) { const char* filename = NULL; @@ -1180,19 +1176,8 @@ int pakfire_elf_foreach_source_file(struct pakfire_elf* self, // Fetch the source files r = dwarf_getsrcfiles(die, &files, &count); - if (r < 0) { - switch (dwarf_errno()) { - // Skip any invalid DWARF sections - case DWARF_E_INVALID_DWARF: - goto NEXT; - - default: - ERROR(self->ctx, "Could not fetch the source files for %s: %s\n", - self->path, dwarf_errmsg(-1)); - r = -ENOTSUP; - goto ERROR; - } - } + if (r < 0) + goto NEXT; // Iterate over all files... for (unsigned int i = 0; i < count; i++) { -- 2.39.5