From 32bfbc788d2fd161569f2ac3c192667a3cd196a9 Mon Sep 17 00:00:00 2001 From: Jennifer Sutton Date: Tue, 12 Aug 2025 12:26:52 +1200 Subject: [PATCH] =?utf8?q?python:samba:=20Raise=20an=20exception=20if=20we?= =?utf8?q?=20can=E2=80=99t=20parse=20a=20Markdown=20operation?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Otherwise we would continue with the wrong GUID and filename. Signed-off-by: Jennifer Sutton Reviewed-by: Douglas Bagnall --- python/samba/ms_forest_updates_markdown.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/python/samba/ms_forest_updates_markdown.py b/python/samba/ms_forest_updates_markdown.py index 0a0d2111a72..12a2041459a 100644 --- a/python/samba/ms_forest_updates_markdown.py +++ b/python/samba/ms_forest_updates_markdown.py @@ -253,10 +253,11 @@ def read_ms_markdown(in_file, out_folder=None, out_dict=None): if updates: for update in updates[2:]: output = re.match(r'Operation (\d+): {(.*)}', update[0]) - if output: - # print output.group(1), output.group(2) - guid = output.group(2) - filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid) + if not output: + raise Exception(update) + + guid = output.group(2) + filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid) found = False -- 2.47.3