From 330001202ada53dcf3de81f95edc2616f8d75c68 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=89rico=20Nogueira?= Date: Mon, 3 May 2021 22:51:50 -0300 Subject: [PATCH] misc: use _fitoa_word to implement __fd_to_filename. In a default build for x86_64, size decreased by 24 bytes: 1883294 to 1883270. Aditionally, avoids repeating the number printing logic in multiple places. Reviewed-by: Adhemerval Zanella --- misc/fd_to_filename.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/misc/fd_to_filename.c b/misc/fd_to_filename.c index 86a1a1acc29..20c20149037 100644 --- a/misc/fd_to_filename.c +++ b/misc/fd_to_filename.c @@ -20,6 +20,7 @@ #include #include +#include <_itoa.h> char * __fd_to_filename (int descriptor, struct fd_to_filename *storage) @@ -28,11 +29,7 @@ __fd_to_filename (int descriptor, struct fd_to_filename *storage) char *p = mempcpy (storage->buffer, FD_TO_FILENAME_PREFIX, strlen (FD_TO_FILENAME_PREFIX)); + *_fitoa_word (descriptor, p, 10, 0) = '\0'; - for (int d = descriptor; p++, (d /= 10) != 0; ) - continue; - *p = '\0'; - for (int d = descriptor; *--p = '0' + d % 10, (d /= 10) != 0; ) - continue; return storage->buffer; } -- 2.47.2