From 34ed8f25c4a753333d680c537818a5ad2bf67ca7 Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Wed, 23 Oct 2024 12:08:26 +0000 Subject: [PATCH] parser: Don't duplicate and leak arch Signed-off-by: Michael Tremer --- src/libpakfire/parser.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/libpakfire/parser.c b/src/libpakfire/parser.c index 54852dc84..2f1589429 100644 --- a/src/libpakfire/parser.c +++ b/src/libpakfire/parser.c @@ -1030,19 +1030,15 @@ int pakfire_parser_create_package(struct pakfire_parser* parser, // Fetch arch arch = pakfire_parser_get(parser, namespace, "arch"); if (!arch || !*arch) { - if (default_arch) { - arch = strdup(default_arch); - if (!arch) - goto CLEANUP; - } else { + if (!default_arch) { ERROR(parser->ctx, "Arch is empty\n"); goto CLEANUP; } } // Create a new package object - r = pakfire_package_create(pkg, parser->pakfire, repo, name, evr, arch); - if (r) { + r = pakfire_package_create(pkg, parser->pakfire, repo, name, evr, (arch) ? arch : default_arch); + if (r < 0) { ERROR(parser->ctx, "Could not create package: %m\n"); goto CLEANUP; } -- 2.39.5