From 36119c51369714b6a92eb89b3cb6f51b8f575641 Mon Sep 17 00:00:00 2001 From: Andrey Albershteyn Date: Wed, 26 Feb 2025 15:50:31 +0100 Subject: [PATCH] git-contributors: make revspec required and shebang fix Without default value script will show help instead of just hanging waiting for input on stdin. Shebang fix for system with different python location than the /usr/bin one. Cut leading delimiter from the final CC string. Reviewed-by: Darrick J. Wong Signed-off-by: Andrey Albershteyn --- tools/git-contributors.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/git-contributors.py b/tools/git-contributors.py index 1a0f2b80..01177a9a 100755 --- a/tools/git-contributors.py +++ b/tools/git-contributors.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 # List all contributors to a series of git commits. # Copyright(C) 2025 Oracle, All Rights Reserved. @@ -144,8 +144,7 @@ def main(): global DEBUG parser = argparse.ArgumentParser(description = "List email addresses of contributors to a series of git commits.") - parser.add_argument("revspec", nargs = '?', default = None, \ - help = "git revisions to process.") + parser.add_argument("revspec", help = "git revisions to process.") parser.add_argument("--separator", type = str, default = '\n', \ help = "Separate each email address with this string.") parser.add_argument('--debug', action = 'store_true', default = False, \ @@ -160,9 +159,6 @@ def main(): # read git commits from repo contributors = fd.run(backtick(['git', 'log', '--pretty=medium', args.revspec])) - else: - # read patch from stdin - contributors = fd.run(sys.stdin.readlines()) print(args.separator.join(sorted(contributors))) return 0 -- 2.47.3