From 36951036a725271826773e7feb852496b16dc38d Mon Sep 17 00:00:00 2001 From: Peng Fan Date: Wed, 19 Nov 2025 12:21:47 +0800 Subject: [PATCH] remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan Link: https://lore.kernel.org/r/20251119-imx-dsp-2025-11-19-v4-2-adafd342d07b@nxp.com Signed-off-by: Mathieu Poirier --- drivers/remoteproc/imx_dsp_rproc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index 1f7d15227ce4..418bd3ac70a4 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev) init_completion(&priv->pm_comp); rproc->auto_boot = false; - ret = rproc_add(rproc); + ret = devm_rproc_add(dev, rproc); if (ret) return dev_err_probe(dev, ret, "rproc_add failed\n"); @@ -1207,10 +1207,7 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev) static void imx_dsp_rproc_remove(struct platform_device *pdev) { - struct rproc *rproc = platform_get_drvdata(pdev); - pm_runtime_disable(&pdev->dev); - rproc_del(rproc); } /* pm runtime functions */ -- 2.47.3