From 37786fc4e27dad1e519cb82e5ff2493e1d3a0221 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Thu, 7 Oct 2021 10:20:27 -0400 Subject: [PATCH] Fixes for 4.4 Signed-off-by: Sasha Levin --- ...fix-sleeping-in-atomic-bugs-on-error.patch | 62 +++++++++++++ ...free-scsi_disk-device-via-put_device.patch | 50 +++++++++++ queue-4.4/series | 5 ++ ...i_iounmap-when-config_pci-is-not-set.patch | 48 ++++++++++ ...fix-for-showing-the-connection-speed.patch | 88 +++++++++++++++++++ ...ect-success-error-reporting-for-the-.patch | 40 +++++++++ 6 files changed, 293 insertions(+) create mode 100644 queue-4.4/ext2-fix-sleeping-in-atomic-bugs-on-error.patch create mode 100644 queue-4.4/scsi-sd-free-scsi_disk-device-via-put_device.patch create mode 100644 queue-4.4/series create mode 100644 queue-4.4/sparc64-fix-pci_iounmap-when-config_pci-is-not-set.patch create mode 100644 queue-4.4/usb-testusb-fix-for-showing-the-connection-speed.patch create mode 100644 queue-4.4/xen-netback-correct-success-error-reporting-for-the-.patch diff --git a/queue-4.4/ext2-fix-sleeping-in-atomic-bugs-on-error.patch b/queue-4.4/ext2-fix-sleeping-in-atomic-bugs-on-error.patch new file mode 100644 index 00000000000..57af1ca9859 --- /dev/null +++ b/queue-4.4/ext2-fix-sleeping-in-atomic-bugs-on-error.patch @@ -0,0 +1,62 @@ +From de38224df86247a33abf16b36846a7f4903d235b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 21 Sep 2021 23:32:33 +0300 +Subject: ext2: fix sleeping in atomic bugs on error + +From: Dan Carpenter + +[ Upstream commit 372d1f3e1bfede719864d0d1fbf3146b1e638c88 ] + +The ext2_error() function syncs the filesystem so it sleeps. The caller +is holding a spinlock so it's not allowed to sleep. + + ext2_statfs() <- disables preempt + -> ext2_count_free_blocks() + -> ext2_get_group_desc() + +Fix this by using WARN() to print an error message and a stack trace +instead of using ext2_error(). + +Link: https://lore.kernel.org/r/20210921203233.GA16529@kili +Signed-off-by: Dan Carpenter +Signed-off-by: Jan Kara +Signed-off-by: Sasha Levin +--- + fs/ext2/balloc.c | 14 ++++++-------- + 1 file changed, 6 insertions(+), 8 deletions(-) + +diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c +index 9f9992b37924..2e4747e0aaf0 100644 +--- a/fs/ext2/balloc.c ++++ b/fs/ext2/balloc.c +@@ -46,10 +46,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, + struct ext2_sb_info *sbi = EXT2_SB(sb); + + if (block_group >= sbi->s_groups_count) { +- ext2_error (sb, "ext2_get_group_desc", +- "block_group >= groups_count - " +- "block_group = %d, groups_count = %lu", +- block_group, sbi->s_groups_count); ++ WARN(1, "block_group >= groups_count - " ++ "block_group = %d, groups_count = %lu", ++ block_group, sbi->s_groups_count); + + return NULL; + } +@@ -57,10 +56,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, + group_desc = block_group >> EXT2_DESC_PER_BLOCK_BITS(sb); + offset = block_group & (EXT2_DESC_PER_BLOCK(sb) - 1); + if (!sbi->s_group_desc[group_desc]) { +- ext2_error (sb, "ext2_get_group_desc", +- "Group descriptor not loaded - " +- "block_group = %d, group_desc = %lu, desc = %lu", +- block_group, group_desc, offset); ++ WARN(1, "Group descriptor not loaded - " ++ "block_group = %d, group_desc = %lu, desc = %lu", ++ block_group, group_desc, offset); + return NULL; + } + +-- +2.33.0 + diff --git a/queue-4.4/scsi-sd-free-scsi_disk-device-via-put_device.patch b/queue-4.4/scsi-sd-free-scsi_disk-device-via-put_device.patch new file mode 100644 index 00000000000..7b429ddd01b --- /dev/null +++ b/queue-4.4/scsi-sd-free-scsi_disk-device-via-put_device.patch @@ -0,0 +1,50 @@ +From 004b02c664b6cd54c7ca385dc0701f010e94334a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 6 Sep 2021 17:01:12 +0800 +Subject: scsi: sd: Free scsi_disk device via put_device() + +From: Ming Lei + +[ Upstream commit 265dfe8ebbabae7959060bd1c3f75c2473b697ed ] + +After a device is initialized via device_initialize() it should be freed +via put_device(). sd_probe() currently gets this wrong, fix it up. + +Link: https://lore.kernel.org/r/20210906090112.531442-1-ming.lei@redhat.com +Reviewed-by: Bart Van Assche +Reviewed-by: Christoph Hellwig +Signed-off-by: Ming Lei +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/sd.c | 9 +++++---- + 1 file changed, 5 insertions(+), 4 deletions(-) + +diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c +index 9176fb1b1615..935add4d6f83 100644 +--- a/drivers/scsi/sd.c ++++ b/drivers/scsi/sd.c +@@ -3146,15 +3146,16 @@ static int sd_probe(struct device *dev) + } + + device_initialize(&sdkp->dev); +- sdkp->dev.parent = dev; ++ sdkp->dev.parent = get_device(dev); + sdkp->dev.class = &sd_disk_class; + dev_set_name(&sdkp->dev, "%s", dev_name(dev)); + + error = device_add(&sdkp->dev); +- if (error) +- goto out_free_index; ++ if (error) { ++ put_device(&sdkp->dev); ++ goto out; ++ } + +- get_device(dev); + dev_set_drvdata(dev, sdkp); + + get_device(&sdkp->dev); /* prevent release before async_schedule */ +-- +2.33.0 + diff --git a/queue-4.4/series b/queue-4.4/series new file mode 100644 index 00000000000..4e8f1907e92 --- /dev/null +++ b/queue-4.4/series @@ -0,0 +1,5 @@ +xen-netback-correct-success-error-reporting-for-the-.patch +sparc64-fix-pci_iounmap-when-config_pci-is-not-set.patch +ext2-fix-sleeping-in-atomic-bugs-on-error.patch +scsi-sd-free-scsi_disk-device-via-put_device.patch +usb-testusb-fix-for-showing-the-connection-speed.patch diff --git a/queue-4.4/sparc64-fix-pci_iounmap-when-config_pci-is-not-set.patch b/queue-4.4/sparc64-fix-pci_iounmap-when-config_pci-is-not-set.patch new file mode 100644 index 00000000000..745d35eb910 --- /dev/null +++ b/queue-4.4/sparc64-fix-pci_iounmap-when-config_pci-is-not-set.patch @@ -0,0 +1,48 @@ +From df702c0de3e93f0f75982d23cd6576a5deaa6de5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 20 Sep 2021 10:56:32 -0700 +Subject: sparc64: fix pci_iounmap() when CONFIG_PCI is not set + +From: Linus Torvalds + +[ Upstream commit d8b1e10a2b8efaf71d151aa756052fbf2f3b6d57 ] + +Guenter reported [1] that the pci_iounmap() changes remain problematic, +with sparc64 allnoconfig and tinyconfig still not building due to the +header file changes and confusion with the arch-specific pci_iounmap() +implementation. + +I'm pretty convinced that sparc should just use GENERIC_IOMAP instead of +doing its own thing, since it turns out that the sparc64 version of +pci_iounmap() is somewhat buggy (see [2]). But in the meantime, this +just fixes the build by avoiding the trivial re-definition of the empty +case. + +Link: https://lore.kernel.org/lkml/20210920134424.GA346531@roeck-us.net/ [1] +Link: https://lore.kernel.org/lkml/CAHk-=wgheheFx9myQyy5osh79BAazvmvYURAtub2gQtMvLrhqQ@mail.gmail.com/ [2] +Reported-by: Guenter Roeck +Cc: David Miller +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + arch/sparc/lib/iomap.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/arch/sparc/lib/iomap.c b/arch/sparc/lib/iomap.c +index c4d42a50ebc0..fa4abbaf27de 100644 +--- a/arch/sparc/lib/iomap.c ++++ b/arch/sparc/lib/iomap.c +@@ -18,8 +18,10 @@ void ioport_unmap(void __iomem *addr) + EXPORT_SYMBOL(ioport_map); + EXPORT_SYMBOL(ioport_unmap); + ++#ifdef CONFIG_PCI + void pci_iounmap(struct pci_dev *dev, void __iomem * addr) + { + /* nothing to do */ + } + EXPORT_SYMBOL(pci_iounmap); ++#endif +-- +2.33.0 + diff --git a/queue-4.4/usb-testusb-fix-for-showing-the-connection-speed.patch b/queue-4.4/usb-testusb-fix-for-showing-the-connection-speed.patch new file mode 100644 index 00000000000..b1f49f4b378 --- /dev/null +++ b/queue-4.4/usb-testusb-fix-for-showing-the-connection-speed.patch @@ -0,0 +1,88 @@ +From 5bec7511f615b9a7560f8e8caaf4f8b01b80c255 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 2 Sep 2021 17:14:44 +0530 +Subject: usb: testusb: Fix for showing the connection speed + +From: Faizel K B + +[ Upstream commit f81c08f897adafd2ed43f86f00207ff929f0b2eb ] + +testusb' application which uses 'usbtest' driver reports 'unknown speed' +from the function 'find_testdev'. The variable 'entry->speed' was not +updated from the application. The IOCTL mentioned in the FIXME comment can +only report whether the connection is low speed or not. Speed is read using +the IOCTL USBDEVFS_GET_SPEED which reports the proper speed grade. The +call is implemented in the function 'handle_testdev' where the file +descriptor was availble locally. Sample output is given below where 'high +speed' is printed as the connected speed. + +sudo ./testusb -a +high speed /dev/bus/usb/001/011 0 +/dev/bus/usb/001/011 test 0, 0.000015 secs +/dev/bus/usb/001/011 test 1, 0.194208 secs +/dev/bus/usb/001/011 test 2, 0.077289 secs +/dev/bus/usb/001/011 test 3, 0.170604 secs +/dev/bus/usb/001/011 test 4, 0.108335 secs +/dev/bus/usb/001/011 test 5, 2.788076 secs +/dev/bus/usb/001/011 test 6, 2.594610 secs +/dev/bus/usb/001/011 test 7, 2.905459 secs +/dev/bus/usb/001/011 test 8, 2.795193 secs +/dev/bus/usb/001/011 test 9, 8.372651 secs +/dev/bus/usb/001/011 test 10, 6.919731 secs +/dev/bus/usb/001/011 test 11, 16.372687 secs +/dev/bus/usb/001/011 test 12, 16.375233 secs +/dev/bus/usb/001/011 test 13, 2.977457 secs +/dev/bus/usb/001/011 test 14 --> 22 (Invalid argument) +/dev/bus/usb/001/011 test 17, 0.148826 secs +/dev/bus/usb/001/011 test 18, 0.068718 secs +/dev/bus/usb/001/011 test 19, 0.125992 secs +/dev/bus/usb/001/011 test 20, 0.127477 secs +/dev/bus/usb/001/011 test 21 --> 22 (Invalid argument) +/dev/bus/usb/001/011 test 24, 4.133763 secs +/dev/bus/usb/001/011 test 27, 2.140066 secs +/dev/bus/usb/001/011 test 28, 2.120713 secs +/dev/bus/usb/001/011 test 29, 0.507762 secs + +Signed-off-by: Faizel K B +Link: https://lore.kernel.org/r/20210902114444.15106-1-faizel.kb@dicortech.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + tools/usb/testusb.c | 14 ++++++++------ + 1 file changed, 8 insertions(+), 6 deletions(-) + +diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c +index 0692d99b6d8f..18c895654e76 100644 +--- a/tools/usb/testusb.c ++++ b/tools/usb/testusb.c +@@ -278,12 +278,6 @@ nomem: + } + + entry->ifnum = ifnum; +- +- /* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */ +- +- fprintf(stderr, "%s speed\t%s\t%u\n", +- speed(entry->speed), entry->name, entry->ifnum); +- + entry->next = testdevs; + testdevs = entry; + return 0; +@@ -312,6 +306,14 @@ static void *handle_testdev (void *arg) + return 0; + } + ++ status = ioctl(fd, USBDEVFS_GET_SPEED, NULL); ++ if (status < 0) ++ fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status); ++ else ++ dev->speed = status; ++ fprintf(stderr, "%s speed\t%s\t%u\n", ++ speed(dev->speed), dev->name, dev->ifnum); ++ + restart: + for (i = 0; i < TEST_CASES; i++) { + if (dev->test != -1 && dev->test != i) +-- +2.33.0 + diff --git a/queue-4.4/xen-netback-correct-success-error-reporting-for-the-.patch b/queue-4.4/xen-netback-correct-success-error-reporting-for-the-.patch new file mode 100644 index 00000000000..abe030b2530 --- /dev/null +++ b/queue-4.4/xen-netback-correct-success-error-reporting-for-the-.patch @@ -0,0 +1,40 @@ +From d51b56e501032beed3580053217e3ade1735baf3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 17 Sep 2021 08:27:10 +0200 +Subject: xen-netback: correct success/error reporting for the + SKB-with-fraglist case + +From: Jan Beulich + +[ Upstream commit 3ede7f84c7c21f93c5eac611d60eba3f2c765e0f ] + +When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the +special considerations for the head of the SKB no longer apply. Don't +mistakenly report ERROR to the frontend for the first entry in the list, +even if - from all I can tell - this shouldn't matter much as the overall +transmit will need to be considered failed anyway. + +Signed-off-by: Jan Beulich +Reviewed-by: Paul Durrant +Signed-off-by: David S. Miller +Signed-off-by: Sasha Levin +--- + drivers/net/xen-netback/netback.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c +index c8c6afc0ab51..15c73ebe5efc 100644 +--- a/drivers/net/xen-netback/netback.c ++++ b/drivers/net/xen-netback/netback.c +@@ -994,7 +994,7 @@ check_frags: + * the header's copy failed, and they are + * sharing a slot, send an error + */ +- if (i == 0 && sharedslot) ++ if (i == 0 && !first_shinfo && sharedslot) + xenvif_idx_release(queue, pending_idx, + XEN_NETIF_RSP_ERROR); + else +-- +2.33.0 + -- 2.47.3