From 3c3f1f6349ae997041de347a2b0bca3e95944c59 Mon Sep 17 00:00:00 2001 From: Dylan William Hardison Date: Thu, 15 Jun 2017 16:50:15 -0400 Subject: [PATCH] Bug 1372363 - Fix BMO defaults (bug modal pref, needinfo exclusions) * add comment to explain 0:0 --- extensions/BugModal/Extension.pm | 2 +- extensions/Needinfo/Extension.pm | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/BugModal/Extension.pm b/extensions/BugModal/Extension.pm index 90406abca..1291fca21 100644 --- a/extensions/BugModal/Extension.pm +++ b/extensions/BugModal/Extension.pm @@ -325,7 +325,7 @@ sub install_before_final_checks { add_setting({ name => 'ui_experiments', options => ['on', 'off'], - default => 'off', + default => 'on', category => 'User Interface' }); add_setting({ diff --git a/extensions/Needinfo/Extension.pm b/extensions/Needinfo/Extension.pm index 3b99b5a44..c2d0c7304 100644 --- a/extensions/Needinfo/Extension.pm +++ b/extensions/Needinfo/Extension.pm @@ -39,8 +39,8 @@ sub install_update_db { print "Creating needinfo flag ... " . "enable the Needinfo feature by editing the flag's properties.\n"; - # Initially populate the list of exclusions as __Any__:__Any__ to - # allow admin to decide which products to enable the flag for. + # inclusions 0:0 maps to __ANY__ : __ANY__ in the UI, + # meaning needinfo is enabled for all products and components by default my $flagtype = Bugzilla::FlagType->create({ name => 'needinfo', description => "Set this flag when the bug is in need of additional information", @@ -53,8 +53,8 @@ sub install_update_db { is_multiplicable => 0, request_group => '', grant_group => '', - inclusions => [], - exclusions => ['0:0'], + inclusions => ['0:0'], + exclusions => [], }); } -- 2.47.3