From 431946e9617572d2813bd5a8f5a51ce36f841ea3 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 24 Feb 2012 19:20:12 +0100 Subject: [PATCH] MEDIUM: increase chunk-size limit to 2GB-1 Since commit 115acb97, chunk size was limited to 256MB. There is no reason for such a limit and the comment on the code suggests a missing zero. However, increasing the limit past 2 GB causes trouble due to some 32-bit subtracts in various computations becoming negative (eg: buffer_max_len). So let's limit the chunk size to 2 GB - 1 max. --- src/proto_http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proto_http.c b/src/proto_http.c index cfbebd9f73..5efc7ec751 100644 --- a/src/proto_http.c +++ b/src/proto_http.c @@ -2150,7 +2150,7 @@ int http_parse_chunk_size(struct buffer *buf, struct http_msg *msg) break; if (++ptr >= end) ptr = buf->data; - if (chunk & 0xF000000) /* overflow will occur */ + if (chunk & 0xF8000000) /* integer overflow will occur if result >= 2GB */ goto error; chunk = (chunk << 4) + c; } -- 2.47.3