From 452a96d3904b14a64d5fdcb06dec7f5d584bc3b0 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Tue, 28 Mar 2023 14:34:55 +0200 Subject: [PATCH] 4.14-stable patches added patches: nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch --- ...el-infoleak-in-nilfs_ioctl_wrap_copy.patch | 86 +++++++++++++++++++ queue-4.14/series | 1 + 2 files changed, 87 insertions(+) create mode 100644 queue-4.14/nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch diff --git a/queue-4.14/nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch b/queue-4.14/nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch new file mode 100644 index 00000000000..bae4556938f --- /dev/null +++ b/queue-4.14/nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch @@ -0,0 +1,86 @@ +From 003587000276f81d0114b5ce773d80c119d8cb30 Mon Sep 17 00:00:00 2001 +From: Ryusuke Konishi +Date: Tue, 7 Mar 2023 17:55:48 +0900 +Subject: nilfs2: fix kernel-infoleak in nilfs_ioctl_wrap_copy() + +From: Ryusuke Konishi + +commit 003587000276f81d0114b5ce773d80c119d8cb30 upstream. + +The ioctl helper function nilfs_ioctl_wrap_copy(), which exchanges a +metadata array to/from user space, may copy uninitialized buffer regions +to user space memory for read-only ioctl commands NILFS_IOCTL_GET_SUINFO +and NILFS_IOCTL_GET_CPINFO. + +This can occur when the element size of the user space metadata given by +the v_size member of the argument nilfs_argv structure is larger than the +size of the metadata element (nilfs_suinfo structure or nilfs_cpinfo +structure) on the file system side. + +KMSAN-enabled kernels detect this issue as follows: + + BUG: KMSAN: kernel-infoleak in instrument_copy_to_user + include/linux/instrumented.h:121 [inline] + BUG: KMSAN: kernel-infoleak in _copy_to_user+0xc0/0x100 lib/usercopy.c:33 + instrument_copy_to_user include/linux/instrumented.h:121 [inline] + _copy_to_user+0xc0/0x100 lib/usercopy.c:33 + copy_to_user include/linux/uaccess.h:169 [inline] + nilfs_ioctl_wrap_copy+0x6fa/0xc10 fs/nilfs2/ioctl.c:99 + nilfs_ioctl_get_info fs/nilfs2/ioctl.c:1173 [inline] + nilfs_ioctl+0x2402/0x4450 fs/nilfs2/ioctl.c:1290 + nilfs_compat_ioctl+0x1b8/0x200 fs/nilfs2/ioctl.c:1343 + __do_compat_sys_ioctl fs/ioctl.c:968 [inline] + __se_compat_sys_ioctl+0x7dd/0x1000 fs/ioctl.c:910 + __ia32_compat_sys_ioctl+0x93/0xd0 fs/ioctl.c:910 + do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] + __do_fast_syscall_32+0xa2/0x100 arch/x86/entry/common.c:178 + do_fast_syscall_32+0x37/0x80 arch/x86/entry/common.c:203 + do_SYSENTER_32+0x1f/0x30 arch/x86/entry/common.c:246 + entry_SYSENTER_compat_after_hwframe+0x70/0x82 + + Uninit was created at: + __alloc_pages+0x9f6/0xe90 mm/page_alloc.c:5572 + alloc_pages+0xab0/0xd80 mm/mempolicy.c:2287 + __get_free_pages+0x34/0xc0 mm/page_alloc.c:5599 + nilfs_ioctl_wrap_copy+0x223/0xc10 fs/nilfs2/ioctl.c:74 + nilfs_ioctl_get_info fs/nilfs2/ioctl.c:1173 [inline] + nilfs_ioctl+0x2402/0x4450 fs/nilfs2/ioctl.c:1290 + nilfs_compat_ioctl+0x1b8/0x200 fs/nilfs2/ioctl.c:1343 + __do_compat_sys_ioctl fs/ioctl.c:968 [inline] + __se_compat_sys_ioctl+0x7dd/0x1000 fs/ioctl.c:910 + __ia32_compat_sys_ioctl+0x93/0xd0 fs/ioctl.c:910 + do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] + __do_fast_syscall_32+0xa2/0x100 arch/x86/entry/common.c:178 + do_fast_syscall_32+0x37/0x80 arch/x86/entry/common.c:203 + do_SYSENTER_32+0x1f/0x30 arch/x86/entry/common.c:246 + entry_SYSENTER_compat_after_hwframe+0x70/0x82 + + Bytes 16-127 of 3968 are uninitialized + ... + +This eliminates the leak issue by initializing the page allocated as +buffer using get_zeroed_page(). + +Link: https://lkml.kernel.org/r/20230307085548.6290-1-konishi.ryusuke@gmail.com +Signed-off-by: Ryusuke Konishi +Reported-by: syzbot+132fdd2f1e1805fdc591@syzkaller.appspotmail.com + Link: https://lkml.kernel.org/r/000000000000a5bd2d05f63f04ae@google.com +Tested-by: Ryusuke Konishi +Cc: +Signed-off-by: Andrew Morton +Signed-off-by: Greg Kroah-Hartman +--- + fs/nilfs2/ioctl.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/fs/nilfs2/ioctl.c ++++ b/fs/nilfs2/ioctl.c +@@ -79,7 +79,7 @@ static int nilfs_ioctl_wrap_copy(struct + if (argv->v_index > ~(__u64)0 - argv->v_nmembs) + return -EINVAL; + +- buf = (void *)__get_free_pages(GFP_NOFS, 0); ++ buf = (void *)get_zeroed_page(GFP_NOFS); + if (unlikely(!buf)) + return -ENOMEM; + maxmembs = PAGE_SIZE / argv->v_size; diff --git a/queue-4.14/series b/queue-4.14/series index 3fb9e13c11a..847883b3aab 100644 --- a/queue-4.14/series +++ b/queue-4.14/series @@ -33,3 +33,4 @@ usb-gadget-u_audio-don-t-let-userspace-block-driver-unbind.patch igb-revert-rtnl_lock-that-causes-deadlock.patch usb-chipdea-core-fix-return-einval-if-request-role-is-the-same-with-current-role.patch usb-chipidea-core-fix-possible-concurrent-when-switch-role.patch +nilfs2-fix-kernel-infoleak-in-nilfs_ioctl_wrap_copy.patch -- 2.47.2