From 474c36ca2e1fcc7d15706d51223d45bb4db5fd79 Mon Sep 17 00:00:00 2001 From: Marek Schimara Date: Wed, 15 Jun 2016 11:34:49 +0200 Subject: [PATCH] src/rrd_daemon.c: fix Coverity CIDs#32418,#32419 Resource leak CWE-404 / https://cwe.mitre.org/data/definitions/404.html --- src/rrd_daemon.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 32d8a240..3c8773c7 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -3468,6 +3468,8 @@ static int open_listen_socket_network(const listen_socket_t *sock) /* {{{ */ if (status != 0) { fprintf(stderr, "rrdcached: setsockopt(SO_REUSEADDR) failed: %s\n", rrd_strerror(errno)); + close (fd); + freeaddrinfo(ai_res); return (-1); } /* Nagle will cause significant delay in processing requests so @@ -3476,6 +3478,8 @@ static int open_listen_socket_network(const listen_socket_t *sock) /* {{{ */ if (status != 0) { fprintf(stderr, "rrdcached: setsockopt(TCP_NODELAY) failed: %s\n", rrd_strerror(errno)); + close (fd); + freeaddrinfo(ai_res); return (-1); } #ifdef IPV6_V6ONLY @@ -3486,6 +3490,8 @@ static int open_listen_socket_network(const listen_socket_t *sock) /* {{{ */ if (status != 0) { fprintf(stderr, "rrdcached: setsockopt(IPV6_V6ONLY) failed: %s\n", rrd_strerror(errno)); + close (fd); + freeaddrinfo(ai_res); return (-1); } #endif /* IPV6_V6ONLY */ -- 2.47.3