From 47cf87a147478818d33ff24a7484a09f8c8d5e96 Mon Sep 17 00:00:00 2001 From: Itagaki Takahiro Date: Wed, 9 Jun 2010 01:00:13 +0000 Subject: [PATCH] Fix connection leak in dblink when dblink_connect() or dblink_connect_u() end with "duplicate connection name" errors. Backported to release 7.4. --- contrib/dblink/dblink.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 16f50200818..f67128e7519 100644 --- a/contrib/dblink/dblink.c +++ b/contrib/dblink/dblink.c @@ -2151,9 +2151,14 @@ createNewConnection(const char *name, remoteConn * rconn) HASH_ENTER, &found); if (found) + { + PQfinish(rconn->conn); + pfree(rconn); + ereport(ERROR, (errcode(ERRCODE_DUPLICATE_OBJECT), errmsg("duplicate connection name"))); + } hentry->rconn = rconn; strncpy(hentry->name, name, NAMEDATALEN - 1); -- 2.39.5